Review request for type annotation reflection test

[Alex Buckley]

I have no further comments. Thanks for all your work to test this new 
and expansive API.

Alex

On 8/20/2013 1:56 AM, Charlie Wang wrote:
> Hi Alex,
>    I used testInput.size() instead of static int clsIdx as suffix this
> time. And other update according to your comments.
>
> Here's the link. Please review again.
> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation1/webrev/
>
>
> - Charlie
>
> On 2013/8/9 1:05, Alex Buckley wrote:
>> - AnnotationTest.i/clsIdx: it wasn't the name of the variable I was
>> objecting to. It was the fact that you're relying on a mutable public
>> static variable at all.
>>
>> - GenTestCode should take Class<? extends TestCaseGenerator>, so you
>> don't need to cast to TestCaseGenerator in GenTestCode. (Same comment
>> for AnnotationTest.compileCode).
>>
>> - AnnotationTest.testInput is a Map<Object,String> but I'm sure you
>> can do better than Object for keys.'
>>
>> - ExecutableGetAnnotatedParameterTypesTest.testInput hides
>> AnnotationTest.testInput, but swaps the order of the type arguments!
>> Map<String,Object> is either wrong, or should not use Object.
>>
>> Alex