changes for annotations in code attribute

[Steve Sides]

Last I looked (which was a while ago), the javap/typeAnnotations tests 
were mostly duplicates of the javac ones, only slightly differently 
implemented, and they weren't truly javap tests.  Since then Peter has 
been writing javap tests. I'll have a look and also have Peter give them 
a look.

With the recent code attribute change, he may need to edit a little 
anyway. :)

thanks,
steve

On 2/25/2013 9:07 PM, Werner Dietl wrote:
> Thanks,teve!
> I've pushed your changes:
>
> http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/8c7da944ce32
>
> I still see three javap tests failing:
>
> tools/javap/typeAnnotations/NewArray.java: test that all type
> annotations are present in the classfile
> tools/javap/typeAnnotations/Presence.java: test that all type
> annotations are present in the classfile
> tools/javap/typeAnnotations/TypeCasts.java: test that typecasts
> annotation are emitted if only the cast expression is optimized away
>
> Could you also take a look at those? I think there is some code that
> could be re-used between the javac and javap tests.
>
> Thanks,
> cu, WMD.
>
> On Mon, Feb 25, 2013 at 5:26 PM, Steve Sides <steve.sides at oracle.com> wrote:
>> Hi Werner,
>>   Here are changes for the typeAnnotations/classfile tests to look for
>> annotations in the right place:
>> http://cr.openjdk.java.net/~ssides/8008928/
>> I have another test for anonymous and inner classes (the one that found the
>> last few bugs) but it is a little different and not as easy to rework.
>> It's also sensitive to the AssertionError reported a little earlier today.
>>   CombinationsTargetTest2 also has some filtering due to some open bugs
>> including the most recent AssertionError but reworking that test was more
>> doable at the moment.
>>
>> However, the changes enable all the tests include to pass. :)
>>
>> I'd like to get the anon and inner class tests fixed as it might be a good
>> test case for you ongoing and recent changes for type-annotations workspace.
>>
>> -steve
>>
>
>