webrev for type-annotations, repeating type-annotations test

[Alex Buckley]

On 1/10/2013 3:40 PM, Steve Sides wrote:
>> The writeup of CombinationsTargetTest is helpful, especially the
>> sample output. It shows there is a lot going on: i) annotation types
>> which are declaration-site v. use-site v. decl-and-use-site, and ii)
>> annotations which occur once v. multiple times v. jointly with other
>> annotations. Two questions:
>>
>> 1. Could you expand "4) inside method bodies" to make clear what
>> locations are tested with type annotations?
> Do you want I should add this to the comments or put it in comment in
> the test?
> Each code scenario could have a comment blurb listing usages.

Just the comments. Giving the line numbers of the test which generate 
annotations for certain locations would be good too.

BTW the opening line is: "CombinationsTargetTest.java tests type 
annotations with combinations of target types on ..." - the term "target 
types" is not entirely clear and I think @Target is relevant.

> FWIW, I did find the bug for double annotations on new,array,cast using
> this test. It failed as noted in the webrevComment.txt file.
> Once it fails, i can see there is a mismatch in the number of expected
> annotations, and I started narrowing it down...it wasn't that difficult.
>
> This test case,
> http://cr.openjdk.java.net/~ssides/tests/TypeAnnoContainers.java, is
> essentially a smaller version of the whole thing.

Right, thanks for posting that.

Alex