From charlie.wang at oracle.com Sun Jun 2 23:39:44 2013 From: charlie.wang at oracle.com (Charlie Wang) Date: Mon, 03 Jun 2013 14:39:44 +0800 Subject: Review request for type annotation reflection test In-Reply-To: <519C2582.6040401@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> Message-ID: <51AC3A30.6000706@oracle.com> Hi, Please review attached 2 files, which I've changed according to comments. If OK, I will update the rest of the tests and publish for review. Regards, Charlie On 2013/5/22 9:55, Joseph Darcy wrote: > Hello, > > On 5/21/2013 6:37 PM, Alex Buckley wrote: >> I see you have extracted the validation logic and common annotation >> types into TestUtil, so that any individual test will primarily be a >> data provider + test cases. However: >> >> 1. Jon is our resident TestNG expert and he says that data providers >> are intended to enumerate input values for tests; other code >> determines which values should pass the tests and which values should >> fail. But your data provider encodes the types and element values of >> annotations which are expected to appear at various locations - this >> is output data, not input data. >> >> 2. There is basically no abstraction over the expected annotations in >> the data provider. It's just a bunch of Object[][] values. >> Consequently, TestUtil is very brittle. There is weird indexing of >> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >> knowledge of specific test cases: >> >> catch (NoSuchMethodException e) { >> //expected exception for TypeAnno3 >> } >> >> 3. I'm suspicious of static methods in TestUtil. They are stateless >> at present, but if they ever share state then you'll be in trouble, >> especially with the instance methods in GetAnnotated*Test. >> >> Charlie, there are two techniques you should adopt for tests on the >> core reflection API: >> >> - First, encode expected values of type annotations more directly, by >> annotating the AnnotationTypeTestXX declarations themselves. > > Note that this technique is used in various other regression tests in > the JDK repository. For some recently-written small examples see > > test/java/lang/reflect/Parameter/WithoutParameters.java > test/java/lang/reflect/Method/DefaultMethodModeling.java.html > >> >> - Second, embrace combinatorial testing rather than declaring a bunch >> of ad-hoc AnnotationTypeTestXX types with type annotations in various >> locations. >> >> The core reflection tests for repeating annotations use both these >> techniques. Please look at item 2 of >> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >> - apologies for non-Oracle readers. Please talk with Steve and >> Matherey to get background. To be clear, I will not sign off the type >> annotations reflection tests in their present form. > > I concur that using combinatorial tests is appropriate for this > domain. The basic approach is to programatically generate both the > expected result and the code to test and verify that the computed > answer is consistent with the expected one. The regression tests > currently in JDK 8 have code that allows source code to be generated > at runtime, loading in by a class loader, and then run. > > HTH, > > -Joe > >> >> Alex >> >> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>> OK, thanks. >>> I will create a TestUtil.java (as attached file). Extract the common >>> part and put them in it. And Add comments on data provider. >>> I'm on a very tight schedule, so this time I just send out two of the >>> updated files (attached files) for review so I can get a quick >>> response. >>> If it is OK, I will use it as a template on other tests. >>> Please take a look and send me your comments as soon as possible. >>> >>> >>> Thanks, >>> Charlie >>> >>> >>> On 2013/5/22 2:24, Alex Buckley wrote: >>>> Please keep one source file per tested API method, because it is easy >>>> to navigate. The problem is the body of the test() method in each >>>> source file. It should call utility methods to inspect annotations, >>>> rather that repeating more or less the same 'for' loops as every other >>>> test() method. >>>> >>>> As for data providers, I believe they are a TestNG thing. Please add >>>> comments to each source file to describe what the data provider >>>> represents. >>>> >>>> Finally, when you make a "little update", you should give a short >>>> description of what has changed. If you don't, someone who looked at >>>> the previous version has no idea what changed and will have to look at >>>> everything again. >>>> >>>> Alex >>>> >>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>> Yes, that make sense. What do you think if I combine the tests? It >>>>> would >>>>> then have 1 unified data provider and test method, thus solve the 2 >>>>> problems. >>>>> >>>>> Regards, >>>>> Charlie >>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>> I agree with Alex's first two comments. The code duplication for the >>>>>> test logic and all the different annotation types seems hard to >>>>>> maintain and update. >>>>>> >>>>>> cu, WMD. >>>>>> >>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>> wrote: >>>>>>> Hi, >>>>>>> Here's the latest one with a little update: >>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>> Please provide comments as soon as possible now that due date is >>>>>>> approaching. >>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> Charlie >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>> >>>>>>> Hi, >>>>>>> Here's test for core reflection support of type-annotations >>>>>>> JDK-8013497. >>>>>>> Please take a look. >>>>>>> >>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> Charlie >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>> > -------------- next part -------------- /* * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. */ /** * @test * @bug 8013497 * @summary Utility class for constructing, compiling and execute code */ import java.io.File; import java.io.IOException; import java.net.MalformedURLException; import java.net.URI; import java.net.URISyntaxException; import java.net.URL; import java.net.URLClassLoader; import java.util.ArrayList; import java.util.Arrays; import java.util.Iterator; import java.util.LinkedHashMap; import java.util.List; import javax.tools.Diagnostic; import javax.tools.DiagnosticCollector; import javax.tools.JavaCompiler; import javax.tools.JavaCompiler.CompilationTask; import javax.tools.JavaFileObject.Kind; import javax.tools.JavaFileObject; import javax.tools.SimpleJavaFileObject; import javax.tools.StandardJavaFileManager; import javax.tools.StandardLocation; import javax.tools.ToolProvider; import com.sun.source.util.JavacTask; import java.lang.annotation.Annotation; import java.lang.reflect.AnnotatedType; import java.lang.reflect.Method; public class Helper { public enum SrcType { PKGINFO("[#ANNO] \npackage #NAME; \n") { public String getSrc(String... annoStr) { if (0 == annoStr.length || 1 == annoStr.length) { return PKGINFO.replaceMultipleAnnoStr(annoStr); } else { throw new RuntimeException("illegal annotation or package info!"); } } }, PACKAGE("\npackage #NAME; \n") { public String getSrc(String... annoStr) { if (0 == annoStr.length || 1 == annoStr.length) { return PACKAGE.replaceMultipleAnnoStr(annoStr); } else { throw new RuntimeException("illegal package name!"); } } }, IMPORT("\nimport java.io.*;\n" + "import java.util.*;\n" + "import java.lang.*;\n" + "import java.lang.reflect.*;\n" + "import java.lang.annotation.*;\n") { public String getSrc(String... annoStr) { if (null == annoStr) { return template; } return ""; } }, CLASS("\n[#ANNO] \nclass #NAME") { public String getSrc(String... annoStr) { if (0 == annoStr.length || 1 == annoStr.length) { return CLASS.replaceMultipleAnnoStr(annoStr); } else { throw new RuntimeException("illegal class name!"); } } }, INTERFACE("\n[#ANNO] \ninterface #NAME") { public String getSrc(String... annoStr) { if (0 == annoStr.length || 1 == annoStr.length) { return INTERFACE.replaceMultipleAnnoStr(annoStr); } else { throw new RuntimeException("illegal interface name!"); } } }, EXTENDS(" extends [#ANNO] #NAME") { public String getSrc(String... annoStr) { if (0 == annoStr.length || 1 == annoStr.length) { return EXTENDS.replaceMultipleAnnoStr(annoStr); } else { throw new RuntimeException("illegal class name!"); } } }, IMPLEMENTS(" implements [[#ANNO] #NAME, ]") { public String getSrc(String... annoStr) { return IMPLEMENTS.replaceMultipleAnnoStr(annoStr); } }, GENERICS("<[[#ANNO1] #TYPE1 [#INHERITANCE [#ANNO2] #TYPE2], ]>") { // input should be like ["@realanno1 Type1 //extends @realanno2 Type2", "@realanno3 Type3 //super @realanno4 Type4"] public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } String temp = template; for (String as : annoStr) { temp = temp.replaceAll("\\[\\[#ANNO1\\] #TYPE1 " + "\\[#INHERITANCE \\[#ANNO2\\] #TYPE2\\], \\]", "[#ANNO1] #TYPE1 [#INHERITANCE [#ANNO2] #TYPE2], " + "[[#TMP_ANNO1] #TMP_TYPE1 [#TMP_INHERITANCE " + "[#TMP_ANNO2] #TMP_TYPE2], ]"); int j = 0; // index of ) String ss = as.trim(); // get @anno for [#ANNO1] while (ss.startsWith("@")) { j = ss.indexOf(")") + 1; String anno = ss.substring(0, j); temp = temp.replaceFirst("\\[#ANNO1\\]", anno + " [#ANNO1]"); ss = ss.substring(j).trim(); } temp = temp.replaceAll("\\[#ANNO1\\]", ""); // get #TYPE1 if (j == ss.length()) { throw new RuntimeException("illegal generics."); } j = ss.indexOf(" ") + 1; String type = j == 0 ? ss : ss.substring(0, j); temp = temp.replaceFirst("#TYPE1", type); ss = ss.substring(j).trim(); // get #INHERITANCE if (ss.startsWith("extends") || ss.startsWith("super")) { temp = temp.replaceAll("\\[#INHERITANCE " + "\\[#ANNO2\\] #TYPE2\\]", "#INHERITANCE \\[#ANNO2\\] #TYPE2"); j = ss.indexOf(" ") + 1; String inheritance = j == 0 ? ss : ss.substring(0, j); temp = temp.replaceFirst("#INHERITANCE", inheritance); ss = ss.substring(j).trim(); // get @anno for [#ANNO2] while (ss.startsWith("@")) { j = ss.indexOf(")") + 1; String anno = ss.substring(0, j); temp = temp.replaceFirst("\\[#ANNO2\\]", anno + " [#ANNO2]"); ss = ss.substring(j).trim(); } temp = temp.replaceAll("\\[#ANNO2\\]", ""); // get #TYPE2 if (j == ss.length()) { throw new RuntimeException("********"); } j = ss.indexOf(" ") + 1; type = j == 0 ? ss : ss.substring(0, j); temp = temp.replaceFirst("#TYPE2", type); ss = ss.substring(j).trim(); } else { temp = temp.replaceAll("\\[#INHERITANCE \\[#ANNO2\\] " + "#TYPE2\\]", ""); } temp = temp.replaceAll("TMP_", ""); } return temp.replaceAll(", \\[\\[#ANNO1\\] #TYPE1 " + "\\[#INHERITANCE \\[#ANNO2\\] #TYPE2\\], \\]", ""); } }, CLASSBODYSTART(" {\n") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } }, FIELDTYPE(" public [#ANNO] #NAME") { public String getSrc(String... annoStr) { if (0 == annoStr.length || 1 == annoStr.length) { return FIELDTYPE.replaceMultipleAnnoStr(annoStr); } else { throw new RuntimeException("illegal field type."); } } }, FIELDARRAY(" [[#ANNO] [] ] ") { // input should be like ["@A() @B()", "@C() @D()"...] public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } String temp = template; for (String as : annoStr) { temp = temp.replaceAll("\\[\\[#ANNO\\] \\[\\] \\]", "[#ANNO] [] [[#TMP_ANNO] [] ]"); // replace "[#ANNO]..." with "@realannotation [#ANNO]..." int i = 0; // index of @ int j = 0; // index of ) for (; -1 != as.indexOf("@", j);) { i = as.indexOf("@", j); j = as.indexOf(")", i) + 1; String anno = as.substring(i, j); temp = temp.replaceFirst("\\[#ANNO\\]", anno + " [#ANNO]"); } temp = temp.replaceAll("\\[#ANNO\\]", ""). replaceAll("TMP_", ""); } return temp.replaceAll("\\[\\[#ANNO\\] \\[\\] \\]", ""); } }, FIELDNAME(" #NAME;\n") { public String getSrc(String... annoStr) { if (0 == annoStr.length || 1 == annoStr.length) { return FIELDNAME.replaceMultipleAnnoStr(annoStr); } else { throw new RuntimeException("illegal field name"); } } }, METHODHEAD("\n public [#ANNO] #TYPE #NAME") { // input should be like "@realanno Type method" public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } String temp = template; for (String as : annoStr) { int j = 0; // index of ")" String ss = as.trim(); // get @anno for [#ANNO1] while (ss.startsWith("@")) { j = ss.indexOf(")") + 1; String anno = ss.substring(0, j); temp = temp.replaceFirst("\\[#ANNO\\]", anno + " [#ANNO]"); ss = ss.substring(j).trim(); } temp = temp.replaceAll("\\[#ANNO\\]", ""); // get #TYPE if (j == ss.length()) { throw new RuntimeException("illegal method head."); } j = ss.indexOf(" ") + 1; if (0 == j) { throw new RuntimeException("illegal method head."); } String type = ss.substring(0, j); temp = temp.replaceFirst("#TYPE", type); ss = ss.substring(j).trim(); // get #NAME if (0 <= ss.indexOf(" ") || 0 == ss.length()) { throw new RuntimeException("illegal method head."); } temp = temp.replaceFirst("#NAME", ss); } return temp; } }, METHODPARAM("([[#ANNO] #TYPE #NAME, ])") { // input should be like "@realanno Type arg" public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } String temp = template; for (String as : annoStr) { temp = temp.replaceFirst("\\[\\[#ANNO\\] #TYPE #NAME, \\]", "[#ANNO] #TYPE #NAME, " + "[[#TMP_ANNO] #TMP_TYPE #TMP_NAME, ]"); int j = 0; // index of ")" String ss = as.trim(); // get @anno for [#ANNO1] while (ss.startsWith("@")) { j = ss.indexOf(")") + 1; String anno = ss.substring(0, j); temp = temp.replaceFirst("\\[#ANNO\\]", anno + " [#ANNO]"); ss = ss.substring(j).trim(); } temp = temp.replaceAll("\\[#ANNO\\]", ""); // get #TYPE if (j == ss.length()) { throw new RuntimeException("illegal method parameter."); } j = ss.indexOf(" ") + 1; if (0 == j) { throw new RuntimeException("illegal method parameter."); } String type = ss.substring(0, j); temp = temp.replaceFirst("#TYPE", type); ss = ss.substring(j).trim(); // get #NAME if (0 <= ss.indexOf(" ") || 0 == ss.length()) { throw new RuntimeException("illegal method parameter."); } temp = temp.replaceFirst("#NAME", ss); temp = temp.replaceAll("TMP_", ""); } return temp.replaceAll(", \\[\\[#ANNO\\] #TYPE #NAME, \\]", ""); } }, METHODEXCEPTION(" throws [[#ANNO] #NAME, ]") { public String getSrc(String... annoStr) { return METHODEXCEPTION.replaceMultipleAnnoStr(annoStr); } }, METHODBODY(" {return null;}\n"), CLASSBODYEND("\n}\n") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } }, TYPEANNO1("\n at Target(ElementType.TYPE_USE)" + "\n at Retention(RetentionPolicy.RUNTIME)" + "\n at Repeatable(TypeAnno1Container.class)" + "\n at interface TypeAnno1 {" + "\n String value();" + "\n}") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } public String toString() { return "@TypeAnno1(\"TypeAnno1\")"; } }, TYPEANNO2("\n at Target(ElementType.TYPE_USE)" + "\n at Retention(RetentionPolicy.RUNTIME)" + "\n at Repeatable(TypeAnno2Container.class)" + "\n at interface TypeAnno2 {" + "\n String value();" + "\n}") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } public String toString() { return "@TypeAnno2(\"TypeAnno2\")"; } }, TYPEANNO3("\n at Target(ElementType.TYPE_USE)" + "\n at Retention(RetentionPolicy.RUNTIME)" + "\n at Repeatable(TypeAnno3Container.class)" + "\n at interface TypeAnno3 {" + "\n}") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } public String toString() { return "@TypeAnno3"; } }, TYPEANNOCONTAINER1("\n at Target(ElementType.TYPE_USE)" + "\n at Retention(RetentionPolicy.RUNTIME)" + "\n at interface TypeAnno1Container {" + "\n TypeAnno1[] value();" + "\n}") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } }, TYPEANNOCONTAINER2("\n at Target(ElementType.TYPE_USE)" + "\n at Retention(RetentionPolicy.RUNTIME)" + "\n at interface TypeAnno2Container {" + "\n TypeAnno2[] value();" + "\n}") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } }, TYPEANNOCONTAINER3("\n at Target(ElementType.TYPE_USE)" + "\n at Retention(RetentionPolicy.RUNTIME)" + "\n at interface TypeAnno3Container {" + "\n TypeAnno3[] value();" + "\n}") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } }, PKGANNOTATION1("\n at Target(ElementType.PACKAGE)" + "\n at Retention(RetentionPolicy.RUNTIME)" + "\npublic @interface PkgAnno1 {" + "\n String value();" + "\n}") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } public String toString() { return "@PkgAnno1(\"PkgAnno1\")"; } }, PKGANNOTATION2("\n at Target(ElementType.PACKAGE)" + "\n at Retention(RetentionPolicy.RUNTIME)" + "\npublic @interface PkgAnno2 {" + "\n String value();" + "\n}") { public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return template; } } public String toString() { return "@PkgAnno2(\"PkgAnno2\")"; } }; String template = ""; private SrcType(String template) { this.template = template; } // change [#ANNO] #NAME into @realannotation name private String replaceMultipleAnnoStr(String... annoStr) { if (0 == annoStr.length) { return ""; } String temp = template; for (String as : annoStr) { temp = temp.replaceAll("\\[\\[#ANNO\\] #NAME, \\]", "[#ANNO] #NAME, [[#TMP_ANNO] #TMP_NAME, ]"); // replace "[#ANNO]..." with "@realannotation [#ANNO]..." int i = 0; // index of @ int j = 0; // index of " " for (; -1 != as.indexOf("@", j);) { i = as.indexOf("@", j); j = as.indexOf(" ", i); // annotation check - should be like @A or @A() or @A("...") if (2 > j - i) { throw new RuntimeException("illegal annotation."); } String anno = as.substring(i, j); temp = temp.replaceFirst("\\[#ANNO\\]", anno + " [#ANNO]"); } String name = as.substring(j, as.length()).trim(); temp = temp.replaceAll("#NAME", name).replaceAll( "\\[#ANNO\\]", ""); temp = temp.replaceAll("\\[\\[#TMP_ANNO\\] #TMP_NAME, \\]", "[[#ANNO] #NAME, ]"); } return temp.replaceAll(", \\[\\[#ANNO\\] #NAME, \\]", ""); } public String getTemplate() { return template; } public String getSrc(String... annoStr) { if (0 == annoStr.length) { return ""; } else { return ""; } } } // generate test class code with annotations, which is used for test public synchronized static String genTestCode(LinkedHashMap input) { StringBuffer result = new StringBuffer(); for (Helper.SrcType st : Helper.SrcType.values()) { if (input.containsKey(st)) { Object temp = input.get(st); if (temp instanceof String) { result.append(st.getSrc((String) temp)); } else { result.append(st.getSrc((String[]) temp)); } // auto correction, in case input misses class brackets if (SrcType.CLASS == st || SrcType.INTERFACE == st) { input.put(SrcType.CLASSBODYSTART, ""); input.put(SrcType.CLASSBODYEND, ""); } // auto correction, in case input misses method brackets if (SrcType.METHODHEAD == st) { if (!input.containsKey(SrcType.METHODPARAM)) { input.put(SrcType.METHODPARAM, ""); } input.put(SrcType.METHODBODY, ""); } } else { result.append(st.getSrc()); } } return result.toString(); } // Create and compile FileObject using values for className and contents public static boolean compileCode(String className, String contents, DiagnosticCollector diagnostics) { boolean ok = false; JavaCompiler compiler = ToolProvider.getSystemJavaCompiler(); if (compiler == null) { throw new RuntimeException("can't get javax.tools.JavaCompiler!"); } JavaFileObject file = getFile(className, contents); Iterable compilationUnit = Arrays.asList(file); CompilationTask task = compiler.getTask(null, null, diagnostics, null, null, compilationUnit); ok = task.call(); return ok; } // Compile a list of FileObjects // Used when packages are needed and classes need to be loaded at runtime static File destDir = new File(System.getProperty("user.dir")); public static boolean compileCode( DiagnosticCollector diagnostics, Iterable files) { boolean ok = false; JavaCompiler compiler = ToolProvider.getSystemJavaCompiler(); if (compiler == null) { throw new RuntimeException("can't get javax.tools.JavaCompiler!"); } StandardJavaFileManager fm = compiler.getStandardFileManager( null, null, null); // Assuming filesCount can maximum be 2 and if true, one file is package-info.java if (isPkgInfoPresent(files)) { JavacTask task = (JavacTask) compiler.getTask(null, fm, diagnostics, null, null, files); try { fm.setLocation(StandardLocation.CLASS_OUTPUT, Arrays.asList(destDir)); task.generate(); } catch (IOException ioe) { throw new RuntimeException( "Compilation failed for package level tests", ioe); } int err = 0; for (Diagnostic d : diagnostics.getDiagnostics()) { if (d.getKind() == Diagnostic.Kind.ERROR) { err++; } } ok = (err == 0); } else { CompilationTask task = compiler.getTask(null, null, diagnostics, null, null, files); ok = task.call(); } return ok; } static private boolean isPkgInfoPresent( Iterable files) { Iterator itr = files.iterator(); while (itr.hasNext()) { String name = itr.next().getName(); if (name.contains("package-info")) { return true; } } return false; } static JavaFileObject getFile(String name, String code) { JavaFileObject o = null; try { o = new JavaStringFileObject(name, code); } catch (URISyntaxException e) { throw new RuntimeException(e); } return o; } static class JavaStringFileObject extends SimpleJavaFileObject { final String theCode; public JavaStringFileObject(String fileName, String theCode) throws URISyntaxException { super(new URI("string:///" + fileName.replace('.', '/') + ".java"), Kind.SOURCE); this.theCode = theCode; } @Override public CharSequence getCharContent(boolean ignoreEncodingErrors) { return theCode; } } public static Class loadClass(String className, ClassLoader parentClassLoader, File... destDirs) { try { List list = new ArrayList<>(); for (File f : destDirs) { list.add(new URL("file:" + f.toString().replace("\\", "/") + "/")); } return Class.forName(className, true, new URLClassLoader( list.toArray(new URL[list.size()]), parentClassLoader)); } catch (ClassNotFoundException | MalformedURLException e) { throw new RuntimeException("Error loading class " + className, e); } } // generate class from test code public static void genClass(String testCode, ClassLoader parentClassLoader, String clsName) { JavaFileObject jfo = Helper.getFile(clsName, testCode); Iterable files = Arrays.asList(jfo); DiagnosticCollector diagnostics = new DiagnosticCollector<>(); // Compile the list of JavaFileObjects try { Helper.compileCode(diagnostics, files); } catch (Exception ex) { throw new RuntimeException( "Exception when compiling class "); } } // get annotation public static String getAnno(Annotation[] annotations) throws Exception { StringBuffer result = new StringBuffer(""); for (int i = 0; i < annotations.length; i++) { if (null != annotations) { String annoName = ""; Object value = null; try { value = annotations[i].annotationType().getMethod("value", new Class[]{}).invoke(annotations[i], new Object[]{}); } catch (NoSuchMethodException e) { //expected exception for annotations without value } if (null == value) { annoName = annotations[i].annotationType().getSimpleName(); result.append("@" + annoName); result.append(" "); } else if (value instanceof String) { annoName = annotations[i].annotationType().getSimpleName(); result.append("@" + annoName); result.append("(\"" + value + "\") "); } else { //for repeated anno Annotation[] av = (Annotation[]) value; for (int j = 0; j < av.length; j++) { annoName = av[j].annotationType().getSimpleName(); value = " "; try { value = av[j].annotationType().getMethod("value", new Class[]{}).invoke(av[j], new Object[]{}); value = "(\"" + value + "\") "; } catch (NoSuchMethodException e) { //expected exception for annotations without value } result.append("@" + annoName); result.append(value); } } } } return result.toString(); } // get AnnotatedType type and value public static String getAT(AnnotatedType at) throws Exception { Annotation[] annotations = at.getAnnotations(); return getAnno(annotations); } // get multiple AnnotatedType type and value public static List getMultipleAT(AnnotatedType[] as) throws Exception { List result = new ArrayList(); for (int i = 0; i < as.length; i++) { result.add(getAT(as[i])); } return result; } } -------------- next part -------------- /* * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. */ /** * @test * @bug 8013497 * @author Charlie * @summary test for API: Class.getAnnotatedInterfaces() * @build Helper * @run main ClsGetAnnotatedInterTest */ import java.io.File; import java.lang.annotation.Annotation; import java.lang.reflect.AnnotatedType; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; import java.net.MalformedURLException; import java.net.URL; import java.net.URLClassLoader; import java.util.ArrayList; import java.util.Arrays; import java.util.LinkedHashMap; import java.util.List; import java.util.Set; import javax.tools.DiagnosticCollector; import javax.tools.JavaFileObject; public class ClsGetAnnotatedInterTest { // combinations of annotations to test String[] annoComb = new String[]{"", Helper.SrcType.TYPEANNO1 + " ", Helper.SrcType.TYPEANNO2 + " " + Helper.SrcType.TYPEANNO2 + " " + Helper.SrcType.TYPEANNO3 + " ", Helper.SrcType.TYPEANNO2 + " " + Helper.SrcType.TYPEANNO2 + " " + Helper.SrcType.TYPEANNO2 + " ", Helper.SrcType.TYPEANNO3 + " " + Helper.SrcType.TYPEANNO3 + " " + Helper.SrcType.TYPEANNO3 + " ", Helper.SrcType.TYPEANNO3 + " "}; // holds class name -- annotation correspondence static LinkedHashMap testInput = new LinkedHashMap(); // Set it to true to get more debug information static final boolean DEBUG = false; String typeAnnoClsName = "TypeAnnoCls"; String typeAnnoIntName = "TypeAnnoInt"; String testBaseClsName = typeAnnoClsName + 0; static LinkedHashMap lhm = new LinkedHashMap(); enum TestCase { // base class TESTBASECLS() { // generate test base, input should be like [cls name] public String genTestCase(String... str) { /* generate class like below import java.io.*; import java.util.*; import java.lang.*; import java.lang.reflect.*; import java.lang.annotation.*; class testBaseClsName { } */ if (1 != str.length) { throw new RuntimeException("bad test base."); } String testCode = ""; lhm.clear(); lhm.put(Helper.SrcType.IMPORT, null); lhm.put(Helper.SrcType.CLASS, str[0]); testCode += Helper.genTestCode(lhm); lhm.clear(); lhm.put(Helper.SrcType.TYPEANNO1, ""); lhm.put(Helper.SrcType.TYPEANNO2, ""); lhm.put(Helper.SrcType.TYPEANNO3, ""); lhm.put(Helper.SrcType.TYPEANNOCONTAINER1, ""); lhm.put(Helper.SrcType.TYPEANNOCONTAINER2, ""); lhm.put(Helper.SrcType.TYPEANNOCONTAINER3, ""); testCode += Helper.genTestCode(lhm); lhm.clear(); return testCode; } }, // single interface SINGLEINT() { // input should be like [cls name, "@anno"] public String genTestCase(String... str) { // append annotation on ###: interface TypeAnnoInt01 { } if (2 != str.length) { throw new RuntimeException("bad test case."); } String testCode = ""; lhm.put(Helper.SrcType.INTERFACE, str[0]); testCode += Helper.genTestCode(lhm); lhm.clear(); testInput.put(str[0], null); return testCode; } }, // interface extends interface INTEXTINT() { // input should be like [cls name, "@anno"] public String genTestCase(String... str) { // append annotation on ###: interface TypeAnnoInt02 extends ### // Serializable { } if (2 != str.length) { throw new RuntimeException("bad test case."); } String testCode = ""; lhm.put(Helper.SrcType.INTERFACE, str[0]); lhm.put(Helper.SrcType.EXTENDS, str[1] + " Serializable"); testCode += Helper.genTestCode(lhm); lhm.clear(); testInput.put(str[0], str[1]); return testCode; } }, // single class SINGLECLS() { // input should be like [cls name, "@anno"] public String genTestCase(String... str) { // append annotation on ### class TypeAnnoCls01 { } if (2 != str.length) { throw new RuntimeException("bad test case."); } String testCode = ""; lhm.put(Helper.SrcType.CLASS, str[0]); testCode += Helper.genTestCode(lhm); lhm.clear(); testInput.put(str[0], null); return testCode; } }, // cls implements interface CLSIMPINTS() { // input should be like [cls name, "@anno"] public String genTestCase(String... str) { // append annotation on ### class TypeAnnoCls02 implements ### // Serializable, ### Cloneable{ } if (2 != str.length) { throw new RuntimeException("bad test case."); } String testCode = ""; lhm.put(Helper.SrcType.CLASS, str[0]); lhm.put(Helper.SrcType.IMPLEMENTS, new String[]{str[1] + " Serializable", str[1] + " Cloneable"}); testCode += Helper.genTestCode(lhm); lhm.clear(); testInput.put(str[0], str[1]); return testCode; } }; // generate test class of a specific case public String genTestCase(String... str) { return ""; } } // generate source code for test according to TestCase public String GenTestCode() { int i = 0; String testCode = ""; for (String anno : annoComb) { for (TestCase tc : TestCase.values()) { if (tc == TestCase.TESTBASECLS) { if (0 == i) { testCode += tc.genTestCase(testBaseClsName); i++; } } else { // append annotation on automatically generated // class/interface with given name if (tc == TestCase.SINGLEINT || tc == TestCase.INTEXTINT) { testCode += tc.genTestCase(typeAnnoIntName + i, anno); } else { testCode += tc.genTestCase(typeAnnoClsName + i, anno); } i++; } } } return testCode; } // compare input with result public boolean checkResult() throws Exception { boolean ret = true; String testCode = GenTestCode(); debugPrint(testCode); ClassLoader parentClassLoader = getClass().getClassLoader(); // Get Class object for the compiled class Helper.genClass(testCode, parentClassLoader, testBaseClsName); for (String clsName : testInput.keySet()) { // Get Class object for the compiled class Class c1 = Helper.loadClass(clsName, parentClassLoader, Helper.destDir); AnnotatedType[] as = c1.getAnnotatedInterfaces(); List result = Helper.getMultipleAT(as); if (0 == result.size()) { if (null != testInput.get(clsName)) { // should be empty output ret = false; debugPrint(clsName); } } else { for (int i = 0; i < result.size(); i++) { if (!result.get(i).equals(testInput.get(clsName))) { // annotations not match ret = false; debugPrint(clsName); } } } } return ret; } public void test() throws Exception { if (!checkResult()) { throw new RuntimeException("test fail."); } else { System.out.println("Pass."); } } public static void main(String[] args) throws Exception { new ClsGetAnnotatedInterTest().test(); } private static void debugPrint(String string) { if (DEBUG) { System.out.println(string); } } } From alex.buckley at oracle.com Mon Jun 3 14:52:23 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 03 Jun 2013 14:52:23 -0700 Subject: Review request for type annotation reflection test In-Reply-To: <51AC3A30.6000706@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> Message-ID: <51AD1017.9050703@oracle.com> Hi Charlie, First, I think there is some clever stuff going on here, but it's hard to figure out what it is. It's not enough to sprinkle comments like "// input should be like ["@A() @B()", "@C() @D()"...]" in SrcType. I would like an explanation of what a test case like ClsGetAnnotatedInterTest is trying to do. The TestCase enum type looks like a good place to start. Then, I would like to know how Helper.SrcType supports that with search-and-replace on keys like #ANNO. To be clear, I'm not looking for three bullet points; I'm looking for paragraphs that can be added to your code's javadoc and be useful to someone in ten years time. Second, in the interest of increasing the abstraction of Helper.SrcType, you should introduce an interface with a getSrc method and have it be implemented by the SrcType enum type. You should also remove duplicated code throughout SrcType's enum constant bodies (e.g. the code for "// get @anno for [#ANNO1] ..."). Third, please don't shorten terms which are part of the Java language. METHODHEAD should be METHOD_HEADER. METHODPARAM should be METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And so on. Rigor really matters when dealing with the Java language. Alex On 6/2/2013 11:39 PM, Charlie Wang wrote: > Hi, > Please review attached 2 files, which I've changed according to > comments. If OK, I will update the rest of the tests and publish for > review. > > Regards, > Charlie > On 2013/5/22 9:55, Joseph Darcy wrote: >> Hello, >> >> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>> I see you have extracted the validation logic and common annotation >>> types into TestUtil, so that any individual test will primarily be a >>> data provider + test cases. However: >>> >>> 1. Jon is our resident TestNG expert and he says that data providers >>> are intended to enumerate input values for tests; other code >>> determines which values should pass the tests and which values should >>> fail. But your data provider encodes the types and element values of >>> annotations which are expected to appear at various locations - this >>> is output data, not input data. >>> >>> 2. There is basically no abstraction over the expected annotations in >>> the data provider. It's just a bunch of Object[][] values. >>> Consequently, TestUtil is very brittle. There is weird indexing of >>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>> knowledge of specific test cases: >>> >>> catch (NoSuchMethodException e) { >>> //expected exception for TypeAnno3 >>> } >>> >>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>> at present, but if they ever share state then you'll be in trouble, >>> especially with the instance methods in GetAnnotated*Test. >>> >>> Charlie, there are two techniques you should adopt for tests on the >>> core reflection API: >>> >>> - First, encode expected values of type annotations more directly, by >>> annotating the AnnotationTypeTestXX declarations themselves. >> >> Note that this technique is used in various other regression tests in >> the JDK repository. For some recently-written small examples see >> >> test/java/lang/reflect/Parameter/WithoutParameters.java >> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >> >>> >>> - Second, embrace combinatorial testing rather than declaring a bunch >>> of ad-hoc AnnotationTypeTestXX types with type annotations in various >>> locations. >>> >>> The core reflection tests for repeating annotations use both these >>> techniques. Please look at item 2 of >>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>> - apologies for non-Oracle readers. Please talk with Steve and >>> Matherey to get background. To be clear, I will not sign off the type >>> annotations reflection tests in their present form. >> >> I concur that using combinatorial tests is appropriate for this >> domain. The basic approach is to programatically generate both the >> expected result and the code to test and verify that the computed >> answer is consistent with the expected one. The regression tests >> currently in JDK 8 have code that allows source code to be generated >> at runtime, loading in by a class loader, and then run. >> >> HTH, >> >> -Joe >> >>> >>> Alex >>> >>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>> OK, thanks. >>>> I will create a TestUtil.java (as attached file). Extract the common >>>> part and put them in it. And Add comments on data provider. >>>> I'm on a very tight schedule, so this time I just send out two of the >>>> updated files (attached files) for review so I can get a quick >>>> response. >>>> If it is OK, I will use it as a template on other tests. >>>> Please take a look and send me your comments as soon as possible. >>>> >>>> >>>> Thanks, >>>> Charlie >>>> >>>> >>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>> Please keep one source file per tested API method, because it is easy >>>>> to navigate. The problem is the body of the test() method in each >>>>> source file. It should call utility methods to inspect annotations, >>>>> rather that repeating more or less the same 'for' loops as every other >>>>> test() method. >>>>> >>>>> As for data providers, I believe they are a TestNG thing. Please add >>>>> comments to each source file to describe what the data provider >>>>> represents. >>>>> >>>>> Finally, when you make a "little update", you should give a short >>>>> description of what has changed. If you don't, someone who looked at >>>>> the previous version has no idea what changed and will have to look at >>>>> everything again. >>>>> >>>>> Alex >>>>> >>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>> Yes, that make sense. What do you think if I combine the tests? It >>>>>> would >>>>>> then have 1 unified data provider and test method, thus solve the 2 >>>>>> problems. >>>>>> >>>>>> Regards, >>>>>> Charlie >>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>> I agree with Alex's first two comments. The code duplication for the >>>>>>> test logic and all the different annotation types seems hard to >>>>>>> maintain and update. >>>>>>> >>>>>>> cu, WMD. >>>>>>> >>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>> wrote: >>>>>>>> Hi, >>>>>>>> Here's the latest one with a little update: >>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>> Please provide comments as soon as possible now that due date is >>>>>>>> approaching. >>>>>>>> >>>>>>>> >>>>>>>> Regards, >>>>>>>> Charlie >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>> >>>>>>>> Hi, >>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>> JDK-8013497. >>>>>>>> Please take a look. >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>> >>>>>>>> >>>>>>>> Regards, >>>>>>>> Charlie >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>> >> From maurizio.cimadamore at oracle.com Tue Jun 4 09:13:57 2013 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 04 Jun 2013 17:13:57 +0100 Subject: RFR: 8004643 Reduce javac space overhead introduced with compiler support for repeating annotations In-Reply-To: <51A958F1.3010203@oracle.com> References: <51A958F1.3010203@oracle.com> Message-ID: <51AE1245.6040709@oracle.com> Hi Jon, the patch is fine in th short term - this is a list of issues I think we should work on to alleviate the pain in this area: *) There's an annoying split between symbol annos and type annos; we have twice the methods we need - I think some work should be done to consolidate existing APIs onto a more stable version where stuff like this: public boolean hasAnnotations() { + return (annotations != null && !annotations.isEmpty()); + } + + public boolean hasTypeAnnotations() { + return (annotations != null && !annotations.isTypesEmpty()); + } Is replaced by this: public boolean hasAnnotations(AnnoKind kind) { ... } *) I think all methods that modify annotations should not be exposed through Symbol API *) This should be done via a Symbol flag - annotationsPendingCompletion In other words, I would keep the Symbol API light by providing: *) a way for getting symbol/type annos *) a way to tell as to whether annotation completion has already happened (i.e. will the above method yield meaningful answer?) Everything else should be done through a separate class (Annotations), pretty much like we do now, by accessing symbol's metadata and playing with it. I also would remove any back pointer from Annotations to Symbol (if any). Maurizio On 01/06/13 03:14, Jonathan Gibbons wrote: > More from the javac janitation crew, cleaning up the odds and ends. > > This is a relatively simple fix for the space overhead introduced by > allocating an Annotations object for every Symbol. The fix is to hide > the Annotations object behind methods in Symbol (which also cleans up > the client code a bunch) and to lazily allocate the Annotations object > if and only if it is needed. If the reference to the Annotations > object is null, that means "no annotations on this symbol". (I tried > using an immutable empty object, but it caused more clutter than it > saved.) > > Most notably, Annotations is not itself changed by this changeset. > > The savings on a JDK build are significant, going from every Symbol > having an Annotations object, to < 1% of Symbols needing an > Annotations object ... from 4,024,455 to just 35,272. In the table > below, each row is a separate javac compilation in the JDK build. The > left hand block of numbers comes from a recent build of TL; the right > hand block of numbers comes from a build of TL with the patch applied. > There may be more optimizations possible, by further improving the > checks on whether a new Annotations object is required. > > There's a couple of related minor cleanups here as well. Going > forward, it would be nice to clean up the method names on Annotations > and the wrapper methods on Symbol. There's an inconsistent set of > names using fragments like {(empty), Raw, Declaration, Type} x > {Attributes, Annotations}. Once we can decide on a better set of > names, we can do a separate "renaming only" changeset for that. > > The webrev is available at > http://cr.openjdk.java.net/~jjg/8004643/webrev.00/ It is against > tl/langtools. > > -- Jon > > > > > > OLD > > > NEW > > > > Symbols Annotations % > Symbols Annotations % > > > 269,144 269,144 100.00% > 269,191 1,817 0.67% > > > 4,463 4,463 100.00% > 4,463 32 0.72% > > > 39,845 39,845 100.00% > 39,845 40 0.10% > > > 2,276 2,276 100.00% > 2,276 7 0.31% > > > 224,546 224,546 100.00% > 224,546 182 0.08% > > > 356,137 356,137 100.00% > 356,137 343 0.10% > > > 8,610 8,610 100.00% > 8,610 37 0.43% > > > 428,097 428,097 100.00% > 428,097 4,884 1.14% > > > 49,031 49,031 100.00% > 49,031 253 0.52% > > > 1,338 1,338 100.00% > 1,338 4 0.30% > > > 2,016,962 2,016,962 100.00% > 2,017,279 9,824 0.49% > > > 2,642 2,642 100.00% > 3,944 110 2.79% > > > 3,937 3,937 100.00% > 2,642 78 2.95% > > > 3,944 3,944 100.00% > 3,937 112 2.84% > > > 4,015 4,015 100.00% > 4,015 101 2.52% > > > 5,361 5,361 100.00% > 4,462 120 2.69% > > > 4,779 4,779 100.00% > 5,361 139 2.59% > > > 3,855 3,855 100.00% > 4,281 88 2.06% > > > 4,281 4,281 100.00% > 4,779 135 2.82% > > > 4,462 4,462 100.00% > 4,447 107 2.41% > > > 4,546 4,546 100.00% > 4,546 102 2.24% > > > 5,795 5,795 100.00% > 3,855 28 0.73% > > > 4,447 4,447 100.00% > 5,795 144 2.48% > > > 5,176 5,176 100.00% > 6,496 117 1.80% > > > 6,496 6,496 100.00% > 5,176 144 2.78% > > > 6,056 6,056 100.00% > 6,056 118 1.95% > > > 5,759 5,759 100.00% > 5,759 112 1.94% > > > 4,926 4,926 100.00% > 4,926 106 2.15% > > > 1,025 1,025 100.00% > 6,468 136 2.10% > > > 3,697 3,697 100.00% > 4,185 43 1.03% > > > 6,468 6,468 100.00% > 7,804 139 1.78% > > > 4,185 4,185 100.00% > 3,697 40 1.08% > > > 7,809 7,809 100.00% > 1,025 12 1.17% > > > 8,878 8,878 100.00% > 8,878 170 1.91% > > > 7,804 7,804 100.00% > 7,809 173 2.22% > > > 1,029 1,029 100.00% > 10,420 164 1.57% > > > 1,403 1,403 100.00% > 8,011 183 2.28% > > > 10,420 10,420 100.00% > 10,024 227 2.26% > > > 8,011 8,011 100.00% > 11,303 190 1.68% > > > 10,024 10,024 100.00% > 12,225 231 1.89% > > > 11,303 11,303 100.00% > 1,029 12 1.17% > > > 12,225 12,225 100.00% > 1,403 28 2.00% > > > 15,827 15,827 100.00% > 15,827 173 1.09% > > > 12,642 12,642 100.00% > 12,686 166 1.31% > > > 124,653 124,653 100.00% > 124,654 2,824 2.27% > > > 39,797 39,797 100.00% > 39,797 691 1.74% > > > 255,866 255,866 100.00% > 255,910 10,386 4.06% > > TOTAL 4,023,992 4,023,992 100.00% > 4,024,445 35,272 0.88% > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130604/a44a481f/attachment-0001.html From jonathan.gibbons at oracle.com Tue Jun 4 09:24:06 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 04 Jun 2013 09:24:06 -0700 Subject: RFR: 8004643 Reduce javac space overhead introduced with compiler support for repeating annotations In-Reply-To: <51AE1245.6040709@oracle.com> References: <51A958F1.3010203@oracle.com> <51AE1245.6040709@oracle.com> Message-ID: <51AE14A6.6040004@oracle.com> Thanks. JDK-8015899 filed to track the folowup issue. I think we need to focus on consolidating the Annotations abstraction before we focus on cleaning up how it is accessed via Symbol. Or at least, we should work on it in maybe multiple cleanup phases. --Jon On 06/04/2013 09:13 AM, Maurizio Cimadamore wrote: > Hi Jon, > the patch is fine in th short term - this is a list of issues I think > we should work on to alleviate the pain in this area: > > *) There's an annoying split between symbol annos and type annos; we > have twice the methods we need - I think some work should be done to > consolidate existing APIs onto a more stable version where stuff like > this: > > public boolean hasAnnotations() { > + return (annotations != null && !annotations.isEmpty()); > + } > + > + public boolean hasTypeAnnotations() { > + return (annotations != null && !annotations.isTypesEmpty()); > + } > > > Is replaced by this: > > public boolean hasAnnotations(AnnoKind kind) { ... } > > > *) I think all methods that modify annotations should not be exposed > through Symbol API > > *) This should be done via a Symbol flag > > - annotationsPendingCompletion > > In other words, I would keep the Symbol API light by providing: > > *) a way for getting symbol/type annos > *) a way to tell as to whether annotation completion has already > happened (i.e. will the above method yield meaningful answer?) > > Everything else should be done through a separate class (Annotations), > pretty much like we do now, by accessing symbol's metadata and playing > with it. I also would remove any back pointer from Annotations to > Symbol (if any). > > Maurizio > > > On 01/06/13 03:14, Jonathan Gibbons wrote: >> More from the javac janitation crew, cleaning up the odds and ends. >> >> This is a relatively simple fix for the space overhead introduced by >> allocating an Annotations object for every Symbol. The fix is to >> hide the Annotations object behind methods in Symbol (which also >> cleans up the client code a bunch) and to lazily allocate the >> Annotations object if and only if it is needed. If the reference to >> the Annotations object is null, that means "no annotations on this >> symbol". (I tried using an immutable empty object, but it caused more >> clutter than it saved.) >> >> Most notably, Annotations is not itself changed by this changeset. >> >> The savings on a JDK build are significant, going from every Symbol >> having an Annotations object, to < 1% of Symbols needing an >> Annotations object ... from 4,024,455 to just 35,272. In the table >> below, each row is a separate javac compilation in the JDK build. >> The left hand block of numbers comes from a recent build of TL; the >> right hand block of numbers comes from a build of TL with the patch >> applied. There may be more optimizations possible, by further >> improving the checks on whether a new Annotations object is required. >> >> There's a couple of related minor cleanups here as well. Going >> forward, it would be nice to clean up the method names on Annotations >> and the wrapper methods on Symbol. There's an inconsistent set of >> names using fragments like {(empty), Raw, Declaration, Type} x >> {Attributes, Annotations}. Once we can decide on a better set of >> names, we can do a separate "renaming only" changeset for that. >> >> The webrev is available at >> http://cr.openjdk.java.net/~jjg/8004643/webrev.00/ It is against >> tl/langtools. > > > > >> >> -- Jon >> >> >> >> >> >> OLD >> >> >> NEW >> >> >> >> Symbols Annotations % >> Symbols Annotations % >> >> >> 269,144 269,144 100.00% >> 269,191 1,817 0.67% >> >> >> 4,463 4,463 100.00% >> 4,463 32 0.72% >> >> >> 39,845 39,845 100.00% >> 39,845 40 0.10% >> >> >> 2,276 2,276 100.00% >> 2,276 7 0.31% >> >> >> 224,546 224,546 100.00% >> 224,546 182 0.08% >> >> >> 356,137 356,137 100.00% >> 356,137 343 0.10% >> >> >> 8,610 8,610 100.00% >> 8,610 37 0.43% >> >> >> 428,097 428,097 100.00% >> 428,097 4,884 1.14% >> >> >> 49,031 49,031 100.00% >> 49,031 253 0.52% >> >> >> 1,338 1,338 100.00% >> 1,338 4 0.30% >> >> >> 2,016,962 2,016,962 100.00% >> 2,017,279 9,824 0.49% >> >> >> 2,642 2,642 100.00% >> 3,944 110 2.79% >> >> >> 3,937 3,937 100.00% >> 2,642 78 2.95% >> >> >> 3,944 3,944 100.00% >> 3,937 112 2.84% >> >> >> 4,015 4,015 100.00% >> 4,015 101 2.52% >> >> >> 5,361 5,361 100.00% >> 4,462 120 2.69% >> >> >> 4,779 4,779 100.00% >> 5,361 139 2.59% >> >> >> 3,855 3,855 100.00% >> 4,281 88 2.06% >> >> >> 4,281 4,281 100.00% >> 4,779 135 2.82% >> >> >> 4,462 4,462 100.00% >> 4,447 107 2.41% >> >> >> 4,546 4,546 100.00% >> 4,546 102 2.24% >> >> >> 5,795 5,795 100.00% >> 3,855 28 0.73% >> >> >> 4,447 4,447 100.00% >> 5,795 144 2.48% >> >> >> 5,176 5,176 100.00% >> 6,496 117 1.80% >> >> >> 6,496 6,496 100.00% >> 5,176 144 2.78% >> >> >> 6,056 6,056 100.00% >> 6,056 118 1.95% >> >> >> 5,759 5,759 100.00% >> 5,759 112 1.94% >> >> >> 4,926 4,926 100.00% >> 4,926 106 2.15% >> >> >> 1,025 1,025 100.00% >> 6,468 136 2.10% >> >> >> 3,697 3,697 100.00% >> 4,185 43 1.03% >> >> >> 6,468 6,468 100.00% >> 7,804 139 1.78% >> >> >> 4,185 4,185 100.00% >> 3,697 40 1.08% >> >> >> 7,809 7,809 100.00% >> 1,025 12 1.17% >> >> >> 8,878 8,878 100.00% >> 8,878 170 1.91% >> >> >> 7,804 7,804 100.00% >> 7,809 173 2.22% >> >> >> 1,029 1,029 100.00% >> 10,420 164 1.57% >> >> >> 1,403 1,403 100.00% >> 8,011 183 2.28% >> >> >> 10,420 10,420 100.00% >> 10,024 227 2.26% >> >> >> 8,011 8,011 100.00% >> 11,303 190 1.68% >> >> >> 10,024 10,024 100.00% >> 12,225 231 1.89% >> >> >> 11,303 11,303 100.00% >> 1,029 12 1.17% >> >> >> 12,225 12,225 100.00% >> 1,403 28 2.00% >> >> >> 15,827 15,827 100.00% >> 15,827 173 1.09% >> >> >> 12,642 12,642 100.00% >> 12,686 166 1.31% >> >> >> 124,653 124,653 100.00% >> 124,654 2,824 2.27% >> >> >> 39,797 39,797 100.00% >> 39,797 691 1.74% >> >> >> 255,866 255,866 100.00% >> 255,910 10,386 4.06% >> >> TOTAL 4,023,992 4,023,992 100.00% >> 4,024,445 35,272 0.88% >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130604/53a6d844/attachment-0001.html From wdietl at gmail.com Tue Jun 4 23:08:27 2013 From: wdietl at gmail.com (Werner Dietl) Date: Tue, 4 Jun 2013 23:08:27 -0700 Subject: RFR: 8004643 Reduce javac space overhead introduced with compiler support for repeating annotations In-Reply-To: <51AE14A6.6040004@oracle.com> References: <51A958F1.3010203@oracle.com> <51AE1245.6040709@oracle.com> <51AE14A6.6040004@oracle.com> Message-ID: Hi Jon, I think it's great that all these allocations of Annotations are removed. The changes look good to me. cu, WMD. On Tue, Jun 4, 2013 at 9:24 AM, Jonathan Gibbons < jonathan.gibbons at oracle.com> wrote: > Thanks. JDK-8015899 filed to track the folowup issue. > > I think we need to focus on consolidating the Annotations abstraction > before we focus on cleaning up how it is accessed via Symbol. Or at least, > we should work on it in maybe multiple cleanup phases. > > --Jon > > > > > On 06/04/2013 09:13 AM, Maurizio Cimadamore wrote: > > Hi Jon, > the patch is fine in th short term - this is a list of issues I think we > should work on to alleviate the pain in this area: > > *) There's an annoying split between symbol annos and type annos; we have > twice the methods we need - I think some work should be done to consolidate > existing APIs onto a more stable version where stuff like this: > > public boolean hasAnnotations() { > + return (annotations != null && !annotations.isEmpty()); > + } > + > + public boolean hasTypeAnnotations() { > + return (annotations != null && !annotations.isTypesEmpty()); > + } > > > Is replaced by this: > > public boolean hasAnnotations(AnnoKind kind) { ... } > > > *) I think all methods that modify annotations should not be exposed > through Symbol API > > *) This should be done via a Symbol flag > > - annotationsPendingCompletion > > In other words, I would keep the Symbol API light by providing: > > *) a way for getting symbol/type annos > *) a way to tell as to whether annotation completion has already happened > (i.e. will the above method yield meaningful answer?) > > Everything else should be done through a separate class (Annotations), > pretty much like we do now, by accessing symbol's metadata and playing with > it. I also would remove any back pointer from Annotations to Symbol (if > any). > > Maurizio > > > On 01/06/13 03:14, Jonathan Gibbons wrote: > > More from the javac janitation crew, cleaning up the odds and ends. > > This is a relatively simple fix for the space overhead introduced by > allocating an Annotations object for every Symbol. The fix is to hide the > Annotations object behind methods in Symbol (which also cleans up the > client code a bunch) and to lazily allocate the Annotations object if and > only if it is needed. If the reference to the Annotations object is null, > that means "no annotations on this symbol". (I tried using an immutable > empty object, but it caused more clutter than it saved.) > > Most notably, Annotations is not itself changed by this changeset. > > The savings on a JDK build are significant, going from every Symbol having > an Annotations object, to < 1% of Symbols needing an Annotations object ... > from 4,024,455 to just 35,272. In the table below, each row is a separate > javac compilation in the JDK build. The left hand block of numbers comes > from a recent build of TL; the right hand block of numbers comes from a > build of TL with the patch applied. There may be more optimizations > possible, by further improving the checks on whether a new Annotations > object is required. > > There's a couple of related minor cleanups here as well. Going forward, it > would be nice to clean up the method names on Annotations and the wrapper > methods on Symbol. There's an inconsistent set of names using fragments > like {(empty), Raw, Declaration, Type} x {Attributes, Annotations}. Once > we can decide on a better set of names, we can do a separate "renaming > only" changeset for that. > > The webrev is available at > http://cr.openjdk.java.net/~jjg/8004643/webrev.00/ It is against > tl/langtools. > > > > > > > -- Jon > > > > > > OLD > > > NEW > > > > Symbols Annotations % > Symbols Annotations % > > 269,144 269,144 100.00% > 269,191 1,817 0.67% > > 4,463 4,463 100.00% > 4,463 32 0.72% > > 39,845 39,845 100.00% > 39,845 40 0.10% > > 2,276 2,276 100.00% > 2,276 7 0.31% > > 224,546 224,546 100.00% > 224,546 182 0.08% > > 356,137 356,137 100.00% > 356,137 343 0.10% > > 8,610 8,610 100.00% > 8,610 37 0.43% > > 428,097 428,097 100.00% > 428,097 4,884 1.14% > > 49,031 49,031 100.00% > 49,031 253 0.52% > > 1,338 1,338 100.00% > 1,338 4 0.30% > > 2,016,962 2,016,962 100.00% > 2,017,279 9,824 0.49% > > 2,642 2,642 100.00% > 3,944 110 2.79% > > 3,937 3,937 100.00% > 2,642 78 2.95% > > 3,944 3,944 100.00% > 3,937 112 2.84% > > 4,015 4,015 100.00% > 4,015 101 2.52% > > 5,361 5,361 100.00% > 4,462 120 2.69% > > 4,779 4,779 100.00% > 5,361 139 2.59% > > 3,855 3,855 100.00% > 4,281 88 2.06% > > 4,281 4,281 100.00% > 4,779 135 2.82% > > 4,462 4,462 100.00% > 4,447 107 2.41% > > 4,546 4,546 100.00% > 4,546 102 2.24% > > 5,795 5,795 100.00% > 3,855 28 0.73% > > 4,447 4,447 100.00% > 5,795 144 2.48% > > 5,176 5,176 100.00% > 6,496 117 1.80% > > 6,496 6,496 100.00% > 5,176 144 2.78% > > 6,056 6,056 100.00% > 6,056 118 1.95% > > 5,759 5,759 100.00% > 5,759 112 1.94% > > 4,926 4,926 100.00% > 4,926 106 2.15% > > 1,025 1,025 100.00% > 6,468 136 2.10% > > 3,697 3,697 100.00% > 4,185 43 1.03% > > 6,468 6,468 100.00% > 7,804 139 1.78% > > 4,185 4,185 100.00% > 3,697 40 1.08% > > 7,809 7,809 100.00% > 1,025 12 1.17% > > 8,878 8,878 100.00% > 8,878 170 1.91% > > 7,804 7,804 100.00% > 7,809 173 2.22% > > 1,029 1,029 100.00% > 10,420 164 1.57% > > 1,403 1,403 100.00% > 8,011 183 2.28% > > 10,420 10,420 100.00% > 10,024 227 2.26% > > 8,011 8,011 100.00% > 11,303 190 1.68% > > 10,024 10,024 100.00% > 12,225 231 1.89% > > 11,303 11,303 100.00% > 1,029 12 1.17% > > 12,225 12,225 100.00% > 1,403 28 2.00% > > 15,827 15,827 100.00% > 15,827 173 1.09% > > 12,642 12,642 100.00% > 12,686 166 1.31% > > 124,653 124,653 100.00% > 124,654 2,824 2.27% > > 39,797 39,797 100.00% > 39,797 691 1.74% > > 255,866 255,866 100.00% > 255,910 10,386 4.06% > TOTAL 4,023,992 4,023,992 100.00% > 4,024,445 35,272 0.88% > > > > -- http://www.google.com/profiles/wdietl -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130604/a3289c05/attachment-0001.html From wdietl at gmail.com Tue Jun 4 23:55:36 2013 From: wdietl at gmail.com (Werner Dietl) Date: Tue, 4 Jun 2013 23:55:36 -0700 Subject: test for inner and anon class In-Reply-To: <519FD227.4020900@oracle.com> References: <519EBA74.1020101@oracle.com> <519EBCC3.6060207@oracle.com> <519FD227.4020900@oracle.com> Message-ID: Hi Steve, Jon, that URL doesn't work for me from outside Oracle, so I was expecting somebody on the inside to push it. I tried http://cr.openjdk.java.net/~ssides/8015323.1/webrev.01/ but there doesn't seem to be a mapping there. cu, WMD. On Fri, May 24, 2013 at 1:48 PM, Steve Sides wrote: > On 5/23/2013 6:05 PM, Jonathan Gibbons wrote: >> >> On 05/23/2013 05:55 PM, Steve Sides wrote: >>> >>> Hi Werner, >>> I updated the test I had for Inner and anonymous classes. It has been >>> blocked by a few bugs (listed @bug) which are now fixed. >>> However, as I started enabling the tests I ran in to a couple more. The >>> test is here, >>> http://cr.openjdk.java.net/~ssides/8015323/ >>> but it will fail due to these two >>> >>> 8015323 If class InnerAnnon is instantiated, type annotations on ia_m1() >>> are incorrectly written to classfile. >>> >>> 8015257 A type annotation with ElementTypes TYPE_USE and FIELD placed on >>> type >>> argument is placed on the ctor if repeated and on the field if not >>> repeated. >>> >>> There is currently an @ignore on the test as I wasn't sure which repo >>> this might want to go into, and if in tl/langtools it should have the >>> ignore. >>> The affect parts of the test are noted in the generated test sources(if >>> you comment out all the next lines, it'll pass). >>> >>> The 8015323 scenario used to crash, not they're written incorrectly. >>> 8015727 used to not write to classfile at all if repeated, not it just >>> writes incorrectly. >>> >>> The test case is a little clunky looking, but it found several bugs and I >>> found it runs faster and is very easy to diagnose and narrow down a test >>> case. >>> >>> -steve >>> >>> >> >> Steve, >> >> Nice test. >> >> I don't know if it would ease maintenance, but one suggestion might be to >> move the testsource string into a separate file, called something like >> testsource.template, and then read it into a String use java.nio.file.Files >> API. I know normally we keep the template within the main source file, but >> this template is getting pretty long. Anyway, just a suggestion, for your >> ease-of-use. Your call. >> >> -- Jon > > I put the source in a template file. I created a new webrev for it since > it's not checked in anywhere yet. > http://sqeweb.us.oracle.com/coretools/ssides/webrevs/8015323.1/webrev.01/ > As is, it does not have @ignore and it fails with the buggy lines having > comments above them in the template. > > -steve -- http://www.google.com/profiles/wdietl From wdietl at gmail.com Wed Jun 5 00:06:32 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 05 Jun 2013 07:06:32 +0000 Subject: hg: type-annotations/type-annotations/corba: 3 new changesets Message-ID: <20130605070640.AA80848F68@hg.openjdk.java.net> Changeset: 717aa26f8e0a Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/717aa26f8e0a Added tag jdk8-b91 for changeset 8f7ffb296385 ! .hgtags Changeset: 8dc9d7ccbb2d Author: katleman Date: 2013-05-30 10:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/8dc9d7ccbb2d Added tag jdk8-b92 for changeset 717aa26f8e0a ! .hgtags Changeset: 6af2621cc39d Author: wmdietl Date: 2013-06-04 23:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/6af2621cc39d Automated merge with http://hg.openjdk.java.net/jdk8/tl/corba ! .hgtags From wdietl at gmail.com Wed Jun 5 00:06:53 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 05 Jun 2013 07:06:53 +0000 Subject: hg: type-annotations/type-annotations/jaxws: 3 new changesets Message-ID: <20130605070713.3498948F69@hg.openjdk.java.net> Changeset: a0f604766ca1 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/a0f604766ca1 Added tag jdk8-b91 for changeset 0bb1a9fa56b0 ! .hgtags Changeset: 7386eca865e1 Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/7386eca865e1 Added tag jdk8-b92 for changeset a0f604766ca1 ! .hgtags Changeset: ec41c0fe6754 Author: wmdietl Date: 2013-06-04 23:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/ec41c0fe6754 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxws ! .hgtags From wdietl at gmail.com Wed Jun 5 00:05:57 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 05 Jun 2013 07:05:57 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 6 new changesets Message-ID: <20130605070610.93F0848F66@hg.openjdk.java.net> Changeset: dee23cce5235 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/dee23cce5235 Added tag jdk8-b91 for changeset 6b9f41203800 ! .hgtags Changeset: 1c7481ac7fe0 Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/1c7481ac7fe0 Added tag jdk8-b92 for changeset dee23cce5235 ! .hgtags Changeset: 7e105c2f3167 Author: lana Date: 2013-06-03 16:10 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/7e105c2f3167 Merge Changeset: 4463e94d9b0d Author: lana Date: 2013-05-29 16:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/4463e94d9b0d Merge - src/jdk/nashorn/internal/runtime/options/ValueOption.java - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java - src/netscape/javascript/JSObject.java Changeset: ddbf41575a2b Author: lana Date: 2013-06-03 23:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/ddbf41575a2b Merge - src/jdk/nashorn/internal/runtime/options/ValueOption.java - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java - src/netscape/javascript/JSObject.java Changeset: d2bd881976b5 Author: lana Date: 2013-06-04 21:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d2bd881976b5 Merge From wdietl at gmail.com Wed Jun 5 00:06:21 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 05 Jun 2013 07:06:21 +0000 Subject: hg: type-annotations/type-annotations: 13 new changesets Message-ID: <20130605070623.B7CE148F67@hg.openjdk.java.net> Changeset: eea249c1ecee Author: erikj Date: 2013-05-21 13:18 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/eea249c1ecee 8014508: Fix log levels in make Reviewed-by: tbell ! NewMakefile.gmk ! common/autoconf/spec.gmk.in Changeset: e83abb0a04ab Author: katleman Date: 2013-05-21 12:51 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/e83abb0a04ab Merge Changeset: cb51fb4789ac Author: andrew Date: 2013-05-22 13:49 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/cb51fb4789ac 8015087: Provide debugging information for programs Summary: Enable debugging info on programs in OpenJDK builds Reviewed-by: erikj ! common/makefiles/NativeCompilation.gmk Changeset: f089df41bff5 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/f089df41bff5 Added tag jdk8-b91 for changeset cb51fb4789ac ! .hgtags Changeset: e247ee3924d5 Author: erikj Date: 2013-05-22 17:26 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/e247ee3924d5 8014514: Fix jvm args for sjavac Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/build-performance.m4 ! common/autoconf/generated-configure.sh Changeset: e7c09a983c3c Author: erikj Date: 2013-05-28 08:50 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/e7c09a983c3c 8007129: build-infra Add configure --with-jtreg option for location of JTREG Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 Changeset: 3a36c926a7aa Author: katleman Date: 2013-05-28 17:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/3a36c926a7aa Merge Changeset: 46be9eb242d1 Author: katleman Date: 2013-05-30 10:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/46be9eb242d1 Added tag jdk8-b92 for changeset 3a36c926a7aa ! .hgtags Changeset: b1ccd05cb64b Author: wmdietl Date: 2013-06-04 22:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/b1ccd05cb64b Automated merge with http://hg.openjdk.java.net/jdk8/tl/ ! .hgtags Changeset: 78852ce176db Author: jqzuo Date: 2013-05-28 20:03 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/78852ce176db 8014762: Add JMC configure option mapping to Jprt.gmk Summary: Need to add the mapping between JPRT env var and configure flag for JMC, from ALT_JMC_ZIP_DIR to --with-jmc-zip-dir (same pattern as for Javafx) Reviewed-by: tbell, erikj Contributed-by: klara.ward at oracle.com ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gmk Changeset: c22d59e3f06e Author: pbhat Date: 2013-05-29 11:02 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/c22d59e3f06e Merge Changeset: ea6f3bf82903 Author: jqzuo Date: 2013-06-04 00:12 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/ea6f3bf82903 Merge ! common/autoconf/generated-configure.sh Changeset: 1eff91a06d6e Author: wmdietl Date: 2013-06-04 23:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/1eff91a06d6e Automated merge with http://hg.openjdk.java.net/jdk8/tl/ From wdietl at gmail.com Wed Jun 5 00:07:28 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 05 Jun 2013 07:07:28 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 6 new changesets Message-ID: <20130605070758.1A27E48F6A@hg.openjdk.java.net> Changeset: 827b59af45f3 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/827b59af45f3 Added tag jdk8-b91 for changeset e3065fb07877 ! .hgtags Changeset: 1ab5d8d6eab8 Author: katleman Date: 2013-05-29 10:15 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/1ab5d8d6eab8 8015525: JDK8 b91 source with GPL header errors Reviewed-by: dholmes, lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java Changeset: a6596a06e10b Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/a6596a06e10b Added tag jdk8-b92 for changeset 1ab5d8d6eab8 ! .hgtags Changeset: f117a66f337c Author: lana Date: 2013-06-03 16:09 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/f117a66f337c Merge Changeset: 5b958f0a5498 Author: joehw Date: 2013-06-04 09:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/5b958f0a5498 8015630: Remove default restriction settings of jaxp 1.5 properties in JDK8 Reviewed-by: alanb ! src/com/sun/org/apache/xalan/internal/XalanConstants.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xerces/internal/impl/Constants.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/XMLSchemaFactory.java Changeset: 95763a96d748 Author: wmdietl Date: 2013-06-04 23:14 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/95763a96d748 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxp ! .hgtags From wdietl at gmail.com Wed Jun 5 00:13:02 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 05 Jun 2013 07:13:02 +0000 Subject: hg: type-annotations/type-annotations/langtools: 22 new changesets Message-ID: <20130605071613.5000148F6B@hg.openjdk.java.net> Changeset: e9855150c5b0 Author: vromero Date: 2013-06-01 21:57 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e9855150c5b0 8010737: javac, known parameter's names should be copied to automatically generated constructors for inner classes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! test/tools/javac/MethodParameters/ClassFileVisitor.java ! test/tools/javac/MethodParameters/ReflectionVisitor.java + test/tools/javac/T8010737/ParameterNamesAreNotCopiedToAnonymousInitTest.java Changeset: ec871c3e8337 Author: vromero Date: 2013-06-01 22:09 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/ec871c3e8337 6695379: Copy method annotations and parameter annotations to synthetic bridge methods Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! test/tools/javac/6889255/T6889255.java ! test/tools/javac/MethodParameters/ClassFileVisitor.java ! test/tools/javac/MethodParameters/ReflectionVisitor.java ! test/tools/javac/MethodParameters/Tester.java + test/tools/javac/T6695379/AnnotationsAreNotCopiedToBridgeMethodsTest.java Changeset: 391f97e270c2 Author: jjg Date: 2013-06-03 16:22 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/391f97e270c2 8013405: DocLint should support
  • Reviewed-by: ksrini ! src/share/classes/com/sun/tools/doclint/Checker.java ! src/share/classes/com/sun/tools/doclint/HtmlTag.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties ! test/tools/doclint/html/ListTagsTest.java + test/tools/doclint/html/ListTagsTest.out Changeset: 4830d661c4f9 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/4830d661c4f9 Added tag jdk8-b91 for changeset 997c0fae2b12 ! .hgtags Changeset: 58eace4d997f Author: erikj Date: 2013-05-28 08:49 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/58eace4d997f 8012566: Replace find, rm, printf and similar with their proper variables Reviewed-by: tbell ! makefiles/BuildLangtools.gmk Changeset: 3597773628a4 Author: katleman Date: 2013-05-28 17:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/3597773628a4 Merge Changeset: 149890642a0e Author: katleman Date: 2013-05-29 10:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/149890642a0e 8015525: JDK8 b91 source with GPL header errors Reviewed-by: dholmes, lancea ! test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java Changeset: 023e9a614d26 Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/023e9a614d26 Added tag jdk8-b92 for changeset 149890642a0e ! .hgtags Changeset: 8258f84a8649 Author: lana Date: 2013-06-03 16:10 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/8258f84a8649 Merge Changeset: 7a4fd1076b15 Author: lana Date: 2013-06-03 16:56 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/7a4fd1076b15 Merge Changeset: 242bcad5be74 Author: jjg Date: 2013-06-03 17:09 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/242bcad5be74 8006615: [doclint] move remaining messages into resource bundle Reviewed-by: mcimadamore, vromero ! src/share/classes/com/sun/tools/doclint/DocLint.java ! src/share/classes/com/sun/tools/doclint/resources/doclint.properties + test/tools/doclint/ResourceTest.java ! test/tools/doclint/tool/RunTest.java Changeset: 019063968164 Author: jjg Date: 2013-06-03 17:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/019063968164 8007687: javadoc -X does not include -Xdoclint Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties ! test/com/sun/javadoc/testHelpOption/TestHelpOption.java + test/com/sun/javadoc/testXOption/TestXOption.java Changeset: 5cd3cb69c8b3 Author: mcimadamore Date: 2013-06-04 11:30 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/5cd3cb69c8b3 7116676: RichDiagnosticFormatter throws NPE when formatMessage is called directly Summary: Fix NPE in RichDiagnosticFormatter.formatMessage Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java + test/tools/javac/Diagnostics/7116676/T7116676.java Changeset: 32c50b5f70b5 Author: mcimadamore Date: 2013-06-04 11:31 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/32c50b5f70b5 8008160: Five lambda TargetType tests have @ignore Summary: Remove @ignore flags from tests that now pass Reviewed-by: jjg ! test/tools/javac/lambda/TargetType53.java ! test/tools/javac/lambda/TargetType54.java ! test/tools/javac/lambda/TargetType58.java ! test/tools/javac/lambda/TargetType59.java ! test/tools/javac/lambda/TargetType62.java Changeset: c8acc254b6d7 Author: mcimadamore Date: 2013-06-04 11:34 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/c8acc254b6d7 8015505: Spurious inference error when return type of generic method requires unchecked conversion to target Summary: Use check context compatibility during 15.12.2.8 check (only when JDK 8 inference is enabled) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/8015505/T8015505.java + test/tools/javac/generics/inference/8015505/T8015505.out ! test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java Changeset: 775a51e3276f Author: vromero Date: 2013-06-04 13:21 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/775a51e3276f 7165659: javac incorrectly sets strictfp access flag on inner-classes Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java + test/tools/javac/T7165659/InnerClassAttrMustNotHaveStrictFPFlagTest.java Changeset: 8fb68f73d4b1 Author: jjg Date: 2013-06-04 14:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/8fb68f73d4b1 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations Reviewed-by: mcimadamore, jfranck ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/lib/DPrinter.java Changeset: 29598a102f5f Author: wmdietl Date: 2013-06-04 23:15 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/29598a102f5f Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools ! .hgtags ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties ! test/tools/javac/annotations/typeAnnotations/classfile/TestNewCastArray.java Changeset: 18943a1b7a47 Author: lana Date: 2013-05-29 16:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/18943a1b7a47 Merge - test/tools/javac/HiddenAbstractMethod/Test - test/tools/javac/NonAmbiguousField/Test Changeset: 2c5a568ee36e Author: lana Date: 2013-06-03 23:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/2c5a568ee36e Merge - test/tools/javac/HiddenAbstractMethod/Test - test/tools/javac/NonAmbiguousField/Test Changeset: 9acd0f8d6e44 Author: lana Date: 2013-06-04 21:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/9acd0f8d6e44 Merge Changeset: 3832d8aaa06b Author: wmdietl Date: 2013-06-04 23:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/3832d8aaa06b Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools From wdietl at gmail.com Wed Jun 5 00:12:39 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 05 Jun 2013 07:12:39 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 43 new changesets Message-ID: <20130605071644.5C48848F6C@hg.openjdk.java.net> Changeset: ad47de214f0c Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ad47de214f0c Added tag jdk8-b91 for changeset 7cbdf0e3725c ! .hgtags Changeset: 7ec426e29e4c Author: amurillo Date: 2013-05-17 09:10 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/7ec426e29e4c 8014760: new hotspot build - hs25-b34 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f49e0508a38a Author: rbackman Date: 2013-05-15 11:30 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f49e0508a38a 4965252: JvmtiExport::post_raw_field_modification jni ref handling is odd Reviewed-by: coleenp, sspitsyn ! src/share/vm/prims/jvmtiExport.cpp Changeset: 243469d929e6 Author: ctornqvi Date: 2013-05-16 15:31 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/243469d929e6 8008169: test/runtime/7158804/Test7158804.sh has bad copyright header Summary: Re-wrote test in Java in addition to fixing the Copyright notice. Also reviewed by leonid.mesnik at oracle.com Reviewed-by: coleenp, ctornqvi Contributed-by: Mikhailo Seledtsov - test/runtime/7158804/Test7158804.sh + test/runtime/CommandLine/ConfigFileParsing.java Changeset: 17db82f22f1e Author: ctornqvi Date: 2013-05-16 17:54 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/17db82f22f1e 8014511: runtime/RedefineObject/TestRedefineObject.java has incorrect classname in @run tag Summary: Corrected the class name Reviewed-by: coleenp, ctornqvi, hseigel Contributed-by: Mikhailo Seledtsov ! test/runtime/RedefineObject/TestRedefineObject.java Changeset: 78332b46e604 Author: kevinw Date: 2013-05-16 12:40 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/78332b46e604 6313816: SA: jstack -m fails on Win32 : UnalignedAddressException Reviewed-by: sla, poonam - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgCDebugger.java + agent/src/share/classes/sun/jvm/hotspot/debugger/windows/amd64/WindowsAMD64CFrame.java + agent/src/share/classes/sun/jvm/hotspot/debugger/windows/x86/WindowsX86CFrame.java ! make/sa.files Changeset: 205dd30230e1 Author: shade Date: 2013-05-17 01:43 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/205dd30230e1 8012939: @Contended doesn't work correctly with inheritance Summary: Fix instance_size miscalculation. Reviewed-by: jrose, kvn ! src/share/vm/classfile/classFileParser.cpp + test/runtime/contended/Inheritance1.java Changeset: b334821dad92 Author: dholmes Date: 2013-05-16 21:19 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b334821dad92 Merge Changeset: 50e9396d5257 Author: shade Date: 2013-05-17 01:58 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/50e9396d5257 8014509: @Contended: explicit default value behaves differently from the implicit value Summary: Treat the empty string as the default value tag Reviewed-by: kvn, twisti ! src/share/vm/classfile/classFileParser.cpp + test/runtime/contended/DefaultValue.java Changeset: 074ba6269cf4 Author: dholmes Date: 2013-05-16 22:11 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/074ba6269cf4 Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java Changeset: 1ba508fcd3e2 Author: dholmes Date: 2013-05-16 23:40 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1ba508fcd3e2 Merge Changeset: 6ce351ac7339 Author: rdurbin Date: 2013-05-17 08:51 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/6ce351ac7339 7145527: sscanf must use a length in the format string Summary: Remove dead code containing last call to scanf with no string length specifier Reviewed-by: dcubed, coleenp ! src/share/vm/utilities/debug.cpp Changeset: a250c89cf9e3 Author: dcubed Date: 2013-05-17 08:56 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a250c89cf9e3 Merge Changeset: b5be63340698 Author: dcubed Date: 2013-05-17 11:36 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b5be63340698 Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java ! src/share/vm/classfile/classFileParser.cpp - test/runtime/7158804/Test7158804.sh Changeset: 386b77bf6427 Author: dcubed Date: 2013-05-17 17:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/386b77bf6427 Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp Changeset: a5d6f0c3585f Author: iklam Date: 2013-05-18 20:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a5d6f0c3585f 8014262: PrintStringTableStatistics should include more footprint info Summary: Added info for the string/symbol objects and the hash entries Reviewed-by: coleenp, rbackman ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/utilities/hashtable.cpp ! src/share/vm/utilities/hashtable.hpp Changeset: 5e3573e08a83 Author: shade Date: 2013-05-20 15:43 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5e3573e08a83 8014871: Move @Contended regression tests to the same place Summary: Move the missing test to appropriate location. Reviewed-by: dholmes, sla - test/runtime/8003985/Test8003985.java + test/runtime/contended/Basic.java Changeset: bbddfb08190f Author: shade Date: 2013-05-20 23:41 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/bbddfb08190f 8014878: Clean up class field layout code Summary: rename/remove local variables, re-arrange instance_size calculation, more comments. Reviewed-by: kvn, coleenp ! src/share/vm/classfile/classFileParser.cpp Changeset: 293b99787401 Author: dholmes Date: 2013-05-14 07:24 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/293b99787401 8014460: Need to check for non-empty EXT_LIBS_PATH before using it Reviewed-by: tbell, collins, sla, coleenp ! make/bsd/makefiles/arm.make ! make/linux/makefiles/arm.make Changeset: 26579ac80ce9 Author: bpittore Date: 2013-05-15 23:06 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/26579ac80ce9 8014669: arch specific flags not passed to some link commands Summary: EXTRA_CFLAGS does not propagate to saproc and jsig makefiles Reviewed-by: dholmes, tbell, collins ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make Changeset: f8c833eb2a5f Author: jiangli Date: 2013-05-20 13:13 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f8c833eb2a5f Merge Changeset: c838b672691c Author: jiangli Date: 2013-05-23 13:40 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c838b672691c Merge Changeset: 91eba9f82325 Author: anoll Date: 2013-05-16 15:46 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/91eba9f82325 8012371: Adjust Tiered compile threshold according to available space in code cache Summary: Added command line parameter to define a threshold at which C1 compilation threshold for is increased. Reviewed-by: kvn, iveresov ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: ec922e5c545a Author: anoll Date: 2013-05-22 10:28 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ec922e5c545a 8012312: hsdis fails to compile with binutils-2.23.2 Summary: added to header file to make hsdis compile with binutils 2.23.* Reviewed-by: kvn, twisti ! src/share/tools/hsdis/hsdis.c Changeset: b4907b24ed48 Author: twisti Date: 2013-05-22 11:44 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b4907b24ed48 Merge Changeset: 1682bec79205 Author: kvn Date: 2013-05-22 09:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1682bec79205 8014811: loopTransform.cpp assert(cmp_end->in(2) == limit) failed Summary: Stop current iteration of loop opts if partial_peel() failed and it created node clones outside processed loop. Reviewed-by: roland ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp Changeset: 71a2d06b9c2b Author: kvn Date: 2013-05-22 17:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/71a2d06b9c2b Merge Changeset: 3f281b313240 Author: kvn Date: 2013-05-22 18:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3f281b313240 8010927: Kitchensink crashed with SIGSEGV, Problematic frame: v ~StubRoutines::checkcast_arraycopy Summary: Changed gen_write_ref_array_post_barrier() code on x64 to pass start address and number of copied oop elements. In generate_checkcast_copy() skip post barrier code if no elements are copied. Reviewed-by: roland ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp + test/compiler/8010927/Test8010927.java Changeset: 01e51113b4f5 Author: anoll Date: 2013-05-23 14:11 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/01e51113b4f5 8014430: JRE crashes instead of stop compilation on full Code Cache. Internal Error (c1_Compiler.cpp:87) Summary: Disable client compiler and switch to interpreter if there is not enough free space in the code cache. Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_Compiler.cpp ! src/share/vm/c1/c1_Compiler.hpp Changeset: 59e18b573605 Author: twisti Date: 2013-05-23 15:30 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/59e18b573605 Merge Changeset: 001ec9515f84 Author: ehelin Date: 2013-05-17 11:57 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/001ec9515f84 8014277: Remove ObjectClosure as base class for BoolObjectClosure Reviewed-by: brutisso, tschatzl ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/runtime/jniHandles.cpp Changeset: 2138a2c14831 Author: jwilhelm Date: 2013-05-19 20:31 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2138a2c14831 Merge ! src/share/vm/gc_implementation/shared/markSweep.cpp Changeset: 10f759898d40 Author: tamao Date: 2013-05-20 10:44 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/10f759898d40 7186737: Unable to allocate bit maps or card tables for parallel gc for the requested heap Summary: Print helpful error message when VM aborts due to inability of allocating bit maps or card tables Reviewed-by: jmasa, stefank Contributed-by: tamao ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: 2b1a9d972fc2 Author: jmasa Date: 2013-05-20 22:34 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2b1a9d972fc2 8014862: Add fast Metasapce capacity and used per MetadataType Reviewed-by: ehelin, stefank ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp Changeset: 28e53b8db94f Author: brutisso Date: 2013-05-21 08:50 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/28e53b8db94f 7066063: CMS: "Conservation Principle" assert failed Summary: Add call to coalBirth() in CompactibleFreeListSpace::reset() Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp Changeset: 5ed122fbd0ef Author: brutisso Date: 2013-05-21 10:39 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5ed122fbd0ef Merge Changeset: 6702da6b6082 Author: tschatzl Date: 2013-05-21 11:30 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/6702da6b6082 8014405: G1: PerRegionTable::fl_mem_size() calculates size of the free list using wrong element sizes Summary: Instead of using a simple sizeof(), ask the PerRegionTable class about its size when iterating over the free list. Reviewed-by: jwilhelm, brutisso ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/prims/jni.cpp Changeset: 7c5a1b62f53d Author: brutisso Date: 2013-05-22 08:04 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/7c5a1b62f53d 8014971: Minor code cleanup of the freelist management Reviewed-by: jwilhelm, jmasa, tschatzl ! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp Changeset: 62890ed7e2a8 Author: jwilhelm Date: 2013-05-24 09:29 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/62890ed7e2a8 Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java - test/runtime/7158804/Test7158804.sh - test/runtime/8003985/Test8003985.java Changeset: 38da9f4f6709 Author: amurillo Date: 2013-05-24 09:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/38da9f4f6709 Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java - test/runtime/7158804/Test7158804.sh - test/runtime/8003985/Test8003985.java Changeset: 092018493d3b Author: amurillo Date: 2013-05-24 09:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/092018493d3b Added tag hs25-b34 for changeset 38da9f4f6709 ! .hgtags Changeset: 573d86d412cd Author: katleman Date: 2013-05-30 10:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/573d86d412cd Added tag jdk8-b92 for changeset 092018493d3b ! .hgtags Changeset: aeea38105bee Author: wmdietl Date: 2013-06-04 23:12 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/aeea38105bee Automated merge with http://hg.openjdk.java.net/jdk8/tl/hotspot ! .hgtags From wdietl at gmail.com Wed Jun 5 00:08:26 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 05 Jun 2013 07:08:26 +0000 Subject: hg: type-annotations/type-annotations/jdk: 55 new changesets Message-ID: <20130605073347.6194448F6F@hg.openjdk.java.net> Changeset: 11cdcf87ad5d Author: jzavgren Date: 2013-05-31 15:23 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/11cdcf87ad5d 8008972: Memory leak: Java_java_net_TwoStacksPlainDatagramSocketImpl_receive0 [parfait] Summary: Modified the code so that "jumbo frames" are truncated before buffer allocation is considered. This makes the buffer length a reliable indication that a buffer has been allocated, and it can then be used during clean up. Reviewed-by: chegar, khazra, alanb Contributed-by: john.zavgren at oracle.com ! src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c Changeset: f6e6c27c19f3 Author: jzavgren Date: 2013-05-31 15:18 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f6e6c27c19f3 7188517: Check on '$' character is missing in the HttpCookie class constructor Summary: Modified the constructor code so that the cookie names are examined for leading dollar signs and if they do, an illegal argument exception is thrown. Reviewed-by: chegar, khazra, michaelm Contributed-by: john.zavgren at oracle.com ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/TestHttpCookie.java Changeset: fc0b3e86fdcf Author: mduigou Date: 2013-05-31 11:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fc0b3e86fdcf 8015686: {Int|Long}SummaryStatistics toString() throws IllegalFormatConversionException Reviewed-by: dholmes, alanb, psandoz ! src/share/classes/java/util/IntSummaryStatistics.java ! src/share/classes/java/util/LongSummaryStatistics.java Changeset: 198de8103df2 Author: mduigou Date: 2013-05-31 17:31 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/198de8103df2 Merge Changeset: c8410ce73ad6 Author: mduigou Date: 2013-02-12 17:04 -0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c8410ce73ad6 8007398: Peformance improvements to Integer and Long string formatting. Reviewed-by: mduigou, martin, darcy, briangoetz Contributed-by: Steven Schlansker , Mike Duigou ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java + test/java/lang/IntegralPrimitiveToString.java Changeset: f3c7c5f753dc Author: psandoz Date: 2013-06-03 10:28 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f3c7c5f753dc 8015008: Primitive iterator over empty sequence, null consumer: forEachRemaining methods do not throw NPE Reviewed-by: chegar ! src/share/classes/java/util/PrimitiveIterator.java + test/java/util/Iterator/PrimitiveIteratorDefaults.java Changeset: 44ef47f3efed Author: psandoz Date: 2013-06-03 10:45 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/44ef47f3efed 8014731: j.u.stream.StreamSupport class has default constructor generated Summary: This change set also fixes broken links Reviewed-by: alanb, chegar Contributed-by: Paul Sandoz , Henry Jen ! src/share/classes/java/util/stream/StreamSupport.java Changeset: 33d1376bf725 Author: nloodin Date: 2013-06-03 16:13 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/33d1376bf725 6526682: JConsole shows negative CPU Usage Reviewed-by: alanb, mchung ! src/share/classes/sun/tools/jconsole/SummaryTab.java Changeset: 3d4d7ed93731 Author: emc Date: 2013-06-03 10:44 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3d4d7ed93731 8014834: shell tests don't begin with #!/bin/sh Summary: Some shell tests don't begin with the command interpreter line Reviewed-by: alanb, ksrini ! test/java/util/Locale/LocaleCategory.sh ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/Locale/data/deflocale.sh ! test/java/util/PluggableLocale/BreakIteratorProviderTest.sh ! test/java/util/PluggableLocale/CalendarDataProviderTest.sh ! test/java/util/PluggableLocale/ClasspathTest.sh ! test/java/util/PluggableLocale/CollatorProviderTest.sh ! test/java/util/PluggableLocale/CurrencyNameProviderTest.sh ! test/java/util/PluggableLocale/DateFormatProviderTest.sh ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.sh ! test/java/util/PluggableLocale/DecimalFormatSymbolsProviderTest.sh ! test/java/util/PluggableLocale/ExecTest.sh ! test/java/util/PluggableLocale/GenericTest.sh ! test/java/util/PluggableLocale/LocaleNameProviderTest.sh ! test/java/util/PluggableLocale/NumberFormatProviderTest.sh ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.sh ! test/java/util/ResourceBundle/Bug6299235Test.sh ! test/sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.sh ! test/sun/rmi/rmic/manifestClassPath/run.sh ! test/sun/rmi/rmic/newrmic/equivalence/batch.sh ! test/tools/launcher/MultipleJRE.sh Changeset: a79e2683eae3 Author: psandoz Date: 2013-06-03 17:37 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a79e2683eae3 8014383: StringJoiner example in class description not in sync with streams API Reviewed-by: alanb ! src/share/classes/java/util/StringJoiner.java Changeset: 62d3c82b4509 Author: shade Date: 2013-06-03 22:09 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/62d3c82b4509 8014966: Add the proper Javadoc to @Contended Summary: more extensive description. Reviewed-by: dholmes, mduigou, martin ! src/share/classes/sun/misc/Contended.java Changeset: f4e2a70260cf Author: ksrini Date: 2013-06-03 13:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f4e2a70260cf 8015813: add test/tools/pack200/TimeStamp.java to ProblemsList Reviewed-by: sherman ! test/ProblemList.txt Changeset: 2868607646a0 Author: erikj Date: 2013-05-21 17:02 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2868607646a0 8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist Reviewed-by: dholmes, tbell, naoto ! makefiles/GensrcSwing.gmk Changeset: b61632814be2 Author: katleman Date: 2013-05-21 12:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b61632814be2 Merge Changeset: f559fadbf491 Author: andrew Date: 2013-05-22 13:48 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f559fadbf491 8015087: Provide debugging information for programs Summary: Add missing debug info to unpack200 and jexec Reviewed-by: erikj ! makefiles/CompileLaunchers.gmk Changeset: 88d6a20672ac Author: erikj Date: 2013-05-22 10:31 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/88d6a20672ac 8014970: Use open man pages for non commercial builds Reviewed-by: omajid, tbell ! makefiles/Images.gmk Changeset: 169451cf0cc5 Author: erikj Date: 2013-05-22 15:00 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/169451cf0cc5 Merge Changeset: fbd926b20201 Author: katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fbd926b20201 Added tag jdk8-b91 for changeset 169451cf0cc5 ! .hgtags Changeset: a2a2a91075ad Author: katleman Date: 2013-05-29 10:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a2a2a91075ad 8015525: JDK8 b91 source with GPL header errors Reviewed-by: dholmes, lancea ! test/java/util/stream/test/org/openjdk/tests/java/util/FillableStringTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/MapTest.java ! test/jdk/lambda/MethodReferenceTestInstanceMethod.java ! test/jdk/lambda/MethodReferenceTestKinds.java ! test/jdk/lambda/MethodReferenceTestSueCase1.java ! test/jdk/lambda/MethodReferenceTestSueCase2.java ! test/jdk/lambda/MethodReferenceTestSueCase4.java ! test/jdk/lambda/separate/AttributeInjector.java ! test/jdk/lambda/separate/ClassFile.java ! test/jdk/lambda/separate/ClassFilePreprocessor.java ! test/jdk/lambda/separate/ClassToInterfaceConverter.java ! test/jdk/lambda/separate/Compiler.java ! test/jdk/lambda/separate/DirectedClassLoader.java ! test/jdk/lambda/separate/SourceModel.java ! test/jdk/lambda/separate/TestHarness.java ! test/jdk/lambda/vm/DefaultMethodRegressionTests.java ! test/jdk/lambda/vm/DefaultMethodsTest.java ! test/jdk/lambda/vm/InterfaceAccessFlagsTest.java Changeset: 3c08c9ebd1fb Author: katleman Date: 2013-05-30 10:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3c08c9ebd1fb Added tag jdk8-b92 for changeset a2a2a91075ad ! .hgtags Changeset: 1fd682e7110b Author: lana Date: 2013-06-03 16:09 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1fd682e7110b Merge Changeset: 25cf25fb8c68 Author: sla Date: 2013-06-04 09:45 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/25cf25fb8c68 8015856: Remove java/lang/instrument/IsModifiableClassAgent.java from ProblemList.txt Reviewed-by: dholmes ! test/ProblemList.txt Changeset: 5223d3228658 Author: bchristi Date: 2013-06-04 10:04 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5223d3228658 8005698: Handle Frequent HashMap Collisions with Balanced Trees Summary: HashMap bins with many collisions store entries in balanced trees Reviewed-by: alanb, dl, mduigou ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/LinkedHashMap.java ! src/share/classes/java/util/WeakHashMap.java ! src/share/classes/sun/misc/Hashing.java + test/java/util/Map/CheckRandomHashSeed.java ! test/java/util/Map/Collisions.java + test/java/util/Map/InPlaceOpsCollisions.java + test/java/util/Map/TreeBinSplitBackToEntries.java + test/java/util/Spliterator/SpliteratorCollisions.java Changeset: fad4ef2123ca Author: psandoz Date: 2013-06-04 11:53 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fad4ef2123ca 8015790: Remove duplicate spliterator tests Reviewed-by: alanb, mduigou - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java Changeset: f8b071428ca5 Author: michaelm Date: 2013-06-04 10:56 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f8b071428ca5 8014723: sun/misc/URLClassPath/ClassnameCharTest.java failing Reviewed-by: alanb, chegar ! src/share/classes/java/net/HttpURLPermission.java ! test/ProblemList.txt Changeset: 780fbbd50ce4 Author: alanb Date: 2013-06-04 11:52 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/780fbbd50ce4 8015872: ProblemList.txt updates (6/2013) Reviewed-by: chegar ! test/ProblemList.txt Changeset: 25a8e6fd0210 Author: alanb Date: 2013-06-04 15:18 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/25a8e6fd0210 8014855: TEST_BUG: java/nio/file/Files/StreamTest.java fails when sym links not supported Reviewed-by: alanb Contributed-by: henry.jen at oracle.com ! test/java/nio/file/Files/StreamTest.java Changeset: 379e1bcae693 Author: naoto Date: 2013-06-04 10:33 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/379e1bcae693 8013903: Japanese calendar field names are not displayed with -Djava.locale.providers=HOST on Windows Reviewed-by: okutsu ! src/share/classes/java/util/spi/LocaleServiceProvider.java ! src/share/classes/sun/util/locale/provider/FallbackLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleServiceProviderPool.java ! src/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: d6401129327e Author: dl Date: 2013-06-04 21:59 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d6401129327e 8005704: Update ConcurrentHashMap to v8 Reviewed-by: chegar, mduigou ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: bd84bad9ee99 Author: jdn Date: 2013-06-04 15:33 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bd84bad9ee99 8014097: add doPrivileged methods with limited privilege scope Reviewed-by: mchung ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/AccessController.java + test/java/security/AccessController/LimitedDoPrivileged.java Changeset: c8855eb0b300 Author: wmdietl Date: 2013-06-04 22:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c8855eb0b300 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk ! .hgtags Changeset: 93de1ab38793 Author: jchen Date: 2013-05-17 10:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/93de1ab38793 8003444: Fix potential NULL pointer dereference Reviewed-by: jgodinez, prr ! src/share/native/sun/java2d/cmm/lcms/cmscgats.c ! src/share/native/sun/java2d/cmm/lcms/cmslut.c Changeset: 0cec8dc2bcf8 Author: lana Date: 2013-05-22 19:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0cec8dc2bcf8 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/lang/Thread/StackTraces.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java - test/java/util/logging/bundlesearch/LoadItUp.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 0208f5f12dc3 Author: jchen Date: 2013-05-23 12:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0208f5f12dc3 8012629: java.lang.UnsatisfiedLinkError exception throw by getAllFonts() on MacOSX Reviewed-by: bae, prr ! make/sun/awt/FILES_c_unix.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/mawt.gmk ! makefiles/CompileNativeLibraries.gmk ! src/macosx/native/sun/font/AWTFont.m Changeset: f24f9038e050 Author: prr Date: 2013-05-24 09:31 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f24f9038e050 8008535: JDK7 Printing : CJK and Latin Text in a string overlap Reviewed-by: bae, jgodinez ! src/windows/classes/sun/awt/windows/WPathGraphics.java + test/java/awt/print/PrinterJob/PrintLatinCJKTest.java Changeset: f4ad2fa22474 Author: jgodinez Date: 2013-05-29 09:18 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f4ad2fa22474 7183520: [macosx]Unable to print out the defined page for 2D_PrintingTiger/JTablePrintPageRangesTest. Reviewed-by: bae, prr ! src/macosx/classes/sun/lwawt/macosx/CPrinterJob.java Changeset: 7e2a887a069e Author: jgodinez Date: 2013-05-29 09:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7e2a887a069e 8012381: [macosx]Unable to print out the defined page for 2D_PrintingTiger/JTablePrintPageRangesTest Reviewed-by: jchen, prr ! src/solaris/classes/sun/print/IPPPrintService.java ! test/java/awt/print/PrinterJob/Collate2DPrintingTest.java Changeset: 8ac29ee867fd Author: lana Date: 2013-05-29 16:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8ac29ee867fd Merge Changeset: 85df65495177 Author: mcherkas Date: 2013-05-21 03:20 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/85df65495177 7011777: JDK 6 parses html text with script tags within comments differently from previous releases Reviewed-by: alexsch Contributed-by: Dmitry Markov ! src/share/classes/javax/swing/text/html/parser/Parser.java + test/javax/swing/text/html/parser/Parser/7011777/bug7011777.java Changeset: e36d0b9ed018 Author: alitvinov Date: 2013-05-21 05:02 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e36d0b9ed018 8005607: Recursion in J2DXErrHandler() Causes a Stack Overflow on Linux Reviewed-by: art, anthony, prr ! src/solaris/classes/sun/awt/X11/MotifDnDConstants.java ! src/solaris/classes/sun/awt/X11/MotifDnDDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/WindowPropertyGetter.java ! src/solaris/classes/sun/awt/X11/XConstants.java ! src/solaris/classes/sun/awt/X11/XDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDnDDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XErrorHandler.java + src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java ! src/solaris/classes/sun/awt/X11/XQueryTree.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTranslateCoordinates.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XlibUtil.java ! src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_GraphicsEnv.h ! src/solaris/native/sun/awt/awt_util.c ! src/solaris/native/sun/awt/awt_util.h ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: 73d3bed5f8c8 Author: lana Date: 2013-05-22 17:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/73d3bed5f8c8 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/lang/Thread/StackTraces.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java - test/java/util/logging/bundlesearch/LoadItUp.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: 6261e94e9869 Author: alexsch Date: 2013-05-23 15:52 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6261e94e9869 8014924: JToolTip#setTipText() sometimes (very often) not repaints component. Reviewed-by: serb ! src/share/classes/javax/swing/JToolTip.java Changeset: e8cacde33d27 Author: ant Date: 2013-05-24 18:01 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e8cacde33d27 8013437: Test sun/awt/datatransfer/SuplementaryCharactersTransferTest.java fails to compile since 8b86 Reviewed-by: alexsch ! test/sun/awt/datatransfer/SuplementaryCharactersTransferTest.java Changeset: 6b29c27d0807 Author: malenkov Date: 2013-05-24 19:41 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6b29c27d0807 8013416: Java Bean Persistence with XMLEncoder Reviewed-by: alexsch ! src/share/classes/com/sun/beans/finder/AbstractFinder.java ! src/share/classes/com/sun/beans/finder/ConstructorFinder.java ! src/share/classes/com/sun/beans/finder/MethodFinder.java + test/java/beans/XMLEncoder/Test8013416.java Changeset: c36626831f07 Author: vkarnauk Date: 2013-05-27 12:47 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c36626831f07 8010721: [macosx] In JDK7 the menu bar disappears when a Dialog is shown Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 70ac1bf74865 Author: serb Date: 2013-05-27 22:31 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/70ac1bf74865 8014726: TEST_BUG: java/awt/WMSpecificTests/Metacity/FullscreenDialogModality.java should be modified Reviewed-by: serb, anthony Contributed-by: alexander.zvegintsev at oracle.com ! test/java/awt/WMSpecificTests/Metacity/FullscreenDialogModality.java Changeset: ff1c2e379f27 Author: pchelko Date: 2013-05-28 12:37 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ff1c2e379f27 8000422: [macosx] Views keep scrolling back to the drag position after DnD Reviewed-by: serb, anthony ! src/macosx/classes/sun/lwawt/macosx/CDropTargetContextPeer.java Changeset: 4f24a4f65a07 Author: anthony Date: 2013-05-28 16:38 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4f24a4f65a07 7039616: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java should be updated Summary: Consider the test passed if the system does not support translucency Reviewed-by: art ! test/java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java Changeset: 1f0628078531 Author: pchelko Date: 2013-05-29 12:10 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1f0628078531 8009911: [macosx] SWT app freeze when going full screen using Java 7 on Mac Reviewed-by: anthony, ksrini ! src/macosx/bin/java_md_macosx.c Changeset: c8a0abc1fd2d Author: mcherkas Date: 2013-05-29 18:40 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c8a0abc1fd2d 8014863: Line break calculations in Java 7 are incorrect. Reviewed-by: alexp, alexsch Contributed-by: Dmitry Markov ! src/share/classes/javax/swing/text/View.java + test/javax/swing/text/View/8014863/bug8014863.java Changeset: aae7b96a350e Author: lana Date: 2013-05-29 16:56 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/aae7b96a350e Merge Changeset: 5d9273a5a84e Author: lana Date: 2013-05-29 16:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5d9273a5a84e Merge - test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh Changeset: 7eae7c89dab4 Author: lana Date: 2013-06-03 23:23 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7eae7c89dab4 Merge - test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh Changeset: bb71021af586 Author: lana Date: 2013-06-04 21:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bb71021af586 Merge Changeset: 157b9c55f0a1 Author: wmdietl Date: 2013-06-04 23:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/157b9c55f0a1 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk From wdietl at gmail.com Wed Jun 5 18:37:45 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 06 Jun 2013 01:37:45 +0000 Subject: hg: type-annotations/type-annotations/jdk: 8 new changesets Message-ID: <20130606014105.B4F4948FDA@hg.openjdk.java.net> Changeset: 8a9f897a57d6 Author: alanb Date: 2013-06-05 11:12 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8a9f897a57d6 8003895: java/nio/channels/AsynchronousChannelGroup/Unbounded.java failing again [win64] Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/AsynchronousChannelGroup/Unbounded.java Changeset: de11b20f8c01 Author: psandoz Date: 2013-05-31 10:53 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/de11b20f8c01 8013649: HashMap spliterator tryAdvance() encounters remaining elements after forEachRemaining() Reviewed-by: chegar ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/WeakHashMap.java ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java Changeset: ae700bdb68b6 Author: alanb Date: 2013-06-05 13:57 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ae700bdb68b6 8015880: GenerateBreakIteratorData build warning Reviewed-by: peytoia ! make/tools/src/build/tools/generatebreakiteratordata/CharSet.java Changeset: df1b35c7901d Author: dsamersoff Date: 2013-06-05 18:20 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/df1b35c7901d 8015604: JDP packets containing ideographic characters are broken Summary: Code uses string length rather than byte array length and non ascii entry brakes packet. Reviewed-by: dholmes, jbachorik, sla ! src/share/classes/sun/management/jdp/JdpPacketWriter.java ! test/sun/management/jdp/JdpUnitTest.java Changeset: 5edcc8ca4146 Author: chegar Date: 2013-06-05 16:06 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5edcc8ca4146 8011719: Properties.loadFromXML fails with a chunked HTTP connection Reviewed-by: michaelm ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/HttpStreams.java Changeset: c1af6b5a979a Author: chegar Date: 2013-06-05 16:23 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c1af6b5a979a 8015963: Add at since tags to new ConcurrentHashMap methods Reviewed-by: shade, martin ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: e857b2a3ecee Author: fparain Date: 2013-06-05 08:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e857b2a3ecee 7150256: Add back Diagnostic Command JMX API Reviewed-by: mchung, jbachorik ! make/java/management/Exportedfiles.gmk ! make/java/management/FILES_c.gmk ! make/java/management/mapfile-vers ! makefiles/mapfiles/libmanagement/mapfile-vers + src/share/classes/com/sun/management/DiagnosticCommandMBean.java ! src/share/classes/java/lang/management/ManagementFactory.java + src/share/classes/sun/management/DiagnosticCommandArgumentInfo.java + src/share/classes/sun/management/DiagnosticCommandImpl.java + src/share/classes/sun/management/DiagnosticCommandInfo.java ! src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/management/VMManagement.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/javavm/export/jmm.h + src/share/native/sun/management/DiagnosticCommandImpl.c ! src/share/native/sun/management/VMManagementImpl.c + test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java + test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java + test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java + test/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java ! test/java/lang/management/MXBean/MXBeanBehavior.java ! test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java Changeset: 7c4610e4f118 Author: wmdietl Date: 2013-06-05 18:23 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7c4610e4f118 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk From wdietl at gmail.com Wed Jun 5 18:41:11 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 06 Jun 2013 01:41:11 +0000 Subject: hg: type-annotations/type-annotations/langtools: 2 new changesets Message-ID: <20130606014136.25BB648FDB@hg.openjdk.java.net> Changeset: 79fd9cfa55f2 Author: kizune Date: 2013-06-05 16:58 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/79fd9cfa55f2 7186887: Test T6567415.java can fail on a slow machine Reviewed-by: jjg, ksrini ! test/tools/javac/6567415/T6567415.java Changeset: babcb9c8ce01 Author: wmdietl Date: 2013-06-05 18:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/babcb9c8ce01 Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools From wdietl at gmail.com Wed Jun 5 18:44:49 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 06 Jun 2013 01:44:49 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 22 new changesets Message-ID: <20130606014522.3F33148FDC@hg.openjdk.java.net> Changeset: 66b2fde90c9d Author: jlaskey Date: 2013-05-29 16:23 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/66b2fde90c9d 8015636: Add more typed arrays code coverage tests. Reviewed-by: sundar Contributed-by: james.laskey at oracle.com + test/script/basic/typedarrays.js Changeset: eda227663eda Author: sundar Date: 2013-05-30 16:49 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/eda227663eda 8015353: Date.parse illegal string parsing issues Reviewed-by: jlaskey, lagergren - src/jdk/nashorn/internal/objects/DateParser.java ! src/jdk/nashorn/internal/objects/NativeDate.java + src/jdk/nashorn/internal/parser/DateParser.java + test/script/basic/JDK-8015353.js Changeset: 818946884410 Author: attila Date: 2013-05-31 12:56 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/818946884410 8015693: reduce NodeLiteralNode to NullLiteralNode Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/ir/LiteralNode.java Changeset: d8a7727a519e Author: attila Date: 2013-05-31 12:57 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d8a7727a519e 8015684: FieldObjectCreator.putField ignores getValueType Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java Changeset: cab639125b98 Author: attila Date: 2013-05-31 12:57 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/cab639125b98 8015674: CodeGenerator.initSymbols mutates a list Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java Changeset: 11b81fa7125a Author: attila Date: 2013-05-31 12:58 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/11b81fa7125a 8015673: Type for :e symbol is wrong Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java Changeset: b4e6cc05ce09 Author: sundar Date: 2013-05-31 17:39 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/b4e6cc05ce09 8012164: Error.stack needs trimming Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/NativeError.java + test/script/basic/JDK-8012164.js + test/script/basic/JDK-8012164.js.EXPECTED ! test/script/basic/NASHORN-108.js.EXPECTED ! test/script/basic/NASHORN-109.js.EXPECTED ! test/script/basic/errorstack.js.EXPECTED Changeset: 64250b3a2f2a Author: jlaskey Date: 2013-05-31 13:04 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/64250b3a2f2a 8015727: Thread safe print function Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/Global.java Changeset: 295c91f5fdde Author: sundar Date: 2013-06-03 15:58 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/295c91f5fdde 8015345: Function("}),print('test'),({") should throw SyntaxError Reviewed-by: lagergren, hannesw, jlaskey ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8015345.js + test/script/basic/JDK-8015345.js.EXPECTED ! test/script/basic/funcconstructor.js.EXPECTED Changeset: 08a8fda6c0bf Author: jlaskey Date: 2013-06-03 08:34 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/08a8fda6c0bf 8015741: Need a global.load function that starts with a new global scope. Reviewed-by: sundar, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java + test/script/basic/JDK-8015741.js + test/script/basic/JDK-8015741.js.EXPECTED Changeset: 2df08f4c531d Author: jlaskey Date: 2013-06-03 11:16 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/2df08f4c531d 8015796: Race condition in RuntimeCallsites Reviewed-by: lagergren, attila Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java Changeset: 0946c8a60f39 Author: jlaskey Date: 2013-06-03 12:57 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/0946c8a60f39 8015814: loadWithNewGlobal needs to wrap createGlobal in AccessController.doPrivileged Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/Context.java Changeset: 78113cda23bf Author: sundar Date: 2013-06-04 17:33 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/78113cda23bf 8015855: test/script/basic/JDK-8012164.js fails on Windows Reviewed-by: hannesw, lagergren, jlaskey ! test/script/basic/JDK-8012164.js Changeset: c70f60578385 Author: sundar Date: 2013-06-04 22:31 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/c70f60578385 8015830: Javascript mapping of ScriptEngine bindings does not expose keys Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java + test/script/basic/JDK-8015830.js + test/script/basic/JDK-8015830.js.EXPECTED Changeset: 62b096f7bac3 Author: sundar Date: 2013-06-05 12:08 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/62b096f7bac3 8015945: loadWithNewGlobal return value has to be properly wrapped Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/Context.java + test/script/basic/JDK-8015945.js + test/script/basic/JDK-8015945.js.EXPECTED Changeset: c6c05f23bca4 Author: sundar Date: 2013-06-05 13:33 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/c6c05f23bca4 Merge - src/jdk/nashorn/internal/objects/DateParser.java Changeset: 0feca8a93cb3 Author: attila Date: 2013-06-05 10:44 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/0feca8a93cb3 8015955: ObjectNode.elements should be stronger typed Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java Changeset: 9374c04f38fe Author: attila Date: 2013-06-05 12:17 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/9374c04f38fe 8015961: Several small code-gardening fixes Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/RuntimeCallSite.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/NativeMath.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Parser.java Changeset: 60bc560df392 Author: hannesw Date: 2013-06-05 12:44 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/60bc560df392 8015350: Array.prototype.reduceRight issue with large length and index Reviewed-by: attila, sundar, lagergren ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/EmptyArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java ! src/jdk/nashorn/internal/runtime/arrays/MapIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ReverseArrayIterator.java ! src/jdk/nashorn/internal/runtime/arrays/ReverseMapIterator.java + test/script/basic/JDK-8015350.js + test/script/basic/JDK-8015350.js.EXPECTED Changeset: 35bba63990b7 Author: jlaskey Date: 2013-06-05 10:32 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/35bba63990b7 8015911: $EXEC does not handle large outputs Reviewed-by: sundar, attila Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java Changeset: 16219bef66ec Author: jlaskey Date: 2013-06-05 12:41 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/16219bef66ec 8015910: Nashorn JavaFX includes are out of sync with JavaFX repo Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/controls.js ! src/jdk/nashorn/internal/runtime/resources/fx/graphics.js ! src/jdk/nashorn/internal/runtime/resources/fx/swt.js ! src/jdk/nashorn/internal/runtime/resources/fx/web.js Changeset: e3bd0ed64da8 Author: jlaskey Date: 2013-06-05 12:54 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/e3bd0ed64da8 Merge From steve.sides at oracle.com Thu Jun 6 10:20:19 2013 From: steve.sides at oracle.com (Steve Sides) Date: Thu, 06 Jun 2013 10:20:19 -0700 Subject: test for inner and anon class In-Reply-To: References: <519EBA74.1020101@oracle.com> <519EBCC3.6060207@oracle.com> <519FD227.4020900@oracle.com> Message-ID: <51B0C4D3.7060305@oracle.com> Back from vacation....sorry about the internal link. :/ On openjdk, it's just at: http://cr.openjdk.java.net/~ssides/8015323/ -steve On 6/4/2013 11:55 PM, Werner Dietl wrote: > Hi Steve, Jon, > > that URL doesn't work for me from outside Oracle, so I was expecting > somebody on the inside to push it. > I tried > http://cr.openjdk.java.net/~ssides/8015323.1/webrev.01/ > but there doesn't seem to be a mapping there. > > cu, WMD. > > On Fri, May 24, 2013 at 1:48 PM, Steve Sides wrote: >> On 5/23/2013 6:05 PM, Jonathan Gibbons wrote: >>> On 05/23/2013 05:55 PM, Steve Sides wrote: >>>> Hi Werner, >>>> I updated the test I had for Inner and anonymous classes. It has been >>>> blocked by a few bugs (listed @bug) which are now fixed. >>>> However, as I started enabling the tests I ran in to a couple more. The >>>> test is here, >>>> http://cr.openjdk.java.net/~ssides/8015323/ >>>> but it will fail due to these two >>>> >>>> 8015323 If class InnerAnnon is instantiated, type annotations on ia_m1() >>>> are incorrectly written to classfile. >>>> >>>> 8015257 A type annotation with ElementTypes TYPE_USE and FIELD placed on >>>> type >>>> argument is placed on the ctor if repeated and on the field if not >>>> repeated. >>>> >>>> There is currently an @ignore on the test as I wasn't sure which repo >>>> this might want to go into, and if in tl/langtools it should have the >>>> ignore. >>>> The affect parts of the test are noted in the generated test sources(if >>>> you comment out all the next lines, it'll pass). >>>> >>>> The 8015323 scenario used to crash, not they're written incorrectly. >>>> 8015727 used to not write to classfile at all if repeated, not it just >>>> writes incorrectly. >>>> >>>> The test case is a little clunky looking, but it found several bugs and I >>>> found it runs faster and is very easy to diagnose and narrow down a test >>>> case. >>>> >>>> -steve >>>> >>>> >>> Steve, >>> >>> Nice test. >>> >>> I don't know if it would ease maintenance, but one suggestion might be to >>> move the testsource string into a separate file, called something like >>> testsource.template, and then read it into a String use java.nio.file.Files >>> API. I know normally we keep the template within the main source file, but >>> this template is getting pretty long. Anyway, just a suggestion, for your >>> ease-of-use. Your call. >>> >>> -- Jon >> I put the source in a template file. I created a new webrev for it since >> it's not checked in anywhere yet. >> http://sqeweb.us.oracle.com/coretools/ssides/webrevs/8015323.1/webrev.01/ >> As is, it does not have @ignore and it fails with the buggy lines having >> comments above them in the template. >> >> -steve > > From wdietl at gmail.com Thu Jun 6 14:04:56 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 06 Jun 2013 21:04:56 +0000 Subject: hg: type-annotations/type-annotations/jdk: 7 new changesets Message-ID: <20130606210823.6732B48023@hg.openjdk.java.net> Changeset: 571e5f452640 Author: dholmes Date: 2013-06-06 05:32 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/571e5f452640 8015470: Remove redundant calls of toString() on String objects Reviewed-by: dholmes, alanb Contributed-by: Otavio Goncalves ! src/share/classes/com/sun/jndi/toolkit/dir/SearchFilter.java ! src/share/classes/java/lang/annotation/IncompleteAnnotationException.java ! src/share/classes/sun/rmi/rmic/Main.java ! src/share/classes/sun/tools/java/MemberDefinition.java ! src/share/classes/sun/tools/jconsole/inspector/Utils.java Changeset: c4480e0d9f53 Author: coffeys Date: 2013-06-06 14:10 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c4480e0d9f53 8000450: Restrict access to com/sun/corba/se/impl package Reviewed-by: alanb, chegar, lancea ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/java/lang/SecurityManager/CheckPackageAccess.java Changeset: 37aa82c52317 Author: emc Date: 2013-06-06 09:51 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/37aa82c52317 8016019: Remove setProtectionDomain0 and JVM_SetProtectionDomain in JDK Summary: setProtectionDomain0 and JVM_SetProtectionDomain are unused since at least 1.5. This is the JDK side of a changeset to remove it. Reviewed-by: alanb ! src/share/classes/java/lang/Class.java ! src/share/javavm/export/jvm.h ! src/share/native/java/lang/Class.c Changeset: e6d2c605930c Author: dmeetry Date: 2013-06-06 20:43 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e6d2c605930c 8009579: Xpathexception does not honor initcause() Reviewed-by: alanb, dholmes, joehw Contributed-by: aleksej.efimov at oracle.com + test/javax/xml/jaxp/XPath/8009579/XPathExceptionInitCause.java Changeset: 69d566198fe4 Author: henryjen Date: 2013-06-05 15:56 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/69d566198fe4 8015522: CharSequence.codePoints can be faster Reviewed-by: martin, psandoz, alanb Contributed-by: henry.jen at oracle.com ! src/share/classes/java/lang/CharSequence.java Changeset: 26922bad9c08 Author: mduigou Date: 2013-06-06 11:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/26922bad9c08 Merge Changeset: b689638cdfee Author: wmdietl Date: 2013-06-06 14:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b689638cdfee Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk ! src/share/classes/java/lang/Class.java From wdietl at gmail.com Thu Jun 6 14:15:09 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 06 Jun 2013 21:15:09 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 6 new changesets Message-ID: <20130606211540.7E98048026@hg.openjdk.java.net> Changeset: 627c265d6e0c Author: lana Date: 2013-05-29 16:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/627c265d6e0c Merge - src/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/com/sun/org/apache/xml/internal/serialize/ObjectFactory.java Changeset: d583a491d63c Author: lana Date: 2013-06-03 23:19 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/d583a491d63c Merge - src/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/com/sun/org/apache/xml/internal/serialize/ObjectFactory.java Changeset: e996ea806630 Author: lana Date: 2013-06-04 21:33 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/e996ea806630 Merge Changeset: 7d14fea1e893 Author: dmeetry Date: 2013-06-06 20:40 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/7d14fea1e893 8009579: Xpathexception does not honor initcause() Reviewed-by: alanb, dholmes, joehw Contributed-by: aleksej.efimov at oracle.com ! src/javax/xml/xpath/XPathException.java Changeset: e93beba07830 Author: dfuchs Date: 2013-06-06 20:47 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/e93beba07830 8013434: Xalan and Xerces internal ObjectFactory need rework Summary: With this changeset, DTMManager and XSLTCDTMManager will always use their own default implementation. Reviewed-by: joehw, alanb - src/com/sun/org/apache/xalan/META-INF/services/javax.xml.transform.TransformerFactory - src/com/sun/org/apache/xalan/META-INF/services/javax.xml.xpath.XPathFactory - src/com/sun/org/apache/xalan/META-INF/services/org.apache.xml.dtm.DTMManager ! src/com/sun/org/apache/xalan/internal/utils/ObjectFactory.java ! src/com/sun/org/apache/xalan/internal/xsltc/cmdline/Transform.java ! src/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java ! src/com/sun/org/apache/xalan/internal/xsltc/dom/XSLTCDTMManager.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerHandlerImpl.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java ! src/com/sun/org/apache/xerces/internal/utils/ObjectFactory.java ! src/com/sun/org/apache/xml/internal/dtm/DTMManager.java ! src/com/sun/org/apache/xpath/internal/XPathContext.java Changeset: caa37098f094 Author: wmdietl Date: 2013-06-06 14:15 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/caa37098f094 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxp From wdietl at gmail.com Thu Jun 6 14:12:57 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 06 Jun 2013 21:12:57 +0000 Subject: hg: type-annotations/type-annotations/langtools: 8 new changesets Message-ID: <20130606211338.7494248024@hg.openjdk.java.net> Changeset: 8717586f7b05 Author: emc Date: 2013-06-06 08:48 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/8717586f7b05 8015701: MethodParameters are not filled in for synthetic captured local variables Summary: Synthetic parameters for captured local variables in an anonymous inner class are not added to MethodParameters attributes Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/8015701/AnonymousParameters.java Changeset: 6e30a513c945 Author: mcimadamore Date: 2013-06-06 15:30 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/6e30a513c945 6360970: javac erroneously accept ambiguous field reference Summary: clash between ambiguous fields in superinterface and unambiguous field in subinterface is erroneously marked as unambiguous Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/6360970/T6360970.java + test/tools/javac/6360970/T6360970.out Changeset: 7889d1fe2597 Author: mcimadamore Date: 2013-06-06 15:32 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/7889d1fe2597 7139681: Enhanced for loop: local variable scope inconsistent with JLS Summary: For-each loop variable is incorrectly visible from the for-each expression Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/foreach/7139681/T7139681neg.java + test/tools/javac/foreach/7139681/T7139681neg.out + test/tools/javac/foreach/7139681/T7139681pos.java Changeset: 349160289ba2 Author: mcimadamore Date: 2013-06-06 15:33 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/349160289ba2 8008627: Compiler mishandles three-way return-type-substitutability Summary: Compiler should not enforce an order in how ambiguous methods should be resolved Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/rawOverride/T8008627.java ! test/tools/javac/lambda/funcInterfaces/NonSAM2.java ! test/tools/javac/lambda/funcInterfaces/NonSAM2.out Changeset: f8472e561a97 Author: mcimadamore Date: 2013-06-06 15:35 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/f8472e561a97 8015432: javac crashes with stack overflow when method called recursively from nested generic call Summary: Check.checkMethod should only be called after inference has completed Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/generics/7015430/T7015430.out ! test/tools/javac/generics/7151802/T7151802.out ! test/tools/javac/generics/inference/6718364/T6718364.out ! test/tools/javac/generics/inference/7177306/T7177306a.out + test/tools/javac/lambda/TargetType74.java Changeset: f218bb5ebd53 Author: mcimadamore Date: 2013-06-06 15:37 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/f218bb5ebd53 8015648: Duplicate variable in lambda causes javac crash Summary: Missing flag in synthetic lambda blog is causing duplicates symbol to go undetected Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/LambdaScope05.java + test/tools/javac/lambda/LambdaScope05.out Changeset: 5b039297151e Author: mcimadamore Date: 2013-06-06 15:38 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/5b039297151e Merge Changeset: 174fe91374f8 Author: wmdietl Date: 2013-06-06 14:12 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/174fe91374f8 Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java From steve.sides at oracle.com Fri Jun 7 12:58:19 2013 From: steve.sides at oracle.com (Steve Sides) Date: Fri, 07 Jun 2013 12:58:19 -0700 Subject: 3 failing tests in type-annotations which are not in tl/langtools yet. Message-ID: <51B23B5B.4040506@oracle.com> Just a reminder, this tests are still failing in the type-annotations builds: 1. com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java javadoc does not properly display type annotations on type parameters (bug?): 2. tools/javac/annotations/typeAnnotations/classfile/T8008762.java 8008762 Type annotation on inner class in anonymous class show up as regular type annotations 3. tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java I'm not sure what's going on with this test. The compiler appears to issue the correct number and type of errors, but CantAnnotateStaticClass.out has just 1 line that says "dummy". This would appear to be a test bug(?). Is there uncertainty about whether javac is doing the right thing? I just want to make sure these aren't forgotten. -steve -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130607/5f61abed/attachment.html From wdietl at gmail.com Sun Jun 9 15:53:49 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 09 Jun 2013 22:53:49 +0000 Subject: hg: type-annotations/type-annotations/jdk: 11 new changesets Message-ID: <20130609225638.3B322480DD@hg.openjdk.java.net> Changeset: 986793409b2b Author: bpb Date: 2013-06-05 21:01 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/986793409b2b 7032154: Performance tuning of sun.misc.FloatingDecimal/FormattedFloatingDecimal Summary: Performance improvements for double/float -> String and decimal/hex String -> double/float conversions. Reviewed-by: martin, iris Contributed-by: Sergey Kuksenko , Brian Burkhalter , Dmitry Nadezhin , Olivier Lagneau ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/util/Formatter.java - src/share/classes/sun/misc/FDBigInt.java ! src/share/classes/sun/misc/FloatingDecimal.java ! src/share/classes/sun/misc/FormattedFloatingDecimal.java + test/sun/misc/FloatingDecimal/OldFDBigIntForTest.java + test/sun/misc/FloatingDecimal/OldFloatingDecimalForTest.java + test/sun/misc/FloatingDecimal/TestFDBigInteger.java + test/sun/misc/FloatingDecimal/TestFloatingDecimal.java Changeset: d28f802ce914 Author: robm Date: 2013-06-06 22:22 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d28f802ce914 8016063: getFinalAttributes should use FindClose Reviewed-by: alanb ! src/windows/native/java/io/WinNTFileSystem_md.c Changeset: f5f54e493a64 Author: bpb Date: 2013-06-06 16:45 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f5f54e493a64 8016117: New sun.misc.FDBigInteger class as part of 7032154 Reviewed-by: martin, iris Contributed-by: Sergey Kuksenko , Brian Burkhalter , Dmitry Nadezhin , Olivier Lagneau + src/share/classes/sun/misc/FDBigInteger.java Changeset: 6975eea0b458 Author: okutsu Date: 2013-06-07 17:07 +0900 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6975eea0b458 7177315: SimpleDateFormat parses wrong 2-digit year if input contains spaces Reviewed-by: peytoia ! src/share/classes/java/text/SimpleDateFormat.java + test/java/text/Format/DateFormat/Bug7177315.java Changeset: a286ed046116 Author: okutsu Date: 2013-06-07 17:37 +0900 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a286ed046116 7064270: java/text/Format/DateFormat/WeekDateTest.java fails on OEL5.6 hi_IN.UTF-8 Reviewed-by: peytoia ! test/java/text/Format/DateFormat/WeekDateTest.java Changeset: 8b65dfe8f509 Author: khazra Date: 2013-06-07 10:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8b65dfe8f509 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER Summary: Return false for null arguments in ACCEPT_ORIGINAL_SERVER#shouldAccept() Reviewed-by: chegar ! src/share/classes/java/net/CookiePolicy.java ! test/java/net/CookieHandler/CookieManagerTest.java Changeset: e2333bd8514a Author: lancea Date: 2013-06-07 14:13 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e2333bd8514a 8016101: Fix typo in SerialRef and missing @param in SerialStruct Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java Changeset: aed2ad905da6 Author: sherman Date: 2013-06-07 13:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/aed2ad905da6 8015728: (zipfs) demo/zipfs/basic.sh failing Summary: to return the correct loc entry size from wirteLOC(); Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: f18337edd201 Author: coleenp Date: 2013-06-07 22:15 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f18337edd201 7124706: enable RetransformBigClass.sh test when fix for 8013063 is promoted Summary: The code for this test is fixed now and integrated to TL repo and it passes now. Reviewed-by: alanb ! test/java/lang/instrument/MakeJAR4.sh ! test/java/lang/instrument/RetransformBigClass.sh Changeset: c351a48c091d Author: ksrini Date: 2013-06-08 09:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c351a48c091d 8016209: TEST_BUG: non-compliant jmc in the bin directory hangs testing Reviewed-by: alanb, darcy, chegar ! test/tools/launcher/VersionCheck.java Changeset: e581aaf4a2f9 Author: wmdietl Date: 2013-06-09 15:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e581aaf4a2f9 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk From wdietl at gmail.com Sun Jun 9 15:54:38 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 09 Jun 2013 22:54:38 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 2 new changesets Message-ID: <20130609225449.47437480DA@hg.openjdk.java.net> Changeset: c2957e596bee Author: joehw Date: 2013-06-06 15:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/c2957e596bee 8015016: Improve JAXP 1.5 error message Reviewed-by: lancea ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages.properties Changeset: 7e7f1d38c0e3 Author: wmdietl Date: 2013-06-09 15:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/7e7f1d38c0e3 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxp From wdietl at gmail.com Sun Jun 9 15:55:21 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 09 Jun 2013 22:55:21 +0000 Subject: hg: type-annotations/type-annotations/langtools: 2 new changesets Message-ID: <20130609225541.8B017480DC@hg.openjdk.java.net> Changeset: fd31bf97340f Author: jjg Date: 2013-06-07 15:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/fd31bf97340f 8016193: Fix OAC issue in langtools docs Reviewed-by: darcy ! src/share/classes/com/sun/javadoc/Tag.java Changeset: 2326d7733296 Author: wmdietl Date: 2013-06-09 15:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/2326d7733296 Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools From charlie.wang at oracle.com Sun Jun 9 08:41:20 2013 From: charlie.wang at oracle.com (Charlie Wang) Date: Sun, 09 Jun 2013 23:41:20 +0800 Subject: Review request for type annotation reflection test In-Reply-To: <51AD1017.9050703@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> <51AD1017.9050703@oracle.com> Message-ID: <51B4A220.1050204@oracle.com> Hi, Updated all the tests according to comments. Here's webrev. Please review. https://www.dropbox.com/sh/qzuu63laqtg2xvw/kgloIb9ZZw Regards, Charlie On 2013/6/4 5:52, Alex Buckley wrote: > Hi Charlie, > > First, I think there is some clever stuff going on here, but it's hard > to figure out what it is. It's not enough to sprinkle comments like > "// input should be like ["@A() @B()", "@C() @D()"...]" in SrcType. I > would like an explanation of what a test case like > ClsGetAnnotatedInterTest is trying to do. The TestCase enum type looks > like a good place to start. Then, I would like to know how > Helper.SrcType supports that with search-and-replace on keys like > #ANNO. To be clear, I'm not looking for three bullet points; I'm > looking for paragraphs that can be added to your code's javadoc and be > useful to someone in ten years time. > > Second, in the interest of increasing the abstraction of > Helper.SrcType, you should introduce an interface with a getSrc method > and have it be implemented by the SrcType enum type. You should also > remove duplicated code throughout SrcType's enum constant bodies (e.g. > the code for "// get @anno for [#ANNO1] ..."). > > Third, please don't shorten terms which are part of the Java language. > METHODHEAD should be METHOD_HEADER. METHODPARAM should be > METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be > TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And > so on. Rigor really matters when dealing with the Java language. > > Alex > > On 6/2/2013 11:39 PM, Charlie Wang wrote: >> Hi, >> Please review attached 2 files, which I've changed according to >> comments. If OK, I will update the rest of the tests and publish for >> review. >> >> Regards, >> Charlie >> On 2013/5/22 9:55, Joseph Darcy wrote: >>> Hello, >>> >>> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>>> I see you have extracted the validation logic and common annotation >>>> types into TestUtil, so that any individual test will primarily be a >>>> data provider + test cases. However: >>>> >>>> 1. Jon is our resident TestNG expert and he says that data providers >>>> are intended to enumerate input values for tests; other code >>>> determines which values should pass the tests and which values should >>>> fail. But your data provider encodes the types and element values of >>>> annotations which are expected to appear at various locations - this >>>> is output data, not input data. >>>> >>>> 2. There is basically no abstraction over the expected annotations in >>>> the data provider. It's just a bunch of Object[][] values. >>>> Consequently, TestUtil is very brittle. There is weird indexing of >>>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>>> knowledge of specific test cases: >>>> >>>> catch (NoSuchMethodException e) { >>>> //expected exception for TypeAnno3 >>>> } >>>> >>>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>>> at present, but if they ever share state then you'll be in trouble, >>>> especially with the instance methods in GetAnnotated*Test. >>>> >>>> Charlie, there are two techniques you should adopt for tests on the >>>> core reflection API: >>>> >>>> - First, encode expected values of type annotations more directly, by >>>> annotating the AnnotationTypeTestXX declarations themselves. >>> >>> Note that this technique is used in various other regression tests in >>> the JDK repository. For some recently-written small examples see >>> >>> test/java/lang/reflect/Parameter/WithoutParameters.java >>> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >>> >>>> >>>> - Second, embrace combinatorial testing rather than declaring a bunch >>>> of ad-hoc AnnotationTypeTestXX types with type annotations in various >>>> locations. >>>> >>>> The core reflection tests for repeating annotations use both these >>>> techniques. Please look at item 2 of >>>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>>> >>>> - apologies for non-Oracle readers. Please talk with Steve and >>>> Matherey to get background. To be clear, I will not sign off the type >>>> annotations reflection tests in their present form. >>> >>> I concur that using combinatorial tests is appropriate for this >>> domain. The basic approach is to programatically generate both the >>> expected result and the code to test and verify that the computed >>> answer is consistent with the expected one. The regression tests >>> currently in JDK 8 have code that allows source code to be generated >>> at runtime, loading in by a class loader, and then run. >>> >>> HTH, >>> >>> -Joe >>> >>>> >>>> Alex >>>> >>>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>>> OK, thanks. >>>>> I will create a TestUtil.java (as attached file). Extract the common >>>>> part and put them in it. And Add comments on data provider. >>>>> I'm on a very tight schedule, so this time I just send out two of the >>>>> updated files (attached files) for review so I can get a quick >>>>> response. >>>>> If it is OK, I will use it as a template on other tests. >>>>> Please take a look and send me your comments as soon as possible. >>>>> >>>>> >>>>> Thanks, >>>>> Charlie >>>>> >>>>> >>>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>>> Please keep one source file per tested API method, because it is >>>>>> easy >>>>>> to navigate. The problem is the body of the test() method in each >>>>>> source file. It should call utility methods to inspect annotations, >>>>>> rather that repeating more or less the same 'for' loops as every >>>>>> other >>>>>> test() method. >>>>>> >>>>>> As for data providers, I believe they are a TestNG thing. Please add >>>>>> comments to each source file to describe what the data provider >>>>>> represents. >>>>>> >>>>>> Finally, when you make a "little update", you should give a short >>>>>> description of what has changed. If you don't, someone who looked at >>>>>> the previous version has no idea what changed and will have to >>>>>> look at >>>>>> everything again. >>>>>> >>>>>> Alex >>>>>> >>>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>>> Yes, that make sense. What do you think if I combine the tests? It >>>>>>> would >>>>>>> then have 1 unified data provider and test method, thus solve the 2 >>>>>>> problems. >>>>>>> >>>>>>> Regards, >>>>>>> Charlie >>>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>>> I agree with Alex's first two comments. The code duplication >>>>>>>> for the >>>>>>>> test logic and all the different annotation types seems hard to >>>>>>>> maintain and update. >>>>>>>> >>>>>>>> cu, WMD. >>>>>>>> >>>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>>> wrote: >>>>>>>>> Hi, >>>>>>>>> Here's the latest one with a little update: >>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>>> Please provide comments as soon as possible now that due >>>>>>>>> date is >>>>>>>>> approaching. >>>>>>>>> >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Charlie >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>>> JDK-8013497. >>>>>>>>> Please take a look. >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>>> >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Charlie >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>> >>> From wdietl at gmail.com Mon Jun 10 14:17:10 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 10 Jun 2013 21:17:10 +0000 Subject: hg: type-annotations/type-annotations/jdk: 6 new changesets Message-ID: <20130610211848.EDFB748109@hg.openjdk.java.net> Changeset: 3990fcab2cd9 Author: psandoz Date: 2013-06-10 11:52 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3990fcab2cd9 8015492: Remove DoubleStream.range methods Reviewed-by: alanb ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/Streams.java ! test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestDataProvider.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java Changeset: 7322e8ad7c01 Author: psandoz Date: 2013-06-10 12:20 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7322e8ad7c01 8015798: Rename IntStream.longs/doubles and LongStream.doubles to asXxxStream Reviewed-by: alanb ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/LongStream.java ! test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DoublePrimitiveOpsTests.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ExplodeOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/MapOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/MinMaxTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/PrimitiveSumTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamBuilderTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java Changeset: 9c462579b624 Author: psandoz Date: 2013-06-10 12:26 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9c462579b624 8015792: Rename Spliterators.spliteratorFromIterator to Spliterators.iterator Reviewed-by: chegar ! src/share/classes/java/util/Spliterators.java ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/SpinedBuffer.java ! test/java/util/Spliterator/SpliteratorTraversingAndSplittingTest.java ! test/java/util/stream/bootlib/java/util/stream/TestData.java ! test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java ! test/java/util/stream/boottest/java/util/stream/IntNodeTest.java ! test/java/util/stream/boottest/java/util/stream/LongNodeTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java Changeset: d790064850a7 Author: alanb Date: 2013-06-10 12:58 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d790064850a7 8016217: More javadoc warnings Reviewed-by: lancea, chegar, psandoz ! src/share/classes/java/io/BufferedInputStream.java ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/Console.java ! src/share/classes/java/io/PipedInputStream.java ! src/share/classes/java/io/PipedReader.java ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/io/PushbackInputStream.java ! src/share/classes/java/io/PushbackReader.java ! src/share/classes/java/io/StringReader.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Comparable.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/StackTraceElement.java ! src/share/classes/java/lang/instrument/Instrumentation.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/management/MemoryUsage.java ! src/share/classes/java/lang/management/RuntimeMXBean.java ! src/share/classes/java/lang/management/ThreadMXBean.java ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/net/CookiePolicy.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/net/InetSocketAddress.java ! src/share/classes/java/net/MulticastSocket.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/StandardSocketOptions.java ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/channels/SelectableChannel.java ! src/share/classes/java/nio/channels/SelectionKey.java ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/SecureRandom.java ! src/share/classes/java/security/cert/CertPathValidatorException.java ! src/share/classes/java/security/cert/CertificateFactory.java ! src/share/classes/java/security/cert/X509Extension.java ! src/share/classes/java/security/spec/EllipticCurve.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/text/CharacterIterator.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/Collator.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Date.java ! src/share/classes/java/util/LinkedHashMap.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/TimerTask.java ! src/share/classes/java/util/jar/Pack200.java ! src/share/classes/java/util/logging/ConsoleHandler.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/prefs/Preferences.java ! src/share/classes/java/util/regex/MatchResult.java ! src/share/classes/java/util/regex/Pattern.java ! src/share/classes/java/util/stream/package-info.java ! src/share/classes/java/util/zip/DeflaterInputStream.java ! src/share/classes/java/util/zip/DeflaterOutputStream.java ! src/share/classes/java/util/zip/GZIPInputStream.java ! src/share/classes/java/util/zip/GZIPOutputStream.java ! src/share/classes/java/util/zip/InflaterInputStream.java ! src/share/classes/java/util/zip/InflaterOutputStream.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/javax/crypto/spec/IvParameterSpec.java ! src/share/classes/javax/crypto/spec/RC5ParameterSpec.java ! src/share/classes/javax/crypto/spec/SecretKeySpec.java ! src/share/classes/javax/naming/BinaryRefAddr.java ! src/share/classes/javax/naming/directory/Attribute.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/PagedResultsControl.java ! src/share/classes/javax/naming/ldap/SortControl.java ! src/share/classes/javax/net/ssl/SNIHostName.java ! src/share/classes/javax/net/ssl/SSLEngine.java ! src/share/classes/javax/net/ssl/SSLEngineResult.java ! src/share/classes/javax/net/ssl/SSLSessionContext.java ! src/share/classes/javax/script/ScriptEngineFactory.java ! src/share/classes/javax/security/auth/callback/CallbackHandler.java ! src/share/classes/javax/security/sasl/Sasl.java ! src/share/classes/javax/security/sasl/SaslClient.java ! src/share/classes/javax/security/sasl/SaslServer.java ! src/share/classes/javax/smartcardio/ResponseAPDU.java ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java ! src/share/classes/javax/xml/crypto/dsig/Manifest.java Changeset: 4a66dd1d7eea Author: dxu Date: 2013-06-10 11:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4a66dd1d7eea 8013827: File.createTempFile hangs with temp file starting with 'com1.4' 8011950: java.io.File.createTempFile enters infinite loop when passed invalid data Reviewed-by: alanb ! src/share/classes/java/io/File.java ! src/windows/native/java/io/WinNTFileSystem_md.c ! test/java/io/File/CreateNewFile.java ! test/java/io/File/NulFile.java + test/java/io/File/createTempFile/SpecialTempFile.java Changeset: 202e3ab44559 Author: wmdietl Date: 2013-06-10 14:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/202e3ab44559 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk From charlie.wang at oracle.com Wed Jun 12 19:41:59 2013 From: charlie.wang at oracle.com (Charlie Wang) Date: Thu, 13 Jun 2013 10:41:59 +0800 Subject: Review request for type annotation reflection test In-Reply-To: <51AD1017.9050703@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> <51AD1017.9050703@oracle.com> Message-ID: <51B93177.6050005@oracle.com> Hi, Updated all the tests according to comments. Here's webrev. Please review. http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ Regards, Charlie On 2013/6/4 5:52, Alex Buckley wrote: > Hi Charlie, > > First, I think there is some clever stuff going on here, but it's hard > to figure out what it is. It's not enough to sprinkle comments like > "// input should be like ["@A() @B()", "@C() @D()"...]" in SrcType. I > would like an explanation of what a test case like > ClsGetAnnotatedInterTest is trying to do. The TestCase enum type looks > like a good place to start. Then, I would like to know how > Helper.SrcType supports that with search-and-replace on keys like > #ANNO. To be clear, I'm not looking for three bullet points; I'm > looking for paragraphs that can be added to your code's javadoc and be > useful to someone in ten years time. > > Second, in the interest of increasing the abstraction of > Helper.SrcType, you should introduce an interface with a getSrc method > and have it be implemented by the SrcType enum type. You should also > remove duplicated code throughout SrcType's enum constant bodies (e.g. > the code for "// get @anno for [#ANNO1] ..."). > > Third, please don't shorten terms which are part of the Java language. > METHODHEAD should be METHOD_HEADER. METHODPARAM should be > METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be > TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And > so on. Rigor really matters when dealing with the Java language. > > Alex > > On 6/2/2013 11:39 PM, Charlie Wang wrote: >> Hi, >> Please review attached 2 files, which I've changed according to >> comments. If OK, I will update the rest of the tests and publish for >> review. >> >> Regards, >> Charlie >> On 2013/5/22 9:55, Joseph Darcy wrote: >>> Hello, >>> >>> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>>> I see you have extracted the validation logic and common annotation >>>> types into TestUtil, so that any individual test will primarily be a >>>> data provider + test cases. However: >>>> >>>> 1. Jon is our resident TestNG expert and he says that data providers >>>> are intended to enumerate input values for tests; other code >>>> determines which values should pass the tests and which values should >>>> fail. But your data provider encodes the types and element values of >>>> annotations which are expected to appear at various locations - this >>>> is output data, not input data. >>>> >>>> 2. There is basically no abstraction over the expected annotations in >>>> the data provider. It's just a bunch of Object[][] values. >>>> Consequently, TestUtil is very brittle. There is weird indexing of >>>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>>> knowledge of specific test cases: >>>> >>>> catch (NoSuchMethodException e) { >>>> //expected exception for TypeAnno3 >>>> } >>>> >>>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>>> at present, but if they ever share state then you'll be in trouble, >>>> especially with the instance methods in GetAnnotated*Test. >>>> >>>> Charlie, there are two techniques you should adopt for tests on the >>>> core reflection API: >>>> >>>> - First, encode expected values of type annotations more directly, by >>>> annotating the AnnotationTypeTestXX declarations themselves. >>> >>> Note that this technique is used in various other regression tests in >>> the JDK repository. For some recently-written small examples see >>> >>> test/java/lang/reflect/Parameter/WithoutParameters.java >>> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >>> >>>> >>>> - Second, embrace combinatorial testing rather than declaring a bunch >>>> of ad-hoc AnnotationTypeTestXX types with type annotations in various >>>> locations. >>>> >>>> The core reflection tests for repeating annotations use both these >>>> techniques. Please look at item 2 of >>>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>>> >>>> - apologies for non-Oracle readers. Please talk with Steve and >>>> Matherey to get background. To be clear, I will not sign off the type >>>> annotations reflection tests in their present form. >>> >>> I concur that using combinatorial tests is appropriate for this >>> domain. The basic approach is to programatically generate both the >>> expected result and the code to test and verify that the computed >>> answer is consistent with the expected one. The regression tests >>> currently in JDK 8 have code that allows source code to be generated >>> at runtime, loading in by a class loader, and then run. >>> >>> HTH, >>> >>> -Joe >>> >>>> >>>> Alex >>>> >>>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>>> OK, thanks. >>>>> I will create a TestUtil.java (as attached file). Extract the common >>>>> part and put them in it. And Add comments on data provider. >>>>> I'm on a very tight schedule, so this time I just send out two of the >>>>> updated files (attached files) for review so I can get a quick >>>>> response. >>>>> If it is OK, I will use it as a template on other tests. >>>>> Please take a look and send me your comments as soon as possible. >>>>> >>>>> >>>>> Thanks, >>>>> Charlie >>>>> >>>>> >>>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>>> Please keep one source file per tested API method, because it is >>>>>> easy >>>>>> to navigate. The problem is the body of the test() method in each >>>>>> source file. It should call utility methods to inspect annotations, >>>>>> rather that repeating more or less the same 'for' loops as every >>>>>> other >>>>>> test() method. >>>>>> >>>>>> As for data providers, I believe they are a TestNG thing. Please add >>>>>> comments to each source file to describe what the data provider >>>>>> represents. >>>>>> >>>>>> Finally, when you make a "little update", you should give a short >>>>>> description of what has changed. If you don't, someone who looked at >>>>>> the previous version has no idea what changed and will have to >>>>>> look at >>>>>> everything again. >>>>>> >>>>>> Alex >>>>>> >>>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>>> Yes, that make sense. What do you think if I combine the tests? It >>>>>>> would >>>>>>> then have 1 unified data provider and test method, thus solve the 2 >>>>>>> problems. >>>>>>> >>>>>>> Regards, >>>>>>> Charlie >>>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>>> I agree with Alex's first two comments. The code duplication >>>>>>>> for the >>>>>>>> test logic and all the different annotation types seems hard to >>>>>>>> maintain and update. >>>>>>>> >>>>>>>> cu, WMD. >>>>>>>> >>>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>>> wrote: >>>>>>>>> Hi, >>>>>>>>> Here's the latest one with a little update: >>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>>> Please provide comments as soon as possible now that due >>>>>>>>> date is >>>>>>>>> approaching. >>>>>>>>> >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Charlie >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>>> JDK-8013497. >>>>>>>>> Please take a look. >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>>> >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Charlie >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>> >>> From alex.buckley at oracle.com Thu Jun 13 12:29:41 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Thu, 13 Jun 2013 12:29:41 -0700 Subject: Review request for type annotation reflection test In-Reply-To: <51B93177.6050005@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> <51AD1017.9050703@oracle.com> <51B93177.6050005@oracle.com> Message-ID: <51BA1DA5.6060304@oracle.com> Thanks Charlie. I can see the combinatorial approach emerging, but the abstraction level still needs to be raised to make the code approachable. This can be achieved with more interfaces and less duplication, as suggested below. - Some of the files have their last line missing. - Please check the jtreg guidelines for how to write @test, @bug, and @author. - PkgGetDeclaredAnnotations should end in Test. Also, don't abbreviate - there is no value saying Cls rather than Class, Pkg rather than Package, and Var rather than Variable, it just trips over the reader. - Here's a bunch of stuff about organization. First, please separate the infrastructure code into a different package than the Test classes. Second, the Test classes themselves should be in named packages, not in unnamed packages. Third, the directory test/java/lang/typeannoreflection is really painful because there is no package java.lang.typeannoreflection. Ideally you would have test/type-annotations/java/lang/Class for the test classes which exercise java.lang.Class, and test/type-annotations/java/lang/reflect/Executable for the test classes which exercise j.l.r.Executable methods, and so on. - annoComb seems to be identical in every Test class. Why not centralize it? Methods like compareAnnoWithDiffSeq and debugPrint are also duplicated in various classes. - The TestCase enum constants are all intended to implement a getTestCase method, so please declare an interface for TestCase to implement. - Style: Taking this as an example: "static LinkedHashMap lhm = new LinkedHashMap();" ... 1) It is not acceptable to use raw types in Java code written in 2013, and 2) Declare variables using interfaces (Map<...>) not classes (LinkedHashMap<..>) wherever possible. Alex On 6/12/2013 7:41 PM, Charlie Wang wrote: > Hi, > Updated all the tests according to comments. Here's webrev. Please > review. > http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ > > > > Regards, > Charlie > > > On 2013/6/4 5:52, Alex Buckley wrote: >> Hi Charlie, >> >> First, I think there is some clever stuff going on here, but it's hard >> to figure out what it is. It's not enough to sprinkle comments like >> "// input should be like ["@A() @B()", "@C() @D()"...]" in SrcType. I >> would like an explanation of what a test case like >> ClsGetAnnotatedInterTest is trying to do. The TestCase enum type looks >> like a good place to start. Then, I would like to know how >> Helper.SrcType supports that with search-and-replace on keys like >> #ANNO. To be clear, I'm not looking for three bullet points; I'm >> looking for paragraphs that can be added to your code's javadoc and be >> useful to someone in ten years time. >> >> Second, in the interest of increasing the abstraction of >> Helper.SrcType, you should introduce an interface with a getSrc method >> and have it be implemented by the SrcType enum type. You should also >> remove duplicated code throughout SrcType's enum constant bodies (e.g. >> the code for "// get @anno for [#ANNO1] ..."). >> >> Third, please don't shorten terms which are part of the Java language. >> METHODHEAD should be METHOD_HEADER. METHODPARAM should be >> METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be >> TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And >> so on. Rigor really matters when dealing with the Java language. >> >> Alex >> >> On 6/2/2013 11:39 PM, Charlie Wang wrote: >>> Hi, >>> Please review attached 2 files, which I've changed according to >>> comments. If OK, I will update the rest of the tests and publish for >>> review. >>> >>> Regards, >>> Charlie >>> On 2013/5/22 9:55, Joseph Darcy wrote: >>>> Hello, >>>> >>>> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>>>> I see you have extracted the validation logic and common annotation >>>>> types into TestUtil, so that any individual test will primarily be a >>>>> data provider + test cases. However: >>>>> >>>>> 1. Jon is our resident TestNG expert and he says that data providers >>>>> are intended to enumerate input values for tests; other code >>>>> determines which values should pass the tests and which values should >>>>> fail. But your data provider encodes the types and element values of >>>>> annotations which are expected to appear at various locations - this >>>>> is output data, not input data. >>>>> >>>>> 2. There is basically no abstraction over the expected annotations in >>>>> the data provider. It's just a bunch of Object[][] values. >>>>> Consequently, TestUtil is very brittle. There is weird indexing of >>>>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>>>> knowledge of specific test cases: >>>>> >>>>> catch (NoSuchMethodException e) { >>>>> //expected exception for TypeAnno3 >>>>> } >>>>> >>>>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>>>> at present, but if they ever share state then you'll be in trouble, >>>>> especially with the instance methods in GetAnnotated*Test. >>>>> >>>>> Charlie, there are two techniques you should adopt for tests on the >>>>> core reflection API: >>>>> >>>>> - First, encode expected values of type annotations more directly, by >>>>> annotating the AnnotationTypeTestXX declarations themselves. >>>> >>>> Note that this technique is used in various other regression tests in >>>> the JDK repository. For some recently-written small examples see >>>> >>>> test/java/lang/reflect/Parameter/WithoutParameters.java >>>> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >>>> >>>>> >>>>> - Second, embrace combinatorial testing rather than declaring a bunch >>>>> of ad-hoc AnnotationTypeTestXX types with type annotations in various >>>>> locations. >>>>> >>>>> The core reflection tests for repeating annotations use both these >>>>> techniques. Please look at item 2 of >>>>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>>>> >>>>> - apologies for non-Oracle readers. Please talk with Steve and >>>>> Matherey to get background. To be clear, I will not sign off the type >>>>> annotations reflection tests in their present form. >>>> >>>> I concur that using combinatorial tests is appropriate for this >>>> domain. The basic approach is to programatically generate both the >>>> expected result and the code to test and verify that the computed >>>> answer is consistent with the expected one. The regression tests >>>> currently in JDK 8 have code that allows source code to be generated >>>> at runtime, loading in by a class loader, and then run. >>>> >>>> HTH, >>>> >>>> -Joe >>>> >>>>> >>>>> Alex >>>>> >>>>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>>>> OK, thanks. >>>>>> I will create a TestUtil.java (as attached file). Extract the common >>>>>> part and put them in it. And Add comments on data provider. >>>>>> I'm on a very tight schedule, so this time I just send out two of the >>>>>> updated files (attached files) for review so I can get a quick >>>>>> response. >>>>>> If it is OK, I will use it as a template on other tests. >>>>>> Please take a look and send me your comments as soon as possible. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Charlie >>>>>> >>>>>> >>>>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>>>> Please keep one source file per tested API method, because it is >>>>>>> easy >>>>>>> to navigate. The problem is the body of the test() method in each >>>>>>> source file. It should call utility methods to inspect annotations, >>>>>>> rather that repeating more or less the same 'for' loops as every >>>>>>> other >>>>>>> test() method. >>>>>>> >>>>>>> As for data providers, I believe they are a TestNG thing. Please add >>>>>>> comments to each source file to describe what the data provider >>>>>>> represents. >>>>>>> >>>>>>> Finally, when you make a "little update", you should give a short >>>>>>> description of what has changed. If you don't, someone who looked at >>>>>>> the previous version has no idea what changed and will have to >>>>>>> look at >>>>>>> everything again. >>>>>>> >>>>>>> Alex >>>>>>> >>>>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>>>> Yes, that make sense. What do you think if I combine the tests? It >>>>>>>> would >>>>>>>> then have 1 unified data provider and test method, thus solve the 2 >>>>>>>> problems. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Charlie >>>>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>>>> I agree with Alex's first two comments. The code duplication >>>>>>>>> for the >>>>>>>>> test logic and all the different annotation types seems hard to >>>>>>>>> maintain and update. >>>>>>>>> >>>>>>>>> cu, WMD. >>>>>>>>> >>>>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>>>> wrote: >>>>>>>>>> Hi, >>>>>>>>>> Here's the latest one with a little update: >>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>>>> Please provide comments as soon as possible now that due >>>>>>>>>> date is >>>>>>>>>> approaching. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Charlie >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>>>> JDK-8013497. >>>>>>>>>> Please take a look. >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Charlie >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>>> > From wdietl at gmail.com Sun Jun 16 16:06:17 2013 From: wdietl at gmail.com (Werner Dietl) Date: Sun, 16 Jun 2013 16:06:17 -0700 Subject: Request for comments: type annotations on nested types Message-ID: Dear all, I've been working on type annotations on nested types and want to make sure I'm implementing the right checks. Find three test classes attached that should contain all legal combinations of nesting of types. Instead of a .out file, see "// err" markers for the lines that I expect errors. CantAnnotateStaticClass.java contains only legal combinations; see tests 2 and 3 for error cases. My interpretation is basically that, if it is possible to refer to a "Outer.this" object, it should be possible to have a type annotation on that type use. Does everybody agree with this interpretation? Do you see any errors in my test cases? Do you see a way to write the test cases in a more succinct and complete way? I have a few local changes that refactor this part of the compiler. I'll push once we agree on the checks. Thanks for all comments! cu, WMD. -- http://www.google.com/profiles/wdietl -------------- next part -------------- A non-text attachment was scrubbed... Name: CantAnnotateStaticClass.java Type: application/octet-stream Size: 2707 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130616/75c466d5/CantAnnotateStaticClass.java -------------- next part -------------- A non-text attachment was scrubbed... Name: CantAnnotateStaticClass2.java Type: application/octet-stream Size: 6566 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130616/75c466d5/CantAnnotateStaticClass2.java -------------- next part -------------- A non-text attachment was scrubbed... Name: CantAnnotateStaticClass3.java Type: application/octet-stream Size: 6686 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130616/75c466d5/CantAnnotateStaticClass3.java From alex.buckley at oracle.com Mon Jun 17 12:57:54 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 17 Jun 2013 12:57:54 -0700 Subject: Request for comments: type annotations on nested types In-Reply-To: References: Message-ID: <51BF6A42.9000106@oracle.com> // For simplicity, sending solely to type-annotations-dev. In what follows, I intend to be precise in talking about _names_ rather than _types_. I am not even going to say "type use" because without some forthcoming JLS changes, it's not precise enough. I am going to speak solely about qualified names composed of simple names. The goal of JSR 308 is that a simple name that acts merely as a "scoping mechanism" may not be annotated. Thus, in a qualified package name like "java.lang", neither the simple package name "java" nor the simple package name "lang" may be annotated. And, in a qualified type name like "A.B", the simple type name "A" may not be annotated if the simple type name "B" refers to a static member. That is, "A" may not be annotated if the type referred to by "B" does not have an enclosing instance. As I look through the fine scenarios in CantAnnotateStaticClass2 (since CantAnnotateStaticClass3 is just a demo that all member declarations in an interface are static), javac looks to be applying the rules correctly: @TB Outer f1; @TB Outer.Inner f1a; @TB Outer.SInner f2a; // err @TB Outer.IInner f3a; // err The problem is, it's rather subtle for the language to work like this: @TB Outer. @TC Inner f1c; @TB Outer. @TC SInner f2c; // err @TB Outer. @TC IInner f3c; // err The ClassFile representation of annotations on qualified type names does not care whether the underlying declarations are static. Personally, I am inclined to drop the "scoping mechanism" rule and allow a TYPE_USE annotation on any simple type name. (I would not, at this stage of the JSR, extend such freedom to simple type names in class-oriented expressions like class literals and qualified this expressions, because storing annotations thereon would require ClassFile changes.) I intend to discuss this with the EG when practical. Alex On 6/16/2013 4:06 PM, Werner Dietl wrote: > Dear all, > > I've been working on type annotations on nested types and want to make > sure I'm implementing the right checks. > > Find three test classes attached that should contain all legal > combinations of nesting of types. > Instead of a .out file, see "// err" markers for the lines that I expect errors. > CantAnnotateStaticClass.java contains only legal combinations; see > tests 2 and 3 for error cases. > My interpretation is basically that, if it is possible to refer to a > "Outer.this" object, it should be possible to have a type annotation > on that type use. > > Does everybody agree with this interpretation? > Do you see any errors in my test cases? > Do you see a way to write the test cases in a more succinct and complete way? > > I have a few local changes that refactor this part of the compiler. > I'll push once we agree on the checks. > > Thanks for all comments! > cu, WMD. > > -- > http://www.google.com/profiles/wdietl > From charlie.wang at oracle.com Mon Jun 17 19:51:25 2013 From: charlie.wang at oracle.com (Charlie Wang) Date: Tue, 18 Jun 2013 10:51:25 +0800 Subject: Review request for type annotation reflection test In-Reply-To: <51B93177.6050005@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> <51AD1017.9050703@oracle.com> <51B93177.6050005@oracle.com> Message-ID: <51BFCB2D.6000706@oracle.com> Hi, Please review type annotation reflection test. http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ Here's test result: http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/1.txt Regards, Charlie On 2013/6/13 10:41, Charlie Wang wrote: > Hi, > Updated all the tests according to comments. Here's webrev. Please > review. > http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ > > > > Regards, > Charlie > > > On 2013/6/4 5:52, Alex Buckley wrote: >> Hi Charlie, >> >> First, I think there is some clever stuff going on here, but it's >> hard to figure out what it is. It's not enough to sprinkle comments >> like "// input should be like ["@A() @B()", "@C() @D()"...]" in >> SrcType. I would like an explanation of what a test case like >> ClsGetAnnotatedInterTest is trying to do. The TestCase enum type >> looks like a good place to start. Then, I would like to know how >> Helper.SrcType supports that with search-and-replace on keys like >> #ANNO. To be clear, I'm not looking for three bullet points; I'm >> looking for paragraphs that can be added to your code's javadoc and >> be useful to someone in ten years time. >> >> Second, in the interest of increasing the abstraction of >> Helper.SrcType, you should introduce an interface with a getSrc >> method and have it be implemented by the SrcType enum type. You >> should also remove duplicated code throughout SrcType's enum constant >> bodies (e.g. the code for "// get @anno for [#ANNO1] ..."). >> >> Third, please don't shorten terms which are part of the Java >> language. METHODHEAD should be METHOD_HEADER. METHODPARAM should be >> METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be >> TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And >> so on. Rigor really matters when dealing with the Java language. >> >> Alex >> >> On 6/2/2013 11:39 PM, Charlie Wang wrote: >>> Hi, >>> Please review attached 2 files, which I've changed according to >>> comments. If OK, I will update the rest of the tests and publish for >>> review. >>> >>> Regards, >>> Charlie >>> On 2013/5/22 9:55, Joseph Darcy wrote: >>>> Hello, >>>> >>>> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>>>> I see you have extracted the validation logic and common annotation >>>>> types into TestUtil, so that any individual test will primarily be a >>>>> data provider + test cases. However: >>>>> >>>>> 1. Jon is our resident TestNG expert and he says that data providers >>>>> are intended to enumerate input values for tests; other code >>>>> determines which values should pass the tests and which values should >>>>> fail. But your data provider encodes the types and element values of >>>>> annotations which are expected to appear at various locations - this >>>>> is output data, not input data. >>>>> >>>>> 2. There is basically no abstraction over the expected annotations in >>>>> the data provider. It's just a bunch of Object[][] values. >>>>> Consequently, TestUtil is very brittle. There is weird indexing of >>>>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>>>> knowledge of specific test cases: >>>>> >>>>> catch (NoSuchMethodException e) { >>>>> //expected exception for TypeAnno3 >>>>> } >>>>> >>>>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>>>> at present, but if they ever share state then you'll be in trouble, >>>>> especially with the instance methods in GetAnnotated*Test. >>>>> >>>>> Charlie, there are two techniques you should adopt for tests on the >>>>> core reflection API: >>>>> >>>>> - First, encode expected values of type annotations more directly, by >>>>> annotating the AnnotationTypeTestXX declarations themselves. >>>> >>>> Note that this technique is used in various other regression tests in >>>> the JDK repository. For some recently-written small examples see >>>> >>>> test/java/lang/reflect/Parameter/WithoutParameters.java >>>> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >>>> >>>>> >>>>> - Second, embrace combinatorial testing rather than declaring a bunch >>>>> of ad-hoc AnnotationTypeTestXX types with type annotations in various >>>>> locations. >>>>> >>>>> The core reflection tests for repeating annotations use both these >>>>> techniques. Please look at item 2 of >>>>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>>>> >>>>> - apologies for non-Oracle readers. Please talk with Steve and >>>>> Matherey to get background. To be clear, I will not sign off the type >>>>> annotations reflection tests in their present form. >>>> >>>> I concur that using combinatorial tests is appropriate for this >>>> domain. The basic approach is to programatically generate both the >>>> expected result and the code to test and verify that the computed >>>> answer is consistent with the expected one. The regression tests >>>> currently in JDK 8 have code that allows source code to be generated >>>> at runtime, loading in by a class loader, and then run. >>>> >>>> HTH, >>>> >>>> -Joe >>>> >>>>> >>>>> Alex >>>>> >>>>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>>>> OK, thanks. >>>>>> I will create a TestUtil.java (as attached file). Extract the common >>>>>> part and put them in it. And Add comments on data provider. >>>>>> I'm on a very tight schedule, so this time I just send out two of >>>>>> the >>>>>> updated files (attached files) for review so I can get a quick >>>>>> response. >>>>>> If it is OK, I will use it as a template on other tests. >>>>>> Please take a look and send me your comments as soon as possible. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Charlie >>>>>> >>>>>> >>>>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>>>> Please keep one source file per tested API method, because it is >>>>>>> easy >>>>>>> to navigate. The problem is the body of the test() method in each >>>>>>> source file. It should call utility methods to inspect annotations, >>>>>>> rather that repeating more or less the same 'for' loops as every >>>>>>> other >>>>>>> test() method. >>>>>>> >>>>>>> As for data providers, I believe they are a TestNG thing. Please >>>>>>> add >>>>>>> comments to each source file to describe what the data provider >>>>>>> represents. >>>>>>> >>>>>>> Finally, when you make a "little update", you should give a short >>>>>>> description of what has changed. If you don't, someone who >>>>>>> looked at >>>>>>> the previous version has no idea what changed and will have to >>>>>>> look at >>>>>>> everything again. >>>>>>> >>>>>>> Alex >>>>>>> >>>>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>>>> Yes, that make sense. What do you think if I combine the tests? It >>>>>>>> would >>>>>>>> then have 1 unified data provider and test method, thus solve >>>>>>>> the 2 >>>>>>>> problems. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Charlie >>>>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>>>> I agree with Alex's first two comments. The code duplication >>>>>>>>> for the >>>>>>>>> test logic and all the different annotation types seems hard to >>>>>>>>> maintain and update. >>>>>>>>> >>>>>>>>> cu, WMD. >>>>>>>>> >>>>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>>>> wrote: >>>>>>>>>> Hi, >>>>>>>>>> Here's the latest one with a little update: >>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>>>> Please provide comments as soon as possible now that due >>>>>>>>>> date is >>>>>>>>>> approaching. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Charlie >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>>>> JDK-8013497. >>>>>>>>>> Please take a look. >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Charlie >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>>> > From wdietl at gmail.com Tue Jun 18 00:55:24 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 07:55:24 +0000 Subject: hg: type-annotations/type-annotations: 15 new changesets Message-ID: <20130618075526.46F30482A0@hg.openjdk.java.net> Changeset: 33b6df33a2b7 Author: erikj Date: 2013-05-29 13:58 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/33b6df33a2b7 8013920: Configure sets JOBS to 0 if memory is too low. Reviewed-by: tbell ! common/autoconf/build-performance.m4 ! common/autoconf/generated-configure.sh Changeset: 03e60e87d92a Author: erikj Date: 2013-05-29 14:01 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/03e60e87d92a 8013489: New build system does not run codesign on SA-related launchers on OS X Reviewed-by: sla, tbell ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/makefiles/MakeBase.gmk ! common/makefiles/NativeCompilation.gmk Changeset: c31e9dc1fe3d Author: erikj Date: 2013-05-31 14:07 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/c31e9dc1fe3d 8014003: New build does not handle symlinks in workspace path Reviewed-by: tbell ! common/autoconf/basics.m4 ! common/autoconf/basics_windows.m4 ! common/autoconf/generated-configure.sh Changeset: 44259699e0b5 Author: erikj Date: 2013-06-04 10:23 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/44259699e0b5 8015784: Add configure parameter --with-update-version Reviewed-by: tbell, katleman, erikj Contributed-by: tristan.yan at oracle.com ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: db3144e1f89b Author: mduigou Date: 2013-06-04 10:36 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/db3144e1f89b 8015510: (s) Improve JTReg location detection and provide location to test/Makefile Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 ! common/makefiles/Main.gmk Changeset: 9b8e8098172c Author: katleman Date: 2013-06-04 11:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/9b8e8098172c Merge Changeset: f55734874c4f Author: katleman Date: 2013-06-04 15:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/f55734874c4f Merge ! common/autoconf/generated-configure.sh Changeset: 27c51c6e31c1 Author: katleman Date: 2013-06-05 15:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/27c51c6e31c1 6983966: remove lzma and upx from repository JDK8 Reviewed-by: tbell, paulk, ngthomas ! common/autoconf/generated-configure.sh ! common/makefiles/Jprt.gmk ! make/deploy-rules.gmk Changeset: 8dfb6ee04114 Author: katleman Date: 2013-06-06 09:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/8dfb6ee04114 Added tag jdk8-b93 for changeset 27c51c6e31c1 ! .hgtags Changeset: 198d25db45da Author: erikj Date: 2013-06-11 13:08 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/198d25db45da 8008707: build-infra: Closed (deploy) can't be built using environment from SDK SetEnv.cmd Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain_windows.m4 Changeset: 3cbcc2b6ba41 Author: erikj Date: 2013-06-11 13:25 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/3cbcc2b6ba41 8010785: JDK 8 build on Linux fails with new build mechanism Reviewed-by: dholmes, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 Changeset: 50d2bde060f2 Author: erikj Date: 2013-06-12 10:33 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/50d2bde060f2 Merge Changeset: 6337f652e71f Author: katleman Date: 2013-06-13 09:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/6337f652e71f Added tag jdk8-b94 for changeset 50d2bde060f2 ! .hgtags Changeset: f8770fe60d53 Author: mduigou Date: 2013-06-17 09:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/f8770fe60d53 8016572: Pass CONCURRENCY=$(JOBS) to test/Makefile Reviewed-by: alanb, erikj ! common/makefiles/Main.gmk Changeset: b5fda499d7d7 Author: wmdietl Date: 2013-06-18 00:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/b5fda499d7d7 Automated merge with http://hg.openjdk.java.net/jdk8/tl/ ! .hgtags From wdietl at gmail.com Tue Jun 18 00:56:06 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 07:56:06 +0000 Subject: hg: type-annotations/type-annotations/jaxws: 5 new changesets Message-ID: <20130618075620.79A7E482A2@hg.openjdk.java.net> Changeset: 8f2986ff0235 Author: mkos Date: 2013-06-12 14:47 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/8f2986ff0235 8013021: Rebase 8005432 & 8003542 against the latest jdk8/jaxws 8003542: Improve processing of MTOM attachments 8005432: Update access to JAX-WS Reviewed-by: mullan ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/DatabindingModeFeature.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/databinding/ExternalMetadataFeature.java ! src/share/jaxws_classes/com/oracle/webservices/internal/api/message/BaseDistributedPropertySet.java ! src/share/jaxws_classes/com/oracle/webservices/internal/impl/encoding/StreamDecoderImpl.java ! src/share/jaxws_classes/com/oracle/xmlns/internal/webservices/jaxws_databinding/package-info.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_de.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_es.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_fr.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_it.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ja.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_ko.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_pt_BR.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_CN.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/MessageBundle_zh_TW.properties ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Classes.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Config.java ! src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/Schema.java ! src/share/jaxws_classes/com/sun/tools/internal/ws/version.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_de.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_es.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_fr.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_it.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ja.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_ko.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_pt_BR.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_CN.properties ! src/share/jaxws_classes/com/sun/tools/internal/xjc/MessageBundle_zh_TW.properties ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/ModelBuilder.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/runtime/JAXBContextImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/XmlSchemaGenerator.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/CommonResourceBundle.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/Decoder.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/algorithm/BASE64EncodingAlgorithm.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/algorithm/BooleanEncodingAlgorithm.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/algorithm/BuiltInEncodingAlgorithm.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/algorithm/FloatEncodingAlgorithm.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/algorithm/HexadecimalEncodingAlgorithm.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/dom/DOMDocumentParser.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/resources/ResourceBundle.properties ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/sax/AttributesHolder.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/sax/SAXDocumentParser.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/stax/StAXDocumentParser.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/stax/events/StartElementEvent.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/stax/factory/StAXOutputFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/tools/SAXEventSerializer.java ! src/share/jaxws_classes/com/sun/xml/internal/fastinfoset/tools/TransformInputOutput.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/DataHead.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/MemoryData.java + src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/mimepull/TempFiles.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/databinding/DatabindingConfig.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/saaj/SAAJFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/pipe/Fiber.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/streaming/XMLStreamWriterFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/MetroConfigLoader.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/assembler/TubeCreator.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/MonitorRootClient.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/SEIPortInfo.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/WSServiceDelegate.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/dispatch/DispatchImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/SEIStub.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/SyncMethodHandler.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/db/DatabindingFactoryImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/db/DatabindingImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/encoding/MtomCodec.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/message/stream/StreamMessage.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/RuntimeModeler.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/WrapperBeanGenerator.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLBoundOperationImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/model/wsdl/WSDLOperationImpl.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/DispatchMessages.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/resources/dispatch.properties ! src/share/jaxws_classes/com/sun/xml/internal/ws/server/EndpointFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/BindingInfo.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/spi/db/JAXBWrapperAccessor.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/transport/http/HttpAdapter.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/util/version.properties ! src/share/jaxws_classes/javax/xml/soap/FactoryFinder.java ! src/share/jaxws_classes/javax/xml/soap/MessageFactory.java ! src/share/jaxws_classes/javax/xml/soap/SAAJMetaFactory.java ! src/share/jaxws_classes/javax/xml/soap/SOAPConnectionFactory.java ! src/share/jaxws_classes/javax/xml/soap/SOAPFactory.java Changeset: 254c53fd97ab Author: katleman Date: 2013-06-06 09:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/254c53fd97ab Added tag jdk8-b93 for changeset 7386eca865e1 ! .hgtags Changeset: 1468c94135f9 Author: katleman Date: 2013-06-13 09:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/1468c94135f9 Added tag jdk8-b94 for changeset 254c53fd97ab ! .hgtags Changeset: c4191a46e3eb Author: lana Date: 2013-06-16 22:33 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/c4191a46e3eb Merge Changeset: 9edc68d7c4b4 Author: wmdietl Date: 2013-06-18 00:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/9edc68d7c4b4 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxws ! .hgtags From wdietl at gmail.com Tue Jun 18 00:56:42 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 07:56:42 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 9 new changesets Message-ID: <20130618075707.08176482A3@hg.openjdk.java.net> Changeset: 5c84d4a878f1 Author: joehw Date: 2013-06-10 14:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/5c84d4a878f1 8016153: Property http://javax.xml.XMLConstants/property/accessExternalDTD is not recognized. Reviewed-by: lancea, dfuchs ! src/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java ! src/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/com/sun/org/apache/xerces/internal/jaxp/validation/ValidatorHandlerImpl.java ! src/com/sun/org/apache/xml/internal/utils/XMLReaderManager.java Changeset: 659828443145 Author: coffeys Date: 2013-06-14 15:14 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/659828443145 8015978: Incorrect transformation of XPath expression "string(-0)" Reviewed-by: darcy, joehw Contributed-by: aleksej.efimov at oracle.com ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java Changeset: 2707f600a096 Author: robm Date: 2013-06-15 09:26 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/2707f600a096 8016701: JAXP Build failure Reviewed-by: darcy, wetmore, alanb, chegar ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java Changeset: 40da96cab40e Author: katleman Date: 2013-06-06 09:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/40da96cab40e Added tag jdk8-b93 for changeset d583a491d63c ! .hgtags Changeset: c84658e1740d Author: lana Date: 2013-06-10 16:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/c84658e1740d Merge Changeset: b8c5f4b6f0ff Author: katleman Date: 2013-06-13 09:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/b8c5f4b6f0ff Added tag jdk8-b94 for changeset c84658e1740d ! .hgtags Changeset: 0142ef23f1b4 Author: lana Date: 2013-06-16 22:32 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/0142ef23f1b4 Merge Changeset: 09d55894844d Author: joehw Date: 2013-06-17 12:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/09d55894844d 8016133: Regression: diff. behavior with user-defined SAXParser Reviewed-by: chegar, dfuchs ! src/org/xml/sax/helpers/XMLReaderFactory.java Changeset: ce7461a9e5cd Author: wmdietl Date: 2013-06-18 00:56 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/ce7461a9e5cd Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxp ! .hgtags From wdietl at gmail.com Tue Jun 18 00:59:45 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 07:59:45 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 66 new changesets Message-ID: <20130618080216.CD531482A6@hg.openjdk.java.net> Changeset: 61dcf187a198 Author: katleman Date: 2013-06-06 09:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/61dcf187a198 Added tag jdk8-b93 for changeset 573d86d412cd ! .hgtags Changeset: 194b27b865bc Author: amurillo Date: 2013-05-24 09:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/194b27b865bc 8015305: new hotspot build - hs25-b35 Reviewed-by: jcoomes ! make/hotspot_version Changeset: ccdecfece956 Author: bharadwaj Date: 2013-05-21 16:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ccdecfece956 8014059: JSR292: Failed to reject invalid class cplmhl00201m28n Summary: Restrict reference of interface methods by invokestatic and invokespecial to classfile version 52 or later. Reviewed-by: kvn, hseigel ! src/share/vm/classfile/classFileParser.cpp Changeset: f54c85acc043 Author: mikael Date: 2013-05-21 09:43 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f54c85acc043 8013726: runtime/memory/ReserveMemory.java fails due to 'assert(bytes % os::vm_allocation_granularity() == 0) failed: reserve block size' Summary: Fix regression test to work on all platforms Reviewed-by: ctornqvi, dholmes ! src/share/vm/prims/whitebox.cpp ! test/runtime/memory/ReserveMemory.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 1a07e086ff28 Author: dholmes Date: 2013-05-21 19:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1a07e086ff28 Merge Changeset: 6bd680e9ea35 Author: coleenp Date: 2013-05-22 14:37 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/6bd680e9ea35 8003421: NPG: Move oops out of InstanceKlass into mirror Summary: Inject protection_domain, signers, init_lock into java_lang_Class Reviewed-by: stefank, dholmes, sla ! agent/src/share/classes/sun/jvm/hotspot/memory/DictionaryEntry.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapGXLWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaInstanceKlass.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 699d9df07e59 Author: ctornqvi Date: 2013-05-23 17:39 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/699d9df07e59 8009576: Test returns ClassNotFoundException Summary: Small classpath fix and move tests into open Reviewed-by: mgerdin, zgu + test/runtime/Metaspace/FragmentMetaspace.java + test/runtime/Metaspace/FragmentMetaspaceSimple.java + test/runtime/Metaspace/classes/test/Empty.java + test/runtime/testlibrary/GeneratedClassLoader.java Changeset: b7fa10a3a69a Author: sspitsyn Date: 2013-05-23 23:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b7fa10a3a69a 8014288: perf regression in nashorn JDK-8008448.js test after 8008511 changes Summary: The fix of perf regression is to use method_idnum() for direct indexing into NMT Reviewed-by: twisti, kvn, coleenp, dholmes Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: cd83e1d98347 Author: dcubed Date: 2013-05-24 10:21 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/cd83e1d98347 Merge Changeset: 6c138b9851fb Author: sspitsyn Date: 2013-05-24 17:36 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/6c138b9851fb 8013945: CMS fatal error: must own lock MemberNameTable_lock Summary: The "delete mnt" needs to grab MemberNameTable_lock if !SafepointSynchronize::is_at_safepoint() Reviewed-by: sla, mgerdin, dholmes, jmasa Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/oops/instanceKlass.cpp Changeset: 3970971c91e0 Author: shade Date: 2013-05-27 12:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3970971c91e0 8015270: @Contended: fix multiple issues in the layout code Summary: field count handling fixed, has_nonstatic_fields invariant fixed, oop map overrun fixed; new asserts Reviewed-by: kvn, dcubed, coleenp ! src/share/vm/classfile/classFileParser.cpp + test/runtime/contended/HasNonStatic.java + test/runtime/contended/OopMaps.java Changeset: a213d425d87a Author: ctornqvi Date: 2013-05-28 15:08 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a213d425d87a 8015329: Print reason for failed MiniDumpWriteDump() call Summary: Printing both result from GetLastError and text representation of error. Also changed so that we produce dumps by default on client versions of Windows when running with a debug build. Also reviewed by peter.allwin at oracle.com Reviewed-by: sla, dholmes ! src/os/windows/vm/os_windows.cpp Changeset: 51af5fae397d Author: ccheung Date: 2013-05-24 17:19 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/51af5fae397d 8015265: revise the fix for 8007037 Reviewed-by: sspitsyn, dholmes, dcubed ! src/share/vm/oops/constantPool.cpp Changeset: 4cc7d4d5dc92 Author: zgu Date: 2013-05-28 08:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/4cc7d4d5dc92 Merge Changeset: 01c2bdd24bb5 Author: shade Date: 2013-05-28 19:54 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/01c2bdd24bb5 8015493: runtime/contended/OopMaps.java fails with OutOfMemory Summary: limit the memory footprint to dodge OutOfMemory errors. Reviewed-by: dcubed, ctornqvi, iignatyev ! test/runtime/contended/OopMaps.java Changeset: 9ea643afcaaf Author: dcubed Date: 2013-05-28 11:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9ea643afcaaf Merge Changeset: dcb062bea05b Author: jprovino Date: 2013-05-28 11:17 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/dcb062bea05b 8013461: There is a symbol AsyncGetCallTrace in libjvm.symbols that does not exist in minimal/libjvm.a when DEBUG_LEVEL == release Summary: AsyncGetCallTrace is needed in libjvm.symbols so that programs which reference it can build correctly. Reviewed-by: dholmes, bobv ! make/excludeSrc.make ! src/share/vm/prims/forte.cpp Changeset: fb14e9ed1594 Author: jprovino Date: 2013-05-28 11:32 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/fb14e9ed1594 8011064: Some tests have failed with SIGSEGV on arm-hflt on build b82 Summary: NMT_detail is only supported when frame pointers are not omitted (-fno-omit-frame-pointer). Reviewed-by: dholmes, cjplummer ! src/share/vm/services/memTracker.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 9e954e8d9139 Author: jprovino Date: 2013-05-28 15:24 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9e954e8d9139 Merge Changeset: 9e86c5544295 Author: jiangli Date: 2013-05-30 13:19 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9e86c5544295 Merge Changeset: 0def34ab1c98 Author: tamao Date: 2013-05-21 16:43 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/0def34ab1c98 8015007: Incorrect print format in error message for VM cannot allocate the requested heap Summary: Correct the wrong print format in error message for VM cannot allocate the requested heap; and clean up the error message call in check_alignment() Reviewed-by: brutisso, tschatzl Contributed-by: tamao ! src/share/vm/memory/universe.cpp Changeset: 14d3f71f831d Author: tamao Date: 2013-05-22 11:11 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/14d3f71f831d 8007762: Rename a bunch of methods in size policy across collectors Summary: Rename: compute_generations_free_space() = compute_eden_space_size() + compute_old_gen_free_space(); update related logging messages Reviewed-by: jmasa, johnc, tschatzl, brutisso Contributed-by: tamao ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parNew/asParNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psGCAdaptivePolicyCounters.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp Changeset: 0886b99a4d1b Author: jwilhelm Date: 2013-05-24 14:16 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/0886b99a4d1b Merge Changeset: eda078b01c65 Author: stefank Date: 2013-05-27 15:22 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/eda078b01c65 8015268: NPG: 2.5% regression in young GC times on CRM Sales Opty Summary: Split SystemDictionary and ClassLoaderDataGraph root processing to help load balancing. Reviewed-by: tschatzl, johnc ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/memory/sharedHeap.cpp Changeset: 95c00927be11 Author: stefank Date: 2013-05-27 12:56 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/95c00927be11 8015428: Remove unused CDS support from StringTable Summary: The string in StringTable is not used by CDS anymore. Remove the unnecessary code in preparation for 8015422: Large performance hit when the StringTable is walked twice in Parallel Scavenge Reviewed-by: pliden, tschatzl, coleenp ! src/share/vm/classfile/symbolTable.cpp Changeset: 8dbc025ff709 Author: stefank Date: 2013-05-27 12:58 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/8dbc025ff709 8015422: Large performance hit when the StringTable is walked twice in Parallel Scavenge Summary: Combine the calls to StringTable::unlink and StringTable::oops_do in Parallel Scavenge. Reviewed-by: pliden, coleenp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp Changeset: f41a577cffb0 Author: jwilhelm Date: 2013-05-31 09:55 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f41a577cffb0 Merge Changeset: b786c04b7be1 Author: amurillo Date: 2013-05-31 09:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b786c04b7be1 Merge Changeset: 5a028ee56116 Author: amurillo Date: 2013-05-31 09:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5a028ee56116 Added tag hs25-b35 for changeset b786c04b7be1 ! .hgtags Changeset: b7569f617285 Author: amurillo Date: 2013-05-31 10:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b7569f617285 8015690: new hotspot build - hs25-b36 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 5534bd30c151 Author: jcoomes Date: 2013-05-30 13:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5534bd30c151 6725714: par compact - add a table to speed up bitmap searches Reviewed-by: jmasa, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: 47bdfb3d010f Author: stefank Date: 2013-05-30 10:58 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/47bdfb3d010f 8015486: PSScavenge::is_obj_in_young is unnecessarily slow with UseCompressedOops Summary: Compare compressed oops to a compressed young gen boundary instead of uncompressing the oops before doing the young gen boundary check. Reviewed-by: brutisso, jmasa ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp Changeset: c20186fa611b Author: jwilhelm Date: 2013-06-01 10:00 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c20186fa611b Merge Changeset: e72f7eecc96d Author: tschatzl Date: 2013-05-28 09:32 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e72f7eecc96d 8013895: G1: G1SummarizeRSetStats output on Linux needs improvemen Summary: Fixed the output of G1SummarizeRSetStats: too small datatype for the number of concurrently processed cards, added concurrent remembered set thread time retrieval for Linux and Windows (BSD uses os::elapsedTime() now), and other cleanup. The information presented during VM operation is now relative to the previous output, not always cumulative if G1SummarizeRSetStatsPeriod > 0. At VM exit, the code prints a cumulative summary. Reviewed-by: johnc, jwilhelm ! make/excludeSrc.make ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp + src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp + src/share/vm/gc_implementation/g1/g1RemSetSummary.hpp + test/gc/g1/TestSummarizeRSetStats.java Changeset: 3a4805ad0005 Author: johnc Date: 2013-06-04 10:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3a4805ad0005 8015244: G1: Verification after a full GC is incorrectly placed. Summary: In a full GC, move the verification after the GC to after RSet rebuilding. Verify RSet entries during a full GC under control of a flag. Reviewed-by: tschatzl, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp Changeset: 87c64c0438fb Author: tamao Date: 2013-06-03 14:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/87c64c0438fb 6976350: G1: deal with fragmentation while copying objects during GC Summary: Create G1ParGCAllocBufferContainer to contain two buffers instead of previously using one buffer, in order to hold the first priority buffer longer. Thus, when some large objects hits the value of free space left in the first priority buffer it has an alternative to fit in the second priority buffer while the first priority buffer is given more chances to try allocating smaller objects. Overall, it will improve heap space efficiency. Reviewed-by: johnc, jmasa, brutisso Contributed-by: tamao ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp Changeset: 2f7a31318b84 Author: johnc Date: 2013-06-04 14:00 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2f7a31318b84 Merge Changeset: a1ebd310d5c1 Author: iklam Date: 2013-05-28 16:36 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a1ebd310d5c1 8014912: Restore PrintSharedSpaces functionality after NPG Summary: Added dumping of object sizes in CDS archive, sorted by MetaspaceObj::Type Reviewed-by: coleenp, acorn ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/methodCounters.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/symbol.cpp ! src/share/vm/utilities/array.hpp Changeset: fe00365c8f31 Author: sspitsyn Date: 2013-05-30 11:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/fe00365c8f31 8015436: compiler/ciReplay/TestSA.sh fails with assert() index is out of bounds Summary: The InstanceKlass _initial_method_idnum value must be adjusted if overpass methods are added. Reviewed-by: twisti, kvn Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/classfile/defaultMethods.cpp + test/compiler/8015436/Test8015436.java Changeset: a589c78a8811 Author: rbackman Date: 2013-05-31 13:02 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a589c78a8811 8014709: Constructor.getAnnotatedReturnType() returns empty AnnotatedType Reviewed-by: stefank, rbackman Contributed-by: Joel Borggren-Franck ! src/share/vm/runtime/reflection.cpp ! test/runtime/8007320/ConstMethodTest.java Changeset: efe8b7d64424 Author: ctornqvi Date: 2013-05-31 20:24 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/efe8b7d64424 6726963: multi_allocate() call does not CHECK_NULL and causes crash in fastdebug bits Summary: Using CHECK_NULL when calling multi_allocate() from the corresponding reflection code; added test for this condition Reviewed-by: dholmes, minqi Contributed-by: Mikhailo Seledtsov ! src/share/vm/runtime/reflection.cpp + test/runtime/memory/MultiAllocateNullCheck.java Changeset: 532c55335fb6 Author: dcubed Date: 2013-06-01 09:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/532c55335fb6 Merge Changeset: 4552a7633a07 Author: hseigel Date: 2013-06-03 10:00 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/4552a7633a07 8015385: Remove RelaxAccessControlCheck for JDK 8 bytecodes Summary: Check bytecode versions along with RelaxAccessControlCheck version Reviewed-by: dholmes, acorn ! src/share/vm/classfile/verifier.hpp ! src/share/vm/runtime/reflection.cpp Changeset: e7d29a019a3c Author: sspitsyn Date: 2013-06-03 14:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e7d29a019a3c 8014052: JSR292: assert(end_offset == next_offset) failed: matched ending Summary: A call to the finalize_operands_merge() must be unconditional Reviewed-by: kvn, twisti Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 2f004f9dc9e1 Author: sspitsyn Date: 2013-06-04 01:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2f004f9dc9e1 8015803: Test8015436.java fails 'can not access a member of class Test8015436 with modifiers "public static"' Summary: Newly added test has an issue: the main class must be public Reviewed-by: kvn, jbachorik, coleenp Contributed-by: serguei.spitsyn at oracle.com ! test/compiler/8015436/Test8015436.java Changeset: 04551f4dbdb9 Author: nloodin Date: 2013-06-05 09:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/04551f4dbdb9 Merge Changeset: 62e7bac9524f Author: dcubed Date: 2013-06-04 19:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/62e7bac9524f 8010257: remove unused thread-local variables _ScratchA and _ScratchB Summary: Remove dead code. Reviewed-by: twisti, coleenp ! src/share/vm/runtime/thread.hpp Changeset: 6bf8b8bb7c19 Author: hseigel Date: 2013-06-05 14:12 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/6bf8b8bb7c19 8009302: Mac OS X: JVM crash on infinite recursion on Appkit Thread Summary: Use SA_ONSTACK flag to ensure signal gets delivered properly. Reviewed-by: dholmes, coleenp Contributed-by: gerard.ziemski at oracle.com ! src/os/bsd/vm/os_bsd.cpp Changeset: f8c8cace25ad Author: dcubed Date: 2013-06-06 05:56 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f8c8cace25ad Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: 320b4e0f0892 Author: roland Date: 2013-05-30 11:21 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/320b4e0f0892 8015585: Missing regression test for 8011771 Summary: missing regression test Reviewed-by: kvn + test/compiler/8011771/Test8011771.java Changeset: f15fe46d8c00 Author: twisti Date: 2013-05-30 08:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f15fe46d8c00 8015266: fix some -Wsign-compare warnings in adlc Reviewed-by: kvn ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/dict2.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/output_c.cpp Changeset: 28e5aed7f3a6 Author: roland Date: 2013-05-31 14:40 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/28e5aed7f3a6 8009981: nashorn tests fail with -XX:+VerifyStack Summary: nmethod::preserve_callee_argument_oops() must take appendix into account. Reviewed-by: kvn, twisti ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 83dcb116fdb1 Author: kvn Date: 2013-05-31 13:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/83dcb116fdb1 8015441: runThese crashed with assert(opcode == Op_ConP || opcode == Op_ThreadLocal || opcode == Op_CastX2P ..) failed: sanity Summary: Relax the assert to accept any raw ptr types. Reviewed-by: roland ! src/share/vm/opto/escape.cpp Changeset: c07dd9be16e8 Author: anoll Date: 2013-05-31 06:41 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c07dd9be16e8 8013496: Code cache management command line options work only in special order. Another order of arguments does not deliver the second parameter to the jvm. Summary: Moved check that ReservedCodeCacheSize >= InitialCodeCacheSize to Arguments::check_vm_args_consistency(). As a result, the ordering in which the two parameters are given to the VM is not relevant. Added a regression test. Reviewed-by: kvn, twisti ! src/share/vm/runtime/arguments.cpp + test/compiler/8013496/Test8013496.sh Changeset: 603ca7e51354 Author: roland Date: 2013-04-24 11:49 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/603ca7e51354 8010460: Interpreter on some platforms loads ConstMethod::_max_stack and misses extra stack slots for JSR 292 Summary: ConstMethod::max_stack() doesn't account for JSR 292 appendix. Reviewed-by: kvn ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/cppInterpreter_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/opto/matcher.cpp Changeset: 813f26e34135 Author: anoll Date: 2013-06-03 08:52 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/813f26e34135 8013329: File leak in hotspot/src/share/vm/compiler/compileBroker.cpp Summary: Added calling of the destructor of CompileLog so that files are closed. Added/moved memory allocation/deallocation of the string that contains the name of the log file to class CompileLog. Reviewed-by: kvn, roland ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/compiler/compileLog.hpp Changeset: b274ac1dbe11 Author: adlertz Date: 2013-06-03 12:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b274ac1dbe11 8005956: C2: assert(!def_outside->member(r)) failed: Use of external LRG overlaps the same LRG defined in this block Summary: Disable re-materialization of reaching definitions (which have live inputs) for phi nodes when spilling. Reviewed-by: twisti, kvn ! src/share/vm/opto/reg_split.cpp Changeset: 770e91e578a6 Author: kvn Date: 2013-06-03 14:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/770e91e578a6 Merge Changeset: 075ea888b039 Author: morris Date: 2013-06-04 12:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/075ea888b039 8010724: [parfait] Null pointer dereference in hotspot/src/share/vm/c1/c1_LIRGenerator.cpp Summary: added guarantee() Reviewed-by: kvn ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: 2cb5d5f6d5e5 Author: simonis Date: 2013-06-04 22:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2cb5d5f6d5e5 8015252: Enable HotSpot build with Clang Reviewed-by: twisti, dholmes, kvn ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/adlc.make ! make/linux/makefiles/gcc.make ! src/os/bsd/vm/os_bsd.cpp ! src/os_cpu/linux_x86/vm/linux_x86_32.s ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp Changeset: 609aad72004a Author: anoll Date: 2013-06-06 09:29 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/609aad72004a 8014246: remove assert to catch access to object headers in index_oop_from_field_offset_long Reviewed-by: twisti, jrose ! src/share/vm/prims/unsafe.cpp Changeset: ef1818846c22 Author: kvn Date: 2013-06-06 11:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ef1818846c22 Merge ! src/os/bsd/vm/os_bsd.cpp Changeset: 3c78a14da19d Author: amurillo Date: 2013-06-07 09:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3c78a14da19d Merge ! .hgtags Changeset: 1beed1f6f9ed Author: amurillo Date: 2013-06-07 09:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1beed1f6f9ed Added tag hs25-b36 for changeset 3c78a14da19d ! .hgtags Changeset: 3a353050e85a Author: katleman Date: 2013-06-13 09:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3a353050e85a Added tag jdk8-b94 for changeset 1beed1f6f9ed ! .hgtags Changeset: 3a6aa83a6abd Author: wmdietl Date: 2013-06-18 00:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3a6aa83a6abd Automated merge with http://hg.openjdk.java.net/jdk8/tl/hotspot ! .hgtags From wdietl at gmail.com Tue Jun 18 01:01:37 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 08:01:37 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 11 new changesets Message-ID: <20130618080151.D726F482A4@hg.openjdk.java.net> Changeset: bab844827181 Author: sundar Date: 2013-06-06 21:41 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/bab844827181 8015346: JSON parsing issues with escaped strings, octal, decimal numbers Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/ir/BlockLexicalContext.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8015346.js Changeset: 918a986b0478 Author: hannesw Date: 2013-06-07 17:44 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/918a986b0478 8012291: NativeArray is inconsistent in using long for length and index in some places and int for the same in other places Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/codegen/FieldObjectCreator.java ! src/jdk/nashorn/internal/codegen/MapCreator.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIndex.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/examples/array-micro.js + test/script/basic/JDK-8012291.js + test/script/basic/JDK-8012291.js.EXPECTED Changeset: 8f890b6bf6de Author: lagergren Date: 2013-06-10 13:21 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/8f890b6bf6de 8015892: canBeUndefined too conservative for some use before declaration cases Reviewed-by: attila, hannesw ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/ir/Symbol.java + test/script/basic/JDK-8015892.js + test/script/basic/fib_wtf.js + test/script/basic/fib_wtf.js.EXPECTED Changeset: a6f8ea57f048 Author: lagergren Date: 2013-06-10 13:27 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/a6f8ea57f048 8016226: backing out test without third party license approval Reviewed-by: attila, sundar - test/script/basic/fib_wtf.js - test/script/basic/fib_wtf.js.EXPECTED Changeset: 966868ef75ee Author: sundar Date: 2013-06-10 19:54 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/966868ef75ee 8016239: loadWithNewGlobal should support user supplied arguments from the caller Reviewed-by: lagergren, attila, jlaskey ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java + test/script/basic/JDK-8016239.js + test/script/basic/JDK-8016239.js.EXPECTED Changeset: 1a5d67424e83 Author: sundar Date: 2013-06-11 13:09 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/1a5d67424e83 8015357: a = []; a[0x7fffffff]=1; a.sort()[0] should evaluate to 1 instead of undefined Reviewed-by: hannesw, lagergren + test/script/basic/JDK-8015357.js Changeset: fe830f6daa3f Author: sundar Date: 2013-06-11 13:12 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/fe830f6daa3f Merge Changeset: e857ab684db0 Author: cl Date: 2013-06-06 20:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/e857ab684db0 Added tag jdk8-b93 for changeset ddbf41575a2b ! .hgtags Changeset: d92b756bc739 Author: lana Date: 2013-06-10 17:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d92b756bc739 Merge - src/jdk/nashorn/internal/objects/DateParser.java Changeset: cbc9926f5b40 Author: katleman Date: 2013-06-13 09:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/cbc9926f5b40 Added tag jdk8-b94 for changeset d92b756bc739 ! .hgtags Changeset: 558d31c168ed Author: lana Date: 2013-06-16 22:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/558d31c168ed Merge From wdietl at gmail.com Tue Jun 18 01:01:25 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 08:01:25 +0000 Subject: hg: type-annotations/type-annotations/langtools: 13 new changesets Message-ID: <20130618080213.1F667482A5@hg.openjdk.java.net> Changeset: 105d1f9c1ab8 Author: vromero Date: 2013-06-10 15:18 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/105d1f9c1ab8 7113519: test/tools/javac/VersionOpt.java passes on windows Reviewed-by: jjg ! test/tools/javac/VersionOpt.java Changeset: 3582b62dccb2 Author: mcimadamore Date: 2013-06-10 15:57 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/3582b62dccb2 8013576: Add stat support to LambdaToMethod Summary: LambdaToMethod should emit info to help diagnose/test lambda metafactory problems Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/LambdaStat.java + test/tools/javac/diags/examples/MrefStat.java + test/tools/javac/diags/examples/MrefStat.java.rej + test/tools/javac/diags/examples/MrefStat1.java + test/tools/javac/diags/examples/MrefStat1.java.rej + test/tools/javac/lambda/TestLambdaToMethodStats.java Changeset: bbedff0dc37e Author: vromero Date: 2013-06-11 09:35 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/bbedff0dc37e 8008547: javac, warning message: use of ''_'' as an identifier might not be supported in future releases, should be more especific Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: 7fe655cad9b1 Author: vromero Date: 2013-06-11 09:59 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/7fe655cad9b1 8007907: javap, method com.sun.tools.javap.Main.run returns 0 even in case of class not found error Reviewed-by: jjg ! src/share/classes/com/sun/tools/javap/JavapTask.java ! test/tools/javac/constDebug/ConstDebugTest.java ! test/tools/javap/8006334/JavapTaskCtorFailWithNPE.java + test/tools/javap/8007907/JavapReturns0AfterClassNotFoundTest.java ! test/tools/javap/T4777949.java ! test/tools/javap/T7190862.java Changeset: 6b48ebae2569 Author: vromero Date: 2013-06-14 16:25 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/6b48ebae2569 8016569: javac, add new flag for polymorphic method signatures Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java Changeset: 1936a884b290 Author: vromero Date: 2013-06-14 18:01 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/1936a884b290 8008023: Get rid of utf8 chars in two tests Reviewed-by: jjg ! test/tools/javac/api/6437999/Utf8.java ! test/tools/javac/api/T6306137.java Changeset: 888386fddc09 Author: katleman Date: 2013-06-06 09:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/888386fddc09 Added tag jdk8-b93 for changeset 2c5a568ee36e ! .hgtags Changeset: 48c6e6ab7c81 Author: lana Date: 2013-06-10 17:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/48c6e6ab7c81 Merge Changeset: 4cb113623127 Author: katleman Date: 2013-06-13 09:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/4cb113623127 Added tag jdk8-b94 for changeset 48c6e6ab7c81 ! .hgtags Changeset: 1eb09dba594a Author: lana Date: 2013-06-16 22:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/1eb09dba594a Merge Changeset: b7a10bc02e7a Author: darcy Date: 2013-06-17 14:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/b7a10bc02e7a 8016779: Fix doclint warnings in javax.lang.model Reviewed-by: jjg ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/ElementScanner7.java ! src/share/classes/javax/lang/model/util/ElementScanner8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java Changeset: 455be95bd1b5 Author: rfield Date: 2013-06-17 20:29 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/455be95bd1b5 8013789: Compiler should emit bridges in interfaces Summary: paired with 8015402: Lambda metafactory should not attempt to determine bridge methods Reviewed-by: vromero Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! test/tools/javac/lambda/lambdaExpression/LambdaTest6.java ! test/tools/javac/lambda/methodReference/BridgeMethod.java Changeset: 140a69b1598f Author: wmdietl Date: 2013-06-18 00:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/140a69b1598f Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools ! .hgtags ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java From wdietl at gmail.com Tue Jun 18 00:55:39 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 07:55:39 +0000 Subject: hg: type-annotations/type-annotations/corba: 5 new changesets Message-ID: <20130618075543.97279482A1@hg.openjdk.java.net> Changeset: 5845df371e25 Author: alanb Date: 2013-06-10 17:15 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/5845df371e25 8016218: Warnings building corba repo due to missing hashCode methods Reviewed-by: chegar, coffeys, dfuchs ! src/share/classes/com/sun/corba/se/impl/javax/rmi/CORBA/StubDelegateImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/ParserTable.java ! src/share/classes/com/sun/corba/se/impl/orbutil/RepIdDelegator.java ! src/share/classes/sun/rmi/rmic/iiop/CompoundType.java Changeset: 22f5d7f261d9 Author: katleman Date: 2013-06-06 09:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/22f5d7f261d9 Added tag jdk8-b93 for changeset 8dc9d7ccbb2d ! .hgtags Changeset: 2cf36f43df36 Author: katleman Date: 2013-06-13 09:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/2cf36f43df36 Added tag jdk8-b94 for changeset 22f5d7f261d9 ! .hgtags Changeset: 0fac0a9d9545 Author: lana Date: 2013-06-16 22:30 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/0fac0a9d9545 Merge Changeset: ad2d934c6989 Author: wmdietl Date: 2013-06-18 00:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/ad2d934c6989 Automated merge with http://hg.openjdk.java.net/jdk8/tl/corba ! .hgtags From wdietl at gmail.com Tue Jun 18 00:58:11 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 07:58:11 +0000 Subject: hg: type-annotations/type-annotations/jdk: 61 new changesets Message-ID: <20130618081113.1215E482A7@hg.openjdk.java.net> Changeset: 8d627f324c38 Author: psandoz Date: 2013-06-11 12:13 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8d627f324c38 8015895: Int/LongStream.range/rangeClosed 8012986: Right-bias range spliterators for large ranges Reviewed-by: mduigou ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/Streams.java ! test/java/util/stream/bootlib/java/util/stream/IntStreamTestDataProvider.java ! test/java/util/stream/bootlib/java/util/stream/LongStreamTestDataProvider.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java Changeset: 669be1677ab7 Author: alanb Date: 2013-06-11 11:22 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/669be1677ab7 7059085: Retire Thread.stop(Throwable) so that it throws UOE Reviewed-by: dholmes, chegar, forax, darcy, mduigou ! src/share/classes/java/lang/Thread.java + test/java/lang/Thread/StopThrowable.java Changeset: 1f33fd081860 Author: alanb Date: 2013-06-11 11:25 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1f33fd081860 8016311: Update j.u.c. tests to avoid using Thread.stop(Throwable) Reviewed-by: alanb Contributed-by: martinrb at google.com ! test/java/util/concurrent/Executors/PrivilegedCallables.java ! test/java/util/concurrent/FutureTask/Throw.java ! test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java ! test/java/util/concurrent/locks/Lock/FlakyMutex.java Changeset: f1a1f65d2861 Author: alanb Date: 2013-06-11 14:09 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f1a1f65d2861 Merge Changeset: cadb0ef6e931 Author: naoto Date: 2013-06-11 11:18 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cadb0ef6e931 8015960: java/util/Locale/LocaleProviders.java failing again on Windows Reviewed-by: alanb ! test/java/util/Locale/LocaleProviders.java Changeset: 7f697d028937 Author: mduigou Date: 2013-06-11 15:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7f697d028937 8016213: Convert j2se NetBeans project to use top-level make targets Reviewed-by: chegar ! make/netbeans/common/shared.xml ! make/netbeans/j2se/build.xml Changeset: f56b5c243f7c Author: alanb Date: 2013-06-12 08:04 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f56b5c243f7c 8016370: javadoc warnings, unexpected

    mostly Reviewed-by: martin, jjg ! makefiles/scripts/genExceptions.sh ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/ByteOrder.java ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/channels/AsynchronousServerSocketChannel.java ! src/share/classes/java/nio/channels/Channel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/channels/FileLock.java ! src/share/classes/java/nio/channels/Pipe.java ! src/share/classes/java/nio/channels/SelectableChannel.java ! src/share/classes/java/nio/channels/SelectionKey.java ! src/share/classes/java/nio/channels/Selector.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelectionKey.java ! src/share/classes/java/nio/channels/spi/AbstractSelector.java ! src/share/classes/java/nio/channels/spi/SelectorProvider.java ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/charset/CoderResult.java ! src/share/classes/java/nio/charset/CodingErrorAction.java ! src/share/classes/java/nio/charset/UnmappableCharacterException.java ! src/share/classes/java/nio/charset/spi/CharsetProvider.java Changeset: 6df79b7bae6f Author: alanb Date: 2013-06-12 09:44 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6df79b7bae6f 8016369: java/lang/instrument/RetransformBigClass.sh failing again Reviewed-by: sla, sergei ! test/java/lang/instrument/MakeJAR4.sh Changeset: c9f5a2fd7d3d Author: bchristi Date: 2013-06-12 11:11 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c9f5a2fd7d3d 8010325: Remove hash32() method and hash32 int field from java.lang.String Reviewed-by: alanb, mduigou ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/WeakHashMap.java - src/share/classes/sun/misc/Hashing.java - test/sun/misc/Hashing.java Changeset: ce8fbca80bbc Author: henryjen Date: 2013-06-12 14:07 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ce8fbca80bbc 8016448: java/util/BitSet/BitSetStreamTest.java no longer compiles, missed by 8015895 Reviewed-by: mduigou ! test/java/util/BitSet/BitSetStreamTest.java Changeset: 021fdd093cd9 Author: weijun Date: 2013-06-13 09:59 +0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/021fdd093cd9 8014310: JAAS/Krb5LoginModule using des encytypes failure with NPE after JDK-8012679 Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/EncryptionKey.java ! src/share/classes/sun/security/krb5/KrbApReq.java ! src/share/classes/sun/security/krb5/KrbTgsReq.java ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! test/sun/security/krb5/auto/BasicKrb5Test.java ! test/sun/security/krb5/auto/OneKDC.java + test/sun/security/krb5/auto/OnlyDesLogin.java Changeset: e9c5ad10fa4b Author: weijun Date: 2013-06-13 10:00 +0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e9c5ad10fa4b 8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TEST_BUG: The 'ptool.test' can't be saved in the 'tmp' folder. 8016158: Instruction is not clear on how to use keytool to create JKS store in case Reviewed-by: mullan ! test/sun/security/tools/policytool/Alias.sh ! test/sun/security/tools/policytool/ChangeUI.html ! test/sun/security/tools/policytool/ChangeUI.sh ! test/sun/security/tools/policytool/OpenPolicy.sh ! test/sun/security/tools/policytool/SaveAs.sh ! test/sun/security/tools/policytool/UpdatePermissions.html ! test/sun/security/tools/policytool/UpdatePermissions.sh ! test/sun/security/tools/policytool/UsePolicy.sh ! test/sun/security/tools/policytool/i18n.html ! test/sun/security/tools/policytool/i18n.sh Changeset: 3c7bab68cd2f Author: yhuang Date: 2013-06-12 23:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3c7bab68cd2f 7040556: SimpleDateFormat.format Portuguese Month should not be capitalized Reviewed-by: okutsu ! src/share/classes/sun/text/resources/pt/FormatData_pt.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: a50394c44464 Author: psandoz Date: 2013-06-13 11:13 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a50394c44464 8016251: Balanced spliterator for SpinedBuffer Reviewed-by: mduigou Contributed-by: Brian Goetz , Peter Levart , Paul Sandoz ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/Node.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/SortedOps.java ! src/share/classes/java/util/stream/SpinedBuffer.java ! test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java ! test/java/util/stream/boottest/java/util/stream/IntNodeTest.java ! test/java/util/stream/boottest/java/util/stream/LongNodeTest.java ! test/java/util/stream/boottest/java/util/stream/SpinedBufferTest.java Changeset: f3609297a868 Author: igerasim Date: 2013-06-13 15:15 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f3609297a868 7181748: java/lang/ThreadGroup/Suspend.java test fails intermittently Reviewed-by: chegar, dholmes ! test/java/lang/ThreadGroup/Suspend.java Changeset: ff83bd43e36a Author: khazra Date: 2013-06-13 11:23 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ff83bd43e36a 8015421: NegativeArraySizeException occurs in ChunkedOutputStream() with Integer.MAX_VALUE Summary: Ensure integer overflow does not occur Reviewed-by: chegar ! src/share/classes/sun/net/www/http/ChunkedOutputStream.java Changeset: 42f9ad39bf42 Author: khazra Date: 2013-06-13 17:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/42f9ad39bf42 7169142: CookieHandler does not work with localhost Summary: Add .local to derived effective hostnames without dot Reviewed-by: chegar ! src/share/classes/java/net/CookieManager.java + test/java/net/CookieHandler/LocalHostCookie.java Changeset: f695f447f6b7 Author: jzavgren Date: 2013-06-14 09:13 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f695f447f6b7 8014307: Memory leak ... security/jgss/wrapper/GSSLibStub.c Summary: I modified the native procedure: Java_sun_security_jgss_wrapper_GSSLibStub_initContext() so that allocated memory is freed when errors occur. Reviewed-by: chegar, valeriep ! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c Changeset: 45a3584bfacf Author: coffeys Date: 2013-06-14 15:14 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/45a3584bfacf 8015978: Incorrect transformation of XPath expression "string(-0)" Reviewed-by: darcy, joehw Contributed-by: aleksej.efimov at oracle.com + test/javax/xml/jaxp/XPath/8015978/XPathNegativeZero.java + test/javax/xml/jaxp/XPath/8015978/dummy.xml + test/javax/xml/jaxp/XPath/8015978/negativezero.xsl Changeset: 583e6dec1ed7 Author: erikj Date: 2013-05-29 14:01 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/583e6dec1ed7 8013489: New build system does not run codesign on SA-related launchers on OS X Reviewed-by: sla, tbell ! makefiles/CompileLaunchers.gmk Changeset: d8c97d6772cd Author: erikj Date: 2013-05-30 09:29 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d8c97d6772cd Merge Changeset: bc3a17982aae Author: erikj Date: 2013-05-31 14:05 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bc3a17982aae 7195481: FDS: debuginfo file for libjdwp.so is missed Reviewed-by: tbell ! make/jpda/back/Makefile ! makefiles/CompileNativeLibraries.gmk Changeset: c50add191a39 Author: katleman Date: 2013-06-04 11:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c50add191a39 Merge ! makefiles/CompileNativeLibraries.gmk Changeset: 16003f414ca3 Author: katleman Date: 2013-06-04 14:11 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/16003f414ca3 8015644: makefile changes to allow integration of new features Reviewed-by: tbell, erikj, dholmes Contributed-by: amy.y.wang at oracle.com ! makefiles/Images.gmk Changeset: 691d6c6cd332 Author: katleman Date: 2013-06-05 15:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/691d6c6cd332 6983966: remove lzma and upx from repository JDK8 Reviewed-by: tbell, paulk, ngthomas ! make/common/Defs-windows.gmk Changeset: 7b757d567346 Author: katleman Date: 2013-06-06 09:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7b757d567346 Added tag jdk8-b93 for changeset 691d6c6cd332 ! .hgtags Changeset: fd377533608b Author: andrew Date: 2013-05-30 16:50 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fd377533608b 8011693: Remove redundant fontconfig files Summary: Remove unused fontconfig files from OpenJDK GNU/Linux builds Reviewed-by: andrew, prr Contributed-by: Jiri Vanek ! make/sun/awt/Makefile ! makefiles/GendataFontConfig.gmk - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties Changeset: b9b73bf450a4 Author: bae Date: 2013-05-31 14:30 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b9b73bf450a4 8015606: Text is not rendered correctly if destination buffer is custom Reviewed-by: prr, vadim ! src/share/classes/sun/java2d/loops/MaskFill.java + test/sun/java2d/loops/RenderToCustomBufferTest.java Changeset: 0a17344d074e Author: prr Date: 2013-05-31 09:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0a17344d074e 8015556: [macosx] surrogate pairs do not render properly. Reviewed-by: bae, jchen ! src/macosx/classes/sun/font/CCharToGlyphMapper.java + test/java/awt/FontClass/SurrogateTest/SuppCharTest.java Changeset: 3af3981dee11 Author: lana Date: 2013-06-05 09:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3af3981dee11 Merge - test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh Changeset: 768fcc36182a Author: anthony Date: 2013-05-30 18:10 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/768fcc36182a 8015303: [macosx] Application launched via custom URL Scheme does not receive URL Summary: Make copies of event parameters Reviewed-by: anthony, swingler, serb Contributed-by: James Tomson ! src/macosx/native/sun/osxapp/QueuingApplicationDelegate.m Changeset: 8472c148688c Author: ant Date: 2013-05-30 18:23 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8472c148688c 8013424: Regression: java.awt.datatransfer.FlavorListeners not notified on Linux/Java 7 Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XClipboard.java Changeset: 56512cfccef9 Author: ant Date: 2013-05-30 18:31 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/56512cfccef9 8013773: requestFocusInWindow to a disabled component prevents window of getting focused Reviewed-by: leonidr, alexsch ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java + test/java/awt/Focus/ResetMostRecentFocusOwnerTest/ResetMostRecentFocusOwnerTest.java Changeset: b0eab0f8b503 Author: anthony Date: 2013-05-31 14:12 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b0eab0f8b503 8013189: JMenuItems draw behind TextArea Summary: Untie XTextAreaPeer internal components from the TextArea parent to prevent its invalidation. I.e. force the java.awt.smartInvalidate=true locally. Reviewed-by: art, serb ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java + test/java/awt/TextArea/Mixing/TextAreaMixing.java Changeset: 481476e941fd Author: ant Date: 2013-05-31 15:56 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/481476e941fd 8015589: Test java/awt/Window/Grab/GrabTest.java fails on MacOSX Reviewed-by: anthony ! test/java/awt/Window/Grab/GrabTest.java Changeset: 611f8664c96c Author: malenkov Date: 2013-05-31 18:25 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/611f8664c96c 8013557: XMLEncoder in 1.7 can't encode objects initialized in no argument constructor Reviewed-by: alexsch ! src/share/classes/java/beans/XMLEncoder.java + test/java/beans/XMLEncoder/Test6989223.java + test/java/beans/XMLEncoder/Test7080156.java + test/java/beans/XMLEncoder/Test8013557.java Changeset: a4356b90f57d Author: vkarnauk Date: 2013-05-31 18:46 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a4356b90f57d 7068740: If you wrap a JTable in a JLayer you can't use the page up and page down cmds Reviewed-by: alexsch, alexp ! src/share/classes/javax/swing/plaf/basic/BasicTableUI.java + test/javax/swing/JTable/7068740/bug7068740.java Changeset: 791fd2ef87b3 Author: vkarnauk Date: 2013-05-31 19:34 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/791fd2ef87b3 6436314: Vector could be created with appropriate size in DefaultComboBoxModel Reviewed-by: alexsch, alexp ! src/share/classes/javax/swing/DefaultComboBoxModel.java Changeset: ae4683a6b860 Author: pchelko Date: 2013-06-03 10:14 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ae4683a6b860 8015477: Support single threaded AWT/FX mode. Reviewed-by: ant, anthony ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/CDropTargetContextPeer.m ! src/macosx/native/sun/awt/LWCToolkit.m ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/AWTAccessor.java + src/share/classes/sun/awt/FwDispatcher.java Changeset: 43f82f573c01 Author: alitvinov Date: 2013-06-03 14:05 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/43f82f573c01 7151823: The test incorrectly recognizing OS Reviewed-by: serb, alexp ! test/javax/swing/JTabbedPane/4624207/bug4624207.java Changeset: d378104e52e3 Author: anthony Date: 2013-06-03 16:27 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d378104e52e3 8015500: Prevent sending multiple WINDOW_CLOSED events for already disposed windows Reviewed-by: anthony, serb Contributed-by: Jose Luis Martin ! src/share/classes/java/awt/Window.java + test/java/awt/Window/WindowClosedEvents/WindowClosedEventOnDispose.java Changeset: 9a8e0140123a Author: alitvinov Date: 2013-06-03 16:37 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9a8e0140123a 6337518: Null Arrow Button Throws Exception in BasicComboBoxUI Reviewed-by: alexp, alexsch ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java + test/javax/swing/JComboBox/6337518/bug6337518.java Changeset: 8b274eccd94a Author: mcherkas Date: 2013-06-05 14:21 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8b274eccd94a 8015375: Edits to text components hang for clipboard access Reviewed-by: art, anthony Contributed-by: Dmitry Markov ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: 1390369d4457 Author: vkarnauk Date: 2013-06-05 16:57 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1390369d4457 8015425: [macosx] A follow-up for the fix 8010721 Reviewed-by: serb, anthony ! src/macosx/native/sun/awt/AWTWindow.m Changeset: a4af3d10d19e Author: ant Date: 2013-06-05 17:44 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a4af3d10d19e 8015339: Correct a wording in javadoc of java.awt.ContainerOrderFocusTraversalPolicy Reviewed-by: art, anthony ! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java Changeset: 6802f71a5eb2 Author: malenkov Date: 2013-06-05 18:15 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6802f71a5eb2 8013370: Null pointer exception when adding more than 9 accelators to a JMenuBar Reviewed-by: serb ! src/share/classes/javax/swing/KeyboardManager.java + test/javax/swing/KeyboardManager/8013370/Test8013370.java Changeset: e246bc03c8cb Author: lana Date: 2013-06-05 00:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e246bc03c8cb Merge - test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh Changeset: 3e904a3f3c9f Author: lana Date: 2013-06-05 09:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3e904a3f3c9f Merge Changeset: f272934d41fb Author: lana Date: 2013-06-05 12:30 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f272934d41fb Merge Changeset: 388b4d4cae3b Author: lana Date: 2013-06-05 12:31 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/388b4d4cae3b Merge - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java Changeset: 080449feeca9 Author: lana Date: 2013-06-10 17:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/080449feeca9 Merge - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java Changeset: e833fa13dce3 Author: erikj Date: 2013-06-11 13:26 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e833fa13dce3 8010785: JDK 8 build on Linux fails with new build mechanism Reviewed-by: dholmes, tbell ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk ! makefiles/Import.gmk ! makefiles/Setup.gmk Changeset: 51479fa56b7c Author: erikj Date: 2013-06-12 10:33 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/51479fa56b7c Merge Changeset: 992b39afdcb9 Author: katleman Date: 2013-06-13 09:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/992b39afdcb9 Added tag jdk8-b94 for changeset 51479fa56b7c ! .hgtags Changeset: bad604b15314 Author: lana Date: 2013-06-16 22:36 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bad604b15314 Merge - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties Changeset: adf70cb48ce0 Author: chegar Date: 2013-06-17 14:09 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/adf70cb48ce0 8016747: Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level) Reviewed-by: darcy ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/share/classes/java/awt/AWTEvent.java ! src/share/classes/java/awt/AttributeValue.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java ! src/share/classes/java/awt/Cursor.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/SplashScreen.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/WaitDispatchSupport.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/net/CookieManager.java ! src/share/classes/java/util/Currency.java ! src/share/classes/javax/swing/BufferStrategyPaintManager.java ! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! src/share/classes/sun/awt/AWTAutoShutdown.java ! src/share/classes/sun/awt/DebugSettings.java ! src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java ! src/share/classes/sun/awt/ScrollPaneWheelScroller.java ! src/share/classes/sun/awt/SunDisplayChanger.java ! src/share/classes/sun/awt/SunGraphicsCallback.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java ! src/share/classes/sun/awt/im/InputContext.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/net/ftp/impl/FtpClient.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java ! src/share/classes/sun/net/www/protocol/http/Negotiator.java ! src/share/classes/sun/net/www/protocol/https/HttpsClient.java ! src/solaris/classes/sun/awt/X11/ListHelper.java ! src/solaris/classes/sun/awt/X11/UnsafeXDisposerRecord.java ! src/solaris/classes/sun/awt/X11/XAWTXSettings.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDnDDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XDropTargetContextPeer.java ! src/solaris/classes/sun/awt/X11/XDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedServerTester.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XErrorHandlerUtil.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XIconWindow.java ! src/solaris/classes/sun/awt/X11/XInputMethod.java ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XMSelection.java ! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java ! src/solaris/classes/sun/awt/X11/XMenuPeer.java ! src/solaris/classes/sun/awt/X11/XMenuWindow.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XPopupMenuPeer.java ! src/solaris/classes/sun/awt/X11/XProtocol.java ! src/solaris/classes/sun/awt/X11/XScrollbar.java ! src/solaris/classes/sun/awt/X11/XScrollbarPeer.java ! src/solaris/classes/sun/awt/X11/XSystemTrayPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWINProtocol.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11InputMethod.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WDesktopProperties.java ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/classes/sun/awt/windows/WScrollPanePeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: b0cfde1e70e9 Author: shade Date: 2013-06-17 16:28 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b0cfde1e70e9 8016236: Class.getGenericInterfaces performance improvement Summary: cache more reflective data and lookup results. Reviewed-by: alanb, plevart, psandoz, dl Contributed-by: Doug Lea
    , Aleksey Shipilev ! src/share/classes/java/lang/Class.java ! src/share/classes/sun/reflect/generics/repository/ClassRepository.java ! src/share/native/java/lang/Class.c Changeset: 2b63fda275a3 Author: twisti Date: 2013-06-17 16:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2b63fda275a3 7177472: JSR292: MethodType interning penalizes scalability Reviewed-by: twisti Contributed-by: Aleksey Shipilev ! src/share/classes/java/lang/invoke/MethodType.java Changeset: 116050227ee9 Author: youdwei Date: 2013-06-17 17:36 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/116050227ee9 8014620: Signature.getAlgorithm return null in special case Reviewed-by: wetmore ! src/share/classes/java/security/Signature.java + test/java/security/Signature/SignatureGetAlgorithm.java Changeset: 989049977d04 Author: rfield Date: 2013-06-17 20:31 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/989049977d04 8015402: Lambda metafactory should not attempt to determine bridge methods Summary: paired with 8013789: Compiler should emit bridges in interfaces Reviewed-by: twisti ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java Changeset: 017819b78eab Author: wmdietl Date: 2013-06-18 00:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/017819b78eab Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk ! .hgtags ! src/share/classes/java/lang/Class.java From wdietl at gmail.com Tue Jun 18 14:03:28 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 21:03:28 +0000 Subject: hg: type-annotations/type-annotations/langtools: 17 new changesets Message-ID: <20130618210429.6DF1E482D3@hg.openjdk.java.net> Changeset: e701af23a095 Author: vromero Date: 2013-06-18 18:57 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e701af23a095 8016607: javac, avoid analyzing lambdas for source 7 compilation Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java Changeset: 9851071b551a Author: vromero Date: 2013-06-18 19:02 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/9851071b551a 8016267: javac, TypeTag refactoring has provoked performance issues Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java Changeset: 4d4818b6df72 Author: chegar Date: 2013-04-24 11:03 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/4d4818b6df72 Merge Changeset: 27cda5134748 Author: chegar Date: 2013-04-28 08:16 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/27cda5134748 Merge Changeset: c7c6bfe7fc1f Author: bpatel Date: 2013-05-03 08:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/c7c6bfe7fc1f 8012375: Improve Javadoc framing Reviewed-by: mduigou, jlaskey ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java Changeset: 8074ccd57d89 Author: chegar Date: 2013-05-08 10:27 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/8074ccd57d89 Merge Changeset: 9d7d36e6927c Author: chegar Date: 2013-05-08 10:28 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/9d7d36e6927c Merge Changeset: 7ee1fd365cdd Author: chegar Date: 2013-05-16 11:42 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/7ee1fd365cdd Merge Changeset: f1b90ea7d402 Author: chegar Date: 2013-05-23 12:50 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/f1b90ea7d402 Merge - src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ExpertTaglet.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java - src/share/classes/javax/tools/annotation/GenerateNativeHeader.java - test/tools/javac/nativeHeaders/javahComparison/TestClass2.java - test/tools/javac/nativeHeaders/javahComparison/TestClass3.java Changeset: 76d08c649607 Author: chegar Date: 2013-05-31 10:28 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/76d08c649607 Merge Changeset: 536cad596942 Author: bpatel Date: 2013-06-07 16:12 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/536cad596942 8015997: Additional improvement in Javadoc framing Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java Changeset: da8d0ee0938e Author: chegar Date: 2013-06-10 09:52 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/da8d0ee0938e Merge - test/tools/javac/HiddenAbstractMethod/Test - test/tools/javac/NonAmbiguousField/Test Changeset: cc89c8333127 Author: chegar Date: 2013-06-11 09:25 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/cc89c8333127 Merge Changeset: 31e1151ef3cc Author: chegar Date: 2013-06-17 11:27 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/31e1151ef3cc Merge Changeset: db6bf740a578 Author: chegar Date: 2013-06-18 09:36 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/db6bf740a578 Merge Changeset: 64f511787fd9 Author: chegar Date: 2013-06-18 20:08 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/64f511787fd9 Merge Changeset: 0c4bf81f12b1 Author: wmdietl Date: 2013-06-18 14:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/0c4bf81f12b1 Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java From wdietl at gmail.com Tue Jun 18 14:20:21 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 21:20:21 +0000 Subject: hg: type-annotations/type-annotations/corba: 10 new changesets Message-ID: <20130618212029.359E2482DA@hg.openjdk.java.net> Changeset: 39d15bbb5741 Author: coffeys Date: 2013-04-08 23:12 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/39d15bbb5741 8001032: Restrict object access Summary: Restrict object access; fix reviewed also by Alexander Fomin Reviewed-by: alanb, ahgross ! make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk ! src/share/classes/com/sun/corba/se/impl/activation/ServerManagerImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/PIHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/interceptors/RequestInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/io/ValueUtility.java ! src/share/classes/com/sun/corba/se/impl/javax/rmi/CORBA/Util.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBDataParserImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/ParserTable.java - src/share/classes/com/sun/corba/se/impl/orbutil/ORBClassLoader.java ! src/share/classes/com/sun/corba/se/impl/orbutil/ORBUtility.java ! src/share/classes/com/sun/corba/se/impl/protocol/giopmsgheaders/LocateReplyMessage_1_2.java ! src/share/classes/com/sun/corba/se/impl/protocol/giopmsgheaders/MessageBase.java ! src/share/classes/com/sun/corba/se/impl/protocol/giopmsgheaders/ReplyMessage_1_0.java ! src/share/classes/com/sun/corba/se/impl/protocol/giopmsgheaders/ReplyMessage_1_1.java ! src/share/classes/com/sun/corba/se/spi/orb/ORB.java ! src/share/classes/com/sun/corba/se/spi/orb/OperationFactory.java ! src/share/classes/sun/corba/JavaCorbaAccess.java Changeset: 978818df41b9 Author: chegar Date: 2013-04-24 10:17 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/978818df41b9 Merge Changeset: 68d407e4d204 Author: chegar Date: 2013-04-28 08:15 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/68d407e4d204 Merge Changeset: 80161c61aa68 Author: coffeys Date: 2013-04-30 11:53 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/80161c61aa68 8000642: Better handling of objects for transportation Reviewed-by: alanb, mchung, skoivu ! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java ! src/share/classes/com/sun/corba/se/impl/corba/TypeCodeImpl.java ! src/share/classes/com/sun/corba/se/impl/encoding/IDLJavaSerializationOutputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/TypeCodeOutputStream.java ! src/share/classes/com/sun/corba/se/impl/interceptors/CDREncapsCodec.java ! src/share/classes/com/sun/corba/se/impl/interceptors/RequestInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java ! src/share/classes/com/sun/corba/se/impl/io/IIOPOutputStream.java ! src/share/classes/com/sun/corba/se/impl/io/InputStreamHook.java ! src/share/classes/com/sun/corba/se/impl/io/OutputStreamHook.java ! src/share/classes/com/sun/corba/se/impl/ior/EncapsulationUtility.java ! src/share/classes/com/sun/corba/se/impl/ior/GenericTaggedProfile.java ! src/share/classes/com/sun/corba/se/impl/ior/IORImpl.java ! src/share/classes/com/sun/corba/se/impl/ior/ObjectKeyImpl.java ! src/share/classes/com/sun/corba/se/impl/ior/TaggedComponentFactoryFinderImpl.java ! src/share/classes/com/sun/corba/se/impl/ior/iiop/IIOPProfileImpl.java ! src/share/classes/com/sun/corba/se/impl/ior/iiop/IIOPProfileTemplateImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/ORBSingleton.java ! src/share/classes/com/sun/corba/se/impl/protocol/CorbaMessageMediatorImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/CorbaContactInfoBase.java ! src/share/classes/com/sun/corba/se/impl/transport/SharedCDRContactInfoImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/SocketOrChannelAcceptorImpl.java ! src/share/classes/com/sun/corba/se/impl/transport/SocketOrChannelConnectionImpl.java ! src/share/classes/com/sun/corba/se/spi/ior/TaggedComponentBase.java ! src/share/classes/com/sun/corba/se/spi/servicecontext/ServiceContext.java ! src/share/classes/org/omg/CORBA_2_3/portable/OutputStream.java + src/share/classes/sun/corba/OutputStreamFactory.java Changeset: 4fe1edbec7bc Author: chegar Date: 2013-05-08 10:09 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/4fe1edbec7bc Merge Changeset: e9c924d3475c Author: chegar Date: 2013-05-16 11:39 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/e9c924d3475c Merge Changeset: 216cb38dce0a Author: chegar Date: 2013-05-23 12:41 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/216cb38dce0a Merge Changeset: 25e68d232c20 Author: chegar Date: 2013-05-31 10:26 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/25e68d232c20 Merge Changeset: c1f80e733eb0 Author: chegar Date: 2013-06-17 11:11 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/c1f80e733eb0 Merge ! src/share/classes/com/sun/corba/se/impl/orb/ParserTable.java Changeset: c29bab588f63 Author: wmdietl Date: 2013-06-18 14:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/c29bab588f63 Automated merge with http://hg.openjdk.java.net/jdk8/tl/corba From wdietl at gmail.com Tue Jun 18 14:21:28 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 21:21:28 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 10 new changesets Message-ID: <20130618212155.3F37E482DB@hg.openjdk.java.net> Changeset: f14f72174f00 Author: chegar Date: 2013-04-24 10:18 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/f14f72174f00 Merge Changeset: b225607e056b Author: chegar Date: 2013-04-28 08:15 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/b225607e056b Merge Changeset: 5b7a22859380 Author: chegar Date: 2013-05-08 10:10 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/5b7a22859380 Merge Changeset: 96223058c269 Author: chegar Date: 2013-05-16 11:41 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/96223058c269 Merge Changeset: ed115f7cc6d0 Author: chegar Date: 2013-05-23 12:44 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/ed115f7cc6d0 Merge Changeset: 231034c73ed5 Author: chegar Date: 2013-05-31 10:27 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/231034c73ed5 Merge Changeset: f8f257062d53 Author: chegar Date: 2013-06-10 09:51 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/f8f257062d53 Merge - src/com/sun/org/apache/xalan/META-INF/services/javax.xml.transform.TransformerFactory - src/com/sun/org/apache/xalan/META-INF/services/javax.xml.xpath.XPathFactory - src/com/sun/org/apache/xalan/META-INF/services/org.apache.xml.dtm.DTMManager - src/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java - src/com/sun/org/apache/xml/internal/serialize/ObjectFactory.java Changeset: ec38586b8bf3 Author: chegar Date: 2013-06-17 11:18 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/ec38586b8bf3 Merge Changeset: 1c5e3ae28f81 Author: chegar Date: 2013-06-18 09:36 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/1c5e3ae28f81 Merge Changeset: 9a3df631bc12 Author: wmdietl Date: 2013-06-18 14:21 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/9a3df631bc12 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxp From wdietl at gmail.com Tue Jun 18 14:08:57 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 21:08:57 +0000 Subject: hg: type-annotations/type-annotations/jdk: 96 new changesets Message-ID: <20130618212831.DDF88482DC@hg.openjdk.java.net> Changeset: 956b00d7d4ea Author: uta Date: 2013-06-18 17:19 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/956b00d7d4ea 8016046: (process) Strict validation of input should be security manager case only [win]. Reviewed-by: alanb, ahgross ! src/windows/classes/java/lang/ProcessImpl.java ! test/java/lang/Runtime/exec/ExecCommand.java Changeset: 3c36782f5129 Author: bae Date: 2013-02-27 12:10 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3c36782f5129 8001034: Memory management improvements Reviewed-by: mschoene, prr, jgodinez ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_GraphicsEnv.h ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c Changeset: b4a306969af5 Author: alanb Date: 2013-02-27 11:44 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b4a306969af5 8004288: (fs) Files.probeContentType problems Reviewed-by: ahgross, sherman ! src/share/classes/java/nio/file/Files.java ! src/solaris/classes/sun/nio/fs/GnomeFileTypeDetector.java Changeset: ecf85457671a Author: dmocek Date: 2013-03-04 14:34 -0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ecf85457671a 8000638: Improve deserialization Reviewed-by: smarks, hawtin, mchung ! src/share/classes/java/io/ObjectStreamClass.java Changeset: 1bd2a0bb583e Author: jbachorik Date: 2013-03-07 14:05 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1bd2a0bb583e 8008603: Improve provision of JMX providers Reviewed-by: alanb, dfuchs, jfdenise, skoivu ! src/share/classes/javax/management/remote/JMXConnectorFactory.java Changeset: 711d544b2319 Author: jbachorik Date: 2013-03-12 09:34 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/711d544b2319 8009038: Improve JMX notification support Summary: Disallowing access to mutable shared arrays Reviewed-by: dfuchs, mchung, skoivu ! src/share/classes/javax/management/StandardEmitterMBean.java Changeset: 363547f54176 Author: jbachorik Date: 2013-03-12 11:09 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/363547f54176 8009034: Improve resulting notifications in JMX Summary: Disallowing access to mutable shared arrays Reviewed-by: dfuchs, mchung, skoivu ! src/share/classes/javax/management/remote/NotificationResult.java Changeset: 9114ea4791ec Author: jbachorik Date: 2013-03-14 14:42 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9114ea4791ec 8008585: Better JMX data handling Reviewed-by: alanb, dfuchs, jfdenise, skoivu, sjiang ! src/share/classes/javax/management/remote/JMXConnectorFactory.java Changeset: 200ae4b8f192 Author: jbachorik Date: 2013-03-14 14:45 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/200ae4b8f192 8008607: Better input checking in JMX Reviewed-by: dfuchs, mchung, skoivu, sjiang ! src/share/classes/com/sun/jmx/mbeanserver/MBeanIntrospector.java Changeset: a65111ce1ed7 Author: khazra Date: 2013-03-14 13:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a65111ce1ed7 7170730: Improve Windows network stack support. Summary: Enable exclusive binding of ports on Windows Reviewed-by: alanb, chegar, ahgross ! make/java/nio/mapfile-bsd ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! makefiles/mapfiles/libnio/mapfile-linux ! makefiles/mapfiles/libnio/mapfile-macosx ! makefiles/mapfiles/libnio/mapfile-solaris ! src/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/solaris/native/sun/nio/ch/Net.c ! src/windows/classes/java/net/DefaultDatagramSocketImplFactory.java ! src/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java ! src/windows/classes/java/net/DualStackPlainSocketImpl.java ! src/windows/classes/java/net/PlainSocketImpl.java ! src/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java ! src/windows/classes/java/net/TwoStacksPlainSocketImpl.java ! src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c ! src/windows/native/java/net/DualStackPlainSocketImpl.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c ! src/windows/native/java/net/net_util_md.c ! src/windows/native/java/net/net_util_md.h ! src/windows/native/sun/nio/ch/Net.c Changeset: 30f15138e298 Author: dmocek Date: 2013-03-13 17:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/30f15138e298 8001033: Refactor network address handling in virtual machine identifiers Reviewed-by: smarks, hawtin, mchung ! src/share/classes/java/rmi/dgc/VMID.java Changeset: 9f99c9ab588b Author: jgodinez Date: 2013-03-15 12:31 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9f99c9ab588b 8007927: Improve cmsAllocProfileSequenceDescription Reviewed-by: bae, mschoene, prr Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/java2d/cmm/lcms/cmsnamed.c Changeset: bf7120252a95 Author: jbachorik Date: 2013-03-18 11:17 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bf7120252a95 8009996: tests javax/management/mxbean/MiscTest.java and javax/management/mxbean/StandardMBeanOverrideTest.java fail Reviewed-by: dfuchs, dholmes ! src/share/classes/javax/management/StandardEmitterMBean.java Changeset: 59ced5cf8344 Author: dfuchs Date: 2013-03-18 11:55 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/59ced5cf8344 8001043: Clarify definition restrictions Reviewed-by: alanb, skoivu, smarks ! src/share/classes/sun/rmi/server/LoaderHandler.java Changeset: 810688020f65 Author: sla Date: 2013-03-19 13:26 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/810688020f65 8003703: Update RMI connection dialog box Reviewed-by: skoivu, ahgross, mchung, jbachorik ! src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/ProxyClient.java ! src/share/classes/sun/tools/jconsole/VMPanel.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties Changeset: 8b4c3e09b29a Author: jgodinez Date: 2013-03-19 14:29 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8b4c3e09b29a 8009013: Better handling of T2K glyphs Reviewed-by: bae, mschoene, prr Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/font/freetypeScaler.c Changeset: dd60654d4a8b Author: darcy Date: 2013-03-19 14:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/dd60654d4a8b 8001309: Better handling of annotation interfaces Reviewed-by: ahgross, smarks, alanb ! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java Changeset: b412e6128726 Author: jgodinez Date: 2013-03-20 10:12 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b412e6128726 8007929: Improve CurvesAlloc Reviewed-by: bae, mschoene, prr Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/java2d/cmm/lcms/cmsopt.c Changeset: cfea7f72cbcd Author: khazra Date: 2013-03-20 11:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cfea7f72cbcd 8010213: Some api/javax_net/SocketFactory tests fail in 7u25 nightly build Summary: Eliminate fall-through while setting socket options on Windows Reviewed-by: alanb, chegar ! src/windows/classes/java/net/DualStackPlainSocketImpl.java Changeset: 711187756b9e Author: leonidr Date: 2013-03-21 02:13 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/711187756b9e 8004584: Augment applet contextualization Summary: Do not create the main AppContext for applets Reviewed-by: art, ahgross ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/sun/applet/AppletSecurity.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/SunToolkit.java Changeset: 9d6d7886a74c Author: jbachorik Date: 2013-03-21 09:26 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9d6d7886a74c 8008623: Better handling of MBeanServers Reviewed-by: dfuchs, dholmes, skoivu ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/com/sun/jmx/mbeanserver/JmxMBeanServer.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java Changeset: 9bcf9c9cb73d Author: vinnie Date: 2013-03-21 12:14 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9bcf9c9cb73d 8009067: Improve storing keys in KeyStore Reviewed-by: mullan, skoivu ! src/share/classes/java/security/KeyStore.java Changeset: 434e0155180c Author: jfdenise Date: 2013-03-26 09:12 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/434e0155180c 8009004: Better implementation of RMI connections Summary: Better class handling. Reviewed-by: alanb, dfuchs, skoivu, jbachorik Contributed-by: jean-francois.denise at oracle.com ! src/share/classes/com/sun/jmx/remote/util/OrderClassLoaders.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java Changeset: 72fac19dad5c Author: sjiang Date: 2013-03-26 08:32 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/72fac19dad5c 8008615: Improve robustness of JMX internal APIs Reviewed-by: dfuchs, skoivu, dholmes ! src/share/classes/com/sun/jmx/mbeanserver/ObjectInputStreamWithLoader.java ! src/share/classes/javax/management/MBeanServerFactory.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java Changeset: 27d79fbadda1 Author: jfdenise Date: 2013-03-27 09:59 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/27d79fbadda1 8008128: Better API coherence for JMX Summary: Permission for getting classloader Reviewed-by: alanb, dfuchs, skoivu Contributed-by: jean-francois.denise at oracle.com ! src/share/classes/com/sun/jmx/mbeanserver/ClassLoaderRepositorySupport.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java Changeset: 311f16954ada Author: jbachorik Date: 2013-03-27 13:29 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/311f16954ada 8010209: Better provision of factories Reviewed-by: dcubed, ahgross ! src/share/classes/sun/tracing/ProviderSkeleton.java ! src/share/classes/sun/tracing/dtrace/DTraceProvider.java Changeset: 185cbf454f51 Author: jgodinez Date: 2013-03-27 11:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/185cbf454f51 8009654: Improve stability of cmsnamed Reviewed-by: bae, mschoene, prr Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/java2d/cmm/lcms/cmsnamed.c Changeset: c193b7431ea6 Author: jgodinez Date: 2013-03-27 15:58 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c193b7431ea6 8007925: Improve cmsStageAllocLabV2ToV4curves 8007926: Improve cmsPipelineDup Reviewed-by: bae, mschoene, prr Contributed-by: jia-hong.chen at oracle.com ! src/share/native/sun/java2d/cmm/lcms/cmslut.c Changeset: 9137e1efe9fd Author: lancea Date: 2013-03-28 06:55 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9137e1efe9fd 8009554: Improve SerialJavaObject.getFields Reviewed-by: alanb, skoivu, mchung ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java Changeset: 7067e2e493e5 Author: khazra Date: 2013-03-28 14:34 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7067e2e493e5 8001318: Socket.getLocalAddress not consistent with InetAddress.getLocalHost Reviewed-by: alanb, chegar, hawtin ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/nio/channels/AsynchronousServerSocketChannel.java ! src/share/classes/java/nio/channels/AsynchronousSocketChannel.java ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/java/nio/channels/NetworkChannel.java ! src/share/classes/java/nio/channels/ServerSocketChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/ftp/impl/FtpClient.java ! src/share/classes/sun/net/httpserver/ServerImpl.java ! src/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/rmi/server/Activation.java ! src/share/classes/sun/rmi/transport/proxy/WrappedSocket.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpNet.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java Changeset: d0ba983c0e70 Author: jbachorik Date: 2013-03-28 09:39 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d0ba983c0e70 8008982: Adjust JMX for underlying interface changes Reviewed-by: mchung, dholmes, dfuchs, skoivu ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanServerInvocationHandler.java Changeset: 2db5b7f6aa66 Author: jgodinez Date: 2013-03-29 10:01 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2db5b7f6aa66 8001038: Resourcefully handle resources Reviewed-by: prr, bae Contributed-by: jia-hong.chen at oracle.com ! src/share/classes/java/awt/Font.java ! src/share/classes/sun/font/CreatedFontTracker.java Changeset: d6f0cbba0b8a Author: serb Date: 2013-03-29 22:07 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d6f0cbba0b8a 8006328: Improve robustness of sound classes 8009057: Improve MIDI event handling Reviewed-by: amenkov, art, skoivu ! src/share/classes/com/sun/media/sound/AbstractDataLine.java ! src/share/classes/com/sun/media/sound/AbstractLine.java ! src/share/classes/com/sun/media/sound/AbstractMidiDevice.java ! src/share/classes/com/sun/media/sound/AbstractMidiDeviceProvider.java ! src/share/classes/com/sun/media/sound/AbstractMixer.java ! src/share/classes/com/sun/media/sound/AiffFileFormat.java ! src/share/classes/com/sun/media/sound/AiffFileReader.java ! src/share/classes/com/sun/media/sound/AiffFileWriter.java ! src/share/classes/com/sun/media/sound/AlawCodec.java ! src/share/classes/com/sun/media/sound/AuFileFormat.java ! src/share/classes/com/sun/media/sound/AuFileReader.java ! src/share/classes/com/sun/media/sound/AuFileWriter.java ! src/share/classes/com/sun/media/sound/AudioFileSoundbankReader.java ! src/share/classes/com/sun/media/sound/AudioFloatConverter.java ! src/share/classes/com/sun/media/sound/AudioFloatFormatConverter.java ! src/share/classes/com/sun/media/sound/AudioFloatInputStream.java ! src/share/classes/com/sun/media/sound/AudioSynthesizerPropertyInfo.java ! src/share/classes/com/sun/media/sound/DLSInfo.java ! src/share/classes/com/sun/media/sound/DLSInstrument.java ! src/share/classes/com/sun/media/sound/DLSModulator.java ! src/share/classes/com/sun/media/sound/DLSRegion.java ! src/share/classes/com/sun/media/sound/DLSSample.java ! src/share/classes/com/sun/media/sound/DLSSampleLoop.java ! src/share/classes/com/sun/media/sound/DLSSampleOptions.java ! src/share/classes/com/sun/media/sound/DLSSoundbank.java ! src/share/classes/com/sun/media/sound/DLSSoundbankReader.java ! src/share/classes/com/sun/media/sound/DataPusher.java ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/share/classes/com/sun/media/sound/DirectAudioDeviceProvider.java ! src/share/classes/com/sun/media/sound/EmergencySoundbank.java ! src/share/classes/com/sun/media/sound/EventDispatcher.java ! src/share/classes/com/sun/media/sound/FFT.java ! src/share/classes/com/sun/media/sound/FastShortMessage.java ! src/share/classes/com/sun/media/sound/JARSoundbankReader.java ! src/share/classes/com/sun/media/sound/JDK13Services.java ! src/share/classes/com/sun/media/sound/JSSecurityManager.java ! src/share/classes/com/sun/media/sound/JavaSoundAudioClip.java ! src/share/classes/com/sun/media/sound/MidiDeviceReceiverEnvelope.java ! src/share/classes/com/sun/media/sound/MidiDeviceTransmitterEnvelope.java ! src/share/classes/com/sun/media/sound/MidiInDevice.java ! src/share/classes/com/sun/media/sound/MidiInDeviceProvider.java ! src/share/classes/com/sun/media/sound/MidiOutDevice.java ! src/share/classes/com/sun/media/sound/MidiOutDeviceProvider.java ! src/share/classes/com/sun/media/sound/MidiUtils.java ! src/share/classes/com/sun/media/sound/ModelByteBuffer.java ! src/share/classes/com/sun/media/sound/ModelByteBufferWavetable.java ! src/share/classes/com/sun/media/sound/ModelConnectionBlock.java ! src/share/classes/com/sun/media/sound/ModelDestination.java ! src/share/classes/com/sun/media/sound/ModelIdentifier.java ! src/share/classes/com/sun/media/sound/ModelInstrument.java ! src/share/classes/com/sun/media/sound/ModelInstrumentComparator.java ! src/share/classes/com/sun/media/sound/ModelMappedInstrument.java ! src/share/classes/com/sun/media/sound/ModelPatch.java ! src/share/classes/com/sun/media/sound/ModelPerformer.java ! src/share/classes/com/sun/media/sound/ModelSource.java ! src/share/classes/com/sun/media/sound/ModelStandardDirector.java ! src/share/classes/com/sun/media/sound/ModelStandardIndexedDirector.java ! src/share/classes/com/sun/media/sound/ModelStandardTransform.java ! src/share/classes/com/sun/media/sound/PCMtoPCMCodec.java ! src/share/classes/com/sun/media/sound/Platform.java ! src/share/classes/com/sun/media/sound/PortMixer.java ! src/share/classes/com/sun/media/sound/PortMixerProvider.java ! src/share/classes/com/sun/media/sound/Printer.java ! src/share/classes/com/sun/media/sound/RIFFInvalidDataException.java ! src/share/classes/com/sun/media/sound/RIFFInvalidFormatException.java ! src/share/classes/com/sun/media/sound/RIFFReader.java ! src/share/classes/com/sun/media/sound/RIFFWriter.java ! src/share/classes/com/sun/media/sound/RealTimeSequencer.java ! src/share/classes/com/sun/media/sound/RealTimeSequencerProvider.java ! src/share/classes/com/sun/media/sound/SF2GlobalRegion.java ! src/share/classes/com/sun/media/sound/SF2Instrument.java ! src/share/classes/com/sun/media/sound/SF2InstrumentRegion.java ! src/share/classes/com/sun/media/sound/SF2Layer.java ! src/share/classes/com/sun/media/sound/SF2LayerRegion.java ! src/share/classes/com/sun/media/sound/SF2Modulator.java ! src/share/classes/com/sun/media/sound/SF2Sample.java ! src/share/classes/com/sun/media/sound/SF2Soundbank.java ! src/share/classes/com/sun/media/sound/SF2SoundbankReader.java ! src/share/classes/com/sun/media/sound/SoftAbstractResampler.java ! src/share/classes/com/sun/media/sound/SoftAudioBuffer.java ! src/share/classes/com/sun/media/sound/SoftAudioPusher.java ! src/share/classes/com/sun/media/sound/SoftChannel.java ! src/share/classes/com/sun/media/sound/SoftChannelProxy.java ! src/share/classes/com/sun/media/sound/SoftChorus.java ! src/share/classes/com/sun/media/sound/SoftCubicResampler.java ! src/share/classes/com/sun/media/sound/SoftEnvelopeGenerator.java ! src/share/classes/com/sun/media/sound/SoftFilter.java ! src/share/classes/com/sun/media/sound/SoftInstrument.java ! src/share/classes/com/sun/media/sound/SoftJitterCorrector.java ! src/share/classes/com/sun/media/sound/SoftLanczosResampler.java ! src/share/classes/com/sun/media/sound/SoftLimiter.java ! src/share/classes/com/sun/media/sound/SoftLinearResampler.java ! src/share/classes/com/sun/media/sound/SoftLinearResampler2.java ! src/share/classes/com/sun/media/sound/SoftLowFrequencyOscillator.java ! src/share/classes/com/sun/media/sound/SoftMainMixer.java ! src/share/classes/com/sun/media/sound/SoftMidiAudioFileReader.java ! src/share/classes/com/sun/media/sound/SoftMixingClip.java ! src/share/classes/com/sun/media/sound/SoftMixingDataLine.java ! src/share/classes/com/sun/media/sound/SoftMixingMainMixer.java ! src/share/classes/com/sun/media/sound/SoftMixingMixer.java ! src/share/classes/com/sun/media/sound/SoftMixingMixerProvider.java ! src/share/classes/com/sun/media/sound/SoftMixingSourceDataLine.java ! src/share/classes/com/sun/media/sound/SoftPerformer.java ! src/share/classes/com/sun/media/sound/SoftPointResampler.java ! src/share/classes/com/sun/media/sound/SoftProvider.java ! src/share/classes/com/sun/media/sound/SoftReceiver.java ! src/share/classes/com/sun/media/sound/SoftReverb.java ! src/share/classes/com/sun/media/sound/SoftShortMessage.java ! src/share/classes/com/sun/media/sound/SoftSincResampler.java ! src/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/share/classes/com/sun/media/sound/SoftTuning.java ! src/share/classes/com/sun/media/sound/SoftVoice.java ! src/share/classes/com/sun/media/sound/StandardMidiFileReader.java ! src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java ! src/share/classes/com/sun/media/sound/SunCodec.java ! src/share/classes/com/sun/media/sound/SunFileReader.java ! src/share/classes/com/sun/media/sound/SunFileWriter.java ! src/share/classes/com/sun/media/sound/Toolkit.java ! src/share/classes/com/sun/media/sound/UlawCodec.java ! src/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java ! src/share/classes/com/sun/media/sound/WaveFileFormat.java ! src/share/classes/com/sun/media/sound/WaveFileReader.java ! src/share/classes/com/sun/media/sound/WaveFileWriter.java ! src/share/classes/com/sun/media/sound/WaveFloatFileReader.java ! src/share/classes/com/sun/media/sound/WaveFloatFileWriter.java ! src/share/classes/javax/sound/midi/MetaMessage.java ! src/share/classes/javax/sound/sampled/Mixer.java ! src/share/classes/sun/audio/AudioData.java ! src/share/classes/sun/audio/AudioDataStream.java ! src/share/classes/sun/audio/AudioDevice.java ! src/share/classes/sun/audio/AudioPlayer.java ! src/share/classes/sun/audio/AudioStream.java ! src/share/classes/sun/audio/AudioStreamSequence.java ! src/share/classes/sun/audio/AudioTranslatorStream.java ! src/share/classes/sun/audio/ContinuousAudioDataStream.java ! src/share/classes/sun/audio/InvalidAudioFormatException.java Changeset: 2eac60e99307 Author: dsamersoff Date: 2013-03-31 22:00 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2eac60e99307 8007471: Improve MBean notifications Summary: Improve MBean notifications Reviewed-by: dfuchs, mchung, alanb, skoivu ! src/share/classes/com/sun/jmx/remote/internal/ArrayNotificationBuffer.java ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java Changeset: 107f21efda78 Author: dsamersoff Date: 2013-03-31 22:59 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/107f21efda78 8008120: Improve JMX class checking Summary: Improve JMX class checking Reviewed-by: mchung, dfuchs, alanb, skoivu ! src/share/classes/javax/management/relation/RelationNotification.java Changeset: 0bddd4e8bfb6 Author: dsamersoff Date: 2013-03-31 23:47 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0bddd4e8bfb6 8008124: Better compliance testing Summary: Better compliance testing Reviewed-by: dfuchs, jfdenise, skoivu, alanb ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java Changeset: 0d36b1e3e509 Author: prr Date: 2013-04-01 09:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0d36b1e3e509 8005007: Better glyph processing Reviewed-by: srl, mschoene, bae ! src/share/classes/sun/font/ExtendedTextSourceLabel.java ! src/share/native/sun/font/layout/LEGlyphStorage.cpp ! src/share/native/sun/font/layout/LookupProcessor.cpp Changeset: 4224b02452f5 Author: sjiang Date: 2013-04-02 10:38 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4224b02452f5 8007467: Better JMX type conversion Reviewed-by: dfuchs, mchung, skoivu ! src/share/classes/com/sun/jmx/mbeanserver/ConvertingMethod.java ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/StandardMBeanIntrospector.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java Changeset: 5ae5c4120014 Author: egahlin Date: 2013-03-21 13:56 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5ae5c4120014 8008611: Better handling of annotations in JMX Reviewed-by: skoivu, dholmes, jfdenise ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java Changeset: 802f5e480c8a Author: mullan Date: 2013-04-05 10:17 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/802f5e480c8a 8001330: Improve on checking order Reviewed-by: acorn, hawtin ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/AccessController.java ! src/share/classes/java/security/ProtectionDomain.java Changeset: e5969bf37f26 Author: chegar Date: 2013-04-08 06:15 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e5969bf37f26 8008593: Better URLClassLoader resource management Reviewed-by: alanb, sherman, hawtin ! make/java/zip/mapfile-vers ! make/java/zip/reorder-i586 ! make/java/zip/reorder-sparc ! make/java/zip/reorder-sparcv9 ! makefiles/mapfiles/libzip/mapfile-vers ! makefiles/mapfiles/libzip/reorder-sparc ! makefiles/mapfiles/libzip/reorder-sparcv9 ! makefiles/mapfiles/libzip/reorder-x86 ! src/share/classes/java/util/zip/ZipFile.java + src/share/classes/sun/misc/JavaUtilZipFileAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/misc/URLClassPath.java ! src/share/native/java/util/zip/ZipFile.c ! src/share/native/java/util/zip/zip_util.c ! src/share/native/java/util/zip/zip_util.h Changeset: 6f75b365af19 Author: vinnie Date: 2013-04-08 21:12 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6f75b365af19 8009235: Improve handling of TSA data Reviewed-by: ahgross, mullan ! src/share/classes/sun/security/pkcs/SignerInfo.java ! src/share/classes/sun/security/timestamp/TimestampToken.java Changeset: 5496abfc666a Author: prr Date: 2013-04-08 13:29 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5496abfc666a 8011248: Better Component Rasters Reviewed-by: bae, vadim, mschoene ! src/share/classes/sun/awt/image/IntegerComponentRaster.java Changeset: 761e0002dcfe Author: prr Date: 2013-04-08 13:32 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/761e0002dcfe 8011253: Better Short Component Rasters Reviewed-by: bae, vadim, mschoene ! src/share/classes/sun/awt/image/ShortBandedRaster.java ! src/share/classes/sun/awt/image/ShortComponentRaster.java Changeset: 1adc1051f2d3 Author: prr Date: 2013-04-08 13:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1adc1051f2d3 8011257: Better Byte Component Rasters Reviewed-by: bae, vadim, mschoene ! src/share/classes/sun/awt/image/ByteBandedRaster.java ! src/share/classes/sun/awt/image/ByteComponentRaster.java Changeset: eafd52d53f09 Author: bae Date: 2013-04-10 15:55 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/eafd52d53f09 8011243: Improve ImagingLib Reviewed-by: prr, vadim ! src/share/native/sun/awt/medialib/awt_ImagingLib.c ! src/share/native/sun/awt/medialib/mlib_ImageCreate.c Changeset: fa42f0831e66 Author: bae Date: 2013-04-12 14:08 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fa42f0831e66 8011992: java/awt/image/mlib/MlibOpsTest.java failed since jdk7u25b05 Reviewed-by: vadim ! src/share/native/sun/awt/medialib/awt_ImagingLib.c ! test/java/awt/image/mlib/MlibOpsTest.java Changeset: bfe04328d394 Author: bae Date: 2013-04-15 14:11 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bfe04328d394 8012112: java/awt/image/mlib/MlibOpsTest.java fails on sparc solaris Reviewed-by: prr, vadim ! src/share/native/sun/awt/medialib/awt_ImagingLib.c ! test/java/awt/image/mlib/MlibOpsTest.java Changeset: 7d90e3e0a8ec Author: leonidr Date: 2013-04-16 21:19 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7d90e3e0a8ec 8011695: [tck-red] Application can not be run, the Security Warning dialog is gray. Summary: EventQueue shouldn't use AppContext.getAppContext() to obtain its AppContext. Reviewed-by: art ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/sun/awt/SunToolkit.java Changeset: cf14f699f36c Author: anthony Date: 2013-04-18 13:52 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cf14f699f36c 8009071: Improve shape handling Reviewed-by: art, mschoene ! src/macosx/native/sun/awt/CRobot.m ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/awt/splashscreen/splashscreen_sys.m + src/share/native/common/sizecalc.h ! src/share/native/sun/awt/splashscreen/java_awt_SplashScreen.c ! src/share/native/sun/awt/splashscreen/splashscreen_gif.c ! src/share/native/sun/java2d/pipe/Region.c ! src/solaris/native/sun/awt/awt_Robot.c ! src/solaris/native/sun/awt/awt_UNIXToolkit.c ! src/solaris/native/sun/awt/fontpath.c ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/splashscreen/splashscreen_sys.c ! src/solaris/native/sun/xawt/XlibWrapper.c ! src/windows/native/sun/awt/splashscreen/splashscreen_sys.c ! src/windows/native/sun/font/lcdglyph.c ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c ! src/windows/native/sun/java2d/windows/GDIBlitLoops.cpp ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp ! src/windows/native/sun/windows/CmdIDList.cpp ! src/windows/native/sun/windows/Devices.cpp ! src/windows/native/sun/windows/ShellFolder2.cpp ! src/windows/native/sun/windows/WPrinterJob.cpp ! src/windows/native/sun/windows/alloc.h ! src/windows/native/sun/windows/awt.h ! src/windows/native/sun/windows/awt_BitmapUtil.cpp ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Cursor.cpp ! src/windows/native/sun/windows/awt_DataTransferer.cpp ! src/windows/native/sun/windows/awt_DesktopProperties.cpp ! src/windows/native/sun/windows/awt_DnDDT.cpp ! src/windows/native/sun/windows/awt_InputMethod.cpp ! src/windows/native/sun/windows/awt_PrintControl.cpp ! src/windows/native/sun/windows/awt_PrintJob.cpp ! src/windows/native/sun/windows/awt_Robot.cpp Changeset: 4934254492af Author: sundar Date: 2013-04-19 11:43 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4934254492af 8006611: Improve scripting Reviewed-by: mchung ! src/share/classes/javax/script/ScriptEngineManager.java Changeset: a73ecb5085eb Author: jfranck Date: 2013-04-19 14:40 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a73ecb5085eb 8007812: (reflect) Class.getEnclosingMethod problematic for some classes Summary: Better checking in getEnclosing(Method|Constructor|Class) Reviewed-by: darcy, ahgross, mchung ! src/share/classes/java/lang/Class.java + test/lib/testlibrary/ClassFileInstaller.java Changeset: 15370008c68d Author: chegar Date: 2013-04-22 10:21 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/15370008c68d 8012692: SerialJavaObject.java should be CallerSensitive aware Reviewed-by: mchung ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java Changeset: ff3ac3680ffa Author: mchung Date: 2013-04-22 10:22 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ff3ac3680ffa 8012689: CallerSensitive annotation should not have CONSTRUCTOR Target Reviewed-by: chegar ! src/share/classes/sun/reflect/CallerSensitive.java Changeset: 783ed53bce0b Author: smarks Date: 2013-04-22 10:55 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/783ed53bce0b 8008132: Better serialization support Reviewed-by: alanb, hawtin ! src/share/classes/java/io/ObjectOutputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/io/ObjectStreamField.java Changeset: bb0ec4661eb8 Author: chegar Date: 2013-04-22 11:08 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bb0ec4661eb8 8012917: ObjectStreamClass and ObjectStreamField should be CallerSensitive aware Reviewed-by: mchung ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/io/ObjectStreamField.java Changeset: 10558009e439 Author: anthony Date: 2013-04-09 12:05 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/10558009e439 8011154: java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java failed since 7u25b03 on windows Reviewed-by: art, yan ! src/windows/native/sun/windows/awt_Component.cpp Changeset: 0f0ff6e9da05 Author: mullan Date: 2013-04-22 11:23 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0f0ff6e9da05 6741606: Integrate Apache Santuario Reviewed-by: vinnie, hawtin ! src/share/classes/com/sun/org/apache/xml/internal/security/Init.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/JCEMapper.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/Canonicalizer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/CanonicalizerSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RetrievalMethodResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/resource/xmlsecurity_en.properties ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignedInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInput.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transform.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transforms.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformBase64Decode.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformXSLT.java + src/share/classes/com/sun/org/apache/xml/internal/security/utils/ClassLoaderUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementProxy.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/I18n.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/ResourceResolverSpi.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverFragment.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverXPointer.java ! src/share/classes/javax/xml/crypto/dsig/dom/DOMValidateContext.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/javax/xml/crypto/dsig/GenerationTests.java ! test/javax/xml/crypto/dsig/SecurityManager/XMLDSigWithSecMgr.java ! test/javax/xml/crypto/dsig/ValidationTests.java Changeset: 72f55e763113 Author: leonidr Date: 2013-03-27 16:37 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/72f55e763113 8003559: Update display of applet windows Summary: Implemented applet security warning for OS X port Reviewed-by: art, anthony, serb, skoivu ! make/sun/awt/Makefile + make/sun/awt/ToBin.java ! make/sun/lwawt/FILES_export_macosx.gmk ! make/sun/xawt/Makefile - make/sun/xawt/ToBin.java ! makefiles/GenerateJavaSources.gmk ! makefiles/GensrcIcons.gmk ! makefiles/Tools.gmk + makefiles/sun/awt/ToBin.java - makefiles/sun/awt/X11/ToBin.java ! src/macosx/classes/sun/java2d/opengl/CGLLayer.java ! src/macosx/classes/sun/lwawt/LWKeyboardFocusManagerPeer.java ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java + src/macosx/classes/sun/lwawt/PlatformEventNotifier.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java + src/macosx/classes/sun/lwawt/SecurityWarningWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CTrayIcon.java ! src/macosx/classes/sun/lwawt/macosx/CViewPlatformEmbeddedFrame.java + src/macosx/classes/sun/lwawt/macosx/CWarningWindow.java ! src/macosx/classes/sun/lwawt/macosx/CWrapper.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/CWrapper.m + src/share/classes/sun/awt/IconInfo.java + src/share/classes/sun/awt/resources/security-icon-bw16.png + src/share/classes/sun/awt/resources/security-icon-bw24.png + src/share/classes/sun/awt/resources/security-icon-bw32.png + src/share/classes/sun/awt/resources/security-icon-bw48.png + src/share/classes/sun/awt/resources/security-icon-interim16.png + src/share/classes/sun/awt/resources/security-icon-interim24.png + src/share/classes/sun/awt/resources/security-icon-interim32.png + src/share/classes/sun/awt/resources/security-icon-interim48.png + src/share/classes/sun/awt/resources/security-icon-yellow16.png + src/share/classes/sun/awt/resources/security-icon-yellow24.png + src/share/classes/sun/awt/resources/security-icon-yellow32.png + src/share/classes/sun/awt/resources/security-icon-yellow48.png ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java - src/solaris/classes/sun/awt/X11/XIconInfo.java ! src/solaris/classes/sun/awt/X11/XIconWindow.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XWarningWindow.java ! src/solaris/classes/sun/awt/X11/XWindowAttributesData.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png Changeset: 31980806a21a Author: chegar Date: 2013-04-19 14:14 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/31980806a21a Merge - make/sun/xawt/ToBin.java ! makefiles/Tools.gmk - makefiles/sun/awt/X11/ToBin.java ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java - src/solaris/classes/sun/awt/X11/XIconInfo.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png Changeset: 7615af456906 Author: chegar Date: 2013-04-22 11:29 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7615af456906 Merge Changeset: d0dbbdbb217f Author: mchung Date: 2013-04-17 15:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d0dbbdbb217f 8011557: Improve reflection utility classes Reviewed-by: ahgross, alanb ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java Changeset: 25b69fbfe80f Author: chegar Date: 2013-04-23 11:13 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/25b69fbfe80f Merge ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/sun/security/timestamp/TimestampToken.java Changeset: 3197c702c8d1 Author: bae Date: 2013-04-24 21:15 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3197c702c8d1 8012438: Better image validation Reviewed-by: prr ! src/share/classes/java/awt/image/ComponentSampleModel.java ! src/share/classes/java/awt/image/PixelInterleavedSampleModel.java ! src/share/classes/java/awt/image/Raster.java ! src/share/classes/sun/awt/image/ByteBandedRaster.java ! src/share/classes/sun/awt/image/ByteComponentRaster.java ! src/share/classes/sun/awt/image/BytePackedRaster.java ! src/share/classes/sun/awt/image/IntegerComponentRaster.java ! src/share/classes/sun/awt/image/ShortBandedRaster.java ! src/share/classes/sun/awt/image/ShortComponentRaster.java ! src/share/native/sun/awt/medialib/awt_ImagingLib.c Changeset: 256ebcf1317b Author: chegar Date: 2013-04-28 09:35 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/256ebcf1317b Merge ! src/macosx/classes/sun/java2d/opengl/CGLLayer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/share/classes/sun/awt/SunToolkit.java - src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.PCMM ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XIconWindow.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: c3a08adee3ea Author: chegar Date: 2013-05-01 12:25 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c3a08adee3ea Merge Changeset: f1c0e2da008c Author: chegar Date: 2013-05-08 11:22 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f1c0e2da008c Merge ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java - src/share/classes/java/beans/ReflectionUtils.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/nio/file/Files.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java - test/java/awt/Focus/OverrideRedirectWindowActivationTest/OverrideRedirectWindowActivationTest.java - test/java/io/Serializable/accessConstants/AccessConstants.java - test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/sun/reflect/CallerSensitive/MethodFinder.java Changeset: b8102c2f6632 Author: chegar Date: 2013-05-16 11:47 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b8102c2f6632 Merge Changeset: 60a2184a71f2 Author: chegar Date: 2013-05-23 12:58 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/60a2184a71f2 Merge - make/com/sun/script/Makefile - make/sun/org/Makefile - make/sun/org/mozilla/Makefile - make/sun/org/mozilla/javascript/Makefile ! src/macosx/classes/sun/lwawt/LWToolkit.java - src/share/classes/com/sun/script/javascript/ExternalScriptable.java - src/share/classes/com/sun/script/javascript/JSAdapter.java - src/share/classes/com/sun/script/javascript/JavaAdapter.java - src/share/classes/com/sun/script/javascript/META-INF/services/javax.script.ScriptEngineFactory - src/share/classes/com/sun/script/javascript/RhinoClassShutter.java - src/share/classes/com/sun/script/javascript/RhinoCompiledScript.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngine.java - src/share/classes/com/sun/script/javascript/RhinoScriptEngineFactory.java - src/share/classes/com/sun/script/javascript/RhinoTopLevel.java - src/share/classes/com/sun/script/javascript/RhinoWrapFactory.java - src/share/classes/com/sun/script/util/BindingsBase.java - src/share/classes/com/sun/script/util/BindingsEntrySet.java - src/share/classes/com/sun/script/util/BindingsImpl.java - src/share/classes/com/sun/script/util/InterfaceImplementor.java - src/share/classes/com/sun/script/util/ScriptEngineFactoryBase.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java - src/share/classes/java/time/format/DateTimeFormatSymbols.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/sun/net/httpserver/ServerImpl.java - src/share/classes/sun/nio/cs/ext/META-INF/services/java.nio.charset.spi.CharsetProvider - test/java/lang/Thread/StackTraces.java - test/java/time/tck/java/time/format/TCKDateTimeFormatSymbols.java - test/java/time/test/java/time/format/TestDateTimeFormatSymbols.java - test/java/util/logging/bundlesearch/LoadItUp.java - test/sun/security/provider/certpath/X509CertPath/ForwardBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ReverseBuildCompromised.java - test/sun/security/provider/certpath/X509CertPath/ValidateCompromised.java Changeset: aa559d55fc4a Author: chegar Date: 2013-05-31 10:34 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/aa559d55fc4a Merge Changeset: 405cd7338069 Author: chegar Date: 2013-06-10 10:38 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/405cd7338069 Merge ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/AccessController.java ! src/share/classes/java/util/zip/ZipFile.java - src/share/classes/sun/misc/FDBigInt.java ! src/share/classes/sun/tools/jconsole/VMPanel.java ! src/share/classes/sun/tools/jconsole/resources/messages.properties ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! src/share/native/sun/java2d/cmm/lcms/cmslut.c ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_GraphicsEnv.h ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/xawt/XlibWrapper.c ! src/windows/native/java/net/DualStackPlainDatagramSocketImpl.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c - test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java Changeset: cd0140e5bee5 Author: prr Date: 2013-04-25 16:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cd0140e5bee5 8012421: Better positioning of PairPositioning Reviewed-by: srl, mschoene, vadim ! src/share/native/sun/font/layout/PairPositioningSubtables.cpp ! src/share/native/sun/font/layout/PairPositioningSubtables.h Changeset: 97149218a8ad Author: bae Date: 2013-04-26 11:46 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/97149218a8ad 8012601: Better validation of image layouts Reviewed-by: prr ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java Changeset: 40c65c6711ee Author: prr Date: 2013-04-26 15:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/40c65c6711ee 8012617: ArrayIndexOutOfBoundsException with some fonts using LineBreakMeasurer Reviewed-by: bae, srl ! src/share/classes/sun/font/ExtendedTextSourceLabel.java ! src/share/classes/sun/font/GlyphLayout.java ! src/share/native/sun/font/layout/ContextualSubstSubtables.cpp ! src/share/native/sun/font/layout/CursiveAttachmentSubtables.cpp ! src/share/native/sun/font/layout/ExtensionSubtables.cpp ! src/share/native/sun/font/layout/ExtensionSubtables.h ! src/share/native/sun/font/layout/GlyphPosnLookupProc.cpp ! src/share/native/sun/font/layout/GlyphSubstLookupProc.cpp ! src/share/native/sun/font/layout/LigatureSubstSubtables.cpp ! src/share/native/sun/font/layout/MarkToBasePosnSubtables.cpp ! src/share/native/sun/font/layout/MarkToLigaturePosnSubtables.cpp ! src/share/native/sun/font/layout/MarkToMarkPosnSubtables.cpp ! src/share/native/sun/font/layout/MultipleSubstSubtables.cpp ! src/share/native/sun/font/layout/PairPositioningSubtables.cpp ! src/share/native/sun/font/layout/SinglePositioningSubtables.cpp ! src/share/native/sun/font/layout/SingleSubstitutionSubtables.cpp ! src/share/native/sun/font/layout/SunLayoutEngine.cpp + test/java/awt/font/LineBreakMeasurer/AllFontsLBM.java Changeset: 30c8c83eeb70 Author: mullan Date: 2013-04-29 11:47 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/30c8c83eeb70 8009217: REGRESSION: test com/sun/org/apache/xml/internal/security/transforms/ClassLoaderTest.java fails to compile since 7u21b03 Reviewed-by: xuelei ! test/com/sun/org/apache/xml/internal/security/transforms/ClassLoaderTest.java ! test/com/sun/org/apache/xml/internal/security/transforms/MyTransform.java Changeset: 19af6fae7b98 Author: bae Date: 2013-04-30 04:41 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/19af6fae7b98 8012597: Better image channel verification Reviewed-by: vadim ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/native/sun/awt/image/awt_parseImage.c ! src/share/native/sun/awt/medialib/awt_ImagingLib.c Changeset: 1b86ce92dc2f Author: alexsch Date: 2013-04-30 13:55 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1b86ce92dc2f 8012330: [macosx] Sometimes the applet showing the modal dialog itself loses the ability to gain focus Reviewed-by: serb, ant ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java Changeset: d4c5b2792d55 Author: dfuchs Date: 2013-05-02 10:46 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d4c5b2792d55 8012243: about 30% regression on specjvm2008.serial on 7u25 comparing 7u21 Reviewed-by: alanb, skoivu, smarks, mchung ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/io/ObjectStreamField.java Changeset: e898a9e1404b Author: mullan Date: 2013-05-02 11:42 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e898a9e1404b 8008744: Rework part of fix for JDK-6741606 Reviewed-by: xuelei, ahgross + src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/ClassLoaderUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithm.java + src/share/classes/com/sun/org/apache/xml/internal/security/transforms/ClassLoaderUtils.java ! src/share/classes/com/sun/org/apache/xml/internal/security/transforms/Transform.java - src/share/classes/com/sun/org/apache/xml/internal/security/utils/ClassLoaderUtils.java Changeset: b3850bdca7f1 Author: leonidr Date: 2013-05-06 16:12 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b3850bdca7f1 8012933: Test closed/java/awt/Dialog/DialogAnotherThread/JaWSTest.java fails since jdk 7u25 b07 Summary: Do not mark context as disposed until we've posted all the events Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java + test/sun/awt/AppContext/8012933/Test8012933.java Changeset: fb7dc7c54145 Author: jfranck Date: 2013-05-07 13:23 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fb7dc7c54145 8011139: (reflect) Revise checking in getEnclosingClass Reviewed-by: darcy, mchung, ahgross ! src/share/classes/java/lang/Class.java Changeset: cefd77938a6c Author: twisti Date: 2013-05-08 12:09 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cefd77938a6c 8009424: Restrict publicLookup with additional checks Reviewed-by: vlivanov, jdn ! src/share/classes/java/lang/invoke/MethodHandles.java Changeset: 7f2fc413fb1d Author: coffeys Date: 2013-05-09 20:31 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7f2fc413fb1d 8013196: TimeZone.getDefault() throws NPE due to sun.awt.AppContext.getAppContext() Reviewed-by: mchung, okutsu ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/misc/SharedSecrets.java Changeset: 3948bdc62c34 Author: mullan Date: 2013-05-13 17:50 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3948bdc62c34 8010714: XML DSig API allows a RetrievalMethod to reference another RetrievalMethod Reviewed-by: xuelei, hawtin ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/KeyInfo.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Manifest.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/ObjectContainer.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/Reference.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignatureProperties.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/SignatureProperty.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInput.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementProxy.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/ApacheNodeSetData.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/Utils.java ! test/com/sun/org/apache/xml/internal/security/TruncateHMAC.java Changeset: 5d342b420db0 Author: xuelei Date: 2013-05-14 05:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5d342b420db0 8014281: Better checking of XML signature Summary: also reviewed by Andrew Gross and Christophe Ravel Reviewed-by: mullan ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalizationMethod.java Changeset: c261596407b5 Author: bae Date: 2013-05-14 21:10 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c261596407b5 8014427: REGRESSION: closed/javax/imageio/plugins/bmp/Write3ByteBgrTest.java fails since 7u25 b09 Reviewed-by: prr ! src/share/classes/java/awt/image/Raster.java Changeset: 392f03789497 Author: mchung Date: 2013-05-14 08:07 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/392f03789497 8010727: WLS fails to add a logger with "" in its own LogManager subclass instance Reviewed-by: alanb, jgish ! src/share/classes/java/util/logging/LogManager.java + test/java/util/logging/LogManagerInstanceTest.java Changeset: 8e07710dca9a Author: bae Date: 2013-05-17 16:14 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8e07710dca9a 8014205: Most of the Swing dialogs are blank on one win7 MUI Reviewed-by: vadim ! src/share/classes/java/awt/image/BufferedImage.java Changeset: 1d8fe72d3c4e Author: leonidr Date: 2013-05-20 19:07 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1d8fe72d3c4e 8014718: Netbeans IDE begins to throw a lot exceptions since 7u25 b10 Summary: Removed logging from SunToolkit Reviewed-by: art ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/sun/awt/SunToolkit.java Changeset: 25baf6dc46a0 Author: chegar Date: 2013-05-22 13:57 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/25baf6dc46a0 8014737: java/lang/invoke/7196190/MHProxyTest.java fails after 8009424 Reviewed-by: twisti - test/java/lang/invoke/7196190/MHProxyTest.java Changeset: a4ea4234facf Author: chegar Date: 2013-06-14 16:38 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a4ea4234facf 8012156: tools/javac/file/zip/T6865530.java fails for win32/64 in 7u25 nightly runs Reviewed-by: alanb ! src/share/classes/sun/misc/URLClassPath.java Changeset: 7d56b8a92f52 Author: chegar Date: 2013-06-17 11:26 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7d56b8a92f52 Merge ! make/sun/awt/Makefile ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/nio/channels/AsynchronousServerSocketChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/security/KeyStore.java - src/share/classes/sun/misc/Hashing.java - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties ! src/solaris/native/sun/xawt/XlibWrapper.c - test/sun/misc/Hashing.java Changeset: e3b075b8f21f Author: chegar Date: 2013-06-17 14:23 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e3b075b8f21f Merge ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/net/ftp/impl/FtpClient.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XIconWindow.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: c31fa946605c Author: chegar Date: 2013-06-18 09:39 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c31fa946605c Merge ! src/share/classes/java/lang/Class.java Changeset: 403e63195af5 Author: chegar Date: 2013-06-18 16:08 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/403e63195af5 Merge Changeset: 4b1421ceae93 Author: wmdietl Date: 2013-06-18 14:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4b1421ceae93 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk ! src/share/classes/java/lang/Class.java From wdietl at gmail.com Tue Jun 18 14:32:23 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 21:32:23 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 23 new changesets Message-ID: <20130618213241.99512482DD@hg.openjdk.java.net> Changeset: df5d7f34e35e Author: hannesw Date: 2013-06-11 17:50 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/df5d7f34e35e 8015379: PropertyMap.addProperty() is slow Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/runtime/PropertyMap.java Changeset: aa16622193e1 Author: jlaskey Date: 2013-06-12 11:22 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/aa16622193e1 8016453: loadWithNewGlobal does not allow apply operation Reviewed-by: hannesw, sundar Contributed-by: james.laskey at oracle.com ! samples/test.js ! src/jdk/nashorn/internal/objects/Global.java Changeset: d26e069353c0 Author: hannesw Date: 2013-06-12 16:41 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d26e069353c0 8011893: JS Object builtin prototype is not thread safe Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.java + test/script/basic/JDK-8011893.js + test/script/basic/JDK-8011893.js.EXPECTED Changeset: b0dcc3727fc3 Author: sundar Date: 2013-06-13 16:08 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/b0dcc3727fc3 8015355: Array.prototype functions don't honour non-writable length and / or index properties Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeEvalError.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeRangeError.java ! src/jdk/nashorn/internal/objects/NativeReferenceError.java ! src/jdk/nashorn/internal/objects/NativeSyntaxError.java ! src/jdk/nashorn/internal/objects/NativeTypeError.java ! src/jdk/nashorn/internal/objects/NativeURIError.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptingFunctions.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayIterator.java + test/script/basic/JDK-8015355.js Changeset: 6d6133ef1fd5 Author: hannesw Date: 2013-06-13 12:52 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/6d6133ef1fd5 8016518: Parsing of octal string escapes is broken Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/parser/Lexer.java + test/script/basic/JDK-8016518.js + test/script/basic/JDK-8016518.js.EXPECTED Changeset: 18362e95e638 Author: hannesw Date: 2013-06-13 14:02 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/18362e95e638 8016522: Numeric literal must not be followed by IdentifierStart Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/parser/Lexer.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/error/JDK-8016522.js + test/script/error/JDK-8016522.js.EXPECTED Changeset: fe80eda7b57e Author: hannesw Date: 2013-06-13 15:26 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/fe80eda7b57e 8016528: Hex code from escape() should be padded Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java + test/script/basic/JDK-8016528.js + test/script/basic/JDK-8016528.js.EXPECTED Changeset: c5f783d83180 Author: hannesw Date: 2013-06-13 20:50 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/c5f783d83180 8016542: String.prototype.replace called with function argument should not replace $ patterns Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/objects/NativeRegExp.java + test/script/basic/JDK-8016542.js + test/script/basic/JDK-8016542.js.EXPECTED Changeset: 3efa56767847 Author: lagergren Date: 2013-06-14 13:53 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/3efa56767847 8016235: Use in catch block that may not have been executed in try block caused illegal byte code to be generated Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/ir/Symbol.java ! src/jdk/nashorn/internal/parser/JSONParser.java ! src/jdk/nashorn/internal/parser/Lexer.java + test/script/basic/JDK-8016235.js Changeset: 3d947baa33cc Author: sundar Date: 2013-06-14 21:16 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/3d947baa33cc 8016618: script mirror object access should be improved Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/ir/BreakableNode.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java + src/jdk/nashorn/internal/runtime/arrays/ReverseScriptObjectMirrorIterator.java + src/jdk/nashorn/internal/runtime/arrays/ScriptObjectMirrorIterator.java + test/script/basic/JDK-8016618.js + test/script/basic/JDK-8016618.js.EXPECTED Changeset: a2fa56222fa2 Author: sundar Date: 2013-06-17 13:56 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/a2fa56222fa2 8016550: nashorn.option.no.syntax.extensions has the wrong default Reviewed-by: hannesw, lagergren ! make/project.properties ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! test/script/basic/moduleload.js Changeset: bfac80dffc49 Author: sundar Date: 2013-06-18 13:25 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/bfac80dffc49 Merge Changeset: 616ab697fcac Author: sundar Date: 2013-06-18 13:45 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/616ab697fcac 8008915: URLReader constructor should allow specifying encoding Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/URLReader.java ! src/jdk/nashorn/internal/runtime/Source.java Changeset: 2cf438a3a3aa Author: sundar Date: 2013-06-18 13:52 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/2cf438a3a3aa Merge Changeset: af8a98ea83d4 Author: chegar Date: 2013-04-24 11:03 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/af8a98ea83d4 Merge Changeset: 2237e2ff3685 Author: chegar Date: 2013-04-28 08:16 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/2237e2ff3685 Merge Changeset: 2a377892c255 Author: chegar Date: 2013-05-08 10:21 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/2a377892c255 Merge Changeset: d8ae3d87ca26 Author: chegar Date: 2013-05-16 11:42 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d8ae3d87ca26 Merge Changeset: d3076aecc567 Author: chegar Date: 2013-05-23 12:50 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d3076aecc567 Merge - src/jdk/nashorn/internal/ir/LineNumberNode.java - src/jdk/nashorn/internal/ir/Location.java - src/jdk/nashorn/internal/runtime/SpillProperty.java - test/script/trusted/logcoverage.js Changeset: ded7168cb008 Author: chegar Date: 2013-05-31 10:28 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/ded7168cb008 Merge Changeset: 2b61f82350de Author: chegar Date: 2013-06-10 09:53 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/2b61f82350de Merge - src/jdk/nashorn/internal/objects/DateParser.java - src/jdk/nashorn/internal/runtime/options/ValueOption.java - src/jdk/nashorn/internal/runtime/regexp/DefaultRegExp.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompiler.java - src/jdk/nashorn/internal/runtime/regexp/joni/AsmCompilerSupport.java - src/jdk/nashorn/internal/runtime/regexp/joni/CaptureTreeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/NameEntry.java - src/jdk/nashorn/internal/runtime/regexp/joni/NativeMachine.java - src/jdk/nashorn/internal/runtime/regexp/joni/UnsetAddrList.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CTypeNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/ast/CallNode.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/AbstractBench.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchGreedyBacktrack.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchRailsRegs.java - src/jdk/nashorn/internal/runtime/regexp/joni/bench/BenchSeveralRegexps.java - src/jdk/nashorn/internal/runtime/regexp/joni/constants/Reduce.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/AsciiTables.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/PosixBracket.java - src/jdk/nashorn/internal/runtime/regexp/joni/encoding/Ptr.java - src/netscape/javascript/JSObject.java Changeset: 12f1d8d74375 Author: chegar Date: 2013-06-17 11:27 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/12f1d8d74375 Merge Changeset: fbcd5c26937a Author: chegar Date: 2013-06-18 16:06 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/fbcd5c26937a Merge From alex.buckley at oracle.com Tue Jun 18 14:56:42 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Tue, 18 Jun 2013 14:56:42 -0700 Subject: Review request for type annotation reflection test In-Reply-To: <51BFCB2D.6000706@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> <51AD1017.9050703@oracle.com> <51B93177.6050005@oracle.com> <51BFCB2D.6000706@oracle.com> Message-ID: <51C0D79A.3020105@oracle.com> Did you see my last review email? http://mail.openjdk.java.net/pipermail/type-annotations-dev/2013-June/001066.html The webrev appears unchanged since the last time you sent its URL. Not sure what to say about the text file showing test runs... Alex On 6/17/2013 7:51 PM, Charlie Wang wrote: > Hi, > Please review type annotation reflection test. > http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ > > Here's test result: > http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/1.txt > > > Regards, > Charlie > On 2013/6/13 10:41, Charlie Wang wrote: >> Hi, >> Updated all the tests according to comments. Here's webrev. Please >> review. >> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ >> >> >> >> Regards, >> Charlie >> >> >> On 2013/6/4 5:52, Alex Buckley wrote: >>> Hi Charlie, >>> >>> First, I think there is some clever stuff going on here, but it's >>> hard to figure out what it is. It's not enough to sprinkle comments >>> like "// input should be like ["@A() @B()", "@C() @D()"...]" in >>> SrcType. I would like an explanation of what a test case like >>> ClsGetAnnotatedInterTest is trying to do. The TestCase enum type >>> looks like a good place to start. Then, I would like to know how >>> Helper.SrcType supports that with search-and-replace on keys like >>> #ANNO. To be clear, I'm not looking for three bullet points; I'm >>> looking for paragraphs that can be added to your code's javadoc and >>> be useful to someone in ten years time. >>> >>> Second, in the interest of increasing the abstraction of >>> Helper.SrcType, you should introduce an interface with a getSrc >>> method and have it be implemented by the SrcType enum type. You >>> should also remove duplicated code throughout SrcType's enum constant >>> bodies (e.g. the code for "// get @anno for [#ANNO1] ..."). >>> >>> Third, please don't shorten terms which are part of the Java >>> language. METHODHEAD should be METHOD_HEADER. METHODPARAM should be >>> METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be >>> TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And >>> so on. Rigor really matters when dealing with the Java language. >>> >>> Alex >>> >>> On 6/2/2013 11:39 PM, Charlie Wang wrote: >>>> Hi, >>>> Please review attached 2 files, which I've changed according to >>>> comments. If OK, I will update the rest of the tests and publish for >>>> review. >>>> >>>> Regards, >>>> Charlie >>>> On 2013/5/22 9:55, Joseph Darcy wrote: >>>>> Hello, >>>>> >>>>> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>>>>> I see you have extracted the validation logic and common annotation >>>>>> types into TestUtil, so that any individual test will primarily be a >>>>>> data provider + test cases. However: >>>>>> >>>>>> 1. Jon is our resident TestNG expert and he says that data providers >>>>>> are intended to enumerate input values for tests; other code >>>>>> determines which values should pass the tests and which values should >>>>>> fail. But your data provider encodes the types and element values of >>>>>> annotations which are expected to appear at various locations - this >>>>>> is output data, not input data. >>>>>> >>>>>> 2. There is basically no abstraction over the expected annotations in >>>>>> the data provider. It's just a bunch of Object[][] values. >>>>>> Consequently, TestUtil is very brittle. There is weird indexing of >>>>>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>>>>> knowledge of specific test cases: >>>>>> >>>>>> catch (NoSuchMethodException e) { >>>>>> //expected exception for TypeAnno3 >>>>>> } >>>>>> >>>>>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>>>>> at present, but if they ever share state then you'll be in trouble, >>>>>> especially with the instance methods in GetAnnotated*Test. >>>>>> >>>>>> Charlie, there are two techniques you should adopt for tests on the >>>>>> core reflection API: >>>>>> >>>>>> - First, encode expected values of type annotations more directly, by >>>>>> annotating the AnnotationTypeTestXX declarations themselves. >>>>> >>>>> Note that this technique is used in various other regression tests in >>>>> the JDK repository. For some recently-written small examples see >>>>> >>>>> test/java/lang/reflect/Parameter/WithoutParameters.java >>>>> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >>>>> >>>>>> >>>>>> - Second, embrace combinatorial testing rather than declaring a bunch >>>>>> of ad-hoc AnnotationTypeTestXX types with type annotations in various >>>>>> locations. >>>>>> >>>>>> The core reflection tests for repeating annotations use both these >>>>>> techniques. Please look at item 2 of >>>>>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>>>>> >>>>>> - apologies for non-Oracle readers. Please talk with Steve and >>>>>> Matherey to get background. To be clear, I will not sign off the type >>>>>> annotations reflection tests in their present form. >>>>> >>>>> I concur that using combinatorial tests is appropriate for this >>>>> domain. The basic approach is to programatically generate both the >>>>> expected result and the code to test and verify that the computed >>>>> answer is consistent with the expected one. The regression tests >>>>> currently in JDK 8 have code that allows source code to be generated >>>>> at runtime, loading in by a class loader, and then run. >>>>> >>>>> HTH, >>>>> >>>>> -Joe >>>>> >>>>>> >>>>>> Alex >>>>>> >>>>>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>>>>> OK, thanks. >>>>>>> I will create a TestUtil.java (as attached file). Extract the common >>>>>>> part and put them in it. And Add comments on data provider. >>>>>>> I'm on a very tight schedule, so this time I just send out two of >>>>>>> the >>>>>>> updated files (attached files) for review so I can get a quick >>>>>>> response. >>>>>>> If it is OK, I will use it as a template on other tests. >>>>>>> Please take a look and send me your comments as soon as possible. >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Charlie >>>>>>> >>>>>>> >>>>>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>>>>> Please keep one source file per tested API method, because it is >>>>>>>> easy >>>>>>>> to navigate. The problem is the body of the test() method in each >>>>>>>> source file. It should call utility methods to inspect annotations, >>>>>>>> rather that repeating more or less the same 'for' loops as every >>>>>>>> other >>>>>>>> test() method. >>>>>>>> >>>>>>>> As for data providers, I believe they are a TestNG thing. Please >>>>>>>> add >>>>>>>> comments to each source file to describe what the data provider >>>>>>>> represents. >>>>>>>> >>>>>>>> Finally, when you make a "little update", you should give a short >>>>>>>> description of what has changed. If you don't, someone who >>>>>>>> looked at >>>>>>>> the previous version has no idea what changed and will have to >>>>>>>> look at >>>>>>>> everything again. >>>>>>>> >>>>>>>> Alex >>>>>>>> >>>>>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>>>>> Yes, that make sense. What do you think if I combine the tests? It >>>>>>>>> would >>>>>>>>> then have 1 unified data provider and test method, thus solve >>>>>>>>> the 2 >>>>>>>>> problems. >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Charlie >>>>>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>>>>> I agree with Alex's first two comments. The code duplication >>>>>>>>>> for the >>>>>>>>>> test logic and all the different annotation types seems hard to >>>>>>>>>> maintain and update. >>>>>>>>>> >>>>>>>>>> cu, WMD. >>>>>>>>>> >>>>>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>>>>> wrote: >>>>>>>>>>> Hi, >>>>>>>>>>> Here's the latest one with a little update: >>>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>>>>> Please provide comments as soon as possible now that due >>>>>>>>>>> date is >>>>>>>>>>> approaching. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Charlie >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>>>>> JDK-8013497. >>>>>>>>>>> Please take a look. >>>>>>>>>>> >>>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Charlie >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>> >>>>> >> > From wdietl at gmail.com Tue Jun 18 15:46:58 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 22:46:58 +0000 Subject: hg: type-annotations/type-annotations/langtools: 2 new changesets Message-ID: <20130618224705.0ADF2482EE@hg.openjdk.java.net> Changeset: 5658cfb633c1 Author: wmdietl Date: 2013-06-18 15:44 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/5658cfb633c1 Patch 8006734 from Steve Sides: http://cr.openjdk.java.net/~ssides/8006734/langtools_8006734.patch ! test/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java Changeset: 3df6f93d9adf Author: wmdietl Date: 2013-06-18 15:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/3df6f93d9adf Path 8015323 from Steve Sides: http://cr.openjdk.java.net/~ssides/8015323/langtools_8015323.patch + test/tools/javac/annotations/typeAnnotations/classfile/TestAnonInnerClasses.java + test/tools/javac/annotations/typeAnnotations/classfile/testanoninner.template From wdietl at gmail.com Tue Jun 18 15:55:14 2013 From: wdietl at gmail.com (Werner Dietl) Date: Tue, 18 Jun 2013 15:55:14 -0700 Subject: Request for comments: type annotations on nested types In-Reply-To: <51BF6A42.9000106@oracle.com> References: <51BF6A42.9000106@oracle.com> Message-ID: Thanks for these comments, Alex. In the language model, there is no TypeMirror for some of these, so you would have a TYPE_USE annotation according to the bytecode which is not represented in the language model. (I found javac inconsistent in when Outer had a Type and when not. I'll write up a small test case and send that out separately.) I will not push my updates until the EG decided the desired behavior. Failing tests T8008762.java and TestAnonInnerClasses.java are waiting on this discussion: http://mail.openjdk.java.net/pipermail/type-annotations-dev/2013-April/000782.html There are some refactorings of the Annotations code in the pipeline and I suggest we look at these issues again after those refactorings. cu, WMD. On Mon, Jun 17, 2013 at 12:57 PM, Alex Buckley wrote: > // For simplicity, sending solely to type-annotations-dev. > > In what follows, I intend to be precise in talking about _names_ rather than > _types_. I am not even going to say "type use" because without some > forthcoming JLS changes, it's not precise enough. I am going to speak solely > about qualified names composed of simple names. > > The goal of JSR 308 is that a simple name that acts merely as a "scoping > mechanism" may not be annotated. > > Thus, in a qualified package name like "java.lang", neither the simple > package name "java" nor the simple package name "lang" may be annotated. > > And, in a qualified type name like "A.B", the simple type name "A" may not > be annotated if the simple type name "B" refers to a static member. That is, > "A" may not be annotated if the type referred to by "B" does not have an > enclosing instance. > > As I look through the fine scenarios in CantAnnotateStaticClass2 (since > CantAnnotateStaticClass3 is just a demo that all member declarations in an > interface are static), javac looks to be applying the rules correctly: > > @TB Outer f1; > @TB Outer.Inner f1a; > @TB Outer.SInner f2a; // err > @TB Outer.IInner f3a; // err > > The problem is, it's rather subtle for the language to work like this: > > @TB Outer. @TC Inner f1c; > @TB Outer. @TC SInner f2c; // err > @TB Outer. @TC IInner f3c; // err > > The ClassFile representation of annotations on qualified type names does not > care whether the underlying declarations are static. Personally, I am > inclined to drop the "scoping mechanism" rule and allow a TYPE_USE > annotation on any simple type name. (I would not, at this stage of the JSR, > extend such freedom to simple type names in class-oriented expressions like > class literals and qualified this expressions, because storing annotations > thereon would require ClassFile changes.) I intend to discuss this with the > EG when practical. > > Alex > > > On 6/16/2013 4:06 PM, Werner Dietl wrote: >> >> Dear all, >> >> I've been working on type annotations on nested types and want to make >> sure I'm implementing the right checks. >> >> Find three test classes attached that should contain all legal >> combinations of nesting of types. >> Instead of a .out file, see "// err" markers for the lines that I expect >> errors. >> CantAnnotateStaticClass.java contains only legal combinations; see >> tests 2 and 3 for error cases. >> My interpretation is basically that, if it is possible to refer to a >> "Outer.this" object, it should be possible to have a type annotation >> on that type use. >> >> Does everybody agree with this interpretation? >> Do you see any errors in my test cases? >> Do you see a way to write the test cases in a more succinct and complete >> way? >> >> I have a few local changes that refactor this part of the compiler. >> I'll push once we agree on the checks. >> >> Thanks for all comments! >> cu, WMD. >> >> -- >> http://www.google.com/profiles/wdietl >> > -- http://www.google.com/profiles/wdietl From wdietl at gmail.com Tue Jun 18 14:19:11 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Tue, 18 Jun 2013 21:19:11 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 12 new changesets Message-ID: <20130618211943.A1369482D8@hg.openjdk.java.net> Changeset: f75faf51e8c4 Author: hseigel Date: 2013-03-07 11:49 -0500 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f75faf51e8c4 7158805: Better rewriting of nested subroutine calls Reviewed-by: mschoene, coleenp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/oops/generateOopMap.cpp Changeset: b295e132102d Author: mullan Date: 2013-04-05 10:18 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b295e132102d 8001330: Improve on checking order Reviewed-by: acorn, hawtin ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/prims/jvm.cpp Changeset: be131aa5a529 Author: mullan Date: 2013-04-22 08:33 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/be131aa5a529 8011896: Add check for invalid offset for new AccessControlContext isAuthorized field Reviewed-by: acorn ! src/share/vm/classfile/javaClasses.cpp Changeset: 3463b5b373f7 Author: chegar Date: 2013-04-24 10:17 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3463b5b373f7 Merge Changeset: f822ecf621ce Author: chegar Date: 2013-04-28 08:15 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f822ecf621ce Merge Changeset: 4b52137b07c9 Author: chegar Date: 2013-05-01 14:11 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/4b52137b07c9 Merge - make/bsd/makefiles/jvmg.make - make/bsd/makefiles/profiled.make - make/linux/makefiles/jvmg.make - make/linux/makefiles/profiled.make - make/solaris/makefiles/jvmg.make - make/solaris/makefiles/profiled.make - src/os/bsd/vm/chaitin_bsd.cpp - src/os/linux/vm/chaitin_linux.cpp - src/os/solaris/vm/chaitin_solaris.cpp - src/os/windows/vm/chaitin_windows.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp Changeset: 7ee0d5c53c78 Author: chegar Date: 2013-05-08 15:25 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/7ee0d5c53c78 Merge - agent/doc/c2replay.html ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp Changeset: cb92413c6934 Author: chegar Date: 2013-05-16 11:44 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/cb92413c6934 Merge ! src/share/vm/classfile/vmSymbols.hpp Changeset: ce9ecec70f99 Author: chegar Date: 2013-05-23 12:44 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ce9ecec70f99 Merge - make/bsd/makefiles/launcher.make - make/linux/makefiles/launcher.make - make/solaris/makefiles/launcher.make - make/windows/makefiles/launcher.make - src/os/posix/launcher/java_md.c - src/os/posix/launcher/java_md.h - src/os/posix/launcher/launcher.script - src/os/windows/launcher/java_md.c - src/os/windows/launcher/java_md.h - src/share/tools/launcher/java.c - src/share/tools/launcher/java.h - src/share/tools/launcher/jli_util.c - src/share/tools/launcher/jli_util.h - src/share/tools/launcher/wildcard.c - src/share/tools/launcher/wildcard.h ! src/share/vm/classfile/vmSymbols.hpp - src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.inline.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/prims/jvm.cpp Changeset: 0861193d358a Author: chegar Date: 2013-05-31 10:27 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/0861193d358a Merge - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java - agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java - test/runtime/7158804/Test7158804.sh - test/runtime/8003985/Test8003985.java Changeset: eaf3742822ec Author: chegar Date: 2013-06-17 11:17 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/eaf3742822ec Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jvm.cpp Changeset: 4dc7c2619987 Author: wmdietl Date: 2013-06-18 14:18 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/4dc7c2619987 Automated merge with http://hg.openjdk.java.net/jdk8/tl/hotspot From charlie.wang at oracle.com Tue Jun 18 19:07:15 2013 From: charlie.wang at oracle.com (Charlie Wang) Date: Wed, 19 Jun 2013 10:07:15 +0800 Subject: Review request for type annotation reflection test In-Reply-To: <51C0D79A.3020105@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> <51AD1017.9050703@oracle.com> <51B93177.6050005@oracle.com> <51BFCB2D.6000706@oracle.com> <51C0D79A.3020105@oracle.com> Message-ID: <51C11253.8020200@oracle.com> No. I don't know why I can't get mails from type-annotations-dev at openjdk.java.net. I've subscribed the alias. In regards to some of your comments. "- Some of the files have their last line missing." It's not missing in the files. I guess it has something to do with the webrev tool I used. "- annoComb seems to be identical in every Test class. Why not centralize it?" I suggest leave it there for future extension. In case we want to add some special annotations other than the ones already defined in the test. I will update the rest of code according to your comments. Regards, Charlie On 2013/6/19 5:56, Alex Buckley wrote: > Did you see my last review email? > > http://mail.openjdk.java.net/pipermail/type-annotations-dev/2013-June/001066.html > > > The webrev appears unchanged since the last time you sent its URL. Not > sure what to say about the text file showing test runs... > > Alex > > On 6/17/2013 7:51 PM, Charlie Wang wrote: >> Hi, >> Please review type annotation reflection test. >> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ >> >> Here's test result: >> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/1.txt >> >> >> Regards, >> Charlie >> On 2013/6/13 10:41, Charlie Wang wrote: >>> Hi, >>> Updated all the tests according to comments. Here's webrev. Please >>> review. >>> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ >>> >>> >>> >>> Regards, >>> Charlie >>> >>> >>> On 2013/6/4 5:52, Alex Buckley wrote: >>>> Hi Charlie, >>>> >>>> First, I think there is some clever stuff going on here, but it's >>>> hard to figure out what it is. It's not enough to sprinkle comments >>>> like "// input should be like ["@A() @B()", "@C() @D()"...]" in >>>> SrcType. I would like an explanation of what a test case like >>>> ClsGetAnnotatedInterTest is trying to do. The TestCase enum type >>>> looks like a good place to start. Then, I would like to know how >>>> Helper.SrcType supports that with search-and-replace on keys like >>>> #ANNO. To be clear, I'm not looking for three bullet points; I'm >>>> looking for paragraphs that can be added to your code's javadoc and >>>> be useful to someone in ten years time. >>>> >>>> Second, in the interest of increasing the abstraction of >>>> Helper.SrcType, you should introduce an interface with a getSrc >>>> method and have it be implemented by the SrcType enum type. You >>>> should also remove duplicated code throughout SrcType's enum constant >>>> bodies (e.g. the code for "// get @anno for [#ANNO1] ..."). >>>> >>>> Third, please don't shorten terms which are part of the Java >>>> language. METHODHEAD should be METHOD_HEADER. METHODPARAM should be >>>> METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be >>>> TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And >>>> so on. Rigor really matters when dealing with the Java language. >>>> >>>> Alex >>>> >>>> On 6/2/2013 11:39 PM, Charlie Wang wrote: >>>>> Hi, >>>>> Please review attached 2 files, which I've changed according to >>>>> comments. If OK, I will update the rest of the tests and publish for >>>>> review. >>>>> >>>>> Regards, >>>>> Charlie >>>>> On 2013/5/22 9:55, Joseph Darcy wrote: >>>>>> Hello, >>>>>> >>>>>> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>>>>>> I see you have extracted the validation logic and common annotation >>>>>>> types into TestUtil, so that any individual test will primarily >>>>>>> be a >>>>>>> data provider + test cases. However: >>>>>>> >>>>>>> 1. Jon is our resident TestNG expert and he says that data >>>>>>> providers >>>>>>> are intended to enumerate input values for tests; other code >>>>>>> determines which values should pass the tests and which values >>>>>>> should >>>>>>> fail. But your data provider encodes the types and element >>>>>>> values of >>>>>>> annotations which are expected to appear at various locations - >>>>>>> this >>>>>>> is output data, not input data. >>>>>>> >>>>>>> 2. There is basically no abstraction over the expected >>>>>>> annotations in >>>>>>> the data provider. It's just a bunch of Object[][] values. >>>>>>> Consequently, TestUtil is very brittle. There is weird indexing of >>>>>>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>>>>>> knowledge of specific test cases: >>>>>>> >>>>>>> catch (NoSuchMethodException e) { >>>>>>> //expected exception for TypeAnno3 >>>>>>> } >>>>>>> >>>>>>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>>>>>> at present, but if they ever share state then you'll be in trouble, >>>>>>> especially with the instance methods in GetAnnotated*Test. >>>>>>> >>>>>>> Charlie, there are two techniques you should adopt for tests on the >>>>>>> core reflection API: >>>>>>> >>>>>>> - First, encode expected values of type annotations more >>>>>>> directly, by >>>>>>> annotating the AnnotationTypeTestXX declarations themselves. >>>>>> >>>>>> Note that this technique is used in various other regression >>>>>> tests in >>>>>> the JDK repository. For some recently-written small examples see >>>>>> >>>>>> test/java/lang/reflect/Parameter/WithoutParameters.java >>>>>> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >>>>>> >>>>>>> >>>>>>> - Second, embrace combinatorial testing rather than declaring a >>>>>>> bunch >>>>>>> of ad-hoc AnnotationTypeTestXX types with type annotations in >>>>>>> various >>>>>>> locations. >>>>>>> >>>>>>> The core reflection tests for repeating annotations use both these >>>>>>> techniques. Please look at item 2 of >>>>>>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>>>>>> >>>>>>> >>>>>>> - apologies for non-Oracle readers. Please talk with Steve and >>>>>>> Matherey to get background. To be clear, I will not sign off the >>>>>>> type >>>>>>> annotations reflection tests in their present form. >>>>>> >>>>>> I concur that using combinatorial tests is appropriate for this >>>>>> domain. The basic approach is to programatically generate both the >>>>>> expected result and the code to test and verify that the computed >>>>>> answer is consistent with the expected one. The regression tests >>>>>> currently in JDK 8 have code that allows source code to be generated >>>>>> at runtime, loading in by a class loader, and then run. >>>>>> >>>>>> HTH, >>>>>> >>>>>> -Joe >>>>>> >>>>>>> >>>>>>> Alex >>>>>>> >>>>>>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>>>>>> OK, thanks. >>>>>>>> I will create a TestUtil.java (as attached file). Extract the >>>>>>>> common >>>>>>>> part and put them in it. And Add comments on data provider. >>>>>>>> I'm on a very tight schedule, so this time I just send out two of >>>>>>>> the >>>>>>>> updated files (attached files) for review so I can get a quick >>>>>>>> response. >>>>>>>> If it is OK, I will use it as a template on other tests. >>>>>>>> Please take a look and send me your comments as soon as possible. >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Charlie >>>>>>>> >>>>>>>> >>>>>>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>>>>>> Please keep one source file per tested API method, because it is >>>>>>>>> easy >>>>>>>>> to navigate. The problem is the body of the test() method in each >>>>>>>>> source file. It should call utility methods to inspect >>>>>>>>> annotations, >>>>>>>>> rather that repeating more or less the same 'for' loops as every >>>>>>>>> other >>>>>>>>> test() method. >>>>>>>>> >>>>>>>>> As for data providers, I believe they are a TestNG thing. Please >>>>>>>>> add >>>>>>>>> comments to each source file to describe what the data provider >>>>>>>>> represents. >>>>>>>>> >>>>>>>>> Finally, when you make a "little update", you should give a short >>>>>>>>> description of what has changed. If you don't, someone who >>>>>>>>> looked at >>>>>>>>> the previous version has no idea what changed and will have to >>>>>>>>> look at >>>>>>>>> everything again. >>>>>>>>> >>>>>>>>> Alex >>>>>>>>> >>>>>>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>>>>>> Yes, that make sense. What do you think if I combine the >>>>>>>>>> tests? It >>>>>>>>>> would >>>>>>>>>> then have 1 unified data provider and test method, thus solve >>>>>>>>>> the 2 >>>>>>>>>> problems. >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Charlie >>>>>>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>>>>>> I agree with Alex's first two comments. The code duplication >>>>>>>>>>> for the >>>>>>>>>>> test logic and all the different annotation types seems hard to >>>>>>>>>>> maintain and update. >>>>>>>>>>> >>>>>>>>>>> cu, WMD. >>>>>>>>>>> >>>>>>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>>>>>> wrote: >>>>>>>>>>>> Hi, >>>>>>>>>>>> Here's the latest one with a little update: >>>>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>>>>>> Please provide comments as soon as possible now that due >>>>>>>>>>>> date is >>>>>>>>>>>> approaching. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Regards, >>>>>>>>>>>> Charlie >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>>>>>> JDK-8013497. >>>>>>>>>>>> Please take a look. >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Regards, >>>>>>>>>>>> Charlie >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>> >>> >> From charlie.wang at oracle.com Wed Jun 19 01:04:12 2013 From: charlie.wang at oracle.com (Charlie Wang) Date: Wed, 19 Jun 2013 16:04:12 +0800 Subject: Review request for type annotation reflection test In-Reply-To: <51C0D79A.3020105@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> <51AD1017.9050703@oracle.com> <51B93177.6050005@oracle.com> <51BFCB2D.6000706@oracle.com> <51C0D79A.3020105@oracle.com> Message-ID: <51C165FC.10300@oracle.com> Hi, Please review type annotation reflection test. Updated according to Alex's comments. http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ Here's test result: http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/1.txt Regards, Charlie On 2013/6/19 5:56, Alex Buckley wrote: > Did you see my last review email? > > http://mail.openjdk.java.net/pipermail/type-annotations-dev/2013-June/001066.html > > > The webrev appears unchanged since the last time you sent its URL. Not > sure what to say about the text file showing test runs... > > Alex > > On 6/17/2013 7:51 PM, Charlie Wang wrote: >> Hi, >> Please review type annotation reflection test. >> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ >> >> Here's test result: >> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/1.txt >> >> >> Regards, >> Charlie >> On 2013/6/13 10:41, Charlie Wang wrote: >>> Hi, >>> Updated all the tests according to comments. Here's webrev. Please >>> review. >>> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ >>> >>> >>> >>> Regards, >>> Charlie >>> >>> >>> On 2013/6/4 5:52, Alex Buckley wrote: >>>> Hi Charlie, >>>> >>>> First, I think there is some clever stuff going on here, but it's >>>> hard to figure out what it is. It's not enough to sprinkle comments >>>> like "// input should be like ["@A() @B()", "@C() @D()"...]" in >>>> SrcType. I would like an explanation of what a test case like >>>> ClsGetAnnotatedInterTest is trying to do. The TestCase enum type >>>> looks like a good place to start. Then, I would like to know how >>>> Helper.SrcType supports that with search-and-replace on keys like >>>> #ANNO. To be clear, I'm not looking for three bullet points; I'm >>>> looking for paragraphs that can be added to your code's javadoc and >>>> be useful to someone in ten years time. >>>> >>>> Second, in the interest of increasing the abstraction of >>>> Helper.SrcType, you should introduce an interface with a getSrc >>>> method and have it be implemented by the SrcType enum type. You >>>> should also remove duplicated code throughout SrcType's enum constant >>>> bodies (e.g. the code for "// get @anno for [#ANNO1] ..."). >>>> >>>> Third, please don't shorten terms which are part of the Java >>>> language. METHODHEAD should be METHOD_HEADER. METHODPARAM should be >>>> METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be >>>> TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And >>>> so on. Rigor really matters when dealing with the Java language. >>>> >>>> Alex >>>> >>>> On 6/2/2013 11:39 PM, Charlie Wang wrote: >>>>> Hi, >>>>> Please review attached 2 files, which I've changed according to >>>>> comments. If OK, I will update the rest of the tests and publish for >>>>> review. >>>>> >>>>> Regards, >>>>> Charlie >>>>> On 2013/5/22 9:55, Joseph Darcy wrote: >>>>>> Hello, >>>>>> >>>>>> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>>>>>> I see you have extracted the validation logic and common annotation >>>>>>> types into TestUtil, so that any individual test will primarily >>>>>>> be a >>>>>>> data provider + test cases. However: >>>>>>> >>>>>>> 1. Jon is our resident TestNG expert and he says that data >>>>>>> providers >>>>>>> are intended to enumerate input values for tests; other code >>>>>>> determines which values should pass the tests and which values >>>>>>> should >>>>>>> fail. But your data provider encodes the types and element >>>>>>> values of >>>>>>> annotations which are expected to appear at various locations - >>>>>>> this >>>>>>> is output data, not input data. >>>>>>> >>>>>>> 2. There is basically no abstraction over the expected >>>>>>> annotations in >>>>>>> the data provider. It's just a bunch of Object[][] values. >>>>>>> Consequently, TestUtil is very brittle. There is weird indexing of >>>>>>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>>>>>> knowledge of specific test cases: >>>>>>> >>>>>>> catch (NoSuchMethodException e) { >>>>>>> //expected exception for TypeAnno3 >>>>>>> } >>>>>>> >>>>>>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>>>>>> at present, but if they ever share state then you'll be in trouble, >>>>>>> especially with the instance methods in GetAnnotated*Test. >>>>>>> >>>>>>> Charlie, there are two techniques you should adopt for tests on the >>>>>>> core reflection API: >>>>>>> >>>>>>> - First, encode expected values of type annotations more >>>>>>> directly, by >>>>>>> annotating the AnnotationTypeTestXX declarations themselves. >>>>>> >>>>>> Note that this technique is used in various other regression >>>>>> tests in >>>>>> the JDK repository. For some recently-written small examples see >>>>>> >>>>>> test/java/lang/reflect/Parameter/WithoutParameters.java >>>>>> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >>>>>> >>>>>>> >>>>>>> - Second, embrace combinatorial testing rather than declaring a >>>>>>> bunch >>>>>>> of ad-hoc AnnotationTypeTestXX types with type annotations in >>>>>>> various >>>>>>> locations. >>>>>>> >>>>>>> The core reflection tests for repeating annotations use both these >>>>>>> techniques. Please look at item 2 of >>>>>>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>>>>>> >>>>>>> >>>>>>> - apologies for non-Oracle readers. Please talk with Steve and >>>>>>> Matherey to get background. To be clear, I will not sign off the >>>>>>> type >>>>>>> annotations reflection tests in their present form. >>>>>> >>>>>> I concur that using combinatorial tests is appropriate for this >>>>>> domain. The basic approach is to programatically generate both the >>>>>> expected result and the code to test and verify that the computed >>>>>> answer is consistent with the expected one. The regression tests >>>>>> currently in JDK 8 have code that allows source code to be generated >>>>>> at runtime, loading in by a class loader, and then run. >>>>>> >>>>>> HTH, >>>>>> >>>>>> -Joe >>>>>> >>>>>>> >>>>>>> Alex >>>>>>> >>>>>>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>>>>>> OK, thanks. >>>>>>>> I will create a TestUtil.java (as attached file). Extract the >>>>>>>> common >>>>>>>> part and put them in it. And Add comments on data provider. >>>>>>>> I'm on a very tight schedule, so this time I just send out two of >>>>>>>> the >>>>>>>> updated files (attached files) for review so I can get a quick >>>>>>>> response. >>>>>>>> If it is OK, I will use it as a template on other tests. >>>>>>>> Please take a look and send me your comments as soon as possible. >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Charlie >>>>>>>> >>>>>>>> >>>>>>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>>>>>> Please keep one source file per tested API method, because it is >>>>>>>>> easy >>>>>>>>> to navigate. The problem is the body of the test() method in each >>>>>>>>> source file. It should call utility methods to inspect >>>>>>>>> annotations, >>>>>>>>> rather that repeating more or less the same 'for' loops as every >>>>>>>>> other >>>>>>>>> test() method. >>>>>>>>> >>>>>>>>> As for data providers, I believe they are a TestNG thing. Please >>>>>>>>> add >>>>>>>>> comments to each source file to describe what the data provider >>>>>>>>> represents. >>>>>>>>> >>>>>>>>> Finally, when you make a "little update", you should give a short >>>>>>>>> description of what has changed. If you don't, someone who >>>>>>>>> looked at >>>>>>>>> the previous version has no idea what changed and will have to >>>>>>>>> look at >>>>>>>>> everything again. >>>>>>>>> >>>>>>>>> Alex >>>>>>>>> >>>>>>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>>>>>> Yes, that make sense. What do you think if I combine the >>>>>>>>>> tests? It >>>>>>>>>> would >>>>>>>>>> then have 1 unified data provider and test method, thus solve >>>>>>>>>> the 2 >>>>>>>>>> problems. >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Charlie >>>>>>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>>>>>> I agree with Alex's first two comments. The code duplication >>>>>>>>>>> for the >>>>>>>>>>> test logic and all the different annotation types seems hard to >>>>>>>>>>> maintain and update. >>>>>>>>>>> >>>>>>>>>>> cu, WMD. >>>>>>>>>>> >>>>>>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>>>>>> wrote: >>>>>>>>>>>> Hi, >>>>>>>>>>>> Here's the latest one with a little update: >>>>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>>>>>> Please provide comments as soon as possible now that due >>>>>>>>>>>> date is >>>>>>>>>>>> approaching. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Regards, >>>>>>>>>>>> Charlie >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>>>>>> JDK-8013497. >>>>>>>>>>>> Please take a look. >>>>>>>>>>>> >>>>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Regards, >>>>>>>>>>>> Charlie >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>> >>> >> From alex.buckley at oracle.com Wed Jun 19 16:21:17 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Wed, 19 Jun 2013 16:21:17 -0700 Subject: Review request for type annotation reflection test In-Reply-To: <51C165FC.10300@oracle.com> References: <51986CBC.2000107@oracle.com> <519AE246.80500@oracle.com> <519B4807.1040007@oracle.com> <519BBBE4.5020009@oracle.com> <519BE728.4050806@oracle.com> <519C214D.20802@oracle.com> <519C2582.6040401@oracle.com> <51AC3A30.6000706@oracle.com> <51AD1017.9050703@oracle.com> <51B93177.6050005@oracle.com> <51BFCB2D.6000706@oracle.com> <51C0D79A.3020105@oracle.com> <51C165FC.10300@oracle.com> Message-ID: <51C23CED.6050801@oracle.com> - Please provide a text file for the generated code of each java/lang/* test. - Two kinds of TestXYZGenerator is confusing. TestSourceGenerator should be called DeclarationGenerator. That's what it generates: declarations of classes, interfaces, fields, etc which are gathered up by the test case generators. Helper.SrcType should be called Helper.Declaration. The name of an enum type should describe what kind of things are represented by the enum constants, which here means declarations (of classes, interfaces, fields, etc). And you have a method called "genTestCode" in Helper as well as a method called "GenTestCode" in each test file (e.g. ClassGetAnnotatedInterfaceTest.java). - It is extremely subtle that TYPE_ANNOTATION_1/2/3 represents both the declaration of an annotation type (to be part of a test case) _and_ an annotation (to be applied wherever #ANNO appears in the declaration under test). Please rename TYPE_ANNOTATION_1/2/3 to ANNOTATION_TYPE_1/2/3 (and, TYPE_ANNOTATION_CONTAINER_1/2/3 to CONTAINING_ANNOTATION_TYPE_1/2/3). - There is too much duplication in the java/lang/* classes, and generally too much use of static fields. These classes should each be a subclass of an abstract class AnnotationTest, which declares test() and the bulk of the code in checkResult(). AnnotationTest should have a variable "annotationCombinations" (not "annoComb") to enumerate the annotations to be applied. - Raw type Map in signature of Helper#genTestCode. - ClassGetAnnotatedInterfaceTest -> missing an 's' after Interface. ClassGetAnnotatedSuperClassTest should be Superclass not SuperClass. - @author should be a full name, not a first name. Alex On 6/19/2013 1:04 AM, Charlie Wang wrote: > Hi, > Please review type annotation reflection test. Updated according to > Alex's comments. > http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ > > Here's test result: > http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/1.txt > > > > Regards, > Charlie > > > On 2013/6/19 5:56, Alex Buckley wrote: >> Did you see my last review email? >> >> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2013-June/001066.html >> >> >> The webrev appears unchanged since the last time you sent its URL. Not >> sure what to say about the text file showing test runs... >> >> Alex >> >> On 6/17/2013 7:51 PM, Charlie Wang wrote: >>> Hi, >>> Please review type annotation reflection test. >>> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ >>> >>> Here's test result: >>> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/1.txt >>> >>> >>> Regards, >>> Charlie >>> On 2013/6/13 10:41, Charlie Wang wrote: >>>> Hi, >>>> Updated all the tests according to comments. Here's webrev. Please >>>> review. >>>> http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation/webrev/ >>>> >>>> >>>> >>>> Regards, >>>> Charlie >>>> >>>> >>>> On 2013/6/4 5:52, Alex Buckley wrote: >>>>> Hi Charlie, >>>>> >>>>> First, I think there is some clever stuff going on here, but it's >>>>> hard to figure out what it is. It's not enough to sprinkle comments >>>>> like "// input should be like ["@A() @B()", "@C() @D()"...]" in >>>>> SrcType. I would like an explanation of what a test case like >>>>> ClsGetAnnotatedInterTest is trying to do. The TestCase enum type >>>>> looks like a good place to start. Then, I would like to know how >>>>> Helper.SrcType supports that with search-and-replace on keys like >>>>> #ANNO. To be clear, I'm not looking for three bullet points; I'm >>>>> looking for paragraphs that can be added to your code's javadoc and >>>>> be useful to someone in ten years time. >>>>> >>>>> Second, in the interest of increasing the abstraction of >>>>> Helper.SrcType, you should introduce an interface with a getSrc >>>>> method and have it be implemented by the SrcType enum type. You >>>>> should also remove duplicated code throughout SrcType's enum constant >>>>> bodies (e.g. the code for "// get @anno for [#ANNO1] ..."). >>>>> >>>>> Third, please don't shorten terms which are part of the Java >>>>> language. METHODHEAD should be METHOD_HEADER. METHODPARAM should be >>>>> METHOD_PARAMETER. Inter should be Interface. TYPEANNO1 should be >>>>> TYPE_ANNOTATION_1. PKGANNOTATION1 should be PACKAGE_ANNOTATION_1. And >>>>> so on. Rigor really matters when dealing with the Java language. >>>>> >>>>> Alex >>>>> >>>>> On 6/2/2013 11:39 PM, Charlie Wang wrote: >>>>>> Hi, >>>>>> Please review attached 2 files, which I've changed according to >>>>>> comments. If OK, I will update the rest of the tests and publish for >>>>>> review. >>>>>> >>>>>> Regards, >>>>>> Charlie >>>>>> On 2013/5/22 9:55, Joseph Darcy wrote: >>>>>>> Hello, >>>>>>> >>>>>>> On 5/21/2013 6:37 PM, Alex Buckley wrote: >>>>>>>> I see you have extracted the validation logic and common annotation >>>>>>>> types into TestUtil, so that any individual test will primarily >>>>>>>> be a >>>>>>>> data provider + test cases. However: >>>>>>>> >>>>>>>> 1. Jon is our resident TestNG expert and he says that data >>>>>>>> providers >>>>>>>> are intended to enumerate input values for tests; other code >>>>>>>> determines which values should pass the tests and which values >>>>>>>> should >>>>>>>> fail. But your data provider encodes the types and element >>>>>>>> values of >>>>>>>> annotations which are expected to appear at various locations - >>>>>>>> this >>>>>>>> is output data, not input data. >>>>>>>> >>>>>>>> 2. There is basically no abstraction over the expected >>>>>>>> annotations in >>>>>>>> the data provider. It's just a bunch of Object[][] values. >>>>>>>> Consequently, TestUtil is very brittle. There is weird indexing of >>>>>>>> arrays - [i * 2 + 1] and [j / 2] all over the place - and excessive >>>>>>>> knowledge of specific test cases: >>>>>>>> >>>>>>>> catch (NoSuchMethodException e) { >>>>>>>> //expected exception for TypeAnno3 >>>>>>>> } >>>>>>>> >>>>>>>> 3. I'm suspicious of static methods in TestUtil. They are stateless >>>>>>>> at present, but if they ever share state then you'll be in trouble, >>>>>>>> especially with the instance methods in GetAnnotated*Test. >>>>>>>> >>>>>>>> Charlie, there are two techniques you should adopt for tests on the >>>>>>>> core reflection API: >>>>>>>> >>>>>>>> - First, encode expected values of type annotations more >>>>>>>> directly, by >>>>>>>> annotating the AnnotationTypeTestXX declarations themselves. >>>>>>> >>>>>>> Note that this technique is used in various other regression >>>>>>> tests in >>>>>>> the JDK repository. For some recently-written small examples see >>>>>>> >>>>>>> test/java/lang/reflect/Parameter/WithoutParameters.java >>>>>>> test/java/lang/reflect/Method/DefaultMethodModeling.java.html >>>>>>> >>>>>>>> >>>>>>>> - Second, embrace combinatorial testing rather than declaring a >>>>>>>> bunch >>>>>>>> of ad-hoc AnnotationTypeTestXX types with type annotations in >>>>>>>> various >>>>>>>> locations. >>>>>>>> >>>>>>>> The core reflection tests for repeating annotations use both these >>>>>>>> techniques. Please look at item 2 of >>>>>>>> http://wiki.se.oracle.com/display/JPG/Repeating+Annotation+Test+Plan#RepeatingAnnotationTestPlan-1.Featurecases >>>>>>>> >>>>>>>> >>>>>>>> - apologies for non-Oracle readers. Please talk with Steve and >>>>>>>> Matherey to get background. To be clear, I will not sign off the >>>>>>>> type >>>>>>>> annotations reflection tests in their present form. >>>>>>> >>>>>>> I concur that using combinatorial tests is appropriate for this >>>>>>> domain. The basic approach is to programatically generate both the >>>>>>> expected result and the code to test and verify that the computed >>>>>>> answer is consistent with the expected one. The regression tests >>>>>>> currently in JDK 8 have code that allows source code to be generated >>>>>>> at runtime, loading in by a class loader, and then run. >>>>>>> >>>>>>> HTH, >>>>>>> >>>>>>> -Joe >>>>>>> >>>>>>>> >>>>>>>> Alex >>>>>>>> >>>>>>>> On 5/21/2013 2:29 PM, Charlie Wang wrote: >>>>>>>>> OK, thanks. >>>>>>>>> I will create a TestUtil.java (as attached file). Extract the >>>>>>>>> common >>>>>>>>> part and put them in it. And Add comments on data provider. >>>>>>>>> I'm on a very tight schedule, so this time I just send out two of >>>>>>>>> the >>>>>>>>> updated files (attached files) for review so I can get a quick >>>>>>>>> response. >>>>>>>>> If it is OK, I will use it as a template on other tests. >>>>>>>>> Please take a look and send me your comments as soon as possible. >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Charlie >>>>>>>>> >>>>>>>>> >>>>>>>>> On 2013/5/22 2:24, Alex Buckley wrote: >>>>>>>>>> Please keep one source file per tested API method, because it is >>>>>>>>>> easy >>>>>>>>>> to navigate. The problem is the body of the test() method in each >>>>>>>>>> source file. It should call utility methods to inspect >>>>>>>>>> annotations, >>>>>>>>>> rather that repeating more or less the same 'for' loops as every >>>>>>>>>> other >>>>>>>>>> test() method. >>>>>>>>>> >>>>>>>>>> As for data providers, I believe they are a TestNG thing. Please >>>>>>>>>> add >>>>>>>>>> comments to each source file to describe what the data provider >>>>>>>>>> represents. >>>>>>>>>> >>>>>>>>>> Finally, when you make a "little update", you should give a short >>>>>>>>>> description of what has changed. If you don't, someone who >>>>>>>>>> looked at >>>>>>>>>> the previous version has no idea what changed and will have to >>>>>>>>>> look at >>>>>>>>>> everything again. >>>>>>>>>> >>>>>>>>>> Alex >>>>>>>>>> >>>>>>>>>> On 5/21/2013 3:10 AM, Charlie Wang wrote: >>>>>>>>>>> Yes, that make sense. What do you think if I combine the >>>>>>>>>>> tests? It >>>>>>>>>>> would >>>>>>>>>>> then have 1 unified data provider and test method, thus solve >>>>>>>>>>> the 2 >>>>>>>>>>> problems. >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Charlie >>>>>>>>>>> On 2013/5/21 14:56, Werner Dietl wrote: >>>>>>>>>>>> I agree with Alex's first two comments. The code duplication >>>>>>>>>>>> for the >>>>>>>>>>>> test logic and all the different annotation types seems hard to >>>>>>>>>>>> maintain and update. >>>>>>>>>>>> >>>>>>>>>>>> cu, WMD. >>>>>>>>>>>> >>>>>>>>>>>> On Mon, May 20, 2013 at 7:56 PM, Charlie Wang >>>>>>>>>>>> wrote: >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> Here's the latest one with a little update: >>>>>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.03/ >>>>>>>>>>>>> Please provide comments as soon as possible now that due >>>>>>>>>>>>> date is >>>>>>>>>>>>> approaching. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Regards, >>>>>>>>>>>>> Charlie >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On 2013/5/19 14:10, Charlie Wang wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> Here's test for core reflection support of type-annotations >>>>>>>>>>>>> JDK-8013497. >>>>>>>>>>>>> Please take a look. >>>>>>>>>>>>> >>>>>>>>>>>>> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/ >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Regards, >>>>>>>>>>>>> Charlie >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>> >>>> >>> > From wdietl at gmail.com Thu Jun 20 13:20:20 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 20 Jun 2013 20:20:20 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 6 new changesets Message-ID: <20130620202047.9F20548382@hg.openjdk.java.net> Changeset: d0add7016434 Author: amurillo Date: 2013-06-07 09:33 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/d0add7016434 8016078: new hotspot build - hs25-b37 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f2110083203d Author: sla Date: 2013-06-10 11:30 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f2110083203d 8005849: JEP 167: Event-Based JVM Tracing Reviewed-by: acorn, coleenp, sla Contributed-by: Karen Kinnear , Bengt Rutisson , Calvin Cheung , Erik Gahlin , Erik Helin , Jesper Wilhelmsson , Keith McGuigan , Mattias Tobiasson , Markus Gronlund , Mikael Auno , Nils Eliasson , Nils Loodin , Rickard Backman , Staffan Larsen , Stefan Karlsson , Yekaterina Kantserova ! make/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/minimal1.make ! make/bsd/makefiles/top.make + make/bsd/makefiles/trace.make ! make/bsd/makefiles/vm.make ! make/defs.make ! make/excludeSrc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/minimal1.make ! make/linux/makefiles/top.make + make/linux/makefiles/trace.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/top.make + make/solaris/makefiles/trace.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/create_obj_files.sh ! make/windows/makefiles/generated.make ! make/windows/makefiles/projectcreator.make + make/windows/makefiles/trace.make ! make/windows/makefiles/vm.make ! make/windows/projectfiles/common/Makefile ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.hpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/linux/vm/osThread_linux.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/solaris/vm/osThread_solaris.cpp ! src/os/solaris/vm/osThread_solaris.hpp ! src/os/solaris/vm/os_share_solaris.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/thread_bsd_x86.cpp ! src/os_cpu/bsd_x86/vm/thread_bsd_x86.hpp ! src/os_cpu/linux_x86/vm/thread_linux_x86.cpp ! src/os_cpu/linux_x86/vm/thread_linux_x86.hpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/thread_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/thread_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/thread_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/thread_windows_x86.cpp ! src/os_cpu/windows_x86/vm/thread_windows_x86.hpp ! src/share/tools/ProjectCreator/BuildConfig.java ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp + src/share/vm/gc_implementation/g1/evacuationInfo.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.hpp ! src/share/vm/gc_implementation/g1/g1MonitoringSupport.hpp + src/share/vm/gc_implementation/g1/g1YCTypes.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp + src/share/vm/gc_implementation/shared/copyFailedInfo.hpp + src/share/vm/gc_implementation/shared/gcHeapSummary.hpp + src/share/vm/gc_implementation/shared/gcTimer.cpp + src/share/vm/gc_implementation/shared/gcTimer.hpp + src/share/vm/gc_implementation/shared/gcTrace.cpp + src/share/vm/gc_implementation/shared/gcTrace.hpp + src/share/vm/gc_implementation/shared/gcTraceSend.cpp + src/share/vm/gc_implementation/shared/gcTraceTime.cpp + src/share/vm/gc_implementation/shared/gcTraceTime.hpp + src/share/vm/gc_implementation/shared/gcWhen.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp + src/share/vm/gc_interface/allocTracer.cpp + src/share/vm/gc_interface/allocTracer.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/gc_interface/gcCause.cpp ! src/share/vm/gc_interface/gcCause.hpp + src/share/vm/gc_interface/gcName.hpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/generation.cpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp + src/share/vm/memory/klassInfoClosure.hpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp + src/share/vm/memory/referenceProcessorStats.hpp + src/share/vm/memory/referenceType.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/matcher.cpp + src/share/vm/opto/phasetype.hpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiGen.java ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/frame.inline.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/objectMonitor.cpp ! src/share/vm/runtime/objectMonitor.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/perfData.hpp ! src/share/vm/runtime/stubRoutines.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/task.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/timer.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_operations.hpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/memBaseline.cpp + src/share/vm/trace/noTraceBackend.hpp + src/share/vm/trace/trace.dtd + src/share/vm/trace/trace.xml + src/share/vm/trace/traceBackend.hpp + src/share/vm/trace/traceDataTypes.hpp + src/share/vm/trace/traceEvent.hpp + src/share/vm/trace/traceEventClasses.xsl + src/share/vm/trace/traceEventIds.xsl - src/share/vm/trace/traceEventTypes.hpp ! src/share/vm/trace/traceMacros.hpp + src/share/vm/trace/traceStream.hpp + src/share/vm/trace/traceTime.hpp + src/share/vm/trace/traceTypes.xsl + src/share/vm/trace/tracetypes.xml ! src/share/vm/trace/tracing.hpp + src/share/vm/trace/xinclude.mod + src/share/vm/trace/xsl_util.xsl ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/macros.hpp Changeset: 69689078dff8 Author: amurillo Date: 2013-06-13 23:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/69689078dff8 Merge - src/share/vm/trace/traceEventTypes.hpp Changeset: 5d65c078cd0a Author: amurillo Date: 2013-06-13 23:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5d65c078cd0a Added tag hs25-b37 for changeset 69689078dff8 ! .hgtags Changeset: 3a0774193f71 Author: chegar Date: 2013-06-19 11:02 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3a0774193f71 Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/prims/jvm.cpp - src/share/vm/trace/traceEventTypes.hpp Changeset: 61d28ae30cb9 Author: wmdietl Date: 2013-06-20 13:19 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/61d28ae30cb9 Automated merge with http://hg.openjdk.java.net/jdk8/tl/hotspot ! .hgtags From wdietl at gmail.com Thu Jun 20 13:22:44 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 20 Jun 2013 20:22:44 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 2 new changesets Message-ID: <20130620202254.97AB148384@hg.openjdk.java.net> Changeset: 21d9cbbb7bf3 Author: mfang Date: 2013-06-18 22:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/21d9cbbb7bf3 8016824: jdk8 l10n resource file translation update 3 - jaxp Reviewed-by: joehw ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/DatatypeMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/JAXPValidationMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/SAXMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XIncludeMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSchemaMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XMLSerializerMessages_zh_TW.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_de.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_es.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_fr.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_it.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_ja.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_ko.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_pt_BR.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_sv.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_zh_CN.properties ! src/com/sun/org/apache/xerces/internal/impl/msg/XPointerMessages_zh_TW.properties + src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_de.properties + src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_es.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_fr.properties + src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_it.properties ! src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_ja.properties + src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_ko.properties + src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_pt_BR.properties + src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_sv.properties + src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_zh_CN.properties + src/com/sun/org/apache/xerces/internal/impl/xpath/regex/message_zh_TW.properties Changeset: 657818c01f86 Author: wmdietl Date: 2013-06-20 13:22 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/657818c01f86 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxp From wdietl at gmail.com Thu Jun 20 13:23:13 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 20 Jun 2013 20:23:13 +0000 Subject: hg: type-annotations/type-annotations/corba: 2 new changesets Message-ID: <20130620202317.1B19248385@hg.openjdk.java.net> Changeset: d406edd4f6fd Author: mfang Date: 2013-06-18 20:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/d406edd4f6fd 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ko.properties ! src/share/classes/com/sun/tools/corba/se/idl/idl_zh_CN.prp ! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_ja.prp Changeset: c34bddc68ed8 Author: wmdietl Date: 2013-06-20 13:22 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/c34bddc68ed8 Automated merge with http://hg.openjdk.java.net/jdk8/tl/corba From wdietl at gmail.com Thu Jun 20 13:19:09 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 20 Jun 2013 20:19:09 +0000 Subject: hg: type-annotations/type-annotations/jdk: 28 new changesets Message-ID: <20130620202732.0C2CD48386@hg.openjdk.java.net> Changeset: ba544aab1fcd Author: bpb Date: 2013-06-18 11:36 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ba544aab1fcd 8015395: NumberFormatException during startup if JDK-internal property java.lang.Integer.IntegerCache.high set to bad value Summary: Fall back to default if a bad value is passed for this property. Reviewed-by: mduigou ! src/share/classes/java/lang/Integer.java Changeset: eb1a3c50a2a9 Author: mduigou Date: 2013-06-18 14:11 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/eb1a3c50a2a9 Merge Changeset: 1f7cbe4829fe Author: mduigou Date: 2013-06-18 16:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1f7cbe4829fe 8016446: Improve forEach/replaceAll for Map, HashMap, Hashtable, IdentityHashMap, WeakHashMap, TreeMap, ConcurrentMap Reviewed-by: forax, mduigou, psandoz Contributed-by: Mike Duigou , Remi Forax ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/LinkedHashMap.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/WeakHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentMap.java ! test/java/util/Map/Defaults.java Changeset: 2d9da733014f Author: xuelei Date: 2013-06-18 18:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2d9da733014f 8000456: Add programmatic deadlock detection in SSLEngineDeadlock Reviewed-by: wetmore ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineDeadlock.java Changeset: d82773b770ce Author: mfang Date: 2013-06-18 21:08 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d82773b770ce 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang ! src/macosx/classes/com/apple/laf/resources/aqua_pt_BR.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ja.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ko.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_pt_BR.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_sv.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_CN.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_CN.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_TW.java ! src/share/classes/sun/launcher/resources/launcher_de.properties ! src/share/classes/sun/launcher/resources/launcher_es.properties ! src/share/classes/sun/launcher/resources/launcher_fr.properties ! src/share/classes/sun/launcher/resources/launcher_it.properties ! src/share/classes/sun/launcher/resources/launcher_ja.properties ! src/share/classes/sun/launcher/resources/launcher_ko.properties ! src/share/classes/sun/launcher/resources/launcher_pt_BR.properties ! src/share/classes/sun/launcher/resources/launcher_sv.properties ! src/share/classes/sun/launcher/resources/launcher_zh_CN.properties ! src/share/classes/sun/launcher/resources/launcher_zh_TW.properties ! src/share/classes/sun/security/util/AuthResources_zh_CN.java ! src/share/classes/sun/security/util/Resources_de.java ! src/share/classes/sun/security/util/Resources_es.java ! src/share/classes/sun/security/util/Resources_fr.java ! src/share/classes/sun/security/util/Resources_it.java ! src/share/classes/sun/security/util/Resources_ja.java ! src/share/classes/sun/security/util/Resources_ko.java ! src/share/classes/sun/security/util/Resources_pt_BR.java ! src/share/classes/sun/security/util/Resources_sv.java ! src/share/classes/sun/security/util/Resources_zh_CN.java ! src/share/classes/sun/security/util/Resources_zh_TW.java ! src/share/classes/sun/tools/jar/resources/jar_de.properties ! src/share/classes/sun/tools/jar/resources/jar_es.properties ! src/share/classes/sun/tools/jar/resources/jar_fr.properties ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/share/classes/sun/tools/jar/resources/jar_ja.properties ! src/share/classes/sun/tools/jar/resources/jar_ko.properties ! src/share/classes/sun/tools/jar/resources/jar_pt_BR.properties ! src/share/classes/sun/tools/jar/resources/jar_sv.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_CN.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_TW.properties ! src/share/classes/sun/tools/serialver/serialver_zh_CN.properties ! src/share/classes/sun/util/logging/resources/logging_de.properties ! src/share/classes/sun/util/logging/resources/logging_es.properties ! src/share/classes/sun/util/logging/resources/logging_fr.properties ! src/share/classes/sun/util/logging/resources/logging_it.properties ! src/share/classes/sun/util/logging/resources/logging_ja.properties ! src/share/classes/sun/util/logging/resources/logging_ko.properties ! src/share/classes/sun/util/logging/resources/logging_pt_BR.properties ! src/share/classes/sun/util/logging/resources/logging_sv.properties ! src/share/classes/sun/util/logging/resources/logging_zh_CN.properties ! src/share/classes/sun/util/logging/resources/logging_zh_TW.properties Changeset: a76858faad59 Author: xuelei Date: 2013-06-19 02:33 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a76858faad59 7188658: Add possibility to disable client initiated renegotiation Reviewed-by: weijun, wetmore ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NoImpactServerRenego.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/RejectClientRenego.java Changeset: 22337da71eca Author: chegar Date: 2013-06-19 11:47 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/22337da71eca 8017044: anti-delta fix for 8015402 Reviewed-by: alanb ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java Changeset: 8bc1b313a082 Author: chegar Date: 2013-06-19 13:03 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8bc1b313a082 Merge Changeset: 9b802d99cb52 Author: bpb Date: 2013-06-19 08:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9b802d99cb52 4837946: Faster multiplication and exponentiation of large integers 4646474: BigInteger.pow() algorithm slow in 1.4.0 Summary: Implement Karatsuba and 3-way Toom-Cook multiplication as well as exponentiation using Karatsuba and Toom-Cook squaring. Reviewed-by: alanb, bpb, martin Contributed-by: Alan Eliasen ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/BigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java Changeset: e7ece2dbdc70 Author: sla Date: 2013-06-10 11:33 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e7ece2dbdc70 8005008: Add Java Flight Recorder Phase II Reviewed-by: erikj Contributed-by: Karen Kinnear , Bengt Rutisson , Calvin Cheung , Erik Gahlin , Erik Helin , Jesper Wilhelmsson , Keith McGuigan , Mattias Tobiasson , Markus Gronlund , Mikael Auno , Nils Eliasson , Nils Loodin , Rickard Backman , Staffan Larsen , Stefan Karlsson , Yekaterina Kantserova ! make/com/oracle/jfr/Makefile ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyFiles.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/mapfiles/libjfr/mapfile-vers ! makefiles/mapfiles/libjli/mapfile-vers ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 1f855dd74077 Author: amurillo Date: 2013-06-14 07:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1f855dd74077 Merge ! makefiles/CompileNativeLibraries.gmk ! makefiles/CreateJars.gmk Changeset: c3087d966f1f Author: chegar Date: 2013-06-19 11:04 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c3087d966f1f Merge ! src/share/lib/security/java.security-linux ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: a5735e6d6616 Author: chegar Date: 2013-06-19 11:49 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a5735e6d6616 Merge Changeset: a9ad5ac3430b Author: chegar Date: 2013-06-19 15:58 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a9ad5ac3430b 8017057: More ProblemList.txt updates (6/2013) Reviewed-by: alanb ! test/ProblemList.txt Changeset: 8fd1e39b1c2b Author: chegar Date: 2013-06-19 17:32 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8fd1e39b1c2b Merge Changeset: f6d72c4f6bf1 Author: dxu Date: 2013-06-19 13:00 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f6d72c4f6bf1 8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java Summary: Add hashCode() methods to ListenerInfo and WildcardListenerInfo classes Reviewed-by: dfuchs, alanb, sjiang, chegar ! src/share/classes/javax/management/NotificationBroadcasterSupport.java Changeset: de6b93fd6d23 Author: khazra Date: 2013-06-19 14:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/de6b93fd6d23 8016576: Overrides warnings in jdi and jconsole Summary: Implement hashCode() in classes emitting warnings Reviewed-by: alanb, chegar ! src/share/classes/com/sun/tools/jdi/SDE.java ! src/share/classes/sun/tools/jconsole/inspector/XObject.java Changeset: e1b18a666f76 Author: khazra Date: 2013-06-19 14:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e1b18a666f76 8016698: Cleanup overrides warning in sun/tools/ClassDeclaration.java Summary: Override Object.hashCode() Reviewed-by: alanb, chegar ! src/share/classes/sun/tools/java/ClassDeclaration.java Changeset: 2b156531b7eb Author: arieber Date: 2013-06-19 17:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2b156531b7eb 7025238: HttpURLConnection does not handle URLs with an empty path component. Summary: Prepend a '/' to file when path is empty Reviewed-by: chegar, khazra ! src/share/classes/sun/net/www/http/HttpClient.java + test/sun/net/www/http/HttpClient/B7025238.java Changeset: 656ea2349aa5 Author: psandoz Date: 2013-06-20 10:45 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/656ea2349aa5 8016308: Updates to j.u.stream.Node/Nodes Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! src/share/classes/java/util/stream/Node.java ! src/share/classes/java/util/stream/Nodes.java ! src/share/classes/java/util/stream/SliceOps.java ! test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java ! test/java/util/stream/boottest/java/util/stream/IntNodeTest.java ! test/java/util/stream/boottest/java/util/stream/LongNodeTest.java Changeset: 85524d9839dc Author: psandoz Date: 2013-06-20 11:02 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/85524d9839dc 8016324: filter/flatMap pipeline sinks should pass size information to downstream sink Reviewed-by: chegar, mduigou Contributed-by: Brian Goetz ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/ReferencePipeline.java Changeset: f758d7c24396 Author: psandoz Date: 2013-06-20 11:15 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f758d7c24396 8016455: Sync stream tests from lambda to tl Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! test/java/util/stream/bootlib/java/util/stream/IntStreamTestDataProvider.java ! test/java/util/stream/bootlib/java/util/stream/LambdaTestHelpers.java + test/java/util/stream/bootlib/java/util/stream/LoggingTestCase.java ! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java ! test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java ! test/java/util/stream/boottest/java/util/stream/DoubleNodeTest.java ! test/java/util/stream/boottest/java/util/stream/IntNodeTest.java ! test/java/util/stream/boottest/java/util/stream/LongNodeTest.java ! test/java/util/stream/boottest/java/util/stream/NodeTest.java ! test/java/util/stream/boottest/java/util/stream/UnorderedTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ForEachOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/GroupByOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntSliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/IntUniqOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/MatchOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/RangeTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ReduceByOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamLinkTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamSpliteratorTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/ToArrayOpTest.java Changeset: 562f5cf13a9c Author: psandoz Date: 2013-06-20 11:21 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/562f5cf13a9c 8016139: PrimitiveIterator.forEachRemaining Reviewed-by: alanb ! src/share/classes/java/util/PrimitiveIterator.java Changeset: a44bd993ce93 Author: xuelei Date: 2013-06-20 07:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a44bd993ce93 8017157: catch more exception in test RejectClientRenego Reviewed-by: vinnie ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/RejectClientRenego.java Changeset: 49b78ec058fb Author: mduigou Date: 2013-06-20 07:23 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/49b78ec058fb 8017088: Map/HashMap.compute() incorrect with key mapping to null value Reviewed-by: dl, dholmes, plevart ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Map.java ! test/java/util/Map/Defaults.java Changeset: 9fa37bd38d4b Author: mduigou Date: 2013-06-20 08:21 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9fa37bd38d4b Merge Changeset: bf2bacf934d1 Author: chegar Date: 2013-06-20 18:53 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bf2bacf934d1 8014499: MulticastSocket should enable IP_MULTICAST_ALL (lnx) Reviewed-by: alanb, chegar Contributed-by: John Zavgren , Chris Hegarty ! src/solaris/native/java/net/PlainDatagramSocketImpl.c + test/java/net/MulticastSocket/Promiscuous.java Changeset: ed4adf4cf4e7 Author: wmdietl Date: 2013-06-20 13:18 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ed4adf4cf4e7 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk From wdietl at gmail.com Thu Jun 20 13:20:32 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 20 Jun 2013 20:20:32 +0000 Subject: hg: type-annotations/type-annotations/langtools: 7 new changesets Message-ID: <20130620202122.55A0F48383@hg.openjdk.java.net> Changeset: 792c40d5185a Author: mfang Date: 2013-06-18 20:56 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/792c40d5185a 8015657: jdk8 l10n resource file translation update 3 Reviewed-by: yhuang ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_ja.properties ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_zh_CN.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_ja.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_zh_CN.properties + src/share/classes/com/sun/tools/doclint/resources/doclint_ja.properties + src/share/classes/com/sun/tools/doclint/resources/doclint_zh_CN.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/resources/javac_ja.properties ! src/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties ! src/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties + src/share/classes/com/sun/tools/javap/resources/javap_ja.properties + src/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties + src/share/classes/com/sun/tools/jdeps/resources/jdeps_ja.properties + src/share/classes/com/sun/tools/jdeps/resources/jdeps_zh_CN.properties Changeset: 6d3b33aea370 Author: vromero Date: 2013-06-19 11:09 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/6d3b33aea370 8006981: javac, method toString() of class ...javac.code.Flags doesn't print all the flag bits Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Check.java Changeset: be62183f938a Author: chegar Date: 2013-06-19 11:48 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/be62183f938a 8017045: anti-delta fix for 8013789 Reviewed-by: alanb ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! test/tools/javac/lambda/lambdaExpression/LambdaTest6.java ! test/tools/javac/lambda/methodReference/BridgeMethod.java Changeset: 29dcd6715b04 Author: chegar Date: 2013-06-19 13:00 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/29dcd6715b04 Merge ! src/share/classes/com/sun/tools/javac/comp/Check.java Changeset: be10ac0081b2 Author: vromero Date: 2013-06-19 22:07 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/be10ac0081b2 8016610: javac, add new internal symbols to make operator resolution faster Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java Changeset: 6debfa63a4a1 Author: vromero Date: 2013-06-20 08:45 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/6debfa63a4a1 8016613: javac should avoid source 8 only analysis when compiling for source 7 Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java Changeset: 8f5f40451ae8 Author: wmdietl Date: 2013-06-20 13:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/8f5f40451ae8 Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java From wdietl at gmail.com Thu Jun 20 13:19:20 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 20 Jun 2013 20:19:20 +0000 Subject: hg: type-annotations/type-annotations: 2 new changesets Message-ID: <20130620201921.30D8948380@hg.openjdk.java.net> Changeset: b9587f41fd55 Author: smarks Date: 2013-06-18 17:18 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/b9587f41fd55 8016780: README-builds.html misses crucial requirement on bootstrap JDK Reviewed-by: dholmes, chegar ! README-builds.html Changeset: e3b7300bcecf Author: wmdietl Date: 2013-06-20 13:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/e3b7300bcecf Automated merge with http://hg.openjdk.java.net/jdk8/tl/ From steve.sides at oracle.com Fri Jun 21 10:38:14 2013 From: steve.sides at oracle.com (Steve Sides) Date: Fri, 21 Jun 2013 10:38:14 -0700 Subject: 8006733 : allow type annotations only on type uses, not on scoping Message-ID: <51C48F86.6020303@oracle.com> Hi Werner, I see this open bug, http://bugs.sun.com/view_bug.do?bug_id=8006733, has a note on the current test failures wiki as relates to the test, tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java I think the last day for fixing P4 is early-mid July, so a couple question, Is this currently being looked at? Since this is a new feature, and there are few open bugs, it'd be nice if this fix gets in for jdk8. If this will take longer, might we up the priority to P3? -steve -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/type-annotations-dev/attachments/20130621/35ee94e7/attachment.html From wdietl at gmail.com Fri Jun 21 14:23:35 2013 From: wdietl at gmail.com (Werner Dietl) Date: Fri, 21 Jun 2013 14:23:35 -0700 Subject: 8006733 : allow type annotations only on type uses, not on scoping In-Reply-To: <51C48F86.6020303@oracle.com> References: <51C48F86.6020303@oracle.com> Message-ID: Hi Steve, Alex wants to raise the correct behavior for CantAnnotateStaticClass with the EG. I don't know what timeline he/the EG has. I don't know about the difference between P3 and P4 and what the different timelines and other implications are. Maybe somebody else can comment on this. cu, WMD. On Fri, Jun 21, 2013 at 10:38 AM, Steve Sides wrote: > Hi Werner, > I see this open bug, http://bugs.sun.com/view_bug.do?bug_id=8006733, > has a note on the current test failures wiki as relates to the test, > tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java > > I think the last day for fixing P4 is early-mid July, so a couple question, > Is this currently being looked at? Since this is a new feature, and there > are few open bugs, it'd be nice if this fix gets in for jdk8. If this will > take longer, might we up the priority to P3? > > > -steve -- http://www.google.com/profiles/wdietl From alex.buckley at oracle.com Fri Jun 21 14:29:51 2013 From: alex.buckley at oracle.com (Alex Buckley) Date: Fri, 21 Jun 2013 14:29:51 -0700 Subject: 8006733 : allow type annotations only on type uses, not on scoping In-Reply-To: References: <51C48F86.6020303@oracle.com> Message-ID: <51C4C5CF.7020306@oracle.com> Mike is unavailable until July, so I will raise the issue as soon as he returns. I am sorry for the delay but there is little alternative. Alex On 6/21/2013 2:23 PM, Werner Dietl wrote: > Hi Steve, > > Alex wants to raise the correct behavior for CantAnnotateStaticClass > with the EG. I don't know what timeline he/the EG has. > > I don't know about the difference between P3 and P4 and what the > different timelines and other implications are. Maybe somebody else > can comment on this. > > cu, WMD. > > On Fri, Jun 21, 2013 at 10:38 AM, Steve Sides wrote: >> Hi Werner, >> I see this open bug, http://bugs.sun.com/view_bug.do?bug_id=8006733, >> has a note on the current test failures wiki as relates to the test, >> tools/javac/annotations/typeAnnotations/failures/CantAnnotateStaticClass.java >> >> I think the last day for fixing P4 is early-mid July, so a couple question, >> Is this currently being looked at? Since this is a new feature, and there >> are few open bugs, it'd be nice if this fix gets in for jdk8. If this will >> take longer, might we up the priority to P3? >> >> >> -steve > > > From wdietl at gmail.com Fri Jun 21 16:48:22 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Fri, 21 Jun 2013 23:48:22 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 7 new changesets Message-ID: <20130621234830.0D78F4840C@hg.openjdk.java.net> Changeset: 6a75a505301f Author: sundar Date: 2013-06-18 18:43 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/6a75a505301f 8012698: [nashorn] tests fail to run with agentvm or samevm Reviewed-by: hannesw, jlaskey ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/MethodAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/NumberBoxingTest.java ! test/src/jdk/nashorn/api/javaaccess/ObjectAccessTest.java ! test/src/jdk/nashorn/api/javaaccess/StringAccessTest.java Changeset: 7276d66b7118 Author: jlaskey Date: 2013-06-19 09:10 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/7276d66b7118 8010697: DeletedArrayFilter seems to leak memory Reviewed-by: hannesw, sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/DeletedRangeArrayFilter.java ! src/jdk/nashorn/internal/runtime/arrays/ObjectArrayData.java ! src/jdk/nashorn/internal/runtime/arrays/SparseArrayData.java + test/script/basic/JDK-8010697.js + test/script/basic/JDK-8010697.js.EXPECTED Changeset: c7c9222cfe69 Author: sundar Date: 2013-06-19 21:07 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/c7c9222cfe69 8015347: Parsing issue with decodeURIComponent Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/URIUtils.java + test/script/basic/JDK-8015347.js Changeset: ac404bf3f8c8 Author: sundar Date: 2013-06-20 13:45 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/ac404bf3f8c8 8017046: Cannot assign undefined to a function argument if the function uses arguments object Reviewed-by: hannesw ! src/jdk/nashorn/internal/objects/NativeArguments.java + test/script/basic/JDK-8017046.js Changeset: c7672e621b14 Author: sundar Date: 2013-06-20 17:34 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/c7672e621b14 Merge Changeset: 8e03121cc286 Author: sundar Date: 2013-06-21 16:55 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/8e03121cc286 8017260: adjust lookup code in objects.* classes Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java Changeset: b4e2bccf9598 Author: sundar Date: 2013-06-21 17:33 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/b4e2bccf9598 Merge From wdietl at gmail.com Fri Jun 21 16:47:38 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Fri, 21 Jun 2013 23:47:38 +0000 Subject: hg: type-annotations/type-annotations/jdk: 6 new changesets Message-ID: <20130621234956.85A594840E@hg.openjdk.java.net> Changeset: cd06fc069152 Author: alanb Date: 2013-06-20 19:14 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cd06fc069152 8014377: (dc) DatagramChannel should set IP_MULTICAST_ALL=0 (lnx) Reviewed-by: chegar, jzavgren ! src/solaris/native/sun/nio/ch/Net.c + test/java/nio/channels/DatagramChannel/Promiscuous.java Changeset: 4503e04141f7 Author: weijun Date: 2013-06-21 18:26 +0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4503e04141f7 8001326: Improve Kerberos caching Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/krb5/AcceptSecContextToken.java ! src/share/classes/sun/security/krb5/EncryptionKey.java ! src/share/classes/sun/security/krb5/KrbApRep.java ! src/share/classes/sun/security/krb5/KrbApReq.java + src/share/classes/sun/security/krb5/internal/ReplayCache.java + src/share/classes/sun/security/krb5/internal/rcache/AuthList.java ! src/share/classes/sun/security/krb5/internal/rcache/AuthTime.java + src/share/classes/sun/security/krb5/internal/rcache/AuthTimeWithHash.java - src/share/classes/sun/security/krb5/internal/rcache/CacheTable.java + src/share/classes/sun/security/krb5/internal/rcache/DflCache.java + src/share/classes/sun/security/krb5/internal/rcache/MemoryCache.java - src/share/classes/sun/security/krb5/internal/rcache/ReplayCache.java + test/java/security/testlibrary/Proc.java ! test/sun/security/krb5/auto/AcceptorSubKey.java + test/sun/security/krb5/auto/BasicProc.java ! test/sun/security/krb5/auto/Context.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/NoneReplayCacheTest.java - test/sun/security/krb5/auto/ReplayCache.java + test/sun/security/krb5/auto/ReplayCacheExpunge.java + test/sun/security/krb5/auto/ReplayCachePrecise.java + test/sun/security/krb5/auto/ReplayCacheTest.java + test/sun/security/krb5/auto/ReplayCacheTestProc.java ! test/sun/security/krb5/ccache/EmptyCC.java Changeset: a88f6f4d279f Author: bpb Date: 2013-06-21 11:12 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a88f6f4d279f 7192954: Fix Float.parseFloat to round correctly and preserve monotonicity. 4396272: Parsing doubles fails to follow IEEE for largest decimal that should yield 0 7039391: Use Math.ulp in FloatingDecimal Summary: Correct rounding and monotonicity problems in floats and doubles Reviewed-by: bpb, martin Contributed-by: Dmitry Nadezhin , Louis Wasserman ! src/share/classes/sun/misc/FDBigInteger.java ! src/share/classes/sun/misc/FloatingDecimal.java ! test/java/lang/Double/ParseDouble.java ! test/java/lang/Float/ParseFloat.java ! test/sun/misc/FloatingDecimal/TestFDBigInteger.java Changeset: 814759462705 Author: bpb Date: 2013-06-21 11:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/814759462705 7131192: BigInteger.doubleValue() is depressingly slow Summary: In doubleValue() and floatValue() replace converting to String and parsing to Double or Float with direct conversion into IEEE 754 bits. Reviewed-by: bpb, drchase, martin Contributed-by: Louis Wasserman ! src/share/classes/java/math/BigInteger.java + test/java/math/BigInteger/PrimitiveConversionTests.java Changeset: 8b84d557570c Author: naoto Date: 2013-06-21 13:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8b84d557570c 6863624: java/util/Currency/PropertiesTest.sh writable check is incorrect Reviewed-by: alanb ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: 87589884dd59 Author: wmdietl Date: 2013-06-21 16:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/87589884dd59 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk From wdietl at gmail.com Fri Jun 21 16:47:30 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Fri, 21 Jun 2013 23:47:30 +0000 Subject: hg: type-annotations/type-annotations/langtools: 2 new changesets Message-ID: <20130621234750.E4E694840B@hg.openjdk.java.net> Changeset: e9ebff1840e5 Author: emc Date: 2013-06-20 19:01 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e9ebff1840e5 8007546: ClassCastException on JSR308 tests 8015993: jck-compiler tests are failed with java.lang.ClassCastException Summary: Fix ClassCastExceptions arising from addition of AnnotatedType. Reviewed-by: jjg, abuckley ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java Changeset: 02571c510c7b Author: wmdietl Date: 2013-06-21 16:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/02571c510c7b Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java From wdietl at gmail.com Wed Jun 26 23:34:11 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 27 Jun 2013 06:34:11 +0000 Subject: hg: type-annotations/type-annotations/langtools: 10 new changesets Message-ID: <20130627063446.C8EA7485A2@hg.openjdk.java.net> Changeset: bf020de5a6db Author: emc Date: 2013-06-24 22:03 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/bf020de5a6db 8012722: Single comma in array initializer should parse Summary: Annotations of the form @Foo({,}) should parse Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/parser/SingleCommaAnnotationValue.java + test/tools/javac/parser/SingleCommaAnnotationValueFail.java + test/tools/javac/parser/SingleCommaAnnotationValueFail.out Changeset: 831467c4c6a7 Author: vromero Date: 2013-06-25 16:12 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/831467c4c6a7 8017104: javac should have a class for primitive types that inherits from Type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java Changeset: aceae9ceebbe Author: kizune Date: 2013-06-25 20:08 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/aceae9ceebbe 8006973: jtreg test fails: test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java Reviewed-by: ksrini ! test/tools/javac/warnings/AuxiliaryClass/SelfClassWithAux.java Changeset: c2d9303c3477 Author: ksrini Date: 2013-06-26 09:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/c2d9303c3477 8016908: TEST_BUG: removing non-ascii characters causes tests to fail Reviewed-by: jjg, vromero ! test/tools/javac/api/6437999/T6437999.java - test/tools/javac/api/6437999/Utf8.java ! test/tools/javac/api/T6306137.java Changeset: 3b2e10524627 Author: jjg Date: 2013-06-26 18:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/3b2e10524627 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values Reviewed-by: jjg, darcy Contributed-by: matherey.nunez at oracle.com ! test/tools/javac/literals/UnderscoreLiterals.java Changeset: 4fe5aab73bb2 Author: bpatel Date: 2013-06-26 20:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/4fe5aab73bb2 8007338: Method grouping tab line-folding Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java Changeset: 27bd6a2302f6 Author: bpatel Date: 2013-06-26 20:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/27bd6a2302f6 8014017: extra space in javadoc class heading Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java Changeset: 36e8bc1907a2 Author: bpatel Date: 2013-06-26 20:45 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/36e8bc1907a2 8013738: Two javadoc tests have bug 0000000 Reviewed-by: jjg ! test/com/sun/javadoc/testNestedInlineTag/TestNestedInlineTag.java ! test/com/sun/javadoc/testTagMisuse/TestTagMisuse.java Changeset: c674b396827c Author: emc Date: 2013-06-27 00:37 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/c674b396827c 8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters Summary: The compiler does not account fr extra parameters due to inner this parameters Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/Main.java + test/tools/javac/limits/NestedClassConstructorArgs.java + test/tools/javac/limits/NestedClassMethodArgs.java - test/tools/javac/limits/NumArgs1.java - test/tools/javac/limits/NumArgs2.java - test/tools/javac/limits/NumArgs3.java - test/tools/javac/limits/NumArgs4.java + test/tools/javac/limits/NumArgsTest.java + test/tools/javac/limits/StaticNestedClassConstructorArgs.java + test/tools/javac/limits/TopLevelClassConstructorArgs.java + test/tools/javac/limits/TopLevelClassMethodArgs.java + test/tools/javac/limits/TopLevelClassStaticMethodArgs.java Changeset: 0a8bbb5db61a Author: wmdietl Date: 2013-06-27 08:34 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/0a8bbb5db61a Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/tools/javac/api/6437999/T6437999.java From wdietl at gmail.com Wed Jun 26 23:35:42 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 27 Jun 2013 06:35:42 +0000 Subject: hg: type-annotations/type-annotations/jdk: 22 new changesets Message-ID: <20130627064146.9134D485A3@hg.openjdk.java.net> Changeset: cb3f3a05eee3 Author: chegar Date: 2013-06-22 08:14 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cb3f3a05eee3 8017271: Crash may occur in java.net.DualStackPlainSocketImpl::initIDs due to unchecked values returned from JNI functions Reviewed-by: alanb, khazra ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/windows/native/java/net/DualStackPlainSocketImpl.c Changeset: fd050ba1cf72 Author: arieber Date: 2013-06-22 08:20 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fd050ba1cf72 7157360: HttpURLConnection: HTTP method DELETE doesn't support output Reviewed-by: chegar ! src/share/classes/sun/net/www/http/PosterOutputStream.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/http/HttpURLConnection/PostOnDelete.java Changeset: 1bf060029a5d Author: weijun Date: 2013-06-24 16:25 +0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1bf060029a5d 8017453: ReplayCache tests fail on multiple platforms Reviewed-by: xuelei ! test/sun/security/krb5/auto/ReplayCacheExpunge.java ! test/sun/security/krb5/auto/ReplayCacheTestProc.java Changeset: 5f80b8cee601 Author: alanb Date: 2013-06-24 11:26 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5f80b8cee601 8017477: Remove TimeZone.DisplayNames, no longer used Reviewed-by: okutsu ! src/share/classes/java/util/TimeZone.java Changeset: bb2e67628dc0 Author: naoto Date: 2013-06-24 16:21 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bb2e67628dc0 8017468: typo in javadoc: " ResourceBunlde " Reviewed-by: okutsu ! src/share/classes/java/util/spi/LocaleServiceProvider.java Changeset: eabcb85fcabc Author: bpb Date: 2013-06-24 14:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/eabcb85fcabc 6469160: (fmt) general (%g) formatting of zero (0.0) with precision 0 or 1 throws ArrayOutOfBoundsException Summary: For zero value ensure than an unpadded zero character is passed to Formatter.addZeros() Reviewed-by: iris, darcy Contributed-by: Brian Burkhalter ! src/share/classes/java/util/Formatter.java ! src/share/classes/sun/misc/FloatingDecimal.java ! test/java/util/Formatter/Basic-X.java.template ! test/java/util/Formatter/Basic.java ! test/java/util/Formatter/BasicBigDecimal.java ! test/java/util/Formatter/BasicDouble.java ! test/java/util/Formatter/BasicDoubleObject.java ! test/java/util/Formatter/BasicFloat.java ! test/java/util/Formatter/BasicFloatObject.java Changeset: 82e7682c17e2 Author: darcy Date: 2013-06-24 23:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/82e7682c17e2 8017550: Fix doclint issues in java.lang and subpackages Reviewed-by: alanb, chegar ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/StrictMath.java ! src/share/classes/java/lang/SuppressWarnings.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/annotation/Annotation.java ! src/share/classes/java/lang/annotation/Repeatable.java ! src/share/classes/java/lang/annotation/Retention.java ! src/share/classes/java/lang/annotation/Target.java ! src/share/classes/java/lang/reflect/AnnotatedElement.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Parameter.java ! src/share/classes/java/lang/reflect/TypeVariable.java Changeset: 4a4d910e1504 Author: alanb Date: 2013-06-25 13:53 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4a4d910e1504 8017570: jfr.jar should not be in compact3 (for now) Reviewed-by: erikj ! makefiles/profile-includes.txt Changeset: 01fcca3d2b8c Author: bpb Date: 2013-06-20 12:15 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/01fcca3d2b8c 4641897: Faster string conversion of large integers Summary: Accelerate conversion to string by means of Schoenhage recursive base conversion. Reviewed-by: bpb, alanb Contributed-by: Alan Eliasen ! src/share/classes/java/math/BigInteger.java ! test/java/math/BigInteger/BigIntegerTest.java Changeset: 89631a384ee6 Author: weijun Date: 2013-06-25 21:51 +0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/89631a384ee6 8016051: Possible ClassCastException in KdcComm Reviewed-by: weijun Contributed-by: Artem Smotrakov ! src/share/classes/sun/security/krb5/KdcComm.java Changeset: ac61efd8c593 Author: shade Date: 2013-06-25 20:06 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ac61efd8c593 8014233: java.lang.Thread should have @Contended on TLR fields Summary: add the @Contended over three TLR fields. Reviewed-by: psandoz, chegar, dholmes, dl ! src/share/classes/java/lang/Thread.java Changeset: 757290440a2f Author: juh Date: 2013-06-25 14:31 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/757290440a2f 8017325: Cleanup of the javadoc tag in java.security.cert Summary: Convert javadoc ... and ... tags to {@code ...} Reviewed-by: darcy ! src/share/classes/java/security/cert/CRLException.java ! src/share/classes/java/security/cert/CRLSelector.java ! src/share/classes/java/security/cert/CertPath.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathBuilderException.java ! src/share/classes/java/security/cert/CertPathBuilderResult.java ! src/share/classes/java/security/cert/CertPathBuilderSpi.java ! src/share/classes/java/security/cert/CertPathParameters.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertPathValidatorException.java ! src/share/classes/java/security/cert/CertPathValidatorResult.java ! src/share/classes/java/security/cert/CertPathValidatorSpi.java ! src/share/classes/java/security/cert/CertSelector.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/java/security/cert/CertStoreException.java ! src/share/classes/java/security/cert/CertStoreParameters.java ! src/share/classes/java/security/cert/CertStoreSpi.java ! src/share/classes/java/security/cert/Certificate.java ! src/share/classes/java/security/cert/CertificateEncodingException.java ! src/share/classes/java/security/cert/CertificateException.java ! src/share/classes/java/security/cert/CertificateExpiredException.java ! src/share/classes/java/security/cert/CertificateFactory.java ! src/share/classes/java/security/cert/CertificateFactorySpi.java ! src/share/classes/java/security/cert/CertificateNotYetValidException.java ! src/share/classes/java/security/cert/CertificateParsingException.java ! src/share/classes/java/security/cert/CertificateRevokedException.java ! src/share/classes/java/security/cert/CollectionCertStoreParameters.java ! src/share/classes/java/security/cert/Extension.java ! src/share/classes/java/security/cert/LDAPCertStoreParameters.java ! src/share/classes/java/security/cert/PKIXBuilderParameters.java ! src/share/classes/java/security/cert/PKIXCertPathBuilderResult.java ! src/share/classes/java/security/cert/PKIXCertPathChecker.java ! src/share/classes/java/security/cert/PKIXCertPathValidatorResult.java ! src/share/classes/java/security/cert/PKIXParameters.java ! src/share/classes/java/security/cert/PKIXReason.java ! src/share/classes/java/security/cert/PolicyNode.java ! src/share/classes/java/security/cert/PolicyQualifierInfo.java ! src/share/classes/java/security/cert/TrustAnchor.java ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509CRLEntry.java ! src/share/classes/java/security/cert/X509CRLSelector.java ! src/share/classes/java/security/cert/X509CertSelector.java ! src/share/classes/java/security/cert/X509Certificate.java ! src/share/classes/java/security/cert/X509Extension.java Changeset: 3700bb58c9a2 Author: juh Date: 2013-06-25 14:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3700bb58c9a2 8017326: Cleanup of the javadoc tag in java.security.spec Summary: Convert javadoc and tags to {@code ...} Reviewed-by: darcy ! src/share/classes/java/security/spec/DSAGenParameterSpec.java ! src/share/classes/java/security/spec/DSAParameterSpec.java ! src/share/classes/java/security/spec/DSAPrivateKeySpec.java ! src/share/classes/java/security/spec/DSAPublicKeySpec.java ! src/share/classes/java/security/spec/ECFieldF2m.java ! src/share/classes/java/security/spec/ECFieldFp.java ! src/share/classes/java/security/spec/ECGenParameterSpec.java ! src/share/classes/java/security/spec/ECParameterSpec.java ! src/share/classes/java/security/spec/ECPoint.java ! src/share/classes/java/security/spec/ECPrivateKeySpec.java ! src/share/classes/java/security/spec/ECPublicKeySpec.java ! src/share/classes/java/security/spec/EllipticCurve.java ! src/share/classes/java/security/spec/EncodedKeySpec.java ! src/share/classes/java/security/spec/InvalidKeySpecException.java ! src/share/classes/java/security/spec/KeySpec.java ! src/share/classes/java/security/spec/MGF1ParameterSpec.java ! src/share/classes/java/security/spec/PKCS8EncodedKeySpec.java ! src/share/classes/java/security/spec/PSSParameterSpec.java ! src/share/classes/java/security/spec/RSAKeyGenParameterSpec.java ! src/share/classes/java/security/spec/RSAMultiPrimePrivateCrtKeySpec.java ! src/share/classes/java/security/spec/RSAOtherPrimeInfo.java ! src/share/classes/java/security/spec/RSAPrivateCrtKeySpec.java ! src/share/classes/java/security/spec/X509EncodedKeySpec.java Changeset: 510035b7bbbb Author: yhuang Date: 2013-06-25 21:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/510035b7bbbb 8013836: getFirstDayOfWeek reports wrong day for pt-BR locale Reviewed-by: naoto + src/share/classes/sun/util/resources/pt/CalendarData_pt_BR.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 0822bcddbd4f Author: xuelei Date: 2013-06-26 06:32 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0822bcddbd4f 8017049: rename property jdk.tls.rejectClientInitializedRenego Reviewed-by: vinnie, wetmore, mullan ! src/share/classes/sun/security/ssl/Handshaker.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NoImpactServerRenego.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/RejectClientRenego.java Changeset: e83cdd58f1cf Author: chegar Date: 2013-06-26 15:30 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e83cdd58f1cf 8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum) Reviewed-by: chegar, alanb, psandoz Contributed-by: Doug Lea
    , Tristan Yan , Chris Hegarty + src/share/classes/java/util/ArrayPrefixHelpers.java ! src/share/classes/java/util/Arrays.java + test/java/util/Arrays/ParallelPrefix.java Changeset: 71059bca036a Author: rfield Date: 2013-06-26 07:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/71059bca036a 8016761: Lambda metafactory - incorrect type conversion of constructor method handle Reviewed-by: jrose ! src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + test/java/lang/invoke/lambda/LambdaConstructorMethodHandleUnbox.java Changeset: 336e5a862013 Author: naoto Date: 2013-06-26 11:21 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/336e5a862013 8017322: java/util/Currency/PropertiesTest.sh should run exclusively Reviewed-by: alanb ! test/TEST.ROOT Changeset: 1fda8fa7ae97 Author: darcy Date: 2013-06-26 13:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1fda8fa7ae97 7018139: Fix HTML accessibility and doclint issues in java.math Reviewed-by: lancea, bpb ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/RoundingMode.java Changeset: a5aa57eb85b6 Author: darcy Date: 2013-06-26 19:09 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a5aa57eb85b6 8019223: Fix doclint warnings in java.rmi.server Reviewed-by: smarks ! src/share/classes/java/rmi/server/RMIClassLoader.java Changeset: ac65905883a7 Author: darcy Date: 2013-06-26 22:12 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ac65905883a7 8019228: Fix doclint issues in java.util.zip Reviewed-by: sherman, mchung ! src/share/classes/java/util/zip/Deflater.java ! src/share/classes/java/util/zip/Inflater.java Changeset: 5acff15e12dc Author: wmdietl Date: 2013-06-27 08:35 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5acff15e12dc Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/TypeVariable.java From wdietl at gmail.com Sun Jun 30 12:59:17 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 30 Jun 2013 19:59:17 +0000 Subject: hg: type-annotations/type-annotations: 12 new changesets Message-ID: <20130630195919.186A2486A4@hg.openjdk.java.net> Changeset: c961c8972485 Author: erikj Date: 2013-06-13 14:04 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/c961c8972485 8014231: --with-alsa configuration options don't add include or lib directories to proper flags Reviewed-by: tbell ! common/autoconf/spec.gmk.in Changeset: 0c540b1505e3 Author: erikj Date: 2013-06-14 13:30 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/0c540b1505e3 8016520: jdk native build does not fail on compilation error on windows Reviewed-by: tbell ! common/makefiles/NativeCompilation.gmk Changeset: 0d1e8518c722 Author: erikj Date: 2013-06-18 11:29 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/0d1e8518c722 8014404: Debug flag not added to jdk native compile when --enable-debug is set Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: c0fa87863427 Author: erikj Date: 2013-06-18 11:30 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/c0fa87863427 8015377: Support using compiler devkits on Linux Reviewed-by: tbell, dholmes ! common/autoconf/basics.m4 ! common/autoconf/build-performance.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 + common/makefiles/devkit/Makefile + common/makefiles/devkit/Tools.gmk Changeset: 785d07fe3890 Author: katleman Date: 2013-06-18 15:32 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/785d07fe3890 Merge Changeset: 794cceb5dc82 Author: katleman Date: 2013-06-20 10:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/794cceb5dc82 Added tag jdk8-b95 for changeset 785d07fe3890 ! .hgtags Changeset: d72e765a9fbe Author: lana Date: 2013-06-19 17:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/d72e765a9fbe Merge Changeset: f1010ef2f451 Author: lana Date: 2013-06-24 14:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/f1010ef2f451 Merge Changeset: ebcd79fc658d Author: erikj Date: 2013-06-25 09:37 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/ebcd79fc658d 8012564: The SOURCE value in release file of JDK 8 doesn't contain valid changesets for some OS since b74 Reviewed-by: alanb, tbell ! common/makefiles/Main.gmk Changeset: c156084add48 Author: katleman Date: 2013-06-25 13:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/c156084add48 Merge ! common/makefiles/Main.gmk Changeset: 4c363b94ea2a Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/4c363b94ea2a Added tag jdk8-b96 for changeset c156084add48 ! .hgtags Changeset: b4f83af80c51 Author: wmdietl Date: 2013-06-30 21:59 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/b4f83af80c51 Automated merge with http://hg.openjdk.java.net/jdk8/tl/ ! .hgtags From wdietl at gmail.com Sun Jun 30 13:00:03 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 30 Jun 2013 20:00:03 +0000 Subject: hg: type-annotations/type-annotations/corba: 4 new changesets Message-ID: <20130630200007.877CE486A5@hg.openjdk.java.net> Changeset: c68c35f50413 Author: katleman Date: 2013-06-20 10:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/c68c35f50413 Added tag jdk8-b95 for changeset 2cf36f43df36 ! .hgtags Changeset: 3357c2776431 Author: lana Date: 2013-06-24 14:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/3357c2776431 Merge Changeset: 469995a8e974 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/469995a8e974 Added tag jdk8-b96 for changeset 3357c2776431 ! .hgtags Changeset: df1eb56dd471 Author: wmdietl Date: 2013-06-30 21:59 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/df1eb56dd471 Automated merge with http://hg.openjdk.java.net/jdk8/tl/corba ! .hgtags From wdietl at gmail.com Sun Jun 30 13:00:33 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 30 Jun 2013 20:00:33 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 4 new changesets Message-ID: <20130630200048.66812486A6@hg.openjdk.java.net> Changeset: e68a5d2efcae Author: katleman Date: 2013-06-20 10:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/e68a5d2efcae Added tag jdk8-b95 for changeset b8c5f4b6f0ff ! .hgtags Changeset: 6121efd29923 Author: lana Date: 2013-06-24 14:27 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/6121efd29923 Merge Changeset: 403f882ecc94 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/403f882ecc94 Added tag jdk8-b96 for changeset 6121efd29923 ! .hgtags Changeset: b0ec48cd17c2 Author: wmdietl Date: 2013-06-30 22:00 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/b0ec48cd17c2 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxp ! .hgtags From wdietl at gmail.com Sun Jun 30 13:01:24 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 30 Jun 2013 20:01:24 +0000 Subject: hg: type-annotations/type-annotations/jaxws: 4 new changesets Message-ID: <20130630200152.60271486A7@hg.openjdk.java.net> Changeset: 7de08fa7cb34 Author: katleman Date: 2013-06-20 10:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/7de08fa7cb34 Added tag jdk8-b95 for changeset 1468c94135f9 ! .hgtags Changeset: 690d34b326bc Author: lana Date: 2013-06-24 14:27 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/690d34b326bc Merge Changeset: dcde7f049111 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/dcde7f049111 Added tag jdk8-b96 for changeset 690d34b326bc ! .hgtags Changeset: 0b270f441be1 Author: wmdietl Date: 2013-06-30 22:01 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/0b270f441be1 Automated merge with http://hg.openjdk.java.net/jdk8/tl/jaxws ! .hgtags From wdietl at gmail.com Sun Jun 30 13:03:56 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 30 Jun 2013 20:03:56 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 15 new changesets Message-ID: <20130630200409.D2321486A9@hg.openjdk.java.net> Changeset: c30beaf3c42a Author: jlaskey Date: 2013-06-21 14:34 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/c30beaf3c42a 8010732: BigDecimal, BigInteger and Long handling in nashorn Reviewed-by: sundar Contributed-by: james.laskey at oracle.com + test/script/basic/JDK-8010732.js + test/script/basic/JDK-8010732.js.EXPECTED Changeset: 2ded2fc08c94 Author: jlaskey Date: 2013-06-22 10:12 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/2ded2fc08c94 8017448: JDK-8010732.js.EXPECTED truncated Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! test/script/basic/JDK-8010732.js.EXPECTED Changeset: 51a5ee93d6bc Author: sundar Date: 2013-06-24 19:06 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/51a5ee93d6bc 8015959: Can't call foreign constructor Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/runtime/ScriptFunction.java ! src/jdk/nashorn/internal/runtime/ScriptFunctionData.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java + test/script/basic/JDK-8015959.js + test/script/basic/JDK-8015959.js.EXPECTED Changeset: 26a345c26e62 Author: sundar Date: 2013-06-25 17:31 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/26a345c26e62 8015969: Needs to enforce and document that global "context" and "engine" can't be modified when running via jsr223 Reviewed-by: hannesw, jlaskey ! docs/JavaScriptingProgrammersGuide.html ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java + test/script/basic/JDK-8015969.js Changeset: 39e17373d8df Author: sundar Date: 2013-06-26 16:36 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/39e17373d8df 8017950: error.stack should be a string rather than an array Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/runtime/ECMAException.java ! test/script/basic/JDK-8012164.js ! test/script/basic/JDK-8012164.js.EXPECTED + test/script/basic/JDK-8017950.js + test/script/basic/JDK-8017950.js.EXPECTED ! test/script/basic/NASHORN-109.js ! test/script/basic/NASHORN-296.js ! test/script/basic/errorstack.js Changeset: 682889823712 Author: jlaskey Date: 2013-06-26 08:36 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/682889823712 8008458: Strict functions dont share property map Reviewed-by: sundar, hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java Changeset: 80c66d3fd872 Author: hannesw Date: 2013-06-26 15:40 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/80c66d3fd872 8019157: Avoid calling ScriptObject.setProto() if possible Reviewed-by: jlaskey, sundar ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ScriptClassInstrumentor.java ! src/jdk/nashorn/internal/codegen/ClassEmitter.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/codegen/Compiler.java ! src/jdk/nashorn/internal/codegen/ObjectClassGenerator.java ! src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeArrayBuffer.java ! src/jdk/nashorn/internal/objects/NativeBoolean.java ! src/jdk/nashorn/internal/objects/NativeDate.java ! src/jdk/nashorn/internal/objects/NativeDebug.java ! src/jdk/nashorn/internal/objects/NativeError.java ! src/jdk/nashorn/internal/objects/NativeEvalError.java ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeJSAdapter.java ! src/jdk/nashorn/internal/objects/NativeJSON.java ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/objects/NativeJavaImporter.java ! src/jdk/nashorn/internal/objects/NativeMath.java ! src/jdk/nashorn/internal/objects/NativeNumber.java ! src/jdk/nashorn/internal/objects/NativeObject.java ! src/jdk/nashorn/internal/objects/NativeRangeError.java ! src/jdk/nashorn/internal/objects/NativeReferenceError.java ! src/jdk/nashorn/internal/objects/NativeRegExp.java ! src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java ! src/jdk/nashorn/internal/objects/NativeStrictArguments.java ! src/jdk/nashorn/internal/objects/NativeString.java ! src/jdk/nashorn/internal/objects/NativeSyntaxError.java ! src/jdk/nashorn/internal/objects/NativeTypeError.java ! src/jdk/nashorn/internal/objects/NativeURIError.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/objects/PrototypeObject.java ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/FunctionScope.java ! src/jdk/nashorn/internal/runtime/PropertyMap.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/scripts/JO.java Changeset: 635098f9f45e Author: sundar Date: 2013-06-26 19:42 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/635098f9f45e 8014781: support Error.captureStackTrace Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/api/scripting/NashornException.java ! src/jdk/nashorn/internal/objects/NativeError.java + test/script/basic/JDK-8014781.js + test/script/basic/JDK-8014781.js.EXPECTED Changeset: d1886ad46f0c Author: jlaskey Date: 2013-06-26 12:38 -0300 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d1886ad46f0c 8019175: Simplify ScriptObject.modifyOwnProperty Reviewed-by: hannesw Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java Changeset: f9c855b828fe Author: sundar Date: 2013-06-27 13:24 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/f9c855b828fe 8019226: line number not generated for first statement if it is on the same function declaration line Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/script/basic/JDK-8019226.js + test/script/basic/JDK-8019226.js.EXPECTED Changeset: 5ec4762d9df0 Author: sundar Date: 2013-06-27 13:47 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/5ec4762d9df0 Merge Changeset: b031efa535ad Author: katleman Date: 2013-06-20 10:18 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/b031efa535ad Added tag jdk8-b95 for changeset cbc9926f5b40 ! .hgtags Changeset: d6bd440ac5b9 Author: lana Date: 2013-06-24 14:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d6bd440ac5b9 Merge Changeset: 1bf1d6ce3042 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/1bf1d6ce3042 Added tag jdk8-b96 for changeset d6bd440ac5b9 ! .hgtags Changeset: 90864d892593 Author: lana Date: 2013-06-28 19:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/90864d892593 Merge From wdietl at gmail.com Sun Jun 30 13:00:26 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 30 Jun 2013 20:00:26 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 47 new changesets Message-ID: <20130630200329.C23B7486A8@hg.openjdk.java.net> Changeset: aaa45012be98 Author: katleman Date: 2013-06-20 10:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/aaa45012be98 Added tag jdk8-b95 for changeset 5d65c078cd0a ! .hgtags Changeset: 38e483cb1bcd Author: lana Date: 2013-06-24 14:27 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/38e483cb1bcd Merge Changeset: f9709e27a876 Author: amurillo Date: 2013-06-14 07:27 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f9709e27a876 8016567: new hotspot build - hs25-b38 Reviewed-by: jcoomes ! make/hotspot_version Changeset: a837fa3d3f86 Author: dcubed Date: 2013-06-13 11:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a837fa3d3f86 8013057: assert(_needs_gc || SafepointSynchronize::is_at_safepoint()) failed: only read at safepoint Summary: Detect mmap() commit failures in Linux and Solaris os::commit_memory() impls and call vm_exit_out_of_memory(). Add os::commit_memory_or_exit(). Also tidy up some NMT accounting and some mmap() return value checking. Reviewed-by: zgu, stefank, dholmes, dsamersoff ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.cpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/virtualspace.cpp Changeset: 2bffd20a0fcc Author: ctornqvi Date: 2013-06-13 21:57 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2bffd20a0fcc 8016065: Write regression test for 7167142 Summary: Regression tests written for both test cases (.hotspotrc and .hotspot_compiler). Also reviewed by mikhailo.seledtsov at oracle.com Reviewed-by: zgu, coleenp + test/runtime/CommandLine/CompilerConfigFileWarning.java + test/runtime/CommandLine/ConfigFileWarning.java Changeset: 1e9094165098 Author: ctornqvi Date: 2013-06-13 22:00 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1e9094165098 8015324: Create tests for CDS feature Summary: Wrote tests for use of CDS with ObjectAlignmentInBytes CL option Reviewed-by: coleenp, ctornqvi, hseigel Contributed-by: Mikhailo Seledtsov + test/runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java + test/runtime/SharedArchiveFile/CdsSameObjectAlignment.java + test/testlibrary/com/oracle/java/testlibrary/Platform.java ! test/testlibrary/com/oracle/java/testlibrary/ProcessTools.java Changeset: a0a47b2649a2 Author: ctornqvi Date: 2013-06-14 13:11 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a0a47b2649a2 Merge Changeset: ef57c43512d6 Author: ccheung Date: 2013-06-13 22:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ef57c43512d6 8014431: cleanup warnings indicated by the -Wunused-value compiler option on linux Reviewed-by: dholmes, coleenp Contributed-by: jeremymanson at google.com, calvin.cheung at oracle.com ! make/linux/makefiles/gcc.make ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/ci/ciUtilities.hpp ! src/share/vm/classfile/genericSignatures.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/prims/forte.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/services/diagnosticArgument.cpp ! src/share/vm/utilities/exceptions.hpp ! src/share/vm/utilities/taskqueue.hpp Changeset: bcb96b2922f2 Author: zgu Date: 2013-06-14 07:30 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/bcb96b2922f2 Merge Changeset: ab313d4e9a8b Author: zgu Date: 2013-06-14 09:18 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ab313d4e9a8b 8011968: Kitchensink crashed with SIGSEGV in MemBaseline::baseline Summary: Simple fix to add NULL pointer check that can cause segv Reviewed-by: coleenp, ctornqvi ! src/share/vm/services/memBaseline.cpp Changeset: dba2306ee2e3 Author: zgu Date: 2013-06-14 07:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/dba2306ee2e3 Merge Changeset: 3aaa16611c30 Author: zgu Date: 2013-06-14 15:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3aaa16611c30 Merge Changeset: e95fc50106cf Author: rdurbin Date: 2013-06-14 07:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e95fc50106cf 7178026: os::close can restart ::close but that is not a restartable syscall Summary: Removed restart macros from all os:close calls on Solaris, Linux, MacOS X platforms. Reviewed-by: dcubed, dholmes ! src/os/bsd/dtrace/jvm_dtrace.c ! src/os/bsd/vm/attachListener_bsd.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/attachListener_linux.cpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/solaris/dtrace/jvm_dtrace.c ! src/os/solaris/vm/attachListener_solaris.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/perfMemory_solaris.cpp Changeset: f2d56a269345 Author: dcubed Date: 2013-06-14 08:00 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f2d56a269345 Merge Changeset: c7242a797916 Author: dcubed Date: 2013-06-14 19:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c7242a797916 Merge Changeset: 5c89346f2bdd Author: sspitsyn Date: 2013-06-14 15:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5c89346f2bdd 6493116: JVMTI Doc: GetOwnedMonitorStackDepthInfo has a typo in monitor_info_ptr parameter description Summary: A typo in the parameter spelling, a bound update missed when the parameter was renamed Reviewed-by: sla, minqi Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmti.xml Changeset: 7fa28f3d3f62 Author: sspitsyn Date: 2013-06-14 22:34 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/7fa28f3d3f62 Merge Changeset: abbd5c660b48 Author: mgronlun Date: 2013-06-15 13:17 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/abbd5c660b48 8016105: Add complementary RETURN_NULL allocation macros in allocation.hpp Reviewed-by: sla, rbackman ! src/share/vm/memory/allocation.hpp Changeset: cd2118b62475 Author: zgu Date: 2013-06-10 10:45 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/cd2118b62475 8013917: Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites Summary: Simple fix when memory allocation site is gone, NMT should report 0 memory size, instead old memory size. Reviewed-by: dcubed, ctornqvi ! src/share/vm/services/memReporter.cpp Changeset: ef748153ee8f Author: sla Date: 2013-06-17 18:35 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ef748153ee8f 8016304: ThreadMXBean.getDeadlockedThreads reports bogus deadlocks on JDK 8 Reviewed-by: dcubed, mgronlun ! src/share/vm/services/threadService.cpp + test/serviceability/threads/TestFalseDeadLock.java Changeset: 1f4355cee9a2 Author: zgu Date: 2013-06-18 08:44 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1f4355cee9a2 8013651: NMT: reserve/release sequence id's in incorrect order due to race Summary: Fixed NMT race condition for realloc, uncommit and release Reviewed-by: coleenp, ccheung ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: a5904a086d9f Author: zgu Date: 2013-06-18 09:34 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a5904a086d9f Merge Changeset: cd54c7e92908 Author: minqi Date: 2013-06-18 09:08 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/cd54c7e92908 8015660: Test8009761.java "Failed: init recursive calls: 24. After deopt 25" Summary: Windows reserves and only partially commits thread stack. For detecting more thread stack space for execution, Windows installs one-shot page as guard page just before the current commited edge. It will trigger STACK_OVERFLOW_EXCEPTION when lands on last 4 pages of thread stack space. StackYellowPages default value is 2 on Windows (plus 1 page of StackRedPages, 3 pages guarded by hotspot) so the exception happens one page before Yellow pages. Same route executed second time will have one more page brought in, this leads same execution with different stack depth(interpreter mode). We need match Windows settings so the stack overflow exception will not happen before Yellow pages. Reviewed-by: dholmes Contributed-by: andreas.schoesser at sap.com ! src/cpu/x86/vm/globals_x86.hpp Changeset: 726d2d4913fc Author: nloodin Date: 2013-06-19 18:13 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/726d2d4913fc Merge Changeset: 0abfeed51c9e Author: brutisso Date: 2013-06-14 08:02 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/0abfeed51c9e 8012265: VM often crashes on solaris with a lot of memory Summary: Increase HeapBaseMinAddress for G1 from 256m to 1g on Solaris x86 Reviewed-by: mgerdin, coleenp, kvn ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 01522ca68fc7 Author: johnc Date: 2013-06-18 12:31 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/01522ca68fc7 8015237: Parallelize string table scanning during strong root processing Summary: Parallelize the scanning of the intern string table by having each GC worker claim a given number of buckets. Changes were also reviewed by Per Liden . Reviewed-by: tschatzl, stefank, twisti ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/memory/sharedHeap.cpp Changeset: b9d151496930 Author: brutisso Date: 2013-06-18 22:45 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b9d151496930 8016556: G1: Use ArrayAllocator for BitMaps Reviewed-by: tschatzl, dholmes, coleenp, johnc ! src/share/vm/memory/allocation.hpp ! src/share/vm/utilities/bitMap.cpp ! src/share/vm/utilities/bitMap.hpp Changeset: 493089fd29df Author: poonam Date: 2013-06-19 06:09 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/493089fd29df 8015903: Format issue with -XX:+PrintAdaptiveSizePolicy on JDK8 Summary: Missing linebreak in hotspot log. Reviewed-by: brutisso, tschatzl Contributed-by: vladimir.kempik at oracle.com ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp Changeset: 9f9c0a163cc5 Author: ehelin Date: 2013-06-20 10:03 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9f9c0a163cc5 Merge ! src/share/vm/memory/allocation.hpp Changeset: 8d52e305a777 Author: morris Date: 2013-06-07 07:33 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/8d52e305a777 8015437: SPARC cbcond branch offset out of 10-bit range Summary: Forced SPARC MacroAssembler eden_alloate to use long branch to slow case Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/macroAssembler_sparc.cpp Changeset: ea60d1de6735 Author: kvn Date: 2013-06-07 11:43 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ea60d1de6735 Merge Changeset: 46c544b8fbfc Author: morris Date: 2013-06-07 16:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/46c544b8fbfc 8008407: remove SPARC V8 support Summary: Removed most of the SPARC V8 instructions Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/c2_init_sparc.cpp ! src/cpu/sparc/vm/disassembler_sparc.hpp ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.hpp ! src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.hpp ! src/cpu/sparc/vm/register_sparc.hpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp ! src/os_cpu/linux_sparc/vm/atomic_linux_sparc.inline.hpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/os_cpu/solaris_sparc/vm/solaris_sparc.il ! src/share/vm/runtime/arguments.cpp Changeset: e7f5651d459c Author: twisti Date: 2013-06-11 11:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e7f5651d459c 8003268: SharedRuntime::generate_native_wrapper doesn't save all registers across runtime tracing calls for JNI critical native methods Reviewed-by: kvn ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp Changeset: 693e4d04fd09 Author: drchase Date: 2013-06-11 16:34 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/693e4d04fd09 8014959: assert(Compile::current()->live_nodes() < (uint)MaxNodeLimit) failed: Live Node limit exceeded limit Summary: Insert extra checks and bailouts for too many nodes Reviewed-by: kvn ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/matcher.cpp Changeset: bc8956037049 Author: kvn Date: 2013-06-11 16:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/bc8956037049 Merge Changeset: c52abc8a0b08 Author: drchase Date: 2013-06-13 15:39 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c52abc8a0b08 8010124: JVM_GetClassContext: use GrowableArray instead of KlassLink Summary: replace linked data structure with array (performance) Reviewed-by: kvn Contributed-by: christian.thalinger at oracle.com, david.r.chase at oracle.com ! src/share/vm/prims/jvm.cpp Changeset: 7fa25f5575c9 Author: adlertz Date: 2013-06-14 01:19 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/7fa25f5575c9 8016157: During CTW: C2: assert(!def_outside->member(r)) failed: Use of external LRG overlaps the same LRG defined in this block Summary: Disable rematerialization for negD node Reviewed-by: kvn, roland ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp Changeset: ac91879aa56f Author: kvn Date: 2013-06-14 16:33 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ac91879aa56f Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/prims/jvm.cpp Changeset: 87a6f2df28e2 Author: drchase Date: 2013-06-17 12:35 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/87a6f2df28e2 8002160: Compilation issue with adlc using latest SunStudio compilers Summary: modify declaration of 'swap' overloading; dodge optimizer bug in c1_LIR.cpp Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/macroAssembler_sparc.hpp ! src/cpu/sparc/vm/macroAssembler_sparc.inline.hpp ! src/share/vm/c1/c1_LIR.cpp Changeset: 08d35fd1b599 Author: adlertz Date: 2013-06-19 00:41 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/08d35fd1b599 8001345: VM crashes with assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc Summary: Remove unnecessary LoadN / DecodeN nodes at MemBarAcquire nodes. Reviewed-by: kvn, roland ! src/share/vm/opto/memnode.cpp Changeset: b88209cf98c0 Author: kvn Date: 2013-06-20 16:08 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b88209cf98c0 Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 2cc5a9d1ba66 Author: amurillo Date: 2013-06-21 00:51 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2cc5a9d1ba66 Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp Changeset: 3bdeff4a6ca7 Author: amurillo Date: 2013-06-21 00:51 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3bdeff4a6ca7 Added tag hs25-b38 for changeset 2cc5a9d1ba66 ! .hgtags Changeset: 9f3e3245b50f Author: amurillo Date: 2013-06-25 12:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9f3e3245b50f Merge - src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp - src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jvm.cpp Changeset: e6a4b8c71fa6 Author: katleman Date: 2013-06-26 11:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e6a4b8c71fa6 8017323: JDK8 b95 source with GPL header errors Reviewed-by: tbell, darcy ! src/share/vm/memory/referenceProcessorStats.hpp Changeset: b6d1e42655cd Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b6d1e42655cd Added tag jdk8-b96 for changeset e6a4b8c71fa6 ! .hgtags Changeset: 0ead7c0b3e97 Author: wmdietl Date: 2013-06-30 22:00 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/0ead7c0b3e97 Automated merge with http://hg.openjdk.java.net/jdk8/tl/hotspot ! .hgtags From wdietl at gmail.com Sun Jun 30 12:56:20 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 30 Jun 2013 19:56:20 +0000 Subject: hg: type-annotations/type-annotations/langtools: 19 new changesets Message-ID: <20130630195717.A7728486A2@hg.openjdk.java.net> Changeset: dcc6a52bf363 Author: erikj Date: 2013-06-27 10:35 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/dcc6a52bf363 8014513: Sjavac doesn't detect 32-bit jvm properly Reviewed-by: jjg ! src/share/classes/com/sun/tools/sjavac/CompileJavaPackages.java Changeset: a47e28759666 Author: vromero Date: 2013-06-27 09:51 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/a47e28759666 7066788: javah again accepts -old option (ineffectively) which was removed in 1.5. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javah/JavahTask.java Changeset: 8e3d391c88c6 Author: vromero Date: 2013-06-27 09:54 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/8e3d391c88c6 8017609: javac, ClassFile.read(Path) should be ClassFile.read(Path, Attribute.Factory) Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/ClassFile.java Changeset: e42c27026290 Author: vromero Date: 2013-06-27 16:04 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e42c27026290 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes ) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/T8016099/UncheckedWarningRegressionTest.java + test/tools/javac/T8016099/UncheckedWarningRegressionTest.out Changeset: d137ce373c4c Author: vromero Date: 2013-06-27 16:06 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/d137ce373c4c 7008643: inlined finally clauses confuse debuggers Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/T7008643/InlinedFinallyConfuseDebuggersTest.java Changeset: 26437287529d Author: janvalenta Date: 2013-06-27 17:47 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/26437287529d 8015720: since tag isn't copied while generating JavaFX documentation Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! test/com/sun/javadoc/testJavaFX/C.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java Changeset: 065f8cb7bd89 Author: darcy Date: 2013-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/065f8cb7bd89 8019308: Add descriptions of Java SE 7 and 8 language changes to SourceVersion Reviewed-by: jjg ! src/share/classes/javax/lang/model/SourceVersion.java Changeset: 97e798c06804 Author: ksrini Date: 2013-06-27 12:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/97e798c06804 7080001: Need to bump version numbers in build.properties for 8 Reviewed-by: jjg ! make/build.properties Changeset: 5c548a8542b8 Author: emc Date: 2013-06-27 17:45 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/5c548a8542b8 8013357: javac accepts erroneous binary comparison operations Summary: javac does not report type errors on illegal Object == primitive comparisons Reviewed-by: abuckley, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! test/tools/javac/lambda/LambdaConv01.java ! test/tools/javac/lambda/LambdaExpr15.java ! test/tools/javac/lambda/typeInference/InferenceTest2b.java + test/tools/javac/types/TestComparisons.java Changeset: 6101e52ce9e3 Author: emc Date: 2013-06-28 06:54 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/6101e52ce9e3 8016760: Failure of regression test langtools/tools/javac/T6725036.java Summary: Marking the failing test @ignore; the proposed change for 8015666 addresses the underlying issue Reviewed-by: jjg ! test/tools/javac/T6725036.java Changeset: bb06c412d079 Author: vromero Date: 2013-06-28 13:20 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/bb06c412d079 6473148: TreePath.iterator() should document the iteration order Reviewed-by: mcimadamore ! src/share/classes/com/sun/source/util/TreePath.java Changeset: bdd699d7378d Author: vromero Date: 2013-06-28 14:36 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/bdd699d7378d 8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/AttributeWriter.java Changeset: 3478b1e81baf Author: katleman Date: 2013-06-20 10:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/3478b1e81baf Added tag jdk8-b95 for changeset 4cb113623127 ! .hgtags Changeset: b3458329d060 Author: lana Date: 2013-06-24 14:27 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/b3458329d060 Merge Changeset: 988aef3a8c3a Author: katleman Date: 2013-06-26 11:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/988aef3a8c3a 8016684: JDK8 b94 source with GPL header errors Reviewed-by: tbell, darcy ! test/tools/javac/6567415/T6567415.java Changeset: 6a11a81a8824 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/6a11a81a8824 Added tag jdk8-b96 for changeset 988aef3a8c3a ! .hgtags Changeset: 66147d50d8d6 Author: lana Date: 2013-06-28 19:47 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/66147d50d8d6 Merge Changeset: 891c5ecb8306 Author: vromero Date: 2013-06-29 20:12 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/891c5ecb8306 6983646: javap should identify why a DefaultAttribute is being used Reviewed-by: jjg ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/classfile/DefaultAttribute.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java Changeset: a004d53eb41d Author: wmdietl Date: 2013-06-30 21:56 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/a004d53eb41d Automated merge with http://hg.openjdk.java.net/jdk8/tl/langtools ! .hgtags ! make/build.properties ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/tools/classfile/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javap/AttributeWriter.java ! src/share/classes/javax/lang/model/SourceVersion.java From wdietl at gmail.com Sun Jun 30 12:59:10 2013 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sun, 30 Jun 2013 19:59:10 +0000 Subject: hg: type-annotations/type-annotations/jdk: 57 new changesets Message-ID: <20130630201255.BACB1486AA@hg.openjdk.java.net> Changeset: 370e7beff8a0 Author: wetmore Date: 2013-06-27 10:19 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/370e7beff8a0 8019227: JDK-8010325 broke the old build Reviewed-by: alanb, chegar ! make/java/java/FILES_java.gmk Changeset: 4e69a7dfbeac Author: chegar Date: 2013-06-27 10:21 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4e69a7dfbeac Merge Changeset: 1c31082f0a51 Author: darcy Date: 2013-06-27 11:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1c31082f0a51 8019304: Fix doclint issues in java.util.prefs Reviewed-by: lancea ! src/share/classes/java/util/prefs/AbstractPreferences.java ! src/share/classes/java/util/prefs/PreferencesFactory.java Changeset: b9ba04dc210f Author: lancea Date: 2013-06-27 15:07 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b9ba04dc210f 8017471: Fix JDBC -Xdoclint public errors Reviewed-by: darcy ! src/share/classes/java/sql/Blob.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Clob.java ! src/share/classes/java/sql/DatabaseMetaData.java ! src/share/classes/java/sql/Driver.java ! src/share/classes/java/sql/DriverAction.java ! src/share/classes/java/sql/NClob.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/java/sql/SQLInput.java ! src/share/classes/java/sql/SQLPermission.java ! src/share/classes/java/sql/SQLXML.java ! src/share/classes/java/sql/Wrapper.java ! src/share/classes/javax/sql/CommonDataSource.java ! src/share/classes/javax/sql/ConnectionPoolDataSource.java ! src/share/classes/javax/sql/DataSource.java ! src/share/classes/javax/sql/RowSet.java ! src/share/classes/javax/sql/XADataSource.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/Joinable.java ! src/share/classes/javax/sql/rowset/Predicate.java ! src/share/classes/javax/sql/rowset/RowSetProvider.java ! src/share/classes/javax/sql/rowset/RowSetWarning.java ! src/share/classes/javax/sql/rowset/WebRowSet.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/share/classes/javax/sql/rowset/spi/SyncResolver.java Changeset: b8f16cb2d95b Author: darcy Date: 2013-06-27 12:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b8f16cb2d95b 8019315: Fix doclint issues in java.util.logging Reviewed-by: lancea ! src/share/classes/java/util/logging/Handler.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LogRecord.java Changeset: 6729f7ef94cd Author: smarks Date: 2013-06-27 13:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6729f7ef94cd 8019224: add exception chaining to RMI CGIHandler Reviewed-by: darcy ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java Changeset: 1099fe14fb65 Author: darcy Date: 2013-06-27 14:11 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1099fe14fb65 8019320: Fix doclint issues in javax.script Reviewed-by: lancea ! src/share/classes/javax/script/Invocable.java ! src/share/classes/javax/script/ScriptContext.java ! src/share/classes/javax/script/ScriptEngineFactory.java ! src/share/classes/javax/script/SimpleScriptContext.java Changeset: e34e3ddb3cd8 Author: naoto Date: 2013-06-27 14:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e34e3ddb3cd8 6609431: (rb) ResourceBundle.getString() returns incorrect value Reviewed-by: okutsu, sherman ! src/share/classes/java/util/Properties.java + test/java/util/Properties/Bug6609431.java + test/java/util/Properties/Bug6609431.properties Changeset: 29bbbb136bc5 Author: darcy Date: 2013-06-27 19:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/29bbbb136bc5 8019357: Fix doclint warnings in java.lang.invoke Reviewed-by: jrose ! src/share/classes/java/lang/invoke/LambdaConversionException.java ! src/share/classes/java/lang/invoke/LambdaMetafactory.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodType.java ! src/share/classes/java/lang/invoke/MutableCallSite.java ! src/share/classes/java/lang/invoke/SerializedLambda.java ! src/share/classes/java/lang/invoke/package-info.java Changeset: 60d1994f63f7 Author: xuelei Date: 2013-06-27 19:22 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/60d1994f63f7 8019359: To comment why not use no_renegotiation to reject client initiated renegotiation Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/ServerHandshaker.java Changeset: c1df54fd19b2 Author: henryjen Date: 2013-06-11 13:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c1df54fd19b2 8009736: Comparator API cleanup Reviewed-by: psandoz, briangoetz, mduigou, plevart ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Comparator.java ! src/share/classes/java/util/Comparators.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/function/BinaryOperator.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/SortedOps.java ! test/java/nio/file/Files/StreamTest.java ! test/java/util/Collection/ListDefaults.java + test/java/util/Comparator/BasicTest.java + test/java/util/Comparator/TypeTest.java - test/java/util/Comparators/BasicTest.java + test/java/util/Map/EntryComparators.java + test/java/util/function/BinaryOperator/BasicTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SequentialOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java ! test/sun/misc/JavaLangAccess/NewUnsafeString.java Changeset: 28b71c97a72d Author: psandoz Date: 2013-06-28 10:29 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/28b71c97a72d 8012987: Optimizations for Stream.limit/substream Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! src/share/classes/java/util/stream/AbstractPipeline.java ! src/share/classes/java/util/stream/AbstractTask.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/ForEachOps.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/PipelineHelper.java ! src/share/classes/java/util/stream/SliceOps.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/StreamSpliterators.java ! test/java/util/stream/bootlib/java/util/stream/OpTestCase.java ! test/java/util/stream/bootlib/java/util/stream/SpliteratorTestHelper.java + test/java/util/stream/boottest/java/util/stream/SliceSpliteratorTest.java ! test/java/util/stream/boottest/java/util/stream/StreamFlagsTest.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest.java Changeset: 19a6d2d701d9 Author: sla Date: 2013-06-26 19:15 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/19a6d2d701d9 8019155: Update makefiles with correct jfr packages Reviewed-by: mgronlun, erikj ! make/common/Release.gmk ! makefiles/CreateJars.gmk Changeset: 04378a645944 Author: alanb Date: 2013-06-28 16:10 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/04378a645944 8019380: doclint warnings in java.nio, java.nio.file.**, java.nio.channels.** Reviewed-by: chegar ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/MappedByteBuffer.java ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/channels/AsynchronousByteChannel.java ! src/share/classes/java/nio/channels/AsynchronousChannel.java ! src/share/classes/java/nio/channels/AsynchronousChannelGroup.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/AsynchronousServerSocketChannel.java ! src/share/classes/java/nio/channels/AsynchronousSocketChannel.java ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/channels/FileLock.java ! src/share/classes/java/nio/channels/MulticastChannel.java ! src/share/classes/java/nio/channels/NetworkChannel.java ! src/share/classes/java/nio/channels/Pipe.java ! src/share/classes/java/nio/channels/SelectableChannel.java ! src/share/classes/java/nio/channels/SelectionKey.java ! src/share/classes/java/nio/channels/Selector.java ! src/share/classes/java/nio/channels/ServerSocketChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelectableChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelector.java ! src/share/classes/java/nio/channels/spi/AsynchronousChannelProvider.java ! src/share/classes/java/nio/channels/spi/SelectorProvider.java ! src/share/classes/java/nio/charset/Charset-X-Coder.java.template ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/nio/charset/CoderResult.java ! src/share/classes/java/nio/charset/spi/CharsetProvider.java ! src/share/classes/java/nio/file/FileStore.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/FileSystems.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/SecureDirectoryStream.java ! src/share/classes/java/nio/file/WatchEvent.java ! src/share/classes/java/nio/file/WatchService.java ! src/share/classes/java/nio/file/attribute/AclEntry.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java ! src/share/classes/java/nio/file/attribute/AttributeView.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java ! src/share/classes/java/nio/file/attribute/DosFileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileAttribute.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributeView.java ! src/share/classes/java/nio/file/spi/FileSystemProvider.java ! src/share/classes/java/sql/SQLInput.java Changeset: 1919c226b427 Author: dl Date: 2013-06-28 12:10 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1919c226b427 8017739: ReentrantReadWriteLock is confused by the Threads with reused IDs Reviewed-by: chegar ! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java Changeset: 0e24065a75db Author: dl Date: 2013-06-28 12:12 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0e24065a75db 8019377: Sync j.u.c locks and atomic from 166 to tl Reviewed-by: chegar ! src/share/classes/java/util/concurrent/atomic/AtomicBoolean.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicMarkableReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicStampedReference.java ! src/share/classes/java/util/concurrent/atomic/DoubleAccumulator.java ! src/share/classes/java/util/concurrent/atomic/DoubleAdder.java ! src/share/classes/java/util/concurrent/atomic/LongAccumulator.java ! src/share/classes/java/util/concurrent/atomic/Striped64.java ! src/share/classes/java/util/concurrent/atomic/package-info.java ! src/share/classes/java/util/concurrent/locks/AbstractOwnableSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java ! src/share/classes/java/util/concurrent/locks/Condition.java ! src/share/classes/java/util/concurrent/locks/Lock.java ! src/share/classes/java/util/concurrent/locks/LockSupport.java ! src/share/classes/java/util/concurrent/locks/ReadWriteLock.java ! src/share/classes/java/util/concurrent/locks/ReentrantLock.java ! src/share/classes/java/util/concurrent/locks/StampedLock.java Changeset: ff0242ed08db Author: jzavgren Date: 2013-06-28 16:38 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ff0242ed08db 8015799: HttpURLConnection.getHeaderFields() throws IllegalArgumentException Reviewed-by: chegar, dsamersoff, khazra ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/java/net/CookieHandler/EmptyCookieHeader.java Changeset: 52b4527d3fc7 Author: chegar Date: 2013-06-28 16:39 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/52b4527d3fc7 Merge Changeset: 389f59e6288f Author: juh Date: 2013-06-28 10:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/389f59e6288f 8019360: Cleanup of the javadoc tag in java.security.* Summary: Convert to {@code ...} tags. convert package.html to package-info.java. Reviewed-by: darcy ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/AccessControlException.java ! src/share/classes/java/security/AccessController.java ! src/share/classes/java/security/AlgorithmParameterGenerator.java ! src/share/classes/java/security/AlgorithmParameterGeneratorSpi.java ! src/share/classes/java/security/AlgorithmParameters.java ! src/share/classes/java/security/AlgorithmParametersSpi.java ! src/share/classes/java/security/AllPermission.java ! src/share/classes/java/security/AuthProvider.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/Certificate.java ! src/share/classes/java/security/CodeSigner.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/DigestException.java ! src/share/classes/java/security/DigestInputStream.java ! src/share/classes/java/security/DigestOutputStream.java ! src/share/classes/java/security/DomainCombiner.java ! src/share/classes/java/security/GeneralSecurityException.java ! src/share/classes/java/security/Guard.java ! src/share/classes/java/security/GuardedObject.java ! src/share/classes/java/security/Identity.java ! src/share/classes/java/security/IdentityScope.java ! src/share/classes/java/security/InvalidAlgorithmParameterException.java ! src/share/classes/java/security/InvalidKeyException.java ! src/share/classes/java/security/Key.java ! src/share/classes/java/security/KeyException.java ! src/share/classes/java/security/KeyFactory.java ! src/share/classes/java/security/KeyFactorySpi.java ! src/share/classes/java/security/KeyManagementException.java ! src/share/classes/java/security/KeyPair.java ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyPairGeneratorSpi.java ! src/share/classes/java/security/KeyRep.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/KeyStoreException.java ! src/share/classes/java/security/KeyStoreSpi.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/MessageDigestSpi.java ! src/share/classes/java/security/NoSuchAlgorithmException.java ! src/share/classes/java/security/Permission.java ! src/share/classes/java/security/PermissionCollection.java ! src/share/classes/java/security/Permissions.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/PolicySpi.java ! src/share/classes/java/security/PrivilegedAction.java ! src/share/classes/java/security/PrivilegedActionException.java ! src/share/classes/java/security/PrivilegedExceptionAction.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Provider.java ! src/share/classes/java/security/ProviderException.java ! src/share/classes/java/security/PublicKey.java ! src/share/classes/java/security/SecureClassLoader.java ! src/share/classes/java/security/SecureRandom.java ! src/share/classes/java/security/SecureRandomSpi.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/SecurityPermission.java ! src/share/classes/java/security/Signature.java ! src/share/classes/java/security/SignatureException.java ! src/share/classes/java/security/SignatureSpi.java ! src/share/classes/java/security/SignedObject.java ! src/share/classes/java/security/Signer.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/acl/Acl.java ! src/share/classes/java/security/acl/AclEntry.java ! src/share/classes/java/security/acl/Group.java ! src/share/classes/java/security/acl/Owner.java + src/share/classes/java/security/acl/package-info.java - src/share/classes/java/security/acl/package.html + src/share/classes/java/security/cert/package-info.java - src/share/classes/java/security/cert/package.html ! src/share/classes/java/security/interfaces/DSAKeyPairGenerator.java ! src/share/classes/java/security/interfaces/DSAParams.java ! src/share/classes/java/security/interfaces/DSAPrivateKey.java ! src/share/classes/java/security/interfaces/DSAPublicKey.java + src/share/classes/java/security/interfaces/package-info.java - src/share/classes/java/security/interfaces/package.html + src/share/classes/java/security/package-info.java - src/share/classes/java/security/package.html + src/share/classes/java/security/spec/package-info.java - src/share/classes/java/security/spec/package.html Changeset: 9d175c6cb527 Author: darcy Date: 2013-06-28 11:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9d175c6cb527 8019407: Fix doclint issues in javax.naming.* Reviewed-by: lancea ! src/share/classes/javax/naming/CompositeName.java ! src/share/classes/javax/naming/CompoundName.java ! src/share/classes/javax/naming/Context.java ! src/share/classes/javax/naming/InitialContext.java ! src/share/classes/javax/naming/RefAddr.java ! src/share/classes/javax/naming/ReferralException.java ! src/share/classes/javax/naming/directory/DirContext.java ! src/share/classes/javax/naming/event/EventContext.java ! src/share/classes/javax/naming/ldap/ControlFactory.java ! src/share/classes/javax/naming/ldap/InitialLdapContext.java ! src/share/classes/javax/naming/ldap/LdapContext.java Changeset: 389b8739a74e Author: alanb Date: 2013-06-28 19:45 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/389b8739a74e 8019384: jps and jcmd tests fail when there is a process started with a .war file Reviewed-by: dcubed, sla, mchung ! test/sun/tools/jcmd/jcmd_Output1.awk ! test/sun/tools/jps/jps-l_Output1.awk ! test/sun/tools/jps/jps_Output1.awk Changeset: 3531945431aa Author: erikj Date: 2013-06-13 14:04 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3531945431aa 8014231: --with-alsa configuration options don't add include or lib directories to proper flags Reviewed-by: tbell ! makefiles/CompileNativeLibraries.gmk Changeset: 42aa9f182885 Author: katleman Date: 2013-06-18 15:32 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/42aa9f182885 Merge ! makefiles/CompileNativeLibraries.gmk Changeset: 0c4db4782114 Author: katleman Date: 2013-06-20 10:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0c4db4782114 Added tag jdk8-b95 for changeset 42aa9f182885 ! .hgtags Changeset: 616a73e97b38 Author: bae Date: 2013-06-06 13:57 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/616a73e97b38 8013430: REGRESSION: closed/java/awt/color/ICC_Profile/LoadProfileTest/LoadProfileTest.java fails with java.io.StreamCorruptedException: invalid type code: EE since 8b87 Reviewed-by: prr, vadim ! src/share/classes/java/awt/color/ICC_Profile.java + src/share/classes/sun/java2d/cmm/ProfileDataVerifier.java Changeset: 917dd642f934 Author: bae Date: 2013-06-07 14:45 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/917dd642f934 6830714: cmm test failures with OpenJDK Reviewed-by: prr ! test/sun/java2d/cmm/ColorConvertOp/ColConvCCMTest.java ! test/sun/java2d/cmm/ColorConvertOp/ColConvDCMTest.java ! test/sun/java2d/cmm/ColorConvertOp/ColConvTest.java Changeset: 1431488fb0f9 Author: jgodinez Date: 2013-06-07 10:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1431488fb0f9 8013810: PrintServiceLookup.lookupPrintServices() does not return consistent result Reviewed-by: prr, jgodinez Contributed-by: patrick at reini.net ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java + test/javax/print/PrintServiceLookup/GetPrintServices.java Changeset: f67db3d2f406 Author: prr Date: 2013-06-13 13:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f67db3d2f406 8016485: Windows native print dialog does not reflect default printer settings Reviewed-by: jgodinez, jchen ! src/windows/classes/sun/awt/windows/WPrinterJob.java ! src/windows/classes/sun/print/Win32PrintService.java ! src/windows/native/sun/windows/WPrinterJob.cpp ! src/windows/native/sun/windows/awt_PrintControl.cpp Changeset: 82927bc76ea5 Author: lana Date: 2013-06-14 11:10 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/82927bc76ea5 Merge - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java Changeset: c636942a28ef Author: prr Date: 2013-06-17 10:34 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c636942a28ef 8015334: Memory leak when kerning is used on Windows. Reviewed-by: srl, bae ! src/share/native/sun/font/layout/KernTable.cpp ! src/share/native/sun/font/layout/KernTable.h ! src/share/native/sun/font/layout/LayoutEngine.cpp + test/java/awt/font/TextLayout/KerningLeak.java Changeset: e3d5df92f4ff Author: lana Date: 2013-06-19 17:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e3d5df92f4ff Merge Changeset: deb8752684e3 Author: kshefov Date: 2013-06-06 17:02 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/deb8752684e3 8015976: OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have conflicting test descriptions Reviewed-by: serb, anthony ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html ! test/java/awt/DataFlavor/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java ! test/java/awt/event/KeyEvent/KeyReleasedInAppletTest/KeyReleasedInAppletTest.java Changeset: cfd3f8bfb96c Author: kshefov Date: 2013-06-06 17:06 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cfd3f8bfb96c 7109977: [macosx] MixingInHwPanel.java test fails on Mac trying to click in the reserved corner Reviewed-by: serb, anthony ! test/java/awt/Mixing/MixingInHwPanel.java Changeset: cb7f711e1752 Author: dmarkov Date: 2013-06-06 17:59 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cb7f711e1752 8015853: java.lang.ArrayIndexOutOfBoundsException when running SwingSet2 demo Reviewed-by: alexp, serb ! src/share/classes/javax/swing/text/View.java + test/javax/swing/text/View/8015853/bug8015853.java + test/javax/swing/text/View/8015853/bug8015853.txt Changeset: 2d5bb70458b6 Author: kshefov Date: 2013-06-10 16:44 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2d5bb70458b6 7105030: [TEST_BUG] [macosx] The tests never finishes Reviewed-by: alexsch, serb + test/javax/swing/JMenu/4692443/bug4692443.java Changeset: d14523c12f20 Author: kshefov Date: 2013-06-11 14:14 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d14523c12f20 8012569: TEST_BUG: java/awt/GraphicsDevice/CheckDisplayModes.java fails Reviewed-by: anthony, serb ! test/java/awt/GraphicsDevice/CheckDisplayModes.java Changeset: 9ab7973d5907 Author: kshefov Date: 2013-06-11 14:20 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9ab7973d5907 7184908: TEST_BUG: [macosx] closed/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java fails Reviewed-by: alexsch, serb + test/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java Changeset: 59dc1385127f Author: malenkov Date: 2013-06-11 16:02 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/59dc1385127f 8015336: BasicComboBoxEditor throws NullPointerException Reviewed-by: alexsch ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java + test/javax/swing/plaf/basic/BasicComboBoxEditor/Test8015336.java Changeset: 7bba0147ab3d Author: alexsch Date: 2013-06-11 16:30 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7bba0147ab3d 8009984: [parfait] Buffer overrun at jdk/src/macosx/native/com/apple/laf/AquaFileView.m Reviewed-by: serb, art ! src/macosx/native/com/apple/laf/AquaFileView.m Changeset: 33fc8a062f90 Author: ant Date: 2013-06-12 16:18 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/33fc8a062f90 8015454: java/awt/Focus/TypeAhead/TestFocusFreeze.java hangs with jdk8 since b56 Reviewed-by: anthony ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! test/java/awt/Focus/TypeAhead/TestFocusFreeze.java Changeset: a7d943998bd3 Author: pchelko Date: 2013-06-13 11:10 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a7d943998bd3 8013468: [macosx] Cursor does not update properly when in fullscreen mode on Mac Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Mouse/EnterExitEvents/FullscreenEnterEventTest.java Changeset: 6e5824a42c49 Author: alitvinov Date: 2013-06-13 18:46 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6e5824a42c49 6847588: AWT test fails Reviewed-by: anthony, serb ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java Changeset: d57fa4e45100 Author: ant Date: 2013-06-14 16:38 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d57fa4e45100 8014821: Regression: Focus issues with Oracle WebCenter Capture applet Reviewed-by: leonidr ! src/windows/native/sun/windows/awt_Frame.cpp Changeset: 3a157a38f9b3 Author: lana Date: 2013-06-14 10:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3a157a38f9b3 Merge - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Fedora.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.SuSE.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.Ubuntu.properties - src/solaris/classes/sun/awt/fontconfigs/linux.fontconfig.properties - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateBindingFailFastTest.java - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorTraversingAndSplittingTest.java Changeset: a0202d94844a Author: malenkov Date: 2013-06-17 18:30 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a0202d94844a 8013571: TreeModelEvent doesn't accept "null" for root as Javadoc specifies. Reviewed-by: alexsch ! src/share/classes/javax/swing/JTree.java ! src/share/classes/javax/swing/event/TreeModelEvent.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/tree/FixedHeightLayoutCache.java ! src/share/classes/javax/swing/tree/VariableHeightLayoutCache.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/JTree/8013571/Test8013571.java Changeset: 6a3a2cb3ca6a Author: malenkov Date: 2013-06-19 14:28 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6a3a2cb3ca6a 8013442: No file filter selected in file type combo box when using JFileChooser Reviewed-by: alexsch ! src/share/classes/javax/swing/JFileChooser.java + test/javax/swing/JFileChooser/8013442/Test8013442.java Changeset: e8000751a585 Author: pchelko Date: 2013-06-19 17:12 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e8000751a585 8005661: [parfait] Possible buffer overrun in jdk/src/solaris/native/sun/awt/awt_GraphicsEnv.c 8005695: [parfait] Format string argument mismatch in jdk/src/solaris/native/sun/xawt/XToolkit.c 8005752: [parfait] False positive function call mismatch at jdk/src/solaris/native/sun/xawt/XWindow.c Reviewed-by: art, serb ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_InputMethod.c ! src/solaris/native/sun/xawt/XToolkit.c Changeset: a117785457f6 Author: lana Date: 2013-06-19 17:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a117785457f6 Merge Changeset: aa4610fe8a73 Author: lana Date: 2013-06-19 18:30 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/aa4610fe8a73 Merge - make/sun/xawt/ToBin.java - makefiles/sun/awt/X11/ToBin.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java - src/share/classes/sun/misc/FDBigInt.java - src/share/classes/sun/misc/Hashing.java - src/solaris/classes/sun/awt/X11/XIconInfo.java ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java - src/solaris/classes/sun/awt/X11/security-icon-bw16.png - src/solaris/classes/sun/awt/X11/security-icon-bw24.png - src/solaris/classes/sun/awt/X11/security-icon-bw32.png - src/solaris/classes/sun/awt/X11/security-icon-bw48.png - src/solaris/classes/sun/awt/X11/security-icon-interim16.png - src/solaris/classes/sun/awt/X11/security-icon-interim24.png - src/solaris/classes/sun/awt/X11/security-icon-interim32.png - src/solaris/classes/sun/awt/X11/security-icon-interim48.png - src/solaris/classes/sun/awt/X11/security-icon-yellow16.png - src/solaris/classes/sun/awt/X11/security-icon-yellow24.png - src/solaris/classes/sun/awt/X11/security-icon-yellow32.png - src/solaris/classes/sun/awt/X11/security-icon-yellow48.png ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/windows/native/sun/windows/WPrinterJob.cpp ! src/windows/native/sun/windows/awt_PrintControl.cpp - test/java/lang/invoke/7196190/MHProxyTest.java - test/sun/misc/Hashing.java Changeset: fce2eaa84b21 Author: lana Date: 2013-06-24 14:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fce2eaa84b21 Merge Changeset: 58e5d1149f97 Author: erikj Date: 2013-06-25 09:25 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/58e5d1149f97 8017480: Move copying of jfr files to closed makefile Reviewed-by: sla, tbell ! makefiles/CopyFiles.gmk Changeset: fd41ca58229c Author: katleman Date: 2013-06-25 13:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fd41ca58229c Merge Changeset: 4a5d3cf2b3af Author: katleman Date: 2013-06-26 11:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4a5d3cf2b3af 8016684: JDK8 b94 source with GPL header errors Reviewed-by: tbell, darcy ! src/share/classes/java/nio/CharBufferSpliterator.java ! src/share/native/sun/management/DiagnosticCommandImpl.c ! test/java/lang/management/MXBean/MXBeanBehavior.java ! test/java/lang/management/ManagementFactory/MBeanServerMXBeanUnsupportedTest.java Changeset: 2f1386fc2079 Author: katleman Date: 2013-06-27 13:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2f1386fc2079 Added tag jdk8-b96 for changeset 4a5d3cf2b3af ! .hgtags Changeset: b4d36f3717b8 Author: lana Date: 2013-06-28 19:46 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b4d36f3717b8 Merge Changeset: a4eb59bffb60 Author: lancea Date: 2013-06-29 06:12 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a4eb59bffb60 8019286: Fix javadoc typo in ResultSet.next Reviewed-by: darcy, mchung ! src/share/classes/java/sql/ResultSet.java Changeset: 3d220023120b Author: wmdietl Date: 2013-06-30 21:57 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3d220023120b Automated merge with http://hg.openjdk.java.net/jdk8/tl/jdk ! .hgtags