Extra fields in ClassSymbol.

Werner Dietl wdietl at gmail.com
Wed May 8 16:37:06 PDT 2013


Hi Jon,

there was no reason for this, other than Annotations not existing (or
me not remembering it) when I added those fields.
I just pushed a change to fix this:

http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/345f3dc73dda

Please let me know what you think.

cu, WMD.

On Wed, May 8, 2013 at 1:29 AM, Jonathan Gibbons
<jonathan.gibbons at oracle.com> wrote:
> Werner,
>
> You appear to have added extra fields into ClassSymbol
>
>> hg diff src/share/classes/com/sun/tools/javac/code/Symbol.java
>> diff -r 43c2f7cb9c76
>> src/share/classes/com/sun/tools/javac/code/Symbol.java
>> --- a/src/share/classes/com/sun/tools/javac/code/Symbol.java    Tue May 07
>> 14:27:30 2013 -0700
>> +++ b/src/share/classes/com/sun/tools/javac/code/Symbol.java    Tue May 07
>> 16:27:49 2013 -0700
>> @@ -794,6 +794,14 @@
>>           */
>>          public Pool pool;
>>
>> +        /** The type attributes of initializers in this class.
>> +         */
>> +        public List<Attribute.TypeCompound> init_type_annotations =
>> List.<Attribute.TypeCompound>nil();
>> +
>> +        /** The type attributes of class initializers in this class.
>> +         */
>> +        public List<Attribute.TypeCompound> clinit_type_annotations =
>> List.<Attribute.TypeCompound>nil();
>> +
>>          public ClassSymbol(long flags, Name name, Type type, Symbol
>> owner) {
>>              super(TYP, flags, name, type, owner);
>>              this.members_field = null;
>
>
>
> This seems highly undesirable.  Is there a reason why these fields are not
> in the Annotations object?
>
> -- Jon
>
>
>



-- 
http://www.google.com/profiles/wdietl


More information about the type-annotations-dev mailing list