Review request for type annotation reflection test
Alex Buckley
alex.buckley at oracle.com
Mon May 20 15:04:42 PDT 2013
Hi Charlie,
- The structure of the test() method in each test is similar. Lots of
code duplication. Is it possible to abstract the inspection of annotations?
- Similarly, each test has a bunch of annotation type declarations at
the end - TypeAnno1/2/3 etc - which could be pulled into a common
"types" directory.
- Could you please update the rows in
http://cr.openjdk.java.net/~ssides/docs/JSR308_Type-Annotations_Reflection_Tests.html
to link to the corresponding test?
Alex
On 5/18/2013 11:10 PM, Charlie Wang wrote:
> Hi,
> Here's test for core reflection support of type-annotations
> JDK-8013497 <https://jbs.oracle.com/bugs/browse/JDK-8013497>. Please
> take a look.
>
> http://cr.openjdk.java.net/~ssides/8013497/webrev.02/
>
>
> Regards,
> Charlie
More information about the type-annotations-dev
mailing list