Better encapsulation for AnnotatedType

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Sep 19 19:07:21 PDT 2013


On 09/15/2013 12:53 AM, Werner Dietl wrote:
> I have one more change that I just pushed:
>
> http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e1772bcdf768
>
> I changed com.sun.tools.javac.tree.TreeCopier.visitLabeledStatement
> to take the copied body instead of the original body.
> Charlie Garrett discovered this problem after painful debugging of a
> Checker Framework problem that depended on whether a label is present or
> not.
> I cannot present a simple test case for the error, but the change
> doesn't break any existing test cases.
> Also note that this was the only "unused variable" warning in
> TreeCopier. Warnings are useful.

Well, that ws an embarrassing bug. Thank you for pointing it out. I'll 
apply the patch for this changeset to tl/langtools.

-- Jon


More information about the type-annotations-dev mailing list