From wdietl at gmail.com Sat Aug 9 05:04:40 2014 From: wdietl at gmail.com (Werner Dietl) Date: Sat, 9 Aug 2014 01:04:40 -0400 Subject: Type annotation on catch parameter Message-ID: Hi all, a fellow Checker Framework developer recently discovered an issue (https://code.google.com/p/checker-framework/issues/detail?id=344) that can be reproduced with stock jdk9: === import java.lang.annotation.*; class TestIssue344 { public void foo() { try { return; } catch (@TA Exception e) { } } } @Target(ElementType.TYPE_USE) @interface TA {} ==== Compiling this file results in: An exception has occurred in the compiler (1.9.0-internal). Please file a bug at the Java Developer Connection (http://java.sun.com/webapps/bugreport) after checking the Bug Parade for duplicates. Include your program and the following diagnostic in your report. Thank you. java.lang.AssertionError: Could not find exception index for type annotation @TA on exception parameter at com.sun.tools.javac.util.Assert.error(Assert.java:132) at com.sun.tools.javac.jvm.Code.fillExceptionParameterPositions(Code.java:2157) at com.sun.tools.javac.jvm.Gen.genMethod(Gen.java:964) at com.sun.tools.javac.jvm.Gen.visitMethodDef(Gen.java:872) at com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:814) at com.sun.tools.javac.jvm.Gen.genDef(Gen.java:615) at com.sun.tools.javac.jvm.Gen.genClass(Gen.java:2385) at com.sun.tools.javac.main.JavaCompiler.genCode(JavaCompiler.java:741) at com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1578) at com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1542) at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:897) at com.sun.tools.javac.main.Main.compile(Main.java:536) at com.sun.tools.javac.main.Main.compile(Main.java:383) at com.sun.tools.javac.main.Main.compile(Main.java:372) at com.sun.tools.javac.main.Main.compile(Main.java:363) at com.sun.tools.javac.Main.compile(Main.java:56) at com.sun.tools.javac.Main.main(Main.java:42) This issue does not occur in the jdk8 version. Should I continue to use this mailing list for this kind of bug report? Or should I start going directly to a compiler list? Thanks! cu, WMD. -- http://www.google.com/profiles/wdietl From alex.buckley at oracle.com Mon Aug 11 17:53:40 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 11 Aug 2014 10:53:40 -0700 Subject: Type annotation on catch parameter In-Reply-To: References: Message-ID: <53E90324.6050509@oracle.com> Hi Werner, On 8/8/2014 10:04 PM, Werner Dietl wrote: > Should I continue to use this mailing list for this kind of bug > report? Or should I start going directly to a compiler list? Either compiler-dev, or you can file a bug against tools/javac in bugs.openjdk.java.net directly (since you're a Committer on an OpenJDK Project). Alex From alex.buckley at oracle.com Mon Aug 11 18:03:43 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 11 Aug 2014 11:03:43 -0700 Subject: type-annotations based on JDK 9? In-Reply-To: <52D09908.8050101@oracle.com> References: <20131216.161531.731673380041851584.mernst@cs.washington.edu> <52D09908.8050101@oracle.com> Message-ID: <53E9057F.5060800@oracle.com> Mike, I'd like to suggest that it's now time to disable the type-annotations-dev list and remove the type-annotations/type-annotations forest. The Type Annotations Project itself will remain, with a web page in the style of the ThreeTen Project - see http://openjdk.java.net/projects/threeten/. The Project and its contributors will continue to appear in the OpenJDK Census at http://openjdk.java.net/census#type-annotations. Alex On 1/10/2014 5:06 PM, Alex Buckley wrote: > Mike, > > I've asked around (it took a while) about the future of the three > OpenJDK Projects - Lambda, ThreeTen, and Type Annotations - which host > Reference Implementations of JSRs for Java SE 8. > > The Type Annotations Project has essentially served its purpose of > hosting the RI for JSR 308, and allowing the RI's code to make its way > into the repositories of the JDK 8 Project. Woohoo! > > I agree that the type-annotations forest used by the Type Annotations > Project has served its purpose. From now on, bug fixes to javac's > handling of type annotations should be sent as patches to the > compiler-dev list, just like fixes to any other area of javac. Depending > on the nature of the bug in JBS, the patch would target either the > repositories of the JDK 8 Updates Project or the repositories of the JDK > 9 Project. > > The type-annotations-dev list is still playing a useful role as people > download early-access JDK 8 binaries from Oracle and have questions > about applying type annotations in source code, reflecting over them, > etc. However, I don't see the list as necessary after the GA of JDK 8 in > March. > > At that time, we should archive the list, make the forest read-only, and > then vote to shut down the Type Annotations Project. (The ThreeTen > Project will do basically the same.) JSR 308 will have made its Final > Release and you and I will bask in the glory of being Maintenance Leads. > > Werner, > > Since you were an Author in the JDK 8 Project, you're an Author in the > JDK 8 Updates Project and JDK 9 Project. It would probably be useful for > you to be a Committer in one or both of those Projects, but there's a > process for that, of course. > > Alex > > On 12/16/2013 4:15 PM, Michael Ernst wrote: >> Werner- >> >> I feel that the type-annotations forest has served its purpose. We >> don't expect any significant development to occur on it -- just bug >> fixes. Those bug fixes can be communicated as patches and applied to >> whatever forest is used for JDK 8 maintenance. >> >> Do others feel differently? >> >> -Mike >> >> >>> Subject: type-annotations based on JDK 9? >>> From: Werner Dietl >>> To: Jonathan Gibbons >>> Date: Mon, 16 Dec 2013 17:56:06 -0500 >>> >>> Hi all, >>> >>> now that updates in the JDK 8 repositories are winding down, I'm >>> wondering whether I should start updating type-annotations from a JDK >>> 9 forest, e.g.: >>> >>> http://hg.openjdk.java.net/jdk9/dev/ >>> >>> Or should we keep the current jdk8/tl setup and switch once a jdk8u >>> forest exists? >>> >>> The type-annotations forest could continue to be the "play-ground" for >>> fixes to type annotations handling. >>> Or should we unceremoniously remove the type-annotations forest? >>> >>> cu, WMD. >>> >>> On Thu, Dec 5, 2013 at 7:29 PM, Jonathan Gibbons >>> wrote: >>>> Interesting point. >>>> >>>> Once 8 has shipped, the 8 repos will be frozen. Updates to 8 will >>>> occur in >>>> a new 8 update forest, similar to the way that 7 updates happen now. >>>> I'm >>>> not sure if we can reparent type-annotations to 9 -- I will ask. >>>> But we >>>> can still sync the forest from 9. >>>> >>>> -- Jon >>>> >>>> >>>> On 12/05/2013 04:00 PM, Werner Dietl wrote: >>>>> >>>>> Jon, >>>>> >>>>> thanks for that info. >>>>> Will the type-annotations repositories continue to exist? >>>>> Once the jdk9 repos are created, we could continue to use >>>>> type-annotations to test type-annotation fixes. >>>>> >>>>> cu, WMD. >>>> >>>> >>> >>> >>> >>> -- >>> http://www.google.com/profiles/wdietl From mernst at cs.washington.edu Thu Aug 14 03:57:08 2014 From: mernst at cs.washington.edu (Michael Ernst) Date: Thu, 14 Aug 2014 05:57:08 +0200 (CEST) Subject: type-annotations based on JDK 9? In-Reply-To: <53E9057F.5060800@oracle.com> References: <20131216.161531.731673380041851584.mernst@cs.washington.edu> <52D09908.8050101@oracle.com> <53E9057F.5060800@oracle.com> Message-ID: <20140814.055708.2145748878101765923.mernst@cs.washington.edu> Alex- Sorry for the delay in responding; I am traveling. Your proposed change sounds good. I'm glad to see type annotations transition from a project to merely a standard part of Java! -Mike > Subject: Re: type-annotations based on JDK 9? > From: Alex Buckley > To: Michael Ernst > Date: Mon, 11 Aug 2014 11:03:43 -0700 > > Mike, > > I'd like to suggest that it's now time to disable the > type-annotations-dev list and remove the > type-annotations/type-annotations forest. > > The Type Annotations Project itself will remain, with a web page in the > style of the ThreeTen Project - see > http://openjdk.java.net/projects/threeten/. The Project and its > contributors will continue to appear in the OpenJDK Census at > http://openjdk.java.net/census#type-annotations. > > Alex > > On 1/10/2014 5:06 PM, Alex Buckley wrote: >> Mike, >> >> I've asked around (it took a while) about the future of the three >> OpenJDK Projects - Lambda, ThreeTen, and Type Annotations - which host >> Reference Implementations of JSRs for Java SE 8. >> >> The Type Annotations Project has essentially served its purpose of >> hosting the RI for JSR 308, and allowing the RI's code to make its way >> into the repositories of the JDK 8 Project. Woohoo! >> >> I agree that the type-annotations forest used by the Type Annotations >> Project has served its purpose. From now on, bug fixes to javac's >> handling of type annotations should be sent as patches to the >> compiler-dev list, just like fixes to any other area of javac. Depending >> on the nature of the bug in JBS, the patch would target either the >> repositories of the JDK 8 Updates Project or the repositories of the JDK >> 9 Project. >> >> The type-annotations-dev list is still playing a useful role as people >> download early-access JDK 8 binaries from Oracle and have questions >> about applying type annotations in source code, reflecting over them, >> etc. However, I don't see the list as necessary after the GA of JDK 8 in >> March. >> >> At that time, we should archive the list, make the forest read-only, and >> then vote to shut down the Type Annotations Project. (The ThreeTen >> Project will do basically the same.) JSR 308 will have made its Final >> Release and you and I will bask in the glory of being Maintenance Leads. >> >> Werner, >> >> Since you were an Author in the JDK 8 Project, you're an Author in the >> JDK 8 Updates Project and JDK 9 Project. It would probably be useful for >> you to be a Committer in one or both of those Projects, but there's a >> process for that, of course. >> >> Alex >> >> On 12/16/2013 4:15 PM, Michael Ernst wrote: >>> Werner- >>> >>> I feel that the type-annotations forest has served its purpose. We >>> don't expect any significant development to occur on it -- just bug >>> fixes. Those bug fixes can be communicated as patches and applied to >>> whatever forest is used for JDK 8 maintenance. >>> >>> Do others feel differently? >>> >>> -Mike >>> >>> >>>> Subject: type-annotations based on JDK 9? >>>> From: Werner Dietl >>>> To: Jonathan Gibbons >>>> Date: Mon, 16 Dec 2013 17:56:06 -0500 >>>> >>>> Hi all, >>>> >>>> now that updates in the JDK 8 repositories are winding down, I'm >>>> wondering whether I should start updating type-annotations from a JDK >>>> 9 forest, e.g.: >>>> >>>> http://hg.openjdk.java.net/jdk9/dev/ >>>> >>>> Or should we keep the current jdk8/tl setup and switch once a jdk8u >>>> forest exists? >>>> >>>> The type-annotations forest could continue to be the "play-ground" for >>>> fixes to type annotations handling. >>>> Or should we unceremoniously remove the type-annotations forest? >>>> >>>> cu, WMD. >>>> >>>> On Thu, Dec 5, 2013 at 7:29 PM, Jonathan Gibbons >>>> wrote: >>>>> Interesting point. >>>>> >>>>> Once 8 has shipped, the 8 repos will be frozen. Updates to 8 will >>>>> occur in >>>>> a new 8 update forest, similar to the way that 7 updates happen now. >>>>> I'm >>>>> not sure if we can reparent type-annotations to 9 -- I will ask. >>>>> But we >>>>> can still sync the forest from 9. >>>>> >>>>> -- Jon >>>>> >>>>> >>>>> On 12/05/2013 04:00 PM, Werner Dietl wrote: >>>>>> >>>>>> Jon, >>>>>> >>>>>> thanks for that info. >>>>>> Will the type-annotations repositories continue to exist? >>>>>> Once the jdk9 repos are created, we could continue to use >>>>>> type-annotations to test type-annotation fixes. >>>>>> >>>>>> cu, WMD. >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> http://www.google.com/profiles/wdietl