From wdietl at gmail.com Mon May 5 18:35:21 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 18:35:21 +0000 Subject: hg: type-annotations/type-annotations: 5 new changesets Message-ID: <201405051835.s45IZM4F011856@aojmv0008> Changeset: de3a6b2a6904 Author: erikj Date: 2014-04-30 10:36 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/de3a6b2a6904 8041265: jdk/bin/rmic -iiop failed on macosx-x86_64 with "Class sun.rmi.rmic.iiop.BatchEnvironmen not found" Reviewed-by: tbell, msheppar ! make/common/JavaCompilation.gmk Changeset: 183052721803 Author: erikj Date: 2014-04-30 14:45 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/183052721803 8042213: Freetype detection fails on Solaris sparcv9 when using devkit Reviewed-by: tbell ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: 1fd60d6e197e Author: katleman Date: 2014-05-01 12:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/1fd60d6e197e Added tag jdk9-b11 for changeset ab55a18a95e1 ! .hgtags Changeset: 59f6350295f9 Author: lana Date: 2014-05-01 14:19 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/59f6350295f9 Merge Changeset: a579534b82ff Author: wmdietl Date: 2014-05-05 14:35 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/a579534b82ff Automated merge with http://hg.openjdk.java.net/jdk9/dev/ ! .hgtags From wdietl at gmail.com Mon May 5 18:35:39 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 18:35:39 +0000 Subject: hg: type-annotations/type-annotations/corba: 2 new changesets Message-ID: <201405051835.s45IZeB4011920@aojmv0008> Changeset: e212cdcc8c11 Author: katleman Date: 2014-05-01 12:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/e212cdcc8c11 Added tag jdk9-b11 for changeset 77ea0a250358 ! .hgtags Changeset: c4f026e9aa34 Author: wmdietl Date: 2014-05-05 14:35 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/c4f026e9aa34 Automated merge with http://hg.openjdk.java.net/jdk9/dev/corba ! .hgtags From wdietl at gmail.com Mon May 5 18:36:23 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 18:36:23 +0000 Subject: hg: type-annotations/type-annotations/jaxws: 5 new changesets Message-ID: <201405051836.s45IaSV1011986@aojmv0008> Changeset: f51b5ea42589 Author: mkos Date: 2014-04-28 14:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/f51b5ea42589 8040754: Break the circular dependency between SAAJ and JAXB Reviewed-by: chegar, mchung ! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/StaxBridge.java + src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/stax/SaajStaxReaderEx.java + src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/stax/SaajStaxWriter.java + src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/util/stax/SaajStaxWriterEx.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/BinaryText.java ! src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/StAxSOAPBody.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/saaj/SAAJFactory.java ! src/share/jaxws_classes/com/sun/xml/internal/ws/api/message/saaj/SaajStaxWriter.java Changeset: 43683fefd932 Author: mchung Date: 2014-04-28 14:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/43683fefd932 8042058: Missing deleted files from JDK-8040754 breaks jdk9/dev build Reviewed-by: chegar - src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/util/SaajStaxReaderEx.java - src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/util/SaajStaxWriter.java - src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/util/SaajStaxWriterEx.java Changeset: bdef19a15643 Author: katleman Date: 2014-05-01 12:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/bdef19a15643 Added tag jdk9-b11 for changeset 1f953ba7db2b ! .hgtags Changeset: 779f8b21c75f Author: lana Date: 2014-05-01 14:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/779f8b21c75f Merge - src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/util/SaajStaxReaderEx.java - src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/util/SaajStaxWriter.java - src/share/jaxws_classes/com/sun/xml/internal/org/jvnet/staxex/util/SaajStaxWriterEx.java Changeset: 6d7ba9d36401 Author: wmdietl Date: 2014-05-05 14:36 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/6d7ba9d36401 Automated merge with http://hg.openjdk.java.net/jdk9/dev/jaxws ! .hgtags From wdietl at gmail.com Mon May 5 18:37:35 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 18:37:35 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 2 new changesets Message-ID: <201405051837.s45IbchJ012130@aojmv0008> Changeset: e88cecf5a21b Author: katleman Date: 2014-05-01 12:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/e88cecf5a21b Added tag jdk9-b11 for changeset 6b4280dceb00 ! .hgtags Changeset: 4dd19a89d242 Author: wmdietl Date: 2014-05-05 14:37 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/4dd19a89d242 Automated merge with http://hg.openjdk.java.net/jdk9/dev/jaxp ! .hgtags From wdietl at gmail.com Mon May 5 18:38:04 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 18:38:04 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 4 new changesets Message-ID: <201405051838.s45Ic6ef012197@aojmv0008> Changeset: 63d07ab01ced Author: katleman Date: 2014-05-01 12:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/63d07ab01ced Added tag jdk9-b11 for changeset 4d60c3292e14 ! .hgtags Changeset: 282e9a675e07 Author: lana Date: 2014-05-01 14:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/282e9a675e07 Merge Changeset: f7f2e9d2912b Author: sundar Date: 2014-05-02 19:15 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/f7f2e9d2912b 8027933: Add --const-as-var option Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn/internal/parser/TokenType.java ! src/jdk/nashorn/internal/runtime/ScriptEnvironment.java ! src/jdk/nashorn/internal/runtime/resources/Options.properties ! test/script/basic/JDK-8008448.js + test/script/basic/JDK-8027933.js + test/script/basic/JDK-8027933.js.EXPECTED + test/script/error/JDK-8027933.js + test/script/error/JDK-8027933.js.EXPECTED ! test/src/jdk/nashorn/internal/codegen/CompilerTest.java ! test/src/jdk/nashorn/internal/parser/ParserTest.java ! test/src/jdk/nashorn/internal/runtime/TrustedScriptEngineTest.java Changeset: 6957d66d2d4c Author: wmdietl Date: 2014-05-05 14:37 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/6957d66d2d4c Automated merge with http://hg.openjdk.java.net/jdk9/dev/nashorn From wdietl at gmail.com Mon May 5 18:48:26 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 18:48:26 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 32 new changesets Message-ID: <201405051849.s45In0dG013982@aojmv0008> Changeset: 43106b748d31 Author: ctornqvi Date: 2014-04-17 00:03 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/43106b748d31 6959423: [TESTBUG] runtime/6925573/SortMethodsTest.java times out Summary: Decreased maximum number methods in generated classes and decreased ratio to make it reproduce more often Reviewed-by: coleenp, lfoltan ! test/runtime/6925573/SortMethodsTest.java Changeset: baf3131f2e4c Author: ctornqvi Date: 2014-04-18 00:19 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/baf3131f2e4c 8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java Summary: Removed test/runtime/6925573/SortMethodsTest.java Reviewed-by: coleenp, rdurbin - test/runtime/6925573/SortMethodsTest.java Changeset: 681564abbbbd Author: hseigel Date: 2014-04-18 08:51 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/681564abbbbd 8040018: Remove bad assert in ClassFileParser.cpp Summary: Remove assert that prevent throwing valid exception Reviewed-by: coleenp, lfoltan ! src/share/vm/classfile/classFileParser.cpp + test/runtime/classFileParserBug/ClassFileParserBug.java + test/runtime/classFileParserBug/LambdaMath.jcod + test/runtime/classFileParserBug/test.jar Changeset: b663617962e8 Author: dcubed Date: 2014-04-18 10:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b663617962e8 Merge ! src/share/vm/classfile/classFileParser.cpp - test/runtime/6925573/SortMethodsTest.java Changeset: eb8897b2687e Author: roland Date: 2014-04-18 14:25 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/eb8897b2687e 8039975: SIGSEGV in MethodData::next_data(ProfileData*) Summary: profiling code in interpreter broken when argument profiling is off. Reviewed-by: iveresov, kvn ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/x86/vm/interp_masm_x86.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/oops/methodData.hpp Changeset: 2131bc2cc840 Author: bharadwaj Date: 2014-04-18 14:30 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2131bc2cc840 Merge Changeset: 4bc3f8fa071f Author: kvn Date: 2014-04-22 17:45 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/4bc3f8fa071f 8041351: Crash in src/share/vm/opto/loopnode.cpp:3215 - assert(!had_error) failed: bad dominance Summary: add missing is_mem() check when we collect load nodes in SuperWord::co_locate_pack(). Reviewed-by: iveresov ! src/share/vm/opto/superword.cpp Changeset: c800e0d7816f Author: bharadwaj Date: 2014-04-24 17:20 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c800e0d7816f Merge - test/runtime/6925573/SortMethodsTest.java Changeset: cec569179bb8 Author: stefank Date: 2014-04-09 13:54 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/cec569179bb8 8039743: Use correct format specifier to print size_t values and pointers in the GC code Reviewed-by: jmasa, sjohanss Contributed-by: stefan.karlsson at oracle.com, mikael.vidstedt at oracle.com ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/survRateGroup.cpp ! src/share/vm/gc_implementation/parallelScavenge/adjoiningGenerations.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/shared/spaceDecorator.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/generation.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: ebe7363ae01b Author: pliden Date: 2014-04-11 11:00 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ebe7363ae01b 8037112: gc/g1/TestHumongousAllocInitialMark.java caused SIGSEGV Reviewed-by: brutisso, mgerdin ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1StringDedup.cpp ! src/share/vm/gc_implementation/g1/g1StringDedup.hpp ! src/share/vm/gc_implementation/g1/g1StringDedupQueue.cpp ! src/share/vm/gc_implementation/g1/g1StringDedupQueue.hpp ! src/share/vm/gc_implementation/g1/g1StringDedupThread.cpp ! src/share/vm/gc_implementation/g1/g1StringDedupThread.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/runtime/java.cpp Changeset: f447397ebbcd Author: pliden Date: 2014-04-11 12:29 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f447397ebbcd 8039147: Cleanup SuspendibleThreadSet Reviewed-by: brutisso, tschatzl, mgerdin ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1StringDedupThread.cpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.cpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp + src/share/vm/gc_implementation/shared/suspendibleThreadSet.cpp + src/share/vm/gc_implementation/shared/suspendibleThreadSet.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/safepoint.cpp Changeset: f665fa6f2aa4 Author: jwilhelm Date: 2014-04-11 18:28 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f665fa6f2aa4 8037924: CMM Testing: Check Min/MaxHeapFreeRatio flags allows to shrink the heap when using ParallelGC Summary: New test implemented Reviewed-by: ehelin, tschatzl Contributed-by: andrey.x.zakharov at oracle.com ! test/TEST.groups + test/gc/parallelScavenge/TestDynShrinkHeap.java Changeset: c67b4bad6aa1 Author: ehelin Date: 2014-04-14 10:08 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c67b4bad6aa1 Merge ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/runtime/safepoint.cpp Changeset: 43875cba960e Author: jwilhelm Date: 2014-04-15 18:09 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/43875cba960e 8037925: CMM Testing: an allocated humongous object at the end of the heap should not prevents shrinking the heap Summary: New test added. Reviewed-by: ehelin, tschatzl, jwilhelm Contributed-by: andrey.x.zakharov at oracle.com ! test/TEST.groups + test/gc/g1/TestHumongousShrinkHeap.java Changeset: 3c6b2880dcad Author: stefank Date: 2014-04-15 20:46 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3c6b2880dcad 8039957: Replace the last few %p usages with PTR_FORMAT in the GC code Reviewed-by: jwilhelm, sjohanss, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp ! src/share/vm/memory/defNewGeneration.cpp Changeset: 28b574c9e549 Author: tschatzl Date: 2014-04-16 10:14 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/28b574c9e549 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet Summary: The test incorrectly assumed that it had been started with no other previous compilation activity. Fix this by allowing multiple code root free chunk lists, and use one separate from the global one to perform the test. Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/g1CodeCacheRemSet.cpp ! src/share/vm/gc_implementation/g1/g1CodeCacheRemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp Changeset: ed06c8e187ad Author: tschatzl Date: 2014-04-16 10:55 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ed06c8e187ad 8027553: Change the in_cset_fast_test functionality to use the G1BiasedArray abstraction Summary: Instead of using a manually managed array for the in_cset_fast_test array, use a G1BiasedArray instance. Reviewed-by: brutisso, mgerdin ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp Changeset: 51e6d4019aeb Author: tschatzl Date: 2014-04-16 10:55 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/51e6d4019aeb 8037344: Use the "next" field to iterate over fine remembered instead of using the hash table Summary: After changes to the PerRegionTable where all these PRTs are linked together in an additional field, simplify iterating over all PRTs by using these links instead of walki Reviewed-by: mgerdin, jwilhelm, brutisso ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp Changeset: f0caf386d544 Author: tschatzl Date: 2014-04-16 10:56 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f0caf386d544 8039596: Remove HeapRegionRemSet::clear_incoming_entry Summary: The mentioned method is never used and out of date. So it is removed. Reviewed-by: mgerdin, brutisso ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp Changeset: 856a202c9ca0 Author: tschatzl Date: 2014-04-16 11:05 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/856a202c9ca0 8028710: G1 does not retire allocation buffers after reference processing work Summary: G1 does not retire allocation buffers after reference processing work when -XX:+ParallelRefProcEnabled is enabled. This causes wrong calculation of PLAB sizes, as the amount of space wasted is not updated correctly. Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp Changeset: fee044a1aa4e Author: tschatzl Date: 2014-04-16 16:46 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/fee044a1aa4e 8019342: G1: High "Other" time most likely due to card redirtying Summary: Parallelize card redirtying to decrease the time it takes. Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.hpp ! test/gc/g1/TestGCLogMessages.java Changeset: 88c6d7bfc89e Author: tschatzl Date: 2014-04-16 16:47 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/88c6d7bfc89e 8040002: Clean up code and code duplication in re-diryting cards for verification Summary: Card re-dirtying code for verification and actual redirtying uses two different, almost completely identical card closures. Also the verification code still assumes a perm gen. Reviewed-by: brutisso, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: a9272c62c519 Author: brutisso Date: 2014-04-17 15:57 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a9272c62c519 8040722: G1: Clean up usages of heap_region_containing Reviewed-by: tschatzl, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.inline.hpp Changeset: d9c2044cbbd7 Author: pliden Date: 2014-04-17 18:47 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/d9c2044cbbd7 8040245: G1: VM hangs during shutdown Summary: temporarily disable the shutdown of the concurrent GC threads introduced in JDK-8037112 Reviewed-by: brutisso, tschatzl, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 9314dc72e2f9 Author: tschatzl Date: 2014-04-22 11:10 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9314dc72e2f9 8040792: G1: Memory usage calculation uses sizeof(this) instead of sizeof(classname) Summary: A few locations in the code use sizeof(this) which returns the size of the pointer instead of sizeof(classname) which returns the size of the sum of its members. This change fixes these errors and adds a few tests. Reviewed-by: mgerdin, brutisso ! src/share/vm/gc_implementation/g1/g1CodeCacheRemSet.cpp ! src/share/vm/gc_implementation/g1/g1CodeCacheRemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp Changeset: 655fc7de83a2 Author: ehelin Date: 2014-04-23 10:12 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/655fc7de83a2 Merge ! src/share/vm/gc_interface/collectedHeap.hpp ! test/TEST.groups - test/runtime/InitialThreadOverflow/invoke.cxx Changeset: 98dce985df09 Author: brutisso Date: 2014-04-23 12:37 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/98dce985df09 8038265: CMS: enable time based triggering of concurrent cycles Reviewed-by: mgerdin, brutisso Contributed-by: michal at frajt.eu ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/runtime/globals.hpp Changeset: caed2f29a6c2 Author: ehelin Date: 2014-04-25 15:50 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/caed2f29a6c2 Merge Changeset: 5adf605e17db Author: amurillo Date: 2014-04-25 09:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5adf605e17db Merge - test/runtime/6925573/SortMethodsTest.java Changeset: de1dca33bdfc Author: katleman Date: 2014-05-01 12:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/de1dca33bdfc Added tag jdk9-b11 for changeset 783309c3a1a6 ! .hgtags Changeset: 1c383bb39e28 Author: lana Date: 2014-05-01 14:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1c383bb39e28 Merge - test/runtime/6925573/SortMethodsTest.java Changeset: 73e1f2adcf55 Author: wmdietl Date: 2014-05-05 14:48 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/73e1f2adcf55 Automated merge with http://hg.openjdk.java.net/jdk9/dev/hotspot ! .hgtags From wdietl at gmail.com Mon May 5 18:41:39 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 18:41:39 +0000 Subject: hg: type-annotations/type-annotations/jdk: 91 new changesets Message-ID: <201405051849.s45InWrp014081@aojmv0008> Changeset: 2b5b8d82173e Author: sla Date: 2014-04-25 17:19 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2b5b8d82173e 8033104: sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all platforms Reviewed-by: kamg, mgronlun ! make/mapfiles/libjava/mapfile-vers ! src/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java ! src/share/classes/sun/misc/VMSupport.java ! src/share/javavm/export/jvm.h ! src/share/native/sun/misc/VMSupport.c ! test/com/sun/tools/attach/BasicTests.java ! test/com/sun/tools/attach/RunnerUtil.java + test/com/sun/tools/attach/TempDirTest.java ! test/com/sun/tools/attach/java.policy.allow ! test/com/sun/tools/attach/java.policy.deny Changeset: 8adb41252e15 Author: sla Date: 2014-04-25 18:28 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8adb41252e15 8041948: Build broken by fix of 8033104 Reviewed-by: darcy ! make/mapfiles/libjava/mapfile-vers ! src/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java ! src/share/classes/sun/misc/VMSupport.java ! src/share/javavm/export/jvm.h ! src/share/native/sun/misc/VMSupport.c ! test/com/sun/tools/attach/BasicTests.java ! test/com/sun/tools/attach/RunnerUtil.java - test/com/sun/tools/attach/TempDirTest.java ! test/com/sun/tools/attach/java.policy.allow ! test/com/sun/tools/attach/java.policy.deny Changeset: f00efa72970e Author: naoto Date: 2014-04-25 10:30 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f00efa72970e 8035826: [parfait] JNI exception pending in src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c Reviewed-by: msheppar ! src/macosx/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c ! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c Changeset: e8656ee2cdde Author: mduigou Date: 2014-03-12 12:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e8656ee2cdde 8035584: ArrayList(c) should avoid inflation if c is empty Reviewed-by: martin ! src/share/classes/java/util/ArrayList.java Changeset: 8b80651ce43f Author: plevart Date: 2014-04-26 11:11 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8b80651ce43f 8040892: Incorrect message in Exception thrown by Collectors.toMap(Function,Function) Summary: Use Map.putIfAbsent instead of Map.merge when collecting into map using unique keys Reviewed-by: psandoz, chegar ! src/share/classes/java/util/stream/Collectors.java Changeset: 99a5764129fb Author: michaelm Date: 2014-04-28 13:49 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/99a5764129fb 8041621: java/net/Inet4Address/textToNumericFormat.java fails on Solaris and Mac Reviewed-by: chegar + test/java/net/Inet4Address/DummyNameService.java + test/java/net/Inet4Address/DummyNameServiceDescriptor.java + test/java/net/Inet4Address/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor ! test/java/net/Inet4Address/textToNumericFormat.java Changeset: 4e7f3aac979b Author: jbachorik Date: 2014-04-29 11:15 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4e7f3aac979b 8031195: Support default and static interface methods in JDI, JDWP and JDB Reviewed-by: sla, sspitsyn, dcubed ! make/data/jdwp/jdwp.spec + src/share/back/InterfaceTypeImpl.c + src/share/back/InterfaceTypeImpl.h ! src/share/back/VirtualMachineImpl.c ! src/share/back/debugDispatch.c ! src/share/back/util.c ! src/share/classes/com/sun/jdi/ClassType.java ! src/share/classes/com/sun/jdi/InterfaceType.java ! src/share/classes/com/sun/jdi/Method.java ! src/share/classes/com/sun/jdi/ObjectReference.java ! src/share/classes/com/sun/tools/example/debug/expr/LValue.java ! src/share/classes/com/sun/tools/jdi/ClassTypeImpl.java ! src/share/classes/com/sun/tools/jdi/InterfaceTypeImpl.java + src/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java ! src/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java + test/com/sun/jdi/EvalInterfaceStatic.sh + test/com/sun/jdi/InterfaceMethodsTest.java Changeset: cda85444cad2 Author: alanb Date: 2014-04-29 13:23 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cda85444cad2 8034057: Files.getFileStore and Files.isWritable do not work with SUBST'ed drives (win) Reviewed-by: alanb, chegar Contributed-by: pavel.rappo at oracle.com ! src/windows/classes/sun/nio/fs/WindowsConstants.java ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java Changeset: 276c2688450d Author: jbachorik Date: 2014-04-29 14:37 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/276c2688450d 8042096: Backout JDK-8042091 Reviewed-by: sla ! make/data/jdwp/jdwp.spec - src/share/back/InterfaceTypeImpl.c - src/share/back/InterfaceTypeImpl.h ! src/share/back/VirtualMachineImpl.c ! src/share/back/debugDispatch.c ! src/share/back/util.c ! src/share/classes/com/sun/jdi/ClassType.java ! src/share/classes/com/sun/jdi/InterfaceType.java ! src/share/classes/com/sun/jdi/Method.java ! src/share/classes/com/sun/jdi/ObjectReference.java ! src/share/classes/com/sun/tools/example/debug/expr/LValue.java ! src/share/classes/com/sun/tools/jdi/ClassTypeImpl.java ! src/share/classes/com/sun/tools/jdi/InterfaceTypeImpl.java - src/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java ! src/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java - test/com/sun/jdi/EvalInterfaceStatic.sh - test/com/sun/jdi/InterfaceMethodsTest.java Changeset: 44fbb7e1a473 Author: bpb Date: 2014-04-29 09:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/44fbb7e1a473 8041683: Catch OutOfMemoryError in BitLengthOverflow and DoubleValueOverflow Summary: java/math/BigInteger/BitLengthOverflow.java failing with OOME Reviewed-by: alanb ! test/java/math/BigInteger/BitLengthOverflow.java ! test/java/math/BigInteger/DoubleValueOverflow.java Changeset: 8c8bc4ac31a3 Author: mduigou Date: 2014-03-11 15:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8c8bc4ac31a3 8037097: Improve diagnosability of test failures for java/util/Arrays/Correct.java Reviewed-by: mchung, alanb ! test/java/util/Arrays/Correct.java Changeset: 0336df7ba915 Author: pchelko Date: 2014-03-25 16:31 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0336df7ba915 8031001: [Parfait] warnings from b121 for jdk/src/solaris/native/sun/awt: JNI-related warnings Reviewed-by: serb, anthony ! src/solaris/native/sun/awt/CUPSfuncs.c ! src/solaris/native/sun/awt/X11Color.c ! src/solaris/native/sun/awt/awt.h ! src/solaris/native/sun/awt/awt_AWTEvent.c ! src/solaris/native/sun/awt/awt_DrawingSurface.c ! src/solaris/native/sun/awt/awt_Font.c ! src/solaris/native/sun/awt/awt_GraphicsEnv.c ! src/solaris/native/sun/awt/awt_InputMethod.c ! src/solaris/native/sun/awt/awt_Insets.c ! src/solaris/native/sun/awt/awt_LoadLibrary.c ! src/solaris/native/sun/awt/awt_Robot.c ! src/solaris/native/sun/awt/awt_UNIXToolkit.c ! src/solaris/native/sun/awt/awt_util.c ! src/solaris/native/sun/awt/fontpath.c ! src/solaris/native/sun/awt/initIDs.c ! src/solaris/native/sun/awt/multi_font.c ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c Changeset: 3844d4e9fda5 Author: kshefov Date: 2014-03-25 18:23 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3844d4e9fda5 8031422: [TEST_BUG] java/awt/Paint/bug8024864.java fails on Windows 7 Reviewed-by: pchelko, azvegint ! test/java/awt/Paint/bug8024864.java Changeset: 8b206653d196 Author: prr Date: 2014-03-25 12:51 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8b206653d196 8034104: [parfait] warnings from jdk/src/macosx/native/sun/awt/CTextPipe.m Reviewed-by: serb, jgodinez ! src/macosx/native/sun/awt/CTextPipe.m Changeset: 218ba3f17a70 Author: prr Date: 2014-03-25 14:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/218ba3f17a70 8037910: [parfait] JNI warnings in jdk/src/windows/native/sun/java2d/d3d/D3DSurfaceData.cpp Reviewed-by: serb, jgodinez ! src/share/native/sun/java2d/opengl/OGLSurfaceData.c ! src/windows/native/sun/java2d/d3d/D3DSurfaceData.cpp Changeset: ee50ec79fa07 Author: pchelko Date: 2014-03-26 17:01 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ee50ec79fa07 8032595: [macosx] setResizable(false) makes a frame slide down Reviewed-by: serb, ddehaven, azvegint ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Frame/SlideNotResizableTest/SlideNotResizableTest.java Changeset: 8379313ae50e Author: alitvinov Date: 2014-03-28 14:41 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8379313ae50e 8032832: Applet/browser deadlocks, when IIS integrated authentication is used Reviewed-by: chegar, weijun ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java Changeset: 16f14268c0da Author: vadim Date: 2014-03-28 14:53 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/16f14268c0da 8029628: Many graphic artifacts Reviewed-by: prr, bae ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 07dc208840ca Author: alexsch Date: 2014-03-28 17:31 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/07dc208840ca 8036882: [macosx] Native memory leak in Java_sun_lwawt_macosx_CImage_nativeGetNSImageRepresentationSizes Reviewed-by: serb, pchelko ! src/macosx/native/sun/awt/CImage.m Changeset: 4126433e0bd2 Author: alexsch Date: 2014-03-28 18:56 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4126433e0bd2 8032667: [macosx] Components cannot be rendered in HiDPI to BufferedImage Reviewed-by: serb, pchelko ! src/macosx/classes/com/apple/laf/AquaPainter.java ! src/share/classes/sun/awt/image/MultiResolutionBufferedImage.java + test/javax/swing/JCheckBox/8032667/bug8032667.html + test/javax/swing/JCheckBox/8032667/bug8032667.java + test/javax/swing/JCheckBox/8032667/bug8032667_image_diff.java Changeset: 7c421bd2740f Author: prr Date: 2014-03-28 11:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7c421bd2740f 8037506: [javadoc] broken link in java.awt.geom.Line2D.java Reviewed-by: jgodinez ! src/share/classes/java/awt/geom/Line2D.java Changeset: 393cbd8d9525 Author: ptbrunet Date: 2014-03-28 16:40 -0500 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/393cbd8d9525 8034118: [parfait] JNI exception pending in macosx/native/sun/awt/JavaComponentAccessibility.m Summary: handle possible JNI Exceptions Reviewed-by: prr, serb Contributed-by: peter.brunet at oracle.com ! src/macosx/native/sun/awt/JavaComponentAccessibility.m Changeset: 76bc6626152d Author: ptbrunet Date: 2014-03-28 17:19 -0500 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/76bc6626152d 8034768: [parfait] JNI exception pending in jdk/src/macosx/native/sun/awt/JavaTextAccessibility.m Summary: handle possible JNI Exceptions Reviewed-by: prr, serb Contributed-by: peter.brunet at oracle.com ! src/macosx/native/sun/awt/JavaTextAccessibility.m Changeset: 7f98f7c79bc5 Author: kshefov Date: 2014-03-31 17:59 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7f98f7c79bc5 8002148: [TEST_BUG] The four lines printed are not the bold typeface. Reviewed-by: pchelko, serb + test/javax/swing/text/GlyphView/4984669/bug4984669.html + test/javax/swing/text/GlyphView/4984669/bug4984669.java Changeset: 5ca706cc04ba Author: prr Date: 2014-03-31 11:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5ca706cc04ba 8038723: Openup some PrinterJob tests Reviewed-by: jgodinez + test/java/awt/print/Dialog/DestinationTest.java + test/java/awt/print/Dialog/MediaInPrintable.java + test/java/awt/print/Dialog/PrintApplet.html + test/java/awt/print/Dialog/PrintApplet.java + test/java/awt/print/Dialog/PrintDialog.java + test/java/awt/print/Dialog/PrintDlgApp.java + test/java/awt/print/Dialog/PrintDlgPageable.java + test/java/awt/print/Dialog/RestoreActiveWindowTest/RestoreActiveWindowTest.html + test/java/awt/print/Dialog/RestoreActiveWindowTest/RestoreActiveWindowTest.java + test/java/awt/print/PageFormat/CustomPaper.java + test/java/awt/print/PageFormat/NullPaper.java + test/java/awt/print/PageFormat/Orient.java + test/java/awt/print/PageFormat/PDialogTest.java + test/java/awt/print/PageFormat/PageSetupDialog.java + test/java/awt/print/PageFormat/ReverseLandscapeTest.java + test/java/awt/print/PageFormat/SetOrient.html + test/java/awt/print/PageFormat/SetOrient.java + test/java/awt/print/PageFormat/SmallPaperPrinting.java + test/java/awt/print/PageFormat/ValidateCustom.java + test/java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java + test/java/awt/print/PrinterJob/CheckAccess.java + test/java/awt/print/PrinterJob/CheckPrivilege.java + test/java/awt/print/PrinterJob/CompareImageable.java + test/java/awt/print/PrinterJob/CustomFont/A.ttf + test/java/awt/print/PrinterJob/CustomFont/CustomFont.java + test/java/awt/print/PrinterJob/DeviceScale.java + test/java/awt/print/PrinterJob/DrawImage.java + test/java/awt/print/PrinterJob/DrawStringMethods.java + test/java/awt/print/PrinterJob/EmptyFill.java + test/java/awt/print/PrinterJob/GlyphPositions.java + test/java/awt/print/PrinterJob/HeadlessPrintingTest.java + test/java/awt/print/PrinterJob/InitToBlack.java + test/java/awt/print/PrinterJob/InvalidPage.java + test/java/awt/print/PrinterJob/JobName/PrinterJobName.java + test/java/awt/print/PrinterJob/Legal/PrintTest.java + test/java/awt/print/PrinterJob/MultiThread/MultiThreadTest.java + test/java/awt/print/PrinterJob/NullGetName.java + test/java/awt/print/PrinterJob/NumCopies.java + test/java/awt/print/PrinterJob/PSQuestionMark.java + test/java/awt/print/PrinterJob/PSWindingRule.java + test/java/awt/print/PrinterJob/PageDialogTest.java + test/java/awt/print/PrinterJob/PageDlgPrnButton.java + test/java/awt/print/PrinterJob/PaintText.java + test/java/awt/print/PrinterJob/PrintAllFonts.java + test/java/awt/print/PrinterJob/PrintBadImage.java + test/java/awt/print/PrinterJob/PrintCompoundString.java + test/java/awt/print/PrinterJob/PrintDialog.java + test/java/awt/print/PrinterJob/PrintDialogCancel.java + test/java/awt/print/PrinterJob/PrintFontStyle.java + test/java/awt/print/PrinterJob/PrintImage.java + test/java/awt/print/PrinterJob/PrintNullString.java + test/java/awt/print/PrinterJob/PrintParenString.java + test/java/awt/print/PrinterJob/PrintRotatedText.java + test/java/awt/print/PrinterJob/PrintTextLayout.java + test/java/awt/print/PrinterJob/PrintTextPane.java + test/java/awt/print/PrinterJob/PrintTextTest.java + test/java/awt/print/PrinterJob/PrintTranslatedFont.java + test/java/awt/print/PrinterJob/PrintVolatileImage.java + test/java/awt/print/PrinterJob/PrinterDevice.java + test/java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html + test/java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.java + test/java/awt/print/PrinterJob/PrinterJobDialogBugDemo.java + test/java/awt/print/PrinterJob/RemoveListener.java + test/java/awt/print/PrinterJob/ScaledText/ScaledText.java + test/java/awt/print/PrinterJob/SecurityDialogTest.java + test/java/awt/print/PrinterJob/SetCopies/Test.java + test/java/awt/print/PrinterJob/SwingUIText.java + test/java/awt/print/PrinterJob/ThinLines.java + test/java/awt/print/PrinterJob/XparColor.java + test/java/awt/print/PrinterJob/raster/RasterTest.java Changeset: 1c293d61d0b3 Author: serb Date: 2014-04-01 00:33 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1c293d61d0b3 8038657: javax.swing.BufferStrategyPaintManager has unused imports Reviewed-by: pchelko, malenkov ! src/share/classes/javax/swing/BufferStrategyPaintManager.java Changeset: 1e44b6d7dec5 Author: serb Date: 2014-04-01 01:03 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1e44b6d7dec5 8035736: [parfait] JNI primitive type mismatch in jdk/src/windows/native/sun/windows/awt_Component.cpp Reviewed-by: pchelko, anthony ! src/windows/native/sun/windows/awt.h ! src/windows/native/sun/windows/awt_Component.cpp Changeset: b0ff34b54008 Author: serb Date: 2014-04-01 01:59 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b0ff34b54008 8035624: [parfait] JNI exception pending, JNI primitive type mismatch in jdk/src/windows/native/sun/windows/ThemeReader.cpp Reviewed-by: pchelko, anthony ! src/windows/native/sun/windows/ThemeReader.cpp Changeset: 92601a5f04b6 Author: alexsch Date: 2014-04-01 13:56 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/92601a5f04b6 8030052: Remove reflection from JOptionPane Reviewed-by: serb, pchelko ! src/share/classes/java/awt/Container.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/sun/awt/AWTAccessor.java Changeset: 4e0d9cfcde1b Author: alexsch Date: 2014-04-01 16:46 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4e0d9cfcde1b 7052708: Grammar error in EditorKit documentation Reviewed-by: serb, pchelko ! src/share/classes/javax/swing/text/EditorKit.java Changeset: dc74b3d65622 Author: prr Date: 2014-04-01 11:53 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/dc74b3d65622 Merge - src/bsd/doc/man/ja/kinit.1 - src/bsd/doc/man/ja/klist.1 - src/bsd/doc/man/ja/ktab.1 - src/share/classes/sun/misc/REException.java - src/share/classes/sun/misc/Regexp.java - src/share/classes/sun/misc/RegexpPool.java - src/share/classes/sun/misc/RegexpTarget.java Changeset: ebb3e01cace5 Author: prr Date: 2014-04-01 12:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ebb3e01cace5 8035623: [parfait] JNI warnings in jdk/src/windows/native/sun/windows/awt_Font.cpp Reviewed-by: serb, pchelko ! src/windows/native/sun/windows/awt_Font.cpp Changeset: f6ca21925713 Author: serb Date: 2014-04-02 15:23 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f6ca21925713 8029196: Focus border of JButton.buttonType=roundRect is cut off Reviewed-by: pchelko, alexsch ! src/macosx/classes/apple/laf/JRSUIConstants.java ! src/macosx/classes/com/apple/laf/AquaButtonExtendedTypes.java ! src/macosx/classes/com/apple/laf/AquaPainter.java ! src/macosx/native/com/apple/laf/JRSUIController.m Changeset: aae3193ac2df Author: pchelko Date: 2014-04-02 16:14 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/aae3193ac2df 8037560: [macosx] Cleanup CClipboard.m Reviewed-by: anthony, serb - src/macosx/native/sun/awt/CClipboard.h ! src/macosx/native/sun/awt/CClipboard.m Changeset: 22ee41633622 Author: pchelko Date: 2014-04-02 17:37 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/22ee41633622 6463901: Either generify or deprecate sun.awt.EventListenerAggregate Reviewed-by: anthony, serb ! src/share/classes/java/awt/datatransfer/Clipboard.java - src/share/classes/sun/awt/EventListenerAggregate.java ! src/share/classes/sun/awt/datatransfer/SunClipboard.java Changeset: f05f59cf3e93 Author: alexsch Date: 2014-04-02 18:34 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f05f59cf3e93 6612752: Incorrect getOpenIcon() instanceof in the DefaultTreeCellRenderer Reviewed-by: serb, pchelko ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java Changeset: e83692abf6ab Author: bae Date: 2014-04-03 11:19 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e83692abf6ab 8019990: IM candidate window appears on the South-East corner of the display. Reviewed-by: bagiras, serb ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Frame.cpp ! test/java/awt/Frame/7024749/bug7024749.java Changeset: 13900e0ef37b Author: pchelko Date: 2014-04-03 13:02 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/13900e0ef37b 8038999: In Java 8 java.awt.datatransfer.DataFlavor.equals is no longer symmetric Reviewed-by: anthony, serb ! src/share/classes/java/awt/datatransfer/DataFlavor.java + test/java/awt/datatransfer/DataFlavor/EqualsHashCodeSymmetryTest/EqualsHashCodeSymmetryTest.java Changeset: bf775ab86401 Author: malenkov Date: 2014-04-04 20:12 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bf775ab86401 8038962: KSS: javax.swing.text.html[.parser].ResourceLoader Reviewed-by: alexsch, serb ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java - src/share/classes/javax/swing/text/html/ResourceLoader.java ! src/share/classes/javax/swing/text/html/parser/ParserDelegator.java - src/share/classes/javax/swing/text/html/parser/ResourceLoader.java ! src/share/classes/javax/swing/text/rtf/RTFReader.java Changeset: 89c029b981d3 Author: malenkov Date: 2014-04-04 20:18 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/89c029b981d3 8039137: KSS: JTextComponent.isProcessInputMethodEventOverridden Reviewed-by: alexsch, serb ! src/share/classes/com/sun/beans/util/Cache.java ! src/share/classes/javax/swing/text/JTextComponent.java + test/java/beans/Introspector/TestCacheRecursion.java Changeset: fe18f0dfc582 Author: bagiras Date: 2014-04-04 20:26 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fe18f0dfc582 8035737: [parfait] JNI exception pending in jdk/src/windows/native/sun/windows/awt_PrintControl.cpp Reviewed-by: serb, pchelko ! src/windows/native/sun/windows/awt_PrintControl.cpp ! src/windows/native/sun/windows/awt_PrintDialog.cpp Changeset: 06fd809d777f Author: prr Date: 2014-04-04 10:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/06fd809d777f 8035569: [parfait] JNI expection pending in jdk/src/windows/native/sun/windows/WPrinterJob.cpp Reviewed-by: serb, jgodinez ! src/windows/native/sun/windows/WPrinterJob.cpp ! src/windows/native/sun/windows/awt_new.cpp Changeset: 41406dbf8160 Author: prr Date: 2014-04-04 10:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/41406dbf8160 Merge ! src/share/classes/javax/swing/JOptionPane.java Changeset: 2232c28d36c2 Author: prr Date: 2014-04-04 11:18 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2232c28d36c2 8031095: [Parfait] warning from jdk/src/solaris/native/sun/awt: memory leak Reviewed-by: bae, jgodinez ! src/solaris/native/sun/awt/awt_Font.c Changeset: 879b5bacec09 Author: serb Date: 2014-04-07 15:34 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/879b5bacec09 8032219: [macosx] Scrollbars looks bad under retina in Motif and Metal L&F Reviewed-by: pchelko, flar ! src/share/classes/com/sun/java/swing/plaf/motif/MotifScrollBarUI.java ! src/share/classes/com/sun/java/swing/plaf/motif/MotifSliderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java ! src/share/classes/javax/swing/plaf/metal/MetalScrollBarUI.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/SwingUtilities/8032219/DrawRect.java Changeset: feff13841b98 Author: alexsch Date: 2014-04-07 18:01 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/feff13841b98 6475394: Spelling mistake in doc for ComponentUI.getBaselineResizeBehaviour Reviewed-by: serb, pchelko ! src/share/classes/javax/swing/plaf/ComponentUI.java Changeset: 82ff53bbc895 Author: azvegint Date: 2014-04-07 17:41 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/82ff53bbc895 8031087: [Parfait] warnings from b121 for jdk/src/solaris/native/sun/xawt Reviewed-by: anthony, pchelko, serb ! src/solaris/native/sun/awt/awt_util.c ! src/solaris/native/sun/awt/awt_util.h ! src/solaris/native/sun/xawt/XToolkit.c ! src/solaris/native/sun/xawt/XWindow.c ! src/solaris/native/sun/xawt/XlibWrapper.c ! src/solaris/native/sun/xawt/awt_Desktop.c Changeset: de1b74b33be2 Author: azvegint Date: 2014-04-07 17:43 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/de1b74b33be2 6788138: leak in Java_sun_awt_X11_XlibWrapper_getStringBytes? Reviewed-by: pchelko, serb ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: c2fab0bedaac Author: azvegint Date: 2014-04-07 17:45 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c2fab0bedaac 8030100: java.awt.Desktop: Enable check for supported URI schemes on Linux Reviewed-by: anthony, pchelko, serb ! src/solaris/native/sun/awt/gtk2_interface.c Changeset: d8fd8c0c5ef8 Author: pchelko Date: 2014-04-08 14:02 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d8fd8c0c5ef8 6690000: Typo's in DataFlavor Javadoc Reviewed-by: serb, azvegint ! src/share/classes/java/awt/datatransfer/DataFlavor.java Changeset: b1b7cc164a69 Author: serb Date: 2014-04-09 14:38 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b1b7cc164a69 8038765: [macosx] Toolkit.sync should be implemented Reviewed-by: pchelko, anthony ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m Changeset: b35c7f58d9a1 Author: pchelko Date: 2014-04-09 15:20 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b35c7f58d9a1 8039083: REGRESSION: closed/java/awt/dnd/DragSourceListenerSerializationTest/DragSourceListenerSerializationTest.html fails with NPE since 8u20 b07 on Linux Reviewed-by: serb, azvegint ! src/share/classes/java/awt/dnd/DragSourceContext.java + test/java/awt/dnd/DragSourceListenerSerializationTest/DragSourceListenerSerializationTest.java Changeset: 0d65f6942ae9 Author: yan Date: 2014-04-09 17:30 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0d65f6942ae9 8038631: Create wrapper for awt.Robot with additional functionality Reviewed-by: pchelko, alexsch Contributed-by: Dmitriy Ermashov + test/lib/testlibrary/ExtendedRobot.java Changeset: 1f6e9333a960 Author: pchelko Date: 2014-04-09 18:20 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1f6e9333a960 8039752: Regression: Clipboard couldn't be used on linux Reviewed-by: anthony, serb, azvegint ! src/share/classes/java/awt/datatransfer/Clipboard.java Changeset: b1994e5c11ad Author: pchelko Date: 2014-04-10 11:56 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b1994e5c11ad 8035734: [parfait] JNI exception pending in jdk/src/windows/native/sun/windows/awt_Choice.cpp Reviewed-by: anthony, serb ! src/windows/native/sun/windows/awt_Choice.cpp Changeset: 5d22ffb8b826 Author: pchelko Date: 2014-04-10 11:57 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5d22ffb8b826 8035739: [parfait] JNI exception pending and primitive type mismatch in jdk/src/windows/native/sun/windows/awt_List.cpp Reviewed-by: serb, azvegint ! src/windows/native/sun/windows/awt_List.cpp Changeset: 4ebe24f57e52 Author: alexsch Date: 2014-04-10 13:22 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4ebe24f57e52 8038113: [macosx] JTree icon is not rendered in high resolution on Retina Reviewed-by: serb, pchelko ! src/macosx/classes/com/apple/laf/AquaIcon.java ! src/macosx/classes/com/apple/laf/AquaInternalFrameUI.java + test/javax/swing/JTree/8038113/bug8038113.html + test/javax/swing/JTree/8038113/bug8038113.java Changeset: 752d53546d81 Author: malenkov Date: 2014-04-10 22:26 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/752d53546d81 8039750: KSS: Replace MetalLazyValue with lambda Reviewed-by: alexsch, serb ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! test/javax/swing/JTable/8031971/bug8031971.java + test/javax/swing/plaf/metal/MetalLookAndFeel/Test8039750.java Changeset: fec418e9db54 Author: malenkov Date: 2014-04-10 22:30 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fec418e9db54 8039776: Introspector throws NullPointerException for subclasses' mismatched get/setter Reviewed-by: alexsch, serb ! src/share/classes/java/beans/Introspector.java + test/java/beans/Introspector/Test8039776.java Changeset: f6f2f6588851 Author: serb Date: 2014-04-11 16:18 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f6f2f6588851 8039418: [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical Reviewed-by: bae, prr ! src/share/native/sun/java2d/loops/TransformHelper.c Changeset: 4dc800f5c546 Author: serb Date: 2014-04-11 17:28 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4dc800f5c546 8039774: [OGL] Image painting is broken if 'sun.java2d.accthreshold' is set to 0 Reviewed-by: bae, flar ! src/share/classes/sun/java2d/pipe/DrawImage.java + test/sun/java2d/DrawCachedImageAndTransform.java Changeset: 872d3e03bbb5 Author: darcy Date: 2014-04-11 11:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/872d3e03bbb5 8039863: Fix fallthrough lint warnings in sound Reviewed-by: kalli ! src/share/classes/com/sun/media/sound/SoftEnvelopeGenerator.java Changeset: f3fe1074dcdf Author: bagiras Date: 2014-04-14 21:24 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f3fe1074dcdf 8035866: [parfait] JNI exception pending in jdk/src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp Reviewed-by: serb, pchelko ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp Changeset: 5f96ab8e69f8 Author: prr Date: 2014-04-14 12:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5f96ab8e69f8 Merge - src/share/classes/com/oracle/net/Sdp.java - src/share/classes/java/net/SdpSocketImpl.java - test/com/oracle/net/Sanity.java - test/com/oracle/net/sanity.sh Changeset: a8ef9ee4b5f3 Author: ngthomas Date: 2014-04-15 22:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a8ef9ee4b5f3 Merge ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java - src/macosx/lib/content-types.properties ! src/macosx/native/sun/awt/LWCToolkit.m ! src/share/classes/sun/awt/datatransfer/SunClipboard.java - src/share/demo/nio/zipfs/Demo.java - src/share/demo/nio/zipfs/README.txt - src/share/demo/nio/zipfs/src/META-INF/services/java.nio.file.spi.FileSystemProvider - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/JarFileSystemProvider.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipCoder.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipConstants.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipDirectoryStream.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileAttributeView.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileAttributes.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileStore.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipInfo.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipUtils.java - src/solaris/lib/content-types.properties - src/windows/lib/content-types.properties - test/demo/zipfs/Basic.java - test/demo/zipfs/PathOps.java - test/demo/zipfs/ZFSTests.java - test/demo/zipfs/ZipFSTester.java - test/demo/zipfs/basic.sh Changeset: 44b5e71b143f Author: dmarkov Date: 2014-04-16 12:51 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/44b5e71b143f 8032874: ArrayIndexOutOfBoundsException in JTable while clearing data in JTable Reviewed-by: alexp, alexsch ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/8032874/bug8032874.java Changeset: 6e94fbb84c5e Author: bagiras Date: 2014-04-16 16:55 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6e94fbb84c5e 8035625: [parfait] JNI exception pending in jdk/src/windows/native/sun/windows/awt_MenuItem.cpp Reviewed-by: serb, pchelko ! src/windows/native/sun/windows/awt_MenuItem.cpp Changeset: 1f09d4dcedbc Author: bagiras Date: 2014-04-16 17:01 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1f09d4dcedbc 8035745: [parfait] JNI exception pending in src/windows/native/sun/windows/awt_InputMethod.cpp Reviewed-by: serb, pchelko ! src/windows/native/sun/windows/awt_InputMethod.cpp Changeset: 9ab949f4c867 Author: asaha Date: 2014-04-15 15:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9ab949f4c867 8036983: JAB:Multiselection Ctrl+CursorUp/Down and ActivateDescenderPropertyChanged event Reviewed-by: pchelko, alexsch Contributed-by: vivi.an at oracle.com ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/JTree.java Changeset: 886f6d4cde9e Author: asaha Date: 2014-04-16 10:53 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/886f6d4cde9e Merge - src/macosx/lib/content-types.properties ! src/share/classes/javax/swing/JTable.java - src/share/demo/nio/zipfs/Demo.java - src/share/demo/nio/zipfs/README.txt - src/share/demo/nio/zipfs/src/META-INF/services/java.nio.file.spi.FileSystemProvider - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/JarFileSystemProvider.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipCoder.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipConstants.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipDirectoryStream.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileAttributeView.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileAttributes.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileStore.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipInfo.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java - src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipUtils.java - src/solaris/lib/content-types.properties - src/windows/lib/content-types.properties - test/demo/zipfs/Basic.java - test/demo/zipfs/PathOps.java - test/demo/zipfs/ZFSTests.java - test/demo/zipfs/ZipFSTester.java - test/demo/zipfs/basic.sh Changeset: 367ba237687a Author: ngthomas Date: 2014-04-16 12:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/367ba237687a Merge Changeset: a673ffda4f64 Author: pchelko Date: 2014-04-17 16:26 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a673ffda4f64 8039926: -spash: can't be combined with -xStartOnFirstThread since JDK 7 Reviewed-by: anthony, azvegint ! src/macosx/native/sun/awt/splashscreen/splashscreen_sys.m Changeset: 095dac8cf52c Author: darcy Date: 2014-04-17 09:45 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/095dac8cf52c 8039861: Fix fallthrough lint warnings in awt Reviewed-by: pchelko ! src/share/classes/java/awt/dnd/DragSourceContext.java ! src/share/classes/sun/awt/image/GifImageDecoder.java ! src/share/classes/sun/awt/image/PixelConverter.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XWM.java Changeset: 75b062617601 Author: ngthomas Date: 2014-04-29 09:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/75b062617601 Merge Changeset: 6ff36c51c2bc Author: ngthomas Date: 2014-04-29 11:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6ff36c51c2bc Merge Changeset: 7ca64573d521 Author: xuelei Date: 2014-04-29 23:20 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7ca64573d521 8042178: A comment need to go in RSAClientKeyExchange.java Reviewed-by: mullan ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java Changeset: 830cc367f41b Author: jbachorik Date: 2014-04-30 11:28 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/830cc367f41b 8042123: Support default and static interface methods in JDI, JDWP and JDB Reviewed-by: sla, sspitsyn ! make/data/jdwp/jdwp.spec + src/share/back/InterfaceTypeImpl.c + src/share/back/InterfaceTypeImpl.h ! src/share/back/VirtualMachineImpl.c ! src/share/back/debugDispatch.c ! src/share/back/util.c ! src/share/classes/com/sun/jdi/ClassType.java ! src/share/classes/com/sun/jdi/InterfaceType.java ! src/share/classes/com/sun/jdi/Method.java ! src/share/classes/com/sun/jdi/ObjectReference.java ! src/share/classes/com/sun/tools/example/debug/expr/LValue.java ! src/share/classes/com/sun/tools/jdi/ClassTypeImpl.java ! src/share/classes/com/sun/tools/jdi/InterfaceTypeImpl.java + src/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java ! src/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java + test/com/sun/jdi/EvalInterfaceStatic.sh + test/com/sun/jdi/InterfaceMethodsTest.java Changeset: 045ed4e4d8bc Author: yan Date: 2014-04-30 15:02 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/045ed4e4d8bc 8029451: Tidy warnings cleanup for java.util package; minor changes in java.nio, java.sql Reviewed-by: lancea Contributed-by: Alexander Stepanov ! src/share/classes/java/nio/package.html ! src/share/classes/java/sql/package.html ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/Properties.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java ! src/share/classes/java/util/jar/Pack200.java ! src/share/classes/java/util/jar/package.html ! src/share/classes/java/util/logging/ConsoleHandler.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/Formatter.java ! src/share/classes/java/util/logging/Handler.java ! src/share/classes/java/util/logging/Level.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/StreamHandler.java ! src/share/classes/java/util/logging/package.html ! src/share/classes/java/util/prefs/PreferenceChangeListener.java ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/java/util/zip/package.html Changeset: ee5dc744fd7a Author: yan Date: 2014-04-30 15:13 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ee5dc744fd7a 8039488: Tidy warnings cleanup for javax.sql Reviewed-by: lancea Contributed-by: Alexander Stepanov ! src/share/classes/javax/sql/PooledConnection.java ! src/share/classes/javax/sql/StatementEvent.java ! src/share/classes/javax/sql/StatementEventListener.java ! src/share/classes/javax/sql/package.html ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/CachedRowSet.java ! src/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/share/classes/javax/sql/rowset/package.html ! src/share/classes/javax/sql/rowset/serial/SQLInputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/share/classes/javax/sql/rowset/spi/package.html Changeset: ad8d6a1dac3e Author: erikj Date: 2014-04-30 14:46 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ad8d6a1dac3e 8042208: Build fails on Solaris using devkit when X isn't installed Reviewed-by: tbell ! make/lib/Awt2dLibraries.gmk Changeset: 9ea90ce2b8d9 Author: alanb Date: 2014-04-30 14:27 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9ea90ce2b8d9 8041772: (ch) PendingFuture.CANCELLED has backtrace that potentially keeps objects alive Reviewed-by: chegar ! src/share/classes/sun/nio/ch/PendingFuture.java Changeset: 9c7285a47776 Author: katleman Date: 2014-05-01 12:51 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9c7285a47776 Added tag jdk9-b11 for changeset 47feccd164b7 ! .hgtags Changeset: 83d9bc20973d Author: lana Date: 2014-05-01 14:21 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/83d9bc20973d Merge - src/macosx/native/sun/awt/CClipboard.h - src/share/classes/javax/swing/text/html/ResourceLoader.java - src/share/classes/javax/swing/text/html/parser/ResourceLoader.java - src/share/classes/sun/awt/EventListenerAggregate.java Changeset: 32ef8cd730ec Author: sjiang Date: 2014-05-02 14:40 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/32ef8cd730ec 8031036: com/sun/management/OperatingSystemMXBean/GetCommittedVirtualMemorySize.java failed on 8b121 Reviewed-by: dfuchs ! test/javax/management/monitor/CounterMonitorDeadlockTest.java Changeset: d7640cee30d8 Author: mullan Date: 2014-05-02 10:01 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d7640cee30d8 8038349: Signing XML with DSA throws Exception when key is larger than 1024 bits Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/JCEMapper.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/SignatureAlgorithm.java ! src/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/SignatureDSA.java ! src/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignature.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/JavaUtils.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java ! test/javax/xml/crypto/dsig/GenerationTests.java ! test/javax/xml/crypto/dsig/KeySelectors.java Changeset: 94776e898d0e Author: mullan Date: 2014-05-02 10:05 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/94776e898d0e Merge - src/macosx/native/sun/awt/CClipboard.h - src/share/classes/javax/swing/text/html/ResourceLoader.java - src/share/classes/javax/swing/text/html/parser/ResourceLoader.java - src/share/classes/sun/awt/EventListenerAggregate.java Changeset: 15b5ea29bab8 Author: bpb Date: 2014-05-02 11:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/15b5ea29bab8 8032016: Optimizations of Math.next{After,Up}({float,double}) Summary: Rearrange code to handle the more common and costly case first. Reviewed-by: darcy Contributed-by: Jeff Hain ! src/share/classes/java/lang/Math.java Changeset: 0619a50c0e2b Author: ksrini Date: 2014-05-03 17:23 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0619a50c0e2b 8035782: sun/launcher/LauncherHelper$FXHelper loaded unnecessarily Reviewed-by: ddehaven, kcr, ksrini, mchung Contributed-by: neil.toda at oracle.com ! src/share/classes/sun/launcher/LauncherHelper.java ! test/tools/launcher/FXLauncherTest.java Changeset: c9e91d933770 Author: mduigou Date: 2014-05-05 09:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c9e91d933770 8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour Reviewed-by: mduigou, martin, psandoz Contributed-by: sandhya.viswanathan at intel.com, mike.duigou at oracle.com ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/Vector.java Changeset: f3905a67a72c Author: scolebourne Date: 2014-03-06 16:51 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f3905a67a72c 8034906: Fix typos, errors and Javadoc differences in java.time Reviewed-by: psandoz ! src/share/classes/java/time/DayOfWeek.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/Month.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDate.java ! src/share/classes/java/time/chrono/ChronoLocalDateImpl.java ! src/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/Era.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/format/DateTimeFormatter.java ! src/share/classes/java/time/format/DateTimeFormatterBuilder.java ! src/share/classes/java/time/format/DecimalStyle.java ! src/share/classes/java/time/temporal/IsoFields.java ! src/share/classes/java/time/temporal/Temporal.java ! src/share/classes/java/time/temporal/TemporalAccessor.java ! src/share/classes/java/time/temporal/TemporalField.java ! src/share/classes/java/time/temporal/TemporalUnit.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java Changeset: 57c7860afddb Author: wmdietl Date: 2014-05-05 14:40 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/57c7860afddb Automated merge with http://hg.openjdk.java.net/jdk9/dev/jdk ! .hgtags ! src/macosx/native/sun/awt/splashscreen/splashscreen_sys.m ! src/macosx/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c ! src/share/back/util.c ! src/share/classes/java/awt/datatransfer/Clipboard.java ! src/share/classes/java/awt/datatransfer/DataFlavor.java ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/util/logging/ConsoleHandler.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/StreamHandler.java ! src/share/classes/javax/swing/JOptionPane.java ! src/share/classes/javax/swing/JTable.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/rtf/RTFReader.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java ! src/solaris/native/sun/awt/awt_LoadLibrary.c ! src/solaris/native/sun/awt/fontpath.c ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h From wdietl at gmail.com Mon May 5 18:54:10 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 18:54:10 +0000 Subject: hg: type-annotations/type-annotations/langtools: 15 new changesets Message-ID: <201405051854.s45IsWtx014869@aojmv0008> Changeset: 5828c0ddbb04 Author: jjg Date: 2014-04-25 13:08 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/5828c0ddbb04 8040904: Ensure javadoc tests do not overwrite results within tests Reviewed-by: ksrini ! test/com/sun/javadoc/lib/JavadocTester.java ! test/com/sun/javadoc/testDocFileDir/TestDocFileDir.java ! test/com/sun/javadoc/testGeneratedBy/TestGeneratedBy.java ! test/com/sun/javadoc/testGroupOption/TestGroupOption.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java ! test/com/sun/javadoc/testHtmlTag/TestHtmlTag.java ! test/com/sun/javadoc/testLinkOption/TestLinkOption.java ! test/com/sun/javadoc/testNotifications/TestNotifications.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java Changeset: 7c1bfb902276 Author: pgovereau Date: 2014-04-25 22:00 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/7c1bfb902276 8039026: Definitely unassigned field can be accessed Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/DefiniteAssignment/T8039026.java + test/tools/javac/DefiniteAssignment/T8039026.out Changeset: 4d0d7a33730d Author: vromero Date: 2014-04-28 14:48 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/4d0d7a33730d 8029102: Enhance compiler warnings for Lambda Reviewed-by: briangoetz, jjg, jlahoda, ahgross ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/T8029102/WarnSerializableLambdaTest.java + test/tools/javac/T8029102/WarnSerializableLambdaTest.out + test/tools/javac/T8029102/WarnSerializableLambdaTestb.java + test/tools/javac/T8029102/WarnSerializableLambdaTestb.out + test/tools/javac/diags/examples/WarnSerializableLambda.java Changeset: a89f10b5dd01 Author: ksrini Date: 2014-04-18 08:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/a89f10b5dd01 8039410: [javadoc] fix class-use items to be deterministic and index ordering Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java + test/com/sun/javadoc/testOrdering/C.java + test/com/sun/javadoc/testOrdering/TestOrdering.java + test/com/sun/javadoc/testOrdering/UsedInC.java + test/com/sun/javadoc/testOrdering/pkg1/C1.java + test/com/sun/javadoc/testOrdering/pkg1/C2.java + test/com/sun/javadoc/testOrdering/pkg1/C3.java + test/com/sun/javadoc/testOrdering/pkg1/C4.java + test/com/sun/javadoc/testOrdering/pkg1/UsedClass.java + test/com/sun/javadoc/testOrdering/pkg1/ZZTop.java Changeset: d002fb1287ec Author: ksrini Date: 2014-04-18 08:44 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/d002fb1287ec 8038583: [javadoc] Refactor uses of arrays to Collections Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfileSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java Changeset: e6e9f1b096c8 Author: pgovereau Date: 2014-04-21 17:57 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e6e9f1b096c8 8030046: javac incorrectly handles absolute paths in manifest classpath Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/file/FSInfo.java + test/tools/javac/Paths/AbsolutePathTest.java ! test/tools/javac/lib/ToolBox.java Changeset: af0eb050cfba Author: anazarov Date: 2014-04-30 13:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/af0eb050cfba 8040097: Implement classfile tests for LocalVariableTable and LocalVariableTypeTable attribute. Reviewed-by: jjg, shurailine, emc + test/tools/javac/classfiles/attributes/LocalVariableTable/LocalVariableTableTest.java + test/tools/javac/classfiles/attributes/LocalVariableTable/LocalVariableTestBase.java + test/tools/javac/classfiles/attributes/LocalVariableTable/LocalVariableTypeTableTest.java + test/tools/javac/classfiles/attributes/lib/TestBase.java + test/tools/javac/lib/InMemoryFileManager.java ! test/tools/javac/lib/ToolBox.java Changeset: c2200da8ec5b Author: rfield Date: 2014-04-30 18:19 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/c2200da8ec5b 8036942: javac generates incorrect exception table for multi-catch statements inside a lambda Summary: Union type info lost and also union type is not processed by TreeMaker.Type -- address by using existing tree, thus by-passing such issues. Reviewed-by: vromero, jlahoda ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaMultiCatchTest.java Changeset: 689266bbcd6a Author: rfield Date: 2014-04-30 23:02 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/689266bbcd6a 8029852: Bad code generated (VerifyError) when lambda instantiates enclosing local class and has captured variables 8029725: Lambda reference to containing local class causes javac infinite recursion Reviewed-by: vromero, jlahoda, dlsmith ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/tools/javac/lambda/LambdaLocalTest.java + test/tools/javac/lambda/LambdaOuterLocalTest.java + test/tools/javac/lambda/SingleLocalTest.java Changeset: c062c8dc1e4a Author: vromero Date: 2014-05-01 20:36 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/c062c8dc1e4a 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800 Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/inference/EagerReturnTypeResolution/EagerReturnTypeResolutionTesta.java + test/tools/javac/inference/EagerReturnTypeResolution/EagerReturnTypeResolutionTestb.java + test/tools/javac/inference/EagerReturnTypeResolution/EagerReturnTypeResolutionTestb.out + test/tools/javac/inference/EagerReturnTypeResolution/PrimitiveTypeBoxingTest.java + test/tools/javac/inference/EagerReturnTypeResolution/PrimitiveTypeBoxingTest.out Changeset: 55e92b74c283 Author: katleman Date: 2014-05-01 12:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/55e92b74c283 Added tag jdk9-b11 for changeset f04fccfbd880 ! .hgtags Changeset: 72efbe612e49 Author: lana Date: 2014-05-01 14:21 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/72efbe612e49 Merge Changeset: 9cfffe95a5fc Author: pgovereau Date: 2014-05-02 22:35 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/9cfffe95a5fc 8033437: javac, inconsistent generic types behaviour when compiling together vs. separate Reviewed-by: jjg Contributed-by: vicente.romero at oracle.com, paul.govereau at oracle.com ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/wildcards/RefQueue.java + test/tools/javac/generics/wildcards/RefQueueBug.java Changeset: 5fbdcc2e3a75 Author: jjg Date: 2014-05-02 16:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/5fbdcc2e3a75 8042358: some tests have placeholder bugid 1234567 Reviewed-by: mduigou ! test/tools/javac/annotations/typeAnnotations/failures/CantAnnotatePackages.java ! test/tools/javac/annotations/typeAnnotations/failures/TypeVariableMissingTA.java ! test/tools/javac/annotations/typeAnnotations/failures/common/arrays/DeclarationAnnotation.java ! test/tools/javac/annotations/typeAnnotations/failures/common/receiver/DeclarationAnnotation.java ! test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.java ! test/tools/javac/annotations/typeAnnotations/newlocations/AnonymousClass.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Initializers.java ! test/tools/javac/processing/model/type/BasicAnnoTests.java Changeset: 345c88905b2c Author: wmdietl Date: 2014-05-05 14:53 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/345c88905b2c Automated merge with http://hg.openjdk.java.net/jdk9/dev/langtools ! .hgtags ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! test/tools/javac/annotations/typeAnnotations/failures/common/wildcards/DeclarationAnnotation.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Initializers.java ! test/tools/javac/processing/model/type/BasicAnnoTests.java From wdietl at gmail.com Mon May 5 19:26:59 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 05 May 2014 19:26:59 +0000 Subject: hg: type-annotations/type-annotations/langtools: Make field exception_index public, to allow easier access from jdk8 and jdk9. Message-ID: <201405051927.s45JR1Jk019668@aojmv0008> Changeset: 5d24ce9712eb Author: wmdietl Date: 2014-05-05 15:26 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/5d24ce9712eb Make field exception_index public, to allow easier access from jdk8 and jdk9. ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java From alex.buckley at oracle.com Mon May 5 22:58:13 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 05 May 2014 15:58:13 -0700 Subject: Future of 'type-annotations/type-annotations' forest Message-ID: <53681785.5040203@oracle.com> Werner, all, Due to bug fixing and other cleanup for JDK 8u20 and JDK 9 [1], Oracle engineers have been working on patches to the implementation of type annotations [2][3][4]. The patches will be sent for review on compiler-dev soon. Once they go into the jdk8u/jdk8u forest or jdk9/dev forest, the type-annotations/type-annotations forest will be significantly out of date and should no longer be used for new contributions. As I indicated in January: -- From now on, bug fixes to javac's handling of type annotations should be sent as patches to the compiler-dev list, just like fixes to any other area of javac. Depending on the nature of the bug in JBS, the patch would target either the repositories of the JDK 8 Updates Project or the repositories of the JDK 9 Project. -- I looked at the type-annotation-dev archives and identified four threads that discuss changes in the type-annotations/type-annotations forest but which is intended for the jdk8u/jdk8u or jdk9/dev forests: - type-annotations based on JDK 9? (Jan 2014) - Webrev for making parts of TypeAnnotationPosition immutable (Feb 2014) - Invalid reordering in ClassReader (Feb 2014) - Changes in type-annotations repository (Mar 2014) It will not be straightforward to port these changes into jdk8u/jdk8u or jdk9/dev after the patches I mentioned at the start of this mail have been applied. Werner, I think it would be best if you mailed compiler-dev with a summary of your changes as soon as possible. Then, if they are still applicable, individual patches can be discussed and sponsored into the appropriate jdk* forest. Alex [1] https://bugs.openjdk.java.net/browse/JDK-8027181 [2] https://bugs.openjdk.java.net/browse/JDK-8040327 [3] https://bugs.openjdk.java.net/browse/JDK-8027262 [4] https://bugs.openjdk.java.net/browse/JDK-8027188 From eric.mccorkle at oracle.com Wed May 7 23:08:03 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Wed, 07 May 2014 19:08:03 -0400 Subject: Public review for 8040327: Eliminate AnnotatedType Message-ID: <536ABCD3.5070109@oracle.com> Hello, This is the first of a series of patches which implement a significant overhaul of type annotations code in the javac frontend. This patch eliminates the AnnotatedType class, replacing its functionality by storing annotations on the Type class itself. This will eventually be rolled into a more general type metadata framework that has been planned as part of ongoing work. Note that this patch is also being reviewed by the langtools team using the Crucible tool. The webrev can be found here: http://cr.openjdk.java.net/~emc/8040327/ The following patches are also under initial review, and will be posted soon: 1) A patch which replaces much of the functionality in TypeAnnotations.java with code integrated directly into the MemberEnter and Attr phases. The end result is that Attribute.TypeCompound objects will now contain the correct position from the moment they are created, and the position field will be final. This patch is known colloquially as the "positions patch", though its scope has grown considerably beyond that. 2) A follow-up patch which removes code dead code that was replaced by the positions patch, and removes some code duplication that was introduced by that patch. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available URL: From wdietl at gmail.com Thu May 8 03:18:19 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 08 May 2014 03:18:19 +0000 Subject: hg: type-annotations/type-annotations: 3 new changesets Message-ID: <201405080318.s483IJaG029822@aojmv0008> Changeset: ccbabea88c1c Author: erikj Date: 2014-05-06 11:43 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/ccbabea88c1c 8042348: Copyright link in Javadoc page for Java SE 8 Reviewed-by: tbell, iris ! make/Javadoc.gmk Changeset: d6f66566d8b3 Author: mduigou Date: 2014-05-06 13:24 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/d6f66566d8b3 8042417: hgforest: allow local clone of extra repos Reviewed-by: chegar, erikj ! common/bin/hgforest.sh Changeset: 02865a5ce591 Author: wmdietl Date: 2014-05-07 23:18 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/02865a5ce591 Automated merge with http://hg.openjdk.java.net/jdk9/dev/ From wdietl at gmail.com Thu May 8 03:19:33 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 08 May 2014 03:19:33 +0000 Subject: hg: type-annotations/type-annotations/langtools: 7 new changesets Message-ID: <201405080319.s483Jkjj029995@aojmv0008> Changeset: 54a460e0ac76 Author: dlsmith Date: 2014-05-06 15:46 -0600 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/54a460e0ac76 8033718: Inference ignores capture variable as upper bound Summary: Split Types.lowerBound into two methods; fix bugs in inference handling of capture variables. Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/inference/7086586/T7086586.out ! test/tools/javac/generics/inference/7086586/T7086586b.java + test/tools/javac/generics/inference/LowerBoundGLB.java Changeset: 5df0952dff0e Author: anazarov Date: 2014-05-07 14:22 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/5df0952dff0e 8040129: Implement classfile tests for SourceFile attribute. Reviewed-by: shurailine, jjg + test/tools/javac/classfiles/attributes/SourceFile/AnonymousClassTest.java + test/tools/javac/classfiles/attributes/SourceFile/InnerClassTest.java + test/tools/javac/classfiles/attributes/SourceFile/LocalClassTest.java + test/tools/javac/classfiles/attributes/SourceFile/MixTest.java + test/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java + test/tools/javac/classfiles/attributes/SourceFile/SourceFileTestBase.java + test/tools/javac/classfiles/attributes/SourceFile/SyntheticClassTest.java + test/tools/javac/classfiles/attributes/SourceFile/TopLevelClassesOneFileTest.java Changeset: 08889445d3dc Author: ohrstrom Date: 2014-05-07 23:55 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/08889445d3dc 8042699: sjavac does not track dependencies Summary: Using / in some places and . in other places break package comparisons. The fix standardizes on dots. Reviewed-by: jjg ! src/share/classes/com/sun/tools/sjavac/Source.java ! test/tools/sjavac/SJavac.java ! test/tools/sjavac/SJavacWrapper.java Changeset: aba030ee43b5 Author: ohrstrom Date: 2014-05-08 00:22 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/aba030ee43b5 8042441: sjavac does not track dependencies Summary: Add support for tracking fully qualified references. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + src/share/classes/com/sun/tools/sjavac/comp/AttrWithDeps.java ! src/share/classes/com/sun/tools/sjavac/server/CompilerThread.java ! test/tools/sjavac/SJavac.java ! test/tools/sjavac/SJavacWrapper.java Changeset: 39f1e6271591 Author: ksrini Date: 2014-05-07 15:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/39f1e6271591 8042654: [javadoc] revert the default methods list.sort to Collections.sort Reviewed-by: jfranck, jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java Changeset: baf35a88504b Author: alundblad Date: 2014-05-07 17:29 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/baf35a88504b 8028196: Javac allows timestamps inside rt.jar to affect compilation when using -sourcepath. Summary: Added -XXuserPathsFirst to allow user classes to take precedence over boot classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/options/xprefer/XPreferTest.java Changeset: 4b2344efa243 Author: wmdietl Date: 2014-05-07 23:19 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/4b2344efa243 Automated merge with http://hg.openjdk.java.net/jdk9/dev/langtools ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties From wdietl at gmail.com Thu May 8 03:21:06 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 08 May 2014 03:21:06 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 5 new changesets Message-ID: <201405080321.s483LASi000177@aojmv0008> Changeset: 6321f565a7b1 Author: hannesw Date: 2014-05-06 12:38 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/6321f565a7b1 8041998: RegExp implementation is not thread-safe Reviewed-by: lagergren, sundar, attila ! src/jdk/nashorn/internal/runtime/regexp/JdkRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/JoniRegExp.java ! src/jdk/nashorn/internal/runtime/regexp/joni/Regex.java + test/script/basic/JDK-8041998.js + test/script/basic/JDK-8041998.js.EXPECTED Changeset: d16c80270f7d Author: sundar Date: 2014-05-06 17:54 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d16c80270f7d 8042364: Make __proto__ ES6 draft compliant Reviewed-by: jlaskey, lagergren, attila ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! test/script/basic/JDK-8024120.js ! test/script/basic/JDK-8024174.js + test/script/basic/JDK-8042364.js + test/script/basic/JDK-8042364.js.EXPECTED Changeset: 7217348b5f95 Author: sundar Date: 2014-05-07 14:07 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/7217348b5f95 8041697: CompiledScript slower when eval with binding Reviewed-by: lagergren, attila, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/tools/Shell.java Changeset: 235d22ccfd24 Author: sundar Date: 2014-05-07 20:20 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/235d22ccfd24 8042600: Add more samples in nashorn/samples directory Reviewed-by: jlaskey, hannesw + samples/BufferArray.java + samples/CastExample.java + samples/README + samples/array_mapreduce.js + samples/astviewer.js + samples/barchart_weather.js + samples/call_lambda.js ! samples/counters.js + samples/dirname.js + samples/disassemble.js + samples/engine/README + samples/engine/accessvar.js + samples/engine/callfunc.js + samples/engine/callmethod.js + samples/engine/exposevar.js + samples/engine/foreignobject.js + samples/engine/hello.js + samples/engine/interface.js + samples/engine/interface2.js + samples/engine/lambda_as_func.js + samples/env.js + samples/expression_closure.js + samples/fileline.js + samples/fizzbuzz.js + samples/for_each.js + samples/gaussian_random.js + samples/gaussian_random_bind.js + samples/gutenberg.js + samples/heredoc.js + samples/interface_impl.js + samples/javaastviewer.js + samples/javacastcounter.js + samples/javaimporter.js + samples/javalist.js + samples/javamap.js + samples/javashell.js + samples/jsadapter_dom.js + samples/jsobject.js + samples/jsobject_mapreduce.js + samples/jsonviewer.js ! samples/letter.js + samples/list_mapreduce.js + samples/locales.js + samples/logisticmap.js + samples/options.js + samples/readLine.js + samples/sam_function.js ! samples/shell.js + samples/stack.js ! samples/test.js + samples/uniform_random.js ! samples/uniq.js + samples/uniqs.js + samples/weather.js Changeset: ef976b30edf0 Author: wmdietl Date: 2014-05-07 23:21 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/ef976b30edf0 Automated merge with http://hg.openjdk.java.net/jdk9/dev/nashorn From wdietl at gmail.com Thu May 8 03:23:05 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 08 May 2014 03:23:05 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 12 new changesets Message-ID: <201405080323.s483NJkO000363@aojmv0008> Changeset: dc427574bc7a Author: ctornqvi Date: 2014-04-24 00:46 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/dc427574bc7a 8033405: metaspace/stressHierarchy/stressHierarchy005 hangs in atexit handler Summary: Changeset: 3bbb836bdf90 Author: igerasim Date: 2014-05-06 10:28 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/3bbb836bdf90 8040806: BitSet.toString() can throw IndexOutOfBoundsException Reviewed-by: plevart, mduigou ! src/share/classes/java/util/BitSet.java ! test/java/util/BitSet/BSMethods.java Changeset: 60147ddadf07 Author: psandoz Date: 2014-05-06 10:29 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/60147ddadf07 8042355: stream with sorted() causes downstream ops not to be lazy Reviewed-by: mduigou ! src/share/classes/java/util/stream/SortedOps.java ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/SortedOpTest.java Changeset: 113db8fa2161 Author: miauno Date: 2014-05-06 10:51 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/113db8fa2161 8040748: [TESTBUG] Exclude failing (serviceability) jtreg tests Reviewed-by: sla ! test/ProblemList.txt Changeset: d062f1046081 Author: chegar Date: 2014-05-02 19:38 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d062f1046081 8039470: java.net Content Handler API incorrectly specifies implementation specific location of handler classes Reviewed-by: alanb, michaelm ! src/share/classes/java/net/ContentHandler.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLConnection.java Changeset: 1ae50c4b8800 Author: chegar Date: 2014-05-06 12:20 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1ae50c4b8800 Merge Changeset: e9a7ff92a858 Author: ksrini Date: 2014-05-06 10:32 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e9a7ff92a858 8042266: [launcher] create test groups for launcher regression tests Reviewed-by: alanb, mduigou ! test/TEST.groups Changeset: 9a9d52c44ea8 Author: xuelei Date: 2014-05-07 02:24 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9a9d52c44ea8 8042449: Issue for negative byte major record version Summary: Convert byte to positive integer before making comparison. Also reviewed by Florian Weimer . Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/ByteBufferInputStream.java ! src/share/classes/sun/security/ssl/EngineInputRecord.java ! src/share/classes/sun/security/ssl/InputRecord.java ! src/share/classes/sun/security/ssl/ProtocolVersion.java + test/javax/net/ssl/SSLEngine/IllegalRecordVersion.java Changeset: 99e0f1f9c401 Author: igerasim Date: 2014-05-07 09:43 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/99e0f1f9c401 8011537: (fs) Path.register(..) clears interrupt status of thread with no InterruptedException Reviewed-by: alanb ! src/share/classes/sun/nio/fs/AbstractPoller.java ! test/java/nio/file/WatchService/Basic.java Changeset: 43f769f86f47 Author: igerasim Date: 2014-05-07 16:50 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/43f769f86f47 8042470: (fs) Path.register doesn't throw IllegalArgumentException if multiple OVERFLOW events are specified Reviewed-by: alanb, chegar ! src/share/classes/sun/nio/fs/AbstractPoller.java ! test/java/nio/file/WatchService/Basic.java Changeset: 1811177bdbc6 Author: bpb Date: 2014-05-07 11:45 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1811177bdbc6 8026236: Add PrimeTest for BigInteger Summary: Test primality verification methods in BigInteger Reviewed-by: psandoz Contributed-by: Brian Burkhalter , Peter Levart , Paul Sandoz , Aleksey Shipilev , Florian Weimer + test/java/math/BigInteger/PrimeTest.java Changeset: 2d7287eae0ad Author: peytoia Date: 2014-05-08 08:22 +0900 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2d7287eae0ad 8042360: Subtag syntax check is incomplete in Locale.LanguageRange Reviewed-by: naoto, okutsu ! src/share/classes/java/util/Locale.java ! test/java/util/Locale/Bug7069824.java Changeset: 2745e23dfd4c Author: wmdietl Date: 2014-05-07 23:25 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2745e23dfd4c Automated merge with http://hg.openjdk.java.net/jdk9/dev/jdk From wdietl at gmail.com Thu May 8 04:18:01 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 08 May 2014 04:18:01 +0000 Subject: hg: type-annotations/type-annotations/hotspot: Remove file that was deleted in jdk9, but somehow survived a merge. Message-ID: <201405080418.s484I2m3008555@aojmv0008> Changeset: eb3c819ab3d7 Author: wmdietl Date: 2014-05-08 00:17 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/eb3c819ab3d7 Remove file that was deleted in jdk9, but somehow survived a merge. - make/hotspot_version From wdietl at gmail.com Thu May 8 04:45:02 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 08 May 2014 04:45:02 +0000 Subject: hg: type-annotations/type-annotations/jdk: Fix all unwanted differences against jdk9/jdk. Message-ID: <201405080445.s484j9l5012679@aojmv0008> Changeset: d0e8f3422df6 Author: wmdietl Date: 2014-05-08 00:44 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d0e8f3422df6 Fix all unwanted differences against jdk9/jdk. ! .hgtags - make/gensrc/GensrcJObjC.gmk - make/src/classes/build/tools/classfile/RemoveMethods.java ! src/bsd/doc/man/jarsigner.1 ! src/bsd/doc/man/java.1 ! src/linux/doc/man/jarsigner.1 ! src/linux/doc/man/java.1 ! src/macosx/native/sun/security/krb5/SCDynamicStoreConfig.m - src/share/classes/com/sun/security/auth/callback/DialogCallbackHandler.java - src/share/classes/sun/awt/AWTPermissionFactory.java ! src/share/classes/sun/security/tools/policytool/Resources_de.java ! src/share/classes/sun/security/tools/policytool/Resources_es.java ! src/share/classes/sun/security/tools/policytool/Resources_fr.java ! src/share/classes/sun/security/tools/policytool/Resources_it.java ! src/share/classes/sun/security/tools/policytool/Resources_ja.java ! src/share/classes/sun/security/tools/policytool/Resources_ko.java ! src/share/classes/sun/security/tools/policytool/Resources_pt_BR.java ! src/share/classes/sun/security/tools/policytool/Resources_sv.java ! src/share/classes/sun/security/tools/policytool/Resources_zh_CN.java ! src/share/classes/sun/security/tools/policytool/Resources_zh_TW.java - src/share/classes/sun/swing/SwingLazyValue.java ! src/share/classes/sun/util/resources/pt/LocaleNames_pt.properties ! src/share/classes/sun/util/resources/pt/LocaleNames_pt_PT.properties ! src/solaris/doc/sun/man/man1/jarsigner.1 ! src/solaris/doc/sun/man/man1/java.1 - test/com/sun/security/auth/callback/DialogCallbackHandler/Default.java ! test/java/awt/dnd/URIListToFileListBetweenJVMsTest/InterprocessMessages.java - test/java/lang/ClassLoader/Assert.sh - test/java/lang/management/MemoryMXBean/LowMemoryTestConcMarkSweepGC.sh - test/java/lang/management/MemoryMXBean/LowMemoryTestParallelGC.sh - test/java/lang/management/MemoryMXBean/LowMemoryTestSerialGC.sh - test/java/lang/management/ThreadMXBean/ThreadExecutionSynchronizer.java - test/java/util/logging/Listeners.java - test/java/util/logging/ListenersWithSM.java - test/java/util/logging/java.policy - test/sun/security/krb5/TimeInCCache.java ! test/sun/security/krb5/config/ParseCAPaths.java ! test/sun/text/resources/LocaleData - test/tools/pack200/NoBeans.java - test/tools/pack200/Reflect.java From wdietl at gmail.com Thu May 8 19:54:56 2014 From: wdietl at gmail.com (Werner Dietl) Date: Thu, 8 May 2014 15:54:56 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <53681785.5040203@oracle.com> References: <53681785.5040203@oracle.com> Message-ID: Alex, all, thanks for this update. Type annotations in the jdk9 repo are currently broken for serious use. On Feb 7 I identified the invalid re-ordering performed in ClassReader: http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-February/001592.html This problem still exists in jdk9 - the problematic changeset wasn't rolled back, nor was the fix applied. I have fixed this problem in type-annotations. I was waiting to hear an update on this before pursuing the other outstanding changes. You say that after the new changes type-annotations will be seriously out of date. I don't see why this would be the case. I'm currently keeping type-annotations in sync with jdk9, making sure that the Checker Framework correctly works with type-annotations. Once these further refactorings go into jdk9, they should be easy to pull into type-annotations. I agree with the goal of retiring the type-annotations repositories, but do not see any urgency from these upcoming refactorings. I would rather have a working jdk9 before removing type-annotations. As to the differences between the jdk9 and type-annotations repos: - jdk9, jdk9/corba, jdk9/hotspot, jdk9/jaxp, jdk9/jaxws only differ in the .hgtags file, were we marked when the type-annotations clones split off. - jdk9/jdk differs in .hgtags and contains two typo fixes in - java/lang/reflect/Field.java (whitespace fix about closing bracket) - java/lang/reflect/Modifier.java (spelling error) - jdk9/nashorn doesn't differ at all All the interesting changes are against jdk9/langtools: - com/sun/tools/javac/code/TypeAnnotationPosition.java: I added a "copy" method to make it possible to create an updated TAP. Alternatively, constructors that give a new TAP with a changed location would be possible. A mechanism like this is required to allow the Checker Framework to build TAPs for defaulted locations. One issue I run into is making the Checker Framework work with both JDK 8 and JDK 9 - the APIs for things like TAP changed significantly and I now need to access many things reflectively to correctly access the right API. One simple change I made was to make field "exception_index" public to allow direct access from JDK 8 and JDK 9. As the upcoming changes will require further changes in the Checker Framework, making this change is not necessary. - com/sun/tools/javac/code/TypeAnnotations.java: initializes an Options object that is unused. I removed that code. - com/sun/tools/javac/comp/Check.java: the call to Assert.checkNonNull always constructs a toString of an annotation - this was slow and annoying when debugging some problems. Other uses of Assert also use simple error messages, so I adapted this one. - com/sun/tools/javac/jvm/ClassReader.java: the jdk 9 code incorrectly reads the location of type annotations, which results in a compiler crash. type-annotations fixed this. - com/sun/tools/javac/model/JavacTypes.java: this change improves an exception message. This message is only created when throwing an exception, so the argument I have for the change to "Check" above doesn't apply. - com/sun/tools/javac/parser/Scanner.java: remove an unused import - com/sun/tools/javac/util/RichDiagnosticFormatter.java: fix typo in javadoc - All changes below javax, e.g. javax/annotation/processing/Messager.java and javax/lang/model/element/Element.java, remove unused imports only. - test/tools/javac/annotations/typeAnnotations/classfile/T8008762.java: fixes to whitespace - test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java is being ignored in jdk9, even though it is working. Same for AnnotatedPackage1 and CantAnnotateStaticClass3. - test/tools/javac/annotations/typeAnnotations/referenceinfos/Fields.java and MethodReturns.java contain test cases for old-style arrays after the identifier/method signature. - test/tools/javac/lib/DPrinter.java uses an incorrect method and doesn't work as is; fixed in type-annotations. - test/tools/javac/processing/model/type/BasicAnnoTests.java uses DPrinter and type-annotations makes the test compile - the problem itself is still not fixed, but that is one of the improvements that Eric was working on. Therefore, it would be good to enable this test and see whether all problems are fixed now. How should I go about getting these changes into jdk9/jdk and jdk9/langtools? Is it enough to send the above descriptions to compiler-dev and point interested reviewers to a diff between the two repos? Should I attach a diff? Cheers, cu, WMD. On Mon, May 5, 2014 at 6:58 PM, Alex Buckley wrote: > Werner, all, > > Due to bug fixing and other cleanup for JDK 8u20 and JDK 9 [1], Oracle > engineers have been working on patches to the implementation of type > annotations [2][3][4]. The patches will be sent for review on compiler-dev > soon. Once they go into the jdk8u/jdk8u forest or jdk9/dev forest, the > type-annotations/type-annotations forest will be significantly out of date > and should no longer be used for new contributions. As I indicated in > January: > > -- > From now on, bug fixes to javac's handling of type annotations should be > sent as patches to the compiler-dev list, just like fixes to any other area > of javac. Depending on the nature of the bug in JBS, the patch would target > either the repositories of the JDK 8 Updates Project or the repositories of > the JDK 9 Project. > -- > > I looked at the type-annotation-dev archives and identified four threads > that discuss changes in the type-annotations/type-annotations forest but > which is intended for the jdk8u/jdk8u or jdk9/dev forests: > > - type-annotations based on JDK 9? (Jan 2014) > - Webrev for making parts of TypeAnnotationPosition immutable (Feb 2014) > - Invalid reordering in ClassReader (Feb 2014) > - Changes in type-annotations repository (Mar 2014) > > It will not be straightforward to port these changes into jdk8u/jdk8u or > jdk9/dev after the patches I mentioned at the start of this mail have been > applied. > > Werner, I think it would be best if you mailed compiler-dev with a summary > of your changes as soon as possible. Then, if they are still applicable, > individual patches can be discussed and sponsored into the appropriate jdk* > forest. > > Alex > > [1] https://bugs.openjdk.java.net/browse/JDK-8027181 > [2] https://bugs.openjdk.java.net/browse/JDK-8040327 > [3] https://bugs.openjdk.java.net/browse/JDK-8027262 > [4] https://bugs.openjdk.java.net/browse/JDK-8027188 -- http://www.google.com/profiles/wdietl From wdietl at gmail.com Thu May 8 20:23:11 2014 From: wdietl at gmail.com (Werner Dietl) Date: Thu, 8 May 2014 16:23:11 -0400 Subject: Public review for 8040327: Eliminate AnnotatedType In-Reply-To: <536ABCD3.5070109@oracle.com> References: <536ABCD3.5070109@oracle.com> Message-ID: Hi Eric, I had a quick look and notice: com/sun/tools/javac/code/Printer.java: + List annos = t.getAnnotationMirrors(); + if (!annos.isEmpty()) { + if (prefix) sb.append(' '); + sb.append(t.getAnnotationMirrors()); The last line could use annos instead of calling t.getAnnotationMirrors again. + private void printBrackets(Type t, StringBuilder sb, Locale locale) { Type arrel = t; while (arrel.hasTag(TypeTag.ARRAY)) { - if (arrel.isAnnotated()) { - sb.append(' '); - sb.append(arrel.getAnnotationMirrors()); - sb.append(' '); - } + sb.append(printAnnotations(t, true)); sb.append("[]"); - arrel = arrel.unannotatedType(); arrel = ((ArrayType) arrel).elemtype; } } This change seems wrong. Previously, the type annotations on arrel were printed on each iteration of the loop. Now, each iteration prints the annotations on "t" - the top-level type. The added line should be sb.append(printAnnotation(arrel, true)); @Override public String visitMethodType(MethodType t, Locale locale) { - return "(" + printMethodArgs(t.argtypes, false, locale) + ")" + visit(t.restype, locale); + return printAnnotations(t) + "(" + + printMethodArgs(t.argtypes, false, locale) + ")" + + visit(t.restype, locale); } What is the meaning of type annotations on a MethodType? We have TAs on the return type of a method or constructor, but those are in t.restype. I don't see what annotations a MethodType itself should contain and why they would be separate from restype. Should TAs on the receiver of a method be printed instead (in the right location)? Same comment for MethodType.toString() later in the diff. MethodType.annotatedType correctly raises an error, so I don't see why toString outputs it. I'll wait with adapting the Checker Framework until all three patches are available and can then give more detailed feedback. cu, WMD. On Wed, May 7, 2014 at 7:08 PM, Eric McCorkle wrote: > Hello, > > This is the first of a series of patches which implement a significant > overhaul of type annotations code in the javac frontend. This patch > eliminates the AnnotatedType class, replacing its functionality by > storing annotations on the Type class itself. > > This will eventually be rolled into a more general type metadata > framework that has been planned as part of ongoing work. > > Note that this patch is also being reviewed by the langtools team using > the Crucible tool. > > The webrev can be found here: > http://cr.openjdk.java.net/~emc/8040327/ > > > The following patches are also under initial review, and will be posted > soon: > > 1) A patch which replaces much of the functionality in > TypeAnnotations.java with code integrated directly into the MemberEnter > and Attr phases. The end result is that Attribute.TypeCompound objects > will now contain the correct position from the moment they are created, > and the position field will be final. This patch is known colloquially > as the "positions patch", though its scope has grown considerably beyond > that. > > 2) A follow-up patch which removes code dead code that was replaced by > the positions patch, and removes some code duplication that was > introduced by that patch. -- http://www.google.com/profiles/wdietl From eric.mccorkle at oracle.com Thu May 8 20:57:32 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Thu, 08 May 2014 16:57:32 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: References: <53681785.5040203@oracle.com> Message-ID: <536BEFBC.4080508@oracle.com> On 05/08/14 15:54, Werner Dietl wrote: > Alex, all, > > thanks for this update. > > Type annotations in the jdk9 repo are currently broken for serious > use. On Feb 7 I identified the invalid re-ordering performed in > ClassReader: > > http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-February/001592.html > > This problem still exists in jdk9 - the problematic changeset wasn't > rolled back, nor was the fix applied. I have fixed this problem in > type-annotations. > I was waiting to hear an update on this before pursuing the other > outstanding changes. I am aware of the fix that was pushed into the type annotations forest. As we discussed when you developed the fix, I cannot push it into jdk9-dev as-is, because the development practices of the langtools team require that any changeset that introduces behavioral changes be accompanied by a test. I will take care of the test this time, so that you can run checkers on the contents of jdk9. However, in the future, we ask that patches submitted against jdk9 conform to the langtools group's development practices. > You say that after the new changes type-annotations will be seriously > out of date. I don't see why this would be the case. I'm currently > keeping type-annotations in sync with jdk9, making sure that the > Checker Framework correctly works with type-annotations. Once these > further refactorings go into jdk9, they should be easy to pull into > type-annotations. I am posting a series of three (maybe just two) patches against jdk9, which rearchitect a significant portion of the frontend implementation. The end result is that it may not be trivial to rebase all the changes you list below. > All the interesting changes are against jdk9/langtools: > > - com/sun/tools/javac/code/TypeAnnotationPosition.java: > I added a "copy" method to make it possible to create an updated > TAP. Alternatively, constructors that give a new TAP with a changed > location would be possible. A mechanism like this is required to allow > the Checker Framework to build TAPs for defaulted locations. That sounds fine. Also, it shouldn't be affected by anything I'm doing. > One issue I run into is making the Checker Framework work with both > JDK 8 and JDK 9 - the APIs for things like TAP changed significantly > and I now need to access many things reflectively to correctly access > the right API. One simple change I made was to make field > "exception_index" public to allow direct access from JDK 8 and JDK 9. > As the upcoming changes will require further changes in the Checker > Framework, making this change is not necessary. My changes affect exception_index in nontrivial ways... I am now storing catch-types and class ids, as well as exception indexes in a private field. Exception indexes are accessed via a getter. However, this is a temporary measure. My tentative agenda for 8u40 is to rework the way we do exception parameters and eliminate. > > - com/sun/tools/javac/code/TypeAnnotations.java: initializes an > Options object that is unused. I removed that code. Most if not all of TypeAnnotations.java is going away anyway. I've moved most of the core functionality into Annotate. > - com/sun/tools/javac/comp/Check.java: the call to Assert.checkNonNull > always constructs a toString of an annotation - this was slow and > annoying when debugging some problems. Other uses of Assert also use > simple error messages, so I adapted this one. A good change. We may actually want to file a blanket issue about this as part of langtools code cleanup projects. > - com/sun/tools/javac/jvm/ClassReader.java: the jdk 9 code incorrectly > reads the location of type annotations, which results in a compiler > crash. type-annotations fixed this. Discussed above. (skipped a bunch that won't be affected by my work) > - test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java > is being ignored in jdk9, even though it is working. Same for > AnnotatedPackage1 and CantAnnotateStaticClass3. The positions patch will probably fix a few of the @ignore'd tests. So I'd planned to go through, figure out what's working, and turn them back on. (The rest should be unaffected by my work) > How should I go about getting these changes into jdk9/jdk and jdk9/langtools? > Is it enough to send the above descriptions to compiler-dev and point > interested reviewers to a diff between the two repos? Should I attach > a diff? I have three major patches planned: remove AnnotatedType, which is already out for public review, the "positions patch", which is about to be, and a patch to remove code obsoleted by the positions patch. Here's what I'll do: we want to get the first two in ASAP, but the third is mostly for code cleanliness, and it may cause trouble rebasing some of those changes. I'll hold off on the cleanup patch, and we'll look at bringing the changes over after. As for the reorder fix, I will commit that to jdk9 (with a test) before I commit the two major changes, so that you can run checkers with them. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 901 bytes Desc: OpenPGP digital signature URL: From wdietl at gmail.com Thu May 8 21:13:17 2014 From: wdietl at gmail.com (Werner Dietl) Date: Thu, 8 May 2014 17:13:17 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <536BEFBC.4080508@oracle.com> References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> Message-ID: Eric, >> Type annotations in the jdk9 repo are currently broken for serious >> use. On Feb 7 I identified the invalid re-ordering performed in >> ClassReader: >> >> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-February/001592.html >> >> This problem still exists in jdk9 - the problematic changeset wasn't >> rolled back, nor was the fix applied. I have fixed this problem in >> type-annotations. >> I was waiting to hear an update on this before pursuing the other >> outstanding changes. > > I am aware of the fix that was pushed into the type annotations forest. > As we discussed when you developed the fix, I cannot push it into > jdk9-dev as-is, because the development practices of the langtools team > require that any changeset that introduces behavioral changes be > accompanied by a test. > > I will take care of the test this time, so that you can run checkers on > the contents of jdk9. However, in the future, we ask that patches > submitted against jdk9 conform to the langtools group's development > practices. It was your "cleanup" changeset that broke this. I think the correct thing to do would have been to either roll back your broken changeset or apply my fix. >> You say that after the new changes type-annotations will be seriously >> out of date. I don't see why this would be the case. I'm currently >> keeping type-annotations in sync with jdk9, making sure that the >> Checker Framework correctly works with type-annotations. Once these >> further refactorings go into jdk9, they should be easy to pull into >> type-annotations. > > I am posting a series of three (maybe just two) patches against jdk9, > which rearchitect a significant portion of the frontend implementation. > The end result is that it may not be trivial to rebase all the changes > you list below. I don't see why this should be hard - I'm just pulling in the changesets that you will push to jdk9. >> - test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java >> is being ignored in jdk9, even though it is working. Same for >> AnnotatedPackage1 and CantAnnotateStaticClass3. > > The positions patch will probably fix a few of the @ignore'd tests. So > I'd planned to go through, figure out what's working, and turn them back on. > > (The rest should be unaffected by my work) These tests are already working - so the @ignore in them might hide if one of your changes breaks them. >> How should I go about getting these changes into jdk9/jdk and jdk9/langtools? >> Is it enough to send the above descriptions to compiler-dev and point >> interested reviewers to a diff between the two repos? Should I attach >> a diff? > > I have three major patches planned: remove AnnotatedType, which is > already out for public review, the "positions patch", which is about to > be, and a patch to remove code obsoleted by the positions patch. > > Here's what I'll do: we want to get the first two in ASAP, but the third > is mostly for code cleanliness, and it may cause trouble rebasing some > of those changes. I'll hold off on the cleanup patch, and we'll look at > bringing the changes over after. > > As for the reorder fix, I will commit that to jdk9 (with a test) before > I commit the two major changes, so that you can run checkers with them. This sounds like I shouldn't do anything with the changes in type-annotations/langtools and you will take care that all meaningful changes are transfered to jdk9. Right? Should I do something about the two small fixes in type-annotations/jdk? cu, WMD. -- http://www.google.com/profiles/wdietl From eric.mccorkle at oracle.com Thu May 8 21:39:48 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Thu, 08 May 2014 17:39:48 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> Message-ID: <536BF9A4.5050707@oracle.com> On 05/08/14 17:13, Werner Dietl wrote: > > It was your "cleanup" changeset that broke this. > I think the correct thing to do would have been to either roll back > your broken changeset or apply my fix. > Again, the rules for the langtools repository require that all patches be accompanied by a test, unless the accompanying JBS issue has one of the "noreg-" tags. These noreg- tags are only allowed in a very small number of cases. One of these is for "cleanup" patches (indicated by "noreg-cleanup"), which are explicitly *not* supposed to introduce any behavior changes. However, accidents do happen, and in this case, one did. The fix for this accident clearly intends to change the behavior of javac, and thus, it must be accompanied by a test in order to be integrated into the jdk9 forest. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 901 bytes Desc: OpenPGP digital signature URL: From wdietl at gmail.com Thu May 8 22:10:14 2014 From: wdietl at gmail.com (Werner Dietl) Date: Thu, 8 May 2014 18:10:14 -0400 Subject: interactions between type annotations and language model APIs. Message-ID: In this message: http://mail.openjdk.java.net/pipermail/compiler-dev/2014-May/008758.html Alex raises the issue of "generator" methods and how "the "correct" thing to do would be to inspect the TypeMirror argument and thread its type annotations into the TypeMirror result." I agree that better support for type annotations in these methods would be great. It would also be awesome if subtyping, type inference, and other type operations were aware of type annotations. In the Checker Framework we need to go to great effort to re-calculate some computations that the compiler already performed, just to add the right type annotations. This is error prone and we might produce incorrect results. However, one complication is that to correctly "thread" type annotations through such computations, it is not enough to take the annotations from one side or the other or to append the lists of type annotations. For uses in type systems, you want to perform an operation like building the least upper bound or greatest lower bound of the two sets of type annotations. These operations depend on the particular interpretation of type annotations and I don't see how the compiler could independently perform the right operation. It would be awesome if there were a way for outside tool-builders to adapt the behavior of the compiler in such situations. Is this something you are considering when planning these changes? Cheers, cu, WMD. -- http://www.google.com/profiles/wdietl From jonathan.gibbons at oracle.com Thu May 8 22:16:27 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 08 May 2014 15:16:27 -0700 Subject: interactions between type annotations and language model APIs. In-Reply-To: References: Message-ID: <536C023B.70800@oracle.com> On 05/08/2014 03:10 PM, Werner Dietl wrote: > In this message: > > http://mail.openjdk.java.net/pipermail/compiler-dev/2014-May/008758.html > > Alex raises the issue of "generator" methods and how "the "correct" > thing to do would be to inspect the TypeMirror argument and thread its > type annotations into the TypeMirror result." > > I agree that better support for type annotations in these methods > would be great. > It would also be awesome if subtyping, type inference, and other type > operations were aware of type annotations. Type annotations exist outside the Java type system, and outside the JLS, so it is not clear to me how subtyping, inference, etc could be aware of type annotations beyond just noting their existence. The only place these annotations have any meaning attached is in the processors that manipulate them, and so that is where to model the interactions between type operations and type annotations. -- Jon > > In the Checker Framework we need to go to great effort to re-calculate > some computations that the compiler already performed, just to add the > right type annotations. This is error prone and we might produce > incorrect results. > > However, one complication is that to correctly "thread" type > annotations through such computations, it is not enough to take the > annotations from one side or the other or to append the lists of type > annotations. For uses in type systems, you want to perform an > operation like building the least upper bound or greatest lower bound > of the two sets of type annotations. > These operations depend on the particular interpretation of type > annotations and I don't see how the compiler could independently > perform the right operation. > > It would be awesome if there were a way for outside tool-builders to > adapt the behavior of the compiler in such situations. > Is this something you are considering when planning these changes? > > Cheers, > cu, WMD. > From eric.mccorkle at oracle.com Thu May 8 22:24:04 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Thu, 08 May 2014 18:24:04 -0400 Subject: interactions between type annotations and language model APIs. In-Reply-To: References: Message-ID: <536C0404.7080600@oracle.com> On 05/08/14 18:10, Werner Dietl wrote: > In this message: > > http://mail.openjdk.java.net/pipermail/compiler-dev/2014-May/008758.html > > Alex raises the issue of "generator" methods and how "the "correct" > thing to do would be to inspect the TypeMirror argument and thread its > type annotations into the TypeMirror result." > > I agree that better support for type annotations in these methods > would be great. > It would also be awesome if subtyping, type inference, and other type > operations were aware of type annotations. In my ongoing work, I have taken careful steps to preserve type annotations everywhere they ought to be. Now, I can't guarantee at this point that every single type that conceptually ought to have annotations will, but this is a first step. The prior step to making any such guarantee is figuring out what the spec does, or ought to say. Some cases are clear, others are not so clear. Subtyping is such an example. It is possible to think up examples of type annotations that should be preserved for subtypes, others that ought to be preserved for supertypes, and others that ought not to be preserved at all. (Stated more formally: we can think of type annotations as commutative unary type functions, which means we might see any kind of variance). > In the Checker Framework we need to go to great effort to re-calculate > some computations that the compiler already performed, just to add the > right type annotations. This is error prone and we might produce > incorrect results. > > However, one complication is that to correctly "thread" type > annotations through such computations, it is not enough to take the > annotations from one side or the other or to append the lists of type > annotations. For uses in type systems, you want to perform an > operation like building the least upper bound or greatest lower bound > of the two sets of type annotations. > These operations depend on the particular interpretation of type > annotations and I don't see how the compiler could independently > perform the right operation. > > It would be awesome if there were a way for outside tool-builders to > adapt the behavior of the compiler in such situations. > Is this something you are considering when planning these changes? If type annotations had a notion of variance, I think that would solve most of the cases I encountered in my recent patch. I can't say for sure it would solve them all, though. > Cheers, > cu, WMD. > -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 901 bytes Desc: OpenPGP digital signature URL: From eric.mccorkle at oracle.com Thu May 8 23:06:53 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Thu, 08 May 2014 19:06:53 -0400 Subject: Clarification for CantAnnotateStaticClass2 test Message-ID: <536C0E0D.6030701@oracle.com> Hello, In the test CantAnnotateStaticClass2, the following lines appear. @TB Outer f1; @TB Outer.Inner f1a; @TB Outer.SInner f2a; // err @TB Outer.IInner f3a; // err In the second line, TB annotates a static class from which a member is being selected, which should result in an error, but the test does not expect an error message. Should there, in fact, be an error message? Thanks, Eric -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available URL: From alex.buckley at oracle.com Thu May 8 23:19:41 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Thu, 08 May 2014 16:19:41 -0700 Subject: Clarification for CantAnnotateStaticClass2 test In-Reply-To: <536C0E0D.6030701@oracle.com> References: <536C0E0D.6030701@oracle.com> Message-ID: <536C110D.8070105@oracle.com> Good question, but the test is correct in not expecting an error from f1a. See http://mail.openjdk.java.net/pipermail/type-annotations-spec-observers/2013-October/000198.html and the ensuing rules in JLS8 9.7.4 about an "admissible" type annotation. Alex On 5/8/2014 4:06 PM, Eric McCorkle wrote: > Hello, > > In the test CantAnnotateStaticClass2, the following lines appear. > > > @TB Outer f1; > @TB Outer.Inner f1a; > @TB Outer.SInner f2a; // err > @TB Outer.IInner f3a; // err > > In the second line, TB annotates a static class from which a member is > being selected, which should result in an error, but the test does not > expect an error message. Should there, in fact, be an error message? > > Thanks, > Eric > From wdietl at gmail.com Thu May 8 23:21:39 2014 From: wdietl at gmail.com (Werner Dietl) Date: Thu, 8 May 2014 19:21:39 -0400 Subject: interactions between type annotations and language model APIs. In-Reply-To: <536C0404.7080600@oracle.com> References: <536C0404.7080600@oracle.com> Message-ID: Eric, Jon, all, I don't see how variance comes into play, Eric. A very simple example: (bool ? new @A Object() : new @B Object()) To determine the type of the ternary expression, we need to compute the least upper bound of the two cases. For a particular type system, the LUB of @A and @B might be @C. It would be nice if the compiler "asked" a plug-in for what the LUB of the two types is, instead of taking @A, @B, or @A @B. Currently, the compiler doesn't use either annotation, which to me is better than incorrectly taking the wrong annotation. Not promoting type annotations makes re-computation easier. If incorrect type annotations are promoted, an external tool would also need to know which type annotations from the compiler are correct and which are incorrectly promoted. So I see two options: - provide a mechanism for external tools to decide how type annotations are combined. From Jon's answer I take it that that is unlikely to happen. - only have type annotations in the locations explicitly written by the programmer, which is the current behavior. Eric, from your answer it sounds like you're working on changing the current behavior. Can you share more details of how you want to "preserve type annotations everywhere they ought to be"? cu, WMD. On Thu, May 8, 2014 at 6:24 PM, Eric McCorkle wrote: > On 05/08/14 18:10, Werner Dietl wrote: >> In this message: >> >> http://mail.openjdk.java.net/pipermail/compiler-dev/2014-May/008758.html >> >> Alex raises the issue of "generator" methods and how "the "correct" >> thing to do would be to inspect the TypeMirror argument and thread its >> type annotations into the TypeMirror result." >> >> I agree that better support for type annotations in these methods >> would be great. >> It would also be awesome if subtyping, type inference, and other type >> operations were aware of type annotations. > > In my ongoing work, I have taken careful steps to preserve type > annotations everywhere they ought to be. Now, I can't guarantee at this > point that every single type that conceptually ought to have annotations > will, but this is a first step. > > The prior step to making any such guarantee is figuring out what the > spec does, or ought to say. Some cases are clear, others are not so clear. > > Subtyping is such an example. It is possible to think up examples of > type annotations that should be preserved for subtypes, others that > ought to be preserved for supertypes, and others that ought not to be > preserved at all. (Stated more formally: we can think of type > annotations as commutative unary type functions, which means we might > see any kind of variance). > >> In the Checker Framework we need to go to great effort to re-calculate >> some computations that the compiler already performed, just to add the >> right type annotations. This is error prone and we might produce >> incorrect results. >> >> However, one complication is that to correctly "thread" type >> annotations through such computations, it is not enough to take the >> annotations from one side or the other or to append the lists of type >> annotations. For uses in type systems, you want to perform an >> operation like building the least upper bound or greatest lower bound >> of the two sets of type annotations. >> These operations depend on the particular interpretation of type >> annotations and I don't see how the compiler could independently >> perform the right operation. >> >> It would be awesome if there were a way for outside tool-builders to >> adapt the behavior of the compiler in such situations. >> Is this something you are considering when planning these changes? > > If type annotations had a notion of variance, I think that would solve > most of the cases I encountered in my recent patch. I can't say for > sure it would solve them all, though. > >> Cheers, >> cu, WMD. >> -- http://www.google.com/profiles/wdietl From alex.buckley at oracle.com Thu May 8 23:33:16 2014 From: alex.buckley at oracle.com (Alex Buckley) Date: Thu, 08 May 2014 16:33:16 -0700 Subject: interactions between type annotations and language model APIs. In-Reply-To: References: <536C0404.7080600@oracle.com> Message-ID: <536C143C.2000800@oracle.com> On 5/8/2014 4:21 PM, Werner Dietl wrote: > - provide a mechanism for external tools to decide how type > annotations are combined. From Jon's answer I take it that that is > unlikely to happen. Werner, as an OpenJDK Committer, you could propose a JEP to design and implement such a mechanism. Clearly, it would be important to delineate interaction with the type checker. Alex From eric.mccorkle at oracle.com Fri May 9 19:49:04 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 09 May 2014 15:49:04 -0400 Subject: Public review of rearchitected front-end type annotations pipeline Message-ID: <536D3130.2010500@oracle.com> Hello, This is the public review of the second in my series of patches dealing with type annotations. http://cr.openjdk.java.net/~emc/8027262/ This patch rearchitects the type annotations pipeline, integrating handling of type annotations directly into the javac MemberEnter/Annotate/Attr pipeline. It represents the majority of the work I have been doing regarding type annotations for 8u20. The handling of type annotations is now dispatched by the MemberEnter or Attr visitors and uses information from those visitors. Most of the actual functionality is now implemented in Annotate. The new test Stress.java is the test for this patch. Stress.java will cause 8-release javac to fail with an assertion failure. Its addition to the test suite demonstrates that this change fixes those cases. This patch addresses a number of JBS issues: https://bugs.openjdk.java.net/browse/JDK-8027262 https://bugs.openjdk.java.net/browse/JDK-8027261 https://bugs.openjdk.java.net/browse/JDK-8027258 https://bugs.openjdk.java.net/browse/JDK-8027182 and possibly others as well. Note: this patch does not attempt to remove code made obsolete; however, any such code is very clearly marked as deprecated. Removal of dead code will be done in the last of the series. This patch also does not attempt to re-enable tests which were previously disabled. That will be done as a separate patch as well. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 303 bytes Desc: not available URL: From wdietl at gmail.com Fri May 9 20:20:28 2014 From: wdietl at gmail.com (Werner Dietl) Date: Fri, 9 May 2014 16:20:28 -0400 Subject: Public review of rearchitected front-end type annotations pipeline In-Reply-To: <536D3130.2010500@oracle.com> References: <536D3130.2010500@oracle.com> Message-ID: Hi Eric, two quick questions: - I don't see "Stress" anywhere in the patch. Is that test case included? - Is there a reason to not use @Deprecated for the classes/methods that will be removed? Is this a good time to adapt the Checker Framework to these changes or should I wait for patch 3? Thanks, cu, WMD. On Fri, May 9, 2014 at 3:49 PM, Eric McCorkle wrote: > Hello, > > This is the public review of the second in my series of patches dealing > with type annotations. > > http://cr.openjdk.java.net/~emc/8027262/ > > This patch rearchitects the type annotations pipeline, integrating > handling of type annotations directly into the javac > MemberEnter/Annotate/Attr pipeline. It represents the majority of the > work I have been doing regarding type annotations for 8u20. > > The handling of type annotations is now dispatched by the MemberEnter or > Attr visitors and uses information from those visitors. Most of the > actual functionality is now implemented in Annotate. > > The new test Stress.java is the test for this patch. Stress.java will > cause 8-release javac to fail with an assertion failure. Its addition > to the test suite demonstrates that this change fixes those cases. > > This patch addresses a number of JBS issues: > https://bugs.openjdk.java.net/browse/JDK-8027262 > https://bugs.openjdk.java.net/browse/JDK-8027261 > https://bugs.openjdk.java.net/browse/JDK-8027258 > https://bugs.openjdk.java.net/browse/JDK-8027182 > and possibly others as well. > > Note: this patch does not attempt to remove code made obsolete; however, > any such code is very clearly marked as deprecated. Removal of dead > code will be done in the last of the series. This patch also does not > attempt to re-enable tests which were previously disabled. That will be > done as a separate patch as well. -- http://www.google.com/profiles/wdietl From eric.mccorkle at oracle.com Fri May 9 20:34:38 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 09 May 2014 16:34:38 -0400 Subject: Public review of rearchitected front-end type annotations pipeline In-Reply-To: References: <536D3130.2010500@oracle.com> Message-ID: <536D3BDE.3010806@oracle.com> On 05/09/14 16:20, Werner Dietl wrote: > Hi Eric, > > two quick questions: > > - I don't see "Stress" anywhere in the patch. Is that test case included? Apologies, Stress.java got left out by accident. That has been corrected. > - Is there a reason to not use @Deprecated for the classes/methods > that will be removed? There are still some uses of the deprecated code, which will produce warnings. Since javac is required to compile with -Werror, we can't have warnings. > Is this a good time to adapt the Checker Framework to these changes or > should I wait for patch 3? You should be fine. Patch 3 does some very minor code moving, and a whole lot of removal. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available URL: From wdietl at gmail.com Fri May 9 20:48:36 2014 From: wdietl at gmail.com (Werner Dietl) Date: Fri, 9 May 2014 16:48:36 -0400 Subject: Public review of rearchitected front-end type annotations pipeline In-Reply-To: <536D3BDE.3010806@oracle.com> References: <536D3130.2010500@oracle.com> <536D3BDE.3010806@oracle.com> Message-ID: >> two quick questions: >> >> - I don't see "Stress" anywhere in the patch. Is that test case included? > > Apologies, Stress.java got left out by accident. That has been corrected. Would it be better to write that test in the "referenceinfos" style? At the moment Stress just makes sure that all the different syntax elements work, which other tests in "newlocations" also do. It's not clear which of the examples in Stress previously worked and which didn't. The "referenceinfos" style of tests would also make sure that the generated bytecode contains the correct type annotations. >> - Is there a reason to not use @Deprecated for the classes/methods >> that will be removed? > > There are still some uses of the deprecated code, which will produce > warnings. Since javac is required to compile with -Werror, we can't > have warnings. Ok, then I just make them @Deprecated locally to make it easier to find my uses of these methods. >> Is this a good time to adapt the Checker Framework to these changes or >> should I wait for patch 3? > > You should be fine. Patch 3 does some very minor code moving, and a > whole lot of removal. Is there a timeline for this patch? If it also comes within a few days, I'll rather wait for it. cu, WMD. -- http://www.google.com/profiles/wdietl From eric.mccorkle at oracle.com Fri May 9 20:55:25 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 09 May 2014 16:55:25 -0400 Subject: Public review of rearchitected front-end type annotations pipeline In-Reply-To: References: <536D3130.2010500@oracle.com> <536D3BDE.3010806@oracle.com> Message-ID: <536D40BD.9020106@oracle.com> On 05/09/14 16:48, Werner Dietl wrote: >>> two quick questions: >>> >>> - I don't see "Stress" anywhere in the patch. Is that test case included? >> >> Apologies, Stress.java got left out by accident. That has been corrected. > > Would it be better to write that test in the "referenceinfos" style? > At the moment Stress just makes sure that all the different syntax > elements work, which other tests in "newlocations" also do. It's not > clear which of the examples in Stress previously worked and which > didn't. > The "referenceinfos" style of tests would also make sure that the > generated bytecode contains the correct type annotations. > The idea of Stress is to hit a whole bunch of edge cases. While I'm not opposed to expanding the newlocations tests (or preferably, writing a combo-test), I would prefer to put Stress in as-is. There is also the fact that it is a kind of regression test, as it crashes 8-release javac. >>> Is this a good time to adapt the Checker Framework to these changes or >>> should I wait for patch 3? >> >> You should be fine. Patch 3 does some very minor code moving, and a >> whole lot of removal. > > Is there a timeline for this patch? If it also comes within a few > days, I'll rather wait for it. > The dead code patch depends on this one (obviously), and unfortunately, my only option for review until this patch goes in is to post a diff. Ideally, this patch will be committed some time early next week, at which point the dead code patch will immediately go up for review. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available URL: From wdietl at gmail.com Fri May 9 21:53:33 2014 From: wdietl at gmail.com (Werner Dietl) Date: Fri, 9 May 2014 17:53:33 -0400 Subject: Public review of rearchitected front-end type annotations pipeline In-Reply-To: <536D40BD.9020106@oracle.com> References: <536D3130.2010500@oracle.com> <536D3BDE.3010806@oracle.com> <536D40BD.9020106@oracle.com> Message-ID: In test/tools/javac/warnings/suppress/TypeAnnotations.out 9 warnings are removed. For example, line 23 uses a @Deprecated type annotation in a cast twice. Why don't you expect the warnings for this anymore? cu, WMD. On Fri, May 9, 2014 at 4:55 PM, Eric McCorkle wrote: > On 05/09/14 16:48, Werner Dietl wrote: >>>> two quick questions: >>>> >>>> - I don't see "Stress" anywhere in the patch. Is that test case included? >>> >>> Apologies, Stress.java got left out by accident. That has been corrected. >> >> Would it be better to write that test in the "referenceinfos" style? >> At the moment Stress just makes sure that all the different syntax >> elements work, which other tests in "newlocations" also do. It's not >> clear which of the examples in Stress previously worked and which >> didn't. >> The "referenceinfos" style of tests would also make sure that the >> generated bytecode contains the correct type annotations. >> > > The idea of Stress is to hit a whole bunch of edge cases. While I'm not > opposed to expanding the newlocations tests (or preferably, writing a > combo-test), I would prefer to put Stress in as-is. > > There is also the fact that it is a kind of regression test, as it > crashes 8-release javac. > >>>> Is this a good time to adapt the Checker Framework to these changes or >>>> should I wait for patch 3? >>> >>> You should be fine. Patch 3 does some very minor code moving, and a >>> whole lot of removal. >> >> Is there a timeline for this patch? If it also comes within a few >> days, I'll rather wait for it. >> > > The dead code patch depends on this one (obviously), and unfortunately, > my only option for review until this patch goes in is to post a diff. > > Ideally, this patch will be committed some time early next week, at > which point the dead code patch will immediately go up for review. -- http://www.google.com/profiles/wdietl From eric.mccorkle at oracle.com Fri May 9 23:21:25 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 09 May 2014 19:21:25 -0400 Subject: Public review of rearchitected front-end type annotations pipeline In-Reply-To: References: <536D3130.2010500@oracle.com> <536D3BDE.3010806@oracle.com> <536D40BD.9020106@oracle.com> Message-ID: <536D62F5.6000008@oracle.com> On 05/09/14 17:53, Werner Dietl wrote: > In test/tools/javac/warnings/suppress/TypeAnnotations.out > 9 warnings are removed. > For example, line 23 uses a @Deprecated type annotation in a cast twice. > Why don't you expect the warnings for this anymore? If you look, you will notice that all the removed warnings are duplicates of other warnings. There was a bug in the original implementation that apparently caused warnings coming from annotations on instanceof and cast (and probably other things) to be emitted twice. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available URL: From wdietl at gmail.com Fri May 9 23:24:44 2014 From: wdietl at gmail.com (Werner Dietl) Date: Fri, 9 May 2014 19:24:44 -0400 Subject: Public review of rearchitected front-end type annotations pipeline In-Reply-To: <536D62F5.6000008@oracle.com> References: <536D3130.2010500@oracle.com> <536D3BDE.3010806@oracle.com> <536D40BD.9020106@oracle.com> <536D62F5.6000008@oracle.com> Message-ID: Ah, sorry for missing that! cu, WMD. On Fri, May 9, 2014 at 7:21 PM, Eric McCorkle wrote: > On 05/09/14 17:53, Werner Dietl wrote: >> In test/tools/javac/warnings/suppress/TypeAnnotations.out >> 9 warnings are removed. >> For example, line 23 uses a @Deprecated type annotation in a cast twice. >> Why don't you expect the warnings for this anymore? > > If you look, you will notice that all the removed warnings are > duplicates of other warnings. > > There was a bug in the original implementation that apparently caused > warnings coming from annotations on instanceof and cast (and probably > other things) to be emitted twice. -- http://www.google.com/profiles/wdietl From eric.mccorkle at oracle.com Sat May 10 00:42:02 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Fri, 09 May 2014 20:42:02 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <536BEFBC.4080508@oracle.com> References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> Message-ID: <536D75DA.8050908@oracle.com> On 05/08/14 16:57, Eric McCorkle wrote: > I am aware of the fix that was pushed into the type annotations forest. > As we discussed when you developed the fix, I cannot push it into > jdk9-dev as-is, because the development practices of the langtools team > require that any changeset that introduces behavioral changes be > accompanied by a test. > > I will take care of the test this time, so that you can run checkers on > the contents of jdk9. However, in the future, we ask that patches > submitted against jdk9 conform to the langtools group's development > practices. I looked into this more. I'm not at all certain how you even get this problem to show up. The only type annotations with local variable info are LOCAL_VARIABLE or RESOURCE_VARIABLE type annotations, both of which javac only ever generates on code attributes. Also, javac never *reads* annotations on code attributes. Therefore, it is not really possible to write a test. It also suggests you're running into funny class files in checkers somehow. On the other hand, all this means we can give the bug the noreg-hard tag, and send it through the review process. So it should be in jdk9 soon. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 901 bytes Desc: OpenPGP digital signature URL: From wdietl at gmail.com Sat May 10 01:15:52 2014 From: wdietl at gmail.com (Werner Dietl) Date: Fri, 9 May 2014 21:15:52 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <536D75DA.8050908@oracle.com> References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> <536D75DA.8050908@oracle.com> Message-ID: Eric, are you saying that that part of ClassReader is dead code that will never run? Shouldn't it be removed then? cu, WMD. On Fri, May 9, 2014 at 8:42 PM, Eric McCorkle wrote: > On 05/08/14 16:57, Eric McCorkle wrote: > >> I am aware of the fix that was pushed into the type annotations forest. >> As we discussed when you developed the fix, I cannot push it into >> jdk9-dev as-is, because the development practices of the langtools team >> require that any changeset that introduces behavioral changes be >> accompanied by a test. >> >> I will take care of the test this time, so that you can run checkers on >> the contents of jdk9. However, in the future, we ask that patches >> submitted against jdk9 conform to the langtools group's development >> practices. > > I looked into this more. I'm not at all certain how you even get this > problem to show up. The only type annotations with local variable info > are LOCAL_VARIABLE or RESOURCE_VARIABLE type annotations, both of which > javac only ever generates on code attributes. Also, javac never *reads* > annotations on code attributes. Therefore, it is not really possible to > write a test. It also suggests you're running into funny class files in > checkers somehow. > > On the other hand, all this means we can give the bug the noreg-hard > tag, and send it through the review process. So it should be in jdk9 soon. -- http://www.google.com/profiles/wdietl From jonathan.gibbons at oracle.com Sat May 10 01:18:19 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 09 May 2014 18:18:19 -0700 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> <536D75DA.8050908@oracle.com> Message-ID: <536D7E5B.70603@oracle.com> Werner, Potentially, yes. We're investigating. -- Jon On 05/09/2014 06:15 PM, Werner Dietl wrote: > Eric, > > are you saying that that part of ClassReader is dead code that will > never run? Shouldn't it be removed then? > > cu, WMD. > > On Fri, May 9, 2014 at 8:42 PM, Eric McCorkle wrote: >> On 05/08/14 16:57, Eric McCorkle wrote: >> >>> I am aware of the fix that was pushed into the type annotations forest. >>> As we discussed when you developed the fix, I cannot push it into >>> jdk9-dev as-is, because the development practices of the langtools team >>> require that any changeset that introduces behavioral changes be >>> accompanied by a test. >>> >>> I will take care of the test this time, so that you can run checkers on >>> the contents of jdk9. However, in the future, we ask that patches >>> submitted against jdk9 conform to the langtools group's development >>> practices. >> I looked into this more. I'm not at all certain how you even get this >> problem to show up. The only type annotations with local variable info >> are LOCAL_VARIABLE or RESOURCE_VARIABLE type annotations, both of which >> javac only ever generates on code attributes. Also, javac never *reads* >> annotations on code attributes. Therefore, it is not really possible to >> write a test. It also suggests you're running into funny class files in >> checkers somehow. >> >> On the other hand, all this means we can give the bug the noreg-hard >> tag, and send it through the review process. So it should be in jdk9 soon. > > From wdietl at gmail.com Sat May 10 01:26:04 2014 From: wdietl at gmail.com (Werner Dietl) Date: Fri, 9 May 2014 21:26:04 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <536D7E5B.70603@oracle.com> References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> <536D75DA.8050908@oracle.com> <536D7E5B.70603@oracle.com> Message-ID: The stack trace that caused me to look at this, with code from February 7, 2014, is below. When I changed the reordering code back to the way it is in type-annotations now, this exception went away. The Checker Framework isn't doing funny things with the class files and it isn't on this stack trace. So to me it seems like that code is used, as it had direct impact on this exception. java.lang.ClassCastException: com.sun.tools.javac.code.Symbol$MethodSymbol cannot be cast to com.sun.tools.javac.util.Name at com.sun.tools.javac.jvm.ClassReader.readName(ClassReader.java:565) at com.sun.tools.javac.jvm.ClassReader.readCompoundAnnotation(ClassReader.java:1458) at com.sun.tools.javac.jvm.ClassReader.readTypeAnnotation(ClassReader.java:1467) at com.sun.tools.javac.jvm.ClassReader.attachTypeAnnotations(ClassReader.java:1415) at com.sun.tools.javac.jvm.ClassReader$23.read(ClassReader.java:1180) at com.sun.tools.javac.jvm.ClassReader.readAttrs(ClassReader.java:1330) at com.sun.tools.javac.jvm.ClassReader.readMemberAttrs(ClassReader.java:1320) at com.sun.tools.javac.jvm.ClassReader.readCode(ClassReader.java:1357) at com.sun.tools.javac.jvm.ClassReader$3.read(ClassReader.java:954) at com.sun.tools.javac.jvm.ClassReader.readAttrs(ClassReader.java:1330) at com.sun.tools.javac.jvm.ClassReader.readMemberAttrs(ClassReader.java:1320) at com.sun.tools.javac.jvm.ClassReader.readMethod(ClassReader.java:2088) at com.sun.tools.javac.jvm.ClassReader.readClass(ClassReader.java:2296) at com.sun.tools.javac.jvm.ClassReader.readClassFile(ClassReader.java:2368) at com.sun.tools.javac.jvm.ClassReader.fillIn(ClassReader.java:2484) at com.sun.tools.javac.jvm.ClassReader.complete(ClassReader.java:2415) at com.sun.tools.javac.jvm.ClassReader.access$000(ClassReader.java:76) at com.sun.tools.javac.jvm.ClassReader$1.complete(ClassReader.java:234) at com.sun.tools.javac.code.Symbol.complete(Symbol.java:560) at com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1024) at com.sun.tools.javac.jvm.ClassReader.loadClass(ClassReader.java:2597) at com.sun.tools.javac.comp.Resolve.loadClass(Resolve.java:1862) at com.sun.tools.javac.comp.Resolve.findIdentInPackage(Resolve.java:2101) at com.sun.tools.javac.comp.Attr.selectSym(Attr.java:3366) at com.sun.tools.javac.comp.Attr.visitSelect(Attr.java:3265) at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:1891) at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:595) at com.sun.tools.javac.comp.Attr.attribType(Attr.java:657) at com.sun.tools.javac.comp.Attr.attribType(Attr.java:650) at com.sun.tools.javac.comp.MemberEnter.attribImportType(MemberEnter.java:835) at com.sun.tools.javac.comp.MemberEnter.visitImport(MemberEnter.java:555) at com.sun.tools.javac.tree.JCTree$JCImport.accept(JCTree.java:571) at com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:434) at com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:446) at com.sun.tools.javac.comp.MemberEnter.visitTopLevel(MemberEnter.java:525) at com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:518) at com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:434) at com.sun.tools.javac.comp.MemberEnter.complete(MemberEnter.java:1035) at com.sun.tools.javac.code.Symbol.complete(Symbol.java:560) at com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1024) at com.sun.tools.javac.comp.Enter.complete(Enter.java:495) at com.sun.tools.javac.comp.Enter.main(Enter.java:473) at com.sun.tools.javac.main.JavaCompiler.enterTrees(JavaCompiler.java:981) at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856) at com.sun.tools.javac.main.Main.compile(Main.java:521) at com.sun.tools.javac.main.Main.compile(Main.java:381) at com.sun.tools.javac.main.Main.compile(Main.java:370) at com.sun.tools.javac.main.Main.compile(Main.java:361) at com.sun.tools.javac.Main.compile(Main.java:56) at com.sun.tools.javac.Main.main(Main.java:42) cu, WMD. On Fri, May 9, 2014 at 9:18 PM, Jonathan Gibbons wrote: > Werner, > > Potentially, yes. We're investigating. > > -- Jon > > > On 05/09/2014 06:15 PM, Werner Dietl wrote: >> >> Eric, >> >> are you saying that that part of ClassReader is dead code that will >> never run? Shouldn't it be removed then? >> >> cu, WMD. >> >> On Fri, May 9, 2014 at 8:42 PM, Eric McCorkle >> wrote: >>> >>> On 05/08/14 16:57, Eric McCorkle wrote: >>> >>>> I am aware of the fix that was pushed into the type annotations forest. >>>> As we discussed when you developed the fix, I cannot push it into >>>> jdk9-dev as-is, because the development practices of the langtools team >>>> require that any changeset that introduces behavioral changes be >>>> accompanied by a test. >>>> >>>> I will take care of the test this time, so that you can run checkers on >>>> the contents of jdk9. However, in the future, we ask that patches >>>> submitted against jdk9 conform to the langtools group's development >>>> practices. >>> >>> I looked into this more. I'm not at all certain how you even get this >>> problem to show up. The only type annotations with local variable info >>> are LOCAL_VARIABLE or RESOURCE_VARIABLE type annotations, both of which >>> javac only ever generates on code attributes. Also, javac never *reads* >>> annotations on code attributes. Therefore, it is not really possible to >>> write a test. It also suggests you're running into funny class files in >>> checkers somehow. >>> >>> On the other hand, all this means we can give the bug the noreg-hard >>> tag, and send it through the review process. So it should be in jdk9 >>> soon. >> >> >> > -- http://www.google.com/profiles/wdietl From jonathan.gibbons at oracle.com Sat May 10 01:34:38 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 09 May 2014 18:34:38 -0700 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> <536D75DA.8050908@oracle.com> <536D7E5B.70603@oracle.com> Message-ID: <536D822E.7020405@oracle.com> Aha, I think the code may be triggered by saveParameterNames. Thanks for the stack trace. -- Jon On 05/09/2014 06:26 PM, Werner Dietl wrote: > The stack trace that caused me to look at this, with code from > February 7, 2014, is below. > When I changed the reordering code back to the way it is in > type-annotations now, this exception went away. > The Checker Framework isn't doing funny things with the class files > and it isn't on this stack trace. > So to me it seems like that code is used, as it had direct impact on > this exception. > > java.lang.ClassCastException: > com.sun.tools.javac.code.Symbol$MethodSymbol cannot be cast to > com.sun.tools.javac.util.Name > at com.sun.tools.javac.jvm.ClassReader.readName(ClassReader.java:565) > at com.sun.tools.javac.jvm.ClassReader.readCompoundAnnotation(ClassReader.java:1458) > at com.sun.tools.javac.jvm.ClassReader.readTypeAnnotation(ClassReader.java:1467) > at com.sun.tools.javac.jvm.ClassReader.attachTypeAnnotations(ClassReader.java:1415) > at com.sun.tools.javac.jvm.ClassReader$23.read(ClassReader.java:1180) > at com.sun.tools.javac.jvm.ClassReader.readAttrs(ClassReader.java:1330) > at com.sun.tools.javac.jvm.ClassReader.readMemberAttrs(ClassReader.java:1320) > at com.sun.tools.javac.jvm.ClassReader.readCode(ClassReader.java:1357) > at com.sun.tools.javac.jvm.ClassReader$3.read(ClassReader.java:954) > at com.sun.tools.javac.jvm.ClassReader.readAttrs(ClassReader.java:1330) > at com.sun.tools.javac.jvm.ClassReader.readMemberAttrs(ClassReader.java:1320) > at com.sun.tools.javac.jvm.ClassReader.readMethod(ClassReader.java:2088) > at com.sun.tools.javac.jvm.ClassReader.readClass(ClassReader.java:2296) > at com.sun.tools.javac.jvm.ClassReader.readClassFile(ClassReader.java:2368) > at com.sun.tools.javac.jvm.ClassReader.fillIn(ClassReader.java:2484) > at com.sun.tools.javac.jvm.ClassReader.complete(ClassReader.java:2415) > at com.sun.tools.javac.jvm.ClassReader.access$000(ClassReader.java:76) > at com.sun.tools.javac.jvm.ClassReader$1.complete(ClassReader.java:234) > at com.sun.tools.javac.code.Symbol.complete(Symbol.java:560) > at com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1024) > at com.sun.tools.javac.jvm.ClassReader.loadClass(ClassReader.java:2597) > at com.sun.tools.javac.comp.Resolve.loadClass(Resolve.java:1862) > at com.sun.tools.javac.comp.Resolve.findIdentInPackage(Resolve.java:2101) > at com.sun.tools.javac.comp.Attr.selectSym(Attr.java:3366) > at com.sun.tools.javac.comp.Attr.visitSelect(Attr.java:3265) > at com.sun.tools.javac.tree.JCTree$JCFieldAccess.accept(JCTree.java:1891) > at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:595) > at com.sun.tools.javac.comp.Attr.attribType(Attr.java:657) > at com.sun.tools.javac.comp.Attr.attribType(Attr.java:650) > at com.sun.tools.javac.comp.MemberEnter.attribImportType(MemberEnter.java:835) > at com.sun.tools.javac.comp.MemberEnter.visitImport(MemberEnter.java:555) > at com.sun.tools.javac.tree.JCTree$JCImport.accept(JCTree.java:571) > at com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:434) > at com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:446) > at com.sun.tools.javac.comp.MemberEnter.visitTopLevel(MemberEnter.java:525) > at com.sun.tools.javac.tree.JCTree$JCCompilationUnit.accept(JCTree.java:518) > at com.sun.tools.javac.comp.MemberEnter.memberEnter(MemberEnter.java:434) > at com.sun.tools.javac.comp.MemberEnter.complete(MemberEnter.java:1035) > at com.sun.tools.javac.code.Symbol.complete(Symbol.java:560) > at com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1024) > at com.sun.tools.javac.comp.Enter.complete(Enter.java:495) > at com.sun.tools.javac.comp.Enter.main(Enter.java:473) > at com.sun.tools.javac.main.JavaCompiler.enterTrees(JavaCompiler.java:981) > at com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856) > at com.sun.tools.javac.main.Main.compile(Main.java:521) > at com.sun.tools.javac.main.Main.compile(Main.java:381) > at com.sun.tools.javac.main.Main.compile(Main.java:370) > at com.sun.tools.javac.main.Main.compile(Main.java:361) > at com.sun.tools.javac.Main.compile(Main.java:56) > at com.sun.tools.javac.Main.main(Main.java:42) > > cu, WMD. > > > On Fri, May 9, 2014 at 9:18 PM, Jonathan Gibbons > wrote: >> Werner, >> >> Potentially, yes. We're investigating. >> >> -- Jon >> >> >> On 05/09/2014 06:15 PM, Werner Dietl wrote: >>> Eric, >>> >>> are you saying that that part of ClassReader is dead code that will >>> never run? Shouldn't it be removed then? >>> >>> cu, WMD. >>> >>> On Fri, May 9, 2014 at 8:42 PM, Eric McCorkle >>> wrote: >>>> On 05/08/14 16:57, Eric McCorkle wrote: >>>> >>>>> I am aware of the fix that was pushed into the type annotations forest. >>>>> As we discussed when you developed the fix, I cannot push it into >>>>> jdk9-dev as-is, because the development practices of the langtools team >>>>> require that any changeset that introduces behavioral changes be >>>>> accompanied by a test. >>>>> >>>>> I will take care of the test this time, so that you can run checkers on >>>>> the contents of jdk9. However, in the future, we ask that patches >>>>> submitted against jdk9 conform to the langtools group's development >>>>> practices. >>>> I looked into this more. I'm not at all certain how you even get this >>>> problem to show up. The only type annotations with local variable info >>>> are LOCAL_VARIABLE or RESOURCE_VARIABLE type annotations, both of which >>>> javac only ever generates on code attributes. Also, javac never *reads* >>>> annotations on code attributes. Therefore, it is not really possible to >>>> write a test. It also suggests you're running into funny class files in >>>> checkers somehow. >>>> >>>> On the other hand, all this means we can give the bug the noreg-hard >>>> tag, and send it through the review process. So it should be in jdk9 >>>> soon. >>> >>> > > From wdietl at gmail.com Wed May 14 23:25:23 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 14 May 2014 23:25:23 +0000 Subject: hg: type-annotations/type-annotations: 5 new changesets Message-ID: <201405142325.s4ENPOf0023254@aojmv0008> Changeset: c06426b116fb Author: katleman Date: 2014-05-08 01:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/c06426b116fb Added tag jdk9-b12 for changeset 59f6350295f9 ! .hgtags Changeset: 5800456add07 Author: lana Date: 2014-05-08 15:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/5800456add07 Merge Changeset: 87acde3de1cc Author: coffeys Date: 2014-05-13 10:20 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/87acde3de1cc 8042932: Bump up the -source version for JDK 9 builds Reviewed-by: chegar, erikj, thurka ! common/autoconf/boot-jdk.m4 ! common/autoconf/generated-configure.sh Changeset: b84fc0b1efc2 Author: mduigou Date: 2014-05-13 08:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/b84fc0b1efc2 8042810: hgforest: some shells run read in sub-shell and can't use fifo Reviewed-by: chegar, erikj ! common/bin/hgforest.sh Changeset: 9a4d0c939f41 Author: wmdietl Date: 2014-05-14 19:25 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/9a4d0c939f41 Automated merge with http://hg.openjdk.java.net/jdk9/dev/ ! .hgtags From wdietl at gmail.com Wed May 14 23:26:05 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 14 May 2014 23:26:05 +0000 Subject: hg: type-annotations/type-annotations/corba: 3 new changesets Message-ID: <201405142326.s4ENQ6Xs023355@aojmv0008> Changeset: 088eec4c36f4 Author: katleman Date: 2014-05-08 01:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/088eec4c36f4 Added tag jdk9-b12 for changeset e212cdcc8c11 ! .hgtags Changeset: 48a86f89eeb3 Author: coffeys Date: 2014-05-13 20:59 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/48a86f89eeb3 8042906: Remove use of reflection in ORB Reviewed-by: alanb, chegar, dfuchs, psandoz ! src/share/classes/com/sun/corba/se/spi/orb/ORB.java Changeset: 68e5b99dd570 Author: wmdietl Date: 2014-05-14 19:25 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/68e5b99dd570 Automated merge with http://hg.openjdk.java.net/jdk9/dev/corba ! .hgtags From wdietl at gmail.com Wed May 14 23:27:12 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 14 May 2014 23:27:12 +0000 Subject: hg: type-annotations/type-annotations/jaxws: 2 new changesets Message-ID: <201405142327.s4ENRG6E023852@aojmv0008> Changeset: 3d42204854c9 Author: katleman Date: 2014-05-08 01:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/3d42204854c9 Added tag jdk9-b12 for changeset 779f8b21c75f ! .hgtags Changeset: 59b40846a55a Author: wmdietl Date: 2014-05-14 19:26 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/59b40846a55a Automated merge with http://hg.openjdk.java.net/jdk9/dev/jaxws ! .hgtags From wdietl at gmail.com Wed May 14 23:30:57 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 14 May 2014 23:30:57 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 2 new changesets Message-ID: <201405142331.s4ENV0Q2024365@aojmv0008> Changeset: 5eaf717f6e36 Author: katleman Date: 2014-05-08 01:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/5eaf717f6e36 Added tag jdk9-b12 for changeset e88cecf5a21b ! .hgtags Changeset: 416f6d17ed9a Author: wmdietl Date: 2014-05-14 19:27 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/416f6d17ed9a Automated merge with http://hg.openjdk.java.net/jdk9/dev/jaxp ! .hgtags From wdietl at gmail.com Wed May 14 23:51:53 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Wed, 14 May 2014 23:51:53 +0000 Subject: hg: type-annotations/type-annotations/jdk: 22 new changesets Message-ID: <201405142354.s4ENs2Ro027893@aojmv0008> Changeset: 851b1ddcdfb2 Author: sla Date: 2014-04-25 17:19 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/851b1ddcdfb2 8041979: sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all platforms Reviewed-by: kamg, mgronlun ! make/mapfiles/libjava/mapfile-vers ! src/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java ! src/share/classes/sun/misc/VMSupport.java ! src/share/javavm/export/jvm.h ! src/share/native/sun/misc/VMSupport.c ! test/com/sun/tools/attach/BasicTests.java ! test/com/sun/tools/attach/RunnerUtil.java + test/com/sun/tools/attach/TempDirTest.java ! test/com/sun/tools/attach/java.policy.allow ! test/com/sun/tools/attach/java.policy.deny Changeset: 690ac983ad6c Author: yan Date: 2014-05-08 13:26 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/690ac983ad6c 8042105: Fix some more doclint issues in javax.swing.text.html classes Reviewed-by: alexsch ! src/share/classes/javax/swing/text/html/CSS.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/HTML.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/HTMLFrameHyperlinkEvent.java Changeset: a9d59d9496c2 Author: weijun Date: 2014-05-08 22:30 +0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a9d59d9496c2 8040068: SolarisSystem should be @Deprecated and @jdk.Exported(false) Reviewed-by: alanb, mullan ! src/share/classes/com/sun/security/auth/module/SolarisSystem.java Changeset: 86305d35de9b Author: weijun Date: 2014-05-08 22:30 +0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/86305d35de9b 8039951: com.sun.security.auth.module missing classes on some platforms Reviewed-by: mullan ! make/CompileJavaClasses.gmk ! src/share/classes/com/sun/security/auth/module/NTLoginModule.java ! src/share/classes/com/sun/security/auth/module/SolarisLoginModule.java ! src/share/classes/com/sun/security/auth/module/UnixLoginModule.java ! src/share/classes/sun/security/krb5/internal/rcache/DflCache.java + test/com/sun/security/auth/module/AllPlatforms.java ! test/sun/security/krb5/auto/ReplayCacheTestProc.java Changeset: 249337ca0ce7 Author: bpb Date: 2014-05-08 16:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/249337ca0ce7 8042478: Include Mersenne primes in BigInteger primality testing Summary: Add testing of some of the Mersenne primes. Reviewed-by: darcy ! test/java/math/BigInteger/PrimeTest.java Changeset: ac1b3c46ed4d Author: katleman Date: 2014-05-08 01:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ac1b3c46ed4d Added tag jdk9-b12 for changeset 83d9bc20973d ! .hgtags Changeset: b04f3a46b5d7 Author: lana Date: 2014-05-08 15:27 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b04f3a46b5d7 Merge Changeset: c7c8002d0272 Author: lana Date: 2014-05-08 17:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c7c8002d0272 Merge Changeset: 0836900e58a3 Author: alanb Date: 2014-05-09 09:47 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/0836900e58a3 8042816: (fs) Path.register doesn't throw IllegalArgumentException if multiple OVERFLOW events are specified, part 2 Reviewed-by: chegar ! src/share/classes/sun/nio/fs/PollingWatchService.java Changeset: 7426549b1e3b Author: sla Date: 2014-05-09 12:06 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7426549b1e3b 8039173: Propagate errors from Diagnostic Commands as exceptions in the attach framework Reviewed-by: igerasim, alanb, dsamersoff + src/share/classes/com/sun/tools/attach/AttachOperationFailedException.java ! src/share/classes/com/sun/tools/attach/VirtualMachine.java ! src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java ! src/share/classes/sun/tools/jcmd/JCmd.java ! src/solaris/classes/sun/tools/attach/BsdVirtualMachine.java ! src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java ! src/solaris/classes/sun/tools/attach/SolarisVirtualMachine.java ! src/solaris/native/sun/tools/attach/BsdVirtualMachine.c ! src/solaris/native/sun/tools/attach/LinuxVirtualMachine.c ! src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c ! src/windows/classes/sun/tools/attach/WindowsVirtualMachine.java ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c ! test/sun/management/jmxremote/startstop/JMXStartStopTest.java Changeset: bb79460d72d8 Author: mchung Date: 2014-05-09 09:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bb79460d72d8 8040059: Change default policy for extensions to no permission Reviewed-by: alanb, mullan, erikj ! make/CopyFiles.gmk ! src/share/classes/jdk/nio/zipfs/ZipFileSystem.java ! src/share/lib/security/java.policy + src/windows/lib/security/java.policy ! test/TEST.groups ! test/jdk/nio/zipfs/Basic.java ! test/jdk/nio/zipfs/PathOps.java ! test/jdk/nio/zipfs/ZFSTests.java ! test/jdk/nio/zipfs/ZipFSTester.java + test/jdk/nio/zipfs/test.policy + test/jdk/nio/zipfs/test.policy.readonly ! test/lib/security/java.policy/Ext_AllPolicy.java ! test/lib/security/java.policy/Ext_AllPolicy.sh + test/lib/security/java.policy/test.policy Changeset: ad7720938e7c Author: emc Date: 2014-05-09 15:27 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ad7720938e7c 8042859: Build broken for Solaris Summary: Remove stray quotes causing build failures Reviewed-by: sla, chegar ! src/solaris/native/sun/tools/attach/SolarisVirtualMachine.c Changeset: 05e9c9216e26 Author: ykantser Date: 2014-05-09 15:24 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/05e9c9216e26 8034960: Serviceability tests using @library failing with java.lang.NoClassDefFoundError Reviewed-by: sla, alanb ! test/com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java ! test/com/sun/tools/attach/BasicTests.java ! test/com/sun/tools/attach/PermissionTest.java ! test/com/sun/tools/attach/ProviderTest.java ! test/java/io/BufferedInputStream/LargeCopyWithMark.java ! test/java/lang/instrument/PremainClass/NoPremainAgentTest.java ! test/java/lang/instrument/PremainClass/PremainClassTest.java ! test/java/lang/instrument/PremainClass/ZeroArgPremainAgentTest.java ! test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java ! test/java/lang/management/MemoryMXBean/LowMemoryTest.java ! test/java/net/URLPermission/nstest/lookup.sh ! test/javax/management/monitor/StartStopTest.java ! test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java ! test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java ! test/sun/tools/jcmd/TestJcmdDefaults.java ! test/sun/tools/jcmd/TestJcmdSanity.java ! test/sun/tools/jmap/BasicJMapTest.java ! test/sun/tools/jstack/BasicJStackTest.java Changeset: 35bbba418241 Author: yan Date: 2014-05-12 14:12 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/35bbba418241 8030709: Tidy warnings cleanup for java.lang package; minor cleanup in java.math, javax.script Reviewed-by: lancea Contributed-by: Alexander Stepanov ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/Runtime.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/instrument/package.html ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/management/MemoryNotificationInfo.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/package.html ! src/share/classes/java/math/BigInteger.java ! src/share/classes/javax/script/ScriptEngineFactory.java Changeset: fa4fc23cba16 Author: yan Date: 2014-05-12 14:33 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/fa4fc23cba16 8038795: Tidy warnings cleanup for javax.management Reviewed-by: dfuchs Contributed-by: Alexander Stepanov ! src/share/classes/javax/management/MBeanPermission.java ! src/share/classes/javax/management/MBeanServerPermission.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationBroadcaster.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfo.java ! src/share/classes/javax/management/openmbean/OpenMBeanConstructorInfo.java ! src/share/classes/javax/management/openmbean/OpenMBeanInfo.java ! src/share/classes/javax/management/openmbean/OpenMBeanOperationInfo.java ! src/share/classes/javax/management/openmbean/OpenMBeanParameterInfo.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/JMXPrincipal.java ! src/share/classes/javax/management/remote/package.html ! src/share/classes/javax/management/remote/rmi/package.html Changeset: 27e0909d3fa0 Author: plevart Date: 2014-05-12 17:34 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/27e0909d3fa0 8000975: (process) Merge UNIXProcess.java.bsd & UNIXProcess.java.linux (& .solaris & .aix) Reviewed-by: alanb, rriggs, martin ! make/gensrc/GensrcMisc.gmk + src/solaris/classes/java/lang/UNIXProcess.java - src/solaris/classes/java/lang/UNIXProcess.java.aix - src/solaris/classes/java/lang/UNIXProcess.java.bsd - src/solaris/classes/java/lang/UNIXProcess.java.linux - src/solaris/classes/java/lang/UNIXProcess.java.solaris ! test/java/lang/ProcessBuilder/SecurityManagerClinit.java Changeset: 013ac43d9800 Author: mullan Date: 2014-05-12 12:35 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/013ac43d9800 6996377: shrink duplicate code in the constructor of PKIXValidator Reviewed-by: mullan, xuelei Contributed-by: jamil.j.nimeh at oracle.com ! src/share/classes/sun/security/validator/PKIXValidator.java + test/sun/security/validator/ConstructorTest.java Changeset: 97487e77f598 Author: alanb Date: 2014-05-13 11:03 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/97487e77f598 8042889: (props) Properties.loadFromXML/storeToXML should consistently use the UKit parser Reviewed-by: joehw, chegar, mchung ! make/profile-rtjar-includes.txt ! src/share/classes/java/util/Properties.java - src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java - src/share/classes/sun/util/spi/XmlPropertiesProvider.java - src/share/classes/sun/util/xml/META-INF/services/sun.util.spi.XmlPropertiesProvider - src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java ! test/java/util/Properties/CompatibilityTest.java ! test/java/util/Properties/ConcurrentLoadAndStoreXML.java - test/java/util/Properties/CustomProvider.java ! test/java/util/Properties/LoadAndStoreXML.java ! test/java/util/Properties/LoadAndStoreXMLWithDefaults.java - test/java/util/Properties/MyXmlPropertiesProvider.java Changeset: b5fe9c840818 Author: michaelm Date: 2014-05-14 11:16 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b5fe9c840818 8034170: src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java + test/java/net/Authenticator/B8034170.java Changeset: d7a42bf19905 Author: alanb Date: 2014-05-14 16:40 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d7a42bf19905 8043119: (props) Properties.storeToXML closes output stream Reviewed-by: lancea ! src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java ! test/java/util/Properties/LoadAndStoreXML.java Changeset: 6d8b6c20a32b Author: naoto Date: 2014-05-14 10:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6d8b6c20a32b 8041791: String.toLowerCase regression - violates Unicode standard Reviewed-by: peytoia ! src/share/classes/java/lang/ConditionalSpecialCasing.java ! src/share/classes/java/lang/String.java ! test/java/lang/String/ToLowerCase.java Changeset: 66c497c6d8ef Author: wmdietl Date: 2014-05-14 19:50 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/66c497c6d8ef Automated merge with http://hg.openjdk.java.net/jdk9/dev/jdk ! .hgtags ! make/CompileJavaClasses.gmk ! make/gensrc/GensrcMisc.gmk ! src/share/classes/java/lang/ConditionalSpecialCasing.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/solaris/classes/java/lang/UNIXProcess.java ! test/java/lang/String/ToLowerCase.java ! test/lib/security/java.policy/Ext_AllPolicy.sh From wdietl at gmail.com Thu May 15 00:08:48 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 15 May 2014 00:08:48 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 53 new changesets Message-ID: <201405150009.s4F09gvm000568@aojmv0008> Changeset: 8c3dc205ab2b Author: katleman Date: 2014-05-08 01:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/8c3dc205ab2b Added tag jdk9-b12 for changeset 1c383bb39e28 ! .hgtags Changeset: 456ad9c99133 Author: lana Date: 2014-05-08 15:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/456ad9c99133 Merge - make/hotspot_version Changeset: 9f916a62b252 Author: anoll Date: 2014-04-24 09:47 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9f916a62b252 8041468: Field nmethod::_lock_count should be declared volatile Summary: The jint field nmethod::_lock_count which is used in nmethodLocker::lock_nmethod and nmethodLocker::unlock_nmethod should be declared volatile (see also signature of Atomic::inc) Reviewed-by: kvn, roland Contributed-by: Tobias Hartmann ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: e9bd2a761882 Author: roland Date: 2014-04-24 11:05 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e9bd2a761882 8039960: Unexpected exit from test compiler/profiling/spectrapredefineclass/Launcher.java Summary: the test case doesn't need to change the heap size to reproduce the failure. Reviewed-by: twisti, kvn ! test/compiler/profiling/spectrapredefineclass/Agent.java ! test/compiler/profiling/spectrapredefineclass/Launcher.java Changeset: 1420e44e390b Author: iignatyev Date: 2014-04-24 14:02 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1420e44e390b 8041497: Compilation of compiler/rtm/cli/TestUseRTMDeoptOption* tests failed Reviewed-by: kvn, roland ! test/compiler/rtm/cli/TestUseRTMDeoptOptionOnSupportedConfig.java ! test/compiler/rtm/cli/TestUseRTMDeoptOptionOnUnsupportedConfig.java Changeset: a123d95f638f Author: iignatyev Date: 2014-04-24 10:32 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a123d95f638f Merge Changeset: a35e424a76a4 Author: roland Date: 2014-04-25 09:22 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a35e424a76a4 8041481: JVM crashes with collect_args_for_profiling Summary: method handle call to c1 intrinsic tries to profile popped argument Reviewed-by: kvn, twisti ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp + test/compiler/profiling/TestMethodHandleInvokesIntrinsic.java Changeset: 6a81ae43d3a3 Author: adlertz Date: 2014-04-25 12:48 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/6a81ae43d3a3 8029302: Performance regression in Math.pow intrinsic Summary: Added special case for x^y where y == 2 Reviewed-by: kvn, roland ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/opto/library_call.cpp Changeset: d3dff66800f3 Author: bharadwaj Date: 2014-04-25 14:29 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/d3dff66800f3 Merge Changeset: ccbe4f8119b6 Author: anoll Date: 2014-04-28 12:39 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ccbe4f8119b6 8040085: dtrace/jsdt tests crash on solaris. found an unadvertised bad scavengable oop in the code cache Summary: Add CodeCache::add_scavenge_root_nmethod(this) to the dtrace-constructor of nmethod Reviewed-by: roland, iveresov ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 590c234f1f5e Author: anoll Date: 2014-04-28 03:44 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/590c234f1f5e Merge ! src/share/vm/code/nmethod.cpp - test/runtime/6925573/SortMethodsTest.java Changeset: 0b46bc08ff09 Author: anoll Date: 2014-04-28 14:34 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/0b46bc08ff09 8041771: C1: remove unused IR::_locals_size Summary: The unused IR::_locals_size is removed. Reviewed-by: kvn, roland Contributed-by: Tobias Hartmann ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp Changeset: cbb70f720ddb Author: drchase Date: 2014-04-28 15:09 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/cbb70f720ddb 8039407: Regression test needed for JDK-8015396 Summary: Converted bug demo into regression test Reviewed-by: kvn + test/compiler/floatingpoint/ModNaN.java Changeset: 401efd13b064 Author: morris Date: 2014-04-28 16:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/401efd13b064 8040919: Uninitialised memory in hotspot/src/share/vm/compiler/oopMap.cpp Summary: Parfait refactoring in OopMapSet::update_register_map Reviewed-by: kvn, twisti ! src/share/vm/compiler/oopMap.cpp Changeset: 48c15b47a4f1 Author: anoll Date: 2014-04-29 07:59 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/48c15b47a4f1 8040798: compiler/startup/SmallCodeCacheStartup.java timed out in RT_Baseline Summary: Fixes broken memory freeing of compile queue tasks and makes sure that blocking compiles do not hang the VM if compilation gets disabled due to a full code cache. Reviewed-by: kvn, iveresov ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: d02dbc95b60b Author: anoll Date: 2014-04-29 08:08 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/d02dbc95b60b 8036956: remove EnableInvokeDynamic flag Summary: The EnableInvokeDynamic flag and all support code is removed because it is not longer used in JDK 9. Reviewed-by: kvn, twisti Contributed-by: Tobias Hartmann ! src/cpu/ppc/vm/cppInterpreter_ppc.cpp ! src/cpu/ppc/vm/interp_masm_ppc_64.cpp ! src/cpu/ppc/vm/templateTable_ppc_64.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciObject.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/bytecodes.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: 790cbd800fe4 Author: anoll Date: 2014-04-29 07:14 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/790cbd800fe4 Merge Changeset: 4f0ae81062fd Author: kvn Date: 2014-04-29 10:29 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/4f0ae81062fd 8041959: Skip replay parsing errors with ReplayIgnoreInitErrors Summary: Allow replay compilation with replay file parsing error. Reviewed-by: twisti, iveresov ! src/share/vm/ci/ciReplay.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: 9883c95f17f6 Author: kvn Date: 2014-04-29 12:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9883c95f17f6 8041957: -XX:UseAVX=0 cause assert(UseAVX) failed Summary: temporary set UseAVX=1 and UseSSE=2 in generate_get_cpu_info() Reviewed-by: twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/vm_version_x86.cpp Changeset: e3a56821c4e3 Author: mikael Date: 2014-04-29 22:04 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e3a56821c4e3 8022070: Compilation error in stubGenerator_sparc.cpp with some compilers Reviewed-by: twisti, kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp Changeset: c884ec3ea87f Author: mikael Date: 2014-04-29 22:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c884ec3ea87f 8042059: Various fixes to linux/sparc Reviewed-by: twisti, kvn ! agent/src/os/linux/libproc.h ! src/cpu/sparc/vm/frame_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.inline.hpp ! src/os_cpu/linux_sparc/vm/atomic_linux_sparc.inline.hpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp Changeset: 7c68337bb685 Author: kvn Date: 2014-04-30 14:14 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/7c68337bb685 8035936: SIGBUS in StubRoutines::aesencryptBlock, solaris-sparc Summary: Fix the arbitrary alignment issue in SPARC AES crypto stub routines. Reviewed-by: kvn, iveresov Contributed-by: shrinivas.joshi at oracle.com ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.hpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/runtime.cpp ! test/compiler/7184394/TestAESBase.java ! test/compiler/7184394/TestAESDecode.java ! test/compiler/7184394/TestAESEncode.java ! test/compiler/7184394/TestAESMain.java Changeset: ae70708e34c5 Author: kvn Date: 2014-05-01 17:57 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ae70708e34c5 8042281: compiler/7184394/TestAESMain.java fails with: javax.crypto.IllegalBlockSizeException: Input length not multiple of 16 bytes Summary: Added missing -DmsgSize=640 to test's run commands. Reviewed-by: kvn Contributed-by: shrinivas.joshi at oracle.com ! test/compiler/7184394/TestAESMain.java Changeset: 5edc16b659dd Author: twisti Date: 2014-05-02 19:00 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5edc16b659dd Merge - make/hotspot_version ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: cdc3ba20b08f Author: zgu Date: 2014-05-01 05:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/cdc3ba20b08f 6885993: Named Thread: introduce print() and print_on(outputStream* st) methods Summary: Eliminating duplicated code by introducing print_on(outputStream* st) methods in NamedThread Reviewed-by: twisti, coleenp, dholmes ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp ! src/share/vm/gc_implementation/g1/g1StringDedupThread.cpp ! src/share/vm/gc_implementation/g1/g1StringDedupThread.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp Changeset: bcf479da3ce5 Author: dcubed Date: 2014-05-02 11:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/bcf479da3ce5 Merge Changeset: af53a220ea60 Author: sla Date: 2014-05-05 20:17 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/af53a220ea60 8031126: java/lang/management/ThreadMXBean/ThreadUserTime.java fails intermittently Reviewed-by: coleenp, simonis, goetz, gthornbr ! src/os/linux/vm/os_linux.cpp Changeset: 003c36658224 Author: coleenp Date: 2014-05-05 19:53 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/003c36658224 8023697: failed class resolution reports different class name in detail message for the first and subsequent times Summary: Cache detail message when we cache exception for constant pool resolution. Reviewed-by: acorn, twisti, jrose ! src/share/vm/classfile/resolutionErrors.cpp ! src/share/vm/classfile/resolutionErrors.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/utilities/constantTag.cpp ! src/share/vm/utilities/constantTag.hpp + test/runtime/ClassResolutionFail/Property.java + test/runtime/ClassResolutionFail/PropertySuper.java + test/runtime/ClassResolutionFail/TestClassResolutionFail.java Changeset: e7a6a3354c84 Author: lfoltan Date: 2014-05-06 08:59 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e7a6a3354c84 8041627: Solaris Studio 12.4 C++ 5.13 compilation error due to lack of "surplus" prototype for binaryTreeDictionary.cpp. Summary: Fix C++ compilation error diagnostic for the call of "surplus" within get_better_list() method. Reviewed-by: coleenp, dholmes ! src/share/vm/memory/binaryTreeDictionary.cpp Changeset: 21130eb5768d Author: lfoltan Date: 2014-05-06 09:56 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/21130eb5768d 8041620: Solaris Studio 12.4 C++ 5.13 change in behavior for placing friend declarations within surrounding scope. Summary: Remove adlc's unused class FileBuffRegion. Reviewed-by: coleenp, dholmes, kvn ! src/share/vm/adlc/filebuff.cpp ! src/share/vm/adlc/filebuff.hpp Changeset: dd10307aad9d Author: coleenp Date: 2014-05-07 18:19 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/dd10307aad9d Merge ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/runtime/thread.cpp Changeset: c6d29f2731d5 Author: anoll Date: 2014-05-02 06:24 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c6d29f2731d5 8041992: Fix of JDK-8034775 neglects to account for non-JIT VMs Summary: Allow 0 compiler threads if no JIT is used. Reviewed-by: kvn, dholmes Contributed-by: Severin Gehwolf ! src/share/vm/runtime/arguments.cpp ! test/compiler/startup/NumCompilerThreadsCheck.java Changeset: d54237e9d713 Author: anoll Date: 2014-05-01 21:30 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/d54237e9d713 Merge Changeset: 477b5a69ee6d Author: iignatyev Date: 2014-05-02 13:20 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/477b5a69ee6d 8042214: add @ignore tag to all excluded jtreg tests in test/compiler Reviewed-by: kvn, ctornqvi ! test/compiler/5091921/Test7005594.java ! test/compiler/7052494/Test7052494.java ! test/compiler/ciReplay/TestVM.sh ! test/compiler/ciReplay/TestVM_no_comp_level.sh Changeset: 802d8115b5f1 Author: iignatyev Date: 2014-05-02 09:30 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/802d8115b5f1 Merge Changeset: bd1a985905ed Author: kvn Date: 2014-05-02 16:44 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/bd1a985905ed 8039298: assert(base == NULL || t_adr->isa_rawptr() || !phase->type(base)->higher_equal(TypePtr::NULL_PTR)) Summary: Convert the assert into the runtime check to skip IGVN optimizations for problematic memory nodes. Eliminate dead nodes more aggressively. Reviewed-by: twisti, iveresov ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/node.cpp Changeset: c41037fab04f Author: twisti Date: 2014-05-02 19:10 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c41037fab04f Merge Changeset: 3e1b9ea326fa Author: anoll Date: 2014-05-05 15:10 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3e1b9ea326fa 8042052: assert(t != NULL) failed: must set before get Summary: Added missing call to _gvn.transform to make sure the type of the PhiNode is recorded in the gvn. Reviewed-by: kvn Contributed-by: Tobias Hartmann ! src/share/vm/opto/library_call.cpp Changeset: 446bb44e5367 Author: anoll Date: 2014-05-06 09:17 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/446bb44e5367 8036851: volatile double accesses are not explicitly atomic in C2 Summary: The C2 structure is adapted to distinguish between volatile and non-volatile double accesses. Reviewed-by: twisti, kvn Contributed-by: Tobias Hartmann ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: 6786f914240e Author: anoll Date: 2014-05-06 09:52 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/6786f914240e 8042428: CompileQueue::free_all() code is incorrect Summary: Free task after getting next pointer of freelist. Reviewed-by: kvn, adlertz ! src/share/vm/compiler/compileBroker.cpp Changeset: 15b2bb6fd673 Author: anoll Date: 2014-05-06 08:01 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/15b2bb6fd673 Merge Changeset: 9433721e2340 Author: anoll Date: 2014-05-06 13:08 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9433721e2340 8042443: Fix C++-Interpreter after "8036956: remove EnableInvokeDynamic flag" Summary: Insert missing bracket to make the interpreter build again Reviewed-by: sla Contributed-by: Volker Simonis ! src/share/vm/interpreter/bytecodeInterpreter.cpp Changeset: b5e1deb7279e Author: goetz Date: 2014-05-02 14:53 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b5e1deb7279e 8042309: Some bugfixes for the ppc64 port. Reviewed-by: kvn ! src/cpu/ppc/vm/cppInterpreter_ppc.cpp ! src/cpu/ppc/vm/frame_ppc.inline.hpp ! src/cpu/ppc/vm/interp_masm_ppc_64.hpp ! src/cpu/ppc/vm/interpreterRT_ppc.cpp ! src/cpu/ppc/vm/interpreter_ppc.cpp ! src/cpu/ppc/vm/jniFastGetField_ppc.cpp ! src/cpu/ppc/vm/ppc.ad ! src/cpu/ppc/vm/templateInterpreter_ppc.cpp ! src/cpu/ppc/vm/templateTable_ppc_64.cpp ! src/os_cpu/linux_ppc/vm/atomic_linux_ppc.inline.hpp Changeset: 8fddb780f3a7 Author: anoll Date: 2014-05-07 22:06 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/8fddb780f3a7 8042570: Excessive number of tests timing out on nightly testing due to fix for 8040798 Summary: Remove unnecessary lock in CompileBroker::mark_on_stack() that causes the deadlock Reviewed-by: kvn, dcubed ! src/share/vm/compiler/compileBroker.cpp Changeset: 2377269bd73d Author: goetz Date: 2014-04-29 15:17 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/2377269bd73d 8042195: Introduce umbrella header orderAccess.inline.hpp. Reviewed-by: dholmes, kvn, stefank, twisti ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/os/aix/vm/os_aix.cpp ! src/os/aix/vm/os_aix.inline.hpp ! src/os/aix/vm/thread_aix.inline.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/bsd/vm/thread_bsd.inline.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/linux/vm/thread_linux.inline.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/solaris/vm/thread_solaris.inline.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.inline.hpp ! src/os/windows/vm/thread_windows.inline.hpp ! src/os_cpu/aix_ppc/vm/atomic_aix_ppc.inline.hpp ! src/os_cpu/linux_ppc/vm/atomic_linux_ppc.inline.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1AllocRegion.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/space.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/prims/forte.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiRawMonitor.cpp ! src/share/vm/prims/jvmtiThreadState.inline.hpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/fprofiler.cpp ! src/share/vm/runtime/interfaceSupport.cpp ! src/share/vm/runtime/javaFrameAnchor.hpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/objectMonitor.cpp + src/share/vm/runtime/orderAccess.inline.hpp ! src/share/vm/runtime/perfMemory.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/thread.inline.hpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/memoryPool.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/utilities/array.hpp ! src/share/vm/utilities/hashtable.inline.hpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.cpp Changeset: 97356e139532 Author: twisti Date: 2014-05-08 15:08 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/97356e139532 Merge ! src/os/linux/vm/os_linux.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 8886a4bcaeaa Author: jwilhelm Date: 2014-04-29 22:57 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/8886a4bcaeaa 8027643: Merge GenCollectorPolicy and TwoGenerationCollectorPolicy Summary: Merged the two calsses GenCollectorPolicy and TwoGenerationCollectorPolicy Reviewed-by: sjohanss, jcoomes ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsCollectorPolicy.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.cpp ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/services/memoryService.cpp Changeset: 5549b26a0660 Author: jwilhelm Date: 2014-05-02 21:10 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5549b26a0660 Merge Changeset: 83dc9a7abcce Author: tschatzl Date: 2014-05-06 09:41 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/83dc9a7abcce 8026784: Error message in AdaptiveFreeList::verify_stats is wrong Summary: Changed faulty error message in the verification code Reviewed-by: stefank, tschatzl Contributed-by: Andreas Sjoberg ! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp Changeset: a5730e3dee96 Author: ehelin Date: 2014-03-19 17:04 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a5730e3dee96 8034094: SA agent can't compile when jni_x86.h is used Reviewed-by: dsamersoff, erikj ! src/cpu/x86/vm/jni_x86.h Changeset: 957ed38326bd Author: jmasa Date: 2014-05-08 18:22 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/957ed38326bd Merge ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: a7d16a7880ab Author: amurillo Date: 2014-05-09 08:34 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/a7d16a7880ab Merge Changeset: 4a9fc88453b8 Author: wmdietl Date: 2014-05-14 20:08 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/4a9fc88453b8 Automated merge with http://hg.openjdk.java.net/jdk9/dev/hotspot ! .hgtags ! src/share/vm/runtime/sharedRuntime.cpp From wdietl at gmail.com Thu May 15 00:19:08 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 15 May 2014 00:19:08 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 4 new changesets Message-ID: <201405150019.s4F0JBP3002030@aojmv0008> Changeset: ea95bb0346ac Author: katleman Date: 2014-05-08 01:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/ea95bb0346ac Added tag jdk9-b12 for changeset 282e9a675e07 ! .hgtags Changeset: be4580ae56e2 Author: lana Date: 2014-05-08 15:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/be4580ae56e2 Merge Changeset: 093df4def9a7 Author: sundar Date: 2014-05-14 19:01 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/093df4def9a7 8043132: Nashorn : all tests failed with java.security.AccessControlException Reviewed-by: jlaskey, attila ! make/build.xml Changeset: 947da3edd9d7 Author: wmdietl Date: 2014-05-14 20:18 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/947da3edd9d7 Automated merge with http://hg.openjdk.java.net/jdk9/dev/nashorn From wdietl at gmail.com Thu May 15 00:21:02 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Thu, 15 May 2014 00:21:02 +0000 Subject: hg: type-annotations/type-annotations/langtools: 17 new changesets Message-ID: <201405150021.s4F0LPRu002345@aojmv0008> Changeset: 955d619d42e6 Author: katleman Date: 2014-05-08 01:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/955d619d42e6 Added tag jdk9-b12 for changeset 72efbe612e49 ! .hgtags Changeset: 2c8bb81b5d48 Author: lana Date: 2014-05-08 15:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/2c8bb81b5d48 Merge Changeset: da8d9f8995d1 Author: jlahoda Date: 2014-05-09 09:36 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/da8d9f8995d1 8040822: Duplicated notifications can be sent to TaskListener Summary: The analyze finished event must only be sent on the first call to JavaCompiler.flow for a given class. Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/api/taskListeners/EventsBalancedTest.java Changeset: dfd281a9c6bf Author: jlahoda Date: 2014-05-09 12:55 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/dfd281a9c6bf 8041663: Sensitive dependence on location of nested interface Summary: Adding a method among ambiguous candidates only if it is more specific than some of the existing candidates. Reviewed-by: dlsmith, vromero ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/resolve/AmbiguityErrorTest.java Changeset: 28ff3e6247b6 Author: ksrini Date: 2014-05-08 08:23 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/28ff3e6247b6 8042601: Javadoc sort fails Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! test/com/sun/javadoc/testOrdering/TestOrdering.java ! test/com/sun/javadoc/testOrdering/pkg1/UsedClass.java ! test/com/sun/javadoc/testOrdering/pkg1/ZZTop.java Changeset: 228659ae84f3 Author: jjg Date: 2014-05-09 08:52 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/228659ae84f3 8042839: XPreferTest fails on Windows Reviewed-by: vromero ! test/tools/javac/options/xprefer/XPreferTest.java Changeset: 1472e30d4a7b Author: emc Date: 2014-05-09 09:28 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/1472e30d4a7b 8040327: Eliminate AnnotatedType Summary: Replace AnnotatedType with type annotations being stored in the Type class as metadata Reviewed-by: jjg, jfranck, wmdietl, jlahoda ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/jvm/UninitializedType.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java ! test/tools/javac/types/TypeHarness.java Changeset: e5d0d7510671 Author: dlsmith Date: 2014-05-09 14:56 -0600 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e5d0d7510671 8042656: Inference produces spurious error for intersection type bounds check Summary: Fix subtyping for intersections involving capture variables Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/typevars/IntersectionSubVar.java Changeset: 7e5918873ba1 Author: jlahoda Date: 2014-05-09 23:31 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/7e5918873ba1 8042867: Missing license header for langtools/make/netbeans/langtools/nbproject/project.properties Reviewed-by: ksrini ! make/netbeans/langtools/nbproject/project.properties Changeset: 94aca852a4d0 Author: jjg Date: 2014-05-09 15:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/94aca852a4d0 8038730: Clean up the way JavadocTester is invoked, and checks for errors. Reviewed-by: ksrini, sogoel, bpatel ! test/com/sun/javadoc/5093723/T5093723.java ! test/com/sun/javadoc/AccessAsciiArt/AccessAsciiArt.java ! test/com/sun/javadoc/AccessFrameTitle/AccessFrameTitle.java ! test/com/sun/javadoc/AccessH1/AccessH1.java ! test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java ! test/com/sun/javadoc/AccessSummary/AccessSummary.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/DocRootSlash/DocRootSlash.java ! test/com/sun/javadoc/InheritDocForUserTags/DocTest.java ! test/com/sun/javadoc/JavascriptWinTitle/JavascriptWinTitle.java ! test/com/sun/javadoc/MetaTag/MetaTag.java ! test/com/sun/javadoc/PackagesHeader/PackagesHeader.java ! test/com/sun/javadoc/T6735320/T6735320.java ! test/com/sun/javadoc/ValidHtml/ValidHtml.java ! test/com/sun/javadoc/VersionNumber/VersionNumber.java ! test/com/sun/javadoc/WindowTitles/WindowTitles.java ! test/com/sun/javadoc/constantValues/TestConstantValuesDriver.java ! test/com/sun/javadoc/dupThrowsTags/TestDupThrowsTags.java ! test/com/sun/javadoc/lib/JavadocTester.java ! test/com/sun/javadoc/testAbsLinkPath/TestAbsLinkPath.java ! test/com/sun/javadoc/testAbstractMethod/TestAbstractMethod.java ! test/com/sun/javadoc/testAnchorNames/TestAnchorNames.java ! test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java ! test/com/sun/javadoc/testAnnotationTypes/TestAnnotationTypes.java ! test/com/sun/javadoc/testBackSlashInLink/TestBackSlashInLink.java ! test/com/sun/javadoc/testBadPackageFileInJar/TestBadPackageFileInJar.java ! test/com/sun/javadoc/testBadSourceFile/TestBadSourceFile.java ! test/com/sun/javadoc/testBaseClass/TestBaseClass.java ! test/com/sun/javadoc/testBreakIterator/TestBreakIterator.java ! test/com/sun/javadoc/testCRLineSeparator/TestCRLineSeparator.java ! test/com/sun/javadoc/testCharset/TestCharset.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testClassTree/TestClassTree.java ! test/com/sun/javadoc/testCmndLineClass/TestCmndLineClass.java ! test/com/sun/javadoc/testCompletionFailure/TestCompletionFailure.java ! test/com/sun/javadoc/testConstantValuesPage/TestConstantValuesPage.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testConstructors/TestConstructors.java ! test/com/sun/javadoc/testCustomTag/TestCustomTag.java ! test/com/sun/javadoc/testDeprecatedDocs/TestDeprecatedDocs.java ! test/com/sun/javadoc/testDocEncoding/TestDocEncoding.java ! test/com/sun/javadoc/testDocErrorReporter/TestDocErrorReporter.java ! test/com/sun/javadoc/testDocFileDir/TestDocFileDir.java ! test/com/sun/javadoc/testDocFiles/TestDocFiles.java ! test/com/sun/javadoc/testDocRootInlineTag/TestDocRootInlineTag.java ! test/com/sun/javadoc/testDocRootLink/TestDocRootLink.java ! test/com/sun/javadoc/testDupParamWarn/TestDupParamWarn.java ! test/com/sun/javadoc/testEmptyClass/TestEmptyClass.java ! test/com/sun/javadoc/testEnclosingClass/TestEnclosingClass.java ! test/com/sun/javadoc/testEncoding/TestEncoding.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testGeneratedBy/TestGeneratedBy.java ! test/com/sun/javadoc/testGroupOption/TestGroupOption.java ! test/com/sun/javadoc/testHeadings/TestHeadings.java ! test/com/sun/javadoc/testHelpFile/TestHelpFile.java ! test/com/sun/javadoc/testHelpOption/TestHelpOption.java ! test/com/sun/javadoc/testHiddenMembers/TestHiddenMembers.java ! test/com/sun/javadoc/testHref/TestHref.java ! test/com/sun/javadoc/testHrefInDocComment/TestHrefInDocComment.java ! test/com/sun/javadoc/testHtmlComments/TestHtmlComments.java ! test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java ! test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java ! test/com/sun/javadoc/testHtmlTableStyles/TestHtmlTableStyles.java ! test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java ! test/com/sun/javadoc/testHtmlTag/TestHtmlTag.java ! test/com/sun/javadoc/testIndentation/TestIndentation.java ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInlineLinkLabel/TestInlineLinkLabel.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavaFX/TestJavaFX.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java ! test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java ! test/com/sun/javadoc/testLeadingSpaces/LeadingSpaces.java ! test/com/sun/javadoc/testLegacyTaglet/TestLegacyTaglet.java ! test/com/sun/javadoc/testLinkOption/TestBadLinkOption.java ! test/com/sun/javadoc/testLinkOption/TestLinkOption.java ! test/com/sun/javadoc/testLinkOption/TestNewLineInLink.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLinkToSerialForm/TestLinkToSerialForm.java ! test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java ! test/com/sun/javadoc/testModifier/TestModifier.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java ! test/com/sun/javadoc/testNestedGenerics/TestNestedGenerics.java ! test/com/sun/javadoc/testNestedInlineTag/TestNestedInlineTag.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testNoPackagesFile/TestNoPackagesFile.java ! test/com/sun/javadoc/testNonFrameWarning/TestNonFrameWarning.java ! test/com/sun/javadoc/testNotifications/TestNotifications.java ! test/com/sun/javadoc/testOptions/TestOptions.java ! test/com/sun/javadoc/testOrdering/TestOrdering.java ! test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackageDeprecation/TestPackageDeprecation.java ! test/com/sun/javadoc/testPackagePage/TestPackagePage.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java ! test/com/sun/javadoc/testProfiles/TestProfilesConfiguration.java ! test/com/sun/javadoc/testRecurseSubPackages/TestRecurseSubPackages.java ! test/com/sun/javadoc/testRelativeLinks/TestRelativeLinks.java ! test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java ! test/com/sun/javadoc/testReturnTag/TestReturnTag.java ! test/com/sun/javadoc/testSeeTag/TestSeeTag.java ! test/com/sun/javadoc/testSerialVersionUID/TestSerialVersionUID.java ! test/com/sun/javadoc/testSerializedForm/TestSerializedForm.java ! test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java ! test/com/sun/javadoc/testSimpleTag/TestSimpleTag.java ! test/com/sun/javadoc/testSimpleTagExclude/TestSimpleTagExclude.java ! test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java ! test/com/sun/javadoc/testSinceTag/TestSinceTag.java ! test/com/sun/javadoc/testSingleQuotedLink/TestSingleQuotedLink.java ! test/com/sun/javadoc/testSourceTab/TestSourceTab.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java ! test/com/sun/javadoc/testSubTitle/TestSubTitle.java ! test/com/sun/javadoc/testSummaryHeading/TestSummaryHeading.java ! test/com/sun/javadoc/testSuperclassInSerialForm/TestSuperClassInSerialForm.java ! test/com/sun/javadoc/testSupplementary/TestSupplementary.java ! test/com/sun/javadoc/testTagHolderMethod/TestTagHolderMethod.java ! test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java ! test/com/sun/javadoc/testTagMisuse/TestTagMisuse.java ! test/com/sun/javadoc/testTagOutput/TestTagOutput.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/com/sun/javadoc/testThrowsHead/TestThrowsHead.java ! test/com/sun/javadoc/testThrowsInheritence/TestThrowsTagInheritence.java ! test/com/sun/javadoc/testThrowsTag/TestThrowsTag.java ! test/com/sun/javadoc/testTitleInHref/TestTitleInHref.java ! test/com/sun/javadoc/testTopOption/TestTopOption.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/testTypeParams/TestTypeParameters.java ! test/com/sun/javadoc/testUnnamedPackage/TestUnnamedPackage.java ! test/com/sun/javadoc/testUseOption/TestUseOption.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java ! test/com/sun/javadoc/testWarnBadParamNames/TestWarnBadParamNames.java ! test/com/sun/javadoc/testWarnings/TestWarnings.java ! test/com/sun/javadoc/testWindowTitle/TestWindowTitle.java ! test/com/sun/javadoc/testXOption/TestXOption.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java Changeset: 615a70db794b Author: vromero Date: 2014-05-10 00:46 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/615a70db794b 8037379: fix for JDK-8029569 doesn't cover all possible cases Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/T8029569/VarargsAmbiguityCrashTest.java ! test/tools/javac/T8029569/VarargsAmbiguityCrashTest.out Changeset: aa1236dbf865 Author: vromero Date: 2014-05-10 01:24 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/aa1236dbf865 8028503: javac, for method references a primitive type can be added as a bound Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/inference/T8028503/PrimitiveTypeInBoundForMethodRefTest.java ! test/tools/javac/lambda/MethodReference42.out ! test/tools/javac/lambda/MethodReference44.out Changeset: c1c2a5f9ba0c Author: jjg Date: 2014-05-09 18:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/c1c2a5f9ba0c 8042886: Test langtools/test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java fails on Windows Reviewed-by: darcy ! test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java Changeset: 9c2c24a6785d Author: emc Date: 2014-05-09 22:27 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/9c2c24a6785d 8035763: Error parsing binary type annotations data in javac Summary: Fix accidental reversal of read order from a previous change Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java Changeset: 4525f3a38730 Author: dlsmith Date: 2014-05-13 15:29 -0600 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/4525f3a38730 8034223: Most-specific should not have any special treatment for boxed vs. unboxed types Summary: Rewrite most-specific logic to conform to JLS 8 15.12.2.5 Reviewed-by: vromero ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/lambda/MostSpecific10.java + test/tools/javac/lambda/MostSpecific11.java + test/tools/javac/lambda/MostSpecific12.java + test/tools/javac/lambda/MostSpecific12.out + test/tools/javac/lambda/MostSpecific13.java + test/tools/javac/lambda/MostSpecific13.out + test/tools/javac/lambda/MostSpecific14.java + test/tools/javac/lambda/MostSpecific14.out ! test/tools/javac/lambda/TargetType16.java - test/tools/javac/lambda/TargetType16.out ! test/tools/javac/lambda/TargetType23.java ! test/tools/javac/lambda/TargetType23.out ! test/tools/javac/resolve/ResolveHarness.java ! test/tools/javac/resolve/tests/PrimitiveOverReferenceVarargsAmbiguous.java + test/tools/javac/resolve/tests/PrimitiveVsReferenceSamePhase.java Changeset: 464d69f73516 Author: dlsmith Date: 2014-05-13 15:34 -0600 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/464d69f73516 8042882: Support verbosity options in langtools testing 8032441: langtools/test/Makefile breaks when JT_JAVA set to a JDK 9 build Reviewed-by: mduigou ! test/Makefile Changeset: e885301fa1f2 Author: wmdietl Date: 2014-05-14 20:20 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e885301fa1f2 Automated merge with http://hg.openjdk.java.net/jdk9/dev/langtools ! .hgtags ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! test/com/sun/javadoc/AccessH1/AccessH1.java ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java ! test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java ! test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java ! test/tools/javac/annotations/typeAnnotations/referenceinfos/Driver.java From wdietl at gmail.com Sat May 17 13:59:20 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sat, 17 May 2014 13:59:20 +0000 Subject: hg: type-annotations/type-annotations: 4 new changesets Message-ID: <201405171359.s4HDxLdE026361@aojmv0008> Changeset: 4b3b50207ae3 Author: mduigou Date: 2014-05-14 16:45 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/4b3b50207ae3 8043182: hgforest.sh: syntax error on line 329 Reviewed-by: darcy ! common/bin/hgforest.sh Changeset: aa3bad45444a Author: katleman Date: 2014-05-15 10:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/aa3bad45444a Added tag jdk9-b13 for changeset 5800456add07 ! .hgtags Changeset: 4e3aa9723e99 Author: lana Date: 2014-05-15 10:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/4e3aa9723e99 Merge Changeset: 610aa377dda8 Author: wmdietl Date: 2014-05-17 09:59 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/610aa377dda8 Automated merge with http://hg.openjdk.java.net/jdk9/dev/ ! .hgtags From wdietl at gmail.com Sat May 17 14:00:52 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sat, 17 May 2014 14:00:52 +0000 Subject: hg: type-annotations/type-annotations/corba: 3 new changesets Message-ID: <201405171400.s4HE0r3i026555@aojmv0008> Changeset: a8950b108a74 Author: katleman Date: 2014-05-15 10:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/a8950b108a74 Added tag jdk9-b13 for changeset 088eec4c36f4 ! .hgtags Changeset: a2b82f863ba9 Author: lana Date: 2014-05-15 10:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/a2b82f863ba9 Merge Changeset: 74ff3dcb554f Author: wmdietl Date: 2014-05-17 10:00 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/74ff3dcb554f Automated merge with http://hg.openjdk.java.net/jdk9/dev/corba ! .hgtags From wdietl at gmail.com Sat May 17 14:02:50 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sat, 17 May 2014 14:02:50 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 2 new changesets Message-ID: <201405171402.s4HE2rPE026913@aojmv0008> Changeset: 32b3fc4bc737 Author: katleman Date: 2014-05-15 10:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/32b3fc4bc737 Added tag jdk9-b13 for changeset 5eaf717f6e36 ! .hgtags Changeset: eae9c2a85088 Author: wmdietl Date: 2014-05-17 10:02 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/eae9c2a85088 Automated merge with http://hg.openjdk.java.net/jdk9/dev/jaxp ! .hgtags From wdietl at gmail.com Sat May 17 14:05:51 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sat, 17 May 2014 14:05:51 +0000 Subject: hg: type-annotations/type-annotations/jaxws: 2 new changesets Message-ID: <201405171405.s4HE5ruu027731@aojmv0008> Changeset: 02e58850b706 Author: katleman Date: 2014-05-15 10:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/02e58850b706 Added tag jdk9-b13 for changeset 3d42204854c9 ! .hgtags Changeset: 853aa599ffe8 Author: wmdietl Date: 2014-05-17 10:05 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/853aa599ffe8 Automated merge with http://hg.openjdk.java.net/jdk9/dev/jaxws ! .hgtags From wdietl at gmail.com Sat May 17 14:07:54 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sat, 17 May 2014 14:07:54 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 3 new changesets Message-ID: <201405171407.s4HE7viW027920@aojmv0008> Changeset: 4ba78adea63f Author: katleman Date: 2014-05-15 10:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/4ba78adea63f Added tag jdk9-b13 for changeset be4580ae56e2 ! .hgtags Changeset: 806df06b6ac5 Author: lana Date: 2014-05-15 10:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/806df06b6ac5 Merge Changeset: 9867bfb4aa5b Author: wmdietl Date: 2014-05-17 10:07 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/9867bfb4aa5b Automated merge with http://hg.openjdk.java.net/jdk9/dev/nashorn From wdietl at gmail.com Sat May 17 14:25:50 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sat, 17 May 2014 14:25:50 +0000 Subject: hg: type-annotations/type-annotations/jdk: 10 new changesets Message-ID: <201405171426.s4HEQns8000243@aojmv0008> Changeset: 14eb478a5c4c Author: aefimov Date: 2014-05-15 18:18 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/14eb478a5c4c 8043012: (tz) Support tzdata2014c Reviewed-by: okutsu, peytoia ! make/data/tzdata/VERSION ! make/data/tzdata/africa ! make/data/tzdata/asia ! make/data/tzdata/europe ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/africa ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/europe Changeset: eb6f07ec4509 Author: chegar Date: 2014-05-14 15:46 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/eb6f07ec4509 7153400: ThreadPoolExecutor's setCorePoolSize method allows corePoolSize > maxPoolSize Reviewed-by: chegar, martin, mduigou Contributed-by: Pavel Rappo ! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java Changeset: b014e6e0b04d Author: katleman Date: 2014-05-15 10:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b014e6e0b04d Added tag jdk9-b13 for changeset c7c8002d0272 ! .hgtags Changeset: 5c7a17a81afd Author: lana Date: 2014-05-15 10:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5c7a17a81afd Merge - src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java - src/share/classes/sun/util/spi/XmlPropertiesProvider.java - src/share/classes/sun/util/xml/META-INF/services/sun.util.spi.XmlPropertiesProvider - src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java - src/solaris/classes/java/lang/UNIXProcess.java.aix - src/solaris/classes/java/lang/UNIXProcess.java.bsd - src/solaris/classes/java/lang/UNIXProcess.java.linux - src/solaris/classes/java/lang/UNIXProcess.java.solaris - test/java/util/Properties/CustomProvider.java - test/java/util/Properties/MyXmlPropertiesProvider.java Changeset: e2347ee6c0f2 Author: jfranck Date: 2014-05-12 14:47 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e2347ee6c0f2 8038994: AnnotatedType.getType() of a TypeVariable boundary without annotations return null Reviewed-by: psandoz ! src/share/classes/sun/reflect/annotation/TypeAnnotationParser.java + test/java/lang/annotation/TypeVariableBounds.java Changeset: 038f4771af6e Author: yan Date: 2014-05-16 17:41 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/038f4771af6e 8042120: Fix doclint warnings from javax.swing.text.html.parser Reviewed-by: alexsch Contributed-by: Alexander Stepanov ! src/share/classes/javax/swing/text/html/parser/AttributeList.java ! src/share/classes/javax/swing/text/html/parser/ContentModel.java ! src/share/classes/javax/swing/text/html/parser/DTD.java ! src/share/classes/javax/swing/text/html/parser/Element.java ! src/share/classes/javax/swing/text/html/parser/Parser.java Changeset: 320dd90143c2 Author: yan Date: 2014-05-16 17:45 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/320dd90143c2 8042089: Fix doclint warnings from javax.swing.tree and javax.swing.undo packages Reviewed-by: alexsch Contributed-by: Dmitriy Ermashov ! src/share/classes/javax/swing/tree/AbstractLayoutCache.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/javax/swing/tree/MutableTreeNode.java ! src/share/classes/javax/swing/tree/RowMapper.java ! src/share/classes/javax/swing/tree/TreeCellRenderer.java ! src/share/classes/javax/swing/tree/TreeModel.java ! src/share/classes/javax/swing/tree/TreeNode.java ! src/share/classes/javax/swing/tree/TreePath.java ! src/share/classes/javax/swing/tree/TreeSelectionModel.java ! src/share/classes/javax/swing/undo/CompoundEdit.java ! src/share/classes/javax/swing/undo/StateEditable.java ! src/share/classes/javax/swing/undo/UndoManager.java ! src/share/classes/javax/swing/undo/UndoableEditSupport.java Changeset: 2e2ffb5d33ff Author: twisti Date: 2014-05-16 09:20 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2e2ffb5d33ff 8032606: ClassValue.ClassValueMap.type is unused Reviewed-by: jrose, vlivanov ! src/share/classes/java/lang/ClassValue.java Changeset: 05b9fbd90083 Author: lancea Date: 2014-05-16 14:48 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/05b9fbd90083 8043278: Add initial unit tests for javax.sql.rowset.serial Reviewed-by: rriggs ! test/java/sql/util/BaseTest.java + test/javax/sql/testng/TEST.properties + test/javax/sql/testng/test/rowset/serial/SerialArrayTests.java + test/javax/sql/testng/test/rowset/serial/SerialBlobTests.java + test/javax/sql/testng/test/rowset/serial/SerialClobTests.java + test/javax/sql/testng/test/rowset/serial/SerialDataLinkTests.java + test/javax/sql/testng/test/rowset/serial/SerialExceptionTests.java + test/javax/sql/testng/test/rowset/serial/SerialJavaObjectTests.java + test/javax/sql/testng/test/rowset/serial/SerialRefTests.java + test/javax/sql/testng/test/rowset/serial/SerialStructTests.java + test/javax/sql/testng/util/BaseTest.java + test/javax/sql/testng/util/StubArray.java + test/javax/sql/testng/util/StubBlob.java + test/javax/sql/testng/util/StubClob.java + test/javax/sql/testng/util/StubRef.java + test/javax/sql/testng/util/StubStruct.java + test/javax/sql/testng/util/SuperHero.java Changeset: e927ac730a2f Author: wmdietl Date: 2014-05-17 10:21 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e927ac730a2f Automated merge with http://hg.openjdk.java.net/jdk9/dev/jdk ! .hgtags ! src/share/classes/javax/swing/tree/AbstractLayoutCache.java ! src/share/classes/javax/swing/tree/DefaultMutableTreeNode.java ! src/share/classes/javax/swing/tree/DefaultTreeCellEditor.java ! src/share/classes/javax/swing/tree/DefaultTreeCellRenderer.java ! src/share/classes/javax/swing/tree/DefaultTreeModel.java ! src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/share/classes/javax/swing/tree/TreePath.java ! src/share/classes/javax/swing/undo/UndoManager.java From wdietl at gmail.com Sat May 17 14:44:48 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sat, 17 May 2014 14:44:48 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 3 new changesets Message-ID: <201405171444.s4HEiq5W003153@aojmv0008> Changeset: 9b104882b5c7 Author: katleman Date: 2014-05-15 10:25 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9b104882b5c7 Added tag jdk9-b13 for changeset 456ad9c99133 ! .hgtags Changeset: bd333491bb6c Author: lana Date: 2014-05-15 10:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/bd333491bb6c Merge Changeset: bf64b7e7f9c7 Author: wmdietl Date: 2014-05-17 10:35 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/bf64b7e7f9c7 Automated merge with http://hg.openjdk.java.net/jdk9/dev/hotspot ! .hgtags From wdietl at gmail.com Sat May 17 14:54:36 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Sat, 17 May 2014 14:54:36 +0000 Subject: hg: type-annotations/type-annotations/langtools: 5 new changesets Message-ID: <201405171454.s4HEsi7Y004497@aojmv0008> Changeset: 69210df6b020 Author: katleman Date: 2014-05-15 10:26 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/69210df6b020 Added tag jdk9-b13 for changeset 2c8bb81b5d48 ! .hgtags Changeset: 1df3f53b9d98 Author: lana Date: 2014-05-15 10:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/1df3f53b9d98 Merge - test/tools/javac/lambda/TargetType16.out Changeset: d488132dbea7 Author: anazarov Date: 2014-05-12 17:09 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/d488132dbea7 8042771: Missing bug id in test/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java Reviewed-by: jjg ! test/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java Changeset: 4487f6f98252 Author: jlahoda Date: 2014-05-16 10:52 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/4487f6f98252 8043186: javac test langtools/tools/javac/util/StringUtilsTest.java fails Summary: The result of String.toLowerCase.indexOf does not always point at the start of the given string in the non-lowercased text. Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/javac/util/StringUtils.java ! test/com/sun/javadoc/testRelativeLinks/TestRelativeLinks.java ! test/com/sun/javadoc/testRelativeLinks/pkg/C.java ! test/com/sun/javadoc/testTopOption/TestTopOption.java ! test/tools/javac/util/StringUtilsTest.java Changeset: 51f48a6ab5f7 Author: wmdietl Date: 2014-05-17 10:54 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/51f48a6ab5f7 Automated merge with http://hg.openjdk.java.net/jdk9/dev/langtools ! .hgtags ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java From wdietl at gmail.com Mon May 19 06:21:19 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 19 May 2014 06:21:19 +0000 Subject: hg: type-annotations/type-annotations/langtools: 3 new changesets Message-ID: <201405190621.s4J6LQkH014396@aojmv0008> Changeset: e897d564e235 Author: wmdietl Date: 2014-05-19 02:20 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/e897d564e235 Update to compile with recent langtools changes. ! test/tools/javac/lib/DPrinter.java Changeset: 2a096f5666fd Author: jjg Date: 2014-05-18 19:59 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/2a096f5666fd 8041422: Split javac ClassReader into ClassReader+ClassFinder Reviewed-by: jfranck + src/share/classes/com/sun/tools/javac/code/ClassFinder.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java + src/share/classes/com/sun/tools/javadoc/JavadocClassFinder.java - src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! test/tools/javac/6330997/T6330997.java ! test/tools/javac/MethodParametersTest.java ! test/tools/javac/T6435291/T6435291.java ! test/tools/javac/defaultMethods/BadClassfile.java Changeset: a085f4d4ebd8 Author: wmdietl Date: 2014-05-19 02:21 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/a085f4d4ebd8 Automated merge with http://hg.openjdk.java.net/jdk9/dev/langtools ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java From wdietl at gmail.com Mon May 19 16:55:08 2014 From: wdietl at gmail.com (Werner Dietl) Date: Mon, 19 May 2014 12:55:08 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <536BEFBC.4080508@oracle.com> References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> Message-ID: Hi Eric, all, thanks for all your recent improvements to type annotations! I have integrated all jdk9 changes into type-annotations without any issue. I then updated the Checker Framework to the new API and all unit tests and running checkers on Daikon pass again. So things are looking good from my side. (I might still be using "deprecated" APIs though. Do you have an ETA for when the clean-up patch is going out?) Thanks for integrating the re-ordering fix with: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/9c2c24a6785d I think a reference to my original contribution from: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/7e9c983565ac would have been appropriate. In type-annotations, I made sure that the BasicAnnoTest at: test/tools/javac/processing/model/type/BasicAnnoTests.java compiles correctly. However, the generics/arrays/exceptions test cases at the end do not work yet. Is this something you are aware of? I thought one reason for your refactorings was exactly to make these tests work. There is one difference between jdk9 and type-annotations that is required for the Checker Framework to work: adding the "copy" method to com/sun/tools/javac/code/TypeAnnotationPosition.java. An alternative design would be to have factory methods that create new TAPs from an existing TAP, changing the position. Another difference that would make compatibility between jdk8 and jkd9 easier is if field "exception_index" remained public to allow direct access. A few tests in jdk9 are disabled, even though they pass in type-annotations. The other differences between jdk9 and type-annotations are small fixes to javadoc, performance, and imports. See my message from May 8 for details: http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-May/001722.html Are you working on integrating these changes? How can I help? Best regards, cu, WMD. On Thu, May 8, 2014 at 4:57 PM, Eric McCorkle wrote: > On 05/08/14 15:54, Werner Dietl wrote: >> Alex, all, >> >> thanks for this update. >> >> Type annotations in the jdk9 repo are currently broken for serious >> use. On Feb 7 I identified the invalid re-ordering performed in >> ClassReader: >> >> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-February/001592.html >> >> This problem still exists in jdk9 - the problematic changeset wasn't >> rolled back, nor was the fix applied. I have fixed this problem in >> type-annotations. >> I was waiting to hear an update on this before pursuing the other >> outstanding changes. > > I am aware of the fix that was pushed into the type annotations forest. > As we discussed when you developed the fix, I cannot push it into > jdk9-dev as-is, because the development practices of the langtools team > require that any changeset that introduces behavioral changes be > accompanied by a test. > > I will take care of the test this time, so that you can run checkers on > the contents of jdk9. However, in the future, we ask that patches > submitted against jdk9 conform to the langtools group's development > practices. > >> You say that after the new changes type-annotations will be seriously >> out of date. I don't see why this would be the case. I'm currently >> keeping type-annotations in sync with jdk9, making sure that the >> Checker Framework correctly works with type-annotations. Once these >> further refactorings go into jdk9, they should be easy to pull into >> type-annotations. > > I am posting a series of three (maybe just two) patches against jdk9, > which rearchitect a significant portion of the frontend implementation. > The end result is that it may not be trivial to rebase all the changes > you list below. > > >> All the interesting changes are against jdk9/langtools: >> >> - com/sun/tools/javac/code/TypeAnnotationPosition.java: >> I added a "copy" method to make it possible to create an updated >> TAP. Alternatively, constructors that give a new TAP with a changed >> location would be possible. A mechanism like this is required to allow >> the Checker Framework to build TAPs for defaulted locations. > > That sounds fine. Also, it shouldn't be affected by anything I'm doing. > >> One issue I run into is making the Checker Framework work with both >> JDK 8 and JDK 9 - the APIs for things like TAP changed significantly >> and I now need to access many things reflectively to correctly access >> the right API. One simple change I made was to make field >> "exception_index" public to allow direct access from JDK 8 and JDK 9. >> As the upcoming changes will require further changes in the Checker >> Framework, making this change is not necessary. > > My changes affect exception_index in nontrivial ways... I am now > storing catch-types and class ids, as well as exception indexes in a > private field. Exception indexes are accessed via a getter. > > However, this is a temporary measure. My tentative agenda for 8u40 is > to rework the way we do exception parameters and eliminate. > >> >> - com/sun/tools/javac/code/TypeAnnotations.java: initializes an >> Options object that is unused. I removed that code. > > Most if not all of TypeAnnotations.java is going away anyway. I've > moved most of the core functionality into Annotate. > >> - com/sun/tools/javac/comp/Check.java: the call to Assert.checkNonNull >> always constructs a toString of an annotation - this was slow and >> annoying when debugging some problems. Other uses of Assert also use >> simple error messages, so I adapted this one. > > A good change. We may actually want to file a blanket issue about this > as part of langtools code cleanup projects. > >> - com/sun/tools/javac/jvm/ClassReader.java: the jdk 9 code incorrectly >> reads the location of type annotations, which results in a compiler >> crash. type-annotations fixed this. > > Discussed above. > > (skipped a bunch that won't be affected by my work) > >> - test/tools/javac/annotations/typeAnnotations/failures/AnnotatedImport.java >> is being ignored in jdk9, even though it is working. Same for >> AnnotatedPackage1 and CantAnnotateStaticClass3. > > The positions patch will probably fix a few of the @ignore'd tests. So > I'd planned to go through, figure out what's working, and turn them back on. > > (The rest should be unaffected by my work) > >> How should I go about getting these changes into jdk9/jdk and jdk9/langtools? >> Is it enough to send the above descriptions to compiler-dev and point >> interested reviewers to a diff between the two repos? Should I attach >> a diff? > > I have three major patches planned: remove AnnotatedType, which is > already out for public review, the "positions patch", which is about to > be, and a patch to remove code obsoleted by the positions patch. > > Here's what I'll do: we want to get the first two in ASAP, but the third > is mostly for code cleanliness, and it may cause trouble rebasing some > of those changes. I'll hold off on the cleanup patch, and we'll look at > bringing the changes over after. > > As for the reorder fix, I will commit that to jdk9 (with a test) before > I commit the two major changes, so that you can run checkers with them. -- http://www.google.com/profiles/wdietl From eric.mccorkle at oracle.com Mon May 19 17:48:23 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Mon, 19 May 2014 13:48:23 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> Message-ID: <537A43E7.7000306@oracle.com> On 05/19/14 12:55, Werner Dietl wrote: > Hi Eric, all, > > thanks for all your recent improvements to type annotations! > I have integrated all jdk9 changes into type-annotations without any issue. > I then updated the Checker Framework to the new API and all unit tests > and running checkers on Daikon pass again. So things are looking good > from my side. > (I might still be using "deprecated" APIs though. Do you have an ETA > for when the clean-up patch is going out?) I could post the cleanup in diff form right now. The webrev script seems to include any outgoing changesets, so I can't post a "clean" webrev for it until the patch on which it depends goes in. > Thanks for integrating the re-ordering fix with: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/9c2c24a6785d > I think a reference to my original contribution from: > http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/7e9c983565ac > would have been appropriate. Of course; it is always my intention that the right people are attributed. I had copied your patch intending to write a test, but after investigation, we determined that a test can't really be written. The correct thing probably would have been to import your change directly, and that's what I would have done had I known ahead of time that writing a test wasn't feasible. That was an accident; however, I will update the JBS issue to reference your fix. > > In type-annotations, I made sure that the BasicAnnoTest at: > test/tools/javac/processing/model/type/BasicAnnoTests.java > compiles correctly. > However, the generics/arrays/exceptions test cases at the end do not work yet. > Is this something you are aware of? I thought one reason for your > refactorings was exactly to make these tests work. It seems that DPrinter has gotten out of date, due to a few fixes that have changed the internal data structures. Among these are a fix that refactors the top-level nodes, and my fix that eliminates AnnotatedType. If you've fixed all (or even some) of these issues, I'll gladly integrate your changes. > > There is one difference between jdk9 and type-annotations that is > required for the Checker Framework to work: > adding the "copy" method to > com/sun/tools/javac/code/TypeAnnotationPosition.java. An alternative > design would be to have factory methods that create new TAPs from an > existing TAP, changing the position. I think I like the factory approach better, as it's more in line with the way we've evolved the TypeAnnotationPosition API. I will file an RFE to add it. > Another difference that would make compatibility between jdk8 and jkd9 > easier is if field "exception_index" remained public to allow direct > access. Unfortunately, I think that's less feasible. The exception_index field currently gets used to store both exception indexes, as well as a combination of catch info and source positions. Because the formatting for this is nontrivial, and we have plans to eliminate it in the future, exception_index was made private and accessible through getters and setters. I would, however, be willing to add an updateExceptionIndex, which would allow you to change the index after it has already been set. > A few tests in jdk9 are disabled, even though they pass in type-annotations. > The other differences between jdk9 and type-annotations are small > fixes to javadoc, performance, and imports. > See my message from May 8 for details: > http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-May/001722.html More tests are being re-enabled in the cleanup patch. I am currently looking into the javadoc tests as well. As for the other fixes, I think I would like to get the two big patches (the rearchitecting patch and the cleanup patch) integrated, then look at them one-by-one. -------------- next part -------------- A non-text attachment was scrubbed... Name: eric_mccorkle.vcf Type: text/x-vcard Size: 314 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 901 bytes Desc: OpenPGP digital signature URL: From wdietl at gmail.com Mon May 19 21:17:50 2014 From: wdietl at gmail.com (Werner Dietl) Date: Mon, 19 May 2014 17:17:50 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <537A43E7.7000306@oracle.com> References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> <537A43E7.7000306@oracle.com> Message-ID: >> In type-annotations, I made sure that the BasicAnnoTest at: >> test/tools/javac/processing/model/type/BasicAnnoTests.java >> compiles correctly. >> However, the generics/arrays/exceptions test cases at the end do not work yet. >> Is this something you are aware of? I thought one reason for your >> refactorings was exactly to make these tests work. > > It seems that DPrinter has gotten out of date, due to a few fixes that > have changed the internal data structures. Among these are a fix that > refactors the top-level nodes, and my fix that eliminates AnnotatedType. > > If you've fixed all (or even some) of these issues, I'll gladly > integrate your changes. The type-annotations repo contains a fixed DPrinter and I've kept it up-to-date through all recent refactorings. I haven't fixed the BasicAnnoTests, as my understanding was that fixing these tests is one reason for your refactorings. >> Another difference that would make compatibility between jdk8 and jkd9 >> easier is if field "exception_index" remained public to allow direct >> access. > > Unfortunately, I think that's less feasible. The exception_index field > currently gets used to store both exception indexes, as well as a > combination of catch info and source positions. Because the formatting > for this is nontrivial, and we have plans to eliminate it in the future, > exception_index was made private and accessible through getters and setters. > > I would, however, be willing to add an updateExceptionIndex, which would > allow you to change the index after it has already been set. I have two use cases: create a new TAP from an existing TAP and comparing two TAPs for equality. For either one, I don't care what the underlying interpretation of the ints is, I just need to copy/compare them. One of our goals is to keep the Checker Framework running with the standard Java 8 compiler. I already perform quite a few TAP things reflectively to achieve this. I can do the same with the exception_index field, its just yet another complication that gets introduced. >> A few tests in jdk9 are disabled, even though they pass in type-annotations. >> The other differences between jdk9 and type-annotations are small >> fixes to javadoc, performance, and imports. >> See my message from May 8 for details: >> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-May/001722.html > > More tests are being re-enabled in the cleanup patch. I am currently > looking into the javadoc tests as well. As for the other fixes, I think > I would like to get the two big patches (the rearchitecting patch and > the cleanup patch) integrated, then look at them one-by-one. Ok, please do let me know if I can help. I would like to get all useful changes from type-annotations into jdk9 so that we can ideally close type-annotations in a state that exactly matches jdk9. Thanks, cu, WMD. -- http://www.google.com/profiles/wdietl From jonathan.gibbons at oracle.com Mon May 19 23:49:47 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 19 May 2014 16:49:47 -0700 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> <537A43E7.7000306@oracle.com> Message-ID: <537A989B.8080506@oracle.com> On 05/19/2014 02:17 PM, Werner Dietl wrote: >>> In type-annotations, I made sure that the BasicAnnoTest at: >>> test/tools/javac/processing/model/type/BasicAnnoTests.java >>> compiles correctly. >>> However, the generics/arrays/exceptions test cases at the end do not work yet. >>> Is this something you are aware of? I thought one reason for your >>> refactorings was exactly to make these tests work. >> It seems that DPrinter has gotten out of date, due to a few fixes that >> have changed the internal data structures. Among these are a fix that >> refactors the top-level nodes, and my fix that eliminates AnnotatedType. >> >> If you've fixed all (or even some) of these issues, I'll gladly >> integrate your changes. > The type-annotations repo contains a fixed DPrinter and I've kept it > up-to-date through all recent refactorings. > > I haven't fixed the BasicAnnoTests, as my understanding was that > fixing these tests is one reason for your refactorings. > > >>> Another difference that would make compatibility between jdk8 and jkd9 >>> easier is if field "exception_index" remained public to allow direct >>> access. >> Unfortunately, I think that's less feasible. The exception_index field >> currently gets used to store both exception indexes, as well as a >> combination of catch info and source positions. Because the formatting >> for this is nontrivial, and we have plans to eliminate it in the future, >> exception_index was made private and accessible through getters and setters. >> >> I would, however, be willing to add an updateExceptionIndex, which would >> allow you to change the index after it has already been set. > I have two use cases: create a new TAP from an existing TAP and > comparing two TAPs for equality. > For either one, I don't care what the underlying interpretation of the > ints is, I just need to copy/compare them. > > One of our goals is to keep the Checker Framework running with the > standard Java 8 compiler. I already perform quite a few TAP things > reflectively to achieve this. I can do the same with the > exception_index field, its just yet another complication that gets > introduced. > > >>> A few tests in jdk9 are disabled, even though they pass in type-annotations. >>> The other differences between jdk9 and type-annotations are small >>> fixes to javadoc, performance, and imports. >>> See my message from May 8 for details: >>> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-May/001722.html >> More tests are being re-enabled in the cleanup patch. I am currently >> looking into the javadoc tests as well. As for the other fixes, I think >> I would like to get the two big patches (the rearchitecting patch and >> the cleanup patch) integrated, then look at them one-by-one. > Ok, please do let me know if I can help. > I would like to get all useful changes from type-annotations into jdk9 > so that we can ideally close type-annotations in a state that exactly > matches jdk9. > > Thanks, > cu, WMD. > Werner, Can you clarify how much Checker Framework uses javac internal API and how much it just relies on public/supported API like java.*, javax.* and com.sun.source.*? Going forward, you should not assume you will have direct access to javac internals forever. -- Jon From wdietl at gmail.com Tue May 20 03:27:10 2014 From: wdietl at gmail.com (Werner Dietl) Date: Mon, 19 May 2014 23:27:10 -0400 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <537A989B.8080506@oracle.com> References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> <537A43E7.7000306@oracle.com> <537A989B.8080506@oracle.com> Message-ID: Hi Jon, access to javac internals at the moment is unfortunately necessary to implement some functionality. I do realize that such access might go away or break any moment. In general the Checker Framework relies on the public APIs as much as possible. Out of curiosity, I've done some grep, sort, uniq and came up with the import numbers below. There might be a few fully-qualified accesses, but I guess not too many. The one that surprised me was "import com.sun.tools.classfile"; I use that in a test case only to make sure type annotations are written to a classfile. Please do let me know if you want me to look into any particular uses. Cheers, cu, WMD. 6 import com.sun.source.tree.AnnotatedTypeTree; 7 import com.sun.source.tree.AnnotationTree; 12 import com.sun.source.tree.ArrayAccessTree; 4 import com.sun.source.tree.ArrayTypeTree; 5 import com.sun.source.tree.AssertTree; 13 import com.sun.source.tree.AssignmentTree; 22 import com.sun.source.tree.BinaryTree; 8 import com.sun.source.tree.BlockTree; 2 import com.sun.source.tree.BreakTree; 4 import com.sun.source.tree.CaseTree; 2 import com.sun.source.tree.CatchTree; 35 import com.sun.source.tree.ClassTree; 16 import com.sun.source.tree.CompilationUnitTree; 17 import com.sun.source.tree.CompoundAssignmentTree; 8 import com.sun.source.tree.ConditionalExpressionTree; 2 import com.sun.source.tree.ContinueTree; 3 import com.sun.source.tree.DoWhileLoopTree; 2 import com.sun.source.tree.EmptyStatementTree; 6 import com.sun.source.tree.EnhancedForLoopTree; 2 import com.sun.source.tree.ErroneousTree; 4 import com.sun.source.tree.ExpressionStatementTree; 48 import com.sun.source.tree.ExpressionTree; 3 import com.sun.source.tree.ForLoopTree; 24 import com.sun.source.tree.IdentifierTree; 6 import com.sun.source.tree.IfTree; 1 import com.sun.source.tree.ImportTree; 7 import com.sun.source.tree.InstanceOfTree; 2 import com.sun.source.tree.LabeledStatementTree; 2 import com.sun.source.tree.LambdaExpressionTree; 1 import com.sun.source.tree.LineMap; 31 import com.sun.source.tree.LiteralTree; 2 import com.sun.source.tree.MemberReferenceTree; 27 import com.sun.source.tree.MemberSelectTree; 41 import com.sun.source.tree.MethodInvocationTree; 35 import com.sun.source.tree.MethodTree; 4 import com.sun.source.tree.ModifiersTree; 15 import com.sun.source.tree.NewArrayTree; 23 import com.sun.source.tree.NewClassTree; 7 import com.sun.source.tree.ParameterizedTypeTree; 6 import com.sun.source.tree.ParenthesizedTree; 4 import com.sun.source.tree.PrimitiveTypeTree; 11 import com.sun.source.tree.ReturnTree; 1 import com.sun.source.tree.Scope; 6 import com.sun.source.tree.StatementTree; 4 import com.sun.source.tree.SwitchTree; 3 import com.sun.source.tree.SynchronizedTree; 5 import com.sun.source.tree.ThrowTree; 146 import com.sun.source.tree.Tree; 45 import com.sun.source.tree.Tree.Kind; 2 import com.sun.source.tree.TryTree; 15 import com.sun.source.tree.TypeCastTree; 7 import com.sun.source.tree.TypeParameterTree; 12 import com.sun.source.tree.UnaryTree; 2 import com.sun.source.tree.UnionTypeTree; 30 import com.sun.source.tree.VariableTree; 3 import com.sun.source.tree.WhileLoopTree; 3 import com.sun.source.tree.WildcardTree; 2 import com.sun.source.util.JavacTask; 6 import com.sun.source.util.SimpleTreeVisitor; 2 import com.sun.source.util.SourcePositions; 1 import com.sun.source.util.TaskEvent; 1 import com.sun.source.util.TaskListener; 28 import com.sun.source.util.TreePath; 5 import com.sun.source.util.TreePathScanner; 11 import com.sun.source.util.Trees; 2 import com.sun.source.util.TreeScanner; 1 import com.sun.tools.classfile.Attribute; 2 import com.sun.tools.classfile.ClassFile; 1 import com.sun.tools.classfile.Code_attribute; 1 import com.sun.tools.classfile.ConstantPool.InvalidIndex; 1 import com.sun.tools.classfile.ConstantPool.UnexpectedEntry; 1 import com.sun.tools.classfile.Field; 1 import com.sun.tools.classfile.Method; 1 import com.sun.tools.classfile.RuntimeTypeAnnotations_attribute; 2 import com.sun.tools.classfile.TypeAnnotation; 1 import com.sun.tools.classfile.TypeAnnotation.TargetType; 1 import com.sun.tools.doclets.Taglet; 3 import com.sun.tools.javac.api.JavacScope; 1 import com.sun.tools.javac.api.JavacTool; 1 import com.sun.tools.javac.code.*; 4 import com.sun.tools.javac.code.Attribute; 4 import com.sun.tools.javac.code.Attribute.TypeCompound; 1 import com.sun.tools.javac.code.BoundKind; 3 import com.sun.tools.javac.code.Flags; 13 import com.sun.tools.javac.code.Symbol; 2 import com.sun.tools.javac.code.Symbol.*; 2 import com.sun.tools.javac.code.Symbol.ClassSymbol; 6 import com.sun.tools.javac.code.Symbol.MethodSymbol; 2 import com.sun.tools.javac.code.Symbol.TypeSymbol; 3 import com.sun.tools.javac.code.Symbol.VarSymbol; 1 import com.sun.tools.javac.code.Symtab; 2 import com.sun.tools.javac.code.TargetType; 13 import com.sun.tools.javac.code.Type; 3 import com.sun.tools.javac.code.TypeAnnotationPosition; 2 import com.sun.tools.javac.code.TypeAnnotationPosition.TypePathEntry; 2 import com.sun.tools.javac.code.TypeAnnotationPosition.TypePathEntryKind; 1 import com.sun.tools.javac.code.Type.ClassType; 1 import com.sun.tools.javac.code.Types; 1 import com.sun.tools.javac.code.TypeTag; 1 import com.sun.tools.javac.code.Type.WildcardType; 1 import com.sun.tools.javac.comp.*; 2 import com.sun.tools.javac.comp.AttrContext; 1 import com.sun.tools.javac.comp.CompileStates.CompileState; 1 import com.sun.tools.javac.comp.DeferredAttr; 2 import com.sun.tools.javac.comp.Env; 2 import com.sun.tools.javac.comp.Resolve; 2 import com.sun.tools.javac.file.JavacFileManager; 2 import com.sun.tools.javac.main.JavaCompiler; 1 import com.sun.tools.javac.model.JavacElements; 1 import com.sun.tools.javac.model.JavacTypes; 15 import com.sun.tools.javac.processing.JavacProcessingEnvironment; 9 import com.sun.tools.javac.tree.JCTree; 1 import com.sun.tools.javac.tree.JCTree.JCAnnotatedType; 2 import com.sun.tools.javac.tree.JCTree.JCAnnotation; 1 import com.sun.tools.javac.tree.JCTree.JCCompilationUnit; 2 import com.sun.tools.javac.tree.JCTree.JCExpression; 1 import com.sun.tools.javac.tree.JCTree.JCExpressionStatement; 1 import com.sun.tools.javac.tree.JCTree.JCLambda; 1 import com.sun.tools.javac.tree.JCTree.JCMethodDecl; 2 import com.sun.tools.javac.tree.JCTree.JCMethodInvocation; 2 import com.sun.tools.javac.tree.JCTree.JCNewArray; 2 import com.sun.tools.javac.tree.JCTree.JCNewClass; 1 import com.sun.tools.javac.tree.JCTree.JCTypeParameter; 1 import com.sun.tools.javac.tree.Pretty; 3 import com.sun.tools.javac.tree.TreeInfo; 3 import com.sun.tools.javac.tree.TreeMaker; 1 import com.sun.tools.javac.tree.TreeScanner; 1 import com.sun.tools.javac.util.*; 15 import com.sun.tools.javac.util.Context; 8 import com.sun.tools.javac.util.List; 2 import com.sun.tools.javac.util.ListBuffer; 4 import com.sun.tools.javac.util.Log; 3 import com.sun.tools.javac.util.Name; 4 import com.sun.tools.javac.util.Names; 2 import com.sun.tools.javac.util.Pair; 1 import javax.annotation.meta.When; 18 import javax.annotation.Nullable; 5 import javax.annotation.processing.*; 3 import javax.annotation.processing.AbstractProcessor; 1 import javax.annotation.processing.Messager; 38 import javax.annotation.processing.ProcessingEnvironment; 1 import javax.annotation.processing.Processor; 1 import javax.annotation.processing.RoundEnvironment; 3 import javax.annotation.processing.SupportedAnnotationTypes; 8 import javax.annotation.processing.SupportedOptions; 3 import javax.annotation.processing.SupportedSourceVersion; 4 import javax.lang.model.element.*; 79 import javax.lang.model.element.AnnotationMirror; 6 import javax.lang.model.element.AnnotationValue; 2 import javax.lang.model.element.AnnotationValueVisitor; 65 import javax.lang.model.element.Element; 28 import javax.lang.model.element.ElementKind; 48 import javax.lang.model.element.ExecutableElement; 12 import javax.lang.model.element.Modifier; 26 import javax.lang.model.element.Name; 5 import javax.lang.model.element.PackageElement; 39 import javax.lang.model.element.TypeElement; 6 import javax.lang.model.element.TypeParameterElement; 40 import javax.lang.model.element.VariableElement; 11 import javax.lang.model.SourceVersion; 4 import javax.lang.model.type.*; 10 import javax.lang.model.type.ArrayType; 18 import javax.lang.model.type.DeclaredType; 2 import javax.lang.model.type.ExecutableType; 1 import javax.lang.model.type.IntersectionType; 1 import javax.lang.model.type.MirroredTypeException; 1 import javax.lang.model.type.NoType; 2 import javax.lang.model.type.NullType; 5 import javax.lang.model.type.PrimitiveType; 1 import javax.lang.model.type.ReferenceType; 51 import javax.lang.model.type.TypeKind; 53 import javax.lang.model.type.TypeMirror; 12 import javax.lang.model.type.TypeVariable; 2 import javax.lang.model.type.UnionType; 5 import javax.lang.model.type.WildcardType; 2 import javax.lang.model.util.*; 1 import javax.lang.model.util.AbstractElementVisitor6; 14 import javax.lang.model.util.ElementFilter; 23 import javax.lang.model.util.Elements; 1 import javax.lang.model.util.SimpleElementVisitor7; 1 import javax.lang.model.util.SimpleTypeVisitor7; 22 import javax.lang.model.util.Types; 6 import javax.tools.Diagnostic; 2 import javax.tools.DiagnosticCollector; 7 import javax.tools.Diagnostic.Kind; 2 import javax.tools.JavaCompiler; 1 import javax.tools.JavaFileManager; 8 import javax.tools.JavaFileObject; 2 import javax.tools.StandardJavaFileManager; 2 import javax.tools.ToolProvider; 1 import javax.validation.constraints.NotNull; 1 import static com.sun.source.tree.Tree.Kind.NULL_LITERAL; 1 import static com.sun.source.tree.Tree.Kind.STRING_LITERAL; 4 import static com.sun.tools.classfile.TypeAnnotation.TargetType.*; 1 import static com.sun.tools.javac.code.Flags.ABSTRACT; 1 import static com.sun.tools.javac.code.Flags.EFFECTIVELY_FINAL; 1 import static com.sun.tools.javac.code.Flags.FINAL; 1 import static com.sun.tools.javac.code.Kinds.*; 1 import static com.sun.tools.javac.code.Kinds.VAR; 1 import static com.sun.tools.javac.code.TypeTag.CLASS; 1 import static javax.lang.model.util.ElementFilter.methodsIn; On Mon, May 19, 2014 at 7:49 PM, Jonathan Gibbons wrote: > On 05/19/2014 02:17 PM, Werner Dietl wrote: >>>> >>>> In type-annotations, I made sure that the BasicAnnoTest at: >>>> test/tools/javac/processing/model/type/BasicAnnoTests.java >>>> compiles correctly. >>>> However, the generics/arrays/exceptions test cases at the end do not >>>> work yet. >>>> Is this something you are aware of? I thought one reason for your >>>> refactorings was exactly to make these tests work. >>> >>> It seems that DPrinter has gotten out of date, due to a few fixes that >>> have changed the internal data structures. Among these are a fix that >>> refactors the top-level nodes, and my fix that eliminates AnnotatedType. >>> >>> If you've fixed all (or even some) of these issues, I'll gladly >>> integrate your changes. >> >> The type-annotations repo contains a fixed DPrinter and I've kept it >> up-to-date through all recent refactorings. >> >> I haven't fixed the BasicAnnoTests, as my understanding was that >> fixing these tests is one reason for your refactorings. >> >> >>>> Another difference that would make compatibility between jdk8 and jkd9 >>>> easier is if field "exception_index" remained public to allow direct >>>> access. >>> >>> Unfortunately, I think that's less feasible. The exception_index field >>> currently gets used to store both exception indexes, as well as a >>> combination of catch info and source positions. Because the formatting >>> for this is nontrivial, and we have plans to eliminate it in the future, >>> exception_index was made private and accessible through getters and >>> setters. >>> >>> I would, however, be willing to add an updateExceptionIndex, which would >>> allow you to change the index after it has already been set. >> >> I have two use cases: create a new TAP from an existing TAP and >> comparing two TAPs for equality. >> For either one, I don't care what the underlying interpretation of the >> ints is, I just need to copy/compare them. >> >> One of our goals is to keep the Checker Framework running with the >> standard Java 8 compiler. I already perform quite a few TAP things >> reflectively to achieve this. I can do the same with the >> exception_index field, its just yet another complication that gets >> introduced. >> >> >>>> A few tests in jdk9 are disabled, even though they pass in >>>> type-annotations. >>>> The other differences between jdk9 and type-annotations are small >>>> fixes to javadoc, performance, and imports. >>>> See my message from May 8 for details: >>>> >>>> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-May/001722.html >>> >>> More tests are being re-enabled in the cleanup patch. I am currently >>> looking into the javadoc tests as well. As for the other fixes, I think >>> I would like to get the two big patches (the rearchitecting patch and >>> the cleanup patch) integrated, then look at them one-by-one. >> >> Ok, please do let me know if I can help. >> I would like to get all useful changes from type-annotations into jdk9 >> so that we can ideally close type-annotations in a state that exactly >> matches jdk9. >> >> Thanks, >> cu, WMD. >> > > > Werner, > > Can you clarify how much Checker Framework uses javac internal API > and how much it just relies on public/supported API like java.*, javax.* > and com.sun.source.*? > > Going forward, you should not assume you will have direct access to > javac internals forever. > > -- Jon -- http://www.google.com/profiles/wdietl From jonathan.gibbons at oracle.com Tue May 20 03:47:04 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 19 May 2014 20:47:04 -0700 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: References: <53681785.5040203@oracle.com> <536BEFBC.4080508@oracle.com> <537A43E7.7000306@oracle.com> <537A989B.8080506@oracle.com> Message-ID: <537AD038.5020509@oracle.com> java.*, javax.*, com.sun.source.* and yes, Taglet, are all OK. Joe has now annotated the acceptable APIs with @jdk.Exported Anything beginning com.sun.tools. (except Taglet) is risky. Apart from the risk of the API becoming hidden, there is (obviously) no guarantee as to the stability of the internal APIs during JDK 9 development, or for consistency between 8 and 9. -- Jon On 05/19/2014 08:27 PM, Werner Dietl wrote: > Hi Jon, > > access to javac internals at the moment is unfortunately necessary to > implement some functionality. > I do realize that such access might go away or break any moment. > > In general the Checker Framework relies on the public APIs as much as > possible. Out of curiosity, I've done some grep, sort, uniq and came > up with the import numbers below. There might be a few fully-qualified > accesses, but I guess not too many. > > The one that surprised me was "import com.sun.tools.classfile"; I use > that in a test case only to make sure type annotations are written to > a classfile. > > Please do let me know if you want me to look into any particular uses. > > Cheers, > cu, WMD. > > 6 import com.sun.source.tree.AnnotatedTypeTree; > 7 import com.sun.source.tree.AnnotationTree; > 12 import com.sun.source.tree.ArrayAccessTree; > 4 import com.sun.source.tree.ArrayTypeTree; > 5 import com.sun.source.tree.AssertTree; > 13 import com.sun.source.tree.AssignmentTree; > 22 import com.sun.source.tree.BinaryTree; > 8 import com.sun.source.tree.BlockTree; > 2 import com.sun.source.tree.BreakTree; > 4 import com.sun.source.tree.CaseTree; > 2 import com.sun.source.tree.CatchTree; > 35 import com.sun.source.tree.ClassTree; > 16 import com.sun.source.tree.CompilationUnitTree; > 17 import com.sun.source.tree.CompoundAssignmentTree; > 8 import com.sun.source.tree.ConditionalExpressionTree; > 2 import com.sun.source.tree.ContinueTree; > 3 import com.sun.source.tree.DoWhileLoopTree; > 2 import com.sun.source.tree.EmptyStatementTree; > 6 import com.sun.source.tree.EnhancedForLoopTree; > 2 import com.sun.source.tree.ErroneousTree; > 4 import com.sun.source.tree.ExpressionStatementTree; > 48 import com.sun.source.tree.ExpressionTree; > 3 import com.sun.source.tree.ForLoopTree; > 24 import com.sun.source.tree.IdentifierTree; > 6 import com.sun.source.tree.IfTree; > 1 import com.sun.source.tree.ImportTree; > 7 import com.sun.source.tree.InstanceOfTree; > 2 import com.sun.source.tree.LabeledStatementTree; > 2 import com.sun.source.tree.LambdaExpressionTree; > 1 import com.sun.source.tree.LineMap; > 31 import com.sun.source.tree.LiteralTree; > 2 import com.sun.source.tree.MemberReferenceTree; > 27 import com.sun.source.tree.MemberSelectTree; > 41 import com.sun.source.tree.MethodInvocationTree; > 35 import com.sun.source.tree.MethodTree; > 4 import com.sun.source.tree.ModifiersTree; > 15 import com.sun.source.tree.NewArrayTree; > 23 import com.sun.source.tree.NewClassTree; > 7 import com.sun.source.tree.ParameterizedTypeTree; > 6 import com.sun.source.tree.ParenthesizedTree; > 4 import com.sun.source.tree.PrimitiveTypeTree; > 11 import com.sun.source.tree.ReturnTree; > 1 import com.sun.source.tree.Scope; > 6 import com.sun.source.tree.StatementTree; > 4 import com.sun.source.tree.SwitchTree; > 3 import com.sun.source.tree.SynchronizedTree; > 5 import com.sun.source.tree.ThrowTree; > 146 import com.sun.source.tree.Tree; > 45 import com.sun.source.tree.Tree.Kind; > 2 import com.sun.source.tree.TryTree; > 15 import com.sun.source.tree.TypeCastTree; > 7 import com.sun.source.tree.TypeParameterTree; > 12 import com.sun.source.tree.UnaryTree; > 2 import com.sun.source.tree.UnionTypeTree; > 30 import com.sun.source.tree.VariableTree; > 3 import com.sun.source.tree.WhileLoopTree; > 3 import com.sun.source.tree.WildcardTree; > 2 import com.sun.source.util.JavacTask; > 6 import com.sun.source.util.SimpleTreeVisitor; > 2 import com.sun.source.util.SourcePositions; > 1 import com.sun.source.util.TaskEvent; > 1 import com.sun.source.util.TaskListener; > 28 import com.sun.source.util.TreePath; > 5 import com.sun.source.util.TreePathScanner; > 11 import com.sun.source.util.Trees; > 2 import com.sun.source.util.TreeScanner; > 1 import com.sun.tools.classfile.Attribute; > 2 import com.sun.tools.classfile.ClassFile; > 1 import com.sun.tools.classfile.Code_attribute; > 1 import com.sun.tools.classfile.ConstantPool.InvalidIndex; > 1 import com.sun.tools.classfile.ConstantPool.UnexpectedEntry; > 1 import com.sun.tools.classfile.Field; > 1 import com.sun.tools.classfile.Method; > 1 import com.sun.tools.classfile.RuntimeTypeAnnotations_attribute; > 2 import com.sun.tools.classfile.TypeAnnotation; > 1 import com.sun.tools.classfile.TypeAnnotation.TargetType; > 1 import com.sun.tools.doclets.Taglet; > 3 import com.sun.tools.javac.api.JavacScope; > 1 import com.sun.tools.javac.api.JavacTool; > 1 import com.sun.tools.javac.code.*; > 4 import com.sun.tools.javac.code.Attribute; > 4 import com.sun.tools.javac.code.Attribute.TypeCompound; > 1 import com.sun.tools.javac.code.BoundKind; > 3 import com.sun.tools.javac.code.Flags; > 13 import com.sun.tools.javac.code.Symbol; > 2 import com.sun.tools.javac.code.Symbol.*; > 2 import com.sun.tools.javac.code.Symbol.ClassSymbol; > 6 import com.sun.tools.javac.code.Symbol.MethodSymbol; > 2 import com.sun.tools.javac.code.Symbol.TypeSymbol; > 3 import com.sun.tools.javac.code.Symbol.VarSymbol; > 1 import com.sun.tools.javac.code.Symtab; > 2 import com.sun.tools.javac.code.TargetType; > 13 import com.sun.tools.javac.code.Type; > 3 import com.sun.tools.javac.code.TypeAnnotationPosition; > 2 import com.sun.tools.javac.code.TypeAnnotationPosition.TypePathEntry; > 2 import com.sun.tools.javac.code.TypeAnnotationPosition.TypePathEntryKind; > 1 import com.sun.tools.javac.code.Type.ClassType; > 1 import com.sun.tools.javac.code.Types; > 1 import com.sun.tools.javac.code.TypeTag; > 1 import com.sun.tools.javac.code.Type.WildcardType; > 1 import com.sun.tools.javac.comp.*; > 2 import com.sun.tools.javac.comp.AttrContext; > 1 import com.sun.tools.javac.comp.CompileStates.CompileState; > 1 import com.sun.tools.javac.comp.DeferredAttr; > 2 import com.sun.tools.javac.comp.Env; > 2 import com.sun.tools.javac.comp.Resolve; > 2 import com.sun.tools.javac.file.JavacFileManager; > 2 import com.sun.tools.javac.main.JavaCompiler; > 1 import com.sun.tools.javac.model.JavacElements; > 1 import com.sun.tools.javac.model.JavacTypes; > 15 import com.sun.tools.javac.processing.JavacProcessingEnvironment; > 9 import com.sun.tools.javac.tree.JCTree; > 1 import com.sun.tools.javac.tree.JCTree.JCAnnotatedType; > 2 import com.sun.tools.javac.tree.JCTree.JCAnnotation; > 1 import com.sun.tools.javac.tree.JCTree.JCCompilationUnit; > 2 import com.sun.tools.javac.tree.JCTree.JCExpression; > 1 import com.sun.tools.javac.tree.JCTree.JCExpressionStatement; > 1 import com.sun.tools.javac.tree.JCTree.JCLambda; > 1 import com.sun.tools.javac.tree.JCTree.JCMethodDecl; > 2 import com.sun.tools.javac.tree.JCTree.JCMethodInvocation; > 2 import com.sun.tools.javac.tree.JCTree.JCNewArray; > 2 import com.sun.tools.javac.tree.JCTree.JCNewClass; > 1 import com.sun.tools.javac.tree.JCTree.JCTypeParameter; > 1 import com.sun.tools.javac.tree.Pretty; > 3 import com.sun.tools.javac.tree.TreeInfo; > 3 import com.sun.tools.javac.tree.TreeMaker; > 1 import com.sun.tools.javac.tree.TreeScanner; > 1 import com.sun.tools.javac.util.*; > 15 import com.sun.tools.javac.util.Context; > 8 import com.sun.tools.javac.util.List; > 2 import com.sun.tools.javac.util.ListBuffer; > 4 import com.sun.tools.javac.util.Log; > 3 import com.sun.tools.javac.util.Name; > 4 import com.sun.tools.javac.util.Names; > 2 import com.sun.tools.javac.util.Pair; > 1 import javax.annotation.meta.When; > 18 import javax.annotation.Nullable; > 5 import javax.annotation.processing.*; > 3 import javax.annotation.processing.AbstractProcessor; > 1 import javax.annotation.processing.Messager; > 38 import javax.annotation.processing.ProcessingEnvironment; > 1 import javax.annotation.processing.Processor; > 1 import javax.annotation.processing.RoundEnvironment; > 3 import javax.annotation.processing.SupportedAnnotationTypes; > 8 import javax.annotation.processing.SupportedOptions; > 3 import javax.annotation.processing.SupportedSourceVersion; > 4 import javax.lang.model.element.*; > 79 import javax.lang.model.element.AnnotationMirror; > 6 import javax.lang.model.element.AnnotationValue; > 2 import javax.lang.model.element.AnnotationValueVisitor; > 65 import javax.lang.model.element.Element; > 28 import javax.lang.model.element.ElementKind; > 48 import javax.lang.model.element.ExecutableElement; > 12 import javax.lang.model.element.Modifier; > 26 import javax.lang.model.element.Name; > 5 import javax.lang.model.element.PackageElement; > 39 import javax.lang.model.element.TypeElement; > 6 import javax.lang.model.element.TypeParameterElement; > 40 import javax.lang.model.element.VariableElement; > 11 import javax.lang.model.SourceVersion; > 4 import javax.lang.model.type.*; > 10 import javax.lang.model.type.ArrayType; > 18 import javax.lang.model.type.DeclaredType; > 2 import javax.lang.model.type.ExecutableType; > 1 import javax.lang.model.type.IntersectionType; > 1 import javax.lang.model.type.MirroredTypeException; > 1 import javax.lang.model.type.NoType; > 2 import javax.lang.model.type.NullType; > 5 import javax.lang.model.type.PrimitiveType; > 1 import javax.lang.model.type.ReferenceType; > 51 import javax.lang.model.type.TypeKind; > 53 import javax.lang.model.type.TypeMirror; > 12 import javax.lang.model.type.TypeVariable; > 2 import javax.lang.model.type.UnionType; > 5 import javax.lang.model.type.WildcardType; > 2 import javax.lang.model.util.*; > 1 import javax.lang.model.util.AbstractElementVisitor6; > 14 import javax.lang.model.util.ElementFilter; > 23 import javax.lang.model.util.Elements; > 1 import javax.lang.model.util.SimpleElementVisitor7; > 1 import javax.lang.model.util.SimpleTypeVisitor7; > 22 import javax.lang.model.util.Types; > 6 import javax.tools.Diagnostic; > 2 import javax.tools.DiagnosticCollector; > 7 import javax.tools.Diagnostic.Kind; > 2 import javax.tools.JavaCompiler; > 1 import javax.tools.JavaFileManager; > 8 import javax.tools.JavaFileObject; > 2 import javax.tools.StandardJavaFileManager; > 2 import javax.tools.ToolProvider; > 1 import javax.validation.constraints.NotNull; > 1 import static com.sun.source.tree.Tree.Kind.NULL_LITERAL; > 1 import static com.sun.source.tree.Tree.Kind.STRING_LITERAL; > 4 import static com.sun.tools.classfile.TypeAnnotation.TargetType.*; > 1 import static com.sun.tools.javac.code.Flags.ABSTRACT; > 1 import static com.sun.tools.javac.code.Flags.EFFECTIVELY_FINAL; > 1 import static com.sun.tools.javac.code.Flags.FINAL; > 1 import static com.sun.tools.javac.code.Kinds.*; > 1 import static com.sun.tools.javac.code.Kinds.VAR; > 1 import static com.sun.tools.javac.code.TypeTag.CLASS; > 1 import static javax.lang.model.util.ElementFilter.methodsIn; > > > On Mon, May 19, 2014 at 7:49 PM, Jonathan Gibbons > wrote: >> On 05/19/2014 02:17 PM, Werner Dietl wrote: >>>>> In type-annotations, I made sure that the BasicAnnoTest at: >>>>> test/tools/javac/processing/model/type/BasicAnnoTests.java >>>>> compiles correctly. >>>>> However, the generics/arrays/exceptions test cases at the end do not >>>>> work yet. >>>>> Is this something you are aware of? I thought one reason for your >>>>> refactorings was exactly to make these tests work. >>>> It seems that DPrinter has gotten out of date, due to a few fixes that >>>> have changed the internal data structures. Among these are a fix that >>>> refactors the top-level nodes, and my fix that eliminates AnnotatedType. >>>> >>>> If you've fixed all (or even some) of these issues, I'll gladly >>>> integrate your changes. >>> The type-annotations repo contains a fixed DPrinter and I've kept it >>> up-to-date through all recent refactorings. >>> >>> I haven't fixed the BasicAnnoTests, as my understanding was that >>> fixing these tests is one reason for your refactorings. >>> >>> >>>>> Another difference that would make compatibility between jdk8 and jkd9 >>>>> easier is if field "exception_index" remained public to allow direct >>>>> access. >>>> Unfortunately, I think that's less feasible. The exception_index field >>>> currently gets used to store both exception indexes, as well as a >>>> combination of catch info and source positions. Because the formatting >>>> for this is nontrivial, and we have plans to eliminate it in the future, >>>> exception_index was made private and accessible through getters and >>>> setters. >>>> >>>> I would, however, be willing to add an updateExceptionIndex, which would >>>> allow you to change the index after it has already been set. >>> I have two use cases: create a new TAP from an existing TAP and >>> comparing two TAPs for equality. >>> For either one, I don't care what the underlying interpretation of the >>> ints is, I just need to copy/compare them. >>> >>> One of our goals is to keep the Checker Framework running with the >>> standard Java 8 compiler. I already perform quite a few TAP things >>> reflectively to achieve this. I can do the same with the >>> exception_index field, its just yet another complication that gets >>> introduced. >>> >>> >>>>> A few tests in jdk9 are disabled, even though they pass in >>>>> type-annotations. >>>>> The other differences between jdk9 and type-annotations are small >>>>> fixes to javadoc, performance, and imports. >>>>> See my message from May 8 for details: >>>>> >>>>> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-May/001722.html >>>> More tests are being re-enabled in the cleanup patch. I am currently >>>> looking into the javadoc tests as well. As for the other fixes, I think >>>> I would like to get the two big patches (the rearchitecting patch and >>>> the cleanup patch) integrated, then look at them one-by-one. >>> Ok, please do let me know if I can help. >>> I would like to get all useful changes from type-annotations into jdk9 >>> so that we can ideally close type-annotations in a state that exactly >>> matches jdk9. >>> >>> Thanks, >>> cu, WMD. >>> >> >> Werner, >> >> Can you clarify how much Checker Framework uses javac internal API >> and how much it just relies on public/supported API like java.*, javax.* >> and com.sun.source.*? >> >> Going forward, you should not assume you will have direct access to >> javac internals forever. >> >> -- Jon > > From mernst at cs.washington.edu Tue May 20 04:06:59 2014 From: mernst at cs.washington.edu (Michael Ernst) Date: Mon, 19 May 2014 21:06:59 -0700 (PDT) Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <537AD038.5020509@oracle.com> References: <537A989B.8080506@oracle.com> <537AD038.5020509@oracle.com> Message-ID: <20140519.210659.323247370198650393.mernst@cs.washington.edu> Jonathan- Thanks for the information. We understand the risks. But there is significant information that we simply cannot do without -- information that is only available through the unsupported APIs, so we'll keep using them. My kingdom for JSR 198... -Mike > Subject: Re: Future of 'type-annotations/type-annotations' forest > From: Jonathan Gibbons > To: Werner Dietl > Date: Mon, 19 May 2014 20:47:04 -0700 > > java.*, javax.*, com.sun.source.* and yes, Taglet, are all OK. > Joe has now annotated the acceptable APIs with @jdk.Exported > > Anything beginning com.sun.tools. (except Taglet) is risky. > > Apart from the risk of the API becoming hidden, there is (obviously) no > guarantee as to the stability of the internal APIs during JDK 9 > development, or for consistency between 8 and 9. > > -- Jon > > On 05/19/2014 08:27 PM, Werner Dietl wrote: >> Hi Jon, >> >> access to javac internals at the moment is unfortunately necessary to >> implement some functionality. >> I do realize that such access might go away or break any moment. >> >> In general the Checker Framework relies on the public APIs as much as >> possible. Out of curiosity, I've done some grep, sort, uniq and came >> up with the import numbers below. There might be a few fully-qualified >> accesses, but I guess not too many. >> >> The one that surprised me was "import com.sun.tools.classfile"; I use >> that in a test case only to make sure type annotations are written to >> a classfile. >> >> Please do let me know if you want me to look into any particular uses. >> >> Cheers, >> cu, WMD. >> >> 6 import com.sun.source.tree.AnnotatedTypeTree; >> 7 import com.sun.source.tree.AnnotationTree; >> 12 import com.sun.source.tree.ArrayAccessTree; >> 4 import com.sun.source.tree.ArrayTypeTree; >> 5 import com.sun.source.tree.AssertTree; >> 13 import com.sun.source.tree.AssignmentTree; >> 22 import com.sun.source.tree.BinaryTree; >> 8 import com.sun.source.tree.BlockTree; >> 2 import com.sun.source.tree.BreakTree; >> 4 import com.sun.source.tree.CaseTree; >> 2 import com.sun.source.tree.CatchTree; >> 35 import com.sun.source.tree.ClassTree; >> 16 import com.sun.source.tree.CompilationUnitTree; >> 17 import com.sun.source.tree.CompoundAssignmentTree; >> 8 import com.sun.source.tree.ConditionalExpressionTree; >> 2 import com.sun.source.tree.ContinueTree; >> 3 import com.sun.source.tree.DoWhileLoopTree; >> 2 import com.sun.source.tree.EmptyStatementTree; >> 6 import com.sun.source.tree.EnhancedForLoopTree; >> 2 import com.sun.source.tree.ErroneousTree; >> 4 import com.sun.source.tree.ExpressionStatementTree; >> 48 import com.sun.source.tree.ExpressionTree; >> 3 import com.sun.source.tree.ForLoopTree; >> 24 import com.sun.source.tree.IdentifierTree; >> 6 import com.sun.source.tree.IfTree; >> 1 import com.sun.source.tree.ImportTree; >> 7 import com.sun.source.tree.InstanceOfTree; >> 2 import com.sun.source.tree.LabeledStatementTree; >> 2 import com.sun.source.tree.LambdaExpressionTree; >> 1 import com.sun.source.tree.LineMap; >> 31 import com.sun.source.tree.LiteralTree; >> 2 import com.sun.source.tree.MemberReferenceTree; >> 27 import com.sun.source.tree.MemberSelectTree; >> 41 import com.sun.source.tree.MethodInvocationTree; >> 35 import com.sun.source.tree.MethodTree; >> 4 import com.sun.source.tree.ModifiersTree; >> 15 import com.sun.source.tree.NewArrayTree; >> 23 import com.sun.source.tree.NewClassTree; >> 7 import com.sun.source.tree.ParameterizedTypeTree; >> 6 import com.sun.source.tree.ParenthesizedTree; >> 4 import com.sun.source.tree.PrimitiveTypeTree; >> 11 import com.sun.source.tree.ReturnTree; >> 1 import com.sun.source.tree.Scope; >> 6 import com.sun.source.tree.StatementTree; >> 4 import com.sun.source.tree.SwitchTree; >> 3 import com.sun.source.tree.SynchronizedTree; >> 5 import com.sun.source.tree.ThrowTree; >> 146 import com.sun.source.tree.Tree; >> 45 import com.sun.source.tree.Tree.Kind; >> 2 import com.sun.source.tree.TryTree; >> 15 import com.sun.source.tree.TypeCastTree; >> 7 import com.sun.source.tree.TypeParameterTree; >> 12 import com.sun.source.tree.UnaryTree; >> 2 import com.sun.source.tree.UnionTypeTree; >> 30 import com.sun.source.tree.VariableTree; >> 3 import com.sun.source.tree.WhileLoopTree; >> 3 import com.sun.source.tree.WildcardTree; >> 2 import com.sun.source.util.JavacTask; >> 6 import com.sun.source.util.SimpleTreeVisitor; >> 2 import com.sun.source.util.SourcePositions; >> 1 import com.sun.source.util.TaskEvent; >> 1 import com.sun.source.util.TaskListener; >> 28 import com.sun.source.util.TreePath; >> 5 import com.sun.source.util.TreePathScanner; >> 11 import com.sun.source.util.Trees; >> 2 import com.sun.source.util.TreeScanner; >> 1 import com.sun.tools.classfile.Attribute; >> 2 import com.sun.tools.classfile.ClassFile; >> 1 import com.sun.tools.classfile.Code_attribute; >> 1 import com.sun.tools.classfile.ConstantPool.InvalidIndex; >> 1 import com.sun.tools.classfile.ConstantPool.UnexpectedEntry; >> 1 import com.sun.tools.classfile.Field; >> 1 import com.sun.tools.classfile.Method; >> 1 import >> com.sun.tools.classfile.RuntimeTypeAnnotations_attribute; >> 2 import com.sun.tools.classfile.TypeAnnotation; >> 1 import com.sun.tools.classfile.TypeAnnotation.TargetType; >> 1 import com.sun.tools.doclets.Taglet; >> 3 import com.sun.tools.javac.api.JavacScope; >> 1 import com.sun.tools.javac.api.JavacTool; >> 1 import com.sun.tools.javac.code.*; >> 4 import com.sun.tools.javac.code.Attribute; >> 4 import com.sun.tools.javac.code.Attribute.TypeCompound; >> 1 import com.sun.tools.javac.code.BoundKind; >> 3 import com.sun.tools.javac.code.Flags; >> 13 import com.sun.tools.javac.code.Symbol; >> 2 import com.sun.tools.javac.code.Symbol.*; >> 2 import com.sun.tools.javac.code.Symbol.ClassSymbol; >> 6 import com.sun.tools.javac.code.Symbol.MethodSymbol; >> 2 import com.sun.tools.javac.code.Symbol.TypeSymbol; >> 3 import com.sun.tools.javac.code.Symbol.VarSymbol; >> 1 import com.sun.tools.javac.code.Symtab; >> 2 import com.sun.tools.javac.code.TargetType; >> 13 import com.sun.tools.javac.code.Type; >> 3 import com.sun.tools.javac.code.TypeAnnotationPosition; >> 2 import >> com.sun.tools.javac.code.TypeAnnotationPosition.TypePathEntry; >> 2 import >> com.sun.tools.javac.code.TypeAnnotationPosition.TypePathEntryKind; >> 1 import com.sun.tools.javac.code.Type.ClassType; >> 1 import com.sun.tools.javac.code.Types; >> 1 import com.sun.tools.javac.code.TypeTag; >> 1 import com.sun.tools.javac.code.Type.WildcardType; >> 1 import com.sun.tools.javac.comp.*; >> 2 import com.sun.tools.javac.comp.AttrContext; >> 1 import com.sun.tools.javac.comp.CompileStates.CompileState; >> 1 import com.sun.tools.javac.comp.DeferredAttr; >> 2 import com.sun.tools.javac.comp.Env; >> 2 import com.sun.tools.javac.comp.Resolve; >> 2 import com.sun.tools.javac.file.JavacFileManager; >> 2 import com.sun.tools.javac.main.JavaCompiler; >> 1 import com.sun.tools.javac.model.JavacElements; >> 1 import com.sun.tools.javac.model.JavacTypes; >> 15 import >> com.sun.tools.javac.processing.JavacProcessingEnvironment; >> 9 import com.sun.tools.javac.tree.JCTree; >> 1 import com.sun.tools.javac.tree.JCTree.JCAnnotatedType; >> 2 import com.sun.tools.javac.tree.JCTree.JCAnnotation; >> 1 import com.sun.tools.javac.tree.JCTree.JCCompilationUnit; >> 2 import com.sun.tools.javac.tree.JCTree.JCExpression; >> 1 import com.sun.tools.javac.tree.JCTree.JCExpressionStatement; >> 1 import com.sun.tools.javac.tree.JCTree.JCLambda; >> 1 import com.sun.tools.javac.tree.JCTree.JCMethodDecl; >> 2 import com.sun.tools.javac.tree.JCTree.JCMethodInvocation; >> 2 import com.sun.tools.javac.tree.JCTree.JCNewArray; >> 2 import com.sun.tools.javac.tree.JCTree.JCNewClass; >> 1 import com.sun.tools.javac.tree.JCTree.JCTypeParameter; >> 1 import com.sun.tools.javac.tree.Pretty; >> 3 import com.sun.tools.javac.tree.TreeInfo; >> 3 import com.sun.tools.javac.tree.TreeMaker; >> 1 import com.sun.tools.javac.tree.TreeScanner; >> 1 import com.sun.tools.javac.util.*; >> 15 import com.sun.tools.javac.util.Context; >> 8 import com.sun.tools.javac.util.List; >> 2 import com.sun.tools.javac.util.ListBuffer; >> 4 import com.sun.tools.javac.util.Log; >> 3 import com.sun.tools.javac.util.Name; >> 4 import com.sun.tools.javac.util.Names; >> 2 import com.sun.tools.javac.util.Pair; >> 1 import javax.annotation.meta.When; >> 18 import javax.annotation.Nullable; >> 5 import javax.annotation.processing.*; >> 3 import javax.annotation.processing.AbstractProcessor; >> 1 import javax.annotation.processing.Messager; >> 38 import javax.annotation.processing.ProcessingEnvironment; >> 1 import javax.annotation.processing.Processor; >> 1 import javax.annotation.processing.RoundEnvironment; >> 3 import javax.annotation.processing.SupportedAnnotationTypes; >> 8 import javax.annotation.processing.SupportedOptions; >> 3 import javax.annotation.processing.SupportedSourceVersion; >> 4 import javax.lang.model.element.*; >> 79 import javax.lang.model.element.AnnotationMirror; >> 6 import javax.lang.model.element.AnnotationValue; >> 2 import javax.lang.model.element.AnnotationValueVisitor; >> 65 import javax.lang.model.element.Element; >> 28 import javax.lang.model.element.ElementKind; >> 48 import javax.lang.model.element.ExecutableElement; >> 12 import javax.lang.model.element.Modifier; >> 26 import javax.lang.model.element.Name; >> 5 import javax.lang.model.element.PackageElement; >> 39 import javax.lang.model.element.TypeElement; >> 6 import javax.lang.model.element.TypeParameterElement; >> 40 import javax.lang.model.element.VariableElement; >> 11 import javax.lang.model.SourceVersion; >> 4 import javax.lang.model.type.*; >> 10 import javax.lang.model.type.ArrayType; >> 18 import javax.lang.model.type.DeclaredType; >> 2 import javax.lang.model.type.ExecutableType; >> 1 import javax.lang.model.type.IntersectionType; >> 1 import javax.lang.model.type.MirroredTypeException; >> 1 import javax.lang.model.type.NoType; >> 2 import javax.lang.model.type.NullType; >> 5 import javax.lang.model.type.PrimitiveType; >> 1 import javax.lang.model.type.ReferenceType; >> 51 import javax.lang.model.type.TypeKind; >> 53 import javax.lang.model.type.TypeMirror; >> 12 import javax.lang.model.type.TypeVariable; >> 2 import javax.lang.model.type.UnionType; >> 5 import javax.lang.model.type.WildcardType; >> 2 import javax.lang.model.util.*; >> 1 import javax.lang.model.util.AbstractElementVisitor6; >> 14 import javax.lang.model.util.ElementFilter; >> 23 import javax.lang.model.util.Elements; >> 1 import javax.lang.model.util.SimpleElementVisitor7; >> 1 import javax.lang.model.util.SimpleTypeVisitor7; >> 22 import javax.lang.model.util.Types; >> 6 import javax.tools.Diagnostic; >> 2 import javax.tools.DiagnosticCollector; >> 7 import javax.tools.Diagnostic.Kind; >> 2 import javax.tools.JavaCompiler; >> 1 import javax.tools.JavaFileManager; >> 8 import javax.tools.JavaFileObject; >> 2 import javax.tools.StandardJavaFileManager; >> 2 import javax.tools.ToolProvider; >> 1 import javax.validation.constraints.NotNull; >> 1 import static com.sun.source.tree.Tree.Kind.NULL_LITERAL; >> 1 import static com.sun.source.tree.Tree.Kind.STRING_LITERAL; >> 4 import static >> com.sun.tools.classfile.TypeAnnotation.TargetType.*; >> 1 import static com.sun.tools.javac.code.Flags.ABSTRACT; >> 1 import static com.sun.tools.javac.code.Flags.EFFECTIVELY_FINAL; >> 1 import static com.sun.tools.javac.code.Flags.FINAL; >> 1 import static com.sun.tools.javac.code.Kinds.*; >> 1 import static com.sun.tools.javac.code.Kinds.VAR; >> 1 import static com.sun.tools.javac.code.TypeTag.CLASS; >> 1 import static javax.lang.model.util.ElementFilter.methodsIn; >> >> >> On Mon, May 19, 2014 at 7:49 PM, Jonathan Gibbons >> wrote: >>> On 05/19/2014 02:17 PM, Werner Dietl wrote: >>>>>> In type-annotations, I made sure that the BasicAnnoTest at: >>>>>> test/tools/javac/processing/model/type/BasicAnnoTests.java >>>>>> compiles correctly. >>>>>> However, the generics/arrays/exceptions test cases at the end do not >>>>>> work yet. >>>>>> Is this something you are aware of? I thought one reason for your >>>>>> refactorings was exactly to make these tests work. >>>>> It seems that DPrinter has gotten out of date, due to a few fixes >>>>> that >>>>> have changed the internal data structures. Among these are a fix >>>>> that >>>>> refactors the top-level nodes, and my fix that eliminates >>>>> AnnotatedType. >>>>> >>>>> If you've fixed all (or even some) of these issues, I'll gladly >>>>> integrate your changes. >>>> The type-annotations repo contains a fixed DPrinter and I've kept it >>>> up-to-date through all recent refactorings. >>>> >>>> I haven't fixed the BasicAnnoTests, as my understanding was that >>>> fixing these tests is one reason for your refactorings. >>>> >>>> >>>>>> Another difference that would make compatibility between jdk8 and >>>>>> jkd9 >>>>>> easier is if field "exception_index" remained public to allow direct >>>>>> access. >>>>> Unfortunately, I think that's less feasible. The exception_index >>>>> field >>>>> currently gets used to store both exception indexes, as well as a >>>>> combination of catch info and source positions. Because the >>>>> formatting >>>>> for this is nontrivial, and we have plans to eliminate it in the >>>>> future, >>>>> exception_index was made private and accessible through getters and >>>>> setters. >>>>> >>>>> I would, however, be willing to add an updateExceptionIndex, which >>>>> would >>>>> allow you to change the index after it has already been set. >>>> I have two use cases: create a new TAP from an existing TAP and >>>> comparing two TAPs for equality. >>>> For either one, I don't care what the underlying interpretation of the >>>> ints is, I just need to copy/compare them. >>>> >>>> One of our goals is to keep the Checker Framework running with the >>>> standard Java 8 compiler. I already perform quite a few TAP things >>>> reflectively to achieve this. I can do the same with the >>>> exception_index field, its just yet another complication that gets >>>> introduced. >>>> >>>> >>>>>> A few tests in jdk9 are disabled, even though they pass in >>>>>> type-annotations. >>>>>> The other differences between jdk9 and type-annotations are small >>>>>> fixes to javadoc, performance, and imports. >>>>>> See my message from May 8 for details: >>>>>> >>>>>> http://mail.openjdk.java.net/pipermail/type-annotations-dev/2014-May/001722.html >>>>> More tests are being re-enabled in the cleanup patch. I am currently >>>>> looking into the javadoc tests as well. As for the other fixes, I >>>>> think >>>>> I would like to get the two big patches (the rearchitecting patch and >>>>> the cleanup patch) integrated, then look at them one-by-one. >>>> Ok, please do let me know if I can help. >>>> I would like to get all useful changes from type-annotations into jdk9 >>>> so that we can ideally close type-annotations in a state that exactly >>>> matches jdk9. >>>> >>>> Thanks, >>>> cu, WMD. >>>> >>> >>> Werner, >>> >>> Can you clarify how much Checker Framework uses javac internal API >>> and how much it just relies on public/supported API like java.*, >>> javax.* >>> and com.sun.source.*? >>> >>> Going forward, you should not assume you will have direct access to >>> javac internals forever. >>> >>> -- Jon >> > From jonathan.gibbons at oracle.com Tue May 20 20:25:07 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 20 May 2014 13:25:07 -0700 Subject: Future of 'type-annotations/type-annotations' forest In-Reply-To: <20140519.210659.323247370198650393.mernst@cs.washington.edu> References: <537A989B.8080506@oracle.com> <537AD038.5020509@oracle.com> <20140519.210659.323247370198650393.mernst@cs.washington.edu> Message-ID: <537BBA23.8090801@oracle.com> I doubt that JSR 198 would help you. It is too IDE-focussed and not enough compiler-focussed. At some point it would be interesting to look at the Checker Framework with a view to figuring out the extra info you need from the AST and supporting API. -- Jon On 05/19/2014 09:06 PM, Michael Ernst wrote: > Jonathan- > > Thanks for the information. We understand the risks. But there is > significant information that we simply cannot do without -- > information that is only available through the unsupported APIs, so > we'll keep using them. My kingdom for JSR 198... > > -Mike From wdietl at gmail.com Mon May 26 21:07:45 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 26 May 2014 21:07:45 +0000 Subject: hg: type-annotations/type-annotations: 9 new changesets Message-ID: <201405262107.s4QL7kW2009536@aojmv0008> Changeset: bad356c6b417 Author: erikj Date: 2014-05-20 12:54 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/bad356c6b417 8043127: Convert JPRT_ARCHIVE_BUNDLE to unix style paths Reviewed-by: tbell ! make/Jprt.gmk Changeset: 824ca17eb07a Author: katleman Date: 2014-05-22 12:53 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/824ca17eb07a Added tag jdk9-b14 for changeset 4e3aa9723e99 ! .hgtags Changeset: 62cf732b4959 Author: lana Date: 2014-05-22 14:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/62cf732b4959 Merge Changeset: 6676325a167c Author: omajid Date: 2014-04-29 15:44 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/6676325a167c 8042159: Allow using a system-installed lcms2 Reviewed-by: andrew, ihse, prr ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 ! common/autoconf/spec.gmk.in Changeset: e5bcac256cc3 Author: ngthomas Date: 2014-04-29 14:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/e5bcac256cc3 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in Changeset: 1612c1abd8f0 Author: prr Date: 2014-05-05 12:48 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/1612c1abd8f0 Merge ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4 Changeset: b7267b3d951e Author: prr Date: 2014-05-12 09:37 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/b7267b3d951e Merge Changeset: 72f16d882fe2 Author: prr Date: 2014-05-23 09:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/72f16d882fe2 Merge ! common/autoconf/generated-configure.sh Changeset: 3d0aca20dd24 Author: wmdietl Date: 2014-05-26 17:07 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/rev/3d0aca20dd24 Automated merge with http://hg.openjdk.java.net/jdk9/dev/ ! .hgtags From wdietl at gmail.com Mon May 26 21:08:01 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 26 May 2014 21:08:01 +0000 Subject: hg: type-annotations/type-annotations/corba: 2 new changesets Message-ID: <201405262108.s4QL81wP009687@aojmv0008> Changeset: e54022d0dd92 Author: katleman Date: 2014-05-22 12:53 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/e54022d0dd92 Added tag jdk9-b14 for changeset a2b82f863ba9 ! .hgtags Changeset: b540c233123d Author: wmdietl Date: 2014-05-26 17:07 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/corba/rev/b540c233123d Automated merge with http://hg.openjdk.java.net/jdk9/dev/corba ! .hgtags From wdietl at gmail.com Mon May 26 21:08:31 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 26 May 2014 21:08:31 +0000 Subject: hg: type-annotations/type-annotations/jaxws: 5 new changesets Message-ID: <201405262108.s4QL8aD8009771@aojmv0008> Changeset: 1ba2ace9be55 Author: katleman Date: 2014-05-22 12:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/1ba2ace9be55 Added tag jdk9-b14 for changeset 02e58850b706 ! .hgtags Changeset: e3b68a164ebf Author: mkos Date: 2014-05-23 16:24 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/e3b68a164ebf 8039210: Fix type error in DefaultResourceInjector Summary: adding generic types to method call; blocker for fixing javac issue Reviewed-by: chegar ! src/share/jaxws_classes/com/sun/xml/internal/ws/server/DefaultResourceInjector.java Changeset: 0754bb097fd2 Author: mkos Date: 2014-05-23 16:25 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/0754bb097fd2 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail Reviewed-by: chegar ! src/share/jaxws_classes/com/sun/xml/internal/messaging/saaj/soap/AttachmentPartImpl.java Changeset: e9780330017a Author: mkos Date: 2014-05-26 14:59 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/e9780330017a 8043762: Remove unused files from jaxws repository Reviewed-by: alanb - src/share/jaxws_classes/com/sun/tools/etc/META-INF/services/com.sun.xml.internal.ws.spi.db.BindingContextFactory - src/share/jaxws_classes/com/sun/tools/internal/jxc/gen/config/config.rng - src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/dtd/bindinfo/bindingfile.rng - src/share/jaxws_classes/com/sun/tools/internal/xjc/reader/xmlschema/bindinfo/binding.rng - src/share/jaxws_classes/com/sun/xml/internal/bind/v2/schemagen/xmlschema/xmlschema-for-jaxb.rng - src/share/jaxws_classes/com/sun/xml/internal/rngom/parse/compact/CompactSyntax.jj - src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/pacakge-info.java + src/share/jaxws_classes/com/sun/xml/internal/ws/client/sei/package-info.java Changeset: 2ade295cb161 Author: wmdietl Date: 2014-05-26 17:08 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxws/rev/2ade295cb161 Automated merge with http://hg.openjdk.java.net/jdk9/dev/jaxws ! .hgtags From wdietl at gmail.com Mon May 26 21:08:55 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 26 May 2014 21:08:55 +0000 Subject: hg: type-annotations/type-annotations/jaxp: 3 new changesets Message-ID: <201405262108.s4QL8wel009811@aojmv0008> Changeset: 7755df76a8f6 Author: katleman Date: 2014-05-22 12:53 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/7755df76a8f6 Added tag jdk9-b14 for changeset 32b3fc4bc737 ! .hgtags Changeset: 6bad71866c75 Author: joehw Date: 2014-05-23 09:06 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/6bad71866c75 8043666: Remove unused files from jaxp repository Reviewed-by: alanb - src/com/sun/org/apache/xalan/internal/xsltc/compiler/Makefile.inc - src/com/sun/org/apache/xalan/internal/xsltc/javax.xml.transform.TransformerFactory - src/com/sun/org/apache/xerces/internal/dom/org.apache.xerces.dom.DOMImplementationSourceImpl - src/com/sun/org/apache/xerces/internal/dom/org.w3c.dom.DOMImplementationSourceList - src/com/sun/org/apache/xerces/internal/jaxp/datatype/javax.xml.datatype.DatatypeFactory - src/com/sun/org/apache/xerces/internal/jaxp/javax.xml.parsers.DocumentBuilderFactory - src/com/sun/org/apache/xerces/internal/jaxp/javax.xml.parsers.SAXParserFactory - src/com/sun/org/apache/xerces/internal/jaxp/validation/javax.xml.validation.SchemaFactory - src/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.DTDConfiguration - src/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.XML11Configuration - src/com/sun/org/apache/xerces/internal/parsers/org.apache.xerces.xni.parser.XMLParserConfiguration - src/com/sun/org/apache/xerces/internal/parsers/org.xml.sax.driver - src/com/sun/xml/internal/stream/javax.xml.stream.XMLEventFactory - src/com/sun/xml/internal/stream/javax.xml.stream.XMLInputFactory - src/com/sun/xml/internal/stream/javax.xml.stream.XMLOutputFactory - src/org/xml/sax/COPYING - src/org/xml/sax/COPYING.txt Changeset: bbbe9329d3e0 Author: wmdietl Date: 2014-05-26 17:08 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jaxp/rev/bbbe9329d3e0 Automated merge with http://hg.openjdk.java.net/jdk9/dev/jaxp ! .hgtags From wdietl at gmail.com Mon May 26 21:09:20 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 26 May 2014 21:09:20 +0000 Subject: hg: type-annotations/type-annotations/nashorn: 7 new changesets Message-ID: <201405262109.s4QL9PPm009874@aojmv0008> Changeset: 185501198f64 Author: sundar Date: 2014-05-20 08:32 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/185501198f64 8043443: Test framework changes to run script tests without security manager Reviewed-by: attila ! make/build.xml ! make/project.properties + test/script/nosecurity/nosecurity.js Changeset: 5c906c370739 Author: mnunez Date: 2014-05-22 11:12 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/5c906c370739 8028615: jdk.nashorn.x3::some.serious.failure needs more memory to run Reviewed-by: attila, sundar Contributed-by: sergey.lugovoy at oracle.com ! make/project.properties Changeset: 23a42e0d8a5a Author: hannesw Date: 2014-05-22 17:51 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/23a42e0d8a5a 8030202: Nashorn: Multiple RegExp#ignoreCase issues Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/runtime/regexp/joni/Analyser.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ApplyCaseFold.java ! src/jdk/nashorn/internal/runtime/regexp/joni/ByteCodeMachine.java ! src/jdk/nashorn/internal/runtime/regexp/joni/EncodingHelper.java ! src/jdk/nashorn/internal/runtime/regexp/joni/SearchAlgorithm.java + test/script/basic/JDK-8030202.js + test/script/basic/JDK-8030202.js.EXPECTED Changeset: edc146bdfd8d Author: katleman Date: 2014-05-22 12:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/edc146bdfd8d Added tag jdk9-b14 for changeset 806df06b6ac5 ! .hgtags Changeset: d60ebb2d32a6 Author: lana Date: 2014-05-22 14:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/d60ebb2d32a6 Merge Changeset: 068b13565a57 Author: sundar Date: 2014-05-26 15:48 +0530 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/068b13565a57 8043930: TypeError when attemping to create an instance of non-public class could be better Reviewed-by: attila, lagergren ! src/jdk/nashorn/internal/runtime/linker/NashornStaticClassLinker.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/JDK-8043930.js + test/script/basic/JDK-8043930.js.EXPECTED Changeset: ba8bd936551a Author: wmdietl Date: 2014-05-26 17:09 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/nashorn/rev/ba8bd936551a Automated merge with http://hg.openjdk.java.net/jdk9/dev/nashorn From wdietl at gmail.com Mon May 26 21:10:28 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 26 May 2014 21:10:28 +0000 Subject: hg: type-annotations/type-annotations/hotspot: 27 new changesets Message-ID: <201405262111.s4QLB0f0010060@aojmv0008> Changeset: 53a41e7cbe05 Author: drchase Date: 2014-05-09 16:50 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/53a41e7cbe05 8037816: Fix for 8036122 breaks build with Xcode5/clang Summary: Repaired or selectively disabled offending formats; future-proofed with additional checking Reviewed-by: kvn, jrose, stefank ! src/cpu/ppc/vm/vm_version_ppc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/compiledIC_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/nativeInst_x86.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/os/bsd/vm/decoder_machO.cpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/c1/c1_CFGPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_RangeCheckElimination.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_ValueType.hpp ! src/share/vm/ci/bcEscapeAnalyzer.cpp ! src/share/vm/ci/ciConstant.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciMetadata.cpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciObject.cpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciType.cpp ! src/share/vm/classfile/classFileError.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/defaultMethods.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/dictionary.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/verifier.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/compressedStream.cpp ! src/share/vm/code/debugInfo.cpp ! src/share/vm/code/exceptionHandlerTable.cpp ! src/share/vm/code/icBuffer.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/pcDesc.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/scopeDesc.cpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/compiler/compileLog.hpp ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/methodLiveness.cpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1AllocRegion.cpp ! src/share/vm/gc_implementation/g1/g1AllocRegion.hpp ! src/share/vm/gc_implementation/g1/g1BiasedArray.cpp ! src/share/vm/gc_implementation/g1/g1BiasedArray.hpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.hpp ! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp ! src/share/vm/gc_implementation/g1/g1CardCounts.hpp ! src/share/vm/gc_implementation/g1/g1CodeCacheRemSet.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/gc_implementation/g1/g1HRPrinter.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/satbQueue.cpp ! src/share/vm/gc_implementation/g1/survRateGroup.cpp ! src/share/vm/gc_implementation/parNew/asParNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parNew/parOopClosures.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/asPSYoungGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.cpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/immutableSpace.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_implementation/shared/mutableSpace.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/shared/spaceDecorator.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/oopMapCache.cpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/libadt/dict.cpp ! src/share/vm/libadt/set.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/blockOffsetTable.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/cardTableRS.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genOopClosures.hpp ! src/share/vm/memory/generation.cpp ! src/share/vm/memory/generation.hpp ! src/share/vm/memory/heapInspection.cpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/metachunk.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/threadLocalAllocBuffer.inline.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/annotations.cpp ! src/share/vm/oops/constMethod.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/generateOopMap.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/klass.inline.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnvThreadState.cpp ! src/share/vm/prims/jvmtiEventController.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/privilegedStack.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/fprofiler.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/interfaceSupport.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/mutex.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/osThread.cpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/perfMemory.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/signature.cpp ! src/share/vm/runtime/stackValue.cpp ! src/share/vm/runtime/stackValueCollection.cpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/synchronizer.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/unhandledOops.cpp ! src/share/vm/runtime/vframe.cpp ! src/share/vm/runtime/vframe.hpp ! src/share/vm/runtime/vframeArray.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticFramework.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/lowMemoryDetector.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/memReporter.cpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/nmtDCmd.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/trace/traceStream.hpp ! src/share/vm/utilities/array.hpp ! src/share/vm/utilities/bitMap.cpp ! src/share/vm/utilities/constantTag.cpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/events.cpp ! src/share/vm/utilities/events.hpp ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/exceptions.hpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/numberSeq.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp ! src/share/vm/utilities/quickSort.cpp ! src/share/vm/utilities/taskqueue.cpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/xmlstream.cpp ! src/share/vm/utilities/xmlstream.hpp Changeset: f88688d5c78c Author: zgu Date: 2014-05-07 06:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/f88688d5c78c 8041415: remove port.{cpp,hpp} files Summary: Hotspot should use standard headers and types Reviewed-by: coleenp, kvn ! src/share/vm/adlc/adlc.hpp ! src/share/vm/adlc/adlparse.hpp ! src/share/vm/adlc/filebuff.cpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/libadt/dict.cpp ! src/share/vm/libadt/dict.hpp - src/share/vm/libadt/port.cpp - src/share/vm/libadt/port.hpp ! src/share/vm/libadt/set.cpp ! src/share/vm/libadt/set.hpp ! src/share/vm/libadt/vectset.cpp ! src/share/vm/libadt/vectset.hpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/indexSet.cpp ! src/share/vm/opto/indexSet.hpp ! src/share/vm/opto/live.hpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/phase.hpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/regmask.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/precompiled/precompiled.hpp Changeset: 9b502ede714c Author: gziemski Date: 2014-05-07 14:16 -0500 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9b502ede714c 8038654: Separate SymbolTable and StringTable code Summary: Refactor stringTable class out of symbolTable, making sure all includes are minimal set and are sorted. Reviewed-by: coleenp, stefank ! src/share/vm/classfile/javaClasses.cpp + src/share/vm/classfile/stringTable.cpp + src/share/vm/classfile/stringTable.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/hashtable.cpp Changeset: ff15e9a66f7b Author: ctornqvi Date: 2014-05-09 17:06 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/ff15e9a66f7b 8042471: Unable to build JDK 9 Hotspot within VS2010 Summary: Fixed quoting issue and passing on defines to project file Reviewed-by: mgronlun, sla ! make/windows/projectfiles/common/Makefile Changeset: 1d9cd7b779a7 Author: ctornqvi Date: 2014-05-09 17:06 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/1d9cd7b779a7 8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal Summary: Removed runtime/6925573/SortMethodsTest.java from TEST.groups Reviewed-by: gtriantafill, lfoltan, coleenp, dholmes ! test/TEST.groups Changeset: aa3adb6da964 Author: coleenp Date: 2014-05-12 09:47 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/aa3adb6da964 Merge ! src/share/vm/adlc/output_h.cpp ! src/share/vm/classfile/javaClasses.cpp + src/share/vm/classfile/stringTable.cpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/libadt/dict.cpp - src/share/vm/libadt/port.cpp - src/share/vm/libadt/port.hpp ! src/share/vm/libadt/set.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/regmask.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: e657971fd67a Author: simonis Date: 2014-05-12 09:59 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/e657971fd67a 8039805: Fix the signature of the global new/delete operators in allocation.cpp. Reviewed-by: dholmes, lfoltan ! make/aix/makefiles/vm.make ! make/bsd/makefiles/vm.make ! src/os/aix/vm/os_aix.cpp ! src/os/aix/vm/porting_aix.cpp ! src/share/vm/memory/allocation.cpp Changeset: 9ea2d010f47c Author: lfoltan Date: 2014-05-12 15:50 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/9ea2d010f47c Merge ! src/os/aix/vm/os_aix.cpp ! src/share/vm/memory/allocation.cpp Changeset: 544227bb06d0 Author: hseigel Date: 2014-05-12 13:12 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/544227bb06d0 8040292: Annotation attributes must not appear more than once Summary: Add checks for duplicate attributes. Reviewed-by: coleenp, lfoltan ! src/share/vm/classfile/classFileParser.cpp + test/runtime/duplAttributes/DuplAttributes.jcod + test/runtime/duplAttributes/DuplAttributesTest.java + test/runtime/duplAttributes/test.jar Changeset: 21a8a08025a0 Author: mikael Date: 2014-05-12 06:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/21a8a08025a0 8042804: Support invoking Hotspot tests from top level Reviewed-by: sla, erikj ! test/Makefile Changeset: 05d8994e9f35 Author: ctornqvi Date: 2014-05-12 18:45 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/05d8994e9f35 Merge Changeset: 5e6dc4e3c761 Author: dholmes Date: 2014-05-12 20:20 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/5e6dc4e3c761 8032551: Remove UsePPCLWSYNC from globals.hpp Reviewed-by: lfoltan, zgu ! src/share/vm/runtime/globals.hpp Changeset: 722198b9fa26 Author: dholmes Date: 2014-05-12 20:25 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/722198b9fa26 Merge ! src/share/vm/runtime/globals.hpp Changeset: fef9b88e2585 Author: anoll Date: 2014-05-08 12:49 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/fef9b88e2585 8042431: compiler/7200264/TestIntVect.java fails with: Test Failed: AddVI 0 < 4 Summary: Define a new function that determines the minimum number of compiler threads for a particular platform/configuration. Reviewed-by: kvn ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 035c93dbff0b Author: twisti Date: 2014-05-08 15:16 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/035c93dbff0b Merge Changeset: 53acad1e7f52 Author: anoll Date: 2014-05-09 09:12 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/53acad1e7f52 8029343: CodeCache::allocate increments '_number_of_blobs' even if allocation fails. Summary: Incrementing the number of code blobs in CodeCache::allocate(...) is now only performed if allocation succeeds. The guarantee is fixed. Reviewed-by: kvn, iveresov Contributed-by: Tobias Hartmann ! src/share/vm/code/codeCache.cpp Changeset: c31d0c31e7bf Author: twisti Date: 2014-05-12 17:01 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c31d0c31e7bf Merge ! src/share/vm/code/codeCache.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 3d247564e2d8 Author: anoll Date: 2014-05-13 11:25 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3d247564e2d8 8021770: BackEdgeThreshold option is no longer used and should be removed Summary: The BackEdgeThreshold option is removed because it is no longer used. Reviewed-by: twisti, kvn, cjplummer Contributed-by: Tobias Hartmann ! src/cpu/ppc/vm/c2_globals_ppc.hpp ! src/cpu/sparc/vm/c1_globals_sparc.hpp ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c1_globals_x86.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/zero/vm/shark_globals_zero.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 975d903e1de3 Author: iveresov Date: 2014-05-13 11:32 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/975d903e1de3 8032463: VirtualDispatch test timeout with DeoptimizeALot Summary: Introduce code aging for warm method detection Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_CodeStubs.hpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/methodCounters.cpp ! src/share/vm/oops/methodCounters.hpp ! src/share/vm/oops/methodData.cpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 99dc0ff1d4c7 Author: vlivanov Date: 2014-03-11 15:06 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/99dc0ff1d4c7 8023461: Thread holding lock at safepoint that vm can block on: MethodCompileQueue_lock Reviewed-by: kvn, iveresov ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/oops/method.hpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp Changeset: 3624b11235ba Author: simonis Date: 2014-05-14 12:09 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/3624b11235ba 8043029: Change 8037816 breaks HS build with older GCC versions which don't support diagnostic pragmas Summary: Added conditions around macro definitions for pragmas. Reviewed-by: kvn ! src/share/vm/utilities/globalDefinitions_gcc.hpp Changeset: c98ef93bfe9a Author: iveresov Date: 2014-05-14 14:28 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/c98ef93bfe9a 8043063: Code aging should allocate MethodCounters when flushing a method Summary: Make sure that MethodCounters are present when the method is flushed for the first time to switch on code aging Reviewed-by: kvn ! src/share/vm/runtime/sweeper.cpp Changeset: 466b58fa837b Author: twisti Date: 2014-05-15 11:35 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/466b58fa837b Merge - src/share/vm/libadt/port.cpp - src/share/vm/libadt/port.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b329ff11a78c Author: amurillo Date: 2014-05-16 02:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/b329ff11a78c Merge - src/share/vm/libadt/port.cpp - src/share/vm/libadt/port.hpp Changeset: 18f86da62a40 Author: katleman Date: 2014-05-22 12:53 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/18f86da62a40 Added tag jdk9-b14 for changeset bd333491bb6c ! .hgtags Changeset: be9e24a9d6c6 Author: lana Date: 2014-05-22 14:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/be9e24a9d6c6 Merge - src/share/vm/libadt/port.cpp - src/share/vm/libadt/port.hpp Changeset: 8c7d69dd3056 Author: wmdietl Date: 2014-05-26 17:10 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/hotspot/rev/8c7d69dd3056 Automated merge with http://hg.openjdk.java.net/jdk9/dev/hotspot ! .hgtags ! src/share/vm/runtime/sharedRuntime.cpp From wdietl at gmail.com Mon May 26 21:15:11 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 26 May 2014 21:15:11 +0000 Subject: hg: type-annotations/type-annotations/jdk: 77 new changesets Message-ID: <201405262122.s4QLMCI0011944@aojmv0008> Changeset: e7cf67ef0900 Author: sla Date: 2014-05-18 20:42 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e7cf67ef0900 8043382: TempDirTest.java times out Summary: Remove explicit timeout Reviewed-by: alanb ! test/com/sun/tools/attach/TempDirTest.java Changeset: e4af4e06bc9e Author: yan Date: 2014-05-19 10:34 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e4af4e06bc9e 8039966: Add @return and @param block tags in colorchooser and filechooser swing classes Reviewed-by: malenkov, alexsch Contributed-by: Steven Sides ! src/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/share/classes/javax/swing/filechooser/FileFilter.java ! src/share/classes/javax/swing/filechooser/FileSystemView.java ! src/share/classes/javax/swing/filechooser/FileView.java Changeset: 4410f30150d0 Author: yan Date: 2014-05-19 10:43 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4410f30150d0 8040893: Add block tags for @return and @param to swing border classes Reviewed-by: malenkov, alexsch Contributed-by: Steven Sides ! src/share/classes/javax/swing/border/BevelBorder.java ! src/share/classes/javax/swing/border/Border.java ! src/share/classes/javax/swing/border/CompoundBorder.java ! src/share/classes/javax/swing/border/EmptyBorder.java ! src/share/classes/javax/swing/border/EtchedBorder.java ! src/share/classes/javax/swing/border/LineBorder.java ! src/share/classes/javax/swing/border/MatteBorder.java Changeset: 33a73cb00814 Author: robm Date: 2014-05-19 14:28 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/33a73cb00814 8028627: Unsynchronized code path from javax.crypto.Cipher to the WeakHashMap used by JceSecurity to store codebase mappings Reviewed-by: mullan ! src/share/classes/javax/crypto/JceSecurity.java Changeset: 5b45a5efe417 Author: igerasim Date: 2014-05-20 10:11 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5b45a5efe417 7195480: javax.smartcardio does not detect cards on Mac OS X Reviewed-by: valeriep ! src/solaris/native/sun/security/smartcardio/MUSCLE/pcsclite.h Changeset: 030dae646c6b Author: dsamersoff Date: 2014-05-20 06:11 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/030dae646c6b 8041435: Make JDWP socket connector accept only local connections by default Summary: Bind to localhost only if no address specified. Require * to bind to all available addresses Reviewed-by: dcubed, sspitsyn ! src/share/transport/socket/socketTransport.c ! test/com/sun/jdi/OptionTest.java Changeset: c4eb752f6a13 Author: kizune Date: 2014-05-20 23:17 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c4eb752f6a13 8037398: integer overflow in jdk/src/share/bin/java.c Reviewed-by: ksrini ! src/share/bin/java.c Changeset: 149f7e1e8cb7 Author: sla Date: 2014-05-21 10:22 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/149f7e1e8cb7 8043551: [TESTBUG] sun/tools/jcmd/TestJcmdSanity.java failure in nightly jdk9-dev fastdebug build Summary: Add -XX:+UsePerfData to the test Reviewed-by: dholmes ! test/sun/tools/jcmd/TestJcmdSanity.java Changeset: 9fdc6c3ea1bb Author: weijun Date: 2014-05-22 07:04 +0800 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9fdc6c3ea1bb 8043537: Changes for JDK-8039951 introduced circular dependency between Kerberos and com.sun.security.auth Reviewed-by: alanb ! make/mapfiles/libjava/mapfile-vers ! src/share/classes/sun/misc/VM.java ! src/share/classes/sun/security/krb5/internal/rcache/DflCache.java ! src/solaris/native/sun/misc/VM_md.c ! src/windows/native/sun/misc/VM_md.c ! test/sun/security/krb5/auto/ReplayCacheTestProc.java Changeset: 50e6d06f5cb6 Author: valeriep Date: 2014-05-21 23:30 +0000 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/50e6d06f5cb6 8037745: Consider re-enabling PKCS11 mechanisms previously disabled due to Solaris bug 7050617 Summary: Remove digest mechanisms from the disabled mechanisms section Reviewed-by: ascarpino, wetmore ! src/share/lib/security/sunpkcs11-solaris.cfg Changeset: 72814084db02 Author: okutsu Date: 2014-05-22 13:21 +0900 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/72814084db02 8032650: [parfait] warning from b124 for jdk/src/share/native/java/util: jni exception pending Reviewed-by: naoto ! src/share/classes/java/util/TimeZone.java ! src/share/native/java/util/TimeZone.c ! src/solaris/native/java/util/TimeZone_md.c ! src/solaris/native/java/util/TimeZone_md.h ! src/windows/native/java/util/TimeZone_md.c ! src/windows/native/java/util/TimeZone_md.h Changeset: 4ae47665ede7 Author: ykantser Date: 2014-05-22 11:05 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4ae47665ede7 8043520: Serviceability tests using @library failing with java.lang.NoClassDefFoundError Reviewed-by: sla, egahlin ! test/com/sun/jdi/BadHandshakeTest.java ! test/com/sun/jdi/ExclusiveBind.java ! test/com/sun/tools/attach/TempDirTest.java ! test/java/lang/instrument/DaemonThread/TestDaemonThread.java ! test/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java ! test/sun/management/jdp/JdpDefaultsTest.java ! test/sun/management/jdp/JdpOffTest.java ! test/sun/management/jdp/JdpSpecificAddressTest.java ! test/sun/management/jmxremote/bootstrap/LocalManagementTest.java ! test/sun/management/jmxremote/bootstrap/PasswordFilePermissionTest.java ! test/sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh ! test/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java ! test/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh ! test/sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.java ! test/sun/tools/jstat/JStatInterval.java ! test/sun/tools/jstatd/TestJstatdDefaults.java ! test/sun/tools/jstatd/TestJstatdExternalRegistry.java ! test/sun/tools/jstatd/TestJstatdPort.java ! test/sun/tools/jstatd/TestJstatdPortAndServer.java ! test/sun/tools/jstatd/TestJstatdServer.java ! test/sun/tools/jstatd/TestJstatdUsage.java Changeset: b39e23ebc008 Author: alanb Date: 2014-05-21 14:33 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b39e23ebc008 8042887: Remove serialver -show, this tool does not need a GUI Reviewed-by: alanb, chegar Contributed-by: Pavel Rappo ! src/share/classes/sun/tools/serialver/SerialVer.java ! src/share/classes/sun/tools/serialver/resources/serialver.properties Changeset: baffcaf51b02 Author: mfang Date: 2014-05-22 08:13 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/baffcaf51b02 8037343: Wrong dateformat for locale es_DO Reviewed-by: okutsu Contributed-by: me at sandipan.net ! src/share/classes/sun/text/resources/es/FormatData_es_DO.java + test/sun/text/resources/Format/Bug8037343.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 8ef4d3c258c0 Author: mfang Date: 2014-05-22 09:15 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8ef4d3c258c0 Merge Changeset: ae3f2b31bb3c Author: igerasim Date: 2014-05-22 20:19 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ae3f2b31bb3c 8043772: Typos in Double/Int/LongSummaryStatistics.java Reviewed-by: rriggs ! src/share/classes/java/util/DoubleSummaryStatistics.java ! src/share/classes/java/util/IntSummaryStatistics.java ! src/share/classes/java/util/LongSummaryStatistics.java Changeset: 5d191d40073f Author: dsamersoff Date: 2014-05-22 13:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/5d191d40073f 8043716: JDI test com/sun/jdi/ProcessAttachTest.sh and other 3 jdi tests failed in nightly Summary: InetAddress.getLocalHost() returns configured host name instead of localhost. Reviewed-by: dcubed ! src/share/classes/com/sun/tools/jdi/SocketAttachingConnector.java ! src/share/classes/com/sun/tools/jdi/SocketTransportService.java ! src/share/transport/socket/socketTransport.c ! test/com/sun/jdi/BadHandshakeTest.java ! test/com/sun/jdi/RunToExit.java Changeset: 28d1de89ff27 Author: katleman Date: 2014-05-22 12:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/28d1de89ff27 Added tag jdk9-b14 for changeset 5c7a17a81afd ! .hgtags Changeset: af9c7dccd0f6 Author: lana Date: 2014-05-22 14:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/af9c7dccd0f6 Merge Changeset: 1dc8226a83ed Author: igerasim Date: 2014-05-23 07:07 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1dc8226a83ed 8043507: javax.smartcardio.CardTerminals.list() fails on MacOSX Reviewed-by: valeriep ! src/share/native/sun/security/smartcardio/pcsc.c Changeset: 022372f3db57 Author: jbachorik Date: 2014-05-23 15:07 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/022372f3db57 8043572: demo/jvmti/mtrace/TraceJFrame.java fails with AWTError: Can't connect to X11 window server using '$DISPLAY_SITE' as the value of the DISPLAY variable Reviewed-by: sla ! test/demo/jvmti/mtrace/JFrameCreateTime.java ! test/demo/jvmti/mtrace/TraceJFrame.java Changeset: 7eac6175f210 Author: mkos Date: 2014-05-23 16:35 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7eac6175f210 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail Reviewed-by: chegar + test/javax/xml/ws/8043129/MailTest.java + test/javax/xml/ws/8043129/javax.mail.jar Changeset: 474739f38cb3 Author: robm Date: 2014-05-23 16:24 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/474739f38cb3 8042857: 14 stuck threads waiting for notification on LDAPRequest Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/ldap/Connection.java ! test/com/sun/jndi/ldap/LdapTimeoutTest.java Changeset: 525b6c4aded7 Author: pchelko Date: 2014-04-18 10:47 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/525b6c4aded7 8035169: Move ThreadGroupUtils from the sun.misc package Reviewed-by: anthony, serb, azvegint ! src/macosx/classes/sun/font/CFontManager.java ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/macosx/native/sun/awt/awt.m ! src/share/classes/sun/awt/AWTAutoShutdown.java + src/share/classes/sun/awt/util/ThreadGroupUtils.java ! src/share/classes/sun/font/CreatedFontTracker.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/java2d/Disposer.java ! src/share/classes/sun/java2d/opengl/OGLRenderQueue.java - src/share/classes/sun/misc/ThreadGroupUtils.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java Changeset: 87168e781129 Author: serb Date: 2014-04-18 20:10 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/87168e781129 8026252: [macosx] Change AWT_DEBUG_BUG_REPORT_MESSAGE for macosx platform Reviewed-by: azvegint, pchelko ! src/macosx/native/sun/osxapp/AWT_debug.h Changeset: 7c3ea6969f1a Author: henryjen Date: 2014-04-18 09:56 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7c3ea6969f1a 8038644: Fix raw and unchecked warnings in sun.java2d.* Reviewed-by: darcy, prr ! src/share/classes/sun/java2d/Spans.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/share/classes/sun/java2d/cmm/lcms/LCMS.java ! src/share/classes/sun/java2d/loops/Blit.java ! src/share/classes/sun/java2d/loops/CustomComponent.java ! src/share/classes/sun/java2d/loops/GeneralRenderer.java ! src/share/classes/sun/java2d/loops/GraphicsPrimitive.java ! src/share/classes/sun/java2d/loops/GraphicsPrimitiveMgr.java ! src/share/classes/sun/java2d/loops/GraphicsPrimitiveProxy.java ! src/share/classes/sun/java2d/loops/MaskBlit.java ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/pipe/AlphaPaintPipe.java ! src/share/classes/sun/java2d/pipe/RenderQueue.java ! src/share/classes/sun/java2d/pipe/SpanClipRenderer.java ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java Changeset: e128f966866a Author: pchelko Date: 2014-04-21 11:00 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e128f966866a 8037477: Reproducible hang of JAWS and webstart application with JAB 2.0.4 Reviewed-by: anthony, serb ! src/share/classes/javax/accessibility/AccessibleContext.java ! src/share/classes/sun/awt/AWTAccessor.java Changeset: c904d2c4425d Author: yan Date: 2014-04-21 14:35 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c904d2c4425d 8039279: Move awt tests to openjdk repository Reviewed-by: pchelko, alexsch Contributed-by: Dmitriy Ermashov + test/java/awt/Frame/SetMaximizedBounds/SetMaximizedBounds.java + test/java/awt/GridLayout/ChangeGridSize/ChangeGridSize.java + test/java/awt/GridLayout/ComponentPreferredSize/ComponentPreferredSize.java + test/java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java + test/java/awt/Toolkit/LockingKeyStateTest/LockingKeyStateTest.java Changeset: 85b7ff7d0ba7 Author: alitvinov Date: 2014-04-21 16:32 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/85b7ff7d0ba7 8024061: Exception thrown when drag and drop between two components is executed quickly Reviewed-by: pchelko, serb Contributed-by: alexey.ivanov at oracle.com ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java + test/sun/awt/dnd/8024061/bug8024061.java Changeset: a8ca8e71ce49 Author: malenkov Date: 2014-04-21 20:59 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a8ca8e71ce49 8040656: Classes with overriden methods with covariant returns return random read methods Reviewed-by: alexsch, serb ! src/share/classes/java/beans/MethodDescriptor.java + test/java/beans/Introspector/Test8040656.java Changeset: ef1c998c0233 Author: darcy Date: 2014-04-21 23:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ef1c998c0233 8039862: Fix fallthrough lint warnings in 2d Reviewed-by: flar ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/font/TrueTypeGlyphMapper.java ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java Changeset: ae68e97bb4c6 Author: darcy Date: 2014-04-22 17:55 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ae68e97bb4c6 8039860: Fix fallthrough lint warnings in swing Reviewed-by: malenkov ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTableHeaderUI.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/javax/swing/text/html/parser/ContentModelState.java ! src/share/classes/javax/swing/text/html/parser/Parser.java ! src/share/classes/javax/swing/text/rtf/RTFGenerator.java ! src/share/classes/javax/swing/text/rtf/RTFParser.java Changeset: a56aca1ce81b Author: pchelko Date: 2014-04-23 17:56 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a56aca1ce81b 8027148: SystemFlavorMap.getNativesForFlavor returns list of native formats in incorrect order Reviewed-by: anthony, serb ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/solaris/classes/sun/awt/X11/XDataTransferer.java + test/java/awt/datatransfer/MappingGenerationTest/MappingGenerationTest.java Changeset: 91d3e34bf1e6 Author: pchelko Date: 2014-04-23 18:07 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/91d3e34bf1e6 8039567: Duplicated code in DataTransferer Reviewed-by: serb, azvegint ! src/macosx/classes/sun/lwawt/macosx/CDataTransferer.java ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/solaris/classes/sun/awt/X11/XDataTransferer.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java Changeset: bd2c6062791f Author: malenkov Date: 2014-04-23 21:11 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bd2c6062791f 8039464: The scrollbar in JScrollPane has no right border if used WindowsLookAndFeel Reviewed-by: alexsch, serb ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsScrollBarUI.java + test/javax/swing/JScrollBar/8039464/Test8039464.html + test/javax/swing/JScrollBar/8039464/Test8039464.java Changeset: 2723947e6d31 Author: alexsch Date: 2014-04-24 16:15 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2723947e6d31 8040279: [macosx] Do not use the base image in the MultiResolutionBufferedImage Reviewed-by: serb, pchelko ! src/macosx/classes/com/apple/laf/AquaImageFactory.java ! src/macosx/classes/com/apple/laf/AquaPainter.java ! src/macosx/classes/com/apple/laf/AquaUtils.java ! src/macosx/classes/sun/lwawt/macosx/CImage.java + src/share/classes/sun/awt/image/AbstractMultiResolutionImage.java - src/share/classes/sun/awt/image/MultiResolutionBufferedImage.java + src/share/classes/sun/awt/image/MultiResolutionCachedImage.java ! test/javax/swing/JMenuItem/8031573/bug8031573.java ! test/javax/swing/JOptionPane/8024926/bug8024926.java Changeset: 03da9ca135ac Author: pchelko Date: 2014-04-24 20:22 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/03da9ca135ac 7124250: [macosx] JOptionPane dialogs show wrong icons Reviewed-by: serb, leonidr ! src/macosx/classes/com/apple/laf/AquaImageFactory.java Changeset: 63e1be3350fa Author: pchelko Date: 2014-04-25 16:27 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/63e1be3350fa 8041572: [macosx] huge native memory leak in AWTWindow.m Reviewed-by: serb, anthony ! src/macosx/native/sun/awt/AWTWindow.m ! src/macosx/native/sun/awt/CGraphicsDevice.m Changeset: 015dda6cfc53 Author: pchelko Date: 2014-04-25 16:39 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/015dda6cfc53 8041490: PIT: [macosx] Crash in system tray functionality check test Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/CWarningWindow.java + test/java/awt/security/WarningWindowDisposeTest/WarningWindowDisposeCrashTest.java Changeset: 4fc46640afa1 Author: pchelko Date: 2014-04-28 16:45 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/4fc46640afa1 8041987: [macosx] setDisplayMode crashes Reviewed-by: anthony, serb ! src/macosx/native/sun/awt/CGraphicsDevice.m + test/java/awt/FullScreen/DisplayChangeVITest/DisplayChangeVITest.java Changeset: 40e611441867 Author: asaha Date: 2014-04-28 11:03 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/40e611441867 8036819: JAB: mneumonics not read for textboxes Reviewed-by: alexsch Contributed-by: vivi.an at oracle.com ! src/share/classes/javax/swing/JComponent.java + test/javax/swing/JTextField/8036819/bug8036819.java Changeset: cca9b752e5f6 Author: henryjen Date: 2014-04-28 19:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/cca9b752e5f6 8039642: Fix raw and unchecked warnings in sun.awt.* Reviewed-by: darcy, prr, flar ! src/share/classes/java/awt/Menu.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/HToolkit.java ! src/share/classes/sun/awt/HeadlessToolkit.java ! src/share/classes/sun/awt/PlatformFont.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/datatransfer/SunClipboard.java ! src/share/classes/sun/awt/datatransfer/TransferableProxy.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java ! src/share/classes/sun/awt/geom/AreaOp.java ! src/share/classes/sun/awt/geom/Crossings.java ! src/share/classes/sun/awt/geom/Curve.java ! src/share/classes/sun/awt/geom/Order2.java ! src/share/classes/sun/awt/geom/Order3.java ! src/share/classes/sun/awt/image/BufImgSurfaceData.java ! src/share/classes/sun/awt/image/GifImageDecoder.java ! src/share/classes/sun/awt/image/ImageDecoder.java ! src/share/classes/sun/awt/image/ImageFetcher.java ! src/share/classes/sun/awt/image/ImageRepresentation.java ! src/share/classes/sun/awt/image/ImagingLib.java ! src/share/classes/sun/awt/image/JPEGImageDecoder.java ! src/share/classes/sun/awt/image/OffScreenImageSource.java ! src/share/classes/sun/awt/image/PNGImageDecoder.java ! src/share/classes/sun/awt/image/ToolkitImage.java ! src/share/classes/sun/awt/shell/ShellFolder.java ! src/share/classes/sun/awt/shell/ShellFolderColumnInfo.java ! src/share/classes/sun/awt/util/IdentityArrayList.java ! src/share/classes/sun/awt/util/IdentityLinkedList.java ! src/solaris/classes/sun/awt/X11/InfoWindow.java ! src/solaris/classes/sun/awt/X11/ListHelper.java ! src/solaris/classes/sun/awt/X11/MotifDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/Native.java ! src/solaris/classes/sun/awt/X11/XAWTXSettings.java ! src/solaris/classes/sun/awt/X11/XAtomList.java ! src/solaris/classes/sun/awt/X11/XAwtState.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XCreateWindowParams.java ! src/solaris/classes/sun/awt/X11/XDataTransferer.java ! src/solaris/classes/sun/awt/X11/XDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDragAndDropProtocols.java ! src/solaris/classes/sun/awt/X11/XDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetContextPeer.java ! src/solaris/classes/sun/awt/X11/XDropTargetEventProcessor.java ! src/solaris/classes/sun/awt/X11/XDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XEmbeddingContainer.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XMSelection.java ! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java ! src/solaris/classes/sun/awt/X11/XMenuPeer.java ! src/solaris/classes/sun/awt/X11/XMenuWindow.java ! src/solaris/classes/sun/awt/X11/XPopupMenuPeer.java ! src/solaris/classes/sun/awt/X11/XSelection.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11CustomCursor.java ! src/solaris/classes/sun/awt/X11FontManager.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11InputMethod.java ! src/solaris/classes/sun/awt/XSettings.java ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java Changeset: b3bd0f3320b6 Author: yan Date: 2014-04-29 14:32 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b3bd0f3320b6 8041592: [TEST_BUG] Move 42 AWT hw/lw mixing tests to jdk Reviewed-by: anthony, pchelko + test/java/awt/Mixing/AWT_Mixing/FrameBorderCounter.java + test/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java + test/java/awt/Mixing/AWT_Mixing/HierarchyBoundsListenerMixingTest.java + test/java/awt/Mixing/AWT_Mixing/JButtonInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JColorChooserOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JEditorPaneInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JEditorPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JGlassPaneInternalFrameOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JGlassPaneMoveOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JInternalFrameMoveOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JInternalFrameOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JLabelInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JLabelOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JListInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JListOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JPanelInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JPanelOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JPopupMenuOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JProgressBarInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JProgressBarOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JScrollBarInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JScrollBarOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JScrollPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JSliderInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JSliderOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JSpinnerInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JSpinnerOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JSplitPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JTableInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JTableOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JTextAreaInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JTextAreaOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JTextFieldInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JTextFieldOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JToggleButtonInGlassPaneOverlapping.java + test/java/awt/Mixing/AWT_Mixing/JToggleButtonOverlapping.java + test/java/awt/Mixing/AWT_Mixing/MixingFrameResizing.java + test/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java + test/java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java + test/java/awt/Mixing/AWT_Mixing/OpaqueOverlappingChoice.java + test/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java + test/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java + test/java/awt/Mixing/AWT_Mixing/Util.java + test/java/awt/Mixing/AWT_Mixing/ViewportOverlapping.java Changeset: bcf64fb3407f Author: omajid Date: 2014-04-29 15:46 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bcf64fb3407f 8042159: Allow using a system-installed lcms2 Reviewed-by: andrew, ihse, prr ! make/lib/Awt2dLibraries.gmk ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: c0192683fb63 Author: ngthomas Date: 2014-04-29 14:40 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c0192683fb63 Merge Changeset: 69ca0ba20534 Author: pchelko Date: 2014-04-30 12:41 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/69ca0ba20534 8042087: [macosx] LWCToolkit.inokeAndWait is calling EventQueue.invokeLater Reviewed-by: anthony, serb ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java Changeset: 1047241ab94b Author: simonis Date: 2014-04-30 11:29 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1047241ab94b 8042090: Fix invalid variable names sun/java2d/loops/ProcessPath.c Reviewed-by: prr ! src/share/native/sun/java2d/loops/ProcessPath.c Changeset: b04dc2c5b9b9 Author: malenkov Date: 2014-04-30 19:28 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/b04dc2c5b9b9 8041917: unexcepted behavior of LineBorder while using Boolean variable true Reviewed-by: alexsch, serb ! src/share/classes/javax/swing/border/LineBorder.java ! test/javax/swing/border/Test4252164.java Changeset: 8a32763ec0b1 Author: serb Date: 2014-05-05 19:42 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8a32763ec0b1 8042212: [macosx] Toolkit.getScreenResolution() can return incorrect resolution Reviewed-by: anthony, pchelko ! src/macosx/native/sun/awt/CGraphicsDevice.m Changeset: d01841fda7a8 Author: prr Date: 2014-05-05 09:41 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d01841fda7a8 8038838: Totally remove all vestiges of com.sun.image.codec.jpeg from JDK 9 Reviewed-by: bae, vadim ! make/mapfiles/libjpeg/mapfile-vers-closed Changeset: de42513e996d Author: prr Date: 2014-05-05 12:49 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/de42513e996d Merge ! make/lib/Awt2dLibraries.gmk Changeset: d41dba23eca9 Author: darcy Date: 2014-05-05 23:19 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/d41dba23eca9 8042256: Fix raw and unchecked lint warnings in com.sun.media.sound Reviewed-by: prr ! src/share/classes/com/sun/media/sound/AbstractLine.java ! src/share/classes/com/sun/media/sound/AbstractMidiDevice.java ! src/share/classes/com/sun/media/sound/AbstractMixer.java ! src/share/classes/com/sun/media/sound/AlawCodec.java ! src/share/classes/com/sun/media/sound/AudioSynthesizerPropertyInfo.java ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/share/classes/com/sun/media/sound/EventDispatcher.java ! src/share/classes/com/sun/media/sound/JDK13Services.java ! src/share/classes/com/sun/media/sound/MidiInDeviceProvider.java ! src/share/classes/com/sun/media/sound/MidiOutDeviceProvider.java ! src/share/classes/com/sun/media/sound/MidiUtils.java ! src/share/classes/com/sun/media/sound/PCMtoPCMCodec.java ! src/share/classes/com/sun/media/sound/PortMixer.java ! src/share/classes/com/sun/media/sound/RealTimeSequencer.java ! src/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/share/classes/com/sun/media/sound/UlawCodec.java Changeset: 16471134008a Author: darcy Date: 2014-05-05 23:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/16471134008a 8039109: Fix unchecked and raw lint warnings in java.awt Reviewed-by: pchelko, forax, flar, prr ! src/share/classes/java/awt/AWTKeyStroke.java ! src/share/classes/java/awt/CardLayout.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/datatransfer/MimeTypeParameterList.java ! src/share/classes/java/awt/dnd/DragGestureEvent.java ! src/share/classes/java/awt/geom/Area.java ! src/share/classes/java/awt/image/BufferedImage.java ! src/share/classes/java/awt/image/CropImageFilter.java ! src/share/classes/java/awt/image/FilteredImageSource.java ! src/share/classes/java/awt/image/ImageFilter.java ! src/share/classes/java/awt/image/MemoryImageSource.java ! src/share/classes/java/awt/image/ReplicateScaleFilter.java ! src/share/classes/java/awt/image/renderable/ParameterBlock.java ! src/share/classes/java/awt/image/renderable/RenderableImageOp.java ! src/share/classes/java/awt/image/renderable/RenderableImageProducer.java ! src/share/classes/java/awt/print/Book.java ! src/share/classes/java/awt/print/PrinterJob.java Changeset: eff56d740e3d Author: pchelko Date: 2014-05-07 19:40 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/eff56d740e3d 8042585: [macosx] Unused code in LWCToolkit.m Reviewed-by: serb, azvegint ! src/macosx/native/sun/awt/LWCToolkit.m Changeset: ddb31ed7121b Author: pchelko Date: 2014-05-07 19:47 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ddb31ed7121b 8042219: [macosx] LWComponentPeer should not reference classes from sun.lwawt.macosx Reviewed-by: serb, azvegint ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWToolkit.java + src/macosx/classes/sun/lwawt/PlatformDropTarget.java ! src/macosx/classes/sun/lwawt/macosx/CDropTarget.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/CDropTarget.h ! src/macosx/native/sun/awt/CDropTarget.m Changeset: 75206fa5a43e Author: ddehaven Date: 2014-05-05 23:21 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/75206fa5a43e 8042440: awt_Plugin no longer needed Reviewed-by: serb, pchelko Contributed-by: David DeHaven ! make/lib/Awt2dLibraries.gmk ! make/mapfiles/libawt/mapfile-mawt-vers ! make/mapfiles/libawt/mapfile-vers ! make/mapfiles/libawt/mapfile-vers-linux ! make/mapfiles/libawt_xawt/mapfile-vers ! src/solaris/native/sun/awt/awt_LoadLibrary.c - src/solaris/native/sun/awt/awt_Plugin.c - src/solaris/native/sun/awt/awt_Plugin.h Changeset: 6f660f46f0f2 Author: simonis Date: 2014-05-08 11:46 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6f660f46f0f2 8042416: X11GraphicsEnvironment.isDisplayLocal() throws NoSuchElementException if DISPLAY host has more IP addresses than a local interface Reviewed-by: anthony, azvegint Contributed-by: matthia.braun at sap.com ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java Changeset: 415e14c14558 Author: pchelko Date: 2014-05-08 16:50 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/415e14c14558 8036917: [macosx] Native memory leaks. Reviewed-by: serb, azvegint ! src/macosx/native/sun/awt/CImage.m Changeset: 9c6ff56dfe00 Author: pchelko Date: 2014-05-08 18:37 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/9c6ff56dfe00 8042752: [macosx] NSEvent instances leak throw JNI local references Reviewed-by: serb, azvegint ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/CTrayIcon.m Changeset: 28b9b1940ff3 Author: prr Date: 2014-05-08 15:17 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/28b9b1940ff3 8038875: Remove use of ServiceLoader in finding class implementing sun.java2d.pipe. RenderingEngine Reviewed-by: flar, mchung ! make/CopyIntoClasses.gmk ! make/profile-rtjar-includes.txt - src/share/classes/sun/dc/META-INF/services/sun.java2d.pipe.RenderingEngine ! src/share/classes/sun/java2d/pipe/RenderingEngine.java - src/share/classes/sun/java2d/pisces/META-INF/services/sun.java2d.pipe.RenderingEngine - src/solaris/classes/sun/java2d/pisces/META-INF/services/sun.java2d.pipe.RenderingEngine Changeset: 8b9bbe3b2e83 Author: omajid Date: 2014-05-08 19:27 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/8b9bbe3b2e83 8042806: Splashscreen uses libjpeg-internal macros Reviewed-by: anthony, prr ! src/share/native/sun/awt/splashscreen/splashscreen_jpeg.c Changeset: e343eef24517 Author: anashaty Date: 2014-05-12 18:21 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e343eef24517 8024932: [TEST_BUG] [macosx] javax/swing/text/StyledEditorKit/8016833/bug8016833.java failed Reviewed-by: serb, alexsch ! test/javax/swing/text/StyledEditorKit/8016833/bug8016833.java Changeset: 1a6c78863ead Author: prr Date: 2014-05-12 09:32 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/1a6c78863ead 8038876: Remove use of ServiceLoader in finding class implementing sun.java2d.cmm.CMMServiceProvider Reviewed-by: bae, mchung ! make/CopyIntoClasses.gmk ! make/profile-rtjar-includes.txt ! src/share/classes/sun/java2d/cmm/CMSManager.java - src/share/classes/sun/java2d/cmm/lcms/META-INF/services/sun.java2d.cmm.CMMServiceProvider Changeset: a0fcf95f8143 Author: prr Date: 2014-05-12 09:38 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/a0fcf95f8143 Merge - src/solaris/classes/java/lang/UNIXProcess.java.aix - src/solaris/classes/java/lang/UNIXProcess.java.bsd - src/solaris/classes/java/lang/UNIXProcess.java.linux - src/solaris/classes/java/lang/UNIXProcess.java.solaris Changeset: 30544a627823 Author: serb Date: 2014-05-13 16:06 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/30544a627823 8042007: Javadoc cleanup of javax.sound.sampled.spi package Reviewed-by: pchelko, bagiras ! src/share/classes/javax/sound/sampled/spi/AudioFileReader.java ! src/share/classes/javax/sound/sampled/spi/AudioFileWriter.java ! src/share/classes/javax/sound/sampled/spi/FormatConversionProvider.java ! src/share/classes/javax/sound/sampled/spi/MixerProvider.java Changeset: 335a1e9fce6f Author: bae Date: 2014-05-14 18:19 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/335a1e9fce6f 6945174: IndexOutOfBoundsException calling ImageIO.read() on malformed PNG Reviewed-by: prr, serb ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java + test/javax/imageio/plugins/png/ReadMalformedPngTest.java Changeset: 6f3559938123 Author: bagiras Date: 2014-05-15 20:09 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/6f3559938123 8014755: [TEST_BUG] frames didn't closed after execution some awt/dnd/ tests Reviewed-by: serb, pchelko + test/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html + test/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.java + test/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorFrame.java + test/java/awt/dnd/DragInterceptorAppletTest/InterprocessMessages.java + test/java/awt/dnd/DragInterceptorAppletTest/SourceFrame.java + test/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html + test/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java + test/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html + test/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.java ! test/java/awt/regtesthelpers/process/ProcessCommunicator.java Changeset: ba159a52edcc Author: alitvinov Date: 2014-05-15 20:21 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/ba159a52edcc 8041725: Nimbus JList selection colors persist across L&F changes Reviewed-by: alexsch, alexp ! src/share/classes/javax/swing/plaf/nimbus/skin.laf + test/javax/swing/plaf/nimbus/8041725/bug8041725.java Changeset: c793ef08dc08 Author: azvegint Date: 2014-05-15 20:24 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c793ef08dc08 8041896: Test closed/java/awt/Choice/RemoveAllShrinkTest/RemoveAllShrinkTest fails with java.awt.IllegalComponentStateException Reviewed-by: pchelko, serb ! src/macosx/classes/com/apple/laf/AquaComboBoxPopup.java ! src/macosx/classes/sun/lwawt/LWChoicePeer.java + test/java/awt/Choice/RemoveAllShrinkTest/RemoveAllShrinkTest.java Changeset: 56024e323104 Author: ddehaven Date: 2014-05-13 10:29 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/56024e323104 8003900: X11 dependencies should be removed from Mac OS X build. Reviewed-by: anthony, art, pchelko Contributed-by: David DeHaven ! make/lib/Awt2dLibraries.gmk ! src/solaris/native/sun/awt/awt.h ! src/solaris/native/sun/awt/color.h ! src/solaris/native/sun/awt/img_util_md.h ! src/solaris/native/sun/awt/utility/rect.h Changeset: f142c0938978 Author: prr Date: 2014-05-23 09:05 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/f142c0938978 Merge ! make/profile-rtjar-includes.txt ! src/share/classes/javax/swing/border/LineBorder.java ! src/share/classes/javax/swing/text/html/parser/Parser.java - src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java - src/share/classes/sun/util/spi/XmlPropertiesProvider.java - src/share/classes/sun/util/xml/META-INF/services/sun.util.spi.XmlPropertiesProvider - src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java - test/java/util/Properties/CustomProvider.java - test/java/util/Properties/MyXmlPropertiesProvider.java Changeset: e48e3e902f4c Author: robm Date: 2014-05-23 19:42 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/e48e3e902f4c 8041451: com.sun.jndi.ldap.Connection:ReadTimeout should abandon ldap request Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/ldap/Connection.java Changeset: bff46681a3f8 Author: sla Date: 2014-05-25 09:37 +0200 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/bff46681a3f8 8041923: Command line output is missing from jinfo Reviewed-by: dcubed, allwin, jbachorik ! src/share/classes/sun/tools/jinfo/JInfo.java Changeset: 461d8801b05a Author: alanb Date: 2014-05-26 15:52 +0100 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/461d8801b05a 8043958: Remove unused com.sun.pept classes from jdk repository Reviewed-by: lancea ! make/CompileJavaClasses.gmk - src/share/classes/com/sun/pept/Delegate.java - src/share/classes/com/sun/pept/encoding/Decoder.java - src/share/classes/com/sun/pept/encoding/Encoder.java - src/share/classes/com/sun/pept/ept/Acceptor.java - src/share/classes/com/sun/pept/ept/ContactInfo.java - src/share/classes/com/sun/pept/ept/ContactInfoList.java - src/share/classes/com/sun/pept/ept/ContactInfoListIterator.java - src/share/classes/com/sun/pept/ept/EPTFactory.java - src/share/classes/com/sun/pept/ept/MessageInfo.java - src/share/classes/com/sun/pept/presentation/MessageStruct.java - src/share/classes/com/sun/pept/presentation/Stub.java - src/share/classes/com/sun/pept/presentation/TargetFinder.java - src/share/classes/com/sun/pept/presentation/Tie.java - src/share/classes/com/sun/pept/protocol/Interceptors.java - src/share/classes/com/sun/pept/protocol/MessageDispatcher.java - src/share/classes/com/sun/pept/transport/Connection.java Changeset: c33989af5014 Author: igerasim Date: 2014-05-26 19:59 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/c33989af5014 8043476: java/util/BitSet/BSMethods.java failed with: java.lang.OutOfMemoryError: Java heap space Reviewed-by: alanb ! test/java/util/BitSet/BSMethods.java Changeset: 7d144f6951bc Author: vlivanov Date: 2014-02-24 18:11 +0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/7d144f6951bc 8037210: Get rid of char-based descriptions 'J' of basic types Reviewed-by: jrose, psandoz, twisti ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/SimpleMethodHandle.java + test/java/lang/invoke/LambdaFormTest.java Changeset: 2f3cbac99c10 Author: wmdietl Date: 2014-05-26 17:14 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/jdk/rev/2f3cbac99c10 Automated merge with http://hg.openjdk.java.net/jdk9/dev/jdk ! .hgtags ! make/CompileJavaClasses.gmk ! src/macosx/classes/sun/font/CFontManager.java ! src/share/classes/java/awt/AWTKeyStroke.java ! src/share/classes/java/awt/CardLayout.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/javax/accessibility/AccessibleContext.java ! src/share/classes/javax/swing/border/BevelBorder.java ! src/share/classes/javax/swing/border/EtchedBorder.java ! src/share/classes/javax/swing/border/LineBorder.java ! src/share/classes/javax/swing/colorchooser/AbstractColorChooserPanel.java ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/share/classes/javax/swing/text/JTextComponent.java ! src/share/classes/javax/swing/text/html/StyleSheet.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/image/ImageRepresentation.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/java2d/Disposer.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/share/classes/sun/java2d/cmm/CMSManager.java ! src/share/classes/sun/misc/VM.java ! src/share/classes/sun/tools/jinfo/JInfo.java ! src/share/transport/socket/socketTransport.c ! src/solaris/classes/sun/awt/X11/XDataTransferer.java ! src/solaris/classes/sun/awt/X11/XDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java ! src/solaris/classes/sun/awt/X11/XMenuWindow.java ! src/solaris/classes/sun/awt/X11/XPopupMenuPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java ! src/solaris/native/sun/awt/awt_LoadLibrary.c ! src/windows/classes/sun/awt/windows/WToolkit.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java From wdietl at gmail.com Mon May 26 21:23:04 2014 From: wdietl at gmail.com (wdietl at gmail.com) Date: Mon, 26 May 2014 21:23:04 +0000 Subject: hg: type-annotations/type-annotations/langtools: 6 new changesets Message-ID: <201405262123.s4QLNGnb012571@aojmv0008> Changeset: 87491833da58 Author: pgovereau Date: 2014-05-16 17:08 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/87491833da58 8015927: Class reference duplicates in constant pool Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java + test/tools/javac/jvm/ClassRefDupInConstantPoolTest.java Changeset: 30e0e2a21c7d Author: ntoda Date: 2014-05-20 15:50 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/30e0e2a21c7d 8042406: javac.jvm.ClassReader.readClassFile() is using Target to verify valid major versions Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java Changeset: 282210d7b08b Author: katleman Date: 2014-05-22 12:54 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/282210d7b08b Added tag jdk9-b14 for changeset 1df3f53b9d98 ! .hgtags Changeset: 1948f43148ec Author: lana Date: 2014-05-22 14:39 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/1948f43148ec Merge - src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java Changeset: a43b8dbe5f50 Author: sogoel Date: 2014-05-22 15:42 -0700 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/a43b8dbe5f50 8043336: Missing bug id in test/tools/javac/lambda/TargetType23.java Reviewed-by: jjg, vromero, dlsmith ! test/tools/javac/lambda/TargetType23.java Changeset: cb0e8e67d555 Author: wmdietl Date: 2014-05-26 17:22 -0400 URL: http://hg.openjdk.java.net/type-annotations/type-annotations/langtools/rev/cb0e8e67d555 Automated merge with http://hg.openjdk.java.net/jdk9/dev/langtools ! .hgtags ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java