[type-annos-observers] "final" ReceiverParameter?

Michael Ernst mernst at cs.washington.edu
Tue Oct 22 09:05:41 PDT 2013


I concur with both of these comments.  Thanks, Markus, for your careful reading!

                    -Mike


> Subject: "final" ReceiverParameter? (was: Public Review for JSR 308)
> From: Markus Keller <markus_keller at ch.ibm.com>
> To: type-annotations-spec-comments at openjdk.java.net
> Date: Mon, 21 Oct 2013 17:32:16 +0200
> 
> Alex Buckley <alex.buckley at oracle.com> wrote on 2013-10-16 20:32:38:
> 
>> http://cr.openjdk.java.net/~abuckley/308.pdf
> 
> Two more nits:
> 
> 1.
> 
> ReceiverParameter:
>   {VariableModifier} UnannType {Identifier .} this
> 
> VariableModifier syntactically allows annotations and "final". I don't 
> think "final" makes sense here, not even optional. {VariableModifier} 
> would better be replaced by {Annotation}. Otherwise, we'd need some spec 
> text that tells that "final" is not a legal modifier for a receiver 
> parameter.
> 
> 2. Typo on p.18: "that type is the type is the newly constructed object"
>    => 2nd "is" should be "of"           ^^
> 
> Markus


More information about the type-annotations-spec-observers mailing list