hg: valhalla/valhalla/langtools: Add more type information to bytecode mapping associated to member items

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Thu Aug 14 22:47:00 UTC 2014


On 14/08/14 21:35, Remi Forax wrote:
> Hi Maurizio,
> I've seen that you have also changed the format of BytecodeMapping,
> the signature field is now an offset to a String which is an offset to 
> the UTF8 entry instead of being directly an offset to the UTF8 entry,
> (it's now a String instead of a Name in term of javac object)
Well-spotted, I noticed that when tweaking the harness - I now realize 
that there's a slight signature skew between Types.typeSig and 
ClassWriter.typeSig, as one returns a String while the other a Name. It 
should be an UTF-8, I'll change Types.typeSig to return a Name too.

Maurizio
>
> Is it a bug or a feature ?
>
> cheers,
> Rémi
>
> On 08/14/2014 04:33 PM, maurizio.cimadamore at oracle.com wrote:
>> Changeset: 944eb6b60804
>> Author:    mcimadamore
>> Date:      2014-08-14 15:29 +0100
>> URL: 
>> http://hg.openjdk.java.net/valhalla/valhalla/langtools/rev/944eb6b60804
>>
>> Add more type information to bytecode mapping associated to member items
>> *) Member items should generate a mapping of the kind 'O::M', where O 
>> is the signature of the (instantiated) owner type and M is the 
>> signature of the (instantiated) member type
>> *) Moved some useful routines from Items to Types
>> *) Added more tests for nested generics
>>
>> ! src/share/classes/com/sun/tools/javac/code/Types.java
>> ! src/share/classes/com/sun/tools/javac/comp/Attr.java
>> ! src/share/classes/com/sun/tools/javac/comp/Infer.java
>> ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
>> ! src/share/classes/com/sun/tools/javac/jvm/Code.java
>> ! src/share/classes/com/sun/tools/javac/jvm/Gen.java
>> ! src/share/classes/com/sun/tools/javac/jvm/Items.java
>> + test/tools/javac/valhalla/typespec/items/tests/TestNestedGenerics.java
>>
>



More information about the valhalla-dev mailing list