VarHandles & LMAX Disruptor

Paul Sandoz paul.sandoz at oracle.com
Wed Jul 29 10:56:17 UTC 2015


On 29 Jul 2015, at 12:19, Kirk Pepperdine <kirk.pepperdine at gmail.com> wrote:
>>> 
>>> I am marginally in favour of the keeping the default accessors. FWIW they have parity with method handle field setters/getters (and of course get/putfield).
>>> 
>>> Vitaly, i think it’s ok to experiment. We can easily remove the default accessors if we eventually conclude these are more of a nuisance.
>> 
>> Not sure I agree, it feels a bit like API smell to have both versions. but yeah they can be removed at any point in time.
> 
> Without a backward compatibility issues?

We are talking in the context of pre-Java 9 integration. The API should be locked down once we integrate.

Paul.

> 
> At any rate, I always vote for readability so this is a welcome change. FWIW, there is quite a bit of JDK code that would not pass our internal code reviews based on this point.
> 
> Regards,
> Kirk
> 




More information about the valhalla-dev mailing list