Fail to build on windows 'g1ParScanThreadState.cpp'

[Volker Simonis]

Hi Boaz,

I'm a little confused about which hotspot version the valhalla repo is
based on. Your output mentions "JDK8Build" but from the path and line
information this should be jdk9.

That said, I think your problem is related to "8141134: Remove unnecessary
pragma warning(disable:4355) from GC code (
https://bugs.openjdk.java.net/browse/JDK-8141134)". It removed the pragma
which suppressed the warning C4355 from several files, but instead added it
globally for  VS less than 2013 (i.e. _MSC_VER < 1800) which should match
your compiler. You should have the following code in
src/share/vm/utilities/globalDefinitions_visCPP.hpp:

#if _MSC_VER < 1800
// Visual Studio 2013 introduced strtoull(); before, one has to use
_strtoui64() instead.
#define strtoull _strtoui64
// Fixes some wrong warnings about 'this' : used in base member initializer
list
#pragma warning( disable : 4355 )
#endif

If it's not there, you should just sync valhalla with the latest jdk9 or
use VS2013 or newer.

Regards,
Volker


On Sat, Nov 28, 2015 at 7:51 PM, Boaz Nahum <boaznahum at gmail.com> wrote:

> Hi.
> (Please correct me if I need to send to different group)
> I'm building valhalla on daily basis, lately I have a little problem with
> g1ParScanThreadState.cpp
>
> I tried to configure with '--disable-warnings-as-errors' - no luck
>
> Compiling 72 files for java.sql
> Compiling 281 files for java.xml.crypto
>
> F:\Dev\JDK8Build\valhalla\hotspot\src\share\vm\gc\g1\g1ParScanThreadState.cpp(46)
> : warning C4355: 'this' : used in base member initializer list
> Compiling 50 files for java.sql.rowset
> NMAKE : fatal error U1077: 'D:\ProgFiles\VS10.0\VC\BIN\amd64\cl.exe' :
> return code '0x2'
> Stop.
> NMAKE : fatal error U1077: 'cd' : return code '0x2'
> Stop.
> NMAKE : fatal error U1077: 'D:\ProgFiles\VS10.0\VC\BIN\amd64\nmake.EXE' :
> return code '0x2'
> Stop.
> Makefile:230: recipe for target 'generic_build2' failedmake[5]: ***
> [generic_build2] Error 2
>
> Please note that I tried temporarily replacing 'this' with 'NULL' - I just
> got the same error in other file. So I gave up:
>
> Thank
> Boaz
>