RFR: 8183137: [MVT] C2 doesn't eliminate redundant value type allocations inside loops

Tobias Hartmann tobias.hartmann at oracle.com
Thu Jul 13 11:04:14 UTC 2017


Hi Roland,

> http://cr.openjdk.java.net/~roland/8183137/webrev.01/

This looks good to me!

Just some minor things:
- little typo in valuetypenode.hpp:134  ValueTypeNode -> ValueTypePtrNode
- for better readability, you could merge test95_mt/test95_mt3/test96_mt/test96_mt3 in ValueTypeTestBench.java because they are identical

> There are tests such as test95/test96 for which the allocation is still
> not eliminated but could be by improving this further.

Is this because C2 does not inline the non-static method handle calls? You've mentioned off-thread that you are working on fixing this. What's your plan there?

Thanks,
Tobias


More information about the valhalla-dev mailing list