Crash with "assert(number_of_codes <= 256) failed: too many bytecodes"

[Maurizio Cimadamore]

On 27/07/17 16:57, Tobias Hartmann wrote:
> Hi Maurizio,
>
> On 27.07.2017 17:55, Maurizio Cimadamore wrote:
>> Looks good. Do you want to push?
> Sure, I'll push it.
>
>> Also, why did I not see the issue when running all tests?
> Did you run with a debug build? Maybe your build cached some files. Re-building after changing bytecodes.hpp should take a long time.
Nope - I ran with product build
Maurizio
>
> Best regards,
> Tobias
>
>> On 27/07/17 16:31, Tobias Hartmann wrote:
>>> Hi,
>>>
>>> seems like this is due to:
>>> http://hg.openjdk.java.net/valhalla/valhalla/hotspot/rev/dbb31857c4d4
>>>
>>> If I count correctly, adding _vgetfield at the end 'causes number_of_codes' to be 257 and thus we fail.
>>>
>>> We should reset the value type bytecode numbers:
>>>
>>> diff -r 5cd8d5559192 src/share/vm/interpreter/bytecodes.hpp
>>> --- a/src/share/vm/interpreter/bytecodes.hpp    Thu Jul 27 16:00:00 2017 +0100
>>> +++ b/src/share/vm/interpreter/bytecodes.hpp    Thu Jul 27 17:23:40 2017 +0200
>>> @@ -248,11 +248,11 @@
>>>        _vstore               = 204, // 0xcc
>>>        _vaload               = 205, // 0xcd
>>>        _vastore              = 206, // 0xce
>>> -    _vreturn              = 210, // 0xd2
>>> -    _vdefault             = 214, // 0xd6
>>> -    _vwithfield           = 215, // 0xd7
>>> -    _vbox                 = 216, // 0xd6
>>> -    _vunbox               = 217, // 0xd7
>>> +    _vreturn              = 207, // 0xcf
>>> +    _vdefault             = 208, // 0xd0
>>> +    _vwithfield           = 209, // 0xd1
>>> +    _vbox                 = 210, // 0xd2
>>> +    _vunbox               = 211, // 0xd3
>>>          number_of_java_codes,
>>>
>>> Thanks,
>>> Tobias