RFR JDK-8181425: Reflection API defend against issues with internal VM derived value type

Mandy Chung mandy.chung at oracle.com
Wed Jun 21 02:26:28 UTC 2017


> On Jun 20, 2017, at 4:19 PM, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
> 
> The new version looks good - I wonder if we should add a dual method called isValueCapable(Class<?>) and use that for the assertion check? The method would look at the class, retrieve the @VCC annotation and return true if one such annotation exists.
> 
> As things stand, it is possible to pass classes to the loadValueClassType that are not VCC but which fail to trigger the assertion check.
> 
> Probably a nitpick - but since we're tweaking in this area…
> 

I added the isValueCapable method and made further clean up that I think
MinimalValueTypes_1_0 class is clearer.

http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8181425/webrev.01/index.html

Mandy


More information about the valhalla-dev mailing list