[Nestmates] RFR: 8187768 and 8189940 - nest host resolution and exceptions

David Holmes david.holmes at oracle.com
Thu Nov 2 21:25:27 UTC 2017


On 3/11/2017 3:23 AM, John Rose wrote:
> On Nov 2, 2017, at 6:01 AM, Maurizio Cimadamore 
> <maurizio.cimadamore at oracle.com <mailto:maurizio.cimadamore at oracle.com>> 
> wrote:
>>
>> On 01/11/17 22:23, David Holmes wrote:
>>> The ClassInfo has to refer to a class else it gets rejected, but it 
>>> can't be a class for a primitive or array type, or ?? - it has to be 
>>> an instance class. As I don't really expect anyone to ever encounter 
>>> this in practice I'm not too concerned if it seems a little cryptic. 
>>> The full message looks like this:
>> Right - I'm just suggesting to drop 'instance' from the message (as 
>> that seems to be inspired from instanceKlass, which doesn't have a 
>> real spec'd counterpart). Not feeling super strongly about it though.
> 
> +1 on removing 'instance'

Ok.

Thanks,
David
-----

> The classfile parser has similar checks for super-class and interfaces,
> so you could just adapt the error-reporting language near those checks.
> For example, near line 3639 of classFileParser.cpp:
> 
>      if (need_verify) {
>        guarantee_property(!is_array,
>                          "Bad superclass name in class file %s", 
> CHECK_NULL);
>      }
> 
> 
> — John



More information about the valhalla-dev mailing list