From forax at univ-mlv.fr Sat Aug 4 17:12:47 2018 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 4 Aug 2018 19:12:47 +0200 (CEST) Subject: VM crash Message-ID: <1327988994.192674.1533402767955.JavaMail.zimbra@u-pem.fr> Hi all, i've found a crash when the VM is running some of my unit tests. download all the jars from http://monge.univ-mlv.fr/~forax/tmp/lworld/ run this command line /usr/jdk/jdk-11-lworldea/bin/java -XX:+EnableValhalla --module-path test-fr.umlv.valuetype-1.0.jar:org.junit.jupiter.api.jar:org.junit.jupiter.params.jar:org.junit.platform.commons.jar:org.apiguardian.api.jar:org.opentest4j.jar --add-modules fr.umlv.valuetype --class-path junit-platform-console-standalone-1.3.0-M1.jar org.junit.platform.console.ConsoleLauncher --select-module fr.umlv.valuetype and it should crash Note: i've not exactly the same error when i do not use the standalone console launcher of JUnit so there are maybe more that one issue. regards, R?mi From tobias.hartmann at oracle.com Mon Aug 6 08:40:37 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 6 Aug 2018 10:40:37 +0200 Subject: VM crash In-Reply-To: <1327988994.192674.1533402767955.JavaMail.zimbra@u-pem.fr> References: <1327988994.192674.1533402767955.JavaMail.zimbra@u-pem.fr> Message-ID: <5de7169b-05b6-7ca1-1527-6691dd482d9b@oracle.com> Hi Remi, thanks a lot for reporting this issue. The following jars were missing but I still had them around and could reproduce the crash: org.openjdk.jmh.jar:org.openjdk.jmh.generator.jar:org.apache.commons.math3.jar:net.sf.jopt-simple.jar I've filed: https://bugs.openjdk.java.net/browse/JDK-8209009 Thanks, Tobias On 04.08.2018 19:12, Remi Forax wrote: > -XX:+EnableValhalla --module-path test-fr.umlv.valuetype-1.0.jar:org.junit.jupiter.api.jar:org.junit.jupiter.params.jar:org.junit.platform.commons.jar:org.apiguardian.api.jar:org.opentest4j.jar --add-modules fr.umlv.valuetype --class-path junit-platform-console-standalone-1.3.0-M1.jar org.junit.platform.console.ConsoleLauncher --select-module fr.umlv.valuetype From tobias.hartmann at oracle.com Mon Aug 6 09:15:51 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 6 Aug 2018 11:15:51 +0200 Subject: VM crash In-Reply-To: <5de7169b-05b6-7ca1-1527-6691dd482d9b@oracle.com> References: <1327988994.192674.1533402767955.JavaMail.zimbra@u-pem.fr> <5de7169b-05b6-7ca1-1527-6691dd482d9b@oracle.com> Message-ID: It's a problem with bimorphic inlining in C2. Workaround: -XX:-UseBimorphicInlining Best regards, Tobias On 06.08.2018 10:40, Tobias Hartmann wrote: > Hi Remi, > > thanks a lot for reporting this issue. The following jars were missing but I still had them around > and could reproduce the crash: > org.openjdk.jmh.jar:org.openjdk.jmh.generator.jar:org.apache.commons.math3.jar:net.sf.jopt-simple.jar > > I've filed: > https://bugs.openjdk.java.net/browse/JDK-8209009 > > Thanks, > Tobias > > On 04.08.2018 19:12, Remi Forax wrote: >> -XX:+EnableValhalla --module-path test-fr.umlv.valuetype-1.0.jar:org.junit.jupiter.api.jar:org.junit.jupiter.params.jar:org.junit.platform.commons.jar:org.apiguardian.api.jar:org.opentest4j.jar --add-modules fr.umlv.valuetype --class-path junit-platform-console-standalone-1.3.0-M1.jar org.junit.platform.console.ConsoleLauncher --select-module fr.umlv.valuetype From forax at univ-mlv.fr Mon Aug 6 10:16:52 2018 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Mon, 6 Aug 2018 12:16:52 +0200 (CEST) Subject: VM crash In-Reply-To: References: <1327988994.192674.1533402767955.JavaMail.zimbra@u-pem.fr> <5de7169b-05b6-7ca1-1527-6691dd482d9b@oracle.com> Message-ID: <1062569939.24891.1533550612769.JavaMail.zimbra@u-pem.fr> Hi Tobias, sorry i forgot to upload the test jar without the JMH dependencies (still not understand why the wifi never really works in US airports unlike the rest of the world). Thanks for the workaround. R?mi ----- Mail original ----- > De: "Tobias Hartmann" > ?: "Remi Forax" , "valhalla-dev" > Envoy?: Lundi 6 Ao?t 2018 11:15:51 > Objet: Re: VM crash > It's a problem with bimorphic inlining in C2. Workaround: > -XX:-UseBimorphicInlining > > Best regards, > Tobias > > On 06.08.2018 10:40, Tobias Hartmann wrote: >> Hi Remi, >> >> thanks a lot for reporting this issue. The following jars were missing but I >> still had them around >> and could reproduce the crash: >> org.openjdk.jmh.jar:org.openjdk.jmh.generator.jar:org.apache.commons.math3.jar:net.sf.jopt-simple.jar >> >> I've filed: >> https://bugs.openjdk.java.net/browse/JDK-8209009 >> >> Thanks, >> Tobias >> >> On 04.08.2018 19:12, Remi Forax wrote: >>> -XX:+EnableValhalla --module-path >>> test-fr.umlv.valuetype-1.0.jar:org.junit.jupiter.api.jar:org.junit.jupiter.params.jar:org.junit.platform.commons.jar:org.apiguardian.api.jar:org.opentest4j.jar >>> --add-modules fr.umlv.valuetype --class-path >>> junit-platform-console-standalone-1.3.0-M1.jar > >> org.junit.platform.console.ConsoleLauncher --select-module fr.umlv.valuetype From karen.kinnear at oracle.com Mon Aug 6 14:07:59 2018 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Mon, 6 Aug 2018 10:07:59 -0400 Subject: CFV: New Valhalla Committer: Ioi Lam Message-ID: <9BC9D04E-0BC4-4393-96E3-B3F575EA9997@oracle.com> Voting for Ioi Lam [1] is now closed. Yes: 13 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. thanks, Karen [1] http://mail.openjdk.java.net/pipermail/valhalla-dev/2018-July/004706.html From tobias.hartmann at oracle.com Tue Aug 7 11:37:23 2018 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Tue, 07 Aug 2018 11:37:23 +0000 Subject: hg: valhalla/valhalla: 8209009: [lworld] C2 compilation fails with 'assert(ptn != __null) failed: node should be registered' Message-ID: <201808071137.w77BbONS027723@aojmv0008.oracle.com> Changeset: d3794708550f Author: thartmann Date: 2018-08-07 13:36 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d3794708550f 8209009: [lworld] C2 compilation fails with 'assert(ptn != __null) failed: node should be registered' ! src/hotspot/share/opto/callGenerator.cpp + test/hotspot/jtreg/compiler/valhalla/valuetypes/TestBimorphicInlining.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java From tobias.hartmann at oracle.com Tue Aug 7 11:38:13 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 7 Aug 2018 13:38:13 +0200 Subject: VM crash In-Reply-To: <1062569939.24891.1533550612769.JavaMail.zimbra@u-pem.fr> References: <1327988994.192674.1533402767955.JavaMail.zimbra@u-pem.fr> <5de7169b-05b6-7ca1-1527-6691dd482d9b@oracle.com> <1062569939.24891.1533550612769.JavaMail.zimbra@u-pem.fr> Message-ID: <388ef57c-71e4-1cfc-5382-995d93f77816@oracle.com> Hi Remi, I've just pushed a fix for this issue. Your test should now pass. Best regards, Tobias On 06.08.2018 12:16, forax at univ-mlv.fr wrote: > Hi Tobias, > sorry i forgot to upload the test jar without the JMH dependencies > (still not understand why the wifi never really works in US airports unlike the rest of the world). > > Thanks for the workaround. > > R?mi > > ----- Mail original ----- >> De: "Tobias Hartmann" >> ?: "Remi Forax" , "valhalla-dev" >> Envoy?: Lundi 6 Ao?t 2018 11:15:51 >> Objet: Re: VM crash > >> It's a problem with bimorphic inlining in C2. Workaround: >> -XX:-UseBimorphicInlining >> >> Best regards, >> Tobias >> >> On 06.08.2018 10:40, Tobias Hartmann wrote: >>> Hi Remi, >>> >>> thanks a lot for reporting this issue. The following jars were missing but I >>> still had them around >>> and could reproduce the crash: >>> org.openjdk.jmh.jar:org.openjdk.jmh.generator.jar:org.apache.commons.math3.jar:net.sf.jopt-simple.jar >>> >>> I've filed: >>> https://bugs.openjdk.java.net/browse/JDK-8209009 >>> >>> Thanks, >>> Tobias >>> >>> On 04.08.2018 19:12, Remi Forax wrote: >>>> -XX:+EnableValhalla --module-path >>>> test-fr.umlv.valuetype-1.0.jar:org.junit.jupiter.api.jar:org.junit.jupiter.params.jar:org.junit.platform.commons.jar:org.apiguardian.api.jar:org.opentest4j.jar >>>> --add-modules fr.umlv.valuetype --class-path >>>> junit-platform-console-standalone-1.3.0-M1.jar >>>> org.junit.platform.console.ConsoleLauncher --select-module fr.umlv.valuetype From tobias.hartmann at oracle.com Tue Aug 7 11:39:33 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 7 Aug 2018 13:39:33 +0200 Subject: hg: valhalla/valhalla: 8209009: [lworld] C2 compilation fails with 'assert(ptn != __null) failed: node should be registered' In-Reply-To: <201808071137.w77BbONS027723@aojmv0008.oracle.com> References: <201808071137.w77BbONS027723@aojmv0008.oracle.com> Message-ID: The problem was that bimorphic inlining needs to allocate value types before merging the fast and slow path: http://cr.openjdk.java.net/~thartmann/8209009/webrev.00/ Thanks, Tobias On 07.08.2018 13:37, tobias.hartmann at oracle.com wrote: > Changeset: d3794708550f > Author: thartmann > Date: 2018-08-07 13:36 +0200 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d3794708550f > > 8209009: [lworld] C2 compilation fails with 'assert(ptn != __null) failed: node should be registered' > > ! src/hotspot/share/opto/callGenerator.cpp > + test/hotspot/jtreg/compiler/valhalla/valuetypes/TestBimorphicInlining.java > ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java > From tobias.hartmann at oracle.com Wed Aug 8 16:39:34 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 8 Aug 2018 18:39:34 +0200 Subject: RFR(M): 8209134: [lworld] New nmethod entry point for unscalarized (nullable) value type arguments Message-ID: <55c3f0c2-c951-4ee2-e5eb-9120e42d1177@oracle.com> Hi, please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8209134 http://cr.openjdk.java.net/~thartmann/8209134/webrev.00/ This patch adds a new entry point to nmethods that have a value type argument. This "Verified Value Entry Point" jumps to the c2i adapter if any of the value type arguments is null. Like this, we can avoid explicit null checks in the C2 IR which significantly reduces code size and complexity. More important, we can now completely avoid null checking when calling from compiled code by using the "normal" entry point. The "Verified Value Entry Point" is only used in the i2c adapter and the method handle dispatch code (because both may pass NULL for a value type whereas compiled code never passes NULL). The nmethod entries for TestValueTypeEntryPoint.test1 now look like this: [Verified Value Entry Point] 0x00007fc7751ffb60: test %rdx,%rdx 0x00007fc7751ffb63: je 0x00007fc7751ecc62 ; {runtime_call I2C/C2I adapters} 0x00007fc7751ffb69: test %rcx,%rcx 0x00007fc7751ffb6c: je 0x00007fc7751ecc62 ; {runtime_call I2C/C2I adapters} [...] 0x00007fc7751ffbba: cmpq $0x0,0x20(%rsp) 0x00007fc7751ffbc3: je 0x00007fc7751ecc62 ; {runtime_call I2C/C2I adapters} 0x00007fc7751ffbc9: jmpq 0x00007fc7751ffbf0 [Entry Point] 0x00007fc7751ffbce: mov 0x8(%rsi),%r10d 0x00007fc7751ffbd2: movabs $0x800000000,%r12 0x00007fc7751ffbdc: add %r12,%r10 0x00007fc7751ffbdf: xor %r12,%r12 0x00007fc7751ffbe2: cmp %r10,%rax 0x00007fc7751ffbe5: jne 0x00007fc7750577a0 ; {runtime_call ic_miss_stub} 0x00007fc7751ffbeb: nop 0x00007fc7751ffbec: nop 0x00007fc7751ffbed: nop 0x00007fc7751ffbee: nop 0x00007fc7751ffbef: nop [Verified Entry Point] [...] For details, compare the generated code with [1] and without [2] the patch. An unverified entry point is not required because it's only called from compiled code (inline caches). I also came up with branchless null checking using setne instructions: [Verified Value Entry Point] 0x00007f7b89164540: xor %r13,%r13 0x00007f7b89164543: test %rdx,%rdx 0x00007f7b89164546: setne %r13b 0x00007f7b8916454a: dec %r13 0x00007f7b8916454d: test %rcx,%rcx 0x00007f7b89164550: setne %r13b 0x00007f7b89164554: dec %r13 [...] 0x00007f7b891645a5: cmpq $0x0,0x20(%rsp) 0x00007f7b891645ae: setne %r13b 0x00007f7b891645b2: dec %r13 0x00007f7b891645b5: jne 0x00007f7b8915f0e2 ; {runtime_call I2C/C2I adapters} 0x00007f7b891645bb: jmpq 0x00007f7b891645e0 But since I couldn't measure any performance difference, I went with the explicit checks. All tests pass. Thanks, Tobias [1] https://bugs.openjdk.java.net/secure/attachment/78094/TestValueTypeEntryPoint.log [2] https://bugs.openjdk.java.net/secure/attachment/78095/TestValueTypeEntryPoint_Old.log From dl at cs.oswego.edu Wed Aug 8 18:33:01 2018 From: dl at cs.oswego.edu (Doug Lea) Date: Wed, 8 Aug 2018 14:33:01 -0400 Subject: Value type sorting Message-ID: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> I've been exploring sorting algorithms (mainly parallel but also sequential) that should apply well to value types. Even though Valhalla is not yet at a state where you can use generic by-value Comparables, I've been trying things out by manually plugging in various types, in part to scope out future issues. Sorting is the most famous example of a problem for which no algorithm is always best. Among other things, performance varies with element comparison vs copying cost, parallelism support, workspace overhead, and trade-offs of average vs worst case behavior. I placed a snapshot of the current Goldilocks candidate balancing these for value types at: http://gee.cs.oswego.edu/dl/wwwtmp/CVSorter.java The internal documentation describes some of the algorithmic choices. As the instruction near the top indicate, for now you need to plug in any __ByValue class named "CVal". This compiles and runs using current (build zero) early access (http://jdk.java.net/valhalla/). Just for comparison, there's also an otherwise identical version for long[] arrays at: http://gee.cs.oswego.edu/dl/wwwtmp/LongSorter.java When using a __ByValue type just emulating a single long, CVSorter seems to be only 5% or so slower than LongSorter sorting 100 million elements, which is pretty good for using something labeled build zero. But CVSorter also works well with various small or medium-sized value types. Any feedback would be welcome. It would be especially nice to hear from anyone who has actual data and types that need sorting. There are a lot of synthetic loads available (it does well on most), but having some actual cases that anyone might be dealing with in the future would be helpful. -Doug From forax at univ-mlv.fr Wed Aug 8 19:34:42 2018 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 8 Aug 2018 21:34:42 +0200 (CEST) Subject: Value type sorting In-Reply-To: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> References: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> Message-ID: <1329843440.121903.1533756882405.JavaMail.zimbra@u-pem.fr> Hi Doug, the example of CVal in CVSorter is weird, *
 {@code
 * __ByValue class CVal {
 *   final long field1;
 *   final long field2;
 *   public CVal(long f2, long f2) { field1 = f1; field2 = f2; }
 *   public int compareTo(CVal b) {
 *       return (field1 < b.field1) ? -1 : (field1 == b.field1) ? 0 : 1;
 *   }
 * }}
why do you have two long fields instead of one, it doesn't seem to be a fair comparison. Also, your constructor is weird (f2 is defined twice). R?mi ----- Mail original ----- > De: "Doug Lea"
> ?: "valhalla-dev" > Envoy?: Mercredi 8 Ao?t 2018 20:33:01 > Objet: Value type sorting > I've been exploring sorting algorithms (mainly parallel but also > sequential) that should apply well to value types. Even though Valhalla > is not yet at a state where you can use generic by-value Comparables, > I've been trying things out by manually plugging in various types, in > part to scope out future issues. Sorting is the most famous example of a > problem for which no algorithm is always best. Among other things, > performance varies with element comparison vs copying cost, parallelism > support, workspace overhead, and trade-offs of average vs worst case > behavior. I placed a snapshot of the current Goldilocks candidate > balancing these for value types at: > http://gee.cs.oswego.edu/dl/wwwtmp/CVSorter.java > The internal documentation describes some of the algorithmic choices. > As the instruction near the top indicate, for now you need to plug in > any __ByValue class named "CVal". This compiles and runs using current > (build zero) early access (http://jdk.java.net/valhalla/). > > Just for comparison, there's also an otherwise identical version for > long[] arrays at: > http://gee.cs.oswego.edu/dl/wwwtmp/LongSorter.java > When using a __ByValue type just emulating a single long, CVSorter seems > to be only 5% or so slower than LongSorter sorting 100 million elements, > which is pretty good for using something labeled build zero. But > CVSorter also works well with various small or medium-sized value types. > > Any feedback would be welcome. It would be especially nice to hear from > anyone who has actual data and types that need sorting. There are a lot > of synthetic loads available (it does well on most), but having some > actual cases that anyone might be dealing with in the future would be > helpful. > > -Doug From dl at cs.oswego.edu Wed Aug 8 19:43:27 2018 From: dl at cs.oswego.edu (Doug Lea) Date: Wed, 8 Aug 2018 15:43:27 -0400 Subject: Value type sorting In-Reply-To: <1329843440.121903.1533756882405.JavaMail.zimbra@u-pem.fr> References: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> <1329843440.121903.1533756882405.JavaMail.zimbra@u-pem.fr> Message-ID: On 08/08/2018 03:34 PM, Remi Forax wrote: > Hi Doug, > the example of CVal in CVSorter is weird, > > *
 {@code
>  * __ByValue class CVal {
>  *   final long field1;
>  *   final long field2;
>  *   public CVal(long f2, long f2) { field1 = f1; field2 = f2; }

Thanks. I fixed typo: first f2 should be f1

> why do you have two long fields instead of one, it doesn't seem to be a fair comparison.

It's not fair for comparing vs plain long[] (and is not the version used
for that), but shows a typical case in which not all fields are used in
comparator.

-Doug


> 
> ----- Mail original -----
>> De: "Doug Lea" 
>> ?: "valhalla-dev" >> Envoy?: Mercredi 8 Ao?t 2018 20:33:01 >> Objet: Value type sorting > >> I've been exploring sorting algorithms (mainly parallel but also >> sequential) that should apply well to value types. Even though Valhalla >> is not yet at a state where you can use generic by-value Comparables, >> I've been trying things out by manually plugging in various types, in >> part to scope out future issues. Sorting is the most famous example of a >> problem for which no algorithm is always best. Among other things, >> performance varies with element comparison vs copying cost, parallelism >> support, workspace overhead, and trade-offs of average vs worst case >> behavior. I placed a snapshot of the current Goldilocks candidate >> balancing these for value types at: >> http://gee.cs.oswego.edu/dl/wwwtmp/CVSorter.java >> The internal documentation describes some of the algorithmic choices. >> As the instruction near the top indicate, for now you need to plug in >> any __ByValue class named "CVal". This compiles and runs using current >> (build zero) early access (http://jdk.java.net/valhalla/). >> >> Just for comparison, there's also an otherwise identical version for >> long[] arrays at: >> http://gee.cs.oswego.edu/dl/wwwtmp/LongSorter.java >> When using a __ByValue type just emulating a single long, CVSorter seems >> to be only 5% or so slower than LongSorter sorting 100 million elements, >> which is pretty good for using something labeled build zero. But >> CVSorter also works well with various small or medium-sized value types. >> >> Any feedback would be welcome. It would be especially nice to hear from >> anyone who has actual data and types that need sorting. There are a lot >> of synthetic loads available (it does well on most), but having some >> actual cases that anyone might be dealing with in the future would be >> helpful. >> >> -Doug > From paul.sandoz at oracle.com Thu Aug 9 16:50:24 2018 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Thu, 9 Aug 2018 09:50:24 -0700 Subject: VM crash In-Reply-To: <388ef57c-71e4-1cfc-5382-995d93f77816@oracle.com> References: <1327988994.192674.1533402767955.JavaMail.zimbra@u-pem.fr> <5de7169b-05b6-7ca1-1527-6691dd482d9b@oracle.com> <1062569939.24891.1533550612769.JavaMail.zimbra@u-pem.fr> <388ef57c-71e4-1cfc-5382-995d93f77816@oracle.com> Message-ID: <3F85F65C-A63A-43EA-9B8B-6E1FE90D2F44@oracle.com> I believe this may also have fixed a VarHandle value access test i have cooking which pretty aggressively accesses value fields. Thanks! Paul. > On Aug 7, 2018, at 4:38 AM, Tobias Hartmann wrote: > > Hi Remi, > > I've just pushed a fix for this issue. Your test should now pass. > > Best regards, > Tobias > > On 06.08.2018 12:16, forax at univ-mlv.fr wrote: >> Hi Tobias, >> sorry i forgot to upload the test jar without the JMH dependencies >> (still not understand why the wifi never really works in US airports unlike the rest of the world). >> >> Thanks for the workaround. >> >> R?mi >> >> ----- Mail original ----- >>> De: "Tobias Hartmann" >>> ?: "Remi Forax" , "valhalla-dev" >>> Envoy?: Lundi 6 Ao?t 2018 11:15:51 >>> Objet: Re: VM crash >> >>> It's a problem with bimorphic inlining in C2. Workaround: >>> -XX:-UseBimorphicInlining >>> >>> Best regards, >>> Tobias >>> >>> On 06.08.2018 10:40, Tobias Hartmann wrote: >>>> Hi Remi, >>>> >>>> thanks a lot for reporting this issue. The following jars were missing but I >>>> still had them around >>>> and could reproduce the crash: >>>> org.openjdk.jmh.jar:org.openjdk.jmh.generator.jar:org.apache.commons.math3.jar:net.sf.jopt-simple.jar >>>> >>>> I've filed: >>>> https://bugs.openjdk.java.net/browse/JDK-8209009 >>>> >>>> Thanks, >>>> Tobias >>>> >>>> On 04.08.2018 19:12, Remi Forax wrote: >>>>> -XX:+EnableValhalla --module-path >>>>> test-fr.umlv.valuetype-1.0.jar:org.junit.jupiter.api.jar:org.junit.jupiter.params.jar:org.junit.platform.commons.jar:org.apiguardian.api.jar:org.opentest4j.jar >>>>> --add-modules fr.umlv.valuetype --class-path >>>>> junit-platform-console-standalone-1.3.0-M1.jar >>>>> org.junit.platform.console.ConsoleLauncher --select-module fr.umlv.valuetype From ioi.lam at oracle.com Fri Aug 10 21:37:56 2018 From: ioi.lam at oracle.com (Ioi Lam) Date: Fri, 10 Aug 2018 14:37:56 -0700 Subject: RFR 8208163 [lworld] performance regression on String(char[]) constructor Message-ID: <4b7360e7-c9d1-858a-8259-bd66bd406b30@oracle.com> https://bugs.openjdk.java.net/browse/JDK-8208163 http://cr.openjdk.java.net/~iklam/valhalla/8208163_string_charary_ctor_slowdown.v01/ In the following code: http://hg.openjdk.java.net/valhalla/valhalla/annotate/7feb5ae0f3dc/src/hotspot/share/opto/graphKit.cpp#l3962 ? const TypeInt* length_type = _gvn.find_int_type(length); ? const TypeOopPtr* ary_type = _gvn.type(klass_node)->is_klassptr()->as_instance_type(); ? .... ? const TypeAryPtr* ary_ptr = ary_type->isa_aryptr(); ? ciKlass* elem_klass = ary_ptr != NULL ? ary_ptr->klass()->as_array_klass()->element_klass() : NULL; ? ... ? } else if (EnableValhalla && (!layout_con || elem_klass == NULL || ??????????????? (elem_klass->is_java_lang_Object() && !ary_type->klass_is_exact()))) { ??? InitializeNode* init = alloc->initialization(); ??? init->set_unknown_value(); ? } I think the intention of the (elem_klass == NULL) check is for cases like the following ? class compiler.valhalla.valuetypes.TestIntrinsics { ? public void test7(Class componentType, int len, long hash) { ????? Object[] va = (Object[])Array.newInstance(componentType, len); ????? ... The Array.newInstance call is inlined, but the array type is unknown -- newInstance returns an Object, so ary_type is java/lang/Object. However, elem_klass is also NULL for primitive arrays. This is the root cause for JDK-8208163. The fix is to replace elem_klass == NULL) with (!ary_type->isa_aryptr()), which covers the Array.newInstance case without affecting primitive arrays. Thanks - Ioi From tobias.hartmann at oracle.com Tue Aug 14 14:28:02 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 14 Aug 2018 16:28:02 +0200 Subject: RFR 8208163 [lworld] performance regression on String(char[]) constructor In-Reply-To: <4b7360e7-c9d1-858a-8259-bd66bd406b30@oracle.com> References: <4b7360e7-c9d1-858a-8259-bd66bd406b30@oracle.com> Message-ID: <17895d56-97b9-3c74-8788-c611ad239f33@oracle.com> Hi Ioi, On 10.08.2018 23:37, Ioi Lam wrote: > https://bugs.openjdk.java.net/browse/JDK-8208163 > http://cr.openjdk.java.net/~iklam/valhalla/8208163_string_charary_ctor_slowdown.v01/ It seems that with your change, we now mark all non-array allocations as "unknown value", right? This will cause PhaseMacroExpand::expand_allocate_common() to add additional runtime checks. It might be better to check for primitive arrays (TypeArrayKlass) explicitly. Also, your comment is a bit misleading because it suggests that the set_unknown_value() code is only used for reflective array creation. However, that code should be invoked whenever we create an array and don't know if the element type is a value type. To improve readability, I think it would also be good to wrap the entire code starting from line 3972 into 'if (EnableValhalla)' and not only the else branch. Thanks, Tobias From harold.seigel at oracle.com Tue Aug 14 18:26:58 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Tue, 14 Aug 2018 14:26:58 -0400 Subject: RFR 8209443: [lworld] byteMutation test asserts intermittently in the verifier Message-ID: <527cb1c3-b142-11d6-8c10-75079b5ea097@oracle.com> Hi, Please review this LWorld change for bug JDK-8209443.? The fix checks that the verificationType is not an uninitialized type before calling VerificationType.name(), preventing VerificationType::name() from asserting.? The fix also includes two small changes to use the constant pool index version of is_declared_value_type(), instead of the class name version. Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8209443/webrev/ JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8209443 The changes were tested with Mach5 tiers 1 - 5 on Linux and Mac. Additionally, the byteMutation test was run over 25 times against the fix. Thanks, Harold From frederic.parain at oracle.com Tue Aug 14 19:20:21 2018 From: frederic.parain at oracle.com (Frederic Parain) Date: Tue, 14 Aug 2018 15:20:21 -0400 Subject: RFR 8209443: [lworld] byteMutation test asserts intermittently in the verifier In-Reply-To: <527cb1c3-b142-11d6-8c10-75079b5ea097@oracle.com> References: <527cb1c3-b142-11d6-8c10-75079b5ea097@oracle.com> Message-ID: <4F5685B0-C63C-49C0-8C09-6CD1F07F4EC2@oracle.com> Looks good to me. Fred > On Aug 14, 2018, at 14:26, Harold David Seigel wrote: > > Hi, > > Please review this LWorld change for bug JDK-8209443. The fix checks that the verificationType is not an uninitialized type before calling VerificationType.name(), preventing VerificationType::name() from asserting. The fix also includes two small changes to use the constant pool index version of is_declared_value_type(), instead of the class name version. > > Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8209443/webrev/ > > JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8209443 > > The changes were tested with Mach5 tiers 1 - 5 on Linux and Mac. Additionally, the byteMutation test was run over 25 times against the fix. > > Thanks, Harold > From harold.seigel at oracle.com Tue Aug 14 19:21:17 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Tue, 14 Aug 2018 15:21:17 -0400 Subject: RFR 8209443: [lworld] byteMutation test asserts intermittently in the verifier In-Reply-To: <4F5685B0-C63C-49C0-8C09-6CD1F07F4EC2@oracle.com> References: <527cb1c3-b142-11d6-8c10-75079b5ea097@oracle.com> <4F5685B0-C63C-49C0-8C09-6CD1F07F4EC2@oracle.com> Message-ID: Thanks Fred! Harold On 8/14/2018 3:20 PM, Frederic Parain wrote: > Looks good to me. > > Fred > > >> On Aug 14, 2018, at 14:26, Harold David Seigel wrote: >> >> Hi, >> >> Please review this LWorld change for bug JDK-8209443. The fix checks that the verificationType is not an uninitialized type before calling VerificationType.name(), preventing VerificationType::name() from asserting. The fix also includes two small changes to use the constant pool index version of is_declared_value_type(), instead of the class name version. >> >> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8209443/webrev/ >> >> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8209443 >> >> The changes were tested with Mach5 tiers 1 - 5 on Linux and Mac. Additionally, the byteMutation test was run over 25 times against the fix. >> >> Thanks, Harold >> From harold.seigel at oracle.com Tue Aug 14 19:58:48 2018 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Tue, 14 Aug 2018 19:58:48 +0000 Subject: hg: valhalla/valhalla: 8209443: [lworld] byteMutation test asserts intermittently in the verifier Message-ID: <201808141958.w7EJwnJZ026496@aojmv0008.oracle.com> Changeset: 4be33f4bd64d Author: hseigel Date: 2018-08-14 15:58 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4be33f4bd64d 8209443: [lworld] byteMutation test asserts intermittently in the verifier Summary: Add check for uninitialized type before calling VerificationType::name() Reviewed-by: fparain ! src/hotspot/share/classfile/verifier.cpp From mandy.chung at oracle.com Wed Aug 15 17:45:17 2018 From: mandy.chung at oracle.com (mandy chung) Date: Wed, 15 Aug 2018 10:45:17 -0700 Subject: [lworld] RFR JDK-8207259: Ensure VarHandle compare and set/exchange work for value types Message-ID: <7411fac5-6c79-0480-6226-1e412067eaaa@oracle.com> Webrev: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8207259/webrev.01 This patch fixes the compare and set/exchange to work properly for flattened, and non-flattened value types properly. The new VarHandle access tests cover flattened, non-flattened value fields and arrays and VarHandle whose symbolic type is Object[] writing on a flattened array. - Unsafe::compareAndSetObject and compareAndExchangeObject may be called for writing to a non-flattened value field. In that case, it should perform the substitutability check (rather than identity check). We probably need some unsafe API to detect if the operands are identityless. For now, Unsafe::compareAndSetObject and compareAndExchangeObject take an additional field type parameter and determine if it's identityless based on the field type and the expected object. - refactor VarHandleObjects to split the support for flat value and generate from X-VarHandle.java.template a new class VarHandleValues at build time. I think this is a cleaner way to handle values. VarHandleObjects provides VarHandle support for references including non-flattened value fields that uses Unsafe reference access e.g getObject/putObject whereas VarHandleValues provides VarHandle support for flattened value fields that uses Unsafe flat value access. (I'm working on a separate patch to rename xxxObject to xxxReference to make the Unsafe API explicit). - VarHandleObjects.Array has to handle Object[] as the symbolic type but the array instance is a flattened value type that might have the performance impact for VarHandle for reference types. The implementation tests if VarHandle symbolic type is Object[] and the array object is flattened array and hence the impact hopefully is limited but will wait for performance number to tell. - The new VarHandleTestAccessPoint test crashes (SIGSEGV) when running with compiler. I will file a JBS issue separately. So the test for now will run only with -Xint. Thanks Mandy From forax at univ-mlv.fr Wed Aug 15 20:07:21 2018 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 15 Aug 2018 22:07:21 +0200 (CEST) Subject: [lworld] RFR JDK-8207259: Ensure VarHandle compare and set/exchange work for value types In-Reply-To: <7411fac5-6c79-0480-6226-1e412067eaaa@oracle.com> References: <7411fac5-6c79-0480-6226-1e412067eaaa@oracle.com> Message-ID: <2095238317.155214.1534363641242.JavaMail.zimbra@u-pem.fr> Hi Mandy, the use of Objects.equals to test two values is i believe wrong because a value type can have its method equals overriden but here you want to test the component wise equality bypassing the user defined equals. and as a meta/spec comment, i do not think that using a lock is the right semantics, we should not allow compareAndSet on values, as a user if i use a CAS i want the platform to use a CAS (or equivalent) not a lock, it's important that the performance model of Java stay predictable for a user. so we need a flag flattenIfAtomic which avoid flattening a field if the platform is not able to perform a CAS on the flattened value of that field. A volatile field is implicitly flattenIfAtomic, but because we can do a CAS without the field been marked volatile using VarHandles, we need a separated flag. cheers, R?mi ----- Mail original ----- > De: "mandy chung" > ?: "valhalla-dev" > Envoy?: Mercredi 15 Ao?t 2018 19:45:17 > Objet: [lworld] RFR JDK-8207259: Ensure VarHandle compare and set/exchange work for value types > Webrev: > http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8207259/webrev.01 > > This patch fixes the compare and set/exchange to work properly for > flattened, and non-flattened value types properly. The new VarHandle > access tests cover flattened, non-flattened value fields and arrays and > VarHandle whose symbolic type is Object[] writing on a flattened array. > > - Unsafe::compareAndSetObject and compareAndExchangeObject may be > called for writing to a non-flattened value field. In that case, > it should perform the substitutability check (rather than identity > check). We probably need some unsafe API to detect if the operands > are identityless. For now, Unsafe::compareAndSetObject and > compareAndExchangeObject take an additional field type parameter > and determine if it's identityless based on the field type and > the expected object. > > - refactor VarHandleObjects to split the support for flat value and > generate from X-VarHandle.java.template a new class VarHandleValues > at build time. I think this is a cleaner way to handle values. > VarHandleObjects provides VarHandle support for references including > non-flattened value fields that uses Unsafe reference access e.g > getObject/putObject whereas VarHandleValues provides VarHandle > support for flattened value fields that uses Unsafe flat value access. > > (I'm working on a separate patch to rename xxxObject to xxxReference > to make the Unsafe API explicit). > > - VarHandleObjects.Array has to handle Object[] as the symbolic type > but the array instance is a flattened value type that might have > the performance impact for VarHandle for reference types. The > implementation tests if VarHandle symbolic type is Object[] > and the array object is flattened array and hence the impact > hopefully is limited but will wait for performance number to tell. > > - The new VarHandleTestAccessPoint test crashes (SIGSEGV) when running > with compiler. I will file a JBS issue separately. So the test > for now will run only with -Xint. > > Thanks > Mandy From mandy.chung at oracle.com Wed Aug 15 21:30:18 2018 From: mandy.chung at oracle.com (mandy chung) Date: Wed, 15 Aug 2018 14:30:18 -0700 Subject: [lworld] RFR JDK-8207259: Ensure VarHandle compare and set/exchange work for value types In-Reply-To: <2095238317.155214.1534363641242.JavaMail.zimbra@u-pem.fr> References: <7411fac5-6c79-0480-6226-1e412067eaaa@oracle.com> <2095238317.155214.1534363641242.JavaMail.zimbra@u-pem.fr> Message-ID: <92cc736b-83b1-3504-d1b6-1f507040778e@oracle.com> On 8/15/18 1:07 PM, Remi Forax wrote: > Hi Mandy, > > the use of Objects.equals to test two values is i believe > wrong because a value type can have its method equals overriden but > here you want to test the component wise equality bypassing the user > defined equals. Ah, good catch. This should use System::substitutabilityTest when present. I will look into that next. > and as a meta/spec comment, i do not think that using a lock is the > right semantics, we should not allow compareAndSet on values, as a > user if i use a CAS i want the platform to use a CAS (or equivalent) > not a lock, it's important that the performance model of Java stay > predictable for a user so we need a flag flattenIfAtomic which avoid > flattening a field if the platform is not able to perform a CAS on > the flattened value of that field. A volatile field is implicitly > flattenIfAtomic, but because we can do a CAS without the field been > marked volatile using VarHandles, we need a separated flag. I was also in that line of thought whether compareAndSet on values should be allowed. Using a lock is a workaround to allow further exploration as in this prototype. BTW this patch is specific to CAS on non-flattened value fields. The flattenIfAtomic flag seems to concern on CAS on flattened value fields. Mandy [1] http://mail.openjdk.java.net/pipermail/valhalla-dev/2018-June/004509.html From tobias.hartmann at oracle.com Fri Aug 17 10:10:25 2018 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Fri, 17 Aug 2018 10:10:25 +0000 Subject: hg: valhalla/valhalla: [lworld] Refactoring of acmp related code Message-ID: <201808171010.w7HAAQr6025332@aojmv0008.oracle.com> Changeset: 43ab93c69a8f Author: thartmann Date: 2018-08-17 12:08 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/43ab93c69a8f [lworld] Refactoring of acmp related code ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/graphKit.hpp ! src/hotspot/share/opto/parse.hpp ! src/hotspot/share/opto/parse2.cpp From tobias.hartmann at oracle.com Fri Aug 17 10:13:38 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 17 Aug 2018 12:13:38 +0200 Subject: hg: valhalla/valhalla: [lworld] Refactoring of acmp related code In-Reply-To: <201808171010.w7HAAQr6025332@aojmv0008.oracle.com> References: <201808171010.w7HAAQr6025332@aojmv0008.oracle.com> Message-ID: I've also set the safe_for_replace argument for null_check_oop() in acmp to always true such that the not-null knowledge is passed on. Best regards, Tobias On 17.08.2018 12:10, tobias.hartmann at oracle.com wrote: > Changeset: 43ab93c69a8f > Author: thartmann > Date: 2018-08-17 12:08 +0200 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/43ab93c69a8f > > [lworld] Refactoring of acmp related code > > ! src/hotspot/share/opto/graphKit.cpp > ! src/hotspot/share/opto/graphKit.hpp > ! src/hotspot/share/opto/parse.hpp > ! src/hotspot/share/opto/parse2.cpp > From tobias.hartmann at oracle.com Fri Aug 17 13:19:46 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 17 Aug 2018 15:19:46 +0200 Subject: optimizing acmp in L-World In-Reply-To: <6654e587-6e23-24ab-f992-5d2e28c8e8ac@oracle.com> References: <47625659-9B0E-481C-B755-4C5C4E2DE23C@oracle.com> <6654e587-6e23-24ab-f992-5d2e28c8e8ac@oracle.com> Message-ID: Hi Sergey, thanks for this analysis and sorry for the delay. Please see comments below. On 26.07.2018 03:14, Sergey Kuksenko wrote: > I've measured new Valhalla acmp code on legacy (non-value types code). > Performance regression of acmp operation is 10%-20% comparing to before valhalla world. It was > measured on microbenchmarks and looks like it shouldn't be significantly visible on real apps except > some corner cases. Yes, I don't think that this is measurable for real applications. Especially because real applications usually not just check for equality but also do something with these objects. In most cases, C2 will either be able to figure out at compile time that one of the operands is *not* a value type (and therefore emit old acmp) or that one operand *is* a value type (and therefore emit a double null check because a value type can only ever be equal to null). In addition, if C2 emits a null check or klass load, it will re-use the knowledge/result throughout the scope of the compilation. For example, although the additional null check will slow things down, C2 can omit another null check that would usually follow up in one of the branches. > And right now the code checking and mixing if class is value looks like: > > mov??? 0x8(%rcx),%r10d? // load class ptr > shr ? ? $0x3,%r10 > and??? $0x1,%r10??????????? // here r10 is 1 if value, 0 if not value > add??? %r10,%rcx??????????? // mix with value bit Yes, C2 generated code for old acmp 'return a == b;' looks like this: xor %r10d,%r10d mov $0x1,%eax cmp %rdx,%rcx cmovne %r10d,%eax Whereas new acmp looks like this: test %rcx,%rcx je is_null mov 0x8(%rcx),%r10d shr $0x3,%r10 and $0x1,%r10 add %r10,%rcx is_null: xor %r11d,%r11d mov $0x1,%eax cmp %rdx,%rcx cmovne %r11d,%eax > I'd rather rewrite to: > > ? bool new_acmp(ptr x, ptr y) { > ??? if (!old_acmp(x, y))? return false;? // x != y => false > ??? return x!=null && !is_value_ptr(x); > ? } I gave that a try (see below). > and the following will get us required 0 and 1 from this > > mov??? 0x8(%rcx),%r10d? // load class ptr > shr ? ? $0x3,%r10 > and??? $0x1,%r10??????????? // here r10 is 1 if value, 0 if not value > xor ??? $0x1,%r10??????????? // here r10 false if value, true if not value. As John already pointed out, this only helps if we want the result in a register. Due to aggressive inlining in C2, this is rarely the case but usually we need an explicit cmp/jmp to branch to the corresponding target blocks. It's also not possible in the interpreter where we always explicitly branch. > Checking currently generated code I'd split it into traces and count asm instructions, and count asm > instructions which could new in suggested codegeneration: > (doesn't count unconditional branches) > > case x==null & y==null: > ?? ? ? current code:? 3 ALU ops + 2 branches > ? suggested code:? 3 ALU ops + 2 branches > > case x==null & y!=null: > ?? ? ? current code:? 3 ALU ops + 2 branches > ? suggested code:? 2 ALU ops + 1 branches > > case x==y: > ?? ? ? current code:? 6 ALU ops + 2 branches + 1 load from memory > ? suggested code:? 5 ALU ops + 2 branches + 1 load from memory > > case x!=y: > ?? ? ? current code:? 6 ALU ops + 2 branches + 1 load from memory > ? suggested code:? 2 ALU ops + 1 branch > > In some cases acmp cost is the same as in before valhalla world? (2 ALU ops + 1 branch) > > The most important fact here is not a quite small decrease of ALU instructions, which honestly won't > be visible even on microbenchmarks, but the fact in case of x!=y we eliminate load from memory which > even in hit to L1 cache will cost as all other instructions and much more in case of cache miss. Yes, I think avoiding the load from memory is the main benefit here. > The final suggested code (simplified): > > ??? cmp rx,ry > ??? je equal > ??? xor eax,eax > ??? jmp end > > equal: > ??? test rx,rx > ??? je is_null > ??? mov klass ptr from memory to eax > ??? shr 3,eax > ??? and 1,eax > ? ? xor? 1,eax > ? ? jmp end > > is_null: > ?? mov 1,eax > ?? jmp end > > end: > ? // eax contains result I've implemented this (-XX:+UseOldAcmp): http://cr.openjdk.java.net/~thartmann/valhalla/lworld/acmp_optimization/webrev.00/ The generated code then looks like this: cmp %rdx,%rcx jne is_ne test %rcx,%rcx je is_null mov 0x8(%rcx),%r11d mov %r11,%r10 shr $0x3,%r10 test $0x1,%r10 jne is_ne is_null: mov $0x1,%eax jmp end is_ne: xor %eax,%eax end: I'm using this benchmark for evaluation: http://cr.openjdk.java.net/~thartmann/valhalla/lworld/acmp_optimization/webrev.00/NewAcmpBenchmark.java Unfortunately, the results are highly dependent on profiling information and the resulting layout of code. I've therefore executed the benchmark with -XX:-ProfileInterpreter. Here are the results: With -XX:+UseOldAcmp Benchmark Mode Cnt Score Error Units NewAcmpBenchmark.newCmpEqAll thrpt 5 44.109 ? 0.045 ops/us NewAcmpBenchmark.newCmpEq_null_null thrpt 5 112.509 ? 0.073 ops/us NewAcmpBenchmark.newCmpEq_null_o1 thrpt 5 149.950 ? 0.124 ops/us NewAcmpBenchmark.newCmpEq_o1_null thrpt 5 149.960 ? 0.130 ops/us NewAcmpBenchmark.newCmpEq_o1_o1 thrpt 5 132.312 ? 0.171 ops/us NewAcmpBenchmark.newCmpEq_o1_o2 thrpt 5 140.188 ? 0.056 ops/us NewAcmpBenchmark.newCmpEq_o2_o1 thrpt 5 140.119 ? 0.141 ops/us With -XX:-UseOldAcmp Benchmark Mode Cnt Score Error Units NewAcmpBenchmark.newCmpEqAll thrpt 5 41.727 ? 0.022 ops/us NewAcmpBenchmark.newCmpEq_null_null thrpt 5 124.938 ? 0.088 ops/us NewAcmpBenchmark.newCmpEq_null_o1 thrpt 5 139.842 ? 0.108 ops/us NewAcmpBenchmark.newCmpEq_o1_null thrpt 5 149.930 ? 0.105 ops/us NewAcmpBenchmark.newCmpEq_o1_o1 thrpt 5 138.952 ? 0.065 ops/us NewAcmpBenchmark.newCmpEq_o1_o2 thrpt 5 131.435 ? 0.119 ops/us NewAcmpBenchmark.newCmpEq_o2_o1 thrpt 5 131.307 ? 0.140 ops/us As expected, your version is better if a != b. In the a == b case, the current implementation is better. If we are assuming that != is more common than == (like in the newCmpEqAll case), your version is better. Which acmp microbenchmarks are you using? I couldn't find any in the set of benchmarks that you've pushed. Thanks, Tobias From thompsonjamesrichard at gmail.com Tue Aug 14 18:13:58 2018 From: thompsonjamesrichard at gmail.com (James Thompson) Date: Tue, 14 Aug 2018 19:13:58 +0100 Subject: [lworld] javac allows Value Type generic parameters with var Message-ID: Local type inference with the use of var masks at the source level generic type parameters, therefore it is trivial to create a new generic collection of Value types. e.g. var list = List.of(Point.create(1, 1), Point.create(2, 2)); where Point is a Value type. This will compile without *-XDallowGenericsOverValues* From uberto.gama at gmail.com Sat Aug 18 10:40:36 2018 From: uberto.gama at gmail.com (Uberto Barbini) Date: Sat, 18 Aug 2018 11:40:36 +0100 Subject: Feedback on LW1 EAR Message-ID: Good morning, I've played a bit in these days with the EAR and here is my feedback. First of all, thanks for the great work! It's really nice to be able to use ValueTypes for immutable small objects. We the London Java Community we are organizing a hack day on this for middle of September, if someone is interested. Now I've a few question and a fatal error to report. 1) I saw there I can create Value Types using makeDefault + setField in a static method or I can use the "normal" new Value() syntax? The byte code produced seems identical: 4 invokestatic #3 Is there a difference or a preference for the future? 2) Currently == won't compile. It will work eventually? It would be nice to be able to control a few of operator (== + - * / say)... 3) in the declaration final __ByVal public class final seems to be optional. Will it stay so? 4) isValue() is still not present, is there another way to know if an instance or a class is a Value or not with current EAR? 5) I saw that I can override toString() and call super.toString() to have the standard Object behavior. I wonder if there will be some kind of base class for all ValueTypes or not. Then I've tried to replace some immutable classes into Value Types use them in my other projects. The main hindrance has been the missing support for generics. As workaround I've created a interface and based the collection on the interface. It worked in a few projects but I had a Fatal Error on a simple algorithm. I've tried to understand the exact problem but the same code seems to work as standalone project... If it's something worth investigating I can dig it more https://github.com/uberto/eopi/blob/ValhallaLW01/src/test/java/com/gamasoft/eopi/cap17_DynamicProgramming/KnapsackTest.java # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f08c3d648aa, pid=18399, tid=18426 # # JRE version: OpenJDK Runtime Environment (11.0) (build 11-lworldea+0-2018-07-30-1734349.david.simms.valhalla) # Java VM: OpenJDK 64-Bit Server VM (11-lworldea+0-2018-07-30-1734349.david.simms.valhalla, mixed mode, compressed oops, g1 gc, linux-amd64) # Problematic frame: # V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a # # No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again # # If you would like to submit a bug report, please visit: # http://bugreport.java.com/bugreport/crash.jsp # --------------- S U M M A R Y ------------ Command Line: -ea -XX:+EnableValhalla -Didea.test.cyclic.buffer.size=1048576 -javaagent:/home/uberto/idea-IC-181.4203.550/lib/idea_rt.jar=35303:/home/uberto/idea-IC-181.4203.550/bin -Dfile.encoding=UTF-8 com.intellij.rt.execution.junit.JUnitStarter -ideVersion5 -junit4 com.gamasoft.eopi.cap17_DynamicProgramming.KnapsackTest,bigShop Host: Intel(R) Core(TM) i7-4750HQ CPU @ 2.00GHz, 8 cores, 15G, Ubuntu 16.04.4 LTS Time: Sat Aug 18 11:05:34 2018 BST elapsed time: 0 seconds (0d 0h 0m 0s) --------------- T H R E A D --------------- Current thread (0x00007f0880159800): JavaThread "C2 CompilerThread1" daemon [_thread_in_native, id=18426, stack(0x00007f089c2f5000,0x00007f089c3f6000)] Current CompileTask: C2: 805 250 com.gamasoft.eopi.cap17_DynamicProgramming.Knapsack$WatchV::equals (8 bytes) Stack: [0x00007f089c2f5000,0x00007f089c3f6000], sp=0x00007f089c3f1f10, free space=1011k Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a V [libjvm.so+0xc95769] PhaseGVN::transform_no_reclaim(Node*)+0x49 V [libjvm.so+0xc750b5] Parse::optimize_cmp_with_klass(Node*)+0x125 V [libjvm.so+0xc7c6c8] Parse::do_one_bytecode()+0x3f28 V [libjvm.so+0xc6aa78] Parse::do_one_block()+0x218 V [libjvm.so+0xc6aea3] Parse::do_all_blocks()+0xc3 V [libjvm.so+0xc6cf60] Parse::Parse(JVMState*, ciMethod*, float)+0x940 V [libjvm.so+0x561968] ParseGenerator::generate(JVMState*)+0x78 V [libjvm.so+0x749360] Parse::do_call()+0x2c0 V [libjvm.so+0xc7c4a4] Parse::do_one_bytecode()+0x3d04 V [libjvm.so+0xc6aa78] Parse::do_one_block()+0x218 V [libjvm.so+0xc6aea3] Parse::do_all_blocks()+0xc3 V [libjvm.so+0xc6cf60] Parse::Parse(JVMState*, ciMethod*, float)+0x940 V [libjvm.so+0x561968] ParseGenerator::generate(JVMState*)+0x78 ---class code interface Watch{ //mini interface for use with generics int weight(); int price(); } __ByValue public static class WatchV implements Watch { public final int weight; public final int price; public WatchV(int weight, int price) { this.weight = weight; this.price = price; } @Override public String toString() { return "W{"+ weight + "," + price + '}'; } @Override public int weight() { return weight; } @Override public int price() { return price; } } From forax at univ-mlv.fr Sat Aug 18 17:44:51 2018 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 18 Aug 2018 19:44:51 +0200 (CEST) Subject: Feedback on LW1 EAR In-Reply-To: References: Message-ID: <1104801948.391069.1534614291680.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "Uberto Barbini" > ?: "valhalla-dev" > Envoy?: Samedi 18 Ao?t 2018 12:40:36 > Objet: Feedback on LW1 EAR > Good morning, > hi Uberto, > > I've played a bit in these days with the EAR and here is my feedback. thanks for doing that ! > > First of all, thanks for the great work! It's really nice to be able to use > ValueTypes for immutable small objects. > > We the London Java Community we are organizing a hack day on this for > middle of September, if someone is interested. > > Now I've a few question and a fatal error to report. > > 1) I saw there I can create Value Types using makeDefault + setField in a > static method or I can use the "normal" new Value() syntax? > The byte code produced seems identical: > 4 invokestatic #3 > Is there a difference or a preference for the future ? The current prototype focus on the VM side of the value types, not the language side (the Java side), we have voluntarily move all the syntax discussion into a latter phase because, it's hard to do both the VM and the Java side at the same time so the only answer i can provide is we don't know :) So the syntax for accessing to the opcodes default and withfield are placeholders. That's said having a similar way to describe the initialization of a value type compared to the initialization of a class is something which is appealing, it's aligned with our moto . > > 2) Currently == won't compile. It will work eventually? It would be nice to > be able to control a few of operator (== + - * / say)... Again, it's a surface syntax discussion, so i will wanser with another question, what about == if the right side is an Object and the left side is a value type (or vice versa). What we know is that acmp (the bytecode of == between object) returns false if one of the Object is a value type. > > 3) in the declaration > final __ByVal public class > final seems to be optional. Will it stay so ? again, syntax discussion, what we now is that a value class can not be inherited and is immutable. > > 4) isValue() is still not present, is there another way to know if an > instance or a class is a Value or not with current EAR? isValue() is declared on the class i.e. foo.getClass().isValue() > > 5) I saw that I can override toString() and call super.toString() to have > the standard Object behavior. I wonder if there will be some kind of base > class for all ValueTypes or not. no base class, a value type is a subtype of Object the same way an interface is a subtype of an Object, i.e. the relation between a value type and Object is not an inheritance relationship but a subtyping relationship, so you can see a value as an Object Object o = value; but you can not expect all the methods of java.lang.Object to be available on a value type. The only 3 methods from j.l.Object available are toString(), equals() and hashCode(). Currently, the compiler (and the JDK) provides a default implementation for those methods and you can override them. > > > Then I've tried to replace some immutable classes into Value Types use them > in my other projects. > The main hindrance has been the missing support for generics. not only, but i let you find the other issues by yourself :) You can disable the error about generics using javac -XDallowGenericsOverValues, obviously, it doesn't provide any support of reified generics, it just disable the error. > As workaround I've created a interface and based the collection on the > interface. It worked in a few projects but I had a Fatal Error on a simple > algorithm. I've tried to understand the exact problem but the same code > seems to work as standalone project... If it's something worth > investigating I can dig it more > > https://github.com/uberto/eopi/blob/ValhallaLW01/src/test/java/com/gamasoft/eopi/cap17_DynamicProgramming/KnapsackTest.java Thanks for the report ! regards, R?mi [1] https://bugs.openjdk.java.net/browse/JDK-8209009 > > > # > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGSEGV (0xb) at pc=0x00007f08c3d648aa, pid=18399, tid=18426 > # > # JRE version: OpenJDK Runtime Environment (11.0) (build > 11-lworldea+0-2018-07-30-1734349.david.simms.valhalla) > # Java VM: OpenJDK 64-Bit Server VM > (11-lworldea+0-2018-07-30-1734349.david.simms.valhalla, mixed mode, > compressed oops, g1 gc, linux-amd64) > # Problematic frame: > # V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a > # > # No core dump will be written. Core dumps have been disabled. To enable > core dumping, try "ulimit -c unlimited" before starting Java again > # > # If you would like to submit a bug report, please visit: > # http://bugreport.java.com/bugreport/crash.jsp > # > > --------------- S U M M A R Y ------------ > > Command Line: -ea -XX:+EnableValhalla > -Didea.test.cyclic.buffer.size=1048576 > -javaagent:/home/uberto/idea-IC-181.4203.550/lib/idea_rt.jar=35303:/home/uberto/idea-IC-181.4203.550/bin > -Dfile.encoding=UTF-8 com.intellij.rt.execution.junit.JUnitStarter > -ideVersion5 -junit4 > com.gamasoft.eopi.cap17_DynamicProgramming.KnapsackTest,bigShop > > Host: Intel(R) Core(TM) i7-4750HQ CPU @ 2.00GHz, 8 cores, 15G, Ubuntu > 16.04.4 LTS > Time: Sat Aug 18 11:05:34 2018 BST elapsed time: 0 seconds (0d 0h 0m 0s) > > --------------- T H R E A D --------------- > > Current thread (0x00007f0880159800): JavaThread "C2 CompilerThread1" > daemon [_thread_in_native, id=18426, > stack(0x00007f089c2f5000,0x00007f089c3f6000)] > > > Current CompileTask: > C2: 805 250 > com.gamasoft.eopi.cap17_DynamicProgramming.Knapsack$WatchV::equals (8 bytes) > > Stack: [0x00007f089c2f5000,0x00007f089c3f6000], sp=0x00007f089c3f1f10, > free space=1011k > Native frames: (J=compiled Java code, A=aot compiled Java code, > j=interpreted, Vv=VM code, C=native code) > V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a > V [libjvm.so+0xc95769] PhaseGVN::transform_no_reclaim(Node*)+0x49 > V [libjvm.so+0xc750b5] Parse::optimize_cmp_with_klass(Node*)+0x125 > V [libjvm.so+0xc7c6c8] Parse::do_one_bytecode()+0x3f28 > V [libjvm.so+0xc6aa78] Parse::do_one_block()+0x218 > V [libjvm.so+0xc6aea3] Parse::do_all_blocks()+0xc3 > V [libjvm.so+0xc6cf60] Parse::Parse(JVMState*, ciMethod*, float)+0x940 > V [libjvm.so+0x561968] ParseGenerator::generate(JVMState*)+0x78 > V [libjvm.so+0x749360] Parse::do_call()+0x2c0 > V [libjvm.so+0xc7c4a4] Parse::do_one_bytecode()+0x3d04 > V [libjvm.so+0xc6aa78] Parse::do_one_block()+0x218 > V [libjvm.so+0xc6aea3] Parse::do_all_blocks()+0xc3 > V [libjvm.so+0xc6cf60] Parse::Parse(JVMState*, ciMethod*, float)+0x940 > V [libjvm.so+0x561968] ParseGenerator::generate(JVMState*)+0x78 > > > > ---class code > > > interface Watch{ //mini interface for use with generics > int weight(); > int price(); > } > > > __ByValue public static class WatchV implements Watch { > public final int weight; > public final int price; > > public WatchV(int weight, int price) { > this.weight = weight; > this.price = price; > } > > @Override > public String toString() { > return "W{"+ weight + > "," + price + > '}'; > } > > @Override > public int weight() { > return weight; > } > > @Override > public int price() { > return price; > } > } From forax at univ-mlv.fr Sat Aug 18 18:05:27 2018 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 18 Aug 2018 20:05:27 +0200 (CEST) Subject: [lworld] javac allows Value Type generic parameters with var In-Reply-To: References: Message-ID: <41536976.391475.1534615527364.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "James Thompson" > ?: "valhalla-dev" > Envoy?: Mardi 14 Ao?t 2018 20:13:58 > Objet: [lworld] javac allows Value Type generic parameters with var > Local type inference with the use of var masks at the source level generic > type parameters, therefore it is trivial to create a new generic collection > of Value types. > > e.g. var list = List.of(Point.create(1, 1), Point.create(2, 2)); > > where Point is a Value type. This will compile without > *-XDallowGenericsOverValues* Thanks James, i suppose you can also do the same thing with the other kind of type inference, method call and diamond syntax. regards, R?mi From uberto.gama at gmail.com Sun Aug 19 20:07:43 2018 From: uberto.gama at gmail.com (Uberto Barbini) Date: Sun, 19 Aug 2018 21:07:43 +0100 Subject: Feedback on LW1 EAR In-Reply-To: <1104801948.391069.1534614291680.JavaMail.zimbra@u-pem.fr> References: <1104801948.391069.1534614291680.JavaMail.zimbra@u-pem.fr> Message-ID: Thank you very much for your detailed reply The current prototype focus on the VM side of the value types, not the > language side (the Java side), we have voluntarily move all the syntax > discussion into a latter phase because, it's hard to do both the VM and the > Java side at the same time so the only answer i can provide is we don't > know :) > > So the syntax for accessing to the opcodes default and withfield are > placeholders. > > That's said having a similar way to describe the initialization of a value > type compared to the initialization of a class is something which is > appealing, it's aligned with our moto . > > I understand that is too early to discuss the syntax, but I was curious. Thanks for the explanation. :) > > > > 2) Currently == won't compile. It will work eventually? It would be nice > to > > be able to control a few of operator (== + - * / say)... > > Again, it's a surface syntax discussion, so i will wanser with another > question, what about == if the right side is an Object and the left side is > a value type (or vice versa). > > What we know is that acmp (the bytecode of == between object) returns > false if one of the Object is a value type. > I see... I'll stay tuned for updates in this area. What I can say is that for Value object would be very useful to have support to define a few basic operators. > > 5) I saw that I can override toString() and call super.toString() to have > > the standard Object behavior. I wonder if there will be some kind of base > > class for all ValueTypes or not. > > no base class, a value type is a subtype of Object the same way an > interface is a subtype of an Object, > i.e. the relation between a value type and Object is not an inheritance > relationship but a subtyping relationship, > so you can see a value as an Object > Object o = value; > but you can not expect all the methods of java.lang.Object to be available > on a value type. > > The only 3 methods from j.l.Object available are toString(), equals() and > hashCode(). > Currently, the compiler (and the JDK) provides a default implementation > for those methods and you can override them. > > thanks for the explanation. I understand better now. > > not only, but i let you find the other issues by yourself :) > > You can disable the error about generics using javac > -XDallowGenericsOverValues, > obviously, it doesn't provide any support of reified generics, it just > disable the error. > Thanks, it actually helps a lot for testing Value Types on existing projects. Uberto From srikanth.adayapalam at oracle.com Mon Aug 20 05:35:56 2018 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Mon, 20 Aug 2018 11:05:56 +0530 Subject: Feedback on LW1 EAR In-Reply-To: References: Message-ID: <0522d554-9eb7-00b9-30fd-9a2a1930857f@oracle.com> On Saturday 18 August 2018 04:10 PM, Uberto Barbini wrote: > Good morning, > > > I've played a bit in these days with the EAR and here is my feedback. Thanks a lot. I'll add to Remi's answers with insight from Javac's work items list. > 1) I saw there I can create Value Types using makeDefault + setField in a > static method or I can use the "normal" new Value() syntax? > The byte code produced seems identical: > 4 invokestatic #3 > Is there a difference or a preference for the future? For LW1 EAR we wanted to allow only the new ValueType() syntax and push the programmer level usage of __MakeDefault and __WithField under a compile time flag, but ran out of time. So I would say there is an inclination to prefer the classic/canonical construction notation (CCN). However as Remi alluded to, syntax details are subject to change. > > 2) Currently == won't compile. It will work eventually? It would be nice to > be able to control a few of operator (== + - * / say)... Operator overloading is a separate subject altogether - there are many other issues relating to value types that are vying for the lions share of language designer's time I would say. Specifically speaking of `==' in the very near term, javac will begin to tolerate certain idioms that it forbids today: viz if (v1 == v2 || v1.equals(v2)) (what we internally call "LIFE" - the legacy idiom for equality") In slightly longer term, we are also asking the question whether == should simply be translated into the equals method call by javac where it can statically discern the operands to be values. > 3) in the declaration > final __ByVal public class > final seems to be optional. Will it stay so? Syntax details are subject to change, but I will share here that the final keyword was expressly required till very recently. That gives an indication of the present thinking. > 5) I saw that I can override toString() and call super.toString() to have > the standard Object behavior. This should have been rejected by javac. That it is not is a defect I would say. Srikanth From tobias.hartmann at oracle.com Mon Aug 20 08:41:15 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 20 Aug 2018 10:41:15 +0200 Subject: Feedback on LW1 EAR In-Reply-To: References: Message-ID: <82c3335c-147a-bfdd-e24e-2598f25568ed@oracle.com> Hi Uberto, first of all, thanks a lot for trying out LW1 EA and for reporting these issues! The crash is a bug in the just-in-time (JIT) compiler when compiling the WatchV:equals method, I've filed [1] and will work on a fix. As a temporary workaround you can disable JIT compilation of the affected method via -XX:CompileCommand=exclude,"Knapsack\$WatchV::equals" or disable JIT compilation altogether by adding the -Xint command line flag (unfortunately, both options will slow down execution a lot but it should be good enough for non-performance testing). Thanks, Tobias [1] https://bugs.openjdk.java.net/browse/JDK-8209687 On 18.08.2018 12:40, Uberto Barbini wrote: > 5) I saw that I can override toString() and call super.toString() to have > the standard Object behavior. I wonder if there will be some kind of base > class for all ValueTypes or not. > > > Then I've tried to replace some immutable classes into Value Types use them > in my other projects. > The main hindrance has been the missing support for generics. > As workaround I've created a interface and based the collection on the > interface. It worked in a few projects but I had a Fatal Error on a simple > algorithm. I've tried to understand the exact problem but the same code > seems to work as standalone project... If it's something worth > investigating I can dig it more > > https://github.com/uberto/eopi/blob/ValhallaLW01/src/test/java/com/gamasoft/eopi/cap17_DynamicProgramming/KnapsackTest.java > > > # > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGSEGV (0xb) at pc=0x00007f08c3d648aa, pid=18399, tid=18426 > # > # JRE version: OpenJDK Runtime Environment (11.0) (build > 11-lworldea+0-2018-07-30-1734349.david.simms.valhalla) > # Java VM: OpenJDK 64-Bit Server VM > (11-lworldea+0-2018-07-30-1734349.david.simms.valhalla, mixed mode, > compressed oops, g1 gc, linux-amd64) > # Problematic frame: > # V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a > # > # No core dump will be written. Core dumps have been disabled. To enable > core dumping, try "ulimit -c unlimited" before starting Java again > # > # If you would like to submit a bug report, please visit: > # http://bugreport.java.com/bugreport/crash.jsp > # From tobias.hartmann at oracle.com Mon Aug 20 15:16:28 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 20 Aug 2018 17:16:28 +0200 Subject: RFR(S): 8209687: [lworld] C2 compilation crashes in AddPNode::Value Message-ID: <9b0feb49-713d-14a2-dd26-38cdce2c721a@oracle.com> Hi, please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8209687 http://cr.openjdk.java.net/~thartmann/8209687/webrev.00/ Parse::optimize_cmp_with_klass() needs to properly handle value types. Thanks, Tobias From tobias.hartmann at oracle.com Mon Aug 20 15:39:55 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 20 Aug 2018 17:39:55 +0200 Subject: RFR(S): 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" Message-ID: Hi, please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8209702 http://cr.openjdk.java.net/~thartmann/8209702/webrev.00/ The native clone intrinsic needs to handle value types. Thanks, Tobias From rwestrel at redhat.com Mon Aug 20 15:49:36 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Mon, 20 Aug 2018 17:49:36 +0200 Subject: RFR(S): 8209687: [lworld] C2 compilation crashes in AddPNode::Value In-Reply-To: <9b0feb49-713d-14a2-dd26-38cdce2c721a@oracle.com> References: <9b0feb49-713d-14a2-dd26-38cdce2c721a@oracle.com> Message-ID: > http://cr.openjdk.java.net/~thartmann/8209687/webrev.00/ Looks good to me. Roland. From tobias.hartmann at oracle.com Mon Aug 20 15:50:48 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 20 Aug 2018 17:50:48 +0200 Subject: RFR(S): 8209687: [lworld] C2 compilation crashes in AddPNode::Value In-Reply-To: References: <9b0feb49-713d-14a2-dd26-38cdce2c721a@oracle.com> Message-ID: <2231970a-2426-c9a8-af46-d55481cc4423@oracle.com> Thanks Roland! Best regards, Tobias On 20.08.2018 17:49, Roland Westrelin wrote: > >> http://cr.openjdk.java.net/~thartmann/8209687/webrev.00/ > > Looks good to me. > > Roland. > From rwestrel at redhat.com Mon Aug 20 15:55:10 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Mon, 20 Aug 2018 17:55:10 +0200 Subject: RFR(S): 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" In-Reply-To: References: Message-ID: > http://cr.openjdk.java.net/~thartmann/8209702/webrev.00/ I wonder if it's sufficient to: 4373 assert(!obj->is_ValueType(), "value types don't support cloning"); i.e. if that's really impossible. Profile data could be inaccurate for that code path I suppose. Roland. From david.simms at oracle.com Tue Aug 21 15:09:37 2018 From: david.simms at oracle.com (david.simms at oracle.com) Date: Tue, 21 Aug 2018 15:09:37 +0000 Subject: hg: valhalla/valhalla: 489 new changesets Message-ID: <201808211510.w7LFAFOA028056@aojmv0008.oracle.com> Changeset: e0028bb6dd3d Author: coleenp Date: 2018-07-10 11:13 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e0028bb6dd3d 8206471: Race with ConcurrentHashTable deleting items on insert with cleanup thread Summary: Only fetch Node::next once and use that result. Reviewed-by: hseigel, dholmes ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp Changeset: f9b96afb7c5e Author: dl Date: 2018-07-10 10:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f9b96afb7c5e 8206123: ArrayDeque created with default constructor can only hold 15 elements Reviewed-by: martin, psandoz, igerasim ! src/java.base/share/classes/java/util/ArrayDeque.java + test/jdk/java/util/ArrayDeque/WhiteBox.java Changeset: ebfb1ae41f4b Author: dl Date: 2018-07-10 10:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ebfb1ae41f4b 8205576: forkjoin/FJExceptionTableLeak.java fails "AssertionError: failed to satisfy condition" Reviewed-by: martin, psandoz, dholmes, tschatzl ! test/jdk/java/util/concurrent/forkjoin/FJExceptionTableLeak.java Changeset: 0d28f82ecac6 Author: dl Date: 2018-07-10 10:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0d28f82ecac6 8205620: Miscellaneous changes imported from jsr166 CVS 2018-07 Reviewed-by: martin, psandoz ! src/java.base/share/classes/java/util/HashMap.java Changeset: dbe8aa90d4dd Author: ccheung Date: 2018-07-10 19:04 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dbe8aa90d4dd 8205946: JVM crash after call to ClassLoader::setup_bootstrap_search_path() Summary: exit vm if setting of boot class path fails. Reviewed-by: lfoltan, jiangli, dholmes ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/classfile/classLoader.cpp ! test/hotspot/jtreg/runtime/appcds/MoveJDKTest.java Changeset: 69b438908512 Author: shade Date: 2018-07-11 08:44 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/69b438908512 8206931: Misleading "COMPILE SKIPPED: invalid non-klass dependency" compile log Reviewed-by: vlivanov, never ! src/hotspot/share/ci/ciEnv.cpp Changeset: 225b61293064 Author: darcy Date: 2018-07-11 08:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/225b61293064 8173606: Deprecate constructors of 7-era visitors Reviewed-by: vromero, jjg ! src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor7.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/java.compiler/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementScanner7.java ! src/java.compiler/share/classes/javax/lang/model/util/ElementScanner8.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java ! src/java.compiler/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/java.compiler/share/classes/javax/lang/model/util/TypeKindVisitor8.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java Changeset: 29eaf3feab30 Author: zgu Date: 2018-07-11 13:28 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/29eaf3feab30 8206183: Possible construct EMPTY_STACK and allocation stack, etc. on first use Summary: Uses "construct on First Use Idiom" pattern to workaround static initialization order Reviewed-by: dholmes, minqi ! src/hotspot/share/services/mallocSiteTable.cpp ! src/hotspot/share/services/mallocSiteTable.hpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/utilities/nativeCallStack.cpp ! src/hotspot/share/utilities/nativeCallStack.hpp Changeset: f939a67fea30 Author: coleenp Date: 2018-07-11 14:44 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f939a67fea30 8198720: Obsolete PrintSafepointStatistics, PrintSafepointStatisticsTimeout and PrintSafepointStatisticsCount options Summary: Convert PrintSafepointStatistics to UL Reviewed-by: shade, lfoltan ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/runtime/vm_operations.hpp ! test/hotspot/gtest/utilities/utilitiesHelper.inline.hpp Changeset: 1e24c7152e47 Author: jjg Date: 2018-07-02 17:54 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1e24c7152e47 8205563: modules/AnnotationProcessing.java failed testGenerateSingleModule Reviewed-by: darcy ! test/langtools/tools/javac/modules/AnnotationProcessing.java ! test/langtools/tools/lib/toolbox/ToolBox.java Changeset: 14708e1acdc3 Author: jjiang Date: 2018-07-03 09:27 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/14708e1acdc3 8205984: javax/net/ssl/compatibility/Compatibility.java failed to access port log file Summary: Release resource after reading port log file Reviewed-by: xuelei ! test/jdk/javax/net/ssl/compatibility/Compatibility.java ! test/jdk/javax/net/ssl/compatibility/Server.java Changeset: 3f879ff34084 Author: mchung Date: 2018-07-03 11:16 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3f879ff34084 8206184: docs-reference build fails due to extlink.spec.version property not set Reviewed-by: erikj ! make/Docs.gmk Changeset: d30b4459b71b Author: iignatyev Date: 2018-06-28 10:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d30b4459b71b 8202561: clean up TEST.groups file Reviewed-by: kvn, iklam, epavlova ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/TEST.groups + test/hotspot/jtreg/TEST.quick-groups Changeset: 34872a21af82 Author: psandoz Date: 2018-07-02 10:09 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/34872a21af82 8202769: jck test fails with C2: vm/jvmti/FollowReferences/fref001/fref00113/fref00113.html Reviewed-by: kvn, coleenp ! src/hotspot/share/ci/ciStreams.cpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/constantPool.hpp Changeset: 51e49f77f7eb Author: bobv Date: 2018-07-03 10:59 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/51e49f77f7eb 8205928: [TESTBUG] jdk/internal/platform/docker/TestDockerMemoryMetrics Reviewed-by: stuefe ! test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java Changeset: 833a291460b7 Author: bobv Date: 2018-07-03 15:08 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/833a291460b7 Merge Changeset: 24bf1bd23725 Author: rgoel Date: 2018-07-04 11:55 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/24bf1bd23725 8204603: Short week days, NaN value and timezone name are inconsistent between CLDR and Java in zh_CN, zh_TW locales. Summary: handled languageALiases for supported locales of CLDR. Reviewed-by: naoto + src/java.base/share/classes/sun/util/cldr/CLDRCalendarNameProviderImpl.java ! src/java.base/share/classes/sun/util/cldr/CLDRLocaleProviderAdapter.java ! src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/java.base/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java + test/jdk/sun/util/resources/cldr/Bug8204603.java Changeset: b833992fa8fa Author: pliden Date: 2018-07-04 08:33 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b833992fa8fa 8206322: ZGC: Incorrect license header in gtests Reviewed-by: kbarrett, tschatzl ! test/hotspot/gtest/gc/z/test_zAddress.cpp ! test/hotspot/gtest/gc/z/test_zArray.cpp ! test/hotspot/gtest/gc/z/test_zBitField.cpp ! test/hotspot/gtest/gc/z/test_zBitMap.cpp ! test/hotspot/gtest/gc/z/test_zForwardingTable.cpp ! test/hotspot/gtest/gc/z/test_zList.cpp ! test/hotspot/gtest/gc/z/test_zLiveMap.cpp ! test/hotspot/gtest/gc/z/test_zPhysicalMemory.cpp ! test/hotspot/gtest/gc/z/test_zUtils.cpp ! test/hotspot/gtest/gc/z/test_zVirtualMemory.cpp Changeset: 59ee619866c3 Author: simonis Date: 2018-07-04 09:21 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/59ee619866c3 8206173: MallocSiteTable::initialize() doesn't take function descriptors into account Reviewed-by: stuefe, zgu ! src/hotspot/share/services/mallocSiteTable.cpp ! src/hotspot/share/utilities/macros.hpp Changeset: ab9312fac8eb Author: mgronlun Date: 2018-07-04 10:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ab9312fac8eb 8206254: Unable to complete emergency dump during safepoint Reviewed-by: egahlin ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeManager.cpp Changeset: a63f6915a1f9 Author: xyin Date: 2018-07-04 16:49 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a63f6915a1f9 8187069: The case auto failed with the java.lang.ClassNotFoundException: IPv6NameserverPlatformParsingTest exception Reviewed-by: vtewari, dfuchs ! test/jdk/com/sun/jndi/dns/Test6991580.java Changeset: 270b11dadbaf Author: pliden Date: 2018-07-04 12:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/270b11dadbaf 8205924: ZGC: Premature OOME due to failure to expand backing file Reviewed-by: ehelin ! src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.hpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp ! src/hotspot/share/gc/z/zDirector.cpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp ! src/hotspot/share/gc/z/zPhysicalMemory.cpp ! src/hotspot/share/gc/z/zPhysicalMemory.hpp ! src/hotspot/share/gc/z/zPhysicalMemory.inline.hpp ! src/hotspot/share/gc/z/zPreMappedMemory.cpp ! test/hotspot/gtest/gc/z/test_zPhysicalMemory.cpp Changeset: 343d3c0dd368 Author: pliden Date: 2018-07-04 12:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/343d3c0dd368 8206316: ZGC: Preferred tmpfs mount point not found on Debian Reviewed-by: kbarrett, tschatzl, ehelin ! src/hotspot/os_cpu/linux_x86/gc/z/zBackingFile_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zBackingPath_linux_x86.hpp Changeset: ce27f6e0734d Author: sdama Date: 2018-07-04 17:49 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ce27f6e0734d 8198819: tools/jimage/JImageExtractTest.java, fails intermittently at testExtract (macos) Summary: Modified test to work on only modules extracted using jimage instead of files present in current directory Reviewed-by: jlaskey ! test/jdk/ProblemList.txt ! test/jdk/tools/jimage/JImageExtractTest.java Changeset: 0a8198fa7e7a Author: neliasso Date: 2018-07-03 09:11 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0a8198fa7e7a 8205999: C2 compilation fails with "assert(store->find_edge(load) != -1) failed: missing precedence edge" Summary: Backout 8204157 to state before 8192992 Reviewed-by: thartmann, mdoerr ! src/hotspot/share/opto/gcm.cpp Changeset: 66a808262d3b Author: mbaesken Date: 2018-07-03 12:40 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/66a808262d3b 8206255: fix compiler/intrinsics/sha/cli/TestUseSHAOptionOnSupportedCPU.java jtreg test on linux s390x Reviewed-by: stuefe ! src/hotspot/cpu/s390/vm_version_s390.cpp Changeset: f1f4b8cd0192 Author: mbaesken Date: 2018-07-04 16:54 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f1f4b8cd0192 8206145: dbgsysSocketClose - do not restart close if errno is EINTR [linux] Reviewed-by: alanb, stuefe ! src/jdk.jdwp.agent/unix/native/libdt_socket/socket_md.c Changeset: cd41f34e548c Author: michaelm Date: 2018-07-04 16:16 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cd41f34e548c 8206001: Enable TLS1.3 by default in Http Client Reviewed-by: dfuchs ! src/java.net.http/share/classes/jdk/internal/net/http/AbstractAsyncSSLConnection.java ! src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http1AsyncReceiver.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http1Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/SocketTube.java ! src/java.net.http/share/classes/jdk/internal/net/http/Stream.java ! src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/SSLFlowDelegate.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/SSLTube.java ! src/java.net.http/share/classes/jdk/internal/net/http/frame/SettingsFrame.java ! test/jdk/java/net/httpclient/CancelledResponse.java ! test/jdk/java/net/httpclient/MockServer.java ! test/jdk/java/net/httpclient/ShortResponseBody.java ! test/jdk/java/net/httpclient/SplitResponse.java ! test/jdk/java/net/httpclient/http2/FixedThreadPoolTest.java ! test/jdk/java/net/httpclient/http2/TLSConnection.java ! test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/SSLEchoTubeTest.java Changeset: b289815d0db3 Author: mgronlun Date: 2018-07-04 18:39 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b289815d0db3 8198346: assert(!_cld->claimed()) failed in TestObjectDescription.java Reviewed-by: egahlin ! src/hotspot/share/jfr/leakprofiler/utilities/saveRestore.cpp Changeset: e4a92c455d1c Author: ssahoo Date: 2018-07-04 11:49 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e4a92c455d1c 8206355: SSLSessionImpl.getLocalPrincipal() throws NPE Summary: Fixed SSLSessionImpl.getLocalPrincipal() implementation when client side authentication is not enabled. Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java + test/jdk/javax/net/ssl/TLSCommon/TestSessionLocalPrincipal.java Changeset: e5e3e2c1b2e5 Author: xiaofeya Date: 2018-07-05 13:22 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e5e3e2c1b2e5 8206378: Backout JDK-8202561 Reviewed-by: dholmes ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/TEST.groups - test/hotspot/jtreg/TEST.quick-groups Changeset: 3bc865cc2122 Author: stuefe Date: 2018-07-05 11:56 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3bc865cc2122 8206243: java -XshowSettings fails if memory.limit_in_bytes overflows LONG.max Reviewed-by: dholmes, bobv ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java Changeset: f604d14c8132 Author: jwilhelm Date: 2018-07-05 13:26 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f604d14c8132 Added tag jdk-11+21 for changeset 14708e1acdc3 ! .hgtags Changeset: a80638fa1a8c Author: serb Date: 2018-07-05 19:05 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a80638fa1a8c 8189604: possible hang in sun.awt.shell.Win32ShellFolder2$KnownFolderDefinition:: Reviewed-by: prr, kaddepalli ! src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java ! src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp + test/jdk/javax/swing/reliability/HangDuringStaticInitialization.java Changeset: faf1cd52a5b7 Author: simonis Date: 2018-06-12 13:00 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/faf1cd52a5b7 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5 Reviewed-by: simonis, stuefe Contributed-by: bhamaram at in.ibm.com ! src/java.base/unix/native/libjava/java_props_md.c ! test/jdk/sun/nio/cs/TestIBMBugs.java Changeset: 3924d4cf8b41 Author: serb Date: 2018-07-05 21:29 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3924d4cf8b41 8205454: & is displayed in some Swing docs Reviewed-by: prr, psadhukhan ! src/java.desktop/share/classes/javax/swing/JButton.java ! src/java.desktop/share/classes/javax/swing/JCheckBox.java ! src/java.desktop/share/classes/javax/swing/JFileChooser.java ! src/java.desktop/share/classes/javax/swing/JPanel.java ! src/java.desktop/share/classes/javax/swing/JRadioButton.java ! src/java.desktop/share/classes/javax/swing/JSplitPane.java ! src/java.desktop/share/classes/javax/swing/JToggleButton.java + test/jdk/java/beans/Beans/TypoInBeanDescription.java Changeset: 09776f847bf4 Author: sdama Date: 2018-07-06 00:40 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/09776f847bf4 8198405: JImageExtractTest.java & JImageListTest.java failed in Windows. Summary: Make a directory readonly using nio file attribute AclEntry Reviewed-by: jlaskey ! test/jdk/ProblemList.txt ! test/jdk/tools/jimage/JImageExtractTest.java Changeset: 3c59afe1afc9 Author: mbaesken Date: 2018-07-05 09:38 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3c59afe1afc9 8206394: missing ResourceMark in AOTCompiledMethod::metadata_do, AOTCompiledMethod::clear_inline_caches , CompiledMethod::clear_ic_stubs , CompiledMethod::cleanup_inline_caches_impl Reviewed-by: kvn ! src/hotspot/share/aot/aotCompiledMethod.cpp ! src/hotspot/share/code/compiledMethod.cpp Changeset: 8ad85ab7a188 Author: kvn Date: 2018-07-05 12:38 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8ad85ab7a188 8206324: compiler/whitebox/DeoptimizeFramesTest.java to ProblemList-graal.txt Reviewed-by: dlong ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: b9361d8c58a5 Author: iignatyev Date: 2018-07-05 20:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b9361d8c58a5 8206429: [REDO] 8202561 clean up TEST.groups Reviewed-by: kvn, dholmes, ctornqvi ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/TEST.groups + test/hotspot/jtreg/TEST.quick-groups Changeset: 4fc6bca9e941 Author: simonis Date: 2018-07-06 09:22 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4fc6bca9e941 8206436: sun/nio/cs/TestIBMBugs.java no longer compiles Reviewed-by: mikael, stuefe, alanb ! test/jdk/sun/nio/cs/TestIBMBugs.java Changeset: f8038b878d27 Author: sdama Date: 2018-07-06 13:38 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f8038b878d27 8206450: Add JImageListTest.java to ProblemList.txt Summary: Added JImageListTest.java to ProblemList.txt Reviewed-by: dholmes ! test/jdk/ProblemList.txt Changeset: 7c8841474f57 Author: prr Date: 2018-07-06 10:37 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7c8841474f57 8206428: Upgrade JDK11 to harfbuzz 1.8.2 Reviewed-by: serb ! src/java.desktop/share/legal/harfbuzz.md ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gpos-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-version.h Changeset: deff20e15445 Author: prr Date: 2018-07-06 10:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/deff20e15445 8206375: ProblemList update of bug ID for SwingFontMetricsTest Reviewed-by: serb ! test/jdk/ProblemList.txt Changeset: 0665a966cac6 Author: kvn Date: 2018-07-06 13:45 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0665a966cac6 8193126: Incorrect setting of MetaspaceSize and NewSizeThreadIncrease when using JVMCI compiler Summary: select maximum default values for JVMCI Reviewed-by: dnsimon, iveresov ! src/hotspot/share/compiler/compilerDefinitions.cpp Changeset: f8ebefc29b79 Author: cushon Date: 2018-07-06 12:10 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f8ebefc29b79 8204630: Generating an anonymous class with Filer#createClassFile causes an NPE in JavacProcessingEnvironment Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/langtools/tools/javac/processing/rounds/GenerateAnonymousClass.java + test/langtools/tools/javac/processing/rounds/GenerateAnonymousClass.out Changeset: 162867fa0f8d Author: mgronlun Date: 2018-07-08 11:54 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/162867fa0f8d 8203943: eventThreadGroup was null in TestJavaBlockedEvent.java Reviewed-by: egahlin ! src/hotspot/share/jfr/jfr.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp ! src/hotspot/share/jfr/support/jfrThreadLocal.cpp ! src/hotspot/share/jfr/support/jfrThreadLocal.hpp Changeset: 0083d474b0e1 Author: dholmes Date: 2018-07-08 20:00 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0083d474b0e1 8205966: [testbug] New Nestmates JDI test times out with Xcomp on sparc Reviewed-by: mikael, sspitsyn ! test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java Changeset: 3982b9671e71 Author: weijun Date: 2018-07-09 12:20 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3982b9671e71 8198352: java.util.MissingResourceException: sun.security.util.AuthResources when trying to use com.sun.security.auth.module.UnixLoginModule Reviewed-by: xuelei ! src/jdk.security.auth/share/classes/com/sun/security/auth/UnixNumericGroupPrincipal.java + test/jdk/com/sun/security/auth/UnixPrincipalHashCode.java + test/jdk/com/sun/security/auth/uphc.policy Changeset: fc9dd181d70e Author: tschatzl Date: 2018-07-09 10:19 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fc9dd181d70e 8205426: Humongous continues remembered set does not match humongous start region one after Remark Summary: Remembered set states for humongous objects crossing an internal per-thread processing threshold could synchronized if the humongous continues regions were processed first. Reviewed-by: ehelin, kbarrett ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1RemSetTrackingPolicy.cpp ! src/hotspot/share/gc/g1/g1RemSetTrackingPolicy.hpp + test/hotspot/jtreg/gc/g1/TestHumongousRemsetsMatch.java Changeset: 8df91a1b549b Author: adinn Date: 2018-07-09 09:38 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8df91a1b549b 8206163: AArch64: incorrect code generation for StoreCM Summary: StoreCM may require planting a StoreStore barrier Reviewed-by: aph, zyao, roland ! src/hotspot/cpu/aarch64/aarch64.ad ! test/hotspot/jtreg/compiler/c2/aarch64/TestVolatiles.java Changeset: 44b07bd68f6d Author: mdoerr Date: 2018-07-09 15:26 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/44b07bd68f6d 8206459: [s390] Prevent restoring incorrect bcp and locals in interpreter and avoid incorrect size of partialSubtypeCheckNode in C2 Reviewed-by: goetz ! src/hotspot/cpu/s390/s390.ad ! src/hotspot/cpu/s390/templateTable_s390.cpp Changeset: 29be48779807 Author: serb Date: 2018-07-09 16:36 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/29be48779807 8201611: Broken links in java.desktop javadoc Reviewed-by: prr, kaddepalli ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/java/awt/Shape.java ! src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadataNode.java Changeset: c9bf46f4d555 Author: ghaug Date: 2018-07-09 12:51 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c9bf46f4d555 8206408: Add missing CPU/system info to vm_version_ext on PPC64 Reviewed-by: mdoerr, simonis ! src/hotspot/cpu/ppc/vm_version_ext_ppc.cpp ! src/hotspot/cpu/ppc/vm_version_ext_ppc.hpp Changeset: cd557cad6e0a Author: serb Date: 2018-07-09 19:09 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cd557cad6e0a 8205588: Deprecate for removal com.sun.awt.SecurityWarning Reviewed-by: prr, kaddepalli ! src/java.desktop/share/classes/com/sun/awt/SecurityWarning.java Changeset: 6e760728afaa Author: erikj Date: 2018-07-09 09:09 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6e760728afaa 8206433: Several jib profiles missing autoconf dependency Reviewed-by: tbell ! make/conf/jib-profiles.js Changeset: 9ad98030b2b6 Author: prr Date: 2018-07-09 10:23 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9ad98030b2b6 8205646: Broken link in jdk.jsobject Reviewed-by: serb ! src/jdk.jsobject/share/classes/netscape/javascript/JSObject.java Changeset: 01fc2c1ee3e6 Author: prr Date: 2018-07-09 10:25 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/01fc2c1ee3e6 8206106: [solaris sparc] jck tests api/javax_print/PrintService failing Reviewed-by: simonis, erikj ! src/java.desktop/unix/native/common/awt/CUPSfuncs.c Changeset: a926b7737d3b Author: iignatyev Date: 2018-07-09 11:15 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a926b7737d3b 8206287: fix legal notice in hotspot tests Reviewed-by: kvn, hseigel ! test/hotspot/jtreg/Makefile ! test/hotspot/jtreg/compiler/debug/TraceIterativeGVN.java ! test/hotspot/jtreg/compiler/dependencies/MonomorphicObjectCall/java.base/java/lang/Object.java ! test/hotspot/jtreg/compiler/eliminateAutobox/UnsignedLoads.java ! test/hotspot/jtreg/compiler/intrinsics/string/TestHasNegatives.java ! test/hotspot/jtreg/compiler/intrinsics/string/TestStringIntrinsicRangeChecks.java ! test/hotspot/jtreg/compiler/intrinsics/string/TestStringUTF16IntrinsicRangeChecks.java ! test/hotspot/jtreg/compiler/patches/java.base/java/lang/Helper.java ! test/hotspot/jtreg/compiler/stable/StableConfiguration.java ! test/hotspot/jtreg/compiler/stable/TestStableBoolean.java ! test/hotspot/jtreg/compiler/stable/TestStableByte.java ! test/hotspot/jtreg/compiler/stable/TestStableChar.java ! test/hotspot/jtreg/compiler/stable/TestStableDouble.java ! test/hotspot/jtreg/compiler/stable/TestStableFloat.java ! test/hotspot/jtreg/compiler/stable/TestStableInt.java ! test/hotspot/jtreg/compiler/stable/TestStableLong.java ! test/hotspot/jtreg/compiler/stable/TestStableMemoryBarrier.java ! test/hotspot/jtreg/compiler/stable/TestStableObject.java ! test/hotspot/jtreg/compiler/stable/TestStableShort.java ! test/hotspot/jtreg/compiler/stable/TestStableUByte.java ! test/hotspot/jtreg/compiler/stable/TestStableUShort.java ! test/hotspot/jtreg/compiler/unsafe/OpaqueAccesses.java ! test/hotspot/jtreg/compiler/unsafe/UnsafeGetConstantField.java ! test/hotspot/jtreg/compiler/unsafe/UnsafeGetStableArrayElement.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/CheckRead.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/DiffCL_CheckRead.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/DiffCL_ExpQualOther.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/DiffCL_ExpQualToM1.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/DiffCL_ExpUnqual.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/DiffCL_PkgNotExp.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/DiffCL_Umod.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/DiffCL_UmodUpkg.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/ExpQualOther.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/ExpQualToM1.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/ExpQualToM1PrivateMethodIAE.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/ExpUnqual.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/ExportAllUnnamed.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/PkgNotExp.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/Umod.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodDiffCL_ExpQualOther.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodDiffCL_ExpUnqual.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodDiffCL_PkgNotExp.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodDiffCL_Umod.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodDiffCL_UmodUpkg.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodUPkg.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodUpkgDiffCL_ExpQualOther.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodUpkgDiffCL_NotExp.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodUpkgDiffCL_Umod.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodUpkg_ExpQualOther.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodUpkg_NotExp.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/UmodUpkg_Umod.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/Umod_ExpQualOther.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/Umod_ExpUnqual.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/Umod_PkgNotExp.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/Umod_UmodUpkg.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/p1/c1.jasm ! test/hotspot/jtreg/runtime/modules/AccessCheck/p2/c2.jasm ! test/hotspot/jtreg/runtime/modules/ModuleStress/ModuleNonBuiltinCLMain.java ! test/hotspot/jtreg/runtime/modules/ModuleStress/ModuleSameCLMain.java ! test/hotspot/jtreg/runtime/modules/ModuleStress/ModuleStress.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach024/java.base/java/util/TooManyListenersException.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/tools/Indify.java Changeset: dd7ce84016a5 Author: vdeshpande Date: 2018-07-09 13:25 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dd7ce84016a5 8194740: UseSubwordForMaxVector causes performance regression Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/superword.cpp Changeset: 591c34a66d41 Author: jjg Date: 2018-07-09 13:26 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/591c34a66d41 8185740: The help-doc.html generated by the doclet is outdated Reviewed-by: sundar ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Contents.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java Changeset: 3e416c21e763 Author: erikj Date: 2018-07-09 14:21 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3e416c21e763 8206323: Missing some legal notices in docs bundle Reviewed-by: mchung, tbell ! make/Docs.gmk Changeset: 1835f9fca157 Author: dholmes Date: 2018-07-09 20:17 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1835f9fca157 8205878: pthread_getcpuclockid is expected to return 0 code Reviewed-by: cjplummer, amenkov, coleenp ! make/test/JtregNativeHotspot.gmk ! src/hotspot/os/linux/os_linux.cpp + test/hotspot/jtreg/runtime/jni/terminatedThread/TestTerminatedThread.java + test/hotspot/jtreg/runtime/jni/terminatedThread/libterminatedThread.c ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/ji05t001.c ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/jni_interception/JI06/ji06t001/ji06t001.c Changeset: c18ca8590dfa Author: jjiang Date: 2018-07-10 10:59 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c18ca8590dfa 8203007: Address missing block coverage for ChaCha20 and Poly1305 algorithms Summary: Add unit tests for ChaCha20Cipher, ChaCha20Poly1305Parameters and Poly1305 Reviewed-by: xuelei, jnimeh + test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/unittest/ChaCha20CipherUnitTest.java + test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/unittest/ChaCha20Poly1305ParametersUnitTest.java + test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/unittest/Poly1305UnitTestDriver.java + test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/unittest/java.base/com/sun/crypto/provider/Poly1305UnitTest.java Changeset: 4df86b2a804d Author: kvn Date: 2018-07-09 22:20 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4df86b2a804d 8206952: java/lang/Class/GetPackageBootLoaderChildLayer.java fails with Graal Summary: don't run test with Graal Reviewed-by: mchung, epavlova ! test/jdk/java/lang/Class/GetPackageBootLoaderChildLayer.java Changeset: 46ca5e6b7ed8 Author: dholmes Date: 2018-07-10 03:14 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/46ca5e6b7ed8 8206954: Test runtime/Thread/ThreadPriorities.java crashes with SEGV in pthread_getcpuclockid Summary: Run the new runtime/jni/terminatedThread/TestTerminatedThread.java test in othervm mode Reviewed-by: alanb, mikael ! test/hotspot/jtreg/runtime/jni/terminatedThread/TestTerminatedThread.java Changeset: 3fd01bccc81f Author: roland Date: 2018-06-29 17:59 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3fd01bccc81f 8202123: C2 Crash in Node::in(unsigned int) const+0x14 Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/loopnode.cpp + test/hotspot/jtreg/compiler/loopopts/TestLimitLoadBelowLoopLimitCheck.java Changeset: e4ca45413ddd Author: tschatzl Date: 2018-07-10 15:09 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e4ca45413ddd 8206476: Wrong assert in phase_enum_2_phase_string() in referenceProcessorPhaseTimes.cpp Summary: A less or equal than should be less than. Reviewed-by: ehelin, kbarrett ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.cpp Changeset: 510ac4c08610 Author: thartmann Date: 2018-07-10 15:33 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/510ac4c08610 8205472: Deadlock in Kitchensink when trying to print compile queues causing timeout Summary: Do not acquire the MethodCompileQueue_lock in CompileBroker::print_compile_queues(). Reviewed-by: kvn, kbarrett, dholmes ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/runtime/thread.cpp Changeset: 01316e7ac1d1 Author: kbarrett Date: 2018-07-10 13:34 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/01316e7ac1d1 8204691: HeapRegion.apply_to_marked_objects_other_vm_test fails with assert(!hr->is_free() || hr->is_empty()) failed: Free region 0 is not empty for set Free list # Summary: Run test in safepoint. Reviewed-by: tschatzl, ehelin ! test/hotspot/gtest/gc/g1/test_heapRegion.cpp Changeset: 2a89e80301b1 Author: epavlova Date: 2018-07-10 13:54 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2a89e80301b1 8206951: [Graal] org.graalvm.compiler.hotspot.test.GraalOSRTest to ProblemList-graal.txt Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: bfeee03c49fe Author: mikael Date: 2018-07-10 16:14 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bfeee03c49fe 8207007: Add missing license header to zHash.inline.hpp Reviewed-by: tschatzl, pliden ! src/hotspot/share/gc/z/zHash.inline.hpp Changeset: 33be1da67b11 Author: kvn Date: 2018-07-10 19:42 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/33be1da67b11 8206135: Building jvm with AOT but without JVMCI should fail at configure time Reviewed-by: erikj ! make/autoconf/hotspot.m4 ! make/autoconf/spec.gmk.in ! make/common/Modules.gmk Changeset: a40b75d39ecd Author: jjiang Date: 2018-07-11 10:39 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a40b75d39ecd 8199645: javax/net/ssl/SSLSession/TestEnabledProtocols.java failed with Connection reset Summary: Refactor this test with SSLSocketTemplate Reviewed-by: xuelei ! test/jdk/javax/net/ssl/SSLSession/TestEnabledProtocols.java Changeset: 43ee4f1c333b Author: serb Date: 2018-07-11 13:17 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/43ee4f1c333b 8205973: Client jtreg ProblemList cleanup Reviewed-by: prr ! test/jdk/ProblemList.txt Changeset: 003aa3e59090 Author: serb Date: 2018-07-11 13:41 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/003aa3e59090 8202264: Race condition in AudioClip.loop() Reviewed-by: prr ! src/java.desktop/share/classes/com/sun/media/sound/EventDispatcher.java ! src/java.desktop/share/classes/com/sun/media/sound/JavaSoundAudioClip.java + test/jdk/javax/sound/sampled/Clip/AutoCloseTimeCheck.java Changeset: 9937ef7499dc Author: ghaug Date: 2018-07-10 11:36 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9937ef7499dc 8206919: s390: add missing info to vm_version_ext_s390 Reviewed-by: simonis, mdoerr ! src/hotspot/cpu/s390/vm_version_ext_s390.cpp ! src/hotspot/cpu/s390/vm_version_ext_s390.hpp ! src/hotspot/cpu/s390/vm_version_s390.cpp ! src/hotspot/cpu/s390/vm_version_s390.hpp ! test/jdk/jdk/jfr/event/os/TestCPUInformation.java Changeset: 0484b16ef437 Author: dl Date: 2018-07-10 10:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0484b16ef437 8205576: forkjoin/FJExceptionTableLeak.java fails "AssertionError: failed to satisfy condition" Reviewed-by: martin, psandoz, dholmes, tschatzl ! test/jdk/java/util/concurrent/forkjoin/FJExceptionTableLeak.java Changeset: 1880809b126d Author: rhalade Date: 2018-07-11 11:17 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1880809b126d 8205967: Remove sun/security/krb5/auto/UnboundSSL.java from ProblemList.txt Reviewed-by: xuelei, rhalade Contributed-by: Andrew Wong ! test/jdk/ProblemList.txt Changeset: 46d206233051 Author: bulasevich Date: 2018-07-11 15:08 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/46d206233051 8207044: minimal vm build fail: missing #include Summary: Add missing #include Reviewed-by: kbarrett, shade Contributed-by: boris.ulasevich at bell-sw.com ! src/hotspot/share/gc/shared/space.inline.hpp Changeset: 3312e730c791 Author: jwilhelm Date: 2018-07-11 21:41 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3312e730c791 Merge ! .hgtags ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/services/mallocSiteTable.cpp ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties ! test/hotspot/jtreg/ProblemList-graal.txt ! test/jdk/ProblemList.txt ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java Changeset: ae39e5a991ed Author: bchristi Date: 2018-07-11 14:32 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ae39e5a991ed 8207005: Disable the file canonicalization cache by default Reviewed-by: alanb, bpb ! src/java.base/share/classes/java/io/FileSystem.java Changeset: e0bce2635ec5 Author: darcy Date: 2018-07-11 16:12 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e0bce2635ec5 8207055: Make javac -help output for -source and -target more informative Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Target.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Option.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties ! test/langtools/jdk/javadoc/tool/modules/ReleaseOptions.java ! test/langtools/tools/javac/modules/AddLimitMods.java Changeset: 5c3c53703b8b Author: jwilhelm Date: 2018-07-12 12:22 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5c3c53703b8b Added tag jdk-12+2 for changeset 69b438908512 ! .hgtags Changeset: f378705346bf Author: zgu Date: 2018-07-11 13:55 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f378705346bf 8207056: Epsilon GC to support object pinning Summary: Epsilon GC to use object pinning to avoid expensive GCLocker Reviewed-by: shade, rkennke ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp Changeset: 6c449bdee4fa Author: igerasim Date: 2018-07-12 06:04 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6c449bdee4fa 8207145: (fs) Native memory leak in WindowsNativeDispatcher.LookupPrivilegeValue0 Reviewed-by: alanb ! src/java.base/windows/classes/sun/nio/fs/WindowsSecurity.java ! src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c Changeset: 68646e6522ca Author: igerasim Date: 2018-07-12 11:18 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/68646e6522ca 8207060: Memory leak when malloc fails within WITH_UNICODE_STRING block Reviewed-by: vtewari, rriggs ! src/java.base/windows/native/libjava/io_util_md.c Changeset: 215d1a5b097a Author: igerasim Date: 2018-07-12 11:32 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/215d1a5b097a 8206122: Use Queue in place of ArrayList when need to remove first element Reviewed-by: martin, jjg, vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTaskPool.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Analyzer.java Changeset: 69634e97740c Author: joehw Date: 2018-07-12 12:06 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/69634e97740c 8194680: StartElement#getAttributes and getNamespaces refer to incorrect package Reviewed-by: jjg, lancea ! src/java.xml/share/classes/javax/xml/stream/events/StartElement.java Changeset: 860a3648c494 Author: darcy Date: 2018-07-12 14:13 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/860a3648c494 8028563: Remove javac support for 6/1.6 source and target values Reviewed-by: jjg, erikj, henryjen - make/data/symbols/java.base-6.sym.txt - make/data/symbols/java.compiler-6.sym.txt - make/data/symbols/java.desktop-6.sym.txt - make/data/symbols/java.logging-6.sym.txt - make/data/symbols/java.management-6.sym.txt - make/data/symbols/java.rmi-6.sym.txt - make/data/symbols/java.security.jgss-6.sym.txt - make/data/symbols/java.sql-6.sym.txt - make/data/symbols/java.sql.rowset-6.sym.txt - make/data/symbols/java.xml-6.sym.txt - make/data/symbols/java.xml.bind-6.sym.txt - make/data/symbols/java.xml.ws-6.sym.txt - make/data/symbols/java.xml.ws.annotation-6.sym.txt - make/data/symbols/jdk.management-6.sym.txt - make/data/symbols/jdk.sctp-6.sym.txt - make/data/symbols/jdk.security.jgss-6.sym.txt ! make/data/symbols/symbols ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Target.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/jdk/tools/pack200/PackageVersionTest.java ! test/langtools/ProblemList.txt ! test/langtools/jdk/jshell/CompilerOptionsTest.java ! test/langtools/tools/javac/conditional/Conditional.java ! test/langtools/tools/javac/conditional/Conditional.out ! test/langtools/tools/javac/defaultMethodsVisibility/DefaultMethodsNotVisibleForSourceLessThan8Test.java ! test/langtools/tools/javac/diags/examples.not-yet.txt ! test/langtools/tools/javac/diags/examples/AnnotationsAfterTypeParamsNotSupportedInSource.java ! test/langtools/tools/javac/diags/examples/DiamondNotSupported.java - test/langtools/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java - test/langtools/tools/javac/diags/examples/MulticatchNotSupported.java ! test/langtools/tools/javac/diags/examples/ObsoleteSourceAndTarget.java ! test/langtools/tools/javac/diags/examples/ParametersUnsupported.java ! test/langtools/tools/javac/diags/examples/RepeatableAnnotationsNotSupported.java ! test/langtools/tools/javac/diags/examples/SourceNoBootclasspath.java - test/langtools/tools/javac/diags/examples/StringSwitchNotSupported.java - test/langtools/tools/javac/diags/examples/TryResourceNotSupported.java - test/langtools/tools/javac/diags/examples/TryWithoutCatchOrFinally.java ! test/langtools/tools/javac/diags/examples/TypeAnnotationsNotSupported.java - test/langtools/tools/javac/diags/examples/UnsupportedBinaryLiteral.java - test/langtools/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java ! test/langtools/tools/javac/generics/inference/6278587/T6278587Neg.java ! test/langtools/tools/javac/generics/inference/6278587/T6278587Neg.out ! test/langtools/tools/javac/generics/odersky/BadTest4.java ! test/langtools/tools/javac/generics/odersky/BadTest4.out ! test/langtools/tools/javac/lambda/SourceLevelTest.java ! test/langtools/tools/javac/lambda/SourceLevelTest.out ! test/langtools/tools/javac/options/modes/SourceTargetTest.java ! test/langtools/tools/javac/options/release/ReleaseOption.java ! test/langtools/tools/javac/options/release/ReleaseOptionThroughAPI.java ! test/langtools/tools/javac/processing/environment/TestSourceVersion.java ! test/langtools/tools/javac/varargs/6313164/T6313164.java ! test/langtools/tools/javac/varargs/6313164/T6313164Source7.out ! test/langtools/tools/javac/varargs/warning/Warn4.java ! test/langtools/tools/javac/versions/Versions.java Changeset: 5c58b4c10fbd Author: lmesnik Date: 2018-07-12 13:32 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5c58b4c10fbd 8139876: Exclude hanging nsk/stress/stack from execution with deoptimization enabled Reviewed-by: kvn, mseledtsov ! test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java ! test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTestCompiler.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack001.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack002.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack003.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack004.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack005.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack006.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack007.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack008.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack009.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack010.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack011.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack012.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack013.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack014.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack015.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack016.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack017.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack018.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack019.java Changeset: 70295a56c207 Author: gadams Date: 2018-07-12 10:41 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/70295a56c207 8206007: nsk/jdb/exclude001 test is taking a long time on some builds Reviewed-by: cjplummer, sspitsyn ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdb/exclude/exclude001/exclude001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/exclude/exclude001/exclude001a.java Changeset: 96ea37459ca7 Author: mikael Date: 2018-07-12 17:29 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/96ea37459ca7 8207011: Remove uses of the register storage class specifier Reviewed-by: kbarrett, kvn ! src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp ! src/hotspot/os_cpu/bsd_x86/os_bsd_x86.cpp ! src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp ! src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp ! src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp ! src/hotspot/share/adlc/adlparse.cpp ! src/hotspot/share/adlc/arena.cpp ! src/hotspot/share/adlc/dict2.cpp ! src/hotspot/share/adlc/main.cpp ! src/hotspot/share/interpreter/bytecodeInterpreter.cpp ! src/hotspot/share/libadt/dict.cpp ! src/hotspot/share/libadt/set.cpp ! src/hotspot/share/libadt/vectset.cpp ! src/hotspot/share/memory/arena.cpp ! src/hotspot/share/opto/mulnode.cpp Changeset: 4e98b465d706 Author: weijun Date: 2018-07-12 08:44 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4e98b465d706 8206189: sun/security/pkcs12/EmptyPassword.java fails with Sequence tag error Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 080776992b29 Author: valeriep Date: 2018-07-13 02:36 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/080776992b29 8179098: Crypto AES/ECB encryption/decryption performance regression (introduced in jdk9b73) Summary: Do bounds check per encryption/decryption call instead of per block Reviewed-by: ascarpino, redestad ! src/java.base/share/classes/com/sun/crypto/provider/AESCrypt.java ! src/java.base/share/classes/com/sun/crypto/provider/CipherBlockChaining.java ! src/java.base/share/classes/com/sun/crypto/provider/CipherFeedback.java ! src/java.base/share/classes/com/sun/crypto/provider/CounterMode.java ! src/java.base/share/classes/com/sun/crypto/provider/ElectronicCodeBook.java ! src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java ! src/java.base/share/classes/com/sun/crypto/provider/OutputFeedback.java ! src/java.base/share/classes/com/sun/crypto/provider/PCBC.java + src/java.base/share/classes/sun/security/util/ArrayUtil.java Changeset: 02a46b740866 Author: dtitov Date: 2018-07-12 22:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/02a46b740866 8191948: db error: InvalidTypeException: Can't assign double[][][] to double[][][] Reviewed-by: sspitsyn, amenkov ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/eval/eval001/eval001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/eval/eval001/eval001a.java Changeset: 147b20e60274 Author: nishjain Date: 2018-07-13 14:04 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/147b20e60274 8193444: SimpleDateFormat throws ArrayIndexOutOfBoundsException when format contains long sequences of unicode characters Reviewed-by: naoto, rriggs ! src/java.base/share/classes/java/text/SimpleDateFormat.java + test/jdk/java/text/Format/DateFormat/Bug8193444.java Changeset: a3183ce753e6 Author: amenkov Date: 2018-07-13 10:10 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a3183ce753e6 8201513: nsk/jvmti/IterateThroughHeap/filter-* are broken Reviewed-by: sspitsyn, cjplummer ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateThroughHeap/filter-tagged/HeapFilter.c Changeset: 3ddf41505d54 Author: iklam Date: 2018-06-03 23:33 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3ddf41505d54 8204267: Generate comments in -XX:+PrintInterpreter to link to source code Summary: Changed __ macro to use Disassembler::hook() Reviewed-by: coleenp, aph ! src/hotspot/cpu/x86/methodHandles_x86.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86_32.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/share/compiler/disassembler.cpp ! src/hotspot/share/compiler/disassembler.hpp ! src/hotspot/share/interpreter/templateInterpreterGenerator.cpp Changeset: 13ed0d538b89 Author: coleenp Date: 2018-07-13 13:58 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/13ed0d538b89 8206470: Incorrect use of os::lasterror in ClassListParser Summary: The change is for future-proof the code in case errno gets overwritten inside the allocation logic. Reviewed-by: dholmes Contributed-by: patricio.chilano.mateo at oracle.com ! src/hotspot/share/classfile/classListParser.cpp Changeset: 44c355346475 Author: jjiang Date: 2018-07-14 07:31 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/44c355346475 8206443: Update security libs manual test to cope with removal of javac -source/-target 6 Summary: Change compile -source/-target from 1.6 to 1.7 Reviewed-by: xuelei ! test/jdk/javax/net/ssl/compatibility/Compatibility.java ! test/jdk/javax/net/ssl/compatibility/JdkRelease.java ! test/jdk/javax/net/ssl/compatibility/Parameter.java ! test/jdk/javax/net/ssl/compatibility/README ! test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java Changeset: bb16beb8f792 Author: mikael Date: 2018-07-12 15:02 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bb16beb8f792 8207210: Problem list javax/sound/sampled/Clip/AutoCloseTimeCheck.java Reviewed-by: prr ! test/jdk/ProblemList.txt Changeset: 175187a33b83 Author: jcbeyler Date: 2018-07-10 15:29 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/175187a33b83 8205643: HeapMonitorGCCMSTest fails with Graal Summary: Do not run HeapMonitorGCCMSTest with Graal Reviewed-by: amenkov, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java Changeset: 9f310b672b8c Author: naoto Date: 2018-07-11 14:47 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9f310b672b8c 8206980: ZonedDateTime could not parse timezone name with zh_CN locale correctly. Reviewed-by: rriggs ! src/java.base/share/classes/sun/util/cldr/CLDRTimeZoneNameProviderImpl.java ! test/jdk/java/time/test/java/time/format/TestZoneTextPrinterParser.java Changeset: 53b0d5ad71db Author: rhalade Date: 2018-07-11 14:54 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/53b0d5ad71db 8207068: Add Entrust root certificates Reviewed-by: weijun ! src/java.base/share/lib/security/cacerts ! test/jdk/lib/security/cacerts/VerifyCACerts.java + test/jdk/security/infra/java/security/cert/CertPathValidator/certification/EntrustCA.java Changeset: 038688fa32d0 Author: weijun Date: 2018-07-12 08:44 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/038688fa32d0 8206189: sun/security/pkcs12/EmptyPassword.java fails with Sequence tag error Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java Changeset: 1a89ca728abd Author: shade Date: 2018-07-12 09:13 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1a89ca728abd 8207006: serviceability/sa/TestUniverse.java#id0 crashes with EpsilonGC and AOT Reviewed-by: twisti, kvn ! src/hotspot/share/aot/aotCodeHeap.cpp Changeset: 20a772d8ded0 Author: mhalder Date: 2018-07-12 15:17 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/20a772d8ded0 8204860: The frame could be resized by dragging a corner of the frame with the mouse Reviewed-by: prr, psadhukhan ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! test/jdk/java/awt/Frame/UnfocusableMaximizedFrameResizablity/UnfocusableMaximizedFrameResizablity.java Changeset: 5bf28fee65c1 Author: jwilhelm Date: 2018-07-12 13:40 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5bf28fee65c1 Added tag jdk-11+22 for changeset 9937ef7499dc ! .hgtags Changeset: 0961485fc686 Author: kaddepalli Date: 2018-07-12 17:34 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0961485fc686 8206238: Aspect ratio is not maintained when Image is scaled in JEditorPane Reviewed-by: prr, sveerabhadra ! src/java.desktop/share/classes/javax/swing/text/html/ImageView.java ! test/jdk/javax/swing/JEditorPane/8195095/ImageViewTest.java Changeset: 2e675859332a Author: erikj Date: 2018-07-12 07:14 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2e675859332a 8206903: Unable to build Client VM with JVMCI Reviewed-by: erikj, kvn Contributed-by: aleksei.voitylov at bell-sw.com ! make/autoconf/hotspot.m4 Changeset: d5d5f6658b12 Author: erikj Date: 2018-07-12 16:30 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d5d5f6658b12 8207001: *.obj.log files get truncated causing unreliable incremental builds on Windows Reviewed-by: erikj, tbell Contributed-by: ralf.schmelter at sap.com ! make/common/MakeBase.gmk Changeset: 2f4c3cac8556 Author: goetz Date: 2018-07-11 16:11 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2f4c3cac8556 8206977: Minor improvements of runtime code. Reviewed-by: coleenp, lfoltan ! src/hotspot/cpu/x86/vm_version_ext_x86.cpp ! src/hotspot/cpu/x86/vm_version_ext_x86.hpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/perfMemory_linux.cpp ! src/hotspot/share/classfile/moduleEntry.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/logging/logOutput.cpp ! src/hotspot/share/memory/filemap.cpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/virtualspace.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/runtime/flags/jvmFlag.cpp ! src/hotspot/share/services/writeableFlags.cpp ! src/hotspot/share/utilities/ostream.cpp ! test/hotspot/gtest/logging/logTestUtils.inline.hpp ! test/hotspot/gtest/memory/test_metachunk.cpp Changeset: 040880bdd0d4 Author: psandoz Date: 2018-07-11 15:35 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/040880bdd0d4 8207027: Lookup.accessClass fails for an array type in the same package when assertions are enabled Reviewed-by: redestad, mchung ! src/java.base/share/classes/sun/invoke/util/VerifyAccess.java ! test/jdk/java/lang/invoke/t8150782/TestAccessClass.java ! test/jdk/java/lang/invoke/t8150782/TestFindClass.java Changeset: 6a037fd949e4 Author: naoto Date: 2018-07-12 11:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6a037fd949e4 8207152: Placeholder for Japanese new era should be two characters Reviewed-by: rriggs ! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_ja.java ! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ja.java ! test/jdk/java/util/Calendar/JapaneseEraNameTest.java Changeset: 34696f3aa22b Author: kvn Date: 2018-07-12 11:57 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/34696f3aa22b 8206953: compiler/profiling/TestTypeProfiling.java fails when JVMCI build disabled Summary: restore original behavior when C2 is used Reviewed-by: thartmann, mdoerr, dnsimon, gdub ! src/hotspot/share/runtime/deoptimization.cpp ! test/hotspot/jtreg/compiler/profiling/TestTypeProfiling.java Changeset: bf686c47c109 Author: jcbeyler Date: 2018-07-12 12:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf686c47c109 8206960: HeapMonitor tests fail with Graal Summary: Remove checking lines and disable VMEventsTest when using Graal Reviewed-by: amenkov, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorVMEventsTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c Changeset: e6ee7cf448f0 Author: mikael Date: 2018-07-12 15:02 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e6ee7cf448f0 8207210: Problem list javax/sound/sampled/Clip/AutoCloseTimeCheck.java Reviewed-by: prr ! test/jdk/ProblemList.txt Changeset: 7c96d1e40280 Author: mikael Date: 2018-07-12 17:32 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7c96d1e40280 8207217: Problem list java/lang/management/ThreadMXBean/AllThreadIds.java Reviewed-by: dholmes ! test/jdk/ProblemList.txt Changeset: 9baa91bc7567 Author: xiaofeya Date: 2018-07-13 11:21 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9baa91bc7567 8202481: RegisterDuringSelect.java fails with java.util.concurrent.ExecutionException: java.nio.channels.ClosedSelectorException 8207023: Add trace info to java/nio/channels/Selector/RegisterDuringSelect.java Reviewed-by: alanb ! test/jdk/java/nio/channels/Selector/RegisterDuringSelect.java Changeset: fc6cfe40e32a Author: goetz Date: 2018-07-12 16:31 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fc6cfe40e32a 8207049: Minor improvements of compiler code. Reviewed-by: kvn, mdoerr ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/share/adlc/archDesc.cpp ! src/hotspot/share/adlc/arena.cpp ! src/hotspot/share/adlc/dfa.cpp ! src/hotspot/share/adlc/filebuff.cpp ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/adlc/main.cpp ! src/hotspot/share/adlc/output_c.cpp ! src/hotspot/share/asm/codeBuffer.cpp ! src/hotspot/share/c1/c1_IR.cpp ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/compiler/compileLog.cpp ! src/hotspot/share/compiler/disassembler.cpp ! src/hotspot/share/compiler/methodLiveness.cpp ! src/hotspot/share/compiler/oopMap.cpp ! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/bytecodeInfo.cpp ! src/hotspot/share/opto/callnode.cpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/gcm.cpp ! src/hotspot/share/opto/ifnode.cpp ! src/hotspot/share/opto/indexSet.cpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/macro.cpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/output.cpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/opto/reg_split.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/opto/type.cpp ! src/hotspot/share/runtime/simpleThresholdPolicy.cpp Changeset: 9e19d3a1a69d Author: rraghavan Date: 2018-07-13 01:31 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9e19d3a1a69d 8206873: 2 Null pointer dereference defect groups in LIRGenerator Summary: Added missing assert statements Reviewed-by: kvn, thartmann ! src/hotspot/share/c1/c1_LIRGenerator.cpp Changeset: 6ec8d47cb021 Author: zyao Date: 2018-07-11 15:00 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6ec8d47cb021 8206975: AArch64: Fix CompareAndSwapOp when useLSE is enabled in Graal Reviewed-by: adinn, aph ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64AtomicMove.java Changeset: 7b4cc0cd6fe6 Author: simonis Date: 2018-07-11 19:23 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7b4cc0cd6fe6 8207067: [test] prevent timeouts in serviceability/tmtools/jstat/{GcTest02,GcCauseTest02}.java Reviewed-by: dholmes, goetz ! test/hotspot/jtreg/serviceability/tmtools/jstat/GcCauseTest02.java ! test/hotspot/jtreg/serviceability/tmtools/jstat/GcTest02.java Changeset: 6a5c674b7413 Author: simonis Date: 2018-07-13 11:07 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6a5c674b7413 8206998: [test] runtime/ElfDecoder/TestElfDirectRead.java requires longer timeout on ppc64 Reviewed-by: zgu, dholmes ! test/hotspot/jtreg/runtime/ElfDecoder/TestElfDirectRead.java Changeset: d2e182aa44c9 Author: bulasevich Date: 2018-07-13 07:01 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d2e182aa44c9 8207047: Multiple VM variants build fail Reviewed-by: erikj ! make/hotspot/gensrc/GensrcJfr.gmk Changeset: 2282560a3d29 Author: xuelei Date: 2018-07-13 07:08 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2282560a3d29 8207029: Unable to use custom SSLEngine with default TrustManagerFactory after updating to JDK 11 b21 Reviewed-by: wetmore ! src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java Changeset: ad9d95f1a1f6 Author: roland Date: 2018-07-13 15:44 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ad9d95f1a1f6 8200282: Serializing non-zero byte as zero to ByteBuffer Summary: arraycopy converted as a series of loads/stores uses wrong slice for loads Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/arraycopynode.cpp + test/hotspot/jtreg/compiler/arraycopy/ACasLoadsStoresBadMem.java Changeset: 57c152eb3198 Author: apetcher Date: 2018-07-13 10:42 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/57c152eb3198 8206915: XDH TCK issues Summary: Fixing a couple of conformance issues in XDH Reviewed-by: mullan ! src/jdk.crypto.ec/share/classes/sun/security/ec/XDHKeyAgreement.java ! test/jdk/sun/security/ec/xec/TestXDH.java Changeset: 73c769e0486a Author: dtitov Date: 2018-07-12 22:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/73c769e0486a 8191948: db error: InvalidTypeException: Can't assign double[][][] to double[][][] Reviewed-by: sspitsyn, amenkov ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/eval/eval001/eval001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/eval/eval001/eval001a.java Changeset: c36ca9d88f54 Author: redestad Date: 2018-07-13 18:39 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c36ca9d88f54 8207235: ManagementFactory.getPlatformMXBeans(BufferPoolMXBean.class) throws NPE Reviewed-by: alanb ! src/java.base/share/classes/java/nio/Bits.java ! src/java.base/share/classes/java/nio/Buffer.java ! src/java.base/share/classes/jdk/internal/misc/SharedSecrets.java Changeset: 4447720200f2 Author: rhalade Date: 2018-07-13 09:48 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4447720200f2 8199779: Add T-Systems, GlobalSign and Starfield services root certificates Reviewed-by: mullan ! src/java.base/share/lib/security/cacerts ! test/jdk/lib/security/cacerts/VerifyCACerts.java Changeset: adc4d3fd4095 Author: kvn Date: 2018-07-13 11:13 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/adc4d3fd4095 8207065: Cleanup compiler tests for Client VM Reviewed-by: kvn, iignatyev Contributed-by: aleksei.voitylov at bell-sw.com ! test/hotspot/jtreg/compiler/c2/Test8062950.java ! test/hotspot/jtreg/compiler/loopopts/IterationSplitPredicateInconsistency.java ! test/hotspot/jtreg/compiler/loopopts/TestCMovSplitThruPhi.java ! test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMiningIterShortLoop.java ! test/hotspot/jtreg/compiler/vectorization/TestUnexpectedLoadOrdering.java Changeset: a602706ccaaa Author: jjg Date: 2018-07-13 13:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a602706ccaaa 8207213: The help-doc.html generated by the doclet is incomplete Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties Changeset: 3b5fd72147c9 Author: jwilhelm Date: 2018-07-14 02:14 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3b5fd72147c9 Merge ! .hgtags ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/share/adlc/arena.cpp ! src/hotspot/share/adlc/main.cpp ! src/hotspot/share/compiler/disassembler.cpp ! src/java.base/share/lib/security/cacerts ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties ! test/hotspot/jtreg/ProblemList.txt ! test/jdk/ProblemList.txt Changeset: 4db6e8715e35 Author: dsamersoff Date: 2018-07-15 18:16 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4db6e8715e35 8206265: aarch64 jtreg: assert in TestOptionsWithRanges.jtr Summary: Limit flag range to don't overflow 12bit instruction operand Reviewed-by: aph, dsamersoff Contributed-by: boris.ulasevich at bell-sw.com ! src/hotspot/cpu/aarch64/globals_aarch64.hpp Changeset: a49d106e9b7c Author: jlahoda Date: 2018-07-16 12:35 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a49d106e9b7c 8189747: JDK9 javax.lang.model.util.Elements#getTypeElement regressed 1000x in performance. Summary: Caching the results of Elements.getTypeElement/getPackageElement Reviewed-by: darcy ! src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/langtools/tools/javac/modules/AnnotationProcessing.java Changeset: a8ee31fb99e1 Author: sgehwolf Date: 2018-07-12 16:28 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a8ee31fb99e1 8207057: No debug info for assembler files Summary: Generate debug info for assembler files as needed. Reviewed-by: erikj ! make/autoconf/flags-cflags.m4 ! make/autoconf/spec.gmk.in ! make/common/NativeCompilation.gmk Changeset: 695dff91a997 Author: lfoltan Date: 2018-07-16 09:06 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/695dff91a997 8178712: ResourceMark may be missing inside initialize_[vi]table Summary: Clean up use of ResourceMark within initialize_[vi]table. Reviewed-by: ccheung, iklam, jiangli ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/klassVtable.hpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp Changeset: bef02342d179 Author: lfoltan Date: 2018-07-16 11:34 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bef02342d179 8205611: Improve the wording of LinkageErrors to include module and class loader information Summary: Clean up the wording of loader constraint violations to include the module and class loader information. Reviewed-by: coleenp, goetz, hseigel ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/oops/klassVtable.cpp ! test/hotspot/jtreg/runtime/LoaderConstraints/differentLE/Test.java ! test/hotspot/jtreg/runtime/LoaderConstraints/duplicateLE/Test.java ! test/hotspot/jtreg/runtime/LoaderConstraints/itableLdrConstraint/Test.java ! test/hotspot/jtreg/runtime/LoaderConstraints/vtableLdrConstraint/Test.java Changeset: 9bad3472ee2c Author: rhalade Date: 2018-07-16 08:59 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9bad3472ee2c 8207321: Merge error with 8199779 Reviewed-by: mullan ! src/java.base/share/lib/security/cacerts Changeset: e9b5be715837 Author: igerasim Date: 2018-07-16 10:07 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e9b5be715837 8207016: Avoid redundant native memory allocation in getFinalPath() Reviewed-by: alanb ! src/java.base/windows/native/libjava/WinNTFileSystem_md.c Changeset: 523eedf01aa7 Author: bpb Date: 2018-07-16 10:58 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/523eedf01aa7 8206448: (fs) Extended attributes assumed to be enabled on ext3 (lnx) Summary: Assume extended attributes are only explicitly enable on ext3 Reviewed-by: mbaesken, alanb ! src/java.base/linux/classes/sun/nio/fs/LinuxFileStore.java Changeset: babe5786dea9 Author: darcy Date: 2018-07-16 21:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/babe5786dea9 8207248: Reduce incidence of compiler.warn.source.no.bootclasspath in javac tests Reviewed-by: vromero - test/langtools/tools/javac/TryWithResources/WeirdTwr.out ! test/langtools/tools/javac/depDocComment/SuppressDeprecation.java ! test/langtools/tools/javac/depDocComment/SuppressDeprecation8.out ! test/langtools/tools/javac/diags/examples/DiamondAndAnonClass.java ! test/langtools/tools/javac/diags/examples/DirPathElementNotFound.java ! test/langtools/tools/javac/diags/examples/ModulesNotSupportedInSource/module-info.java ! test/langtools/tools/javac/diags/examples/PrivateInterfaceMethodsNotSupported.java ! test/langtools/tools/javac/diags/examples/VarInTryWithResourcesNotSupportedInSource.java ! test/langtools/tools/javac/generics/diamond/neg/Neg09a.java ! test/langtools/tools/javac/generics/diamond/neg/Neg09a.out ! test/langtools/tools/javac/generics/diamond/neg/Neg09b.java ! test/langtools/tools/javac/generics/diamond/neg/Neg09b.out ! test/langtools/tools/javac/generics/diamond/neg/Neg09c.java ! test/langtools/tools/javac/generics/diamond/neg/Neg09c.out ! test/langtools/tools/javac/generics/diamond/neg/Neg09d.java ! test/langtools/tools/javac/generics/diamond/neg/Neg09d.out - test/langtools/tools/javac/warnings/6594914/T6594914b.out Changeset: 90144bc10fe6 Author: alanb Date: 2018-07-17 08:10 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/90144bc10fe6 8207340: (fs) UnixNativeDispatcher close and readdir usages should be fixed Reviewed-by: bpb ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c Changeset: cecc2e10edf4 Author: jlahoda Date: 2018-07-17 14:28 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cecc2e10edf4 8207229: Trees.getScope crashes for broken lambda 8207230: Trees.getScope runs Analyzers Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Analyzer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! test/langtools/tools/javac/api/TestGetScopeResult.java Changeset: e34379f2a1c8 Author: ccheung Date: 2018-07-17 11:58 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e34379f2a1c8 8204591: Expire/remove the UseAppCDS option in JDK 12 Reviewed-by: jiangli, mseledtsov, iklam ! src/hotspot/share/runtime/arguments.cpp ! test/hotspot/jtreg/runtime/appcds/CommandLineFlagComboNegative.java - test/hotspot/jtreg/runtime/appcds/MismatchedUseAppCDS.java - test/hotspot/jtreg/runtime/appcds/test-classes/CheckIfShared.java Changeset: c6600aba799b Author: bpb Date: 2018-07-17 12:03 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c6600aba799b 8202794: Native Unix code should use readdir rather than readdir_r Reviewed-by: alanb, bsrbnd Contributed-by: Bernard Blaser ! src/java.base/unix/native/libjava/TimeZone_md.c ! src/java.base/unix/native/libjava/UnixFileSystem_md.c ! src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c Changeset: f605c91e5219 Author: kbarrett Date: 2018-07-17 15:59 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f605c91e5219 8202353: os::readdir should use readdir instead of readdir_r 8202835: jfr/event/os/TestSystemProcess.java fails on missing events Summary: os::readdir uses POSIX readdir, drop buffer arg, fix JFR uses. Reviewed-by: coleenp, tschatzl, bsrbnd ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/aix/os_aix.inline.hpp ! src/hotspot/os/aix/os_perf_aix.cpp ! src/hotspot/os/aix/perfMemory_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/bsd/os_bsd.inline.hpp ! src/hotspot/os/bsd/perfMemory_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_linux.inline.hpp ! src/hotspot/os/linux/os_perf_linux.cpp ! src/hotspot/os/linux/perfMemory_linux.cpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/solaris/os_perf_solaris.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/solaris/os_solaris.inline.hpp ! src/hotspot/os/solaris/perfMemory_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/os/windows/os_windows.inline.hpp ! src/hotspot/os/windows/perfMemory_windows.cpp ! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp ! src/hotspot/share/runtime/os.hpp ! test/jdk/ProblemList.txt Changeset: 35e64b62b284 Author: rriggs Date: 2018-07-17 17:14 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/35e64b62b284 8205610: [TESTLIB] Improve listing of open file descriptors Reviewed-by: lancea ! test/lib/jdk/test/lib/util/FileUtils.java Changeset: 54106907e72e Author: bpb Date: 2018-07-17 16:22 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/54106907e72e 8207748: Fix for 8202794 breaks tier1 builds Reviewed-by: kbarrett, darcy ! src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c Changeset: 6c5b01529873 Author: igerasim Date: 2018-07-17 17:17 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6c5b01529873 8207750: Native handle leak in java.io.WinNTFileSystem.list() Reviewed-by: bpb ! src/java.base/windows/native/libjava/WinNTFileSystem_md.c Changeset: 03f2bfdcb636 Author: martin Date: 2018-07-17 17:36 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/03f2bfdcb636 8206863: A closed JarVerifier.VerifierStream should throw IOException Reviewed-by: rasbold Contributed-by: Tobias Thierer , Martin Buchholz ! src/java.base/share/classes/java/util/jar/JarVerifier.java ! test/jdk/java/util/jar/JarFile/SignedJarFileGetInputStream.java Changeset: 99a7d10f248c Author: alanb Date: 2018-07-18 07:39 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/99a7d10f248c 8207393: ServiceLoader class description improvements Reviewed-by: alanb, lancea Contributed-by: alex.buckley at oracle.com ! src/java.base/share/classes/java/util/ServiceLoader.java Changeset: e43f36744522 Author: rriggs Date: 2018-07-18 09:46 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e43f36744522 8189717: Too much documentation of ProcessBuilder.start copied to ProcessBuilder.startPipeline Reviewed-by: bpb, lancea ! src/java.base/share/classes/java/lang/ProcessBuilder.java Changeset: 45108171551d Author: darcy Date: 2018-07-18 08:27 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/45108171551d 8207751: Remove misleading serialVersionUID from JulienFields.Field Reviewed-by: lancea ! src/java.base/share/classes/java/time/temporal/JulianFields.java Changeset: 990db216e719 Author: rhalade Date: 2018-07-18 09:50 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/990db216e719 8203230: update VerifyCACerts test Reviewed-by: mullan ! test/jdk/lib/security/cacerts/VerifyCACerts.java Changeset: 6659a00bc2ea Author: jnimeh Date: 2018-07-18 14:32 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6659a00bc2ea 8207237: SSLSocket#setEnabledCipherSuites is accepting empty string Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/CipherSuite.java Changeset: 7e34f3da2293 Author: darcy Date: 2018-07-18 16:13 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7e34f3da2293 8203263: Remove unnecessary throws clauses from serialization-related methods Reviewed-by: prr ! src/java.desktop/share/classes/java/awt/Font.java ! src/java.desktop/share/classes/java/awt/MenuBar.java ! src/java.desktop/share/classes/java/awt/font/TransformAttribute.java ! src/java.desktop/share/classes/java/awt/geom/AffineTransform.java ! src/java.desktop/share/classes/java/beans/beancontext/BeanContextSupport.java Changeset: c96c7d08ae49 Author: mli Date: 2018-07-19 16:22 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c96c7d08ae49 8207316: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed Reviewed-by: alanb, simonis ! test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/CloseTest.java ! test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/EchoService.java ! test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/EchoTest.java ! test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java ! test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/StateTest.java Changeset: 2467bd84c59b Author: darcy Date: 2018-07-19 09:20 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2467bd84c59b 8207816: Align declaration of SerializedLambda.readResolve with serialization conventions Reviewed-by: briangoetz ! src/java.base/share/classes/java/lang/invoke/SerializedLambda.java Changeset: 02266d771ec5 Author: prr Date: 2018-07-19 09:46 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/02266d771ec5 Added tag jdk-12+3 for changeset 990db216e719 ! .hgtags Changeset: dccdf51b10dd Author: goetz Date: 2018-07-13 17:42 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dccdf51b10dd 8207233: Minor improvements of jdk C-coding Reviewed-by: rriggs, prr ! src/java.base/share/native/libzip/zip_util.c ! src/java.desktop/unix/native/common/awt/fontpath.c ! src/java.smartcardio/share/native/libj2pcsc/pcsc.c ! src/jdk.crypto.ec/share/native/libsunec/impl/ecl_mult.c ! src/jdk.jdwp.agent/share/native/libjdwp/transport.c ! src/jdk.pack/share/native/common-unpack/unpack.cpp ! src/jdk.security.auth/unix/native/libjaas/Unix.c Changeset: 44483330f7cf Author: dsamersoff Date: 2018-07-15 20:15 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/44483330f7cf 8206265: aarch64 jtreg: assert in TestOptionsWithRanges.jtr Summary: Limit flag range to don't overflow 12bit instruction operand Reviewed-by: aph, dsamersoff Contributed-by: boris.ulasevich at bell-sw.com ! src/hotspot/cpu/aarch64/globals_aarch64.hpp Changeset: 3c0e39975ae5 Author: jlahoda Date: 2018-07-16 12:58 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3c0e39975ae5 8189747: JDK9 javax.lang.model.util.Elements#getTypeElement regressed 1000x in performance. Summary: Caching the results of Elements.getTypeElement/getPackageElement Reviewed-by: darcy ! src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! test/langtools/tools/javac/modules/AnnotationProcessing.java Changeset: d7c4c42ab260 Author: jlahoda Date: 2018-07-16 16:31 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d7c4c42ab260 8207032: Compilation succeeds without checking readability when --add-exports used Summary: Ensuring --add-exports are only propagated when the target module reads the exporting module. Reviewed-by: vromero, jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! test/jdk/tools/launcher/modules/addexports/AddExportsTestWarningError.java ! test/langtools/tools/javac/modules/AddExportsTest.java Changeset: 40ef1bb91ee8 Author: lucy Date: 2018-07-16 16:57 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/40ef1bb91ee8 8206271: CodeHeap State Analytics must digest new method state Reviewed-by: kvn, mdoerr, thartmann ! src/hotspot/share/code/codeHeapState.cpp ! src/hotspot/share/code/codeHeapState.hpp Changeset: b6b9a2515525 Author: bpb Date: 2018-07-16 10:58 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b6b9a2515525 8206448: (fs) Extended attributes assumed to be enabled on ext3 (lnx) Summary: Assume extended attributes are only explicitly enable on ext3 Reviewed-by: mbaesken, alanb ! src/java.base/linux/classes/sun/nio/fs/LinuxFileStore.java Changeset: a25c48c0a1ab Author: dlong Date: 2018-07-16 15:09 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a25c48c0a1ab 8181855: [Graal] runtime/ReservedStack/ReservedStackTest.java triggers: assert(thread->deopt_mark() == __null) failed: no stack overflow from deopt blob/uncommon trap Reviewed-by: kvn ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/BinaryContainer.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotDeoptimizeCallerOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotEpilogueOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotJumpToExceptionHandlerInCallerOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotReturnOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotUnwindOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotReturnOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotReturnOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/ReservedStackAccessTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotHostBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotLIRGenerationResult.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotHostForeignCallsProvider.java ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: c2e676c2cf7b Author: pmuthuswamy Date: 2018-07-17 16:49 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c2e676c2cf7b 8207190: JDK 11 javadoc generates bad code example Reviewed-by: sundar ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlStyle.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testDeprecatedDocs/TestDeprecatedDocs.java ! test/langtools/jdk/javadoc/doclet/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java ! test/langtools/jdk/javadoc/doclet/testIndentation/TestIndentation.java ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testLambdaFeature/TestLambdaFeature.java ! test/langtools/jdk/javadoc/doclet/testLiteralCodeInPre/TestLiteralCodeInPre.java ! test/langtools/jdk/javadoc/doclet/testMemberSummary/TestMemberSummary.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestBadOverride.java ! test/langtools/jdk/javadoc/doclet/testPrivateClasses/TestPrivateClasses.java ! test/langtools/jdk/javadoc/doclet/testSerializedFormWithClassFile/TestSerializedFormWithClassFile.java ! test/langtools/jdk/javadoc/doclet/testSummaryTag/TestSummaryTag.java ! test/langtools/jdk/javadoc/doclet/testTypeAnnotations/TestTypeAnnotations.java Changeset: f0193a4828ef Author: chegar Date: 2018-07-17 12:22 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f0193a4828ef 8207265: Bad HTML in {@link} in HttpResponse.BodySubscribers.ofPublisher Reviewed-by: michaelm ! src/java.net.http/share/classes/java/net/http/HttpResponse.java Changeset: 0a018efec082 Author: coleenp Date: 2018-07-10 11:13 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0a018efec082 8206471: Race with ConcurrentHashTable deleting items on insert with cleanup thread Summary: Only fetch Node::next once and use that result. Reviewed-by: hseigel, dholmes ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp Changeset: d379f06962cf Author: coleenp Date: 2018-07-17 09:37 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d379f06962cf Merge Changeset: 9502e3b9d415 Author: weijun Date: 2018-07-17 22:22 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9502e3b9d415 8207318: KeyStore#getInstance(File, LoadStoreParameter) does not load the keystore Reviewed-by: mullan ! src/java.base/share/classes/java/security/KeyStore.java ! test/jdk/java/security/KeyStore/ProbeKeystores.java Changeset: 8a07817a6c57 Author: aph Date: 2018-07-17 15:28 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8a07817a6c57 8207345: AArch64: Trampoline generation code reads from unitialized memory Reviewed-by: shade ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp Changeset: e15cd424736d Author: dpochepk Date: 2018-07-17 19:25 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e15cd424736d 8207240: AARCH64: C2-only VM does not build Reviewed-by: shade Contributed-by: aleksei.voitylov at bell-sw.com ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp Changeset: a0de9a3a6766 Author: apetcher Date: 2018-07-17 13:04 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a0de9a3a6766 8206929: Check session context for TLS 1.3 session resumption Summary: additional checks to prevent TLS 1.3 sessions from being resumed when they shouldn't Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/PostHandshakeContext.java ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java + test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksClient.java + test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java Changeset: 610d15624bdd Author: dtitov Date: 2018-07-17 11:20 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/610d15624bdd 8207261: [Graal] JDI and JDWP tests that consume all memory should be filtered out to not run with Graal Reviewed-by: sspitsyn, cjplummer ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects001/referringObjects001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects003/referringObjects003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ReferenceType/instances/instances001/instances001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VMOutOfMemoryException/VMOutOfMemoryException001/VMOutOfMemoryException001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/instanceCounts/instancecounts001/instancecounts001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdwp/ObjectReference/ReferringObjects/referringObjects001/referringObjects001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdwp/ReferenceType/Instances/instances001/instances001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdwp/VirtualMachine/InstanceCounts/instanceCounts001/instanceCounts001.java Changeset: 6d6611346837 Author: jcbeyler Date: 2018-07-17 15:09 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6d6611346837 8205541: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java fails with Should not have any events stored yet. Summary: Fix StatArray and StatObject tests from the HeapMonitor package Reviewed-by: amenkov, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c Changeset: e3bcc86855dd Author: jcbeyler Date: 2018-07-17 17:52 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e3bcc86855dd 8205652: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java fails Summary: Fix the StatRateTest test from the HeapMonitor package Reviewed-by: amenkov, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java Changeset: 914f305ba6fa Author: jcbeyler Date: 2018-07-17 19:59 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/914f305ba6fa 8205725: Update the JVMTI Spec for Heap Sampling Summary: Update the JVMTI Spec for Heap Sampling Reviewed-by: amenkov, sspitsyn Contributed-by: jcbeyler at google.com ! src/hotspot/share/prims/jvmti.xml ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/runtime/threadHeapSampler.cpp ! src/hotspot/share/runtime/threadHeapSampler.hpp ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorArrayAllSampledTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorIllegalArgumentTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatArrayCorrectnessTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorVMEventsTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c Changeset: c95334202a14 Author: mdoerr Date: 2018-07-18 11:27 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c95334202a14 8207342: error occurred during error reporting (printing register info) Summary: os::print_location misses a check if the pointer is readable. Reviewed-by: goetz, coleenp ! src/hotspot/os/aix/misc_aix.cpp ! src/hotspot/os/aix/misc_aix.hpp ! src/hotspot/os/aix/porting_aix.cpp ! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp ! src/hotspot/os_cpu/linux_s390/os_linux_s390.cpp ! src/hotspot/share/code/codeHeapState.cpp ! src/hotspot/share/code/codeHeapState.hpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/os.hpp Changeset: 1edcf36fe15f Author: jcbeyler Date: 2018-07-18 11:57 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1edcf36fe15f 8207763: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java failed with Error. Parse Exception: Can't find source file: HeapMonitorStatIntervalTest.java Summary: Rename the test. Reviewed-by: amenkov, sspitsyn Contributed-by: jcbeyler at google.com + test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatIntervalTest.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java Changeset: 2dd2d73c52f6 Author: weijun Date: 2018-07-19 00:14 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2dd2d73c52f6 8207250: setUseClientMode post handshake with the same value as before does not throw IAE Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/TransportContext.java ! test/jdk/sun/security/ssl/SSLEngineImpl/EngineEnforceUseClientMode.java Changeset: 69dc9ea17b33 Author: weijun Date: 2018-07-19 00:14 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/69dc9ea17b33 8202837: PBES2 AlgorithmId encoding error in PKCS12 KeyStore Reviewed-by: xuelei ! src/java.base/share/classes/com/sun/crypto/provider/PBES2Parameters.java ! src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java + test/jdk/sun/security/pkcs12/PBES2Encoding.java Changeset: dfa8a5be78c4 Author: shade Date: 2018-07-11 08:44 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dfa8a5be78c4 8206931: Misleading "COMPILE SKIPPED: invalid non-klass dependency" compile log Reviewed-by: vlivanov, never ! src/hotspot/share/ci/ciEnv.cpp Changeset: 7dc181cb3603 Author: epavlova Date: 2018-07-18 13:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7dc181cb3603 8207380: compiler/graalunit/JttLangMTest.java timeout Reviewed-by: kvn - test/hotspot/jtreg/compiler/graalunit/JttLangMTest.java + test/hotspot/jtreg/compiler/graalunit/JttLangMathALTest.java + test/hotspot/jtreg/compiler/graalunit/JttLangMathMZTest.java ! test/hotspot/jtreg/compiler/graalunit/TestPackages.txt Changeset: 04764dc834d0 Author: gromero Date: 2018-06-24 21:48 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/04764dc834d0 8205580: PPC64: RTM: Don't retry lock on abort if abort was intentional Reviewed-by: mdoerr, goetz ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp Changeset: 08c3167e2d22 Author: gromero Date: 2018-06-26 08:33 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/08c3167e2d22 8205581: PPC64: RTM: Fix abort on native calls Reviewed-by: mdoerr, goetz ! src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp Changeset: a1a53d240353 Author: gromero Date: 2018-07-06 16:25 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a1a53d240353 8205582: PPC64: RTM: Fix counter for aborts on nested transactions Reviewed-by: mdoerr, goetz ! src/hotspot/cpu/ppc/assembler_ppc.hpp ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp Changeset: 959dbf7e96d0 Author: gromero Date: 2018-06-23 18:02 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/959dbf7e96d0 8205390: jtreg: Fix failing TestRTMSpinLoopCount on PPC64 Reviewed-by: kvn, iignatyev ! test/hotspot/jtreg/compiler/rtm/locking/TestRTMSpinLoopCount.java Changeset: a2a25f5bfd18 Author: gromero Date: 2018-06-24 17:11 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a2a25f5bfd18 8205578: jtreg: Fix failing TestRTMAbortRatio on PPC64 Reviewed-by: iignatyev, kvn ! test/hotspot/jtreg/compiler/rtm/locking/TestRTMAbortRatio.java Changeset: 2449e681ac60 Author: epavlova Date: 2018-07-18 14:44 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2449e681ac60 8207761: Split compiler/graalunit/JttReflectFTest.java Reviewed-by: kvn - test/hotspot/jtreg/compiler/graalunit/JttReflectFTest.java + test/hotspot/jtreg/compiler/graalunit/JttReflectFieldGetTest.java + test/hotspot/jtreg/compiler/graalunit/JttReflectFieldSetTest.java ! test/hotspot/jtreg/compiler/graalunit/TestPackages.txt ! test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java Changeset: d6b131d2bc8b Author: vtewari Date: 2018-01-18 13:55 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d6b131d2bc8b 8193419: Better Internet address support Reviewed-by: chegar, rriggs, igerasim, skoivu, rhalade ! src/java.base/share/native/libjava/jni_util.h ! src/java.base/share/native/libnet/net_util.c ! src/java.base/unix/native/libnet/Inet4AddressImpl.c ! src/java.base/unix/native/libnet/Inet6AddressImpl.c ! src/java.base/unix/native/libnet/NetworkInterface.c ! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c ! src/java.base/unix/native/libnet/net_util_md.c ! src/java.base/windows/native/libnet/Inet4AddressImpl.c ! src/java.base/windows/native/libnet/Inet6AddressImpl.c ! src/java.base/windows/native/libnet/NetworkInterface.c ! src/java.base/windows/native/libnet/NetworkInterface_winXP.c ! src/java.base/windows/native/libnet/TwoStacksPlainDatagramSocketImpl.c ! src/java.base/windows/native/libnet/net_util_md.c Changeset: edd69f959190 Author: serb Date: 2018-01-31 18:13 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/edd69f959190 8191239: Improve desktop file usage Reviewed-by: prr, rhalade, aghaisas ! src/java.desktop/macosx/classes/com/apple/eio/FileManager.java ! src/java.desktop/share/classes/java/awt/Desktop.java Changeset: 78f16a9f7563 Author: igerasim Date: 2018-02-05 14:18 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/78f16a9f7563 8196224: Even better Internet address support Reviewed-by: chegar, rriggs, rhalade, vtewari ! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c ! src/java.base/windows/native/libnet/TwoStacksPlainDatagramSocketImpl.c Changeset: 393f8a42190b Author: sherman Date: 2018-03-15 16:04 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/393f8a42190b 8199547: Exception to Pattern Syntax Reviewed-by: rriggs ! src/java.base/share/classes/java/util/regex/PatternSyntaxException.java Changeset: c2c9c209e22a Author: apetcher Date: 2018-04-09 14:10 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c2c9c209e22a 8200332: Improve GCM counting Reviewed-by: ascarpino ! src/java.base/share/classes/com/sun/crypto/provider/GCTR.java Changeset: da85dc1f0162 Author: smarks Date: 2018-05-31 11:31 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/da85dc1f0162 8197925: Better stack walking Reviewed-by: alanb, skoivu, rriggs, igerasim, rhalade, darcy ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java Changeset: e9bbd853944d Author: vtewari Date: 2018-06-07 18:21 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e9bbd853944d 8200666: Improve LDAP support Reviewed-by: rpatil, skoivu, rhalade, chegar, rriggs, mullan Contributed-by: vyom.tewari at oracle.com ! src/java.naming/share/classes/com/sun/jndi/ldap/Connection.java Changeset: e2bf86b88863 Author: smarks Date: 2018-06-22 17:08 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e2bf86b88863 8205491: adjust reflective access checks Reviewed-by: alanb, mchung, igerasim, rhalade, ahgross ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java Changeset: 3c0a5bf931e4 Author: amlu Date: 2018-07-19 10:30 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3c0a5bf931e4 8207818: Problem list several rmi tests Reviewed-by: darcy ! test/jdk/ProblemList.txt Changeset: 1cf07877b739 Author: sspitsyn Date: 2018-07-18 20:54 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1cf07877b739 8207819: Problem list serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java Summary: Problem list the test Reviewed-by: cjplummer ! test/hotspot/jtreg/ProblemList.txt Changeset: afe2cecf8867 Author: prr Date: 2018-07-19 09:42 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/afe2cecf8867 Added tag jdk-11+23 for changeset 1edcf36fe15f ! .hgtags Changeset: 52f96cca600f Author: bobv Date: 2018-07-19 12:57 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/52f96cca600f 8206456: [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mem Reviewed-by: mbaesken, mchung ! test/jdk/jdk/internal/platform/docker/MetricsCpuTester.java ! test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java Changeset: 8b8658b1b7e4 Author: prr Date: 2018-07-19 10:17 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8b8658b1b7e4 Merge ! .hgtags ! src/hotspot/share/runtime/os.hpp ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/compiler/graalunit/JttLangMTest.java - test/hotspot/jtreg/compiler/graalunit/JttReflectFTest.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java ! test/jdk/ProblemList.txt Changeset: b94063762a7c Author: kaddepalli Date: 2018-07-02 14:31 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b94063762a7c 8197810: Test java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html fails on Windows Reviewed-by: serb, pbansal - test/jdk/java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html ! test/jdk/java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.java Changeset: 6d59a6d025e8 Author: sveerabhadra Date: 2018-07-03 16:09 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6d59a6d025e8 8195991: [TEST_BUG]:Regression manual Test java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.html fails Reviewed-by: serb, mhalder + test/jdk/java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.java Changeset: 97f4558b287f Author: prr Date: 2018-07-12 11:09 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/97f4558b287f Merge - src/java.base/share/classes/sun/net/NetworkServer.java - src/java.base/share/classes/sun/net/URLCanonicalizer.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/AltHashing.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/SymbolTable.java - test/hotspot/jtreg/runtime/SharedArchiveFile/SASymbolTableTest.java - test/hotspot/jtreg/runtime/SharedArchiveFile/SASymbolTableTestAgent.java - test/hotspot/jtreg/serviceability/sa/ClhsdbSymbol.java - test/hotspot/jtreg/serviceability/sa/ClhsdbSymbolTable.java - test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach024/java.base/java/util/ServiceConfigurationError.java - test/jdk/java/lang/System/SetProperties.java - test/jdk/sun/tools/jhsdb/AlternateHashingTest.java - test/jdk/sun/tools/jhsdb/LingeredAppWithAltHashing.java - test/langtools/tools/javac/6558548/T6558548_6.out - test/langtools/tools/javac/8013179/T8013179.java - test/langtools/tools/javac/8013179/T8013179.out - test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel1_6.out - test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel2_6.out - test/langtools/tools/javac/StringsInSwitch/NonConstantLabel6.out - test/langtools/tools/javac/StringsInSwitch/OneCaseSwitches.out - test/langtools/tools/javac/StringsInSwitch/RSCL1_6.out - test/langtools/tools/javac/StringsInSwitch/RSCL2_6.out - test/langtools/tools/javac/TryWithResources/BadTwr6.out - test/langtools/tools/javac/TryWithResources/BadTwrSyntax6.out - test/langtools/tools/javac/TryWithResources/PlainTry6.out - test/langtools/tools/javac/TryWithResources/TwrOnNonResource6.out - test/langtools/tools/javac/annotations/repeatingAnnotations/WrongVersion6.out - test/langtools/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out - test/langtools/tools/javac/defaultMethods/static/StaticInvokeQualified6.out - test/langtools/tools/javac/defaultMethods/static/StaticInvokeSimple6.out - test/langtools/tools/javac/literals/BadBinaryLiterals.6.out - test/langtools/tools/javac/literals/BadUnderscoreLiterals.6.out - test/langtools/tools/javac/types/CastObjectToPrimitiveTest.out Changeset: d03b04e7569a Author: kaddepalli Date: 2018-07-19 13:49 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d03b04e7569a 8206343: There is a typo in the java documentation of javax.swing.JScrollBar. Reviewed-by: prr, mhalder ! src/java.desktop/share/classes/javax/swing/JScrollBar.java Changeset: 17148c9457a6 Author: prr Date: 2018-07-19 10:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/17148c9457a6 Merge - make/data/symbols/java.base-6.sym.txt - make/data/symbols/java.compiler-6.sym.txt - make/data/symbols/java.desktop-6.sym.txt - make/data/symbols/java.logging-6.sym.txt - make/data/symbols/java.management-6.sym.txt - make/data/symbols/java.rmi-6.sym.txt - make/data/symbols/java.security.jgss-6.sym.txt - make/data/symbols/java.sql-6.sym.txt - make/data/symbols/java.sql.rowset-6.sym.txt - make/data/symbols/java.xml-6.sym.txt - make/data/symbols/java.xml.bind-6.sym.txt - make/data/symbols/java.xml.ws-6.sym.txt - make/data/symbols/java.xml.ws.annotation-6.sym.txt - make/data/symbols/jdk.management-6.sym.txt - make/data/symbols/jdk.sctp-6.sym.txt - make/data/symbols/jdk.security.jgss-6.sym.txt - test/hotspot/jtreg/compiler/graalunit/JttLangMTest.java - test/hotspot/jtreg/compiler/graalunit/JttReflectFTest.java - test/hotspot/jtreg/runtime/appcds/MismatchedUseAppCDS.java - test/hotspot/jtreg/runtime/appcds/test-classes/CheckIfShared.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java - test/langtools/tools/javac/TryWithResources/WeirdTwr.out - test/langtools/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java - test/langtools/tools/javac/diags/examples/MulticatchNotSupported.java - test/langtools/tools/javac/diags/examples/StringSwitchNotSupported.java - test/langtools/tools/javac/diags/examples/TryResourceNotSupported.java - test/langtools/tools/javac/diags/examples/TryWithoutCatchOrFinally.java - test/langtools/tools/javac/diags/examples/UnsupportedBinaryLiteral.java - test/langtools/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java - test/langtools/tools/javac/warnings/6594914/T6594914b.out Changeset: 0058ffa0a922 Author: naoto Date: 2018-07-19 11:15 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0058ffa0a922 8206886: Java does not set the default format locale correctly on mac10.13 Reviewed-by: rriggs ! src/java.base/macosx/native/libjava/java_props_macosx.c Changeset: 7410cb248bbf Author: never Date: 2018-07-19 12:55 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7410cb248bbf 8207202: [Graal] compiler/graalunit/CoreTest.java fails Reviewed-by: kvn ! src/hotspot/share/interpreter/interpreterRuntime.cpp Changeset: c3a089b16cc9 Author: igerasim Date: 2018-07-19 13:41 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c3a089b16cc9 8207753: Handle to process snapshot is leaked if Process32First() fails Reviewed-by: rriggs ! src/java.base/windows/native/libjava/ProcessHandleImpl_win.c Changeset: e443c637b238 Author: vromero Date: 2018-07-19 15:13 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e443c637b238 8206874: Evaluate LoadClassFromJava6CreatedJarTest.java after dropping -source 6 Reviewed-by: darcy - test/langtools/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java Changeset: 6c62929bd870 Author: dtitov Date: 2018-07-19 16:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6c62929bd870 8204695: [Graal] vmTestbase/nsk/jdi/ClassPrepareRequest/addSourceNameFilter/addSourceNameFilter002/addSourceNameFilter002.java fails Reviewed-by: sspitsyn, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassPrepareRequest/addSourceNameFilter/addSourceNameFilter002/addSourceNameFilter002.java Changeset: bee24106cfc0 Author: ctornqvi Date: 2018-07-20 09:15 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bee24106cfc0 8207855: Make applications/jcstress invoke tests in batches Reviewed-by: kvn, iignatyev ! test/hotspot/jtreg/TEST.groups ! test/hotspot/jtreg/applications/jcstress/TestGenerator.java + test/hotspot/jtreg/applications/jcstress/accessAtomic.java + test/hotspot/jtreg/applications/jcstress/acqrel.java - test/hotspot/jtreg/applications/jcstress/acqrel/Test.java + test/hotspot/jtreg/applications/jcstress/atomicity.java - test/hotspot/jtreg/applications/jcstress/atomicity/Test.java + test/hotspot/jtreg/applications/jcstress/atomics.java + test/hotspot/jtreg/applications/jcstress/causality.java + test/hotspot/jtreg/applications/jcstress/coherence.java + test/hotspot/jtreg/applications/jcstress/copy.java - test/hotspot/jtreg/applications/jcstress/copy/Test.java + test/hotspot/jtreg/applications/jcstress/countdownlatch.java + test/hotspot/jtreg/applications/jcstress/defaultValues.java + test/hotspot/jtreg/applications/jcstress/executors.java + test/hotspot/jtreg/applications/jcstress/fences.java - test/hotspot/jtreg/applications/jcstress/fences/Test.java + test/hotspot/jtreg/applications/jcstress/future.java + test/hotspot/jtreg/applications/jcstress/init.java + test/hotspot/jtreg/applications/jcstress/initClass.java + test/hotspot/jtreg/applications/jcstress/initLen.java + test/hotspot/jtreg/applications/jcstress/interrupt.java + test/hotspot/jtreg/applications/jcstress/locks.java + test/hotspot/jtreg/applications/jcstress/memeffects.java - test/hotspot/jtreg/applications/jcstress/memeffects/Test.java - test/hotspot/jtreg/applications/jcstress/other/Test.java + test/hotspot/jtreg/applications/jcstress/seqcst.java - test/hotspot/jtreg/applications/jcstress/seqcst.sync/Test.java - test/hotspot/jtreg/applications/jcstress/seqcst.volatiles/Test.java + test/hotspot/jtreg/applications/jcstress/singletons.java + test/hotspot/jtreg/applications/jcstress/strings.java + test/hotspot/jtreg/applications/jcstress/tearing.java + test/hotspot/jtreg/applications/jcstress/unsafe.java + test/hotspot/jtreg/applications/jcstress/varhandles.java + test/hotspot/jtreg/applications/jcstress/volatiles.java Changeset: 65556ae796ad Author: jcbeyler Date: 2018-07-19 18:21 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/65556ae796ad 8207765: HeapMonitorStatIntervalTest.java fails with ZGC Summary: Add a calculation of array sizes before test to satisfy ZGC support Reviewed-by: amenkov, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatIntervalTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c Changeset: 0d02393d9115 Author: darcy Date: 2018-07-18 00:16 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0d02393d9115 8193214: Incorrect annotations.without.processors warnings with JDK 9 Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/langtools/tools/javac/processing/warnings/LintProcessing/TestAnnotationsWithoutProcessors.java + test/langtools/tools/javac/processing/warnings/LintProcessing/empty.out Changeset: ae39ec0b0502 Author: darcy Date: 2018-07-18 00:23 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ae39ec0b0502 8193462: Fix Filer handling of package-info initial elements Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! test/langtools/tools/javac/processing/filer/TestPackageInfo.java Changeset: 416a76fe8067 Author: kvn Date: 2018-07-20 11:55 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/416a76fe8067 8206075: On x86, assert on unbound assembler Labels used as branch targets Reviewed-by: kvn, mdoerr, phh Contributed-by: xxinliu at amazon.com ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/share/asm/assembler.hpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp Changeset: 516acf6956a2 Author: coleenp Date: 2018-07-20 14:52 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/516acf6956a2 8207359: Make SymbolTable increment_refcount disallow zero Summary: Use cmpxchg for non permanent symbol refcounting, and pack refcount and length into an int. Reviewed-by: gziemski, kbarrett, iklam ! make/hotspot/src/native/dtrace/generateJvmOffsets.cpp ! src/hotspot/os/solaris/dtrace/jhelper.d ! src/hotspot/share/classfile/compactHashtable.inline.hpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/java.base/solaris/native/libjvm_db/libjvm_db.c ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Symbol.java ! test/hotspot/gtest/classfile/test_symbolTable.cpp + test/hotspot/gtest/threadHelper.inline.hpp ! test/hotspot/gtest/utilities/test_concurrentHashtable.cpp ! test/hotspot/gtest/utilities/test_globalCounter.cpp - test/hotspot/gtest/utilities/utilitiesHelper.inline.hpp Changeset: b7eb9cc56277 Author: iklam Date: 2018-07-20 12:19 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b7eb9cc56277 8203382: Rename SystemDictionary::initialize_wk_klass to resolve_wk_klass Reviewed-by: jiangli ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/jvmci/jvmciRuntime.cpp Changeset: 01b8120f867a Author: darcy Date: 2018-07-20 14:46 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/01b8120f867a 8208060: Additional corrections of serial-related declarations Reviewed-by: rriggs, lancea ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.management/share/classes/java/lang/management/MemoryType.java ! src/java.rmi/share/classes/java/rmi/activation/ActivationID.java ! src/java.rmi/share/classes/java/rmi/server/RemoteObject.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/java.sql/share/classes/java/sql/BatchUpdateException.java Changeset: b0fcf59be391 Author: vromero Date: 2018-07-20 14:48 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b0fcf59be391 8205493: OptionSmokeTest.java uses hard-coded release values Reviewed-by: darcy ! test/langtools/tools/javac/options/smokeTests/OptionSmokeTest.java Changeset: bd2e3c3b4547 Author: tschatzl Date: 2018-07-23 17:32 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bd2e3c3b4547 8207953: Remove dead code in G1CopyingKeepAliveClosure Reviewed-by: kbarrett ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp Changeset: 1edc62f9ba3a Author: tonyp Date: 2018-07-23 11:38 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1edc62f9ba3a 8207849: Allow the addition of more number to the Java version string Reviewed-by: erikj ! make/autoconf/jdk-version.m4 ! make/autoconf/spec.gmk.in ! make/autoconf/version-numbers Changeset: e5cf42428787 Author: dcubed Date: 2018-07-23 14:41 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e5cf42428787 8208092: ProblemList serviceability/sa/ClhsdbCDSCore.java Reviewed-by: sspitsyn ! test/hotspot/jtreg/ProblemList.txt Changeset: 22e1b5900d90 Author: kvn Date: 2018-07-23 18:29 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/22e1b5900d90 8207262: enable applications/ctw/modules/java_desktop_2.java test again Reviewed-by: iignatyev ! test/hotspot/jtreg/ProblemList.txt Changeset: e55d46250431 Author: igerasim Date: 2018-07-23 22:07 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e55d46250431 8207314: Unnecessary reallocation when constructing WeakHashMap from a large Map Reviewed-by: martin ! src/java.base/share/classes/java/util/WeakHashMap.java Changeset: 630b5e06a947 Author: mbaesken Date: 2018-07-19 11:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/630b5e06a947 8207395: jar has issues with UNC-path arguments for the jar -C parameter [windows] Reviewed-by: goetz, sherman ! src/jdk.jartool/share/classes/sun/tools/jar/Main.java Changeset: 0ce279d8c9cd Author: mbaesken Date: 2018-07-24 09:27 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0ce279d8c9cd 8207941: javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails on machines without Arial font [testbug] Reviewed-by: goetz, psadhukhan ! test/jdk/javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java Changeset: fb4a7b894fac Author: jjg Date: 2018-07-24 11:37 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fb4a7b894fac 8207214: Broken links in JDK API serialized-form page Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java + test/langtools/jdk/javadoc/doclet/testSerializedFormWithSee/TestSerializedFormWithSee.java Changeset: 96fae3a62612 Author: shurailine Date: 2018-07-24 08:58 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/96fae3a62612 8208157: requires.VMProps throws NPE for missing properties in "release" file Reviewed-by: iignatyev, lancea ! test/jtreg-ext/requires/VMProps.java Changeset: 499b873761d8 Author: xyin Date: 2018-07-25 11:03 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/499b873761d8 8198882: Add 10 JNDI tests to com/sun/jndi/dns/AttributeTests/ Reviewed-by: vtewari, rriggs ! test/jdk/com/sun/jndi/dns/AttributeTests/GetAny.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrs.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrs.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsBase.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsEmptyAttrIds.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsEmptyAttrIds.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsNonExistentAttrIds.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsNonExistentAttrIds.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsNotFound.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsNotFound.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsNullAttrIds.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsNullAttrIds.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsSomeAttrIds.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetAttrsSomeAttrIds.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetNonstandard.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetNonstandard.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetNumericIRRs.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetNumericIRRs.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetNumericRRs.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetNumericRRs.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetRRs.dns + test/jdk/com/sun/jndi/dns/AttributeTests/GetRRs.java + test/jdk/com/sun/jndi/dns/AttributeTests/GetRRsBase.java ! test/jdk/com/sun/jndi/dns/lib/DNSServer.java + test/jdk/com/sun/jndi/dns/lib/DNSTestBase.java ! test/jdk/com/sun/jndi/dns/lib/DNSTestUtils.java ! test/jdk/com/sun/jndi/dns/lib/DNSTracer.java + test/jdk/com/sun/jndi/dns/lib/Server.java + test/jdk/com/sun/jndi/dns/lib/TestBase.java Changeset: f4f5f961a81f Author: dcubed Date: 2018-07-25 12:32 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f4f5f961a81f 8208189: ProblemList compiler/graalunit/JttThreadsTest.java Reviewed-by: darcy ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: 766df90d6fb5 Author: darcy Date: 2018-07-25 12:32 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/766df90d6fb5 8190886: package-info handling in RoundEnvironment.getElementsAnnotatedWith Reviewed-by: vromero, jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java - test/langtools/tools/javac/processing/environment/round/AnnotatedElementInfo.java ! test/langtools/tools/javac/processing/environment/round/BuriedAnnotations.java ! test/langtools/tools/javac/processing/environment/round/C2.java ! test/langtools/tools/javac/processing/environment/round/ErroneousAnnotations.java ! test/langtools/tools/javac/processing/environment/round/ErroneousAnnotations.out ! test/langtools/tools/javac/processing/environment/round/Foo.java ! test/langtools/tools/javac/processing/environment/round/ParameterAnnotations.java ! test/langtools/tools/javac/processing/environment/round/Part1.java ! test/langtools/tools/javac/processing/environment/round/SurfaceAnnotations.java ! test/langtools/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java ! test/langtools/tools/javac/processing/environment/round/TypeParameterAnnotations.java + test/langtools/tools/javac/processing/environment/round/annot/AnnotatedElementInfo.java + test/langtools/tools/javac/processing/environment/round/annot/MarkerAnnot.java + test/langtools/tools/javac/processing/environment/round/mod/module-info.java + test/langtools/tools/javac/processing/environment/round/mod/quux/Quux.java + test/langtools/tools/javac/processing/environment/round/mod/quux/package-info.java + test/langtools/tools/javac/processing/environment/round/pkg/Foo.java + test/langtools/tools/javac/processing/environment/round/pkg/package-info.java Changeset: 08d99d33e0aa Author: jcbeyler Date: 2018-07-25 10:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/08d99d33e0aa 8207765: HeapMonitorTest.java intermittent failure Summary: Lower the interval rate and check GC objects too Reviewed-by: dcubed, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorTest.java Changeset: 6d9f7c323266 Author: dcubed Date: 2018-07-25 15:38 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6d9f7c323266 8208205: ProblemList tests that fail due to 'Error attaching to process: Can't create thread_db agent!' Reviewed-by: cjplummer ! test/hotspot/jtreg/ProblemList.txt Changeset: 3a6be93c9660 Author: rkennke Date: 2018-07-25 21:47 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3a6be93c9660 8204970: Remaing object comparisons need to use oopDesc::equals() Reviewed-by: eosterlund, zgu ! src/hotspot/share/ci/ciObjectFactory.hpp ! src/hotspot/share/classfile/modules.cpp Changeset: 979e4708da65 Author: darcy Date: 2018-07-25 12:54 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/979e4708da65 8208201: Update SourceVersion.RELEASE_11 docs to mention var for lambda param Reviewed-by: jjg ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java Changeset: 9f200b5bd189 Author: dcubed Date: 2018-07-25 17:22 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9f200b5bd189 8208226: ProblemList com/sun/jdi/BasicJDWPConnectionTest.java Reviewed-by: sspitsyn ! test/jdk/ProblemList.txt Changeset: 628333cfee7a Author: darcy Date: 2018-07-25 17:22 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/628333cfee7a 8208200: Add missing periods to sentences in RoundEnvironment specs Reviewed-by: jjg ! src/java.compiler/share/classes/javax/annotation/processing/RoundEnvironment.java Changeset: 21626dccd2ca Author: jjg Date: 2018-07-25 17:26 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/21626dccd2ca 8208227: tools/jdeps/DotFileTest.java fails on Win-X64 Reviewed-by: darcy ! test/langtools/tools/jdeps/DotFileTest.java Changeset: 59b0d8afc831 Author: dbuck Date: 2018-07-26 10:56 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/59b0d8afc831 8208183: update HSDIS plugin license to UPL Reviewed-by: simonis, adinn, jrose ! src/utils/hsdis/Makefile ! src/utils/hsdis/README ! src/utils/hsdis/hsdis-demo.c ! src/utils/hsdis/hsdis.c ! src/utils/hsdis/hsdis.h Changeset: 220c9188db4f Author: ysuenaga Date: 2018-07-27 00:54 +0900 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/220c9188db4f 8205992: jhsdb cannot attach to Java processes running in Docker containers Reviewed-by: cjplummer, jgeorge ! src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.c ! src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h ! src/jdk.hotspot.agent/linux/native/libsaproc/ps_proc.c ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/LinuxThread.java Changeset: b257e2c3bc8d Author: prr Date: 2018-07-26 09:30 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b257e2c3bc8d Added tag jdk-12+4 for changeset 499b873761d8 ! .hgtags Changeset: 7cfc6c381cfa Author: bulasevich Date: 2018-07-19 21:46 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7cfc6c381cfa 8207584: ARM32: ShouldNotReachHere assertion on Test8168712 jtreg test Reviewed-by: shade ! src/hotspot/cpu/arm/sharedRuntime_arm.cpp Changeset: 14b870bda24f Author: kvn Date: 2018-07-19 13:41 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/14b870bda24f 8207069: [AOT] we should check that VM uses the same GC as one used for AOT library generation. Reviewed-by: twisti, dnsimon, never ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/aot/aotCodeHeap.hpp ! src/hotspot/share/gc/shared/gcConfig.cpp ! src/hotspot/share/gc/shared/gcConfig.hpp ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/BinaryContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Main.java Changeset: fc24da4898f1 Author: erikj Date: 2018-07-19 14:25 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fc24da4898f1 8207243: Fix translation filtering to also support zh_HK and zh_TW Reviewed-by: tbell ! make/CompileJavaModules.gmk ! make/conf/jib-profiles.js ! test/jdk/build/translations/VerifyTranslations.java ! test/jdk/java/util/logging/LocalizedLevelName.java Changeset: 0d2e45b25c3d Author: zgu Date: 2018-07-11 13:55 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0d2e45b25c3d 8207056: Epsilon GC to support object pinning Summary: Epsilon GC to use object pinning to avoid expensive GCLocker Reviewed-by: shade, rkennke ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp Changeset: 4630bb315ec0 Author: mli Date: 2018-07-20 08:40 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4630bb315ec0 8207244: java/nio/channels/Selector/SelectWithConsumer.java testInterruptDuringSelect() fails intermittently Reviewed-by: alanb ! test/jdk/java/nio/channels/Selector/SelectWithConsumer.java Changeset: e750c1a054fa Author: jcbeyler Date: 2018-07-19 18:21 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e750c1a054fa 8207765: HeapMonitorStatIntervalTest.java fails with ZGC Summary: Add a calculation of array sizes before test to satisfy ZGC support Reviewed-by: amenkov, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatIntervalTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c Changeset: 6ed2290ba410 Author: mli Date: 2018-07-20 15:24 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6ed2290ba410 8207833: java/nio/channels/Selector/SelectWithConsumer.java testCancel() fails intermittently Reviewed-by: alanb ! test/jdk/java/nio/channels/Selector/SelectWithConsumer.java Changeset: a138b5fe288d Author: rraghavan Date: 2018-07-20 01:23 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a138b5fe288d 8203504: [Graal] org.graalvm.compiler.debug.test.DebugContextTest fails with java.util.ServiceConfigurationError Summary: Added required uses statement Reviewed-by: dnsimon, kvn ! src/jdk.internal.vm.compiler/share/classes/module-info.java Changeset: 24c4780f69a5 Author: goetz Date: 2018-07-20 09:33 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/24c4780f69a5 8207766: [testbug] Adapt tests for Aix. Reviewed-by: clanger, mbaesken ! test/jdk/ProblemList.txt ! test/jdk/com/sun/jdi/EvalArraysAsList.sh ! test/jdk/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh ! test/jdk/sun/security/pkcs11/PKCS11Test.java ! test/jdk/sun/security/pkcs11/Secmod/TestNssDbSqlite.java ! test/jdk/tools/launcher/SourceMode.java Changeset: 67736b4846a0 Author: goetz Date: 2018-07-20 09:46 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/67736b4846a0 8207830: [aix] disable jfr in build and tests Reviewed-by: kvn, erikj ! make/autoconf/hotspot.m4 ! src/hotspot/share/prims/whitebox.cpp ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/runtime/appcds/CDSandJFR.java ! test/hotspot/jtreg/runtime/appcds/TestWithProfiler.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/FlagCombo.java ! test/jdk/TEST.ROOT ! test/jdk/jdk/jfr/api/consumer/TestFieldAccess.java ! test/jdk/jdk/jfr/api/consumer/TestGetStackTrace.java ! test/jdk/jdk/jfr/api/consumer/TestHiddenMethod.java ! test/jdk/jdk/jfr/api/consumer/TestMethodGetModifiers.java ! test/jdk/jdk/jfr/api/consumer/TestReadTwice.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedClassLoader.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedEvent.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedEventGetThread.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedEventGetThreadOther.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedFrame.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedFullStackTrace.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedInstantEventTimestamp.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedMethodDescriptor.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedObject.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedThreadGroupParent.java ! test/jdk/jdk/jfr/api/consumer/TestRecordingFile.java ! test/jdk/jdk/jfr/api/consumer/TestRecordingFileReadEventEof.java ! test/jdk/jdk/jfr/api/consumer/TestRecordingInternals.java ! test/jdk/jdk/jfr/api/consumer/TestSingleRecordedEvent.java ! test/jdk/jdk/jfr/api/consumer/TestToString.java ! test/jdk/jdk/jfr/api/consumer/TestValueDescriptorRecorded.java ! test/jdk/jdk/jfr/api/event/TestAbstractEvent.java ! test/jdk/jdk/jfr/api/event/TestBeginEnd.java ! test/jdk/jdk/jfr/api/event/TestClinitRegistration.java ! test/jdk/jdk/jfr/api/event/TestClonedEvent.java ! test/jdk/jdk/jfr/api/event/TestEnableDisable.java ! test/jdk/jdk/jfr/api/event/TestEventFactory.java ! test/jdk/jdk/jfr/api/event/TestEventFactoryRegisterTwice.java ! test/jdk/jdk/jfr/api/event/TestEventFactoryRegistration.java ! test/jdk/jdk/jfr/api/event/TestExtends.java ! test/jdk/jdk/jfr/api/event/TestGetDuration.java ! test/jdk/jdk/jfr/api/event/TestIsEnabled.java ! test/jdk/jdk/jfr/api/event/TestIsEnabledMultiple.java ! test/jdk/jdk/jfr/api/event/TestOwnCommit.java ! test/jdk/jdk/jfr/api/event/TestShouldCommit.java ! test/jdk/jdk/jfr/api/event/TestStaticEnable.java ! test/jdk/jdk/jfr/api/event/dynamic/TestDynamicAnnotations.java ! test/jdk/jdk/jfr/api/event/dynamic/TestEventFactory.java ! test/jdk/jdk/jfr/api/flightrecorder/TestAddListenerTwice.java ! test/jdk/jdk/jfr/api/flightrecorder/TestAddPeriodicEvent.java ! test/jdk/jdk/jfr/api/flightrecorder/TestFlightRecorderListenerRecorderInitialized.java ! test/jdk/jdk/jfr/api/flightrecorder/TestGetEventTypes.java ! test/jdk/jdk/jfr/api/flightrecorder/TestGetPlatformRecorder.java ! test/jdk/jdk/jfr/api/flightrecorder/TestGetRecordings.java ! test/jdk/jdk/jfr/api/flightrecorder/TestGetSettings.java ! test/jdk/jdk/jfr/api/flightrecorder/TestIsAvailable.java ! test/jdk/jdk/jfr/api/flightrecorder/TestIsInitialized.java ! test/jdk/jdk/jfr/api/flightrecorder/TestListener.java ! test/jdk/jdk/jfr/api/flightrecorder/TestListenerNull.java ! test/jdk/jdk/jfr/api/flightrecorder/TestPeriodicEventsSameHook.java ! test/jdk/jdk/jfr/api/flightrecorder/TestRecorderInitializationCallback.java ! test/jdk/jdk/jfr/api/flightrecorder/TestRegisterUnregisterEvent.java ! test/jdk/jdk/jfr/api/flightrecorder/TestSettingsControl.java ! test/jdk/jdk/jfr/api/flightrecorder/TestSnapshot.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestCategory.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestContentType.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestDescription.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestDynamicAnnotation.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestEnabled.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestExperimental.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestFieldAnnotations.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestHasValue.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestInheritedAnnotations.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestLabel.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestMetadata.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestName.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestPeriod.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestRegistered.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestRegisteredFalseAndRunning.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestRelational.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestSimpleMetadataEvent.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestStackTrace.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestThreshold.java ! test/jdk/jdk/jfr/api/metadata/annotations/TestTypesIdentical.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetAnnotation.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetAnnotationElements.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetAnnotations.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetCategory.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetDefaultValues.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetDescription.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetEventType.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetField.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetFields.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestGetSettings.java ! test/jdk/jdk/jfr/api/metadata/eventtype/TestUnloadingEventClass.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestDefaultValue.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestGetAnnotation.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestGetAnnotationElement.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestGetContentType.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestGetDescription.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestGetLabel.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestGetName.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestGetTypeId.java ! test/jdk/jdk/jfr/api/metadata/settingdescriptor/TestGetTypeName.java ! test/jdk/jdk/jfr/api/metadata/valuedescriptor/TestClasses.java ! test/jdk/jdk/jfr/api/metadata/valuedescriptor/TestConstructor.java ! test/jdk/jdk/jfr/api/metadata/valuedescriptor/TestGetAnnotations.java ! test/jdk/jdk/jfr/api/metadata/valuedescriptor/TestGetFields.java ! test/jdk/jdk/jfr/api/metadata/valuedescriptor/TestIsArray.java ! test/jdk/jdk/jfr/api/metadata/valuedescriptor/TestSimpleTypes.java ! test/jdk/jdk/jfr/api/metadata/valuedescriptor/TestValueDescriptorContentType.java ! test/jdk/jdk/jfr/api/recorder/TestRecorderInitialized.java ! test/jdk/jdk/jfr/api/recorder/TestRecorderListener.java ! test/jdk/jdk/jfr/api/recorder/TestStartStopRecording.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestFileExist.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestFileReadOnly.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestInvalid.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestLongPath.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestMultiple.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestReadOnly.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestState.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestToDiskFalse.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestToDiskTrue.java ! test/jdk/jdk/jfr/api/recording/destination/TestDestWithDuration.java ! test/jdk/jdk/jfr/api/recording/dump/TestDump.java ! test/jdk/jdk/jfr/api/recording/dump/TestDumpInvalid.java ! test/jdk/jdk/jfr/api/recording/dump/TestDumpLongPath.java ! test/jdk/jdk/jfr/api/recording/dump/TestDumpMultiple.java ! test/jdk/jdk/jfr/api/recording/dump/TestDumpReadOnly.java ! test/jdk/jdk/jfr/api/recording/dump/TestDumpState.java ! test/jdk/jdk/jfr/api/recording/event/TestChunkPeriod.java ! test/jdk/jdk/jfr/api/recording/event/TestEnableClass.java ! test/jdk/jdk/jfr/api/recording/event/TestEnableName.java ! test/jdk/jdk/jfr/api/recording/event/TestEventTime.java ! test/jdk/jdk/jfr/api/recording/event/TestLoadEventAfterStart.java ! test/jdk/jdk/jfr/api/recording/event/TestPeriod.java ! test/jdk/jdk/jfr/api/recording/event/TestReEnableClass.java ! test/jdk/jdk/jfr/api/recording/event/TestReEnableMultiple.java ! test/jdk/jdk/jfr/api/recording/event/TestReEnableName.java ! test/jdk/jdk/jfr/api/recording/event/TestRecordingEnableDisable.java ! test/jdk/jdk/jfr/api/recording/event/TestThreshold.java ! test/jdk/jdk/jfr/api/recording/misc/TestGetId.java ! test/jdk/jdk/jfr/api/recording/misc/TestGetSize.java ! test/jdk/jdk/jfr/api/recording/misc/TestGetSizeToMem.java ! test/jdk/jdk/jfr/api/recording/misc/TestGetStream.java ! test/jdk/jdk/jfr/api/recording/misc/TestRecordingBase.java ! test/jdk/jdk/jfr/api/recording/misc/TestRecordingCopy.java ! test/jdk/jdk/jfr/api/recording/options/TestDuration.java ! test/jdk/jdk/jfr/api/recording/options/TestName.java ! test/jdk/jdk/jfr/api/recording/settings/TestConfigurationGetContents.java ! test/jdk/jdk/jfr/api/recording/settings/TestCreateConfigFromPath.java ! test/jdk/jdk/jfr/api/recording/settings/TestCreateConfigFromReader.java ! test/jdk/jdk/jfr/api/recording/settings/TestGetConfigurations.java ! test/jdk/jdk/jfr/api/recording/settings/TestSettingsAvailability.java ! test/jdk/jdk/jfr/api/recording/state/TestOptionState.java ! test/jdk/jdk/jfr/api/recording/state/TestState.java ! test/jdk/jdk/jfr/api/recording/state/TestStateDuration.java ! test/jdk/jdk/jfr/api/recording/state/TestStateIdenticalListeners.java ! test/jdk/jdk/jfr/api/recording/state/TestStateInvalid.java ! test/jdk/jdk/jfr/api/recording/state/TestStateMultiple.java ! test/jdk/jdk/jfr/api/recording/state/TestStateScheduleStart.java ! test/jdk/jdk/jfr/api/recording/time/TestTime.java ! test/jdk/jdk/jfr/api/recording/time/TestTimeDuration.java ! test/jdk/jdk/jfr/api/recording/time/TestTimeMultiple.java ! test/jdk/jdk/jfr/api/recording/time/TestTimeScheduleStart.java ! test/jdk/jdk/jfr/api/settings/TestFilterEvents.java ! test/jdk/jdk/jfr/cmd/TestHelp.java ! test/jdk/jdk/jfr/cmd/TestPrint.java ! test/jdk/jdk/jfr/cmd/TestPrintDefault.java ! test/jdk/jdk/jfr/cmd/TestPrintJSON.java ! test/jdk/jdk/jfr/cmd/TestPrintXML.java ! test/jdk/jdk/jfr/cmd/TestReconstruct.java ! test/jdk/jdk/jfr/cmd/TestSplit.java ! test/jdk/jdk/jfr/cmd/TestSummary.java ! test/jdk/jdk/jfr/event/compiler/TestAllocInNewTLAB.java ! test/jdk/jdk/jfr/event/compiler/TestAllocOutsideTLAB.java ! test/jdk/jdk/jfr/event/compiler/TestCodeCacheConfig.java ! test/jdk/jdk/jfr/event/compiler/TestCodeCacheFull.java ! test/jdk/jdk/jfr/event/compiler/TestCodeCacheStats.java ! test/jdk/jdk/jfr/event/compiler/TestCodeSweeper.java ! test/jdk/jdk/jfr/event/compiler/TestCodeSweeperConfig.java ! test/jdk/jdk/jfr/event/compiler/TestCodeSweeperStats.java ! test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java ! test/jdk/jdk/jfr/event/compiler/TestCompilerConfig.java ! test/jdk/jdk/jfr/event/compiler/TestCompilerInlining.java ! test/jdk/jdk/jfr/event/compiler/TestCompilerPhase.java ! test/jdk/jdk/jfr/event/compiler/TestCompilerStats.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSConcurrent.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithG1ConcurrentMark.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithG1FullCollection.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithPSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithParallelOld.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithSerial.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSConcurrent.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithG1ConcurrentMark.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithG1FullCollection.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithPSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithParNew.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithParallelOld.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithSerial.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCGarbageCollectionEvent.java ! test/jdk/jdk/jfr/event/gc/collection/TestGCWithFasttime.java ! test/jdk/jdk/jfr/event/gc/collection/TestYoungGarbageCollectionEventWithDefNew.java ! test/jdk/jdk/jfr/event/gc/collection/TestYoungGarbageCollectionEventWithG1New.java ! test/jdk/jdk/jfr/event/gc/collection/TestYoungGarbageCollectionEventWithParNew.java ! test/jdk/jdk/jfr/event/gc/collection/TestYoungGarbageCollectionEventWithParallelScavenge.java ! test/jdk/jdk/jfr/event/gc/configuration/TestGCConfigurationEvent.java ! test/jdk/jdk/jfr/event/gc/configuration/TestGCConfigurationEventWithDefaultPauseTarget.java ! test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWith32BitOops.sh ! test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithHeapBasedOops.sh ! test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithZeroBasedOops.sh ! test/jdk/jdk/jfr/event/gc/configuration/TestGCSurvivorConfigurationEvent.java ! test/jdk/jdk/jfr/event/gc/configuration/TestGCTLABConfigurationEvent.java ! test/jdk/jdk/jfr/event/gc/configuration/TestGCYoungGenerationConfigurationEventWithMinAndMaxSize.java ! test/jdk/jdk/jfr/event/gc/configuration/TestGCYoungGenerationConfigurationEventWithNewRatio.java ! test/jdk/jdk/jfr/event/gc/detailed/TestCMSConcurrentModeFailureEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestEvacuationFailedEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestEvacuationInfoEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestG1AIHOPEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestG1ConcurrentModeFailureEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestG1EvacMemoryStatsEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestG1HeapRegionTypeChangeEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestG1IHOPEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestG1MMUEvent.java ! test/jdk/jdk/jfr/event/gc/detailed/TestPromotionEventWithG1.java ! test/jdk/jdk/jfr/event/gc/detailed/TestPromotionEventWithParallelScavenge.java ! test/jdk/jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithDefNew.java ! test/jdk/jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParNew.java ! test/jdk/jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithCMS.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithDefNew.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithG1.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithParNew.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithParallel.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithCMS.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithDefNew.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithG1.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithParNew.java ! test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithParallel.java ! test/jdk/jdk/jfr/event/gc/detailed/TestTenuringDistributionEvent.java ! test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryCommittedSize.java ! test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventConcurrentCMS.java ! test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventDefNewSerial.java ! test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventG1.java ! test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventPSParOld.java ! test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventPSSerial.java ! test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventParNewCMS.java ! test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSConcurrent.java ! test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithG1ConcurrentMark.java ! test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithG1FullCollection.java ! test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithPSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithParallelOld.java ! test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithSerial.java ! test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountEvent.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSConcurrent.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithDefNew.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithG1ConcurrentMark.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithG1FullCollection.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithG1New.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithPSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithParallelOld.java ! test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithParallelScavenge.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestConcMarkSweepAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestDefNewAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestG1HumongousAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestG1OldAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestG1YoungAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestMarkSweepCompactAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceConcMarkSweepGCAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceG1GCAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceParallelGCAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceSerialGCAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestParNewAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/gc/stacktrace/TestParallelScavengeAllocationPendingStackTrace.java ! test/jdk/jdk/jfr/event/io/EvilInstrument.java ! test/jdk/jdk/jfr/event/io/TestDisabledEvents.java ! test/jdk/jdk/jfr/event/io/TestFileChannelEvents.java ! test/jdk/jdk/jfr/event/io/TestFileReadOnly.java ! test/jdk/jdk/jfr/event/io/TestFileStreamEvents.java ! test/jdk/jdk/jfr/event/io/TestInstrumentation.java ! test/jdk/jdk/jfr/event/io/TestRandomAccessFileEvents.java ! test/jdk/jdk/jfr/event/io/TestRandomAccessFileThread.java ! test/jdk/jdk/jfr/event/io/TestSocketChannelEvents.java ! test/jdk/jdk/jfr/event/io/TestSocketEvents.java ! test/jdk/jdk/jfr/event/metadata/TestDefaultConfigurations.java ! test/jdk/jdk/jfr/event/metadata/TestEventMetadata.java ! test/jdk/jdk/jfr/event/oldobject/TestAllocationTime.java ! test/jdk/jdk/jfr/event/oldobject/TestArrayInformation.java ! test/jdk/jdk/jfr/event/oldobject/TestCMS.java ! test/jdk/jdk/jfr/event/oldobject/TestCircularReference.java ! test/jdk/jdk/jfr/event/oldobject/TestClassLoaderLeak.java ! test/jdk/jdk/jfr/event/oldobject/TestFieldInformation.java ! test/jdk/jdk/jfr/event/oldobject/TestG1.java ! test/jdk/jdk/jfr/event/oldobject/TestHeapDeep.java ! test/jdk/jdk/jfr/event/oldobject/TestHeapShallow.java ! test/jdk/jdk/jfr/event/oldobject/TestLargeRootSet.java ! test/jdk/jdk/jfr/event/oldobject/TestLastKnownHeapUsage.java ! test/jdk/jdk/jfr/event/oldobject/TestListenerLeak.java ! test/jdk/jdk/jfr/event/oldobject/TestMetadataRetention.java ! test/jdk/jdk/jfr/event/oldobject/TestObjectDescription.java ! test/jdk/jdk/jfr/event/oldobject/TestParallel.java ! test/jdk/jdk/jfr/event/oldobject/TestParallelOld.java ! test/jdk/jdk/jfr/event/oldobject/TestReferenceChainLimit.java ! test/jdk/jdk/jfr/event/oldobject/TestSanityDefault.java ! test/jdk/jdk/jfr/event/oldobject/TestSerial.java ! test/jdk/jdk/jfr/event/oldobject/TestThreadLocalLeak.java ! test/jdk/jdk/jfr/event/os/TestCPUInformation.java ! test/jdk/jdk/jfr/event/os/TestCPULoad.java ! test/jdk/jdk/jfr/event/os/TestCPUTimeStampCounter.java ! test/jdk/jdk/jfr/event/os/TestInitialEnvironmentVariable.sh ! test/jdk/jdk/jfr/event/os/TestOSInfo.java ! test/jdk/jdk/jfr/event/os/TestPhysicalMemoryEvent.java ! test/jdk/jdk/jfr/event/os/TestSystemProcess.java ! test/jdk/jdk/jfr/event/os/TestThreadContextSwitches.java ! test/jdk/jdk/jfr/event/profiling/TestFullStackTrace.java ! test/jdk/jdk/jfr/event/runtime/TestActiveRecordingEvent.java ! test/jdk/jdk/jfr/event/runtime/TestActiveSettingEvent.java ! test/jdk/jdk/jfr/event/runtime/TestBiasedLockRevocationEvents.java ! test/jdk/jdk/jfr/event/runtime/TestClassDefineEvent.java ! test/jdk/jdk/jfr/event/runtime/TestClassLoadEvent.java ! test/jdk/jdk/jfr/event/runtime/TestClassLoaderStatsEvent.java ! test/jdk/jdk/jfr/event/runtime/TestClassLoadingStatisticsEvent.java ! test/jdk/jdk/jfr/event/runtime/TestClassUnloadEvent.java ! test/jdk/jdk/jfr/event/runtime/TestExceptionEvents.java ! test/jdk/jdk/jfr/event/runtime/TestExceptionSubclass.java ! test/jdk/jdk/jfr/event/runtime/TestJavaBlockedEvent.java ! test/jdk/jdk/jfr/event/runtime/TestJavaMonitorInflateEvent.java ! test/jdk/jdk/jfr/event/runtime/TestJavaMonitorWaitEvent.java ! test/jdk/jdk/jfr/event/runtime/TestJavaMonitorWaitTimeOut.java ! test/jdk/jdk/jfr/event/runtime/TestJavaThreadStatisticsEvent.java ! test/jdk/jdk/jfr/event/runtime/TestJavaThreadStatisticsEventBean.java ! test/jdk/jdk/jfr/event/runtime/TestModuleEvents.java ! test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java ! test/jdk/jdk/jfr/event/runtime/TestNetworkUtilizationEvent.java ! test/jdk/jdk/jfr/event/runtime/TestSafepointEvents.java ! test/jdk/jdk/jfr/event/runtime/TestSizeTFlags.java ! test/jdk/jdk/jfr/event/runtime/TestSystemPropertyEvent.java ! test/jdk/jdk/jfr/event/runtime/TestThreadAllocationEvent.java ! test/jdk/jdk/jfr/event/runtime/TestThreadCpuTimeEvent.java ! test/jdk/jdk/jfr/event/runtime/TestThreadDumpEvent.java ! test/jdk/jdk/jfr/event/runtime/TestThreadParkEvent.java ! test/jdk/jdk/jfr/event/runtime/TestThreadSleepEvent.java ! test/jdk/jdk/jfr/event/runtime/TestThreadStartEndEvents.java ! test/jdk/jdk/jfr/event/runtime/TestThrowableInstrumentation.java ! test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.sh ! test/jdk/jdk/jfr/event/runtime/TestVMOperation.java ! test/jdk/jdk/jfr/event/runtime/TestVmFlagChangedEvent.java ! test/jdk/jdk/jfr/event/sampling/TestNative.java ! test/jdk/jdk/jfr/jcmd/TestJcmdChangeLogLevel.java ! test/jdk/jdk/jfr/jcmd/TestJcmdConfigure.java ! test/jdk/jdk/jfr/jcmd/TestJcmdDump.java ! test/jdk/jdk/jfr/jcmd/TestJcmdDumpGeneratedFilename.java ! test/jdk/jdk/jfr/jcmd/TestJcmdDumpLimited.java ! test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java ! test/jdk/jdk/jfr/jcmd/TestJcmdLegacy.java ! test/jdk/jdk/jfr/jcmd/TestJcmdSaveToFile.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStartDirNotExist.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStartInvaldFile.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStartPathToGCRoots.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStartReadOnlyFile.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStartStopDefault.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStartWithOptions.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStartWithSettings.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStopInvalidFile.java ! test/jdk/jdk/jfr/jcmd/TestJcmdStopReadOnlyFile.java ! test/jdk/jdk/jfr/jmx/TestClone.java ! test/jdk/jdk/jfr/jmx/TestCloneRepeat.java ! test/jdk/jdk/jfr/jmx/TestConfigurationInfo.java ! test/jdk/jdk/jfr/jmx/TestCopyTo.java ! test/jdk/jdk/jfr/jmx/TestCopyToInvalidPath.java ! test/jdk/jdk/jfr/jmx/TestCopyToReadOnlyDir.java ! test/jdk/jdk/jfr/jmx/TestCopyToRunning.java ! test/jdk/jdk/jfr/jmx/TestEventTypes.java ! test/jdk/jdk/jfr/jmx/TestGetRecordings.java ! test/jdk/jdk/jfr/jmx/TestGetRecordingsMultiple.java ! test/jdk/jdk/jfr/jmx/TestMultipleRecordings.java ! test/jdk/jdk/jfr/jmx/TestNotificationListener.java ! test/jdk/jdk/jfr/jmx/TestPredefinedConfiguration.java ! test/jdk/jdk/jfr/jmx/TestPredefinedConfigurationInvalid.java ! test/jdk/jdk/jfr/jmx/TestRecordingOptions.java ! test/jdk/jdk/jfr/jmx/TestRecordingSettings.java ! test/jdk/jdk/jfr/jmx/TestRecordingSettingsInvalid.java ! test/jdk/jdk/jfr/jmx/TestRecordingSettingsMultiple.java ! test/jdk/jdk/jfr/jmx/TestRecordingState.java ! test/jdk/jdk/jfr/jmx/TestRecordingStateInvalid.java ! test/jdk/jdk/jfr/jmx/TestSetConfiguration.java ! test/jdk/jdk/jfr/jmx/TestSetConfigurationInvalid.java ! test/jdk/jdk/jfr/jmx/TestSnapshot.java ! test/jdk/jdk/jfr/jmx/TestStartRecording.java ! test/jdk/jdk/jfr/jmx/TestStream.java ! test/jdk/jdk/jfr/jmx/TestStreamClosed.java ! test/jdk/jdk/jfr/jmx/TestStreamMultiple.java ! test/jdk/jdk/jfr/jmx/TestWrongId.java ! test/jdk/jdk/jfr/jmx/info/TestConfigurationInfo.java ! test/jdk/jdk/jfr/jmx/info/TestEventTypeInfo.java ! test/jdk/jdk/jfr/jmx/info/TestRecordingInfo.java ! test/jdk/jdk/jfr/jmx/info/TestSettingDescriptorInfo.java ! test/jdk/jdk/jfr/jmx/security/TestEnoughPermission.java ! test/jdk/jdk/jfr/jmx/security/TestNoControlPermission.java ! test/jdk/jdk/jfr/jmx/security/TestNoMonitorPermission.java ! test/jdk/jdk/jfr/jmx/security/TestNotificationListenerPermission.java ! test/jdk/jdk/jfr/jvm/TestBeginAndEnd.java ! test/jdk/jdk/jfr/jvm/TestClassId.java ! test/jdk/jdk/jfr/jvm/TestCounterTime.java ! test/jdk/jdk/jfr/jvm/TestCreateNative.java ! test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java ! test/jdk/jdk/jfr/jvm/TestGetAllEventClasses.java ! test/jdk/jdk/jfr/jvm/TestGetEventWriter.java ! test/jdk/jdk/jfr/jvm/TestGetStackTraceId.java ! test/jdk/jdk/jfr/jvm/TestJFRIntrinsic.java ! test/jdk/jdk/jfr/jvm/TestJavaEvent.java ! test/jdk/jdk/jfr/jvm/TestJfrJavaBase.java ! test/jdk/jdk/jfr/jvm/TestLargeJavaEvent512k.java ! test/jdk/jdk/jfr/jvm/TestLargeJavaEvent64k.java ! test/jdk/jdk/jfr/jvm/TestLogImplementation.java ! test/jdk/jdk/jfr/jvm/TestLogOutput.java ! test/jdk/jdk/jfr/jvm/TestPid.java ! test/jdk/jdk/jfr/jvm/TestUnloadEventClassCount.java ! test/jdk/jdk/jfr/jvm/TestUnsupportedVM.java ! test/jdk/jdk/jfr/startupargs/TestBadOptionValues.java ! test/jdk/jdk/jfr/startupargs/TestDumpOnExit.java ! test/jdk/jdk/jfr/startupargs/TestMemoryOptions.java ! test/jdk/jdk/jfr/startupargs/TestMultipleStartupRecordings.java ! test/jdk/jdk/jfr/startupargs/TestOldObjectQueueSize.java ! test/jdk/jdk/jfr/startupargs/TestRepositoryPath.java ! test/jdk/jdk/jfr/startupargs/TestRepositoryPathLong.java ! test/jdk/jdk/jfr/startupargs/TestRetransform.java ! test/jdk/jdk/jfr/startupargs/TestRetransformUsingLog.java ! test/jdk/jdk/jfr/startupargs/TestStartDelay.java ! test/jdk/jdk/jfr/startupargs/TestStartDelayRunning.java ! test/jdk/jdk/jfr/startupargs/TestStartDuration.java ! test/jdk/jdk/jfr/startupargs/TestStartMaxAgeSize.java ! test/jdk/jdk/jfr/startupargs/TestStartName.java ! test/jdk/jdk/jfr/startupargs/TestStartRecording.java ! test/jtreg-ext/requires/VMProps.java ! test/lib/sun/hotspot/WhiteBox.java Changeset: 936823fcf202 Author: erikj Date: 2018-07-20 09:07 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/936823fcf202 8207365: Make man pages optional Reviewed-by: tbell ! make/Images.gmk ! make/autoconf/configure.ac ! make/autoconf/jdk-options.m4 ! make/autoconf/spec.gmk.in ! make/conf/jib-profiles.js Changeset: e429a304c97d Author: ascarpino Date: 2018-07-20 09:55 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e429a304c97d 8204196: integer cleanup Reviewed-by: xuelei ! src/java.base/share/classes/com/sun/crypto/provider/RSACipher.java ! src/java.base/share/classes/javax/crypto/Cipher.java ! src/java.base/share/classes/sun/security/provider/DSA.java ! src/java.base/share/classes/sun/security/x509/AlgorithmId.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Signature.java ! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/RSASignature.java ! src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/NativeRSASignature.java Changeset: 79926aa725f7 Author: naoto Date: 2018-07-20 10:12 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/79926aa725f7 8206886: Java does not set the default format locale correctly on mac10.13 Reviewed-by: rriggs ! src/java.base/macosx/native/libjava/java_props_macosx.c Changeset: bfcdf06f97fa Author: iignatyev Date: 2018-07-20 11:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bfcdf06f97fa 8207915: [AOT] jaotc w/ '--ignore-errors' should ignore illegal class files Reviewed-by: kvn ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Collector.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/ClassSearch.java + test/hotspot/jtreg/compiler/aot/cli/jaotc/IgnoreErrorsTest.java + test/hotspot/jtreg/compiler/aot/cli/jaotc/IllegalClass.jasm Changeset: e5c3953c5f88 Author: epavlova Date: 2018-07-20 11:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e5c3953c5f88 8206241: compiler/graalunit/PhasesCommonTest.java fails with java.lang.Error: TESTBUG: no tests found for prefix org.graalvm.compiler.phases.common.test Reviewed-by: kvn ! test/hotspot/jtreg/compiler/graalunit/common/GraalUnitTestLauncher.java Changeset: 23167d80e0f2 Author: smarks Date: 2018-07-20 14:34 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/23167d80e0f2 8206865: RMI activation tests fail with InvalidClassException Reviewed-by: darcy, alanb, mchung ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java ! test/jdk/ProblemList.txt Changeset: b65916c52e3c Author: coleenp Date: 2018-07-20 18:03 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b65916c52e3c 8203820: [TESTBUG] vmTestbase/metaspace/staticReferences/StaticReferences.java timed out Summary: Moved InMemoryJavaCompiler out of loops or reduced loops with InMemoryJavaCompiler Reviewed-by: vromero, jiangli ! test/hotspot/jtreg/vmTestbase/metaspace/staticReferences/StaticReferences.java ! test/hotspot/jtreg/vmTestbase/metaspace/stressDictionary/StressDictionary.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine.java Changeset: d5138f8da1ba Author: weijun Date: 2018-07-21 21:46 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d5138f8da1ba 8207223: SSL Handshake failures are reported with more generic SSLException Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/Alert.java Changeset: 7efacf6d4cc6 Author: xiaofeya Date: 2018-07-23 10:02 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7efacf6d4cc6 8207952: Problem-list 3 sctp tests Reviewed-by: chegar ! test/jdk/ProblemList.txt Changeset: dd1aa4229fd4 Author: jcbeyler Date: 2018-07-22 20:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dd1aa4229fd4 8207252: C1 still does eden allocations when TLAB is enabled Summary: Only do eden allocations when TLAB is disabled Reviewed-by: kbarrett, jrose, tschatzl, iveresov Contributed-by: jcbeyler at google.com ! src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp ! src/hotspot/cpu/arm/c1_Runtime1_arm.cpp ! src/hotspot/cpu/sparc/c1_Runtime1_sparc.cpp ! src/hotspot/cpu/x86/c1_Runtime1_x86.cpp Changeset: 50eb2c0f252b Author: gromero Date: 2018-07-19 16:56 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/50eb2c0f252b 8189922: UseNUMA memory interleaving vs membind Reviewed-by: gromero, drwhite, dholmes, tschatzl Contributed-by: Swati Sharma ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_linux.hpp Changeset: d9b22cbe3e7a Author: sdama Date: 2018-07-23 19:58 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d9b22cbe3e7a 8206445: JImageListTest.java failed in Windows Summary: Added System.gc() call to address unmapped jimage files Reviewed-by: alanb ! test/jdk/ProblemList.txt ! test/jdk/tools/jimage/JImageListTest.java Changeset: ed66516bab5b Author: dcubed Date: 2018-07-23 14:41 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ed66516bab5b 8208092: ProblemList serviceability/sa/ClhsdbCDSCore.java Reviewed-by: sspitsyn ! test/hotspot/jtreg/ProblemList.txt Changeset: 087c3ba2d138 Author: dlong Date: 2018-07-23 12:01 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/087c3ba2d138 8207383: [Graal] SelfChangedCDS.java fails with "guarantee(disp == (intptr_t)(jint)disp) failed: must be 32-bit offset" Reviewed-by: kvn ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotReturnOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Call.java Changeset: 17b7d7034e8e Author: valeriep Date: 2018-07-23 23:18 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/17b7d7034e8e 8206171: Signature#getParameters for RSASSA-PSS throws ProviderException when not initialized Summary: Changed SunRsaSign and SunMSCAPI provider to return null and updated javadoc Reviewed-by: weijun, mullan ! src/java.base/share/classes/java/security/Signature.java ! src/java.base/share/classes/java/security/SignatureSpi.java ! src/java.base/share/classes/sun/security/rsa/RSAPSSSignature.java ! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/RSASignature.java Changeset: 9c1d9d1fb543 Author: mli Date: 2018-07-24 13:55 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9c1d9d1fb543 8208111: Problem list java/nio/channels/Selector/RacyDeregister.java Reviewed-by: alanb ! test/jdk/ProblemList.txt Changeset: 1d8b1d4eae6a Author: chegar Date: 2018-07-23 11:47 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1d8b1d4eae6a 8207959: The initial value of SETTINGS_MAX_CONCURRENT_STREAMS should have no limit Reviewed-by: michaelm ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! src/java.net.http/share/classes/jdk/internal/net/http/frame/SettingsFrame.java ! test/jdk/java/net/httpclient/http2/server/Http2TestServerConnection.java Changeset: ad1fa1db73d9 Author: chegar Date: 2018-07-24 10:07 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ad1fa1db73d9 8207960: Non-negative WINDOW_UPDATE increments may leave the stream window size negative Reviewed-by: michaelm ! src/java.net.http/share/classes/jdk/internal/net/http/WindowController.java + test/jdk/java/net/httpclient/whitebox/WindowControllerTestDriver.java + test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/WindowControllerTest.java Changeset: ceebbc92b3b0 Author: ghaug Date: 2018-07-24 12:57 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ceebbc92b3b0 8207392: [PPC64] Implement JFR profiling. Reviewed-by: simonis, goetz ! src/hotspot/cpu/ppc/frame_ppc.cpp ! src/hotspot/os_cpu/linux_ppc/thread_linux_ppc.cpp Changeset: 5cff3e41d003 Author: cjplummer Date: 2018-07-24 10:35 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5cff3e41d003 8208075: Quarantine vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java Summary: add test to ProblemsList.txt Reviewed-by: sspitsyn ! test/hotspot/jtreg/ProblemList.txt Changeset: 049b2037b5d8 Author: rhalade Date: 2018-07-24 12:12 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/049b2037b5d8 8203230: update VerifyCACerts test Reviewed-by: mullan ! test/jdk/lib/security/cacerts/VerifyCACerts.java Changeset: a90d8198d7e4 Author: chegar Date: 2018-07-25 10:08 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a90d8198d7e4 8207846: Generalize the jdk.net.includeInExceptions security property Reviewed-by: alanb, michaelm, rriggs, mullan ! src/java.base/share/classes/sun/net/util/SocketExceptions.java ! src/java.base/share/conf/security/java.security ! test/jdk/java/net/Socket/ExceptionText.java Changeset: ea900a7dc7d7 Author: erikj Date: 2018-07-25 08:36 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ea900a7dc7d7 8208096: Update build documentation to reflect compiler upgrades at Oracle Reviewed-by: tbell ! doc/building.html ! doc/building.md Changeset: 628718bf8970 Author: dcubed Date: 2018-07-25 12:32 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/628718bf8970 8208189: ProblemList compiler/graalunit/JttThreadsTest.java Reviewed-by: darcy ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: 7087c6657f35 Author: jnimeh Date: 2018-07-25 09:48 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7087c6657f35 8207237: SSLSocket#setEnabledCipherSuites is accepting empty string Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/CipherSuite.java Changeset: 224c202c02a5 Author: jcbeyler Date: 2018-07-25 10:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/224c202c02a5 8207765: HeapMonitorTest.java intermittent failure Summary: Lower the interval rate and check GC objects too Reviewed-by: dcubed, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorTest.java Changeset: ec6d5843068a Author: dcubed Date: 2018-07-25 15:38 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ec6d5843068a 8208205: ProblemList tests that fail due to 'Error attaching to process: Can't create thread_db agent!' Reviewed-by: cjplummer ! test/hotspot/jtreg/ProblemList.txt Changeset: f6c70dedae1a Author: cjplummer Date: 2018-07-25 13:15 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f6c70dedae1a 8151259: [TESTBUG] nsk/jvmti/RedefineClasses/redefclass030 fails with "unexpected values of outer fields of the class" when running with -Xcomp Summary: do a better job of handling compilations before execution Reviewed-by: sspitsyn, amenkov ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/redefclass028.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/redefclass028/redefclass028.c ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/redefclass029.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/redefclass029/redefclass029.c ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/redefclass030.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/redefclass030/redefclass030.c Changeset: 9e04723f53c7 Author: dcubed Date: 2018-07-25 17:22 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9e04723f53c7 8208226: ProblemList com/sun/jdi/BasicJDWPConnectionTest.java Reviewed-by: sspitsyn ! test/jdk/ProblemList.txt Changeset: d31dcfaa96f3 Author: xuelei Date: 2018-07-25 17:21 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d31dcfaa96f3 8208166: Still unable to use custom SSLEngine with default TrustManagerFactory after JDK-8207029 Reviewed-by: ascarpino ! src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java Changeset: f095e3bc2d41 Author: jjiang Date: 2018-07-26 08:46 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f095e3bc2d41 8206258: [Test Error] sun/security/pkcs11 tests fail if NSS libs not found Summary: Improve the logics on skipping test Reviewed-by: valeriep ! test/jdk/sun/security/pkcs11/PKCS11Test.java ! test/jdk/sun/security/pkcs11/Secmod/TestNssDbSqlite.java ! test/jdk/sun/security/pkcs11/Signature/TestDSAKeyLength.java ! test/jdk/sun/security/pkcs11/ec/TestCurves.java ! test/jdk/sun/security/pkcs11/ec/TestECDH.java ! test/jdk/sun/security/pkcs11/ec/TestECDH2.java ! test/jdk/sun/security/pkcs11/ec/TestECDSA.java ! test/jdk/sun/security/pkcs11/ec/TestECDSA2.java ! test/jdk/sun/security/pkcs11/ec/TestECGenSpec.java Changeset: 73f3487f271d Author: ljiang Date: 2018-07-25 22:48 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/73f3487f271d 8207948: JDK 11 L10n resource file update msg drop 10 Reviewed-by: naoto ! src/demo/share/jfc/SwingSet2/resources/swingset_ja.properties ! src/demo/share/jfc/SwingSet2/resources/swingset_zh_CN.properties ! src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource_ja.java ! src/java.base/share/classes/com/sun/java/util/jar/pack/DriverResource_zh_CN.java ! src/java.base/share/classes/sun/launcher/resources/launcher_ja.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_zh_CN.properties ! src/java.base/share/classes/sun/security/tools/keytool/Resources_ja.java ! src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java ! src/java.rmi/share/classes/sun/rmi/server/resources/rmid_ja.properties ! src/java.rmi/share/classes/sun/rmi/server/resources/rmid_zh_CN.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_ja.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties + src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher_ja.properties + src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher_zh_CN.properties ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources_ja.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources_zh_CN.java ! src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_ja.properties ! src/jdk.jartool/share/classes/sun/tools/jar/resources/jar_zh_CN.properties ! src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties ! src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard_ja.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard_zh_CN.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc_ja.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc_zh_CN.properties ! src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_ja.properties ! src/jdk.jdeps/share/classes/com/sun/tools/javap/resources/javap_zh_CN.properties ! src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/resources/jdeprscan_ja.properties ! src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/resources/jdeprscan_zh_CN.properties ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps_ja.properties ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps_zh_CN.properties ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java ! src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink_ja.properties ! src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink_zh_CN.properties ! src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_ja.properties ! src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_zh_CN.properties ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_ja.properties ! src/jdk.jshell/share/classes/jdk/internal/jshell/tool/resources/l10n_zh_CN.properties ! src/jdk.rmic/share/classes/sun/rmi/rmic/resources/rmic_ja.properties ! src/jdk.rmic/share/classes/sun/rmi/rmic/resources/rmic_zh_CN.properties Changeset: 13e816d02c25 Author: rgoel Date: 2018-07-26 14:15 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/13e816d02c25 8206965: java/util/TimeZone/Bug8149452.java failed on de_DE and ja_JP locale. Summary: generated display names for missing timezones at run time. Reviewed-by: naoto ! src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java ! src/java.base/share/classes/sun/util/resources/TimeZoneNames.java ! test/jdk/java/util/TimeZone/Bug8149452.java Changeset: 21ce0a9e592a Author: simonis Date: 2018-07-23 15:17 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/21ce0a9e592a 8205608: Fix 'frames()' in ThreadReferenceImpl.c to prevent quadratic runtime behavior Reviewed-by: sspitsyn, cjplummer ! src/jdk.jdwp.agent/share/native/libjdwp/ThreadReferenceImpl.c + test/jdk/com/sun/jdi/Frames2Test.java Changeset: 3fe0329588b8 Author: jlaskey Date: 2018-07-26 10:25 -0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3fe0329588b8 8208164: (str) improve specification of String::lines Reviewed-by: smarks ! src/java.base/share/classes/java/lang/String.java Changeset: a87d1966c35c Author: prr Date: 2018-07-26 09:27 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a87d1966c35c Added tag jdk-11+24 for changeset ea900a7dc7d7 ! .hgtags Changeset: 0a7a0a6dfa22 Author: prr Date: 2018-07-26 10:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0a7a0a6dfa22 Merge ! .hgtags ! make/autoconf/spec.gmk.in ! src/hotspot/os/linux/os_linux.cpp ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/ProblemList.txt ! test/jdk/ProblemList.txt ! test/jtreg-ext/requires/VMProps.java Changeset: 80afb5e16bd1 Author: dcubed Date: 2018-07-26 13:08 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/80afb5e16bd1 8208305: ProblemList compiler/jvmci/compilerToVM/GetFlagValueTest.java Reviewed-by: hseigel, kvn ! test/hotspot/jtreg/ProblemList.txt Changeset: 35ca229c7f6f Author: amenkov Date: 2018-07-26 11:31 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/35ca229c7f6f 8199155: Accessibility issues in jdk.jdi Reviewed-by: dtitov, sspitsyn ! make/jdk/src/classes/build/tools/jdwpgen/RootNode.java ! src/hotspot/share/prims/jvmti.xsl ! src/jdk.jdi/share/classes/com/sun/jdi/doc-files/signature.html Changeset: 448cd909c9e2 Author: jcbeyler Date: 2018-07-26 11:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/448cd909c9e2 8208251: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java fails intermittently on Linux-X64 Summary: Lower the interval rate and check GC objects too Reviewed-by: dcubed, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCTest.java Changeset: 65fc31d1042b Author: dtitov Date: 2018-07-26 16:22 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/65fc31d1042b 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start Reviewed-by: sspitsyn, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TestDescription.java Changeset: 604581924221 Author: tschatzl Date: 2018-07-27 09:49 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/604581924221 8208297: Allow printing of taskqueue stats if compiled in in product builds Reviewed-by: kbarrett ! src/hotspot/share/gc/cms/parNewGeneration.cpp ! src/hotspot/share/gc/parallel/psPromotionManager.cpp Changeset: 979e349059eb Author: nishjain Date: 2018-07-27 14:20 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/979e349059eb 8021322: [Fmt-Ch] Implementation of ChoiceFormat math methods should delegate to java.lang.Math methods Reviewed-by: naoto, darcy ! src/java.base/share/classes/java/text/ChoiceFormat.java Changeset: 2ce72467c4e8 Author: dcubed Date: 2018-07-27 16:29 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2ce72467c4e8 8171157: Convert ObjectMonitor_test to GTest Summary: Migration of the ObjectMonitor test to GTest. Two GTests were actually created, one for ObjectMonitor and one for ObjectSynchronizer. Reviewed-by: dcubed, hseigel Contributed-by: patricio.chilano.mateo at oracle.com ! src/hotspot/share/runtime/objectMonitor.cpp ! src/hotspot/share/runtime/objectMonitor.hpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/utilities/internalVMTests.cpp + test/hotspot/gtest/runtime/test_objectMonitor.cpp + test/hotspot/gtest/runtime/test_synchronizer.cpp Changeset: 5fd711ba43f5 Author: xyin Date: 2018-07-30 09:06 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5fd711ba43f5 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration Reviewed-by: lancea, mchung ! test/jdk/java/lang/Package/PackageFromManifest.java Changeset: b7a307084247 Author: pmuthuswamy Date: 2018-07-30 11:52 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b7a307084247 8203791: Remove "compatibility" features from Table.java Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/EnumConstantWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Table.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testMethodTypes/TestMethodTypes.java ! test/langtools/jdk/javadoc/doclet/testProperty/TestProperty.java ! test/langtools/jdk/javadoc/doclet/testUnnamedPackage/TestUnnamedPackage.java Changeset: 0a4916c1418c Author: dcubed Date: 2018-07-30 14:22 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0a4916c1418c 8208521: ProblemList more tests that fail due to 'Error attaching to process: Can't create thread_db agent!' Reviewed-by: cjplummer ! test/hotspot/jtreg/ProblemList.txt Changeset: d4b9a434af84 Author: mvala Date: 2018-07-30 14:08 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d4b9a434af84 8208084: Windows build failure - "'snprintf': identifier not found" Reviewed-by: kbarrett, coleenp ! test/hotspot/gtest/classfile/test_symbolTable.cpp Changeset: b5aac518b097 Author: hseigel Date: 2018-07-30 16:35 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b5aac518b097 8207779: Method::is_valid_method() compares 'this' with NULL Summary: Add Method* parameter and make method static to avoid 'thi's comparison with NULL Reviewed-by: lfoltan, coleenp ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/arm/frame_arm.cpp ! src/hotspot/cpu/sparc/frame_sparc.cpp ! src/hotspot/cpu/x86/frame_x86.cpp ! src/hotspot/share/jfr/periodic/sampling/jfrCallTrace.cpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/prims/forte.cpp Changeset: cf34c71ca27c Author: zgu Date: 2018-07-31 07:35 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cf34c71ca27c 8208499: NMT: Missing memory tag for Safepoint polling page Summary: Added missing memory tag and cleanup memory type enum Reviewed-by: shade, coleenp ! src/hotspot/share/memory/allocation.hpp ! src/hotspot/share/runtime/safepointMechanism.cpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/services/nmtCommon.cpp + test/hotspot/jtreg/runtime/NMT/SafepointPollingPages.java Changeset: 8329bfbe1b30 Author: hseigel Date: 2018-07-31 09:55 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8329bfbe1b30 8208399: Metadata methods print_(value_)on_maybe_null() compare 'this' to NULL Summary: Add Method* parameter and make method static to avoid 'this' comparison with NULL Reviewed-by: lfoltan, gziemski, coleenp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/metadata.hpp Changeset: f8696e0ab9b7 Author: mcimadamore Date: 2018-07-31 16:49 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f8696e0ab9b7 8208524: IntelliJ support broken since 2018.2 Summary: Move build.xml out of .idea folder Reviewed-by: stuefe ! bin/idea.sh ! make/idea/template/ant.xml ! make/idea/template/build.xml ! make/idea/template/misc.xml ! make/langtools/build.xml ! make/langtools/intellij/ant.xml ! make/langtools/intellij/build.xml ! make/langtools/intellij/misc.xml Changeset: 2cd8bbccbd2d Author: zgu Date: 2018-07-31 13:12 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2cd8bbccbd2d 8199868: Support JNI critical functions in object pinning API Summary: Pin/unpin incoming array arguments of critical native JNI call Reviewed-by: shade, adinn ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp + test/hotspot/jtreg/gc/epsilon/CriticalNativeArgs.java + test/hotspot/jtreg/gc/epsilon/CriticalNativeStress.java + test/hotspot/jtreg/gc/epsilon/libCriticalNative.c Changeset: 4ac20e5f96ce Author: hseigel Date: 2018-07-31 14:24 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4ac20e5f96ce 8202171: Some oopDesc functions compare this with NULL Summary: Add Method* parameter and made verify* methods static to avoid 'this' comparison with NULL, Added NULL checks before calling print_on() methods. Reviewed-by: kbarrett, coleenp ! src/hotspot/share/classfile/dictionary.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/code/debugInfo.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp ! src/hotspot/share/gc/parallel/immutableSpace.cpp ! src/hotspot/share/gc/parallel/mutableSpace.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/objArrayKlass.cpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/runtime/fieldDescriptor.cpp ! src/hotspot/share/runtime/jniHandles.cpp Changeset: b53d1f96b8c4 Author: coleenp Date: 2018-07-31 15:57 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b53d1f96b8c4 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException Summary: fixed refactoring caused by JDK-8203820 Reviewed-by: dholmes, sspitsyn, cjplummer ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine.java Changeset: 15486bed8a5f Author: dcubed Date: 2018-07-31 17:07 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/15486bed8a5f 8208605: Fix for 8199868 breaks tier1 build Summary: Move variable declarations to make studio compiler happy. Reviewed-by: kbarrett ! test/hotspot/jtreg/gc/epsilon/libCriticalNative.c Changeset: b6e0bfe4a6ec Author: dbuck Date: 2018-08-01 01:40 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b6e0bfe4a6ec 8208541: non-ASCII characters in hsdis UPL text Summary: replace Unicode left/right double quote pair with normal ASCII double quotes Reviewed-by: jrose ! src/utils/hsdis/Makefile ! src/utils/hsdis/README ! src/utils/hsdis/hsdis-demo.c ! src/utils/hsdis/hsdis.c ! src/utils/hsdis/hsdis.h Changeset: 9d92ff04a29c Author: weijun Date: 2018-08-01 13:35 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9d92ff04a29c 8208602: Cannot read PEM X.509 cert if there is whitespace after the header or footer Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/provider/X509Factory.java ! test/jdk/sun/security/provider/X509Factory/BadPem.java Changeset: 5064f30ac015 Author: dbuck Date: 2018-08-01 02:21 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5064f30ac015 8191006: hsdis disassembler plugin does not compile with binutils 2.29+ Summary: update call to disassembler() function to match new signature used by Binutils Reviewed-by: gromero, kvn ! src/utils/hsdis/README ! src/utils/hsdis/hsdis.c Changeset: 24904e14794b Author: pmuthuswamy Date: 2018-08-01 12:36 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/24904e14794b 8208484: color contrast issues in a couple of spec files Reviewed-by: jjg, ihse ! make/data/docs-resources/resources/jdk-default.css Changeset: b095f437af22 Author: nishjain Date: 2018-08-01 18:02 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b095f437af22 8208560: ChoiceFormat class has unused constants needs cleanup Reviewed-by: rriggs, naoto ! src/java.base/share/classes/java/text/ChoiceFormat.java Changeset: 04183bf08bff Author: naoto Date: 2018-08-01 09:33 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/04183bf08bff 8208080: Locale extensions via Service provider is not working for region extensions Reviewed-by: rriggs, nishjain ! src/java.base/share/classes/sun/util/locale/provider/CalendarDataUtility.java ! src/java.base/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java + test/jdk/java/util/Locale/bcp47u/spi/DateFormatSymbolsProviderTests.java + test/jdk/java/util/Locale/bcp47u/spi/provider/foo/DateFormatSymbolsProviderImpl.java ! test/jdk/java/util/Locale/bcp47u/spi/provider/module-info.java Changeset: dfe1cff5c2f6 Author: iignatyev Date: 2018-08-01 10:04 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dfe1cff5c2f6 8174691: [TESTBUG] A number of native hotspot unit tests fail when executed in stand-alone mode Reviewed-by: kvn, tschatzl ! src/hotspot/share/gc/g1/g1Arguments.hpp ! test/hotspot/gtest/gc/g1/test_g1HeapVerifier.cpp ! test/hotspot/gtest/runtime/test_os.cpp ! test/hotspot/gtest/utilities/test_spinYield.cpp Changeset: d56dd9798d54 Author: kbarrett Date: 2018-08-01 19:14 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d56dd9798d54 8208611: Refactor SATBMarkQueue filtering to allow GC-specific filters Summary: Add SATBMarkQueueFilter. Reviewed-by: tschatzl, eosterlund, rkennke ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp + src/hotspot/share/gc/g1/g1SATBMarkQueueFilter.cpp + src/hotspot/share/gc/g1/g1SATBMarkQueueFilter.hpp ! src/hotspot/share/gc/g1/satbMarkQueue.cpp ! src/hotspot/share/gc/g1/satbMarkQueue.hpp Changeset: 5cc6acb1d6b6 Author: mseledtsov Date: 2018-08-01 19:07 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5cc6acb1d6b6 8185531: [TESTBUG] Improve test configuration for shared strings Summary: Added extra test configurations to the tests Reviewed-by: iklam, gziemski ! test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasic.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsStress.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/SysDictCrash.java Changeset: a306c84e40fa Author: iignatyev Date: 2018-08-01 23:06 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a306c84e40fa 8208647: switch jtreg to 4.2b13 Reviewed-by: kvn, dholmes, ihse ! make/conf/jib-profiles.js ! test/failure_handler/src/share/classes/jdk/test/failurehandler/jtreg/GatherDiagnosticInfoObserver.java Changeset: 3bd8d0a0e28c Author: jcbeyler Date: 2018-07-31 10:20 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3bd8d0a0e28c 8208246: flags duplications in vmTestbase_vm_g1classunloading tests Summary: Remove duplicate flags for the classunloading tests Reviewed-by: tschatzl, iignatyev ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_anonclassloader_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_anonclassloader_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_anonclassloader_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_anonclassloader_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_keep_obj/TestDescription.java Changeset: 1c8cdf3d4c9e Author: jcbeyler Date: 2018-08-01 09:23 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1c8cdf3d4c9e 8069343: Improve gc/g1/TestHumongousCodeCacheRoots.java to use jtreg @requires Summary: Remove client test entirely and clean up test Reviewed-by: tschatzl, iignatyev ! test/hotspot/jtreg/gc/g1/TestHumongousCodeCacheRoots.java Changeset: ac4f5ef0edd9 Author: jcbeyler Date: 2018-07-31 12:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ac4f5ef0edd9 8169004: Fix redundant @requires tags in tests Reviewed-by: tschatzl, iignatyev ! test/hotspot/jtreg/gc/TestNUMAPageSize.java ! test/hotspot/jtreg/gc/arguments/TestTargetSurvivorRatioFlag.java ! test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData00.java ! test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData05.java ! test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData10.java ! test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData15.java ! test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData20.java ! test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData25.java ! test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData30.java ! test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java ! test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTestCompiler.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack001.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack002.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack003.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack004.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack005.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack006.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack007.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack008.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack009.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack010.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack011.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack012.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack013.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack014.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack015.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack016.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack017.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack018.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack019.java Changeset: 3528ba05663a Author: jcbeyler Date: 2018-07-31 10:16 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3528ba05663a 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names Summary: Put a ThreadLocal around the object to be thread safe Reviewed-by: tschatzl, iignatyev ! test/hotspot/jtreg/vmTestbase/vm/share/gc/TriggerUnloadingByFillingMetaspace.java Changeset: 1129f9833589 Author: zgu Date: 2018-08-02 11:13 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1129f9833589 8208635: Minimal VM build is broken after JDK-8199868 (Support JNI critical functions in object pinning API) Summary: Added missing header file Reviewed-by: shade, gziemski ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp Changeset: 744f731e9e8c Author: prr Date: 2018-08-02 09:27 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/744f731e9e8c Added tag jdk-12+5 for changeset f8696e0ab9b7 ! .hgtags Changeset: 7b1ddbafa134 Author: iignatyev Date: 2018-08-02 14:40 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7b1ddbafa134 8208655: use JTreg skipped status in hotspot tests Reviewed-by: kvn, hseigel, iklam ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/compiler/codecache/dtrace/SegmentedCodeCacheDtraceTest.java ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java ! test/hotspot/jtreg/compiler/tiered/ConstantGettersTransitionsTest.java ! test/hotspot/jtreg/compiler/tiered/LevelTransitionTest.java ! test/hotspot/jtreg/compiler/tiered/NonTieredLevelsTest.java ! test/hotspot/jtreg/compiler/tiered/TieredLevelsTest.java ! test/hotspot/jtreg/gc/arguments/TestAggressiveHeap.java ! test/hotspot/jtreg/gc/g1/TestHumongousShrinkHeap.java ! test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java ! test/hotspot/jtreg/gc/g1/TestShrinkAuxiliaryData.java ! test/hotspot/jtreg/runtime/6819213/TestBootNativeLibraryPath.java ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java ! test/hotspot/jtreg/runtime/CompressedOops/CompressedKlassPointerAndOops.java ! test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java ! test/hotspot/jtreg/runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java ! test/hotspot/jtreg/runtime/SharedArchiveFile/CdsSameObjectAlignment.java ! test/hotspot/jtreg/runtime/XCheckJniJsig/XCheckJSig.java ! test/hotspot/jtreg/runtime/libadimalloc.solaris.sparc/Testlibadimalloc.java ! test/hotspot/jtreg/runtime/memory/LargePages/TestLargePagesFlags.java ! test/hotspot/jtreg/runtime/os/AvailableProcessors.java ! test/hotspot/jtreg/runtime/signal/SigTestDriver.java ! test/hotspot/jtreg/serviceability/jvmti/GetObjectSizeOverflow.java ! test/hotspot/jtreg/serviceability/jvmti/NotifyFramePop/NotifyFramePopTest.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbCDSCore.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbCDSJstackPrintAll.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbInspect.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbJdis.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbLongConstant.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbPrintAs.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbRegionDetailsScanOopsForG1.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbScanOops.java ! test/hotspot/jtreg/serviceability/sa/DeadlockDetectionTest.java ! test/hotspot/jtreg/serviceability/sa/TestJmapCore.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/UnloadingTest.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/AttachingConnector/attach/attach004/TestDriver.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/stress/thread/strace001.java + test/lib/jtreg/SkippedException.java Changeset: 8e2f5dad68a0 Author: iignatyev Date: 2018-08-02 16:15 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8e2f5dad68a0 8208699: remove unneeded imports from runtime tests Reviewed-by: iklam ! test/hotspot/jtreg/runtime/SharedArchiveFile/CdsSameObjectAlignment.java ! test/hotspot/jtreg/runtime/XCheckJniJsig/XCheckJSig.java Changeset: 531de4cbaa4f Author: iignatyev Date: 2018-08-02 16:16 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/531de4cbaa4f 8208701: Fix for JDK-8208655 causes test failures in CI tier1 Reviewed-by: dholmes, dcubed ! test/hotspot/jtreg/runtime/6819213/TestBootNativeLibraryPath.java ! test/hotspot/jtreg/runtime/CompressedOops/CompressedKlassPointerAndOops.java ! test/hotspot/jtreg/runtime/XCheckJniJsig/XCheckJSig.java ! test/hotspot/jtreg/runtime/memory/LargePages/TestLargePagesFlags.java Changeset: 5afd528675f6 Author: dcubed Date: 2018-08-02 22:14 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5afd528675f6 8208706: compiler/tiered/ConstantGettersTransitionsTest.java fails to compile Reviewed-by: dholmes ! test/hotspot/jtreg/compiler/tiered/ConstantGettersTransitionsTest.java Changeset: 57aa80913140 Author: coffeys Date: 2018-08-03 09:57 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/57aa80913140 8207775: Better management of CipherCore buffers Reviewed-by: ascarpino ! src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java Changeset: 0538a5cdb474 Author: zgu Date: 2018-08-03 11:06 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0538a5cdb474 8205921: Optimizing best-of-2 work stealing queue selection Summary: Bias towards stealing from queues that we recently successfully stole from to decrease the number of unsuccessful steal attempts. Reviewed-by: eosterlund, kbarrett Contributed-by: Zhengyu Gu , Thomas Schatzl ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp ! src/hotspot/share/gc/cms/parNewGeneration.cpp ! src/hotspot/share/gc/cms/parNewGeneration.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1FullGCMarker.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp ! src/hotspot/share/gc/parallel/pcTasks.cpp ! src/hotspot/share/gc/parallel/psCompactionManager.hpp ! src/hotspot/share/gc/parallel/psCompactionManager.inline.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.hpp ! src/hotspot/share/gc/parallel/psPromotionManager.inline.hpp ! src/hotspot/share/gc/parallel/psTasks.cpp ! src/hotspot/share/gc/shared/taskqueue.cpp ! src/hotspot/share/gc/shared/taskqueue.hpp ! src/hotspot/share/gc/shared/taskqueue.inline.hpp Changeset: 53c3b460503c Author: coffeys Date: 2018-08-03 14:14 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/53c3b460503c 8208583: Better management of internal KeyStore buffers Reviewed-by: weijun ! src/java.base/share/classes/com/sun/crypto/provider/KeyProtector.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEKey.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEKeyFactory.java ! src/java.base/share/classes/javax/crypto/spec/PBEKeySpec.java ! src/java.base/share/classes/sun/security/provider/JavaKeyStore.java ! src/java.base/share/classes/sun/security/provider/KeyProtector.java Changeset: 38cbdf8f383f Author: dcubed Date: 2018-07-26 13:08 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/38cbdf8f383f 8208305: ProblemList compiler/jvmci/compilerToVM/GetFlagValueTest.java Reviewed-by: hseigel, kvn ! test/hotspot/jtreg/ProblemList.txt Changeset: 76ffdd60d5bc Author: epavlova Date: 2018-07-26 10:23 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/76ffdd60d5bc 8195156: [Graal] serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java fails with Graal in Xcomp mode Reviewed-by: kvn, sspitsyn ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java Changeset: d64013e38c11 Author: jcbeyler Date: 2018-07-26 11:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d64013e38c11 8208251: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java fails intermittently on Linux-X64 Summary: Lower the interval rate and check GC objects too Reviewed-by: dcubed, sspitsyn Contributed-by: jcbeyler at google.com ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCTest.java Changeset: 9d49099287b1 Author: hseigel Date: 2018-07-26 15:56 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9d49099287b1 8207944: java.lang.ClassFormatError: Extra bytes at the end of class file test" possibly violation of JVMS 4.7.1 Summary: Add code to skip over unknown attributes when class file version >= 11. Reviewed-by: lfoltan ! src/hotspot/share/classfile/classFileParser.cpp + test/hotspot/jtreg/runtime/classFileParserBug/UnknownAttr.jcod + test/hotspot/jtreg/runtime/classFileParserBug/UnknownAttrTest.java Changeset: 3e08503ad77e Author: iignatyev Date: 2018-07-26 23:59 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3e08503ad77e 8208358: update bug ids mentioned in tests Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/jit/escape/LockCoarsening/LockCoarsening001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/jit/escape/LockCoarsening/LockCoarsening002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/metaspace/gc/firstGC_10m/TestDescription.java ! test/hotspot/jtreg/vmTestbase/metaspace/gc/firstGC_50m/TestDescription.java ! test/hotspot/jtreg/vmTestbase/metaspace/gc/firstGC_99m/TestDescription.java ! test/hotspot/jtreg/vmTestbase/metaspace/gc/firstGC_default/TestDescription.java ! test/hotspot/jtreg/vmTestbase/metaspace/shrink_grow/CompressedClassSpaceSize/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdb/exclude/exclude001/exclude001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/AttachingConnector/attach/attach002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/AttachingConnector/attachnosuspend/attachnosuspend001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/hotswap/tc10x001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/multithrd/tc02x004/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod009/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassType/newInstance/newinstance002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove_l/remove_l005/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequest/setEnabled/setenabled003/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequestManager/createStepRequest/crstepreq001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequestManager/deleteEventRequest/delevtreq002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ObjectReference/invokeMethod/invokemethod006/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/StackFrame/_bounds_/bounds001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadGroupReference/resume/resume001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/frameCount/framecount001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/resume/resume001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/redefineClasses/redefineclasses021/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/redefineClasses/redefineclasses023/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/stress/ClassPrepareEvents/ClassPrepareEvents001/ClassPrepareEvents001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn001/forceEarlyReturn001.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/getCollectionUsage/getusage004/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded003/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isUsageThresholdExceeded/isexceeded002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isUsageThresholdExceeded/isexceeded003/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isUsageThresholdExceeded/isexceeded004/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isUsageThresholdExceeded/isexceeded005/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi001/Multi001.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi002/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi003/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi004/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Multi/Multi005/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/jni/gclocker/gcl001.java ! test/hotspot/jtreg/vmTestbase/vm/compiler/jbe/subcommon/subcommon02/subcommon02.java ! test/hotspot/jtreg/vmTestbase/vm/gc/containers/TreeMap_Arrays/TestDescription.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/func/java/throwException/Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/func/jdi/breakpointOtherStratum/Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/compiler/i2c_c2i/Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/compiler/sequences/Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/gc/callSequencesDuringGC/Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/java/sequences/Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/stress/jdi/breakpointInCompiledCode/Test.java ! test/hotspot/jtreg/vmTestbase/vm/mlvm/mixed/stress/java/findDeadlock/TestDescription.java Changeset: 24517a097dc1 Author: iignatyev Date: 2018-07-27 00:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/24517a097dc1 8208370: fix typo in ReservedStack tests' @requires Reviewed-by: kvn ! test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTest.java ! test/hotspot/jtreg/runtime/ReservedStack/ReservedStackTestCompiler.java Changeset: 93bee498934c Author: dcubed Date: 2018-07-30 14:22 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/93bee498934c 8208521: ProblemList more tests that fail due to 'Error attaching to process: Can't create thread_db agent!' Reviewed-by: cjplummer ! test/hotspot/jtreg/ProblemList.txt Changeset: ea972a176435 Author: epavlova Date: 2018-07-31 09:48 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ea972a176435 8208347: ProblemList compiler/cpuflags/TestAESIntrinsicsOnSupportedConfig.java Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList.txt Changeset: 6ada313454e9 Author: dsamersoff Date: 2018-07-31 21:23 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6ada313454e9 8207046: arm32 vm crash: C1 arm32 platform functions parameters type mismatch Summary: fixed unexpected parameter location in arm32 LIR_Assembler Reviewed-by: dsamersoff, kvn ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp Changeset: 0eeff620cdf5 Author: prr Date: 2018-07-31 12:23 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0eeff620cdf5 8208466: Fix potential memory leak in harfbuzz shaping. Reviewed-by: jdv, kaddepalli ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ft.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.cc Changeset: 66d9993dd4ad Author: prr Date: 2018-07-31 14:03 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/66d9993dd4ad 8208353: Upgrade JDK 11 to libpng 1.6.35 Reviewed-by: jdv, kaddepalli ! src/java.desktop/share/legal/libpng.md ! src/java.desktop/share/native/libsplashscreen/libpng/CHANGES ! src/java.desktop/share/native/libsplashscreen/libpng/LICENSE ! src/java.desktop/share/native/libsplashscreen/libpng/README + src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt ! src/java.desktop/share/native/libsplashscreen/libpng/png.c ! src/java.desktop/share/native/libsplashscreen/libpng/png.h ! src/java.desktop/share/native/libsplashscreen/libpng/pngconf.h ! src/java.desktop/share/native/libsplashscreen/libpng/pngget.c ! src/java.desktop/share/native/libsplashscreen/libpng/pnginfo.h ! src/java.desktop/share/native/libsplashscreen/libpng/pnglibconf.h ! src/java.desktop/share/native/libsplashscreen/libpng/pngpread.c ! src/java.desktop/share/native/libsplashscreen/libpng/pngpriv.h ! src/java.desktop/share/native/libsplashscreen/libpng/pngread.c ! src/java.desktop/share/native/libsplashscreen/libpng/pngrio.c ! src/java.desktop/share/native/libsplashscreen/libpng/pngrtran.c ! src/java.desktop/share/native/libsplashscreen/libpng/pngrutil.c ! src/java.desktop/share/native/libsplashscreen/libpng/pngset.c ! src/java.desktop/share/native/libsplashscreen/libpng/pngstruct.h ! src/java.desktop/share/native/libsplashscreen/libpng/pngtrans.c Changeset: 331888ea4a78 Author: prr Date: 2018-07-31 14:04 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/331888ea4a78 8204931: Colors with alpha are painted incorrectly on Linux Reviewed-by: jdv, psadhukhan ! src/java.desktop/unix/classes/sun/java2d/xr/XRGraphicsConfig.java ! src/java.desktop/unix/classes/sun/java2d/xr/XRSurfaceData.java + test/jdk/java/awt/Color/AlphaColorTest.java Changeset: 26cca23c165a Author: mgronlun Date: 2018-08-02 09:49 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/26cca23c165a 8207139: NMT is not enabled on Windows 2016/10 Reviewed-by: dcubed, zgu, dholmes ! src/hotspot/share/services/memTracker.cpp Changeset: 4322ef0c1684 Author: prr Date: 2018-08-02 09:26 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4322ef0c1684 Added tag jdk-11+25 for changeset 331888ea4a78 ! .hgtags Changeset: acf02a6f369e Author: prr Date: 2018-08-03 09:42 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/acf02a6f369e Merge ! .hgtags ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/services/memTracker.cpp ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdb/exclude/exclude001/exclude001.java Changeset: 13e2e64337be Author: bpb Date: 2018-08-03 12:45 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/13e2e64337be 8186766: UnixNativeDispatcher::readlink() may truncate overlong paths Reviewed-by: alanb ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c Changeset: a694574b2def Author: darcy Date: 2018-08-03 21:06 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a694574b2def 8208782: Remove extra type in throws clause of SerialClob.writeObject Reviewed-by: lancea ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialClob.java Changeset: d93577466d8c Author: alanb Date: 2018-08-05 19:16 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d93577466d8c 8208998: Typo in ModueInfo.java, field for ModuleHashes should be moduleHashes Reviewed-by: alanb Contributed-by: christoph.dreis at freenet.de ! src/java.base/share/classes/jdk/internal/module/ModuleInfo.java Changeset: c00451b67854 Author: dholmes Date: 2018-08-06 04:31 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c00451b67854 8208623: [TESTBUG] runtime/LoadClass/LongBCP.java fails in AUFS file system Summary: Limit the maximal file name length to 242 for AUFS file system Reviewed-by: dholmes, redestad Contributed-by: pengfei.li at arm.com ! test/hotspot/jtreg/runtime/LoadClass/LongBCP.java Changeset: f7236b46b60c Author: dcubed Date: 2018-08-06 13:57 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f7236b46b60c 8209018: ProblemList tests affected by JDK-8208690 Reviewed-by: kvn ! test/jdk/ProblemList.txt Changeset: 82adcc8ad853 Author: hseigel Date: 2018-08-06 14:20 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/82adcc8ad853 8208604: Metadata::print_value_string() compares 'this' to NULL Summary: Remove the comparison and add asserts to check for NULL Reviewed-by: coleenp, gziemski ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/code/compiledIC.cpp ! src/hotspot/share/jvmci/jvmciRuntime.cpp ! src/hotspot/share/oops/metadata.cpp Changeset: 2ec98fcfb2b2 Author: dcubed Date: 2018-08-06 16:15 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2ec98fcfb2b2 8209020: ProblemList tests affected by JDK-8208778 Reviewed-by: hseigel ! test/hotspot/jtreg/ProblemList.txt Changeset: c23f1e4910f3 Author: epavlova Date: 2018-08-06 13:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c23f1e4910f3 8194958: [Graal] disable compiler/c2/cr7200264 tests Reviewed-by: kvn, tschatzl ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/compiler/c2/cr7200264/TestSSE2IntVect.java ! test/hotspot/jtreg/compiler/c2/cr7200264/TestSSE4IntVect.java Changeset: e122220d7d7e Author: darcy Date: 2018-08-06 14:29 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e122220d7d7e 8209024: Use SuppressWarnings on serialVersionUID fields in interfaces Reviewed-by: bpb, rriggs, mullan ! src/java.base/share/classes/java/security/Key.java ! src/java.base/share/classes/java/security/PrivateKey.java ! src/java.base/share/classes/java/security/PublicKey.java ! src/java.base/share/classes/java/security/interfaces/DSAPrivateKey.java ! src/java.base/share/classes/java/security/interfaces/DSAPublicKey.java ! src/java.base/share/classes/java/security/interfaces/ECPrivateKey.java ! src/java.base/share/classes/java/security/interfaces/ECPublicKey.java ! src/java.base/share/classes/java/security/interfaces/RSAMultiPrimePrivateCrtKey.java ! src/java.base/share/classes/java/security/interfaces/RSAPrivateCrtKey.java ! src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java ! src/java.base/share/classes/java/security/interfaces/RSAPublicKey.java ! src/java.base/share/classes/javax/crypto/SecretKey.java ! src/java.base/share/classes/javax/crypto/interfaces/DHPrivateKey.java ! src/java.base/share/classes/javax/crypto/interfaces/DHPublicKey.java ! src/java.base/share/classes/javax/crypto/interfaces/PBEKey.java ! src/java.base/share/classes/sun/security/internal/interfaces/TlsMasterSecret.java ! src/java.naming/share/classes/javax/naming/Name.java ! src/java.naming/share/classes/javax/naming/directory/Attribute.java ! src/java.rmi/share/classes/java/rmi/server/RemoteRef.java ! src/java.rmi/share/classes/java/rmi/server/ServerRef.java Changeset: 60f9b6b5ad86 Author: fweimer Date: 2018-08-06 14:55 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/60f9b6b5ad86 8208362: (bf) Long chains created by direct Buffer::slice Reviewed-by: mr, psandoz, alanb ! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template + test/jdk/java/nio/Buffer/ReachabilityTest.java Changeset: 3142a04a2f6d Author: psandoz Date: 2018-08-06 15:18 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3142a04a2f6d 8206955: MethodHandleProxies.asInterfaceInstance does not support default methods Reviewed-by: mchung, plevart ! src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java + test/jdk/java/lang/invoke/MethodHandlesProxiesTest.java Changeset: 932efe020b20 Author: shurailine Date: 2018-08-06 15:35 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/932efe020b20 8208364: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java missing module dependencies declaration Reviewed-by: mchung ! test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java Changeset: ad9ecba11565 Author: jcbeyler Date: 2018-08-06 14:23 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ad9ecba11565 8079682: [mlvm] remove SAM code in MHTransformationGen Summary: Remove SAM code from the test and remove related dead code Reviewed-by: iignatyev ! test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/share/MHTransformationGen.java - test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/share/transform/v2/MHSamTF.java Changeset: 094ba0b5001a Author: dcubed Date: 2018-08-06 20:52 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/094ba0b5001a 8209029: ProblemList tests that fail due to 'Error attaching to process: Can't create thread_db agent!' in jdk-11+25 testing Reviewed-by: dholmes, sspitsyn ! test/hotspot/jtreg/ProblemList.txt Changeset: b44abec1bcfc Author: kvn Date: 2018-08-06 18:49 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b44abec1bcfc 8209023: fix 2 compiler tests to avoid JDK-8208690 Reviewed-by: dholmes, dcubed ! test/hotspot/jtreg/compiler/runtime/cr6891750/Test6891750.java Changeset: 10ef3d870cb7 Author: mbaesken Date: 2018-08-03 07:59 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/10ef3d870cb7 8208744: remove unneeded -DUSE_MMAP settings for JDK native libs builds Reviewed-by: ihse, martin, alanb, dholmes ! make/lib/Lib-jdk.jdi.gmk ! make/lib/Lib-jdk.jdwp.agent.gmk Changeset: 52fed262f009 Author: ccheung Date: 2018-08-07 09:44 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/52fed262f009 8208704: runtime/appcds/MultiReleaseJars.java timed out often in hs-tier7 testing Summary: increase timout to 2400 and reduce the amount of output Reviewed-by: mseledtsov, jiangli ! test/hotspot/jtreg/runtime/appcds/MultiReleaseJars.java Changeset: 0fe936321c82 Author: iignatyev Date: 2018-08-07 13:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0fe936321c82 8031761: [TESTBUG] Add a regression test for JDK-8026328 Reviewed-by: kvn, iignatyev Contributed-by: staffan.larsen at oracle.com + test/hotspot/jtreg/compiler/jsr292/cr8026328/Test8026328.java + test/hotspot/jtreg/compiler/jsr292/cr8026328/libTest8026328.c Changeset: a19fda433921 Author: redestad Date: 2018-08-07 23:08 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a19fda433921 8209003: Consolidate use of empty collections in java.lang.module Reviewed-by: alanb, mchung ! src/java.base/share/classes/java/lang/Module.java ! src/java.base/share/classes/java/lang/ModuleLayer.java ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java ! src/java.base/share/classes/java/lang/module/ModuleFinder.java ! src/java.base/share/classes/jdk/internal/module/Builder.java ! src/java.base/share/classes/jdk/internal/module/ExplodedSystemModules.java ! src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java ! src/java.base/share/classes/jdk/internal/module/ModuleInfo.java ! src/java.base/share/classes/jdk/internal/module/ModulePatcher.java ! src/java.base/share/classes/jdk/internal/module/ModulePath.java ! src/java.base/share/classes/jdk/internal/module/ServicesCatalog.java ! src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java ! test/jdk/java/lang/module/ModuleDescriptorTest.java Changeset: fad2334b2906 Author: sherman Date: 2018-08-07 16:07 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fad2334b2906 8208634: Add x-IBM-1129 charset Reviewed-by: alanb, sherman Contributed-by: enasser at in.ibm.com + make/data/charsetmapping/IBM1129.c2b + make/data/charsetmapping/IBM1129.map ! make/data/charsetmapping/charsets ! make/data/charsetmapping/stdcs-aix ! make/nb_native/nbproject/configurations.xml ! test/jdk/java/nio/charset/Charset/RegisteredCharsets.java ! test/jdk/java/nio/charset/RemovingSunIO/SunioAlias.java ! test/jdk/sun/nio/cs/CheckHistoricalNames.java Changeset: 9c68699bebe5 Author: iklam Date: 2018-08-07 15:45 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9c68699bebe5 8208999: Some use of Klass* should be replaced by InstanceKlass* Summary: Klass::java_super() => InstanceKlass*; InstanceKlass::{local,transitive}_interfaces() => Array* Reviewed-by: coleenp, hseigel ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/code/dependencies.hpp ! src/hotspot/share/memory/heapInspection.cpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/memory/universe.hpp ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/arrayKlass.hpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/klassVtable.hpp ! src/hotspot/share/oops/objArrayKlass.cpp ! src/hotspot/share/oops/objArrayKlass.hpp ! src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiImpl.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/runtime/reflectionUtils.cpp ! src/hotspot/share/runtime/reflectionUtils.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/services/heapDumper.cpp Changeset: edd33b9946ca Author: coleenp Date: 2018-08-07 19:35 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/edd33b9946ca 8208575: Remove Atomic::add/sub for short Summary: Removed code to atomic::add for short because it's no longer used for Symbol. Reviewed-by: iklam ! src/hotspot/share/runtime/atomic.hpp ! src/hotspot/share/utilities/macros.hpp Changeset: 7939b3c4e408 Author: xyin Date: 2018-08-08 10:21 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7939b3c4e408 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/ Reviewed-by: vtewari, rriggs + test/jdk/com/sun/jndi/dns/EnvTests/AddInherited.dns + test/jdk/com/sun/jndi/dns/EnvTests/AddInherited.java + test/jdk/com/sun/jndi/dns/EnvTests/AddOps.dns + test/jdk/com/sun/jndi/dns/EnvTests/AddOps.java + test/jdk/com/sun/jndi/dns/EnvTests/EnvTestBase.java + test/jdk/com/sun/jndi/dns/EnvTests/GetEnv.dns + test/jdk/com/sun/jndi/dns/EnvTests/GetEnv.java + test/jdk/com/sun/jndi/dns/EnvTests/ProviderUrlGen.java + test/jdk/com/sun/jndi/dns/EnvTests/RemoveInherited.dns + test/jdk/com/sun/jndi/dns/EnvTests/RemoveInherited.java + test/jdk/com/sun/jndi/dns/EnvTests/RemoveOps.dns + test/jdk/com/sun/jndi/dns/EnvTests/RemoveOps.java + test/jdk/com/sun/jndi/dns/EnvTests/SubcontextAdd.dns + test/jdk/com/sun/jndi/dns/EnvTests/SubcontextAdd.java + test/jdk/com/sun/jndi/dns/EnvTests/SubcontextRemove.dns + test/jdk/com/sun/jndi/dns/EnvTests/SubcontextRemove.java Changeset: c25572739e7c Author: tschatzl Date: 2018-08-08 15:31 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c25572739e7c 8208669: GC changes to allow enabling -Wreorder Reviewed-by: kbarrett ! src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp ! src/hotspot/share/gc/cms/parNewGeneration.cpp ! src/hotspot/share/gc/epsilon/epsilonMemoryPool.cpp ! src/hotspot/share/gc/g1/c1/g1BarrierSetC1.hpp ! src/hotspot/share/gc/g1/g1AllocRegion.cpp ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1Analytics.cpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectionSet.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkBitMap.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp ! src/hotspot/share/gc/g1/g1ConcurrentRefineThread.cpp ! src/hotspot/share/gc/g1/g1ConcurrentRefineThread.hpp ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1FullGCMarker.cpp ! src/hotspot/share/gc/g1/g1FullGCMarker.hpp ! src/hotspot/share/gc/g1/g1FullGCOopClosures.cpp ! src/hotspot/share/gc/g1/g1FullGCOopClosures.hpp ! src/hotspot/share/gc/g1/g1FullGCPrepareTask.cpp ! src/hotspot/share/gc/g1/g1FullGCScope.cpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp ! src/hotspot/share/gc/g1/g1HeapVerifier.cpp ! src/hotspot/share/gc/g1/g1HotCardCache.cpp ! src/hotspot/share/gc/g1/g1IHOPControl.cpp ! src/hotspot/share/gc/g1/g1MemoryPool.cpp ! src/hotspot/share/gc/g1/g1MonitoringSupport.cpp ! src/hotspot/share/gc/g1/g1OopClosures.hpp ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1RegionMarkStatsCache.cpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSetSummary.cpp ! src/hotspot/share/gc/g1/g1RootProcessor.cpp ! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionManager.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/g1/heapRegionSet.cpp ! src/hotspot/share/gc/g1/heapRegionSet.hpp ! src/hotspot/share/gc/g1/ptrQueue.cpp ! src/hotspot/share/gc/g1/ptrQueue.hpp ! src/hotspot/share/gc/g1/sparsePRT.cpp ! src/hotspot/share/gc/g1/survRateGroup.cpp ! src/hotspot/share/gc/g1/vm_operations_g1.cpp ! src/hotspot/share/gc/g1/vm_operations_g1.hpp ! src/hotspot/share/gc/parallel/adjoiningVirtualSpaces.cpp ! src/hotspot/share/gc/parallel/gcTaskManager.cpp ! src/hotspot/share/gc/parallel/mutableNUMASpace.hpp ! src/hotspot/share/gc/parallel/mutableSpace.cpp ! src/hotspot/share/gc/parallel/parMarkBitMap.inline.hpp ! src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.cpp ! src/hotspot/share/gc/shared/cardTable.cpp ! src/hotspot/share/gc/shared/collectorPolicy.cpp ! src/hotspot/share/gc/shared/gcTraceTime.inline.hpp ! src/hotspot/share/gc/shared/gcUtil.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/generation.cpp ! src/hotspot/share/gc/shared/generationCounters.hpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp ! src/hotspot/share/gc/shared/referenceProcessor.inline.hpp ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.cpp ! src/hotspot/share/gc/shared/space.hpp ! src/hotspot/share/gc/shared/space.inline.hpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp ! src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp ! src/hotspot/share/gc/shared/vmGCOperations.cpp ! src/hotspot/share/gc/shared/workerDataArray.inline.hpp ! src/hotspot/share/gc/shared/workgroup.cpp ! src/hotspot/share/gc/shared/workgroup.hpp ! src/hotspot/share/gc/z/zStat.cpp Changeset: f6641fcf7b7e Author: tschatzl Date: 2018-08-08 15:31 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f6641fcf7b7e 8208670: Compiler changes to allow enabling -Wreorder Reviewed-by: kvn ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/c1_CodeStubs_x86.cpp ! src/hotspot/cpu/x86/c1_LinearScan_x86.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/share/adlc/output_h.cpp ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/c1/c1_CodeStubs.hpp ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_IR.cpp ! src/hotspot/share/c1/c1_IR.hpp ! src/hotspot/share/c1/c1_Instruction.hpp ! src/hotspot/share/c1/c1_InstructionPrinter.hpp ! src/hotspot/share/c1/c1_LIR.cpp ! src/hotspot/share/c1/c1_LIR.hpp ! src/hotspot/share/c1/c1_LIRAssembler.cpp ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/c1/c1_Optimizer.cpp ! src/hotspot/share/c1/c1_ValueMap.cpp ! src/hotspot/share/c1/c1_ValueType.hpp ! src/hotspot/share/ci/bcEscapeAnalyzer.cpp ! src/hotspot/share/ci/ciMethod.cpp ! src/hotspot/share/ci/ciMethodBlocks.cpp ! src/hotspot/share/ci/ciTypeFlow.hpp ! src/hotspot/share/code/codeBlob.cpp ! src/hotspot/share/code/codeBlob.hpp ! src/hotspot/share/code/compiledIC.hpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/dependencies.hpp ! src/hotspot/share/code/dependencyContext.hpp ! src/hotspot/share/code/exceptionHandlerTable.hpp ! src/hotspot/share/code/oopRecorder.cpp ! src/hotspot/share/code/vtableStubs.hpp ! src/hotspot/share/compiler/abstractCompiler.hpp ! src/hotspot/share/compiler/compilerDirectives.cpp ! src/hotspot/share/compiler/methodLiveness.cpp ! src/hotspot/share/compiler/methodMatcher.cpp ! src/hotspot/share/compiler/oopMap.cpp ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/block.cpp ! src/hotspot/share/opto/block.hpp ! src/hotspot/share/opto/bytecodeInfo.cpp ! src/hotspot/share/opto/callGenerator.cpp ! src/hotspot/share/opto/callnode.cpp ! src/hotspot/share/opto/callnode.hpp ! src/hotspot/share/opto/chaitin.cpp ! src/hotspot/share/opto/chaitin.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/escape.hpp ! src/hotspot/share/opto/idealKit.cpp ! src/hotspot/share/opto/live.cpp ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/machnode.hpp ! src/hotspot/share/opto/matcher.cpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/memnode.hpp ! src/hotspot/share/opto/opaquenode.hpp ! src/hotspot/share/opto/output.cpp ! src/hotspot/share/opto/phaseX.cpp ! src/hotspot/share/opto/regalloc.cpp ! src/hotspot/share/opto/runtime.hpp ! src/hotspot/share/opto/stringopts.cpp ! src/hotspot/share/opto/subnode.hpp ! src/hotspot/share/opto/superword.cpp ! src/hotspot/share/opto/type.hpp Changeset: cc2c79d22508 Author: tschatzl Date: 2018-08-08 15:31 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cc2c79d22508 8208671: Runtime, JFR, Serviceability changes to allow enabling -Wreorder Reviewed-by: dholmes, hseigel ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/classLoaderData.hpp ! src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp ! src/hotspot/share/classfile/classLoaderStats.hpp ! src/hotspot/share/classfile/defaultMethods.cpp ! src/hotspot/share/classfile/dictionary.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/stackMapFrame.cpp ! src/hotspot/share/classfile/stackMapFrame.hpp ! src/hotspot/share/classfile/stringTable.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/jfr/dcmd/jfrDcmds.cpp ! src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp ! src/hotspot/share/jfr/leakprofiler/sampling/sampleList.cpp ! src/hotspot/share/jfr/periodic/sampling/jfrCallTrace.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetUtils.cpp ! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp ! src/hotspot/share/jfr/recorder/stacktrace/jfrStackTraceRepository.hpp ! src/hotspot/share/libadt/dict.cpp ! src/hotspot/share/logging/logFileOutput.cpp ! src/hotspot/share/logging/logMessageBuffer.hpp ! src/hotspot/share/memory/heapInspection.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace/metachunk.cpp ! src/hotspot/share/memory/metaspace/metaspaceDCmd.cpp ! src/hotspot/share/memory/metaspace/printCLDMetaspaceInfoClosure.cpp ! src/hotspot/share/memory/metaspace/spaceManager.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp ! src/hotspot/share/memory/virtualspace.cpp ! src/hotspot/share/oops/constantPool.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/methodData.hpp ! src/hotspot/share/prims/jvmtiGetLoadedClasses.cpp ! src/hotspot/share/prims/jvmtiImpl.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/perfData.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/vm_operations.hpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/heapDumper.hpp ! src/hotspot/share/services/mallocSiteTable.hpp ! src/hotspot/share/services/memBaseline.hpp ! src/hotspot/share/services/threadService.cpp ! src/hotspot/share/services/threadService.hpp ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp ! src/hotspot/share/utilities/concurrentHashTableTasks.inline.hpp ! src/hotspot/share/utilities/elfFile.cpp ! src/hotspot/share/utilities/elfFuncDescTable.cpp ! src/hotspot/share/utilities/elfStringTable.cpp ! src/hotspot/share/utilities/elfSymbolTable.cpp ! src/hotspot/share/utilities/events.hpp ! src/hotspot/share/utilities/json.cpp ! src/hotspot/share/utilities/numberSeq.cpp ! src/hotspot/share/utilities/stack.inline.hpp ! test/hotspot/gtest/logging/logTestFixture.cpp ! test/hotspot/gtest/utilities/test_concurrentHashtable.cpp Changeset: 3965b3332610 Author: tschatzl Date: 2018-08-08 15:31 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3965b3332610 8208672: Enable -Wreorder in make files for gcc, clang Reviewed-by: dholmes, ihse ! make/autoconf/flags-cflags.m4 Changeset: d8cd1a8ae50f Author: bpb Date: 2018-08-08 09:25 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d8cd1a8ae50f 8193822: Remove unused newDirectByteBuffer and truncate methods from buffer classes Reviewed-by: alanb, psandoz ! src/java.base/share/classes/java/nio/Buffer.java ! src/java.base/share/classes/jdk/internal/misc/JavaNioAccess.java Changeset: 0bcb90968b3c Author: dcubed Date: 2018-08-08 15:11 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0bcb90968b3c 8209149: [TESTBUG] runtime/RedefineTests/RedefineRunningMethods.java needs a longer timeout Reviewed-by: coleenp ! test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java Changeset: aa3bfacc912c Author: coleenp Date: 2018-08-08 15:24 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/aa3bfacc912c 8208677: Move inner metaspace cleaning out of class unloading Summary: move to safepoint cleanup actions to do if needed. Reviewed-by: eosterlund, hseigel ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/classLoaderData.hpp ! src/hotspot/share/classfile/classLoaderData.inline.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/runtime/safepoint.cpp ! test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java Changeset: 554bb4e2d10d Author: mchung Date: 2018-08-08 14:40 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/554bb4e2d10d 8202941: GenModuleInfoSource build tool does not detect missing semicolons Reviewed-by: erikj ! make/gensrc/Gensrc-jdk.internal.vm.compiler.gmk ! make/jdk/src/classes/build/tools/module/GenModuleInfoSource.java ! make/jdk/src/classes/build/tools/module/ModuleInfoExtraTest.java ! src/java.base/share/classes/module-info.java Changeset: 818768cd1c6c Author: jcbeyler Date: 2018-08-08 15:34 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/818768cd1c6c 8208303: Track JNI failures and fail tests Summary: Fail in native code via FatalException to signal test failure Reviewed-by: amenkov, sspitsyn ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c Changeset: 09cc8813ae51 Author: kvn Date: 2018-08-08 18:38 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/09cc8813ae51 8207965: C2-only debug build fails Reviewed-by: kvn, iignatyev Contributed-by: xxinliu at amazon.com ! make/hotspot/src/native/dtrace/generateJvmOffsets.cpp ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/aot/aotCompiledMethod.cpp ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/compiler/compilerDirectives.cpp ! src/hotspot/share/gc/z/zBarrierSet.cpp ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java ! test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWait.java + test/hotspot/jtreg/compiler/onSpinWait/TestOnSpinWaitC1.java ! test/hotspot/jtreg/compiler/runtime/Test6859338.java ! test/hotspot/jtreg/compiler/types/TestMeetIncompatibleInterfaceArrays.java ! test/hotspot/jtreg/compiler/whitebox/BlockingCompilation.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java ! test/hotspot/jtreg/vmTestbase/jit/tiered/tieredTest.sh ! test/jdk/TEST.ROOT ! test/jtreg-ext/requires/VMProps.java Changeset: 2b3b7db9b889 Author: xiaofeya Date: 2018-08-09 15:42 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2b3b7db9b889 8208656: Move java/util/Calendar/CalendarTestScripts tests into OpenJDK Reviewed-by: naoto + test/jdk/java/util/Calendar/CalendarTestScripts/CalendarAdapter.java + test/jdk/java/util/Calendar/CalendarTestScripts/CalendarTestEngine.java + test/jdk/java/util/Calendar/CalendarTestScripts/CalendarTestException.java + test/jdk/java/util/Calendar/CalendarTestScripts/Exceptions.java + test/jdk/java/util/Calendar/CalendarTestScripts/GregorianAdapter.java + test/jdk/java/util/Calendar/CalendarTestScripts/JapaneseRollDayOfWeekTestGenerator.java + test/jdk/java/util/Calendar/CalendarTestScripts/JapaneseRollTests.java + test/jdk/java/util/Calendar/CalendarTestScripts/JapaneseTests.java + test/jdk/java/util/Calendar/CalendarTestScripts/README + test/jdk/java/util/Calendar/CalendarTestScripts/Result.java + test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java + test/jdk/java/util/Calendar/CalendarTestScripts/Variable.java + test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese.cts + test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_add.cts + test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_exceptions.cts + test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_minmax.cts + test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_normalization.cts + test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_roll.cts + test/jdk/java/util/Calendar/CalendarTestScripts/params/lenient.cts + test/jdk/java/util/Calendar/CalendarTestScripts/params/non-lenient.cts + test/jdk/java/util/Calendar/CalendarTestScripts/timezones/tz_japan.cts + test/jdk/java/util/Calendar/CalendarTestScripts/timezones/tz_novosibirsk.cts + test/jdk/java/util/Calendar/CalendarTestScripts/timezones/tz_pst.cts + test/jdk/java/util/Calendar/CalendarTestScripts/timezones/tz_sydney.cts Changeset: da5b0111c93c Author: pliden Date: 2018-08-09 11:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/da5b0111c93c 8207756: ZGC: jstat should show CGC STW phases Reviewed-by: pliden, ysuenaga, eosterlund Contributed-by: yasuenag at gmail.com, per.liden at oracle.com ! src/hotspot/share/gc/shared/vmGCOperations.hpp ! src/hotspot/share/gc/z/zDriver.cpp ! src/hotspot/share/gc/z/zServiceability.cpp ! src/hotspot/share/gc/z/zServiceability.hpp Changeset: 7504e7937183 Author: pliden Date: 2018-08-09 11:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7504e7937183 8209125: ZGC: Clean up ZServiceabilityCounters Reviewed-by: eosterlund, tschatzl ! src/hotspot/share/gc/z/zServiceability.cpp Changeset: 31b0e90ddbf0 Author: pliden Date: 2018-08-09 11:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/31b0e90ddbf0 8209126: ZGC: ZMarkStackAllocator::is_initialized() never called Reviewed-by: eosterlund, tschatzl ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/gc/z/zMark.hpp Changeset: d98f2adf09c9 Author: pliden Date: 2018-08-09 11:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d98f2adf09c9 8209127: ZGC: Improve error message when failing to map memory for mark stacks Reviewed-by: eosterlund, tschatzl ! src/hotspot/share/gc/z/zMarkStack.cpp ! src/hotspot/share/gc/z/zMarkStack.hpp Changeset: 54dd2b86a543 Author: jcbeyler Date: 2018-08-08 11:11 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/54dd2b86a543 8208242: Add @requires to vmTestbase/gc/g1 tests Summary: Added classunloading must not be disabled and G1 is required to g1/unloading tests Reviewed-by: kbarrett, tschatzl ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_anonclassloader_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_anonclassloader_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_anonclassloader_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_anonclassloader_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level1_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level2_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level3_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_compilation_level4_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_humongous_class_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_jni_classloading_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_global_ref_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_jni_local_ref_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_stackLocal_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_staticField_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_strongRef_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_keepRef_threadItself_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_phantom_ref_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_prot_domains_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_redefinition_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_reflection_classloading_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_inMemoryCompilation_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_inMemoryCompilation_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_inMemoryCompilation_keep_obj/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_keep_cl/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_keep_class/TestDescription.java ! test/hotspot/jtreg/vmTestbase/gc/g1/unloading/tests/unloading_weak_ref_keep_obj/TestDescription.java Changeset: 3d4292720da3 Author: mikael Date: 2018-08-09 08:02 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3d4292720da3 Added tag jdk-12+6 for changeset 7939b3c4e408 ! .hgtags Changeset: 343f580476d6 Author: rkennke Date: 2018-08-09 17:11 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/343f580476d6 8204969: Asserts in objArrayKlass.cpp need to use _raw variants of obj_addr_at() Reviewed-by: tschatzl, eosterlund ! src/hotspot/share/oops/objArrayKlass.cpp Changeset: 57565f7dcb2a Author: rkennke Date: 2018-06-22 16:07 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/57565f7dcb2a 8205523: Explicit barriers for interpreter Reviewed-by: eosterlund, coleenp ! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/share/oops/accessDecorators.hpp Changeset: 2bb9b1abadbf Author: iignatyev Date: 2018-08-03 15:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2bb9b1abadbf 8199081: [Testbug] compiler/linkage/LinkageErrors.java fails if run twice Reviewed-by: kvn, vlivanov ! test/hotspot/jtreg/compiler/linkage/CallSites.jasm ! test/hotspot/jtreg/compiler/linkage/LinkageErrors.java Changeset: f646ca47e561 Author: thartmann Date: 2018-08-06 09:09 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f646ca47e561 8207355: C1 compilation hangs in ComputeLinearScanOrder::compute_dominator Summary: Bail out from recursive computation if the block was already processed. Reviewed-by: kvn, iveresov ! src/hotspot/share/c1/c1_IR.cpp + test/hotspot/jtreg/compiler/c1/TestLinearScanOrder.jasm + test/hotspot/jtreg/compiler/c1/TestLinearScanOrderMain.java Changeset: f3e15dcdc333 Author: ssahoo Date: 2018-08-06 00:46 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f3e15dcdc333 8208496: New Test to verify concurrent behavior of TLS. Summary: Verify TLS behavior with multiple threads accessing concurrently. Reviewed-by: xuelei + test/jdk/javax/net/ssl/TLSCommon/ConcurrentClientAccessTest.java Changeset: 3cc181307917 Author: dcubed Date: 2018-08-06 20:44 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3cc181307917 8209029: ProblemList tests that fail due to 'Error attaching to process: Can't create thread_db agent!' in jdk-11+25 testing Reviewed-by: dholmes, sspitsyn ! test/hotspot/jtreg/ProblemList.txt Changeset: 9fb336cee537 Author: dbuck Date: 2018-08-06 22:30 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9fb336cee537 8204966: [TESTBUG] hotspot/test/compiler/whitebox/IsMethodCompilableTest.java test fails with -XX:CompileThreshold=1 Summary: enforce lower bound on number of loop iterations used to trigger OSR Reviewed-by: kvn, iignatyev ! test/hotspot/jtreg/compiler/whitebox/CompilerWhiteBoxTest.java Changeset: 88d9be7f52c5 Author: mullan Date: 2018-08-07 10:29 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/88d9be7f52c5 8208691: Tighten up jdk.includeInExceptions security property Summary: Add stronger warning on usage and add test to check that property is not set Reviewed-by: alanb, rriggs ! src/java.base/share/conf/security/java.security ! test/jdk/java/net/Socket/ExceptionText.java Changeset: f689461b1684 Author: iignatyev Date: 2018-08-07 13:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f689461b1684 8031761: [TESTBUG] Add a regression test for JDK-8026328 Reviewed-by: kvn, iignatyev Contributed-by: staffan.larsen at oracle.com + test/hotspot/jtreg/compiler/jsr292/cr8026328/Test8026328.java + test/hotspot/jtreg/compiler/jsr292/cr8026328/libTest8026328.c Changeset: 2dddf65a7f87 Author: iris Date: 2018-08-07 17:40 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2dddf65a7f87 8201394: Update java.se module summary to reflect removal of java.se.ee module Reviewed-by: alanb, lancea, mchung ! src/java.se/share/classes/module-info.java Changeset: 945ba9278a27 Author: ljiang Date: 2018-08-07 00:06 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/945ba9278a27 8208663: JDK 11 L10n resource file update msg drop 20 Reviewed-by: naoto ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard_ja.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard_zh_CN.properties Changeset: d2c720caa480 Author: rwestberg Date: 2018-08-06 14:56 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d2c720caa480 8208676: Missing NULL check and resource leak in NetworkPerformanceInterface::NetworkPerformance::network_utilization Reviewed-by: mgronlun, rehn ! src/hotspot/os/linux/os_perf_linux.cpp ! src/hotspot/os/solaris/os_perf_solaris.cpp Changeset: 2afc9aa349ed Author: yzhang Date: 2018-08-08 13:45 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2afc9aa349ed 8209011: [TESTBUG] AArch64: sun/security/pkcs11/Secmod/TestNssDbSqlite.java fails in aarch64 platforms Summary: Add the path of libnss3.so for aarch64 platform. Reviewed-by: weijun ! test/jdk/sun/security/pkcs11/PKCS11Test.java Changeset: 72d0f57cef00 Author: dcubed Date: 2018-08-08 15:11 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/72d0f57cef00 8209149: [TESTBUG] runtime/RedefineTests/RedefineRunningMethods.java needs a longer timeout Reviewed-by: coleenp ! test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java Changeset: a6fa2016cff1 Author: serb Date: 2018-08-08 15:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a6fa2016cff1 8189667: Desktop#moveToTrash expects incorrect "<>" FilePermission Reviewed-by: prr, sveerabhadra ! src/java.desktop/share/classes/java/awt/Desktop.java Changeset: 31d9e82b2e64 Author: chegar Date: 2018-08-09 11:23 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/31d9e82b2e64 8208391: Differentiate response and connect timeouts in HTTP Client API Reviewed-by: michaelm ! src/java.net.http/share/classes/java/net/http/HttpClient.java + src/java.net.http/share/classes/java/net/http/HttpConnectTimeoutException.java ! src/java.net.http/share/classes/jdk/internal/net/http/AbstractAsyncSSLConnection.java ! src/java.net.http/share/classes/jdk/internal/net/http/AsyncSSLConnection.java ! src/java.net.http/share/classes/jdk/internal/net/http/AsyncSSLTunnelConnection.java ! src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http1Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2ClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpClientBuilderImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpClientFacade.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java ! src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/PlainHttpConnection.java ! src/java.net.http/share/classes/jdk/internal/net/http/PlainTunnelingConnection.java + src/java.net.http/share/classes/jdk/internal/net/http/ResponseTimerEvent.java ! src/java.net.http/share/classes/jdk/internal/net/http/TimeoutEvent.java + test/jdk/java/net/httpclient/AbstractConnectTimeout.java + test/jdk/java/net/httpclient/AbstractConnectTimeoutHandshake.java + test/jdk/java/net/httpclient/ConnectTimeoutHandshakeAsync.java + test/jdk/java/net/httpclient/ConnectTimeoutHandshakeSync.java + test/jdk/java/net/httpclient/ConnectTimeoutNoProxyAsync.java + test/jdk/java/net/httpclient/ConnectTimeoutNoProxySync.java + test/jdk/java/net/httpclient/ConnectTimeoutWithProxyAsync.java + test/jdk/java/net/httpclient/ConnectTimeoutWithProxySync.java ! test/jdk/java/net/httpclient/HttpClientBuilderTest.java ! test/jdk/java/net/httpclient/TimeoutBasic.java ! test/jdk/java/net/httpclient/examples/JavadocExamples.java ! test/jdk/java/net/httpclient/offline/DelegatingHttpClient.java ! test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/ConnectionPoolTest.java Changeset: 1ba7c83cd8a6 Author: mikael Date: 2018-08-09 07:58 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1ba7c83cd8a6 Added tag jdk-11+26 for changeset 945ba9278a27 ! .hgtags Changeset: 292a9d391a20 Author: mikael Date: 2018-08-09 10:08 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/292a9d391a20 Merge ! .hgtags ! src/hotspot/os/linux/os_perf_linux.cpp ! src/hotspot/os/solaris/os_perf_solaris.cpp ! src/hotspot/share/c1/c1_IR.cpp ! test/hotspot/jtreg/ProblemList.txt Changeset: d9439d4b15e2 Author: epavlova Date: 2018-08-09 11:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d9439d4b15e2 8205078: [Graal] org.graalvm.compiler.core.test.VerifyDebugUsageTest fails with "Expected exception: VerificationError" Reviewed-by: kvn, dnsimon ! make/test/JtregGraalUnit.gmk ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: adcb0bb3d1e9 Author: rkennke Date: 2018-08-09 22:51 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/adcb0bb3d1e9 8209118: Abstract SATBMarkQueueSet's ThreadLocalData access Reviewed-by: kbarrett, shade ! src/hotspot/cpu/ppc/gc/g1/g1BarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp ! src/hotspot/cpu/sparc/gc/g1/g1BarrierSetAssembler_sparc.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp + src/hotspot/share/gc/g1/g1SATBMarkQueueSet.cpp + src/hotspot/share/gc/g1/g1SATBMarkQueueSet.hpp ! src/hotspot/share/gc/g1/satbMarkQueue.cpp ! src/hotspot/share/gc/g1/satbMarkQueue.hpp Changeset: f32e61253792 Author: redestad Date: 2018-08-10 00:20 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f32e61253792 8209186: Rename SimpleThresholdPolicy to TieredThresholdPolicy Reviewed-by: thartmann, pliden, kvn ! src/hotspot/share/runtime/compilationPolicy.cpp - src/hotspot/share/runtime/simpleThresholdPolicy.cpp - src/hotspot/share/runtime/simpleThresholdPolicy.hpp - src/hotspot/share/runtime/simpleThresholdPolicy.inline.hpp + src/hotspot/share/runtime/tieredThresholdPolicy.cpp + src/hotspot/share/runtime/tieredThresholdPolicy.hpp Changeset: fbb62267e5e9 Author: ccheung Date: 2018-08-09 15:52 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fbb62267e5e9 8208705: [TESTBUG] The -Xlog:cds,cds+hashtables vm option is not always required for appcds tests Summary: only include the CDS logging option in the tests which require it Reviewed-by: mseledtsov, jiangli, iklam ! test/hotspot/jtreg/runtime/appcds/ExtraSymbols.java ! test/hotspot/jtreg/runtime/appcds/TestCommon.java ! test/hotspot/jtreg/runtime/appcds/VerifierTest.java ! test/hotspot/jtreg/runtime/appcds/customLoader/ClassListFormatBase.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/ExerciseGC.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/FlagCombo.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/InternSharedString.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/LargePages.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/LockSharedStrings.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsBasicPlus.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/SharedStringsWbTest.java Changeset: 3ab8b84e93cd Author: jiangli Date: 2018-08-10 00:35 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3ab8b84e93cd 8207263: Store the Configuration for system modules into CDS archive. Summary: Archive boot layer Configuration. Reviewed-by: redestad, iklam, ccheung ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/memory/heapShared.cpp ! src/hotspot/share/memory/metaspaceShared.cpp ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/util/ImmutableCollections.java ! src/java.base/share/classes/jdk/internal/module/ArchivedModuleGraph.java ! src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java ! test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleComboTest.java ! test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedModuleWithCustomImageTest.java ! test/hotspot/jtreg/runtime/appcds/cacheObject/CheckArchivedModuleApp.java Changeset: 4737d92d752f Author: xyin Date: 2018-08-10 13:07 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4737d92d752f 8208483: Add 5 JNDI tests to com/sun/jndi/dns/FactoryTests/ Reviewed-by: vtewari, rriggs + test/jdk/com/sun/jndi/dns/FactoryTests/DirAFactory.java + test/jdk/com/sun/jndi/dns/FactoryTests/DirTxtFactory.java + test/jdk/com/sun/jndi/dns/FactoryTests/GetAttrsWithFactory.dns + test/jdk/com/sun/jndi/dns/FactoryTests/GetAttrsWithFactory.java + test/jdk/com/sun/jndi/dns/FactoryTests/LookupFactoryBase.java + test/jdk/com/sun/jndi/dns/FactoryTests/LookupWithAnyAttrProp.dns + test/jdk/com/sun/jndi/dns/FactoryTests/LookupWithAnyAttrProp.java + test/jdk/com/sun/jndi/dns/FactoryTests/LookupWithAttrProp.dns + test/jdk/com/sun/jndi/dns/FactoryTests/LookupWithAttrProp.java + test/jdk/com/sun/jndi/dns/FactoryTests/LookupWithDirFactory.dns + test/jdk/com/sun/jndi/dns/FactoryTests/LookupWithDirFactory.java + test/jdk/com/sun/jndi/dns/FactoryTests/LookupWithFactory.dns + test/jdk/com/sun/jndi/dns/FactoryTests/LookupWithFactory.java + test/jdk/com/sun/jndi/dns/FactoryTests/TestDnsObject.java + test/jdk/com/sun/jndi/dns/FactoryTests/TxtFactory.java Changeset: 514035618c1d Author: weijun Date: 2018-08-10 17:07 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/514035618c1d 8201290: keytool importcert fails with CertificateParsingException if unknown certificate algorithms should be imported Reviewed-by: mullan, xuelei ! src/java.base/share/classes/sun/security/tools/keytool/Main.java Changeset: 7be0084191ed Author: bulasevich Date: 2018-08-10 14:22 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7be0084191ed 8206895: aarch64: rework error-prone cmp instuction Reviewed-by: aph ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp ! src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64_log.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64_trig.cpp ! src/hotspot/cpu/aarch64/methodHandles_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp Changeset: b812a85b3aa4 Author: hseigel Date: 2018-08-10 09:30 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b812a85b3aa4 8207778: Add locking to ModuleEntry and PackageEntry tables Summary: Restructure ClassLoaderDataGraph code to simplify using locks in SystemDictionary::do_unloading() Reviewed-by: lfoltan, coleenp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/classLoaderData.hpp ! src/hotspot/share/classfile/loaderConstraints.cpp ! src/hotspot/share/classfile/moduleEntry.cpp ! src/hotspot/share/classfile/packageEntry.cpp ! src/hotspot/share/classfile/resolutionErrors.cpp ! src/hotspot/share/classfile/systemDictionary.cpp Changeset: 181e6a03249b Author: coleenp Date: 2018-08-10 09:36 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/181e6a03249b 8164683: Solaris: JVM abuses thread preemption control Summary: Complete removal of preemption control and command line arguments (were deprecated in 11). Reviewed-by: hseigel, pchilanomate, dholmes ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/objectMonitor.cpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmThread.cpp Changeset: f23aeb97ae17 Author: bchristi Date: 2018-08-10 12:05 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f23aeb97ae17 8205399: Set node color on pinned HashMap.TreeNode deletion Reviewed-by: martin ! src/java.base/share/classes/java/util/HashMap.java + test/jdk/java/util/HashMap/TreeBinAssert.java Changeset: 5db166e5580b Author: coleenp Date: 2018-08-10 22:38 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5db166e5580b 8209384: ProblemList stressHierarchy metaspace tests Summary: These try to trigger GC by filling metaspace which seems to be not working. Reviewed-by: jiangli ! test/hotspot/jtreg/ProblemList.txt Changeset: 802f7e5e7e6b Author: coleenp Date: 2018-08-11 12:49 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/802f7e5e7e6b 8207924: serviceability/sa/TestUniverse.java#id0 intermittently fails with assert(get_instanceKlass()->is_loaded()) failed: must be at least loaded Summary: InstanceKlass::implementors() needs the Compile_lock Reviewed-by: thartmann, eosterlund ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp Changeset: e081161320e4 Author: shade Date: 2018-08-13 10:28 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e081161320e4 8209378: Fix Minimal VM after JDK-8208677 Reviewed-by: coleenp, shade Contributed-by: Aleksei Voitylov ! src/hotspot/share/classfile/classLoaderData.inline.hpp Changeset: e354938b4073 Author: avoitylov Date: 2018-08-13 12:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e354938b4073 8209380: ARM: cleanup maybe-uninitialized and reorder compiler warnings Reviewed-by: dholmes, drwhite, tschatzl ! src/hotspot/cpu/arm/assembler_arm_32.hpp ! src/hotspot/cpu/arm/c1_CodeStubs_arm.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp Changeset: 0038e99f93bc Author: ghaug Date: 2018-08-13 12:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0038e99f93bc 8209357: [PPC64] Fix build which was broken by 8208672 (Enable -Wreorder) Reviewed-by: mbaesken, tschatzl ! src/hotspot/cpu/ppc/c1_CodeStubs_ppc.cpp ! src/hotspot/cpu/ppc/frame_ppc.hpp ! src/hotspot/cpu/ppc/frame_ppc.inline.hpp Changeset: 2f58537e1bc0 Author: tschatzl Date: 2018-08-13 12:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2f58537e1bc0 8209193: Fix aarch64-linux compilation after -Wreorder changes Reviewed-by: shade, drwhite ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/aarch64/c1_CodeStubs_aarch64.cpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp Changeset: 677e21d875ae Author: tschatzl Date: 2018-08-13 12:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/677e21d875ae 8205633: TestOptionsWithRanges.java of '-XX:TLABSize=2147483648' fails intermittently Summary: Exclude maximum range value from testing. Reviewed-by: sangheki, kbarrett ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java Changeset: be775229d3b3 Author: tschatzl Date: 2018-08-13 12:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/be775229d3b3 8200365: TestOptionsWithRanges.java of '-XX:TLABWasteTargetPercent=100' fails intermittently Summary: For initial TLAB sizing, increase the number of expected refills to 2. Reviewed-by: phh, sangheki ! src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp Changeset: aed534740851 Author: epavlova Date: 2018-08-13 04:02 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/aed534740851 8199486: [Graal] gc/g1/ihop/TestIHOPStatic.java fails by timeout with -Xcomp Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/gc/g1/ihop/TestIHOPStatic.java Changeset: 9fe4fc157f4e Author: mbaesken Date: 2018-08-10 09:16 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9fe4fc157f4e 8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update Reviewed-by: prr, dholmes ! make/lib/Awt2dLibraries.gmk ! src/java.desktop/share/native/libsplashscreen/libpng/pngpriv.h Changeset: 0dcd27526967 Author: redestad Date: 2018-08-13 19:21 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0dcd27526967 8209120: Archive the Integer.IntegerCache Reviewed-by: jiangli, alanb, plevart, iklam, mchung ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/memory/heapShared.cpp ! src/java.base/share/classes/java/lang/Integer.java + test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedIntegerCacheTest.java + test/hotspot/jtreg/runtime/appcds/cacheObject/CheckIntegerCacheApp.java Changeset: ae001a1deb74 Author: kvn Date: 2018-08-13 13:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ae001a1deb74 8207153: Some intrinsic tests take long time to run Reviewed-by: thartmann, mikael ! test/hotspot/jtreg/compiler/codegen/aes/TestAESMain.java ! test/hotspot/jtreg/compiler/intrinsics/base64/TestBase64.java ! test/lib/sun/hotspot/code/Compiler.java Changeset: 135285dfc551 Author: kbarrett Date: 2018-08-13 18:21 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/135285dfc551 8209396: Make PtrQueueSets not statically allocated Summary: Change the G1BarrierSet PtrQueueSet static members to ordinary members. Reviewed-by: shade, tschatzl, rkennke ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp Changeset: 07ea887eee5f Author: iignatyev Date: 2018-08-13 17:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/07ea887eee5f 8209382: [error-prone] HashtableContains in sun/rmi/server/ActivationGroupImpl.java Reviewed-by: rriggs ! src/java.rmi/share/classes/sun/rmi/server/ActivationGroupImpl.java Changeset: 523f58763da6 Author: xiaofeya Date: 2018-08-14 10:42 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/523f58763da6 8194230: jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java fails with java.lang.NullPointerException Reviewed-by: mchung ! test/jdk/jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java Changeset: cc8d309cd05a Author: kbarrett Date: 2018-08-14 00:15 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cc8d309cd05a 8209345: Merge SATBMarkQueueFilter into SATBMarkQueueSet Summary: Move filter extension protocol to SATBMarkQueueSet. Reviewed-by: shade, tschatzl, rkennke ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp - src/hotspot/share/gc/g1/g1SATBMarkQueueFilter.cpp - src/hotspot/share/gc/g1/g1SATBMarkQueueFilter.hpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.cpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.hpp ! src/hotspot/share/gc/g1/satbMarkQueue.cpp ! src/hotspot/share/gc/g1/satbMarkQueue.hpp Changeset: 8ed5f86b15aa Author: pliden Date: 2018-08-13 14:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8ed5f86b15aa 8209375: ZGC: Use dynamic base address for mark stack space Reviewed-by: eosterlund, kbarrett ! src/hotspot/share/gc/z/zGlobals.hpp ! src/hotspot/share/gc/z/zMarkStack.cpp ! src/hotspot/share/gc/z/zMarkStack.hpp ! src/hotspot/share/gc/z/z_globals.hpp Changeset: f3cf91d5373f Author: pliden Date: 2018-08-13 14:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f3cf91d5373f 8209376: ZGC: Move ZMarkStackAllocator into a separate file Reviewed-by: eosterlund, kbarrett ! src/hotspot/share/gc/z/zMark.hpp ! src/hotspot/share/gc/z/zMarkStack.cpp ! src/hotspot/share/gc/z/zMarkStack.hpp + src/hotspot/share/gc/z/zMarkStackAllocator.cpp + src/hotspot/share/gc/z/zMarkStackAllocator.hpp Changeset: 38ec0cea438e Author: jcbeyler Date: 2018-08-13 09:19 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/38ec0cea438e 8061467: Add UseLargePages to TestNUMAPageSize Summary: Add flag to test for all architectures to be tested Reviewed-by: phh, pliden, tschatzl ! test/hotspot/jtreg/gc/TestNUMAPageSize.java Changeset: c9150700bbd0 Author: lucy Date: 2018-08-14 14:28 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c9150700bbd0 8209433: [s390] Fix build, broken by 8208672 (Enable -Wreorder) Reviewed-by: tschatzl, shade ! src/hotspot/cpu/s390/c1_CodeStubs_s390.cpp ! src/hotspot/cpu/s390/frame_s390.hpp ! src/hotspot/cpu/s390/frame_s390.inline.hpp Changeset: 3c389a284345 Author: weijun Date: 2018-08-14 22:39 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3c389a284345 8209416: Refactoring GetPropertyAction calls in security libs Reviewed-by: xuelei, rriggs ! src/java.base/share/classes/com/sun/security/ntlm/NTLM.java ! src/java.base/share/classes/sun/security/action/GetBooleanAction.java ! src/java.base/share/classes/sun/security/internal/spec/TlsRsaPremasterSecretParameterSpec.java ! src/java.base/share/classes/sun/security/provider/certpath/Builder.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionContextImpl.java ! src/java.base/share/classes/sun/security/ssl/StatusResponseManager.java ! src/java.base/share/classes/sun/security/ssl/SupportedGroupsExtension.java ! src/java.base/share/classes/sun/security/validator/PKIXValidator.java ! src/java.base/share/classes/sun/security/x509/AVA.java ! src/java.security.jgss/share/classes/sun/net/www/protocol/http/spnego/NegotiatorImpl.java ! src/java.security.jgss/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/java.security.jgss/share/classes/sun/security/jgss/GSSUtil.java ! src/java.security.jgss/share/classes/sun/security/jgss/ProviderList.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/AcceptSecContextToken.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5Util.java ! src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! src/java.security.jgss/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/java.security.jgss/share/classes/sun/security/krb5/Config.java ! src/java.security.jgss/share/classes/sun/security/krb5/Credentials.java ! src/java.security.jgss/share/classes/sun/security/krb5/KdcComm.java ! src/java.security.jgss/share/classes/sun/security/krb5/Realm.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/Krb5.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ReplayCache.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/Des.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/rcache/AuthTimeWithHash.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/rcache/DflCache.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/util/KerberosString.java Changeset: 3b1ec9d9da43 Author: akolarkunnu Date: 2018-08-13 21:57 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3b1ec9d9da43 8209418: Synchronize test/jdk/sanity/client/lib/jemmy with code-tools/jemmy/v2 Reviewed-by: serb Contributed-by: abdul.kolarkunnu at oracle.com, alexandre.iline at oracle.com ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Action.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/ActionProducer.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Bundle.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/BundleManager.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/CharBindingMap.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/ClassReference.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/ComponentChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/ComponentIsNotFocusedException.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/ComponentIsNotVisibleException.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/ComponentSearcher.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/DefaultCharBindingMap.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/DialogWaiter.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/EventDispatcher.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/EventTool.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/FrameWaiter.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/JemmyException.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/JemmyInputException.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/JemmyProperties.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/NoComponentUnderMouseException.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/ObjectBrowser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Outputable.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/QueueTool.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Scenario.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Test.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/TestCompletedException.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/TestOut.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Timeout.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/TimeoutExpiredException.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Timeoutable.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Timeouts.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Waitable.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/Waiter.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/WindowWaiter.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/accessibility/AccessibilityChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/accessibility/AccessibleDescriptionChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/accessibility/AccessibleNameChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/APIDriverInstaller.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/ArrayDriverInstaller.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/ButtonDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/DefaultDriverInstaller.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/DescriptablePathChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/Driver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/DriverInstaller.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/DriverManager.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/EditorDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/FocusDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/FrameDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/InputDriverInstaller.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/InternalFrameDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/KeyDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/LightDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/LightSupportiveDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/ListDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/MenuDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/MouseDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/MultiSelListDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/OrderedListDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/PathChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/ScrollDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/SupportiveDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/TableDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/TextDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/TreeDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/UnsupportedOperatorException.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/WindowDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/buttons/ButtonMouseDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/buttons/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/focus/APIFocusDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/focus/MouseFocusDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/focus/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/input/EventDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/input/KeyEventDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/input/KeyRobotDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/input/MouseEventDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/input/MouseRobotDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/input/RobotDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/input/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/ChoiceDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/JComboMouseDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/JListMouseDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/JTabAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/JTabMouseDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/JTableHeaderDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/ListAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/ListKeyboardDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/lists/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/menus/APIJMenuDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/menus/AppleMenuDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/menus/DefaultJMenuDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/menus/QueueJMenuDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/menus/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/AWTScrollDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/AbstractScrollDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/JScrollBarAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/JScrollBarDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/JSliderAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/JSliderDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/JSpinnerDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/JSplitPaneDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/KeyboardJSliderScrollDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/ScrollAdjuster.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/ScrollPaneDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/ScrollbarDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/scrolling/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/tables/JTableMouseDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/tables/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/AWTTextAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/AWTTextKeyboardDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/DownKey.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/EndKey.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/GoAndBackKey.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/HomeKey.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/NavigationKey.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/OffsetKey.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/SwingTextAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/SwingTextKeyboardDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/TextAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/TextKeyboardDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/UpKey.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/text/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/trees/JTreeAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/trees/JTreeMouseDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/trees/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/windows/DefaultFrameDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/windows/DefaultInternalFrameDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/windows/DefaultWindowDriver.java + test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/windows/InternalFrameAPIDriver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/windows/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/explorer/GUIBrowser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/explorer/TrialListenerManager.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/explorer/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/ColorImageComparator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/FileImageComparator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/ImageComparator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/ImageFinder.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/ImageLoader.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/ImageSaver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/ImageTool.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/PNGImageLoader.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/PNGImageSaver.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/RoughImageComparator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/RoughImageFinder.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/StrictImageComparator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/StrictImageFinder.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/image/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/AbstractButtonOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/ButtonOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/CheckboxOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/ChoiceOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/ComponentOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/ContainerOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/DialogOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/FrameOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JButtonOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JCheckBoxMenuItemOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JCheckBoxOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JColorChooserOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JComboBoxOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JComponentOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JDialogOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JEditorPaneOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JFileChooserOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JFrameOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JInternalFrameOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JLabelOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JListOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JMenuBarOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JMenuItemOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JMenuOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JPasswordFieldOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JPopupMenuOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JProgressBarOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JRadioButtonMenuItemOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JRadioButtonOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JScrollBarOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JScrollPaneOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JSliderOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JSpinnerOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JSplitPaneOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JTabbedPaneOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JTableHeaderOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JTableOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JTextAreaOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JTextComponentOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JTextFieldOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JTextPaneOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JToggleButtonOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JTreeOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/LabelOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/ListOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/Operator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/ScrollPaneOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/ScrollbarOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/TextAreaOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/TextComponentOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/TextFieldOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/WindowOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/AbstractTextStyleChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/DefaultVisualizer.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/DumpController.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/Dumper.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/EmptyVisualizer.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/MouseVisualizer.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/NameComponentChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/PNGDecoder.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/PNGEncoder.java + test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/Platform.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/PropChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/RegExComparator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/StringPropChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/TextStyleChooser.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/WindowJob.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/WindowManager.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/package-info.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/version_info Changeset: 937fd6b81aaf Author: rhalade Date: 2018-08-14 10:08 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/937fd6b81aaf 8209452: VerifyCACerts.java failed with "At least one cacert test failed" Summary: Allow test to pass even if cert in EXPIRY_EXC_ENTRIES expires Reviewed-by: mullan ! test/jdk/lib/security/cacerts/VerifyCACerts.java Changeset: 58113ce90caf Author: kbarrett Date: 2018-08-14 13:16 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/58113ce90caf 8209346: Refactor SATBMarkQueue filter configuration Summary: Moved reference to G1-specific option to G1CollectedHeap. Reviewed-by: shade, rkennke ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.cpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.hpp ! src/hotspot/share/gc/g1/satbMarkQueue.cpp ! src/hotspot/share/gc/g1/satbMarkQueue.hpp Changeset: bfdebb29b1e5 Author: amenkov Date: 2018-08-14 11:56 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bfdebb29b1e5 8209109: [TEST] rewrite com/sun/jdi shell tests to java version - step1 Reviewed-by: sspitsyn, jcbeyler + test/jdk/com/sun/jdi/ArrayLengthDumpTest.java - test/jdk/com/sun/jdi/ArrayLengthDumpTest.sh + test/jdk/com/sun/jdi/BreakpointWithFullGC.java - test/jdk/com/sun/jdi/BreakpointWithFullGC.sh + test/jdk/com/sun/jdi/lib/jdb/Jdb.java + test/jdk/com/sun/jdi/lib/jdb/JdbCommand.java + test/jdk/com/sun/jdi/lib/jdb/JdbTest.java Changeset: 0f3bfea3acf1 Author: kbarrett Date: 2018-08-14 14:58 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0f3bfea3acf1 8209347: SATBMarkQueue.cpp should not need jvm.h Summary: Use os::snprintf instead of jio_snprintf. Reviewed-by: shade, tschatzl ! src/hotspot/share/gc/g1/satbMarkQueue.cpp Changeset: c5461fe16efb Author: kvn Date: 2018-08-14 14:08 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c5461fe16efb 8208463: jdk.internal.vm.compiler's module-info.java.extra contains duplicated provides of the same service interface Reviewed-by: mchung ! make/gensrc/Gensrc-jdk.internal.vm.compiler.gmk Changeset: 8b23aa7cef47 Author: gziemski Date: 2018-08-14 18:42 -0500 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8b23aa7cef47 8195100: Use a low latency hashtable for SymbolTable Summary: Used concurrentHashTable, similar to stringTable Reviewed-by: coleenp, kbarrett, iklam, pliden ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/compactHashtable.hpp ! src/hotspot/share/classfile/stringTable.cpp ! src/hotspot/share/classfile/stringTable.hpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/classfile/symbolTable.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/z/zRootsIterator.cpp ! src/hotspot/share/gc/z/zRootsIterator.hpp ! src/hotspot/share/gc/z/z_globals.hpp ! src/hotspot/share/logging/logPrefix.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/arena.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/runtime/serviceThread.cpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/utilities/concurrentHashTable.hpp ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp ! src/hotspot/share/utilities/globalCounter.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp - test/hotspot/jtreg/gc/g1/TestStringSymbolTableStats.java + test/hotspot/jtreg/gc/g1/TestStringTableStats.java + test/hotspot/jtreg/runtime/symboltable/ShortLivedSymbolCleanup.java Changeset: f4b4dfac45b1 Author: coleenp Date: 2018-08-14 19:52 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f4b4dfac45b1 8209518: symbol table gtest fails with semaphore error Summary: loop count was wrong. Reviewed-by: mikael, kbarrett ! test/hotspot/gtest/classfile/test_symbolTable.cpp Changeset: 910f7b56592f Author: xuelei Date: 2018-08-14 18:16 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/910f7b56592f 8207009: TLS 1.3 half-close and synchronization issues Reviewed-by: jnimeh, mullan, wetmore ! src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java ! src/java.base/share/classes/javax/net/ssl/SSLEngine.java ! src/java.base/share/classes/javax/net/ssl/SSLSocket.java ! src/java.base/share/classes/sun/security/ssl/Alert.java ! src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java ! src/java.base/share/classes/sun/security/ssl/CipherSuite.java ! src/java.base/share/classes/sun/security/ssl/DTLSOutputRecord.java ! src/java.base/share/classes/sun/security/ssl/HandshakeContext.java ! src/java.base/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/java.base/share/classes/sun/security/ssl/KeyUpdate.java ! src/java.base/share/classes/sun/security/ssl/OutputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineInputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLHandshake.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketInputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java ! src/java.base/share/classes/sun/security/ssl/TransportContext.java ! test/jdk/java/net/httpclient/CookieHeaderTest.java ! test/jdk/java/net/httpclient/EncodedCharsInURI.java ! test/jdk/java/net/httpclient/ServerCloseTest.java ! test/jdk/javax/net/ssl/ALPN/SSLEngineAlpnTest.java ! test/jdk/javax/net/ssl/SSLEngine/Arrays.java ! test/jdk/javax/net/ssl/SSLEngine/ExtendedKeyEngine.java ! test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java + test/jdk/javax/net/ssl/TLSv12/TLSEnginesClosureTest.java ! test/jdk/sun/security/ssl/AppInputStream/ReadBlocksClose.java ! test/jdk/sun/security/ssl/SSLEngineImpl/CloseStart.java ! test/jdk/sun/security/ssl/SSLEngineImpl/SSLEngineDeadlock.java ! test/jdk/sun/security/ssl/SSLEngineImpl/SSLEngineKeyLimit.java ! test/jdk/sun/security/ssl/SSLEngineImpl/TLS13BeginHandshake.java ! test/jdk/sun/security/ssl/SSLSocketImpl/AsyncSSLSocketClose.java ! test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketKeyLimit.java + test/jdk/sun/security/ssl/SSLSocketImpl/ServerRenegoWithTwoVersions.java Changeset: 59269a19f108 Author: eosterlund Date: 2018-08-15 09:51 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/59269a19f108 8208582: Introduce native oop barriers in C1 for OopHandle Reviewed-by: coleenp, kvn ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp ! src/hotspot/share/gc/shared/c1/barrierSetC1.cpp ! src/hotspot/share/gc/shared/c1/barrierSetC1.hpp Changeset: c86627b0bcce Author: dpochepk Date: 2018-08-15 14:48 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c86627b0bcce 8209439: C2 library_call can potentially ignore Math.pow intrinsic or use null pointer Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/library_call.cpp Changeset: cb8cab787ba2 Author: thartmann Date: 2018-08-15 14:35 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cb8cab787ba2 8209459: TestSHA512MultiBlockIntrinsics failed on AArch64 Summary: Prevent classloading to avoid generation of SHA stubs. Reviewed-by: kvn, thartmann Contributed-by: Joshua Zhu ! test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1Intrinsics.java ! test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1MultiBlockIntrinsics.java ! test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256Intrinsics.java ! test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256MultiBlockIntrinsics.java ! test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512Intrinsics.java ! test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512MultiBlockIntrinsics.java ! test/hotspot/jtreg/compiler/testlibrary/sha/predicate/IntrinsicPredicates.java Changeset: 4699147a4f91 Author: mseledtsov Date: 2018-08-15 10:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4699147a4f91 8209164: [TESTBUG] Apply jtreg skipped status to cds tests Summary: Added the SkippedException where applicable Reviewed-by: iklam, jiangli ! test/hotspot/jtreg/runtime/SharedArchiveFile/ArchiveDoesNotExist.java ! test/hotspot/jtreg/runtime/SharedArchiveFile/CdsDifferentCompactStrings.java ! test/hotspot/jtreg/runtime/SharedArchiveFile/NonBootLoaderClasses.java ! test/hotspot/jtreg/runtime/SharedArchiveFile/PrintSharedArchiveAndExit.java ! test/hotspot/jtreg/runtime/SharedArchiveFile/SharedSymbolTableBucketSize.java ! test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/transformRelatedClasses/TransformTestCommon.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/InvalidFileFormat.java ! test/lib/jdk/test/lib/cds/CDSTestUtils.java Changeset: 8f7e3f9ddbc0 Author: darcy Date: 2018-08-15 10:16 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8f7e3f9ddbc0 8176425: Add radix indication in NumberFormatException message for Integer.decode Reviewed-by: lancea ! src/java.base/share/classes/java/lang/Integer.java ! src/java.base/share/classes/java/lang/Long.java ! src/java.base/share/classes/java/lang/NumberFormatException.java ! src/java.base/share/classes/java/lang/Package.java Changeset: 43e41800d579 Author: darcy Date: 2018-08-15 10:44 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/43e41800d579 5075463: (enum) Serialized Form javadoc for java.lang.Enum is misleading Reviewed-by: lancea, rriggs, smarks ! src/java.base/share/classes/java/lang/Enum.java Changeset: b05b839160a3 Author: coleenp Date: 2018-08-15 15:50 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b05b839160a3 8209447: vmTestbase/vm/mlvm/indy/func/jvmti/mergeCP_none2indy_b/TestDescription.java timed out Summary: was walking code cache for every safepoint because redefined methods take a long time to clear out of the code cache Reviewed-by: eosterlund, rehn ! src/hotspot/share/classfile/classLoaderData.inline.hpp Changeset: 0aa5378d4f09 Author: coleenp Date: 2018-08-15 16:01 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0aa5378d4f09 8209541: Fix merge problem in SymbolTable::do_check_concurrent_work Summary: remerged with previous change to do_unloading. Reviewed-by: hseigel ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/systemDictionary.cpp Changeset: 8c2faee50bc4 Author: vromero Date: 2018-08-15 13:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8c2faee50bc4 8207320: Wrong type order for intersection lambdas with multiple abstract methods Reviewed-by: mcimadamore ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/langtools/tools/javac/T8207320/IntersectionOrderTest.java + test/langtools/tools/javac/T8207320/IntersectionOrderTest2.java Changeset: b08c2a94cce1 Author: iklam Date: 2018-08-14 20:46 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b08c2a94cce1 8206115: Use shared macros for JavaClasses::compute_offsets and MetaspaceShared::serialize_well_known_classes Summary: Added BASIC_JAVA_CLASSES_DO in javaClasses.hpp Reviewed-by: jiangli, redestad, coleenp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/memory/metaspaceShared.cpp ! src/hotspot/share/memory/metaspaceShared.hpp Changeset: 45d1f2ec5342 Author: iklam Date: 2018-08-15 19:22 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/45d1f2ec5342 8207832: serviceability/sa/ClhsdbCDSCore.java failed with "Couldn't find core file location" Summary: Handle %p in /proc/sys/kernel/core_pattern Reviewed-by: dholmes, hseigel ! src/hotspot/os/linux/os_linux.cpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/serviceability/sa/ClhsdbCDSCore.java Changeset: c11be049acb8 Author: thartmann Date: 2018-08-16 09:09 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c11be049acb8 8209511: C2 asserts with UseSSE < 4 and AVX enabled: "Label was never bound to a location, but it was used as a jmp target' Summary: Make sure label is bound even if SSE is disabled. Reviewed-by: kvn ! src/hotspot/cpu/x86/macroAssembler_x86.cpp Changeset: 6bb7b8d0da76 Author: dnsimon Date: 2018-08-16 09:46 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6bb7b8d0da76 8209535: [JVMCI] Do not swallow NoClassDefFoundError when converting JVMCI methods and fields to reflection objects Reviewed-by: kvn, iveresov ! src/hotspot/.mx.jvmci/suite.py ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPoolObject.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIMetaAccessContext.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaFieldImpl.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotSignature.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/Assumptions.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/.checkstyle_checks.xml ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/AllocateCompileIdTest.java Changeset: ef57958c7c51 Author: rgoel Date: 2018-08-16 16:06 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ef57958c7c51 8209047: "Illegal pattern character 'B'" IllegalArgumentException with Burmese locales Summary: Replaced time patterns for Burmese locale from CLDR 29's patterns. Reviewed-by: naoto ! src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/my.xml + test/jdk/java/text/Format/DateFormat/Bug8209047.java Changeset: 41257a58a588 Author: rriggs Date: 2018-08-15 10:38 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/41257a58a588 8208715: Conversion of milliseconds to nanoseconds in UNIXProcess contains bug Reviewed-by: martin ! src/java.base/unix/classes/java/lang/ProcessImpl.java ! src/java.base/windows/classes/java/lang/ProcessImpl.java ! src/java.base/windows/native/libjava/ProcessImpl_md.c ! test/jdk/java/lang/ProcessBuilder/Basic.java Changeset: b2319bbcc867 Author: jlahoda Date: 2018-08-16 15:00 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b2319bbcc867 8208269: Javadoc does not support module-info in a multi-release jar Summary: Ensuring correct version is set when reading multi-release jars. Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java + test/langtools/jdk/javadoc/tool/MultiReleaseJar/TestMultiRelease.java Changeset: 083e731da31a Author: amenkov Date: 2018-08-16 10:20 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/083e731da31a 8209517: com/sun/jdi/BreakpointWithFullGC.java fails with timeout Reviewed-by: dcubed, mikael ! test/jdk/com/sun/jdi/BreakpointWithFullGC.java ! test/jdk/com/sun/jdi/lib/jdb/Jdb.java ! test/jdk/com/sun/jdi/lib/jdb/JdbCommand.java ! test/jdk/com/sun/jdi/lib/jdb/JdbTest.java Changeset: 4e9667589c43 Author: jiangli Date: 2018-08-16 17:29 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4e9667589c43 8209389: SIGSEGV in WalkOopAndArchiveClosure::do_oop_work. Summary: Check the MetaspaceShared::archive_heap_object return value and handle failure accordingly. Reviewed-by: iklam, coleenp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/memory/heapShared.cpp ! src/hotspot/share/memory/metaspaceShared.cpp ! src/hotspot/share/oops/constantPool.cpp ! test/hotspot/jtreg/runtime/appcds/cacheObject/ArchivedIntegerCacheTest.java Changeset: 028076b2832a Author: iignatyev Date: 2018-08-16 16:28 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/028076b2832a 8209549: remove VMPropsExt from TEST.ROOT Reviewed-by: dholmes ! test/jdk/TEST.ROOT Changeset: e66a19f29f6e Author: amenkov Date: 2018-08-16 16:44 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e66a19f29f6e 8209608: Problem list com/sun/jdi/BreakpointWithFullGC.java Reviewed-by: mikael, dtitov, dcubed ! test/jdk/ProblemList.txt Changeset: 211998500d39 Author: kbarrett Date: 2018-08-16 19:49 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/211998500d39 8209607: Remove stale comment for JNI mutexes Summary: Remove comment. Reviewed-by: dholmes ! src/hotspot/share/runtime/mutexLocker.cpp Changeset: d9f6e3ee7fcb Author: iklam Date: 2018-08-15 11:19 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d9f6e3ee7fcb 8209545: Simplify HeapShared::archive_module_graph_objects Summary: Added archivable_static_fields array in heapShared.cpp Reviewed-by: jiangli ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/memory/heapShared.cpp ! src/hotspot/share/memory/heapShared.hpp ! src/hotspot/share/memory/metaspaceShared.cpp Changeset: e2ced90cbd36 Author: thartmann Date: 2018-08-17 08:21 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e2ced90cbd36 8208275: C2 crash in Node::add_req(Node*) Summary: Split-if optimization should not process (dead) counted loops. Reviewed-by: roland ! src/hotspot/share/opto/ifnode.cpp + test/hotspot/jtreg/compiler/loopopts/TestOneIterationStripMined.java Changeset: 0bdce38fde83 Author: epavlova Date: 2018-08-17 03:59 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0bdce38fde83 8209587: Update test/hotspot/jtreg/ProblemList-graal.txt Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: 90024ea291b4 Author: rehn Date: 2018-08-17 13:38 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/90024ea291b4 8207334: VM times out in VM_HandshakeAllThreads::doit() with RunThese30M Summary: Handshakes did not consider external suspended threads safe for safepoint. Reviewed-by: dcubed, dholmes ! src/hotspot/share/runtime/handshake.cpp Changeset: f4e9ab292c90 Author: sballal Date: 2018-08-17 21:50 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f4e9ab292c90 8209342: Problemlist SA tests on Solaris due to Error attaching to process: Can't create thread_db agent! Reviewed-by: dcubed, iklam, jgeorge ! test/hotspot/jtreg/ProblemList.txt ! test/jdk/ProblemList.txt Changeset: 8b2310e7b741 Author: mikael Date: 2018-08-17 09:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8b2310e7b741 Added tag jdk-12+7 for changeset ef57958c7c51 ! .hgtags Changeset: 72c82bd05971 Author: gziemski Date: 2018-08-17 11:56 -0500 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/72c82bd05971 8209586: AARCH64: SymbolTable changes throw assert on aarch64 Summary: Cast the comparison value to match the signdeness Reviewed-by: gziemski, coleenp Contributed-by: stuart.monteigh at linaro.org ! src/hotspot/share/classfile/symbolTable.cpp Changeset: 091c0d22e735 Author: iveresov Date: 2018-08-17 13:20 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/091c0d22e735 8206992: Update Graal Reviewed-by: kvn ! make/CompileJavaModules.gmk ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/BinaryContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/ByteContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/CodeContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/Container.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/GotSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/HeaderContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/NativeSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/ReadOnlyDataContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/Relocation.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/Symbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/SymbolTable.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/AArch64JELFRelocObject.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/AMD64JELFRelocObject.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/Elf.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfByteBuffer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfHeader.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfRelocEntry.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfRelocTable.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfSection.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfSymtab.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/ElfTargetInfo.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/elf/JELFRelocObject.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/JMachORelocObject.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachO.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOByteBuffer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachODySymtab.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOHeader.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachORelocEntry.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachORelocTable.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOSection.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOSegment.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOSymtab.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOTargetInfo.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/macho/MachOVersion.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/JPECoffRelocObject.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoff.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffByteBuffer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffContainer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffHeader.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffRelocEntry.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffRelocTable.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffSection.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffSymtab.java ! src/jdk.aot/share/classes/jdk.tools.jaotc.binformat/src/jdk/tools/jaotc/binformat/pecoff/PECoffTargetInfo.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/HelloWorld.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/NativeOrderOutputStreamTest.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSearchTest.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/ClassSourceTest.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/FakeFileSupport.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/FakeSearchPath.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/SearchPathTest.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/Utils.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/directory/DirectorySourceProviderTest.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/jar/JarSourceProviderTest.java + src/jdk.aot/share/classes/jdk.tools.jaotc.test/src/jdk/tools/jaotc/test/collect/module/ModuleSourceProviderTest.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/AOTBackend.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/AOTCompilationTask.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/AOTCompiledClass.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/AOTCompiler.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/AOTDynamicTypeStore.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/AOTHotSpotResolvedJavaMethod.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/AOTStub.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/CallInfo.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/CallSiteRelocationInfo.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/CallSiteRelocationSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/CodeOffsets.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/CodeSectionProcessor.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Collector.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/CompilationSpec.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/CompiledMethodInfo.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/DataBuilder.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/DataPatchProcessor.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/ELFMacroAssembler.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/ForeignCallSiteRelocationInfo.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/ForeignCallSiteRelocationSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/ForeignGotCallSiteRelocationSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/GraalFilters.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/InfopointProcessor.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/InstructionDecoder.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/JavaCallSiteRelocationInfo.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/JavaCallSiteRelocationSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/JavaMethodInfo.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Linker.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/LoadedClass.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/LogPrinter.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Main.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/MarkId.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/MarkProcessor.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/MetadataBuilder.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Options.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/StubDirectCallSiteRelocationSymbol.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/StubInformation.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Timer.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/aarch64/AArch64ELFMacroAssembler.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/aarch64/AArch64InstructionDecoder.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/amd64/AMD64ELFMacroAssembler.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/amd64/AMD64InstructionDecoder.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/ClassSearch.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/ClassSource.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/FileSupport.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/FileSystemFinder.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/SearchFor.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/SearchPath.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/SourceProvider.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/classname/ClassNameSource.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/classname/ClassNameSourceProvider.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/directory/DirectorySource.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/directory/DirectorySourceProvider.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/jar/JarFileSource.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/jar/JarSourceProvider.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/module/ModuleSource.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/module/ModuleSourceProvider.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/utils/NativeOrderOutputStream.java ! src/jdk.internal.vm.compiler.management/share/classes/org.graalvm.compiler.hotspot.management/src/org/graalvm/compiler/hotspot/management/JMXServiceProvider.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections.test/src/jdk/internal/vm/compiler/collections/test/EconomicMapImplTest.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections.test/src/jdk/internal/vm/compiler/collections/test/EconomicSetTest.java ! src/jdk.internal.vm.compiler/share/classes/module-info.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64Address.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64.test/src/org/graalvm/compiler/asm/amd64/test/BitOpsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64Assembler.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64BaseAssembler.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64InstructionAttr.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64MacroAssembler.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64VectorAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AVXKind.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.sparc/src/org/graalvm/compiler/asm/sparc/SPARCAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64MoveFactoryBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64NodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/NumUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/IntList.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.sparc/src/org/graalvm/compiler/core/sparc/SPARCLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CheckGraalInvariants.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConcreteSubtypeTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/EnumValuesTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/FinalizableSubclassTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GraalCompilerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/HashCodeTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/HashMapGetTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/InterfaceMethodHandleTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/InvocationPluginsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnsafeReadEliminationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EscapeAnalysisTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PEAAssertionsTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PartialEscapeAnalysisIterationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PartialEscapeAnalysisTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/inlining/InliningTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/inlining/NestedLoopEffectsPhaseComplexityTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/tutorial/StaticAnalysisTests.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/CompilationWrapper.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/NodeLIRBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/TimerKeyImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph.test/src/org/graalvm/compiler/graph/test/graphio/GraphSnippetTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/Graph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotDeoptimizeCallerOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotEpilogueOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotJumpToExceptionHandlerInCallerOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotReturnOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotUnwindOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64.test/src/org/graalvm/compiler/hotspot/amd64/test/CompressedNullCheckTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64.test/src/org/graalvm/compiler/hotspot/amd64/test/StubAVXTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotReturnOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/ArrayCopyIntrinsificationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HotSpotMethodSubstitutionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HotSpotStackIntrospectionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/WriteBarrierAdditionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilerConfigurationFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigVersioned.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotForeignCallLinkage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotForeignCallLinkageImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalRuntime.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotHostBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotLIRGenerationResult.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/JVMCIVersionCheck.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/PrintStreamOptionKey.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotForeignCallsProviderImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotHostForeignCallsProvider.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/IntrinsificationPredicate.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/ClassGetHubNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotReplacementsUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/MonitorSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/NewObjectSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/ReflectionSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/CreateExceptionStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/ForeignCallStub.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/IntegerExactOverflowExceptionStub.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/LongExactOverflowExceptionStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/NewArrayStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/NewInstanceStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/StubUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BytecodeParser.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/backend/LargeConstantSectionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/bytecode/BC_i2d.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/except/UntrustedInterfaces.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/hotpath/HP_allocate02.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/hotspot/NotOnDebug.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/hotspot/Test6823354.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/hotspot/Test6959129.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/micro/ReferenceMap01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/reflect/Class_newInstance01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/reflect/Class_newInstance02.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/reflect/Class_newInstance03.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/reflect/Class_newInstance06.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/reflect/Class_newInstance07.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Monitor_contended01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Monitor_notowner01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Monitorenter01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Monitorenter02.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Object_wait01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Object_wait02.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Object_wait03.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Object_wait04.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/SynchronizedLoopExit01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Thread_isInterrupted02.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Thread_isInterrupted03.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Thread_isInterrupted05.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Thread_join01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Thread_join02.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Thread_join03.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Thread_sleep01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/threads/Thread_yield01.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ArrayCompareToOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64LIRFlagsVersioned.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayCompareToOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayEqualsOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayIndexOfOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Binary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64BinaryConsumer.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ClearRegisterOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Move.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MulDivOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ShiftOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64SignExtendOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64StringIndexOfOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Unary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorBinary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorClearOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorCompareOp.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorLIRInstruction.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorMove.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorShuffle.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorUnary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/SwitchStrategy.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/alloc/trace/GlobalLivenessAnalysisPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGeneratorTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/profiling/MethodProfilingPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/profiling/MoveProfilingPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodeinfo/src/org/graalvm/compiler/nodeinfo/NodeCycles.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodeinfo/src/org/graalvm/compiler/nodeinfo/NodeSize.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/AbstractBeginNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/ConstantNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/FixedNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/FrameState.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/IfNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/InliningLog.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/PiArrayNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/ProxyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/StructuredGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/debug/DynamicCounterNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/debug/WeakCounterNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/BytecodeExceptionNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/FixedValueAnchorNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/InvocationPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/AbstractNewArrayNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/ArrayLengthNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/LoadFieldNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/LoadIndexedNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/NewMultiArrayNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/ReadNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/ArrayLengthProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/util/GraphUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/virtual/AllocatedObjectNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/virtual/VirtualArrayNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/EnumOptionKey.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/FloatingReadPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/inlining/info/elem/InlineableGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/BasePhase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64ArrayIndexOfNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringLatin1Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringUTF16Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.processor/src/org/graalvm/compiler/replacements/processor/GeneratedPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.processor/src/org/graalvm/compiler/replacements/processor/PluginGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/DeoptimizeOnExceptionTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/DeoptimizeOnIntegerExactTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/IntegerExactExceptionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/MethodSubstitutionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringCompareToTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringEqualsTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringIndexOfCharTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringIndexOfConstantTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringIndexOfTestBase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringSubstitutionTestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringSubstitutionsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/classfile/RedefineIntrinsicTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ConstantStringIndexOfSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/DefaultJavaLoweringProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/InlineDuringParsingPlugin.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/JDK9StringSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetTemplate.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StringLatin1IndexOfNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StringUTF16IndexOfNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/BasicObjectCloneNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerAddExactNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerExactArithmeticNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerExactArithmeticSplitNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulExactNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerSubExactNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalServices.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/JMXService.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/GraalTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/PartialEscapeClosure.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/WordCastNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.micro.benchmarks/src/micro/benchmarks/StringBenchmark.java Changeset: 6221a199ec20 Author: darcy Date: 2018-08-17 13:37 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6221a199ec20 8209304: Deprecate serialVersionUID fields in interfaces Reviewed-by: lancea, mullan, rriggs, smarks ! src/java.base/share/classes/java/security/Key.java ! src/java.base/share/classes/java/security/PrivateKey.java ! src/java.base/share/classes/java/security/PublicKey.java ! src/java.base/share/classes/java/security/interfaces/DSAPrivateKey.java ! src/java.base/share/classes/java/security/interfaces/DSAPublicKey.java ! src/java.base/share/classes/java/security/interfaces/ECPrivateKey.java ! src/java.base/share/classes/java/security/interfaces/ECPublicKey.java ! src/java.base/share/classes/java/security/interfaces/RSAMultiPrimePrivateCrtKey.java ! src/java.base/share/classes/java/security/interfaces/RSAPrivateCrtKey.java ! src/java.base/share/classes/java/security/interfaces/RSAPrivateKey.java ! src/java.base/share/classes/java/security/interfaces/RSAPublicKey.java ! src/java.base/share/classes/javax/crypto/SecretKey.java ! src/java.base/share/classes/javax/crypto/interfaces/DHPrivateKey.java ! src/java.base/share/classes/javax/crypto/interfaces/DHPublicKey.java ! src/java.base/share/classes/javax/crypto/interfaces/PBEKey.java ! src/java.base/share/classes/sun/security/internal/interfaces/TlsMasterSecret.java ! src/java.naming/share/classes/javax/naming/Name.java ! src/java.naming/share/classes/javax/naming/directory/Attribute.java ! src/java.rmi/share/classes/java/rmi/server/RemoteRef.java ! src/java.rmi/share/classes/java/rmi/server/ServerRef.java Changeset: 6ca468ea3564 Author: coffeys Date: 2018-08-17 22:20 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6ca468ea3564 8208675: Remove legacy sun.security.key.serial.interop property Reviewed-by: mullan ! src/java.base/share/classes/sun/security/provider/DSAKeyFactory.java ! src/java.base/share/classes/sun/security/provider/DSAKeyPairGenerator.java Changeset: 0517bd2a0eda Author: ccheung Date: 2018-08-17 14:50 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0517bd2a0eda 8209385: CDS runtime classpath checking is too strict when only classes from the system modules are archived Summary: skip checking the path entries which are not being referenced during CDS dump time Reviewed-by: jiangli, iklam ! src/hotspot/share/classfile/classLoaderExt.cpp ! src/hotspot/share/classfile/classLoaderExt.hpp ! src/hotspot/share/classfile/sharedPathsMiscInfo.cpp ! src/hotspot/share/memory/filemap.cpp ! src/hotspot/share/memory/filemap.hpp ! test/hotspot/jtreg/runtime/appcds/DirClasspathTest.java ! test/hotspot/jtreg/runtime/appcds/PrintSharedArchiveAndExit.java + test/hotspot/jtreg/runtime/appcds/UnusedCPDuringDump.java Changeset: a1aaf68b119d Author: jnimeh Date: 2018-08-17 21:36 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a1aaf68b119d 8203614: Java API SSLEngine example code needs correction Reviewed-by: wetmore, ascarpino ! src/java.base/share/classes/javax/net/ssl/SSLEngine.java Changeset: 2e91d927e00c Author: kbarrett Date: 2018-08-18 13:59 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2e91d927e00c 8154343: Make SATB related code available to other GCs Summary: Move ptrQueue and satbMarkQueue files from g1 to shared. Reviewed-by: rkennke, sangheki ! src/hotspot/share/gc/g1/dirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.cpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.hpp ! src/hotspot/share/gc/g1/g1ThreadLocalData.hpp - src/hotspot/share/gc/g1/ptrQueue.cpp - src/hotspot/share/gc/g1/ptrQueue.hpp - src/hotspot/share/gc/g1/satbMarkQueue.cpp - src/hotspot/share/gc/g1/satbMarkQueue.hpp + src/hotspot/share/gc/shared/ptrQueue.cpp + src/hotspot/share/gc/shared/ptrQueue.hpp + src/hotspot/share/gc/shared/satbMarkQueue.cpp + src/hotspot/share/gc/shared/satbMarkQueue.hpp ! src/hotspot/share/precompiled/precompiled.hpp Changeset: 703576fdd268 Author: iignatyev Date: 2018-08-19 22:41 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/703576fdd268 8209456: [error-prone] ShortCircuitBoolean in java.logging Reviewed-by: rriggs ! src/java.logging/share/classes/java/util/logging/Formatter.java Changeset: cdffba164671 Author: shade Date: 2018-08-20 10:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cdffba164671 8209573: [TESTBUG] gc/epsilon/TestMemoryMXBeans should retry on failure Reviewed-by: kvn, pliden ! test/hotspot/jtreg/gc/epsilon/TestMemoryMXBeans.java Changeset: 0c2f244ae0d1 Author: dsimms Date: 2018-08-20 12:50 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0c2f244ae0d1 Merge ! .hgtags ! make/CompileJavaModules.gmk ! make/Docs.gmk ! make/Images.gmk ! make/common/Modules.gmk ! make/conf/jib-profiles.js - make/data/symbols/java.base-6.sym.txt - make/data/symbols/java.compiler-6.sym.txt - make/data/symbols/java.desktop-6.sym.txt - make/data/symbols/java.logging-6.sym.txt - make/data/symbols/java.management-6.sym.txt - make/data/symbols/java.rmi-6.sym.txt - make/data/symbols/java.security.jgss-6.sym.txt - make/data/symbols/java.sql-6.sym.txt - make/data/symbols/java.sql.rowset-6.sym.txt - make/data/symbols/java.xml-6.sym.txt - make/data/symbols/java.xml.bind-6.sym.txt - make/data/symbols/java.xml.ws-6.sym.txt - make/data/symbols/java.xml.ws.annotation-6.sym.txt - make/data/symbols/jdk.management-6.sym.txt - make/data/symbols/jdk.sctp-6.sym.txt - make/data/symbols/jdk.security.jgss-6.sym.txt ! make/hotspot/symbols/symbols-unix - src/demo/share/applets.html - src/demo/share/applets/ArcTest/ArcTest.java - src/demo/share/applets/ArcTest/example1.html - src/demo/share/applets/BarChart/BarChart.java - src/demo/share/applets/BarChart/example1.html - src/demo/share/applets/BarChart/example2.html - src/demo/share/applets/Blink/Blink.java - src/demo/share/applets/Blink/example1.html - src/demo/share/applets/CardTest/CardTest.java - src/demo/share/applets/CardTest/example1.html - src/demo/share/applets/Clock/Clock.java - src/demo/share/applets/Clock/example1.html - src/demo/share/applets/DitherTest/DitherTest.java - src/demo/share/applets/DitherTest/example1.html - src/demo/share/applets/DrawTest/DrawTest.java - src/demo/share/applets/DrawTest/example1.html - src/demo/share/applets/Fractal/CLSFractal.java - src/demo/share/applets/Fractal/example1.html - src/demo/share/applets/GraphicsTest/AppletFrame.java - src/demo/share/applets/GraphicsTest/GraphicsTest.java - src/demo/share/applets/GraphicsTest/example1.html - src/demo/share/applets/MoleculeViewer/Matrix3D.java - src/demo/share/applets/MoleculeViewer/XYZApp.java - src/demo/share/applets/MoleculeViewer/example1.html - src/demo/share/applets/MoleculeViewer/example2.html - src/demo/share/applets/MoleculeViewer/example3.html - src/demo/share/applets/MoleculeViewer/models/HyaluronicAcid.xyz - src/demo/share/applets/MoleculeViewer/models/benzene.xyz - src/demo/share/applets/MoleculeViewer/models/buckminsterfullerine.xyz - src/demo/share/applets/MoleculeViewer/models/cyclohexane.xyz - src/demo/share/applets/MoleculeViewer/models/ethane.xyz - src/demo/share/applets/MoleculeViewer/models/water.xyz - src/demo/share/applets/NervousText/NervousText.java - src/demo/share/applets/NervousText/example1.html - src/demo/share/applets/SimpleGraph/GraphApplet.java - src/demo/share/applets/SimpleGraph/example1.html - src/demo/share/applets/SortDemo/BidirBubbleSortAlgorithm.java - src/demo/share/applets/SortDemo/BubbleSortAlgorithm.java - src/demo/share/applets/SortDemo/QSortAlgorithm.java - src/demo/share/applets/SortDemo/SortAlgorithm.java - src/demo/share/applets/SortDemo/SortItem.java - src/demo/share/applets/SortDemo/example1.html - src/demo/share/applets/SpreadSheet/SpreadSheet.java - src/demo/share/applets/SpreadSheet/example1.html - src/demo/share/applets/WireFrame/Matrix3D.java - src/demo/share/applets/WireFrame/ThreeD.java - src/demo/share/applets/WireFrame/example1.html - src/demo/share/applets/WireFrame/example2.html - src/demo/share/applets/WireFrame/example3.html - src/demo/share/applets/WireFrame/example4.html - src/demo/share/applets/WireFrame/models/cube.obj - src/demo/share/applets/WireFrame/models/dinasaur.obj - src/demo/share/applets/WireFrame/models/hughes_500.obj - src/demo/share/applets/WireFrame/models/knoxS.obj - src/demo/share/jfc/SwingApplet/README.txt - src/demo/share/jfc/SwingApplet/SwingApplet.html - src/demo/share/jfc/SwingApplet/SwingApplet.java ! src/hotspot/cpu/aarch64/globals_aarch64.hpp ! src/hotspot/cpu/x86/frame_x86.cpp ! src/hotspot/cpu/x86/globals_x86.hpp ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/interp_masm_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/cpu/x86/x86_64.ad - src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.inline.hpp - src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.inline.hpp - src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.inline.hpp - src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.inline.hpp - src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.inline.hpp - src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.inline.hpp - src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.inline.hpp - src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.inline.hpp - src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.inline.hpp - src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.inline.hpp - src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.inline.hpp - src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.inline.hpp - src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.inline.hpp ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_IR.hpp ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/ci/bcEscapeAnalyzer.cpp ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/ci/ciField.cpp ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/ci/ciMethod.cpp ! src/hotspot/share/ci/ciMethodBlocks.cpp ! src/hotspot/share/ci/ciStreams.cpp ! src/hotspot/share/ci/ciTypeFlow.hpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/classLoaderData.hpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/stackMapFrame.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/code/codeBlob.cpp ! src/hotspot/share/code/codeBlob.hpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/methodLiveness.cpp ! src/hotspot/share/compiler/oopMap.cpp - src/hotspot/share/gc/cms/cmsOopClosures.cpp - src/hotspot/share/gc/cms/cms_specialized_oop_closures.hpp - src/hotspot/share/gc/cms/parOopClosures.cpp ! src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp - src/hotspot/share/gc/g1/g1StringDedupTable.cpp - src/hotspot/share/gc/g1/g1StringDedupTable.hpp - src/hotspot/share/gc/g1/g1StringDedupThread.cpp - src/hotspot/share/gc/g1/g1StringDedupThread.hpp - src/hotspot/share/gc/g1/g1_specialized_oop_closures.hpp - src/hotspot/share/gc/g1/ptrQueue.cpp - src/hotspot/share/gc/g1/ptrQueue.hpp - src/hotspot/share/gc/g1/satbMarkQueue.cpp - src/hotspot/share/gc/g1/satbMarkQueue.hpp ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psPromotionManager.cpp - src/hotspot/share/gc/serial/serial_specialized_oop_closures.hpp ! src/hotspot/share/gc/shared/collectedHeap.inline.hpp - src/hotspot/share/gc/shared/genOopClosures.cpp - src/hotspot/share/gc/shared/specialized_oop_closures.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/interpreter/bytecodeInterpreter.cpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/interpreter/templateInterpreterGenerator.cpp ! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.hpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/allocation.hpp ! src/hotspot/share/memory/iterator.hpp ! src/hotspot/share/memory/iterator.inline.hpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/memory/universe.hpp ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/arrayKlass.hpp ! src/hotspot/share/oops/arrayOop.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/constantPool.hpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/instanceKlass.inline.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/klassVtable.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/oops/objArrayKlass.cpp ! src/hotspot/share/oops/objArrayKlass.hpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/typeArrayKlass.cpp ! src/hotspot/share/oops/typeArrayOop.hpp ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/callGenerator.cpp ! src/hotspot/share/opto/callnode.cpp ! src/hotspot/share/opto/callnode.hpp ! src/hotspot/share/opto/chaitin.cpp ! src/hotspot/share/opto/classes.cpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/opto/doCall.cpp ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/idealKit.cpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/live.cpp ! src/hotspot/share/opto/loopopts.cpp ! src/hotspot/share/opto/machnode.hpp ! src/hotspot/share/opto/macro.cpp ! src/hotspot/share/opto/macroArrayCopy.cpp ! src/hotspot/share/opto/matcher.cpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/memnode.hpp ! src/hotspot/share/opto/mulnode.cpp ! src/hotspot/share/opto/node.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/output.cpp ! src/hotspot/share/opto/parse.hpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/opto/parse2.cpp ! src/hotspot/share/opto/parse3.cpp ! src/hotspot/share/opto/phaseX.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/opto/runtime.hpp ! src/hotspot/share/opto/stringopts.cpp ! src/hotspot/share/opto/subnode.hpp ! src/hotspot/share/opto/type.cpp ! src/hotspot/share/opto/type.hpp ! src/hotspot/share/precompiled/precompiled.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiCodeBlobEvents.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/deoptimization.hpp ! src/hotspot/share/runtime/fieldDescriptor.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/interfaceSupport.cpp ! src/hotspot/share/runtime/jniHandles.cpp ! src/hotspot/share/runtime/mutexLocker.cpp - src/hotspot/share/runtime/orderAccess.inline.hpp ! src/hotspot/share/runtime/reflection.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp - src/hotspot/share/runtime/simpleThresholdPolicy.cpp - src/hotspot/share/runtime/simpleThresholdPolicy.hpp - src/hotspot/share/runtime/simpleThresholdPolicy.inline.hpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/hotspot/share/runtime/stubRoutines.hpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/runtime/vm_operations.cpp ! src/hotspot/share/runtime/vm_operations.hpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/diagnosticCommand.hpp ! src/hotspot/share/services/nmtCommon.cpp ! src/hotspot/share/utilities/exceptions.hpp ! src/hotspot/share/utilities/globalDefinitions.hpp - src/java.base/aix/native/libjsig/jsig.c ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java ! src/java.base/share/classes/jdk/internal/misc/JavaLangAccess.java ! src/java.base/share/classes/jdk/internal/reflect/MethodAccessorGenerator.java ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java ! src/java.base/share/classes/module-info.java - src/java.base/share/classes/sun/net/NetworkServer.java - src/java.base/share/classes/sun/net/RegisteredDomain.java - src/java.base/share/classes/sun/net/URLCanonicalizer.java - src/java.base/share/classes/sun/security/ssl/ALPNExtension.java - src/java.base/share/classes/sun/security/ssl/Alerts.java - src/java.base/share/classes/sun/security/ssl/AppInputStream.java - src/java.base/share/classes/sun/security/ssl/AppOutputStream.java - src/java.base/share/classes/sun/security/ssl/ByteBufferInputStream.java - src/java.base/share/classes/sun/security/ssl/CertStatusReqExtension.java - src/java.base/share/classes/sun/security/ssl/CertStatusReqItemV2.java - src/java.base/share/classes/sun/security/ssl/CertStatusReqListV2Extension.java - src/java.base/share/classes/sun/security/ssl/CipherBox.java - src/java.base/share/classes/sun/security/ssl/CipherSuiteList.java - src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java - src/java.base/share/classes/sun/security/ssl/ClientKeyExchangeService.java - src/java.base/share/classes/sun/security/ssl/DHCrypt.java - src/java.base/share/classes/sun/security/ssl/Debug.java - src/java.base/share/classes/sun/security/ssl/ECDHCrypt.java - src/java.base/share/classes/sun/security/ssl/EllipticPointFormatsExtension.java - src/java.base/share/classes/sun/security/ssl/ExtensionType.java - src/java.base/share/classes/sun/security/ssl/HandshakeInStream.java - src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java - src/java.base/share/classes/sun/security/ssl/HandshakeStateManager.java - src/java.base/share/classes/sun/security/ssl/Handshaker.java - src/java.base/share/classes/sun/security/ssl/HelloExtension.java - src/java.base/share/classes/sun/security/ssl/HelloExtensions.java - src/java.base/share/classes/sun/security/ssl/MAC.java - src/java.base/share/classes/sun/security/ssl/MaxFragmentLengthExtension.java - src/java.base/share/classes/sun/security/ssl/NamedGroup.java - src/java.base/share/classes/sun/security/ssl/NamedGroupType.java - src/java.base/share/classes/sun/security/ssl/OCSPStatusRequest.java - src/java.base/share/classes/sun/security/ssl/ProtocolList.java - src/java.base/share/classes/sun/security/ssl/RenegotiationInfoExtension.java - src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java - src/java.base/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java - src/java.base/share/classes/sun/security/ssl/StatusRequest.java - src/java.base/share/classes/sun/security/ssl/StatusRequestType.java - src/java.base/share/classes/sun/security/ssl/UnknownExtension.java - src/java.base/share/classes/sun/security/ssl/UnknownStatusRequest.java ! src/java.base/share/native/libjava/Class.c - src/java.desktop/linux/conf/oblique-fonts/fonts.dir - src/java.desktop/macosx/native/libsplashscreen/libpng/zlib.h - src/java.desktop/share/classes/sun/applet/AppletAudioClip.java - src/java.desktop/share/classes/sun/applet/AppletEvent.java - src/java.desktop/share/classes/sun/applet/AppletEventMulticaster.java - src/java.desktop/share/classes/sun/applet/AppletIOException.java - src/java.desktop/share/classes/sun/applet/AppletIllegalArgumentException.java - src/java.desktop/share/classes/sun/applet/AppletImageRef.java - src/java.desktop/share/classes/sun/applet/AppletListener.java - src/java.desktop/share/classes/sun/applet/AppletMessageHandler.java - src/java.desktop/share/classes/sun/applet/AppletObjectInputStream.java - src/java.desktop/share/classes/sun/applet/AppletPanel.java - src/java.desktop/share/classes/sun/applet/AppletProps.java - src/java.desktop/share/classes/sun/applet/AppletResourceLoader.java - src/java.desktop/share/classes/sun/applet/AppletSecurityException.java - src/java.desktop/share/classes/sun/applet/AppletViewer.java - src/java.desktop/share/classes/sun/applet/AppletViewerFactory.java - src/java.desktop/share/classes/sun/applet/AppletViewerPanel.java - src/java.desktop/share/classes/sun/applet/Main.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_de.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_es.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_fr.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_it.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_ja.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_ko.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_pt_BR.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_sv.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_zh_CN.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_zh_TW.java - src/java.desktop/share/classes/sun/awt/DesktopBrowse.java - src/java.desktop/share/classes/sun/print/DialogOnTop.java - src/java.desktop/share/classes/sun/print/DialogOwner.java - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cbdt-table.hh - src/java.desktop/unix/conf/fonts/fonts.dir - src/java.net.http/share/classes/jdk/internal/net/http/ImmutableHeaders.java - src/java.net.http/share/classes/jdk/internal/net/http/common/HttpHeadersImpl.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/ssl/KerberosPreMasterSecret.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/ssl/Krb5KeyExchangeService.java - src/java.sql.rowset/share/classes/javax/sql/rowset/package.html - src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/helper/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/AbstractSerializer.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/AgreementMethod.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherData.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherReference.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherValue.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/DocumentSerializer.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedData.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedKey.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedType.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionMethod.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionProperties.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionProperty.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/Reference.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/ReferenceList.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/Serializer.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/Transforms.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherInput.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherParameters.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLEncryptionException.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/exceptions/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/EncryptedKeyResolver.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/resource/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementChecker.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementCheckerImpl.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionElementProxy.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/package.html - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/AltHashing.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/StringTable.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/SymbolTable.java - src/jdk.internal.opt/share/classes/jdk/internal/joptsimple/MissingRequiredOptionException.java - src/jdk.internal.opt/share/classes/jdk/internal/joptsimple/UnacceptableNumberOfNonOptionsException.java - src/jdk.internal.opt/share/classes/jdk/internal/joptsimple/internal/Objects.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java - src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntimeProvider.java - src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodUnresolved.java - src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotUnresolvedField.java - src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotUnresolvedJavaType.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfig.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64InstructionAttr.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugValueMap.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/aaa - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/IntrinsificationPredicate.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/hotspot/NotOnDebug.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphSpeculationLog.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/META-INF/services/javax.annotation.processing.Processor - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/APHotSpotSignature.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/AbstractVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/ClassSubstitutionVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/FoldVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/GeneratedFoldPlugin.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/GeneratedNodeIntrinsicPlugin.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/GeneratedPlugin.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/InjectedDependencies.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/MethodSubstitutionVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/NodeIntrinsicVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/PluginGenerator.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/VerifierAnnotationProcessor.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/classfile/D - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/jquery-1.10.2.js ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java - test/hotspot/gtest/utilities/utilitiesHelper.inline.hpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/TEST.groups - test/hotspot/jtreg/applications/ctw/modules/javafx_base.java - test/hotspot/jtreg/applications/ctw/modules/javafx_controls.java - test/hotspot/jtreg/applications/ctw/modules/javafx_fxml.java - test/hotspot/jtreg/applications/ctw/modules/javafx_graphics.java - test/hotspot/jtreg/applications/ctw/modules/javafx_media.java - test/hotspot/jtreg/applications/ctw/modules/javafx_swing.java - test/hotspot/jtreg/applications/ctw/modules/javafx_web.java - test/hotspot/jtreg/applications/jcstress/acqrel/Test.java - test/hotspot/jtreg/applications/jcstress/atomicity/Test.java - test/hotspot/jtreg/applications/jcstress/copy/Test.java - test/hotspot/jtreg/applications/jcstress/fences/Test.java - test/hotspot/jtreg/applications/jcstress/memeffects/Test.java - test/hotspot/jtreg/applications/jcstress/other/Test.java - test/hotspot/jtreg/applications/jcstress/seqcst.sync/Test.java - test/hotspot/jtreg/applications/jcstress/seqcst.volatiles/Test.java - test/hotspot/jtreg/gc/g1/TestStringSymbolTableStats.java - test/hotspot/jtreg/runtime/SharedArchiveFile/SASymbolTableTest.java - test/hotspot/jtreg/runtime/SharedArchiveFile/SASymbolTableTestAgent.java - test/hotspot/jtreg/runtime/appcds/MismatchedUseAppCDS.java - test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsHelper.java - test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsTests.java - test/hotspot/jtreg/runtime/appcds/test-classes/CheckIfShared.java - test/hotspot/jtreg/runtime/appcds/test-classes/jdk/dynalink/DynamicLinker.jasm - test/hotspot/jtreg/runtime/containers/docker/CPUSetsReader.java - test/hotspot/jtreg/runtime/containers/docker/Common.java - test/hotspot/jtreg/runtime/exceptionMsgs/IncompatibleClassChangeError/ICC_B.jasm - test/hotspot/jtreg/serviceability/sa/ClhsdbSymbol.java - test/hotspot/jtreg/serviceability/sa/ClhsdbSymbolTable.java - test/hotspot/jtreg/serviceability/tmtools/jstat/utils/ClassLoadUtils.java - test/hotspot/jtreg/serviceability/tmtools/jstat/utils/GeneratingClassLoader.java - test/hotspot/jtreg/serviceability/tmtools/jstat/utils/TemplateClass.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeap/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeap/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeap/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeapCore/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeapCore/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspace/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspace/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspace/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspaceCore/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspaceCore/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspaceCore/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFile/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFile/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFile/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFileMetaspace/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFileMetaspace/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFileMetaspace/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToPath/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToPath/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToPath/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/README - test/hotspot/jtreg/vmTestbase/heapdump/share/EatMemory.java - test/hotspot/jtreg/vmTestbase/heapdump/share/common.sh - test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach024/java.base/java/util/ServiceConfigurationError.java - test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/share/transform/v2/MHSamTF.java ! test/jdk/TEST.groups - test/jdk/com/sun/jdi/ArrayLengthDumpTest.sh - test/jdk/com/sun/jdi/BreakpointWithFullGC.sh - test/jdk/java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html - test/jdk/java/awt/grab/MenuDragEvents/MenuDragEvents.html - test/jdk/java/lang/System/SetProperties.java - test/jdk/java/lang/Thread/StopThrowable.java - test/jdk/java/net/httpclient/ThrowingPublishers.java - test/jdk/java/net/httpclient/ThrowingPushPromises.java - test/jdk/java/net/httpclient/ThrowingSubscribers.java - test/jdk/java/net/httpclient/offline/FixedHttpHeaders.java - test/jdk/java/util/Formatter/NoGroupingUsed.java - test/jdk/javax/sound/midi/MidiSystem/DefaultProperties.java - test/jdk/javax/sound/midi/MidiSystem/testdata/conf/sound.properties - test/jdk/javax/sound/sampled/AudioSystem/DefaultProperties.java - test/jdk/javax/sound/sampled/AudioSystem/testdata/conf/sound.properties - test/jdk/javax/swing/JLayer/8041982/cupanim.gif - test/jdk/javax/swing/JSlider/4987336/cupanim.gif - test/jdk/javax/swing/JSpinner/6421058/bug6421058.java - test/jdk/javax/swing/JSpinner/WrongEditorTextFieldFont/WrongEditorTextFieldFont.java - test/jdk/sanity/releaseFile/CheckSource.java - test/jdk/sun/applet/DeprecatedAppletViewer/DeprecatedAppletViewer.java - test/jdk/sun/applet/TEST.properties - test/jdk/sun/security/krb5/auto/SSL.java - test/jdk/sun/security/krb5/auto/SSLwithPerms.java - test/jdk/sun/security/krb5/auto/UnboundSSL.java - test/jdk/sun/security/krb5/auto/UnboundSSLMultipleKeys.java - test/jdk/sun/security/krb5/auto/UnboundSSLPrincipalProperty.java - test/jdk/sun/security/krb5/auto/UnboundSSLUtils.java - test/jdk/sun/security/krb5/auto/unbound.ssl.jaas.conf - test/jdk/sun/security/krb5/auto/unbound.ssl.policy - test/jdk/sun/security/ssl/ExtensionType/OptimalListSize.java - test/jdk/sun/security/ssl/SSLEngineImpl/CloseInboundException.java - test/jdk/sun/security/ssl/StatusStapling/RunStatReqSelect.java - test/jdk/sun/security/ssl/StatusStapling/TEST.properties - test/jdk/sun/security/ssl/StatusStapling/TestRun.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/BogusStatusRequest.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/CertStatusReqExtensionTests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/CertStatusReqItemV2Tests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/CertStatusReqListV2ExtensionTests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/OCSPStatusRequestTests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/StatusReqSelection.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/StatusResponseManagerTests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/TestCase.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/TestUtils.java - test/jdk/sun/text/resources/JavaTimeSupplementaryTest.java - test/jdk/sun/tools/jhsdb/AlternateHashingTest.java - test/jdk/sun/tools/jhsdb/LingeredAppWithAltHashing.java ! test/jdk/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java ! test/langtools/lib/annotations/annotations/classfile/ClassfileInspector.java - test/langtools/tools/javac/6558548/T6558548_6.out - test/langtools/tools/javac/8013179/T8013179.java - test/langtools/tools/javac/8013179/T8013179.out ! test/langtools/tools/javac/MethodParameters/AttributeVisitor.java - test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel1_6.out - test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel2_6.out - test/langtools/tools/javac/StringsInSwitch/NonConstantLabel6.out - test/langtools/tools/javac/StringsInSwitch/OneCaseSwitches.out - test/langtools/tools/javac/StringsInSwitch/RSCL1_6.out - test/langtools/tools/javac/StringsInSwitch/RSCL2_6.out - test/langtools/tools/javac/TryWithResources/BadTwr6.out - test/langtools/tools/javac/TryWithResources/BadTwrSyntax6.out - test/langtools/tools/javac/TryWithResources/PlainTry6.out - test/langtools/tools/javac/TryWithResources/TwrOnNonResource6.out - test/langtools/tools/javac/TryWithResources/WeirdTwr.out - test/langtools/tools/javac/annotations/repeatingAnnotations/WrongVersion6.out - test/langtools/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out - test/langtools/tools/javac/defaultMethods/static/StaticInvokeQualified6.out - test/langtools/tools/javac/defaultMethods/static/StaticInvokeSimple6.out ! test/langtools/tools/javac/diags/CheckResourceKeys.java ! test/langtools/tools/javac/diags/examples.not-yet.txt - test/langtools/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java - test/langtools/tools/javac/diags/examples/MulticatchNotSupported.java - test/langtools/tools/javac/diags/examples/StringSwitchNotSupported.java - test/langtools/tools/javac/diags/examples/TryResourceNotSupported.java - test/langtools/tools/javac/diags/examples/TryWithoutCatchOrFinally.java - test/langtools/tools/javac/diags/examples/UnsupportedBinaryLiteral.java - test/langtools/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java - test/langtools/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java - test/langtools/tools/javac/literals/BadBinaryLiterals.6.out - test/langtools/tools/javac/literals/BadUnderscoreLiterals.6.out - test/langtools/tools/javac/processing/environment/round/AnnotatedElementInfo.java - test/langtools/tools/javac/types/CastObjectToPrimitiveTest.out - test/langtools/tools/javac/warnings/6594914/T6594914b.out ! test/lib/sun/hotspot/WhiteBox.java Changeset: 210e716a8810 Author: dsimms Date: 2018-08-21 16:19 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/210e716a8810 Merge ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/runtime/arguments.cpp Changeset: 81246ab1a986 Author: dsimms Date: 2018-08-21 16:33 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/81246ab1a986 Post merge fixes ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psPromotionManager.cpp ! src/hotspot/share/gc/shared/memAllocator.cpp ! src/hotspot/share/memory/iterator.inline.hpp ! src/hotspot/share/memory/oopFactory.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/valueArrayKlass.cpp ! src/hotspot/share/oops/valueArrayKlass.hpp ! src/hotspot/share/oops/valueArrayKlass.inline.hpp ! src/hotspot/share/oops/valueKlass.cpp ! src/hotspot/share/oops/valueKlass.hpp ! src/hotspot/share/oops/valueKlass.inline.hpp ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/idealKit.cpp ! src/hotspot/share/opto/parse2.cpp ! src/hotspot/share/opto/valuetypenode.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/deoptimization.cpp From sergey.kuksenko at oracle.com Tue Aug 21 23:21:45 2018 From: sergey.kuksenko at oracle.com (Sergey Kuksenko) Date: Tue, 21 Aug 2018 16:21:45 -0700 Subject: optimizing acmp in L-World In-Reply-To: References: <47625659-9B0E-481C-B755-4C5C4E2DE23C@oracle.com> <6654e587-6e23-24ab-f992-5d2e28c8e8ac@oracle.com> Message-ID: <6f6a545e-6ccd-b807-fe64-ffaa87aa6290@oracle.com> Hi Tobias, On 08/17/2018 06:19 AM, Tobias Hartmann wrote: > > As John already pointed out, this only helps if we want the result in a register. Due to aggressive > inlining in C2, this is rarely the case but usually we need an explicit cmp/jmp to branch to the > corresponding target blocks. > > It's also not possible in the interpreter where we always explicitly branch. I want say that in case of branching code can be even simpler (below). > I've implemented this (-XX:+UseOldAcmp): > http://cr.openjdk.java.net/~thartmann/valhalla/lworld/acmp_optimization/webrev.00/ > > The generated code then looks like this: > > cmp %rdx,%rcx > jne is_ne > test %rcx,%rcx > je is_null > mov 0x8(%rcx),%r11d > mov %r11,%r10 > shr $0x3,%r10 > test $0x1,%r10 > jne is_ne > is_null: > mov $0x1,%eax > jmp end > is_ne: > xor %eax,%eax > end: I'd rather suggest in case of branching to replace mov 0x8(%rcx),%r11d mov %r11,%r10 shr $0x3,%r10 test $0x1,%r10 jne... with test 0x8(%rcx),$0x8 ?jne... It will save registers which may be visible on highly inlined code. > > I'm using this benchmark for evaluation: > http://cr.openjdk.java.net/~thartmann/valhalla/lworld/acmp_optimization/webrev.00/NewAcmpBenchmark.java > > Unfortunately, the results are highly dependent on profiling information and the resulting layout of > code. I've therefore executed the benchmark with -XX:-ProfileInterpreter. Here are the results: > > With -XX:+UseOldAcmp > Benchmark Mode Cnt Score Error Units > NewAcmpBenchmark.newCmpEqAll thrpt 5 44.109 ? 0.045 ops/us > NewAcmpBenchmark.newCmpEq_null_null thrpt 5 112.509 ? 0.073 ops/us > NewAcmpBenchmark.newCmpEq_null_o1 thrpt 5 149.950 ? 0.124 ops/us > NewAcmpBenchmark.newCmpEq_o1_null thrpt 5 149.960 ? 0.130 ops/us > NewAcmpBenchmark.newCmpEq_o1_o1 thrpt 5 132.312 ? 0.171 ops/us > NewAcmpBenchmark.newCmpEq_o1_o2 thrpt 5 140.188 ? 0.056 ops/us > NewAcmpBenchmark.newCmpEq_o2_o1 thrpt 5 140.119 ? 0.141 ops/us > > With -XX:-UseOldAcmp > Benchmark Mode Cnt Score Error Units > NewAcmpBenchmark.newCmpEqAll thrpt 5 41.727 ? 0.022 ops/us > NewAcmpBenchmark.newCmpEq_null_null thrpt 5 124.938 ? 0.088 ops/us > NewAcmpBenchmark.newCmpEq_null_o1 thrpt 5 139.842 ? 0.108 ops/us > NewAcmpBenchmark.newCmpEq_o1_null thrpt 5 149.930 ? 0.105 ops/us > NewAcmpBenchmark.newCmpEq_o1_o1 thrpt 5 138.952 ? 0.065 ops/us > NewAcmpBenchmark.newCmpEq_o1_o2 thrpt 5 131.435 ? 0.119 ops/us > NewAcmpBenchmark.newCmpEq_o2_o1 thrpt 5 131.307 ? 0.140 ops/us > > As expected, your version is better if a != b. In the a == b case, the current implementation is > better. If we are assuming that != is more common than == (like in the newCmpEqAll case), your > version is better. I need more time to check this. I just want to give you couple advices about microbenchmarks. - double DON_INLINE is not requred, having only on "cmpEq" is enough and you'll get less noisy invocations overhead. - dealing with small operations it's better to switch to benchmark mode to average time in nanoseconds - that allows to quickly notice if something wrong. > > Which acmp microbenchmarks are you using? I couldn't find any in the set of benchmarks that you've > pushed. I am still thinking how to make representative set of acmp micros, to properly cover inlined case as the most important. I'll push them when they will be ready. From david.holmes at oracle.com Wed Aug 22 02:40:31 2018 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 22 Aug 2018 02:40:31 +0000 Subject: hg: valhalla/valhalla: Merge Message-ID: <201808220240.w7M2eWO3018794@aojmv0008.oracle.com> Changeset: d462cfa9403c Author: dholmes Date: 2018-08-21 22:03 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d462cfa9403c Merge ! make/data/jdwp/jdwp.spec - make/data/symbols/java.base-6.sym.txt - make/data/symbols/java.compiler-6.sym.txt - make/data/symbols/java.desktop-6.sym.txt - make/data/symbols/java.logging-6.sym.txt - make/data/symbols/java.management-6.sym.txt - make/data/symbols/java.rmi-6.sym.txt - make/data/symbols/java.security.jgss-6.sym.txt - make/data/symbols/java.sql-6.sym.txt - make/data/symbols/java.sql.rowset-6.sym.txt - make/data/symbols/java.xml-6.sym.txt - make/data/symbols/java.xml.bind-6.sym.txt - make/data/symbols/java.xml.ws-6.sym.txt - make/data/symbols/java.xml.ws.annotation-6.sym.txt - make/data/symbols/jdk.management-6.sym.txt - make/data/symbols/jdk.sctp-6.sym.txt - make/data/symbols/jdk.security.jgss-6.sym.txt ! make/hotspot/symbols/symbols-unix - src/demo/share/applets.html - src/demo/share/applets/ArcTest/ArcTest.java - src/demo/share/applets/ArcTest/example1.html - src/demo/share/applets/BarChart/BarChart.java - src/demo/share/applets/BarChart/example1.html - src/demo/share/applets/BarChart/example2.html - src/demo/share/applets/Blink/Blink.java - src/demo/share/applets/Blink/example1.html - src/demo/share/applets/CardTest/CardTest.java - src/demo/share/applets/CardTest/example1.html - src/demo/share/applets/Clock/Clock.java - src/demo/share/applets/Clock/example1.html - src/demo/share/applets/DitherTest/DitherTest.java - src/demo/share/applets/DitherTest/example1.html - src/demo/share/applets/DrawTest/DrawTest.java - src/demo/share/applets/DrawTest/example1.html - src/demo/share/applets/Fractal/CLSFractal.java - src/demo/share/applets/Fractal/example1.html - src/demo/share/applets/GraphicsTest/AppletFrame.java - src/demo/share/applets/GraphicsTest/GraphicsTest.java - src/demo/share/applets/GraphicsTest/example1.html - src/demo/share/applets/MoleculeViewer/Matrix3D.java - src/demo/share/applets/MoleculeViewer/XYZApp.java - src/demo/share/applets/MoleculeViewer/example1.html - src/demo/share/applets/MoleculeViewer/example2.html - src/demo/share/applets/MoleculeViewer/example3.html - src/demo/share/applets/MoleculeViewer/models/HyaluronicAcid.xyz - src/demo/share/applets/MoleculeViewer/models/benzene.xyz - src/demo/share/applets/MoleculeViewer/models/buckminsterfullerine.xyz - src/demo/share/applets/MoleculeViewer/models/cyclohexane.xyz - src/demo/share/applets/MoleculeViewer/models/ethane.xyz - src/demo/share/applets/MoleculeViewer/models/water.xyz - src/demo/share/applets/NervousText/NervousText.java - src/demo/share/applets/NervousText/example1.html - src/demo/share/applets/SimpleGraph/GraphApplet.java - src/demo/share/applets/SimpleGraph/example1.html - src/demo/share/applets/SortDemo/BidirBubbleSortAlgorithm.java - src/demo/share/applets/SortDemo/BubbleSortAlgorithm.java - src/demo/share/applets/SortDemo/QSortAlgorithm.java - src/demo/share/applets/SortDemo/SortAlgorithm.java - src/demo/share/applets/SortDemo/SortItem.java - src/demo/share/applets/SortDemo/example1.html - src/demo/share/applets/SpreadSheet/SpreadSheet.java - src/demo/share/applets/SpreadSheet/example1.html - src/demo/share/applets/WireFrame/Matrix3D.java - src/demo/share/applets/WireFrame/ThreeD.java - src/demo/share/applets/WireFrame/example1.html - src/demo/share/applets/WireFrame/example2.html - src/demo/share/applets/WireFrame/example3.html - src/demo/share/applets/WireFrame/example4.html - src/demo/share/applets/WireFrame/models/cube.obj - src/demo/share/applets/WireFrame/models/dinasaur.obj - src/demo/share/applets/WireFrame/models/hughes_500.obj - src/demo/share/applets/WireFrame/models/knoxS.obj - src/demo/share/jfc/SwingApplet/README.txt - src/demo/share/jfc/SwingApplet/SwingApplet.html - src/demo/share/jfc/SwingApplet/SwingApplet.java ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp ! src/hotspot/cpu/arm/templateTable_arm.cpp ! src/hotspot/cpu/ppc/templateTable_ppc_64.cpp ! src/hotspot/cpu/s390/templateTable_s390.cpp ! src/hotspot/cpu/sparc/templateTable_sparc.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp - src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.inline.hpp - src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.inline.hpp - src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.inline.hpp - src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.inline.hpp - src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.inline.hpp - src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.inline.hpp - src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.inline.hpp - src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.inline.hpp - src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.inline.hpp - src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.inline.hpp - src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.inline.hpp - src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.inline.hpp - src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.inline.hpp ! src/hotspot/share/ci/ciField.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/stackMapFrame.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/code/dependencies.cpp - src/hotspot/share/gc/cms/cmsOopClosures.cpp - src/hotspot/share/gc/cms/cms_specialized_oop_closures.hpp - src/hotspot/share/gc/cms/parOopClosures.cpp - src/hotspot/share/gc/g1/g1StringDedupTable.cpp - src/hotspot/share/gc/g1/g1StringDedupTable.hpp - src/hotspot/share/gc/g1/g1StringDedupThread.cpp - src/hotspot/share/gc/g1/g1StringDedupThread.hpp - src/hotspot/share/gc/g1/g1_specialized_oop_closures.hpp - src/hotspot/share/gc/g1/ptrQueue.cpp - src/hotspot/share/gc/g1/ptrQueue.hpp - src/hotspot/share/gc/g1/satbMarkQueue.cpp - src/hotspot/share/gc/g1/satbMarkQueue.hpp - src/hotspot/share/gc/serial/serial_specialized_oop_closures.hpp - src/hotspot/share/gc/shared/genOopClosures.cpp - src/hotspot/share/gc/shared/specialized_oop_closures.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/heapInspection.hpp ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/arrayKlass.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmti.xml ! src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp ! src/hotspot/share/prims/jvmtiClassFileReconstituter.hpp ! src/hotspot/share/prims/jvmtiExport.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/methodHandles.cpp - src/hotspot/share/runtime/orderAccess.inline.hpp ! src/hotspot/share/runtime/reflection.cpp - src/hotspot/share/runtime/simpleThresholdPolicy.cpp - src/hotspot/share/runtime/simpleThresholdPolicy.hpp - src/hotspot/share/runtime/simpleThresholdPolicy.inline.hpp - src/java.base/aix/native/libjsig/jsig.c ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java ! src/java.base/share/classes/java/lang/reflect/Method.java ! src/java.base/share/classes/jdk/internal/org/objectweb/asm/Attribute.java ! src/java.base/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java ! src/java.base/share/classes/jdk/internal/reflect/Reflection.java ! src/java.base/share/classes/sun/invoke/util/VerifyAccess.java - src/java.base/share/classes/sun/net/NetworkServer.java - src/java.base/share/classes/sun/net/RegisteredDomain.java - src/java.base/share/classes/sun/net/URLCanonicalizer.java - src/java.base/share/classes/sun/security/ssl/ALPNExtension.java - src/java.base/share/classes/sun/security/ssl/Alerts.java - src/java.base/share/classes/sun/security/ssl/AppInputStream.java - src/java.base/share/classes/sun/security/ssl/AppOutputStream.java - src/java.base/share/classes/sun/security/ssl/ByteBufferInputStream.java - src/java.base/share/classes/sun/security/ssl/CertStatusReqExtension.java - src/java.base/share/classes/sun/security/ssl/CertStatusReqItemV2.java - src/java.base/share/classes/sun/security/ssl/CertStatusReqListV2Extension.java - src/java.base/share/classes/sun/security/ssl/CipherBox.java - src/java.base/share/classes/sun/security/ssl/CipherSuiteList.java - src/java.base/share/classes/sun/security/ssl/ClientHandshaker.java - src/java.base/share/classes/sun/security/ssl/ClientKeyExchangeService.java - src/java.base/share/classes/sun/security/ssl/DHCrypt.java - src/java.base/share/classes/sun/security/ssl/Debug.java - src/java.base/share/classes/sun/security/ssl/ECDHCrypt.java - src/java.base/share/classes/sun/security/ssl/EllipticPointFormatsExtension.java - src/java.base/share/classes/sun/security/ssl/ExtensionType.java - src/java.base/share/classes/sun/security/ssl/HandshakeInStream.java - src/java.base/share/classes/sun/security/ssl/HandshakeMessage.java - src/java.base/share/classes/sun/security/ssl/HandshakeStateManager.java - src/java.base/share/classes/sun/security/ssl/Handshaker.java - src/java.base/share/classes/sun/security/ssl/HelloExtension.java - src/java.base/share/classes/sun/security/ssl/HelloExtensions.java - src/java.base/share/classes/sun/security/ssl/MAC.java - src/java.base/share/classes/sun/security/ssl/MaxFragmentLengthExtension.java - src/java.base/share/classes/sun/security/ssl/NamedGroup.java - src/java.base/share/classes/sun/security/ssl/NamedGroupType.java - src/java.base/share/classes/sun/security/ssl/OCSPStatusRequest.java - src/java.base/share/classes/sun/security/ssl/ProtocolList.java - src/java.base/share/classes/sun/security/ssl/RenegotiationInfoExtension.java - src/java.base/share/classes/sun/security/ssl/ServerHandshaker.java - src/java.base/share/classes/sun/security/ssl/SignatureAndHashAlgorithm.java - src/java.base/share/classes/sun/security/ssl/StatusRequest.java - src/java.base/share/classes/sun/security/ssl/StatusRequestType.java - src/java.base/share/classes/sun/security/ssl/UnknownExtension.java - src/java.base/share/classes/sun/security/ssl/UnknownStatusRequest.java ! src/java.base/share/native/libjava/Class.c ! src/java.base/share/native/libjava/Reflection.c - src/java.desktop/linux/conf/oblique-fonts/fonts.dir - src/java.desktop/macosx/native/libsplashscreen/libpng/zlib.h - src/java.desktop/share/classes/sun/applet/AppletAudioClip.java - src/java.desktop/share/classes/sun/applet/AppletEvent.java - src/java.desktop/share/classes/sun/applet/AppletEventMulticaster.java - src/java.desktop/share/classes/sun/applet/AppletIOException.java - src/java.desktop/share/classes/sun/applet/AppletIllegalArgumentException.java - src/java.desktop/share/classes/sun/applet/AppletImageRef.java - src/java.desktop/share/classes/sun/applet/AppletListener.java - src/java.desktop/share/classes/sun/applet/AppletMessageHandler.java - src/java.desktop/share/classes/sun/applet/AppletObjectInputStream.java - src/java.desktop/share/classes/sun/applet/AppletPanel.java - src/java.desktop/share/classes/sun/applet/AppletProps.java - src/java.desktop/share/classes/sun/applet/AppletResourceLoader.java - src/java.desktop/share/classes/sun/applet/AppletSecurityException.java - src/java.desktop/share/classes/sun/applet/AppletViewer.java - src/java.desktop/share/classes/sun/applet/AppletViewerFactory.java - src/java.desktop/share/classes/sun/applet/AppletViewerPanel.java - src/java.desktop/share/classes/sun/applet/Main.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_de.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_es.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_fr.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_it.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_ja.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_ko.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_pt_BR.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_sv.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_zh_CN.java - src/java.desktop/share/classes/sun/applet/resources/MsgAppletViewer_zh_TW.java - src/java.desktop/share/classes/sun/awt/DesktopBrowse.java - src/java.desktop/share/classes/sun/print/DialogOnTop.java - src/java.desktop/share/classes/sun/print/DialogOwner.java - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cbdt-table.hh - src/java.desktop/unix/conf/fonts/fonts.dir ! src/java.instrument/share/classes/java/lang/instrument/Instrumentation.java - src/java.net.http/share/classes/jdk/internal/net/http/ImmutableHeaders.java - src/java.net.http/share/classes/jdk/internal/net/http/common/HttpHeadersImpl.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/ssl/KerberosPreMasterSecret.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/ssl/Krb5KeyExchangeService.java - src/java.sql.rowset/share/classes/javax/sql/rowset/package.html - src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/helper/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/Canonicalizer11.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/AbstractSerializer.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/AgreementMethod.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherData.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherReference.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/CipherValue.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/DocumentSerializer.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedData.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedKey.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptedType.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionMethod.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionProperties.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/EncryptionProperty.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/Reference.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/ReferenceList.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/Serializer.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/Transforms.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherInput.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipherParameters.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLEncryptionException.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/encryption/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/exceptions/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/keyvalues/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/content/x509/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/EncryptedKeyResolver.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/storage/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/resource/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementChecker.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/ElementCheckerImpl.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/EncryptionElementProxy.java - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/package.html - src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/package.html - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Target.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/AltHashing.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/StringTable.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/SymbolTable.java - src/jdk.internal.opt/share/classes/jdk/internal/joptsimple/MissingRequiredOptionException.java - src/jdk.internal.opt/share/classes/jdk/internal/joptsimple/UnacceptableNumberOfNonOptionsException.java - src/jdk.internal.opt/share/classes/jdk/internal/joptsimple/internal/Objects.java - src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntimeProvider.java - src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodUnresolved.java - src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotUnresolvedField.java - src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotUnresolvedJavaType.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64InstructionAttr.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugValueMap.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/aaa - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/IntrinsificationPredicate.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/hotspot/NotOnDebug.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphSpeculationLog.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/META-INF/services/javax.annotation.processing.Processor - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/APHotSpotSignature.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/AbstractVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/ClassSubstitutionVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/FoldVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/GeneratedFoldPlugin.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/GeneratedNodeIntrinsicPlugin.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/GeneratedPlugin.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/InjectedDependencies.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/MethodSubstitutionVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/NodeIntrinsicVerifier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/PluginGenerator.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.verifier/src/org/graalvm/compiler/replacements/verifier/VerifierAnnotationProcessor.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/classfile/D - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/jquery/jquery-1.10.2.js ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/NestHost_attribute.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/NestMembers_attribute.java ! src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java - test/hotspot/gtest/utilities/utilitiesHelper.inline.hpp ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/applications/ctw/modules/javafx_base.java - test/hotspot/jtreg/applications/ctw/modules/javafx_controls.java - test/hotspot/jtreg/applications/ctw/modules/javafx_fxml.java - test/hotspot/jtreg/applications/ctw/modules/javafx_graphics.java - test/hotspot/jtreg/applications/ctw/modules/javafx_media.java - test/hotspot/jtreg/applications/ctw/modules/javafx_swing.java - test/hotspot/jtreg/applications/ctw/modules/javafx_web.java - test/hotspot/jtreg/applications/jcstress/acqrel/Test.java - test/hotspot/jtreg/applications/jcstress/atomicity/Test.java - test/hotspot/jtreg/applications/jcstress/copy/Test.java - test/hotspot/jtreg/applications/jcstress/fences/Test.java - test/hotspot/jtreg/applications/jcstress/memeffects/Test.java - test/hotspot/jtreg/applications/jcstress/other/Test.java - test/hotspot/jtreg/applications/jcstress/seqcst.sync/Test.java - test/hotspot/jtreg/applications/jcstress/seqcst.volatiles/Test.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ResolvedJavaTypeResolveConcreteMethodTest.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ResolvedJavaTypeResolveMethodTest.java - test/hotspot/jtreg/gc/g1/TestStringSymbolTableStats.java ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestMembersEntry.jcod ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/BadNestMembersLength.jcod ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/ConflictingAttributesInNestMember.jcod ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TestFinalMethodOverride.java ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TestNestmateAttributes.java ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoNestHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/classFileParsing/TwoNestMembers.jcod ! test/hotspot/jtreg/runtime/Nestmates/legacy/TestPrivateLookup.java ! test/hotspot/jtreg/runtime/Nestmates/membership/CallerMissingHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/CallerNoHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/CallerNotInstanceHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/CallerNotOurHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost.java ! test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost2.java ! test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHost2Member.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/PackagedNestHostMember.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/TargetMissingHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/TargetNoHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/TargetNotInstanceHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/TargetNotOurHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/membership/TestNestmateMembership.java ! test/hotspot/jtreg/runtime/Nestmates/privateConstructors/ExternalSub.jcod ! test/hotspot/jtreg/runtime/Nestmates/privateConstructors/ExternalSuper.jcod ! test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestInvokeSpecial.java ! test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestMethodHandles.java ! test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestReflection.java ! test/hotspot/jtreg/runtime/Nestmates/privateFields/TestMethodHandles.java ! test/hotspot/jtreg/runtime/Nestmates/privateFields/TestPrivateField.java ! test/hotspot/jtreg/runtime/Nestmates/privateFields/TestReflection.java ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/ExternalSub.jcod ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/ExternalSuper.jcod ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingMethod.jcod ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingMethodWithSuper.jcod ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/MissingNestHost.jcod ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestInvoke.java ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestInvokeErrors.java ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestMethodHandles.java ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestReflection.java ! test/hotspot/jtreg/runtime/Nestmates/privateStaticFields/TestMethodHandles.java ! test/hotspot/jtreg/runtime/Nestmates/privateStaticFields/TestPrivateStaticField.java ! test/hotspot/jtreg/runtime/Nestmates/privateStaticFields/TestReflection.java ! test/hotspot/jtreg/runtime/Nestmates/privateStaticMethods/TestInvokeStatic.java ! test/hotspot/jtreg/runtime/Nestmates/privateStaticMethods/TestMethodHandles.java ! test/hotspot/jtreg/runtime/Nestmates/privateStaticMethods/TestReflection.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberMalformedHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberMissingHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNoHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNotInstanceHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostOfMemberNotOurHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostWithDuplicateMembers.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/HostWithSelfMember.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/Hosts.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/InvalidNestHost.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MalformedHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberMalformedHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberMissingHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNoHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNotInstanceHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/MemberNotOurHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHost.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHost.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHost2.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHost2Member.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/PackagedNestHostMember.jcod - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/SampleNest.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/TestReflectionAPI.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/TestSecurityManagerChecks.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/empty.policy - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/testPkg/Host.java - test/hotspot/jtreg/runtime/Nestmates/reflectionAPI/testPkg/Singleton.java ! test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java ! test/hotspot/jtreg/runtime/SelectionResolution/InvokeInterfaceICCE.java ! test/hotspot/jtreg/runtime/SelectionResolution/InvokeInterfaceSuccessTest.java - test/hotspot/jtreg/runtime/SharedArchiveFile/SASymbolTableTest.java - test/hotspot/jtreg/runtime/SharedArchiveFile/SASymbolTableTestAgent.java - test/hotspot/jtreg/runtime/appcds/MismatchedUseAppCDS.java - test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsHelper.java - test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsTests.java ! test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_Shared.java - test/hotspot/jtreg/runtime/appcds/test-classes/CheckIfShared.java - test/hotspot/jtreg/runtime/appcds/test-classes/jdk/dynalink/DynamicLinker.jasm - test/hotspot/jtreg/runtime/containers/docker/CPUSetsReader.java - test/hotspot/jtreg/runtime/containers/docker/Common.java - test/hotspot/jtreg/runtime/exceptionMsgs/IncompatibleClassChangeError/ICC_B.jasm - test/hotspot/jtreg/serviceability/sa/ClhsdbSymbol.java - test/hotspot/jtreg/serviceability/sa/ClhsdbSymbolTable.java - test/hotspot/jtreg/serviceability/tmtools/jstat/utils/ClassLoadUtils.java - test/hotspot/jtreg/serviceability/tmtools/jstat/utils/GeneratingClassLoader.java - test/hotspot/jtreg/serviceability/tmtools/jstat/utils/TemplateClass.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeap/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeap/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeap/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeapCore/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapHeapCore/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspace/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspace/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspace/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspaceCore/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspaceCore/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/JMapMetaspaceCore/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFile/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFile/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFile/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFileMetaspace/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFileMetaspace/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToFileMetaspace/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToPath/TEST.properties - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToPath/TestDescription.java - test/hotspot/jtreg/vmTestbase/heapdump/OnOOMToPath/run.sh - test/hotspot/jtreg/vmTestbase/heapdump/README - test/hotspot/jtreg/vmTestbase/heapdump/share/EatMemory.java - test/hotspot/jtreg/vmTestbase/heapdump/share/common.sh - test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach024/java.base/java/util/ServiceConfigurationError.java - test/hotspot/jtreg/vmTestbase/vm/mlvm/meth/share/transform/v2/MHSamTF.java ! test/jdk/ProblemList.txt - test/jdk/com/sun/jdi/ArrayLengthDumpTest.sh - test/jdk/com/sun/jdi/BreakpointWithFullGC.sh ! test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java - test/jdk/java/awt/Choice/SelectCurrentItemTest/SelectCurrentItemTest.html - test/jdk/java/awt/grab/MenuDragEvents/MenuDragEvents.html - test/jdk/java/lang/System/SetProperties.java - test/jdk/java/lang/Thread/StopThrowable.java ! test/jdk/java/lang/instrument/RedefineNestmateAttr/TestNestmateAttr.java ! test/jdk/java/lang/invoke/AccessControlTest.java ! test/jdk/java/lang/invoke/PrivateInterfaceCall.java ! test/jdk/java/lang/invoke/SpecialInterfaceCall.java - test/jdk/java/net/httpclient/ThrowingPublishers.java - test/jdk/java/net/httpclient/ThrowingPushPromises.java - test/jdk/java/net/httpclient/ThrowingSubscribers.java - test/jdk/java/net/httpclient/offline/FixedHttpHeaders.java - test/jdk/java/util/Formatter/NoGroupingUsed.java - test/jdk/javax/sound/midi/MidiSystem/DefaultProperties.java - test/jdk/javax/sound/midi/MidiSystem/testdata/conf/sound.properties - test/jdk/javax/sound/sampled/AudioSystem/DefaultProperties.java - test/jdk/javax/sound/sampled/AudioSystem/testdata/conf/sound.properties - test/jdk/javax/swing/JLayer/8041982/cupanim.gif - test/jdk/javax/swing/JSlider/4987336/cupanim.gif - test/jdk/javax/swing/JSpinner/6421058/bug6421058.java - test/jdk/javax/swing/JSpinner/WrongEditorTextFieldFont/WrongEditorTextFieldFont.java ! test/jdk/jdk/lambda/vm/InterfaceAccessFlagsTest.java - test/jdk/sanity/releaseFile/CheckSource.java - test/jdk/sun/applet/DeprecatedAppletViewer/DeprecatedAppletViewer.java - test/jdk/sun/applet/TEST.properties - test/jdk/sun/security/krb5/auto/SSL.java - test/jdk/sun/security/krb5/auto/SSLwithPerms.java - test/jdk/sun/security/krb5/auto/UnboundSSL.java - test/jdk/sun/security/krb5/auto/UnboundSSLMultipleKeys.java - test/jdk/sun/security/krb5/auto/UnboundSSLPrincipalProperty.java - test/jdk/sun/security/krb5/auto/UnboundSSLUtils.java - test/jdk/sun/security/krb5/auto/unbound.ssl.jaas.conf - test/jdk/sun/security/krb5/auto/unbound.ssl.policy - test/jdk/sun/security/ssl/ExtensionType/OptimalListSize.java - test/jdk/sun/security/ssl/SSLEngineImpl/CloseInboundException.java - test/jdk/sun/security/ssl/StatusStapling/RunStatReqSelect.java - test/jdk/sun/security/ssl/StatusStapling/TEST.properties - test/jdk/sun/security/ssl/StatusStapling/TestRun.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/BogusStatusRequest.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/CertStatusReqExtensionTests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/CertStatusReqItemV2Tests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/CertStatusReqListV2ExtensionTests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/OCSPStatusRequestTests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/StatusReqSelection.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/StatusResponseManagerTests.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/TestCase.java - test/jdk/sun/security/ssl/StatusStapling/java.base/sun/security/ssl/TestUtils.java - test/jdk/sun/text/resources/JavaTimeSupplementaryTest.java - test/jdk/sun/tools/jhsdb/AlternateHashingTest.java - test/jdk/sun/tools/jhsdb/LingeredAppWithAltHashing.java ! test/langtools/lib/annotations/annotations/classfile/ClassfileInspector.java - test/langtools/tools/javac/6558548/T6558548_6.out ! test/langtools/tools/javac/6917288/GraphicalInstallerTest.java ! test/langtools/tools/javac/6917288/T6917288.java ! test/langtools/tools/javac/7199823/InnerClassCannotBeVerified.java - test/langtools/tools/javac/8013179/T8013179.java - test/langtools/tools/javac/8013179/T8013179.out ! test/langtools/tools/javac/MethodParameters/AttributeVisitor.java - test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel1_6.out - test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel2_6.out - test/langtools/tools/javac/StringsInSwitch/NonConstantLabel6.out - test/langtools/tools/javac/StringsInSwitch/OneCaseSwitches.out - test/langtools/tools/javac/StringsInSwitch/RSCL1_6.out - test/langtools/tools/javac/StringsInSwitch/RSCL2_6.out - test/langtools/tools/javac/TryWithResources/BadTwr6.out - test/langtools/tools/javac/TryWithResources/BadTwrSyntax6.out - test/langtools/tools/javac/TryWithResources/PlainTry6.out - test/langtools/tools/javac/TryWithResources/TwrOnNonResource6.out - test/langtools/tools/javac/TryWithResources/WeirdTwr.out - test/langtools/tools/javac/annotations/repeatingAnnotations/WrongVersion6.out - test/langtools/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out ! test/langtools/tools/javac/classfiles/attributes/SourceFile/SyntheticClassTest.java ! test/langtools/tools/javac/classfiles/attributes/Synthetic/AccessToPrivateInnerClassMembersTest.java ! test/langtools/tools/javac/classfiles/attributes/Synthetic/AccessToPrivateSiblingsTest.java ! test/langtools/tools/javac/classfiles/attributes/Synthetic/BridgeMethodsForLambdaTest.java ! test/langtools/tools/javac/classfiles/attributes/innerclasses/InnerClassesInInnerClassTest.java ! test/langtools/tools/javac/classfiles/attributes/innerclasses/InnerClassesInInnerEnumTest.java ! test/langtools/tools/javac/classfiles/attributes/innerclasses/InnerClassesTest.java ! test/langtools/tools/javac/classfiles/attributes/innerclasses/InnerClassesTestBase.java - test/langtools/tools/javac/defaultMethods/static/StaticInvokeQualified6.out - test/langtools/tools/javac/defaultMethods/static/StaticInvokeSimple6.out - test/langtools/tools/javac/diags/examples/MethodInvokedWithWrongNumberOfArgs.java - test/langtools/tools/javac/diags/examples/MulticatchNotSupported.java - test/langtools/tools/javac/diags/examples/StringSwitchNotSupported.java - test/langtools/tools/javac/diags/examples/TryResourceNotSupported.java - test/langtools/tools/javac/diags/examples/TryWithoutCatchOrFinally.java - test/langtools/tools/javac/diags/examples/UnsupportedBinaryLiteral.java - test/langtools/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java - test/langtools/tools/javac/file/zip/8003512/LoadClassFromJava6CreatedJarTest.java - test/langtools/tools/javac/literals/BadBinaryLiterals.6.out - test/langtools/tools/javac/literals/BadUnderscoreLiterals.6.out ! test/langtools/tools/javac/nativeHeaders/NativeHeaderTest.java ! test/langtools/tools/javac/nestmates/CheckNestmateAttrs.java - test/langtools/tools/javac/processing/environment/round/AnnotatedElementInfo.java ! test/langtools/tools/javac/processing/model/completionfailure/NoAbortForBadClassFile.java - test/langtools/tools/javac/types/CastObjectToPrimitiveTest.out - test/langtools/tools/javac/warnings/6594914/T6594914b.out From tobias.hartmann at oracle.com Wed Aug 22 12:16:35 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 22 Aug 2018 14:16:35 +0200 Subject: RFR(S): 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" In-Reply-To: References: Message-ID: Hi Roland, thanks for the review! On 20.08.2018 17:55, Roland Westrelin wrote: > I wonder if it's sufficient to: > > 4373 assert(!obj->is_ValueType(), "value types don't support cloning"); > > i.e. if that's really impossible. Profile data could be inaccurate for > that code path I suppose. It took me a while and I've found a bug in mainline while trying to come up with a test for this (8209833) but it's possible. Since Object.clone() is protected, it can usually only be called from within a method of a deriving class (see test1). In this case the receiver is statically known to be a value type and we will bail out of the intrinsic code before reaching the assert (and value types cannot inherit from anything other than interfaces). However, we can call Object.clone() on a value type receiver by making it accessible through reflection. C2 will still try to predict the call and speculate on the receiver type but we can disable that via -XX:-UseTypeProfile. Here's the new webrev: http://cr.openjdk.java.net/~thartmann/8209702/webrev.01/ I changed the implementation such that we now always take the slow path instead of bailing out if the receiver is a value type. Thanks, Tobias From tobias.hartmann at oracle.com Wed Aug 22 12:19:10 2018 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Wed, 22 Aug 2018 12:19:10 +0000 Subject: hg: valhalla/valhalla: 8209687: [lworld] C2 compilation crashes in AddPNode::Value Message-ID: <201808221219.w7MCJA96025414@aojmv0008.oracle.com> Changeset: bc48956c7832 Author: thartmann Date: 2018-08-22 14:18 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bc48956c7832 8209687: [lworld] C2 compilation crashes in AddPNode::Value Reviewed-by: roland ! src/hotspot/share/opto/parse2.cpp + test/hotspot/jtreg/compiler/valhalla/valuetypes/TestOptimizeKlassCmp.java From uberto.gama at gmail.com Wed Aug 22 14:49:31 2018 From: uberto.gama at gmail.com (Uberto Barbini) Date: Wed, 22 Aug 2018 15:49:31 +0100 Subject: Feedback on LW1 EAR In-Reply-To: <82c3335c-147a-bfdd-e24e-2598f25568ed@oracle.com> References: <82c3335c-147a-bfdd-e24e-2598f25568ed@oracle.com> Message-ID: thanks Tobias, I saw you already fixed it! Uberto On Mon, 20 Aug 2018 at 09:41, Tobias Hartmann wrote: > Hi Uberto, > > first of all, thanks a lot for trying out LW1 EA and for reporting these > issues! > > The crash is a bug in the just-in-time (JIT) compiler when compiling the > WatchV:equals method, I've > filed [1] and will work on a fix. > > As a temporary workaround you can disable JIT compilation of the affected > method via > -XX:CompileCommand=exclude,"Knapsack\$WatchV::equals" or disable JIT > compilation altogether by > adding the -Xint command line flag (unfortunately, both options will slow > down execution a lot but > it should be good enough for non-performance testing). > > Thanks, > Tobias > > [1] https://bugs.openjdk.java.net/browse/JDK-8209687 > > > On 18.08.2018 12:40, Uberto Barbini wrote: > > 5) I saw that I can override toString() and call super.toString() to have > > the standard Object behavior. I wonder if there will be some kind of base > > class for all ValueTypes or not. > > > > > > Then I've tried to replace some immutable classes into Value Types use > them > > in my other projects. > > The main hindrance has been the missing support for generics. > > As workaround I've created a interface and based the collection on the > > interface. It worked in a few projects but I had a Fatal Error on a > simple > > algorithm. I've tried to understand the exact problem but the same code > > seems to work as standalone project... If it's something worth > > investigating I can dig it more > > > > > https://github.com/uberto/eopi/blob/ValhallaLW01/src/test/java/com/gamasoft/eopi/cap17_DynamicProgramming/KnapsackTest.java > > > > > > # > > # A fatal error has been detected by the Java Runtime Environment: > > # > > # SIGSEGV (0xb) at pc=0x00007f08c3d648aa, pid=18399, tid=18426 > > # > > # JRE version: OpenJDK Runtime Environment (11.0) (build > > 11-lworldea+0-2018-07-30-1734349.david.simms.valhalla) > > # Java VM: OpenJDK 64-Bit Server VM > > (11-lworldea+0-2018-07-30-1734349.david.simms.valhalla, mixed mode, > > compressed oops, g1 gc, linux-amd64) > > # Problematic frame: > > # V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a > > # > > # No core dump will be written. Core dumps have been disabled. To enable > > core dumping, try "ulimit -c unlimited" before starting Java again > > # > > # If you would like to submit a bug report, please visit: > > # http://bugreport.java.com/bugreport/crash.jsp > > # > From tobias.hartmann at oracle.com Wed Aug 22 14:58:33 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 22 Aug 2018 16:58:33 +0200 Subject: Feedback on LW1 EAR In-Reply-To: References: <82c3335c-147a-bfdd-e24e-2598f25568ed@oracle.com> Message-ID: <07266eb5-c828-f312-b3dd-6c021fa90336@oracle.com> On 22.08.2018 16:49, Uberto Barbini wrote: > thanks Tobias, I saw you already fixed it! Yes, thanks again for reporting! It might take a bit until we release another EA build that includes the fix though (but of course you can just build the JVM from the sources on your own). Best regards, Tobias > On Mon, 20 Aug 2018 at 09:41, Tobias Hartmann > wrote: > > Hi Uberto, > > first of all, thanks a lot for trying out LW1 EA and for reporting these issues! > > The crash is a bug in the just-in-time (JIT) compiler when compiling the WatchV:equals method, I've > filed [1] and will work on a fix. > > As a temporary workaround you can disable JIT compilation of the affected method via > -XX:CompileCommand=exclude,"Knapsack\$WatchV::equals" or disable JIT compilation altogether by > adding the -Xint command line flag (unfortunately, both options will slow down execution a lot but > it should be good enough for non-performance testing). > > Thanks, > Tobias > > [1] https://bugs.openjdk.java.net/browse/JDK-8209687 > > > On 18.08.2018 12:40, Uberto Barbini wrote: > > 5) I saw that I can override toString() and call super.toString() to have > > the standard Object behavior. I wonder if there will be some kind of base > > class for all ValueTypes or not. > > > > > > Then I've tried to replace some immutable classes into Value Types use them > > in my other projects. > > The main hindrance has been the missing support for generics. > > As workaround I've created a interface and based the collection on the > > interface. It worked in a few projects but I had a Fatal Error on a simple > > algorithm. I've tried to understand the exact problem but the same code > > seems to work as standalone project... If it's something worth > > investigating I can dig it more > > > > > https://github.com/uberto/eopi/blob/ValhallaLW01/src/test/java/com/gamasoft/eopi/cap17_DynamicProgramming/KnapsackTest.java > > > > > > # > > # A fatal error has been detected by the Java Runtime Environment: > > # > > #? SIGSEGV (0xb) at pc=0x00007f08c3d648aa, pid=18399, tid=18426 > > # > > # JRE version: OpenJDK Runtime Environment (11.0) (build > > 11-lworldea+0-2018-07-30-1734349.david.simms.valhalla) > > # Java VM: OpenJDK 64-Bit Server VM > > (11-lworldea+0-2018-07-30-1734349.david.simms.valhalla, mixed mode, > > compressed oops, g1 gc, linux-amd64) > > # Problematic frame: > > # V? [libjvm.so+0x4148aa]? AddPNode::Value(PhaseGVN*) const+0x7a > > # > > # No core dump will be written. Core dumps have been disabled. To enable > > core dumping, try "ulimit -c unlimited" before starting Java again > > # > > # If you would like to submit a bug report, please visit: > > #? ?http://bugreport.java.com/bugreport/crash.jsp > > # > From uberto.gama at gmail.com Wed Aug 22 15:14:48 2018 From: uberto.gama at gmail.com (Uberto Barbini) Date: Wed, 22 Aug 2018 16:14:48 +0100 Subject: Feedback on LW1 EAR In-Reply-To: References: Message-ID: Hi Srikanth, thanks for your illuminating reply. Introducing ValueTypes on others projects I found another curious issue, seems more a javac issue but not sure. concurrentHashMap.computeIfPresent (and the other similar methods) raise an error if the map is inside a ValueType. Other map methods (like the commented code) works fine. __ByValue public class UserAccounts { public final Map accounts = new ConcurrentHashMap<>(); public void addReturnToUser(String userName, double amount){ // Double prev = accounts.get(userName); // if ( prev != null) { // accounts.put(userName, amount + prev); // } accounts.computeIfPresent(userName, (String u, Double a) -> amount + a); } ... (full code here https://github.com/uberto/restApiCalculator/blob/valhalla/src/main/java/com/gamasoft/model/UserAccounts.java ) ---- Error java.lang.IncompatibleClassChangeError: constant pool com.gamasoft.model.UserAccounts$$Lambda$29/0x00000008000ba440 inconsistent value type: com.gamasoft.model.UserAccounts at java.base/java.util.concurrent.ConcurrentHashMap.computeIfPresent(ConcurrentHashMap.java:1836) at com.gamasoft.model.UserAccounts.addReturnToUser(UserAccounts.java:27) at com.gamasoft.model.CompoundInterestTest.addReturnToUserAccount(CompoundInterestTest.java:55) ... Process finished with exit code 255 > In slightly longer term, we are also asking the question whether == > should simply be translated into the equals method call by javac where > it can statically discern the operands to be values. > For what is worth, this solution sounds very attractive and promising to me. Maybe the same could be extended to some other operands as well... :))) > > 5) I saw that I can override toString() and call super.toString() to have > > the standard Object behavior. > This should have been rejected by javac. That it is not is a defect I > would say. > Ok makes sense. I found being able to call on Object base methods is a bit confusing. Uberto > Date: Mon, 20 Aug 2018 10:41:15 +0200 > From: Tobias Hartmann > To: Uberto Barbini , > valhalla-dev at openjdk.java.net > Subject: Re: Feedback on LW1 EAR > Message-ID: <82c3335c-147a-bfdd-e24e-2598f25568ed at oracle.com> > Content-Type: text/plain; charset=utf-8 > > Hi Uberto, > > first of all, thanks a lot for trying out LW1 EA and for reporting these > issues! > > The crash is a bug in the just-in-time (JIT) compiler when compiling the > WatchV:equals method, I've > filed [1] and will work on a fix. > > As a temporary workaround you can disable JIT compilation of the affected > method via > -XX:CompileCommand=exclude,"Knapsack\$WatchV::equals" or disable JIT > compilation altogether by > adding the -Xint command line flag (unfortunately, both options will slow > down execution a lot but > it should be good enough for non-performance testing). > > Thanks, > Tobias > > [1] https://bugs.openjdk.java.net/browse/JDK-8209687 > > > On 18.08.2018 12:40, Uberto Barbini wrote: > > 5) I saw that I can override toString() and call super.toString() to have > > the standard Object behavior. I wonder if there will be some kind of base > > class for all ValueTypes or not. > > > > > > Then I've tried to replace some immutable classes into Value Types use > them > > in my other projects. > > The main hindrance has been the missing support for generics. > > As workaround I've created a interface and based the collection on the > > interface. It worked in a few projects but I had a Fatal Error on a > simple > > algorithm. I've tried to understand the exact problem but the same code > > seems to work as standalone project... If it's something worth > > investigating I can dig it more > > > > > https://github.com/uberto/eopi/blob/ValhallaLW01/src/test/java/com/gamasoft/eopi/cap17_DynamicProgramming/KnapsackTest.java > > > > > > # > > # A fatal error has been detected by the Java Runtime Environment: > > # > > # SIGSEGV (0xb) at pc=0x00007f08c3d648aa, pid=18399, tid=18426 > > # > > # JRE version: OpenJDK Runtime Environment (11.0) (build > > 11-lworldea+0-2018-07-30-1734349.david.simms.valhalla) > > # Java VM: OpenJDK 64-Bit Server VM > > (11-lworldea+0-2018-07-30-1734349.david.simms.valhalla, mixed mode, > > compressed oops, g1 gc, linux-amd64) > > # Problematic frame: > > # V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a > > # > > # No core dump will be written. Core dumps have been disabled. To enable > > core dumping, try "ulimit -c unlimited" before starting Java again > > # > > # If you would like to submit a bug report, please visit: > > # http://bugreport.java.com/bugreport/crash.jsp > > # > > > End of valhalla-dev Digest, Vol 48, Issue 13 > ******************************************** > From rwestrel at redhat.com Wed Aug 22 15:41:37 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 22 Aug 2018 17:41:37 +0200 Subject: RFR(S): 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" In-Reply-To: References: Message-ID: > However, we can call Object.clone() on a value type receiver by making it accessible through > reflection. C2 will still try to predict the call and speculate on the receiver type but we can > disable that via -XX:-UseTypeProfile. I'm confused by this. You're saying it's possible to call Object.clone() with a value receiver? In that case, don't we need a runtime check that clone is not called on value receiver? Roland. From tobias.hartmann at oracle.com Thu Aug 23 06:51:45 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 23 Aug 2018 08:51:45 +0200 Subject: RFR(S): 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" In-Reply-To: References: Message-ID: <069d3058-81c8-1011-073f-1d12d1e8b772@oracle.com> Hi Roland, On 22.08.2018 17:41, Roland Westrelin wrote: >> However, we can call Object.clone() on a value type receiver by making it accessible through >> reflection. C2 will still try to predict the call and speculate on the receiver type but we can >> disable that via -XX:-UseTypeProfile. > > I'm confused by this. You're saying it's possible to call Object.clone() > with a value receiver? Yes, via reflection. > In that case, don't we need a runtime check that > clone is not called on value receiver? Yes but the check for JVM_ACC_IS_CLONEABLE_FAST [1] is sufficient because value types can never implement the Cloneable interface [2] and we'll therefore always go to the slow path. Best regards, Tobias [1] http://hg.openjdk.java.net/valhalla/valhalla/file/bc48956c7832/src/hotspot/share/opto/library_call.cpp#l4478 [2] http://hg.openjdk.java.net/valhalla/valhalla/file/bc48956c7832/src/hotspot/share/classfile/classFileParser.cpp#l4753 From david.simms at oracle.com Thu Aug 23 08:57:34 2018 From: david.simms at oracle.com (david.simms at oracle.com) Date: Thu, 23 Aug 2018 08:57:34 +0000 Subject: hg: valhalla/valhalla: Fixed timeout on debug builds Message-ID: <201808230857.w7N8vZIv023408@aojmv0008.oracle.com> Changeset: 36d08ece871f Author: dsimms Date: 2018-08-22 12:07 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/36d08ece871f Fixed timeout on debug builds ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypesTest.java From forax at univ-mlv.fr Thu Aug 23 10:54:45 2018 From: forax at univ-mlv.fr (Remi Forax) Date: Thu, 23 Aug 2018 12:54:45 +0200 (CEST) Subject: Feedback on LW1 EAR In-Reply-To: References: Message-ID: <677440712.536216.1535021685395.JavaMail.zimbra@u-pem.fr> Hi Uberto, ----- Mail original ----- > De: "Uberto Barbini" > ?: "valhalla-dev" > Envoy?: Mercredi 22 Ao?t 2018 17:14:48 > Objet: Re: Feedback on LW1 EAR > Hi Srikanth, > > thanks for your illuminating reply. > > Introducing ValueTypes on others projects I found another curious issue, > seems more a javac issue but not sure. > concurrentHashMap.computeIfPresent (and the other similar methods) raise an > error if the map is inside a ValueType. Other map methods (like the > commented code) works fine. It's more a bug for Mandy, i.e. it's a JDK issue and not a compiler issue. When creating the lambda proxy, the object that will implement the functional interface and redirect the call to the lambda body, we have forgotten the case where the lambda body is itself declared in a value type. A simple code like below reproduces the issue. public __ByValue class LambdaDesugar { private final int value; public LambdaDesugar() { this.value = 0; } public static void main(String[] args) { Runnable r = () -> { System.out.println("hello lambda inside a value type"); }; r.run(); } } cheers, R?mi > > > __ByValue public class UserAccounts { > > public final Map accounts = new ConcurrentHashMap<>(); > > public void addReturnToUser(String userName, double amount){ > > // Double prev = accounts.get(userName); > // if ( prev != null) { > // accounts.put(userName, amount + prev); > // } > accounts.computeIfPresent(userName, (String u, Double a) -> amount > + a); > } > ... > > (full code here > https://github.com/uberto/restApiCalculator/blob/valhalla/src/main/java/com/gamasoft/model/UserAccounts.java > ) > > ---- Error > java.lang.IncompatibleClassChangeError: constant pool > com.gamasoft.model.UserAccounts$$Lambda$29/0x00000008000ba440 inconsistent > value type: com.gamasoft.model.UserAccounts > > at > java.base/java.util.concurrent.ConcurrentHashMap.computeIfPresent(ConcurrentHashMap.java:1836) > at com.gamasoft.model.UserAccounts.addReturnToUser(UserAccounts.java:27) > at > com.gamasoft.model.CompoundInterestTest.addReturnToUserAccount(CompoundInterestTest.java:55) > ... > Process finished with exit code 255 > > > > > > >> In slightly longer term, we are also asking the question whether == >> should simply be translated into the equals method call by javac where >> it can statically discern the operands to be values. >> > > For what is worth, this solution sounds very attractive and promising to me. > Maybe the same could be extended to some other operands as well... :))) > > >> > 5) I saw that I can override toString() and call super.toString() to have >> > the standard Object behavior. >> This should have been rejected by javac. That it is not is a defect I >> would say. >> > > Ok makes sense. I found being able to call on Object base methods is a bit > confusing. > > > Uberto > > > > > > > >> Date: Mon, 20 Aug 2018 10:41:15 +0200 >> From: Tobias Hartmann >> To: Uberto Barbini , >> valhalla-dev at openjdk.java.net >> Subject: Re: Feedback on LW1 EAR >> Message-ID: <82c3335c-147a-bfdd-e24e-2598f25568ed at oracle.com> >> Content-Type: text/plain; charset=utf-8 >> >> Hi Uberto, >> >> first of all, thanks a lot for trying out LW1 EA and for reporting these >> issues! >> >> The crash is a bug in the just-in-time (JIT) compiler when compiling the >> WatchV:equals method, I've >> filed [1] and will work on a fix. >> >> As a temporary workaround you can disable JIT compilation of the affected >> method via >> -XX:CompileCommand=exclude,"Knapsack\$WatchV::equals" or disable JIT >> compilation altogether by >> adding the -Xint command line flag (unfortunately, both options will slow >> down execution a lot but >> it should be good enough for non-performance testing). >> >> Thanks, >> Tobias >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8209687 >> >> >> On 18.08.2018 12:40, Uberto Barbini wrote: >> > 5) I saw that I can override toString() and call super.toString() to have >> > the standard Object behavior. I wonder if there will be some kind of base >> > class for all ValueTypes or not. >> > >> > >> > Then I've tried to replace some immutable classes into Value Types use >> them >> > in my other projects. >> > The main hindrance has been the missing support for generics. >> > As workaround I've created a interface and based the collection on the >> > interface. It worked in a few projects but I had a Fatal Error on a >> simple >> > algorithm. I've tried to understand the exact problem but the same code >> > seems to work as standalone project... If it's something worth >> > investigating I can dig it more >> > >> > >> https://github.com/uberto/eopi/blob/ValhallaLW01/src/test/java/com/gamasoft/eopi/cap17_DynamicProgramming/KnapsackTest.java >> > >> > >> > # >> > # A fatal error has been detected by the Java Runtime Environment: >> > # >> > # SIGSEGV (0xb) at pc=0x00007f08c3d648aa, pid=18399, tid=18426 >> > # >> > # JRE version: OpenJDK Runtime Environment (11.0) (build >> > 11-lworldea+0-2018-07-30-1734349.david.simms.valhalla) >> > # Java VM: OpenJDK 64-Bit Server VM >> > (11-lworldea+0-2018-07-30-1734349.david.simms.valhalla, mixed mode, >> > compressed oops, g1 gc, linux-amd64) >> > # Problematic frame: >> > # V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a >> > # >> > # No core dump will be written. Core dumps have been disabled. To enable >> > core dumping, try "ulimit -c unlimited" before starting Java again >> > # >> > # If you would like to submit a bug report, please visit: >> > # http://bugreport.java.com/bugreport/crash.jsp >> > # >> >> >> End of valhalla-dev Digest, Vol 48, Issue 13 >> ******************************************** From uberto.gama at gmail.com Thu Aug 23 12:38:43 2018 From: uberto.gama at gmail.com (Uberto Barbini) Date: Thu, 23 Aug 2018 13:38:43 +0100 Subject: Feedback on LW1 EAR In-Reply-To: <677440712.536216.1535021685395.JavaMail.zimbra@u-pem.fr> References: <677440712.536216.1535021685395.JavaMail.zimbra@u-pem.fr> Message-ID: Yes, indeed you cannot call any lambda defined inside in a ValueClass. Playing a bit with breakpoint, it seems that curiously enough toString() method on ValueClass (the automatically created one I mean) is using a lambda without problem, probably because the lambda is defined somewhere else. I've also realized that I have no idea how would the binary compatibility of a TypeValue be considered... Thanks Uberto On Thu, 23 Aug 2018 at 11:54, Remi Forax wrote: > Hi Uberto, > > ----- Mail original ----- > > De: "Uberto Barbini" > > ?: "valhalla-dev" > > Envoy?: Mercredi 22 Ao?t 2018 17:14:48 > > Objet: Re: Feedback on LW1 EAR > > > Hi Srikanth, > > > > thanks for your illuminating reply. > > > > Introducing ValueTypes on others projects I found another curious issue, > > seems more a javac issue but not sure. > > concurrentHashMap.computeIfPresent (and the other similar methods) raise > an > > error if the map is inside a ValueType. Other map methods (like the > > commented code) works fine. > > It's more a bug for Mandy, i.e. it's a JDK issue and not a compiler issue. > When creating the lambda proxy, the object that will implement the > functional interface and redirect the call to the lambda body, > we have forgotten the case where the lambda body is itself declared in a > value type. > > A simple code like below reproduces the issue. > > public __ByValue class LambdaDesugar { > private final int value; > public LambdaDesugar() { this.value = 0; } > > public static void main(String[] args) { > Runnable r = () -> { > System.out.println("hello lambda inside a value type"); > }; > r.run(); > } > } > > cheers, > R?mi > > > > > > > __ByValue public class UserAccounts { > > > > public final Map accounts = new ConcurrentHashMap<>(); > > > > public void addReturnToUser(String userName, double amount){ > > > > // Double prev = accounts.get(userName); > > // if ( prev != null) { > > // accounts.put(userName, amount + prev); > > // } > > accounts.computeIfPresent(userName, (String u, Double a) -> amount > > + a); > > } > > ... > > > > (full code here > > > https://github.com/uberto/restApiCalculator/blob/valhalla/src/main/java/com/gamasoft/model/UserAccounts.java > > ) > > > > ---- Error > > java.lang.IncompatibleClassChangeError: constant pool > > com.gamasoft.model.UserAccounts$$Lambda$29/0x00000008000ba440 > inconsistent > > value type: com.gamasoft.model.UserAccounts > > > > at > > > java.base/java.util.concurrent.ConcurrentHashMap.computeIfPresent(ConcurrentHashMap.java:1836) > > at com.gamasoft.model.UserAccounts.addReturnToUser(UserAccounts.java:27) > > at > > > com.gamasoft.model.CompoundInterestTest.addReturnToUserAccount(CompoundInterestTest.java:55) > > ... > > Process finished with exit code 255 > > > > > > > > > > > > > >> In slightly longer term, we are also asking the question whether == > >> should simply be translated into the equals method call by javac where > >> it can statically discern the operands to be values. > >> > > > > For what is worth, this solution sounds very attractive and promising to > me. > > Maybe the same could be extended to some other operands as well... :))) > > > > > >> > 5) I saw that I can override toString() and call super.toString() to > have > >> > the standard Object behavior. > >> This should have been rejected by javac. That it is not is a defect I > >> would say. > >> > > > > Ok makes sense. I found being able to call on Object base methods is a > bit > > confusing. > > > > > > Uberto > > > > > > > > > > > > > > > >> Date: Mon, 20 Aug 2018 10:41:15 +0200 > >> From: Tobias Hartmann > >> To: Uberto Barbini , > >> valhalla-dev at openjdk.java.net > >> Subject: Re: Feedback on LW1 EAR > >> Message-ID: <82c3335c-147a-bfdd-e24e-2598f25568ed at oracle.com> > >> Content-Type: text/plain; charset=utf-8 > >> > >> Hi Uberto, > >> > >> first of all, thanks a lot for trying out LW1 EA and for reporting these > >> issues! > >> > >> The crash is a bug in the just-in-time (JIT) compiler when compiling the > >> WatchV:equals method, I've > >> filed [1] and will work on a fix. > >> > >> As a temporary workaround you can disable JIT compilation of the > affected > >> method via > >> -XX:CompileCommand=exclude,"Knapsack\$WatchV::equals" or disable JIT > >> compilation altogether by > >> adding the -Xint command line flag (unfortunately, both options will > slow > >> down execution a lot but > >> it should be good enough for non-performance testing). > >> > >> Thanks, > >> Tobias > >> > >> [1] https://bugs.openjdk.java.net/browse/JDK-8209687 > >> > >> > >> On 18.08.2018 12:40, Uberto Barbini wrote: > >> > 5) I saw that I can override toString() and call super.toString() to > have > >> > the standard Object behavior. I wonder if there will be some kind of > base > >> > class for all ValueTypes or not. > >> > > >> > > >> > Then I've tried to replace some immutable classes into Value Types use > >> them > >> > in my other projects. > >> > The main hindrance has been the missing support for generics. > >> > As workaround I've created a interface and based the collection on the > >> > interface. It worked in a few projects but I had a Fatal Error on a > >> simple > >> > algorithm. I've tried to understand the exact problem but the same > code > >> > seems to work as standalone project... If it's something worth > >> > investigating I can dig it more > >> > > >> > > >> > https://github.com/uberto/eopi/blob/ValhallaLW01/src/test/java/com/gamasoft/eopi/cap17_DynamicProgramming/KnapsackTest.java > >> > > >> > > >> > # > >> > # A fatal error has been detected by the Java Runtime Environment: > >> > # > >> > # SIGSEGV (0xb) at pc=0x00007f08c3d648aa, pid=18399, tid=18426 > >> > # > >> > # JRE version: OpenJDK Runtime Environment (11.0) (build > >> > 11-lworldea+0-2018-07-30-1734349.david.simms.valhalla) > >> > # Java VM: OpenJDK 64-Bit Server VM > >> > (11-lworldea+0-2018-07-30-1734349.david.simms.valhalla, mixed mode, > >> > compressed oops, g1 gc, linux-amd64) > >> > # Problematic frame: > >> > # V [libjvm.so+0x4148aa] AddPNode::Value(PhaseGVN*) const+0x7a > >> > # > >> > # No core dump will be written. Core dumps have been disabled. To > enable > >> > core dumping, try "ulimit -c unlimited" before starting Java again > >> > # > >> > # If you would like to submit a bug report, please visit: > >> > # http://bugreport.java.com/bugreport/crash.jsp > >> > # > >> > >> > >> End of valhalla-dev Digest, Vol 48, Issue 13 > >> ******************************************** > From david.simms at oracle.com Thu Aug 23 13:27:23 2018 From: david.simms at oracle.com (david.simms at oracle.com) Date: Thu, 23 Aug 2018 13:27:23 +0000 Subject: hg: valhalla/valhalla: Bad merge, more parentheses Message-ID: <201808231327.w7NDRO7q014260@aojmv0008.oracle.com> Changeset: 4fb4a8f09092 Author: dsimms Date: 2018-08-23 15:25 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4fb4a8f09092 Bad merge, more parentheses ! src/hotspot/share/compiler/oopMap.cpp From harold.seigel at oracle.com Thu Aug 23 14:13:28 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Thu, 23 Aug 2018 10:13:28 -0400 Subject: RFR for small build compilation fix Message-ID: <0e49ee67-89e2-498a-070d-e1d52c7e122a@oracle.com> Hi, Please review this small change to fix building with --disable-precompiled-headers. Webrev: http://cr.openjdk.java.net/~hseigel/valueArrayKlassFix/webrev/ Thanks, Harold From harold.seigel at oracle.com Thu Aug 23 14:14:54 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Thu, 23 Aug 2018 10:14:54 -0400 Subject: RFR for small build compilation fix In-Reply-To: <0e49ee67-89e2-498a-070d-e1d52c7e122a@oracle.com> References: <0e49ee67-89e2-498a-070d-e1d52c7e122a@oracle.com> Message-ID: <1d913ae2-5f60-7952-890c-f977c79317ff@oracle.com> (This is an LWorld change.) On 8/23/2018 10:13 AM, Harold David Seigel wrote: > Hi, > > Please review this small change to fix building with > --disable-precompiled-headers. > > Webrev: http://cr.openjdk.java.net/~hseigel/valueArrayKlassFix/webrev/ > > Thanks, Harold > From david.simms at oracle.com Thu Aug 23 14:41:04 2018 From: david.simms at oracle.com (David Simms) Date: Thu, 23 Aug 2018 16:41:04 +0200 Subject: RFR for small build compilation fix In-Reply-To: <1d913ae2-5f60-7952-890c-f977c79317ff@oracle.com> References: <0e49ee67-89e2-498a-070d-e1d52c7e122a@oracle.com> <1d913ae2-5f60-7952-890c-f977c79317ff@oracle.com> Message-ID: Push it... On 23/08/18 16:14, Harold David Seigel wrote: > (This is an LWorld change.) > > > On 8/23/2018 10:13 AM, Harold David Seigel wrote: >> Hi, >> >> Please review this small change to fix building with >> --disable-precompiled-headers. >> >> Webrev: http://cr.openjdk.java.net/~hseigel/valueArrayKlassFix/webrev/ >> >> Thanks, Harold >> > From harold.seigel at oracle.com Thu Aug 23 14:43:39 2018 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Thu, 23 Aug 2018 14:43:39 +0000 Subject: hg: valhalla/valhalla: Summary: Add missing #include to fix build with no precompiled headers Message-ID: <201808231443.w7NEhdG2008023@aojmv0008.oracle.com> Changeset: d8a6985f0b99 Author: hseigel Date: 2018-08-23 10:43 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d8a6985f0b99 Summary: Add missing #include to fix build with no precompiled headers Reviewed-by: dsimms ! src/hotspot/share/oops/valueArrayKlass.cpp From mandy.chung at oracle.com Thu Aug 23 14:55:46 2018 From: mandy.chung at oracle.com (mandy chung) Date: Thu, 23 Aug 2018 09:55:46 -0500 Subject: Feedback on LW1 EAR In-Reply-To: <677440712.536216.1535021685395.JavaMail.zimbra@u-pem.fr> References: <677440712.536216.1535021685395.JavaMail.zimbra@u-pem.fr> Message-ID: <25a320df-e1b3-63e1-1755-5b419a0118dd@oracle.com> Uberto, thanks for reporting this. Thanks Remi for looking into it. I file https://bugs.openjdk.java.net/browse/JDK-8209896 for this issue. I'm OOO this week and will look into it when I return next week. Mandy On 8/23/18 5:54 AM, Remi Forax wrote: > Hi Uberto, > >> Hi Srikanth, >> >> thanks for your illuminating reply. >> >> Introducing ValueTypes on others projects I found another curious issue, >> seems more a javac issue but not sure. >> concurrentHashMap.computeIfPresent (and the other similar methods) raise an >> error if the map is inside a ValueType. Other map methods (like the >> commented code) works fine. > > It's more a bug for Mandy, i.e. it's a JDK issue and not a compiler issue. > When creating the lambda proxy, the object that will implement the functional > interface and redirect the call to the lambda body, > we have forgotten the case where the lambda body is itself declared in a value type. > > A simple code like below reproduces the issue. > > public __ByValue class LambdaDesugar { > private final int value; > public LambdaDesugar() { this.value = 0; } > > public static void main(String[] args) { > Runnable r = () -> { > System.out.println("hello lambda inside a value type"); > }; > r.run(); > } > } > > cheers, > R?mi From tobias.hartmann at oracle.com Fri Aug 24 14:05:26 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 24 Aug 2018 16:05:26 +0200 Subject: optimizing acmp in L-World In-Reply-To: <6f6a545e-6ccd-b807-fe64-ffaa87aa6290@oracle.com> References: <47625659-9B0E-481C-B755-4C5C4E2DE23C@oracle.com> <6654e587-6e23-24ab-f992-5d2e28c8e8ac@oracle.com> <6f6a545e-6ccd-b807-fe64-ffaa87aa6290@oracle.com> Message-ID: <29ae9ba8-5160-0adf-347c-43a0256df820@oracle.com> Hi Sergey, On 22.08.2018 01:21, Sergey Kuksenko wrote: > I'd rather suggest in case of branching to replace > > ?mov??? 0x8(%rcx),%r11d > ?mov??? %r11,%r10 > ?shr??? $0x3,%r10 > ?test?? $0x1,%r10 > ?jne... > > with > > ?test??? 0x8(%rcx),$0x8 > ?jne... > > It will save registers which may be visible on highly inlined code. Yes but that's only possible if we are testing against a single bit. That's the case with the current klass pointer alignment trick but that will go away. In the future we will use a special bit pattern in the mark word (markOopDesc::always_locked_pattern = 0x405) which has multiple bits set. To test for a value type, we then need to do something like this: mov $0x405,%r10d and (%rcx),%r10 cmp $0x405,%r10 je -> is_value Or this one: mov $0xffffffffffffffff,%r10 xor (%rcx),%r10 test $0x405,%r10 je -> is_value I'm currently working on updating the patch to use the mark word but I need more time. I've noticed that the perturbing approach is much more difficult in that case. The best instruction sequence I could come up with is something like: mov (%rcx),%r10 mov $0x405,%r11d andn %r11,%r10,%r10 // r10 = 0 for values, > 0 for others dec %r10 // r10 < 0 for values, >= 0 for others sar $0x3f,%r10 add %r10,%rcx Or this one: movabs $0x7ffffffffffffbfb,%r10 // MAX_LONG - 0x405 + 1 mov $0x405,%r11d and (%rcx),%r11 add %r10,%r11 // This will overflow to MIN_LONG for values sar $0x3f,%r11 add %r11,%rcx One could also use the set* instructions but we can currently not easily lower these from C2 IR: mov (%rcx), %rdx xorl %eax, %eax andl $0x405, %edx cmpq $0x405, %rdx sete %al add %rcx, %rax I've also checked if the BMI instructions (other than "andn") would help but don't think so. Looks like this complexity is an argument against the perturbation approach. I'll nevertheless implement both approaches and report back once I have a working version. > I just want to give you couple advices about microbenchmarks. > - double DON_INLINE is not requred, having only on "cmpEq" is enough and you'll get less noisy > invocations overhead. > - dealing with small operations it's better to switch to benchmark mode to average time in > nanoseconds - that allows to quickly notice if something wrong. Okay, thanks. I'll update my benchmark accordingly. > I am still thinking how to make representative set of acmp micros, to properly cover inlined case as > the most important. > I'll push them when they will be ready. Sounds good! I'm using the following test cases for correctness testing of the acmp specific C2 optimizations: http://hg.openjdk.java.net/valhalla/valhalla/file/d8a6985f0b99/test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java Best regards, Tobias From tobias.hartmann at oracle.com Mon Aug 27 12:25:02 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 27 Aug 2018 14:25:02 +0200 Subject: Value type sorting In-Reply-To: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> References: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> Message-ID: <3f6bfb0e-7d9e-1336-bf85-38964e0151f1@oracle.com> Hi Doug, thanks for trying out value types EA and for reporting back with these results! I had a look at the 5% performance difference that you were seeing and it turned out that this is not related to value types. The performance difference comes from the use of the CVal::compareTo() method in the CVSorter. The implementation has several branches and after inlining, C2 will add uncommon traps to those branches that profiling suggested are never taken. As a result, 'a.compareTo(b) < 0' is not always optimized to 'a.field < b.field' but might be translated into a 'a.field < b.field' and an additional 'a.field == b.field' check that will trap. I've implemented a JMH benchmark that proves this: http://cr.openjdk.java.net/~thartmann/valhalla/sorting/TestBenchmark.java It uses your version of CVSorter and LongSorter and also CVSorter2 [1] which uses a direct field access instead of a call to compareTo and LongSorter2 [2] which uses a call to compareTo instead of a direct field access. Here are the results of a quick run on my machine (needs more runs for lower error): Benchmark (length) Mode Cnt Score Error Units TestBenchmark.sortCV 1000000 thrpt 5 13.326 ? 0.333 ops/s TestBenchmark.sortCVCompareTo 1000000 thrpt 5 12.613 ? 0.309 ops/s TestBenchmark.sortLong 1000000 thrpt 5 13.271 ? 0.460 ops/s TestBenchmark.sortLongCompareTo 1000000 thrpt 5 11.828 ? 0.626 ops/s It shows that the compareTo versions are significantly slower both for value types as well as for primitive types. Also, without compareTo, the value types version is as fast as the primitive version. Best regards, Tobias [1] http://cr.openjdk.java.net/~thartmann/valhalla/sorting/CVSorter2.java [2] http://cr.openjdk.java.net/~thartmann/valhalla/sorting/LongSorter2.java On 08.08.2018 20:33, Doug Lea wrote: > I've been exploring sorting algorithms (mainly parallel but also > sequential) that should apply well to value types. Even though Valhalla > is not yet at a state where you can use generic by-value Comparables, > I've been trying things out by manually plugging in various types, in > part to scope out future issues. Sorting is the most famous example of a > problem for which no algorithm is always best. Among other things, > performance varies with element comparison vs copying cost, parallelism > support, workspace overhead, and trade-offs of average vs worst case > behavior. I placed a snapshot of the current Goldilocks candidate > balancing these for value types at: > http://gee.cs.oswego.edu/dl/wwwtmp/CVSorter.java > The internal documentation describes some of the algorithmic choices. > As the instruction near the top indicate, for now you need to plug in > any __ByValue class named "CVal". This compiles and runs using current > (build zero) early access (http://jdk.java.net/valhalla/). > > Just for comparison, there's also an otherwise identical version for > long[] arrays at: > http://gee.cs.oswego.edu/dl/wwwtmp/LongSorter.java > When using a __ByValue type just emulating a single long, CVSorter seems > to be only 5% or so slower than LongSorter sorting 100 million elements, > which is pretty good for using something labeled build zero. But > CVSorter also works well with various small or medium-sized value types. > > Any feedback would be welcome. It would be especially nice to hear from > anyone who has actual data and types that need sorting. There are a lot > of synthetic loads available (it does well on most), but having some > actual cases that anyone might be dealing with in the future would be > helpful. > > -Doug From tobias.hartmann at oracle.com Mon Aug 27 12:48:11 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 27 Aug 2018 14:48:11 +0200 Subject: RFR(S): 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" In-Reply-To: <069d3058-81c8-1011-073f-1d12d1e8b772@oracle.com> References: <069d3058-81c8-1011-073f-1d12d1e8b772@oracle.com> Message-ID: Hi Roland, as we've discussed off-thread, here's a version that does not cast to a value type and bails out if the receiver is statically known to be a value type: http://cr.openjdk.java.net/~thartmann/8209702/webrev.02/ Best regards, Tobias On 23.08.2018 08:51, Tobias Hartmann wrote: > Hi Roland, > > On 22.08.2018 17:41, Roland Westrelin wrote: >>> However, we can call Object.clone() on a value type receiver by making it accessible through >>> reflection. C2 will still try to predict the call and speculate on the receiver type but we can >>> disable that via -XX:-UseTypeProfile. >> >> I'm confused by this. You're saying it's possible to call Object.clone() >> with a value receiver? > > Yes, via reflection. > >> In that case, don't we need a runtime check that >> clone is not called on value receiver? > > Yes but the check for JVM_ACC_IS_CLONEABLE_FAST [1] is sufficient because value types can never > implement the Cloneable interface [2] and we'll therefore always go to the slow path. > > Best regards, > Tobias > > [1] > http://hg.openjdk.java.net/valhalla/valhalla/file/bc48956c7832/src/hotspot/share/opto/library_call.cpp#l4478 > [2] > http://hg.openjdk.java.net/valhalla/valhalla/file/bc48956c7832/src/hotspot/share/classfile/classFileParser.cpp#l4753 > From dl at cs.oswego.edu Mon Aug 27 13:03:47 2018 From: dl at cs.oswego.edu (Doug Lea) Date: Mon, 27 Aug 2018 09:03:47 -0400 Subject: Value type sorting In-Reply-To: <3f6bfb0e-7d9e-1336-bf85-38964e0151f1@oracle.com> References: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> <3f6bfb0e-7d9e-1336-bf85-38964e0151f1@oracle.com> Message-ID: <84048716-fcae-1bb1-9562-a738a4e6d4fe@cs.oswego.edu> On 08/27/2018 08:25 AM, Tobias Hartmann wrote: > I had a look at the 5% performance difference that you were seeing > and it turned out that this is not related to value types. The > performance difference comes from the use of the CVal::compareTo() > method in the CVSorter. The implementation has several branches and > after inlining, C2 will add uncommon traps to those branches that > profiling suggested are never taken. Thanks. While this can be worked around for particular cases, it will become a more common issue with generics+values, for which using Comparables and/or Comparators will be inescapable. It might help to intrinsify {Integer,Long, etc}.compareTo methods to somehow return coded condition status registers or somesuch (since only one comparison instruction is actually needed)? If users know that these primitive methods are optimized, they can use them to construct more efficient compareTo methods. -Doug > > As a result, 'a.compareTo(b) < 0' is not always optimized to 'a.field > < b.field' but might be translated into a 'a.field < b.field' and an > additional 'a.field == b.field' check that will trap. > > I've implemented a JMH benchmark that proves this: > http://cr.openjdk.java.net/~thartmann/valhalla/sorting/TestBenchmark.java > > It uses your version of CVSorter and LongSorter and also CVSorter2 > [1] which uses a direct field access instead of a call to compareTo > and LongSorter2 [2] which uses a call to compareTo instead of a > direct field access. > > Here are the results of a quick run on my machine (needs more runs > for lower error): > > Benchmark (length) Mode Cnt Score Error > Units TestBenchmark.sortCV 1000000 thrpt 5 13.326 ? > 0.333 ops/s TestBenchmark.sortCVCompareTo 1000000 thrpt 5 > 12.613 ? 0.309 ops/s TestBenchmark.sortLong 1000000 > thrpt 5 13.271 ? 0.460 ops/s TestBenchmark.sortLongCompareTo > 1000000 thrpt 5 11.828 ? 0.626 ops/s > > It shows that the compareTo versions are significantly slower both > for value types as well as for primitive types. Also, without > compareTo, the value types version is as fast as the primitive > version. > > Best regards, Tobias > > [1] > http://cr.openjdk.java.net/~thartmann/valhalla/sorting/CVSorter2.java > > [2] http://cr.openjdk.java.net/~thartmann/valhalla/sorting/LongSorter2.java > > On 08.08.2018 20:33, Doug Lea wrote: >> I've been exploring sorting algorithms (mainly parallel but also >> sequential) that should apply well to value types. Even though >> Valhalla is not yet at a state where you can use generic by-value >> Comparables, I've been trying things out by manually plugging in >> various types, in part to scope out future issues. Sorting is the >> most famous example of a problem for which no algorithm is always >> best. Among other things, performance varies with element >> comparison vs copying cost, parallelism support, workspace >> overhead, and trade-offs of average vs worst case behavior. I >> placed a snapshot of the current Goldilocks candidate balancing >> these for value types at: >> http://gee.cs.oswego.edu/dl/wwwtmp/CVSorter.java The internal >> documentation describes some of the algorithmic choices. As the >> instruction near the top indicate, for now you need to plug in any >> __ByValue class named "CVal". This compiles and runs using current >> (build zero) early access (http://jdk.java.net/valhalla/). >> >> Just for comparison, there's also an otherwise identical version >> for long[] arrays at: >> http://gee.cs.oswego.edu/dl/wwwtmp/LongSorter.java When using a >> __ByValue type just emulating a single long, CVSorter seems to be >> only 5% or so slower than LongSorter sorting 100 million elements, >> which is pretty good for using something labeled build zero. But >> CVSorter also works well with various small or medium-sized value >> types. >> >> Any feedback would be welcome. It would be especially nice to hear >> from anyone who has actual data and types that need sorting. There >> are a lot of synthetic loads available (it does well on most), but >> having some actual cases that anyone might be dealing with in the >> future would be helpful. >> >> -Doug > From tobias.hartmann at oracle.com Mon Aug 27 13:32:25 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 27 Aug 2018 15:32:25 +0200 Subject: [lworld] RFR JDK-8207259: Ensure VarHandle compare and set/exchange work for value types In-Reply-To: <7411fac5-6c79-0480-6226-1e412067eaaa@oracle.com> References: <7411fac5-6c79-0480-6226-1e412067eaaa@oracle.com> Message-ID: Hi Mandy, seems like the patch in the webrev is outdated as it contains only some of the files: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8207259/webrev.01/lworld-dev.changeset On 15.08.2018 19:45, mandy chung wrote: > - The new VarHandleTestAccessPoint test crashes (SIGSEGV) when running > ? with compiler.? I will file a JBS issue separately.? So the test > ? for now will run only with -Xint. I can reproduce this and filed: https://bugs.openjdk.java.net/browse/JDK-8209989 Best regards, Tobias From tobias.hartmann at oracle.com Mon Aug 27 14:54:56 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 27 Aug 2018 16:54:56 +0200 Subject: Value type sorting In-Reply-To: <84048716-fcae-1bb1-9562-a738a4e6d4fe@cs.oswego.edu> References: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> <3f6bfb0e-7d9e-1336-bf85-38964e0151f1@oracle.com> <84048716-fcae-1bb1-9562-a738a4e6d4fe@cs.oswego.edu> Message-ID: Hi Doug, On 27.08.2018 15:03, Doug Lea wrote: > Thanks. While this can be worked around for particular cases, it will > become a more common issue with generics+values, for which using > Comparables and/or Comparators will be inescapable. It might help to > intrinsify {Integer,Long, etc}.compareTo methods to somehow return coded > condition status registers or somesuch (since only one comparison > instruction is actually needed)? If users know that these primitive > methods are optimized, they can use them to construct more efficient > compareTo methods. Yes, I agree that this pattern might become more common with value types and generics. After looking at this in more detail, I've figured that the problem is not traps inserted due to profiling (all paths should have been marked as taken anyway) but just C2 being not able to optimize the following pattern: public static int compare(long a, long b) { return (a < b) ? -1 : (a == b) ? 0 : 1; } public static boolean test1(long a, long b) { return compare(a, b) > 0; } public static boolean test2(long a, long b) { return a > b; } Test1 is compiled to two cmp instructions: 0x00007f2e04cf714c: cmp %rdx,%rsi 0x00007f2e04cf714f: jl 0x00007f2e04cf7156 0x00007f2e04cf7151: cmp %rdx,%rsi 0x00007f2e04cf7154: jne 0x00007f2e04cf7168 [...] Whereas test2 is compiled to just one: 0x00007f2e04d19fd4: cmp %rdx,%rsi 0x00007f2e04d19fd7: cmovle %r10d,%eax [...] So the performance difference comes from a limitation of C2 unrelated to value types. I'll have a look if we can optimize that or file an RFE. Best regards, Tobias From rwestrel at redhat.com Mon Aug 27 15:40:54 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Mon, 27 Aug 2018 17:40:54 +0200 Subject: RFR(S): 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" In-Reply-To: References: <069d3058-81c8-1011-073f-1d12d1e8b772@oracle.com> Message-ID: > http://cr.openjdk.java.net/~thartmann/8209702/webrev.02/ That looks good. Roland. From tobias.hartmann at oracle.com Mon Aug 27 15:44:39 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 27 Aug 2018 17:44:39 +0200 Subject: RFR(S): 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" In-Reply-To: References: <069d3058-81c8-1011-073f-1d12d1e8b772@oracle.com> Message-ID: <027d9fef-2798-32cc-b040-622c9133ae81@oracle.com> Thanks Roland. Best regards, Tobias On 27.08.2018 17:40, Roland Westrelin wrote: > >> http://cr.openjdk.java.net/~thartmann/8209702/webrev.02/ > > That looks good. > > Roland. > From tobias.hartmann at oracle.com Mon Aug 27 15:46:24 2018 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Mon, 27 Aug 2018 15:46:24 +0000 Subject: hg: valhalla/valhalla: 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" Message-ID: <201808271546.w7RFkPrt025243@aojmv0008.oracle.com> Changeset: 7815e6d56296 Author: thartmann Date: 2018-08-27 17:46 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7815e6d56296 8209702: [lworld] C2 compilation fails with "assert(argument(0)->bottom_type()->isa_ptr()) failed: must be" Reviewed-by: roland ! src/hotspot/share/opto/library_call.cpp + test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNativeClone.java From john.r.rose at oracle.com Mon Aug 27 17:29:00 2018 From: john.r.rose at oracle.com (John Rose) Date: Mon, 27 Aug 2018 10:29:00 -0700 Subject: Value type sorting In-Reply-To: References: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> <3f6bfb0e-7d9e-1336-bf85-38964e0151f1@oracle.com> <84048716-fcae-1bb1-9562-a738a4e6d4fe@cs.oswego.edu> Message-ID: <6EF96F07-F0FB-4A94-8799-E9D04EAF200E@oracle.com> On Aug 27, 2018, at 7:54 AM, Tobias Hartmann wrote: > > So the performance difference comes from a limitation of C2 unrelated to value types. I'll have a > look if we can optimize that or file an RFE. So this doesn't fold up: ((a < b) ? -1 : (a == b) ? 0 : 1) > 0. I suspect it *would* fold up (via split-if?) if by pure chance the expression were (a > b) ? 1 : (? something <= 0 ?). This variation ((a < b) ? -1 : (a == b) ? 0 : 1) < 0 probably *does* fold up. C2 doesn't handle trichotomy calculations as well as it should. There is no TypeInt::CC_NE, for example. And these trivial but nested ?:?: expressions are not inspected vigorously enough. They should be. I don't think we can do anything about CC_NE, though. But maybe we can transform (?:?:) cmp x by reordering the (?:?:) so the top-level ?: shows sides that appear on either side of x. My $0.02. ? John From sergey.kuksenko at oracle.com Mon Aug 27 18:23:56 2018 From: sergey.kuksenko at oracle.com (Sergey Kuksenko) Date: Mon, 27 Aug 2018 11:23:56 -0700 Subject: optimizing acmp in L-World In-Reply-To: <29ae9ba8-5160-0adf-347c-43a0256df820@oracle.com> References: <47625659-9B0E-481C-B755-4C5C4E2DE23C@oracle.com> <6654e587-6e23-24ab-f992-5d2e28c8e8ac@oracle.com> <6f6a545e-6ccd-b807-fe64-ffaa87aa6290@oracle.com> <29ae9ba8-5160-0adf-347c-43a0256df820@oracle.com> Message-ID: Hi Tobias, I've checked your benchmark and UseOldAcmp option. I have to say that according my measurements? -XX:+UseOldAcmp shows better performance in all cases, even comparing the same references. I managed to make and repeat a corner case when the same refs has better performance with -XX:-UseOldAcmp. The reason of this is the fact that -XX:-UseOldAcmp generated code uses conditional move into result register, but -XX:+UseOldAcmp generates branches. So if -XX:-UseOldAcmp will generate branches? -it will be slower, or if -XX:+UseOldAcmp won't generate branches - it will be faster. I think benchmark measuring isolated acmp performance is not relevant to usages of acmp in applications. Isolated - I mean - not inlined method with the result in register. Right now I am trying to make a non isolated benchmark where acmp is used for condition and correspond branching. I've found yet another benchmarking pitfall here. Typically JMH executes all subbenchmarks in separate VMs, that cases that measuring o1==o1 we that have only that branch in the profile. If you want to measure full acmp performance, full - means when all acmp branches are in the profile, you have to use yet another JMH option? "-wm BULK" which provides bulk warmup of all combinations before measurement. As for markOopDesc::always_locked_pattern = 0x405 - just tell me when it'll be ready and I'll check it. But anyway cost of this should be higher than 1 bit in class word. On 08/24/2018 07:05 AM, Tobias Hartmann wrote: > Hi Sergey, > > On 22.08.2018 01:21, Sergey Kuksenko wrote: >> I'd rather suggest in case of branching to replace >> >> ?mov??? 0x8(%rcx),%r11d >> ?mov??? %r11,%r10 >> ?shr??? $0x3,%r10 >> ?test?? $0x1,%r10 >> ?jne... >> >> with >> >> ?test??? 0x8(%rcx),$0x8 >> ?jne... >> >> It will save registers which may be visible on highly inlined code. > Yes but that's only possible if we are testing against a single bit. That's the case with the > current klass pointer alignment trick but that will go away. In the future we will use a special bit > pattern in the mark word (markOopDesc::always_locked_pattern = 0x405) which has multiple bits set. > To test for a value type, we then need to do something like this: > > mov $0x405,%r10d > and (%rcx),%r10 > cmp $0x405,%r10 > je -> is_value > > Or this one: > > mov $0xffffffffffffffff,%r10 > xor (%rcx),%r10 > test $0x405,%r10 > je -> is_value > > I'm currently working on updating the patch to use the mark word but I need more time. I've noticed > that the perturbing approach is much more difficult in that case. The best instruction sequence I > could come up with is something like: > > mov (%rcx),%r10 > mov $0x405,%r11d > andn %r11,%r10,%r10 // r10 = 0 for values, > 0 for others > dec %r10 // r10 < 0 for values, >= 0 for others > sar $0x3f,%r10 > add %r10,%rcx > > Or this one: > > movabs $0x7ffffffffffffbfb,%r10 // MAX_LONG - 0x405 + 1 > mov $0x405,%r11d > and (%rcx),%r11 > add %r10,%r11 // This will overflow to MIN_LONG for values > sar $0x3f,%r11 > add %r11,%rcx > > One could also use the set* instructions but we can currently not easily lower these from C2 IR: > > mov (%rcx), %rdx > xorl %eax, %eax > andl $0x405, %edx > cmpq $0x405, %rdx > sete %al > add %rcx, %rax > > I've also checked if the BMI instructions (other than "andn") would help but don't think so. > > Looks like this complexity is an argument against the perturbation approach. I'll nevertheless > implement both approaches and report back once I have a working version. > >> I just want to give you couple advices about microbenchmarks. >> - double DON_INLINE is not requred, having only on "cmpEq" is enough and you'll get less noisy >> invocations overhead. >> - dealing with small operations it's better to switch to benchmark mode to average time in >> nanoseconds - that allows to quickly notice if something wrong. > Okay, thanks. I'll update my benchmark accordingly. > >> I am still thinking how to make representative set of acmp micros, to properly cover inlined case as >> the most important. >> I'll push them when they will be ready. > Sounds good! > > I'm using the following test cases for correctness testing of the acmp specific C2 optimizations: > http://hg.openjdk.java.net/valhalla/valhalla/file/d8a6985f0b99/test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java > > Best regards, > Tobias From mandy.chung at oracle.com Mon Aug 27 21:37:57 2018 From: mandy.chung at oracle.com (mandy chung) Date: Mon, 27 Aug 2018 14:37:57 -0700 Subject: [lworld] RFR JDK-8207259: Ensure VarHandle compare and set/exchange work for value types In-Reply-To: References: <7411fac5-6c79-0480-6226-1e412067eaaa@oracle.com> Message-ID: <2cf69d5f-3b12-d8b6-dccf-4acab945b6e9@oracle.com> Hi Tobias, On 8/27/18 6:32 AM, Tobias Hartmann wrote: > Hi Mandy, > > seems like the patch in the webrev is outdated as it contains only some of the files: > http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8207259/webrev.01/lworld-dev.changeset Oops.. I fixed it. > On 15.08.2018 19:45, mandy chung wrote: >> - The new VarHandleTestAccessPoint test crashes (SIGSEGV) when running >> ? with compiler.? I will file a JBS issue separately.? So the test >> ? for now will run only with -Xint. > > I can reproduce this and filed: > https://bugs.openjdk.java.net/browse/JDK-8209989 Thanks for filing it and assertion fails at valuetypenode.cpp:909 is what I ran into. Mandy From harold.seigel at oracle.com Tue Aug 28 13:24:17 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Tue, 28 Aug 2018 09:24:17 -0400 Subject: RFR 8205026: [lworld] EnableValhalla regression testing Message-ID: Hi, Please review these open changes to help with regression testing.? The files were changed for the following reasons: ??? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test .../RedefineLeak.java ??? .../ConstantGettersTransitionsTest.java - avoid running tiered test with -XX:+EnableValhalla ??? .../TestMeetIncompatibleInterfaceArrays.java - avoid running tiered test with -XX:+EnableValhalla ??? .../ValueOops.java - avoid running test when specific GC's are explicitly specified ??? .../TestPlatformIsTIeredSupported.java - avoid running tiered test with -XX:+EnableValhalla ??? .../VMProps.java - avoid running CDS tests Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 Thanks! Harold From lois.foltan at oracle.com Tue Aug 28 14:01:00 2018 From: lois.foltan at oracle.com (Lois Foltan) Date: Tue, 28 Aug 2018 10:01:00 -0400 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: References: Message-ID: Looks good. Lois On 8/28/2018 9:24 AM, Harold David Seigel wrote: > Hi, > > Please review these open changes to help with regression testing. The > files were changed for the following reasons: > > ??? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test > .../RedefineLeak.java > > ??? .../ConstantGettersTransitionsTest.java - avoid running tiered > test with -XX:+EnableValhalla > > ??? .../TestMeetIncompatibleInterfaceArrays.java - avoid running > tiered test with -XX:+EnableValhalla > > ??? .../ValueOops.java - avoid running test when specific GC's are > explicitly specified > > ??? .../TestPlatformIsTIeredSupported.java - avoid running tiered test > with -XX:+EnableValhalla > > ??? .../VMProps.java - avoid running CDS tests > > > Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ > > JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 > > Thanks! Harold > > From harold.seigel at oracle.com Tue Aug 28 14:12:56 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Tue, 28 Aug 2018 10:12:56 -0400 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: References: Message-ID: Thanks Lois! Harold On 8/28/2018 10:01 AM, Lois Foltan wrote: > Looks good. > Lois > > On 8/28/2018 9:24 AM, Harold David Seigel wrote: >> Hi, >> >> Please review these open changes to help with regression testing. The >> files were changed for the following reasons: >> >> ??? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed >> test .../RedefineLeak.java >> >> ??? .../ConstantGettersTransitionsTest.java - avoid running tiered >> test with -XX:+EnableValhalla >> >> ??? .../TestMeetIncompatibleInterfaceArrays.java - avoid running >> tiered test with -XX:+EnableValhalla >> >> ??? .../ValueOops.java - avoid running test when specific GC's are >> explicitly specified >> >> ??? .../TestPlatformIsTIeredSupported.java - avoid running tiered >> test with -XX:+EnableValhalla >> >> ??? .../VMProps.java - avoid running CDS tests >> >> >> Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ >> >> JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 >> >> Thanks! Harold >> >> > From tobias.hartmann at oracle.com Tue Aug 28 14:14:09 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 28 Aug 2018 16:14:09 +0200 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: References: Message-ID: Hi Harold, I think the tiered compilation tests that fail should be fixed by adding a @requires statements that checks that tiered compilation is available (see my comment in JDK-8205947). That functionality was added by JDK-8203923. Thanks, Tobias On 28.08.2018 15:24, Harold David Seigel wrote: > Hi, > > Please review these open changes to help with regression testing.? The files were changed for the > following reasons: > > ??? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test .../RedefineLeak.java > > ??? .../ConstantGettersTransitionsTest.java - avoid running tiered test with -XX:+EnableValhalla > > ??? .../TestMeetIncompatibleInterfaceArrays.java - avoid running tiered test with -XX:+EnableValhalla > > ??? .../ValueOops.java - avoid running test when specific GC's are explicitly specified > > ??? .../TestPlatformIsTIeredSupported.java - avoid running tiered test with -XX:+EnableValhalla > > ??? .../VMProps.java - avoid running CDS tests > > > Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ > > JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 > > Thanks! Harold > > From harold.seigel at oracle.com Tue Aug 28 14:21:01 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Tue, 28 Aug 2018 10:21:01 -0400 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: References: Message-ID: Hi Tobias, That makes sense.? Do you know what the syntax of the @requires statement should be for the tiered compilation case? Thanks, Haorld On 8/28/2018 10:14 AM, Tobias Hartmann wrote: > Hi Harold, > > I think the tiered compilation tests that fail should be fixed by adding a @requires statements that > checks that tiered compilation is available (see my comment in JDK-8205947). That functionality was > added by JDK-8203923. > > Thanks, > Tobias > > On 28.08.2018 15:24, Harold David Seigel wrote: >> Hi, >> >> Please review these open changes to help with regression testing.? The files were changed for the >> following reasons: >> >> ??? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test .../RedefineLeak.java >> >> ??? .../ConstantGettersTransitionsTest.java - avoid running tiered test with -XX:+EnableValhalla >> >> ??? .../TestMeetIncompatibleInterfaceArrays.java - avoid running tiered test with -XX:+EnableValhalla >> >> ??? .../ValueOops.java - avoid running test when specific GC's are explicitly specified >> >> ??? .../TestPlatformIsTIeredSupported.java - avoid running tiered test with -XX:+EnableValhalla >> >> ??? .../VMProps.java - avoid running CDS tests >> >> >> Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ >> >> JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 >> >> Thanks! Harold >> >> From tobias.hartmann at oracle.com Tue Aug 28 14:42:10 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 28 Aug 2018 16:42:10 +0200 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: References: Message-ID: <2fe8d667-1b90-9e57-5cb9-fcb666157b03@oracle.com> Hi Harold, I think it should be "@vm.opt.final.TieredCompilation" but you need to add the corresponding "vmOptFinalFlag" statement to VMProps.java: http://hg.openjdk.java.net/jdk/jdk/rev/df02866807b6 Thanks, Tobias On 28.08.2018 16:21, Harold David Seigel wrote: > Hi Tobias, > > That makes sense.? Do you know what the syntax of the @requires statement should be for the tiered > compilation case? > > Thanks, Haorld > > > On 8/28/2018 10:14 AM, Tobias Hartmann wrote: >> Hi Harold, >> >> I think the tiered compilation tests that fail should be fixed by adding a @requires statements that >> checks that tiered compilation is available (see my comment in JDK-8205947). That functionality was >> added by JDK-8203923. >> >> Thanks, >> Tobias >> >> On 28.08.2018 15:24, Harold David Seigel wrote: >>> Hi, >>> >>> Please review these open changes to help with regression testing.? The files were changed for the >>> following reasons: >>> >>> ???? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test .../RedefineLeak.java >>> >>> ???? .../ConstantGettersTransitionsTest.java - avoid running tiered test with -XX:+EnableValhalla >>> >>> ???? .../TestMeetIncompatibleInterfaceArrays.java - avoid running tiered test with >>> -XX:+EnableValhalla >>> >>> ???? .../ValueOops.java - avoid running test when specific GC's are explicitly specified >>> >>> ???? .../TestPlatformIsTIeredSupported.java - avoid running tiered test with -XX:+EnableValhalla >>> >>> ???? .../VMProps.java - avoid running CDS tests >>> >>> >>> Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ >>> >>> JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 >>> >>> Thanks! Harold >>> >>> > From tobias.hartmann at oracle.com Tue Aug 28 14:42:52 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 28 Aug 2018 16:42:52 +0200 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: <2fe8d667-1b90-9e57-5cb9-fcb666157b03@oracle.com> References: <2fe8d667-1b90-9e57-5cb9-fcb666157b03@oracle.com> Message-ID: <7a169183-3271-25f6-0f15-2738933dc101@oracle.com> On 28.08.2018 16:42, Tobias Hartmann wrote: > I think it should be "@vm.opt.final.TieredCompilation" Sorry, I meant "@requires vm.opt.final.TieredCompilation". Tobias From harold.seigel at oracle.com Tue Aug 28 15:06:49 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Tue, 28 Aug 2018 11:06:49 -0400 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: <2fe8d667-1b90-9e57-5cb9-fcb666157b03@oracle.com> References: <2fe8d667-1b90-9e57-5cb9-fcb666157b03@oracle.com> Message-ID: <37d4a0d3-646f-3e47-8480-274111f257e1@oracle.com> Hi Tobias, Please review this updated webrev using your suggestion: http://cr.openjdk.java.net/~hseigel/bug_8205026.2/webrev/index.html Thanks!? Harold On 8/28/2018 10:42 AM, Tobias Hartmann wrote: > Hi Harold, > > I think it should be "@vm.opt.final.TieredCompilation" but you need to add the corresponding > "vmOptFinalFlag" statement to VMProps.java: > http://hg.openjdk.java.net/jdk/jdk/rev/df02866807b6 > > Thanks, > Tobias > > On 28.08.2018 16:21, Harold David Seigel wrote: >> Hi Tobias, >> >> That makes sense.? Do you know what the syntax of the @requires statement should be for the tiered >> compilation case? >> >> Thanks, Haorld >> >> >> On 8/28/2018 10:14 AM, Tobias Hartmann wrote: >>> Hi Harold, >>> >>> I think the tiered compilation tests that fail should be fixed by adding a @requires statements that >>> checks that tiered compilation is available (see my comment in JDK-8205947). That functionality was >>> added by JDK-8203923. >>> >>> Thanks, >>> Tobias >>> >>> On 28.08.2018 15:24, Harold David Seigel wrote: >>>> Hi, >>>> >>>> Please review these open changes to help with regression testing.? The files were changed for the >>>> following reasons: >>>> >>>> ???? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test .../RedefineLeak.java >>>> >>>> ???? .../ConstantGettersTransitionsTest.java - avoid running tiered test with -XX:+EnableValhalla >>>> >>>> ???? .../TestMeetIncompatibleInterfaceArrays.java - avoid running tiered test with >>>> -XX:+EnableValhalla >>>> >>>> ???? .../ValueOops.java - avoid running test when specific GC's are explicitly specified >>>> >>>> ???? .../TestPlatformIsTIeredSupported.java - avoid running tiered test with -XX:+EnableValhalla >>>> >>>> ???? .../VMProps.java - avoid running CDS tests >>>> >>>> >>>> Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ >>>> >>>> JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 >>>> >>>> Thanks! Harold >>>> >>>> From harold.seigel at oracle.com Tue Aug 28 17:44:08 2018 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Tue, 28 Aug 2018 17:44:08 +0000 Subject: hg: valhalla/valhalla: 8205026: [lworld] EnableValhalla regression testing Message-ID: <201808281744.w7SHi9ZB013792@aojmv0008.oracle.com> Changeset: 0f17d8902928 Author: hseigel Date: 2018-08-28 13:43 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0f17d8902928 8205026: [lworld] EnableValhalla regression testing Summary: Fix tests that need special handling when potentially run with -XX:+EnableValhalla Reviewed-by: lfoltan, thartmann ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/compiler/tiered/ConstantGettersTransitionsTest.java ! test/hotspot/jtreg/compiler/types/TestMeetIncompatibleInterfaceArrays.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueOops.java ! test/hotspot/jtreg/testlibrary_tests/TestPlatformIsTieredSupported.java ! test/jtreg-ext/requires/VMProps.java From mandy.chung at oracle.com Tue Aug 28 20:50:18 2018 From: mandy.chung at oracle.com (mandy chung) Date: Tue, 28 Aug 2018 13:50:18 -0700 Subject: RFR JDK-8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type Message-ID: The lambda proxy generator currently generates ValueTypes attribute to list the value types that are declared in parameter types and return type.? But it misses the case when a lambda body is defined in a value class but no value type declared in its signature. This is a simple fix in InnerClassLambdaMetafactory.? I added the test cases for lambda, core reflection, and method handles. Webrev at: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8209896/webrev.00/ Mandy From frederic.parain at oracle.com Tue Aug 28 20:57:17 2018 From: frederic.parain at oracle.com (Frederic Parain) Date: Tue, 28 Aug 2018 16:57:17 -0400 Subject: RFR JDK-8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type In-Reply-To: References: Message-ID: <01FC6A6E-A79C-479D-95B0-7BBA74A81584@oracle.com> Looks good to me. Thank you for fixing this. Fred > On Aug 28, 2018, at 16:50, mandy chung wrote: > > The lambda proxy generator currently generates ValueTypes attribute > to list the value types that are declared in parameter types and > return type. But it misses the case when a lambda body is defined > in a value class but no value type declared in its signature. > > This is a simple fix in InnerClassLambdaMetafactory. I added > the test cases for lambda, core reflection, and method handles. > > Webrev at: > http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8209896/webrev.00/ > > Mandy From forax at univ-mlv.fr Tue Aug 28 22:30:51 2018 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 29 Aug 2018 00:30:51 +0200 (CEST) Subject: RFR JDK-8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type In-Reply-To: <01FC6A6E-A79C-479D-95B0-7BBA74A81584@oracle.com> References: <01FC6A6E-A79C-479D-95B0-7BBA74A81584@oracle.com> Message-ID: <538445928.474006.1535495451716.JavaMail.zimbra@u-pem.fr> Looks good to me too. R?mi ----- Mail original ----- > De: "Frederic Parain" > ?: "mandy chung" > Cc: "valhalla-dev" > Envoy?: Mardi 28 Ao?t 2018 22:57:17 > Objet: Re: RFR JDK-8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type > Looks good to me. > Thank you for fixing this. > > Fred > > >> On Aug 28, 2018, at 16:50, mandy chung wrote: >> >> The lambda proxy generator currently generates ValueTypes attribute >> to list the value types that are declared in parameter types and >> return type. But it misses the case when a lambda body is defined >> in a value class but no value type declared in its signature. >> >> This is a simple fix in InnerClassLambdaMetafactory. I added >> the test cases for lambda, core reflection, and method handles. >> >> Webrev at: >> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8209896/webrev.00/ >> > > Mandy From mandy.chung at oracle.com Tue Aug 28 23:01:36 2018 From: mandy.chung at oracle.com (mandy chung) Date: Tue, 28 Aug 2018 16:01:36 -0700 Subject: RFR JDK-8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type In-Reply-To: <538445928.474006.1535495451716.JavaMail.zimbra@u-pem.fr> References: <01FC6A6E-A79C-479D-95B0-7BBA74A81584@oracle.com> <538445928.474006.1535495451716.JavaMail.zimbra@u-pem.fr> Message-ID: <73098b74-ff2e-b9e7-be91-dabff96537c0@oracle.com> Thanks Frederic and Remi. Mandy On 8/28/18 3:30 PM, Remi Forax wrote: > Looks good to me too. > > R?mi > > ----- Mail original ----- >> De: "Frederic Parain" >> ?: "mandy chung" >> Cc: "valhalla-dev" >> Envoy?: Mardi 28 Ao?t 2018 22:57:17 >> Objet: Re: RFR JDK-8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type >> Looks good to me. >> Thank you for fixing this. >> >> Fred >> >> >>> On Aug 28, 2018, at 16:50, mandy chung wrote: >>> >>> The lambda proxy generator currently generates ValueTypes attribute >>> to list the value types that are declared in parameter types and >>> return type. But it misses the case when a lambda body is defined >>> in a value class but no value type declared in its signature. >>> >>> This is a simple fix in InnerClassLambdaMetafactory. I added >>> the test cases for lambda, core reflection, and method handles. >>> >>> Webrev at: >>> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8209896/webrev.00/ >>> >>> Mandy From mandy.chung at oracle.com Tue Aug 28 23:22:09 2018 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 28 Aug 2018 23:22:09 +0000 Subject: hg: valhalla/valhalla: 8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type Message-ID: <201808282322.w7SNMA4J015953@aojmv0008.oracle.com> Changeset: 2194ea33af93 Author: mchung Date: 2018-08-28 16:22 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2194ea33af93 8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type Reviewed-by: forax, fparain ! src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! test/jdk/valhalla/valuetypes/ValueTypesAttributeTest.java From tobias.hartmann at oracle.com Wed Aug 29 06:03:32 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 29 Aug 2018 08:03:32 +0200 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: <37d4a0d3-646f-3e47-8480-274111f257e1@oracle.com> References: <2fe8d667-1b90-9e57-5cb9-fcb666157b03@oracle.com> <37d4a0d3-646f-3e47-8480-274111f257e1@oracle.com> Message-ID: Hi Harold, looks good to me. Tobias On 28.08.2018 17:06, Harold David Seigel wrote: > Hi Tobias, > > Please review this updated webrev using your suggestion: > > http://cr.openjdk.java.net/~hseigel/bug_8205026.2/webrev/index.html > > Thanks!? Harold > > > On 8/28/2018 10:42 AM, Tobias Hartmann wrote: >> Hi Harold, >> >> I think it should be "@vm.opt.final.TieredCompilation" but you need to add the corresponding >> "vmOptFinalFlag" statement to VMProps.java: >> http://hg.openjdk.java.net/jdk/jdk/rev/df02866807b6 >> >> Thanks, >> Tobias >> >> On 28.08.2018 16:21, Harold David Seigel wrote: >>> Hi Tobias, >>> >>> That makes sense.? Do you know what the syntax of the @requires statement should be for the tiered >>> compilation case? >>> >>> Thanks, Haorld >>> >>> >>> On 8/28/2018 10:14 AM, Tobias Hartmann wrote: >>>> Hi Harold, >>>> >>>> I think the tiered compilation tests that fail should be fixed by adding a @requires statements >>>> that >>>> checks that tiered compilation is available (see my comment in JDK-8205947). That functionality was >>>> added by JDK-8203923. >>>> >>>> Thanks, >>>> Tobias >>>> >>>> On 28.08.2018 15:24, Harold David Seigel wrote: >>>>> Hi, >>>>> >>>>> Please review these open changes to help with regression testing.? The files were changed for the >>>>> following reasons: >>>>> >>>>> ????? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test .../RedefineLeak.java >>>>> >>>>> ????? .../ConstantGettersTransitionsTest.java - avoid running tiered test with -XX:+EnableValhalla >>>>> >>>>> ????? .../TestMeetIncompatibleInterfaceArrays.java - avoid running tiered test with >>>>> -XX:+EnableValhalla >>>>> >>>>> ????? .../ValueOops.java - avoid running test when specific GC's are explicitly specified >>>>> >>>>> ????? .../TestPlatformIsTIeredSupported.java - avoid running tiered test with -XX:+EnableValhalla >>>>> >>>>> ????? .../VMProps.java - avoid running CDS tests >>>>> >>>>> >>>>> Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ >>>>> >>>>> JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 >>>>> >>>>> Thanks! Harold >>>>> >>>>> > From rwestrel at redhat.com Wed Aug 29 12:02:44 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 29 Aug 2018 14:02:44 +0200 Subject: accessing unknown value type element in Object[] array & GC barriers Message-ID: A question for someone familiar with GC barriers below... Currently for: Object array_load(Object[] array) { return array[0]; } we roughly emit: Object array_load(Object[] array) { if (is_flattened(array)) { deoptimize(); } return array[0]; } Same thing for: void array_store(Object[] array, Object o) { array[0] = o; } roughly emitted as: void array_store(Object[] array, Object o) { if (is_flattened(array)) { deoptimize(); } array[0] = o; } Instead we would want: Object array_load(Object[] array) { Object v; if (is_flattened(array)) { v = array.getComponentType().newInstance(); copy(v, array[0]); } else { v = array[0]; } return v; } The first if branch is similar to the clone intrinsic (we're not copying from an instance but from some flattened array element) so reusing that machinery is possible (and prototyped). The problem here is that if the unknown value has oop fields, depending on the gc, barriers might be needed. In its current state ZGC doesn't support the clone intrinsic and so we wouldn't support the pattern above with ZGC either. void array_store(Object[] array, Object o) { if (is_flattened(array)) { copy(array[0], o); post_barrier(); } else { array[0] = o; } } Again somewhat similar to the clone intrinsic but copy is not to a newly allocated object so we need a barrier. C2 has some support for non precise post barrier but I'm unclear what to pass to that barrier for serial/parallel/CMS or G1: the array oop? &array[0]? Are there cases where several cards need to be marked? Other unrelated question: how does the size of the element of a flattened array compare to the size of value instance? Do they differ or can we use either one interchangeably? Roland. From harold.seigel at oracle.com Wed Aug 29 12:58:24 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Wed, 29 Aug 2018 08:58:24 -0400 Subject: RFR 8205026: [lworld] EnableValhalla regression testing In-Reply-To: References: <2fe8d667-1b90-9e57-5cb9-fcb666157b03@oracle.com> <37d4a0d3-646f-3e47-8480-274111f257e1@oracle.com> Message-ID: Thanks Tobias! Harold On 8/29/2018 2:03 AM, Tobias Hartmann wrote: > Hi Harold, > > looks good to me. > > Tobias > > On 28.08.2018 17:06, Harold David Seigel wrote: >> Hi Tobias, >> >> Please review this updated webrev using your suggestion: >> >> http://cr.openjdk.java.net/~hseigel/bug_8205026.2/webrev/index.html >> >> Thanks!? Harold >> >> >> On 8/28/2018 10:42 AM, Tobias Hartmann wrote: >>> Hi Harold, >>> >>> I think it should be "@vm.opt.final.TieredCompilation" but you need to add the corresponding >>> "vmOptFinalFlag" statement to VMProps.java: >>> http://hg.openjdk.java.net/jdk/jdk/rev/df02866807b6 >>> >>> Thanks, >>> Tobias >>> >>> On 28.08.2018 16:21, Harold David Seigel wrote: >>>> Hi Tobias, >>>> >>>> That makes sense.? Do you know what the syntax of the @requires statement should be for the tiered >>>> compilation case? >>>> >>>> Thanks, Haorld >>>> >>>> >>>> On 8/28/2018 10:14 AM, Tobias Hartmann wrote: >>>>> Hi Harold, >>>>> >>>>> I think the tiered compilation tests that fail should be fixed by adding a @requires statements >>>>> that >>>>> checks that tiered compilation is available (see my comment in JDK-8205947). That functionality was >>>>> added by JDK-8203923. >>>>> >>>>> Thanks, >>>>> Tobias >>>>> >>>>> On 28.08.2018 15:24, Harold David Seigel wrote: >>>>>> Hi, >>>>>> >>>>>> Please review these open changes to help with regression testing.? The files were changed for the >>>>>> following reasons: >>>>>> >>>>>> ????? .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test .../RedefineLeak.java >>>>>> >>>>>> ????? .../ConstantGettersTransitionsTest.java - avoid running tiered test with -XX:+EnableValhalla >>>>>> >>>>>> ????? .../TestMeetIncompatibleInterfaceArrays.java - avoid running tiered test with >>>>>> -XX:+EnableValhalla >>>>>> >>>>>> ????? .../ValueOops.java - avoid running test when specific GC's are explicitly specified >>>>>> >>>>>> ????? .../TestPlatformIsTIeredSupported.java - avoid running tiered test with -XX:+EnableValhalla >>>>>> >>>>>> ????? .../VMProps.java - avoid running CDS tests >>>>>> >>>>>> >>>>>> Webrev:? http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/ >>>>>> >>>>>> JBS Bug:? https://bugs.openjdk.java.net/browse/JDK-8205026 >>>>>> >>>>>> Thanks! Harold >>>>>> >>>>>> From rwestrel at redhat.com Wed Aug 29 14:04:10 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 29 Aug 2018 16:04:10 +0200 Subject: RFR(M): 8209134: [lworld] New nmethod entry point for unscalarized (nullable) value type arguments In-Reply-To: <55c3f0c2-c951-4ee2-e5eb-9120e42d1177@oracle.com> References: <55c3f0c2-c951-4ee2-e5eb-9120e42d1177@oracle.com> Message-ID: > http://cr.openjdk.java.net/~thartmann/8209134/webrev.00/ That looks reasonable to me. Why move things around in nmethod::print_nmethod_labels()? Why is the Q showing up in signature.cpp? Roland. From rwestrel at redhat.com Wed Aug 29 14:49:28 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Wed, 29 Aug 2018 16:49:28 +0200 Subject: Unsafe API and explicit VT allocation In-Reply-To: <12523B6F-8265-4E77-AA12-7A9AD5898D3A@oracle.com> References: <22E87C09-C79F-4CAD-89F9-0D875F7D81D9@oracle.com> <12523B6F-8265-4E77-AA12-7A9AD5898D3A@oracle.com> Message-ID: > More control, simpler API, less responsibility on JIT: > That's why I think we want 2 more API points, not #types > new API points. And if you have a way to do it with zero > more Unsafe API points, of course I'm listening. That makes sense now. Thanks for the detailed explanation. Roland. From sergey.kuksenko at oracle.com Wed Aug 29 16:08:42 2018 From: sergey.kuksenko at oracle.com (sergey.kuksenko at oracle.com) Date: Wed, 29 Aug 2018 16:08:42 +0000 Subject: hg: valhalla/valhalla: add acmp benchmarks Message-ID: <201808291608.w7TG8hEr011942@aojmv0008.oracle.com> Changeset: 05b738a90a5d Author: Sergey Kuksenko Date: 2018-08-29 09:06 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/05b738a90a5d add acmp benchmarks ! test/benchmarks/pom.xml + test/benchmarks/src/main/java/oracle/micro/valhalla/AcmpBase.java - test/benchmarks/src/main/java/oracle/micro/valhalla/BigDataSize.java - test/benchmarks/src/main/java/oracle/micro/valhalla/SmallDataSize.java + test/benchmarks/src/main/java/oracle/micro/valhalla/baseline/acmp/IsCmp.java + test/benchmarks/src/main/java/oracle/micro/valhalla/baseline/acmp/IsNull.java + test/benchmarks/src/main/java/oracle/micro/valhalla/baseline/acmp/TrivialEquals.java + test/benchmarks/src/main/java/oracle/micro/valhalla/baseline/acmp/TrivialNotEquals.java ! test/benchmarks/src/main/java/oracle/micro/valhalla/baseline/arraysum/Arraysum1.java ! test/benchmarks/src/main/java/oracle/micro/valhalla/baseline/arraysum/Arraysum2.java ! test/benchmarks/src/main/java/oracle/micro/valhalla/baseline/arraysum/Arraysum8.java From sergey.kuksenko at oracle.com Wed Aug 29 20:30:09 2018 From: sergey.kuksenko at oracle.com (Sergey Kuksenko) Date: Wed, 29 Aug 2018 13:30:09 -0700 Subject: optimizing acmp in L-World In-Reply-To: References: <47625659-9B0E-481C-B755-4C5C4E2DE23C@oracle.com> <6654e587-6e23-24ab-f992-5d2e28c8e8ac@oracle.com> <6f6a545e-6ccd-b807-fe64-ffaa87aa6290@oracle.com> <29ae9ba8-5160-0adf-347c-43a0256df820@oracle.com> Message-ID: <8ac3dea6-ca38-618d-42bb-251d69cc3204@oracle.com> Hi Tobias, I've done and put 'acmp' microbenchmarks into repository. You can find them in 'oracle.micro.valhalla.baseline.acmp' package. I think that is quite representative set. The key idea is to compare a set of references inside loop. There are two versions: where comparison is used for branching (if-condition) and comparison is used as boolean value. Also benchmarks have parameter which allows to control percentage of equals/not-equals values. Two issues related to -XX:+UseOldCmp were found: 1. Operation '!=' when 100% values are equal causes JVM crash (JMH options to reproduce: "IsCmp.isNotCmpBranch ? -p eq=100") 2. -XX:+UseOldCmp? and PrintAssembly causes JVM crash (particularly when I tried to used "-prof? perfasm" JMH option) Non-isolated benchmarks (when 'acmp' code is inlined) show that -XX:+UseOldCmp is always faster than -XX:-UseOldCmp. I've attached 4 charts showing this ('==' and '!=' operations, branching and boolean value) And also there is another consideration related to CompressedOops. Before Valhalla, reference comparison don't care about uncompressing oops, because of comparison of compressed oops is enough. -XX:-UseOldCmp performs uncompressing both references. That increase 'acmp' overhead. -XX:+UseOldCmp may uncompress only the one reference and only in case when compressed oops are equals. On 08/27/2018 11:23 AM, Sergey Kuksenko wrote: > Hi Tobias, > > I've checked your benchmark and UseOldAcmp option. > > I have to say that according my measurements? -XX:+UseOldAcmp shows > better performance in all cases, even comparing the same references. I > managed to make and repeat a corner case when the same refs has better > performance with -XX:-UseOldAcmp. The reason of this is the fact that > -XX:-UseOldAcmp generated code uses conditional move into result > register, but -XX:+UseOldAcmp generates branches. So if > -XX:-UseOldAcmp will generate branches -it will be slower, or if > -XX:+UseOldAcmp won't generate branches - it will be faster. > I think benchmark measuring isolated acmp performance is not relevant > to usages of acmp in applications. Isolated - I mean - not inlined > method with the result in register. Right now I am trying to make a > non isolated benchmark where acmp is used for condition and correspond > branching. > > I've found yet another benchmarking pitfall here. Typically JMH > executes all subbenchmarks in separate VMs, that cases that measuring > o1==o1 we that have only that branch in the profile. If you want to > measure full acmp performance, full - means when all acmp branches are > in the profile, you have to use yet another JMH option? "-wm BULK" > which provides bulk warmup of all combinations before measurement. > > As for markOopDesc::always_locked_pattern = 0x405 - just tell me when > it'll be ready and I'll check it. But anyway cost of this should be > higher than 1 bit in class word. > > On 08/24/2018 07:05 AM, Tobias Hartmann wrote: >> Hi Sergey, >> >> On 22.08.2018 01:21, Sergey Kuksenko wrote: >>> I'd rather suggest in case of branching to replace >>> >>> ??mov??? 0x8(%rcx),%r11d >>> ??mov??? %r11,%r10 >>> ??shr??? $0x3,%r10 >>> ??test?? $0x1,%r10 >>> ??jne... >>> >>> with >>> >>> ??test??? 0x8(%rcx),$0x8 >>> ??jne... >>> >>> It will save registers which may be visible on highly inlined code. >> Yes but that's only possible if we are testing against a single bit. >> That's the case with the >> current klass pointer alignment trick but that will go away. In the >> future we will use a special bit >> pattern in the mark word (markOopDesc::always_locked_pattern = 0x405) >> which has multiple bits set. >> To test for a value type, we then need to do something like this: >> >> ?? mov??? $0x405,%r10d >> ?? and??? (%rcx),%r10 >> ?? cmp??? $0x405,%r10 >> ?? je???? -> is_value >> >> Or this one: >> >> ?? mov??? $0xffffffffffffffff,%r10 >> ?? xor??? (%rcx),%r10 >> ?? test?? $0x405,%r10 >> ?? je???? -> is_value >> >> I'm currently working on updating the patch to use the mark word but >> I need more time. I've noticed >> that the perturbing approach is much more difficult in that case. The >> best instruction sequence I >> could come up with is something like: >> >> ?? mov??? (%rcx),%r10 >> ?? mov??? $0x405,%r11d >> ?? andn?? %r11,%r10,%r10???????????? // r10 = 0 for values, > 0 for >> others >> ?? dec??? %r10?????????????????????? // r10 < 0 for values, >= 0 for >> others >> ?? sar??? $0x3f,%r10 >> ?? add??? %r10,%rcx >> >> Or this one: >> >> ?? movabs $0x7ffffffffffffbfb,%r10?? // MAX_LONG - 0x405 + 1 >> ?? mov??? $0x405,%r11d >> ?? and??? (%rcx),%r11 >> ?? add??? %r10,%r11????????????????? // This will overflow to >> MIN_LONG for values >> ?? sar??? $0x3f,%r11 >> ?? add??? %r11,%rcx >> >> One could also use the set* instructions but we can currently not >> easily lower these from C2 IR: >> >> ?? mov?? (%rcx), %rdx >> ?? xorl? %eax, %eax >> ?? andl? $0x405, %edx >> ?? cmpq? $0x405, %rdx >> ?? sete? %al >> ?? add?? %rcx, %rax >> >> I've also checked if the BMI instructions (other than "andn") would >> help but don't think so. >> >> Looks like this complexity is an argument against the perturbation >> approach. I'll nevertheless >> implement both approaches and report back once I have a working version. >> >>> I just want to give you couple advices about microbenchmarks. >>> - double DON_INLINE is not requred, having only on "cmpEq" is enough >>> and you'll get less noisy >>> invocations overhead. >>> - dealing with small operations it's better to switch to benchmark >>> mode to average time in >>> nanoseconds - that allows to quickly notice if something wrong. >> Okay, thanks. I'll update my benchmark accordingly. >> >>> I am still thinking how to make representative set of acmp micros, >>> to properly cover inlined case as >>> the most important. >>> I'll push them when they will be ready. >> Sounds good! >> >> I'm using the following test cases for correctness testing of the >> acmp specific C2 optimizations: >> http://hg.openjdk.java.net/valhalla/valhalla/file/d8a6985f0b99/test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java >> >> >> Best regards, >> Tobias > From sergey.kuksenko at oracle.com Wed Aug 29 20:39:35 2018 From: sergey.kuksenko at oracle.com (Sergey Kuksenko) Date: Wed, 29 Aug 2018 13:39:35 -0700 Subject: optimizing acmp in L-World In-Reply-To: <8ac3dea6-ca38-618d-42bb-251d69cc3204@oracle.com> References: <47625659-9B0E-481C-B755-4C5C4E2DE23C@oracle.com> <6654e587-6e23-24ab-f992-5d2e28c8e8ac@oracle.com> <6f6a545e-6ccd-b807-fe64-ffaa87aa6290@oracle.com> <29ae9ba8-5160-0adf-347c-43a0256df820@oracle.com> <8ac3dea6-ca38-618d-42bb-251d69cc3204@oracle.com> Message-ID: <8545cd06-bda1-51f7-3bb6-7bc7a622b6f0@oracle.com> Oops. Attachments were cut. Put it here http://cr.openjdk.java.net/~skuksenko/valhalla/acmp/ On 08/29/2018 01:30 PM, Sergey Kuksenko wrote: > Hi Tobias, > > I've done and put 'acmp' microbenchmarks into repository. You can find > them in 'oracle.micro.valhalla.baseline.acmp' package. I think that is > quite representative set. The key idea is to compare a set of > references inside loop. There are two versions: where comparison is > used for branching (if-condition) and comparison is used as boolean > value. Also benchmarks have parameter which allows to control > percentage of equals/not-equals values. > > Two issues related to -XX:+UseOldCmp were found: > 1. Operation '!=' when 100% values are equal causes JVM crash (JMH > options to reproduce: "IsCmp.isNotCmpBranch ? -p eq=100") > 2. -XX:+UseOldCmp? and PrintAssembly causes JVM crash (particularly > when I tried to used "-prof? perfasm" JMH option) > > Non-isolated benchmarks (when 'acmp' code is inlined) show that > -XX:+UseOldCmp is always faster than -XX:-UseOldCmp. > I've attached 4 charts showing this ('==' and '!=' operations, > branching and boolean value) > > And also there is another consideration related to CompressedOops. > Before Valhalla, reference comparison don't care about uncompressing > oops, because of comparison of compressed oops is enough. > > -XX:-UseOldCmp performs uncompressing both references. That increase > 'acmp' overhead. > > -XX:+UseOldCmp may uncompress only the one reference and only in case > when compressed oops are equals. > > > > > On 08/27/2018 11:23 AM, Sergey Kuksenko wrote: >> Hi Tobias, >> >> I've checked your benchmark and UseOldAcmp option. >> >> I have to say that according my measurements? -XX:+UseOldAcmp shows >> better performance in all cases, even comparing the same references. >> I managed to make and repeat a corner case when the same refs has >> better performance with -XX:-UseOldAcmp. The reason of this is the >> fact that -XX:-UseOldAcmp generated code uses conditional move into >> result register, but -XX:+UseOldAcmp generates branches. So if >> -XX:-UseOldAcmp will generate branches -it will be slower, or if >> -XX:+UseOldAcmp won't generate branches - it will be faster. >> I think benchmark measuring isolated acmp performance is not relevant >> to usages of acmp in applications. Isolated - I mean - not inlined >> method with the result in register. Right now I am trying to make a >> non isolated benchmark where acmp is used for condition and >> correspond branching. >> >> I've found yet another benchmarking pitfall here. Typically JMH >> executes all subbenchmarks in separate VMs, that cases that measuring >> o1==o1 we that have only that branch in the profile. If you want to >> measure full acmp performance, full - means when all acmp branches >> are in the profile, you have to use yet another JMH option? "-wm >> BULK" which provides bulk warmup of all combinations before measurement. >> >> As for markOopDesc::always_locked_pattern = 0x405 - just tell me when >> it'll be ready and I'll check it. But anyway cost of this should be >> higher than 1 bit in class word. >> >> On 08/24/2018 07:05 AM, Tobias Hartmann wrote: >>> Hi Sergey, >>> >>> On 22.08.2018 01:21, Sergey Kuksenko wrote: >>>> I'd rather suggest in case of branching to replace >>>> >>>> ??mov??? 0x8(%rcx),%r11d >>>> ??mov??? %r11,%r10 >>>> ??shr??? $0x3,%r10 >>>> ??test?? $0x1,%r10 >>>> ??jne... >>>> >>>> with >>>> >>>> ??test??? 0x8(%rcx),$0x8 >>>> ??jne... >>>> >>>> It will save registers which may be visible on highly inlined code. >>> Yes but that's only possible if we are testing against a single bit. >>> That's the case with the >>> current klass pointer alignment trick but that will go away. In the >>> future we will use a special bit >>> pattern in the mark word (markOopDesc::always_locked_pattern = >>> 0x405) which has multiple bits set. >>> To test for a value type, we then need to do something like this: >>> >>> ?? mov??? $0x405,%r10d >>> ?? and??? (%rcx),%r10 >>> ?? cmp??? $0x405,%r10 >>> ?? je???? -> is_value >>> >>> Or this one: >>> >>> ?? mov??? $0xffffffffffffffff,%r10 >>> ?? xor??? (%rcx),%r10 >>> ?? test?? $0x405,%r10 >>> ?? je???? -> is_value >>> >>> I'm currently working on updating the patch to use the mark word but >>> I need more time. I've noticed >>> that the perturbing approach is much more difficult in that case. >>> The best instruction sequence I >>> could come up with is something like: >>> >>> ?? mov??? (%rcx),%r10 >>> ?? mov??? $0x405,%r11d >>> ?? andn?? %r11,%r10,%r10???????????? // r10 = 0 for values, > 0 for >>> others >>> ?? dec??? %r10?????????????????????? // r10 < 0 for values, >= 0 for >>> others >>> ?? sar??? $0x3f,%r10 >>> ?? add??? %r10,%rcx >>> >>> Or this one: >>> >>> ?? movabs $0x7ffffffffffffbfb,%r10?? // MAX_LONG - 0x405 + 1 >>> ?? mov??? $0x405,%r11d >>> ?? and??? (%rcx),%r11 >>> ?? add??? %r10,%r11????????????????? // This will overflow to >>> MIN_LONG for values >>> ?? sar??? $0x3f,%r11 >>> ?? add??? %r11,%rcx >>> >>> One could also use the set* instructions but we can currently not >>> easily lower these from C2 IR: >>> >>> ?? mov?? (%rcx), %rdx >>> ?? xorl? %eax, %eax >>> ?? andl? $0x405, %edx >>> ?? cmpq? $0x405, %rdx >>> ?? sete? %al >>> ?? add?? %rcx, %rax >>> >>> I've also checked if the BMI instructions (other than "andn") would >>> help but don't think so. >>> >>> Looks like this complexity is an argument against the perturbation >>> approach. I'll nevertheless >>> implement both approaches and report back once I have a working >>> version. >>> >>>> I just want to give you couple advices about microbenchmarks. >>>> - double DON_INLINE is not requred, having only on "cmpEq" is >>>> enough and you'll get less noisy >>>> invocations overhead. >>>> - dealing with small operations it's better to switch to benchmark >>>> mode to average time in >>>> nanoseconds - that allows to quickly notice if something wrong. >>> Okay, thanks. I'll update my benchmark accordingly. >>> >>>> I am still thinking how to make representative set of acmp micros, >>>> to properly cover inlined case as >>>> the most important. >>>> I'll push them when they will be ready. >>> Sounds good! >>> >>> I'm using the following test cases for correctness testing of the >>> acmp specific C2 optimizations: >>> http://hg.openjdk.java.net/valhalla/valhalla/file/d8a6985f0b99/test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java >>> >>> >>> Best regards, >>> Tobias >> > From tobias.hartmann at oracle.com Thu Aug 30 13:00:27 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 30 Aug 2018 15:00:27 +0200 Subject: Value type sorting In-Reply-To: <6EF96F07-F0FB-4A94-8799-E9D04EAF200E@oracle.com> References: <37506437-3946-47c8-a2a4-4490af2b1830@cs.oswego.edu> <3f6bfb0e-7d9e-1336-bf85-38964e0151f1@oracle.com> <84048716-fcae-1bb1-9562-a738a4e6d4fe@cs.oswego.edu> <6EF96F07-F0FB-4A94-8799-E9D04EAF200E@oracle.com> Message-ID: <3325b5aa-2f9e-c6a0-6e80-9718eaa9b367@oracle.com> Hi John, On 27.08.2018 19:29, John Rose wrote: > So this doesn't fold up: ?((a < b) ? -1 : (a == b) ? 0 : 1) > 0. > I suspect it *would* fold up (via split-if?) if by pure chance > the expression were (a > b) ? 1 : (? ?something <= 0 ?). Yes, that expression is folded. > This variation ((a < b) ? -1 : (a == b) ? 0 : 1) < 0 ?probably > *does* fold up. Yes, there are some cases that C2 is able to optimize. I've created a test that checks the most common cases: http://cr.openjdk.java.net/~thartmann/8210215/webrev.00/test/hotspot/jtreg/compiler/codegen/TestTrichotomyExpressions.java.html Out of these 54 tests, C2 can optimize only 16. For all other 38 tests, C2 emits two comparisons. > C2 doesn't handle trichotomy calculations as well as it should. > There is no TypeInt::CC_NE, for example. ?And these trivial > but nested ?:?: expressions are not inspected vigorously > enough. ?They should be. ?I don't think we can do anything > about CC_NE, though. ?But maybe we can transform (?:?:) > cmp x by reordering the (?:?:) so the top-level ?: shows > sides that appear on either side of x. Yes, I've filed JDK-8210215 [1] for that and implemented a prototype: http://cr.openjdk.java.net/~thartmann/8210215/webrev.00/ (not yet ready for review/production but I'll follow up with a RFR for JDK 12 soon) Unfortunately, the fix is a bit more complicated than expected because there are many different cases. However, with this patch, C2 is able to optimize *all* 54 cases of the above test and nicely folds them to a single comparison. Thanks, Tobias [1] https://bugs.openjdk.java.net/browse/JDK-8210215 From tobias.hartmann at oracle.com Thu Aug 30 13:22:09 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 30 Aug 2018 15:22:09 +0200 Subject: RFR(M): 8209134: [lworld] New nmethod entry point for unscalarized (nullable) value type arguments In-Reply-To: References: <55c3f0c2-c951-4ee2-e5eb-9120e42d1177@oracle.com> Message-ID: <3c2f946f-a1e8-8304-cafb-e1cbe232bd6a@oracle.com> Hi Roland, thanks for the review! On 29.08.2018 16:04, Roland Westrelin wrote: > Why move things around in nmethod::print_nmethod_labels()? That fixes a bug that also exists in mainline where the parameter list is printed *after* the [Entry Point] and [Verified Entry Point] labels: [Entry Point] [Verified Entry Point] # {method} {0x00007f56838251b8} 'testGreater1' '(II)Z' in 'MyTest' # parm0: rsi = int # parm1: rdx = int # [sp+0x20] (sp of caller) ;; N1: # B1 <- B3 Freq: 1 ;; B1: # B4 B2 <- BLOCK HEAD IS JUNK Freq: 1 0x00007f56984da0c0: mov %eax,-0x16000(%rsp) It should look like this: # {method} {0x00007f56838251b8} 'testGreater1' '(II)Z' in 'MyTest' # parm0: rsi = int # parm1: rdx = int # [sp+0x20] (sp of caller) ;; N1: # B1 <- B3 Freq: 1 ;; B1: # B4 B2 <- BLOCK HEAD IS JUNK Freq: 1 [Entry Point] [Verified Entry Point] 0x00007f56984da0c0: mov %eax,-0x16000(%rsp) > Why is the Q showing up in signature.cpp? Because I've modified the code in sharedRuntime_x86_64.cpp to now also save the extended signature if a value type argument is passed as oop. That's required because we need the extended signature in MacroAssembler::null_check_value_args() to determine which arguments are value type oops. Thanks, Tobias From rwestrel at redhat.com Thu Aug 30 15:57:04 2018 From: rwestrel at redhat.com (Roland Westrelin) Date: Thu, 30 Aug 2018 17:57:04 +0200 Subject: RFR(M): 8209134: [lworld] New nmethod entry point for unscalarized (nullable) value type arguments In-Reply-To: <3c2f946f-a1e8-8304-cafb-e1cbe232bd6a@oracle.com> References: <55c3f0c2-c951-4ee2-e5eb-9120e42d1177@oracle.com> <3c2f946f-a1e8-8304-cafb-e1cbe232bd6a@oracle.com> Message-ID: Hi Tobias, Thanks for answering the questions. That looks good to me. Roland. From tobias.hartmann at oracle.com Thu Aug 30 15:59:30 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 30 Aug 2018 17:59:30 +0200 Subject: RFR(M): 8209134: [lworld] New nmethod entry point for unscalarized (nullable) value type arguments In-Reply-To: References: <55c3f0c2-c951-4ee2-e5eb-9120e42d1177@oracle.com> <3c2f946f-a1e8-8304-cafb-e1cbe232bd6a@oracle.com> Message-ID: Thanks Roland. Best regards, Tobias On 30.08.2018 17:57, Roland Westrelin wrote: > > Hi Tobias, > > Thanks for answering the questions. That looks good to me. > > Roland. > From tobias.hartmann at oracle.com Fri Aug 31 09:43:23 2018 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Fri, 31 Aug 2018 09:43:23 +0000 Subject: hg: valhalla/valhalla: 8209134: [lworld] New nmethod entry point for unscalarized (nullable) value type arguments Message-ID: <201808310943.w7V9hONc016086@aojmv0008.oracle.com> Changeset: b67209827a78 Author: thartmann Date: 2018-08-31 11:43 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b67209827a78 8209134: [lworld] New nmethod entry point for unscalarized (nullable) value type arguments Reviewed-by: roland ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/methodHandles_x86.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/asm/codeBuffer.hpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/machnode.hpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/output.cpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/opto/type.cpp ! src/hotspot/share/runtime/signature.cpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestMethodHandles.java From tobias.hartmann at oracle.com Fri Aug 31 13:04:14 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 31 Aug 2018 15:04:14 +0200 Subject: optimizing acmp in L-World In-Reply-To: <8ac3dea6-ca38-618d-42bb-251d69cc3204@oracle.com> References: <47625659-9B0E-481C-B755-4C5C4E2DE23C@oracle.com> <6654e587-6e23-24ab-f992-5d2e28c8e8ac@oracle.com> <6f6a545e-6ccd-b807-fe64-ffaa87aa6290@oracle.com> <29ae9ba8-5160-0adf-347c-43a0256df820@oracle.com> <8ac3dea6-ca38-618d-42bb-251d69cc3204@oracle.com> Message-ID: Hi Sergey, here's a new webrev that uses the always locked mark word pattern and completely removes the klass pointer alignment code: http://cr.openjdk.java.net/~thartmann/valhalla/lworld/acmp_optimization/webrev.01/ Old acmp is now the default. The perturbation scheme can be enabled by -XX:+UsePointerPerturbation. I've filed an enhancement for this and will follow up with a RFE once the numbers look good: https://bugs.openjdk.java.net/browse/JDK-8210260 On 29.08.2018 22:30, Sergey Kuksenko wrote: > I've done and put 'acmp' microbenchmarks into repository. You can find them in > 'oracle.micro.valhalla.baseline.acmp' package. I think that is quite representative set. The key > idea is to compare a set of references inside loop. There are two versions: where comparison is used > for branching (if-condition) and comparison is used as boolean value. Also benchmarks have parameter > which allows to control percentage of equals/not-equals values. Great, thank you! > Two issues related to -XX:+UseOldCmp were found: > 1. Operation '!=' when 100% values are equal causes JVM crash (JMH options to reproduce: > "IsCmp.isNotCmpBranch ? -p eq=100") Thanks, I was able to reproduce this, fixed the problem and added a regression test case. > 2. -XX:+UseOldCmp? and PrintAssembly causes JVM crash (particularly when I tried to used "-prof? > perfasm" JMH option) I was not able to reproduce this with the latest webrev. I've tried running all acmp benchmarks with -prof perfasm. Which benchmark/settings triggered this for you? > Non-isolated benchmarks (when 'acmp' code is inlined) show that -XX:+UseOldCmp is always faster than > -XX:-UseOldCmp. > I've attached 4 charts showing this ('==' and '!=' operations, branching and boolean value) Okay, thanks for the details. Could you re-evaluate this with the new webrev? > And also there is another consideration related to CompressedOops. Before Valhalla, reference > comparison don't care about uncompressing oops, because of comparison of compressed oops is enough. > > -XX:-UseOldCmp performs uncompressing both references. That increase 'acmp' overhead. > -XX:+UseOldCmp may uncompress only the one reference and only in case when compressed oops are equals. Yes, that's true. >> I have to say that according my measurements? -XX:+UseOldAcmp shows better performance in all >> cases, even comparing the same references. I managed to make and repeat a corner case when the >> same refs has better performance with -XX:-UseOldAcmp. The reason of this is the fact that >> -XX:-UseOldAcmp generated code uses conditional move into result register, but -XX:+UseOldAcmp >> generates branches. So if -XX:-UseOldAcmp will generate branches -it will be slower, or if >> -XX:+UseOldAcmp won't generate branches - it will be faster. >> I think benchmark measuring isolated acmp performance is not relevant to usages of acmp in >> applications. Isolated - I mean - not inlined method with the result in register. Right now I am >> trying to make a non isolated benchmark where acmp is used for condition and correspond branching. Yes, acmp used in isolation should not be a common case. If it's hot, C2 will inline. >> I've found yet another benchmarking pitfall here. Typically JMH executes all subbenchmarks in >> separate VMs, that cases that measuring o1==o1 we that have only that branch in the profile. If >> you want to measure full acmp performance, full - means when all acmp branches are in the profile, >> you have to use yet another JMH option? "-wm BULK" which provides bulk warmup of all combinations >> before measurement. Yes but that depends on what you want to measure. We should also have benchmarks for the case where C2 cuts of branches due to profile information suggesting that these are never taken. Thanks, Tobias From tobias.hartmann at oracle.com Fri Aug 31 13:47:41 2018 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 31 Aug 2018 15:47:41 +0200 Subject: accessing unknown value type element in Object[] array & GC barriers In-Reply-To: References: Message-ID: <0fe04e50-d3cf-3a80-a3e4-8a54a95f249a@oracle.com> Hi Roland, On 29.08.2018 14:02, Roland Westrelin wrote: > Other unrelated question: how does the size of the element of a > flattened array compare to the size of value instance? Do they differ or > can we use either one interchangeably? Code currently relies on the fact that the fields are at the same offset both for a value type instance, a flattened field, or a flattened array element. Since all fields are at the same offset, I would assume that the size is also the same. Best regards, Tobias From david.simms at oracle.com Fri Aug 31 14:09:14 2018 From: david.simms at oracle.com (David Simms) Date: Fri, 31 Aug 2018 16:09:14 +0200 Subject: accessing unknown value type element in Object[] array & GC barriers In-Reply-To: References: Message-ID: Hi Roland, sorry for the delayed reply... I doubled checked, you are correct, that ZGC does not use the clone intrinsic. Going forward it will, but on TODO list just now. "ValueKlass::value_store()" currently issues write barrier for traditional GCs, and mostly ignores the Access API. ZGC is (will be) disabled in the prototype...but LW10 will need it. Current hack is "BarrierSet::write_ref_array_pre", then copy, then "BarrierSet::write_ref_array()" For read barriers... I'm hoping to get some time to discuss additions to the Access API specifically for value types. Yeah are correct that clone, array store/load to/from heap buffer (i.e. an oop) and loading fields from heap buffered value types all have similar problems. First the source oop when reading from heap buffer (i.e. i2c) will need a read barrier, then the contents need read barrier at their use time, which for array store (and copy) would be immediately before store. The size of the actual element payload in flatten array is the same as the instance...but the addressing is power of 2, so the "element size" may contain some padding which we don't touch. /D On 29/08/18 14:02, Roland Westrelin wrote: > A question for someone familiar with GC barriers below... > > Currently for: > > Object array_load(Object[] array) { > return array[0]; > } > > we roughly emit: > > Object array_load(Object[] array) { > if (is_flattened(array)) { deoptimize(); } > return array[0]; > } > > Same thing for: > > void array_store(Object[] array, Object o) { > array[0] = o; > } > > roughly emitted as: > > void array_store(Object[] array, Object o) { > if (is_flattened(array)) { deoptimize(); } > array[0] = o; > } > > Instead we would want: > > Object array_load(Object[] array) { > Object v; > if (is_flattened(array)) { > v = array.getComponentType().newInstance(); > copy(v, array[0]); > } else { > v = array[0]; > } > return v; > } > > The first if branch is similar to the clone intrinsic (we're not copying > from an instance but from some flattened array element) so reusing that > machinery is possible (and prototyped). The problem here is that if the > unknown value has oop fields, depending on the gc, barriers might be > needed. In its current state ZGC doesn't support the clone intrinsic and > so we wouldn't support the pattern above with ZGC either. > > void array_store(Object[] array, Object o) { > if (is_flattened(array)) { > copy(array[0], o); > post_barrier(); > } else { > array[0] = o; > } > } > > Again somewhat similar to the clone intrinsic but copy is not to a newly > allocated object so we need a barrier. C2 has some support for non > precise post barrier but I'm unclear what to pass to that barrier for > serial/parallel/CMS or G1: the array oop? &array[0]? Are there cases > where several cards need to be marked? > > Other unrelated question: how does the size of the element of a > flattened array compare to the size of value instance? Do they differ or > can we use either one interchangeably? > > Roland. From harold.seigel at oracle.com Fri Aug 31 17:27:37 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Fri, 31 Aug 2018 13:27:37 -0400 Subject: RFR: disable hotspot/compiler/aot testing in LWorld Message-ID: <3a2ced96-8147-3138-3eaa-8178803cf8c3@oracle.com> Hi, Please review this small RFR to disable aot testing in LWorld: Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_no_aot/webrev/index.html Thanks, Harold From frederic.parain at oracle.com Fri Aug 31 17:40:35 2018 From: frederic.parain at oracle.com (Frederic Parain) Date: Fri, 31 Aug 2018 13:40:35 -0400 Subject: RFR: disable hotspot/compiler/aot testing in LWorld In-Reply-To: <3a2ced96-8147-3138-3eaa-8178803cf8c3@oracle.com> References: <3a2ced96-8147-3138-3eaa-8178803cf8c3@oracle.com> Message-ID: Harold, Commenting everything out works but looks extreme. Could it be possible to have something like this instead? protected String vmAOT() { // builds with aot have jaotc in /bin Path bin = Paths.get(System.getProperty("java.home")) .resolve("bin"); Path jaotc; if (Platform.isWindows()) { jaotc = bin.resolve("jaotc.exe?); } else if (WB.getBooleanVMFlag(?EnableValhalla?).booleanValue()) { return ?false?; } else { jaotc = bin.resolve("jaotc"); } return "" + Files.exists(jaotc); } Fred > On Aug 31, 2018, at 13:27, Harold David Seigel wrote: > > Hi, > > Please review this small RFR to disable aot testing in LWorld: > > Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_no_aot/webrev/index.html > > Thanks, Harold > From harold.seigel at oracle.com Fri Aug 31 17:49:14 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Fri, 31 Aug 2018 13:49:14 -0400 Subject: RFR: disable hotspot/compiler/aot testing in LWorld In-Reply-To: References: <3a2ced96-8147-3138-3eaa-8178803cf8c3@oracle.com> Message-ID: <6cb3e035-88f9-5429-d9a1-9e10bc6091a0@oracle.com> Hi Fred, Do we want to always exclude aot testing, or only exclude it when -XX:+EnableValhalla is set ? Thanks, Harold On 8/31/2018 1:40 PM, Frederic Parain wrote: > Harold, > > Commenting everything out works but looks extreme. > Could it be possible to have something like this instead? > > protected String vmAOT() { > > > // builds with aot have jaotc in /bin > > Path bin = Paths.get(System.getProperty("java.home")) > .resolve("bin"); > Path jaotc; > if (Platform.isWindows()) { > jaotc = bin.resolve("jaotc.exe?); > } else if (WB.getBooleanVMFlag(?EnableValhalla?).booleanValue()) { > return ?false?; > } else { > jaotc = bin.resolve("jaotc"); > } > return "" + Files.exists(jaotc); > > } > > Fred > >> On Aug 31, 2018, at 13:27, Harold David Seigel wrote: >> >> Hi, >> >> Please review this small RFR to disable aot testing in LWorld: >> >> Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_no_aot/webrev/index.html >> >> Thanks, Harold >> From frederic.parain at oracle.com Fri Aug 31 17:52:09 2018 From: frederic.parain at oracle.com (Frederic Parain) Date: Fri, 31 Aug 2018 13:52:09 -0400 Subject: RFR: disable hotspot/compiler/aot testing in LWorld In-Reply-To: <6cb3e035-88f9-5429-d9a1-9e10bc6091a0@oracle.com> References: <3a2ced96-8147-3138-3eaa-8178803cf8c3@oracle.com> <6cb3e035-88f9-5429-d9a1-9e10bc6091a0@oracle.com> Message-ID: <83F9E084-779D-4255-8FB8-ACDBCC744724@oracle.com> Good question. Testing with EnableValhalla disabled would ensure that we didn?t break anything, but do we have the testing cycles to do it? Or do we just not care for now? Fred > On Aug 31, 2018, at 13:49, Harold David Seigel wrote: > > Hi Fred, > > Do we want to always exclude aot testing, or only exclude it when -XX:+EnableValhalla is set ? > > Thanks, Harold > > > On 8/31/2018 1:40 PM, Frederic Parain wrote: >> Harold, >> >> Commenting everything out works but looks extreme. >> Could it be possible to have something like this instead? >> >> protected String vmAOT() { >> >> >> // builds with aot have jaotc in /bin >> >> Path bin = Paths.get(System.getProperty("java.home")) >> .resolve("bin"); >> Path jaotc; >> if (Platform.isWindows()) { >> jaotc = bin.resolve("jaotc.exe?); >> } else if (WB.getBooleanVMFlag(?EnableValhalla?).booleanValue()) { >> return ?false?; >> } else { >> jaotc = bin.resolve("jaotc"); >> } >> return "" + Files.exists(jaotc); >> >> } >> >> Fred >> >>> On Aug 31, 2018, at 13:27, Harold David Seigel wrote: >>> >>> Hi, >>> >>> Please review this small RFR to disable aot testing in LWorld: >>> >>> Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_no_aot/webrev/index.html >>> >>> Thanks, Harold >>> > From harold.seigel at oracle.com Fri Aug 31 17:58:48 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Fri, 31 Aug 2018 13:58:48 -0400 Subject: RFR: disable hotspot/compiler/aot testing in LWorld In-Reply-To: <83F9E084-779D-4255-8FB8-ACDBCC744724@oracle.com> References: <3a2ced96-8147-3138-3eaa-8178803cf8c3@oracle.com> <6cb3e035-88f9-5429-d9a1-9e10bc6091a0@oracle.com> <83F9E084-779D-4255-8FB8-ACDBCC744724@oracle.com> Message-ID: <5c40f871-7132-cf55-849e-65b41f20a92a@oracle.com> How about if I disable aot testing for +EnableValhalla and we can always remove it completely later on. I think it should be disabled for Windows also, since we are now testing tier1 on Windows. Does this look okay? ??? protected String vmAOT() { *??????? if (WB.getBooleanVMFlag("EnableValhalla").booleanValue()) {** **??????????? return "false";** **??????? }* ??????? // builds with aot have jaotc in /bin ??????? Path bin = Paths.get(System.getProperty("java.home")) ??????????????????????? .resolve("bin"); ??????? Path jaotc; ??????? if (Platform.isWindows()) { ??????????? jaotc = bin.resolve("jaotc.exe"); ??????? } else { ??????????? jaotc = bin.resolve("jaotc"); ??????? } ??????? return "" + Files.exists(jaotc); ??? } Thanks, Harold On 8/31/2018 1:52 PM, Frederic Parain wrote: > Good question. Testing with EnableValhalla disabled would ensure that we > didn?t break anything, but do we have the testing cycles to do it? Or do we > just not care for now? > > Fred > > >> On Aug 31, 2018, at 13:49, Harold David Seigel wrote: >> >> Hi Fred, >> >> Do we want to always exclude aot testing, or only exclude it when -XX:+EnableValhalla is set ? >> >> Thanks, Harold >> >> >> On 8/31/2018 1:40 PM, Frederic Parain wrote: >>> Harold, >>> >>> Commenting everything out works but looks extreme. >>> Could it be possible to have something like this instead? >>> >>> protected String vmAOT() { >>> >>> >>> // builds with aot have jaotc in /bin >>> >>> Path bin = Paths.get(System.getProperty("java.home")) >>> .resolve("bin"); >>> Path jaotc; >>> if (Platform.isWindows()) { >>> jaotc = bin.resolve("jaotc.exe?); >>> } else if (WB.getBooleanVMFlag(?EnableValhalla?).booleanValue()) { >>> return ?false?; >>> } else { >>> jaotc = bin.resolve("jaotc"); >>> } >>> return "" + Files.exists(jaotc); >>> >>> } >>> >>> Fred >>> >>>> On Aug 31, 2018, at 13:27, Harold David Seigel wrote: >>>> >>>> Hi, >>>> >>>> Please review this small RFR to disable aot testing in LWorld: >>>> >>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_no_aot/webrev/index.html >>>> >>>> Thanks, Harold >>>> From frederic.parain at oracle.com Fri Aug 31 18:04:27 2018 From: frederic.parain at oracle.com (Frederic Parain) Date: Fri, 31 Aug 2018 14:04:27 -0400 Subject: RFR: disable hotspot/compiler/aot testing in LWorld In-Reply-To: <5c40f871-7132-cf55-849e-65b41f20a92a@oracle.com> References: <3a2ced96-8147-3138-3eaa-8178803cf8c3@oracle.com> <6cb3e035-88f9-5429-d9a1-9e10bc6091a0@oracle.com> <83F9E084-779D-4255-8FB8-ACDBCC744724@oracle.com> <5c40f871-7132-cf55-849e-65b41f20a92a@oracle.com> Message-ID: <62A9B564-A074-4CC9-AA0C-86170B2B66FD@oracle.com> Looks even better. Thank you for fixing this. Fred > On Aug 31, 2018, at 13:58, Harold David Seigel wrote: > > How about if I disable aot testing for +EnableValhalla and we can always remove it completely later on. > > I think it should be disabled for Windows also, since we are now testing tier1 on Windows. > > Does this look okay? > protected String vmAOT() { > if (WB.getBooleanVMFlag("EnableValhalla").booleanValue()) { > return "false"; > } > // builds with aot have jaotc in /bin > Path bin = Paths.get(System.getProperty("java.home")) > .resolve("bin"); > Path jaotc; > if (Platform.isWindows()) { > jaotc = bin.resolve("jaotc.exe"); > } else { > jaotc = bin.resolve("jaotc"); > } > return "" + Files.exists(jaotc); > } > Thanks, Harold > > On 8/31/2018 1:52 PM, Frederic Parain wrote: >> Good question. Testing with EnableValhalla disabled would ensure that we >> didn?t break anything, but do we have the testing cycles to do it? Or do we >> just not care for now? >> >> Fred >> >> >> >>> On Aug 31, 2018, at 13:49, Harold David Seigel >>> wrote: >>> >>> Hi Fred, >>> >>> Do we want to always exclude aot testing, or only exclude it when -XX:+EnableValhalla is set ? >>> >>> Thanks, Harold >>> >>> >>> On 8/31/2018 1:40 PM, Frederic Parain wrote: >>> >>>> Harold, >>>> >>>> Commenting everything out works but looks extreme. >>>> Could it be possible to have something like this instead? >>>> >>>> protected String vmAOT() { >>>> >>>> >>>> // builds with aot have jaotc in /bin >>>> >>>> Path bin = Paths.get(System.getProperty("java.home")) >>>> .resolve("bin"); >>>> Path jaotc; >>>> if (Platform.isWindows()) { >>>> jaotc = bin.resolve("jaotc.exe?); >>>> } else if (WB.getBooleanVMFlag(?EnableValhalla?).booleanValue()) { >>>> return ?false?; >>>> } else { >>>> jaotc = bin.resolve("jaotc"); >>>> } >>>> return "" + Files.exists(jaotc); >>>> >>>> } >>>> >>>> Fred >>>> >>>> >>>>> On Aug 31, 2018, at 13:27, Harold David Seigel >>>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> Please review this small RFR to disable aot testing in LWorld: >>>>> >>>>> Open Webrev: >>>>> http://cr.openjdk.java.net/~hseigel/lworld_no_aot/webrev/index.html >>>>> >>>>> >>>>> Thanks, Harold >>>>> >>>>> > From harold.seigel at oracle.com Fri Aug 31 18:08:39 2018 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Fri, 31 Aug 2018 18:08:39 +0000 Subject: hg: valhalla/valhalla: Summary: Don't run hs/compiler/aot tests if +EnableValhalla Message-ID: <201808311808.w7VI8eQA027339@aojmv0008.oracle.com> Changeset: 4693289f124a Author: hseigel Date: 2018-08-31 14:08 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4693289f124a Summary: Don't run hs/compiler/aot tests if +EnableValhalla Reviewed-by: fparain ! test/jtreg-ext/requires/VMProps.java From harold.seigel at oracle.com Fri Aug 31 18:09:02 2018 From: harold.seigel at oracle.com (Harold David Seigel) Date: Fri, 31 Aug 2018 14:09:02 -0400 Subject: RFR: disable hotspot/compiler/aot testing in LWorld In-Reply-To: <62A9B564-A074-4CC9-AA0C-86170B2B66FD@oracle.com> References: <3a2ced96-8147-3138-3eaa-8178803cf8c3@oracle.com> <6cb3e035-88f9-5429-d9a1-9e10bc6091a0@oracle.com> <83F9E084-779D-4255-8FB8-ACDBCC744724@oracle.com> <5c40f871-7132-cf55-849e-65b41f20a92a@oracle.com> <62A9B564-A074-4CC9-AA0C-86170B2B66FD@oracle.com> Message-ID: Thanks for your suggestion. Harold On 8/31/2018 2:04 PM, Frederic Parain wrote: > Looks even better. > Thank you for fixing this. > > Fred > > >> On Aug 31, 2018, at 13:58, Harold David Seigel wrote: >> >> How about if I disable aot testing for +EnableValhalla and we can always remove it completely later on. >> >> I think it should be disabled for Windows also, since we are now testing tier1 on Windows. >> >> Does this look okay? >> protected String vmAOT() { >> if (WB.getBooleanVMFlag("EnableValhalla").booleanValue()) { >> return "false"; >> } >> // builds with aot have jaotc in /bin >> Path bin = Paths.get(System.getProperty("java.home")) >> .resolve("bin"); >> Path jaotc; >> if (Platform.isWindows()) { >> jaotc = bin.resolve("jaotc.exe"); >> } else { >> jaotc = bin.resolve("jaotc"); >> } >> return "" + Files.exists(jaotc); >> } >> Thanks, Harold >> >> On 8/31/2018 1:52 PM, Frederic Parain wrote: >>> Good question. Testing with EnableValhalla disabled would ensure that we >>> didn?t break anything, but do we have the testing cycles to do it? Or do we >>> just not care for now? >>> >>> Fred >>> >>> >>> >>>> On Aug 31, 2018, at 13:49, Harold David Seigel >>>> wrote: >>>> >>>> Hi Fred, >>>> >>>> Do we want to always exclude aot testing, or only exclude it when -XX:+EnableValhalla is set ? >>>> >>>> Thanks, Harold >>>> >>>> >>>> On 8/31/2018 1:40 PM, Frederic Parain wrote: >>>> >>>>> Harold, >>>>> >>>>> Commenting everything out works but looks extreme. >>>>> Could it be possible to have something like this instead? >>>>> >>>>> protected String vmAOT() { >>>>> >>>>> >>>>> // builds with aot have jaotc in /bin >>>>> >>>>> Path bin = Paths.get(System.getProperty("java.home")) >>>>> .resolve("bin"); >>>>> Path jaotc; >>>>> if (Platform.isWindows()) { >>>>> jaotc = bin.resolve("jaotc.exe?); >>>>> } else if (WB.getBooleanVMFlag(?EnableValhalla?).booleanValue()) { >>>>> return ?false?; >>>>> } else { >>>>> jaotc = bin.resolve("jaotc"); >>>>> } >>>>> return "" + Files.exists(jaotc); >>>>> >>>>> } >>>>> >>>>> Fred >>>>> >>>>> >>>>>> On Aug 31, 2018, at 13:27, Harold David Seigel >>>>>> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> Please review this small RFR to disable aot testing in LWorld: >>>>>> >>>>>> Open Webrev: >>>>>> http://cr.openjdk.java.net/~hseigel/lworld_no_aot/webrev/index.html >>>>>> >>>>>> >>>>>> Thanks, Harold >>>>>> >>>>>>