RFR 8205026: [lworld] EnableValhalla regression testing

Tobias Hartmann tobias.hartmann at oracle.com
Tue Aug 28 14:42:10 UTC 2018


Hi Harold,

I think it should be "@vm.opt.final.TieredCompilation" but you need to add the corresponding
"vmOptFinalFlag" statement to VMProps.java:
http://hg.openjdk.java.net/jdk/jdk/rev/df02866807b6

Thanks,
Tobias

On 28.08.2018 16:21, Harold David Seigel wrote:
> Hi Tobias,
> 
> That makes sense.  Do you know what the syntax of the @requires statement should be for the tiered
> compilation case?
> 
> Thanks, Haorld
> 
> 
> On 8/28/2018 10:14 AM, Tobias Hartmann wrote:
>> Hi Harold,
>>
>> I think the tiered compilation tests that fail should be fixed by adding a @requires statements that
>> checks that tiered compilation is available (see my comment in JDK-8205947). That functionality was
>> added by JDK-8203923.
>>
>> Thanks,
>> Tobias
>>
>> On 28.08.2018 15:24, Harold David Seigel wrote:
>>> Hi,
>>>
>>> Please review these open changes to help with regression testing.  The files were changed for the
>>> following reasons:
>>>
>>>      .../test/hotspot/jtreg/ProblemList.txt - avoid running failed test .../RedefineLeak.java
>>>
>>>      .../ConstantGettersTransitionsTest.java - avoid running tiered test with -XX:+EnableValhalla
>>>
>>>      .../TestMeetIncompatibleInterfaceArrays.java - avoid running tiered test with
>>> -XX:+EnableValhalla
>>>
>>>      .../ValueOops.java - avoid running test when specific GC's are explicitly specified
>>>
>>>      .../TestPlatformIsTIeredSupported.java - avoid running tiered test with -XX:+EnableValhalla
>>>
>>>      .../VMProps.java - avoid running CDS tests
>>>
>>>
>>> Webrev:  http://cr.openjdk.java.net/~hseigel/bug_8205026/webrev/
>>>
>>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8205026
>>>
>>> Thanks! Harold
>>>
>>>
> 



More information about the valhalla-dev mailing list