RFR JDK-8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type

[Remi Forax]

Looks good to me too.

Rémi

----- Mail original -----
> De: "Frederic Parain" <frederic.parain at oracle.com>
> À: "mandy chung" <mandy.chung at oracle.com>
> Cc: "valhalla-dev" <valhalla-dev at openjdk.java.net>
> Envoyé: Mardi 28 Août 2018 22:57:17
> Objet: Re: RFR JDK-8209896: [lworld] IncompatibleClassChangeError thrown when defining a lambda within value type

> Looks good to me.
> Thank you for fixing this.
> 
> Fred
> 
> 
>> On Aug 28, 2018, at 16:50, mandy chung <mandy.chung at oracle.com> wrote:
>> 
>> The lambda proxy generator currently generates ValueTypes attribute
>> to list the value types that are declared in parameter types and
>> return type.  But it misses the case when a lambda body is defined
>> in a value class but no value type declared in its signature.
>> 
>> This is a simple fix in InnerClassLambdaMetafactory.  I added
>> the test cases for lambda, core reflection, and method handles.
>> 
>> Webrev at:
>> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8209896/webrev.00/
>> 
> > Mandy