RFR: disable hotspot/compiler/aot testing in LWorld

[Harold David Seigel]

How about if I disable aot testing for +EnableValhalla and we can always 
remove it completely later on.

I think it should be disabled for Windows also, since we are now testing 
tier1 on Windows.

Does this look okay?

     protected String vmAOT() {
*        if (WB.getBooleanVMFlag("EnableValhalla").booleanValue()) {**
**            return "false";**
**        }*
         // builds with aot have jaotc in <JDK>/bin
         Path bin = Paths.get(System.getProperty("java.home"))
                         .resolve("bin");
         Path jaotc;
         if (Platform.isWindows()) {
             jaotc = bin.resolve("jaotc.exe");
         } else {
             jaotc = bin.resolve("jaotc");
         }
         return "" + Files.exists(jaotc);
     }

Thanks, Harold


On 8/31/2018 1:52 PM, Frederic Parain wrote:
> Good question. Testing with EnableValhalla disabled would ensure that we
> didn’t break anything, but do we have the testing cycles to do it? Or do we
> just not care for now?
>
> Fred
>
>
>> On Aug 31, 2018, at 13:49, Harold David Seigel <harold.seigel at oracle.com> wrote:
>>
>> Hi Fred,
>>
>> Do we want to always exclude aot testing, or only exclude it when -XX:+EnableValhalla is set ?
>>
>> Thanks, Harold
>>
>>
>> On 8/31/2018 1:40 PM, Frederic Parain wrote:
>>> Harold,
>>>
>>> Commenting everything out works but looks extreme.
>>> Could it be possible to have something like this instead?
>>>
>>>       protected String vmAOT() {
>>>
>>>
>>>           // builds with aot have jaotc in <JDK>/bin
>>>
>>>           Path bin = Paths.get(System.getProperty("java.home"))
>>>                           .resolve("bin");
>>>           Path jaotc;
>>>           if (Platform.isWindows()) {
>>>               jaotc = bin.resolve("jaotc.exe”);
>>>           } else if (WB.getBooleanVMFlag(“EnableValhalla”).booleanValue()) {
>>>              return “false”;
>>>           } else {
>>>               jaotc = bin.resolve("jaotc");
>>>           }
>>>           return "" + Files.exists(jaotc);
>>>
>>>       }
>>>
>>> Fred
>>>
>>>> On Aug 31, 2018, at 13:27, Harold David Seigel <harold.seigel at oracle.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Please review this small RFR to disable aot testing in LWorld:
>>>>
>>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_no_aot/webrev/index.html
>>>>
>>>> Thanks, Harold
>>>>