RFR (s): 8208162: Support for multi-dimensional value arrays is incomplete

[Frederic Parain]

If no code relies on getting the ValueArrayKlass instance, this change makes sense
and it minimizes changes.

I’ll wait for this fix to be pushed before pushing the fix for JDK-8207788 (because
the fix uses _bottom_klass).

Count this as a positive review.

Thank you,

Fred


> On Jul 25, 2018, at 06:16, David Simms <david.simms at oracle.com> wrote:
> 
> Greetings,
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8208162
> 
> Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8208162/
> 
> I believe the intention of the "ObjArrayKlass::_bottom_klass" field was always to hold an instance klass that contained user class that might require a number of checks, e.g. access checking for reflection, module access etc...
> 
> A value of "typeArrayKlass" simply denoted, "system type". I believe assigning a valueArrayKlass to this field to be incorrect, the fix is simply to pick out the valueArrayKlass element type as "bottom klass"
> 
> Testing: internal tier1, and Ioi's consistency tests now exhibit correct behavior.
> 
> Cheers
> 
> /David Simms
> 
> 
>