RFR: 8205998: [lworld] Verifier should reject value type classes if -XX:+EnableValhalla is not set

[Harold David Seigel]

Thanks!  I'm glad it works.

Harold


On 6/28/2018 4:03 PM, Remi Forax wrote:
> Works great :)
>
> /usr/jdk/jdk-11-lworld/bin/java --module-path target/test/artifact:deps -m fr.umlv.valuetype/fr.umlv.valuetype.ReifiedList
> Error: Unable to load main class fr.umlv.valuetype.ReifiedList in module fr.umlv.valuetype
> 	java.lang.ClassFormatError: Class modifier ACC_VALUE in class fr/umlv/valuetype/ReifiedList requires option -XX:+EnableValhalla
>
> thanks,
> Rémi
>
> ----- Mail original -----
>> De: "Harold David Seigel" <harold.seigel at oracle.com>
>> À: "Karen Kinnear" <karen.kinnear at oracle.com>
>> Cc: "valhalla-dev" <valhalla-dev at openjdk.java.net>
>> Envoyé: Jeudi 28 Juin 2018 17:18:14
>> Objet: Re: RFR: 8205998: [lworld] Verifier should reject value type classes if -XX:+EnableValhalla is not set
>> Thanks Karen!
>>
>> Harold
>>
>>
>> On 6/28/2018 11:17 AM, Karen Kinnear wrote:
>>> Harold,
>>>
>>> Looks good. Thank you for fixing the existing tests as well.
>>>
>>> thanks,
>>> Karen
>>>
>>>> On Jun 28, 2018, at 9:54 AM, Harold David Seigel <harold.seigel at oracle.com>
>>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Please review this LWorld fix that throws a ClassFormatError exception if a
>>>> class is a value type class and -XX:+EnableValhalla is not set.
>>>>
>>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8205998/webrev/index.html
>>>>
>>>> JBS Bug:  https://bugs.openjdk.java.net/browse/JDK-8205998
>>>>
>>>> The fix was tested with tier1 and tier2 tests on Linux x64 and Macosx.
>>>>
>>>> Thanks, Harold