RFR: fix verifier issue and add lworld JTReg verifier tests

harold seigel harold.seigel at oracle.com
Thu Mar 22 12:45:49 UTC 2018


Thanks Karen!

I'll make those changes before pushing the fix.

Harold

On 3/21/2018 5:43 PM, Karen Kinnear wrote:
> Harold,
>
> Looks good. Thanks for catching the verifier fix for withfield.
> 1) In the .jcod file - after the source - would
> you mind putting the original bytecodes and the hex array mapping?
> Might make it easier to read the changes.
>
> 2) VerifierValueTypes.java - line 78 “ClassFormError” -> “ClassFormatError”
>
> thanks,
> Karen
>
>> On Mar 21, 2018, at 4:11 PM, harold seigel <harold.seigel at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review the following webrev:
>>
>>    http://cr.openjdk.java.net/~hseigel/valueTypes_lworld.verfTests/webrev/index.html
>>
>> The webrev contains a fix for the verifier handling of withfield and also adds new lworld tests for the verifier.
>>
>> The webrev was tested with hotspot jtreg tests and many jdk jtreg tests.
>>
>> Thanks, Harold
>>



More information about the valhalla-dev mailing list