RFR (S) 8214341 [lworld][C1] implement anewarray for value type for C1
Tobias Hartmann
tobias.hartmann at oracle.com
Wed Nov 28 10:43:47 UTC 2018
Hi Ioi,
On 28.11.18 06:55, Ioi Lam wrote:
> http://cr.openjdk.java.net/~iklam/valhalla/8214341-c1-anewarray.v01/
> https://bugs.openjdk.java.net/browse/JDK-8214341
>
> The patch is on top of Fred's patch for JDK-8214307 (nested flattened fields).
>
> Most of the logic is shared with NewObjectArray, so I just sprinkled
> the code with test for value-type arrays.
This looks good to me!
> I tested with very basic stuff (see the added test cases 36 and 37 in
> TestBasicFunctionality).
I would prefer to have these in TestArrays.java where we already have similar/same tests (I know the
separation of tests is not perfect).
Thanks,
Tobias
More information about the valhalla-dev
mailing list