hg: valhalla/valhalla: [lworld]: Fix build failure

[Srikanth]

On Thursday 27 September 2018 12:47 PM, Remi Forax wrote:
> ----- Mail original -----
>> De: "Srikanth" <srikanth.adayapalam at oracle.com>
>> À: "valhalla-dev" <valhalla-dev at openjdk.java.net>
>> Envoyé: Jeudi 27 Septembre 2018 06:52:43
>> Objet: Re: hg: valhalla/valhalla: [lworld]: Fix build failure
>> Clarification: It wasn't exactly an OpenJDK build failure - it was a
>> build failure reported by the automated continuous build and test
>> infrastructure while it attempted to build some artifacts needed for
>> testing.
>>
>> This issue is fixed now - but only by temporarily short circuiting the
>> support for anonymous value types. I will work on a fuller fix soon.
>> Apologies for any inconvenience.
> Is it because
>    new value() {
>      ...
>    }
> is a valid syntax for an anonymous class even unlikely because a type should starts with an uppercase letter ?

Indeed.
When I temporarily backed out the support for local classes, it was 
because I anticipated a lot of code which could use value as an 
identifier as in

void foo() {
     ...
     value = 10;
}

But I didn't really expect to run into code out there that would do new 
value() - given the convention you cite. This was the source of the trouble.

Both the problems are solvable of course and I will work on a fix in due 
course.

Srikanth
>
>> Srikanth
> Rémi
>
>> On Wednesday 26 September 2018 05:00 PM, srikanth.adayapalam at oracle.com
>> wrote:
>>> Changeset: 9b12d9f3dabb
>>> Author:    sadayapalam
>>> Date:      2018-09-26 17:00 +0530
>>> URL:       http://hg.openjdk.java.net/valhalla/valhalla/rev/9b12d9f3dabb
>>>
>>> [lworld]: Fix build failure
>>>
>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java
>>> ! test/langtools/tools/javac/valhalla/lworld-values/AnonymousValueType.java
>>> ! test/langtools/tools/javac/valhalla/lworld-values/IllegalByValueTest.java
>>> ! test/langtools/tools/javac/valhalla/lworld-values/IllegalByValueTest2.java