From ioi.lam at oracle.com Tue Apr 2 22:20:55 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Tue, 2 Apr 2019 15:20:55 -0700 Subject: RFR 8221879 [lworld] Calling convention - Interpreter to C1 Message-ID: <26c798bd-33f8-1c95-db72-7a0e1046df60@oracle.com> http://cr.openjdk.java.net/~iklam/valhalla/8221879-interp-to-c1.v01/ https://bugs.openjdk.java.net/browse/JDK-8221879 Change the i2c adapter to always go through Method::_from_compiled_value_entry. Removed the StressValueTypePassFieldsAsArgs that's no longer used. Added test cases. Question for sharedRuntime_x86_64.cpp: Should I revert the changes related to gen_i2c_adapter_helper (i.e., move the body of this function back into SharedRuntime::gen_i2c_adapter), to minimize the delta between the jdk/jdk repo and valhalla? Thanks - Ioi From tobias.hartmann at oracle.com Wed Apr 3 11:29:25 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 3 Apr 2019 13:29:25 +0200 Subject: RFR 8221879 [lworld] Calling convention - Interpreter to C1 In-Reply-To: <26c798bd-33f8-1c95-db72-7a0e1046df60@oracle.com> References: <26c798bd-33f8-1c95-db72-7a0e1046df60@oracle.com> Message-ID: Hi Ioi, On 03.04.19 00:20, Ioi Lam wrote: > http://cr.openjdk.java.net/~iklam/valhalla/8221879-interp-to-c1.v01/ > https://bugs.openjdk.java.net/browse/JDK-8221879 > > Change the i2c adapter to always go through Method::_from_compiled_value_entry. > Removed the StressValueTypePassFieldsAsArgs that's no longer used. > Added test cases. This looks good to me. > Question for sharedRuntime_x86_64.cpp: > > Should I revert the changes related to gen_i2c_adapter_helper (i.e., move the body > of this function back into SharedRuntime::gen_i2c_adapter), to minimize the delta > between the jdk/jdk repo and valhalla? Yes, please. Thanks, Tobias From karen.kinnear at oracle.com Wed Apr 3 16:47:44 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Wed, 3 Apr 2019 12:47:44 -0400 Subject: Updated phasing of Valhalla Value Types Message-ID: <71BEED56-DA5E-4F51-8101-AD92E395BC0B@oracle.com> We held some discussions last week in Burlington MA, with a focus on generic specialization and future direction impacts on our next milestones. A very brief summary of our current thinking and action items for writing proposals is below. One important phasing is moving null-default value types and migrating value-based-classes to null-default value types was moved out to L20, which is after the initial preview. In addition, we are looking to rely on bridging to support migration. We believe we need to work through design and prototype issues for both of the above before making L10 available. Summary of Valhalla offsite: March 25-29 2019 Burlington MA Phases/AIs for Proposals: L10: value class V V, V?: Open Issue: Mirrors: Maurizio Array Covariance Erased Generics Identity operations (acmp): Open Issue: Dan Heidinga Soul of Q: Open Issues: John Rose Reflection: ties in with Mirrors issue: Maurizio Serialization: Open Issues: Brian Volatile - use site JVMTI Specs: JLS, JVMS: Dan Smith binary compatibility/source compatibility RefObject/ValObject/Nullable: Open Issues: Brian MH, VH javac, javap, bytecode API jasm Constable jshell validation (internal JDK library uses) Circularity L20: Null-default Migration bridges: Proposal:Brian field bridges method bridges Inner Values Timeframe unclear: Poxes: value type wrappers for primitives L100: Specialization language model template classes migration generic methods prototypes needed for L10: array covariance acmp (and performance measurements for new and non-value-type benchmarks) serialization validation: internal use cases in JDK libraries without API impact - e.g. HashMap internals, etc. circularity: autodetection and fall-back to non-flattening prototypes needed during L10 timeframe: null-default migration including JDK library sample field and method bridges some level of POC for generic specialization: TBD corrections welcome, thanks, Karen From ioi.lam at oracle.com Wed Apr 3 20:10:42 2019 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Wed, 03 Apr 2019 20:10:42 +0000 Subject: hg: valhalla/valhalla: 8221879: [lworld] Calling convention - Interpreter to C1 Message-ID: <201904032010.x33KAgGv010981@aojmv0008.oracle.com> Changeset: a03ed54ca58c Author: iklam Date: 2019-04-03 12:59 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a03ed54ca58c 8221879: [lworld] Calling convention - Interpreter to C1 Summary: i2c adapter now always go through Method::_from_compiled_value_entry. Reviewed-by: thartmann ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java From david.simms at oracle.com Thu Apr 4 14:53:01 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Thu, 04 Apr 2019 14:53:01 +0000 Subject: hg: valhalla/valhalla: 305 new changesets Message-ID: <201904041453.x34ErHZi014905@aojmv0008.oracle.com> Changeset: d21803f47416 Author: chegar Date: 2019-03-14 09:10 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d21803f47416 8220598: Malformed copyright year range in a few files in java.base Reviewed-by: dfuchs, lancea, rriggs, weijun ! src/java.base/share/classes/jdk/internal/util/ArraysSupport.java ! src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java ! src/java.base/share/classes/sun/security/util/IOUtils.java Changeset: a6221f993616 Author: pzhang Date: 2019-03-12 11:49 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a6221f993616 8220566: AArch64: Set default vm features for Ampere eMAG CPUs Summary: Set defaults for vendor specific features Reviewed-by: adinn ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp Changeset: d611b76d1327 Author: mdoerr Date: 2019-03-14 12:30 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d611b76d1327 8220660: [s390]: debug build broken after JDK-8220301 Reviewed-by: shade ! src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp Changeset: 6bf8877eb1b9 Author: roland Date: 2019-03-12 15:42 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6bf8877eb1b9 8220374: C2: LoopStripMining doesn't strip as expected Reviewed-by: rkennke, thartmann, mdoerr ! src/hotspot/share/opto/loopnode.cpp + test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMining.java Changeset: 677cede5608e Author: stefank Date: 2019-03-14 09:08 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/677cede5608e 8220411: Remove ScavengeRootsInCode=0 code Reviewed-by: thartmann, coleenp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/ci/ciBaseObject.cpp ! src/hotspot/share/ci/ciBaseObject.hpp ! src/hotspot/share/ci/ciObject.cpp ! src/hotspot/share/ci/ciObject.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/opto/type.cpp Changeset: fce463e39f72 Author: stefank Date: 2019-03-14 09:14 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fce463e39f72 8220342: Remove scavenge_root_nmethods_do from VM_HeapWalkOperation::collect_simple_roots Reviewed-by: sspitsyn, ehelin ! src/hotspot/share/prims/jvmtiTagMap.cpp Changeset: 4b1426ed1c44 Author: stefank Date: 2019-03-14 09:15 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4b1426ed1c44 8220343: Move scavenge_root_nmethods from shared code Reviewed-by: kvn, eosterlund ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/pcTasks.cpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psTasks.cpp ! src/hotspot/share/gc/serial/genMarkSweep.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/parallelCleaning.cpp + src/hotspot/share/gc/shared/scavengableNMethods.cpp + src/hotspot/share/gc/shared/scavengableNMethods.hpp + src/hotspot/share/gc/shared/scavengableNMethodsData.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeCache.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java Changeset: 153419748bf8 Author: sgehwolf Date: 2019-02-25 15:41 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/153419748bf8 8219585: [TESTBUG] sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java passes trivially when it shouldn't Reviewed-by: dfuchs, sballal ! test/jdk/sun/management/jmxremote/bootstrap/JMXAgentInterfaceBinding.java ! test/jdk/sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java Changeset: 5d48ae032588 Author: hseigel Date: 2019-03-14 09:38 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5d48ae032588 8219579: Remove redundant signature parsing from the verifier Summary: Change verifier signature checking into asserts because ClassFileParser checks signatures for files being verified. Reviewed-by: lfoltan, coleenp, redestad, dholmes ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp + test/hotspot/jtreg/runtime/verifier/BadSignatures.jcod + test/hotspot/jtreg/runtime/verifier/TestSigParse.java Changeset: 70a818b1d9db Author: redestad Date: 2019-03-14 15:31 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/70a818b1d9db 8220502: Inefficient pre-sizing of PhiResolverState arrays in c1_LIRGenerator Reviewed-by: thartmann, kvn ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp Changeset: 478f1483c511 Author: lancea Date: 2019-03-14 10:50 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/478f1483c511 8220252: Fix Headings in java.naming Reviewed-by: dfuchs ! src/java.naming/share/classes/com/sun/jndi/ldap/EventSupport.java ! src/java.naming/share/classes/javax/naming/CompositeName.java ! src/java.naming/share/classes/javax/naming/CompoundName.java ! src/java.naming/share/classes/javax/naming/Context.java ! src/java.naming/share/classes/javax/naming/directory/DirContext.java ! src/java.naming/share/classes/javax/naming/event/EventContext.java ! src/java.naming/share/classes/javax/naming/ldap/LdapContext.java Changeset: e6a1c4e28294 Author: gadams Date: 2019-03-14 10:58 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e6a1c4e28294 8218166: com/sun/jdi/SimulResumerTest.java failure Reviewed-by: dlong, jcbeyler ! test/jdk/com/sun/jdi/SimulResumerTest.java Changeset: c0fccca69aff Author: jcbeyler Date: 2019-03-14 09:35 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c0fccca69aff 8220628: Move the HeapMonitor library to C++ Summary: Migrate libHeapMonitorTest.c to libHeapMonitorTest.cpp Reviewed-by: cjplummer, sspitsyn - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c + test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp Changeset: deb99f13c6cd Author: bpb Date: 2019-03-14 09:43 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/deb99f13c6cd 8220614: (bf) Buffer absolute slice methods should use Objects.checkFromIndexSize() Reviewed-by: alanb, igerasim, rriggs ! src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template ! src/java.base/share/classes/java/nio/StringCharBuffer.java Changeset: 641768acb12e Author: cushon Date: 2019-03-08 09:58 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/641768acb12e 8220378: Unused Names constants Reviewed-by: jjg, mcimadamore Contributed-by: Ron Shapiro ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java Changeset: 41b79b3e21fb Author: itakiguchi Date: 2019-03-15 00:49 +0900 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/41b79b3e21fb 8220281: IBM-858 alias name is missing on IBM00858 charset Summary: Add aliases into IBM charsets Reviewed-by: naoto ! make/data/charsetmapping/charsets ! test/jdk/sun/nio/cs/TestIBMBugs.java Changeset: 2ab55d39fb5b Author: cushon Date: 2019-03-13 22:05 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2ab55d39fb5b 8220644: Align required/found pairs in diagnostics Reviewed-by: mcimadamore, jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: 829bf950287e Author: redestad Date: 2019-03-14 18:56 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/829bf950287e 8220366: Optimize Symbol handling in ClassVerifier and SignatureStream Reviewed-by: hseigel, coleenp, lfoltan ! src/hotspot/share/classfile/stackMapFrame.cpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp Changeset: 777110c61b1f Author: mseledtsov Date: 2019-03-14 11:26 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/777110c61b1f 8220676: [TESTBUG] ProblemList TestCPUSets until the test issue is resolved Summary: Added the test to problem list Reviewed-by: lfoltan ! test/hotspot/jtreg/ProblemList.txt Changeset: 67f72165dca5 Author: jjg Date: 2019-03-14 11:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/67f72165dca5 8220379: Fix doclint handling of headings Reviewed-by: erikj, jlahoda ! make/CompileJavaModules.gmk ! src/jdk.compiler/share/classes/com/sun/tools/doclint/Checker.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/DocLint.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/Env.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java + test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadingsTest.java ! test/langtools/tools/doclint/AccessibilityTest.java ! test/langtools/tools/doclint/AccessibilityTest.out ! test/langtools/tools/doclint/html/BlockTagsTest.java ! test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java ! test/langtools/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/langtools/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/langtools/tools/doclint/tidy/MissingTag.java ! test/langtools/tools/doclint/tidy/MissingTag.out - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java + test/langtools/tools/javac/doclint/ImplicitHeadingsTest.java Changeset: 3cc19f34075b Author: jjg Date: 2019-03-14 11:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3cc19f34075b Merge Changeset: 943cfab99051 Author: jjg Date: 2019-03-14 13:33 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/943cfab99051 8219691: method summary table head should be enclosed in Reviewed-by: jjg Contributed-by: dthomson at google.com ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTag.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Table.java ! test/langtools/jdk/javadoc/doclet/testDeprecatedDocs/TestDeprecatedDocs.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testModules/TestIndirectExportsOpens.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModuleServices.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/langtools/jdk/javadoc/doclet/testPackagePage/TestPackagePage.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testUnnamedPackage/TestUnnamedPackage.java Changeset: b70c65a946a0 Author: ngasson Date: 2019-03-14 14:25 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b70c65a946a0 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm Reviewed-by: jjg, clanger ! test/langtools/jdk/javadoc/doclet/InheritDocForUserTags/DocTest.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java Changeset: b6134b6d75ff Author: jjg Date: 2019-03-14 15:30 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b6134b6d75ff 8220249: fix headings in java.compiler Reviewed-by: erikj, darcy ! make/CompileJavaModules.gmk ! src/java.compiler/share/classes/javax/annotation/processing/Generated.java Changeset: 8a66c92526cb Author: iignatyev Date: 2019-03-14 16:17 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8a66c92526cb 8220689: problem list RandomCommandsTest in graal runs Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: 421b47214391 Author: dtitov Date: 2019-03-14 16:28 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/421b47214391 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed Reviewed-by: dlong, sspitsyn, jcbeyler ! test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp Changeset: 6ab293f66cae Author: iignatyev Date: 2019-03-14 19:37 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6ab293f66cae 8219139: move hotspot tests from test/jdk/vm Reviewed-by: dholmes, mseledtsov + test/hotspot/jtreg/compiler/codegen/BadLogicCode.java + test/hotspot/jtreg/compiler/codegen/ShiftTest.java + test/hotspot/jtreg/compiler/exceptions/ExceptionInInit.java + test/hotspot/jtreg/compiler/runtime/JITClassInit.java + test/hotspot/jtreg/gc/ArraySize.java + test/hotspot/jtreg/gc/InfiniteList.java + test/hotspot/jtreg/runtime/ErrorHandling/ExplicitArithmeticCheck.java + test/hotspot/jtreg/runtime/Thread/MonitorCacheMaybeExpand_DeadLock.java + test/hotspot/jtreg/runtime/interpreter/WideStrictInline.java + test/hotspot/jtreg/runtime/reflect/ReflectStackOverflow.java + test/hotspot/jtreg/runtime/verifier/TestStaticIF.java + test/hotspot/jtreg/runtime/verifier/VerifyProtectedConstructor.java + test/hotspot/jtreg/runtime/verifier/VerifyStackForExceptionHandlers.java + test/hotspot/jtreg/runtime/verifier/defaultMethods/DefaultMethodRegressionTests.java + test/hotspot/jtreg/runtime/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java ! test/jdk/TEST.groups + test/jdk/tools/launcher/JniInvocationTest.java + test/jdk/tools/launcher/exeJniInvocationTest.c - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java Changeset: 8ff8b3734549 Author: thartmann Date: 2019-03-15 08:27 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8ff8b3734549 8220611: compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java timeout Summary: Test should not be executed with Graal as JIT. Reviewed-by: kvn ! test/hotspot/jtreg/compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java Changeset: fb7a1fdeaea7 Author: gadams Date: 2019-03-15 06:16 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fb7a1fdeaea7 8220678: unquarantine nsk/jdi/ThreadReference/setEnabled/setenabled003 Reviewed-by: cjplummer, sspitsyn ! test/hotspot/jtreg/ProblemList.txt Changeset: 6f14d52d5e10 Author: shade Date: 2019-03-15 13:01 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6f14d52d5e10 8220712: [TESTBUG] gc/shenandoah/compiler/TestMaybeNullUnsafeAccess should run with Shenandoah enabled Reviewed-by: rkennke, roland ! test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java Changeset: 81605c74b980 Author: chegar Date: 2019-03-15 14:50 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/81605c74b980 8179549: Typo in network properties documentation Reviewed-by: clanger, coffeys ! src/java.base/share/classes/java/net/doc-files/net-properties.html Changeset: 8f91e1a7ebdc Author: chegar Date: 2019-03-15 14:54 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8f91e1a7ebdc 8213912: Semantic typo in HttpExchange.java Reviewed-by: dfuchs ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java Changeset: 62e4ada7c4c8 Author: erikj Date: 2019-03-15 09:13 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/62e4ada7c4c8 8220093: Change to GCC 8.2 for building on Linux at Oracle Reviewed-by: tbell ! make/autoconf/toolchain.m4 ! make/conf/jib-profiles.js ! make/devkit/Makefile + make/devkit/Tars.gmk ! make/devkit/Tools.gmk Changeset: c61f09122d3b Author: jwilhelm Date: 2019-03-15 18:59 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c61f09122d3b 8220704: ZGC: gc tests complain Java heap too small Reviewed-by: iignatyev, tschatzl ! test/hotspot/jtreg/gc/ArraySize.java ! test/hotspot/jtreg/gc/InfiniteList.java Changeset: 5529640c5f67 Author: coleenp Date: 2019-03-15 16:00 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5529640c5f67 8220512: Deoptimize redefinition functions that have dirty ICs Summary: Walk ICs to determine whether nmethods are dependent on redefined classes. Reviewed-by: sspitsyn, eosterlund ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/aot/aotCodeHeap.hpp ! src/hotspot/share/aot/aotCompiledMethod.cpp ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/aot/aotLoader.cpp ! src/hotspot/share/aot/aotLoader.hpp ! src/hotspot/share/ci/ciEnv.hpp ! src/hotspot/share/ci/ciObjectFactory.cpp ! src/hotspot/share/ci/ciObjectFactory.hpp ! src/hotspot/share/classfile/metadataOnStackMark.cpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/memory/iterator.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: d2f8b7b33013 Author: bpb Date: 2019-03-15 16:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d2f8b7b33013 8219876: (bf) Improve IndexOutOfBoundsException messages in $Type$Buffer classes Reviewed-by: alanb, rriggs ! src/java.base/share/classes/java/nio/Buffer.java ! src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template ! src/java.base/share/classes/java/nio/StringCharBuffer.java ! src/java.base/share/classes/java/nio/X-Buffer.java.template Changeset: 5274462d5725 Author: jwilhelm Date: 2019-03-16 02:08 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5274462d5725 8220745: Fix problemlist entry to refer to 8220613 Reviewed-by: dcubed ! test/jdk/ProblemList.txt Changeset: 4985c8ca55b9 Author: ysuenaga Date: 2019-03-16 21:27 +0900 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4985c8ca55b9 8220555: JFR tool shows potentially misleading message when it cannot access a file Reviewed-by: egahlin, mseledtsov ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Command.java ! test/jdk/jdk/jfr/tool/TestPrint.java Changeset: 1caf2daef7cf Author: alanb Date: 2019-03-16 12:31 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1caf2daef7cf 8220738: (sc) Move ServerSocketChannelImpl remaining native method to Net Reviewed-by: bpb ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/java.base/unix/classes/sun/nio/ch/UnixAsynchronousServerSocketChannelImpl.java ! src/java.base/unix/native/libnio/ch/IOUtil.c ! src/java.base/unix/native/libnio/ch/Net.c - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c ! src/java.base/unix/native/libnio/ch/nio_util.h ! src/java.base/windows/native/libnio/ch/IOUtil.c ! src/java.base/windows/native/libnio/ch/Net.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c ! src/java.base/windows/native/libnio/ch/nio_util.h ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/SendFailed.java Changeset: b5a73f22b2bd Author: alanb Date: 2019-03-16 19:44 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b5a73f22b2bd 8220493: Prepare Socket/ServerSocket for alternative platform SocketImpl Reviewed-by: chegar Contributed-by: alan.bateman at oracle.com, michael.x.mcmahon at oracle.com ! src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java + src/java.base/share/classes/java/net/DelegatingSocketImpl.java ! src/java.base/share/classes/java/net/HttpConnectSocketImpl.java ! src/java.base/share/classes/java/net/ServerSocket.java ! src/java.base/share/classes/java/net/Socket.java ! src/java.base/share/classes/java/net/SocketImpl.java ! src/java.base/share/classes/java/net/SocksSocketImpl.java + src/java.base/share/classes/sun/net/PlatformSocketImpl.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketInputStreamInstrumentor.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketOutputStreamInstrumentor.java + test/jdk/java/net/SocketImpl/SocketImplCombinations.java ! test/jdk/jdk/jfr/event/io/TestInstrumentation.java Changeset: 56e9781e6044 Author: igerasim Date: 2019-03-16 13:44 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/56e9781e6044 6307456: UnixFileSystem_md.c use of chmod() and access() should handle EINTR signal appropriately (unix) Reviewed-by: bpb, dholmes, alanb ! src/java.base/unix/native/libjava/UnixFileSystem_md.c ! src/java.base/unix/native/libjava/io_util_md.h Changeset: 1a18b8d56d73 Author: igerasim Date: 2019-03-16 15:05 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1a18b8d56d73 8220684: Process.waitFor(long, TimeUnit) can return false for a process that exited within the timeout Reviewed-by: prappo, dholmes, rriggs ! src/java.base/share/classes/java/lang/Process.java + test/jdk/java/lang/Process/WaitFor.java Changeset: 5e1480a38a43 Author: chegar Date: 2019-03-17 08:26 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5e1480a38a43 8220719: Allow other named NetPermissions to be used Reviewed-by: mullan, alanb ! src/java.base/share/classes/java/net/NetPermission.java Changeset: 7c23a4432610 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7c23a4432610 8220569: ZGC: Rename and rework ZUnmapBadViews to ZVerifyViews Reviewed-by: stefank, eosterlund ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp ! src/hotspot/share/gc/z/zPhysicalMemory.cpp ! src/hotspot/share/gc/z/zPhysicalMemory.hpp ! src/hotspot/share/gc/z/z_globals.hpp ! test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java Changeset: 759a63069fac Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/759a63069fac 8220741: ZGC: Move CPU agnostic files from linux_x86 to linux Reviewed-by: stefank, eosterlund + src/hotspot/os/linux/gc/z/zLargePages_linux.cpp + src/hotspot/os/linux/gc/z/zNUMA_linux.cpp + src/hotspot/os/linux/gc/z/zVirtualMemory_linux.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp Changeset: 349843ebb209 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/349843ebb209 8220586: ZGC: Move relocation logic from ZPage to ZRelocate Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocate.hpp Changeset: f344a0c6e19e Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f344a0c6e19e 8220587: ZGC: Break out forwarding information from ZPage Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zBarrier.cpp + src/hotspot/share/gc/z/zForwarding.cpp + src/hotspot/share/gc/z/zForwarding.hpp + src/hotspot/share/gc/z/zForwarding.inline.hpp + src/hotspot/share/gc/z/zForwardingEntry.hpp ! src/hotspot/share/gc/z/zForwardingTable.cpp ! src/hotspot/share/gc/z/zForwardingTable.hpp ! src/hotspot/share/gc/z/zForwardingTable.inline.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp ! src/hotspot/share/gc/z/zGranuleMap.hpp ! src/hotspot/share/gc/z/zGranuleMap.inline.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageCache.cpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocate.hpp + test/hotspot/gtest/gc/z/test_zForwarding.cpp - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp ! test/hotspot/jtreg/ProblemList-zgc.txt Changeset: 790679f86a51 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/790679f86a51 8220588: ZGC: Convert ZRelocationSet to hold ZForwardings instead of ZPages Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zDriver.cpp ! src/hotspot/share/gc/z/zDriver.hpp ! src/hotspot/share/gc/z/zForwarding.cpp ! src/hotspot/share/gc/z/zForwarding.hpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! src/hotspot/share/gc/z/zForwardingTable.cpp ! src/hotspot/share/gc/z/zForwardingTable.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocationSet.cpp ! src/hotspot/share/gc/z/zRelocationSet.hpp ! src/hotspot/share/gc/z/zRelocationSet.inline.hpp ! src/hotspot/share/gc/z/zRelocationSetSelector.cpp ! src/hotspot/share/gc/z/zRelocationSetSelector.hpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: c585ef187216 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c585ef187216 8220589: ZGC: Remove superfluous ZPageTableEntry Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zDebug.gdb ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/gc/z/zMark.hpp ! src/hotspot/share/gc/z/zPageTable.cpp ! src/hotspot/share/gc/z/zPageTable.hpp ! src/hotspot/share/gc/z/zPageTable.inline.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZHeap.java Changeset: 84295bd6d359 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/84295bd6d359 8220590: ZGC: Remove ZPages from ZPageTable when freed Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPageTable.cpp Changeset: b9f030844be4 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b9f030844be4 8220591: ZGC: Don't delay reclaimation of ZVirtualMemory Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zPageAllocator.cpp Changeset: d0d26fc836dd Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d0d26fc836dd 8220592: ZGC: Move destruction of detached ZPages into ZPageAllocator Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp Changeset: eb54b34af2be Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/eb54b34af2be 8220593: ZGC: Remove superfluous ZPage::is_detached() Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageCache.cpp Changeset: 5748eae24183 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5748eae24183 8220594: ZGC: Remove superfluous ZPage::is_active() Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageCache.cpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: 8f1771ea1e39 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8f1771ea1e39 8220595: ZGC: Introduce ZAttachedArray Reviewed-by: stefank, eosterlund + src/hotspot/share/gc/z/zAttachedArray.hpp + src/hotspot/share/gc/z/zAttachedArray.inline.hpp Changeset: 07943af21b96 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/07943af21b96 8220596: ZGC: Convert ZNMethodData to use ZAttachedArray Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zNMethodData.cpp ! src/hotspot/share/gc/z/zNMethodData.hpp Changeset: f92f1f1045ad Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f92f1f1045ad 8220597: ZGC: Convert ZForwarding to use ZAttachedArray Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zForwarding.cpp ! src/hotspot/share/gc/z/zForwarding.hpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: e6a92f2f37a9 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e6a92f2f37a9 8220599: ZGC: Introduce ZSafeDelete Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zArray.hpp ! src/hotspot/share/gc/z/zArray.inline.hpp + src/hotspot/share/gc/z/zSafeDelete.hpp + src/hotspot/share/gc/z/zSafeDelete.inline.hpp Changeset: 6d1caebf8d37 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6d1caebf8d37 8220600: ZGC: Delete ZPages using ZSafeDelete Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zDriver.cpp ! src/hotspot/share/gc/z/zDriver.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp Changeset: 36e0665773e7 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/36e0665773e7 8220601: ZGC: Delete ZNMethodTableEntry arrays using ZSafeDelete Reviewed-by: stefank, eosterlund - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp Changeset: 2786541e4f91 Author: sgehwolf Date: 2019-03-13 20:07 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2786541e4f91 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp Reviewed-by: bobv, adinn ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java Changeset: b4779a44476b Author: stefank Date: 2019-03-18 15:19 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b4779a44476b 8220606: Move ScavengableNMethods unlinking to unregister_nmethod Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.hpp Changeset: 98e21d4da074 Author: stefank Date: 2019-03-18 15:21 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/98e21d4da074 8220609: Cleanups in ScavengableNMethods Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psTasks.cpp ! src/hotspot/share/gc/serial/genMarkSweep.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/scavengableNMethods.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.hpp Changeset: e81b44c68680 Author: rkennke Date: 2019-03-18 16:33 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e81b44c68680 8220780: ShenandoahBS::AccessBarrier::oop_store_in_heap ignores AS_NO_KEEPALIVE Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp Changeset: 564043cbe138 Author: erikj Date: 2019-03-18 17:33 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/564043cbe138 8220737: Jib based 32 bit windows builds fail Reviewed-by: tbell, dholmes ! make/conf/jib-profiles.js Changeset: d265655be483 Author: jjg Date: 2019-03-18 11:50 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d265655be483 8220693: jdk/javadoc/doclet/MetaTag/MetaTag.java with unexpected date Reviewed-by: hannesw ! test/langtools/jdk/javadoc/doclet/MetaTag/MetaTag.java Changeset: 2e586b74722e Author: jnimeh Date: 2019-03-18 15:26 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2e586b74722e 8218723: Use SunJCE Mac in SecretKeyFactory PBKDF2 implementation Reviewed-by: apetcher ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java + test/jdk/javax/crypto/SecretKeyFactory/SecKeyFacSunJCEPrf.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov.jar + test/jdk/javax/crypto/SecretKeyFactory/evilprov/Makefile + test/jdk/javax/crypto/SecretKeyFactory/evilprov/README + test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilProvider.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov/module-info.java Changeset: 7418b266e1c7 Author: jjiang Date: 2019-03-19 10:36 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7418b266e1c7 8220410: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed with missing expected output Summary: Using the same timezone for jar verifying and date formatting Reviewed-by: weijun ! test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java ! test/jdk/sun/security/tools/jarsigner/warnings/Test.java Changeset: 5f4dedb4dcf5 Author: aoqi Date: 2019-03-19 17:03 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5f4dedb4dcf5 8220812: gc/shenandoah/options/TestLoopMiningArguments.java fails if default GC is serial/parallel/cms Reviewed-by: shade Contributed-by: Ao Qi ! test/hotspot/jtreg/gc/shenandoah/options/TestLoopMiningArguments.java Changeset: 8717d7424861 Author: chegar Date: 2019-03-19 11:15 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8717d7424861 8170705: sun/net/www/protocol/http/StackTraceTest.java fails intermittently with Invalid Http response Reviewed-by: dfuchs ! test/jdk/sun/net/www/protocol/http/StackTraceTest.java Changeset: 3827cd66e788 Author: mbaesken Date: 2019-03-18 16:04 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3827cd66e788 8220781: linux-s390 : os::get_summary_cpu_info gives bad output Reviewed-by: dholmes, lucy ! src/hotspot/os/linux/os_linux.cpp Changeset: f554d3e88da3 Author: mbaesken Date: 2019-03-18 15:29 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f554d3e88da3 8220355: Improve assertion texts and exception messages in eventHandlerVMInit Reviewed-by: alanb, sspitsyn, jcbeyler ! src/java.instrument/share/native/libinstrument/InvocationAdapter.c ! src/java.instrument/share/native/libinstrument/JPLISAgent.c Changeset: 791052cc88db Author: chegar Date: 2019-03-19 14:27 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/791052cc88db 8220663: Incorrect handling of IPv6 addresses in Socket(Proxy.HTTP) Reviewed-by: alanb, michaelm ! src/java.base/share/classes/java/net/HttpConnectSocketImpl.java ! test/jdk/java/net/Socket/HttpProxy.java Changeset: dfde3bb48c03 Author: rriggs Date: 2019-03-19 10:47 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dfde3bb48c03 8220613: java/util/Arrays/TimSortStackSize2.java times out with fastdebug build Reviewed-by: lancea, alanb ! test/jdk/ProblemList.txt ! test/jdk/TEST.ROOT ! test/jdk/java/util/Arrays/TimSortStackSize2.java Changeset: 021448dc442c Author: kbarrett Date: 2019-03-19 14:08 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/021448dc442c 8220690: ATTRIBUTE_ALIGNED requires GNU extensions enabled Summary: Use __typeof__(x) instead of typeof(x). Reviewed-by: shade, sgehwolf ! src/hotspot/share/utilities/globalDefinitions_gcc.hpp Changeset: da7f6755ba71 Author: bobv Date: 2019-03-19 12:00 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/da7f6755ba71 8219562: Line of code in osContainer_linux.cpp L102 appears unreachable Reviewed-by: rriggs, sgehwolf ! src/hotspot/os/linux/osContainer_linux.cpp Changeset: d909d0a883c4 Author: bobv Date: 2019-03-19 12:10 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d909d0a883c4 8212528: Wrong cgroup subsystem being used for some CPU Container Metrics Reviewed-by: rriggs, sgehwolf ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java Changeset: d5da034032e9 Author: bobv Date: 2019-03-19 12:29 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d5da034032e9 8217766: Container Support doesn't work for some Join Controllers combinations Reviewed-by: rriggs, sgehwolf ! src/hotspot/os/linux/osContainer_linux.cpp ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java Changeset: c2238a12f259 Author: bobv Date: 2019-03-19 14:31 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c2238a12f259 Merge Changeset: 4b6a629d0615 Author: kbarrett Date: 2019-03-19 14:32 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4b6a629d0615 8218975: Bug in macOSX kernel's pthread support Summary: Use freelist of pthread_mutex/condvar pairs on macOSX. Reviewed-by: tschatzl, dholmes, dcubed Contributed-by: kim.barrett at oracle.com, patricio.chilano.mateo at oracle.com ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/os_posix.hpp ! src/hotspot/os/posix/os_posix.inline.hpp Changeset: 6146ab937899 Author: coleenp Date: 2019-03-19 14:22 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6146ab937899 8220744: Move RedefineTests to from runtime to serviceability Summary: move tests out of runtime to jvmti/RedefineClasses Reviewed-by: sspitsyn, dcubed, cjplummer, hseigel, mseledtsov ! test/hotspot/jtreg/TEST.groups - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c ! test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineBasicTest.java ! test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_Shared.java ! test/hotspot/jtreg/runtime/logging/RedefineClasses.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/Agent.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/ModifyAnonymous.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAddLambdaExpression.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAnnotations.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDeleteJmethod.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDoubleDelete.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineFinalizer.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceCall.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceMethods.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeak.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethods.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithBacktrace.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithResolutionErrors.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineSubtractLambdaExpression.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RetransformClassesZeroLength.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestLambdaFormRetransformation.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestMultipleClasses.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineObject.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineWithUnresolvedClass.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/UnresolvedClassAgent.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/UnresolvedClassAgent.mf + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/WalkThroughInvoke.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/libRedefineDeleteJmethod.c + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/libRedefineDoubleDelete.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf Changeset: ddfb658c8ce3 Author: apetcher Date: 2019-03-19 15:18 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ddfb658c8ce3 8147502: Digest is incorrectly truncated for ECDSA signatures when the bit length of n is less than the field size Summary: Truncate the digest according to the group order, not the field size Reviewed-by: jnimeh ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECDSASignature.java ! src/jdk.crypto.ec/share/native/libsunec/impl/ec.c + test/jdk/sun/security/ec/SignatureDigestTruncate.java Changeset: 6ba98ff89499 Author: pmuthuswamy Date: 2019-03-20 09:58 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6ba98ff89499 8219958: Automatically load taglets from a jar file Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java + test/langtools/jdk/javadoc/doclet/testAutoLoadTaglets/TestAutoLoadTaglets.java Changeset: 40296a51aeb0 Author: chegar Date: 2019-03-20 08:33 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/40296a51aeb0 8153508: ContentHandler API contains link to private contentPathProp Reviewed-by: dfuchs, vtewari ! src/java.base/share/classes/java/net/ContentHandler.java Changeset: af3f568cbd2d Author: dcherepanov Date: 2019-03-20 11:51 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/af3f568cbd2d 8211100: hotspot C1 issue with comparing long numbers on x86 32-bit Reviewed-by: iveresov, thartmann ! src/hotspot/share/c1/c1_LIRGenerator.cpp + test/hotspot/jtreg/compiler/c1/Test8211100.java Changeset: 83cace4142c8 Author: chegar Date: 2019-03-20 09:17 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/83cace4142c8 8221098: Run java/net/URL/HandlerLoop.java in othervm mode Reviewed-by: alanb, martin ! test/jdk/java/net/URL/HandlerLoop.java Changeset: 06222165c35f Author: jwilhelm Date: 2019-03-20 17:13 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/06222165c35f Added tag jdk-12-ga for changeset b67884871b5f ! .hgtags Changeset: 18547cad9ec6 Author: jwilhelm Date: 2019-03-20 17:28 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/18547cad9ec6 Merge ! .hgtags Changeset: 55c262f4f5a1 Author: jwilhelm Date: 2019-03-20 22:53 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/55c262f4f5a1 8220389: Update Graal Reviewed-by: kvn, dlong + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/IntegerStampShiftTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/CompilationWrapper.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/GraalCompilerOptions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationFailureActionHelp.txt + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64ArrayEqualsStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.jdk9.test/src/org/graalvm/compiler/hotspot/jdk9/test/StringUTF16ToBytesGetCharsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/BigIntegerIntrinsicsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorld.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorldTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/GraalOSRTestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalOptionValues.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayIndexOfOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGeneratorTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/UnsignedRightShiftNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayEqualsNode.java Changeset: d9f43dfbe524 Author: dholmes Date: 2019-03-20 18:01 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d9f43dfbe524 8218446: SuspendAtExit hangs Reviewed-by: rehn, dcubed ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 003cc64366da Author: jjg Date: 2019-03-20 15:35 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/003cc64366da 8220249: fix headings in java.compiler Reviewed-by: erikj, darcy ! src/java.base/share/classes/java/io/DataInput.java ! src/java.base/share/classes/java/io/File.java ! src/java.base/share/classes/java/lang/Character.java ! src/java.base/share/classes/java/lang/ClassLoader.java ! src/java.base/share/classes/java/lang/ModuleLayer.java ! src/java.base/share/classes/java/lang/doc-files/ValueBased.html ! src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/MutableCallSite.java ! src/java.base/share/classes/java/lang/invoke/VarHandle.java ! src/java.base/share/classes/java/lang/invoke/package-info.java ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/lang/module/package-info.java ! src/java.base/share/classes/java/lang/reflect/Proxy.java ! src/java.base/share/classes/java/net/Inet4Address.java ! src/java.base/share/classes/java/net/Inet6Address.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/net/URI.java ! src/java.base/share/classes/java/text/ChoiceFormat.java ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! src/java.base/share/classes/java/text/DateFormat.java ! src/java.base/share/classes/java/text/DecimalFormat.java ! src/java.base/share/classes/java/text/Format.java ! src/java.base/share/classes/java/text/MessageFormat.java ! src/java.base/share/classes/java/text/NumberFormat.java ! src/java.base/share/classes/java/text/SimpleDateFormat.java ! src/java.base/share/classes/java/time/Instant.java ! src/java.base/share/classes/java/time/ZoneId.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDate.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDateImpl.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/java.base/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/java.base/share/classes/java/time/chrono/Chronology.java ! src/java.base/share/classes/java/time/format/DateTimeFormatter.java ! src/java.base/share/classes/java/time/temporal/IsoFields.java ! src/java.base/share/classes/java/time/temporal/JulianFields.java ! src/java.base/share/classes/java/time/temporal/Temporal.java ! src/java.base/share/classes/java/time/temporal/WeekFields.java ! src/java.base/share/classes/java/util/Calendar.java ! src/java.base/share/classes/java/util/Formatter.java ! src/java.base/share/classes/java/util/GregorianCalendar.java ! src/java.base/share/classes/java/util/Locale.java ! src/java.base/share/classes/java/util/ResourceBundle.java ! src/java.base/share/classes/java/util/Scanner.java ! src/java.base/share/classes/java/util/ServiceLoader.java ! src/java.base/share/classes/java/util/TimeZone.java ! src/java.base/share/classes/java/util/doc-files/coll-designfaq.html ! src/java.base/share/classes/java/util/regex/Pattern.java ! src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java ! src/java.base/share/classes/java/util/spi/ResourceBundleProvider.java Changeset: ce78fac1f6d5 Author: jwilhelm Date: 2019-03-21 01:49 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ce78fac1f6d5 Added tag jdk-13+13 for changeset 83cace4142c8 ! .hgtags Changeset: 79fcfc6c02e8 Author: dholmes Date: 2019-03-20 23:32 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/79fcfc6c02e8 8221180: Deprecate AllowJNIEnvProxy Reviewed-by: coleenp, dcubed ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: a8e7194c2b0d Author: dholmes Date: 2019-03-21 03:00 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a8e7194c2b0d 8221208: Backout JDK-8218446 Reviewed-by: iignatyev, rehn ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 8d9d71bba199 Author: clanger Date: 2019-03-21 09:16 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8d9d71bba199 8172695: (scanner) java/util/Scanner/ScanTest.java fails Reviewed-by: smarks, bpb ! test/jdk/java/util/Scanner/ScanTest.java Changeset: 67c58bd66e82 Author: jiefu Date: 2019-03-21 04:55 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/67c58bd66e82 8220658: Improve the readability of container information in the error log Reviewed-by: dholmes, bobv ! src/hotspot/os/linux/os_linux.cpp Changeset: ed40b61fed96 Author: ysuenaga Date: 2019-03-21 21:17 +0900 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ed40b61fed96 8220784: hsdis cannot be built with MinGW64 Reviewed-by: iklam, dholmes ! src/utils/hsdis/Makefile Changeset: d8d45286ffa9 Author: mbalao Date: 2019-03-21 01:51 -0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d8d45286ffa9 8220753: Re-introduce the test case for TLS 1.2 algorithms in SunPKCS11 crypto provider Reviewed-by: xuelei + test/jdk/sun/security/pkcs11/tls/tls12/TestTLS12.java + test/jdk/sun/security/pkcs11/tls/tls12/cert8.db + test/jdk/sun/security/pkcs11/tls/tls12/key3.db + test/jdk/sun/security/pkcs11/tls/tls12/keystore + test/jdk/sun/security/pkcs11/tls/tls12/nss.cfg + test/jdk/sun/security/pkcs11/tls/tls12/secmod.db Changeset: 0288c6919a20 Author: hseigel Date: 2019-03-21 10:47 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0288c6919a20 8221096: Description of -XX:+PrintFlagsRanges is incorrect Summary: Remove the phrase: and exit VM Reviewed-by: lfoltan ! src/hotspot/share/runtime/globals.hpp Changeset: b00a4187d5ec Author: apetcher Date: 2019-03-21 13:10 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b00a4187d5ec 8221172: SunEC specific test is not limited to SunEC Summary: Fixing a minor test bug in the SignatureDigestTruncate regression test Reviewed-by: mullan ! test/jdk/sun/security/ec/SignatureDigestTruncate.java Changeset: f10ca228b22f Author: alanb Date: 2019-03-21 17:38 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f10ca228b22f 8221259: New tests for java.net.Socket to exercise long standing behavior Reviewed-by: chegar + test/jdk/java/net/Socket/AsyncShutdown.java + test/jdk/java/net/Socket/ConnectionReset.java + test/jdk/java/net/Socket/Timeouts.java + test/jdk/java/net/Socket/UdpSocket.java Changeset: 98a01c1344aa Author: bobv Date: 2019-03-21 14:40 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/98a01c1344aa 8220674: [TESTBUG] MetricsMemoryTester failcount test in docker container only works with debug JVMs Reviewed-by: sspitsyn, sgehwolf ! test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java ! test/jdk/jdk/internal/platform/docker/TestDockerMemoryMetrics.java Changeset: 3fe41815505c Author: bchristi Date: 2019-03-21 11:58 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3fe41815505c 8211941: Enable checking/ignoring of non-conforming Class-Path entries Reviewed-by: alanb, mchung ! src/java.base/share/classes/jdk/internal/loader/URLClassPath.java Changeset: 35e8d1eb4040 Author: igerasim Date: 2019-03-21 12:28 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/35e8d1eb4040 8170494: JNI exception pending in PlainDatagramSocketImpl.c Reviewed-by: clanger, vtewari ! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c Changeset: 7fbb4340b125 Author: dtitov Date: 2019-03-21 19:56 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7fbb4340b125 8218401: WRONG_PHASE: vmTestbase/nsk/jvmti test crash Reviewed-by: sspitsyn, jcbeyler ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/Breakpoint/breakpoint001/breakpoint001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/FramePop/framepop002/framepop002.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SingleStep/singlestep003/singlestep003.cpp Changeset: 727ab25a4e24 Author: xuelei Date: 2019-03-21 13:32 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/727ab25a4e24 8221270: Duplicated synchronized keywords in SSLSocketImpl Reviewed-by: mullan ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 1928a50e7e83 Author: xuelei Date: 2019-03-21 14:18 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1928a50e7e83 8221273: put sun/security/pkcs11/tls/tls12/TestTLS12.java on ProblemList.txt Reviewed-by: mullan ! test/jdk/ProblemList.txt Changeset: 8478c8c48886 Author: rkennke Date: 2019-03-21 22:37 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8478c8c48886 8221278: Shenandoah should not enqueue string dedup candidates during root scan Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp Changeset: eed9f74eab87 Author: rkennke Date: 2019-03-15 09:57 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/eed9f74eab87 8220714: C2 Compilation failure when accessing off-heap memory using Unsafe Reviewed-by: vlivanov, roland ! src/hotspot/share/opto/library_call.cpp + test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java Changeset: ed34367d4e9f Author: ngasson Date: 2019-03-22 03:04 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ed34367d4e9f 8220451: jdi/EventQueue/remove/remove004 failed due to "ERROR: thread2 is not alive" 8220456: jdi/EventQueue/remove_l/remove_l004 failed due to "TIMEOUT while waiting for event" Reviewed-by: sspitsyn, dcubed, gadams ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove/remove004/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove_l/remove_l004/TestDescription.java Changeset: fce15a3c1922 Author: clanger Date: 2019-03-22 08:56 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fce15a3c1922 8200286: (testbug) MOptionTest test fails with java.lang.AssertionError: Classfiles too old! Reviewed-by: stuefe, jjg ! test/langtools/tools/javac/modules/MOptionTest.java Changeset: 17da5f618aaf Author: akolarkunnu Date: 2019-02-26 03:24 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/17da5f618aaf 8211322: Reduce the timeout of tooltip in SwingSet2DemoTest Reviewed-by: serb, shurailine Contributed-by: gauri.patil at oracle.com ! test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JToolTipOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/version_info Changeset: a17f46493e0b Author: dmarkov Date: 2019-02-26 18:12 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a17f46493e0b 8214109: XToolkit is not correctly displayed color on 16-bit high color setting Reviewed-by: serb, prr ! src/java.desktop/unix/classes/sun/awt/X11/XWindow.java Changeset: 6673d2b7e084 Author: psadhukhan Date: 2019-02-27 14:48 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6673d2b7e084 Merge - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java Changeset: d9d9655bb077 Author: prr Date: 2019-02-27 14:30 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d9d9655bb077 Merge Changeset: e4813eded7cb Author: serb Date: 2019-02-27 18:46 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e4813eded7cb 8213110: Remove the use of applets in automatic tests Reviewed-by: prr ! test/jdk/ProblemList.txt - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html ! test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.java - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html ! test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.java - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html ! test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.java - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html ! test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.java ! test/jdk/java/awt/ComponentOrientation/BorderTest.java ! test/jdk/java/awt/ComponentOrientation/FlowTest.java - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html ! test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html ! test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java ! test/jdk/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java ! test/jdk/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowRetaining.java - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html ! test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.java - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html ! test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java ! test/jdk/java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusSetVisibleTest.java ! test/jdk/java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusToFrontTest.java - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html ! test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.java ! test/jdk/java/awt/Focus/ClearLwQueueBreakTest/ClearLwQueueBreakTest.java ! test/jdk/java/awt/Focus/CloseDialogActivateOwnerTest/CloseDialogActivateOwnerTest.java ! test/jdk/java/awt/Focus/ConsumeNextKeyTypedOnModalShowTest/ConsumeNextKeyTypedOnModalShowTest.java ! test/jdk/java/awt/Focus/ContainerFocusAutoTransferTest/ContainerFocusAutoTransferTest.java - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html ! test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java ! test/jdk/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java ! test/jdk/java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html ! test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.java ! test/jdk/java/awt/Focus/FrameJumpingToMouse/FrameJumpingToMouse.java ! test/jdk/java/awt/Focus/IconifiedFrameFocusChangeTest/IconifiedFrameFocusChangeTest.java - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html ! test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.java - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html ! test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.java - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html ! test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java ! test/jdk/java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html ! test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.java ! test/jdk/java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java ! test/jdk/java/awt/Focus/RequestFocusToDisabledCompTest/RequestFocusToDisabledCompTest.java ! test/jdk/java/awt/Focus/ResetMostRecentFocusOwnerTest/ResetMostRecentFocusOwnerTest.java ! test/jdk/java/awt/Focus/RestoreFocusOnDisabledComponentTest/RestoreFocusOnDisabledComponentTest.java ! test/jdk/java/awt/Focus/ShowFrameCheckForegroundTest/ShowFrameCheckForegroundTest.java - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html ! test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.java - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html ! test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.java - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html ! test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java ! test/jdk/java/awt/Focus/WrongKeyTypedConsumedTest/WrongKeyTypedConsumedTest.java ! test/jdk/java/awt/FontClass/CreateFont/BigFont.java - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html ! test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.java - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html ! test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.java ! test/jdk/java/awt/FullScreen/SetFSWindow/FSFrame.java - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html ! test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html ! test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.java - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html ! test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.java - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html ! test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html ! test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.java - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html ! test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html ! test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.java - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html ! test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.java - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html ! test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.java - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html ! test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.java - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html ! test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.java - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html ! test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html ! test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.java - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.java - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html ! test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html ! test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html ! test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html ! test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.java - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.java - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.java - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html ! test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.java - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html ! test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html ! test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.java - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html ! test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.java - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html ! test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.java - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html ! test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.java - test/jdk/javax/imageio/AppletResourceTest.html ! test/jdk/javax/imageio/AppletResourceTest.java - test/jdk/javax/swing/JFrame/4962534/bug4962534.html ! test/jdk/javax/swing/JFrame/4962534/bug4962534.java - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html ! test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.java - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html ! test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.java - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html ! test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.java - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html ! test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.java Changeset: 7c11a7cc7c1d Author: prr Date: 2019-03-01 16:59 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7c11a7cc7c1d 8210782: Upgrade HarfBuzz to the latest 2.3.1 Reviewed-by: serb, ihse, erikj ! make/lib/Awt2dLibraries.gmk ! src/java.desktop/share/legal/harfbuzz.md + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-fdsc-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-ankr-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-bsln-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-feat-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-just-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-kerx-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-lcar-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-morx-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-trak-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-ltag-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-map.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-array.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-json.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-text.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-serialize.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-cs-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-dict-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff1-interp-cs.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff2-interp-cs.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-coretext.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-debug.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-deprecated.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-dsalgs.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-fallback-shape.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ft.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-iter.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-kern.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-machinery.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-null.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff1-table.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff1-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff2-table.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff2-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cmap-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cbdt-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-colr-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cpal-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-sbix-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-svg-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-deprecated.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-face.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-face.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-font.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-gasp-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-glyf-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hdmx-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-head-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hhea-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hmtx-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-kern-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-base-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gdef-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gpos-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsub-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-jstf-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-math-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-math.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-maxp-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-language.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-language.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-unicode-ranges.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-macroman.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-fallback.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-win1256.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-default.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hangul.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hebrew.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-table.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-thai.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-table.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-vowel-constraints.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-vowel-constraints.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-stat-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-avar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-fvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-hvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-mvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-vorg-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-list.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-static.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-string-array.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff-common.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff1.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff1.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff2.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff2.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-input.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-input.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn/ucdn.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-emoji-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-vector.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-version.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-warning.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb.hh ! src/java.desktop/share/native/libfontmanager/hb-jdk-font.cc Changeset: 9413f1a4dc2b Author: serb Date: 2019-03-04 01:44 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9413f1a4dc2b 8061381: [macosx] Accelerators does not spelled for JMenuItems by Voice Over Reviewed-by: prr, kaddepalli ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java ! src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java Changeset: 6b2f2ec0f618 Author: pbansal Date: 2019-03-05 13:09 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6b2f2ec0f618 8214253: Tooltip is transparent rather than having a black background Reviewed-by: serb, psadhukhan ! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c Changeset: 63946f20c24f Author: pbansal Date: 2019-03-05 14:03 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/63946f20c24f 8214112: The whole text in target JPasswordField image are not selected Reviewed-by: serb, psadhukhan ! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c Changeset: a5af6175d62b Author: kaddepalli Date: 2019-03-07 12:51 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a5af6175d62b 8218674: HTML Tooltip with "img=src" on component doesn't show Reviewed-by: serb, psadhukhan ! src/java.desktop/share/classes/javax/swing/text/html/ImageView.java + test/jdk/javax/swing/text/html/8218674/TooltipImageTest.java + test/jdk/javax/swing/text/html/8218674/circle.png Changeset: 7d5e595cb7aa Author: psadhukhan Date: 2019-03-08 14:07 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7d5e595cb7aa 8215396: JTabbedPane preferred size calculation is wrong for SCROLL_TAB_LAYOUT Reviewed-by: serb ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/jdk/javax/swing/JTabbedPane/TabProb.java Changeset: 371d29d4add5 Author: serb Date: 2019-03-09 14:48 -0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/371d29d4add5 8219504: Test for JDK-8211435 can be run on all platforms Reviewed-by: kaddepalli, dmarkov, sveerabhadra ! test/jdk/java/awt/Focus/NullActiveWindowOnFocusLost/NullActiveWindowOnFocusLost.java Changeset: 0804f29e8be7 Author: mbalao Date: 2019-03-01 12:21 -0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0804f29e8be7 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth Summary: Consider algorithmic bold in FontMetrics.getMaxAdvance value and update obliqueness. Reviewed-by: prr, serb ! src/java.desktop/share/native/libfontmanager/freetypeScaler.c + test/jdk/java/awt/FontMetrics/MaxAdvanceIsMax.java Changeset: 5294813fe931 Author: vagarwal Date: 2019-03-13 00:04 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5294813fe931 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ Reviewed-by: prr, iignatyev ! test/jdk/TEST.ROOT ! test/jdk/sanity/client/README ! test/jdk/sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java ! test/jdk/sanity/client/SwingSet/src/EditorPaneDemoTest.java - test/jdk/sanity/client/TEST.ROOT.template ! test/jdk/sanity/client/TEST.properties Changeset: 3c369ad8c4ac Author: vagarwal Date: 2019-03-13 00:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3c369ad8c4ac 8216353: Use utility APIs introduced in org/netbeans/jemmy/util/LookAndFeel class in client sanity test cases Reviewed-by: serb ! test/jdk/sanity/client/SwingSet/src/FileChooserDemoTest.java ! test/jdk/sanity/client/SwingSet/src/SliderDemoTest.java ! test/jdk/sanity/client/SwingSet/src/SplitPaneDemoTest.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/DefaultDriverInstaller.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JFileChooserOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JInternalFrameOperator.java + test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/LookAndFeel.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/version_info Changeset: 132590e72765 Author: serb Date: 2019-03-16 17:50 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/132590e72765 7106851: Test should not use System.exit Reviewed-by: aivanov, psadhukhan, kaddepalli + test/jdk/javax/accessibility/6192422/bug6192422.java Changeset: 0b9fb3cfb6f2 Author: prr Date: 2019-03-18 14:55 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0b9fb3cfb6f2 8218914: Support fonts installed per-user on Windows 10 Reviewed-by: prr, serb Contributed-by: Mikhail Filippov ! src/java.desktop/windows/native/libfontmanager/fontpath.c Changeset: 3ee03f1d88c9 Author: psadhukhan Date: 2019-03-20 16:07 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3ee03f1d88c9 Merge - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/hotspot/share/prims/evmCompat.cpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf ! test/jdk/ProblemList.txt ! test/jdk/TEST.ROOT - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java Changeset: 96c45aa61056 Author: psadhukhan Date: 2019-03-22 13:42 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/96c45aa61056 Merge - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt ! test/jdk/ProblemList.txt Changeset: f04e3492fd88 Author: alanb Date: 2019-03-22 11:35 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f04e3492fd88 8221252: (sc) SocketChannel and its socket adaptor need to handle connection reset Reviewed-by: bpb ! src/java.base/share/classes/sun/nio/ch/IOStatus.java ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/java.base/unix/classes/sun/nio/ch/SocketDispatcher.java ! src/java.base/unix/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! src/java.base/unix/native/libnio/ch/Net.c + src/java.base/unix/native/libnio/ch/SocketDispatcher.c ! src/java.base/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/java.base/windows/native/libnio/ch/Net.c ! src/java.base/windows/native/libnio/ch/SocketDispatcher.c ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java + test/jdk/java/nio/channels/SocketChannel/ConnectionReset.java Changeset: 3e7fccdb6181 Author: pliden Date: 2019-03-22 12:49 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3e7fccdb6181 8221212: ZGC: Command-line flags should be marked experimental Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/z_globals.hpp Changeset: b9cd87da3211 Author: pliden Date: 2019-03-22 12:49 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b9cd87da3211 8221219: ZGC: Remove ZStallOnOutOfMemory option Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/gc/z/z_globals.hpp Changeset: 931247e90857 Author: dbuck Date: 2019-03-22 09:05 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/931247e90857 8217564: idempotent protection missing in crc32c.h Summary: added include guard to crc32c.h Reviewed-by: dcubed ! src/hotspot/cpu/x86/crc32c.h Changeset: 601326fead41 Author: erikj Date: 2019-03-22 08:14 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/601326fead41 8221179: Zero builds fail when linking with gold and bundling libffi.so Reviewed-by: sgehwolf, tbell ! make/hotspot/lib/JvmFeatures.gmk Changeset: 51195881bd3a Author: bpb Date: 2019-03-22 08:18 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/51195881bd3a 8078860: (spec) InputStream.read(byte[] b, int off, int len) claims to not affect element b[off] Reviewed-by: lancea, darcy, rriggs ! src/java.base/share/classes/java/io/InputStream.java Changeset: 83deaa8f0c8e Author: naoto Date: 2019-03-22 09:31 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/83deaa8f0c8e 8220224: With CLDR provider, NumberFormat.format could not handle locale with number extension correctly. Reviewed-by: darcy ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! src/java.base/share/classes/java/text/DecimalFormat.java ! src/java.base/share/classes/java/text/DecimalFormatSymbols.java + test/jdk/java/text/Format/NumberFormat/DFSMinusPerCentMill.java Changeset: 01d8eae542ff Author: xuelei Date: 2019-03-22 13:47 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/01d8eae542ff 8218889: Improperly use of the Optional API Reviewed-by: jnimeh, wetmore ! src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/java.base/share/classes/sun/security/ssl/ServerHello.java Changeset: a2956337451b Author: coleenp Date: 2019-03-22 16:16 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a2956337451b 8218399: runtime/RedefineObject/TestRedefineObject.java timeout Summary: exclude this test for graal Reviewed-by: hseigel, lfoltan ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineObject.java Changeset: c81fbf340ceb Author: kbarrett Date: 2019-03-22 15:42 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c81fbf340ceb 8220240: Refactor shared dirty card queue Summary: Add G1SharedDirtyCardQueue class. Reviewed-by: tschatzl, lkorinth ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp + src/hotspot/share/gc/g1/g1SharedDirtyCardQueue.cpp + src/hotspot/share/gc/g1/g1SharedDirtyCardQueue.hpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/ptrQueue.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.hpp Changeset: aa937fac07f3 Author: shade Date: 2019-03-23 17:18 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/aa937fac07f3 8221363: Build failure after JDK-8220240 (Refactor shared dirty card queue) Reviewed-by: stuefe ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp Changeset: 21702e87efdf Author: iklam Date: 2019-03-23 21:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/21702e87efdf 8220095: Assertion failure when symlink (with different name) is used for lib/modules file Summary: Removed confusing function ClassLoader::is_modules_image(char*) Reviewed-by: lfoltan, ccheung Contributed-by: Jiangli Zhou ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileStream.cpp ! src/hotspot/share/classfile/classFileStream.hpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoader.hpp ! src/hotspot/share/oops/instanceKlass.cpp + test/hotspot/jtreg/runtime/modules/ModulesSymLink.java Changeset: 0db90e99f13b Author: qpzhang Date: 2019-03-21 16:45 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0db90e99f13b 8221220: AArch64: Add StoreStore membar explicitly for Volatile Writes in TemplateTable Reviewed-by: aph ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp Changeset: d25b24c70126 Author: dholmes Date: 2019-03-25 00:57 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d25b24c70126 8221207: Redo JDK-8218446 - SuspendAtExit hangs Reviewed-by: rehn, dcubed ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: bb8828626944 Author: gadams Date: 2019-03-25 07:31 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bb8828626944 8221164: jstatLineCounts tests need to be more resilient for NaN outputs Reviewed-by: cjplummer, phh, jcbeyler ! test/jdk/sun/tools/jstat/lineCounts3.awk ! test/jdk/sun/tools/jstat/lineCounts4.awk Changeset: b1605a40e336 Author: gadams Date: 2019-03-25 08:37 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b1605a40e336 8220295: sun/tools/jps/TestJps.java still timing out Reviewed-by: cjplummer, jcbeyler ! test/jdk/TEST.ROOT Changeset: 1f9ad92e337b Author: tschatzl Date: 2019-03-25 14:11 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1f9ad92e337b 8219100: Improve do_collection_pause_at_safepoint Reviewed-by: kbarrett, sangheki ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1Policy.hpp ! test/hotspot/jtreg/gc/g1/TestVerifyGCType.java Changeset: 3cabb47758c9 Author: mgronlun Date: 2019-03-25 15:37 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3cabb47758c9 8217362: Emergency dump does not work when disk=false is set Reviewed-by: egahlin, ysuenaga Contributed-by: yasuenag at gmail.com ! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.hpp ! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp ! test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java Changeset: 41af8d0546bc Author: lkorinth Date: 2019-03-25 14:46 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/41af8d0546bc 8221260: Initialize more class members on construction, remove some unused ones Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp ! src/hotspot/share/gc/parallel/adjoiningGenerations.cpp ! src/hotspot/share/gc/parallel/adjoiningGenerations.hpp ! src/hotspot/share/gc/parallel/gcTaskThread.cpp ! src/hotspot/share/gc/parallel/gcTaskThread.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp ! src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.hpp ! src/hotspot/share/gc/parallel/psFileBackedVirtualspace.cpp ! src/hotspot/share/gc/parallel/psFileBackedVirtualspace.hpp ! src/hotspot/share/gc/parallel/psMarkSweepDecorator.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psVirtualspace.cpp ! src/hotspot/share/gc/parallel/psVirtualspace.hpp ! src/hotspot/share/gc/parallel/psYoungGen.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.cpp ! src/hotspot/share/gc/shared/gcStats.cpp Changeset: 1b0163c877c0 Author: erikj Date: 2019-03-25 09:07 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1b0163c877c0 8220445: Support for side by side MSVC Toolset versions Reviewed-by: tbell Contributed-by: ali.ince at gmail.com, erik.joelsson at oracle.com ! make/autoconf/toolchain_windows.m4 Changeset: 7816d989bf21 Author: dpochepk Date: 2019-03-25 19:49 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7816d989bf21 8216989: CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64 Reviewed-by: adinn ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 75445a7c2c04 Author: redestad Date: 2019-03-25 20:57 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/75445a7c2c04 8221343: x86_32 crashes on startup with "_hwm out of range" Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/matcher.cpp Changeset: 0cf2c87ce79a Author: dholmes Date: 2019-03-25 17:29 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0cf2c87ce79a 8221357: Update test documentation by deleting "cd test && make" Reviewed-by: dholmes, tbell, erikj Contributed-by: Jing Tian ! doc/testing.html ! doc/testing.md Changeset: 418fbdb1b581 Author: gromero Date: 2019-03-25 19:40 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/418fbdb1b581 8221434: Fix typo in lib-x11 autoconf error message about missing headers Reviewed-by: dholmes ! make/autoconf/lib-x11.m4 Changeset: 176e8aec3097 Author: sspitsyn Date: 2019-03-25 19:16 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/176e8aec3097 8146986: JDI: Signature lookups for unprepared classes can take a long time Summary: Do not cache classes if signature is not provided Reviewed-by: sspitsyn, jcbeyler ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java Changeset: 44edf64cb206 Author: darcy Date: 2019-03-25 19:40 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/44edf64cb206 8221264: Refactor and update SourceVersion.latestSupported Reviewed-by: jjg, cushon, martin ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java Changeset: 85657f4753e4 Author: dtitov Date: 2019-03-26 04:19 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/85657f4753e4 8217827: [Graal] Some vmTestbase/nsk/jvmti/ResourceExhausted tests failing Reviewed-by: cjplummer, jcbeyler, dholmes ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted002/TestDescription.java Changeset: f0490ada4712 Author: clanger Date: 2019-03-26 09:16 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f0490ada4712 8221262: Cleanups in UnixFileSystem/WinNTFileSystem implementation classes Reviewed-by: alanb, igerasim ! src/java.base/unix/classes/java/io/UnixFileSystem.java ! src/java.base/unix/native/libjava/UnixFileSystem_md.c ! src/java.base/windows/classes/java/io/WinNTFileSystem.java Changeset: a7358438d463 Author: redestad Date: 2019-03-26 10:23 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a7358438d463 8220682: Heap dumping and inspection fails with JDK-8214712 Reviewed-by: jcbeyler, jiangli, sspitsyn ! src/hotspot/share/memory/heapInspection.cpp ! src/hotspot/share/services/heapDumper.cpp Changeset: 5ee30b6991a7 Author: redestad Date: 2018-12-03 16:25 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5ee30b6991a7 8214712: Archive Attributes$Name.KNOWN_NAMES Reviewed-by: alanb, jiangli ! src/hotspot/share/memory/heapShared.cpp ! src/java.base/share/classes/java/util/jar/Attributes.java Changeset: 5487a925f70d Author: simonis Date: 2019-03-26 11:51 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5487a925f70d 8221083: [ppc64] Wrong oop compare in C1-generated code Reviewed-by: mdoerr, goetz ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp + test/hotspot/jtreg/compiler/codegen/TestOopCmp.java Changeset: f283f6871336 Author: gadams Date: 2019-03-26 07:09 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f283f6871336 8203026: java.rmi.NoSuchObjectException: no such object in table Reviewed-by: rriggs, sspitsyn ! src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java ! src/jdk.jstatd/share/classes/sun/tools/jstatd/RemoteHostImpl.java Changeset: 16999bd91ba6 Author: rehn Date: 2019-03-26 12:08 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/16999bd91ba6 8220774: Add HandshakeALot diag option Reviewed-by: dcubed, dholmes ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/runtime/vmThread.hpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/Thread/SuspendAtExit.java + test/hotspot/jtreg/runtime/handshake/HandshakeSuspendExitTest.java ! test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java Changeset: 368757835b97 Author: gadams Date: 2019-03-26 07:24 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/368757835b97 8218128: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003 and 004 use wrong path to test classes Reviewed-by: cjplummer, dholmes, lmesnik ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003.java + test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TEST.properties ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted004/TestDescription.java Changeset: a33c42262338 Author: rschmelter Date: 2019-03-22 04:47 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a33c42262338 8220570: Additonal trace when native thread creation fails Summary: Added additonal trace when native thread creation fails Reviewed-by: dholmes, goetz ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp Changeset: ca554363aed3 Author: weijun Date: 2019-03-26 21:33 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ca554363aed3 8217690: Update public suffix version Reviewed-by: mullan ! make/data/publicsuffixlist/VERSION ! make/data/publicsuffixlist/public_suffix_list.dat Changeset: 6ddb9e3f1654 Author: rehn Date: 2019-03-26 14:49 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6ddb9e3f1654 8221472: Fix HandshakeSuspendExitTest Reviewed-by: dcubed, redestad ! test/hotspot/jtreg/runtime/handshake/HandshakeSuspendExitTest.java Changeset: e61065c08924 Author: gromero Date: 2019-03-20 16:59 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e61065c08924 8220794: PPC64: Fix signal handler for SIGSEGV on branch to illegal address Reviewed-by: stuefe, goetz ! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp Changeset: a2897fb258f1 Author: gromero Date: 2019-03-20 16:43 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a2897fb258f1 8221175: Fix bad function case for controlled JVM crash on PPC64 big-endian Reviewed-by: chrisphi, stuefe, goetz ! src/hotspot/share/utilities/vmError.cpp Changeset: 33f0b34c9dd7 Author: redestad Date: 2019-03-26 15:20 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/33f0b34c9dd7 8221473: Configuration::reads can use Set.copyOf Reviewed-by: alanb, forax ! src/java.base/share/classes/java/lang/module/Configuration.java Changeset: 6640fd9196d9 Author: stuefe Date: 2019-03-26 15:46 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6640fd9196d9 8221406: Windows 32bit build error in NetworkInterface_winXP.c Reviewed-by: clanger ! src/java.base/windows/native/libnet/NetworkInterface_winXP.c Changeset: c02b8d6384ab Author: stuefe Date: 2019-03-26 15:52 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c02b8d6384ab 8221407: Windows 32bit build error in libsunmscapi/security.cpp Reviewed-by: clanger ! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp Changeset: c12b897021ea Author: erikj Date: 2019-03-26 09:24 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c12b897021ea 8221414: Bump required boot jdk version to 12 Reviewed-by: mikael, tbell ! make/autoconf/version-numbers ! make/conf/jib-profiles.js Changeset: 6183f835b9b6 Author: chegar Date: 2019-03-26 17:02 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6183f835b9b6 8219446: Specify behaviour of timeout accepting methods of Socket and ServerSocket if timeout is negative Reviewed-by: alanb, dfuchs ! src/java.base/share/classes/java/net/ServerSocket.java ! src/java.base/share/classes/java/net/Socket.java ! test/jdk/java/net/Socket/Timeouts.java Changeset: 8af48416e31f Author: simonis Date: 2019-03-26 18:42 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8af48416e31f 8221483: TestOopCmp.java fails due to "Multiple garbage collectors selected" Reviewed-by: kvn, mdoerr ! test/hotspot/jtreg/compiler/codegen/TestOopCmp.java Changeset: e6c86f6012bf Author: dcubed Date: 2019-03-26 15:27 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e6c86f6012bf 8221350: more monitor logging updates from Async Monitor Deflation project Reviewed-by: dholmes, coleenp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: c31faeacf00a Author: zgu Date: 2019-03-26 15:50 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c31faeacf00a 8204552: NMT: Separate thread stack tracking from virtual memory tracking Reviewed-by: stuefe, minqi ! make/hotspot/lib/JvmFeatures.gmk ! src/hotspot/share/services/memBaseline.cpp ! src/hotspot/share/services/memReporter.cpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/services/memTracker.hpp + src/hotspot/share/services/threadStackTracker.cpp + src/hotspot/share/services/threadStackTracker.hpp ! src/hotspot/share/services/virtualMemoryTracker.cpp Changeset: dae71635cc3a Author: mseledtsov Date: 2019-03-26 13:25 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dae71635cc3a 8221342: [TESTBUG] Generate Dockerfile for docker testing Summary: Dockerfile is generated; introduced properties to specify custom base image Reviewed-by: sgehwolf, dholmes, jiefu - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x ! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java + test/lib/jdk/test/lib/containers/docker/DockerfileConfig.java Changeset: add0810ec2fa Author: sspitsyn Date: 2019-03-26 14:43 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/add0810ec2fa 8221513: Add vmTestbase/nsk/jdb/eval/eval001/eval001.java to ProblemList.txt Summary: Add test to the ProblemList.txt Reviewed-by: dcubed ! test/hotspot/jtreg/ProblemList.txt Changeset: 49c4b23d8d0a Author: afarley Date: 2019-03-26 15:53 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/49c4b23d8d0a 8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields Reviewed-by: mchung ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! test/jdk/java/lang/invoke/MethodHandlesGeneralTest.java ! test/jdk/java/lang/invoke/MethodHandlesTest.java ! test/jdk/java/lang/invoke/VarHandles/accessibility/TestFieldLookupAccessibility.java Changeset: dc66ada06693 Author: cushon Date: 2019-03-26 15:36 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dc66ada06693 8220633: Optimize CacheFSInfo Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/CacheFSInfo.java Changeset: f98f158c1db8 Author: iklam Date: 2019-03-26 11:34 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f98f158c1db8 8217347: [TESTBUG] runtime/appcds/jvmti/InstrumentationTest.java timed out Summary: Avoid using VirtualMachine.list(). Use Process.pid() instead. Reviewed-by: dholmes ! test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationApp.java ! test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationTest.java Changeset: 6207397a6603 Author: cushon Date: 2019-03-26 15:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6207397a6603 8220687: Add StandardJavaFileManager.getJavaFileObjectsFromPaths overload Reviewed-by: jjg ! src/java.compiler/share/classes/javax/tools/StandardJavaFileManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/DelegatingJavaFileManager.java ! test/langtools/tools/javac/api/file/SJFM_GetFileObjects.java Changeset: 656789f95658 Author: ghaug Date: 2019-03-26 16:00 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/656789f95658 8221479: Fix JFR profiling on s390 Reviewed-by: mdoerr, clanger ! src/hotspot/os_cpu/linux_s390/thread_linux_s390.cpp Changeset: 1b85f55c9aa2 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1b85f55c9aa2 8221396: Clean up serviceability/sa/TestUniverse.java Reviewed-by: stefank, jcbeyler ! test/hotspot/jtreg/serviceability/sa/TestUniverse.java Changeset: 2f522c487791 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2f522c487791 8221392: Reduce ConcurrentGCThreads spinning during start up Reviewed-by: eosterlund, kbarrett ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/init.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp Changeset: 0a2d73e02076 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0a2d73e02076 8221537: ZGC: Fix incorrect comment in zNMethod table entry layout Reviewed-by: stefank ! src/hotspot/share/gc/z/zNMethodTableEntry.hpp Changeset: 3022f7d70897 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3022f7d70897 8220198: Lots of com/sun/crypto/provider/Cipher tests fail on x86_32 due to missing SHA512 stubs Reviewed-by: kvn, thartmann ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/library_call.cpp Changeset: 78f88c4423a4 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/78f88c4423a4 8221400: java/lang/String/StringRepeat.java test requests too much heap Reviewed-by: stuefe, alanb ! test/jdk/java/lang/String/StringRepeat.java Changeset: 848859723503 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/848859723503 8221401: java/math/BigInteger/LargeValueExceptions.java test should be disabled on 32-bit platforms Reviewed-by: stuefe, bpb ! test/jdk/java/math/BigInteger/LargeValueExceptions.java Changeset: 828c4889adfc Author: shade Date: 2019-03-27 12:38 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/828c4889adfc 8221524: java/util/Base64/TestEncodingDecodingLength.java test should be disabled on 32-bit platforms Reviewed-by: stuefe, alanb ! test/jdk/java/util/Base64/TestEncodingDecodingLength.java Changeset: df62ea1da6ad Author: rraghavan Date: 2019-03-27 18:33 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/df62ea1da6ad 8219612: compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host Summary: Test rewritten to use top level classes rather then nested ones Reviewed-by: iignatyev, kvn, thartmann ! test/hotspot/jtreg/compiler/codecache/stress/Helper.java ! test/hotspot/jtreg/compiler/codecache/stress/RandomAllocationTest.java ! test/hotspot/jtreg/compiler/codecache/stress/ReturnBlobToWrongHeapTest.java + test/hotspot/jtreg/compiler/codecache/stress/TestCaseImpl.java ! test/hotspot/jtreg/compiler/codecache/stress/UnexpectedDeoptimizationTest.java Changeset: 1dcacbe612ae Author: hseigel Date: 2019-03-27 09:29 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1dcacbe612ae 8059357: ClassVerifier redundantly checks constant pool entries multiple times Summary: Store translated signature verificationTypes in a hashtable where they can be fetched, instead of having to re-translating the signatures Reviewed-by: iklam, coleenp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp Changeset: c4c225b49c5f Author: bpb Date: 2019-03-27 07:21 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c4c225b49c5f 8219196: DataOutputStream.writeUTF may throw unexpected exceptions Reviewed-by: martin, darcy, rriggs Contributed-by: Martin Buchholz ! src/java.base/share/classes/java/io/DataOutputStream.java ! test/jdk/java/io/DataOutputStream/WriteUTF.java Changeset: 646c54d5989b Author: mseledtsov Date: 2019-03-27 08:38 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/646c54d5989b 8221527: [TESTBUG] DockerBasicTest.java contains hard-coded reference to JDK 10 Summary: Using Docker test library to get the image name Reviewed-by: dholmes ! test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java Changeset: 3fedbfdb25b6 Author: pliden Date: 2019-03-27 18:30 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3fedbfdb25b6 8221456: nmethod::make_unloaded() clears _method member too early Reviewed-by: eosterlund, thartmann ! src/hotspot/share/code/nmethod.cpp Changeset: 0223b7b8a1c5 Author: simonis Date: 2019-03-27 19:47 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0223b7b8a1c5 8220528: [AIX] Fix basic Xinerama and Xrender functionality Reviewed-by: clanger, stuefe, serb ! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c Changeset: 440cbcf3b268 Author: bpb Date: 2019-03-27 13:00 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/440cbcf3b268 8221531: Incorrect copyright header in src/java.base/windows/native/libnio/ch/FileChannelImpl.c Reviewed-by: lancea, bchristi ! src/java.base/windows/native/libnio/ch/FileChannelImpl.c Changeset: 46cf212cdcca Author: aeubanks Date: 2019-03-27 09:06 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/46cf212cdcca 8220575: Replace hardcoded 127.0.0.1 in URLs with new URI builder Reviewed-by: dfuchs, chegar Contributed-by: aeubanks at google.com ! test/jdk/com/sun/net/httpserver/TestLogging.java ! test/jdk/com/sun/net/httpserver/bugs/6725892/Test.java ! test/jdk/com/sun/net/httpserver/bugs/B6373555.java ! test/jdk/com/sun/net/httpserver/bugs/B6401598.java ! test/jdk/java/net/HttpCookie/ExpiredCookieTest.java ! test/jdk/java/net/HttpURLConnection/NoProxyTest.java ! test/jdk/java/net/ProxySelector/NullSelector.java ! test/jdk/java/net/ResponseCache/Test2.java ! test/jdk/java/net/URLClassLoader/closetest/CloseTest.java ! test/jdk/java/net/URLConnection/TimeoutTest.java ! test/jdk/java/net/URLPermission/OpenURL.java ! test/jdk/java/net/httpclient/AuthSchemesTest.java ! test/jdk/java/net/httpclient/LargeResponseContent.java ! test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java ! test/jdk/sun/net/www/protocol/http/6550798/test.java ! test/jdk/sun/net/www/protocol/http/B6890349.java ! test/jdk/sun/net/www/protocol/http/B8012625.java ! test/jdk/sun/net/www/protocol/http/NoNTLM.java ! test/jdk/sun/net/www/protocol/http/RedirectOnPost.java ! test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java ! test/jdk/sun/net/www/protocol/http/RetryUponTimeout.java ! test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java ! test/jdk/sun/net/www/protocol/http/UserAgent.java ! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressDNSIdentities.java ! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java + test/lib/jdk/test/lib/net/URIBuilder.java Changeset: 7d5a4a48e876 Author: joehw Date: 2019-03-27 14:40 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7d5a4a48e876 8221533: Incorrect copyright header in DurationDayTimeImpl.java, DurationYearMonthImpl.java and XMLStreamException.java Reviewed-by: bpb, lancea ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationDayTimeImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationYearMonthImpl.java ! src/java.xml/share/classes/javax/xml/stream/XMLStreamException.java Changeset: f714e4cebceb Author: bpb Date: 2019-03-27 16:35 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f714e4cebceb 8221568: DataOutputStream/WriteUTF.java fails due to "OutOfMemoryError: Java heap space" Reviewed-by: shade ! test/jdk/java/io/DataOutputStream/WriteUTF.java Changeset: 5b5bd291ca32 Author: jwilhelm Date: 2019-03-28 01:43 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5b5bd291ca32 Added tag jdk-13+14 for changeset 46cf212cdcca ! .hgtags Changeset: c0037e86ec02 Author: dtitov Date: 2019-03-28 04:26 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c0037e86ec02 8218727: vmTestbase/nsk/jvmti/scenarios/events/EM04/em04t001/TestDescription.java crash in native library Reviewed-by: sspitsyn, gadams ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM04/em04t001/em04t001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM07/em07t002/em07t002.cpp Changeset: 55025f677f68 Author: dtitov Date: 2019-03-28 04:30 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/55025f677f68 8221532: Incorrect copyright header in FileSystemSupport_md.c Reviewed-by: cjplummer, gadams ! src/java.instrument/unix/native/libinstrument/FileSystemSupport_md.c ! src/java.instrument/windows/native/libinstrument/FileSystemSupport_md.c Changeset: e9618b37f0a5 Author: goetz Date: 2019-03-28 09:15 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e9618b37f0a5 8221398: Move test NoClassDefFoundMsg.java to subdir exceptionMsgs/ Reviewed-by: coleenp + test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java + test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/libNoClassDefFoundErrorTest.c - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c Changeset: c9a492ad1aed Author: jlahoda Date: 2019-03-28 10:32 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c9a492ad1aed 8221413: javac does not recognize variable assigned in switch expression as DA Summary: Fixing definite assignment in presence of implicit throws clause in switch expressions over enums. Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! test/langtools/tools/javac/switchexpr/DefiniteAssignment1.java Changeset: cf75ea6af695 Author: stuefe Date: 2019-03-25 09:35 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cf75ea6af695 8220786: Create new switch to redirect error reporting output to stdout or stderr Reviewed-by: dholmes, goetz ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/utilities/vmError.cpp + test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileRedirectTest.java Changeset: 846bc643f4ef Author: rehn Date: 2019-03-28 11:08 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/846bc643f4ef 8220351: Cross-modifying code Reviewed-by: rrich, mdoerr, dholmes, eosterlund ! src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp ! src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.hpp ! src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.hpp ! src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.hpp ! src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp ! src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp ! src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.hpp ! src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.hpp ! src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.hpp ! src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.hpp ! src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.hpp ! src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.hpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/interfaceSupport.inline.hpp ! src/hotspot/share/runtime/orderAccess.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/safepointMechanism.cpp ! src/hotspot/share/runtime/safepointMechanism.hpp ! src/hotspot/share/runtime/safepointMechanism.inline.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: 9d5c84b0a598 Author: dfuchs Date: 2019-03-28 12:16 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9d5c84b0a598 8221395: HttpClient leaving connections in CLOSE_WAIT state until Java process ends Summary: When a non WebSocket connection is not returned to the pool, it needs to be closed even if HttpConnection::isOpen yields false. Reviewed-by: chegar, michaelm ! src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java ! test/jdk/java/net/httpclient/whitebox/ConnectionPoolTestDriver.java ! test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/ConnectionPoolTest.java Changeset: 04f1a0f925db Author: erikj Date: 2019-03-28 08:37 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/04f1a0f925db 8220530: Build compare script does not compare the contents of the test image Reviewed-by: tbell ! make/conf/jib-profiles.js ! make/scripts/compare.sh ! make/scripts/compare_exceptions.sh.incl Changeset: eb7f2c367f73 Author: erikj Date: 2019-03-28 10:04 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/eb7f2c367f73 8205934: Define jdk -source/-target version in version-numbers file Reviewed-by: tbell ! make/autoconf/jdk-version.m4 ! make/autoconf/spec.gmk.in ! make/autoconf/version-numbers ! make/common/SetupJavaCompilers.gmk Changeset: a4d19817609c Author: jcbeyler Date: 2019-03-28 11:06 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a4d19817609c 8157372: C2: Node::cmp() should return bool Summary: The method Node::cmp() should return a boolean Reviewed-by: vlivanov, kvn Contributed-by: dthomson at google.com ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp ! src/hotspot/share/opto/callnode.cpp ! src/hotspot/share/opto/callnode.hpp ! src/hotspot/share/opto/castnode.cpp ! src/hotspot/share/opto/castnode.hpp ! src/hotspot/share/opto/cfgnode.cpp ! src/hotspot/share/opto/cfgnode.hpp ! src/hotspot/share/opto/locknode.cpp ! src/hotspot/share/opto/locknode.hpp ! src/hotspot/share/opto/machnode.cpp ! src/hotspot/share/opto/machnode.hpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/memnode.hpp ! src/hotspot/share/opto/multnode.cpp ! src/hotspot/share/opto/multnode.hpp ! src/hotspot/share/opto/node.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/opaquenode.cpp ! src/hotspot/share/opto/opaquenode.hpp ! src/hotspot/share/opto/subnode.cpp ! src/hotspot/share/opto/subnode.hpp Changeset: 37648a9c4a6a Author: jwilhelm Date: 2019-03-28 19:39 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/37648a9c4a6a 8221341: Update Graal Reviewed-by: kvn ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/DataPatchProcessor.java ! src/jdk.internal.vm.ci/share/classes/module-info.java ! src/jdk.internal.vm.compiler.management/share/classes/org.graalvm.compiler.hotspot.management/src/org/graalvm/compiler/hotspot/management/HotSpotGraalRuntimeMBean.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64MacroAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm/src/org/graalvm/compiler/asm/Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64.test/src/org/graalvm/compiler/core/amd64/test/AMD64MatchRuleTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/Fields.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/FieldsScanner.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/GraalOptions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeArrayTypeReader.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeArrayTypeWriter.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.match.processor/src/org/graalvm/compiler/core/match/processor/MatchProcessor.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CheckGraalInvariants.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/FinalizableSubclassTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/NewInstanceTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/SwitchTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnbalancedMonitorsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyBailoutUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyCallerSensitiveMethods.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyDebugUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyFoldableMethods.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyGetOptionsUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyGraphAddUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyInstanceOfUsage.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifySystemPropertyUsage.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyUnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyUpdateUsages.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyUsageWithEquals.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyVirtualizableUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EATestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/tutorial/StaticAnalysis.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/tutorial/StaticAnalysisTests.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/LIRGenerationPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/NodeLIRBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/NodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/match/MatchContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/match/MatchPattern.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/match/MatchStatement.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/match/MatchableNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/LogStream.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/MemUseTrackerKey.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/Versions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/Edges.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/Node.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/NodeClass.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/NodeSourcePosition.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64IndirectCallOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64ArrayCompareToStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64ArrayEqualsStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotNodeLIRBuilder.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/NodeCostDumpUtil.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/StringInternConstantTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/BootstrapWatchDog.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationStatistics.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationWatchDog.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalCompiler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalCompilerFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalRuntime.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotTTYStreamProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/IsGraalPredicate.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/IsGraalPredicateBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/JVMCIVersionCheck.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/SymbolicSnippetEncoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/debug/BenchmarkCounters.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotNodePlugin.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotObjdumpDisassemblerProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotSuitesProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/AheadOfTimeVerificationPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BytecodeParser.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/FrameStateBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/GraphBuilderPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ArithmeticLIRGeneratorTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Call.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Compare.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ControlFlow.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64MathIntrinsicBinaryOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Move.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayIndexOfOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Binary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64BinaryConsumer.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGeneratorTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/hashing/HashFunction.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/hashing/Hasher.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/SimplifyingGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/JavaWriteNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderConfiguration.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/NodePlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/AbstractWriteNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/CoreProviders.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/CoreProvidersImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/LoweringTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/NodeLIRBuilderTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionsParser.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/LoweringPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ProfileCompiledMethodsPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/inlining/walker/InliningData.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/VerifyPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/tiers/PhaseContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/util/Providers.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.printer/src/org/graalvm/compiler/printer/CFGPrinterObserver.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.printer/src/org/graalvm/compiler/printer/GraphPrinterDumpHandler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/CachingPEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ConstantStringIndexOfSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/GraphKit.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/InlineDuringParsingPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/IntrinsicGraphBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ReplacementsImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetCounterNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/classfile/ClassfileBytecodeProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayCompareToNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayRegionEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/MacroNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalUnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/JavaVersionUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/EffectsClosure.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/PartialEscapeClosure.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/Word.java Changeset: ddd60ad787d4 Author: pliden Date: 2019-03-28 19:43 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ddd60ad787d4 8221394: Clean up ConcurrentGCThread Reviewed-by: kbarrett, eosterlund ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/gc/shared/concurrentGCThread.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: 69e80a82db9a Author: pliden Date: 2019-03-28 19:43 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/69e80a82db9a 8221540: ZGC: Reduce width of zForwardingEntry::from_index field Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zForwarding.cpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! src/hotspot/share/gc/z/zForwardingEntry.hpp ! src/hotspot/share/gc/z/zRelocate.cpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: f0fec71d2fff Author: pliden Date: 2019-03-28 19:43 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f0fec71d2fff 8221153: ZGC: Heap iteration and verification pollutes GC statistics Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeapIterator.cpp ! src/hotspot/share/gc/z/zStat.cpp ! src/hotspot/share/gc/z/zStat.hpp Changeset: 9a8fe0bc38c3 Author: cushon Date: 2019-03-26 16:09 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9a8fe0bc38c3 8220632: Suggest recompiling with a larger value of -Xmaxerrs/-Xmaxwarns if diagnostics were suppressed Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Log.java + test/langtools/tools/javac/diags/examples/CountErrorRecompile.java + test/langtools/tools/javac/diags/examples/CountWarnRecompile.java + test/langtools/tools/javac/warnings/MaxDiagsRecompile.all.out + test/langtools/tools/javac/warnings/MaxDiagsRecompile.java + test/langtools/tools/javac/warnings/MaxDiagsRecompile.max1.out + test/langtools/tools/javac/warnings/MaxWarnsRecompile.all.out + test/langtools/tools/javac/warnings/MaxWarnsRecompile.java + test/langtools/tools/javac/warnings/MaxWarnsRecompile.max1.out Changeset: 2a29e62446bd Author: valeriep Date: 2019-03-29 00:39 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2a29e62446bd 8220016: Clean up redundant RSA services in the SunJSSE provider Summary: Removed duplicated RSA signature/KF/KPG support in SunJSSE Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/ssl/SunJSSE.java ! test/jdk/java/security/Signature/Offsets.java ! test/jdk/java/security/SignedObject/Chain.java ! test/jdk/sun/security/pkcs11/KeyStore/Basic.java + test/jdk/sun/security/rsa/BrokenRSAPrivateCrtKey.java - test/jdk/sun/security/ssl/rsa/BrokenRSAPrivateCrtKey.java + test/jdk/sun/security/ssl/rsa/CheckProviderEntries.java ! test/jdk/sun/security/ssl/rsa/SignatureOffsets.java ! test/jdk/sun/security/ssl/rsa/SignedObjectChain.java Changeset: f1548abd4ae0 Author: iklam Date: 2019-03-28 20:45 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f1548abd4ae0 8221621: FindTests.gmk cannot handle "=" in TEST.groups comments Reviewed-by: erikj, dholmes ! make/common/FindTests.gmk Changeset: d9f6d16299b1 Author: stuefe Date: 2019-03-29 08:36 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d9f6d16299b1 8221408: Windows 32bit build build errors/warnings in hotspot Reviewed-by: kbarrett, dholmes ! src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/oops/markOop.hpp Changeset: a335a4ddc631 Author: zgu Date: 2019-03-29 10:21 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a335a4ddc631 8221688: Quarantine Shenandoah string dedup tests Reviewed-by: rkennke ! test/hotspot/jtreg/ProblemList.txt Changeset: 5a9d780eb9dd Author: redestad Date: 2019-03-29 15:59 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5a9d780eb9dd 8221687: Deprecated j.u.jar.Attributes.Name attributes accidentally set to null Reviewed-by: alanb ! src/java.base/share/classes/java/util/jar/Attributes.java Changeset: 7a34a3270270 Author: zgu Date: 2019-03-26 12:12 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7a34a3270270 8221435: Shenandoah should not mark through weak roots Reviewed-by: rkennke, shade ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp ! src/hotspot/share/gc/shenandoah/shenandoahStringDedup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahStringDedup.hpp ! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Changeset: f69a2f675f19 Author: ronsh Date: 2019-03-29 07:38 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f69a2f675f19 8221118: Avoid eagerly creating JCDiagnostic for CompletionFailures Reviewed-by: jjg, mcimadamore, forax ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! test/langtools/tools/javac/defaultMethods/BadClassfile.java Changeset: 2221f042556d Author: iklam Date: 2019-03-29 08:42 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2221f042556d 8221351: Crash in KlassFactory::check_shared_class_file_load_hook Reviewed-by: dholmes, ccheung ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoader.hpp ! src/hotspot/share/classfile/klassFactory.cpp ! src/hotspot/share/memory/filemap.cpp ! src/hotspot/share/memory/filemap.hpp ! test/hotspot/jtreg/TEST.groups ! test/hotspot/jtreg/runtime/appcds/TestCommon.java ! test/hotspot/jtreg/runtime/appcds/customLoader/HelloCustom.java + test/hotspot/jtreg/runtime/appcds/customLoader/HelloCustom_JFR.java ! test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ModulePathAndCP.java + test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ModulePathAndCP_JFR.java ! test/hotspot/jtreg/runtime/appcds/jvmti/ClassFileLoadHook.java ! test/hotspot/jtreg/runtime/appcds/jvmti/ClassFileLoadHookTest.java Changeset: 0b47455de59b Author: stuefe Date: 2019-03-26 16:26 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0b47455de59b 8221480: jcmd VM.metaspace shall print limits in basic mode Reviewed-by: adinn, rehn ! src/hotspot/share/memory/metaspace.cpp ! test/hotspot/jtreg/runtime/Metaspace/PrintMetaspaceDcmd.java Changeset: 07212a29787a Author: joehw Date: 2019-03-29 18:00 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/07212a29787a 8220254: fix headings in java.xml Reviewed-by: lancea ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xpath/regex/RegularExpression.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogResolver.java ! src/java.xml/share/classes/javax/xml/datatype/DatatypeFactory.java ! src/java.xml/share/classes/javax/xml/parsers/DocumentBuilderFactory.java ! src/java.xml/share/classes/javax/xml/parsers/SAXParserFactory.java ! src/java.xml/share/classes/javax/xml/transform/TransformerFactory.java ! src/java.xml/share/classes/javax/xml/validation/SchemaFactory.java ! src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java Changeset: 6a1406c718ec Author: zgu Date: 2019-03-29 14:17 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6a1406c718ec 8221643: Tighten up assert(_keep_alive >= 0) in CLD::inc_keep_alive Reviewed-by: coleenp ! src/hotspot/share/classfile/classLoaderData.cpp Changeset: 8cd2af66ac7c Author: zgu Date: 2019-03-28 13:53 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8cd2af66ac7c 8221629: Shenandoah: Cleanup class unloading logic Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp + src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Changeset: 1042cac8bc2a Author: mseledtsov Date: 2019-03-29 18:25 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1042cac8bc2a 8221596: test/hotspot/jtreg/runtime/containers/docker/TestCPUSets.java failed with FileAlreadyExistsException Summary: Using StandardCopyOption.REPLACE_EXISTING to copy whitebox.jar Reviewed-by: dholmes, mseledtsov Contributed-by: jiefu ! test/lib/jdk/test/lib/containers/docker/Common.java Changeset: b7ebff3e4e69 Author: weijun Date: 2019-03-30 16:32 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b7ebff3e4e69 8221257: Improve serial number generation mechanism for keytool -gencert Reviewed-by: xuelei, mullan ! src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/x509/CertificateSerialNumber.java + test/jdk/sun/security/tools/keytool/Serial64.java Changeset: 235883996bc7 Author: iklam Date: 2019-03-30 08:26 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/235883996bc7 8221698: Remove redundant includes from popular header files Summary: Removed histogram.hpp classLoader.hpp utf8.hpp moduleEntry.hpp packageEntry.hpp Reviewed-by: coleenp, stuefe ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/moduleEntry.cpp ! src/hotspot/share/classfile/stringTable.cpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/memory/oopFactory.cpp ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiExport.cpp ! src/hotspot/share/prims/nativeLookup.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/interfaceSupport.inline.hpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/services/management.cpp Changeset: f062188117ad Author: clanger Date: 2019-03-30 21:29 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f062188117ad 8221610: Resurrect (legacy) JRE bundle target Reviewed-by: erikj, azeller ! make/Bundles.gmk ! make/Main.gmk ! make/autoconf/spec.gmk.in Changeset: 492af1f4b6d5 Author: ngasson Date: 2019-03-29 09:31 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/492af1f4b6d5 8220707: [TESTBUG] serviceability/sa/TestHeapDumpForLargeArray.java fails with jtreg -vmoption:-Xmx < 8g Reviewed-by: clanger, sballal, jcbeyler ! test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java Changeset: 4f9772f4403d Author: pmuthuswamy Date: 2019-04-01 12:44 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4f9772f4403d 8215599: Remove support for javadoc "frames" mode Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/script.js ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocPaths.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/AccessFrameTitle.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/p1/C1.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/p2/C2.java ! test/langtools/jdk/javadoc/doclet/AccessH1/AccessH1.java ! test/langtools/jdk/javadoc/doclet/AccessSummary/AccessSummary.java ! test/langtools/jdk/javadoc/doclet/DocRootSlash/DocRootSlash.java ! test/langtools/jdk/javadoc/doclet/JavascriptWinTitle/JavascriptWinTitle.java ! test/langtools/jdk/javadoc/doclet/MetaTag/MetaTag.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/PackagesHeader.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/p1/C1.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/p2/C2.java ! test/langtools/jdk/javadoc/doclet/ValidHtml/ValidHtml.java ! test/langtools/jdk/javadoc/doclet/WindowTitles/WindowTitles.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/TestClassDocCatalog.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyAnnotation.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyClass.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyEnum.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyError.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyException.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyInterface.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyAnnotation.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyClass.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyEnum.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyError.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyException.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyInterface.java - test/langtools/jdk/javadoc/doclet/testFramesNoFrames/TestFramesNoFrames.java ! test/langtools/jdk/javadoc/doclet/testGeneratedBy/TestGeneratedBy.java ! test/langtools/jdk/javadoc/doclet/testGroupName/TestGroupName.java ! test/langtools/jdk/javadoc/doclet/testGroupOption/TestGroupOption.java ! test/langtools/jdk/javadoc/doclet/testHeadings/TestHeadings.java ! test/langtools/jdk/javadoc/doclet/testHiddenTag/TestHiddenTag.java ! test/langtools/jdk/javadoc/doclet/testHtmlLandmarkRegions/TestHtmlLandmarkRegions.java ! test/langtools/jdk/javadoc/doclet/testHtmlTableStyles/TestHtmlTableStyles.java ! test/langtools/jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testIndex/TestIndex.java ! test/langtools/jdk/javadoc/doclet/testIndexWithModules/TestIndexWithModules.java ! test/langtools/jdk/javadoc/doclet/testJavascript/TestJavascript.java ! test/langtools/jdk/javadoc/doclet/testMetadata/TestMetadata.java ! test/langtools/jdk/javadoc/doclet/testModuleDirs/TestModuleDirs.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNavigation/TestModuleNavigation.java ! test/langtools/jdk/javadoc/doclet/testNavigation/TestNavigation.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java + test/langtools/jdk/javadoc/doclet/testNoFrames/TestNoFrames.java ! test/langtools/jdk/javadoc/doclet/testOrdering/TestOrdering.java ! test/langtools/jdk/javadoc/doclet/testOverview/TestOverview.java ! test/langtools/jdk/javadoc/doclet/testPackageDeprecation/TestPackageDeprecation.java ! test/langtools/jdk/javadoc/doclet/testRecurseSubPackages/TestRecurseSubPackages.java ! test/langtools/jdk/javadoc/doclet/testRelativeLinks/TestRelativeLinks.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testSummaryTag/TestSummaryTag.java ! test/langtools/jdk/javadoc/doclet/testTopOption/TestTopOption.java ! test/langtools/jdk/javadoc/doclet/testUseOption/TestUseOption.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/TestWindowTitle.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/p1/C1.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/p2/C2.java ! test/langtools/jdk/javadoc/tool/TestScriptInComment.java Changeset: 964186594f5f Author: shade Date: 2019-04-01 10:02 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/964186594f5f 8221725: AArch64 build failures after JDK-8221408 (Windows 32bit build build errors/warnings in hotspot) Reviewed-by: dholmes, stuefe ! src/hotspot/cpu/aarch64/aarch64.ad Changeset: e0603b4537c3 Author: shade Date: 2019-04-01 10:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e0603b4537c3 8221726: Multiple build failures after JDK-8221698 (Remove redundant includes from popular header files) Reviewed-by: dholmes, stuefe, iklam ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp ! src/hotspot/share/classfile/systemDictionary.hpp Changeset: dfaa9daab43c Author: shade Date: 2019-04-01 13:33 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dfaa9daab43c 8221735: Shenandoah fails ctw/modules/jdk_management_agent.java with Traversal Reviewed-by: rkennke, roland ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Changeset: 80830caaac6e Author: gadams Date: 2019-04-01 07:34 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/80830caaac6e 8221694: jstatLineCounts1 needs to be NaN resilient Reviewed-by: cjplummer, jcbeyler ! test/jdk/sun/tools/jstat/lineCounts1.awk ! test/jdk/sun/tools/jstat/lineCounts2.awk Changeset: f226ab0b7f21 Author: coleenp Date: 2019-04-01 09:53 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f226ab0b7f21 8221183: Avoid code cache walk in MetadataOnStackMark Summary: Note nmethods with "old" Methods in them in table to walk instead. Reviewed-by: eosterlund, sspitsyn ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/classfile/metadataOnStackMark.cpp ! src/hotspot/share/classfile/metadataOnStackMark.hpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp Changeset: 62e87f00e420 Author: rkennke Date: 2019-04-01 16:30 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/62e87f00e420 8221750: Shenandoah: Enable ThreadLocalHandshake by default Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Changeset: a8564226f446 Author: hannesw Date: 2019-04-01 16:49 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a8564226f446 8219733: Restore javadoc header styles Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css Changeset: 72b637d53318 Author: hannesw Date: 2019-04-01 16:51 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/72b637d53318 8221366: Search box tries to search for "Search" Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java Changeset: 3d8934bf505a Author: naoto Date: 2019-04-01 08:19 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3d8934bf505a 8205432: Replace the placeholder Japanese era name Reviewed-by: rriggs, chegar ! make/data/cldr/common/main/ja.xml ! make/data/cldr/common/main/root.xml ! make/data/unicodedata/UnicodeData.txt ! src/java.base/share/classes/java/time/chrono/JapaneseEra.java ! src/java.base/share/classes/java/util/JapaneseImperialCalendar.java ! src/java.base/share/classes/sun/text/resources/FormatData.java ! src/java.base/share/classes/sun/text/resources/JavaTimeSupplementary.java ! src/java.base/share/classes/sun/util/calendar/Era.java ! src/java.base/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! src/java.base/share/classes/sun/util/locale/provider/CalendarNameProviderImpl.java ! src/jdk.localedata/share/classes/sun/text/resources/ext/FormatData_ja.java ! src/jdk.localedata/share/classes/sun/text/resources/ext/JavaTimeSupplementary_ja.java ! test/jdk/java/lang/Character/UnicodeData.txt ! test/jdk/java/text/Format/DateFormat/WeekDateTest.java ! test/jdk/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/jdk/java/time/tck/java/time/chrono/TCKJapaneseEra.java ! test/jdk/java/time/test/java/time/chrono/TestJapaneseChronology.java ! test/jdk/java/time/test/java/time/chrono/TestUmmAlQuraChronology.java ! test/jdk/java/time/test/java/time/format/TestNonIsoFormatter.java ! test/jdk/java/util/Calendar/CalendarTestScripts/CalendarAdapter.java ! test/jdk/java/util/Calendar/CalendarTestScripts/Symbol.java ! test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese.cts ! test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_add.cts ! test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_minmax.cts ! test/jdk/java/util/Calendar/CalendarTestScripts/japanese/japanese_roll.cts ! test/jdk/java/util/Calendar/JapaneseEraNameTest.java ! test/jdk/java/util/Calendar/JapaneseLenientEraTest.java ! test/jdk/java/util/Calendar/NarrowNamesTest.java ! test/jdk/java/util/Calendar/ZoneOffsets.java Changeset: 6a4abdb6749c Author: naoto Date: 2019-04-01 08:21 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6a4abdb6749c 8174268: Declare a public field in JapaneseEra for the era starting May 2019 Reviewed-by: rriggs, chegar ! src/java.base/share/classes/java/time/chrono/JapaneseChronology.java ! src/java.base/share/classes/java/time/chrono/JapaneseEra.java ! src/java.base/share/classes/java/util/spi/CalendarNameProvider.java ! test/jdk/java/time/tck/java/time/chrono/TCKJapaneseChronology.java ! test/jdk/java/time/tck/java/time/chrono/TCKJapaneseEra.java ! test/jdk/java/time/test/java/time/chrono/TestEraDisplayName.java ! test/jdk/java/time/test/java/time/chrono/TestJapaneseChronology.java Changeset: 879051d3772a Author: stefank Date: 2019-04-01 18:34 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/879051d3772a 8220610: Make CollectedHeap nmethod functions pure virtual Reviewed-by: shade ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp Changeset: 313e034d0bcb Author: stefank Date: 2019-04-01 18:34 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/313e034d0bcb 8221146: ZGC: Reports too much relocated Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/z/zRelocationSetSelector.cpp Changeset: f60c52198a42 Author: stefank Date: 2019-04-01 18:36 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f60c52198a42 8221149: os::malloc checks MallocCatchPtr outside of ifdef ASSERT block Reviewed-by: stuefe, dholmes ! src/hotspot/share/runtime/os.cpp Changeset: baf213e62aeb Author: stefank Date: 2019-04-01 18:36 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/baf213e62aeb 8221558: Remove obsolete uses of OopStorage::ParState<'false, false> _par_state Reviewed-by: pliden, tschatzl ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/cms/parNewGeneration.cpp ! src/hotspot/share/gc/cms/parNewGeneration.hpp ! src/hotspot/share/gc/g1/g1RootProcessor.cpp ! src/hotspot/share/gc/g1/g1RootProcessor.hpp Changeset: dd5c64326027 Author: erikj Date: 2019-04-01 11:02 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dd5c64326027 8221703: Rmic build for java.management.api has bad incremental behavior Reviewed-by: tbell ! make/common/RMICompilation.gmk ! make/rmic/Rmic-java.management.rmi.gmk Changeset: 2b48cedce327 Author: kbarrett Date: 2019-04-01 17:11 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2b48cedce327 8220671: Initialization race for non-JavaThread PtrQueues Summary: Include on_thread_(attach|detach) under NJTList_lock. Reviewed-by: pliden, rkennke ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: e2c096943ba2 Author: ctornqvi Date: 2019-04-01 14:34 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e2c096943ba2 8212627: [TESTBUG] runtime/CreateMirror/ArraysNewInstanceBug.java timed out Reviewed-by: coleenp, dcubed, hseigel ! test/hotspot/jtreg/runtime/CreateMirror/ArraysNewInstanceBug.java Changeset: f15b5d110fbc Author: sangheki Date: 2019-04-01 14:54 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f15b5d110fbc 8221517: G1: Reserved page size for heap can be wrong Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp + test/hotspot/jtreg/gc/g1/TestLargePageUseForHeap.java Changeset: 66185e52b979 Author: bpb Date: 2019-04-01 15:59 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/66185e52b979 8218418: (fs) Files.createSymbolicLink should use SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE (win) Reviewed-by: alanb ! src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c Changeset: e057e45b49af Author: xuelei Date: 2019-04-01 16:50 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e057e45b49af 8168261: Use server cipher suites preference by default Reviewed-by: mullan ! src/java.base/share/classes/javax/net/ssl/SSLContextSpi.java ! src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java + test/jdk/sun/security/ssl/SSLContextImpl/DefaultCipherSuitePreference.java Changeset: 72e44c1e7dc6 Author: aoqi Date: 2019-04-02 00:23 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/72e44c1e7dc6 8221763: Build fails when using --with-jvm-features=-g1gc,-jfr,-shenandoahgc Summary: Add missing #include of softRefPolicy.hpp Reviewed-by: kbarrett ! src/hotspot/share/memory/metaspaceShared.cpp Changeset: 9ac5d41abf68 Author: weijun Date: 2019-04-02 10:17 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9ac5d41abf68 8157404: Unable to read certain PKCS12 keystores from SequenceInputStream Reviewed-by: xuelei ! src/java.base/share/classes/sun/security/util/DerIndefLenConverter.java ! src/java.base/share/classes/sun/security/util/DerInputStream.java ! src/java.base/share/classes/sun/security/util/DerValue.java Changeset: 13935056b05e Author: weijun Date: 2019-04-02 11:05 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/13935056b05e 8221801: Update src/java.base/share/legal/public_suffix.md Reviewed-by: xuelei ! src/java.base/share/legal/public_suffix.md + test/jdk/sun/security/util/RegisteredDomain/Versions.java Changeset: 22eb1f7416f1 Author: mbaesken Date: 2019-03-27 10:25 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/22eb1f7416f1 8221541: clean up functions in CompilerOracle Reviewed-by: mdoerr, kvn ! src/hotspot/share/compiler/compilerOracle.cpp ! src/hotspot/share/compiler/compilerOracle.hpp Changeset: a5ce9300462f Author: pliden Date: 2019-04-02 10:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a5ce9300462f 8221648: Remove CollectedHeap::is_in_closed_subset() Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1FullGCOopClosures.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/serial/serialHeap.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/jvmci/jvmciRuntime.cpp ! src/hotspot/share/memory/iterator.inline.hpp Changeset: 2a2fab6fb3a5 Author: pliden Date: 2019-04-02 10:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2a2fab6fb3a5 8221732: Introduce CollectedHeap::hash_oop() Reviewed-by: kbarrett, tschatzl, stefank ! src/hotspot/share/gc/shared/collectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/prims/jvmtiTagMap.cpp Changeset: 35794e8db61b Author: pliden Date: 2019-04-02 10:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/35794e8db61b 8221748: Remove unused oopDesc::is_unlocked_oop() Reviewed-by: kbarrett ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp Changeset: 7c576e4d0afa Author: redestad Date: 2019-04-02 11:24 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7c576e4d0afa 8221723: Avoid storing zero to String.hash Reviewed-by: shade, prappo, jiangli ! src/java.base/share/classes/java/lang/String.java ! test/micro/org/openjdk/bench/java/lang/StringHashCode.java Changeset: 40a7e2fc9beb Author: redestad Date: 2019-04-02 11:37 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/40a7e2fc9beb 8221724: Enable archiving of Strings with hash 0 Reviewed-by: jiangli, iklam ! src/hotspot/share/classfile/stringTable.cpp ! src/hotspot/share/oops/constantPool.cpp ! test/hotspot/jtreg/runtime/appcds/sharedStrings/HelloStringPlus.java ! test/hotspot/jtreg/runtime/appcds/sharedStrings/LockStringTest.java Changeset: e297c7bb6469 Author: erikj Date: 2017-10-24 10:41 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e297c7bb6469 8189861: Refactor CacheFind Reviewed-by: tbell ! make/Bundles.gmk ! make/CompileDemos.gmk ! make/CompileJavaModules.gmk ! make/CopyImportModules.gmk ! make/CreateBuildJdkCopy.gmk ! make/CreateJmods.gmk ! make/Docs.gmk ! make/Images.gmk ! make/MacBundles.gmk ! make/ZipSource.gmk ! make/common/JarArchive.gmk ! make/common/JavaCompilation.gmk ! make/common/MakeBase.gmk ! make/common/NativeCompilation.gmk ! make/common/TestFilesCompilation.gmk ! make/common/TextFileProcessing.gmk ! make/common/Utils.gmk ! make/common/ZipArchive.gmk ! make/copy/CopyCommon.gmk ! make/gensrc/Gensrc-jdk.internal.vm.compiler.gmk ! make/gensrc/Gensrc-jdk.internal.vm.compiler.management.gmk ! make/gensrc/GensrcCommonLangtools.gmk ! make/gensrc/GensrcLocaleData.gmk ! make/gensrc/GensrcProperties.gmk ! make/hotspot/lib/CompileJvm.gmk ! make/hotspot/lib/JvmOverrideFiles.gmk ! make/lib/Lib-java.base.gmk ! make/lib/Lib-java.desktop.gmk ! test/make/TestCopyFiles.gmk ! test/make/TestMakeBase.gmk ! test/make/UtilsForTests.gmk Changeset: c47660e8f5b6 Author: shade Date: 2019-04-02 17:10 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c47660e8f5b6 8221824: Build failure with MSVS 2013 after JDK-8218418 Reviewed-by: stuefe, alanb ! src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c Changeset: 61616f509ef8 Author: erikj Date: 2019-04-02 08:19 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/61616f509ef8 8221762: Improve Main.gmk/FindTests.gmk bootstrap time Reviewed-by: tbell ! make/InitSupport.gmk ! make/RunTestsPrebuilt.gmk ! make/common/FindTests.gmk Changeset: cdc3bb0983a6 Author: rkennke Date: 2019-04-02 18:13 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cdc3bb0983a6 8221751: Shenandoah: Improve SATB enqueueing Reviewed-by: shade ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp Changeset: cd3b7ad53265 Author: kvn Date: 2019-04-02 09:45 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cd3b7ad53265 8221782: [Graal] Module jdk.internal.vm.compiler.management has not been granted accessClassInPackage.jdk.vm.ci.services Reviewed-by: dlong, alanb, mullan ! src/java.base/share/lib/security/default.policy Changeset: 9559ba212c18 Author: kbarrett Date: 2019-04-02 13:08 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9559ba212c18 8221102: Allow GC threads to participate in threads claiming protocol Summary: Expand claim counter from 1bit to uintx, with rare overflow handling. Reviewed-by: tschatzl, rkennke ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/strongRootsScope.cpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/z/zRootsIterator.cpp ! src/hotspot/share/runtime/sweeper.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp + test/hotspot/gtest/runtime/test_threads.cpp Changeset: 00fc7ba000b4 Author: iignatyev Date: 2019-04-02 13:39 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/00fc7ba000b4 8221870: use driver to run CtwRunner in applications/ctw tests Reviewed-by: shade, epavlova ! test/hotspot/jtreg/applications/ctw/modules/generate.bash ! test/hotspot/jtreg/applications/ctw/modules/java_base.java ! test/hotspot/jtreg/applications/ctw/modules/java_base_2.java ! test/hotspot/jtreg/applications/ctw/modules/java_compiler.java ! test/hotspot/jtreg/applications/ctw/modules/java_datatransfer.java ! test/hotspot/jtreg/applications/ctw/modules/java_desktop.java ! test/hotspot/jtreg/applications/ctw/modules/java_desktop_2.java ! test/hotspot/jtreg/applications/ctw/modules/java_instrument.java ! test/hotspot/jtreg/applications/ctw/modules/java_logging.java ! test/hotspot/jtreg/applications/ctw/modules/java_management.java ! test/hotspot/jtreg/applications/ctw/modules/java_management_rmi.java ! test/hotspot/jtreg/applications/ctw/modules/java_naming.java + test/hotspot/jtreg/applications/ctw/modules/java_net_http.java ! test/hotspot/jtreg/applications/ctw/modules/java_prefs.java ! test/hotspot/jtreg/applications/ctw/modules/java_rmi.java ! test/hotspot/jtreg/applications/ctw/modules/java_scripting.java ! test/hotspot/jtreg/applications/ctw/modules/java_security_jgss.java ! test/hotspot/jtreg/applications/ctw/modules/java_security_sasl.java ! test/hotspot/jtreg/applications/ctw/modules/java_smartcardio.java ! test/hotspot/jtreg/applications/ctw/modules/java_sql.java ! test/hotspot/jtreg/applications/ctw/modules/java_sql_rowset.java + test/hotspot/jtreg/applications/ctw/modules/java_transaction_xa.java ! test/hotspot/jtreg/applications/ctw/modules/java_xml.java ! test/hotspot/jtreg/applications/ctw/modules/java_xml_crypto.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_accessibility.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_aot.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_attach.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_charsets.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_compiler.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_cryptoki.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_mscapi.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ucrypto.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_dynalink.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_editpad.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_hotspot_agent.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_httpserver.java - test/hotspot/jtreg/applications/ctw/modules/jdk_incubator_httpclient.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_ed.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_jvmstat.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_le.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_opt.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_vm_ci.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_vm_compiler.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_internal_vm_compiler_management.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jartool.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_javadoc.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jcmd.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jconsole.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jdeps.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jdi.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jfr.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jlink.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jshell.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jsobject.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_jstatd.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_localedata.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_management.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_management_agent.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_management_jfr.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_naming_dns.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_naming_rmi.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_net.java - test/hotspot/jtreg/applications/ctw/modules/jdk_packager.java - test/hotspot/jtreg/applications/ctw/modules/jdk_packager_services.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_rmic.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_scripting_nashorn.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_scripting_nashorn_shell.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_sctp.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_security_auth.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_security_jgss.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_unsupported.java + test/hotspot/jtreg/applications/ctw/modules/jdk_unsupported_desktop.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_xml_dom.java ! test/hotspot/jtreg/applications/ctw/modules/jdk_zipfs.java Changeset: cbde3b803d93 Author: zgu Date: 2019-04-02 16:36 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cbde3b803d93 8221875: Unquarantine Shenandoah string dedup tests Reviewed-by: rkennke ! test/hotspot/jtreg/ProblemList.txt Changeset: a1acc800c87a Author: zgu Date: 2019-03-14 09:53 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a1acc800c87a 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk Reviewed-by: rkennke, cjplummer ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/vmStructs_shenandoah.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/CollectedHeap.java + src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shenandoah/ShenandoahBitMap.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shenandoah/ShenandoahHeap.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shenandoah/ShenandoahHeapRegion.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java ! test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java Changeset: 772f62a13376 Author: lmesnik Date: 2019-04-02 17:11 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/772f62a13376 8221437: assert(java_lang_invoke_ResolvedMethodName::vmtarget(resolved_method()) == m()) failed: Should not change after link resolution Reviewed-by: coleenp, sspitsyn ! src/hotspot/share/prims/methodHandles.cpp Changeset: 3326be37cd9a Author: ronsh Date: 2019-04-02 17:27 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3326be37cd9a 8220792: Performance bottleneck in JavacFileManager.list() Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/BaseFileManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java Changeset: f9feec76a481 Author: amlu Date: 2019-04-03 13:24 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f9feec76a481 8178335: fake pass: jdk/internal/ref/Cleaner/ExitOnThrow.java Reviewed-by: mchung ! test/jdk/jdk/internal/ref/Cleaner/ExitOnThrow.java Changeset: 33ef346b1478 Author: prr Date: 2019-03-21 21:37 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/33ef346b1478 8221304: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java Reviewed-by: serb ! test/jdk/ProblemList.txt Changeset: 7de72c87766a Author: psadhukhan Date: 2019-03-22 14:39 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7de72c87766a Merge - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt ! test/jdk/ProblemList.txt Changeset: a26c1f6f9ad5 Author: serb Date: 2019-03-22 12:44 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a26c1f6f9ad5 8177960: Deprecate the Swing Motif Look and Feel and document it as unsupported on macOS Reviewed-by: psadhukhan, prr ! src/java.desktop/share/classes/com/sun/java/swing/plaf/motif/MotifLookAndFeel.java ! src/java.desktop/unix/classes/sun/awt/X11/XAWTLookAndFeel.java Changeset: 24d072f23933 Author: stuefe Date: 2019-03-26 16:53 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/24d072f23933 8221405: Fix Windows 32bit awt build Reviewed-by: clanger, aivanov ! src/java.desktop/share/native/common/awt/debug/debug_trace.c ! src/java.desktop/share/native/common/awt/debug/debug_trace.h Changeset: 6526e0a7dd99 Author: mhalder Date: 2019-03-27 12:24 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6526e0a7dd99 8216971: [macosx swing] For JCheckBoxMenuItem actionPerformed() is called twice, when apple.laf.useScreenMenuBar=true and modifier is InputEvent.META_DOWN_MASK Reviewed-by: psadhukhan, kaddepalli ! src/java.desktop/macosx/native/libawt_lwawt/awt/CMenuItem.m + test/jdk/javax/swing/JMenuItem/8216971/DoubleActionTest.java Changeset: 65030bbf5ac1 Author: psadhukhan Date: 2019-03-27 12:27 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/65030bbf5ac1 8220250: fix headings in java.desktop Reviewed-by: aivanov, jjg, serb ! src/java.desktop/share/classes/java/awt/AlphaComposite.java ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/java/awt/Font.java ! src/java.desktop/share/classes/java/awt/font/TextAttribute.java ! src/java.desktop/share/classes/java/awt/geom/AffineTransform.java ! src/java.desktop/share/classes/javax/accessibility/package-info.java ! src/java.desktop/share/classes/javax/print/DocFlavor.java ! src/java.desktop/share/classes/javax/print/attribute/package-info.java ! src/java.desktop/share/classes/javax/print/attribute/standard/package-info.java ! src/java.desktop/share/classes/javax/print/package-info.java ! src/java.desktop/share/classes/javax/swing/Action.java ! src/java.desktop/share/classes/javax/swing/GroupLayout.java ! src/java.desktop/share/classes/javax/swing/JTable.java ! src/java.desktop/share/classes/javax/swing/SizeSequence.java ! src/java.desktop/share/classes/javax/swing/SpringLayout.java ! src/java.desktop/share/classes/javax/swing/UIManager.java ! src/java.desktop/share/classes/javax/swing/plaf/metal/DefaultMetalTheme.java Changeset: 62171da145f9 Author: psadhukhan Date: 2019-03-28 13:47 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/62171da145f9 8217735: awt_image_GifImageDecoder_parseImage() "interlace" param has the wrong type Reviewed-by: psadhukhan, jdv Contributed-by: andrew_m_leonard at uk.ibm.com ! src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c Changeset: b10e1f4f8b69 Author: psadhukhan Date: 2019-03-28 13:49 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b10e1f4f8b69 8221411: NullPointerException in RasterPrinterJob without PrinterResolution Reviewed-by: prr ! src/java.desktop/share/classes/sun/print/RasterPrinterJob.java Changeset: 31c35004f300 Author: aivanov Date: 2019-03-28 14:52 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/31c35004f300 8221412: lookupPrintServices() does not always update the list of Windows remote printers Reviewed-by: prr, serb ! src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java ! src/java.desktop/windows/native/libawt/windows/WPrinterJob.cpp Changeset: 3a217bbdd3a2 Author: aivanov Date: 2019-03-28 18:51 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/3a217bbdd3a2 8217707: JNICALL declaration breaks Splash screen functions Reviewed-by: prr, stuefe ! src/java.desktop/share/native/libsplashscreen/splashscreen_impl.c ! src/java.desktop/share/native/libsplashscreen/splashscreen_impl.h ! src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c ! src/java.desktop/windows/native/libsplashscreen/splashscreen_sys.c Changeset: 35975113d5d8 Author: psadhukhan Date: 2019-03-29 10:11 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/35975113d5d8 8212904: JTextArea line wrapping incorrect when using UI scale Reviewed-by: serb, prr ! src/java.desktop/share/classes/javax/swing/text/Utilities.java ! src/java.desktop/share/classes/javax/swing/text/WrappedPlainView.java + test/jdk/javax/swing/JTextArea/JTextAreaWordWrapTest.java Changeset: d5b11b78ed62 Author: dcherepanov Date: 2019-03-27 13:14 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d5b11b78ed62 8221244: Unexpected behavior of PropertyDescription.getReadMethod for boolean properties Reviewed-by: serb ! src/java.desktop/share/classes/com/sun/beans/introspect/PropertyInfo.java + test/jdk/java/beans/Introspector/Test8221244.java Changeset: 9727e63dff13 Author: serb Date: 2019-03-29 16:09 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9727e63dff13 8215105: java/awt/Robot/HiDPIScreenCapture/ScreenCaptureTest.java: Wrong Pixel Color Reviewed-by: prr ! src/java.desktop/macosx/native/libawt_lwawt/awt/CRobot.m + test/jdk/java/awt/Robot/CheckCommonColors/CheckCommonColors.java Changeset: 93b37d7435e8 Author: serb Date: 2019-03-29 17:46 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/93b37d7435e8 8220320: Remove unused old code in GraphicsEnvironment on unix Reviewed-by: prr ! src/java.desktop/unix/classes/sun/awt/X11GraphicsDevice.java ! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c Changeset: 080937e6e85c Author: serb Date: 2019-03-29 23:14 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/080937e6e85c 8221436: Incorrect check of package in Line.Info.toString() Reviewed-by: prr ! src/java.desktop/share/classes/javax/sound/sampled/Line.java + test/jdk/javax/sound/sampled/Lines/ToString.java Changeset: 901ff5aba330 Author: serb Date: 2019-03-31 16:57 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/901ff5aba330 8220495: Update GIFlib library to the 5.1.8 Reviewed-by: prr ! src/java.desktop/share/legal/giflib.md ! src/java.desktop/share/native/libsplashscreen/giflib/dgif_lib.c ! src/java.desktop/share/native/libsplashscreen/giflib/gif_hash.h ! src/java.desktop/share/native/libsplashscreen/giflib/gif_lib.h ! src/java.desktop/share/native/libsplashscreen/giflib/gif_lib_private.h ! src/java.desktop/share/native/libsplashscreen/giflib/gifalloc.c ! src/java.desktop/share/native/libsplashscreen/giflib/openbsd-reallocarray.c Changeset: 8fe16bf92ebd Author: psadhukhan Date: 2019-04-02 10:55 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8fe16bf92ebd 8221731: Fix doclint handling of accessibility heading in java.desktop Reviewed-by: erikj ! make/CompileJavaModules.gmk Changeset: 94986cf5e969 Author: psadhukhan Date: 2019-04-02 10:57 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/94986cf5e969 Merge ! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sun/security/ssl/rsa/BrokenRSAPrivateCrtKey.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/AccessFrameTitle.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/p1/C1.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/p2/C2.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/PackagesHeader.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/p1/C1.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/p2/C2.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/TestClassDocCatalog.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyAnnotation.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyClass.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyEnum.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyError.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyException.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyInterface.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyAnnotation.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyClass.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyEnum.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyError.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyException.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyInterface.java - test/langtools/jdk/javadoc/doclet/testFramesNoFrames/TestFramesNoFrames.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/TestWindowTitle.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/p1/C1.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/p2/C2.java Changeset: 7feb5e303c83 Author: psadhukhan Date: 2019-04-03 13:30 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7feb5e303c83 Merge ! make/CompileJavaModules.gmk - test/hotspot/jtreg/applications/ctw/modules/jdk_incubator_httpclient.java - test/hotspot/jtreg/applications/ctw/modules/jdk_packager.java - test/hotspot/jtreg/applications/ctw/modules/jdk_packager_services.java Changeset: 1ad7f5bcc670 Author: lucy Date: 2019-04-03 16:55 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1ad7f5bcc670 8221482: Initialize VMRegImpl::regName[] earlier to prevent assert during PrintStubCode Reviewed-by: kvn ! src/hotspot/share/runtime/init.cpp Changeset: 41356f083e93 Author: redestad Date: 2019-04-03 17:06 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/41356f083e93 8221701: Archive constant BaseLocales Reviewed-by: naoto ! src/hotspot/share/memory/heapShared.cpp ! src/java.base/share/classes/java/util/Locale.java ! src/java.base/share/classes/sun/util/locale/BaseLocale.java ! src/java.base/share/classes/sun/util/locale/LocaleUtils.java ! src/java.base/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java Changeset: 30067047ed88 Author: lancea Date: 2019-04-03 11:30 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/30067047ed88 8216539: tools/jar/modularJar/Basic.java times out Reviewed-by: mchung, alanb, bchristi, bpb ! test/jdk/tools/jar/modularJar/Basic.java Changeset: f855ec13aa25 Author: rkennke Date: 2019-03-27 22:25 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f855ec13aa25 8220664: Simplify ShenandoahUpdateHeapRefsClosure Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp ! src/hotspot/share/gc/shenandoah/shenandoahOopClosures.inline.hpp Changeset: 00fda51e28cf Author: erikj Date: 2019-04-03 12:52 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/00fda51e28cf 8221764: Reduce make Init.gmk logging overhead Reviewed-by: tbell ! make/Init.gmk ! make/InitSupport.gmk Changeset: b788c494aa46 Author: dholmes Date: 2019-04-03 22:03 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b788c494aa46 8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5" Reviewed-by: dcubed, stuefe ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! test/hotspot/gtest/threadHelper.inline.hpp Changeset: f87041131515 Author: xuelei Date: 2019-04-03 16:23 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f87041131515 8217610: TLSv1.3 fail with ClassException when EC keys are stored in PKCS11 Reviewed-by: valeriep ! src/java.base/share/classes/sun/security/ssl/CertificateVerify.java ! src/java.base/share/classes/sun/security/ssl/DHServerKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/ECDHClientKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/ECDHServerKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/SignatureScheme.java ! src/java.base/share/classes/sun/security/ssl/X509Authentication.java Changeset: e998c9effb37 Author: jwilhelm Date: 2019-04-04 01:46 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e998c9effb37 Added tag jdk-13+15 for changeset f855ec13aa25 ! .hgtags Changeset: 5c7418757bad Author: coleenp Date: 2019-04-03 20:39 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5c7418757bad 8221872: Remove uses of ClassLoaderWeakHandle typedef in protection domain table Summary: Make consistent with StringTable and ResolvedMethodTable Reviewed-by: dholmes ! src/hotspot/share/classfile/protectionDomainCache.cpp ! src/hotspot/share/classfile/protectionDomainCache.hpp ! src/hotspot/share/utilities/hashtable.cpp Changeset: 23d1dd45a1c5 Author: dsimms Date: 2019-04-04 16:52 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/23d1dd45a1c5 Merge ! .hgtags ! make/CompileJavaModules.gmk ! make/Docs.gmk ! make/Images.gmk ! make/conf/jib-profiles.js ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/ci/ciEnv.hpp ! src/hotspot/share/ci/ciObject.hpp ! src/hotspot/share/ci/ciObjectFactory.cpp ! src/hotspot/share/ci/ciObjectFactory.hpp ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/stackMapFrame.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/hotspot/share/memory/heapShared.cpp ! src/hotspot/share/memory/iterator.hpp ! src/hotspot/share/memory/iterator.inline.hpp ! src/hotspot/share/memory/oopFactory.cpp ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/markOop.hpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/opto/callnode.cpp ! src/hotspot/share/opto/callnode.hpp ! src/hotspot/share/opto/castnode.cpp ! src/hotspot/share/opto/castnode.hpp ! src/hotspot/share/opto/cfgnode.cpp ! src/hotspot/share/opto/cfgnode.hpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/locknode.cpp ! src/hotspot/share/opto/machnode.cpp ! src/hotspot/share/opto/machnode.hpp ! src/hotspot/share/opto/matcher.cpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/memnode.hpp ! src/hotspot/share/opto/multnode.cpp ! src/hotspot/share/opto/multnode.hpp ! src/hotspot/share/opto/node.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/subnode.cpp ! src/hotspot/share/opto/subnode.hpp ! src/hotspot/share/opto/type.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvmtiExport.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/VarHandle.java ! src/java.base/share/classes/java/lang/reflect/Proxy.java - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh ! src/jdk.compiler/share/classes/com/sun/tools/doclint/Checker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/TEST.groups - test/hotspot/jtreg/applications/ctw/modules/jdk_incubator_httpclient.java - test/hotspot/jtreg/applications/ctw/modules/jdk_packager.java - test/hotspot/jtreg/applications/ctw/modules/jdk_packager_services.java - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf ! test/jdk/ProblemList.txt ! test/jdk/TEST.groups - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/sun/security/ssl/rsa/BrokenRSAPrivateCrtKey.java - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/AccessFrameTitle.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/p1/C1.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/p2/C2.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/PackagesHeader.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/p1/C1.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/p2/C2.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/TestClassDocCatalog.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyAnnotation.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyClass.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyEnum.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyError.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyException.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyInterface.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyAnnotation.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyClass.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyEnum.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyError.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyException.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyInterface.java - test/langtools/jdk/javadoc/doclet/testFramesNoFrames/TestFramesNoFrames.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/TestWindowTitle.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/p1/C1.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/p2/C2.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From david.simms at oracle.com Fri Apr 5 10:21:29 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 5 Apr 2019 12:21:29 +0200 Subject: CFV: New Valhalla Committer: Chris Hegarty Message-ID: I hereby nominate Chris Hegarty (chegar) to Valhalla Committer. Chris is actively working on JDK core library projects Votes are due by 2019-04-19 1030Z. Only current Valhalla Committers [1] are eligible to vote on this nomination.? Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. David Simms (dsimms) [1] http://openjdk.java.net/census#valhalla [2] http://openjdk.java.net/projects/#committer-vote From david.simms at oracle.com Fri Apr 5 10:21:50 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 5 Apr 2019 12:21:50 +0200 Subject: CFV: New Valhalla Committer: Roger Riggs Message-ID: I hereby nominate Roger Riggs (rriggs) to Valhalla Committer. Roger is actively working on JDK core library projects Votes are due by 2019-04-19 1030Z. Only current Valhalla Committers [1] are eligible to vote on this nomination.? Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. David Simms (dsimms) [1] http://openjdk.java.net/census#valhalla [2] http://openjdk.java.net/projects/#committer-vote From tobias.hartmann at oracle.com Fri Apr 5 10:30:15 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 5 Apr 2019 12:30:15 +0200 Subject: CFV: New Valhalla Committer: Chris Hegarty In-Reply-To: References: Message-ID: <34e83fec-997a-59bf-2918-7eef6e120ecb@oracle.com> Vote: yes Best regards, Tobias On 05.04.19 12:21, David Simms wrote: > I hereby nominate Chris Hegarty (chegar) to Valhalla Committer. > > Chris is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From tobias.hartmann at oracle.com Fri Apr 5 10:30:08 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 5 Apr 2019 12:30:08 +0200 Subject: CFV: New Valhalla Committer: Roger Riggs In-Reply-To: References: Message-ID: Vote: yes Best regards, Tobias On 05.04.19 12:21, David Simms wrote: > I hereby nominate Roger Riggs (rriggs) to Valhalla Committer. > > Roger is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From fweimer at redhat.com Fri Apr 5 11:34:15 2019 From: fweimer at redhat.com (Florian Weimer) Date: Fri, 05 Apr 2019 13:34:15 +0200 Subject: Substitutability, was Re: Finding the spirit of L-World In-Reply-To: (Stephen Colebourne's message of "Sat, 23 Feb 2019 16:57:50 +0000") References: <1c4374be-99ea-850b-1a1c-3535e0b440fb@oracle.com> <4259E8F8-DD5A-4FB2-98B1-3372479CC2F6@oracle.com> <8f543923-a98d-1c19-8e15-02152eb88ce2@oracle.com> <9f2470af-570b-a9d6-1d89-4c7fcdd84ff7@oracle.com> Message-ID: <87r2ag1ya0.fsf@oldenburg2.str.redhat.com> * Stephen Colebourne: > PS. How bad would it really be to change NaN == NaN to be true? > Wouldn't any breakages be pretty minor? There's more than one NaN, so it would still be magical. x != x for checking for NaN is also quite widespread. Thanks, Florian From karen.kinnear at oracle.com Fri Apr 5 13:58:41 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Fri, 5 Apr 2019 09:58:41 -0400 Subject: CFV: New Valhalla Committer: Chris Hegarty In-Reply-To: References: Message-ID: <32D9E78B-8432-43A9-9B22-396B45A31334@oracle.com> Vote: yes thanks, Karen > On Apr 5, 2019, at 6:21 AM, David Simms wrote: > > I hereby nominate Chris Hegarty (chegar) to Valhalla Committer. > > Chris is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From brian.goetz at oracle.com Fri Apr 5 14:05:27 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 5 Apr 2019 10:05:27 -0400 Subject: CFV: New Valhalla Committer: Chris Hegarty In-Reply-To: References: Message-ID: <82EA750E-AC3C-44FE-8280-218F5CDEEA5A@oracle.com> Vote: yes > On Apr 5, 2019, at 6:21 AM, David Simms wrote: > > I hereby nominate Chris Hegarty (chegar) to Valhalla Committer. > > Chris is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From ioi.lam at oracle.com Fri Apr 5 14:32:53 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Fri, 5 Apr 2019 07:32:53 -0700 Subject: RFR 8221879 [lworld] Calling convention - Interpreter to C1 In-Reply-To: References: <26c798bd-33f8-1c95-db72-7a0e1046df60@oracle.com> Message-ID: On 4/3/19 4:29 AM, Tobias Hartmann wrote: > Hi Ioi, > > On 03.04.19 00:20, Ioi Lam wrote: >> http://cr.openjdk.java.net/~iklam/valhalla/8221879-interp-to-c1.v01/ >> https://bugs.openjdk.java.net/browse/JDK-8221879 >> >> Change the i2c adapter to always go through Method::_from_compiled_value_entry. >> Removed the StressValueTypePassFieldsAsArgs that's no longer used. >> Added test cases. > This looks good to me. > >> Question for sharedRuntime_x86_64.cpp: >> >> Should I revert the changes related to gen_i2c_adapter_helper (i.e., move the body >> of this function back into SharedRuntime::gen_i2c_adapter), to minimize the delta >> between the jdk/jdk repo and valhalla? > Yes, please. (Sorry for the later reply .... I forgot the hit the "send" button) Hi Tobias, Thanks for the review. I've reverted the gen_i2c_adapter to mostly this version (the parent of the "import changes from mvt/hotspot" changese) and pushed. http://hg.openjdk.java.net/valhalla/valhalla/file/71c04702a3d5/src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp#l820 Thanks - Ioi > Thanks, > Tobias From karen.kinnear at oracle.com Fri Apr 5 15:35:04 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Fri, 5 Apr 2019 11:35:04 -0400 Subject: CFV: New Valhalla Committer: Roger Riggs In-Reply-To: References: Message-ID: Vote: yes thanks, Karen > On Apr 5, 2019, at 6:21 AM, David Simms wrote: > > I hereby nominate Roger Riggs (rriggs) to Valhalla Committer. > > Roger is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From lois.foltan at oracle.com Fri Apr 5 17:07:20 2019 From: lois.foltan at oracle.com (Lois Foltan) Date: Fri, 5 Apr 2019 13:07:20 -0400 Subject: CFV: New Valhalla Committer: Roger Riggs In-Reply-To: References: Message-ID: Vote: yes thanks, Lois On 4/5/2019 6:21 AM, David Simms wrote: > I hereby nominate Roger Riggs (rriggs) to Valhalla Committer. > > Roger is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From lois.foltan at oracle.com Fri Apr 5 17:07:00 2019 From: lois.foltan at oracle.com (Lois Foltan) Date: Fri, 5 Apr 2019 13:07:00 -0400 Subject: CFV: New Valhalla Committer: Chris Hegarty In-Reply-To: References: Message-ID: Vote: yes thanks, Lois On 4/5/2019 6:21 AM, David Simms wrote: > I hereby nominate Chris Hegarty (chegar) to Valhalla Committer. > > Chris is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From brian.goetz at oracle.com Fri Apr 5 22:04:29 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 5 Apr 2019 18:04:29 -0400 Subject: CFV: New Valhalla Committer: Roger Riggs In-Reply-To: References: Message-ID: <17638087-dfa1-b62f-1300-7e8efe1ba63c@oracle.com> Vote: yes On 4/5/2019 6:21 AM, David Simms wrote: > I hereby nominate Roger Riggs (rriggs) to Valhalla Committer. > > Roger is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination.? Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From frederic.parain at oracle.com Sat Apr 6 00:39:18 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Fri, 5 Apr 2019 20:39:18 -0400 Subject: CFV: New Valhalla Committer: Roger Riggs In-Reply-To: References: Message-ID: <7356491A-A5AE-4B53-9D5E-134B72D0D343@oracle.com> Vote: yes Fred > On Apr 5, 2019, at 06:21, David Simms wrote: > > I hereby nominate Roger Riggs (rriggs) to Valhalla Committer. > > Roger is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From frederic.parain at oracle.com Sat Apr 6 00:38:58 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Fri, 5 Apr 2019 20:38:58 -0400 Subject: CFV: New Valhalla Committer: Chris Hegarty In-Reply-To: References: Message-ID: <300EAD37-AD0E-49D4-B88F-7DD95C26D82A@oracle.com> Vote: yes Fred > On Apr 5, 2019, at 06:21, David Simms wrote: > > I hereby nominate Chris Hegarty (chegar) to Valhalla Committer. > > Chris is actively working on JDK core library projects > > Votes are due by 2019-04-19 1030Z. > > Only current Valhalla Committers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > David Simms (dsimms) > > [1] http://openjdk.java.net/census#valhalla > [2] http://openjdk.java.net/projects/#committer-vote > From vladimir.x.ivanov at oracle.com Sat Apr 6 00:50:50 2019 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Fri, 5 Apr 2019 17:50:50 -0700 Subject: CFV: New Valhalla Committer: Chris Hegarty In-Reply-To: References: Message-ID: <7c2c0e62-1e76-c47f-d397-cabc58f05171@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 05/04/2019 03:21, David Simms wrote: > I hereby nominate Chris Hegarty (chegar) to Valhalla Committer. From vladimir.x.ivanov at oracle.com Sat Apr 6 00:51:02 2019 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Fri, 5 Apr 2019 17:51:02 -0700 Subject: CFV: New Valhalla Committer: Roger Riggs In-Reply-To: References: Message-ID: Vote: yes Best regards, Vladimir Ivanov On 05/04/2019 03:21, David Simms wrote: > I hereby nominate Roger Riggs (rriggs) to Valhalla Committer. From mandy.chung at oracle.com Sat Apr 6 06:51:48 2019 From: mandy.chung at oracle.com (Mandy Chung) Date: Sat, 6 Apr 2019 14:51:48 +0800 Subject: CFV: New Valhalla Committer: Roger Riggs In-Reply-To: References: Message-ID: <6fd6ab10-a8d7-bd05-1a7b-ce2f304a5bf0@oracle.com> Vote: yes Mandy From mandy.chung at oracle.com Sat Apr 6 06:52:03 2019 From: mandy.chung at oracle.com (Mandy Chung) Date: Sat, 6 Apr 2019 14:52:03 +0800 Subject: CFV: New Valhalla Committer: Chris Hegarty In-Reply-To: References: Message-ID: <070f11f6-3364-791b-96f6-6ce2a46949ab@oracle.com> Vote: yes Mandy From srikanth.adayapalam at oracle.com Mon Apr 8 10:43:43 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Mon, 08 Apr 2019 10:43:43 +0000 Subject: hg: valhalla/valhalla: 8222110: [lworld] Javac should tolerate value membership cycles under an option. Message-ID: <201904081043.x38Ahh2g016707@aojmv0008.oracle.com> Changeset: 5b539415f09f Author: sadayapalam Date: 2019-04-08 16:13 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5b539415f09f 8222110: [lworld] Javac should tolerate value membership cycles under an option. ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! test/langtools/tools/javac/valhalla/lworld-values/CheckCyclicMembership.java ! test/langtools/tools/javac/valhalla/lworld-values/CheckFlattenableCycles.java From srikanth.adayapalam at oracle.com Mon Apr 8 12:56:56 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Mon, 08 Apr 2019 12:56:56 +0000 Subject: hg: valhalla/valhalla: 8221699: [lworld] Implement temporary alternative IDE-compatible annotation for "value" keyword Message-ID: <201904081256.x38CuvMJ007833@aojmv0008.oracle.com> Changeset: d70134da3046 Author: sadayapalam Date: 2019-04-08 18:26 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d70134da3046 8221699: [lworld] Implement temporary alternative IDE-compatible annotation for "value" keyword + src/java.base/share/classes/java/lang/__value__.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java ! test/langtools/tools/javac/diags/CheckResourceKeys.java + test/langtools/tools/javac/valhalla/lworld-values/ValueAnnotationTest.java + test/langtools/tools/javac/valhalla/lworld-values/ValueAnnotationTest.out From forax at univ-mlv.fr Mon Apr 8 22:52:50 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Tue, 9 Apr 2019 00:52:50 +0200 (CEST) Subject: hg: valhalla/valhalla: 8221699: [lworld] Implement temporary alternative IDE-compatible annotation for "value" keyword In-Reply-To: <201904081256.x38CuvMJ007833@aojmv0008.oracle.com> References: <201904081256.x38CuvMJ007833@aojmv0008.oracle.com> Message-ID: <1301928485.349699.1554763970058.JavaMail.zimbra@u-pem.fr> Hi Srikanth, that's great ! may i ask for the the support of anonymous value class by adding the target ElementType.TYPE_USE, new @__value__ AnInterface() { ... } cheers, R?mi ----- Mail original ----- > De: "Srikanth" > ?: "valhalla-dev" > Envoy?: Lundi 8 Avril 2019 14:56:56 > Objet: hg: valhalla/valhalla: 8221699: [lworld] Implement temporary alternative IDE-compatible annotation for "value" > keyword > Changeset: d70134da3046 > Author: sadayapalam > Date: 2019-04-08 18:26 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d70134da3046 > > 8221699: [lworld] Implement temporary alternative IDE-compatible annotation for > "value" keyword > > + src/java.base/share/classes/java/lang/__value__.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java > ! test/langtools/tools/javac/diags/CheckResourceKeys.java > + test/langtools/tools/javac/valhalla/lworld-values/ValueAnnotationTest.java > + test/langtools/tools/javac/valhalla/lworld-values/ValueAnnotationTest.out From tobias.hartmann at oracle.com Tue Apr 9 08:14:37 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 9 Apr 2019 10:14:37 +0200 Subject: RFR(S): 8222128: [lworld] Assertion failure in ci with flattenable non-flattened field inside a flattened field Message-ID: Hi, please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8222128 http://cr.openjdk.java.net/~thartmann/8222128/webrev.00/ The assert is too strong. Fields inside a flattened field can be non-flattened but flattenable. Thanks to Fred for reporting. Thanks, Tobias From david.simms at oracle.com Tue Apr 9 08:50:55 2019 From: david.simms at oracle.com (David Simms) Date: Tue, 9 Apr 2019 10:50:55 +0200 Subject: RFR(S): 8222128: [lworld] Assertion failure in ci with flattenable non-flattened field inside a flattened field In-Reply-To: References: Message-ID: <0209a054-de3b-becc-c61e-2fc377786477@oracle.com> Looks good ! On 9/04/19 10:14 AM, Tobias Hartmann wrote: > Hi, > > please review the following patch: > https://bugs.openjdk.java.net/browse/JDK-8222128 > http://cr.openjdk.java.net/~thartmann/8222128/webrev.00/ > > The assert is too strong. Fields inside a flattened field can be non-flattened but flattenable. > > Thanks to Fred for reporting. > > Thanks, > Tobias From tobias.hartmann at oracle.com Tue Apr 9 09:04:02 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 9 Apr 2019 11:04:02 +0200 Subject: RFR(S): 8222128: [lworld] Assertion failure in ci with flattenable non-flattened field inside a flattened field In-Reply-To: <0209a054-de3b-becc-c61e-2fc377786477@oracle.com> References: <0209a054-de3b-becc-c61e-2fc377786477@oracle.com> Message-ID: <711eaebc-7041-fdc4-c3a8-6148e798abd1@oracle.com> Thanks for the review! Best regards, Tobias On 09.04.19 10:50, David Simms wrote: > > Looks good ! > > On 9/04/19 10:14 AM, Tobias Hartmann wrote: >> Hi, >> >> please review the following patch: >> https://bugs.openjdk.java.net/browse/JDK-8222128 >> http://cr.openjdk.java.net/~thartmann/8222128/webrev.00/ >> >> The assert is too strong. Fields inside a flattened field can be non-flattened but flattenable. >> >> Thanks to Fred for reporting. >> >> Thanks, >> Tobias > > From rwestrel at redhat.com Tue Apr 9 12:58:47 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Tue, 09 Apr 2019 14:58:47 +0200 Subject: RFR(S): 8222128: [lworld] Assertion failure in ci with flattenable non-flattened field inside a flattened field In-Reply-To: References: Message-ID: <8736mrqqrc.fsf@redhat.com> > http://cr.openjdk.java.net/~thartmann/8222128/webrev.00/ Looks good to me. Roland. From tobias.hartmann at oracle.com Tue Apr 9 13:03:06 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 9 Apr 2019 15:03:06 +0200 Subject: RFR(S): 8222128: [lworld] Assertion failure in ci with flattenable non-flattened field inside a flattened field In-Reply-To: <8736mrqqrc.fsf@redhat.com> References: <8736mrqqrc.fsf@redhat.com> Message-ID: <0c893920-f151-aa6b-1e53-f6af7f5597ad@oracle.com> Thanks, Roland. Best regards, Tobias On 09.04.19 14:58, Roland Westrelin wrote: > >> http://cr.openjdk.java.net/~thartmann/8222128/webrev.00/ > > Looks good to me. > > Roland. > From tobias.hartmann at oracle.com Tue Apr 9 13:05:17 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Tue, 09 Apr 2019 13:05:17 +0000 Subject: hg: valhalla/valhalla: 8222128: [lworld] Assertion failure in ci with flattenable non-flattened field inside a flattened field Message-ID: <201904091305.x39D5I5B016807@aojmv0008.oracle.com> Changeset: 0f73fc512bea Author: thartmann Date: 2019-04-09 15:04 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0f73fc512bea 8222128: [lworld] Assertion failure in ci with flattenable non-flattened field inside a flattened field Reviewed-by: roland, dsimms ! src/hotspot/share/ci/ciField.cpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java From srikanth.adayapalam at oracle.com Wed Apr 10 05:45:27 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Wed, 10 Apr 2019 05:45:27 +0000 Subject: hg: valhalla/valhalla: 8221699: [lworld] Additional changes to implement temporary alternative IDE-compatible annotation for "value" keyword Message-ID: <201904100545.x3A5jSMW017953@aojmv0008.oracle.com> Changeset: 0156e87c95fe Author: sadayapalam Date: 2019-04-10 11:15 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0156e87c95fe 8221699: [lworld] Additional changes to implement temporary alternative IDE-compatible annotation for "value" keyword ! src/java.base/share/classes/java/lang/__value__.java + test/langtools/tools/javac/valhalla/lworld-values/ValueAnnotationOnAnonymousClass.java + test/langtools/tools/javac/valhalla/lworld-values/ValueAnnotationOnAnonymousClass.out From srikanth.adayapalam at oracle.com Wed Apr 10 05:51:45 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Wed, 10 Apr 2019 11:21:45 +0530 Subject: hg: valhalla/valhalla: 8221699: [lworld] Implement temporary alternative IDE-compatible annotation for "value" keyword In-Reply-To: <1301928485.349699.1554763970058.JavaMail.zimbra@u-pem.fr> References: <201904081256.x38CuvMJ007833@aojmv0008.oracle.com> <1301928485.349699.1554763970058.JavaMail.zimbra@u-pem.fr> Message-ID: <6f96b400-f999-bd50-7cd4-69c874734266@oracle.com> On 09/04/19 4:22 AM, Remi Forax wrote: > Hi Srikanth, > that's great ! > > may i ask for the the support of anonymous value class by adding the target ElementType.TYPE_USE, > new @__value__ AnInterface() { > ... > } Hi Remi, Thanks for the note. I'll sheepishly admit that given the? temporary nature of this annotation support, in order to minimize changes I was opting for a slightly hackish solution that mutates the @__vaue__ annotation into the value modifier keyword during parsing itself. The various value semantic checks are scattered all over the place and annotations get processed slightly late in the normal scheme of things - which would meant that I move all those checks to post annotation processing - a complex and messy change. The effect of this implementation choice was that the code you cited would already compile and the anonymous class would have been marked as a value class - but the present push also makes the @__value__ annotation target TYPE_USE making it internally consistent FWIW. Thanks! Srikanth > cheers, > R?mi > > ----- Mail original ----- >> De: "Srikanth" >> ?: "valhalla-dev" >> Envoy?: Lundi 8 Avril 2019 14:56:56 >> Objet: hg: valhalla/valhalla: 8221699: [lworld] Implement temporary alternative IDE-compatible annotation for "value" >> keyword >> Changeset: d70134da3046 >> Author: sadayapalam >> Date: 2019-04-08 18:26 +0530 >> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d70134da3046 >> >> 8221699: [lworld] Implement temporary alternative IDE-compatible annotation for >> "value" keyword >> >> + src/java.base/share/classes/java/lang/__value__.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java >> ! test/langtools/tools/javac/diags/CheckResourceKeys.java >> + test/langtools/tools/javac/valhalla/lworld-values/ValueAnnotationTest.java >> + test/langtools/tools/javac/valhalla/lworld-values/ValueAnnotationTest.out From ioi.lam at oracle.com Wed Apr 10 05:56:57 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Tue, 9 Apr 2019 22:56:57 -0700 Subject: RFR 8222243 [lworld] Calling convention - C2 to C1 (fixed point params only) Message-ID: https://bugs.openjdk.java.net/browse/JDK-8222243 http://cr.openjdk.java.net/~iklam/valhalla/8222243-c2-calls-c1-fixed-point-params.v01/ Implement Method::verified_entry and Method::verified_value_ro_entry for C1-compiled methods. This allows C2 to call C1 with scalarized parameters. In this RFR, we only support passing of fixed point parameters (boolean, byte, char, short, int and long), along with value objects that contain fields of these types. Support for other types of parameters/fields will be implemented in subsequent steps. The C1 code uses the same functionality as the code in sharedRuntime.cpp that handles the signature of the different compiled entries. Hence, I refactored the code into a new class CompiledEntrySignature. The code is littered with lots of FIXME (no support for floats, oops, GC, etc). I intend to fix those soon. Thanks - Ioi -------------------------------------------------- Example of parameter shuffling in C1 verified_entry static void test(int a, Point p, int b) {...} C2 passes outgoing parameters as ? # parm0:??? rsi?????? = int a ? # parm1:??? rdx?????? = int p.x ? # parm2:??? rcx?????? = int p.y ? # parm3:??? r8??????? = int b C1 expects incoming parameters as ? # parm0:??? rsi?????? = int?? a ? # parm1:??? rdx ? ? ? = Point p ? # parm2:??? rcx?????? = int?? b The C1 Verified Entry Point will pack the scalarized parameters (p.x, p.y) back into a Point reference, and shuffle the rest of the params: ??? 0: push?? %rbp ??? 1: sub??? $0x30,%rsp ??? 5: mov??? $0x7f0b154f9448,%rbx? ; Method test(IQPoint;I) ?? 15: callq? 0x00007f0b4c7d2cc0??? ;? {runtime_call buffer_value_args} ??????????????????????????????????? ;? no need to shuffle rsi (a) ?? 20: mov??? 0x10(%rax),%r11d ?? 24: shl??? $0x3,%r11?????? ????? ;? r11 = p ?? 28: mov??? %edx,0x10(%r11)?????? ;? set p.x ?? 32: mov??? %ecx,0x14(%r11)?????? ;? set p.y ?? 36: mov??? %r11,%rdx???????????? ;? rdx = p ?? 39: mov??? %r8,%rcx????????????? ;? rcx = a ?? 42: pop??? %rbp ?? 43: add??? $0x30,%rsp ?? 47: jmpq?? verified_value_entry From david.simms at oracle.com Wed Apr 10 10:00:50 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Wed, 10 Apr 2019 10:00:50 +0000 Subject: hg: valhalla/valhalla: [lworld] Missed default value in value_mirror Message-ID: <201904101000.x3AA0pnQ029465@aojmv0008.oracle.com> Changeset: e8afa9b24ac7 Author: dsimms Date: 2019-04-10 12:00 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e8afa9b24ac7 [lworld] Missed default value in value_mirror ! src/hotspot/share/oops/valueKlass.hpp From tobias.hartmann at oracle.com Wed Apr 10 10:50:14 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 10 Apr 2019 12:50:14 +0200 Subject: RFR 8222243 [lworld] Calling convention - C2 to C1 (fixed point params only) In-Reply-To: References: Message-ID: Hi Ioi, this looks good to me. Thanks, Tobias On 10.04.19 07:56, Ioi Lam wrote: > https://bugs.openjdk.java.net/browse/JDK-8222243 > http://cr.openjdk.java.net/~iklam/valhalla/8222243-c2-calls-c1-fixed-point-params.v01/ > > Implement Method::verified_entry and Method::verified_value_ro_entry for C1-compiled methods. This > allows C2 to call C1 with scalarized parameters. > > In this RFR, we only support passing of fixed point parameters (boolean, byte, char, short, int and > long), along with value objects that contain fields of these types. Support for other types of > parameters/fields will be implemented in subsequent steps. > > The C1 code uses the same functionality as the code in sharedRuntime.cpp that handles the signature > of the different compiled entries. Hence, I refactored the code into a new class > CompiledEntrySignature. > > The code is littered with lots of FIXME (no support for floats, oops, GC, etc). I intend to fix > those soon. > > Thanks > - Ioi > > -------------------------------------------------- > > Example of parameter shuffling in C1 verified_entry > > static void test(int a, Point p, int b) {...} > > C2 passes outgoing parameters as > > ? # parm0:??? rsi?????? = int a > ? # parm1:??? rdx?????? = int p.x > ? # parm2:??? rcx?????? = int p.y > ? # parm3:??? r8??????? = int b > > > C1 expects incoming parameters as > > ? # parm0:??? rsi?????? = int?? a > ? # parm1:??? rdx ? ? ? = Point p > ? # parm2:??? rcx?????? = int?? b > > > The C1 Verified Entry Point will pack the scalarized parameters (p.x, > p.y) back into a Point reference, and shuffle the rest of the params: > > ??? 0: push?? %rbp > ??? 1: sub??? $0x30,%rsp > ??? 5: mov??? $0x7f0b154f9448,%rbx? ; Method test(IQPoint;I) > ?? 15: callq? 0x00007f0b4c7d2cc0??? ;? {runtime_call buffer_value_args} > ??????????????????????????????????? ;? no need to shuffle rsi (a) > ?? 20: mov??? 0x10(%rax),%r11d > ?? 24: shl??? $0x3,%r11?????? ????? ;? r11 = p > ?? 28: mov??? %edx,0x10(%r11)?????? ;? set p.x > ?? 32: mov??? %ecx,0x14(%r11)?????? ;? set p.y > ?? 36: mov??? %r11,%rdx???????????? ;? rdx = p > ?? 39: mov??? %r8,%rcx????????????? ;? rcx = a > ?? 42: pop??? %rbp > ?? 43: add??? $0x30,%rsp > ?? 47: jmpq?? verified_value_entry > > > > From tobias.hartmann at oracle.com Wed Apr 10 12:48:20 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 10 Apr 2019 14:48:20 +0200 Subject: [lworld] RFR(XL): 8220716: [lworld] C2 support for LW2 arrays Message-ID: Hi, please review the following patch that adds C2 support for LW2 arrays: https://bugs.openjdk.java.net/browse/JDK-8220716 http://cr.openjdk.java.net/~thartmann/8220716/webrev.00/ It's based on Mr. Simms' runtime patch: http://cr.openjdk.java.net/~dsimms/valhalla/lw2_arrays/webrev5/ We now support the following three types of value type arrays: - null-ok: MyValue.box[] (ciObjArrayKlass "[LMyValue") - null-free: MyValue.val[] (ciObjArrayKlass "[QMyValue") - null-free, flattened: MyValue.val[] (ciValueArrayKlass "[QMyValue") GraphKit::new_array needs to emit code to compute the storage properties if the array type is not statically known (i.e. for reflective array creation) and PhaseMacroExpand::initialize_object needs to encode these properties into the klass pointer. Typeflow analysis and C2's type system required some changes to take the array storage properties into account when computing the meet between array types. Complexity of loading/storing from/to an array didn't change compared to LW1. Also allocation of an array with a known element type didn't change. Only unsafe/reflective array creation with an unknown array type is a bit more complicated now because we need to compute the storage properties at runtime. The array_copyOf and native_clone intrinsics now need to load the array element mirror. This patch also includes the following changes: - Intrinsification of Class::asBoxType/asValueType to fold MyValue.class.asBoxType()/asValueType() - Fixed Class.cast intrinsic to check for null when casting to .val - Minor refactoring and cleanups of related code - Lots of additional tests that caught lots of bugs, also in the runtime :) All compiler and runtime value type tests pass. Thanks, Tobias From ioi.lam at oracle.com Wed Apr 10 20:39:11 2019 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Wed, 10 Apr 2019 20:39:11 +0000 Subject: hg: valhalla/valhalla: 8222243: [lworld] Calling convention - C2 to C1 (fixed point params only) Message-ID: <201904102039.x3AKdCP6009661@aojmv0008.oracle.com> Changeset: d2ed608f2906 Author: iklam Date: 2019-04-10 13:38 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d2ed608f2906 8222243: [lworld] Calling convention - C2 to C1 (fixed point params only) Reviewed-by: thartmann ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/c1_Runtime1_x86.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/share/c1/c1_LIRAssembler.cpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp ! src/hotspot/share/c1/c1_MacroAssembler.hpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/c1/c1_Runtime1.hpp ! src/hotspot/share/code/compiledIC.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java From forax at univ-mlv.fr Wed Apr 10 21:47:27 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 10 Apr 2019 23:47:27 +0200 (CEST) Subject: guardIfConstant, the constant sniffer combinator Message-ID: <840979651.1162473.1554932847949.JavaMail.zimbra@u-pem.fr> The problem is the following, with the java compiler intrinsic of amber, String.format() is optimized using invokedynamic in the case the format (the first argument) is constant (and some other conditions on the format), this is great, perf are like 25x in simple benchmarks, and that all because in a lot of code, the format is not constant for the Java compiler. By example, class Logger { public static void log(String format, String message) { System.err.println(String.format(format, message)); } } ... logger.log("%s", "hello"); The format is not a constant inside Logger::log for the Java compiler but when the code is JITed, due to inlining, logger.log("hello") calls String.format() with a constant. I propose a way to fix that, by providing a method handle combiner (guardIfConstant) that detects if an argument is a constant and do something different if it's a constant or not. It's a little more complex than that, we don't only want to have a separate path if the argument is a constant, we also want to be able to build a method handle tree depending on the value of that constant. MethodHandle guardIfConstant(int argument, MethodHandle targetProvider, MethodHandle fallback) the semantics: if the nth argument is a constant, the target provider is called with that argument and the return value, a method handle, is called with all the arguments, otherwise the fallback is called. in term of method type: - the method type of the return value of guardIfConstant is the same as fallback - the method type of targetProvider returns a MethodHandle and takes a single parameter which is the nth parameter type of the fallback method type, the returned method handle as to have the same method type as the fallback. R?mi From john.r.rose at oracle.com Wed Apr 10 22:08:07 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 10 Apr 2019 15:08:07 -0700 Subject: guardIfConstant, the constant sniffer combinator In-Reply-To: <840979651.1162473.1554932847949.JavaMail.zimbra@u-pem.fr> References: <840979651.1162473.1554932847949.JavaMail.zimbra@u-pem.fr> Message-ID: <193F8D3B-6897-4094-9D49-6415EA057176@oracle.com> This is very similar to a "growable switch" combinator, which would call the provider for each distinct selector value. A key difference is that non-constant values go through the fallback, where a "growable switch" doesn't need a fallback, since the provider MH is always free to just return a standard fallback as its result (as is the case with your combinator). I wonder if the concepts can be combined somehow? Here's a test question: When the JIT, after heroic effort, discovers that an argument is constant, can it run the provider (in the compiler thread???) to determine a custom handler for the newly discovered branch of constant code? The answer is probably, "sorry, no", although the JIT might set up an uncommon trap (and/or an execution counter) that can revisit the question at some point. Here's a close point of correspondence between the idea of a growable switch and your combinator: Both need a memory. Both want to remember the appearance of constants, so a later optimization phase can use the full historical knowledge. ? John > On Apr 10, 2019, at 2:47 PM, Remi Forax wrote: > > The problem is the following, > with the java compiler intrinsic of amber, String.format() is optimized using invokedynamic in the case the format (the first argument) is constant (and some other conditions on the format), this is great, perf are like 25x in simple benchmarks, and that all because in a lot of code, the format is not constant for the Java compiler. > > By example, > class Logger { > public static void log(String format, String message) { > System.err.println(String.format(format, message)); > } > } > ... > logger.log("%s", "hello"); > > The format is not a constant inside Logger::log for the Java compiler but when the code is JITed, due to inlining, logger.log("hello") calls String.format() with a constant. > > > I propose a way to fix that, by providing a method handle combiner (guardIfConstant) that detects if an argument is a constant and do something different if it's a constant or not. > It's a little more complex than that, we don't only want to have a separate path if the argument is a constant, we also want to be able to build a method handle tree depending on the value of that constant. > > MethodHandle guardIfConstant(int argument, MethodHandle targetProvider, MethodHandle fallback) > > the semantics: if the nth argument is a constant, the target provider is called with that argument and the return value, a method handle, is called with all the arguments, otherwise the fallback is called. > > in term of method type: > - the method type of the return value of guardIfConstant is the same as fallback > - the method type of targetProvider returns a MethodHandle and takes a single parameter which is the nth parameter type of the fallback method type, > the returned method handle as to have the same method type as the fallback. > > R?mi > > _______________________________________________ > mlvm-dev mailing list > mlvm-dev at openjdk.java.net > https://mail.openjdk.java.net/mailman/listinfo/mlvm-dev From david.holmes at oracle.com Wed Apr 10 23:58:03 2019 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 10 Apr 2019 23:58:03 +0000 Subject: hg: valhalla/valhalla: 77 new changesets Message-ID: <201904102358.x3ANw762028635@aojmv0008.oracle.com> Changeset: 724b9e361cb6 Author: rschmelter Date: 2019-03-26 01:46 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/724b9e361cb6 8221325: Add information about swap space to print_memory_info() on MacOS Reviewed-by: stuefe, dholmes ! src/hotspot/os/bsd/os_bsd.cpp Changeset: a7df0de0835a Author: weijun Date: 2019-04-04 20:22 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a7df0de0835a 8219861: Add new keytool -showinfo -tls command for displaying TLS configuration information Reviewed-by: mullan ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/tools/keytool/Resources.java + src/java.base/share/classes/sun/security/tools/keytool/ShowInfo.java Changeset: f562f8318ebd Author: erikj Date: 2019-04-04 07:43 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f562f8318ebd 8217728: Speed up incremental rerun of "make hotspot" Reviewed-by: tbell ! make/Main.gmk ! make/common/NativeCompilation.gmk Changeset: 6c0ab8bd8da5 Author: rkennke Date: 2019-04-02 23:00 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6c0ab8bd8da5 8221766: Load-reference barriers for Shenandoah Reviewed-by: kvn, erikj, aph, shade ! make/hotspot/lib/JvmFeatures.gmk ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoah_aarch64.ad ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoah_x86_64.ad ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp ! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahAggressiveHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahCompactHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahStaticHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahEvacOOMHandler.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp ! src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/loopopts.cpp ! src/hotspot/share/opto/node.hpp ! test/hotspot/jtreg/gc/shenandoah/options/TestSelectiveBarrierFlags.java ! test/hotspot/jtreg/gc/shenandoah/options/TestWrongBarrierDisable.java Changeset: b354ffb03ae4 Author: mseledtsov Date: 2019-04-04 12:29 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b354ffb03ae4 8221710: [TESTBUG] more configurable parameters for docker testing Summary: Introduced docker test config properties Reviewed-by: lmesnik, iignatyev, egahlin ! test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java ! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java Changeset: 13c02cc7a6e5 Author: rkennke Date: 2019-04-04 21:29 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/13c02cc7a6e5 8221848: Shenandoah: ArrayCopy post-barrier improvements Reviewed-by: zgu ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: 2da3b1a3942f Author: erikj Date: 2019-04-04 13:56 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2da3b1a3942f 8221996: Bootcycle build broken Reviewed-by: tbell ! make/Main.gmk Changeset: 6aa05983e9d3 Author: redestad Date: 2019-04-04 23:19 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6aa05983e9d3 8221980: Simplify Optional implementation Reviewed-by: smarks, clanger ! src/java.base/share/classes/java/util/Optional.java Changeset: 6aedb80a6fd4 Author: redestad Date: 2019-04-04 23:21 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6aedb80a6fd4 8221981: Simplify Map/List/Set.of() implementation Reviewed-by: smarks ! src/java.base/share/classes/java/util/ImmutableCollections.java ! src/java.base/share/classes/java/util/List.java ! src/java.base/share/classes/java/util/Map.java ! src/java.base/share/classes/java/util/Set.java Changeset: 82f41fb55b63 Author: redestad Date: 2019-04-04 23:21 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/82f41fb55b63 8221921: Implement size() / isEmpty() in immutable collections Reviewed-by: smarks ! src/java.base/share/classes/java/util/ImmutableCollections.java Changeset: fb25cd198a10 Author: xuelei Date: 2019-04-04 14:19 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/fb25cd198a10 8163326: Update the default enabled cipher suites preference Reviewed-by: mullan ! src/java.base/share/classes/sun/security/ssl/CipherSuite.java ! test/jdk/javax/net/ssl/sanity/ciphersuites/CheckCipherSuites.java Changeset: ad9fa99fa48e Author: coleenp Date: 2019-04-04 17:23 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ad9fa99fa48e 8221992: Fix old method replacement in ResolvedMethodTable Summary: Use method get_new_method() which is used in other call sites. Reviewed-by: sspitsyn ! src/hotspot/share/prims/resolvedMethodTable.cpp Changeset: 532e88de77eb Author: goetz Date: 2019-04-04 09:39 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/532e88de77eb 8221470: Print methods in exception messages in java-like Syntax. Reviewed-by: dholmes, mdoerr, coleenp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/nativeLookup.cpp ! src/hotspot/share/prims/stackwalk.cpp ! src/hotspot/share/runtime/reflection.cpp ! test/hotspot/jtreg/runtime/LoaderConstraints/itableLdrConstraint/Test.java ! test/hotspot/jtreg/runtime/LoaderConstraints/vtableLdrConstraint/Test.java ! test/hotspot/jtreg/runtime/Nestmates/membership/TestNestmateMembership.java ! test/hotspot/jtreg/runtime/Nestmates/privateConstructors/TestConstructorHierarchy.java ! test/hotspot/jtreg/runtime/exceptionMsgs/AbstractMethodError/AbstractMethodErrorTest.java ! test/hotspot/jtreg/runtime/exceptionMsgs/IllegalAccessError/IllegalAccessErrorTest.java + test/hotspot/jtreg/runtime/exceptionMsgs/methodPrinting/TeMe3_C.jasm + test/hotspot/jtreg/runtime/exceptionMsgs/methodPrinting/TestPrintingMethods.java ! test/hotspot/jtreg/runtime/modules/AccessCheck/ExpQualToM1PrivateMethodIAE.java Changeset: b34bcfbcc2fd Author: goetz Date: 2019-04-05 07:59 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b34bcfbcc2fd 8219918: ProblemList hotspot tests failing in SAP testing. Reviewed-by: dholmes ! test/hotspot/jtreg/ProblemList.txt Changeset: dad2c80ae0b2 Author: mbaesken Date: 2019-04-02 13:54 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dad2c80ae0b2 8218547: Simplify JLI_Open on Windows in native code (libjli) Reviewed-by: alanb, clanger ! src/java.base/windows/native/libjli/java_md.c ! test/jdk/tools/launcher/Arrrghs.java Changeset: 776b261dff84 Author: shade Date: 2019-04-05 09:06 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/776b261dff84 8221918: runtime/SharedArchiveFile/serviceability/ReplaceCriticalClasses.java fails: Shared archive not found Reviewed-by: jiangli, dholmes ! test/hotspot/jtreg/runtime/SharedArchiveFile/serviceability/ReplaceCriticalClasses.java Changeset: d5fb27646df4 Author: mdoerr Date: 2019-04-05 09:18 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d5fb27646df4 8221833: Readability check in Symbol::is_valid not performed for some addresses Reviewed-by: zgu, coleenp ! src/hotspot/share/runtime/os.cpp Changeset: 2ae93028bef3 Author: stuefe Date: 2019-03-27 14:13 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2ae93028bef3 8221539: [metaspace] Improve MetaspaceObj::is_metaspace_obj() and friends Reviewed-by: adinn, coleenp, mdoerr ! src/hotspot/cpu/aarch64/frame_aarch64.cpp ! src/hotspot/cpu/arm/frame_arm.cpp ! src/hotspot/cpu/sparc/frame_sparc.cpp ! src/hotspot/cpu/x86/frame_x86.cpp ! src/hotspot/os_cpu/linux_ppc/thread_linux_ppc.cpp ! src/hotspot/os_cpu/linux_s390/thread_linux_s390.cpp ! src/hotspot/share/memory/allocation.cpp ! src/hotspot/share/memory/allocation.hpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.hpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp ! src/hotspot/share/oops/instanceKlass.cpp + test/hotspot/gtest/memory/test_is_metaspace_obj.cpp Changeset: f2c23221bbd5 Author: gadams Date: 2019-04-05 07:10 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f2c23221bbd5 8203364: Some serviceability/sa/ tests intermittently fail with java.io.IOException: LingeredApp terminated with non-zero exit code 3 Reviewed-by: cjplummer, jcbeyler ! test/lib/jdk/test/lib/apps/LingeredApp.java Changeset: d9b46b7de028 Author: adinn Date: 2019-04-05 10:01 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d9b46b7de028 8221477: Inject os/cpu-specific constants into Unsafe from JVM Summary: Initialize Unsafe os/cpu-specific constants using injection instead of native callouts Reviewed-by: stuefe, coleenp, dholmes, plevart ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/runtime/thread.cpp ! src/java.base/share/classes/jdk/internal/misc/Unsafe.java + src/java.base/share/classes/jdk/internal/misc/UnsafeConstants.java ! test/jdk/java/lang/reflect/AccessibleObject/CanAccessTest.java Changeset: 23a04fe2aca2 Author: aph Date: 2019-04-05 09:53 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/23a04fe2aca2 8219993: AArch64: Compiled CI stubs are unsafely modified Reviewed-by: adinn ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/compiledIC_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp Changeset: 03ea2b6428f0 Author: bpb Date: 2019-04-05 08:37 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/03ea2b6428f0 8221597: A typo in the Java API doc for File.getUsableSpace() Reviewed-by: lancea, darcy ! src/java.base/share/classes/java/io/File.java Changeset: 172f929786ea Author: jjg Date: 2019-04-05 11:17 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/172f929786ea 8221997: fix headings in jdk.javadoc Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/doclet/package-info.java Changeset: dfba4e321ab3 Author: xuelei Date: 2019-04-05 11:28 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/dfba4e321ab3 8221882: Use fiber-friendly java.util.concurrent.locks in JSSE Reviewed-by: alanb, dfuchs ! src/java.base/share/classes/javax/net/ssl/SSLContext.java ! src/java.base/share/classes/javax/net/ssl/SSLServerSocketFactory.java ! src/java.base/share/classes/javax/net/ssl/SSLSocketFactory.java ! src/java.base/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java ! src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java ! src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java ! src/java.base/share/classes/sun/security/ssl/DTLSOutputRecord.java ! src/java.base/share/classes/sun/security/ssl/EphemeralKeyManager.java ! src/java.base/share/classes/sun/security/ssl/HelloCookieManager.java ! src/java.base/share/classes/sun/security/ssl/InputRecord.java ! src/java.base/share/classes/sun/security/ssl/OutputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java ! src/java.base/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java ! src/java.base/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/java.base/share/classes/sun/security/ssl/TransportContext.java ! src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java ! src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java Changeset: 259b40b4d473 Author: jjg Date: 2019-04-05 15:57 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/259b40b4d473 8221871: javadoc should not set role=region on
elements Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java ! test/langtools/jdk/javadoc/doclet/testHtmlTag/TestHtmlTag.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testUseOption/TestUseOption.java Changeset: a5da0277d9bb Author: mchung Date: 2019-04-06 21:05 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a5da0277d9bb 8220282: Add MethodHandle tests on accessing final fields Reviewed-by: lancea ! test/jdk/java/lang/invoke/MethodHandlesGeneralTest.java ! test/jdk/java/lang/invoke/MethodHandlesTest.java Changeset: b16e8a886fc3 Author: mchung Date: 2019-04-06 21:16 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b16e8a886fc3 8221530: Caller sensitive methods not handling caller = null when invoked by JNI code with no java frames on stack Reviewed-by: alanb, dholmes, sundar ! make/test/JtregNativeJdk.gmk ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java ! src/java.base/share/classes/jdk/internal/reflect/Reflection.java + test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java + test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c Changeset: cfe96d1d0715 Author: mchung Date: 2019-04-07 03:00 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cfe96d1d0715 8222078: test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c build fails after 8221530 Reviewed-by: lancea, dholmes ! test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c Changeset: cd2879e0c165 Author: mchung Date: 2019-04-07 18:09 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cd2879e0c165 8222082: Build of test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c still failing on Windows Reviewed-by: alanb, dholmes ! make/test/JtregNativeJdk.gmk Changeset: ac4b327623f6 Author: shade Date: 2019-04-07 13:28 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ac4b327623f6 8221917: serviceability/sa/TestPrintMdo.java fails on 32-bit platforms Reviewed-by: cjplummer, dholmes ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/DataLayout.java Changeset: 8d51a40fbd23 Author: shade Date: 2019-04-07 13:28 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8d51a40fbd23 8222032: x86_32 fails with "wrong size of mach node" on AVX-512 machine Reviewed-by: kvn, vlivanov ! src/hotspot/cpu/x86/x86_32.ad Changeset: 40658cb7f47a Author: ngasson Date: 2019-04-08 09:31 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/40658cb7f47a 8221529: [TESTBUG] Docker tests use old/deprecated image on AArch64 Reviewed-by: aph, sgehwolf, mseledtsov ! test/lib/jdk/test/lib/containers/docker/DockerfileConfig.java Changeset: 0d7fb7f07134 Author: clanger Date: 2019-04-08 06:56 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0d7fb7f07134 8221880: Better customization for Windows RC properties FileDescription and ProductName Reviewed-by: erikj ! make/autoconf/flags-other.m4 ! make/autoconf/jdk-version.m4 ! make/autoconf/spec.gmk.in Changeset: 7b5e2bc79e68 Author: dpochepk Date: 2019-04-08 15:54 +0300 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7b5e2bc79e68 8221995: AARCH64: problems with CAS instructions encoding Reviewed-by: aph ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp Changeset: 22ee881e6a74 Author: shade Date: 2019-04-08 15:25 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/22ee881e6a74 8222111: exeCallerAccessTest.c fails to build: control reaches end of non-void function Reviewed-by: alanb, dholmes ! test/jdk/java/lang/reflect/exeCallerAccessTest/exeCallerAccessTest.c Changeset: 542735f2a53e Author: erikj Date: 2019-04-05 06:48 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/542735f2a53e 8221907: make reconfigure breaks when configured with relative paths Reviewed-by: dholmes ! make/Init.gmk ! make/autoconf/basics.m4 ! make/autoconf/basics_windows.m4 ! make/autoconf/spec.gmk.in ! make/autoconf/toolchain_windows.m4 Changeset: a8db7fd22fd1 Author: mullan Date: 2019-04-08 12:19 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a8db7fd22fd1 8222089: [TESTBUG] sun/security/lib/cacerts/VerifyCACerts.java fails due to cert within 90-day expiry window Reviewed-by: xuelei ! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Changeset: 40dc805f4709 Author: rkennke Date: 2019-04-08 18:42 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/40dc805f4709 8222125: Shenandoah: Crash when running with ShenandoahParallelSafepointThreads=1 Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp + test/hotspot/jtreg/gc/shenandoah/options/TestSafepointWorkers.java Changeset: 0608ef3a7740 Author: rkennke Date: 2019-04-08 18:42 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0608ef3a7740 8222129: Shenandoah: Missing CompareAndSwapP/N case in get_barrier_strength() Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Changeset: e5713cefcf41 Author: sgroeger Date: 2019-04-08 15:01 +0100 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e5713cefcf41 8222027: java/util/logging/LogManager/TestLoggerNames.java generates intermittent ClassCastException Summary: Make a strong reference to TestLogger and dont fetch it from LogManager Reviewed-by: dfuchs ! test/jdk/java/util/logging/LogManager/TestLoggerNames.java Changeset: 6733a9176cce Author: dtitov Date: 2019-04-08 17:09 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6733a9176cce 8221730: jcmd process name matching broken Reviewed-by: jcbeyler, dholmes, cjplummer ! src/jdk.jcmd/linux/classes/sun/tools/ProcessHelper.java ! test/hotspot/jtreg/serviceability/dcmd/framework/HelpTest.java ! test/hotspot/jtreg/serviceability/dcmd/framework/InvalidCommandTest.java - test/hotspot/jtreg/serviceability/dcmd/framework/TestJavaProcess.java + test/hotspot/jtreg/serviceability/dcmd/framework/TestProcessJarLauncher.java ! test/hotspot/jtreg/serviceability/dcmd/framework/TestProcessLauncher.java + test/hotspot/jtreg/serviceability/dcmd/framework/TestProcessModuleLauncher.java ! test/hotspot/jtreg/serviceability/dcmd/framework/VMVersionTest.java + test/hotspot/jtreg/serviceability/dcmd/framework/process/TestJavaProcess.java ! test/jdk/sun/tools/jcmd/TestProcessHelper.java Changeset: ba0d64652b86 Author: zgu Date: 2019-04-08 13:22 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ba0d64652b86 8222086: CodeCache::UnloadingScope needs to preserve and restore previous IsUnloadingBehavior Reviewed-by: eosterlund ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp Changeset: 2020eaa9ca9f Author: mullan Date: 2019-04-08 13:33 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2020eaa9ca9f 8222133: Add temporary exceptions for root certs that are due to expire soon Reviewed-by: xuelei ! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Changeset: b9c461c02f7c Author: shade Date: 2019-04-08 19:43 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b9c461c02f7c 8222130: Shenandoah should verify roots after pre-evacuation Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp Changeset: 1f8938ce8564 Author: epavlova Date: 2019-04-08 11:11 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1f8938ce8564 8216551: GraalUnitTestLauncher should be executed as '@run driver' Reviewed-by: dlong, kvn ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/compiler/graalunit/ApiDirectivesTest.java ! test/hotspot/jtreg/compiler/graalunit/ApiTest.java ! test/hotspot/jtreg/compiler/graalunit/AsmAarch64Test.java ! test/hotspot/jtreg/compiler/graalunit/AsmAmd64Test.java ! test/hotspot/jtreg/compiler/graalunit/AsmSparcTest.java ! test/hotspot/jtreg/compiler/graalunit/CollectionsTest.java ! test/hotspot/jtreg/compiler/graalunit/CoreAmd64Test.java ! test/hotspot/jtreg/compiler/graalunit/CoreTest.java ! test/hotspot/jtreg/compiler/graalunit/DebugTest.java ! test/hotspot/jtreg/compiler/graalunit/EA9Test.java ! test/hotspot/jtreg/compiler/graalunit/EATest.java ! test/hotspot/jtreg/compiler/graalunit/GraphTest.java ! test/hotspot/jtreg/compiler/graalunit/HotspotAmd64Test.java ! test/hotspot/jtreg/compiler/graalunit/HotspotJdk9Test.java ! test/hotspot/jtreg/compiler/graalunit/HotspotLirTest.java ! test/hotspot/jtreg/compiler/graalunit/HotspotSparcTest.java ! test/hotspot/jtreg/compiler/graalunit/HotspotTest.java ! test/hotspot/jtreg/compiler/graalunit/Jtt.MicroTest.java ! test/hotspot/jtreg/compiler/graalunit/JttBackendTest.java ! test/hotspot/jtreg/compiler/graalunit/JttBytecodeTest.java ! test/hotspot/jtreg/compiler/graalunit/JttExceptTest.java ! test/hotspot/jtreg/compiler/graalunit/JttHotpathTest.java ! test/hotspot/jtreg/compiler/graalunit/JttHotspotTest.java ! test/hotspot/jtreg/compiler/graalunit/JttJdkTest.java ! test/hotspot/jtreg/compiler/graalunit/JttLangALTest.java ! test/hotspot/jtreg/compiler/graalunit/JttLangMathALTest.java ! test/hotspot/jtreg/compiler/graalunit/JttLangMathMZTest.java ! test/hotspot/jtreg/compiler/graalunit/JttLangNZTest.java ! test/hotspot/jtreg/compiler/graalunit/JttLoopTest.java ! test/hotspot/jtreg/compiler/graalunit/JttOptimizeTest.java ! test/hotspot/jtreg/compiler/graalunit/JttReflectAETest.java ! test/hotspot/jtreg/compiler/graalunit/JttReflectFieldGetTest.java ! test/hotspot/jtreg/compiler/graalunit/JttReflectFieldSetTest.java ! test/hotspot/jtreg/compiler/graalunit/JttReflectGZTest.java ! test/hotspot/jtreg/compiler/graalunit/JttThreadsTest.java ! test/hotspot/jtreg/compiler/graalunit/LirJttTest.java ! test/hotspot/jtreg/compiler/graalunit/LirTest.java ! test/hotspot/jtreg/compiler/graalunit/LoopTest.java ! test/hotspot/jtreg/compiler/graalunit/NodesTest.java ! test/hotspot/jtreg/compiler/graalunit/OptionsTest.java ! test/hotspot/jtreg/compiler/graalunit/PhasesCommonTest.java ! test/hotspot/jtreg/compiler/graalunit/Replacements12Test.java ! test/hotspot/jtreg/compiler/graalunit/Replacements9Test.java ! test/hotspot/jtreg/compiler/graalunit/ReplacementsTest.java ! test/hotspot/jtreg/compiler/graalunit/TestPackages.txt ! test/hotspot/jtreg/compiler/graalunit/UtilTest.java ! test/hotspot/jtreg/compiler/graalunit/generateTests.sh ! test/jdk/ProblemList-graal.txt Changeset: c4f16445675a Author: tschatzl Date: 2019-04-08 20:37 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c4f16445675a 8218668: Clean up evacuation of optional collection set Summary: Better integrate optional collection set evacuation into the existing evacuation scheme, fixing a few minor issues with the initial implementation. Reviewed-by: kbarrett, sangheki ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectionSet.cpp ! src/hotspot/share/gc/g1/g1CollectionSet.hpp ! src/hotspot/share/gc/g1/g1CollectionSetCandidates.cpp ! src/hotspot/share/gc/g1/g1CollectionSetCandidates.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp ! src/hotspot/share/gc/g1/g1HeapVerifier.cpp ! src/hotspot/share/gc/g1/g1OopStarChunkedList.cpp ! src/hotspot/share/gc/g1/g1OopStarChunkedList.hpp ! src/hotspot/share/gc/g1/g1OopStarChunkedList.inline.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1Policy.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSet.hpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp ! src/hotspot/share/gc/shared/workerDataArray.hpp ! src/hotspot/share/gc/shared/workerDataArray.inline.hpp Changeset: 58751415d5f8 Author: tschatzl Date: 2019-04-08 21:01 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/58751415d5f8 8222105: Add "use_" prefix to G1Policy::adaptive_young_list_length Summary: Improve naming of G1Policy::adaptive_young_list_length to improve readability. Reviewed-by: kbarrett ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1Policy.hpp ! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp ! src/hotspot/share/gc/g1/g1YoungGenSizer.hpp ! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp Changeset: 0c5d713cf43f Author: sangheki Date: 2019-04-08 12:15 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0c5d713cf43f 8218049: Survivor MemoryMXBean used() size granularity is region based Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1EdenRegions.hpp ! src/hotspot/share/gc/g1/g1MonitoringSupport.cpp ! src/hotspot/share/gc/g1/g1MonitoringSupport.hpp ! src/hotspot/share/gc/g1/g1SurvivorRegions.cpp ! src/hotspot/share/gc/g1/g1SurvivorRegions.hpp ! src/hotspot/share/gc/g1/vmStructs_g1.hpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/gc/survivorAlignment/TestAllocationInEden.java ! test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromEdenToTenured.java ! test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterFullGC.java ! test/hotspot/jtreg/gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java ! test/hotspot/jtreg/gc/survivorAlignment/TestPromotionLABLargeSurvivorAlignment.java ! test/hotspot/jtreg/gc/survivorAlignment/TestPromotionToSurvivor.java Changeset: b02d1d829b09 Author: dholmes Date: 2019-04-08 17:30 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b02d1d829b09 8218458: [TESTBUG] runtime/NMT/CheckForProperDetailStackTrace.java fails with Expected stack trace missing from output Reviewed-by: cjplummer, zgu ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/NMT/CheckForProperDetailStackTrace.java Changeset: 8592226f5cd3 Author: dholmes Date: 2019-04-08 21:39 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8592226f5cd3 8221584: SIGSEGV in os::PlatformEvent::unpark() in JvmtiRawMonitor::raw_exit while posting method exit event Reviewed-by: dholmes, dcubed Contributed-by: robbin.ehn at oracle.com, stefan.karlsson at oracle.com ! src/hotspot/share/prims/jvmtiRawMonitor.cpp Changeset: 14986fb09d9a Author: mbaesken Date: 2019-04-08 14:36 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/14986fb09d9a 8221535: add steal tick related information to hs_error file [linux] Reviewed-by: dholmes, goetz ! src/hotspot/os/aix/os_perf_aix.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_linux.hpp ! src/hotspot/os/linux/os_perf_linux.cpp Changeset: f22759e92191 Author: redestad Date: 2019-04-09 11:40 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f22759e92191 8222144: BuiltinClassLoader should create the CodeSource for jrt URLs lazily Reviewed-by: alanb ! src/java.base/share/classes/jdk/internal/loader/BuiltinClassLoader.java Changeset: 89295131e353 Author: mullan Date: 2019-04-09 08:56 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/89295131e353 8020637: Permissions.readObject doesn't enforce proper Class to PermissionCollection mappings Reviewed-by: weijun ! src/java.base/share/classes/java/security/Permissions.java + test/jdk/java/security/Permissions/DeserializeInvalidPermissions.java Changeset: e437ad5643d6 Author: jiefu Date: 2019-04-09 06:11 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e437ad5643d6 8221894: Add comments for docker tests in the test doc Reviewed-by: erikj, dholmes ! doc/testing.html ! doc/testing.md Changeset: 0fa2903fb272 Author: fyang Date: 2019-04-08 14:40 +0800 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0fa2903fb272 8221658: aarch64: add necessary predicate for ubfx patterns Reviewed-by: aph ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_ad.m4 Changeset: 805584336738 Author: smarks Date: 2019-04-09 09:49 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/805584336738 8221924: get(null) on single-entry unmodifiable Map returns null instead of throwing NPE Reviewed-by: redestad, lancea ! src/java.base/share/classes/java/util/ImmutableCollections.java ! test/jdk/java/util/Map/MapFactories.java Changeset: 20f7bbfc61d3 Author: bpb Date: 2019-04-09 12:17 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/20f7bbfc61d3 8221852: SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE should be selected at runtime, not build time Reviewed-by: alanb, shade ! src/java.base/windows/classes/sun/nio/fs/WindowsConstants.java ! src/java.base/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/java.base/windows/native/libnio/fs/WindowsNativeDispatcher.c Changeset: 511be32f3863 Author: shade Date: 2019-04-09 21:20 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/511be32f3863 8222185: Shenandoah should report "committed" as capacity Reviewed-by: zgu, rkennke ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahCompactHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahStaticHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp ! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahMonitoringSupport.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp Changeset: cdc54443fee5 Author: shade Date: 2019-04-09 21:20 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cdc54443fee5 8222186: Shenandoah should not uncommit below minimum heap size Reviewed-by: zgu, rkennke ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! test/hotspot/jtreg/gc/shenandoah/mxbeans/TestMemoryMXBeans.java Changeset: 6ad0281a654e Author: rkennke Date: 2019-04-09 23:36 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6ad0281a654e 8222227: Shenandoah: Fix Traversal GC weak roots handling in final-traversal pause Reviewed-by: shade, zgu ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp ! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Changeset: 625f49b603f0 Author: dcubed Date: 2019-04-09 18:26 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/625f49b603f0 8222229: ProblemList compiler/jsr292/InvokerSignatureMismatch.java Reviewed-by: iignatyev ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: f847a42ddc01 Author: igerasim Date: 2019-04-09 16:32 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f847a42ddc01 8221430: StringBuffer(CharSequence) constructor truncates when -XX:-CompactStrings specified Reviewed-by: igerasim, rriggs Contributed-by: Andrew Leonard , Ivan Gerasimov ! src/java.base/share/classes/java/lang/AbstractStringBuilder.java ! src/java.base/share/classes/java/lang/StringBuffer.java ! src/java.base/share/classes/java/lang/StringBuilder.java ! test/jdk/java/lang/StringBuffer/CompactStringBuffer.java ! test/micro/org/openjdk/bench/java/lang/StringBuilders.java Changeset: c914170817d4 Author: jcbeyler Date: 2019-04-09 19:34 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c914170817d4 8221853: Data race in compile broker (set_last_compile) Summary: Remove the debug code provoking it Reviewed-by: kvn, thartmann ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileBroker.hpp Changeset: ac20c3bdc55d Author: valeriep Date: 2019-04-10 02:35 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ac20c3bdc55d 8216039: TLS with BC and RSASSA-PSS breaks ECDHServerKeyExchange Summary: Add internal Signature init methods to select provider based on both key and parameter Reviewed-by: xuelei ! src/java.base/share/classes/java/security/Signature.java ! src/java.base/share/classes/java/security/SignatureSpi.java ! src/java.base/share/classes/java/security/cert/X509CRL.java ! src/java.base/share/classes/java/security/cert/X509Certificate.java + src/java.base/share/classes/jdk/internal/access/JavaSecuritySignatureAccess.java ! src/java.base/share/classes/jdk/internal/access/SharedSecrets.java ! src/java.base/share/classes/sun/security/pkcs/SignerInfo.java ! src/java.base/share/classes/sun/security/pkcs10/PKCS10.java ! src/java.base/share/classes/sun/security/ssl/SignatureScheme.java ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/util/SignatureUtil.java ! src/java.base/share/classes/sun/security/x509/X509CRLImpl.java ! src/java.base/share/classes/sun/security/x509/X509CertImpl.java + test/jdk/java/security/Signature/SignatureGetInstance.java ! test/jdk/sun/security/util/misc/SetNullSigParams.java Changeset: 72f05350b4b3 Author: valeriep Date: 2019-04-10 02:41 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/72f05350b4b3 Merge Changeset: ddc19ea5059c Author: mbaesken Date: 2019-04-10 08:51 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/ddc19ea5059c 8219241: Provide basic virtualization related info in the hs_error file on linux/windows x86_64 Reviewed-by: dholmes, mdoerr ! src/hotspot/cpu/ppc/vm_version_ppc.cpp ! src/hotspot/cpu/ppc/vm_version_ppc.hpp ! src/hotspot/cpu/s390/vm_version_s390.cpp ! src/hotspot/cpu/s390/vm_version_s390.hpp ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/cpu/x86/vm_version_x86.hpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_linux.hpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/runtime/vm_version.cpp ! src/hotspot/share/runtime/vm_version.hpp Changeset: 7fd299216e97 Author: redestad Date: 2019-04-10 12:05 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/7fd299216e97 8221836: Avoid recalculating String.hash when zero Reviewed-by: jrose, adinn Contributed-by: peter.levart at gmail.com, claes.redestad at oracle.com ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/classfile/stringTable.cpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp ! src/java.base/share/classes/java/lang/String.java Changeset: 4fa1fd8bc21e Author: smonteith Date: 2019-04-09 12:47 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4fa1fd8bc21e 8222180: ZGC: ZForwarding::verify() failing when checking for duplicates Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/z/zForwarding.cpp Changeset: 25199b48f34f Author: pliden Date: 2019-04-10 12:45 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/25199b48f34f 8221984: ZGC: Clean up ZOop Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zBarrier.cpp ! src/hotspot/share/gc/z/zBarrier.inline.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zLiveMap.inline.hpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/gc/z/zOop.hpp ! src/hotspot/share/gc/z/zOop.inline.hpp ! src/hotspot/share/gc/z/zOopClosures.cpp ! src/hotspot/share/gc/z/zUtils.inline.hpp Changeset: a84fefde0543 Author: rkennke Date: 2019-04-10 13:21 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a84fefde0543 8222259: Shenandoah: Pre-evacuate string-dedup roots in Traversal GC Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp Changeset: bf07e140c49c Author: erikj Date: 2019-04-10 07:04 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf07e140c49c 8221851: Use of THIS_FILE in hotspot invalidates precompiled header on Linux/GCC Reviewed-by: tbell, ysuenaga ! make/autoconf/basics.m4 ! make/autoconf/flags-cflags.m4 ! make/autoconf/spec.gmk.in ! make/common/NativeCompilation.gmk ! make/hotspot/gensrc/GensrcAdlc.gmk ! make/hotspot/gensrc/GensrcDtrace.gmk ! make/hotspot/lib/CompileDtraceLibraries.gmk ! make/hotspot/lib/CompileGtest.gmk ! make/hotspot/lib/CompileJvm.gmk ! src/hotspot/share/utilities/exceptions.hpp Changeset: a805bf992bf1 Author: rschmelter Date: 2019-04-10 05:15 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a805bf992bf1 8222264: Windows incremental build is broken with JDK-8217728 Reviewed-by: erikj, clanger ! make/common/NativeCompilation.gmk Changeset: 9d0ae9508d53 Author: redestad Date: 2019-04-10 20:03 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9d0ae9508d53 8222029: Optimize Math.floorMod Reviewed-by: aph, darcy ! src/java.base/share/classes/java/lang/Math.java ! test/jdk/java/lang/Math/DivModTests.java + test/micro/org/openjdk/bench/java/lang/MathBench.java Changeset: 17b1c2c467ad Author: vromero Date: 2019-04-10 17:15 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/17b1c2c467ad 8222035: minimal inference context optimization is forcing resolution with incomplete constraints Reviewed-by: mcimadamore, cushon ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/InferenceContext.java + test/langtools/tools/javac/T8222035/MinContextOpTest.java + test/langtools/tools/javac/T8222035/MinContextOpTest.out Changeset: 1bbce3048d20 Author: dtitov Date: 2019-04-10 21:21 +0000 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1bbce3048d20 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails Reviewed-by: sspitsyn, jcbeyler, amenkov ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SingleStep/singlestep001/singlestep001.cpp Changeset: 941db9c0b5b5 Author: coleenp Date: 2019-04-10 17:31 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/941db9c0b5b5 8222231: Clean up interfaceSupport.inline.hpp duplicated code Reviewed-by: dholmes, pchilanomate ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/runtime/interfaceSupport.inline.hpp ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp Changeset: 30aca1e755bf Author: jwilhelm Date: 2019-04-11 01:21 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/30aca1e755bf Added tag jdk-13+16 for changeset 9d0ae9508d53 ! .hgtags From david.holmes at oracle.com Thu Apr 11 00:59:50 2019 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Thu, 11 Apr 2019 00:59:50 +0000 Subject: hg: valhalla/valhalla: Merge Message-ID: <201904110059.x3B0xo3U001381@aojmv0008.oracle.com> Changeset: 4041fc316f33 Author: dholmes Date: 2019-04-10 20:59 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4041fc316f33 Merge - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - make/gensrc/GensrcCLDR.gmk ! make/hotspot/symbols/symbols-unix ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp ! src/hotspot/cpu/arm/templateTable_arm.cpp ! src/hotspot/cpu/sparc/templateTable_sparc.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/aot/aotLoader.cpp ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/ci/ciInstanceKlass.hpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/classLoaderData.hpp ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/classfile/classLoaderDataGraph.hpp ! src/hotspot/share/classfile/classLoaderExt.cpp ! src/hotspot/share/classfile/defaultMethods.cpp - src/hotspot/share/classfile/dictionary.inline.hpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/klassFactory.cpp ! src/hotspot/share/classfile/klassFactory.hpp ! src/hotspot/share/classfile/moduleEntry.hpp ! src/hotspot/share/classfile/stackMapFrame.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/vmSymbols.hpp - src/hotspot/share/code/relocInfo_ext.cpp - src/hotspot/share/code/relocInfo_ext.hpp - src/hotspot/share/gc/g1/collectionSetChooser.cpp - src/hotspot/share/gc/g1/collectionSetChooser.hpp - src/hotspot/share/gc/g1/dirtyCardQueue.cpp - src/hotspot/share/gc/g1/dirtyCardQueue.hpp - src/hotspot/share/gc/g1/evacuationInfo.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/hotspot/share/gc/z/zStatTLAB.cpp - src/hotspot/share/gc/z/zStatTLAB.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/heapInspection.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace.hpp ! src/hotspot/share/memory/metaspace/spaceManager.cpp ! src/hotspot/share/memory/metaspaceShared.cpp - src/hotspot/share/oops/array.inline.hpp ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/arrayKlass.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/instanceMirrorKlass.inline.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/klassVtable.cpp - src/hotspot/share/prims/evmCompat.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiClassFileReconstituter.hpp ! src/hotspot/share/prims/jvmtiExport.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/prims/unsafe.cpp - src/hotspot/share/runtime/arguments_ext.hpp ! src/hotspot/share/runtime/reflection.cpp ! src/hotspot/share/runtime/vmStructs.cpp - src/hotspot/share/services/diagnosticCommand_ext.hpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/ClassLoader.java ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java ! src/java.base/share/classes/jdk/internal/reflect/Reflection.java ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java ! src/java.base/share/native/libjava/Class.c - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/SocketChannelImpl.c ! src/java.base/unix/native/libnio/ch/SocketDispatcher.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/SocketChannelImpl.c - src/java.desktop/share/classes/sun/awt/AWTSecurityManager.java - src/java.desktop/share/classes/sun/awt/Graphics2Delegate.java - src/java.desktop/share/classes/sun/awt/TracedEventQueue.java - src/java.desktop/share/classes/sun/awt/image/BadDepthException.java - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh - src/java.desktop/windows/native/libawt/windows/awt_Robot.h - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/output_html.properties - src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/output_text.properties - src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/output_unknown.properties - src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/output_xml.properties - src/java.xml/share/classes/com/sun/org/apache/xpath/internal/SourceTreeManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderData.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotatedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationDesc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationValue.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ClassDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ConstructorDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/DocErrorReporter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doclet.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ExecutableMemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/FieldDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/LanguageVersion.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MethodDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/PackageDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParamTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Parameter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParameterizedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ProgramElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/RootDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SeeTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SerialFieldTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SourcePosition.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Tag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ThrowsTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Type.java - src/jdk.javadoc/share/classes/com/sun/javadoc/TypeVariable.java - src/jdk.javadoc/share/classes/com/sun/javadoc/WildcardType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/Standard.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/Main.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AbstractTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotatedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationDescImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationValueImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ClassDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Comment.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ConstructorDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocEnv.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocLocale.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocletInvoker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ExecutableMemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/FieldDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavaScriptScanner.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocClassFinder.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocMemberEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTodo.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTool.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Messager.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MethodDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ModifierFilter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PackageDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParamTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterizedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PrimitiveType.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ProgramElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/RootDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SeeTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerialFieldTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerializedForm.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Start.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ThrowsTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeMaker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeVariableImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/WildcardTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/bcp47/timezone.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/dtd/ldml.dtd - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/dtd/ldmlBCP47.dtd - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/dtd/ldmlSupplemental.dtd - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/af.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/af_NA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/af_ZA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/agq.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/agq_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ak.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ak_GH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/am.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/am_ET.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_001.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_AE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_BH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_DJ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_DZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_EG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_EH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_ER.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_IL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_IQ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_JO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_KM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_KW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_LB.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_LY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_MA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_MR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_OM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_PS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_QA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_SA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_SD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_SO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_SS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_SY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_TD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_TN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ar_YE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/as.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/as_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/asa.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/asa_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ast.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ast_ES.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/az.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/az_Cyrl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/az_Cyrl_AZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/az_Latn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/az_Latn_AZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bas.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bas_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/be.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/be_BY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bem.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bem_ZM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bez.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bez_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bg.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bg_BG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bm.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bm_ML.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bn_BD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bn_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bo_CN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bo_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/br.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/br_FR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/brx.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/brx_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bs.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bs_Cyrl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bs_Cyrl_BA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bs_Latn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/bs_Latn_BA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ca.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ca_AD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ca_ES.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ca_ES_VALENCIA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ca_FR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ca_IT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ccp.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ccp_BD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ccp_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ce.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ce_RU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/cgg.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/cgg_UG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/chr.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/chr_US.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ckb.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ckb_IQ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ckb_IR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/cs.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/cs_CZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/cu.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/cu_RU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/cy.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/cy_GB.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/da.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/da_DK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/da_GL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dav.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dav_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/de.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/de_AT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/de_BE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/de_CH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/de_DE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/de_IT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/de_LI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/de_LU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dje.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dje_NE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dsb.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dsb_DE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dua.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dua_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dyo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dyo_SN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dz.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/dz_BT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ebu.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ebu_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ee.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ee_GH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ee_TG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/el.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/el_CY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/el_GR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_001.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_150.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_AG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_AI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_AS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_AT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_AU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_BB.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_BE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_BI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_BM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_BS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_BW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_BZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_CA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_CC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_CH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_CK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_CX.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_CY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_DE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_DG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_DK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_DM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_ER.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_FI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_FJ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_FK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_FM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_GB.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_GD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_GG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_GH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_GI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_GM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_GU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_GY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_HK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_IE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_IL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_IM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_IO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_JE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_JM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_KI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_KN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_KY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_LC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_LR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_LS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MP.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_MY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_NA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_NF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_NG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_NL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_NR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_NU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_NZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_PG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_PH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_PK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_PN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_PR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_PW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_RW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SB.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SX.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_SZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_TC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_TK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_TO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_TT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_TV.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_UG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_UM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_US.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_US_POSIX.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_VC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_VG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_VI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_VU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_WS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_ZA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_ZM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/en_ZW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/eo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/eo_001.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_419.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_AR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_BO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_BR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_BZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_CL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_CO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_CR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_CU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_DO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_EA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_EC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_ES.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_GQ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_GT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_HN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_IC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_MX.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_NI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_PA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_PE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_PH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_PR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_PY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_SV.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_US.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_UY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/es_VE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/et.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/et_EE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/eu.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/eu_ES.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ewo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ewo_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fa.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fa_AF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fa_IR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ff.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ff_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ff_GN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ff_MR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ff_SN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fi.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fi_FI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fil.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fil_PH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fo_DK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fo_FO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_BE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_BF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_BI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_BJ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_BL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_CA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_CD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_CF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_CG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_CH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_CI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_DJ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_DZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_FR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_GA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_GF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_GN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_GP.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_GQ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_HT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_KM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_LU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_MA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_MC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_MF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_MG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_ML.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_MQ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_MR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_MU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_NC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_NE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_PF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_PM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_RE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_RW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_SC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_SN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_SY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_TD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_TG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_TN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_VU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_WF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fr_YT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fur.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fur_IT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fy.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/fy_NL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ga.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ga_IE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gd.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gd_GB.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gl_ES.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gsw.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gsw_CH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gsw_FR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gsw_LI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gu.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gu_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/guz.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/guz_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gv.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/gv_IM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ha.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ha_GH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ha_NE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ha_NG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/haw.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/haw_US.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/he.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/he_IL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hi.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hi_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hr.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hr_BA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hr_HR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hsb.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hsb_DE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hu.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hu_HU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hy.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/hy_AM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/id.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/id_ID.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ig.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ig_NG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ii.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ii_CN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/is.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/is_IS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/it.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/it_CH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/it_IT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/it_SM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/it_VA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ja.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ja_JP.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/jgo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/jgo_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/jmc.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/jmc_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ka.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ka_GE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kab.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kab_DZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kam.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kam_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kde.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kde_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kea.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kea_CV.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/khq.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/khq_ML.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ki.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ki_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kk.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kk_KZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kkj.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kkj_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kl_GL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kln.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kln_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/km.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/km_KH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kn_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ko.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ko_KP.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ko_KR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kok.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kok_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ks.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ks_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ksb.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ksb_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ksf.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ksf_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ksh.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ksh_DE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kw.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/kw_GB.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ky.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ky_KG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lag.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lag_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lb.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lb_LU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lg.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lg_UG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lkt.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lkt_US.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ln.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ln_AO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ln_CD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ln_CF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ln_CG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lo_LA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lrc.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lrc_IQ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lrc_IR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lt.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lt_LT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lu.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lu_CD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/luo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/luo_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/luy.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/luy_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lv.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/lv_LV.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mas.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mas_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mas_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mer.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mer_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mfe.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mfe_MU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mg.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mg_MG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mgh.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mgh_MZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mgo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mgo_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mk.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mk_MK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ml.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ml_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mn_MN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mr.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mr_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ms.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ms_BN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ms_MY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ms_SG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mt.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mt_MT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mua.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mua_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/my.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/my_MM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mzn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/mzn_IR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/naq.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/naq_NA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nb.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nb_NO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nb_SJ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nd.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nd_ZW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nds.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nds_DE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nds_NL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ne.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ne_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ne_NP.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nl_AW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nl_BE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nl_BQ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nl_CW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nl_NL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nl_SR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nl_SX.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nmg.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nmg_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nn_NO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nnh.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nnh_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nus.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nus_SS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nyn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/nyn_UG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/om.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/om_ET.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/om_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/or.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/or_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/os.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/os_GE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/os_RU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pa.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pa_Arab.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pa_Arab_PK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pa_Guru.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pa_Guru_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pl_PL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/prg.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/prg_001.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ps.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ps_AF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_AO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_BR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_CH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_CV.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_GQ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_GW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_LU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_MO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_MZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_PT.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_ST.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/pt_TL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/qu.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/qu_BO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/qu_EC.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/qu_PE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rm.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rm_CH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rn_BI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ro.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ro_MD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ro_RO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rof.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rof_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/root.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ru.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ru_BY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ru_KG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ru_KZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ru_MD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ru_RU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ru_UA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rw.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rw_RW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rwk.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/rwk_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sah.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sah_RU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/saq.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/saq_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sbp.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sbp_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sd.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sd_PK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/se.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/se_FI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/se_NO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/se_SE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/seh.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/seh_MZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ses.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ses_ML.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sg.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sg_CF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/shi.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/shi_Latn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/shi_Latn_MA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/shi_Tfng.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/shi_Tfng_MA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/si.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/si_LK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sk.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sk_SK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sl_SI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/smn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/smn_FI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sn_ZW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/so.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/so_DJ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/so_ET.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/so_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/so_SO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sq.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sq_AL.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sq_MK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sq_XK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Cyrl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Cyrl_BA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Cyrl_ME.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Cyrl_RS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Cyrl_XK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Latn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Latn_BA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Latn_ME.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Latn_RS.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sr_Latn_XK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sv.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sv_AX.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sv_FI.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sv_SE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sw.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sw_CD.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sw_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sw_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/sw_UG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ta.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ta_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ta_LK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ta_MY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ta_SG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/te.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/te_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/teo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/teo_KE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/teo_UG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tg.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tg_TJ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/th.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/th_TH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ti.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ti_ER.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ti_ET.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tk.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tk_TM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/to.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/to_TO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tr.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tr_CY.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tr_TR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tt.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tt_RU.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/twq.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/twq_NE.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tzm.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/tzm_MA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ug.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ug_CN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uk.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uk_UA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ur.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ur_IN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/ur_PK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uz.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uz_Arab.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uz_Arab_AF.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uz_Cyrl.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uz_Cyrl_UZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uz_Latn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/uz_Latn_UZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vai.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vai_Latn.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vai_Latn_LR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vai_Vaii.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vai_Vaii_LR.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vi.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vi_VN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vo_001.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vun.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/vun_TZ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/wae.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/wae_CH.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/wo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/wo_SN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/xog.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/xog_UG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yav.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yav_CM.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yi.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yi_001.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yo_BJ.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yo_NG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yue.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yue_HK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yue_Hans.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yue_Hans_CN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yue_Hant.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/yue_Hant_HK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zgh.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zgh_MA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hans.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hans_CN.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hans_HK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hans_MO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hans_SG.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hant.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hant_HK.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hant_MO.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zh_Hant_TW.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zu.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/main/zu_ZA.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/attributeValueValidity.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/characters.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/coverageLevels.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/dayPeriods.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/genderList.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/languageInfo.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/likelySubtags.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/metaZones.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/numberingSystems.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/ordinals.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/pluralRanges.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/plurals.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/rgScope.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/subdivisions.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/supplementalData.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/supplementalMetadata.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/telephoneCodeData.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/common/supplemental/windowsZones.xml - src/jdk.localedata/share/classes/sun/util/cldr/resources/unicode-license.txt - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - src/utils/LogCompilation/src/test/resources/hotspot_pid23756.log - src/utils/LogCompilation/src/test/resources/hotspot_pid25109.log - src/utils/LogCompilation/src/test/resources/no_tiered_short.log - src/utils/LogCompilation/src/test/resources/tiered_short.log - test/Makefile - test/TestCommon.gmk - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp - test/hotspot/jtreg/Makefile ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/applications/ctw/modules/jdk_incubator_httpclient.java - test/hotspot/jtreg/applications/ctw/modules/jdk_packager.java - test/hotspot/jtreg/applications/ctw/modules/jdk_packager_services.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/ResolvedJavaTypeResolveMethodTest.java - test/hotspot/jtreg/gc/g1/TestStringTableStats.java ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java ! test/hotspot/jtreg/runtime/Nestmates/membership/TestNestmateMembership.java ! test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestInvokeErrors.java - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c ! test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_Shared.java - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/dcmd/framework/TEST.properties - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jaxp/Makefile - test/jdk/Makefile ! test/jdk/ProblemList.txt ! test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/java/lang/String/AlignIndent.java - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/javax/net/ssl/compatibility/Parameter.java - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/krb5/auto/rcache_usemd5.sh - test/jdk/sun/security/krb5/tools/ktarg.sh - test/jdk/sun/security/krb5/tools/ktcheck.sh - test/jdk/sun/security/krb5/tools/ktmissing.sh - test/jdk/sun/security/krb5/tools/ktzero.sh - test/jdk/sun/security/pkcs11/fips/CipherTest.java - test/jdk/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java - test/jdk/sun/security/pkcs11/fips/ImportKeyStore.java - test/jdk/sun/security/pkcs11/fips/JSSEClient.java - test/jdk/sun/security/pkcs11/fips/JSSEServer.java - test/jdk/sun/security/pkcs11/fips/TestTLS12.java - test/jdk/sun/security/pkcs11/fips/TrustManagerTest.java - test/jdk/sun/security/pkcs11/fips/TrustManagerTest.policy - test/jdk/sun/security/pkcs11/fips/cert8.db - test/jdk/sun/security/pkcs11/fips/certs/anchor.cer - test/jdk/sun/security/pkcs11/fips/certs/ca.cer - test/jdk/sun/security/pkcs11/fips/certs/server.cer - test/jdk/sun/security/pkcs11/fips/fips.cfg - test/jdk/sun/security/pkcs11/fips/key3.db - test/jdk/sun/security/pkcs11/fips/keystore - test/jdk/sun/security/pkcs11/fips/secmod.db - test/jdk/sun/security/pkcs11/fips/truststore - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/jdk/sun/security/ssl/rsa/BrokenRSAPrivateCrtKey.java - test/jdk/sun/security/util/Resources/NewNamesFormat.java - test/jdk/sun/security/util/Resources/NewResourcesNames.java - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java - test/langtools/Makefile - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/AccessFrameTitle.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/p1/C1.java - test/langtools/jdk/javadoc/doclet/AccessFrameTitle/p2/C2.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/PackagesHeader.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/p1/C1.java - test/langtools/jdk/javadoc/doclet/PackagesHeader/p2/C2.java - test/langtools/jdk/javadoc/doclet/lib/JavadocTester.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/TestClassDocCatalog.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyAnnotation.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyClass.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyEnum.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyError.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyException.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg1/EmptyInterface.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyAnnotation.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyClass.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyEnum.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyError.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyException.java - test/langtools/jdk/javadoc/doclet/testClassDocCatalog/pkg2/EmptyInterface.java - test/langtools/jdk/javadoc/doclet/testFramesNoFrames/TestFramesNoFrames.java - test/langtools/jdk/javadoc/doclet/testHtmlLandmarkRegions/TestHtmlLankmarkRegions.java - test/langtools/jdk/javadoc/doclet/testHtmlWarning/TestHtmlWarning.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/TestWindowTitle.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/p1/C1.java - test/langtools/jdk/javadoc/doclet/testWindowTitle/p2/C2.java - test/langtools/jdk/javadoc/tool/api/basic/GetTask_DocletClassTest.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/tools/javac/RawStringLiteralLang.java - test/langtools/tools/javac/RawStringLiteralLangAPI.java - test/langtools/tools/javac/diags/examples/RawStringLiteral.java - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java - test/langtools/tools/javadoc/6176978/T6176978.java - test/langtools/tools/javadoc/6176978/X.java - test/langtools/tools/javadoc/6227454/Test.java - test/langtools/tools/javadoc/6942366/T6942366.java - test/langtools/tools/javadoc/6942366/Test.java - test/langtools/tools/javadoc/6942366/p/Base.java - test/langtools/tools/javadoc/6958836/Test.java - test/langtools/tools/javadoc/6964914/Error.java - test/langtools/tools/javadoc/6964914/JavacWarning.java - test/langtools/tools/javadoc/6964914/JavadocWarning.java - test/langtools/tools/javadoc/6964914/Test.java - test/langtools/tools/javadoc/6964914/TestStdDoclet.java - test/langtools/tools/javadoc/6964914/TestUserDoclet.java - test/langtools/tools/javadoc/8025693/Test.java - test/langtools/tools/javadoc/8147801/T8147801.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib1.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib2.java - test/langtools/tools/javadoc/8147801/p/Test.java - test/langtools/tools/javadoc/AddOpensTest.java - test/langtools/tools/javadoc/BadOptionsTest.java - test/langtools/tools/javadoc/BooleanConst.java - test/langtools/tools/javadoc/BreakIteratorWarning.java - test/langtools/tools/javadoc/CheckResourceKeys.java - test/langtools/tools/javadoc/CompletionError.java - test/langtools/tools/javadoc/EncodingTest.java - test/langtools/tools/javadoc/FlagsTooEarly.java - test/langtools/tools/javadoc/InlineTagsWithBraces.java - test/langtools/tools/javadoc/LangVers.java - test/langtools/tools/javadoc/MaxWarns.java - test/langtools/tools/javadoc/MethodLinks.java - test/langtools/tools/javadoc/NoStar.java - test/langtools/tools/javadoc/ReleaseOption.java - test/langtools/tools/javadoc/ReleaseOptionSource.java - test/langtools/tools/javadoc/T4994049/FileWithTabs.java - test/langtools/tools/javadoc/T4994049/T4994049.java - test/langtools/tools/javadoc/T6968833.java - test/langtools/tools/javadoc/XWerror.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/Main.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/expected.out - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/B.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/E.java - test/langtools/tools/javadoc/annotations/annotatePackage/Main.java - test/langtools/tools/javadoc/annotations/annotatePackage/expected.out - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package-info.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package.html - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/B.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/package.html - test/langtools/tools/javadoc/annotations/annotateParams/Main.java - test/langtools/tools/javadoc/annotations/annotateParams/expected.out - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/C.java - test/langtools/tools/javadoc/annotations/badVals/Main.java - test/langtools/tools/javadoc/annotations/badVals/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/Main.java - test/langtools/tools/javadoc/annotations/defaults/expected.out - test/langtools/tools/javadoc/annotations/defaults/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/pkg1/B.java - test/langtools/tools/javadoc/annotations/elementTypes/Main.java - test/langtools/tools/javadoc/annotations/elementTypes/expected.out - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/A.java - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/B.java - test/langtools/tools/javadoc/annotations/missing/Main.java - test/langtools/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java - test/langtools/tools/javadoc/annotations/shortcuts/Main.java - test/langtools/tools/javadoc/annotations/shortcuts/expected.out - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/A.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Array.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Marker.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Value.java - test/langtools/tools/javadoc/api/basic/APITest.java - test/langtools/tools/javadoc/api/basic/DocletPathTest.java - test/langtools/tools/javadoc/api/basic/DocumentationToolLocationTest.java - test/langtools/tools/javadoc/api/basic/GetSourceVersionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DiagListenerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileManagerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileObjectsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_OptionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_WriterTest.java - test/langtools/tools/javadoc/api/basic/Task_reuseTest.java - test/langtools/tools/javadoc/api/basic/pkg/C.java - test/langtools/tools/javadoc/api/basic/taglets/UnderlineTaglet.java - test/langtools/tools/javadoc/completionFailure/CompletionFailure.java - test/langtools/tools/javadoc/completionFailure/pkg/A.java - test/langtools/tools/javadoc/completionFailure/pkg/B.java - test/langtools/tools/javadoc/dupOk/DupOk.java - test/langtools/tools/javadoc/dupOk/sp1/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/B.java - test/langtools/tools/javadoc/enum/docComments/Main.java - test/langtools/tools/javadoc/enum/docComments/pkg1/Operation.java - test/langtools/tools/javadoc/enum/enumType/Main.java - test/langtools/tools/javadoc/enum/enumType/expected.out - test/langtools/tools/javadoc/enum/enumType/pkg1/QuotablePerson.java - test/langtools/tools/javadoc/generics/genericClass/Main.java - test/langtools/tools/javadoc/generics/genericClass/expected.out - test/langtools/tools/javadoc/generics/genericClass/pkg1/A.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/Main.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/expected.out - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/O.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/X.java - test/langtools/tools/javadoc/generics/genericInterface/Main.java - test/langtools/tools/javadoc/generics/genericInterface/expected.out - test/langtools/tools/javadoc/generics/genericInterface/pkg1/A.java - test/langtools/tools/javadoc/generics/genericMethod/Main.java - test/langtools/tools/javadoc/generics/genericMethod/expected.out - test/langtools/tools/javadoc/generics/genericMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/genericSuper/Main.java - test/langtools/tools/javadoc/generics/genericSuper/expected.out - test/langtools/tools/javadoc/generics/genericSuper/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/Main.java - test/langtools/tools/javadoc/generics/supertypes/expected.out - test/langtools/tools/javadoc/generics/supertypes/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/pkg1/B.java - test/langtools/tools/javadoc/generics/throwsGeneric/Main.java - test/langtools/tools/javadoc/generics/throwsGeneric/expected.out - test/langtools/tools/javadoc/generics/throwsGeneric/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamCycle/Main.java - test/langtools/tools/javadoc/generics/tparamCycle/pkg1/LikeEnum.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamTagOnType/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnType/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnType/pkg1/A.java - test/langtools/tools/javadoc/generics/wildcards/Main.java - test/langtools/tools/javadoc/generics/wildcards/expected.out - test/langtools/tools/javadoc/generics/wildcards/pkg1/A.java - test/langtools/tools/javadoc/imports/I.java - test/langtools/tools/javadoc/imports/MissingImport.java - test/langtools/tools/javadoc/lib/OldToolTester.java - test/langtools/tools/javadoc/lib/ToyDoclet.java - test/langtools/tools/javadoc/nestedClass/NestedClass.java - test/langtools/tools/javadoc/nestedClass/NestedClassB.java - test/langtools/tools/javadoc/nonConstExprs/Test.java - test/langtools/tools/javadoc/outputRedirect/Test.java - test/langtools/tools/javadoc/outputRedirect/p/OutputRedirect.java - test/langtools/tools/javadoc/parser/7091528/T7091528.java - test/langtools/tools/javadoc/parser/7091528/p/C1.java - test/langtools/tools/javadoc/parser/7091528/p/C3.java - test/langtools/tools/javadoc/parser/7091528/p/q/C2.java - test/langtools/tools/javadoc/sourceOnly/Test.java - test/langtools/tools/javadoc/sourceOnly/p/NonSource.jasm - test/langtools/tools/javadoc/sourceOnly/p/SourceOnly.java - test/langtools/tools/javadoc/sourceOption/SourceOption.java - test/langtools/tools/javadoc/sourceOption/p/LambdaConstructTest.java - test/langtools/tools/javadoc/subpackageIgnore/SubpackageIgnore.java - test/langtools/tools/javadoc/subpackageIgnore/pkg1/not-subpkg/SomeJavaFile.java - test/langtools/tools/javadoc/varArgs/Main.java - test/langtools/tools/javadoc/varArgs/expected.out - test/langtools/tools/javadoc/varArgs/pkg1/A.java - test/nashorn/Makefile From david.simms at oracle.com Thu Apr 11 10:19:10 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Thu, 11 Apr 2019 10:19:10 +0000 Subject: hg: valhalla/valhalla: Merge Message-ID: <201904111019.x3BAJBvc029127@aojmv0008.oracle.com> Changeset: c09e30a997d1 Author: dsimms Date: 2019-04-11 12:14 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c09e30a997d1 Merge ! .hgtags ! src/hotspot/cpu/x86/frame_x86.cpp ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/memory/allocation.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/loopopts.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/runtime/reflection.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/utilities/exceptions.hpp ! src/java.base/share/classes/java/lang/reflect/AccessibleObject.java ! src/java.base/share/classes/jdk/internal/misc/Unsafe.java ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/serviceability/dcmd/framework/TestJavaProcess.java From tobias.hartmann at oracle.com Thu Apr 11 15:56:28 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Thu, 11 Apr 2019 15:56:28 +0000 Subject: hg: valhalla/valhalla: [lworld] Print additional field info in ci Message-ID: <201904111556.x3BFuScg011373@aojmv0008.oracle.com> Changeset: bc87b157e193 Author: thartmann Date: 2019-04-11 17:56 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bc87b157e193 [lworld] Print additional field info in ci ! src/hotspot/share/ci/ciField.cpp From forax at univ-mlv.fr Thu Apr 11 20:30:17 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Thu, 11 Apr 2019 22:30:17 +0200 (CEST) Subject: guardIfConstant, the constant sniffer combinator In-Reply-To: <193F8D3B-6897-4094-9D49-6415EA057176@oracle.com> References: <840979651.1162473.1554932847949.JavaMail.zimbra@u-pem.fr> <193F8D3B-6897-4094-9D49-6415EA057176@oracle.com> Message-ID: <1793705226.1441344.1555014617503.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "John Rose" > ?: "Da Vinci Machine Project" > Cc: "valhalla-dev" > Envoy?: Jeudi 11 Avril 2019 00:08:07 > Objet: Re: guardIfConstant, the constant sniffer combinator > This is very similar to a "growable switch" combinator, > which would call the provider for each distinct selector > value. A key difference is that non-constant values > go through the fallback, where a "growable switch" > doesn't need a fallback, since the provider MH is > always free to just return a standard fallback as > its result (as is the case with your combinator). > > I wonder if the concepts can be combined somehow? They are clearly related. I'm trying to avoid the shared pairs of constant/target you need to maintain for a "growable switch" combinator by pushing these states neare to the generated assembly code where the inlining tree is resolved. > > Here's a test question: When the JIT, after heroic > effort, discovers that an argument is constant, can > it run the provider (in the compiler thread???) to > determine a custom handler for the newly discovered > branch of constant code? The answer is probably, > "sorry, no", although the JIT might set up an uncommon > trap (and/or an execution counter) that can revisit > the question at some point. yes, the idea is to revisit later, my hope is that it can work well with tiered compilation or if there is only one JIT, to force a recompilation after some time. > > Here's a close point of correspondence between the > idea of a growable switch and your combinator: Both > need a memory. Both want to remember the appearance > of constants, so a later optimization phase can use the > full historical knowledge. yes ! and my hope is that we don't need a shared memory for that. > > ? John R?mi > >> On Apr 10, 2019, at 2:47 PM, Remi Forax wrote: >> >> The problem is the following, >> with the java compiler intrinsic of amber, String.format() is optimized using >> invokedynamic in the case the format (the first argument) is constant (and some >> other conditions on the format), this is great, perf are like 25x in simple >> benchmarks, and that all because in a lot of code, the format is not constant >> for the Java compiler. >> >> By example, >> class Logger { >> public static void log(String format, String message) { >> System.err.println(String.format(format, message)); >> } >> } >> ... >> logger.log("%s", "hello"); >> >> The format is not a constant inside Logger::log for the Java compiler but when >> the code is JITed, due to inlining, logger.log("hello") calls String.format() >> with a constant. >> >> >> I propose a way to fix that, by providing a method handle combiner >> (guardIfConstant) that detects if an argument is a constant and do something >> different if it's a constant or not. >> It's a little more complex than that, we don't only want to have a separate path >> if the argument is a constant, we also want to be able to build a method handle >> tree depending on the value of that constant. >> >> MethodHandle guardIfConstant(int argument, MethodHandle targetProvider, >> MethodHandle fallback) >> >> the semantics: if the nth argument is a constant, the target provider is called >> with that argument and the return value, a method handle, is called with all >> the arguments, otherwise the fallback is called. >> >> in term of method type: >> - the method type of the return value of guardIfConstant is the same as fallback >> - the method type of targetProvider returns a MethodHandle and takes a single >> parameter which is the nth parameter type of the fallback method type, >> the returned method handle as to have the same method type as the fallback. >> >> R?mi >> >> _______________________________________________ >> mlvm-dev mailing list >> mlvm-dev at openjdk.java.net > > https://mail.openjdk.java.net/mailman/listinfo/mlvm-dev From ioi.lam at oracle.com Fri Apr 12 04:58:08 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Thu, 11 Apr 2019 21:58:08 -0700 Subject: RFR 8222384 [lworld] Calling convention - C2 to C1 (floating point params) Message-ID: https://bugs.openjdk.java.net/browse/JDK-8222384 http://cr.openjdk.java.net/~iklam/valhalla/8222384-c1-calling-convention-floats.v01/ This changeset supports floating point parameters (x64 only, i.e., XMM registers). I also fixed an issue wheresome registers may be trashed before their contents are shuffled. Here's an example (see the rdx register). C2 passes outgoing parameters as: ? # {method} {0x00007fb8593f8420} 'test' '(IQFloatTriplet;I)I' in 'Test' ? # parm0:??? rsi?????? = int ? # parm1:??? xmm0????? = float ? # parm2:??? xmm1????? = float ? # parm3:??? xmm2????? = float ? # parm4:??? rdx?????? = int C1 expects incoming parameters as: ? # parm0:??? rsi?????? = int ? # parm1:??? rdx:rdx?? = 'FloatTriplet' ? # parm2:??? rcx?????? = int shuffling code: ???? 20: mov??? 0x10(%rax),%r11d? ;r11 = buffered FloatTriplet obj ???? 24: shl??? $0x3,%r11 ???? 28: vmovss %xmm0,0x10(%r11) ???? 34: vmovss %xmm1,0x14(%r11) ???? 40: vmovss %xmm2,0x18(%r11) ???? 46: push?? %r11????????????? ; can't write to rdx yet -> save it ???? 48: mov??? %rdx,%rcx???????? ; rdx is now shuffled ???? 51: pop??? %rdx????????????? ; now update rdx Thanks - Ioi From david.simms at oracle.com Fri Apr 12 10:57:14 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 12 Apr 2019 12:57:14 +0200 Subject: FTR: LW2 array covariance Message-ID: <2e31470d-b92b-d12a-4b65-804b0cf1f418@oracle.com> Just dropping a note array covariance and reference conversions rules as we currently understand them for LW2 prototype (coming soon...-ish). Firstly, a small reminder of null-free references. The current prototype is still using "Foo.val" and "Foo.box" syntax, but this will change to: * "Foo" for "null-free value type" (the best kind) o LW2 JVMS draft uses "QFoo;" (Q-type descriptors) * "Foo?" value type reference allowing (for compatibility with existing object references) o LW2 JVMS draft uses "LFoo;" (L-type descriptors) So using this notation, on to arrays. LW2 is looking to using covariance to allow existing code like "Arrays.sort([LObject;)" to "just work", even with null-free arrays: "[QFoo;" <: "[LFoo;? <: ?[LObject;? <: ?Object;" We can freely allow widening conversion, but not narrowing. The VM will support passing value type arrays into old code, but new code users can?t ?cast? an array of null-allowable value types into an array of null-free value types. Some checkcast requirements for reference conversions: * Q->L : "widening reference conversion" (i.e. JLS 5.1.5) * L->Q : "narrowing reference conversion", requires checkcast (cast in source) And for arrays... * [Q->[L : widening * [L->[Q : narrowing, we can't. checkcast (cast in source) will fail if not [Q Some source code... ? Foo?[] la = la(); ? Foo[] qa = qa(); ? qa = (Foo[]) la;? // should fail to compile if type known ? qa = (Foo[]) makeErasedReturnType(); // needs checkcast, will pass only if return reference is Foo[] ? la = qa; // Is fine (no checkcast required for Q-to-L conversions) ? Foo?[] la2 = qa; ? Foo[] qa2 = (Foo[]) la2; // checkcast, which will pass So existing code that accepts and returns array instances, may indeed accept null-free arrays without knowing anything about null-free qualities. This may result in an exception if an attempt to store null is made. So it is up to new code using null-free arrays together with existing L-type signatures to actually test or check if null-store are a risk. New code using existing code that returns traditional null-allowed arrays, cannot simply cast to a null-free array, but must make a copy. /David Simms From tobias.hartmann at oracle.com Fri Apr 12 12:08:16 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Fri, 12 Apr 2019 12:08:16 +0000 Subject: hg: valhalla/valhalla: 8222399: [lworld] Add more compiler tests for .box/.val casts Message-ID: <201904121208.x3CC8H05000493@aojmv0008.oracle.com> Changeset: 5e4095df813e Author: thartmann Date: 2019-04-12 14:08 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/5e4095df813e 8222399: [lworld] Add more compiler tests for .box/.val casts ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableValueTypes.java From tobias.hartmann at oracle.com Fri Apr 12 12:38:07 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 12 Apr 2019 14:38:07 +0200 Subject: RFR 8222384 [lworld] Calling convention - C2 to C1 (floating point params) In-Reply-To: References: Message-ID: Hi Ioi, looks good to me. Little typo: "overwrite it now and and". I wonder if you could use MacroAssembler::move_helper() to avoid code duplication? Thanks, Tobias On 12.04.19 06:58, Ioi Lam wrote: > https://bugs.openjdk.java.net/browse/JDK-8222384 > http://cr.openjdk.java.net/~iklam/valhalla/8222384-c1-calling-convention-floats.v01/ > > This changeset supports floating point parameters (x64 only, i.e., XMM registers). I also fixed an > issue wheresome registers may be trashed before their contents are shuffled. Here's an example (see > the rdx register). > > > C2 passes outgoing parameters as: > > ? # {method} {0x00007fb8593f8420} 'test' '(IQFloatTriplet;I)I' in 'Test' > ? # parm0:??? rsi?????? = int > ? # parm1:??? xmm0????? = float > ? # parm2:??? xmm1????? = float > ? # parm3:??? xmm2????? = float > ? # parm4:??? rdx?????? = int > > > C1 expects incoming parameters as: > > ? # parm0:??? rsi?????? = int > ? # parm1:??? rdx:rdx?? = 'FloatTriplet' > ? # parm2:??? rcx?????? = int > > shuffling code: > > ???? 20: mov??? 0x10(%rax),%r11d? ;r11 = buffered FloatTriplet obj > ???? 24: shl??? $0x3,%r11 > ???? 28: vmovss %xmm0,0x10(%r11) > ???? 34: vmovss %xmm1,0x14(%r11) > ???? 40: vmovss %xmm2,0x18(%r11) > ???? 46: push?? %r11????????????? ; can't write to rdx yet -> save it > ???? 48: mov??? %rdx,%rcx???????? ; rdx is now shuffled > ???? 51: pop??? %rdx????????????? ; now update rdx > > Thanks > - Ioi From ioi.lam at oracle.com Sun Apr 14 01:51:07 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Sat, 13 Apr 2019 18:51:07 -0700 Subject: RFR 8222384 [lworld] Calling convention - C2 to C1 (floating point params) In-Reply-To: References: Message-ID: <7811a03b-ea92-658f-aa41-2001c5445b92@oracle.com> Hi Tobias, Thanks for the code review. On 4/12/19 5:38 AM, Tobias Hartmann wrote: > Hi Ioi, > > looks good to me. Little typo: "overwrite it now and and". Fixed > I wonder if you could use MacroAssembler::move_helper() to avoid code duplication? That's a good idea. I changed it as you suggested, and saved a bunch of code! Here's the delta from my last webrev: http://cr.openjdk.java.net/~iklam/valhalla/8222384-c1-calling-convention-floats.v02-delta/ Thanks - Ioi > Thanks, > Tobias > > On 12.04.19 06:58, Ioi Lam wrote: >> https://bugs.openjdk.java.net/browse/JDK-8222384 >> http://cr.openjdk.java.net/~iklam/valhalla/8222384-c1-calling-convention-floats.v01/ >> >> This changeset supports floating point parameters (x64 only, i.e., XMM registers). I also fixed an >> issue wheresome registers may be trashed before their contents are shuffled. Here's an example (see >> the rdx register). >> >> >> C2 passes outgoing parameters as: >> >> ? # {method} {0x00007fb8593f8420} 'test' '(IQFloatTriplet;I)I' in 'Test' >> ? # parm0:??? rsi?????? = int >> ? # parm1:??? xmm0????? = float >> ? # parm2:??? xmm1????? = float >> ? # parm3:??? xmm2????? = float >> ? # parm4:??? rdx?????? = int >> >> >> C1 expects incoming parameters as: >> >> ? # parm0:??? rsi?????? = int >> ? # parm1:??? rdx:rdx?? = 'FloatTriplet' >> ? # parm2:??? rcx?????? = int >> >> shuffling code: >> >> ???? 20: mov??? 0x10(%rax),%r11d? ;r11 = buffered FloatTriplet obj >> ???? 24: shl??? $0x3,%r11 >> ???? 28: vmovss %xmm0,0x10(%r11) >> ???? 34: vmovss %xmm1,0x14(%r11) >> ???? 40: vmovss %xmm2,0x18(%r11) >> ???? 46: push?? %r11????????????? ; can't write to rdx yet -> save it >> ???? 48: mov??? %rdx,%rcx???????? ; rdx is now shuffled >> ???? 51: pop??? %rdx????????????? ; now update rdx >> >> Thanks >> - Ioi From ioi.lam at oracle.com Sun Apr 14 05:28:08 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Sat, 13 Apr 2019 22:28:08 -0700 Subject: RFR 8222384 [lworld] Calling convention - C2 to C1 (floating point params) In-Reply-To: <7811a03b-ea92-658f-aa41-2001c5445b92@oracle.com> References: <7811a03b-ea92-658f-aa41-2001c5445b92@oracle.com> Message-ID: Actually, please ignore this webrev. I just realized that when shuffling the arguments, the stack may shrink (e.g., if a value argument has 2 int fields) or expand (e.g., if a value argument has 2 float fields). Also, there can be circular dependencies between the vmreg slots.? So I need to rewrite the whole thing to mirror unpack_value_args() :-( Thanks - Ioi On 4/13/19 6:51 PM, Ioi Lam wrote: > Hi Tobias, > > Thanks for the code review. > > On 4/12/19 5:38 AM, Tobias Hartmann wrote: >> Hi Ioi, >> >> looks good to me. Little typo: "overwrite it now and and". > Fixed > >> I wonder if you could use MacroAssembler::move_helper() to avoid code >> duplication? > That's a good idea. I changed it as you suggested, and saved a bunch > of code! > > Here's the delta from my last webrev: > > http://cr.openjdk.java.net/~iklam/valhalla/8222384-c1-calling-convention-floats.v02-delta/ > > > Thanks > - Ioi > >> Thanks, >> Tobias >> >> On 12.04.19 06:58, Ioi Lam wrote: >>> https://bugs.openjdk.java.net/browse/JDK-8222384 >>> http://cr.openjdk.java.net/~iklam/valhalla/8222384-c1-calling-convention-floats.v01/ >>> >>> >>> This changeset supports floating point parameters (x64 only, i.e., >>> XMM registers). I also fixed an >>> issue wheresome registers may be trashed before their contents are >>> shuffled. Here's an example (see >>> the rdx register). >>> >>> >>> C2 passes outgoing parameters as: >>> >>> ?? # {method} {0x00007fb8593f8420} 'test' '(IQFloatTriplet;I)I' in >>> 'Test' >>> ?? # parm0:??? rsi?????? = int >>> ?? # parm1:??? xmm0????? = float >>> ?? # parm2:??? xmm1????? = float >>> ?? # parm3:??? xmm2????? = float >>> ?? # parm4:??? rdx?????? = int >>> >>> >>> C1 expects incoming parameters as: >>> >>> ?? # parm0:??? rsi?????? = int >>> ?? # parm1:??? rdx:rdx?? = 'FloatTriplet' >>> ?? # parm2:??? rcx?????? = int >>> >>> shuffling code: >>> >>> ????? 20: mov??? 0x10(%rax),%r11d? ;r11 = buffered FloatTriplet obj >>> ????? 24: shl??? $0x3,%r11 >>> ????? 28: vmovss %xmm0,0x10(%r11) >>> ????? 34: vmovss %xmm1,0x14(%r11) >>> ????? 40: vmovss %xmm2,0x18(%r11) >>> ????? 46: push?? %r11????????????? ; can't write to rdx yet -> save it >>> ????? 48: mov??? %rdx,%rcx???????? ; rdx is now shuffled >>> ????? 51: pop??? %rdx????????????? ; now update rdx >>> >>> Thanks >>> - Ioi > From tobias.hartmann at oracle.com Mon Apr 15 07:18:42 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 15 Apr 2019 09:18:42 +0200 Subject: RFR 8222384 [lworld] Calling convention - C2 to C1 (floating point params) In-Reply-To: References: <7811a03b-ea92-658f-aa41-2001c5445b92@oracle.com> Message-ID: Hi Ioi, On 14.04.19 07:28, Ioi Lam wrote: > Actually, please ignore this webrev. > > I just realized that when shuffling the arguments, the stack may shrink (e.g., if a value argument > has 2 int fields) or expand (e.g., if a value argument has 2 float fields). Also, there can be > circular dependencies between the vmreg slots.? So I need to rewrite the whole thing to mirror > unpack_value_args() :-( Right, I should have mentioned that but thought you were going to address it in another patch. I think it would be good if the logic in MacroAssembler::unpack_value_args and ::unpack_value_helper could be adapted to support unpacking *and* packing. Thanks, Tobias From dl at cs.oswego.edu Mon Apr 15 13:57:15 2019 From: dl at cs.oswego.edu (Doug Lea) Date: Mon, 15 Apr 2019 09:57:15 -0400 Subject: Observations on sorting values Message-ID: <2ba62a55-5688-088b-a9d3-d62ed7161688@cs.oswego.edu> I've been working sporadically on sorting algorithms expected to work well with value types. This post is mainly on sequential sorting issues. And the measurements here are not even in Java: I've been using plain C with various odd macros to compare cases for which support does yet exist, so are more informative than I could otherwise arrange. The current best candidate is good at conserving and localizing Comparisons, Loads, and Stores (although at the price of being harder to optimize). The expected time to sort random permutations is approximately:?? T(N) = 1.004 NLgN(C + 0.56L + 0.44S + P), where? L is cost to load element (in most cases, at least enough fields needed for compare), C is cost of comparator and (usually poorly predictable) data-branches, S is cost to store (all fields of) element, and P is other sub-NLogN overhead costs. The C, L, and S factors are not necessarily constants, or even simple functions across different modes of use. Here's data from some experiments in which every sort does basically the same thing: sort uniform randomly permuted ids held in a 64bit (8byte) "key" field of a C struct. (Random permutations are among the slowest cases for sorting, mainly because of terrible branch prediction. Also, more theoretical results are also known about this case than others.) The modes vary across: 1. Directly sorting ("V") values (arrays of structs) vs ("P") pointers (arrays of pointers to structs) 2. Size: number of bytes in the struct (minimally 8 for the key; the others unused) 3. For Pointers, whether they are ("L") linearized, initially assigned to adjacent structs (maintaining an initial correlation between pointer and pointee), or are ("R") randomly permuted before sorting 4. Whether the comparator is ("I") inlined or ("C") called. The table reports sorts of arrays of size from 128 to a billion elements, with associated times from about 10microseconds to many minutes. This was run on an Intel E5-2699 with 128Gb RAM, Ubuntu 16.04, gcc5.4? -O3. Some cases of very large arrays of very large structs could not be run because of not enough memory. Tests on other Intel and AMD machines and with other versions of linux and gcc give generally similar results, although with some still undiagnosed variation.? The first two columns show V8I (one 8byte field by value, inlining comparator), basically equivalent to sorting Java "longs", as a time (averaged over 33 minus LgN samples per cell)? and the ratio of time in nanosecs to NLgN. Ideally, this ratio should converge to a constant, which it seems to do; entries up to about 64K show decreasing impact of the sub-NLogN overhead. The other columns report the slowdown (ratio) of each other case to V8I. The table is also at: https://docs.google.com/spreadsheets/d/1iGleQPQt_SCjH6OOyJrZfq4p6Ywi13pNyUCo1ufV0xw/edit?usp=sharing N V8I(sec) ns/nLgn V16I V32I V64I V128I V256I V8C V16C V32C V64C V128C V256C P8RI P8LI P8RC P8LC 128 0.00001 12.06 1.18 1.36 1.63 2.62 6.18 1.52 1.61 2.35 3.34 5.34 12.47 1.13 1.12 1.68 1.62 256 0.00002 11.25 1.10 1.34 1.64 2.61 6.23 1.49 1.61 2.38 3.42 5.65 12.95 1.12 1.09 1.61 1.58 512 0.00005 10.97 1.10 1.38 1.66 2.67 6.00 1.42 1.64 2.42 3.45 5.41 12.37 1.14 1.10 1.48 1.62 1024 0.00010 9.69 1.20 1.39 1.82 2.73 6.28 1.54 1.74 2.59 3.76 5.80 12.40 1.23 1.20 1.60 1.76 2048 0.00020 8.80 1.22 1.40 1.83 2.86 6.04 1.50 1.84 2.67 3.79 5.74 11.34 1.24 1.27 1.56 1.81 4096 0.00039 7.87 1.29 1.34 1.86 2.82 5.56 1.44 1.84 2.64 3.61 5.40 10.53 1.29 1.31 1.50 1.89 8192 0.00070 6.59 1.37 1.31 1.92 2.79 5.68 1.39 1.93 2.67 3.55 5.32 12.38 1.36 1.37 1.47 1.98 16384 0.00125 5.47 1.41 1.41 1.87 2.81 6.78 1.54 1.89 2.64 3.69 6.25 14.67 1.36 1.40 1.76 2.05 32768 0.00267 5.42 1.18 1.41 1.68 2.77 6.28 1.55 1.73 2.59 3.69 6.28 9.17 1.25 1.21 1.87 1.82 65536 0.00565 5.39 1.14 1.37 1.68 2.77 4.16 1.33 1.73 2.60 3.49 4.09 9.19 1.34 1.24 1.26 1.88 131072 0.00727 3.26 1.87 1.43 2.43 3.01 6.86 1.56 2.43 2.84 3.75 6.34 15.20 2.08 2.09 2.16 2.96 262144 0.01530 3.24 1.35 1.43 1.73 2.98 7.15 1.55 1.74 2.64 3.75 6.66 15.44 1.45 1.36 2.23 2.03 524288 0.03217 3.23 1.22 1.43 1.69 2.91 7.38 1.55 1.74 2.64 3.76 6.54 15.55 1.47 1.33 2.27 2.08 1048576 0.06744 3.22 1.19 1.43 1.72 2.94 7.50 1.56 1.74 2.64 3.77 6.41 15.80 1.56 1.38 2.37 2.13 2097152 0.14111 3.20 1.15 1.45 1.76 2.99 7.61 1.56 1.75 2.66 3.81 6.45 15.78 1.74 1.46 2.51 2.21 4194304 0.29483 3.20 1.14 1.46 1.77 3.01 7.68 1.56 1.75 2.66 3.81 6.45 16.41 1.96 1.57 2.75 2.33 8388608 0.61583 3.19 1.15 1.47 1.78 3.04 7.75 1.56 1.76 2.67 3.82 6.47 15.89 2.48 1.84 3.51 2.66 16777216 1.28588 3.19 1.15 1.49 1.79 3.06 7.78 1.56 1.76 2.68 3.83 6.46 15.89 3.03 2.15 4.34 3.12 33554432 2.68097 3.20 1.15 1.47 1.79 3.07 7.80 1.56 1.76 2.67 3.83 6.44 15.88 3.39 2.40 4.84 3.45 67108864 5.55497 3.18 1.15 1.48 1.81 3.10 7.88 1.56 1.76 2.69 3.84 6.54 15.96 3.67 2.63 5.26 3.80 134217728 11.54670 3.19 1.15 1.48 1.81 3.11 7.90 1.55 1.76 2.68 3.85 6.45 15.92 3.82 2.79 5.48 4.04 268435456 23.89779 3.18 1.15 1.48 1.81 3.13 7.96 1.56 1.76 2.70 3.84 6.48 16.05 3.97 2.98 5.73 4.33 536870912 49.40996 3.17 1.16 1.49 1.82 3.15 (OOM) 1.56 1.77 2.70 3.85 6.49 (OOM) 4.18 3.20 6.01 4.63 1073741824 102.16857 3.17 1.16 1.49 1.83 (OOM) (OOM) 1.57 1.77 2.70 3.85 (OOM) (OOM) 4.70 3.57 6.66 5.08 Some observations. None of which are too surprising: 1. For small structs/values, it shows the usual pointer vs value effects: Pointers require twice the number of reads (the pointer and then the pointee key) per access, and the second of these reads has little predictability/locality, which leads to cache/memory traffic overhead that increases with array size rather than staying constant as with Values. For example, the bottom entry for P8LI is analogous to Java sorting a billion Long objects being increasingly slower (here by a factor of 3.57) than sorting longs as N increases. Results for pointers to larger structs are not shown, because they don't vary much from the "P8R" cases. 2. For Values, there is little enough writing overall in this algorithm (as opposed to some others)? that adding fields that must be moved per swap adds only sub-linear cost until struct sizes have hundreds of bytes, where performance starts falling off cliff, and it usually becomes preferable to take the indirection cost on reads for the sake of only one write per array move. (Among the open algorithmic issues is that it is sometimes faster to allow more writes.) 3. In part because there is no common API to send a comparator only key fields, or a by-ref handle, inlining comparators has impact beyond call/return mechanics overhead savings. It can represent the difference between the use of Values being Really Good vs Really Bad for performance, since it allows the comparison of a key field to proceed without reading and passing in unrelated stuff. For Pointers, the main impact is to clue in the compiler to prefetch across an indirection. It would be nice to somehow present a better set of options to programmer. (Short of that, in some cases, it might be a good idea to create and sort another Value/struct with only a key and a pointer to the full value/struct, hitting the V16 case here, at the price of O(n) extra memory.) 4. People who never sort more than say a thousand elements each of which have only a few fields will be comforted that most of these issues don't matter a lot. If you are interested in further experimenting with underdocumented in-progress code, see http://gee.cs.oswego.edu/dl/wwwtmp/ctpq.tar Someday when I have good data, I'll post something about how similar issues surrounding keys and hashcodes apply to other Collections etc. Also stay tuned for more on parallelism. -Doug PS People? betting whether I'd ever send mail with an embedded html table can collect now. The table is too hard to read as plain text. From srikanth.adayapalam at oracle.com Tue Apr 16 03:59:44 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Tue, 16 Apr 2019 09:29:44 +0530 Subject: Build failure ?? Message-ID: As of this morning, I am unable to build lworld branch: I have pulled everything from remote repo and did a fresh configure, clean and when I make I get the error below. Any help in getting past this would be appreciated - TIA Srikanth Building target 'images' in configuration 'linux-x86_64-server-release' /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In static member function ?static void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: error: no matching function for call to ?CallProjections::CallProjections()? ?????? CallProjections projs; ?????????????????????? ^~~~~ In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, ???????????????? from /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, ???????????????? from /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note: candidate: CallProjections::CallProjections(uint) ?? CallProjections(uint nbres) { ?? ^~~~~~~~~~~~~~~ /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note:?? candidate expects 1 argument, 0 provided /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note: candidate: CallProjections::CallProjections(const CallProjections&) ?class CallProjections { ?????? ^~~~~~~~~~~~~~~ /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note:?? candidate expects 1 argument, 0 provided /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1338:53: error: no matching function for call to ?CallNode::extract_projections(CallProjections*, bool, bool)? ?????? call->extract_projections(&projs, false, false); ???????????????????????????????????????????????????? ^ In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, ???????????????? from /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, ???????????????? from /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: note: candidate: CallProjections* CallNode::extract_projections(bool, bool) ?? CallProjections* extract_projections(bool separate_io_proj, bool do_asserts = true); ??????????????????? ^~~~~~~~~~~~~~~~~~~ /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: note:?? candidate expects 2 arguments, 3 provided lib/CompileJvm.gmk:175: recipe for target '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' failed make[3]: *** [/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed make[2]: *** [hotspot-server-libs] Error 2 ERROR: Build failed for target 'images' in configuration 'linux-x86_64-server-release' (exit code 2) === Output from failing command(s) repeated here === * For target hotspot_variant-server_libjvm_objs_shenandoahSupport.o: /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In static member function ?static void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: error: no matching function for call to ?CallProjections::CallProjections()? ?????? CallProjections projs; ?????????????????????? ^~~~~ In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, ???????????????? from /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, ???????????????? from /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note: candidate: CallProjections::CallProjections(uint) ?? CallProjections(uint nbres) { ?? ^~~~~~~~~~~~~~~ /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note:?? candidate expects 1 argument, 0 provided /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note: candidate: CallProjections::CallProjections(const CallProjections&) ?? ... (rest of output omitted) * All command lines available in /home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/make-support/failure-logs. === End of repeated output === === Make failed targets repeated here === lib/CompileJvm.gmk:175: recipe for target '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' failed make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed === End of repeated output === Hint: Try searching the build log for the name of the first failed target. Hint: See doc/building.html#troubleshooting for assistance. /home/srikanth/valhalla/valhalla/make/Init.gmk:307: recipe for target 'main' failed make[1]: *** [main] Error 2 /home/srikanth/valhalla/valhalla/make/Init.gmk:186: recipe for target 'images' failed make: *** [images] Error 2 From forax at univ-mlv.fr Tue Apr 16 05:46:23 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Tue, 16 Apr 2019 07:46:23 +0200 (CEST) Subject: Build failure ?? In-Reply-To: References: Message-ID: <1179894099.370357.1555393583615.JavaMail.zimbra@u-pem.fr> As a workaround, you can test to build with --with-jvm-features=-shenandoahgc given the issue seems to be in shenandoah. R?mi ----- Mail original ----- > De: "Srikanth" > ?: "valhalla-dev" > Envoy?: Mardi 16 Avril 2019 05:59:44 > Objet: Build failure ?? > As of this morning, I am unable to build lworld branch: I have pulled > everything from remote repo and did a fresh configure, clean and when I > make I get the error below. > > Any help in getting past this would be appreciated - TIA Srikanth > > Building target 'images' in configuration 'linux-x86_64-server-release' > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: > In static member function ?static void > ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: > error: no matching function for call to ?CallProjections::CallProjections()? > ?????? CallProjections projs; > ?????????????????????? ^~~~~ > In file included from > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: > note: candidate: CallProjections::CallProjections(uint) > ?? CallProjections(uint nbres) { > ?? ^~~~~~~~~~~~~~~ > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: > note:?? candidate expects 1 argument, 0 provided > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: > note: candidate: CallProjections::CallProjections(const CallProjections&) > ?class CallProjections { > ?????? ^~~~~~~~~~~~~~~ > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: > note:?? candidate expects 1 argument, 0 provided > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1338:53: > error: no matching function for call to > ?CallNode::extract_projections(CallProjections*, bool, bool)? > ?????? call->extract_projections(&projs, false, false); > ???????????????????????????????????????????????????? ^ > In file included from > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: > note: candidate: CallProjections* CallNode::extract_projections(bool, bool) > ?? CallProjections* extract_projections(bool separate_io_proj, bool > do_asserts = true); > ??????????????????? ^~~~~~~~~~~~~~~~~~~ > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: > note:?? candidate expects 2 arguments, 3 provided > lib/CompileJvm.gmk:175: recipe for target > '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' > failed > make[3]: *** > [/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o] > Error 1 > make[3]: *** Waiting for unfinished jobs.... > make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed > make[2]: *** [hotspot-server-libs] Error 2 > > ERROR: Build failed for target 'images' in configuration > 'linux-x86_64-server-release' (exit code 2) > > === Output from failing command(s) repeated here === > * For target hotspot_variant-server_libjvm_objs_shenandoahSupport.o: > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: > In static member function ?static void > ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: > error: no matching function for call to ?CallProjections::CallProjections()? > ?????? CallProjections projs; > ?????????????????????? ^~~~~ > In file included from > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: > note: candidate: CallProjections::CallProjections(uint) > ?? CallProjections(uint nbres) { > ?? ^~~~~~~~~~~~~~~ > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: > note:?? candidate expects 1 argument, 0 provided > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: > note: candidate: CallProjections::CallProjections(const CallProjections&) > ?? ... (rest of output omitted) > > * All command lines available in > /home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/make-support/failure-logs. > === End of repeated output === > > === Make failed targets repeated here === > lib/CompileJvm.gmk:175: recipe for target > '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' > failed > make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed > === End of repeated output === > > Hint: Try searching the build log for the name of the first failed target. > Hint: See doc/building.html#troubleshooting for assistance. > > /home/srikanth/valhalla/valhalla/make/Init.gmk:307: recipe for target > 'main' failed > make[1]: *** [main] Error 2 > /home/srikanth/valhalla/valhalla/make/Init.gmk:186: recipe for target > 'images' failed > make: *** [images] Error 2 From ioi.lam at oracle.com Tue Apr 16 06:25:45 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Mon, 15 Apr 2019 23:25:45 -0700 Subject: RFR 8222384 [lworld] Calling convention - C2 to C1 (floating point params) In-Reply-To: References: <7811a03b-ea92-658f-aa41-2001c5445b92@oracle.com> Message-ID: <05ba294c-b3f2-f07b-afa6-4f2373b59d6f@oracle.com> On 4/15/19 12:18 AM, Tobias Hartmann wrote: > Hi Ioi, > > On 14.04.19 07:28, Ioi Lam wrote: >> Actually, please ignore this webrev. >> >> I just realized that when shuffling the arguments, the stack may shrink (e.g., if a value argument >> has 2 int fields) or expand (e.g., if a value argument has 2 float fields). Also, there can be >> circular dependencies between the vmreg slots.? So I need to rewrite the whole thing to mirror >> unpack_value_args() :-( > Right, I should have mentioned that but thought you were going to address it in another patch. I > think it would be good if the logic in MacroAssembler::unpack_value_args and ::unpack_value_helper > could be adapted to support unpacking *and* packing. Hi Tobias, Thanks for the suggestion. I've refactored MacroAssembler::unpack_value_args so that it can be used for both packing and unpacking. This makes the logic a little messy, but I think it's still better than having two separate loops for packing and unpacking. The packing logic is quite different than unpacking, so I wasn't able to reuse unpack_value_helper. Instead, I added pack_value_helper. Here's the updated webrev: http://cr.openjdk.java.net/~iklam/valhalla/8222384-c1-calling-convention-floats.v02/ I added a new class ScalarizedValueArgsStream to make it a little easier to iterate over the scalarized args. Maybe we should put this inside signature.hpp? Testing: to make sure I didn't mess up the C2 code, I ran the following tests and they all passed: ??? test/hotspot/jtreg/compiler/valhalla ??? test/hotspot/jtreg/runtime/valhalla ??? test/jdk/valhalla Thanks - Ioi From tobias.hartmann at oracle.com Tue Apr 16 07:04:26 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 16 Apr 2019 09:04:26 +0200 Subject: Build failure ?? In-Reply-To: References: Message-ID: <3e68f2d5-7ee2-d2a5-c196-d35e1228137a@oracle.com> Hi Srikanth, thanks for reporting. Looks like an unresolved merge conflict. I'll fix it. Best regards, Tobias On 16.04.19 05:59, Srikanth wrote: > As of this morning, I am unable to build lworld branch: I have pulled everything from remote repo > and did a fresh configure, clean and when I make I get the error below. > > Any help in getting past this would be appreciated - TIA Srikanth > > Building target 'images' in configuration 'linux-x86_64-server-release' > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In static > member function ?static void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: > error: no matching function for call to ?CallProjections::CallProjections()? > ?????? CallProjections projs; > ?????????????????????? ^~~~~ > In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note: candidate: > CallProjections::CallProjections(uint) > ?? CallProjections(uint nbres) { > ?? ^~~~~~~~~~~~~~~ > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note:?? candidate > expects 1 argument, 0 provided > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note: candidate: > CallProjections::CallProjections(const CallProjections&) > ?class CallProjections { > ?????? ^~~~~~~~~~~~~~~ > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note:?? candidate > expects 1 argument, 0 provided > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1338:53: > error: no matching function for call to ?CallNode::extract_projections(CallProjections*, bool, bool)? > ?????? call->extract_projections(&projs, false, false); > ???????????????????????????????????????????????????? ^ > In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: note: candidate: > CallProjections* CallNode::extract_projections(bool, bool) > ?? CallProjections* extract_projections(bool separate_io_proj, bool do_asserts = true); > ??????????????????? ^~~~~~~~~~~~~~~~~~~ > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: note:?? candidate > expects 2 arguments, 3 provided > lib/CompileJvm.gmk:175: recipe for target > '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' > failed > make[3]: *** > [/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o] > Error 1 > make[3]: *** Waiting for unfinished jobs.... > make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed > make[2]: *** [hotspot-server-libs] Error 2 > > ERROR: Build failed for target 'images' in configuration 'linux-x86_64-server-release' (exit code 2) > > === Output from failing command(s) repeated here === > * For target hotspot_variant-server_libjvm_objs_shenandoahSupport.o: > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In static > member function ?static void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: > error: no matching function for call to ?CallProjections::CallProjections()? > ?????? CallProjections projs; > ?????????????????????? ^~~~~ > In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, > ???????????????? from > /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note: candidate: > CallProjections::CallProjections(uint) > ?? CallProjections(uint nbres) { > ?? ^~~~~~~~~~~~~~~ > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note:?? candidate > expects 1 argument, 0 provided > /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note: candidate: > CallProjections::CallProjections(const CallProjections&) > ?? ... (rest of output omitted) > > * All command lines available in > /home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/make-support/failure-logs. > === End of repeated output === > > === Make failed targets repeated here === > lib/CompileJvm.gmk:175: recipe for target > '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' > failed > make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed > === End of repeated output === > > Hint: Try searching the build log for the name of the first failed target. > Hint: See doc/building.html#troubleshooting for assistance. > > /home/srikanth/valhalla/valhalla/make/Init.gmk:307: recipe for target 'main' failed > make[1]: *** [main] Error 2 > /home/srikanth/valhalla/valhalla/make/Init.gmk:186: recipe for target 'images' failed > make: *** [images] Error 2 From tobias.hartmann at oracle.com Tue Apr 16 07:12:44 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Tue, 16 Apr 2019 07:12:44 +0000 Subject: hg: valhalla/valhalla: 8222523: [lworld] Build failure after merge Message-ID: <201904160712.x3G7Cjbx025648@aojmv0008.oracle.com> Changeset: c6671a6d24bc Author: thartmann Date: 2019-04-16 09:12 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c6671a6d24bc 8222523: [lworld] Build failure after merge ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp From tobias.hartmann at oracle.com Tue Apr 16 07:13:13 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 16 Apr 2019 09:13:13 +0200 Subject: Build failure ?? In-Reply-To: <3e68f2d5-7ee2-d2a5-c196-d35e1228137a@oracle.com> References: <3e68f2d5-7ee2-d2a5-c196-d35e1228137a@oracle.com> Message-ID: <47906ce3-4f0a-f639-9287-b40d6d7a8b03@oracle.com> Fixed: http://hg.openjdk.java.net/valhalla/valhalla/rev/c6671a6d24bc Best regards, Tobias On 16.04.19 09:04, Tobias Hartmann wrote: > Hi Srikanth, > > thanks for reporting. Looks like an unresolved merge conflict. I'll fix it. > > Best regards, > Tobias > > On 16.04.19 05:59, Srikanth wrote: >> As of this morning, I am unable to build lworld branch: I have pulled everything from remote repo >> and did a fresh configure, clean and when I make I get the error below. >> >> Any help in getting past this would be appreciated - TIA Srikanth >> >> Building target 'images' in configuration 'linux-x86_64-server-release' >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In static >> member function ?static void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: >> error: no matching function for call to ?CallProjections::CallProjections()? >> ?????? CallProjections projs; >> ?????????????????????? ^~~~~ >> In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note: candidate: >> CallProjections::CallProjections(uint) >> ?? CallProjections(uint nbres) { >> ?? ^~~~~~~~~~~~~~~ >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note:?? candidate >> expects 1 argument, 0 provided >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note: candidate: >> CallProjections::CallProjections(const CallProjections&) >> ?class CallProjections { >> ?????? ^~~~~~~~~~~~~~~ >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note:?? candidate >> expects 1 argument, 0 provided >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1338:53: >> error: no matching function for call to ?CallNode::extract_projections(CallProjections*, bool, bool)? >> ?????? call->extract_projections(&projs, false, false); >> ???????????????????????????????????????????????????? ^ >> In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: note: candidate: >> CallProjections* CallNode::extract_projections(bool, bool) >> ?? CallProjections* extract_projections(bool separate_io_proj, bool do_asserts = true); >> ??????????????????? ^~~~~~~~~~~~~~~~~~~ >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: note:?? candidate >> expects 2 arguments, 3 provided >> lib/CompileJvm.gmk:175: recipe for target >> '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' >> failed >> make[3]: *** >> [/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o] >> Error 1 >> make[3]: *** Waiting for unfinished jobs.... >> make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed >> make[2]: *** [hotspot-server-libs] Error 2 >> >> ERROR: Build failed for target 'images' in configuration 'linux-x86_64-server-release' (exit code 2) >> >> === Output from failing command(s) repeated here === >> * For target hotspot_variant-server_libjvm_objs_shenandoahSupport.o: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In static >> member function ?static void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: >> error: no matching function for call to ?CallProjections::CallProjections()? >> ?????? CallProjections projs; >> ?????????????????????? ^~~~~ >> In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note: candidate: >> CallProjections::CallProjections(uint) >> ?? CallProjections(uint nbres) { >> ?? ^~~~~~~~~~~~~~~ >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note:?? candidate >> expects 1 argument, 0 provided >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note: candidate: >> CallProjections::CallProjections(const CallProjections&) >> ?? ... (rest of output omitted) >> >> * All command lines available in >> /home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/make-support/failure-logs. >> === End of repeated output === >> >> === Make failed targets repeated here === >> lib/CompileJvm.gmk:175: recipe for target >> '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' >> failed >> make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed >> === End of repeated output === >> >> Hint: Try searching the build log for the name of the first failed target. >> Hint: See doc/building.html#troubleshooting for assistance. >> >> /home/srikanth/valhalla/valhalla/make/Init.gmk:307: recipe for target 'main' failed >> make[1]: *** [main] Error 2 >> /home/srikanth/valhalla/valhalla/make/Init.gmk:186: recipe for target 'images' failed >> make: *** [images] Error 2 From david.simms at oracle.com Tue Apr 16 08:09:51 2019 From: david.simms at oracle.com (David Simms) Date: Tue, 16 Apr 2019 10:09:51 +0200 Subject: Build failure ?? In-Reply-To: <3e68f2d5-7ee2-d2a5-c196-d35e1228137a@oracle.com> References: <3e68f2d5-7ee2-d2a5-c196-d35e1228137a@oracle.com> Message-ID: <81108d7f-11f9-969a-b758-508aae6d37f8@oracle.com> Thanks Tobias, my bad, build config I had doesn't include Shenandoah...btw, Valhalla only supports write barriers, and has yet to adapt to the heap access API, so Z and Shenandoah won't function as it is. Sorry for the hassle. /Mr. Simms On 16/04/19 9:04 AM, Tobias Hartmann wrote: > Hi Srikanth, > > thanks for reporting. Looks like an unresolved merge conflict. I'll fix it. > > Best regards, > Tobias > > On 16.04.19 05:59, Srikanth wrote: >> As of this morning, I am unable to build lworld branch: I have pulled everything from remote repo >> and did a fresh configure, clean and when I make I get the error below. >> >> Any help in getting past this would be appreciated - TIA Srikanth >> >> Building target 'images' in configuration 'linux-x86_64-server-release' >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In static >> member function ?static void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: >> error: no matching function for call to ?CallProjections::CallProjections()? >> ?????? CallProjections projs; >> ?????????????????????? ^~~~~ >> In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note: candidate: >> CallProjections::CallProjections(uint) >> ?? CallProjections(uint nbres) { >> ?? ^~~~~~~~~~~~~~~ >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note:?? candidate >> expects 1 argument, 0 provided >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note: candidate: >> CallProjections::CallProjections(const CallProjections&) >> ?class CallProjections { >> ?????? ^~~~~~~~~~~~~~~ >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note:?? candidate >> expects 1 argument, 0 provided >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1338:53: >> error: no matching function for call to ?CallNode::extract_projections(CallProjections*, bool, bool)? >> ?????? call->extract_projections(&projs, false, false); >> ???????????????????????????????????????????????????? ^ >> In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: note: candidate: >> CallProjections* CallNode::extract_projections(bool, bool) >> ?? CallProjections* extract_projections(bool separate_io_proj, bool do_asserts = true); >> ??????????????????? ^~~~~~~~~~~~~~~~~~~ >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:657:20: note:?? candidate >> expects 2 arguments, 3 provided >> lib/CompileJvm.gmk:175: recipe for target >> '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' >> failed >> make[3]: *** >> [/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o] >> Error 1 >> make[3]: *** Waiting for unfinished jobs.... >> make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed >> make[2]: *** [hotspot-server-libs] Error 2 >> >> ERROR: Build failed for target 'images' in configuration 'linux-x86_64-server-release' (exit code 2) >> >> === Output from failing command(s) repeated here === >> * For target hotspot_variant-server_libjvm_objs_shenandoahSupport.o: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp: In static >> member function ?static void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop*)?: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:1337:23: >> error: no matching function for call to ?CallProjections::CallProjections()? >> ?????? CallProjections projs; >> ?????????????????????? ^~~~~ >> In file included from /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/graphKit.hpp:32:0, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp:30, >> ???????????????? from >> /home/srikanth/valhalla/valhalla/src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp:26: >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note: candidate: >> CallProjections::CallProjections(uint) >> ?? CallProjections(uint nbres) { >> ?? ^~~~~~~~~~~~~~~ >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:558:3: note:?? candidate >> expects 1 argument, 0 provided >> /home/srikanth/valhalla/valhalla/src/hotspot/share/opto/callnode.hpp:545:7: note: candidate: >> CallProjections::CallProjections(const CallProjections&) >> ?? ... (rest of output omitted) >> >> * All command lines available in >> /home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/make-support/failure-logs. >> === End of repeated output === >> >> === Make failed targets repeated here === >> lib/CompileJvm.gmk:175: recipe for target >> '/home/srikanth/valhalla/valhalla/build/linux-x86_64-server-release/hotspot/variant-server/libjvm/objs/shenandoahSupport.o' >> failed >> make/Main.gmk:257: recipe for target 'hotspot-server-libs' failed >> === End of repeated output === >> >> Hint: Try searching the build log for the name of the first failed target. >> Hint: See doc/building.html#troubleshooting for assistance. >> >> /home/srikanth/valhalla/valhalla/make/Init.gmk:307: recipe for target 'main' failed >> make[1]: *** [main] Error 2 >> /home/srikanth/valhalla/valhalla/make/Init.gmk:186: recipe for target 'images' failed >> make: *** [images] Error 2 From david.simms at oracle.com Tue Apr 16 08:46:24 2019 From: david.simms at oracle.com (David Simms) Date: Tue, 16 Apr 2019 10:46:24 +0200 Subject: RFR(L): JDK-8222525 : [lworld] Runtime support for LW2 Arrays Message-ID: Please review runtime support for LW2 array covariance[1]: http://cr.openjdk.java.net/~dsimms/valhalla/lw2_arrays/webrev5/ Further testing is needed, but requires javac (for ease of writing) /David Simms [1] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-April/005600.html From srikanth.adayapalam at oracle.com Tue Apr 16 12:02:15 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Tue, 16 Apr 2019 12:02:15 +0000 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes Message-ID: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> Changeset: bf52db1ad4ea Author: sadayapalam Date: 2019-04-16 17:31 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea 8221545: [lworld] Preliminary support for alternate denotation of values and boxes ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java ! test/langtools/tools/javac/valhalla/lworld-values/Point.java From srikanth.adayapalam at oracle.com Tue Apr 16 12:09:00 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Tue, 16 Apr 2019 17:39:00 +0530 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> Message-ID: Notes: ??? - This is the initial commit for supporting V? notation as an alternate for V.box ??? - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. ??? - Existing javac tests have been replicated to use the V? syntax. ??? - VBC migration related work is not done yet. ??? - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? ?????? in? v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather ?????? than as denoting nullability. ??? - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. ??? - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up ????? ticket to address this. ??? - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. Thanks! Srikanth On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: > Changeset: bf52db1ad4ea > Author: sadayapalam > Date: 2019-04-16 17:31 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea > > 8221545: [lworld] Preliminary support for alternate denotation of values and boxes > > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java > ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java > + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java > + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java > + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out > ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java > + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java > + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java > ! test/langtools/tools/javac/valhalla/lworld-values/Point.java > From tobias.hartmann at oracle.com Tue Apr 16 12:35:10 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 16 Apr 2019 14:35:10 +0200 Subject: RFR 8222384 [lworld] Calling convention - C2 to C1 (floating point params) In-Reply-To: <05ba294c-b3f2-f07b-afa6-4f2373b59d6f@oracle.com> References: <7811a03b-ea92-658f-aa41-2001c5445b92@oracle.com> <05ba294c-b3f2-f07b-afa6-4f2373b59d6f@oracle.com> Message-ID: <3ed33dcf-12d2-3b00-fd5b-fa977d76643c@oracle.com> Hi Ioi, this looks good to me! On 16.04.19 08:25, Ioi Lam wrote: > I added a new class ScalarizedValueArgsStream to make it a little easier to iterate over the > scalarized args. Maybe we should put this inside signature.hpp? Yes, I think that's a good idea. Best regards, Tobias From tobias.hartmann at oracle.com Tue Apr 16 12:47:33 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 16 Apr 2019 14:47:33 +0200 Subject: RFR(L): JDK-8222525 : [lworld] Runtime support for LW2 Arrays In-Reply-To: References: Message-ID: <8101ae31-4b19-d6e2-9c42-34ffe9fdd026@oracle.com> Hi Mr. Simms, On 16.04.19 10:46, David Simms wrote: > Please review runtime support for LW2 array covariance[1]: > > http://cr.openjdk.java.net/~dsimms/valhalla/lw2_arrays/webrev5/ This looks good to me and works well with my C2 fix [1]. > Further testing is needed, but requires javac (for ease of writing) Yes, as soon as javac supports widening of [Q to [L, we need to implement runtime and JIT support for that (and add tests). A quick javac hack that I did suggests that some sophisticated changes are required to support widening. Thanks, Tobias [1] http://mail.openjdk.java.net/pipermail/valhalla-dev/2019-April/005590.html From brian.goetz at oracle.com Tue Apr 16 13:24:19 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 16 Apr 2019 09:24:19 -0400 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> Message-ID: <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> Is the conversion from V to V? still considered a boxing conversion, or is it a widening conversion now? The language we (currently think we) want is V <: V? In the other direction, we?re still discussing whether the narrowing conversion is implicit or explicit. > On Apr 16, 2019, at 8:09 AM, Srikanth wrote: > > Notes: > > - This is the initial commit for supporting V? notation as an alternate for V.box > - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. > - Existing javac tests have been replicated to use the V? syntax. > - VBC migration related work is not done yet. > - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? > in v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather > than as denoting nullability. > - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. > - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up > ticket to address this. > - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. > > Thanks! > Srikanth > > On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >> Changeset: bf52db1ad4ea >> Author: sadayapalam >> Date: 2019-04-16 17:31 +0530 >> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >> >> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >> >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >> > From karen.kinnear at oracle.com Tue Apr 16 14:02:22 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Tue, 16 Apr 2019 10:02:22 -0400 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> Message-ID: <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> Brian, This was a request for LW2 - no more boxing. We asked for the subtype relationship for both values and for arrays. For LW2 - we requested explicit checkcasts on attempts to narrow. Agreed that there are discussions about where this is all going after LW2 before LW10. thanks, Karen > On Apr 16, 2019, at 9:24 AM, Brian Goetz wrote: > > Is the conversion from V to V? still considered a boxing conversion, or is it a widening conversion now? The language we (currently think we) want is > > V <: V? > > In the other direction, we?re still discussing whether the narrowing conversion is implicit or explicit. > >> On Apr 16, 2019, at 8:09 AM, Srikanth wrote: >> >> Notes: >> >> - This is the initial commit for supporting V? notation as an alternate for V.box >> - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. >> - Existing javac tests have been replicated to use the V? syntax. >> - VBC migration related work is not done yet. >> - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? >> in v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather >> than as denoting nullability. >> - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. >> - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up >> ticket to address this. >> - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. >> >> Thanks! >> Srikanth >> >> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>> Changeset: bf52db1ad4ea >>> Author: sadayapalam >>> Date: 2019-04-16 17:31 +0530 >>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>> >>> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >>> >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>> >> > From brian.goetz at oracle.com Tue Apr 16 14:02:45 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 16 Apr 2019 10:02:45 -0400 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> Message-ID: > > This was a request for LW2 - no more boxing. Right. I was wondering whether we got there yet, or whether we?d just change the notation to start. > We asked for the subtype relationship for both values and for arrays. For arrays, the covariance rule: T <: U imples T[] <: U[] ? should hold uniformly. No need for special exceptions for value arrays. Since V <: Object and V? <: Object then both V[] and V?[] are <: Object[]. > > For LW2 - we requested explicit checkcasts on attempts to narrow. > > Agreed that there are discussions about where this is all going after LW2 before LW10. > > thanks, > Karen > >> On Apr 16, 2019, at 9:24 AM, Brian Goetz wrote: >> >> Is the conversion from V to V? still considered a boxing conversion, or is it a widening conversion now? The language we (currently think we) want is >> >> V <: V? >> >> In the other direction, we?re still discussing whether the narrowing conversion is implicit or explicit. >> >>> On Apr 16, 2019, at 8:09 AM, Srikanth wrote: >>> >>> Notes: >>> >>> - This is the initial commit for supporting V? notation as an alternate for V.box >>> - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. >>> - Existing javac tests have been replicated to use the V? syntax. >>> - VBC migration related work is not done yet. >>> - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? >>> in v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather >>> than as denoting nullability. >>> - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. >>> - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up >>> ticket to address this. >>> - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. >>> >>> Thanks! >>> Srikanth >>> >>> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>>> Changeset: bf52db1ad4ea >>>> Author: sadayapalam >>>> Date: 2019-04-16 17:31 +0530 >>>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>>> >>>> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >>>> >>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>>> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>>> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>>> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>>> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>>> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>>> >>> >> > From srikanth.adayapalam at oracle.com Tue Apr 16 14:18:36 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Tue, 16 Apr 2019 19:48:36 +0530 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> Message-ID: <33652a65-4d80-03b5-30c1-40793d37fd40@oracle.com> This change set just introduces the new notation doing nothing new about inserting casts. I will go through the mails discussing this and follow up on a different change set. Thanks Srikanth On 16/04/19 7:32 PM, Brian Goetz wrote: >> This was a request for LW2 - no more boxing. > Right. I was wondering whether we got there yet, or whether we?d just change the notation to start. > >> We asked for the subtype relationship for both values and for arrays. > For arrays, the covariance rule: T <: U imples T[] <: U[] ? should hold uniformly. No need for special exceptions for value arrays. Since > > V <: Object > and > V? <: Object > > then both V[] and V?[] are <: Object[]. > > > >> For LW2 - we requested explicit checkcasts on attempts to narrow. >> >> Agreed that there are discussions about where this is all going after LW2 before LW10. >> >> thanks, >> Karen >> >>> On Apr 16, 2019, at 9:24 AM, Brian Goetz wrote: >>> >>> Is the conversion from V to V? still considered a boxing conversion, or is it a widening conversion now? The language we (currently think we) want is >>> >>> V <: V? >>> >>> In the other direction, we?re still discussing whether the narrowing conversion is implicit or explicit. >>> >>>> On Apr 16, 2019, at 8:09 AM, Srikanth wrote: >>>> >>>> Notes: >>>> >>>> - This is the initial commit for supporting V? notation as an alternate for V.box >>>> - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. >>>> - Existing javac tests have been replicated to use the V? syntax. >>>> - VBC migration related work is not done yet. >>>> - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? >>>> in v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather >>>> than as denoting nullability. >>>> - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. >>>> - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up >>>> ticket to address this. >>>> - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. >>>> >>>> Thanks! >>>> Srikanth >>>> >>>> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>>>> Changeset: bf52db1ad4ea >>>>> Author: sadayapalam >>>>> Date: 2019-04-16 17:31 +0530 >>>>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>>>> >>>>> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >>>>> >>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>>>> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>>>> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>>>> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>>>> From brian.goetz at oracle.com Tue Apr 16 14:20:58 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 16 Apr 2019 10:20:58 -0400 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: <33652a65-4d80-03b5-30c1-40793d37fd40@oracle.com> References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> <33652a65-4d80-03b5-30c1-40793d37fd40@oracle.com> Message-ID: <79031832-57CB-4ADF-97CE-1C7DFF70403D@oracle.com> OK, thanks. Hopefully the new rules will be simpler, as they lean more heavily on subtyping. > On Apr 16, 2019, at 10:18 AM, Srikanth wrote: > > > This change set just introduces the new notation doing nothing new about inserting casts. > I will go through the mails discussing this and follow up on a different change set. > > Thanks > Srikanth > On 16/04/19 7:32 PM, Brian Goetz wrote: >>> This was a request for LW2 - no more boxing. >> Right. I was wondering whether we got there yet, or whether we?d just change the notation to start. >> >>> We asked for the subtype relationship for both values and for arrays. >> For arrays, the covariance rule: T <: U imples T[] <: U[] ? should hold uniformly. No need for special exceptions for value arrays. Since >> >> V <: Object >> and >> V? <: Object >> >> then both V[] and V?[] are <: Object[]. >> >> >> >>> For LW2 - we requested explicit checkcasts on attempts to narrow. >>> >>> Agreed that there are discussions about where this is all going after LW2 before LW10. >>> >>> thanks, >>> Karen >>> >>>> On Apr 16, 2019, at 9:24 AM, Brian Goetz wrote: >>>> >>>> Is the conversion from V to V? still considered a boxing conversion, or is it a widening conversion now? The language we (currently think we) want is >>>> >>>> V <: V? >>>> >>>> In the other direction, we?re still discussing whether the narrowing conversion is implicit or explicit. >>>> >>>>> On Apr 16, 2019, at 8:09 AM, Srikanth wrote: >>>>> >>>>> Notes: >>>>> >>>>> - This is the initial commit for supporting V? notation as an alternate for V.box >>>>> - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. >>>>> - Existing javac tests have been replicated to use the V? syntax. >>>>> - VBC migration related work is not done yet. >>>>> - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? >>>>> in v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather >>>>> than as denoting nullability. >>>>> - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. >>>>> - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up >>>>> ticket to address this. >>>>> - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. >>>>> >>>>> Thanks! >>>>> Srikanth >>>>> >>>>> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>>>>> Changeset: bf52db1ad4ea >>>>>> Author: sadayapalam >>>>>> Date: 2019-04-16 17:31 +0530 >>>>>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>>>>> >>>>>> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >>>>>> >>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>>>>> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>>>>> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>>>>> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>>>>> > From srikanth.adayapalam at oracle.com Tue Apr 16 14:30:11 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Tue, 16 Apr 2019 20:00:11 +0530 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: <79031832-57CB-4ADF-97CE-1C7DFF70403D@oracle.com> References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> <33652a65-4d80-03b5-30c1-40793d37fd40@oracle.com> <79031832-57CB-4ADF-97CE-1C7DFF70403D@oracle.com> Message-ID: <8185519c-9d60-27ed-4ebc-5b6d2adf9bc8@oracle.com> On a quick check, I see that on both directions, we have a compiler inserted cast. As I understand, assignment of V to V? being a widening conversion, the cast should go away while the other direction is still being debated. This should be straightforward. Srikanth On 16/04/19 7:50 PM, Brian Goetz wrote: > OK, thanks. Hopefully the new rules will be simpler, as they lean more heavily on subtyping. > > >> On Apr 16, 2019, at 10:18 AM, Srikanth wrote: >> >> >> This change set just introduces the new notation doing nothing new about inserting casts. >> I will go through the mails discussing this and follow up on a different change set. >> >> Thanks >> Srikanth >> On 16/04/19 7:32 PM, Brian Goetz wrote: >>>> This was a request for LW2 - no more boxing. >>> Right. I was wondering whether we got there yet, or whether we?d just change the notation to start. >>> >>>> We asked for the subtype relationship for both values and for arrays. >>> For arrays, the covariance rule: T <: U imples T[] <: U[] ? should hold uniformly. No need for special exceptions for value arrays. Since >>> >>> V <: Object >>> and >>> V? <: Object >>> >>> then both V[] and V?[] are <: Object[]. >>> >>> >>> >>>> For LW2 - we requested explicit checkcasts on attempts to narrow. >>>> >>>> Agreed that there are discussions about where this is all going after LW2 before LW10. >>>> >>>> thanks, >>>> Karen >>>> >>>>> On Apr 16, 2019, at 9:24 AM, Brian Goetz wrote: >>>>> >>>>> Is the conversion from V to V? still considered a boxing conversion, or is it a widening conversion now? The language we (currently think we) want is >>>>> >>>>> V <: V? >>>>> >>>>> In the other direction, we?re still discussing whether the narrowing conversion is implicit or explicit. >>>>> >>>>>> On Apr 16, 2019, at 8:09 AM, Srikanth wrote: >>>>>> >>>>>> Notes: >>>>>> >>>>>> - This is the initial commit for supporting V? notation as an alternate for V.box >>>>>> - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. >>>>>> - Existing javac tests have been replicated to use the V? syntax. >>>>>> - VBC migration related work is not done yet. >>>>>> - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? >>>>>> in v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather >>>>>> than as denoting nullability. >>>>>> - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. >>>>>> - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up >>>>>> ticket to address this. >>>>>> - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. >>>>>> >>>>>> Thanks! >>>>>> Srikanth >>>>>> >>>>>> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>>>>>> Changeset: bf52db1ad4ea >>>>>>> Author: sadayapalam >>>>>>> Date: 2019-04-16 17:31 +0530 >>>>>>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>>>>>> >>>>>>> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >>>>>>> >>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>>>>>> From brian.goetz at oracle.com Tue Apr 16 14:37:32 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 16 Apr 2019 10:37:32 -0400 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: <8185519c-9d60-27ed-4ebc-5b6d2adf9bc8@oracle.com> References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> <33652a65-4d80-03b5-30c1-40793d37fd40@oracle.com> <79031832-57CB-4ADF-97CE-1C7DFF70403D@oracle.com> <8185519c-9d60-27ed-4ebc-5b6d2adf9bc8@oracle.com> Message-ID: Let?s separate the language and VM aspects. In the language, since V <: V?, no cast is needed when assigning a V to a V?. And no CHECKCAST is needed for the corresponding code generation. In the other direction, a CHECKCAST is definitely needed going from V? to V; the question of whether the _language_ requires an explicit cast is still up in the air. I think we should lean on explicit casting for now, but I suspect we?ll slide back to implicit narrowing (with possible NPE). This also makes a difference for overload selection. If I have: m(Object o) { } m(V? v) { } and a call V v = ? m(v) Under the old (V.box) interpretation, we?d prefer the m(Object) overload, since it is applicable without a boxing conversion, and m(V?) would not be. But under the new (subtyping) interpretation, we should treat them both as applicable, and V? is _more specific_ than OIbject, so we pick m(V?). > On Apr 16, 2019, at 10:30 AM, Srikanth wrote: > > On a quick check, I see that on both directions, we have a compiler inserted cast. > As I understand, assignment of V to V? being a widening conversion, the cast should go away while > the other direction is still being debated. > > This should be straightforward. > > Srikanth > > On 16/04/19 7:50 PM, Brian Goetz wrote: >> OK, thanks. Hopefully the new rules will be simpler, as they lean more heavily on subtyping. >> >> >>> On Apr 16, 2019, at 10:18 AM, Srikanth wrote: >>> >>> >>> This change set just introduces the new notation doing nothing new about inserting casts. >>> I will go through the mails discussing this and follow up on a different change set. >>> >>> Thanks >>> Srikanth >>> On 16/04/19 7:32 PM, Brian Goetz wrote: >>>>> This was a request for LW2 - no more boxing. >>>> Right. I was wondering whether we got there yet, or whether we?d just change the notation to start. >>>> >>>>> We asked for the subtype relationship for both values and for arrays. >>>> For arrays, the covariance rule: T <: U imples T[] <: U[] ? should hold uniformly. No need for special exceptions for value arrays. Since >>>> >>>> V <: Object >>>> and >>>> V? <: Object >>>> >>>> then both V[] and V?[] are <: Object[]. >>>> >>>> >>>> >>>>> For LW2 - we requested explicit checkcasts on attempts to narrow. >>>>> >>>>> Agreed that there are discussions about where this is all going after LW2 before LW10. >>>>> >>>>> thanks, >>>>> Karen >>>>> >>>>>> On Apr 16, 2019, at 9:24 AM, Brian Goetz wrote: >>>>>> >>>>>> Is the conversion from V to V? still considered a boxing conversion, or is it a widening conversion now? The language we (currently think we) want is >>>>>> >>>>>> V <: V? >>>>>> >>>>>> In the other direction, we?re still discussing whether the narrowing conversion is implicit or explicit. >>>>>> >>>>>>> On Apr 16, 2019, at 8:09 AM, Srikanth wrote: >>>>>>> >>>>>>> Notes: >>>>>>> >>>>>>> - This is the initial commit for supporting V? notation as an alternate for V.box >>>>>>> - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. >>>>>>> - Existing javac tests have been replicated to use the V? syntax. >>>>>>> - VBC migration related work is not done yet. >>>>>>> - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? >>>>>>> in v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather >>>>>>> than as denoting nullability. >>>>>>> - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. >>>>>>> - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up >>>>>>> ticket to address this. >>>>>>> - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. >>>>>>> >>>>>>> Thanks! >>>>>>> Srikanth >>>>>>> >>>>>>> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>>>>>>> Changeset: bf52db1ad4ea >>>>>>>> Author: sadayapalam >>>>>>>> Date: 2019-04-16 17:31 +0530 >>>>>>>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>>>>>>> >>>>>>>> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >>>>>>>> >>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>>>>>>> > From srikanth.adayapalam at oracle.com Tue Apr 16 14:53:48 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Tue, 16 Apr 2019 20:23:48 +0530 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> <33652a65-4d80-03b5-30c1-40793d37fd40@oracle.com> <79031832-57CB-4ADF-97CE-1C7DFF70403D@oracle.com> <8185519c-9d60-27ed-4ebc-5b6d2adf9bc8@oracle.com> Message-ID: <4d71f1ca-411d-26ed-2119-ca444b787c93@oracle.com> Sounds good. I will work on implementing these (except for the source level express cast). I expect to have a fix by early next week. Thanks Srikanth On 16/04/19 8:07 PM, Brian Goetz wrote: > Let?s separate the language and VM aspects. > > In the language, since V <: V?, no cast is needed when assigning a V to a V?. And no CHECKCAST is needed for the corresponding code generation. > > In the other direction, a CHECKCAST is definitely needed going from V? to V; the question of whether the _language_ requires an explicit cast is still up in the air. I think we should lean on explicit casting for now, but I suspect we?ll slide back to implicit narrowing (with possible NPE). > > This also makes a difference for overload selection. If I have: > > m(Object o) { } > m(V? v) { } > > and a call > > V v = ? > m(v) > > Under the old (V.box) interpretation, we?d prefer the m(Object) overload, since it is applicable without a boxing conversion, and m(V?) would not be. But under the new (subtyping) interpretation, we should treat them both as applicable, and V? is _more specific_ than OIbject, so we pick m(V?). > > > >> On Apr 16, 2019, at 10:30 AM, Srikanth wrote: >> >> On a quick check, I see that on both directions, we have a compiler inserted cast. >> As I understand, assignment of V to V? being a widening conversion, the cast should go away while >> the other direction is still being debated. >> >> This should be straightforward. >> >> Srikanth >> >> On 16/04/19 7:50 PM, Brian Goetz wrote: >>> OK, thanks. Hopefully the new rules will be simpler, as they lean more heavily on subtyping. >>> >>> >>>> On Apr 16, 2019, at 10:18 AM, Srikanth wrote: >>>> >>>> >>>> This change set just introduces the new notation doing nothing new about inserting casts. >>>> I will go through the mails discussing this and follow up on a different change set. >>>> >>>> Thanks >>>> Srikanth >>>> On 16/04/19 7:32 PM, Brian Goetz wrote: >>>>>> This was a request for LW2 - no more boxing. >>>>> Right. I was wondering whether we got there yet, or whether we?d just change the notation to start. >>>>> >>>>>> We asked for the subtype relationship for both values and for arrays. >>>>> For arrays, the covariance rule: T <: U imples T[] <: U[] ? should hold uniformly. No need for special exceptions for value arrays. Since >>>>> >>>>> V <: Object >>>>> and >>>>> V? <: Object >>>>> >>>>> then both V[] and V?[] are <: Object[]. >>>>> >>>>> >>>>> >>>>>> For LW2 - we requested explicit checkcasts on attempts to narrow. >>>>>> >>>>>> Agreed that there are discussions about where this is all going after LW2 before LW10. >>>>>> >>>>>> thanks, >>>>>> Karen >>>>>> >>>>>>> On Apr 16, 2019, at 9:24 AM, Brian Goetz wrote: >>>>>>> >>>>>>> Is the conversion from V to V? still considered a boxing conversion, or is it a widening conversion now? The language we (currently think we) want is >>>>>>> >>>>>>> V <: V? >>>>>>> >>>>>>> In the other direction, we?re still discussing whether the narrowing conversion is implicit or explicit. >>>>>>> >>>>>>>> On Apr 16, 2019, at 8:09 AM, Srikanth wrote: >>>>>>>> >>>>>>>> Notes: >>>>>>>> >>>>>>>> - This is the initial commit for supporting V? notation as an alternate for V.box >>>>>>>> - The old .box and .val notation is not withdrawn yet and can still be used, but we should really move over to the new syntax as soon as possible. >>>>>>>> - Existing javac tests have been replicated to use the V? syntax. >>>>>>>> - VBC migration related work is not done yet. >>>>>>>> - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? >>>>>>>> in v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional rather >>>>>>>> than as denoting nullability. >>>>>>>> - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE colorcoding can address this issue. >>>>>>>> - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a follow up >>>>>>>> ticket to address this. >>>>>>>> - More testing is required and will be undertaken in the coming weeks. I request/encourage testing by the interested parties too. >>>>>>>> >>>>>>>> Thanks! >>>>>>>> Srikanth >>>>>>>> >>>>>>>> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>>>>>>>> Changeset: bf52db1ad4ea >>>>>>>>> Author: sadayapalam >>>>>>>>> Date: 2019-04-16 17:31 +0530 >>>>>>>>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>>>>>>>> >>>>>>>>> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >>>>>>>>> >>>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>>>>>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>>>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>>>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>>>>>>>> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>>>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>>>>>>>> From tobias.hartmann at oracle.com Wed Apr 17 07:30:54 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Wed, 17 Apr 2019 07:30:54 +0000 Subject: hg: valhalla/valhalla: 8222631: [lworld] Reserved entry in signature prevents incremental inlining Message-ID: <201904170730.x3H7UsC2004418@aojmv0008.oracle.com> Changeset: 95cedaefc6f1 Author: thartmann Date: 2019-04-17 09:30 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/95cedaefc6f1 8222631: [lworld] Reserved entry in signature prevents incremental inlining ! src/hotspot/share/opto/callGenerator.cpp From tobias.hartmann at oracle.com Wed Apr 17 07:32:57 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 17 Apr 2019 09:32:57 +0200 Subject: hg: valhalla/valhalla: 8222631: [lworld] Reserved entry in signature prevents incremental inlining In-Reply-To: <201904170730.x3H7UsC2004418@aojmv0008.oracle.com> References: <201904170730.x3H7UsC2004418@aojmv0008.oracle.com> Message-ID: <06f690b2-d3af-85cd-c12d-1e431d2e65e3@oracle.com> Details: LateInlineCallGenerator::do_late_inline() bails out from late inlining if one of the arguments is top. The code needs to ignore reserved entries which are always top. This is triggered by JDK-8222632 which replaces all usages of __WithField with a constructor call which then sometimes fails to inline. Best regards, Tobias On 17.04.19 09:30, tobias.hartmann at oracle.com wrote: > Changeset: 95cedaefc6f1 > Author: thartmann > Date: 2019-04-17 09:30 +0200 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/95cedaefc6f1 > > 8222631: [lworld] Reserved entry in signature prevents incremental inlining > > ! src/hotspot/share/opto/callGenerator.cpp > From tobias.hartmann at oracle.com Wed Apr 17 07:37:19 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Wed, 17 Apr 2019 07:37:19 +0000 Subject: hg: valhalla/valhalla: 8222632: [lworld] Remove usages of __WithField from compiler tests Message-ID: <201904170737.x3H7bKjI006206@aojmv0008.oracle.com> Changeset: 0841eb446b9e Author: thartmann Date: 2019-04-17 09:37 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0841eb446b9e 8222632: [lworld] Remove usages of __WithField from compiler tests ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue1.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue2.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue3.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue4.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestArrays.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestBasicFunctionality.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConvention.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestIntrinsics.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestJNICalls.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestMethodHandles.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableValueTypes.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestOnStackReplacement.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestUnloadedValueTypeArray.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestUnloadedValueTypeField.java From tobias.hartmann at oracle.com Wed Apr 17 08:09:40 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 17 Apr 2019 10:09:40 +0200 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> Message-ID: Hi Srikanth, while trying to convert the JIT tests, I've noticed that some usages of ? fail to compile with javac. I've filed: https://bugs.openjdk.java.net/browse/JDK-8222634 Thanks, Tobias On 16.04.19 14:09, Srikanth wrote: > Notes: > > ??? - This is the initial commit for supporting V? notation as an alternate for V.box > ??? - The old .box and .val notation is not withdrawn yet and can still be used, but we should > really move over to the new syntax as soon as possible. > ??? - Existing javac tests have been replicated to use the V? syntax. > ??? - VBC migration related work is not done yet. > ??? - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? > ?????? in? v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional > rather > ?????? than as denoting nullability. > ??? - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE > colorcoding can address this issue. > ??? - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a > follow up > ????? ticket to address this. > ??? - More testing is required and will be undertaken in the coming weeks. I request/encourage > testing by the interested parties too. > > Thanks! > Srikanth > > On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >> Changeset: bf52db1ad4ea >> Author:??? sadayapalam >> Date:????? 2019-04-16 17:31 +0530 >> URL:?????? http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >> >> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >> >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >> > From srikanth.adayapalam at oracle.com Wed Apr 17 09:03:39 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Wed, 17 Apr 2019 14:33:39 +0530 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> Message-ID: <47e834fd-ade0-bcf8-04e9-c8cab90263af@oracle.com> Thanks Tobias, I am on it. Srikanth On 17/04/19 1:39 PM, Tobias Hartmann wrote: > Hi Srikanth, > > while trying to convert the JIT tests, I've noticed that some usages of ? fail to compile with > javac. I've filed: https://bugs.openjdk.java.net/browse/JDK-8222634 > > Thanks, > Tobias > > On 16.04.19 14:09, Srikanth wrote: >> Notes: >> >> ??? - This is the initial commit for supporting V? notation as an alternate for V.box >> ??? - The old .box and .val notation is not withdrawn yet and can still be used, but we should >> really move over to the new syntax as soon as possible. >> ??? - Existing javac tests have been replicated to use the V? syntax. >> ??? - VBC migration related work is not done yet. >> ??? - One issue that showed up in the parser implementation is the ambiguity at the point of seeing ? >> ?????? in? v instanceof Type? exp: exp2; I have arranged for this to be processed as a conditional >> rather >> ?????? than as denoting nullability. >> ??? - On a long value type name the ? suffix does not really stand out ATM, but I guess IDE >> colorcoding can address this issue. >> ??? - There is one failing test in the langtools suite (jdk/jshell/TypeNameTest.java) I will raise a >> follow up >> ????? ticket to address this. >> ??? - More testing is required and will be undertaken in the coming weeks. I request/encourage >> testing by the interested parties too. >> >> Thanks! >> Srikanth >> >> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>> Changeset: bf52db1ad4ea >>> Author:??? sadayapalam >>> Date:????? 2019-04-16 17:31 +0530 >>> URL:?????? http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>> >>> 8221545: [lworld] Preliminary support for alternate denotation of values and boxes >>> >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>> + test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>> + test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>> + test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>> + test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>> From srikanth.adayapalam at oracle.com Wed Apr 17 12:01:18 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Wed, 17 Apr 2019 12:01:18 +0000 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. Message-ID: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> Changeset: 2e5ecb20aa24 Author: sadayapalam Date: 2019-04-17 17:31 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2e5ecb20aa24 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java + test/langtools/tools/javac/valhalla/lworld-values/CheckFieldDescriptors.java From srikanth.adayapalam at oracle.com Wed Apr 17 12:51:57 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Wed, 17 Apr 2019 12:51:57 +0000 Subject: hg: valhalla/valhalla: 8222634: [lworld] Additional tests for various code snippets that were incorrectly failing to compile. Message-ID: <201904171251.x3HCpwsA001081@aojmv0008.oracle.com> Changeset: 89395b0fea27 Author: sadayapalam Date: 2019-04-17 18:21 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/89395b0fea27 8222634: [lworld] Additional tests for various code snippets that were incorrectly failing to compile. + test/langtools/tools/javac/valhalla/lworld-values/AssortedTests.java From srikanth.adayapalam at oracle.com Wed Apr 17 13:03:22 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Wed, 17 Apr 2019 18:33:22 +0530 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> Message-ID: <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> Hi Tobias, This change set fixes 4 problems you had reported in https://bugs.openjdk.java.net/browse/JDK-8222634: 1. The following code snippet compiles fine now: value class MyValue1 { ????final int x = 0; } public class Test { ????static final MyValue1 vField = new MyValue1(); ????value class MyValue2 { ????????final MyValue1? vBoxField; ????????public MyValue2() { ????????????vBoxField = new MyValue1(); ????????} ????} ????public static void main(String[] args) { } } (earlier error: incompatible types: MyValue1 cannot be converted to Test.MyValue2 ????????????vBoxField = new MyValue1();) (2) The following code snippet compiles fine now: value class MyValue1 { ????final int x = 0; ????public int hash() { return 0; } } public class Test { ????value class MyValue2 { ????????final MyValue1? vBoxField = null; ????????public int test() { ????????????return vBoxField.hash(); ????????} ????} ????public static void main(String[] args) { } } (earlier error: cannot find symbol ????????????return vBoxField.hash();) ????????????????????????????^ (3) The following code snippet compiles fine now: interface MyInterface { ????public void test(MyValue1? vt); } value class MyValue1 implements MyInterface { ????final int x = 0; ????@Override ????public void test(MyValue1? vt) { } } (4) Sometimes field descriptors carried the wrong 'Q' type for V? I have upgraded the javac tests to include these scenarios. I will also be adding more tests in future as I test and upgrade the preliminary support that has been put in place. Here are the pending ones I see: (1) Compile time null assignment to values should be tolerated (?) (2) Compiler does not tolerate the following: MyValue1?[] vBoxArray = new MyValue1?[42]; Thanks! Srikanth On 17/04/19 5:31 PM, srikanth.adayapalam at oracle.com wrote: > Changeset: 2e5ecb20aa24 > Author: sadayapalam > Date: 2019-04-17 17:31 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2e5ecb20aa24 > > 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. > > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java > + test/langtools/tools/javac/valhalla/lworld-values/CheckFieldDescriptors.java > From srikanth.adayapalam at oracle.com Wed Apr 17 13:09:49 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Wed, 17 Apr 2019 18:39:49 +0530 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> Message-ID: On 17/04/19 6:33 PM, Srikanth wrote: > Here are the pending ones I see: > > (1) Compile time null assignment to values should be tolerated (?) > (2) Compiler does not tolerate the following: > MyValue1?[] vBoxArray = new MyValue1?[42]; On (1) can I get a quick confirmation that this is what we want ? I did see some discussion regarding javac not proactively catching these and letting the VM report an NPE. But I seem to have missed the rationale behind that decision against failing early. Thanks for any pointers. Srikanth > > Thanks! > Srikanth > > > On 17/04/19 5:31 PM, srikanth.adayapalam at oracle.com wrote: >> Changeset: 2e5ecb20aa24 >> Author:??? sadayapalam >> Date:????? 2019-04-17 17:31 +0530 >> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2e5ecb20aa24 >> >> 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors >> for fields. >> >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >> + >> test/langtools/tools/javac/valhalla/lworld-values/CheckFieldDescriptors.java >> > From tobias.hartmann at oracle.com Wed Apr 17 13:10:15 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 17 Apr 2019 15:10:15 +0200 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> Message-ID: <79452f40-5908-ae85-ab66-29347da6f77c@oracle.com> Hi Srikanth, On 17.04.19 15:03, Srikanth wrote: > This change set fixes 4 problems you had reported in https://bugs.openjdk.java.net/browse/JDK-8222634: Thanks, I can confirm that these problems are now fixed. > I have upgraded the javac tests to include these scenarios. I will also be adding more tests in > future as I test and upgrade the preliminary support that has been put in place. > > Here are the pending ones I see: > > (1) Compile time null assignment to values should be tolerated (?) > (2) Compiler does not tolerate the following: > MyValue1?[] vBoxArray = new MyValue1?[42]; Right, both cases did work with .box declarations. Best regards, Tobias From brian.goetz at oracle.com Wed Apr 17 13:13:15 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Wed, 17 Apr 2019 09:13:15 -0400 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> Message-ID: <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> >> >> (1) Compile time null assignment to values should be tolerated (?) >> (2) Compiler does not tolerate the following: >> MyValue1?[] vBoxArray = new MyValue1?[42]; > > On (1) can I get a quick confirmation that this is what we want ? I did see some discussion regarding javac not proactively catching these and letting the VM report an NPE. But I seem to have missed the rationale behind that decision against failing early. On (1), I think this should be done on the basis of value set inclusion. For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not. I think the compiler should not allow assignment of a value that is not a member of the value set. We need better terminology?.I said value and null too many times in the above paragraph. From karen.kinnear at oracle.com Wed Apr 17 13:15:12 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Wed, 17 Apr 2019 09:15:12 -0400 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <79452f40-5908-ae85-ab66-29347da6f77c@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <79452f40-5908-ae85-ab66-29347da6f77c@oracle.com> Message-ID: <7F8B3A0C-3157-4EED-9B9D-2CCB17C79477@oracle.com> Srikanth, Just making sure I get it ... > On Apr 17, 2019, at 9:10 AM, Tobias Hartmann wrote: > > Hi Srikanth, > > On 17.04.19 15:03, Srikanth wrote: >> This change set fixes 4 problems you had reported in https://bugs.openjdk.java.net/browse/JDK-8222634: > > Thanks, I can confirm that these problems are now fixed. > >> I have upgraded the javac tests to include these scenarios. I will also be adding more tests in >> future as I test and upgrade the preliminary support that has been put in place. >> >> Here are the pending ones I see: >> >> (1) Compile time null assignment to values should be tolerated (?) For MyValue1? null assignment is ok. For MyValue null assignment should not be tolerated at compile time Is that what you are expecting? thanks, Karen >> (2) Compiler does not tolerate the following: >> MyValue1?[] vBoxArray = new MyValue1?[42]; > > Right, both cases did work with .box declarations. > > Best regards, > Tobias From tobias.hartmann at oracle.com Wed Apr 17 13:16:04 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 17 Apr 2019 15:16:04 +0200 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> Message-ID: <2328e662-ef53-8fba-9324-41ba0fb7b903@oracle.com> On 17.04.19 15:13, Brian Goetz wrote: > On (1), I think this should be done on the basis of value set inclusion. For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not. I think the compiler should not allow assignment of a value that is not a member of the value set. > > We need better terminology?.I said value and null too many times in the above paragraph. Yes, in the bug report I'm referring to V? (V.box) that should allow null assignments. V (V.val) should not allow null. Best regards, Tobias From srikanth.adayapalam at oracle.com Wed Apr 17 13:47:49 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Wed, 17 Apr 2019 13:47:49 +0000 Subject: hg: valhalla/valhalla: 8222634: [lworld] Additional tests for null mixin with (L-form) ValueType?'s Message-ID: <201904171347.x3HDlom0008983@aojmv0008.oracle.com> Changeset: e16696d027d4 Author: sadayapalam Date: 2019-04-17 19:17 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e16696d027d4 8222634: [lworld] Additional tests for null mixin with (L-form) ValueType?'s + test/langtools/tools/javac/valhalla/lworld-values/CheckNullWithQuestion.java From srikanth.adayapalam at oracle.com Wed Apr 17 13:58:01 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Wed, 17 Apr 2019 19:28:01 +0530 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <2328e662-ef53-8fba-9324-41ba0fb7b903@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> <2328e662-ef53-8fba-9324-41ba0fb7b903@oracle.com> Message-ID: <33d9bfb1-7a02-8db3-ec6d-71f5f12b305a@oracle.com> On 17/04/19 6:46 PM, Tobias Hartmann wrote: > On 17.04.19 15:13, Brian Goetz wrote: >> On (1), I think this should be done on the basis of value set inclusion. For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not. I think the compiler should not allow assignment of a value that is not a member of the value set. >> >> We need better terminology?.I said value and null too many times in the above paragraph. > Yes, in the bug report I'm referring to V? (V.box) that should allow null assignments. V (V.val) > should not allow null. Cool. I may have conflated that with a private mail I received that I am unable to locate at the moment that called for the compiler not performing these checks at all. But I see Brian's clarification on this topic that settles it for me. BTW, that same change set also fixes the null mixin issues with V? - these compile now. I have pushed additional tests for this just now. So, ATM, the only issue open is the new ValueType?[42] array creation syntax not being accepted. Working on it. Thanks Srikanth > > Best regards, > Tobias From srikanth.adayapalam at oracle.com Wed Apr 17 13:59:08 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Wed, 17 Apr 2019 19:29:08 +0530 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <7F8B3A0C-3157-4EED-9B9D-2CCB17C79477@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <79452f40-5908-ae85-ab66-29347da6f77c@oracle.com> <7F8B3A0C-3157-4EED-9B9D-2CCB17C79477@oracle.com> Message-ID: <581c4a08-8de4-adbd-91a2-d74049eef2fb@oracle.com> On 17/04/19 6:45 PM, Karen Kinnear wrote: > Srikanth, > > Just making sure I get it ... >> On Apr 17, 2019, at 9:10 AM, Tobias Hartmann wrote: >> >> Hi Srikanth, >> >> On 17.04.19 15:03, Srikanth wrote: >>> This change set fixes 4 problems you had reported in https://bugs.openjdk.java.net/browse/JDK-8222634: >> Thanks, I can confirm that these problems are now fixed. >> >>> I have upgraded the javac tests to include these scenarios. I will also be adding more tests in >>> future as I test and upgrade the preliminary support that has been put in place. >>> >>> Here are the pending ones I see: >>> >>> (1) Compile time null assignment to values should be tolerated (?) > For MyValue1? null assignment is ok. > For MyValue null assignment should not be tolerated at compile time > > Is that what you are expecting? Yes Karen and that matches tip behavior ATM. Thanks Srikanth > thanks, > Karen > >>> (2) Compiler does not tolerate the following: >>> MyValue1?[] vBoxArray = new MyValue1?[42]; >> Right, both cases did work with .box declarations. >> >> Best regards, >> Tobias From srikanth.adayapalam at oracle.com Wed Apr 17 14:02:52 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Wed, 17 Apr 2019 19:32:52 +0530 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> Message-ID: <2b60e8b8-53b5-7c99-293c-687a288c9833@oracle.com> On 17/04/19 6:43 PM, Brian Goetz wrote: >>> (1) Compile time null assignment to values should be tolerated (?) >>> (2) Compiler does not tolerate the following: >>> MyValue1?[] vBoxArray = new MyValue1?[42]; >> On (1) can I get a quick confirmation that this is what we want ? I did see some discussion regarding javac not proactively catching these and letting the VM report an NPE. But I seem to have missed the rationale behind that decision against failing early. > On (1), I think this should be done on the basis of value set inclusion. For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not. I think the compiler should not allow assignment of a value that is not a member of the value set. Perfect. I must have misread a private communication from one of the contributors that ATM I am unable to locate, but your outline clarifies the questions I had. javac does not yet have a notion of null default value types. Other than that the tip behavior should match what describe above. I have half a dozen smallish tasks to wrap the various loose ends and also test the V? implementation more and after that I will start on the null default value types. Thanks Srikanth > > We need better terminology?.I said value and null too many times in the above paragraph. From brian.goetz at oracle.com Wed Apr 17 14:09:51 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Wed, 17 Apr 2019 10:09:51 -0400 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <2b60e8b8-53b5-7c99-293c-687a288c9833@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> <2b60e8b8-53b5-7c99-293c-687a288c9833@oracle.com> Message-ID: Great. Note that null-default is for L20, not L10, so perhaps we should work that in a dependent branch? > On Apr 17, 2019, at 10:02 AM, Srikanth wrote: > > > > On 17/04/19 6:43 PM, Brian Goetz wrote: >>>> (1) Compile time null assignment to values should be tolerated (?) >>>> (2) Compiler does not tolerate the following: >>>> MyValue1?[] vBoxArray = new MyValue1?[42]; >>> On (1) can I get a quick confirmation that this is what we want ? I did see some discussion regarding javac not proactively catching these and letting the VM report an NPE. But I seem to have missed the rationale behind that decision against failing early. >> On (1), I think this should be done on the basis of value set inclusion. For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not. I think the compiler should not allow assignment of a value that is not a member of the value set. > > Perfect. I must have misread a private communication from one of the contributors that ATM I am unable to locate, but your outline clarifies the questions I had. > > javac does not yet have a notion of null default value types. Other than that the tip behavior should match what describe above. I have half a dozen smallish tasks to wrap the various loose ends and also test the V? implementation more and after that I will start on the null default value types. > > Thanks > Srikanth >> >> We need better terminology?.I said value and null too many times in the above paragraph. > From ioi.lam at oracle.com Wed Apr 17 14:50:40 2019 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Wed, 17 Apr 2019 14:50:40 +0000 Subject: hg: valhalla/valhalla: 8222384: [lworld] Calling convention - C2 to C1 (floating point params) Message-ID: <201904171450.x3HEofco020602@aojmv0008.oracle.com> Changeset: 8f64a47cfc12 Author: iklam Date: 2019-04-16 21:13 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8f64a47cfc12 8222384: [lworld] Calling convention - C2 to C1 (floating point params) Reviewed-by: thartmann ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java From karen.kinnear at oracle.com Wed Apr 17 15:25:37 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Wed, 17 Apr 2019 11:25:37 -0400 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> <2b60e8b8-53b5-7c99-293c-687a288c9833@oracle.com> Message-ID: <69381746-1841-44B7-B2BB-E0B28C2F30BF@oracle.com> Srikanth, Many thanks for the quick turnaround on fixes. Your timing helps a great deal as we try to get an LW2 EA ready since you are at the start of the chain. So in addition to the ValueType?[42] array syntax you are working on, we had one more issue with the new syntax update: ?withfield? handling: Old __Withfield syntax supported the model that it could be used in any nestmates of the declaring class, and would explicitly generate just the single bytecode ?withfield?. The updated syntax ?MyValue1.f1 = Foo;? appears to be using different restrictions: javac appears to be restricting it to constructors which convert to factories and therefore is generating defaultvalue followed by with fields. The intent was to have the new syntax also just generate a single ?withfield? bytecode with the nestmate restrictions. As Frederic reminded us, the use model use case is iterators, e.g. for a Cursor inlined class. Does this make sense to you? Do you need me to file a JBS for this? thanks, Karen > On Apr 17, 2019, at 10:09 AM, Brian Goetz wrote: > > Great. Note that null-default is for L20, not L10, so perhaps we should work that in a dependent branch? > >> On Apr 17, 2019, at 10:02 AM, Srikanth wrote: >> >> >> >> On 17/04/19 6:43 PM, Brian Goetz wrote: >>>>> (1) Compile time null assignment to values should be tolerated (?) >>>>> (2) Compiler does not tolerate the following: >>>>> MyValue1?[] vBoxArray = new MyValue1?[42]; >>>> On (1) can I get a quick confirmation that this is what we want ? I did see some discussion regarding javac not proactively catching these and letting the VM report an NPE. But I seem to have missed the rationale behind that decision against failing early. >>> On (1), I think this should be done on the basis of value set inclusion. For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not. I think the compiler should not allow assignment of a value that is not a member of the value set. >> >> Perfect. I must have misread a private communication from one of the contributors that ATM I am unable to locate, but your outline clarifies the questions I had. >> >> javac does not yet have a notion of null default value types. Other than that the tip behavior should match what describe above. I have half a dozen smallish tasks to wrap the various loose ends and also test the V? implementation more and after that I will start on the null default value types. >> >> Thanks >> Srikanth >>> >>> We need better terminology?.I said value and null too many times in the above paragraph. >> > From srikanth.adayapalam at oracle.com Wed Apr 17 15:30:20 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Wed, 17 Apr 2019 21:00:20 +0530 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: <69381746-1841-44B7-B2BB-E0B28C2F30BF@oracle.com> References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> <2b60e8b8-53b5-7c99-293c-687a288c9833@oracle.com> <69381746-1841-44B7-B2BB-E0B28C2F30BF@oracle.com> Message-ID: Hi Karen, Yes, please, raise a ticket ideally with a snippet that shows the problem and the expected behavior in terms of generated code. Thanks! Srikanth On 17/04/19 8:55 PM, Karen Kinnear wrote: > Srikanth, > > Many thanks for the quick turnaround on fixes. Your timing helps a great deal as we try to get an LW2 EA > ready since you are at the start of the chain. > > So in addition to the ValueType?[42] array syntax you are working on, we had one more issue with > the new syntax update: > > ?withfield? handling: > Old __Withfield syntax supported the model that it could be used in any nestmates of the declaring class, > and would explicitly generate just the single bytecode ?withfield?. > > The updated syntax ?MyValue1.f1 = Foo;? > appears to be using different restrictions: > javac appears to be restricting it to constructors which convert to factories > and therefore is generating defaultvalue followed by with fields. > > The intent was to have the new syntax also just generate a single ?withfield? bytecode with the > nestmate restrictions. > > As Frederic reminded us, the use model use case is iterators, e.g. for a Cursor inlined class. > > Does this make sense to you? Do you need me to file a JBS for this? > > thanks, > Karen > >> On Apr 17, 2019, at 10:09 AM, Brian Goetz wrote: >> >> Great. Note that null-default is for L20, not L10, so perhaps we should work that in a dependent branch? >> >>> On Apr 17, 2019, at 10:02 AM, Srikanth wrote: >>> >>> >>> >>> On 17/04/19 6:43 PM, Brian Goetz wrote: >>>>>> (1) Compile time null assignment to values should be tolerated (?) >>>>>> (2) Compiler does not tolerate the following: >>>>>> MyValue1?[] vBoxArray = new MyValue1?[42]; >>>>> On (1) can I get a quick confirmation that this is what we want ? I did see some discussion regarding javac not proactively catching these and letting the VM report an NPE. But I seem to have missed the rationale behind that decision against failing early. >>>> On (1), I think this should be done on the basis of value set inclusion. For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not. I think the compiler should not allow assignment of a value that is not a member of the value set. >>> Perfect. I must have misread a private communication from one of the contributors that ATM I am unable to locate, but your outline clarifies the questions I had. >>> >>> javac does not yet have a notion of null default value types. Other than that the tip behavior should match what describe above. I have half a dozen smallish tasks to wrap the various loose ends and also test the V? implementation more and after that I will start on the null default value types. >>> >>> Thanks >>> Srikanth >>>> We need better terminology?.I said value and null too many times in the above paragraph. From srikanth.adayapalam at oracle.com Wed Apr 17 16:09:47 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Wed, 17 Apr 2019 16:09:47 +0000 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac does not allow array creation of the form new VT? [] Message-ID: <201904171609.x3HG9mp9015524@aojmv0008.oracle.com> Changeset: d6ab78044b40 Author: sadayapalam Date: 2019-04-17 21:39 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d6ab78044b40 8222634: [lworld] Javac does not allow array creation of the form new VT? [] ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/langtools/tools/javac/valhalla/lworld-values/ArrayCreationWithQuestion.java ! test/langtools/tools/javac/valhalla/lworld-values/CheckFieldDescriptors.java From harold.seigel at oracle.com Wed Apr 17 17:15:10 2019 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Wed, 17 Apr 2019 17:15:10 +0000 Subject: hg: valhalla/valhalla: Summary: Change tests to use value and value? instead of value.val and value.box Message-ID: <201904171715.x3HHFBCY026391@aojmv0008.oracle.com> Changeset: 1e3ad59e0153 Author: hseigel Date: 2019-04-17 13:14 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1e3ad59e0153 Summary: Change tests to use value and value? instead of value.val and value.box Reviewed-by: fparain ! test/hotspot/jtreg/runtime/valhalla/valuetypes/CheckcastTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/FlattenableSemanticTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/IntValue.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/QuickeningTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestFieldNullability.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestInheritedValueTypeFields.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue1.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue2.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue3.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue4.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/UninitializedValueFieldsTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/VDefaultTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueOops.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeCreation.java From karen.kinnear at oracle.com Wed Apr 17 18:14:40 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Wed, 17 Apr 2019 14:14:40 -0400 Subject: hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields. In-Reply-To: References: <201904171201.x3HC1Jds029789@aojmv0008.oracle.com> <96e1f7ea-b14d-c839-ad25-c3aa3c6d19c4@oracle.com> <64E43400-7471-477F-889E-C6C809200CAD@oracle.com> <2b60e8b8-53b5-7c99-293c-687a288c9833@oracle.com> <69381746-1841-44B7-B2BB-E0B28C2F30BF@oracle.com> Message-ID: Srikanth, Filed JDK-8222663. So I thought Brian had asked for a change from $makeValue$ to ? I don?t have the specifics - do you need a different rfe for that? thanks, Karen > On Apr 17, 2019, at 11:30 AM, Srikanth wrote: > > Hi Karen, > > Yes, please, raise a ticket ideally with a snippet that shows the problem and the expected behavior in terms of generated code. > > Thanks! > Srikanth > > On 17/04/19 8:55 PM, Karen Kinnear wrote: >> Srikanth, >> >> Many thanks for the quick turnaround on fixes. Your timing helps a great deal as we try to get an LW2 EA >> ready since you are at the start of the chain. >> >> So in addition to the ValueType?[42] array syntax you are working on, we had one more issue with >> the new syntax update: >> >> ?withfield? handling: >> Old __Withfield syntax supported the model that it could be used in any nestmates of the declaring class, >> and would explicitly generate just the single bytecode ?withfield?. >> >> The updated syntax ?MyValue1.f1 = Foo;? >> appears to be using different restrictions: >> javac appears to be restricting it to constructors which convert to factories >> and therefore is generating defaultvalue followed by with fields. >> >> The intent was to have the new syntax also just generate a single ?withfield? bytecode with the >> nestmate restrictions. >> >> As Frederic reminded us, the use model use case is iterators, e.g. for a Cursor inlined class. >> >> Does this make sense to you? Do you need me to file a JBS for this? >> >> thanks, >> Karen >> >>> On Apr 17, 2019, at 10:09 AM, Brian Goetz wrote: >>> >>> Great. Note that null-default is for L20, not L10, so perhaps we should work that in a dependent branch? >>> >>>> On Apr 17, 2019, at 10:02 AM, Srikanth wrote: >>>> >>>> >>>> >>>> On 17/04/19 6:43 PM, Brian Goetz wrote: >>>>>>> (1) Compile time null assignment to values should be tolerated (?) >>>>>>> (2) Compiler does not tolerate the following: >>>>>>> MyValue1?[] vBoxArray = new MyValue1?[42]; >>>>>> On (1) can I get a quick confirmation that this is what we want ? I did see some discussion regarding javac not proactively catching these and letting the VM report an NPE. But I seem to have missed the rationale behind that decision against failing early. >>>>> On (1), I think this should be done on the basis of value set inclusion. For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not. I think the compiler should not allow assignment of a value that is not a member of the value set. >>>> Perfect. I must have misread a private communication from one of the contributors that ATM I am unable to locate, but your outline clarifies the questions I had. >>>> >>>> javac does not yet have a notion of null default value types. Other than that the tip behavior should match what describe above. I have half a dozen smallish tasks to wrap the various loose ends and also test the V? implementation more and after that I will start on the null default value types. >>>> >>>> Thanks >>>> Srikanth >>>>> We need better terminology?.I said value and null too many times in the above paragraph. > From maurizio.cimadamore at oracle.com Wed Apr 17 18:14:45 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Wed, 17 Apr 2019 19:14:45 +0100 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: <4d71f1ca-411d-26ed-2119-ca444b787c93@oracle.com> References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> <33652a65-4d80-03b5-30c1-40793d37fd40@oracle.com> <79031832-57CB-4ADF-97CE-1C7DFF70403D@oracle.com> <8185519c-9d60-27ed-4ebc-5b6d2adf9bc8@oracle.com> <4d71f1ca-411d-26ed-2119-ca444b787c93@oracle.com> Message-ID: As a pointer, I think V -> V? should be part of Types.isSubtypes, whereas V? -> V should be in Types.isAssignable. That should fix overload resolution too Maurizio On 16/04/2019 15:53, Srikanth wrote: > Sounds good. I will work on implementing these (except for the source > level express cast). I expect to have a fix by early next week. > > Thanks > Srikanth > > On 16/04/19 8:07 PM, Brian Goetz wrote: >> Let?s separate the language and VM aspects. >> >> In the language, since V <: V?, no cast is needed when assigning a V >> to a V?.? And no CHECKCAST is needed for the corresponding code >> generation. >> >> In the other direction, a CHECKCAST is definitely needed going from >> V? to V; the question of whether the _language_ requires an explicit >> cast is still up in the air.? I think we should lean on explicit >> casting for now, but I suspect we?ll slide back to implicit narrowing >> (with possible NPE). >> >> This also makes a difference for overload selection.? If I have: >> >> ???? m(Object o) { } >> ???? m(V? v) { } >> >> and a call >> >> ???? V v = ? >> ???? m(v) >> >> Under the old (V.box) interpretation, we?d prefer the m(Object) >> overload, since it is applicable without a boxing conversion, and >> m(V?) would not be.? But under the new (subtyping) interpretation, we >> should treat them both as applicable, and V? is _more specific_ than >> OIbject, so we pick m(V?). >> >> >> >>> On Apr 16, 2019, at 10:30 AM, Srikanth >>> wrote: >>> >>> On a quick check, I see that on both directions, we have a compiler >>> inserted cast. >>> As I understand, assignment of V to V? being a widening conversion, >>> the cast should go away while >>> the other direction is still being debated. >>> >>> This should be straightforward. >>> >>> Srikanth >>> >>> On 16/04/19 7:50 PM, Brian Goetz wrote: >>>> OK, thanks.? Hopefully the new rules will be simpler, as they lean >>>> more heavily on subtyping. >>>> >>>> >>>>> On Apr 16, 2019, at 10:18 AM, Srikanth >>>>> wrote: >>>>> >>>>> >>>>> This change set just introduces the new notation doing nothing new >>>>> about inserting casts. >>>>> I will go through the mails discussing this and follow up on a >>>>> different change set. >>>>> >>>>> Thanks >>>>> Srikanth >>>>> On 16/04/19 7:32 PM, Brian Goetz wrote: >>>>>>> This was a request for LW2 - no more boxing. >>>>>> Right.? I was wondering whether we got there yet, or whether we?d >>>>>> just change the notation to start. >>>>>> >>>>>>> We asked for the subtype relationship for both values and for >>>>>>> arrays. >>>>>> For arrays, the covariance rule: T <: U imples T[] <: U[] ? >>>>>> should hold uniformly.? No need for special exceptions for value >>>>>> arrays.? Since >>>>>> >>>>>> ???? V <: Object >>>>>> and >>>>>> ???? V? <: Object >>>>>> >>>>>> then both V[] and V?[] are <: Object[]. >>>>>> >>>>>> >>>>>> >>>>>>> For LW2 - we requested explicit checkcasts on attempts to narrow. >>>>>>> >>>>>>> Agreed that there are discussions about where this is all going >>>>>>> after LW2 before LW10. >>>>>>> >>>>>>> thanks, >>>>>>> Karen >>>>>>> >>>>>>>> On Apr 16, 2019, at 9:24 AM, Brian Goetz >>>>>>>> wrote: >>>>>>>> >>>>>>>> Is the conversion from V to V? still considered a boxing >>>>>>>> conversion, or is it a widening conversion now?? The language >>>>>>>> we (currently think we) want is >>>>>>>> >>>>>>>> ? V <: V? >>>>>>>> >>>>>>>> In the other direction, we?re still discussing whether the >>>>>>>> narrowing conversion is implicit or explicit. >>>>>>>> >>>>>>>>> On Apr 16, 2019, at 8:09 AM, Srikanth >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Notes: >>>>>>>>> >>>>>>>>> ?? - This is the initial commit for supporting V? notation as >>>>>>>>> an alternate for V.box >>>>>>>>> ?? - The old .box and .val notation is not withdrawn yet and >>>>>>>>> can still be used, but we should really move over to the new >>>>>>>>> syntax as soon as possible. >>>>>>>>> ?? - Existing javac tests have been replicated to use the V? >>>>>>>>> syntax. >>>>>>>>> ?? - VBC migration related work is not done yet. >>>>>>>>> ?? - One issue that showed up in the parser implementation is >>>>>>>>> the ambiguity at the point of seeing ? >>>>>>>>> ????? in? v instanceof Type? exp: exp2; I have arranged for >>>>>>>>> this to be processed as a conditional rather >>>>>>>>> ????? than as denoting nullability. >>>>>>>>> ?? - On a long value type name the ? suffix does not really >>>>>>>>> stand out ATM, but I guess IDE colorcoding can address this >>>>>>>>> issue. >>>>>>>>> ?? - There is one failing test in the langtools suite >>>>>>>>> (jdk/jshell/TypeNameTest.java) I will raise a follow up >>>>>>>>> ???? ticket to address this. >>>>>>>>> ?? - More testing is required and will be undertaken in the >>>>>>>>> coming weeks. I request/encourage testing by the interested >>>>>>>>> parties too. >>>>>>>>> >>>>>>>>> Thanks! >>>>>>>>> Srikanth >>>>>>>>> >>>>>>>>> On 16/04/19 5:32 PM, srikanth.adayapalam at oracle.com wrote: >>>>>>>>>> Changeset: bf52db1ad4ea >>>>>>>>>> Author:??? sadayapalam >>>>>>>>>> Date:????? 2019-04-16 17:31 +0530 >>>>>>>>>> URL: >>>>>>>>>> http://hg.openjdk.java.net/valhalla/valhalla/rev/bf52db1ad4ea >>>>>>>>>> >>>>>>>>>> 8221545: [lworld] Preliminary support for alternate >>>>>>>>>> denotation of values and boxes >>>>>>>>>> >>>>>>>>>> ! >>>>>>>>>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>>>>>>>> >>>>>>>>>> ! >>>>>>>>>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/AttrContext.java >>>>>>>>>> >>>>>>>>>> ! >>>>>>>>>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >>>>>>>>>> >>>>>>>>>> ! >>>>>>>>>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java >>>>>>>>>> ! >>>>>>>>>> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java >>>>>>>>>> >>>>>>>>>> ! >>>>>>>>>> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java >>>>>>>>>> >>>>>>>>>> ! >>>>>>>>>> test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >>>>>>>>>> + >>>>>>>>>> test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>>>>>>>> >>>>>>>>>> + >>>>>>>>>> test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.java >>>>>>>>>> + >>>>>>>>>> test/langtools/tools/javac/valhalla/lworld-values/GenericsWithQuestion.out >>>>>>>>>> ! >>>>>>>>>> test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >>>>>>>>>> + >>>>>>>>>> test/langtools/tools/javac/valhalla/lworld-values/IntercastTest2.java >>>>>>>>>> >>>>>>>>>> + >>>>>>>>>> test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest2.java >>>>>>>>>> >>>>>>>>>> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >>>>>>>>>> > From john.r.rose at oracle.com Wed Apr 17 19:55:50 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 17 Apr 2019 12:55:50 -0700 Subject: hg: valhalla/valhalla: 8221545: [lworld] Preliminary support for alternate denotation of values and boxes In-Reply-To: References: <201904161202.x3GC2GQk004179@aojmv0008.oracle.com> <7499450D-12AC-4A91-B043-8027BDCE6AFE@oracle.com> <07C172F4-1305-4C67-80FD-5B64851BE87C@oracle.com> <33652a65-4d80-03b5-30c1-40793d37fd40@oracle.com> <79031832-57CB-4ADF-97CE-1C7DFF70403D@oracle.com> <8185519c-9d60-27ed-4ebc-5b6d2adf9bc8@oracle.com> Message-ID: <528BE6D5-0B70-41A5-A83A-298D50A8E16D@oracle.com> On Apr 16, 2019, at 7:37 AM, Brian Goetz wrote: > > Let?s separate the language and VM aspects. > > In the language, since V <: V?, no cast is needed when assigning a V to a V?. And no CHECKCAST is needed for the corresponding code generation. I agree with this, although it would be a slight help to require the extra checkcast op. Helpful in that it would give the VM extra local knowledge about shifting between what might be different physical carrier formats. Only "slight", in that the JVMS specifies that a common virtual carrier type, a "reference", for every non-primitive, and *requires* that the interpreter be ready to interconvert these references, at many points between any underlying physical formats. It's not clear to me that the checkcast plugs an important hole that isn't also present elsewhere (though I might be missing something). > In the other direction, a CHECKCAST is definitely needed going from V? to V; That's definitely true, because the JVM must mandate a NPE exception is thrown if the value sets don't line up, and NPE must be thrown by an instruction, and checkcast is the instruction for type checking (hence value set narrowing). > the question of whether the _language_ requires an explicit cast is still up in the air. Yep. Requiring the cast is OK for a start, kind of like prohibiting array covariance was a start. Since V? is the successor to V.box, and V.box is to V as java.lang.Integer is to int (in some use cases we design V? for), I think we all suspect that we'll end up making V? convert to V in similar circumstances to those in which Integer converts to int. > I think we should lean on explicit casting for now, but I suspect we?ll slide back to implicit narrowing (with possible NPE). I'll go out on a limb and mention (again) that I think a reasonable first (and perhaps last) cut is to slot conversion from V? to V (we could call it "null check conversion" in the JLS) right alongside the unboxing conversion in the current JLS. That is, do null check conversion in the second pass of overload matching, at the same time as legacy unboxing conversions. (That's where boxing conversions happen, but they don't have future analog, since V <: V?.) This seems so self-evidently reasonable to me (at least as a first cut) that perhaps we should, sooner rather than later, put a switch into the prototype javac whichenables this behavior, with logging of the difference in overloading choice between it and one which makes the casting required, so we can quickly test its effect. > This also makes a difference for overload selection. If I have: > > m(Object o) { } > m(V? v) { } > > and a call > > V v = ? > m(v) > > Under the old (V.box) interpretation, we?d prefer the m(Object) overload, since it is applicable without a boxing conversion, and m(V?) would not be. But under the new (subtyping) interpretation, we should treat them both as applicable, and V? is _more specific_ than OIbject, so we pick m(V?). That's an argument to think about putting the V to V? conversion into the second pass of the resolution logic, alongside boxing conversion. Which seems a bridge too far, to compatibility-land. My arguments above (the opposite V? to V implicits, in the second pass) become murkier due to this confounding factor, but I think they still stand. The way to investigate is to run some corpus tests, and/or put a switch with logging into javac, so we can look for and analyze use cases. It will always be possible to create sensitive overloading tests which demonstrate the difference between putting implicits in the first or second overloading stage (otherwise we wouldn't have invented the staging structure in the first place). But the real question is what's useful, in the use cases we have today and are likely to have tomorrow. ? John From ioi.lam at oracle.com Thu Apr 18 01:09:46 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Wed, 17 Apr 2019 18:09:46 -0700 Subject: RFR 8222712 [lworld] print parameter types for different compiled entry points Message-ID: https://bugs.openjdk.java.net/browse/JDK-8222712 http://cr.openjdk.java.net/~iklam/valhalla/8222712-print-param-types-for-diff-entry-points.v01/ Compiled methods can have up to 3 entry points that take different types of parameters. For debugging purposes, it's useful to print the types of each entry point. The following example shows how the [Verified Entry Point] of a C1 method shuffles the parameters before jumping to the [Verified Value Entry Point]: [Disassembling for mach='i386:x86-64'] ? # {method} {0x00007fa9108ed690} 'test' '(QI2CStatic$V;IIIIIIII)I' in 'I2CStatic' [Entry Point] [Verified Entry Point] [Verified Value Entry Point (RO)] ? # parm0: rsi = int ? # parm1: rdx = int ? # parm2: rcx = int ? # parm3: r8 = int ? # parm4: r9 = int ? # parm5: rdi = int ? # parm6: [sp+0x40] = int (sp of caller) ? # parm7: [sp+0x48] = int [RESERVED] ? # parm8: [sp+0x50] = int ? # parm9: [sp+0x58] = int [RESERVED] ? # parm10: [sp+0x60] = int ? # parm11: [sp+0x68] = int ? 0x00007fa924e371e0: push %rbp ? 0x00007fa924e371e1: sub $0x30,%rsp ? 0x00007fa924e371e5: mov $0x7fa9108ed690,%rbx ? 0x00007fa924e371ef: callq 0x00007fa9249d9ac0 ; {runtime_call buffer_value_args} ? 0x00007fa924e371f4: mov 0x10(%rax),%r11d ? 0x00007fa924e371f8: mov %esi,0x10(%r11) ? 0x00007fa924e371fc: mov %edx,0x14(%r11) ? 0x00007fa924e37200: mov %r11,%rsi ? 0x00007fa924e37203: mov %rcx,%rdx ? 0x00007fa924e37206: mov %r8,%rcx ? 0x00007fa924e37209: mov %r9,%r8 ? 0x00007fa924e3720c: mov %rdi,%r9 ? 0x00007fa924e3720f: mov 0x40(%rsp),%rdi ? 0x00007fa924e37214: mov 0x50(%rsp),%r13 ? 0x00007fa924e37219: mov %r13,0x40(%rsp) ? 0x00007fa924e3721e: mov 0x60(%rsp),%r13 ? 0x00007fa924e37223: mov %r13,0x48(%rsp) ? 0x00007fa924e37228: mov 0x68(%rsp),%r13 ? 0x00007fa924e3722d: mov %r13,0x50(%rsp) ? 0x00007fa924e37232: pop %rbp ? 0x00007fa924e37233: add $0x30,%rsp ? 0x00007fa924e37237: jmpq 0x00007fa924e37240 ? ... [Verified Value Entry Point] ? # parm0: rsi:rsi = 'java/lang/Object' ? # parm1: rdx = int ? # parm2: rcx = int ? # parm3: r8 = int ? # parm4: r9 = int ? # parm5: rdi = int ? # parm6: [sp+0x40] = int (sp of caller) ? # parm7: [sp+0x48] = int ? # parm8: [sp+0x50] = int ? 0x00007fa924e37240: mov %eax,-0x16000(%rsp) ? 0x00007fa924e37247: push %rbp ? 0x00007fa924e37248: sub $0x30,%rsp From tobias.hartmann at oracle.com Thu Apr 18 06:49:23 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Thu, 18 Apr 2019 06:49:23 +0000 Subject: hg: valhalla/valhalla: 8222718: [lworld] Scalarization of value types around exceptions control flow is broken Message-ID: <201904180649.x3I6nOUD027983@aojmv0008.oracle.com> Changeset: 375f97ac2c45 Author: thartmann Date: 2019-04-18 08:49 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/375f97ac2c45 8222718: [lworld] Scalarization of value types around exceptions control flow is broken ! src/hotspot/share/ci/ciTypeFlow.cpp ! src/hotspot/share/opto/graphKit.cpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java From tobias.hartmann at oracle.com Thu Apr 18 07:09:25 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Thu, 18 Apr 2019 07:09:25 +0000 Subject: hg: valhalla/valhalla: 8222636: [lworld] Remove usages of .val and .box from compiler tests Message-ID: <201904180709.x3I79QWZ008151@aojmv0008.oracle.com> Changeset: d434f72e8e41 Author: thartmann Date: 2019-04-18 09:09 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d434f72e8e41 8222636: [lworld] Remove usages of .val and .box from compiler tests ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue1.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue2.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue3.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue4.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestBasicFunctionality.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestC2CCalls.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConvention.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestIntrinsics.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableValueTypes.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestOnStackReplacement.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestUnloadedValueTypeArray.java From tobias.hartmann at oracle.com Thu Apr 18 08:46:39 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 18 Apr 2019 10:46:39 +0200 Subject: RFR 8222712 [lworld] print parameter types for different compiled entry points In-Reply-To: References: Message-ID: <420a5506-3ee7-83fe-c69b-54da6549a3b5@oracle.com> Hi Ioi, looks good to me, nice feature! Thanks, Tobias On 18.04.19 03:09, Ioi Lam wrote: > https://bugs.openjdk.java.net/browse/JDK-8222712 > http://cr.openjdk.java.net/~iklam/valhalla/8222712-print-param-types-for-diff-entry-points.v01/ > > Compiled methods can have up to 3 entry points that take different types > of parameters. For debugging purposes, it's useful to print the types of each > entry point. > > The following example shows how the [Verified Entry Point] of a C1 method > shuffles the parameters before jumping to the [Verified Value Entry Point]: > > [Disassembling for mach='i386:x86-64'] > ? # {method} {0x00007fa9108ed690} 'test' '(QI2CStatic$V;IIIIIIII)I' in 'I2CStatic' > [Entry Point] > [Verified Entry Point] > [Verified Value Entry Point (RO)] > ? # parm0: rsi = int > ? # parm1: rdx = int > ? # parm2: rcx = int > ? # parm3: r8 = int > ? # parm4: r9 = int > ? # parm5: rdi = int > ? # parm6: [sp+0x40] = int (sp of caller) > ? # parm7: [sp+0x48] = int [RESERVED] > ? # parm8: [sp+0x50] = int > ? # parm9: [sp+0x58] = int [RESERVED] > ? # parm10: [sp+0x60] = int > ? # parm11: [sp+0x68] = int > ? 0x00007fa924e371e0: push %rbp > ? 0x00007fa924e371e1: sub $0x30,%rsp > ? 0x00007fa924e371e5: mov $0x7fa9108ed690,%rbx > ? 0x00007fa924e371ef: callq 0x00007fa9249d9ac0 ; {runtime_call buffer_value_args} > ? 0x00007fa924e371f4: mov 0x10(%rax),%r11d > ? 0x00007fa924e371f8: mov %esi,0x10(%r11) > ? 0x00007fa924e371fc: mov %edx,0x14(%r11) > ? 0x00007fa924e37200: mov %r11,%rsi > ? 0x00007fa924e37203: mov %rcx,%rdx > ? 0x00007fa924e37206: mov %r8,%rcx > ? 0x00007fa924e37209: mov %r9,%r8 > ? 0x00007fa924e3720c: mov %rdi,%r9 > ? 0x00007fa924e3720f: mov 0x40(%rsp),%rdi > ? 0x00007fa924e37214: mov 0x50(%rsp),%r13 > ? 0x00007fa924e37219: mov %r13,0x40(%rsp) > ? 0x00007fa924e3721e: mov 0x60(%rsp),%r13 > ? 0x00007fa924e37223: mov %r13,0x48(%rsp) > ? 0x00007fa924e37228: mov 0x68(%rsp),%r13 > ? 0x00007fa924e3722d: mov %r13,0x50(%rsp) > ? 0x00007fa924e37232: pop %rbp > ? 0x00007fa924e37233: add $0x30,%rsp > ? 0x00007fa924e37237: jmpq 0x00007fa924e37240 > ? ... > [Verified Value Entry Point] > ? # parm0: rsi:rsi = 'java/lang/Object' > ? # parm1: rdx = int > ? # parm2: rcx = int > ? # parm3: r8 = int > ? # parm4: r9 = int > ? # parm5: rdi = int > ? # parm6: [sp+0x40] = int (sp of caller) > ? # parm7: [sp+0x48] = int > ? # parm8: [sp+0x50] = int > ? 0x00007fa924e37240: mov %eax,-0x16000(%rsp) > ? 0x00007fa924e37247: push %rbp > ? 0x00007fa924e37248: sub $0x30,%rsp From rwestrel at redhat.com Thu Apr 18 09:22:38 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Thu, 18 Apr 2019 11:22:38 +0200 Subject: [lworld] RFR(XL): 8220716: [lworld] C2 support for LW2 arrays In-Reply-To: References: Message-ID: <8736mfpt0h.fsf@redhat.com> > http://cr.openjdk.java.net/~thartmann/8220716/webrev.00/ Looks good to me. Roland. From tobias.hartmann at oracle.com Thu Apr 18 09:50:27 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 18 Apr 2019 11:50:27 +0200 Subject: [lworld] RFR(XL): 8220716: [lworld] C2 support for LW2 arrays In-Reply-To: <8736mfpt0h.fsf@redhat.com> References: <8736mfpt0h.fsf@redhat.com> Message-ID: Thanks Roland! Best regards, Tobias On 18.04.19 11:22, Roland Westrelin wrote: > >> http://cr.openjdk.java.net/~thartmann/8220716/webrev.00/ > > Looks good to me. > > Roland. > From srikanth.adayapalam at oracle.com Thu Apr 18 11:06:44 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Thu, 18 Apr 2019 16:36:44 +0530 Subject: Fwd: [JBS] {New} (JDK-8222721) [lworld] Javac generates 'Q' arrays for V.box[] and V?[] In-Reply-To: References: Message-ID: <273d1867-ae37-eb21-5744-c827bbcadd59@oracle.com> Hi Tobias, This does not look like a javac defect to me: Here is the local variable table from javap output: ?LocalVariableTable: ??????? Start? Length? Slot? Name?? Signature ??????????? 0????? 77???? 0? args?? [Ljava/lang/String; ??????????? 6????? 71???? 1? vbox?? [LTest$V; ?????????? 12????? 65???? 2??? vq?? [LTest$V; I think the reflection elements are at fault. Srikanth -------- Forwarded Message -------- Subject: [JBS] {New} (JDK-8222721) [lworld] Javac generates 'Q' arrays for V.box[] and V?[] Date: Thu, 18 Apr 2019 07:16:02 +0000 (UTC) From: Tobias Hartmann (JBS) To: srikanth.adayapalam at oracle.com Message Title Tobias Hartmann *created* an issue JDK / Bug JDK-8222721 [lworld] Javac generates 'Q' arrays for V.box[] and V?[] Issue Type: Bug Bug Affects Versions: repo-valhalla Assignee: Srikanth Adayapalam Components: hotspot Subcomponent: compiler Created: 2019-04-18 00:15 Priority: P2 P2 Reporter: Tobias Hartmann public class Test { ???value class V { ???????int f; ???????V(int ff) { ?????????f = ff; ???????} ???} ???public static void main(String[] args) { ???????V.box[] vbox = new V.box[16]; ???????V?[] vq = new V?[16]; ???????System.out.println("V.box="+vbox.getClass().getName()+"; "+vbox.getClass().getComponentType().getName()); ???????System.out.println("V?="+vq.getClass().getName()+"; "+vq.getClass().getComponentType().getName()); ???????vbox[0] = null; ???????vq[0] = null; ???} } Output: V.box=[QTest$V;; Test$V V?=[QTest$V;; Test$V Exception in thread "main" java.lang.NullPointerException at Test.main(Test.java:15) Add Comment Add Comment This message was sent by Atlassian Jira (v7.13.0#713000-sha1:fbf4068) Atlassian logo From tobias.hartmann at oracle.com Thu Apr 18 11:18:11 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 18 Apr 2019 13:18:11 +0200 Subject: Fwd: [JBS] {New} (JDK-8222721) [lworld] Javac generates 'Q' arrays for V.box[] and V?[] In-Reply-To: <273d1867-ae37-eb21-5744-c827bbcadd59@oracle.com> References: <273d1867-ae37-eb21-5744-c827bbcadd59@oracle.com> Message-ID: Hi Srikanth, you are right. I'll move the bug to core-libs. Thanks, Tobias On 18.04.19 13:06, Srikanth wrote: > Hi Tobias, > > This does not look like a javac defect to me: Here is the local variable table from javap output: > > ?LocalVariableTable: > ??????? Start? Length? Slot? Name?? Signature > ??????????? 0????? 77???? 0? args?? [Ljava/lang/String; > ??????????? 6????? 71???? 1? vbox?? [LTest$V; > ?????????? 12????? 65???? 2??? vq?? [LTest$V; > > I think the reflection elements are at fault. > > Srikanth > > > > > -------- Forwarded Message -------- > Subject: [JBS] {New} (JDK-8222721) [lworld] Javac generates 'Q' arrays for V.box[] and V?[] > Date: Thu, 18 Apr 2019 07:16:02 +0000 (UTC) > From: Tobias Hartmann (JBS) > To: srikanth.adayapalam at oracle.com > > > > Message Title > Tobias Hartmann *created* an > issue > > ? > JDK / Bug > JDK-8222721 > > [lworld] Javac generates 'Q' arrays for V.box[] and V?[] > > > Issue Type: Bug Bug > Affects Versions: repo-valhalla > Assignee: Srikanth Adayapalam > Components: hotspot > Subcomponent: compiler > Created: 2019-04-18 00:15 > Priority: P2 P2 > Reporter: Tobias Hartmann > > public class Test { > > ???value class V { > ???????int f; > ???????V(int ff) { > ?????????f = ff; > ???????} > ???} > > ???public static void main(String[] args) { > ???????V.box[] vbox = new V.box[16]; > ???????V?[] vq = new V?[16]; > ???????System.out.println("V.box="+vbox.getClass().getName()+"; > "+vbox.getClass().getComponentType().getName()); > ???????System.out.println("V?="+vq.getClass().getName()+"; > "+vq.getClass().getComponentType().getName()); > ???????vbox[0] = null; > ???????vq[0] = null; > ???} > } > > Output: > > V.box=[QTest$V;; Test$V > V?=[QTest$V;; Test$V > Exception in thread "main" java.lang.NullPointerException > at Test.main(Test.java:15) > > Add Comment Add Comment > > > ? > > This message was sent by Atlassian Jira (v7.13.0#713000-sha1:fbf4068) > Atlassian logo > From srikanth.adayapalam at oracle.com Thu Apr 18 12:35:42 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Thu, 18 Apr 2019 12:35:42 +0000 Subject: hg: valhalla/valhalla: 8222722: [lworld] Javac fails to compile V?[].class Message-ID: <201904181235.x3ICZgKv011124@aojmv0008.oracle.com> Changeset: 30a601469cc4 Author: sadayapalam Date: 2019-04-18 18:05 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/30a601469cc4 8222722: [lworld] Javac fails to compile V?[].class ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/langtools/tools/javac/valhalla/lworld-values/ProjectedArrayDotClass.java From tobias.hartmann at oracle.com Thu Apr 18 12:42:24 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Thu, 18 Apr 2019 12:42:24 +0000 Subject: hg: valhalla/valhalla: 8222729: [lworld] Crash in Symbol::print_as_signature_external_parameters when encountering [Q Message-ID: <201904181242.x3ICgOQx017429@aojmv0008.oracle.com> Changeset: a21151890849 Author: thartmann Date: 2019-04-18 14:42 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/a21151890849 8222729: [lworld] Crash in Symbol::print_as_signature_external_parameters when encountering [Q ! src/hotspot/share/oops/symbol.cpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestArrays.java From harold.seigel at oracle.com Thu Apr 18 12:58:43 2019 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Thu, 18 Apr 2019 12:58:43 +0000 Subject: hg: valhalla/valhalla: 8222730: Hidden class names should only be accessible through 'this_class' cp entry Message-ID: <201904181258.x3ICwhYn026015@aojmv0008.oracle.com> Changeset: f27772ae22fa Author: hseigel Date: 2019-04-18 08:58 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f27772ae22fa 8222730: Hidden class names should only be accessible through 'this_class' cp entry Summary: Add a new cp utf8 entry for specified hidden name and change this_class's cp Class_info entry to point to it Reviewed-by: dholmes ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/klassFactory.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klass.cpp ! test/jdk/java/lang/invoke/defineClass/DefineNonFindableClass.java ! test/jdk/java/lang/invoke/defineClass/nonFindable/NonFindable.java + test/jdk/java/lang/invoke/defineClass/nonFindable/NonFindableField.java + test/jdk/java/lang/invoke/defineClass/nonFindable/NonFindableMethod.java From srikanth.adayapalam at oracle.com Thu Apr 18 14:32:18 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Thu, 18 Apr 2019 20:02:18 +0530 Subject: Withdraw .box and .val syntax ?? Message-ID: <4e105292-aca3-fb49-6e17-7ef6f3d050fd@oracle.com> I have seen various commit messages fly by that indicate that tests are being migrated into the new syntax V?. Is it ok to withdraw the older .box and .val syntax - Anybody still depending on it ? Or any other reason to keep it around ? Thanks Srikanth From brian.goetz at oracle.com Thu Apr 18 15:04:59 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Thu, 18 Apr 2019 11:04:59 -0400 Subject: Withdraw .box and .val syntax ?? In-Reply-To: <4e105292-aca3-fb49-6e17-7ef6f3d050fd@oracle.com> References: <4e105292-aca3-fb49-6e17-7ef6f3d050fd@oracle.com> Message-ID: <841F2734-26AE-4116-9A55-49BA85CAE211@oracle.com> As soon as the tests are migrated over, I think you can GC it. > On Apr 18, 2019, at 10:32 AM, Srikanth wrote: > > I have seen various commit messages fly by that indicate that tests are being migrated into the new syntax V?. > > Is it ok to withdraw the older .box and .val syntax - Anybody still depending on it ? Or any other reason to keep it around ? > > Thanks > Srikanth From karen.kinnear at oracle.com Thu Apr 18 16:28:55 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 18 Apr 2019 12:28:55 -0400 Subject: Withdraw .box and .val syntax ?? In-Reply-To: <841F2734-26AE-4116-9A55-49BA85CAE211@oracle.com> References: <4e105292-aca3-fb49-6e17-7ef6f3d050fd@oracle.com> <841F2734-26AE-4116-9A55-49BA85CAE211@oracle.com> Message-ID: <40E868C1-2888-472C-A43E-35C9DCA90588@oracle.com> Agreed - as soon as all uses are migrated, you can GC it. I just filed JDK-8222740 for core libraries to clean up uses. I believe that between Tobias and Harold the runtime has removed uses from our tests. thank you for bringing this up, Karen > On Apr 18, 2019, at 11:04 AM, Brian Goetz wrote: > > As soon as the tests are migrated over, I think you can GC it. > >> On Apr 18, 2019, at 10:32 AM, Srikanth wrote: >> >> I have seen various commit messages fly by that indicate that tests are being migrated into the new syntax V?. >> >> Is it ok to withdraw the older .box and .val syntax - Anybody still depending on it ? Or any other reason to keep it around ? >> >> Thanks >> Srikanth > From ioi.lam at oracle.com Thu Apr 18 16:53:26 2019 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Thu, 18 Apr 2019 16:53:26 +0000 Subject: hg: valhalla/valhalla: 8222712: [lworld] print parameter types for different compiled entry points Message-ID: <201904181653.x3IGrRjM016300@aojmv0008.oracle.com> Changeset: 8f90ea256ff7 Author: iklam Date: 2019-04-18 09:51 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8f90ea256ff7 8222712: [lworld] print parameter types for different compiled entry points Reviewed-by: thartmann ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java From harold.seigel at oracle.com Thu Apr 18 19:10:20 2019 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Thu, 18 Apr 2019 19:10:20 +0000 Subject: hg: valhalla/valhalla: Summary: Change tests to use value? and value instead of value.box and value.val Message-ID: <201904181910.x3IJALB1006484@aojmv0008.oracle.com> Changeset: 54d28015bbe3 Author: hseigel Date: 2019-04-18 15:09 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/54d28015bbe3 Summary: Change tests to use value? and value instead of value.box and value.val Reviewed-by lfoltan ! test/jdk/valhalla/valuetypes/MixedValues.java ! test/jdk/valhalla/valuetypes/NonFlattenValue.java ! test/jdk/valhalla/valuetypes/ObjectMethods.java ! test/jdk/valhalla/valuetypes/SubstitutabilityTest.java ! test/jdk/valhalla/valuetypes/ValueArray.java From david.simms at oracle.com Fri Apr 19 10:32:57 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 19 Apr 2019 12:32:57 +0200 Subject: Result: New Valhalla Committer: Chris Hegarty Message-ID: <6bde2c52-11c8-65f3-92c8-a98904b3b7df@oracle.com> Voting for? Chris Hegarty [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. David Simms [1] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-April/005558.html From david.simms at oracle.com Fri Apr 19 10:33:02 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 19 Apr 2019 12:33:02 +0200 Subject: Result: New Valhalla Committer: Roger Riggs Message-ID: <7dc49db8-f2e9-b872-ec82-cbab2e9bc5be@oracle.com> Voting for? Roger Riggs [1] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. David Simms [1] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-April/005559.html From srikanth.adayapalam at oracle.com Sat Apr 20 03:33:11 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Sat, 20 Apr 2019 03:33:11 +0000 Subject: hg: valhalla/valhalla: 8222783: [lworld] Withdraw support for .box and .val syntax Message-ID: <201904200333.x3K3XCc0008527@aojmv0008.oracle.com> Changeset: 9c1cd9deab83 Author: sadayapalam Date: 2019-04-20 09:03 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9c1cd9deab83 8222783: [lworld] Withdraw support for .box and .val syntax ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum1.java ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum2.java ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum8.java ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/util/HashMapValueEntry.java ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/util/HashMapValueTotal.java ! test/langtools/tools/javac/valhalla/lworld-values/ArrayCreationWithQuestion.java ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java ! test/langtools/tools/javac/valhalla/lworld-values/CheckFieldDescriptors.java ! test/langtools/tools/javac/valhalla/lworld-values/CheckFlattenableCycles.java ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java ! test/langtools/tools/javac/valhalla/lworld-values/IntercastTest.java ! test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest.java ! test/langtools/tools/javac/valhalla/lworld-values/Point.java From srikanth.adayapalam at oracle.com Sat Apr 20 03:35:48 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sat, 20 Apr 2019 09:05:48 +0530 Subject: hg: valhalla/valhalla: 8222783: [lworld] Withdraw support for .box and .val syntax In-Reply-To: <201904200333.x3K3XCc0008527@aojmv0008.oracle.com> References: <201904200333.x3K3XCc0008527@aojmv0008.oracle.com> Message-ID: <284d182a-a367-fa52-f4f0-17fdd830ea5e@oracle.com> I found a few lingering uses in the benchmark files and have cleaned them. .box and .val are dead as a dodo. RIP. Srikanth On 20/04/19 9:03 AM, srikanth.adayapalam at oracle.com wrote: > Changeset: 9c1cd9deab83 > Author: sadayapalam > Date: 2019-04-20 09:03 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9c1cd9deab83 > > 8222783: [lworld] Withdraw support for .box and .val syntax > > ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java > ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum1.java > ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum2.java > ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum8.java > ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/util/HashMapValueEntry.java > ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/util/HashMapValueTotal.java > ! test/langtools/tools/javac/valhalla/lworld-values/ArrayCreationWithQuestion.java > ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java > ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java > ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java > ! test/langtools/tools/javac/valhalla/lworld-values/CheckFieldDescriptors.java > ! test/langtools/tools/javac/valhalla/lworld-values/CheckFlattenableCycles.java > ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java > ! test/langtools/tools/javac/valhalla/lworld-values/IntercastTest.java > ! test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest.java > ! test/langtools/tools/javac/valhalla/lworld-values/Point.java > From srikanth.adayapalam at oracle.com Sat Apr 20 05:34:34 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Sat, 20 Apr 2019 05:34:34 +0000 Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors Message-ID: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> Changeset: 49898238a5bb Author: sadayapalam Date: 2019-04-20 11:04 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/49898238a5bb 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/langtools/tools/javac/diags/examples.not-yet.txt ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.java ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.out ! test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.java ! test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.out ! test/langtools/tools/javac/valhalla/lworld-values/InferredValueParameterizationTest.java ! test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java ! test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest.java - test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest2.out ! test/langtools/tools/javac/valhalla/lworld-values/ValuesAsRefs.java From srikanth.adayapalam at oracle.com Sat Apr 20 05:38:21 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sat, 20 Apr 2019 11:08:21 +0530 Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors In-Reply-To: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> References: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> Message-ID: I have removed the support for these two internal experimental options: (1) -XDdisallowValueConstructors: We have settled on value instance construction using the canonial construction syntax via new (). (2) -XDallowGenericsOverValues: Use the null projection type instead (V?) Here is a summary of current internal options: Of these the last two are supposed to be transitory. If you are the concerned contributor, let me know as soon as these can be withdrawn. -XDallowWithFieldOperator -XDallowValueBasedClasses -XDallowEmptyValues -XDnonCovariantValueArrays -XDallowValueMemberCycles Thanks! Srikanth On 20/04/19 11:04 AM, srikanth.adayapalam at oracle.com wrote: > Changeset: 49898238a5bb > Author: sadayapalam > Date: 2019-04-20 11:04 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/49898238a5bb > > 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors > > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties > ! test/langtools/tools/javac/diags/examples.not-yet.txt > ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java > ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java > ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.java > ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.out > ! test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.java > ! test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.out > ! test/langtools/tools/javac/valhalla/lworld-values/InferredValueParameterizationTest.java > ! test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java > ! test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest.java > - test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest2.out > ! test/langtools/tools/javac/valhalla/lworld-values/ValuesAsRefs.java > From srikanth.adayapalam at oracle.com Sat Apr 20 06:45:32 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Sat, 20 Apr 2019 06:45:32 +0000 Subject: hg: valhalla/valhalla: 8222745: [lworld] Declare value classes with "inline" modifier Message-ID: <201904200645.x3K6jXaF014709@aojmv0008.oracle.com> Changeset: 0fab32ad7048 Author: sadayapalam Date: 2019-04-20 12:15 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0fab32ad7048 8222745: [lworld] Declare value classes with "inline" modifier + src/java.base/share/classes/java/lang/__inline__.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java ! test/langtools/tools/javac/diags/CheckResourceKeys.java + test/langtools/tools/javac/valhalla/lworld-values/InlineAnnotationOnAnonymousClass.java + test/langtools/tools/javac/valhalla/lworld-values/InlineAnnotationOnAnonymousClass.out + test/langtools/tools/javac/valhalla/lworld-values/InlineAnnotationTest.java + test/langtools/tools/javac/valhalla/lworld-values/InlineAnnotationTest.out + test/langtools/tools/javac/valhalla/lworld-values/InlineClassTest.java From srikanth.adayapalam at oracle.com Sat Apr 20 06:50:51 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sat, 20 Apr 2019 12:20:51 +0530 Subject: hg: valhalla/valhalla: 8222745: [lworld] Declare value classes with "inline" modifier In-Reply-To: <201904200645.x3K6jXaF014709@aojmv0008.oracle.com> References: <201904200645.x3K6jXaF014709@aojmv0008.oracle.com> Message-ID: <5783859c-5884-ec42-8c74-7889c3cf2b4d@oracle.com> So value classes er .. inline classes are declared with the inline modifier. Also @__inline__ can be used till IDEs catch up. I have not yet withdrawn "value" as a modifier. The @__value__ annotation also remains. I would like to nuke these by end of next business week unless I hear objections/alternatives. Srikanth On 20/04/19 12:15 PM, srikanth.adayapalam at oracle.com wrote: > Changeset: 0fab32ad7048 > Author: sadayapalam > Date: 2019-04-20 12:15 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/0fab32ad7048 > > 8222745: [lworld] Declare value classes with "inline" modifier > > + src/java.base/share/classes/java/lang/__inline__.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java > ! test/langtools/tools/javac/diags/CheckResourceKeys.java > + test/langtools/tools/javac/valhalla/lworld-values/InlineAnnotationOnAnonymousClass.java > + test/langtools/tools/javac/valhalla/lworld-values/InlineAnnotationOnAnonymousClass.out > + test/langtools/tools/javac/valhalla/lworld-values/InlineAnnotationTest.java > + test/langtools/tools/javac/valhalla/lworld-values/InlineAnnotationTest.out > + test/langtools/tools/javac/valhalla/lworld-values/InlineClassTest.java > From srikanth.adayapalam at oracle.com Sat Apr 20 07:50:01 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Sat, 20 Apr 2019 07:50:01 +0000 Subject: hg: valhalla/valhalla: [lworld] Migrate test still depending on -XDallowGenericsOverValues Message-ID: <201904200750.x3K7o1jS014763@aojmv0008.oracle.com> Changeset: f6bbd4dca166 Author: sadayapalam Date: 2019-04-20 13:19 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f6bbd4dca166 [lworld] Migrate test still depending on -XDallowGenericsOverValues ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java From forax at univ-mlv.fr Sat Apr 20 10:23:43 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 20 Apr 2019 12:23:43 +0200 (CEST) Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors In-Reply-To: References: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> Message-ID: <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> Hum, i think you have been a little too fast on removing -XDallowGenericsOverValues, there are still a lot of constructions that doesn't support the null projection. - you can not use '?' in 'implements Comparable' so the following code doesn't compile public @__value__ class Foo implements Comparable{ final int value; public Foo(int value) { this.value = value; } @Override public int compareTo(Foo? o) { return Integer.compare(value, foo.value); } } - lambda with wildcard doesn't work import java.util.function.Consumer; public @__value__ class CaptureBug { final int value; public CaptureBug(int value) { this.value = value; } private static void accept(Consumer consumer) { consumer.accept(new CaptureBug(3)); } public static void main(String[] args) { accept(value -> System.out.println(value)); } } - .class notation is not supported public class DotClass { final int value; public DotClass(int value) { this.value = value; } private static T foo(Class type) { return null; } public static void main(String[] args) { foo(DotClass?.class); } } I'm sure they are other cases, i will iterate over all my examples later this week end. R?mi ----- Mail original ----- > De: "Srikanth" > ?: "valhalla-dev" > Envoy?: Samedi 20 Avril 2019 07:38:21 > Objet: Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and > -XDdisallowValueConstructors > I have removed the support for these two internal experimental options: > > (1) -XDdisallowValueConstructors: We have settled on value instance > construction using the canonial construction syntax via new (). > > (2) -XDallowGenericsOverValues: Use the null projection type instead (V?) > > Here is a summary of current internal options: Of these the last two are > supposed to be transitory. If you are the concerned contributor, let me > know as soon as these can be withdrawn. > > -XDallowWithFieldOperator > -XDallowValueBasedClasses > -XDallowEmptyValues > -XDnonCovariantValueArrays > -XDallowValueMemberCycles > > Thanks! > Srikanth > > On 20/04/19 11:04 AM, srikanth.adayapalam at oracle.com wrote: >> Changeset: 49898238a5bb >> Author: sadayapalam >> Date: 2019-04-20 11:04 +0530 >> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/49898238a5bb >> >> 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and >> -XDdisallowValueConstructors >> >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java >> ! >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties >> ! test/langtools/tools/javac/diags/examples.not-yet.txt >> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java >> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.java >> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.out >> ! >> test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.java >> ! >> test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.out >> ! >> test/langtools/tools/javac/valhalla/lworld-values/InferredValueParameterizationTest.java >> ! test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java >> ! test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest.java >> - test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest2.out >> ! test/langtools/tools/javac/valhalla/lworld-values/ValuesAsRefs.java From srikanth.adayapalam at oracle.com Sat Apr 20 11:44:22 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sat, 20 Apr 2019 17:14:22 +0530 Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors In-Reply-To: <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> References: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> Message-ID: Hi Remi, Thanks for the test cases, I will take a look at these and see how straightforward the fixes will be. If necessary I can revert the withdrawal - do send me other cases as you iterate over your examples Thanks! Srikanth On 20/04/19 3:53 PM, Remi Forax wrote: > Hum, > i think you have been a little too fast on removing -XDallowGenericsOverValues, > there are still a lot of constructions that doesn't support the null projection. > > - you can not use '?' in 'implements Comparable' so the following code doesn't compile > public @__value__ class Foo implements Comparable{ > final int value; > > public Foo(int value) { > this.value = value; > } > > @Override > public int compareTo(Foo? o) { > return Integer.compare(value, foo.value); > } > } > > - lambda with wildcard doesn't work > import java.util.function.Consumer; > > public @__value__ class CaptureBug { > final int value; > > public CaptureBug(int value) { > this.value = value; > } > > private static void accept(Consumer consumer) { > consumer.accept(new CaptureBug(3)); > } > > public static void main(String[] args) { > accept(value -> System.out.println(value)); > } > } > > - .class notation is not supported > public class DotClass { > final int value; > > public DotClass(int value) { > this.value = value; > } > > private static T foo(Class type) { > return null; > } > > public static void main(String[] args) { > foo(DotClass?.class); > } > } > > > I'm sure they are other cases, i will iterate over all my examples later this week end. > > R?mi > > ----- Mail original ----- >> De: "Srikanth" >> ?: "valhalla-dev" >> Envoy?: Samedi 20 Avril 2019 07:38:21 >> Objet: Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and >> -XDdisallowValueConstructors >> I have removed the support for these two internal experimental options: >> >> (1) -XDdisallowValueConstructors: We have settled on value instance >> construction using the canonial construction syntax via new (). >> >> (2) -XDallowGenericsOverValues: Use the null projection type instead (V?) >> >> Here is a summary of current internal options: Of these the last two are >> supposed to be transitory. If you are the concerned contributor, let me >> know as soon as these can be withdrawn. >> >> -XDallowWithFieldOperator >> -XDallowValueBasedClasses >> -XDallowEmptyValues >> -XDnonCovariantValueArrays >> -XDallowValueMemberCycles >> >> Thanks! >> Srikanth >> >> On 20/04/19 11:04 AM, srikanth.adayapalam at oracle.com wrote: >>> Changeset: 49898238a5bb >>> Author: sadayapalam >>> Date: 2019-04-20 11:04 +0530 >>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/49898238a5bb >>> >>> 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and >>> -XDdisallowValueConstructors >>> >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java >>> ! >>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties >>> ! test/langtools/tools/javac/diags/examples.not-yet.txt >>> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.out >>> ! >>> test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.java >>> ! >>> test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.out >>> ! >>> test/langtools/tools/javac/valhalla/lworld-values/InferredValueParameterizationTest.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java >>> ! test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest.java >>> - test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest2.out >>> ! test/langtools/tools/javac/valhalla/lworld-values/ValuesAsRefs.java From forax at univ-mlv.fr Sat Apr 20 12:06:27 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Sat, 20 Apr 2019 14:06:27 +0200 (CEST) Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors In-Reply-To: References: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> Message-ID: <153596075.332636.1555761987892.JavaMail.zimbra@u-pem.fr> ok, i've found only one another one, with import java.util.stream.IntStream; public @__value__ class StreamBug { final int value; public StreamBug(int value) { this.value = value; } public static void main(String[] args) { //var bug = new StreamBug?(7); IntStream.range(0, 10).mapToObj(StreamBug::new).forEach(System.out::println); } } in mapToObj(), it should be StreamBug?::new which doesn't compile, which also means that new StreamBug?(7) should be valid. but i don't think it's the right solution, i think the inference as to be smarter and infers that when you capture a value type to a type variable, the nullable version has to be inferred automatically. R?mi ----- Mail original ----- > De: "Srikanth" > ?: "Remi Forax" > Cc: "valhalla-dev" > Envoy?: Samedi 20 Avril 2019 13:44:22 > Objet: Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and > -XDdisallowValueConstructors > Hi Remi, > > Thanks for the test cases, I will take a look at these and see how > straightforward the fixes will be. > If necessary I can revert the withdrawal - do send me other cases as you > iterate over your examples > > Thanks! > Srikanth > > On 20/04/19 3:53 PM, Remi Forax wrote: >> Hum, >> i think you have been a little too fast on removing -XDallowGenericsOverValues, >> there are still a lot of constructions that doesn't support the null projection. >> >> - you can not use '?' in 'implements Comparable' so the following code >> doesn't compile >> public @__value__ class Foo implements Comparable{ >> final int value; >> >> public Foo(int value) { >> this.value = value; >> } >> >> @Override >> public int compareTo(Foo? o) { >> return Integer.compare(value, foo.value); >> } >> } >> >> - lambda with wildcard doesn't work >> import java.util.function.Consumer; >> >> public @__value__ class CaptureBug { >> final int value; >> >> public CaptureBug(int value) { >> this.value = value; >> } >> >> private static void accept(Consumer consumer) { >> consumer.accept(new CaptureBug(3)); >> } >> >> public static void main(String[] args) { >> accept(value -> System.out.println(value)); >> } >> } >> >> - .class notation is not supported >> public class DotClass { >> final int value; >> >> public DotClass(int value) { >> this.value = value; >> } >> >> private static T foo(Class type) { >> return null; >> } >> >> public static void main(String[] args) { >> foo(DotClass?.class); >> } >> } >> >> >> I'm sure they are other cases, i will iterate over all my examples later this >> week end. >> >> R?mi >> >> ----- Mail original ----- >>> De: "Srikanth" >>> ?: "valhalla-dev" >>> Envoy?: Samedi 20 Avril 2019 07:38:21 >>> Objet: Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler >>> options: -XDallowGenericsOverValues and >>> -XDdisallowValueConstructors >>> I have removed the support for these two internal experimental options: >>> >>> (1) -XDdisallowValueConstructors: We have settled on value instance >>> construction using the canonial construction syntax via new (). >>> >>> (2) -XDallowGenericsOverValues: Use the null projection type instead (V?) >>> >>> Here is a summary of current internal options: Of these the last two are >>> supposed to be transitory. If you are the concerned contributor, let me >>> know as soon as these can be withdrawn. >>> >>> -XDallowWithFieldOperator >>> -XDallowValueBasedClasses >>> -XDallowEmptyValues >>> -XDnonCovariantValueArrays >>> -XDallowValueMemberCycles >>> >>> Thanks! >>> Srikanth >>> >>> On 20/04/19 11:04 AM, srikanth.adayapalam at oracle.com wrote: >>>> Changeset: 49898238a5bb >>>> Author: sadayapalam >>>> Date: 2019-04-20 11:04 +0530 >>>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/49898238a5bb >>>> >>>> 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and >>>> -XDdisallowValueConstructors >>>> >>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java >>>> ! >>>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties >>>> ! test/langtools/tools/javac/diags/examples.not-yet.txt >>>> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java >>>> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.java >>>> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.out >>>> ! >>>> test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.java >>>> ! >>>> test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.out >>>> ! >>>> test/langtools/tools/javac/valhalla/lworld-values/InferredValueParameterizationTest.java >>>> ! test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java >>>> ! test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest.java >>>> - test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest2.out > >>> ! test/langtools/tools/javac/valhalla/lworld-values/ValuesAsRefs.java From forax at univ-mlv.fr Sat Apr 20 12:23:42 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 20 Apr 2019 14:23:42 +0200 (CEST) Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors In-Reply-To: <153596075.332636.1555761987892.JavaMail.zimbra@u-pem.fr> References: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> <153596075.332636.1555761987892.JavaMail.zimbra@u-pem.fr> Message-ID: <1070796117.333742.1555763022182.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "Remi Forax" > ?: "Srikanth" > Cc: "valhalla-dev" > Envoy?: Samedi 20 Avril 2019 14:06:27 > Objet: Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and > -XDdisallowValueConstructors > ok, > i've found only one another one, with > > import java.util.stream.IntStream; > > public @__value__ class StreamBug { > final int value; > > public StreamBug(int value) { > this.value = value; > } > > public static void main(String[] args) { > //var bug = new StreamBug?(7); > > IntStream.range(0, 10).mapToObj(StreamBug::new).forEach(System.out::println); > } > } > > in mapToObj(), it should be StreamBug?::new which doesn't compile, which also > means that new StreamBug?(7) should be valid. > > but i don't think it's the right solution, i think the inference as to be > smarter and infers that when you capture a value type to a type variable, the > nullable version has to be inferred automatically. nope, thinking a little more about this case, it's not a good idea to change the inference, otherwise if in the future Stream is a reified generics, then the inference will return a different type (Stream instead of Stream) and given that in Java generics are non-variant, it means that transforming a generics to a reified generics is not a source backward compatible change. we have to go with StreamBug?::new and new StreamBug?(42) R?mi > > ----- Mail original ----- >> De: "Srikanth" >> ?: "Remi Forax" >> Cc: "valhalla-dev" >> Envoy?: Samedi 20 Avril 2019 13:44:22 >> Objet: Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler >> options: -XDallowGenericsOverValues and >> -XDdisallowValueConstructors > >> Hi Remi, >> >> Thanks for the test cases, I will take a look at these and see how >> straightforward the fixes will be. >> If necessary I can revert the withdrawal - do send me other cases as you >> iterate over your examples >> >> Thanks! >> Srikanth >> >> On 20/04/19 3:53 PM, Remi Forax wrote: >>> Hum, >>> i think you have been a little too fast on removing -XDallowGenericsOverValues, >>> there are still a lot of constructions that doesn't support the null projection. >>> >>> - you can not use '?' in 'implements Comparable' so the following code >>> doesn't compile >>> public @__value__ class Foo implements Comparable{ >>> final int value; >>> >>> public Foo(int value) { >>> this.value = value; >>> } >>> >>> @Override >>> public int compareTo(Foo? o) { >>> return Integer.compare(value, foo.value); >>> } >>> } >>> >>> - lambda with wildcard doesn't work >>> import java.util.function.Consumer; >>> >>> public @__value__ class CaptureBug { >>> final int value; >>> >>> public CaptureBug(int value) { >>> this.value = value; >>> } >>> >>> private static void accept(Consumer consumer) { >>> consumer.accept(new CaptureBug(3)); >>> } >>> >>> public static void main(String[] args) { >>> accept(value -> System.out.println(value)); >>> } >>> } >>> >>> - .class notation is not supported >>> public class DotClass { >>> final int value; >>> >>> public DotClass(int value) { >>> this.value = value; >>> } >>> >>> private static T foo(Class type) { >>> return null; >>> } >>> >>> public static void main(String[] args) { >>> foo(DotClass?.class); >>> } >>> } >>> >>> >>> I'm sure they are other cases, i will iterate over all my examples later this >>> week end. >>> >>> R?mi >>> >>> ----- Mail original ----- >>>> De: "Srikanth" >>>> ?: "valhalla-dev" >>>> Envoy?: Samedi 20 Avril 2019 07:38:21 >>>> Objet: Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler >>>> options: -XDallowGenericsOverValues and >>>> -XDdisallowValueConstructors >>>> I have removed the support for these two internal experimental options: >>>> >>>> (1) -XDdisallowValueConstructors: We have settled on value instance >>>> construction using the canonial construction syntax via new (). >>>> >>>> (2) -XDallowGenericsOverValues: Use the null projection type instead (V?) >>>> >>>> Here is a summary of current internal options: Of these the last two are >>>> supposed to be transitory. If you are the concerned contributor, let me >>>> know as soon as these can be withdrawn. >>>> >>>> -XDallowWithFieldOperator >>>> -XDallowValueBasedClasses >>>> -XDallowEmptyValues >>>> -XDnonCovariantValueArrays >>>> -XDallowValueMemberCycles >>>> >>>> Thanks! >>>> Srikanth >>>> >>>> On 20/04/19 11:04 AM, srikanth.adayapalam at oracle.com wrote: >>>>> Changeset: 49898238a5bb >>>>> Author: sadayapalam >>>>> Date: 2019-04-20 11:04 +0530 >>>>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/49898238a5bb >>>>> >>>>> 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and >>>>> -XDdisallowValueConstructors >>>>> >>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >>>>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java >>>>> ! >>>>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties >>>>> ! test/langtools/tools/javac/diags/examples.not-yet.txt >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.java >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFinal.out >>>>> ! >>>>> test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.java >>>>> ! >>>>> test/langtools/tools/javac/valhalla/lworld-values/CheckValueFactoryWithReference.out >>>>> ! >>>>> test/langtools/tools/javac/valhalla/lworld-values/InferredValueParameterizationTest.java >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java >>>>> ! test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest.java >>>>> - test/langtools/tools/javac/valhalla/lworld-values/ValueOverGenericsTest2.out > > >>> ! test/langtools/tools/javac/valhalla/lworld-values/ValuesAsRefs.java From srikanth.adayapalam at oracle.com Sat Apr 20 12:54:26 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sat, 20 Apr 2019 18:24:26 +0530 Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors In-Reply-To: <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> References: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> Message-ID: On 20/04/19 3:53 PM, Remi Forax wrote: > - .class notation is not supported > public class DotClass { > final int value; > > public DotClass(int value) { > this.value = value; > } > > private static T foo(Class type) { > return null; > } > > public static void main(String[] args) { > foo(DotClass?.class); > } > } For .class notation, see https://bugs.openjdk.java.net/browse/JDK-8221323 where there is an express request not to support these: "Moving forward it looks like we want to say "Foo.class" for class constant (ldc Class) in source code. If you want the boxed/value class mirror, you need to use Class.asBoxType()/asValueType() methods." Any difference of opinion ?? Srikanth From forax at univ-mlv.fr Sat Apr 20 13:44:19 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Sat, 20 Apr 2019 15:44:19 +0200 (CEST) Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors In-Reply-To: References: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> Message-ID: <1206796893.336309.1555767859659.JavaMail.zimbra@u-pem.fr> > De: "Srikanth" > ?: "Remi Forax" > Cc: "valhalla-dev" > Envoy?: Samedi 20 Avril 2019 14:54:26 > Objet: Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler > options: -XDallowGenericsOverValues and -XDdisallowValueConstructors > On 20/04/19 3:53 PM, Remi Forax wrote: >> - .class notation is not supported >> public class DotClass { >> final int value; >> public DotClass(int value) { >> this.value = value; >> } >> private static T foo(Class type) { >> return null; >> } >> public static void main(String[] args) { >> foo(DotClass?.class); >> } >> } > For .class notation, see [ https://bugs.openjdk.java.net/browse/JDK-8221323 | > https://bugs.openjdk.java.net/browse/JDK-8221323 ] > where there is an express request not to support these: > " Moving forward it looks like we want to say "Foo.class" for class constant > (ldc Class) in source code. If you want the boxed/value class mirror, you need > to use Class.asBoxType()/asValueType() methods. " > Any difference of opinion ?? yes, there are two side of the support of Foo?.class, one is how to get the reference to the inline class at runtime, the methods asXXXType covers this, but there is also a typing part, as in the example, the resulting type should be a Class and not a Class. So i agree that we do not need to support the special syntax Foo?.class but in that case the methods asXXXType have to be recognized by the compiler the same way Object.getClass() has a special typing rule in the compiler. regards, R?mi > Srikanth From srikanth.adayapalam at oracle.com Sat Apr 20 13:50:07 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sat, 20 Apr 2019 19:20:07 +0530 Subject: hg: valhalla/valhalla: 8222784: [lworld] Remove stale compiler options: -XDallowGenericsOverValues and -XDdisallowValueConstructors In-Reply-To: <1206796893.336309.1555767859659.JavaMail.zimbra@u-pem.fr> References: <201904200534.x3K5YZnI008761@aojmv0008.oracle.com> <72294507.328745.1555755823551.JavaMail.zimbra@u-pem.fr> <1206796893.336309.1555767859659.JavaMail.zimbra@u-pem.fr> Message-ID: Ok, Thanks, I have reopened https://bugs.openjdk.java.net/browse/JDK-8221323 to cover any potential work here. Srikanth On 20/04/19 7:14 PM, forax at univ-mlv.fr wrote: > > > ------------------------------------------------------------------------ > > *De: *"Srikanth" > *?: *"Remi Forax" > *Cc: *"valhalla-dev" > *Envoy?: *Samedi 20 Avril 2019 14:54:26 > *Objet: *Re: hg: valhalla/valhalla: 8222784: [lworld] Remove stale > compiler options: -XDallowGenericsOverValues and > -XDdisallowValueConstructors > > > > On 20/04/19 3:53 PM, Remi Forax wrote: > > - .class notation is not supported > public class DotClass { > final int value; > > public DotClass(int value) { > this.value = value; > } > > private static T foo(Class type) { > return null; > } > > public static void main(String[] args) { > foo(DotClass?.class); > } > } > > For .class notation, see > https://bugs.openjdk.java.net/browse/JDK-8221323 > where there is an express request not to support these: > > "Moving forward it looks like we want to say "Foo.class" for class > constant (ldc Class) in source code. If you want the boxed/value > class mirror, you need to use Class.asBoxType()/asValueType() > methods." > > Any difference of opinion ?? > > > yes, > there are two side of the support of Foo?.class, one is how to get the > reference to the inline class at runtime, the methods asXXXType covers > this, but there is also a typing part, as in the example, the > resulting type should be a Class and not a Class. > > So i agree that we do not need to support the special syntax > Foo?.class but in that case the methods asXXXType have to be > recognized by the compiler the same way Object.getClass() has a > special typing rule in the compiler. > > regards, > R?mi > > > > Srikanth > > From srikanth.adayapalam at oracle.com Sat Apr 20 15:05:27 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Sat, 20 Apr 2019 15:05:27 +0000 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via Message-ID: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> Changeset: cc473d393abf Author: sadayapalam Date: 2019-04-20 20:35 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cc473d393abf 8222711: [lworld] Initial skeletal implementation of inline class instance construction via ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/TransValues.java ! src/jdk.jdeps/share/classes/com/sun/tools/javap/ClassWriter.java From srikanth.adayapalam at oracle.com Sat Apr 20 15:19:21 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sat, 20 Apr 2019 20:49:21 +0530 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> Message-ID: <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> JVM folk: I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM should be enhanced to work with static factory methods for inline types) in connection with this. I have pushed an initial implementation for JDK-8222711 that alters the way code is generated by javac for inline classes. Rather than emit synthetic $makeValue$ methods that embody the construction, now with the option -XDstaticInitValueFactory emits source level constructors into class file level static factories that ??? - have the name ??? - are static methods ??? - have a return type that matches the class ??? - are invoked via invokestatic at the new V() construction site. All 4 are potential irritants to the JVM and need to be addressed before JDK-8222711 can be tested at all. I have eyeballed the code generated by this changeset and it passes muster, but real testing is possible only after the VM stops choking with: Error: LinkageError occurred while loading main class X ??? java.lang.ClassFormatError: Method "" in class X has illegal signature "(Ljava/lang/String;)QX;" Thanks for looking into this. Srikanth On 20/04/19 8:35 PM, srikanth.adayapalam at oracle.com wrote: > Changeset: cc473d393abf > Author: sadayapalam > Date: 2019-04-20 20:35 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cc473d393abf > > 8222711: [lworld] Initial skeletal implementation of inline class instance construction via > > ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/TransValues.java > ! src/jdk.jdeps/share/classes/com/sun/tools/javap/ClassWriter.java > From srikanth.adayapalam at oracle.com Sat Apr 20 15:59:30 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Sat, 20 Apr 2019 15:59:30 +0000 Subject: hg: valhalla/valhalla: 8222784: [lworld] Partial revert. Restore -XDallowGenericsOverValues for now. Message-ID: <201904201559.x3KFxU8l021248@aojmv0008.oracle.com> Changeset: f3a21057c491 Author: sadayapalam Date: 2019-04-20 21:29 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/f3a21057c491 8222784: [lworld] Partial revert. Restore -XDallowGenericsOverValues for now. ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties + test/langtools/tools/javac/valhalla/lworld-values/GenericsAndValues1.java + test/langtools/tools/javac/valhalla/lworld-values/GenericsAndValues2.java + test/langtools/tools/javac/valhalla/lworld-values/GenericsAndValues3.java From john.r.rose at oracle.com Sat Apr 20 18:48:09 2019 From: john.r.rose at oracle.com (John Rose) Date: Sat, 20 Apr 2019 11:48:09 -0700 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> Message-ID: <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> I've been wanting to do this for some time. I'll take a crack at it. > On Apr 20, 2019, at 8:19 AM, Srikanth wrote: > > JVM folk: > > I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM should be enhanced to work with static factory methods for inline types) in connection with this. > > I have pushed an initial implementation for JDK-8222711 that alters the way code is generated by javac for inline classes. Rather than emit synthetic $makeValue$ methods that embody the construction, now with the option -XDstaticInitValueFactory emits source level constructors into class file level static factories that > > - have the name > - are static methods > - have a return type that matches the class > - are invoked via invokestatic at the new V() construction site. > > All 4 are potential irritants to the JVM and need to be addressed before JDK-8222711 can be tested at all. > > I have eyeballed the code generated by this changeset and it passes muster, but real testing is possible only after the VM stops choking with: > > Error: LinkageError occurred while loading main class X > java.lang.ClassFormatError: Method "" in class X has illegal signature "(Ljava/lang/String;)QX;" > > Thanks for looking into this. > Srikanth > > > On 20/04/19 8:35 PM, srikanth.adayapalam at oracle.com wrote: >> Changeset: cc473d393abf >> Author: sadayapalam >> Date: 2019-04-20 20:35 +0530 >> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cc473d393abf >> >> 8222711: [lworld] Initial skeletal implementation of inline class instance construction via >> >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/TransValues.java >> ! src/jdk.jdeps/share/classes/com/sun/tools/javap/ClassWriter.java >> > From forax at univ-mlv.fr Sat Apr 20 21:29:31 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 20 Apr 2019 23:29:31 +0200 (CEST) Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> Message-ID: <80886689.404842.1555795771545.JavaMail.zimbra@u-pem.fr> There is maybe a way to generate those static factories and be binary backward compatible i.e. support the new L + dup + init L dance, the idea can be decomposed in two rewritings: - new L should be equivalent to calling Q.default if its an inline class - invokespecial L (params)V should be equivalent to calling top_of_stack = invokestatic (top_of_stack, params) if its an inline class obviously the later rewriting seems like a red herring but because of the side effect is on the top of the stack, it may be possible. R?mi ----- Mail original ----- > De: "John Rose" > ?: "Srikanth" > Cc: "valhalla-dev" > Envoy?: Samedi 20 Avril 2019 20:48:09 > Objet: Re: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance > construction via > I've been wanting to do this for some time. I'll take a crack at it. > >> On Apr 20, 2019, at 8:19 AM, Srikanth wrote: >> >> JVM folk: >> >> I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM >> should be enhanced to work with static factory methods for inline types) >> in connection with this. >> >> I have pushed an initial implementation for JDK-8222711 that alters the way code >> is generated by javac for inline classes. Rather than emit synthetic >> $makeValue$ methods that embody the construction, now with the option >> -XDstaticInitValueFactory emits source level constructors into class file level >> static factories that >> >> - have the name >> - are static methods >> - have a return type that matches the class >> - are invoked via invokestatic at the new V() construction site. >> >> All 4 are potential irritants to the JVM and need to be addressed before >> JDK-8222711 can be tested at all. >> >> I have eyeballed the code generated by this changeset and it passes muster, but >> real testing is possible only after the VM stops choking with: >> >> Error: LinkageError occurred while loading main class X >> java.lang.ClassFormatError: Method "" in class X has illegal signature >> "(Ljava/lang/String;)QX;" >> >> Thanks for looking into this. >> Srikanth >> >> >> On 20/04/19 8:35 PM, srikanth.adayapalam at oracle.com wrote: >>> Changeset: cc473d393abf >>> Author: sadayapalam >>> Date: 2019-04-20 20:35 +0530 >>> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/cc473d393abf >>> >>> 8222711: [lworld] Initial skeletal implementation of inline class instance >>> construction via >>> >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java >>> ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/TransValues.java >>> ! src/jdk.jdeps/share/classes/com/sun/tools/javap/ClassWriter.java >>> From john.r.rose at oracle.com Sun Apr 21 06:57:01 2019 From: john.r.rose at oracle.com (John Rose) Date: Sat, 20 Apr 2019 23:57:01 -0700 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> Message-ID: <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787/ This seems to work. It builds in fastdebug mode and passes the eight jtreg tests in test/jdk/valhalla/*. It also passes most of the tests in test/hotspot/jtreg/runtime/valhalla/*. I hacked your option logic, Srikanth, to force javac to use the new mode all the time. This made it easier to verify that things were working?and that change is yours to roll back. The method handle logic changes are untested and probably broken. (Anybody want to co-pilot these changes? :-) ? John P.S. To those celebrating, Happy Easter! On Apr 20, 2019, at 11:48 AM, John Rose wrote: > > I've been wanting to do this for some time. I'll take a crack at it. > >> On Apr 20, 2019, at 8:19 AM, Srikanth wrote: >> >> JVM folk: >> >> I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM should be enhanced to work with static factory methods for inline types) in connection with this. From srikanth.adayapalam at oracle.com Sun Apr 21 07:56:19 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sun, 21 Apr 2019 13:26:19 +0530 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> Message-ID: <79e5db60-b36b-e4c1-2f24-fd5125534012@oracle.com> Wonderful, thanks, I will wait for the JVM changes to make it to tip, polish up and push some additional javac changes after a bit more testing including all components valhalla suites. Of course, Remi will have some tests that fail as they invariably do ;-) but that can be tackled in due course. Happy Easter! Srikanth On 21/04/19 12:27 PM, John Rose wrote: > http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787/ > > This seems to work. It builds in fastdebug mode and passes > the eight jtreg tests in test/jdk/valhalla/*. It also passes > most of the tests in test/hotspot/jtreg/runtime/valhalla/*. > > I hacked your option logic, Srikanth, to force javac to use > the new mode all the time. This made it easier to verify > that things were working?and that change is yours to > roll back. > > The method handle logic changes are untested and > probably broken. > > (Anybody want to co-pilot these changes? :-) > > ? John > > P.S. To those celebrating, Happy Easter! > > On Apr 20, 2019, at 11:48 AM, John Rose wrote: >> I've been wanting to do this for some time. I'll take a crack at it. >> >>> On Apr 20, 2019, at 8:19 AM, Srikanth wrote: >>> >>> JVM folk: >>> >>> I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM should be enhanced to work with static factory methods for inline types) in connection with this. From srikanth.adayapalam at oracle.com Sun Apr 21 10:01:52 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Sun, 21 Apr 2019 10:01:52 +0000 Subject: hg: valhalla/valhalla: 8222790: [lworld] javac diagnostics don't discriminate between inline types and their nullable projection types. Message-ID: <201904211001.x3LA1rCa022152@aojmv0008.oracle.com> Changeset: d20b1256cca2 Author: sadayapalam Date: 2019-04-21 15:31 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/d20b1256cca2 8222790: [lworld] javac diagnostics don't discriminate between inline types and their nullable projection types. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Printer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/jdk.jshell/share/classes/jdk/jshell/TypePrinter.java + test/langtools/tools/javac/valhalla/lworld-values/CheckQuestionInMessages.java + test/langtools/tools/javac/valhalla/lworld-values/CheckQuestionInMessages.out From srikanth.adayapalam at oracle.com Sun Apr 21 17:34:27 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Sun, 21 Apr 2019 17:34:27 +0000 Subject: hg: valhalla/valhalla: 8222790: [lworld] Additional changes to enable javac internals to discriminate between LV; and QV; in various formatted outputs. Message-ID: <201904211734.x3LHYRkH015510@aojmv0008.oracle.com> Changeset: babd7b845c45 Author: sadayapalam Date: 2019-04-21 23:04 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/babd7b845c45 8222790: [lworld] Additional changes to enable javac internals to discriminate between LV; and QV; in various formatted outputs. ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java From srikanth.adayapalam at oracle.com Sun Apr 21 17:42:12 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Sun, 21 Apr 2019 23:12:12 +0530 Subject: javap and nullable projection types. Message-ID: <8ecfc7a6-cc84-aec6-a95a-969d1d1ea3e8@oracle.com> While working on JDK-8222790 (javac diagnostics don't discriminate between inline types and their nullable projection types.) I realized that it is somewhat hard for javap to properly annotate nullable projection types in its text output. A method in source of the form void foo(X x, X? xq) gets disassembled as void foo(X, X); ??? descriptor: (QX;LX;)V ??? flags: (0x0000) ??? Code: Note the parameter types both showing up as X. The descriptor is correct, but the header is misleading. In general this looks unsolvable without the now withdrawn ValueTypes attribute in the class file. This would be a problem for any tool that works only with a "local" view without building an elaborate symbol table of all the classes involved. Srikanth. From srikanth.adayapalam at oracle.com Mon Apr 22 05:40:07 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Mon, 22 Apr 2019 05:40:07 +0000 Subject: hg: valhalla/valhalla: 8222792: [lworld] Javac should enforce the latest relationship rules between an inline type and its nullable projection Message-ID: <201904220540.x3M5e8wQ003366@aojmv0008.oracle.com> Changeset: 8f61beecbe5e Author: sadayapalam Date: 2019-04-22 11:09 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8f61beecbe5e 8222792: [lworld] Javac should enforce the latest relationship rules between an inline type and its nullable projection ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConvention.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableValueTypes.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/CheckcastTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestFieldNullability.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue1.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue2.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue3.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue4.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java ! test/jdk/valhalla/valuetypes/NonFlattenValue.java ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java - test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java ! test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java From srikanth.adayapalam at oracle.com Mon Apr 22 10:43:54 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Mon, 22 Apr 2019 16:13:54 +0530 Subject: Please read: Re: hg: valhalla/valhalla: 8222792: [lworld] Javac should enforce the latest relationship rules between an inline type and its nullable projection In-Reply-To: <201904220540.x3M5e8wQ003366@aojmv0008.oracle.com> References: <201904220540.x3M5e8wQ003366@aojmv0008.oracle.com> Message-ID: <0048a256-3441-18e0-c674-1f5db5cf8038@oracle.com> With this change set: ??? - The compiler treats LX; as a super type of QX; In the class file the super type is still jlO ??? - Since X <: X?, expressions of type X can be assigned to variables of type X? freely, with no cast being required in the source code. Any explicit cast in the source will be discarded. In any event there will not be a checkcast in the class file for this widening operation. (absence of cast is a behavior change) ???? - Expressions of type X? cannot be assigned to variables of type X without an express source cast. X? is not assignable/convertible but is castable to X. VM can expect a checkcast in the binary. ??? - We may relax the express source cast requirement for the narrowing operation at a later time ??? - This change also impacts overload resolution. If we have: ???? m(Object o) { } ???? m(V? v) { } and a call ???? V v = ? ???? m(v) prior to this change, we?d prefer the m(Object) overload, since it is applicable without a boxing conversion, and m(V?) would not be. But under the new subtyping interpretation, we treat them both as applicable, and V? is _more specific_ than Object, so we pick m(V?) ???? - As of now javac allows overloads that differ only in nullability. For example a class can have two methods m(V? v) and m(V v): overload selection behaves as can be expected based on what the compiler is able to discern at the compile time about the static types of the arguments. [Brian, thanks for conforming this is what (or not) we want.) ??? - I have cleaned up various hotspot runtime/compliler tests to adjust the code for the new behavior. One exception is compiler/valhalla/valuetypes/TestNullableValueTypes.java - this test does not compile due to violating covariant return type rules and it is best for the author of the test to make suitable changes. ???? - This change should also automatically cover the requirements for https://bugs.openjdk.java.net/browse/JDK-8222402 (LW2 array support in javac) which requires javac to implement "[QFoo;" <: "[LFoo;? <: ?[LObject;? <: ?Object;" - I am in the process of verifying this. Thanks! Srikanth On 22/04/19 11:10 AM, srikanth.adayapalam at oracle.com wrote: > Changeset: 8f61beecbe5e > Author: sadayapalam > Date: 2019-04-22 11:09 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/8f61beecbe5e > > 8222792: [lworld] Javac should enforce the latest relationship rules between an inline type and its nullable projection > > ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java > ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java > ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConvention.java > ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java > ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableValueTypes.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/CheckcastTest.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestFieldNullability.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue1.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue2.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue3.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue4.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java > ! test/jdk/valhalla/valuetypes/NonFlattenValue.java > ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java > - test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java > ! test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java > From srikanth.adayapalam at oracle.com Mon Apr 22 11:57:12 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Mon, 22 Apr 2019 11:57:12 +0000 Subject: hg: valhalla/valhalla: 8222792: [lworld] Additional tests for enforcing latest type relationship rules between an inline type and its nullable projection Message-ID: <201904221157.x3MBvDgx003500@aojmv0008.oracle.com> Changeset: 4c64df60a706 Author: sadayapalam Date: 2019-04-22 17:26 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/4c64df60a706 8222792: [lworld] Additional tests for enforcing latest type relationship rules between an inline type and its nullable projection + test/langtools/tools/javac/valhalla/lworld-values/TypeRelationsNegativeTest.java + test/langtools/tools/javac/valhalla/lworld-values/TypeRelationsNegativeTest.out + test/langtools/tools/javac/valhalla/lworld-values/TypeRelationsTest.java From srikanth.adayapalam at oracle.com Mon Apr 22 12:50:42 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Mon, 22 Apr 2019 12:50:42 +0000 Subject: hg: valhalla/valhalla: 8222402: [lworld] LW2 array support in javac Message-ID: <201904221250.x3MCohwk004208@aojmv0008.oracle.com> Changeset: 2da7a1ed0104 Author: sadayapalam Date: 2019-04-22 18:20 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2da7a1ed0104 8222402: [lworld] LW2 array support in javac + test/langtools/tools/javac/valhalla/lworld-values/ArrayRelationsTest.java From srikanth.adayapalam at oracle.com Mon Apr 22 12:57:21 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Mon, 22 Apr 2019 18:27:21 +0530 Subject: hg: valhalla/valhalla: 8222402: [lworld] LW2 array support in javac In-Reply-To: <201904221250.x3MCohwk004208@aojmv0008.oracle.com> References: <201904221250.x3MCohwk004208@aojmv0008.oracle.com> Message-ID: With javac cleaning up the notions of type relations between an inline type and its null projection, what is required for array support from javac automatically falls into place. I have pushed this changeset with tests to assert that ??? - "[QFoo;" <: "[LFoo;? <: ?[LObject;? <: ?Object;" ??? - That we can freely allow widening conversion, but not narrowing. I.e. narrow checkcast must match [Q... In general thing work as expected, I did find one problem ??? Foo?[] fa = new Foo?[10]; ??? Foo [] qa = (Foo []) fa;? // <------- No CCE here yet. Thanks! Srikanth On 22/04/19 6:20 PM, srikanth.adayapalam at oracle.com wrote: > Changeset: 2da7a1ed0104 > Author: sadayapalam > Date: 2019-04-22 18:20 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2da7a1ed0104 > > 8222402: [lworld] LW2 array support in javac > > + test/langtools/tools/javac/valhalla/lworld-values/ArrayRelationsTest.java > From srikanth.adayapalam at oracle.com Mon Apr 22 13:01:16 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Mon, 22 Apr 2019 18:31:16 +0530 Subject: hg: valhalla/valhalla: 8222402: [lworld] LW2 array support in javac In-Reply-To: References: <201904221250.x3MCohwk004208@aojmv0008.oracle.com> Message-ID: <06b79438-e14b-3184-6dd0-86d3352db9cd@oracle.com> I meant to add all the code snippets in https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-April/005600.html are covered by the new tests. That page says: ??? qa = (Foo[]) la; // should fail to compile if type known The only case as far as I can see, where the type is "known" to javac to warrant a failure is: ??? qa = new Foo[] { ... null, ... }; At at other places, javac will go with the declared/static type which would permit the cast and defer any problem reporting to a CCE at runtime (which is missing ATM BTW) Srikanth. On 22/04/19 6:27 PM, Srikanth wrote: > With javac cleaning up the notions of type relations between an inline > type and its null projection, > what is required for array support from javac automatically falls into > place. > > I have pushed this changeset with tests to assert that > > ??? - "[QFoo;" <: "[LFoo;? <: ?[LObject;? <: ?Object;" > ??? - That we can freely allow widening conversion, but not narrowing. > I.e. narrow checkcast must match [Q... > > In general thing work as expected, I did find one problem > > ??? Foo?[] fa = new Foo?[10]; > ??? Foo [] qa = (Foo []) fa;? // <------- No CCE here yet. > > Thanks! > Srikanth > > On 22/04/19 6:20 PM, srikanth.adayapalam at oracle.com wrote: >> Changeset: 2da7a1ed0104 >> Author:??? sadayapalam >> Date:????? 2019-04-22 18:20 +0530 >> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2da7a1ed0104 >> >> 8222402: [lworld] LW2 array support in javac >> >> + >> test/langtools/tools/javac/valhalla/lworld-values/ArrayRelationsTest.java >> > From karen.kinnear at oracle.com Mon Apr 22 14:10:21 2019 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Mon, 22 Apr 2019 10:10:21 -0400 Subject: hg: valhalla/valhalla: 8222783: [lworld] Withdraw support for .box and .val syntax In-Reply-To: <284d182a-a367-fa52-f4f0-17fdd830ea5e@oracle.com> References: <201904200333.x3K3XCc0008527@aojmv0008.oracle.com> <284d182a-a367-fa52-f4f0-17fdd830ea5e@oracle.com> Message-ID: Many thanks for catching those and cleaning them up Srikanth, Karen > On Apr 19, 2019, at 11:35 PM, Srikanth wrote: > > I found a few lingering uses in the benchmark files and have cleaned them. > > .box and .val are dead as a dodo. RIP. > > Srikanth > > On 20/04/19 9:03 AM, srikanth.adayapalam at oracle.com wrote: >> Changeset: 9c1cd9deab83 >> Author: sadayapalam >> Date: 2019-04-20 09:03 +0530 >> URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/9c1cd9deab83 >> >> 8222783: [lworld] Withdraw support for .box and .val syntax >> >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java >> ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java >> ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum1.java >> ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum2.java >> ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/listsum/Listsum8.java >> ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/util/HashMapValueEntry.java >> ! test/benchmarks/src/main/java/oracle/micro/valhalla/lworld/util/HashMapValueTotal.java >> ! test/langtools/tools/javac/valhalla/lworld-values/ArrayCreationWithQuestion.java >> ! test/langtools/tools/javac/valhalla/lworld-values/BogusIncompatibility.java >> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java >> ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest2.java >> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFieldDescriptors.java >> ! test/langtools/tools/javac/valhalla/lworld-values/CheckFlattenableCycles.java >> ! test/langtools/tools/javac/valhalla/lworld-values/InnerClassAttributeValuenessTest.java >> ! test/langtools/tools/javac/valhalla/lworld-values/IntercastTest.java >> ! test/langtools/tools/javac/valhalla/lworld-values/LookupOnLoxTest.java >> ! test/langtools/tools/javac/valhalla/lworld-values/Point.java >> > From harold.seigel at oracle.com Mon Apr 22 18:35:33 2019 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Mon, 22 Apr 2019 18:35:33 +0000 Subject: hg: valhalla/valhalla: Summary: Change tests to use 'inline' instead of 'value' for the types previously known as value types. Message-ID: <201904221835.x3MIZYCl002074@aojmv0008.oracle.com> Changeset: 57a1417ebfaf Author: hseigel Date: 2019-04-22 14:35 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/57a1417ebfaf Summary: Change tests to use 'inline' instead of 'value' for the types previously known as value types. Reviewed-by lfoltan ! src/hotspot/share/classfile/verificationType.cpp ! src/hotspot/share/classfile/verifier.cpp ! test/hotspot/jtreg/runtime/valhalla/valuetypes/CheckcastTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/Empty.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/FlattenableSemanticTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/IntValue.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/JumboValue.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/Long8Value.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ObjectMethods.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/Person.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/Point.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/QuickeningTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/Test8186715.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestFieldNullability.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestInheritedValueTypeFields.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue1.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue2.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue3.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/TestValue4.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/UninitializedValueFieldsTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/UnsafeTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/VDefaultTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/VWithFieldTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueOops.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeCreation.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeDensity.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypesTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueWithJni.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/WithFieldAccessorTest.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/WithFieldNoAccessTest.jcod ! test/hotspot/jtreg/runtime/valhalla/valuetypes/classfileparser/BadValueTypes.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/classfileparser/cfpTests.jcod ! test/hotspot/jtreg/runtime/valhalla/valuetypes/verifier/NoArrayCov.jcod ! test/hotspot/jtreg/runtime/valhalla/valuetypes/verifier/NoArrayCovIntf.jcod ! test/hotspot/jtreg/runtime/valhalla/valuetypes/verifier/NoNullVT.jcod ! test/hotspot/jtreg/runtime/valhalla/valuetypes/verifier/VTAssignability.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/verifier/VerifierValueTypes.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/verifier/verifierTests.jcod From ioi.lam at oracle.com Tue Apr 23 01:02:25 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Mon, 22 Apr 2019 18:02:25 -0700 Subject: RFR 8222717 [lworld] Calling convention - repair C1 stack Message-ID: ?Hi Tobias, Here's an example of the code that I am generating for JDK-8222717 [lworld] Calling convention - repair C1 stack [1] The C2 stack repair code relies on the reserved slots in the VEP calling convention (see [2], page 14) to preserve the caller's return address. However, I haven't quite figured out how to do the same thing for the VVEP calling convention (as doing so will also recursively affect the VEP convetion). So for now, I decide to have a simplier approach for C1, by directly manipulating the return address on the stack. See line 165 in the following dump. Actually, I am not quite sure how the C2 code uses the RA pushed by line 31, but it turns out to be very handy for C1 :-) Here's the webrev: http://cr.openjdk.java.net/~iklam/valhalla/8222717-c1-stack-repair.v01/ With C1, the frequency of stack extension is much lower (only when you have scalarized floating-point fields), so even though the code is not as efficient as the C2 stack repair code, maybe it's still OK? What do you think? Thanks - Ioi public class Foo { ??? static value class V { ????? int a = 0, b = 0; ??? } ??? // C1 extends stack (1 extra stack word) ??? static int test(U u1, int a1, int a2, int a3, int a4, int a5, int a6) { ??????? return a1 + a2 + a6; ??? } ??? public static void main(String args[]) { ??????? V v = new V(); ??????? System.out.println("Hello: " + test(u, 1, 2, 3, 4, 5, 6)); ??? } } ---------------------------------------------------------------------- Foo.test(QFoo$U;IIIIII)I? [0x00007fc7a0e361e0, 0x00007fc7a0e36398]? 440 bytes [Disassembling for mach='i386:x86-64'] ? # {method} {0x00007fc78b2f7808} 'test' '(QFoo$U;IIIIII)I' in 'Foo' [Entry Point] [Verified Entry Point] [Verified Value Entry Point (RO)] ? # parm0:??? xmm0????? = float ? # parm1:??? xmm1????? = float ? # parm2:??? xmm2????? = float ? # parm3:??? rsi?????? = int ? # parm4:??? rdx?????? = int ? # parm5:??? rcx?????? = int ? # parm6:??? r8??????? = int ? # parm7:??? r9??????? = int ? # parm8:??? rdi?????? = int ? #?????????? [sp+0x40]? (sp of caller) ?;;? block B1 [0, 0] ???? 0: push?? %rbp ???? 1: sub??? $0x30,%rsp ???? 5: mov??? $0x7fc78b2f7808,%rbx ??? 15: callq? 0x00007fc7a09d8ac0? ;?? {runtime_call buffer_value_args Runtime1 stub} ??? 20: pop??? %rbp // extend stack ??? 21: add??? $0x30,%rsp ??? 25: pop??? %r13 ??? 27: sub??? $0x10,%rsp ??? 31: push?? %r13??????????????? ; << RA saved by stack extension code ??? 33: mov??? %rdi,0x8(%rsp) ??? 38: mov??? %r9,%rdi ??? 41: mov??? %r8,%r9 ??? 44: mov??? %rcx,%r8 ??? 47: mov??? %rdx,%rcx ??? 50: mov??? %rsi,%rdx ??? 53: mov??? 0x10(%rax),%esi ??? 56: vmovss %xmm0,0x10(%rsi) ??? 61: vmovss %xmm1,0x14(%rsi) ??? 66: vmovss %xmm2,0x18(%rsi) ??? 71: mov??? %eax,-0x16000(%rsp) ??? 78: push?? %rbp??????????????? ; << now RA is just one word below saved rbp ??? 79: sub??? $0x30,%rsp ??? 83: movq?? $0x50,0x8(%rsp) ??? 92: jmpq??? L_1 (149) v [Verified Value Entry Point] ? # parm0:??? rsi:rsi?? = 'java/lang/Object' ? # parm1:??? rdx?????? = int ? # parm2:??? rcx?????? = int ? # parm3:??? r8??????? = int ? # parm4:??? r9??????? = int ? # parm5:??? rdi?????? = int ? # parm6:??? [sp+0x40]?? = int? (sp of caller) ?? 128: mov??? %eax,-0x16000(%rsp) ?? 135: push?? %rbp??????????????? ; << RA is? one word below saved rbp ?? 136: sub??? $0x30,%rsp ?? 140: movq?? $0x40,0x8(%rsp) L_1 ?? 149: mov??? 0x40(%rsp),%eax ?;;? block B0 [0, 6] ?? 153: add??? %ecx,%edx ?? 155: add??? %eax,%edx ?? 157: mov??? %rdx,%rax ?? // stack repair ?? 160: mov??? 0x38(%rsp),%r13???? ; get saved RA ?? 165: mov??? 0x30(%rsp),%rbp???? ; restore saved rbp ?? 170: add??? 0x8(%rsp),%rsp ?? 175: push?? %r13??????????????? ; push RA, so stack would look the ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?? ; same as @ line 135 ?? // stack repair - end ?? 177: mov??? 0x128(%r15),%r10 ?? 184: test?? %eax,(%r10)???????? ;?? {poll_return} ?? 187: retq?????????????????????? ; return to caller ---------------------------------------------------------------------- [1] https://bugs.openjdk.java.net/browse/JDK-8222717 [2] http://cr.openjdk.java.net/~thartmann/talks/2019-ValueType_Optimizations.pdf From tobias.hartmann at oracle.com Tue Apr 23 08:20:49 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Tue, 23 Apr 2019 08:20:49 +0000 Subject: hg: valhalla/valhalla: 8222840: [lworld] TestNullableValueTypes fails to compile after 8222792 Message-ID: <201904230820.x3N8KoWg029173@aojmv0008.oracle.com> Changeset: de02e2c0d8de Author: thartmann Date: 2019-04-23 10:20 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/de02e2c0d8de 8222840: [lworld] TestNullableValueTypes fails to compile after 8222792 ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableValueTypes.java From tobias.hartmann at oracle.com Tue Apr 23 08:21:50 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 23 Apr 2019 10:21:50 +0200 Subject: Please read: Re: hg: valhalla/valhalla: 8222792: [lworld] Javac should enforce the latest relationship rules between an inline type and its nullable projection In-Reply-To: <0048a256-3441-18e0-c674-1f5db5cf8038@oracle.com> References: <201904220540.x3M5e8wQ003366@aojmv0008.oracle.com> <0048a256-3441-18e0-c674-1f5db5cf8038@oracle.com> Message-ID: Hi Srikanth, On 22.04.19 12:43, Srikanth wrote: > One exception is compiler/valhalla/valuetypes/TestNullableValueTypes.java - this test does not > compile due to violating covariant return type rules and it is best for the author of the test to > make suitable changes. Fixed: http://hg.openjdk.java.net/valhalla/valhalla/rev/de02e2c0d8de Thanks, Tobias From tobias.hartmann at oracle.com Tue Apr 23 09:57:17 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Tue, 23 Apr 2019 09:57:17 +0000 Subject: hg: valhalla/valhalla: 8222849: [lworld] Use 'inline class' instead of 'value class' in compiler tests Message-ID: <201904230957.x3N9vIdM028353@aojmv0008.oracle.com> Changeset: 47c82eb2e4b2 Author: thartmann Date: 2019-04-23 11:57 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/47c82eb2e4b2 8222849: [lworld] Use 'inline class' instead of 'value class' in compiler tests ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue1.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue2.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue3.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/MyValue4.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/SimpleValueType.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestBimorphicInlining.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestC2CCalls.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConvention.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestIntrinsics.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestJNICalls.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorld.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNativeClone.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNewAcmp.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableValueTypes.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestOptimizeKlassCmp.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestUnloadedValueTypeArray.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestUnloadedValueTypeField.java From srikanth.adayapalam at oracle.com Tue Apr 23 11:22:08 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Tue, 23 Apr 2019 11:22:08 +0000 Subject: hg: valhalla/valhalla: [lworld]: Fix failure that shows up in Mach5 testing probably due to locale settings. Message-ID: <201904231122.x3NBM9Pv019407@aojmv0008.oracle.com> Changeset: 2a445ccee5a7 Author: sadayapalam Date: 2019-04-23 16:51 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/2a445ccee5a7 [lworld]: Fix failure that shows up in Mach5 testing probably due to locale settings. ! test/langtools/tools/javac/valhalla/lworld-values/ArrayRelationsTest.java From harold.seigel at oracle.com Tue Apr 23 15:17:16 2019 From: harold.seigel at oracle.com (Harold Seigel) Date: Tue, 23 Apr 2019 11:17:16 -0400 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> Message-ID: Hi John, >> Anybody want to co-pilot these changes? I'll take a stab at it but will certainly ask core libs and others for help. Harold On 4/21/2019 2:57 AM, John Rose wrote: > http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787/ > > This seems to work. It builds in fastdebug mode and passes > the eight jtreg tests in test/jdk/valhalla/*. It also passes > most of the tests in test/hotspot/jtreg/runtime/valhalla/*. > > I hacked your option logic, Srikanth, to force javac to use > the new mode all the time. This made it easier to verify > that things were working?and that change is yours to > roll back. > > The method handle logic changes are untested and > probably broken. > > (Anybody want to co-pilot these changes? :-) > > ? John > > P.S. To those celebrating, Happy Easter! > > On Apr 20, 2019, at 11:48 AM, John Rose wrote: >> I've been wanting to do this for some time. I'll take a crack at it. >> >>> On Apr 20, 2019, at 8:19 AM, Srikanth wrote: >>> >>> JVM folk: >>> >>> I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM should be enhanced to work with static factory methods for inline types) in connection with this. From ioi.lam at oracle.com Wed Apr 24 02:39:21 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Tue, 23 Apr 2019 19:39:21 -0700 Subject: RFR 8222717 [lworld] Calling convention - repair C1 stack In-Reply-To: References: Message-ID: <75d5759a-77cb-4e75-4bf3-ee7ed82f81a0@oracle.com> I found a bug in the code that saves the real stack size. It was saving to 0x08(rsp). It should save to [frame size - 8](rsp) instead. Here's the delta from the previous webrev, plus a bunch of test cases that checks for stack walking with an extended C1 stack frame. http://cr.openjdk.java.net/~iklam/valhalla/8222717-c1-stack-repair.v02-delta/ Stack unwinding doesn't work yet. I'll fix that in a separate patch. See https://bugs.openjdk.java.net/browse/JDK-8222908 Thanks - Ioi On 4/22/19 6:02 PM, Ioi Lam wrote: > ?Hi Tobias, > > Here's an example of the code that I am generating for JDK-8222717 > [lworld] Calling > convention - repair C1 stack [1] > > The C2 stack repair code relies on the reserved slots in the VEP > calling convention > (see [2], page 14) to preserve the caller's return address. > > However, I haven't quite figured out how to do the same thing for > the VVEP calling convention (as doing so will also recursively affect > the VEP convetion). > So for now, I decide to have a simplier approach for C1, by directly > manipulating the > return address on the stack. See line 165 in the following dump. > > Actually, I am not quite sure how the C2 code uses the RA pushed by > line 31, but it > turns out to be very handy for C1 :-) > > Here's the webrev: > > http://cr.openjdk.java.net/~iklam/valhalla/8222717-c1-stack-repair.v01/ > > With C1, the frequency of stack extension is much lower (only when you > have scalarized > floating-point fields), so even though the code is not as efficient as > the C2 stack > repair code, maybe it's still OK? > > What do you think? > > Thanks > - Ioi > > > > > > public class Foo { > ??? static value class V { > ????? int a = 0, b = 0; > ??? } > ??? // C1 extends stack (1 extra stack word) > ??? static int test(U u1, int a1, int a2, int a3, int a4, int a5, int > a6) { > ??????? return a1 + a2 + a6; > ??? } > ??? public static void main(String args[]) { > ??????? V v = new V(); > ??????? System.out.println("Hello: " + test(u, 1, 2, 3, 4, 5, 6)); > ??? } > } > > ---------------------------------------------------------------------- > > Foo.test(QFoo$U;IIIIII)I? [0x00007fc7a0e361e0, 0x00007fc7a0e36398]? > 440 bytes > [Disassembling for mach='i386:x86-64'] > ? # {method} {0x00007fc78b2f7808} 'test' '(QFoo$U;IIIIII)I' in 'Foo' > [Entry Point] > [Verified Entry Point] > [Verified Value Entry Point (RO)] > ? # parm0:??? xmm0????? = float > ? # parm1:??? xmm1????? = float > ? # parm2:??? xmm2????? = float > ? # parm3:??? rsi?????? = int > ? # parm4:??? rdx?????? = int > ? # parm5:??? rcx?????? = int > ? # parm6:??? r8??????? = int > ? # parm7:??? r9??????? = int > ? # parm8:??? rdi?????? = int > ? #?????????? [sp+0x40]? (sp of caller) > ?;;? block B1 [0, 0] > > ???? 0: push?? %rbp > ???? 1: sub??? $0x30,%rsp > ???? 5: mov??? $0x7fc78b2f7808,%rbx > ??? 15: callq? 0x00007fc7a09d8ac0? ;?? {runtime_call buffer_value_args > Runtime1 stub} > ??? 20: pop??? %rbp > > // extend stack > ??? 21: add??? $0x30,%rsp > ??? 25: pop??? %r13 > ??? 27: sub??? $0x10,%rsp > ??? 31: push?? %r13??????????????? ; << RA saved by stack extension code > > ??? 33: mov??? %rdi,0x8(%rsp) > ??? 38: mov??? %r9,%rdi > ??? 41: mov??? %r8,%r9 > ??? 44: mov??? %rcx,%r8 > ??? 47: mov??? %rdx,%rcx > ??? 50: mov??? %rsi,%rdx > ??? 53: mov??? 0x10(%rax),%esi > ??? 56: vmovss %xmm0,0x10(%rsi) > ??? 61: vmovss %xmm1,0x14(%rsi) > ??? 66: vmovss %xmm2,0x18(%rsi) > > ??? 71: mov??? %eax,-0x16000(%rsp) > > ??? 78: push?? %rbp??????????????? ; << now RA is just one word below > saved rbp > ??? 79: sub??? $0x30,%rsp > ??? 83: movq?? $0x50,0x8(%rsp) > ??? 92: jmpq??? L_1 (149) v > > [Verified Value Entry Point] > ? # parm0:??? rsi:rsi?? = 'java/lang/Object' > ? # parm1:??? rdx?????? = int > ? # parm2:??? rcx?????? = int > ? # parm3:??? r8??????? = int > ? # parm4:??? r9??????? = int > ? # parm5:??? rdi?????? = int > ? # parm6:??? [sp+0x40]?? = int? (sp of caller) > ?? 128: mov??? %eax,-0x16000(%rsp) > ?? 135: push?? %rbp??????????????? ; << RA is? one word below saved rbp > ?? 136: sub??? $0x30,%rsp > ?? 140: movq?? $0x40,0x8(%rsp) > > L_1 > ?? 149: mov??? 0x40(%rsp),%eax > ?;;? block B0 [0, 6] > > ?? 153: add??? %ecx,%edx > ?? 155: add??? %eax,%edx > ?? 157: mov??? %rdx,%rax > > ?? // stack repair > ?? 160: mov??? 0x38(%rsp),%r13???? ; get saved RA > ?? 165: mov??? 0x30(%rsp),%rbp???? ; restore saved rbp > ?? 170: add??? 0x8(%rsp),%rsp > ?? 175: push?? %r13??????????????? ; push RA, so stack would look the > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?? ; same as @ line 135 > ?? // stack repair - end > > ?? 177: mov??? 0x128(%r15),%r10 > ?? 184: test?? %eax,(%r10)???????? ;?? {poll_return} > ?? 187: retq?????????????????????? ; return to caller > > > ---------------------------------------------------------------------- > [1] https://bugs.openjdk.java.net/browse/JDK-8222717 > [2] > http://cr.openjdk.java.net/~thartmann/talks/2019-ValueType_Optimizations.pdf > From tobias.hartmann at oracle.com Wed Apr 24 13:21:06 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Wed, 24 Apr 2019 15:21:06 +0200 Subject: RFR 8222717 [lworld] Calling convention - repair C1 stack In-Reply-To: References: Message-ID: <47fa16b8-6ad6-8565-2c6f-2fb9dbd1b855@oracle.com> Hi Ioi, On 23.04.19 03:02, Ioi Lam wrote: > Here's an example of the code that I am generating for JDK-8222717 [lworld] Calling > convention - repair C1 stack [1] > > The C2 stack repair code relies on the reserved slots in the VEP calling convention > (see [2], page 14) to preserve the caller's return address. > > However, I haven't quite figured out how to do the same thing for > the VVEP calling convention (as doing so will also recursively affect the VEP convetion). > So for now, I decide to have a simplier approach for C1, by directly manipulating the > return address on the stack. See line 165 in the following dump. Yes, that's reasonable. > Actually, I am not quite sure how the C2 code uses the RA pushed by line 31, but it > turns out to be very handy for C1 :-) It currently does not use it but just pushes it there for consistency (in case someone looks at the frame). I'm planning to revisit/benchmark the implementation once everything is done and maybe get rid of the reserved entry complexity by restoring the RA address in a similar way you are doing it for C1 (requires two additional mov instructions at the end). > Here's the webrev: > > http://cr.openjdk.java.net/~iklam/valhalla/8222717-c1-stack-repair.v01/ > > With C1, the frequency of stack extension is much lower (only when you have scalarized > floating-point fields), so even though the code is not as efficient as the C2 stack > repair code, maybe it's still OK? > > What do you think? Yes, that looks good to me. Thanks, Tobias > > public class Foo { > ??? static value class V { > ????? int a = 0, b = 0; > ??? } > ??? // C1 extends stack (1 extra stack word) > ??? static int test(U u1, int a1, int a2, int a3, int a4, int a5, int a6) { > ??????? return a1 + a2 + a6; > ??? } > ??? public static void main(String args[]) { > ??????? V v = new V(); > ??????? System.out.println("Hello: " + test(u, 1, 2, 3, 4, 5, 6)); > ??? } > } > > ---------------------------------------------------------------------- > > Foo.test(QFoo$U;IIIIII)I? [0x00007fc7a0e361e0, 0x00007fc7a0e36398]? 440 bytes > [Disassembling for mach='i386:x86-64'] > ? # {method} {0x00007fc78b2f7808} 'test' '(QFoo$U;IIIIII)I' in 'Foo' > [Entry Point] > [Verified Entry Point] > [Verified Value Entry Point (RO)] > ? # parm0:??? xmm0????? = float > ? # parm1:??? xmm1????? = float > ? # parm2:??? xmm2????? = float > ? # parm3:??? rsi?????? = int > ? # parm4:??? rdx?????? = int > ? # parm5:??? rcx?????? = int > ? # parm6:??? r8??????? = int > ? # parm7:??? r9??????? = int > ? # parm8:??? rdi?????? = int > ? #?????????? [sp+0x40]? (sp of caller) > ?;;? block B1 [0, 0] > > ???? 0: push?? %rbp > ???? 1: sub??? $0x30,%rsp > ???? 5: mov??? $0x7fc78b2f7808,%rbx > ??? 15: callq? 0x00007fc7a09d8ac0? ;?? {runtime_call buffer_value_args Runtime1 stub} > ??? 20: pop??? %rbp > > // extend stack > ??? 21: add??? $0x30,%rsp > ??? 25: pop??? %r13 > ??? 27: sub??? $0x10,%rsp > ??? 31: push?? %r13??????????????? ; << RA saved by stack extension code > > ??? 33: mov??? %rdi,0x8(%rsp) > ??? 38: mov??? %r9,%rdi > ??? 41: mov??? %r8,%r9 > ??? 44: mov??? %rcx,%r8 > ??? 47: mov??? %rdx,%rcx > ??? 50: mov??? %rsi,%rdx > ??? 53: mov??? 0x10(%rax),%esi > ??? 56: vmovss %xmm0,0x10(%rsi) > ??? 61: vmovss %xmm1,0x14(%rsi) > ??? 66: vmovss %xmm2,0x18(%rsi) > > ??? 71: mov??? %eax,-0x16000(%rsp) > > ??? 78: push?? %rbp??????????????? ; << now RA is just one word below saved rbp > ??? 79: sub??? $0x30,%rsp > ??? 83: movq?? $0x50,0x8(%rsp) > ??? 92: jmpq??? L_1 (149) v > > [Verified Value Entry Point] > ? # parm0:??? rsi:rsi?? = 'java/lang/Object' > ? # parm1:??? rdx?????? = int > ? # parm2:??? rcx?????? = int > ? # parm3:??? r8??????? = int > ? # parm4:??? r9??????? = int > ? # parm5:??? rdi?????? = int > ? # parm6:??? [sp+0x40]?? = int? (sp of caller) > ?? 128: mov??? %eax,-0x16000(%rsp) > ?? 135: push?? %rbp??????????????? ; << RA is? one word below saved rbp > ?? 136: sub??? $0x30,%rsp > ?? 140: movq?? $0x40,0x8(%rsp) > > L_1 > ?? 149: mov??? 0x40(%rsp),%eax > ?;;? block B0 [0, 6] > > ?? 153: add??? %ecx,%edx > ?? 155: add??? %eax,%edx > ?? 157: mov??? %rdx,%rax > > ?? // stack repair > ?? 160: mov??? 0x38(%rsp),%r13???? ; get saved RA > ?? 165: mov??? 0x30(%rsp),%rbp???? ; restore saved rbp > ?? 170: add??? 0x8(%rsp),%rsp > ?? 175: push?? %r13??????????????? ; push RA, so stack would look the > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?? ; same as @ line 135 > ?? // stack repair - end > > ?? 177: mov??? 0x128(%r15),%r10 > ?? 184: test?? %eax,(%r10)???????? ;?? {poll_return} > ?? 187: retq?????????????????????? ; return to caller > > > ---------------------------------------------------------------------- > [1] https://bugs.openjdk.java.net/browse/JDK-8222717 > [2] http://cr.openjdk.java.net/~thartmann/talks/2019-ValueType_Optimizations.pdf > From john.r.rose at oracle.com Wed Apr 24 18:00:52 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 24 Apr 2019 11:00:52 -0700 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> Message-ID: <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> Thanks, Harold! I'm doing a small update to the patch which removed "is_object_method_signature". I think it's simpler and easier to replace all the uses of s->is_object_method_signature() with !s->is_void_method_signature(). It makes a small difference in the spec., which is (I think) a good difference. I'm working on an EG mail about the spec. as a whole. The webrev is updated in place: http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787 ? John On Apr 23, 2019, at 8:17 AM, Harold Seigel wrote: > > Hi John, > > >> Anybody want to co-pilot these changes? > > I'll take a stab at it but will certainly ask core libs and others for help. > > Harold > > On 4/21/2019 2:57 AM, John Rose wrote: >> http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787/ >> >> This seems to work. It builds in fastdebug mode and passes >> the eight jtreg tests in test/jdk/valhalla/*. It also passes >> most of the tests in test/hotspot/jtreg/runtime/valhalla/*. >> >> I hacked your option logic, Srikanth, to force javac to use >> the new mode all the time. This made it easier to verify >> that things were working?and that change is yours to >> roll back. >> >> The method handle logic changes are untested and >> probably broken. >> >> (Anybody want to co-pilot these changes? :-) >> >> ? John >> >> P.S. To those celebrating, Happy Easter! >> >> On Apr 20, 2019, at 11:48 AM, John Rose wrote: >>> I've been wanting to do this for some time. I'll take a crack at it. >>> >>>> On Apr 20, 2019, at 8:19 AM, Srikanth wrote: >>>> >>>> JVM folk: >>>> >>>> I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM should be enhanced to work with static factory methods for inline types) in connection with this. From harold.seigel at oracle.com Wed Apr 24 18:04:02 2019 From: harold.seigel at oracle.com (Harold Seigel) Date: Wed, 24 Apr 2019 14:04:02 -0400 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> Message-ID: Thanks John. I'll incorporate the changes. Harold On 4/24/2019 2:00 PM, John Rose wrote: > Thanks, Harold! I'm doing a small update to the patch which > removed "is_object_method_signature". I think it's simpler and > easier to replace all the uses of s->is_object_method_signature() > with !s->is_void_method_signature(). It makes a small difference > in the spec., which is (I think) a good difference. I'm working on > an EG mail about the spec. as a whole. > > The webrev is updated in place: > http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787 > > ? John > > On Apr 23, 2019, at 8:17 AM, Harold Seigel wrote: >> Hi John, >> >>>> Anybody want to co-pilot these changes? >> I'll take a stab at it but will certainly ask core libs and others for help. >> >> Harold >> >> On 4/21/2019 2:57 AM, John Rose wrote: >>> http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787/ >>> >>> This seems to work. It builds in fastdebug mode and passes >>> the eight jtreg tests in test/jdk/valhalla/*. It also passes >>> most of the tests in test/hotspot/jtreg/runtime/valhalla/*. >>> >>> I hacked your option logic, Srikanth, to force javac to use >>> the new mode all the time. This made it easier to verify >>> that things were working?and that change is yours to >>> roll back. >>> >>> The method handle logic changes are untested and >>> probably broken. >>> >>> (Anybody want to co-pilot these changes? :-) >>> >>> ? John >>> >>> P.S. To those celebrating, Happy Easter! >>> >>> On Apr 20, 2019, at 11:48 AM, John Rose wrote: >>>> I've been wanting to do this for some time. I'll take a crack at it. >>>> >>>>> On Apr 20, 2019, at 8:19 AM, Srikanth wrote: >>>>> >>>>> JVM folk: >>>>> >>>>> I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM should be enhanced to work with static factory methods for inline types) in connection with this. From frederic.parain at oracle.com Wed Apr 24 18:54:47 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Wed, 24 Apr 2019 14:54:47 -0400 Subject: RFR(L): JDK-8222525 : [lworld] Runtime support for LW2 Arrays In-Reply-To: References: Message-ID: <5E13BDA9-4B31-40F8-9DF8-9DB4D24196B4@oracle.com> Looks good. Two minor points: ciReplay.cpp:916: Could the resolution fail? If yes, what would be the consequences? oopFactory.hpp:76 typo: of -> if Thanks for doing this huge re-work of value arrays. Fred > On Apr 16, 2019, at 04:46, David Simms wrote: > > > Please review runtime support for LW2 array covariance[1]: > > http://cr.openjdk.java.net/~dsimms/valhalla/lw2_arrays/webrev5/ > > Further testing is needed, but requires javac (for ease of writing) > > /David Simms > > [1] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-April/005600.html > From harold.seigel at oracle.com Wed Apr 24 20:01:43 2019 From: harold.seigel at oracle.com (Harold Seigel) Date: Wed, 24 Apr 2019 16:01:43 -0400 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> Message-ID: Hi John, Just an fyi: Karen and I noticed a few small issues. Line 969 in ciMethod.cpp needs a '!': 967 bool ciMethod::is_static_init_factory() const { 968 return (name() == ciSymbol::object_initializer_name() 969 && signature()->return_type()->is_void()); 970 } Also, the assert() messages at lines 310 and 319 in javaCalls.cpp and lines 1269 and 1275 in reflection.cpp seemed incorrect. Thanks, Harold On 4/24/2019 2:00 PM, John Rose wrote: > Thanks, Harold! I'm doing a small update to the patch which > removed "is_object_method_signature". I think it's simpler and > easier to replace all the uses of s->is_object_method_signature() > with !s->is_void_method_signature(). It makes a small difference > in the spec., which is (I think) a good difference. I'm working on > an EG mail about the spec. as a whole. > > The webrev is updated in place: > http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787 > > ? John > > On Apr 23, 2019, at 8:17 AM, Harold Seigel wrote: >> Hi John, >> >>>> Anybody want to co-pilot these changes? >> I'll take a stab at it but will certainly ask core libs and others for help. >> >> Harold >> >> On 4/21/2019 2:57 AM, John Rose wrote: >>> http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787/ >>> >>> This seems to work. It builds in fastdebug mode and passes >>> the eight jtreg tests in test/jdk/valhalla/*. It also passes >>> most of the tests in test/hotspot/jtreg/runtime/valhalla/*. >>> >>> I hacked your option logic, Srikanth, to force javac to use >>> the new mode all the time. This made it easier to verify >>> that things were working?and that change is yours to >>> roll back. >>> >>> The method handle logic changes are untested and >>> probably broken. >>> >>> (Anybody want to co-pilot these changes? :-) >>> >>> ? John >>> >>> P.S. To those celebrating, Happy Easter! >>> >>> On Apr 20, 2019, at 11:48 AM, John Rose wrote: >>>> I've been wanting to do this for some time. I'll take a crack at it. >>>> >>>>> On Apr 20, 2019, at 8:19 AM, Srikanth wrote: >>>>> >>>>> JVM folk: >>>>> >>>>> I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 ([lworld] JVM should be enhanced to work with static factory methods for inline types) in connection with this. From john.r.rose at oracle.com Wed Apr 24 20:10:22 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 24 Apr 2019 13:10:22 -0700 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> Message-ID: <6E420184-0AC5-4423-964D-679EAECA297C@oracle.com> On Apr 24, 2019, at 1:01 PM, Harold Seigel wrote: > > Just an fyi: Karen and I noticed a few small issues. > > Line 969 in ciMethod.cpp needs a '!': > > 967 bool ciMethod::is_static_init_factory() const { > 968 return (name() == ciSymbol::object_initializer_name() > 969 && signature()->return_type()->is_void()); > > 970 } > > Also, the assert() messages at lines 310 and 319 in javaCalls.cpp and lines 1269 and 1275 in reflection.cpp seemed incorrect. Good catch! Fixed code: bool ciMethod::is_static_init_factory() const { return (name() == ciSymbol::object_initializer_name() && !signature()->return_type()->is_void()); } Maybe this fixes a compiler crash; will retest. I respun the messages, respectively, as: 310: assert(klass->is_value(), "inline classes must use factory methods"); 319: assert(!klass->is_value(), "classic constructors are only for non-inline classes"); 1269: assert(klass->is_value(), "inline classes must use factory methods"); 1275: assert(!klass->is_value(), "classic constructors are only for non-inline classes"); ? John From ioi.lam at oracle.com Wed Apr 24 20:36:38 2019 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Wed, 24 Apr 2019 20:36:38 +0000 Subject: hg: valhalla/valhalla: 2 new changesets Message-ID: <201904242036.x3OKaeJe009414@aojmv0008.oracle.com> Changeset: b956e5e32915 Author: iklam Date: 2019-04-24 13:21 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b956e5e32915 8222717: [lworld] Calling convention - repair C1 stack Reviewed-by: thartmann ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/frame_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/share/c1/c1_Compilation.cpp ! src/hotspot/share/c1/c1_Compilation.hpp ! src/hotspot/share/c1/c1_LIRAssembler.cpp ! src/hotspot/share/c1/c1_LIRAssembler.hpp ! src/hotspot/share/c1/c1_MacroAssembler.hpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java Changeset: 094bfc7c5dfd Author: iklam Date: 2019-04-24 13:28 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/094bfc7c5dfd 8222908: [lworld] Calling convention - unwind C2->C1 callstack ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java From john.r.rose at oracle.com Wed Apr 24 20:43:50 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 24 Apr 2019 13:43:50 -0700 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <6E420184-0AC5-4423-964D-679EAECA297C@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> <6E420184-0AC5-4423-964D-679EAECA297C@oracle.com> Message-ID: On Apr 24, 2019, at 1:10 PM, John Rose wrote: > > Good catch! Fixed code: I updated the webrev. I also added a little more detail to some of the relevant error messages about new uses of . Basically, sometimes the VM should remark that a class with an error in it is an inline class, since some conditions that are errors in inline classes are not errors in non-inline classes, and vice versa. The diff for these error message tweaks is also enclosed. These helped me understand the output of jtreg tests like this one: JTwork/runtime/valhalla/valuetypes/verifier/VerifierValueTypes.jtr:18:execStatus=Failed. Execution failed\: `main' threw exception\: java.lang.ClassFormatError\: Method in class wthFldBadCP (an inline class) has illegal modifiers\: 0x0 ? John diff --git a/src/hotspot/share/classfile/classFileParser.cpp b/src/hotspot/share/classfile/classFileParser.cpp --- b/src/hotspot/share/classfile/classFileParser.cpp +++ a/src/hotspot/share/classfile/classFileParser.cpp @@ -2104,11 +2104,16 @@ assert(name != NULL, "invariant"); assert(sig != NULL, "invariant"); + const char* class_note = ""; + if (is_value_type() && name == vmSymbols::object_initializer_name()) { + class_note = " (an inline class)"; + } + ResourceMark rm(THREAD); Exceptions::fthrow(THREAD_AND_LOCATION, vmSymbols::java_lang_ClassFormatError(), - "%s \"%s\" in class %s has illegal signature \"%s\"", type, - name->as_C_string(), _class_name->as_C_string(), sig->as_C_string()); + "%s \"%s\" in class %s%s has illegal signature \"%s\"", type, + name->as_C_string(), _class_name->as_C_string(), class_note, sig->as_C_string()); } AnnotationCollector::ID @@ -5055,11 +5060,13 @@ (!is_interface && major_gte_15 && is_annotation) || (is_value_type && (is_interface || is_abstract || is_enum || !is_final))) { ResourceMark rm(THREAD); + const char* class_note = ""; + if (is_value_type) class_note = " (an inline class)"; Exceptions::fthrow( THREAD_AND_LOCATION, vmSymbols::java_lang_ClassFormatError(), - "Illegal class modifiers in class %s: 0x%X", - _class_name->as_C_string(), flags + "Illegal class modifiers in class %s%s: 0x%X", + _class_name->as_C_string(), class_note, flags ); return; } @@ -5202,6 +5209,8 @@ bool is_illegal = false; + const char* class_note = ""; + if (is_interface) { if (major_gte_8) { // Class file version is JAVA_8_VERSION or later Methods of @@ -5247,10 +5256,12 @@ } else { // but no other combinations are allowed is_illegal = true; + class_note = (is_value_type ? " (an inline class)" : " (not an inline class)"); } } else { // not initializer if (is_value_type && is_synchronized && !is_static) { is_illegal = true; + class_note = " (an inline class)"; } else { if (is_abstract) { if ((is_final || is_native || is_private || is_static || @@ -5268,8 +5279,8 @@ Exceptions::fthrow( THREAD_AND_LOCATION, vmSymbols::java_lang_ClassFormatError(), - "Method %s in class %s has illegal modifiers: 0x%X", - name->as_C_string(), _class_name->as_C_string(), flags); + "Method %s in class %s%s has illegal modifiers: 0x%X", + name->as_C_string(), _class_name->as_C_string(), class_note, flags); return; } } From srikanth.adayapalam at oracle.com Thu Apr 25 06:41:31 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Thu, 25 Apr 2019 06:41:31 +0000 Subject: hg: valhalla/valhalla: 8222711: [lworld]: Value construction modalities in class file. Make sure to qualify the factory method with the correct containing class. Message-ID: <201904250641.x3P6fWQd028995@aojmv0008.oracle.com> Changeset: 1a4944fedb53 Author: sadayapalam Date: 2019-04-25 12:11 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/1a4944fedb53 8222711: [lworld]: Value construction modalities in class file. Make sure to qualify the factory method with the correct containing class. ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/TransValues.java From tobias.hartmann at oracle.com Thu Apr 25 07:47:03 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 25 Apr 2019 09:47:03 +0200 Subject: RFR(L): JDK-8222525 : [lworld] Runtime support for LW2 Arrays In-Reply-To: <5E13BDA9-4B31-40F8-9DF8-9DB4D24196B4@oracle.com> References: <5E13BDA9-4B31-40F8-9DF8-9DB4D24196B4@oracle.com> Message-ID: <77ff639c-4933-5ba8-877a-3b9301c0f1cb@oracle.com> Hi, On 24.04.19 20:54, Frederic Parain wrote: > ciReplay.cpp:916: > Could the resolution fail? If yes, what would be the consequences? Yes, we print an error message and stop replay compilation if ReplayIgnoreInitErrors is not set: http://hg.openjdk.java.net/jdk/jdk/file/fe9f33555993/src/hotspot/share/ci/ciReplay.cpp#l427 This can already happen when resolving an 'L' array or object: http://hg.openjdk.java.net/jdk/jdk/file/fe9f33555993/src/hotspot/share/ci/ciReplay.cpp#l849 http://hg.openjdk.java.net/jdk/jdk/file/fe9f33555993/src/hotspot/share/ci/ciReplay.cpp#l891 And it actually does happen frequently when trying to replay compilation without all the dependent classes on the classpath. If ReplayIgnoreInitErrors is set, we might crash but that's okay because replay compilation is just a debugging tool that is very powerful if it works but does not work in many cases for various reasons (for example, dynamically generated bytecodes). Best regards, Tobias From srikanth.adayapalam at oracle.com Thu Apr 25 07:52:55 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Thu, 25 Apr 2019 07:52:55 +0000 Subject: hg: valhalla/valhalla: 8222711: [lworld]: Value construction modalities in class file. Remove untenable assert. Message-ID: <201904250752.x3P7quo7003865@aojmv0008.oracle.com> Changeset: b9aac85f70c2 Author: sadayapalam Date: 2019-04-25 13:22 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/b9aac85f70c2 8222711: [lworld]: Value construction modalities in class file. Remove untenable assert. ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/TransValues.java + test/langtools/tools/javac/valhalla/lworld-values/TestQualifierOnInit.java From srikanth.adayapalam at oracle.com Thu Apr 25 08:13:18 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Thu, 25 Apr 2019 08:13:18 +0000 Subject: hg: valhalla/valhalla: 8222711: [lworld]: Value construction modalities in class file. Remove untenable assert. Message-ID: <201904250813.x3P8DJtY017050@aojmv0008.oracle.com> Changeset: e012cac085f8 Author: sadayapalam Date: 2019-04-25 13:43 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e012cac085f8 8222711: [lworld]: Value construction modalities in class file. Remove untenable assert. + test/langtools/tools/javac/valhalla/lworld-values/CompilerNoBogusAssert.java From frederic.parain at oracle.com Thu Apr 25 15:40:34 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Thu, 25 Apr 2019 11:40:34 -0400 Subject: RFR(L): JDK-8222525 : [lworld] Runtime support for LW2 Arrays In-Reply-To: <77ff639c-4933-5ba8-877a-3b9301c0f1cb@oracle.com> References: <5E13BDA9-4B31-40F8-9DF8-9DB4D24196B4@oracle.com> <77ff639c-4933-5ba8-877a-3b9301c0f1cb@oracle.com> Message-ID: Tobias, Thank you for the explanation. Fred On 4/25/19 3:47 AM, Tobias Hartmann wrote: > Hi, > > On 24.04.19 20:54, Frederic Parain wrote: >> ciReplay.cpp:916: >> Could the resolution fail? If yes, what would be the consequences? > > Yes, we print an error message and stop replay compilation if ReplayIgnoreInitErrors is not set: > http://hg.openjdk.java.net/jdk/jdk/file/fe9f33555993/src/hotspot/share/ci/ciReplay.cpp#l427 > > This can already happen when resolving an 'L' array or object: > http://hg.openjdk.java.net/jdk/jdk/file/fe9f33555993/src/hotspot/share/ci/ciReplay.cpp#l849 > http://hg.openjdk.java.net/jdk/jdk/file/fe9f33555993/src/hotspot/share/ci/ciReplay.cpp#l891 > > And it actually does happen frequently when trying to replay compilation without all the dependent > classes on the classpath. If ReplayIgnoreInitErrors is set, we might crash but that's okay because > replay compilation is just a debugging tool that is very powerful if it works but does not work in > many cases for various reasons (for example, dynamically generated bytecodes). > > Best regards, > Tobias > From srikanth.adayapalam at oracle.com Fri Apr 26 02:27:47 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Fri, 26 Apr 2019 02:27:47 +0000 Subject: hg: valhalla/valhalla: 8222555, 8222553: [lworld]: Regression tests to show code compiles properly. Message-ID: <201904260227.x3Q2Rm90008866@aojmv0008.oracle.com> Changeset: 6c4b864386e1 Author: sadayapalam Date: 2019-04-26 07:57 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/6c4b864386e1 8222555, 8222553: [lworld]: Regression tests to show code compiles properly. + test/langtools/tools/javac/valhalla/lworld-values/CompilesJustFine.java From david.simms at oracle.com Fri Apr 26 07:51:38 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 26 Apr 2019 09:51:38 +0200 Subject: RFR(L): JDK-8222525 : [lworld] Runtime support for LW2 Arrays In-Reply-To: <5E13BDA9-4B31-40F8-9DF8-9DB4D24196B4@oracle.com> References: <5E13BDA9-4B31-40F8-9DF8-9DB4D24196B4@oracle.com> Message-ID: <26aa9f4e-7938-8407-f38d-e150f0cc6ef6@oracle.com> Thanks for the review, it was a lot to grok, typo fixed Cheers /D On 24/04/19 8:54 PM, Frederic Parain wrote: > Looks good. > > Two minor points: > > ciReplay.cpp:916: > Could the resolution fail? If yes, what would be the consequences? > > oopFactory.hpp:76 > typo: of -> if > > Thanks for doing this huge re-work of value arrays. > > Fred > >> On Apr 16, 2019, at 04:46, David Simms wrote: >> >> >> Please review runtime support for LW2 array covariance[1]: >> >> http://cr.openjdk.java.net/~dsimms/valhalla/lw2_arrays/webrev5/ >> >> Further testing is needed, but requires javac (for ease of writing) >> >> /David Simms >> >> [1] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-April/005600.html >> From david.simms at oracle.com Fri Apr 26 08:16:07 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Fri, 26 Apr 2019 08:16:07 +0000 Subject: hg: valhalla/valhalla: 8222525: [lworld] Runtime support for LW2 Arrays Message-ID: <201904260816.x3Q8G8VC008976@aojmv0008.oracle.com> Changeset: 785f203628dd Author: dsimms Date: 2019-04-26 10:15 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/785f203628dd 8222525: [lworld] Runtime support for LW2 Arrays Reviewed-by: fparain ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/cpu/x86/vtableStubs_x86_64.cpp ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/gc/shared/memAllocator.cpp ! src/hotspot/share/gc/shared/memAllocator.hpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/oopFactory.cpp ! src/hotspot/share/memory/oopFactory.hpp ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/arrayKlass.hpp + src/hotspot/share/oops/arrayStorageProperties.cpp + src/hotspot/share/oops/arrayStorageProperties.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/objArrayKlass.cpp ! src/hotspot/share/oops/objArrayKlass.hpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/oops/typeArrayKlass.cpp ! src/hotspot/share/oops/typeArrayKlass.hpp ! src/hotspot/share/oops/valueArrayKlass.cpp ! src/hotspot/share/oops/valueArrayKlass.hpp ! src/hotspot/share/oops/valueKlass.cpp ! src/hotspot/share/oops/valueKlass.hpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/prims/jvmtiGetLoadedClasses.cpp ! src/hotspot/share/runtime/fieldType.cpp ! src/hotspot/share/runtime/fieldType.hpp ! src/hotspot/share/runtime/reflection.cpp ! src/hotspot/share/services/heapDumper.cpp ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java From tobias.hartmann at oracle.com Fri Apr 26 08:18:18 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Fri, 26 Apr 2019 08:18:18 +0000 Subject: hg: valhalla/valhalla: 8220716: [lworld] C2 support for LW2 arrays Message-ID: <201904260818.x3Q8IIfp009570@aojmv0008.oracle.com> Changeset: eeb82eab9c31 Author: thartmann Date: 2019-04-26 10:18 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/eeb82eab9c31 8220716: [lworld] C2 support for LW2 arrays Reviewed-by: roland ! src/hotspot/share/ci/ciArrayKlass.cpp ! src/hotspot/share/ci/ciArrayKlass.hpp ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/ci/ciEnv.hpp ! src/hotspot/share/ci/ciInstance.cpp ! src/hotspot/share/ci/ciInstance.hpp ! src/hotspot/share/ci/ciMetadata.hpp ! src/hotspot/share/ci/ciObjArrayKlass.cpp ! src/hotspot/share/ci/ciObjArrayKlass.hpp ! src/hotspot/share/ci/ciType.hpp ! src/hotspot/share/ci/ciTypeFlow.cpp ! src/hotspot/share/ci/ciValueArrayKlass.cpp ! src/hotspot/share/ci/ciValueKlass.cpp ! src/hotspot/share/ci/ciValueKlass.hpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/objArrayKlass.cpp ! src/hotspot/share/oops/typeArrayKlass.cpp ! src/hotspot/share/oops/valueArrayKlass.cpp ! src/hotspot/share/oops/valueKlass.cpp ! src/hotspot/share/oops/valueKlass.hpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/callnode.cpp ! src/hotspot/share/opto/callnode.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/graphKit.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/macro.cpp ! src/hotspot/share/opto/macroArrayCopy.cpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/opto/parse2.cpp ! src/hotspot/share/opto/parse3.cpp ! src/hotspot/share/opto/parseHelper.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/opto/type.cpp ! src/hotspot/share/opto/type.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! src/java.base/share/classes/java/lang/Class.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestArrays.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestIntrinsics.java + test/hotspot/jtreg/compiler/valhalla/valuetypes/TestNullableArrays.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestOnStackReplacement.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestUnloadedValueTypeArray.java From tobias.hartmann at oracle.com Fri Apr 26 10:54:17 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Fri, 26 Apr 2019 10:54:17 +0000 Subject: hg: valhalla/valhalla: [lworld] Removed some accidentally pushed debug code Message-ID: <201904261054.x3QAsI3o009606@aojmv0008.oracle.com> Changeset: c185f52c0906 Author: thartmann Date: 2019-04-26 12:54 +0200 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/c185f52c0906 [lworld] Removed some accidentally pushed debug code ! src/hotspot/share/opto/compile.cpp From srikanth.adayapalam at oracle.com Fri Apr 26 12:15:08 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Fri, 26 Apr 2019 17:45:08 +0530 Subject: hg: valhalla/valhalla: 8222525: [lworld] Runtime support for LW2 Arrays In-Reply-To: <201904260816.x3Q8G8VC008976@aojmv0008.oracle.com> References: <201904260816.x3Q8G8VC008976@aojmv0008.oracle.com> Message-ID: <2ea2a67d-c553-014f-bfe3-d0399760ad53@oracle.com> The following program triggers a CCE: public inline class X { ??? int x = 42; ??? public static void main(String [] args) { ??????? X[] xqa = new X[10]; ??????? X?[] xla; ??????? Object [] oa; ??????? Object o; ??????? o = oa = xla = xqa; ??????? xqa = (X[]) (xla = (X?[])(oa = (Object []) o)); ??? } } on tip. Is that expected ??? Srikanth On 26/04/19 1:46 PM, david.simms at oracle.com wrote: > Changeset: 785f203628dd > Author: dsimms > Date: 2019-04-26 10:15 +0200 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/785f203628dd > > 8222525: [lworld] Runtime support for LW2 Arrays > Reviewed-by: fparain > > ! src/hotspot/cpu/x86/macroAssembler_x86.cpp > ! src/hotspot/cpu/x86/macroAssembler_x86.hpp > ! src/hotspot/cpu/x86/templateTable_x86.cpp > ! src/hotspot/cpu/x86/vtableStubs_x86_64.cpp > ! src/hotspot/cpu/x86/x86_64.ad > ! src/hotspot/share/ci/ciReplay.cpp > ! src/hotspot/share/classfile/classFileParser.cpp > ! src/hotspot/share/classfile/javaClasses.cpp > ! src/hotspot/share/classfile/javaClasses.hpp > ! src/hotspot/share/classfile/systemDictionary.cpp > ! src/hotspot/share/gc/shared/memAllocator.cpp > ! src/hotspot/share/gc/shared/memAllocator.hpp > ! src/hotspot/share/interpreter/interpreterRuntime.cpp > ! src/hotspot/share/memory/metaspace.cpp > ! src/hotspot/share/memory/oopFactory.cpp > ! src/hotspot/share/memory/oopFactory.hpp > ! src/hotspot/share/oops/arrayKlass.cpp > ! src/hotspot/share/oops/arrayKlass.hpp > + src/hotspot/share/oops/arrayStorageProperties.cpp > + src/hotspot/share/oops/arrayStorageProperties.hpp > ! src/hotspot/share/oops/constantPool.cpp > ! src/hotspot/share/oops/instanceKlass.cpp > ! src/hotspot/share/oops/instanceKlass.hpp > ! src/hotspot/share/oops/klass.cpp > ! src/hotspot/share/oops/klass.hpp > ! src/hotspot/share/oops/objArrayKlass.cpp > ! src/hotspot/share/oops/objArrayKlass.hpp > ! src/hotspot/share/oops/oop.hpp > ! src/hotspot/share/oops/oop.inline.hpp > ! src/hotspot/share/oops/symbol.cpp > ! src/hotspot/share/oops/symbol.hpp > ! src/hotspot/share/oops/typeArrayKlass.cpp > ! src/hotspot/share/oops/typeArrayKlass.hpp > ! src/hotspot/share/oops/valueArrayKlass.cpp > ! src/hotspot/share/oops/valueArrayKlass.hpp > ! src/hotspot/share/oops/valueKlass.cpp > ! src/hotspot/share/oops/valueKlass.hpp > ! src/hotspot/share/opto/runtime.cpp > ! src/hotspot/share/prims/jvmtiGetLoadedClasses.cpp > ! src/hotspot/share/runtime/fieldType.cpp > ! src/hotspot/share/runtime/fieldType.hpp > ! src/hotspot/share/runtime/reflection.cpp > ! src/hotspot/share/services/heapDumper.cpp > ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java > From srikanth.adayapalam at oracle.com Fri Apr 26 12:19:01 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Fri, 26 Apr 2019 17:49:01 +0530 Subject: hg: valhalla/valhalla: 8222525: [lworld] Runtime support for LW2 Arrays In-Reply-To: <0f69792c-268a-c15f-1cd3-d422c50e6b08@oracle.com> References: <201904260816.x3Q8G8VC008976@aojmv0008.oracle.com> <0f69792c-268a-c15f-1cd3-d422c50e6b08@oracle.com> Message-ID: On 26/04/19 5:48 PM, Srikanth wrote: > The following javac tests: > > test/langtools/tools/javac/valhalla/lworld-values/TypeRelationsTest.java > test/langtools/tools/javac/valhalla/lworld-values/ArrayRelationsTest.java > > > are not failing with are *now* failing with > java.lang.ClassCastException: class [QTypeRelationsTest; cannot be cast to class [LTypeRelationsTest; > java.lang.ClassCastException: class [QArrayRelationsTest; cannot be cast to class [LArrayRelationsTest; > > Thanks for checking. These tests are basically asserting "[QFoo;" <: > "[LFoo;? <: ?[LObject;? <: ?Object;" > Let me know if I blew something. > > Srikanth > > > On 26/04/19 1:46 PM, david.simms at oracle.com wrote: >> Changeset: 785f203628dd >> Author: dsimms >> Date: 2019-04-26 10:15 +0200 >> URL:http://hg.openjdk.java.net/valhalla/valhalla/rev/785f203628dd >> >> 8222525: [lworld] Runtime support for LW2 Arrays >> Reviewed-by: fparain >> >> ! src/hotspot/cpu/x86/macroAssembler_x86.cpp >> ! src/hotspot/cpu/x86/macroAssembler_x86.hpp >> ! src/hotspot/cpu/x86/templateTable_x86.cpp >> ! src/hotspot/cpu/x86/vtableStubs_x86_64.cpp >> ! src/hotspot/cpu/x86/x86_64.ad >> ! src/hotspot/share/ci/ciReplay.cpp >> ! src/hotspot/share/classfile/classFileParser.cpp >> ! src/hotspot/share/classfile/javaClasses.cpp >> ! src/hotspot/share/classfile/javaClasses.hpp >> ! src/hotspot/share/classfile/systemDictionary.cpp >> ! src/hotspot/share/gc/shared/memAllocator.cpp >> ! src/hotspot/share/gc/shared/memAllocator.hpp >> ! src/hotspot/share/interpreter/interpreterRuntime.cpp >> ! src/hotspot/share/memory/metaspace.cpp >> ! src/hotspot/share/memory/oopFactory.cpp >> ! src/hotspot/share/memory/oopFactory.hpp >> ! src/hotspot/share/oops/arrayKlass.cpp >> ! src/hotspot/share/oops/arrayKlass.hpp >> + src/hotspot/share/oops/arrayStorageProperties.cpp >> + src/hotspot/share/oops/arrayStorageProperties.hpp >> ! src/hotspot/share/oops/constantPool.cpp >> ! src/hotspot/share/oops/instanceKlass.cpp >> ! src/hotspot/share/oops/instanceKlass.hpp >> ! src/hotspot/share/oops/klass.cpp >> ! src/hotspot/share/oops/klass.hpp >> ! src/hotspot/share/oops/objArrayKlass.cpp >> ! src/hotspot/share/oops/objArrayKlass.hpp >> ! src/hotspot/share/oops/oop.hpp >> ! src/hotspot/share/oops/oop.inline.hpp >> ! src/hotspot/share/oops/symbol.cpp >> ! src/hotspot/share/oops/symbol.hpp >> ! src/hotspot/share/oops/typeArrayKlass.cpp >> ! src/hotspot/share/oops/typeArrayKlass.hpp >> ! src/hotspot/share/oops/valueArrayKlass.cpp >> ! src/hotspot/share/oops/valueArrayKlass.hpp >> ! src/hotspot/share/oops/valueKlass.cpp >> ! src/hotspot/share/oops/valueKlass.hpp >> ! src/hotspot/share/opto/runtime.cpp >> ! src/hotspot/share/prims/jvmtiGetLoadedClasses.cpp >> ! src/hotspot/share/runtime/fieldType.cpp >> ! src/hotspot/share/runtime/fieldType.hpp >> ! src/hotspot/share/runtime/reflection.cpp >> ! src/hotspot/share/services/heapDumper.cpp >> ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java >> ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java >> > From david.simms at oracle.com Fri Apr 26 12:19:18 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 26 Apr 2019 14:19:18 +0200 Subject: hg: valhalla/valhalla: 8222525: [lworld] Runtime support for LW2 Arrays In-Reply-To: <2ea2a67d-c553-014f-bfe3-d0399760ad53@oracle.com> References: <201904260816.x3Q8G8VC008976@aojmv0008.oracle.com> <2ea2a67d-c553-014f-bfe3-d0399760ad53@oracle.com> Message-ID: Follow up bug filed: https://bugs.openjdk.java.net/browse/JDK-8223017 (sorry I just adjusted the missing label on the bug) We were looking to sync up in the repo with C2 code first, which also needs widening conversion code. On 26/04/19 2:15 PM, Srikanth wrote: > The following program triggers a CCE: > > public inline class X { > ??? int x = 42; > ??? public static void main(String [] args) { > ??????? X[] xqa = new X[10]; > ??????? X?[] xla; > ??????? Object [] oa; > ??????? Object o; > ??????? o = oa = xla = xqa; > ??????? xqa = (X[]) (xla = (X?[])(oa = (Object []) o)); > ??? } > } > > on tip. Is that expected ??? > > Srikanth > From srikanth.adayapalam at oracle.com Fri Apr 26 12:18:29 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Fri, 26 Apr 2019 17:48:29 +0530 Subject: hg: valhalla/valhalla: 8222525: [lworld] Runtime support for LW2 Arrays In-Reply-To: <201904260816.x3Q8G8VC008976@aojmv0008.oracle.com> References: <201904260816.x3Q8G8VC008976@aojmv0008.oracle.com> Message-ID: <0f69792c-268a-c15f-1cd3-d422c50e6b08@oracle.com> The following javac tests: test/langtools/tools/javac/valhalla/lworld-values/TypeRelationsTest.java test/langtools/tools/javac/valhalla/lworld-values/ArrayRelationsTest.java are not failing with java.lang.ClassCastException: class [QTypeRelationsTest; cannot be cast to class [LTypeRelationsTest; java.lang.ClassCastException: class [QArrayRelationsTest; cannot be cast to class [LArrayRelationsTest; Thanks for checking. These tests are basically asserting "[QFoo;" <: "[LFoo;? <: ?[LObject;? <: ?Object;" Let me know if I blew something. Srikanth On 26/04/19 1:46 PM, david.simms at oracle.com wrote: > Changeset: 785f203628dd > Author: dsimms > Date: 2019-04-26 10:15 +0200 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/785f203628dd > > 8222525: [lworld] Runtime support for LW2 Arrays > Reviewed-by: fparain > > ! src/hotspot/cpu/x86/macroAssembler_x86.cpp > ! src/hotspot/cpu/x86/macroAssembler_x86.hpp > ! src/hotspot/cpu/x86/templateTable_x86.cpp > ! src/hotspot/cpu/x86/vtableStubs_x86_64.cpp > ! src/hotspot/cpu/x86/x86_64.ad > ! src/hotspot/share/ci/ciReplay.cpp > ! src/hotspot/share/classfile/classFileParser.cpp > ! src/hotspot/share/classfile/javaClasses.cpp > ! src/hotspot/share/classfile/javaClasses.hpp > ! src/hotspot/share/classfile/systemDictionary.cpp > ! src/hotspot/share/gc/shared/memAllocator.cpp > ! src/hotspot/share/gc/shared/memAllocator.hpp > ! src/hotspot/share/interpreter/interpreterRuntime.cpp > ! src/hotspot/share/memory/metaspace.cpp > ! src/hotspot/share/memory/oopFactory.cpp > ! src/hotspot/share/memory/oopFactory.hpp > ! src/hotspot/share/oops/arrayKlass.cpp > ! src/hotspot/share/oops/arrayKlass.hpp > + src/hotspot/share/oops/arrayStorageProperties.cpp > + src/hotspot/share/oops/arrayStorageProperties.hpp > ! src/hotspot/share/oops/constantPool.cpp > ! src/hotspot/share/oops/instanceKlass.cpp > ! src/hotspot/share/oops/instanceKlass.hpp > ! src/hotspot/share/oops/klass.cpp > ! src/hotspot/share/oops/klass.hpp > ! src/hotspot/share/oops/objArrayKlass.cpp > ! src/hotspot/share/oops/objArrayKlass.hpp > ! src/hotspot/share/oops/oop.hpp > ! src/hotspot/share/oops/oop.inline.hpp > ! src/hotspot/share/oops/symbol.cpp > ! src/hotspot/share/oops/symbol.hpp > ! src/hotspot/share/oops/typeArrayKlass.cpp > ! src/hotspot/share/oops/typeArrayKlass.hpp > ! src/hotspot/share/oops/valueArrayKlass.cpp > ! src/hotspot/share/oops/valueArrayKlass.hpp > ! src/hotspot/share/oops/valueKlass.cpp > ! src/hotspot/share/oops/valueKlass.hpp > ! src/hotspot/share/opto/runtime.cpp > ! src/hotspot/share/prims/jvmtiGetLoadedClasses.cpp > ! src/hotspot/share/runtime/fieldType.cpp > ! src/hotspot/share/runtime/fieldType.hpp > ! src/hotspot/share/runtime/reflection.cpp > ! src/hotspot/share/services/heapDumper.cpp > ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java > ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java > From tobias.hartmann at oracle.com Fri Apr 26 13:25:42 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 26 Apr 2019 15:25:42 +0200 Subject: hg: valhalla/valhalla: 8222525: [lworld] Runtime support for LW2 Arrays In-Reply-To: References: <201904260816.x3Q8G8VC008976@aojmv0008.oracle.com> <2ea2a67d-c553-014f-bfe3-d0399760ad53@oracle.com> Message-ID: > On 26.04.19 14:19, David Simms wrote: >> Follow up bug filed: https://bugs.openjdk.java.net/browse/JDK-8223017 (sorry I just adjusted the >> missing label on the bug) >> >> We were looking to sync up in the repo with C2 code first, which also needs widening conversion code. For reference, here's the bug for C2: https://bugs.openjdk.java.net/browse/JDK-8223029 Thanks, Tobias From srikanth.adayapalam at oracle.com Fri Apr 26 13:42:56 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Fri, 26 Apr 2019 13:42:56 +0000 Subject: hg: valhalla/valhalla: 8222974: [lworld]: Interim fix for javac doesn't like "?" syntax in instanceof type expression Message-ID: <201904261342.x3QDgvAc021346@aojmv0008.oracle.com> Changeset: e5338bea8270 Author: sadayapalam Date: 2019-04-26 19:12 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e5338bea8270 8222974: [lworld]: Interim fix for javac doesn't like "?" syntax in instanceof type expression ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/langtools/tools/javac/valhalla/lworld-values/InstanceofProjectionArray.java From srikanth.adayapalam at oracle.com Fri Apr 26 13:45:33 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Fri, 26 Apr 2019 19:15:33 +0530 Subject: hg: valhalla/valhalla: 8222974: [lworld]: Interim fix for javac doesn't like "?" syntax in instanceof type expression In-Reply-To: <201904261342.x3QDgvAc021346@aojmv0008.oracle.com> References: <201904261342.x3QDgvAc021346@aojmv0008.oracle.com> Message-ID: Mr Simms, This is an interim fix to unblock you. I'll leave the bug open to cover some corner cases that are not handled yet (such as type annotations on array dimensions) - The code attached to the JBS ticket should compile now. Let me know if you continue to see problems. Thanks! Srikanth On 26/04/19 7:12 PM, srikanth.adayapalam at oracle.com wrote: > Changeset: e5338bea8270 > Author: sadayapalam > Date: 2019-04-26 19:12 +0530 > URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/e5338bea8270 > > 8222974: [lworld]: Interim fix for javac doesn't like "?" syntax in instanceof type expression > > ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java > + test/langtools/tools/javac/valhalla/lworld-values/InstanceofProjectionArray.java > From srikanth.adayapalam at oracle.com Fri Apr 26 17:57:29 2019 From: srikanth.adayapalam at oracle.com (srikanth.adayapalam at oracle.com) Date: Fri, 26 Apr 2019 17:57:29 +0000 Subject: hg: valhalla/valhalla: 8222711: [lworld]: Additional fixes for value construction via static init factories. Message-ID: <201904261757.x3QHvUlH026201@aojmv0008.oracle.com> Changeset: 51c89c6d10e6 Author: sadayapalam Date: 2019-04-26 23:27 +0530 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/51c89c6d10e6 8222711: [lworld]: Additional fixes for value construction via static init factories. ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Items.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/TransValues.java ! test/langtools/tools/javac/valhalla/lworld-values/ArrayCreationWithQuestion.java ! test/langtools/tools/javac/valhalla/lworld-values/BoxValCastTest.java ! test/langtools/tools/javac/valhalla/lworld-values/ProjectedArrayDotClass.java ! test/langtools/tools/javac/valhalla/lworld-values/QTypeTest.java ! test/langtools/tools/javac/valhalla/lworld-values/ValueCreationTest.java ! test/langtools/tools/javac/valhalla/lworld-values/WithFieldOfExplicitSelector.java ! test/langtools/tools/javac/valhalla/lworld-values/WithFieldOfImplicitThis.java From david.simms at oracle.com Mon Apr 29 10:01:12 2019 From: david.simms at oracle.com (David Simms) Date: Mon, 29 Apr 2019 12:01:12 +0200 Subject: RFR (S) JDK-8223017: [lworld] checkcast/instance broken for LW2 arrays Message-ID: <60665f4c-6b1e-a4ea-abee-962bbd3ef61c@oracle.com> Here's a fix for the missing super type relationship for null-free arrays, i.e. "[QFoo;" <: "[LFoo;"...once LW2 array support went in, it accidentally skipped it's null-allow type and went straight to Object[]...added a few more test cases. Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8223017/ Bug: https://bugs.openjdk.java.net/browse/JDK-8223017 From harold.seigel at oracle.com Mon Apr 29 13:52:26 2019 From: harold.seigel at oracle.com (Harold Seigel) Date: Mon, 29 Apr 2019 09:52:26 -0400 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> Message-ID: <9ff40744-7b85-6dea-6147-dd88ad65f599@oracle.com> Hi, Here's a slightly updated version of John's patch to support static factory methods for inline types. Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_8222787/webrev/ Please note the following: 1. The patch hard-wires the Javac noStaticInitValueFactory option to always be 'on'. 2. Two hotspot JTReg compiler/valhalla tests fail with this change: 1. compiler/valhalla/valuetypes/TestBasicFunctionality.java 2. compiler/valhalla/valuetypes/TestLWorld.java 3. Verifier 'withfield' tests are commented out until withfield's fate is decided Any review comments would be welcome. Thanks, Harold On 4/24/2019 4:01 PM, Harold Seigel wrote: > Hi John, > > Just an fyi: Karen and I noticed a few small issues. > > Line 969 in ciMethod.cpp needs a '!': > > 967 bool ciMethod::is_static_init_factory() const { > 968 return (name() == ciSymbol::object_initializer_name() > 969 && signature()->return_type()->is_void()); > ?970 } > > Also, the assert() messages at lines 310 and 319 in javaCalls.cpp and > lines 1269 and 1275 in reflection.cpp seemed incorrect. > > Thanks, Harold > > On 4/24/2019 2:00 PM, John Rose wrote: >> Thanks, Harold!? I'm doing a small update to the patch which >> removed "is_object_method_signature".? I think it's simpler and >> easier to replace all the uses of s->is_object_method_signature() >> with !s->is_void_method_signature().? It makes a small difference >> in the spec., which is (I think) a good difference.? I'm working on >> an EG mail about the spec. as a whole. >> >> The webrev is updated in place: >> ?? http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787 >> >> ? John >> >> On Apr 23, 2019, at 8:17 AM, Harold Seigel >> wrote: >>> Hi John, >>> >>>>> Anybody want to co-pilot these changes? >>> I'll take a stab at it but will certainly ask core libs and others >>> for help. >>> >>> Harold >>> >>> On 4/21/2019 2:57 AM, John Rose wrote: >>>> http://cr.openjdk.java.net/~jrose/jvm/JDK-8222787/ >>>> >>>> This seems to work.? It builds in fastdebug mode and passes >>>> the eight jtreg tests in test/jdk/valhalla/*.? It also passes >>>> most of the tests in test/hotspot/jtreg/runtime/valhalla/*. >>>> >>>> I hacked your option logic, Srikanth, to force javac to use >>>> the new mode all the time.? This made it easier to verify >>>> that things were working?and that change is yours to >>>> roll back. >>>> >>>> The method handle logic changes are untested and >>>> probably broken. >>>> >>>> (Anybody want to co-pilot these changes? :-) >>>> >>>> ? John >>>> >>>> P.S. To those celebrating, Happy Easter! >>>> >>>> On Apr 20, 2019, at 11:48 AM, John Rose >>>> wrote: >>>>> I've been wanting to do this for some time.? I'll take a crack at it. >>>>> >>>>>> On Apr 20, 2019, at 8:19 AM, Srikanth >>>>>> wrote: >>>>>> >>>>>> JVM folk: >>>>>> >>>>>> I have raised https://bugs.openjdk.java.net/browse/JDK-8222787 >>>>>> ([lworld] JVM should be enhanced to work with static >>>>>> factory methods for inline types) in connection with this. From srikanth.adayapalam at oracle.com Mon Apr 29 15:54:56 2019 From: srikanth.adayapalam at oracle.com (Srikanth) Date: Mon, 29 Apr 2019 21:24:56 +0530 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <9ff40744-7b85-6dea-6147-dd88ad65f599@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> <9ff40744-7b85-6dea-6147-dd88ad65f599@oracle.com> Message-ID: <0fa76108-6f06-9c63-5494-e678a08f117d@oracle.com> On 29/04/19 7:22 PM, Harold Seigel wrote: > Hi, > > Here's a slightly updated version of John's patch to support static > factory methods for inline types. > > Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_8222787/webrev/ > > Please note the following: > > 1. The patch hard-wires the Javac noStaticInitValueFactory option to > ?? always be 'on'. I think you are trying to say, unless invoked with -XDnoStaticInitValueFactory, javac will produce the new style static factories. I am OK with this change on the javac side subjecting to a clean run of the langtools/tools/javac/valhalla tests at the time of the push post review - They were clean when we both ran them individually. Srikanth From harold.seigel at oracle.com Mon Apr 29 15:56:43 2019 From: harold.seigel at oracle.com (Harold Seigel) Date: Mon, 29 Apr 2019 11:56:43 -0400 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <0fa76108-6f06-9c63-5494-e678a08f117d@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> <9ff40744-7b85-6dea-6147-dd88ad65f599@oracle.com> <0fa76108-6f06-9c63-5494-e678a08f117d@oracle.com> Message-ID: Thanks Srikanth! Harold On 4/29/2019 11:54 AM, Srikanth wrote: > > > On 29/04/19 7:22 PM, Harold Seigel wrote: >> Hi, >> >> Here's a slightly updated version of John's patch to support static >> factory methods for inline types. >> >> Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_8222787/webrev/ >> >> Please note the following: >> >> 1. The patch hard-wires the Javac noStaticInitValueFactory option to >> ?? always be 'on'. > > I think you are trying to say, unless invoked with > -XDnoStaticInitValueFactory, javac will produce the new style static > factories. > > I am OK with this change on the javac side subjecting to a clean run > of the langtools/tools/javac/valhalla tests at the time of the push > post review - They were clean when we both ran them individually. > > Srikanth > From ioi.lam at oracle.com Tue Apr 30 04:04:57 2019 From: ioi.lam at oracle.com (Ioi Lam) Date: Mon, 29 Apr 2019 21:04:57 -0700 Subject: RFR 8222989 [lworld] Calling convention - C2 to C1 (oop params) Message-ID: <49b792a6-746b-34dc-0d85-fdcec31900ec@oracle.com> https://bugs.openjdk.java.net/browse/JDK-8222989 http://cr.openjdk.java.net/~iklam/valhalla/8222989-c1-calling-convention-oops.v01/ Many files are changed, but mostly are just for passing an extra 'tmp3' parameter to BarrierSetAssembler::store_at(). The old G1 implementation hard-codes tmp3==r8, but this conflicts with the Java calling convention that uses r8 for passing parameters. My next step is to handle GC that happens when the C1 entry points allocate buffered objects of inline class types. See JDK-8223110 Thanks - Ioi From tobias.hartmann at oracle.com Tue Apr 30 10:27:27 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 30 Apr 2019 12:27:27 +0200 Subject: RFR (S) JDK-8223017: [lworld] checkcast/instance broken for LW2 arrays In-Reply-To: <60665f4c-6b1e-a4ea-abee-962bbd3ef61c@oracle.com> References: <60665f4c-6b1e-a4ea-abee-962bbd3ef61c@oracle.com> Message-ID: <74903788-e2d8-daa9-f9bc-46fd9f1c413f@oracle.com> Hi Mr. Simms, I'm seeing the following inconsistent behavior: MyValue1?[] va1 = (MyValue1?[])null; // does not throw NPE MyValue1?[] va2 = null; // does not throw NPE MyValue1[] va3 = null; // does not throw NPE MyValue1[] va4 = (MyValue1[])null; // throws NPE Thanks, Tobias On 29.04.19 12:01, David Simms wrote: > > Here's a fix for the missing super type relationship for null-free arrays, i.e. "[QFoo;" <: > "[LFoo;"...once LW2 array support went in, it accidentally skipped it's null-allow type and went > straight to Object[]...added a few more test cases. > > Webrev: > > http://cr.openjdk.java.net/~dsimms/valhalla/8223017/ > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8223017 > From david.simms at oracle.com Tue Apr 30 13:46:02 2019 From: david.simms at oracle.com (David Simms) Date: Tue, 30 Apr 2019 15:46:02 +0200 Subject: RFR (S) JDK-8223017: [lworld] checkcast/instance broken for LW2 arrays In-Reply-To: <74903788-e2d8-daa9-f9bc-46fd9f1c413f@oracle.com> References: <60665f4c-6b1e-a4ea-abee-962bbd3ef61c@oracle.com> <74903788-e2d8-daa9-f9bc-46fd9f1c413f@oracle.com> Message-ID: <8e5cdab0-fafd-3b5b-c8b1-fd751d74fa40@oracle.com> Nice spotting, I didn't differentiate the "checkcast" behavior for "Q-type descriptors" and "Array Q-type descriptors". Since we are heading into a local holiday (tonight and tomorrow, bonfire night), I'll leave a note on my thinking here if I don't get to it until Thursday... * I probably need to || in another bit for arrays of q-type in the constant pool tag for the difference in behavior. Thinking of using "JVM_CONSTANT_Unicode" since it is unused (further mess, but there are not separate bits left) * anewarray and multianewarray needs something to tell them it's a q-type array, but for the interpreter at least we jump into the VM...so I wonder if we need the constant tag encoding at all Will look a little further into this... Cheers /D On 30/04/19 12:27 PM, Tobias Hartmann wrote: > Hi Mr. Simms, > > I'm seeing the following inconsistent behavior: > > MyValue1?[] va1 = (MyValue1?[])null; // does not throw NPE > MyValue1?[] va2 = null; // does not throw NPE > MyValue1[] va3 = null; // does not throw NPE > MyValue1[] va4 = (MyValue1[])null; // throws NPE > > Thanks, > Tobias > > On 29.04.19 12:01, David Simms wrote: >> Here's a fix for the missing super type relationship for null-free arrays, i.e. "[QFoo;" <: >> "[LFoo;"...once LW2 array support went in, it accidentally skipped it's null-allow type and went >> straight to Object[]...added a few more test cases. >> >> Webrev: >> >> http://cr.openjdk.java.net/~dsimms/valhalla/8223017/ >> >> Bug: >> >> https://bugs.openjdk.java.net/browse/JDK-8223017 >> From tobias.hartmann at oracle.com Tue Apr 30 14:18:25 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 30 Apr 2019 16:18:25 +0200 Subject: RFR 8222989 [lworld] Calling convention - C2 to C1 (oop params) In-Reply-To: <49b792a6-746b-34dc-0d85-fdcec31900ec@oracle.com> References: <49b792a6-746b-34dc-0d85-fdcec31900ec@oracle.com> Message-ID: Hi Ioi, looks good to me! Thanks, Tobias On 30.04.19 06:04, Ioi Lam wrote: > https://bugs.openjdk.java.net/browse/JDK-8222989 > http://cr.openjdk.java.net/~iklam/valhalla/8222989-c1-calling-convention-oops.v01/ > > Many files are changed, but mostly are just for passing an extra 'tmp3' > parameter to BarrierSetAssembler::store_at(). The old G1 implementation > hard-codes tmp3==r8, but this conflicts with the Java calling convention > that uses r8 for passing parameters. > > My next step is to handle GC that happens when the C1 entry points allocate > buffered objects of inline class types. See JDK-8223110 > > Thanks > - Ioi > > From harold.seigel at oracle.com Tue Apr 30 15:44:26 2019 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Tue, 30 Apr 2019 15:44:26 +0000 Subject: hg: valhalla/valhalla: 8223028: [lworld] vm/mlvm/anonloader/stress/byteMutation crash in VerificationType::is_valuetype_assignable_from() Message-ID: <201904301544.x3UFiRto015458@aojmv0008.oracle.com> Changeset: 46e31b376202 Author: hseigel Date: 2019-04-30 11:44 -0400 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/46e31b376202 8223028: [lworld] vm/mlvm/anonloader/stress/byteMutation crash in VerificationType::is_valuetype_assignable_from() Summary: Remove the complaining assert because it's complaining about a valid signature Reviewed-by: fparain ! src/hotspot/share/classfile/verificationType.cpp ! test/hotspot/jtreg/runtime/valhalla/valuetypes/verifier/VerifierValueTypes.java ! test/hotspot/jtreg/runtime/valhalla/valuetypes/verifier/verifierTests.jcod From tobias.hartmann at oracle.com Tue Apr 30 16:41:22 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Tue, 30 Apr 2019 18:41:22 +0200 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: <9ff40744-7b85-6dea-6147-dd88ad65f599@oracle.com> References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> <9ff40744-7b85-6dea-6147-dd88ad65f599@oracle.com> Message-ID: Hi Harold, On 29.04.19 15:52, Harold Seigel wrote: > Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_8222787/webrev/ The compiler changes look good to me. > 2. Two hotspot JTReg compiler/valhalla tests fail with this change: > ??? 1. compiler/valhalla/valuetypes/TestBasicFunctionality.java > ??? 2. compiler/valhalla/valuetypes/TestLWorld.java The tests fail because C2 does not inline some of the '' methods although the constructor is annotated with @ForceInline. The test infrastructure iterates over all methods returned by Class::getDeclaredMethods and calls WhiteBox::testSetForceInlineMethod for those methods annotated with @ForceInline: http://hg.openjdk.java.net/valhalla/valhalla/file/eeb82eab9c31/test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java#l528 Now that worked with old 'makeValue' because it's a normal method and therefore returned by getDeclaredMethods but it does not work with the new '' constructor. Below is a little test that shows the difference. Before, the test printed "public static MyValue1/val MyValue1.$makeValue$(int)". Now it does not print anything. If that is expected behavior, you can go ahead and fix it like this: diff -r 51c89c6d10e6 test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java --- a/test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java Fri Apr 26 23:27:18 2019 +0530 +++ b/test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java Tue Apr 30 17:35:09 2019 +0200 @@ -121,6 +121,7 @@ "-XX:CompileCommand=compileonly,java.lang.invoke.*::*", "-XX:CompileCommand=compileonly,java.lang.Long::sum", "-XX:CompileCommand=compileonly,java.lang.Object::", + "-XX:CompileCommand=inline,compiler.valhalla.valuetypes.MyValue*::", "-XX:CompileCommand=compileonly,compiler.valhalla.valuetypes.*::*"}; private static final String[] printFlags = { "-XX:+PrintCompilation", "-XX:+PrintIdeal", "-XX:+UnlockDiagnosticVMOptions", "-XX:+PrintOptoAssembly"}; I've also noticed that code compiled with -XDnoStaticInitValueFactory throws a ClassFormatError when executed. For example, below test fails with: Exception in thread "main" java.lang.ClassFormatError: Method in class MyValue1 (an inline class) has illegal modifiers: 0x1 at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1016) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:151) at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:823) Best regards, Tobias import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; import java.lang.annotation.Repeatable; import java.lang.reflect.Method; @Retention(RetentionPolicy.RUNTIME) @interface ForceInline { } value class MyValue1 { public final int x; @ForceInline public MyValue1(int x) { this.x = x; } } public class Test { public static void main(String[] args) throws Throwable { Method[] methods = MyValue1.class.getMethods(); for (Method m : methods) { if (m.isAnnotationPresent(ForceInline.class)) { System.out.println(m); } } } } From john.r.rose at oracle.com Tue Apr 30 19:11:30 2019 From: john.r.rose at oracle.com (John Rose) Date: Tue, 30 Apr 2019 12:11:30 -0700 Subject: hg: valhalla/valhalla: 8222711: [lworld] Initial skeletal implementation of inline class instance construction via In-Reply-To: References: <201904201505.x3KF5SKY022229@aojmv0008.oracle.com> <6c9edf41-6d63-394c-fa0e-5656a17dbe04@oracle.com> <8FE44E65-C393-431D-B8CF-AECEA56E404E@oracle.com> <3C062B57-2488-4604-BF58-F46DB57D2DB6@oracle.com> <6979659D-C429-4D0B-86BB-78B36F77760A@oracle.com> <9ff40744-7b85-6dea-6147-dd88ad65f599@oracle.com> Message-ID: <527CC23D-C4C5-4868-B384-B2A12451763D@oracle.com> On Apr 30, 2019, at 9:41 AM, Tobias Hartmann wrote: > > Hi Harold, > > On 29.04.19 15:52, Harold Seigel wrote: >> Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld_8222787/webrev/ > > The compiler changes look good to me. > >> 2. Two hotspot JTReg compiler/valhalla tests fail with this change: >> 1. compiler/valhalla/valuetypes/TestBasicFunctionality.java >> 2. compiler/valhalla/valuetypes/TestLWorld.java > > The tests fail because C2 does not inline some of the '' methods although the constructor is > annotated with @ForceInline. Does the annotation make it into the class file? Either javac is failing to carry it from the constructor AST to the static init factory, or else the JVM is failing to apply it to the static init factory, or else the JIT is ignoring the bit. (Or else something else!) > The test infrastructure iterates over all methods returned by Class::getDeclaredMethods and calls > WhiteBox::testSetForceInlineMethod for those methods annotated with @ForceInline: > http://hg.openjdk.java.net/valhalla/valhalla/file/eeb82eab9c31/test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java#l528 > > Now that worked with old 'makeValue' because it's a normal method and therefore returned by > getDeclaredMethods but it does not work with the new '' constructor. Below is a little test > that shows the difference. Before, the test printed "public static MyValue1/val > MyValue1.$makeValue$(int)". Now it does not print anything. That sounds right. $makeValue$ has been renamed *and* it has been reclassified as a jlr.Constructor. > If that is expected behavior, you can go ahead and fix it like this: > > diff -r 51c89c6d10e6 test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java > --- a/test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java Fri Apr 26 23:27:18 2019 +0530 > +++ b/test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java Tue Apr 30 17:35:09 2019 +0200 > @@ -121,6 +121,7 @@ > "-XX:CompileCommand=compileonly,java.lang.invoke.*::*", > "-XX:CompileCommand=compileonly,java.lang.Long::sum", > "-XX:CompileCommand=compileonly,java.lang.Object::", > + "-XX:CompileCommand=inline,compiler.valhalla.valuetypes.MyValue*::", > "-XX:CompileCommand=compileonly,compiler.valhalla.valuetypes.*::*"}; > private static final String[] printFlags = { > "-XX:+PrintCompilation", "-XX:+PrintIdeal", "-XX:+UnlockDiagnosticVMOptions", > "-XX:+PrintOptoAssembly"}; > > I've also noticed that code compiled with -XDnoStaticInitValueFactory throws a ClassFormatError when > executed. For example, below test fails with: > > Exception in thread "main" java.lang.ClassFormatError: Method in class MyValue1 (an inline > class) has illegal modifiers: 0x1 > at java.base/java.lang.ClassLoader.defineClass1(Native Method) > at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1016) > at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:151) > at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:823) > > Best regards, > Tobias > > > import java.lang.annotation.Retention; > import java.lang.annotation.RetentionPolicy; > import java.lang.annotation.Repeatable; > import java.lang.reflect.Method; > > @Retention(RetentionPolicy.RUNTIME) > @interface ForceInline { } > > value class MyValue1 { > public final int x; > > @ForceInline > public MyValue1(int x) { > this.x = x; > } > } > > public class Test { > > public static void main(String[] args) throws Throwable { > Method[] methods = MyValue1.class.getMethods(); > for (Method m : methods) { > if (m.isAnnotationPresent(ForceInline.class)) { > System.out.println(m); > } > } > } > } From ioi.lam at oracle.com Tue Apr 30 20:27:20 2019 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Tue, 30 Apr 2019 20:27:20 +0000 Subject: hg: valhalla/valhalla: 8222989: [lworld] Calling convention - C2 to C1 (oop params) Message-ID: <201904302027.x3UKRKSA006791@aojmv0008.oracle.com> Changeset: 733920bd8bb1 Author: iklam Date: 2019-04-30 09:46 -0700 URL: http://hg.openjdk.java.net/valhalla/valhalla/rev/733920bd8bb1 8222989: [lworld] Calling convention - C2 to C1 (oop params) Reviewed-by: thartmann ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/modRefBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/z/zBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! test/hotspot/jtreg/compiler/valhalla/valuetypes/TestCallingConventionC1.java