RFR 8222384 [lworld] Calling convention - C2 to C1 (floating point params)

Tobias Hartmann tobias.hartmann at oracle.com
Mon Apr 15 07:18:42 UTC 2019


Hi Ioi,

On 14.04.19 07:28, Ioi Lam wrote:
> Actually, please ignore this webrev.
> 
> I just realized that when shuffling the arguments, the stack may shrink (e.g., if a value argument
> has 2 int fields) or expand (e.g., if a value argument has 2 float fields). Also, there can be
> circular dependencies between the vmreg slots.  So I need to rewrite the whole thing to mirror
> unpack_value_args() :-(

Right, I should have mentioned that but thought you were going to address it in another patch. I
think it would be good if the logic in MacroAssembler::unpack_value_args and ::unpack_value_helper
could be adapted to support unpacking *and* packing.

Thanks,
Tobias



More information about the valhalla-dev mailing list