hg: valhalla/valhalla: 8222634: [lworld] Javac sometimes emits incorrect ('Q') descriptors for fields.

[Srikanth]

On 17/04/19 6:46 PM, Tobias Hartmann wrote:
> On 17.04.19 15:13, Brian Goetz wrote:
>> On (1), I think this should be done on the basis of value set inclusion.  For reference types, null-default value types, and the nullable-projection of zero-default value types (V?), null is a member of the value set; for primitives, and for zero-default value types, it is not.  I think the compiler should not allow assignment of a value that is not a member of the value set.
>>
>> We need better terminology….I said value and null too many times in the above paragraph.
> Yes, in the bug report I'm referring to V? (V.box) that should allow null assignments. V (V.val)
> should not allow null.

Cool. I may have conflated that with a private mail I received that I am 
unable to locate at the moment that called for the compiler not 
performing these checks at all. But I see Brian's clarification on this 
topic that settles it for me.

BTW, that same change set also fixes the null mixin issues with V? - 
these compile now. I have pushed additional tests for this just now.

So, ATM, the only issue open is the new ValueType?[42] array creation 
syntax not being accepted. Working on it.

Thanks
Srikanth
>
> Best regards,
> Tobias