RFR(L): JDK-8222525 : [lworld] Runtime support for LW2 Arrays

David Simms david.simms at oracle.com
Fri Apr 26 07:51:38 UTC 2019


Thanks for the review, it was a lot to grok, typo fixed

Cheers
/D

On 24/04/19 8:54 PM, Frederic Parain wrote:
> Looks good.
>
> Two minor points:
>
> ciReplay.cpp:916:
>    Could the resolution fail? If yes, what would be the consequences?
>
> oopFactory.hpp:76
>    typo: of -> if
>
> Thanks for doing this huge re-work of value arrays.
>
> Fred
>
>> On Apr 16, 2019, at 04:46, David Simms <david.simms at oracle.com> wrote:
>>
>>
>> Please review runtime support for LW2 array covariance[1]:
>>
>> http://cr.openjdk.java.net/~dsimms/valhalla/lw2_arrays/webrev5/
>>
>> Further testing is needed, but requires javac (for ease of writing)
>>
>> /David Simms
>>
>> [1] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-April/005600.html
>>




More information about the valhalla-dev mailing list