RFR: 8234633 [lworld] Create fast path for aaload/aastore of inlined values

David Simms david.simms at oracle.com
Tue Dec 3 09:15:08 UTC 2019


Thanks for looking at this Frederic, good spotting the at_rsp short 
hand, comment applied

On 2/12/19 4:40 pm, Frederic Parain wrote:
> Looks good to me.
>
> Minor style comment:
>
> interp_masm_x86.cpp:1285
>
> could be re-written:
>
> movptr(at_rsp(), obj);
>
> Fred
>
>
>> On Nov 27, 2019, at 11:13, David Simms <david.simms at oracle.com> wrote:
>>
>>
>> Bug/RFE: https://bugs.openjdk.java.net/browse/JDK-8234633
>>
>> Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8234633/webrev0/
>>
>>
>> Continued hand rolling assembler, new for aaload and aastore.
>>
>> Added "MacroAssembler::data_for_value_array_index()" provides similar operation to "valueArrayOopDesc::value_at_addr".
>>
>>
>> /David Simms
>>
>>
>>



More information about the valhalla-dev mailing list