RFR 8218919 [lworld] C1 aastore of flattened array needs null and type check

[Tobias Hartmann]

Hi Ioi,

this looks good to me. Thanks for fixing/extending the tests.

Best regards,
Tobias

On 14.02.19 02:08, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8218919
> http://cr.openjdk.java.net/~iklam/valhalla/8218919-aastore-null-and-type-check.v01/
> 
> With this fix, when necessary, null check/type check are performed
> when storing a value (rdx) into a flattened array (rsi). See instructions 114~123
> 
> 114: mov    0x8(%rdx),%edi           ; implicit exception: dispatches to L_4+137 = 1193
> 117: cmp    $0x60268,%edi            ; {metadata('InlineStore1$V')}
> 123: jne     L_5                     ; runtime_call throw_array_store_exception
> 
> 129: mov    $0x0,%rdi
> 139: lea    0x10(%rsi,%rdi,1),%rsi
> 
> 144: mov    0x10(%rdx),%edi
> 147: mov    %edi,(%rsi)
> 149: mov    0x14(%rdx),%edi
> 152: mov    %edi,0x4(%rsi)
> 
> -----
> 
> Also fixed a few minor issues.
> 
> Thanks
> 
> Ioi
>