RFR 8224944 [lworld] TestCallingConventionC1::test63 fails with -Xcomp

[Ioi Lam]

Hi Tobias,

Thanks for the review. I will fix the following and push.

- Ioi

On 7/8/19 12:01 AM, Tobias Hartmann wrote:
> Hi Ioi,
>
> Looks good!
>
> Some small things:
> - I think you've missed some debug code in c1_LIRAssembler.cpp:661.
> - sharedRuntime.cpp:2841 Excess whitespace after "!="
> - sharedRuntime.cpp:2844 inset -> insert
>
> Best regards,
> Tobias
>
> On 08.07.19 08:09, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8224944
>> http://cr.openjdk.java.net/~iklam/valhalla/8224944-c1-incorrect-vvep-ro-sharing.v01/
>>
>> C1 tries to save space by avoiding the generation of the VVEP(RO) entry. However,
>> in some cases we cannot re-use the VEP for VVEP(RO) -- when some parameters are
>> passed on the stack, VEP has reserved entries, but VVEP(RO) doesn't.
>>
>> I also fixed the printing of the nmethod entry point names after merging with
>> JDK-8213084 (Rework and enhance Print[Opto]Assembly output).
>>
>> Thanks
>> - Ioi
>>
>>
>>
>>