From tobias.hartmann at oracle.com Fri Nov 1 14:39:53 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Fri, 01 Nov 2019 14:39:53 +0000 Subject: hg: valhalla/valhalla: 8233297: [lworld] runtime/NMT/ShutdownTwice.java fails with assert(*_lock >= 0) failed: Can not content exclusive lock Message-ID: <201911011439.xA1Edsod021452@aojmv0008.oracle.com> Changeset: e446f0575631 Author: thartmann Date: 2019-11-01 15:39 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e446f0575631 8233297: [lworld] runtime/NMT/ShutdownTwice.java fails with assert(*_lock >= 0) failed: Can not content exclusive lock ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/share/code/codeBlob.cpp ! src/hotspot/share/code/codeBlob.hpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/valueKlass.cpp ! src/hotspot/share/oops/valueKlass.hpp ! src/hotspot/share/runtime/init.cpp From tobias.hartmann at oracle.com Mon Nov 4 08:27:06 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Mon, 04 Nov 2019 08:27:06 +0000 Subject: hg: valhalla/valhalla: 8233464: [lworld] C2 compilation fails with assert(t->meet(t0) == t) failed: Not monotonic Message-ID: <201911040827.xA48R6wr001141@aojmv0008.oracle.com> Changeset: 6a17a9c61bfb Author: thartmann Date: 2019-11-04 09:26 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6a17a9c61bfb 8233464: [lworld] C2 compilation fails with assert(t->meet(t0) == t) failed: Not monotonic ! src/hotspot/share/opto/parse1.cpp From tobias.hartmann at oracle.com Tue Nov 5 15:29:35 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Tue, 05 Nov 2019 15:29:35 +0000 Subject: hg: valhalla/valhalla: 8233415: [lworld] VM crashes with assert(region != __null) failed: No region for 0x00000005d56dd5f0 Message-ID: <201911051529.xA5FTahv022160@aojmv0008.oracle.com> Changeset: fc4ba9e8ef73 Author: thartmann Date: 2019-11-05 16:29 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fc4ba9e8ef73 8233415: [lworld] VM crashes with assert(region != __null) failed: No region for 0x00000005d56dd5f0 ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp + test/hotspot/jtreg/compiler/valhalla/valuetypes/TestStressReturnBuffering.java From tobias.hartmann at oracle.com Thu Nov 7 11:09:25 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Thu, 07 Nov 2019 11:09:25 +0000 Subject: hg: valhalla/valhalla: 8233076: [lworld] C2 compilation fails in PhaseCFG::insert_anti_dependences Message-ID: <201911071109.xA7B9Qhp012680@aojmv0008.oracle.com> Changeset: 8c36d088de94 Author: thartmann Date: 2019-11-07 12:08 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8c36d088de94 8233076: [lworld] C2 compilation fails in PhaseCFG::insert_anti_dependences ! src/hotspot/share/opto/compile.cpp From david.simms at oracle.com Fri Nov 8 07:56:57 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Fri, 08 Nov 2019 07:56:57 +0000 Subject: hg: valhalla/valhalla: 90 new changesets Message-ID: <201911080757.xA87v3W9026457@aojmv0008.oracle.com> Changeset: f547a06da806 Author: shade Date: 2019-10-31 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f547a06da806 8233303: Shenandoah: verifier assert erroneously uses byte_size_in_exact_unit Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Changeset: 27c2d2a4b695 Author: vjovanovic Date: 2019-10-28 15:03 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/27c2d2a4b695 8232806: Introduce a system property to disable eager lambda initialization Reviewed-by: briangoetz, mr, psandoz, forax ! src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! test/langtools/tools/javac/lambda/lambdaExpression/LambdaTest6.java ! test/langtools/tools/javac/lambda/methodReference/BridgeMethod.java Changeset: ca70299778b9 Author: alanb Date: 2019-10-31 16:45 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ca70299778b9 8205132: Degrade Thread.countStackFrames() to throw UOE Reviewed-by: mchung, dholmes, dcubed ! make/hotspot/symbols/symbols-unix ! src/hotspot/share/include/jvm.h ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/native/libjava/Thread.c - test/hotspot/jtreg/runtime/Thread/CountStackFramesAtExit.java + test/jdk/java/lang/Thread/CountStackFrames.java Changeset: 5f1fe5971ff9 Author: dfuchs Date: 2019-10-31 19:31 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5f1fe5971ff9 8231631: sun/net/ftp/FtpURLConnectionLeak.java fails intermittently with NPE Summary: sun/net/www/ftptest/FtpCommandHandler.java is modified to handle EOF properly Reviewed-by: chegar, vtewari ! test/jdk/sun/net/www/ftptest/FtpCommandHandler.java Changeset: c440a6b4e096 Author: bobv Date: 2019-10-31 19:32 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c440a6b4e096 8227006: [linux] Runtime.availableProcessors execution time increased by factor of 100 Reviewed-by: dholmes, sgehwolf, redestad ! src/hotspot/os/linux/osContainer_linux.cpp ! src/hotspot/os/linux/osContainer_linux.hpp Changeset: 8c0e8cff877f Author: goetz Date: 2019-10-29 15:08 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8c0e8cff877f 8232921: assert(is_object_aligned(result)) failed: address not aligned Reviewed-by: coleenp, rschmelter ! src/hotspot/share/classfile/javaClasses.cpp Changeset: 1a8d65e71a66 Author: amenkov Date: 2019-10-31 14:23 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1a8d65e71a66 8224159: JDWP IPv6 scope support Reviewed-by: sspitsyn, cjplummer ! make/lib/Lib-jdk.jdwp.agent.gmk ! src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c ! test/jdk/com/sun/jdi/JdwpAttachTest.java ! test/jdk/com/sun/jdi/JdwpListenTest.java Changeset: aec7bf35d6f5 Author: dlong Date: 2019-10-31 16:54 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/aec7bf35d6f5 8233273: Update Graal Reviewed-by: kvn ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/EconomicMap.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/EconomicSet.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/Equivalence.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/MapCursor.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/Pair.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/UnmodifiableEconomicMap.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/UnmodifiableEconomicSet.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/UnmodifiableMapCursor.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.collections/src/jdk/internal/vm/compiler/collections/package-info.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/ComparableWord.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/LocationIdentity.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/Pointer.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/PointerBase.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/SignedWord.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/UnsignedWord.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/WordBase.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/WordFactory.java ! src/jdk.internal.vm.compiler/share/classes/jdk.internal.vm.compiler.word/src/jdk/internal/vm/compiler/word/package-info.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.replacements/src/org/graalvm/compiler/api/replacements/MethodSubstitution.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.replacements/src/org/graalvm/compiler/api/replacements/MethodSubstitutionRegistry.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.test/src/org/graalvm/compiler/api/test/ExportingClassLoader.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.test/src/org/graalvm/compiler/api/test/ModuleSupport.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64MacroAssembler.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64.test/src/org/graalvm/compiler/core/aarch64/test/AArch64MultiplyLongTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64NodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64NodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/GraalOptions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/AbstractBlockBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/AbstractControlFlowGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/Loop.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/IntegerStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.sparc/src/org/graalvm/compiler/core/sparc/SPARCNodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/BoxingEliminationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CheckGraalInvariants.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CompareCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CompareCanonicalizerTest2.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CompareCanonicalizerTest3.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationMulTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTest10.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTest14.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTest15.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTest16.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTest2.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CountedLoopTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/DeMorganCanonicalizationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/DegeneratedLoopsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/EnumSwitchTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/FinalizableSubclassTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/FloatingReadTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GraalCompilerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GraphEncoderTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GuardPrioritiesTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/IfCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ImplicitNullCheckTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/IntegerEqualsCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/InterfaceMethodHandleTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/InvokeExceptionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/InvokeHintsTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/LateMembarInsertionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/LockEliminationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/LongNodeChainTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/LoopFullUnrollTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/LoopUnswitchTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/MarkUnsafeAccessTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/MemoryGraphCanonicalizeTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/MemoryScheduleTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/MergeCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/MonitorGraphTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/NodePropertiesTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/PushNodesThroughPiTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/PushThroughIfTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ReadAfterCheckCastTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ReassociateAndCanonicalTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ScalarTypeSystemTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/SchedulingTest2.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/StampCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/StraighteningTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/SwitchCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/SwitchDyingLoopTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/SwitchFoldingTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/TypeSystemTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnsafeReadEliminationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnsafeVirtualizationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnusedArray.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/deopt/CompiledMethodTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EATestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EarlyReadEliminationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EscapeAnalysisTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PEAReadEliminationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PartialEscapeAnalysisIterationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PartialEscapeAnalysisTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PartialEscapeAnalysisTreesTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/PoorMansEATest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/TrufflePEATest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/UnsafeEATest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/inlining/InliningTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/inlining/NestedLoopEffectsPhaseComplexityTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/NodeMatchRules.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/BaseTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/EconomyHighTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/EconomyLowTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/EconomyMidTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/HighTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/LowTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/MidTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorld.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/ConstantPoolSubstitutionsTests.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/DeferredBarrierAdditionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HotSpotCryptoSubstitutionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HotSpotInvokeDynamicPluginTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/ReplaceConstantNodesPhaseTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/TestSHASubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/WriteBarrierAdditionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotReplacementsImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/SymbolicSnippetEncoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotHostForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotSuitesProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/BeginLockScopeNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/EndLockScopeNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/StubForeignCallNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/InitializeKlassNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/InitializeKlassStubCall.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/ResolveDynamicConstantNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/aot/ResolveDynamicStubCall.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/AheadOfTimeVerificationPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/IdentityHashCodeNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHA2Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHA5Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHASubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/ForeignCallStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/SnippetStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BytecodeParser.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/FrameStateBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/backend/LargeConstantSectionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/except/UntrustedInterfaces.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/optimize/NestedLoop_EA.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/optimize/TrichotomyTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ArithmeticOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Move.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64StringLatin1InflateOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64StringUTF16CompressOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorMove.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/LIRIntrospection.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/alloc/lsra/LinearScanLifetimeAnalysisPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/ConvertDeoptimizeToGuardPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/LoopPeelingPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/LoopTransformations.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.test/src/org/graalvm/compiler/loop/test/LoopPartialUnrollTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/CountedLoopInfo.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DefaultLoopPolicies.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopEx.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragment.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragmentInside.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopPolicies.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/MathUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.microbenchmarks/src/org/graalvm/compiler/microbenchmarks/graal/GraalBenchmark.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.microbenchmarks/src/org/graalvm/compiler/microbenchmarks/graal/TestJMHWhitebox.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes.test/src/org/graalvm/compiler/nodes/test/IfNodeCanonicalizationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes.test/src/org/graalvm/compiler/nodes/test/LoopPhiCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes.test/src/org/graalvm/compiler/nodes/test/ShortCircuitOrNodeTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/FrameState.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GuardProxyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/IfNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/InvokeNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/InvokeWithExceptionNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/KillingBeginNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/LoopBeginNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/MemoryProxyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/ProxyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/StartNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/StructuredGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/ValueProxyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/AndNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/BinaryArithmeticNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/CompareNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/OrNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/XorNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/cfg/Block.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/cfg/ControlFlowGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/debug/StringToBytesNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/BytecodeExceptionNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/ForeignCallNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/JavaWriteNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/MembarNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/RawLoadNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/RawStoreNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/SwitchNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/UnsafeAccessNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/UnsafeMemoryStoreNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderConfiguration.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/InvocationPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/MethodSubstitutionPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/AbstractCompareAndSwapNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/AbstractUnsafeCompareAndSwapNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/AtomicReadAndAddNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/AtomicReadAndWriteNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/ExceptionObjectNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/LoweredAtomicReadAndWriteNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/MonitorEnterNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/MonitorExitNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/RawMonitorEnterNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/FixedAccessNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/MemoryCheckpoint.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/VolatileReadNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/WriteNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/DelegatingReplacements.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/Replacements.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/util/GraphUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/virtual/AllocatedObjectNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/virtual/CommitAllocationNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/CanonicalizerPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConditionalEliminationPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/FloatingReadPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/GuardLoweringPhase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/InsertMembarsPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/LoweringPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/inlining/InliningUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/inlining/info/MultiTypeGuardInlineInfo.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/schedule/MemoryScheduleVerification.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/schedule/SchedulePhase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/schedule/ScheduleVerification.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64CountLeadingZerosNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64CountTrailingZerosNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64IntegerSubstitutions.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64LongSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringLatin1InflateNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringUTF16CompressNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.jdk9.test/src/org/graalvm/compiler/replacements/jdk9/test/VarHandleTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.sparc/src/org/graalvm/compiler/replacements/sparc/SPARCGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/ArraysSubstitutionsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/BitOpNodesTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/DeoptimizeOnExceptionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/EdgesTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/FoldTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/IntegerExactFoldTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/MethodSubstitutionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/ObjectAccessTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/PEGraphDecoderTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/PointerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/ReplacementsParseTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StandardMethodSubstitutionsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/SubstitutionNodeSourcePositionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/SubstitutionsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/classfile/ClassfileBytecodeProviderTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/classfile/RedefineIntrinsicTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/CachingPEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/DefaultJavaLoweringProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/NodeIntrinsificationProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ReplacementsImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetTemplate.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/TargetGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopyCallNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/CheckcastArrayCopyCallNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/GenericArrayCopyCallNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/BasicArrayCopyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/MacroNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/MacroStateSplitNode.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ExportingClassLoader.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ModuleSupport.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/PEReadEliminationClosure.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/ReadEliminationBlockState.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/ReadEliminationClosure.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.util/src/org/graalvm/util/OptionsEncoder.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.util/src/org/graalvm/util/TypedDataInputStream.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.util/src/org/graalvm/util/TypedDataOutputStream.java Changeset: 452df727bebb Author: rschmelter Date: 2019-10-15 17:08 +0200 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/452df727bebb 8232168: Fix non wide char canonicalization on Windows Reviewed-by: clanger, alanb, ccheung ! src/java.base/windows/native/libjava/canonicalize_md.c ! test/hotspot/jtreg/runtime/LoadClass/LongBCP.java Changeset: 717ebfbac29d Author: clanger Date: 2019-11-01 07:58 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/717ebfbac29d 8232980: Cleanup initialization of function pointers into java.base from classloader.cpp Reviewed-by: iklam, ccheung ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoader.hpp Changeset: 562df5d69eed Author: coleenp Date: 2019-11-01 10:04 -0400 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/562df5d69eed 8233386: Initialize NULL fields for unused decorations Reviewed-by: shade, hseigel, dcubed ! src/hotspot/share/logging/logDecorations.cpp Changeset: ab4db38ed085 Author: shade Date: 2019-11-01 16:16 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ab4db38ed085 8233387: Shenandoah: passive mode should disable pacing ergonomically Reviewed-by: zgu ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp ! src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.hpp ! src/hotspot/share/gc/shenandoah/shenandoahPassiveMode.cpp Changeset: 35bac2745d04 Author: dl Date: 2019-11-01 09:04 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/35bac2745d04 8231592: Clarify that ConcurrentHashMap compute methods mapping functions execute at most once Reviewed-by: martin ! src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java ! test/jdk/java/util/concurrent/tck/ConcurrentHashMapTest.java ! test/jdk/java/util/concurrent/tck/ConcurrentSkipListMapTest.java ! test/jdk/java/util/concurrent/tck/HashMapTest.java ! test/jdk/java/util/concurrent/tck/HashtableTest.java ! test/jdk/java/util/concurrent/tck/JSR166TestCase.java ! test/jdk/java/util/concurrent/tck/LinkedHashMapTest.java ! test/jdk/java/util/concurrent/tck/MapImplementation.java ! test/jdk/java/util/concurrent/tck/MapTest.java ! test/jdk/java/util/concurrent/tck/TreeMapTest.java Changeset: ec954ef6caf1 Author: dl Date: 2019-11-01 09:07 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ec954ef6caf1 8231026: Miscellaneous changes imported from jsr166 CVS 2019-11 Reviewed-by: martin ! src/java.base/share/classes/java/util/concurrent/CompletableFuture.java ! test/jdk/java/util/concurrent/tck/StampedLockTest.java Changeset: b95bead30957 Author: iveresov Date: 2019-11-01 09:39 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b95bead30957 8227003: Add high-level JIT compilation mode control mechanism Summary: Add tiered mode to emulate non-tiered with special mode for JVMCI compiler. Add -XX:CompilationMode option. Reviewed-by: never, redestad ! src/hotspot/share/compiler/compilerDefinitions.cpp ! src/hotspot/share/compiler/compilerDefinitions.hpp ! src/hotspot/share/compiler/tieredThresholdPolicy.cpp ! src/hotspot/share/compiler/tieredThresholdPolicy.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/compiler/profiling/spectrapredefineclass/Launcher.java ! test/hotspot/jtreg/compiler/profiling/spectrapredefineclass_classloaders/Launcher.java ! test/hotspot/jtreg/serviceability/dcmd/vm/FlagsTest.java Changeset: 42aa251d6eed Author: ccheung Date: 2019-11-01 11:31 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/42aa251d6eed 8233363: Clarify the DumpSharedSpaces condition in InstanceKlass::verify_on Summary: change DumpSharedSpaces to Arguments::is_dumping_archive(). Reviewed-by: iklam, coleenp ! src/hotspot/share/oops/instanceKlass.cpp Changeset: bd9daab73a8e Author: jboes Date: 2019-11-01 12:57 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/bd9daab73a8e 8231632: HttpURLConnection::usingProxy could specify that it may lazily evaluate the fact Summary: Modified method description to disambiguate when false is returned and altered implementation Reviewed-by: dfuchs, chegar, vtewari ! src/java.base/share/classes/java/net/HttpURLConnection.java ! src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/jdk/java/net/HttpURLConnection/HttpURLConnUsingProxy.java Changeset: 76638c631869 Author: bpb Date: 2019-11-01 13:16 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/76638c631869 8162520: (fs) FileStore should support file stores with > Long.MAX_VALUE capacity Reviewed-by: alanb, darcy, rriggs ! src/java.base/share/classes/java/nio/file/FileStore.java ! src/java.base/unix/classes/sun/nio/fs/UnixFileStore.java ! src/java.base/windows/classes/sun/nio/fs/WindowsFileStore.java Changeset: 4ec9fc2b2f0d Author: kbarrett Date: 2019-11-01 16:21 -0400 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/4ec9fc2b2f0d 8233359: Add global sized operator delete definitions Summary: Added new definitions. Reviewed-by: dholmes ! src/hotspot/share/memory/operator_new.cpp Changeset: 5573a7098439 Author: alanb Date: 2019-11-02 10:02 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5573a7098439 8232673: (dc) DatagramChannel socket adaptor issues Reviewed-by: dfuchs, chegar ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/DatagramSocketAdaptor.java - test/jdk/java/nio/channels/DatagramChannel/AdaptDatagramSocket.java + test/jdk/java/nio/channels/DatagramChannel/AdaptorBasic.java + test/jdk/java/nio/channels/DatagramChannel/AdaptorConcurrentIO.java + test/jdk/java/nio/channels/DatagramChannel/AdaptorConnect.java + test/jdk/java/nio/channels/DatagramChannel/AdaptorGetters.java ! test/jdk/java/nio/channels/etc/AdaptorCloseAndInterrupt.java Changeset: 434329f6f456 Author: alanb Date: 2019-11-03 14:07 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/434329f6f456 8233430: (sc) Socket adaptor restoring of blocking mode can override exception if socket closed Reviewed-by: dfuchs, chegar ! src/java.base/share/classes/sun/nio/ch/DummySocketImpl.java ! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java Changeset: 2700c409ff10 Author: dholmes Date: 2019-11-03 18:02 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2700c409ff10 8229516: Thread.isInterrupted() always returns false after thread termination Reviewed-by: dnsimon, sspitsyn, dcubed, alanb ! make/hotspot/symbols/symbols-unix ! src/hotspot/os/windows/osThread_windows.cpp ! src/hotspot/os/windows/osThread_windows.hpp ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/jvmci/jvmciRuntime.cpp ! src/hotspot/share/jvmci/jvmciRuntime.hpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/runtime/osThread.cpp ! src/hotspot/share/runtime/osThread.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/native/libjava/Thread.c ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/OSThread.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/HotSpotMethodSubstitutionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotReplacementsUtil.java Changeset: 197238c30630 Author: weijun Date: 2019-11-04 14:26 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/197238c30630 8231950: keytool -ext camel-case shorthand not working Reviewed-by: mullan ! src/java.base/share/classes/sun/security/tools/keytool/Main.java + test/jdk/sun/security/tools/keytool/ExtOptionCamelCase.java ! test/jdk/sun/security/tools/keytool/KeyToolTest.java Changeset: eeb1c0da2126 Author: jlahoda Date: 2019-11-04 09:40 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/eeb1c0da2126 8229815: Upgrade Jline to 3.12.1 Reviewed-by: rfield ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/keymap/BindingReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/keymap/KeyMap.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Binding.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Buffer.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Candidate.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Completer.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/CompletingParsedLine.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/EndOfFileException.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Expander.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Highlighter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/History.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReaderBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Macro.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/MaskingCallback.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/ParsedLine.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Parser.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Reference.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/UserInterruptException.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Widget.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/BufferImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultExpander.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultHighlighter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultParser.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/KillRing.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/LineReaderImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/ReaderUtils.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/SimpleMaskingCallback.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/UndoTree.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/AggregateCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/ArgumentCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/EnumCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/FileNameCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/NullCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/StringsCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/package-info.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/history/DefaultHistory.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/history/package-info.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/package-info.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/Attributes.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/Cursor.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/MouseEvent.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/Size.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/Terminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/TerminalBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractPosixTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractPty.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractWindowsConsoleWriter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractWindowsTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/CursorSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/DumbTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ExecPty.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/ExternalTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/LineDisciplineTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/MouseSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/NativeSignalHandler.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/PosixPtyTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/PosixSysTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/package-info.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JansiSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JnaSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/Pty.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedCharSequence.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedString.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedStringBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedStyle.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/ClosedException.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Colors.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Curses.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/DiffHelper.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Display.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/ExecHelper.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/InfoCmp.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/InputStreamReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Levenshtein.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Log.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlocking.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingInputStream.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingInputStreamImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpInputStream.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingReaderImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/OSUtils.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/PumpReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/ShutdownHooks.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Signals.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Status.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/StyleResolver.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/WCWidth.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/WriterOutputStream.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/capabilities.txt ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/colors.txt + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/dumb-colors.caps ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/package-info.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/windows-conemu.caps ! src/jdk.internal.le/share/legal/jline.md ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/JnaSupportImpl.java ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinConsoleWriter.java ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinSysTerminal.java ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/Kernel32.java ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/WindowsAnsiWriter.java Changeset: 1f7981ef8779 Author: mbaesken Date: 2019-11-04 09:54 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1f7981ef8779 8233078: fix minimal VM build on Linux ppc64(le) Reviewed-by: mdoerr, lucy ! src/hotspot/cpu/ppc/c1_globals_ppc.hpp ! src/hotspot/cpu/ppc/disassembler_ppc.cpp ! src/hotspot/cpu/ppc/globalDefinitions_ppc.hpp ! src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp ! src/hotspot/cpu/ppc/stubGenerator_ppc.cpp ! src/hotspot/cpu/ppc/vm_version_ppc.cpp Changeset: 75eedcd30a2a Author: mbaesken Date: 2019-10-30 14:52 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/75eedcd30a2a 8233202: exclude javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java Reviewed-by: clanger ! test/jdk/ProblemList.txt Changeset: d58a21542c04 Author: jlahoda Date: 2019-11-04 10:58 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d58a21542c04 8230847: Trees.getScope may crash when invoked for statement inside switch. Summary: More thoroughly avoiding side-effects when attributing (to) for Trees.getScope. Reviewed-by: mcimadamore ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Analyzer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! test/langtools/tools/javac/api/TestGetScopeResult.java Changeset: 2507757e9ef7 Author: chegar Date: 2019-11-04 10:06 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2507757e9ef7 8232367: Update the jdk/java/net/httpclient tests to RS TCK 1.0.3 Reviewed-by: dfuchs ! test/jdk/java/net/httpclient/reactivestreams-tck/org/reactivestreams/tck/SubscriberWhiteboxVerification.java Changeset: 73bb9c4002cc Author: ihse Date: 2019-11-04 11:12 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/73bb9c4002cc 8233381: Update copyright year in build system files Reviewed-by: erikj ! make/CompileToolsJdk.gmk ! make/Coverage.gmk ! make/GenerateLinkOptData.gmk ! make/MainSupport.gmk ! make/ModuleWrapper.gmk ! make/RunTestsPrebuiltSpec.gmk ! make/TestImage.gmk ! make/ZipSecurity.gmk ! make/common/JdkNativeCompilation.gmk ! make/common/ProcessMarkdown.gmk ! make/common/RMICompilation.gmk ! make/common/SetupJavaCompilers.gmk ! make/copy/Copy-jdk.crypto.cryptoki.gmk ! make/copy/Copy-jdk.crypto.ucrypto.gmk ! make/devkit/Tools.gmk ! make/gendata/GendataBlacklistedCerts.gmk ! make/gendata/GendataBreakIterator.gmk ! make/gendata/GendataPublicSuffixList.gmk ! make/gensrc/Gensrc-java.desktop.gmk ! make/gensrc/Gensrc-jdk.hotspot.agent.gmk ! make/gensrc/Gensrc-jdk.jlink.gmk ! make/gensrc/GensrcBuffer.gmk ! make/gensrc/GensrcCharacterData.gmk ! make/gensrc/GensrcCharsetCoder.gmk ! make/gensrc/GensrcIcons.gmk ! make/gensrc/GensrcVarHandles.gmk ! make/hotspot/CopyToExplodedJdk.gmk ! make/hotspot/lib/CompileDtraceLibraries.gmk ! make/hotspot/lib/JvmDtraceObjects.gmk ! make/hotspot/lib/JvmFlags.gmk ! make/hotspot/lib/JvmMapfile.gmk ! make/hotspot/test/GtestImage.gmk ! make/launcher/Launcher-java.security.jgss.gmk ! make/launcher/Launcher-jdk.pack.gmk ! make/lib/CoreLibraries.gmk ! make/lib/Lib-java.instrument.gmk ! make/lib/Lib-java.management.gmk ! make/lib/Lib-java.prefs.gmk ! make/lib/Lib-jdk.accessibility.gmk ! make/lib/Lib-jdk.attach.gmk ! make/lib/Lib-jdk.crypto.mscapi.gmk ! make/lib/Lib-jdk.crypto.ucrypto.gmk ! make/lib/Lib-jdk.internal.le.gmk ! make/lib/Lib-jdk.jdi.gmk ! make/lib/Lib-jdk.management.gmk ! make/lib/Lib-jdk.net.gmk ! make/lib/Lib-jdk.sctp.gmk ! make/rmic/Rmic-java.management.rmi.gmk ! make/test/BuildFailureHandler.gmk ! make/test/JtregGraalUnit.gmk Changeset: 66f7d2494d4e Author: ihse Date: 2019-11-04 11:15 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/66f7d2494d4e 8233383: Various minor fixes Reviewed-by: erikj ! doc/building.html ! doc/building.md - make/GensrcModuleInfo.gmk ! make/Main.gmk ! make/UpdateBuildDocs.gmk ! make/autoconf/configure.ac ! make/autoconf/flags-cflags.m4 ! make/common/JavaCompilation.gmk + make/gensrc/GensrcModuleInfo.gmk Changeset: f61eea1869e4 Author: tschatzl Date: 2019-11-04 11:33 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f61eea1869e4 8232951: TestG1ParallelPhases.java fails with phase NonYoungFreeCSet not found Reviewed-by: lkorinth, kbarrett ! test/jdk/jdk/jfr/event/gc/collection/TestG1ParallelPhases.java Changeset: 44d60fc2dd8a Author: stooke Date: 2019-11-04 13:58 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/44d60fc2dd8a 8232973: Potential infinite loop in macOS hotspot agent Reviewed-by: stuefe, cjplummer, sspitsyn ! src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c Changeset: e2dfab7beccb Author: ysuenaga Date: 2019-11-04 22:31 +0900 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e2dfab7beccb 8233285: Demangling C++ symbols in jhsdb jstack --mixed Reviewed-by: cjplummer, sspitsyn, ihse ! make/lib/Lib-jdk.hotspot.agent.gmk - src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.c + src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.cpp ! src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h ! src/jdk.hotspot.agent/linux/native/libsaproc/proc_service.h ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/LinuxCDebugger.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebugger.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java Changeset: 6f98d0173a72 Author: coffeys Date: 2019-11-04 14:24 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6f98d0173a72 8232984: Upgrading Joni License version to 2.1.16 Reviewed-by: coffeys Contributed-by: kiran.sidhartha.ravikumar at oracle.com ! src/jdk.scripting.nashorn/share/legal/joni.md Changeset: 02ae223a11dc Author: jiefu Date: 2019-11-04 10:03 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/02ae223a11dc 8233291: [TESTBUG] tools/jlink/plugins/VendorInfoPluginsTest.java fails with debug or non-server VMs Reviewed-by: mchung ! test/jdk/tools/jlink/plugins/VendorInfoPluginsTest.java Changeset: 7298f7c503b4 Author: aph Date: 2019-11-01 06:04 -0400 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7298f7c503b4 8233232: AArch64: Shenandoah: jni_fast_GetLongField is broken Reviewed-by: shade, rkennke ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp Changeset: 33f9271b3167 Author: aph Date: 2019-11-04 13:13 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/33f9271b3167 Merge Changeset: c727d5d4c22e Author: shade Date: 2019-11-04 19:40 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c727d5d4c22e 8233520: Shenandoah: do not sleep when thread is attaching Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp Changeset: 1d1f9c43138f Author: bpb Date: 2019-11-04 11:05 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1d1f9c43138f 8233519: Put java/nio/channels/DatagramChannel/Unref.java on the problem list Reviewed-by: alanb, lancea ! test/jdk/ProblemList.txt Changeset: d67ebc838ab8 Author: bchristi Date: 2019-11-04 11:42 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d67ebc838ab8 8233091: Backout JDK-8212117: Class.forName loads a class but not linked if class is not initialized Reviewed-by: alanb, dholmes, mchung ! make/hotspot/symbols/symbols-unix ! src/hotspot/share/include/jvm.h ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvm_misc.hpp ! src/hotspot/share/runtime/globals.hpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/sun/launcher/LauncherHelper.java ! src/java.base/share/native/libjava/Class.c ! test/hotspot/jtreg/gc/logging/TestMetaSpaceLog.java - test/hotspot/jtreg/serviceability/jvmti/ClassStatus/ClassStatus.java - test/hotspot/jtreg/serviceability/jvmti/ClassStatus/libClassStatus.c Changeset: 2938e0a4e954 Author: iklam Date: 2019-11-04 12:36 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2938e0a4e954 8232734: [TESTBUG] avoid using JDK symbols in ExtraSymbols.symbols.txt Reviewed-by: ccheung ! test/hotspot/jtreg/runtime/cds/appcds/ExtraSymbols.java - test/hotspot/jtreg/runtime/cds/appcds/ExtraSymbols.symbols.txt ! test/lib/jdk/test/lib/cds/CDSTestUtils.java Changeset: c41d1303a87c Author: igerasim Date: 2019-11-04 13:02 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c41d1303a87c 8233422: Extra space in the title of the HTML javadoc page Reviewed-by: ihse, erikj ! make/Docs.gmk Changeset: 9bbe560e8131 Author: stuefe Date: 2019-10-31 07:53 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/9bbe560e8131 8233019: java.lang.Class.isPrimitive() (C1) returns wrong result if Klass* is aligned to 32bit Reviewed-by: mdoerr, dlong, aph ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp ! src/hotspot/cpu/s390/c1_LIRAssembler_s390.cpp ! src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! test/hotspot/jtreg/compiler/intrinsics/klass/TestIsPrimitive.java Changeset: ecb801342b8c Author: jiefu Date: 2019-11-05 09:37 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ecb801342b8c 8233429: Minimal and zero VM build broken after JDK-8227003 Reviewed-by: iveresov, shade, thartmann Contributed-by: igor.veresov at oracle.com, fujie at loongson.cn ! src/hotspot/share/compiler/compilerDefinitions.cpp ! src/hotspot/share/compiler/compilerDefinitions.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp Changeset: d8aced36e872 Author: redestad Date: 2019-11-05 09:57 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d8aced36e872 8233494: Avoid calling MallocTracker::record_malloc and record_free when NMT is off Reviewed-by: mdoerr, zgu ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/services/mallocTracker.cpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/services/memTracker.hpp Changeset: 707825662286 Author: redestad Date: 2019-11-05 09:58 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/707825662286 8233495: Some fieldDescriptor methods can pass existing constantPoolHandle Reviewed-by: lfoltan, coleenp ! src/hotspot/share/runtime/fieldDescriptor.inline.hpp Changeset: 03f182a0f62c Author: jiefu Date: 2019-11-05 17:02 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/03f182a0f62c 8233574: Shenandoah: build is broken without jfr Reviewed-by: rkennke, shade ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp Changeset: a4ddd1667c72 Author: dmarkov Date: 2019-11-05 10:11 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a4ddd1667c72 8232880: Update test documentation with additional settings for client UI tooltip tests Reviewed-by: aivanov, serb, ihse ! doc/testing.html ! doc/testing.md Changeset: 304c63b17b07 Author: neliasso Date: 2019-10-31 17:16 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/304c63b17b07 8232896: ZGC: Enable C2 clone intrinsic Reviewed-by: pliden, kvn ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp ! src/hotspot/share/gc/z/zBarrier.hpp ! src/hotspot/share/gc/z/zBarrier.inline.hpp ! src/hotspot/share/gc/z/zBarrierSetRuntime.cpp ! src/hotspot/share/gc/z/zBarrierSetRuntime.hpp ! src/hotspot/share/opto/arraycopynode.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/macroArrayCopy.cpp ! src/hotspot/share/opto/type.hpp ! test/micro/org/openjdk/bench/java/lang/Clone.java Changeset: 8623f75be895 Author: mdoerr Date: 2019-11-05 11:53 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8623f75be895 8233081: C1: PatchingStub for field access copies too much Reviewed-by: thartmann, dlong ! src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp ! src/hotspot/cpu/aarch64/nativeInst_aarch64.hpp ! src/hotspot/cpu/arm/nativeInst_arm_32.hpp ! src/hotspot/cpu/ppc/nativeInst_ppc.hpp ! src/hotspot/cpu/s390/nativeInst_s390.hpp ! src/hotspot/cpu/sparc/nativeInst_sparc.cpp ! src/hotspot/cpu/sparc/nativeInst_sparc.hpp ! src/hotspot/cpu/x86/nativeInst_x86.cpp ! src/hotspot/cpu/x86/nativeInst_x86.hpp ! src/hotspot/share/c1/c1_CodeStubs.hpp Changeset: cc5ac592b9e5 Author: stuefe Date: 2019-11-05 16:57 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/cc5ac592b9e5 8233530: gcc 5.4 build warning -Wc++14-compat after JDK-8233359 Reviewed-by: dholmes, goetz ! src/hotspot/share/memory/operator_new.cpp Changeset: f4b1addb9742 Author: hannesw Date: 2019-11-05 17:27 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f4b1addb9742 8232209: Update double-conversion license file to version 3.1.5 Reviewed-by: sundar ! src/jdk.scripting.nashorn/share/legal/double-conversion.md Changeset: ba99c5a4491d Author: iignatyev Date: 2019-11-05 08:57 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ba99c5a4491d 8233496: AOT tests failures with 'java.lang.RuntimeException: Failed to find sun/hotspot/WhiteBox.class' Reviewed-by: kvn, thartmann ! test/hotspot/jtreg/compiler/aot/DeoptimizationTest.java ! test/hotspot/jtreg/compiler/aot/RecompilationTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeDynamic2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeDynamic2CompiledTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeDynamic2InterpretedTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeDynamic2NativeTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeInterface2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeInterface2CompiledTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeInterface2InterpretedTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeInterface2NativeTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeSpecial2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeSpecial2CompiledTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeSpecial2InterpretedTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeSpecial2NativeTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeStatic2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeStatic2CompiledTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeStatic2InterpretedTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeStatic2NativeTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeVirtual2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeVirtual2CompiledTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeVirtual2InterpretedTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromAot/AotInvokeVirtual2NativeTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromCompiled/CompiledInvokeDynamic2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromCompiled/CompiledInvokeInterface2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromCompiled/CompiledInvokeSpecial2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromCompiled/CompiledInvokeStatic2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromCompiled/CompiledInvokeVirtual2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromInterpreted/InterpretedInvokeDynamic2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromInterpreted/InterpretedInvokeInterface2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromInterpreted/InterpretedInvokeSpecial2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromInterpreted/InterpretedInvokeStatic2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromInterpreted/InterpretedInvokeVirtual2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromNative/NativeInvokeSpecial2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromNative/NativeInvokeStatic2AotTest.java ! test/hotspot/jtreg/compiler/aot/calls/fromNative/NativeInvokeVirtual2AotTest.java ! test/hotspot/jtreg/compiler/aot/fingerprint/SelfChangedCDS.java Changeset: 358783d2ba0b Author: iveresov Date: 2019-11-05 09:59 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/358783d2ba0b 8233590: Compiler thread creation fails with assert(_c2_count > 0 || _c1_count > 0) failed: No compilers? Summary: Handle the case with -XX:-TieredCompilation properly Reviewed-by: shade, thartmann Contributed-by: fujie at loongson.cn ! src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp Changeset: e767fa6a1d45 Author: aoqi Date: 2019-11-06 01:45 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e767fa6a1d45 8233608: Minimal build broken after JDK-8233494 Reviewed-by: shade ! src/hotspot/share/services/memTracker.hpp Changeset: 00878bee8f4b Author: lancea Date: 2019-11-05 14:54 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/00878bee8f4b 8233622: (zipfs) open/test/jdk/jdk/nio/zipfs/CopyMoveTests.java has incorrect bug label Reviewed-by: rriggs ! test/jdk/jdk/nio/zipfs/CopyMoveTests.java Changeset: 5db99b3d6023 Author: dholmes Date: 2019-11-05 18:42 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5db99b3d6023 8233599: ARM32 Build failed due to 8232050 missing an include Reviewed-by: dholmes Contributed-by: Markus Knetschke ! src/hotspot/cpu/arm/vtableStubs_arm.cpp Changeset: e940d13a2ed3 Author: igerasim Date: 2019-11-05 20:27 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e940d13a2ed3 8233650: Javadoc for Math.floorMod(int, int) gives wrong example Reviewed-by: bpb ! src/java.base/share/classes/java/lang/Math.java Changeset: bb2a436e616c Author: jiefu Date: 2019-11-06 13:43 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/bb2a436e616c 8233659: [TESTBUG] runtime/cds/appcds/CommandLineFlagCombo.java fails when jfr is disabled Reviewed-by: iklam ! test/hotspot/jtreg/runtime/cds/appcds/CommandLineFlagCombo.java Changeset: a3b046720c3b Author: ysuenaga Date: 2019-11-06 21:49 +0900 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a3b046720c3b 8233375: JFR emergency dump does not recover thread state Reviewed-by: dholmes, mgronlun ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp Changeset: 83810b7d12e7 Author: zgu Date: 2019-11-06 09:50 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/83810b7d12e7 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code Reviewed-by: aph, shade, rkennke ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp Changeset: d5156218928d Author: shade Date: 2019-11-06 16:52 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d5156218928d 8233695: AArch64 build failures after -Wno-extra removal Reviewed-by: aph ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp Changeset: a2987e18475d Author: bulasevich Date: 2019-11-06 19:27 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a2987e18475d 8233600: Cross-builds fails after JDK-8233285 Reviewed-by: shade, erikj ! make/lib/Lib-jdk.hotspot.agent.gmk Changeset: 898d548e91f5 Author: bulasevich Date: 2019-11-06 19:37 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/898d548e91f5 8231955: ARM32: Address displacement is 0 for volatile field access because of Unsafe field access. Reviewed-by: dlong Contributed-by: christoph.goettschkes at microdoc.com ! src/hotspot/cpu/arm/c1_LIRGenerator_arm.cpp Changeset: d6e682e8fcc3 Author: xuelei Date: 2019-11-06 09:45 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d6e682e8fcc3 8223940: Private key not supported by chosen signature algorithm Reviewed-by: valeriep ! src/java.base/share/classes/sun/security/ssl/CertificateVerify.java ! src/java.base/share/classes/sun/security/ssl/DHServerKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/ECDHServerKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/SignatureScheme.java Changeset: 5cf915f418f2 Author: igerasim Date: 2019-11-06 09:45 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5cf915f418f2 8233658: Escape + in the expression describing Runtime.Version string Reviewed-by: naoto ! src/java.base/share/classes/java/lang/Runtime.java Changeset: 38d4202154f2 Author: jiefu Date: 2019-11-06 15:20 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/38d4202154f2 8233671: [TESTBUG] runtime/cds/appcds/sharedStrings/FlagCombo.java fails to compile without jfr Reviewed-by: iklam ! test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/FlagCombo.java Changeset: 5bc2e9c9604d Author: shade Date: 2019-11-06 19:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5bc2e9c9604d 8233698: GCC 4.8.5 build failure after JDK-8233530 Reviewed-by: stuefe, dholmes, kbarrett ! src/hotspot/share/memory/operator_new.cpp Changeset: dfd5196652dd Author: jwilhelm Date: 2019-11-07 03:01 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/dfd5196652dd Added tag jdk-14+22 for changeset 83810b7d12e7 ! .hgtags Changeset: 9a0a5e70eeb2 Author: dholmes Date: 2019-11-06 21:18 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/9a0a5e70eeb2 8233454: Test fails with assert(!is_init_completed(), "should only happen during init") after JDK-8229516 Reviewed-by: jiefu, dcubed ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/runtime/thread.cpp Changeset: 00244fd3169a Author: thartmann Date: 2019-11-07 07:02 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/00244fd3169a 8233491: Crash in AdapterHandlerLibrary::get_adapter with CDS due to code cache exhaustion Summary: Added null check. Reviewed-by: kvn, iklam ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: 7bfe7df764a2 Author: neliasso Date: 2019-11-07 09:23 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7bfe7df764a2 8233783: Make 8232896 patch complete Reviewed-by: pliden, kvn ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp ! src/hotspot/share/gc/z/zBarrier.hpp ! src/hotspot/share/gc/z/zBarrier.inline.hpp ! src/hotspot/share/gc/z/zBarrierSetRuntime.cpp ! src/hotspot/share/gc/z/zBarrierSetRuntime.hpp Changeset: b7b170ba3ba9 Author: mbaesken Date: 2019-11-06 14:04 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b7b170ba3ba9 8233328: fix minimal VM build on Linux s390x Reviewed-by: lucy, mdoerr ! src/hotspot/cpu/s390/compiledIC_s390.cpp ! src/hotspot/cpu/s390/disassembler_s390.cpp ! src/hotspot/cpu/s390/macroAssembler_s390.cpp ! src/hotspot/cpu/s390/macroAssembler_s390.hpp ! src/hotspot/cpu/s390/sharedRuntime_s390.cpp ! src/hotspot/cpu/s390/vm_version_s390.cpp ! src/hotspot/os_cpu/linux_s390/os_linux_s390.cpp Changeset: f79a8217d4c9 Author: roland Date: 2019-10-22 11:55 +0200 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f79a8217d4c9 8232539: SIGSEGV in C2 Node::unique_ctrl_out Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/ifnode.cpp Changeset: 5d462d4b7a8b Author: eosterlund Date: 2019-11-07 10:28 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5d462d4b7a8b 8233073: Make BitMap accessors more memory ordering friendly Reviewed-by: kbarrett, pliden ! src/hotspot/share/c1/c1_Instruction.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/utilities/bitMap.hpp ! src/hotspot/share/utilities/bitMap.inline.hpp Changeset: 2dcfc28a314d Author: redestad Date: 2019-11-07 12:12 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2dcfc28a314d 8233708: VectorSet cleanup Reviewed-by: neliasso, shade, thartmann ! src/hotspot/share/ci/bcEscapeAnalyzer.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp - src/hotspot/share/libadt/set.cpp - src/hotspot/share/libadt/set.hpp ! src/hotspot/share/libadt/vectset.cpp ! src/hotspot/share/libadt/vectset.hpp ! src/hotspot/share/opto/chaitin.cpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/opto/gcm.cpp ! src/hotspot/share/opto/idealGraphPrinter.cpp ! src/hotspot/share/opto/ifg.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopopts.cpp ! src/hotspot/share/opto/matcher.cpp ! src/hotspot/share/opto/node.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/phaseX.hpp ! src/hotspot/share/opto/stringopts.cpp ! src/hotspot/share/opto/superword.hpp ! test/hotspot/gtest/utilities/test_population_count.cpp Changeset: b9ce8d09bfd4 Author: dholmes Date: 2019-11-07 07:53 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b9ce8d09bfd4 8233784: ProblemList failing JVMTI scenario tests Reviewed-by: goetz ! test/hotspot/jtreg/ProblemList.txt Changeset: 029d941c2e35 Author: zgu Date: 2019-11-07 09:41 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/029d941c2e35 8233796: Shenandoah is broken after 8233708 Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp Changeset: 86c8b22945a1 Author: pliden Date: 2019-11-07 15:48 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/86c8b22945a1 8233793: ZGC: Incorrect type used in ZBarrierSetC2 clone_type() Reviewed-by: eosterlund ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp Changeset: 6c6cce0f149d Author: mgronlun Date: 2019-11-07 15:53 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6c6cce0f149d 8233416: JFR: assert((((((klass)->trace_id()) & (((1 << 1) << 8) | (JfrTraceIdEpoch::in_use_this_epoch_bit()))) != 0))) failed: invariant Reviewed-by: egahlin ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp Changeset: 3c2e49d43ba3 Author: mgronlun Date: 2019-11-07 15:56 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3c2e49d43ba3 8232905: JFR fails with assertion: assert(t->unflushed_size() == 0) failed: invariant Reviewed-by: egahlin ! src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp Changeset: 7f1daafda27b Author: dfuchs Date: 2019-11-07 16:18 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7f1daafda27b 8233403: Improve verbosity of some httpclient tests Summary: improve the verbosity of some httpclient tests to help diagnosis of intermittent failures. Also fixes ShortRequestBody test. Reviewed-by: chegar ! test/jdk/java/net/httpclient/AbstractThrowingPublishers.java ! test/jdk/java/net/httpclient/AbstractThrowingPushPromises.java ! test/jdk/java/net/httpclient/AbstractThrowingSubscribers.java ! test/jdk/java/net/httpclient/ShortRequestBody.java ! test/jdk/java/net/httpclient/ShortResponseBody.java Changeset: a4430bb9f97d Author: naoto Date: 2019-11-07 10:06 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a4430bb9f97d 8233579: DateFormatSymbols.getShortMonths() return wrong string on es_CL, es_CO locales Reviewed-by: joehw ! make/jdk/src/classes/build/tools/cldrconverter/Bundle.java ! test/jdk/sun/text/resources/LocaleData.cldr ! test/jdk/sun/text/resources/LocaleDataTest.java Changeset: dc998d4a227e Author: naoto Date: 2019-11-07 11:34 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/dc998d4a227e 8232871: Host Locale Provider on Mac does not return translated values of Japanese calendar Reviewed-by: bchristi ! src/java.base/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/java.base/macosx/native/libjava/HostLocaleProviderAdapter_md.c ! test/jdk/java/util/Locale/LocaleProviders.java ! test/jdk/java/util/Locale/LocaleProvidersRun.java Changeset: 291775bcf35d Author: kbarrett Date: 2019-11-07 16:22 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/291775bcf35d 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp Summary: Add java_shift_xxx helpers and use them. Reviewed-by: aph, kvn ! src/hotspot/share/c1/c1_Canonicalizer.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp + test/hotspot/gtest/utilities/test_java_arithmetic.cpp Changeset: 2b0f2fe82735 Author: iignatyev Date: 2019-11-07 13:39 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2b0f2fe82735 8230364: [JVMCI] a number of JVMCI tests are not jtreg enabled Reviewed-by: kvn ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestHotSpotJVMCIRuntime.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestHotSpotSpeculationLog.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestServices.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestTranslatedException.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/VirtualObjectLayoutTest.java Changeset: 19744a63c295 Author: bpb Date: 2019-11-07 13:53 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/19744a63c295 8232178: MacVolumesTest failed after upgrade to MacOS Catalina Reviewed-by: lancea ! test/jdk/java/nio/file/etc/MacVolumesTest.java Changeset: 4e3694a617d4 Author: mseledtsov Date: 2019-11-07 16:00 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/4e3694a617d4 8209813: [TESTBUG] rewrite JFR shell tests in Java Summary: Converted shell tests to Java Reviewed-by: lmesnik, egahlin ! test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWith32BitOops.java - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWith32BitOops.sh ! test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithHeapBasedOops.java - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithHeapBasedOops.sh ! test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithZeroBasedOops.java - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithZeroBasedOops.sh ! test/jdk/jdk/jfr/event/io/EvilInstrument.java - test/jdk/jdk/jfr/event/io/MakeJAR.sh ! test/jdk/jdk/jfr/event/os/TestInitialEnvironmentVariable.java - test/jdk/jdk/jfr/event/os/TestInitialEnvironmentVariable.sh - test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.flags ! test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.java - test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.sh - test/jdk/jdk/jfr/javaagent/JavaAgentBuilder.java + test/lib/jdk/test/lib/util/JavaAgentBuilder.java Changeset: c6a789f495fe Author: kvn Date: 2019-11-07 17:47 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c6a789f495fe 8233741: AES Countermode (AES-CTR) optimization using AVX512 + VAES instructions Reviewed-by: kvn Contributed-by: smita.kamath at intel.com, regev.shemy at intel.com, shay.gueron at intel.com ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86_aes.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.hpp Changeset: ad157fab6bf5 Author: iklam Date: 2019-11-07 16:26 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ad157fab6bf5 8233086: [TESTBUG] need to test field layout style difference between CDS dump time and run time Reviewed-by: fparain + test/hotspot/jtreg/runtime/cds/appcds/FieldLayoutFlags.java + test/hotspot/jtreg/runtime/cds/appcds/test-classes/FieldLayoutApp.java From david.simms at oracle.com Fri Nov 8 09:13:07 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Fri, 08 Nov 2019 09:13:07 +0000 Subject: hg: valhalla/valhalla: Merge Message-ID: <201911080913.xA89D8DI003327@aojmv0008.oracle.com> Changeset: 1bc7bbde735e Author: dsimms Date: 2019-11-08 09:20 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1bc7bbde735e Merge ! .hgtags ! make/Docs.gmk - make/GensrcModuleInfo.gmk ! make/gensrc/GensrcVarHandles.gmk ! make/hotspot/symbols/symbols-unix ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/share/c1/c1_CodeStubs.hpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/z/zBarrier.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/opto/arraycopynode.hpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/macroArrayCopy.cpp ! src/hotspot/share/opto/type.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/fieldDescriptor.inline.hpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/native/libjava/Class.c ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java - src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.c - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.replacements/src/org/graalvm/compiler/api/replacements/MethodSubstitutionRegistry.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/schedule/MemoryScheduleVerification.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ExportingClassLoader.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ModuleSupport.java - test/hotspot/jtreg/runtime/Thread/CountStackFramesAtExit.java - test/hotspot/jtreg/runtime/cds/appcds/ExtraSymbols.symbols.txt - test/hotspot/jtreg/serviceability/jvmti/ClassStatus/ClassStatus.java - test/hotspot/jtreg/serviceability/jvmti/ClassStatus/libClassStatus.c ! test/jdk/ProblemList.txt - test/jdk/java/nio/channels/DatagramChannel/AdaptDatagramSocket.java From harold.seigel at oracle.com Tue Nov 12 20:49:05 2019 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Tue, 12 Nov 2019 20:49:05 +0000 Subject: hg: valhalla/valhalla: 8230816: Consolidate classData and dynamic_nest_host into a new ClassLoadInfo data structure Message-ID: <201911122049.xACKn5UE007768@aojmv0008.oracle.com> Changeset: 7764761b3a98 Author: hseigel Date: 2019-11-12 20:48 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7764761b3a98 8230816: Consolidate classData and dynamic_nest_host into a new ClassLoadInfo data structure Summary: create ClassInstanceInfo and ClassLoadInfo classes to consolidate parameter types Reviewed-by: lfoltan, mchung ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoaderExt.cpp ! src/hotspot/share/classfile/klassFactory.cpp ! src/hotspot/share/classfile/klassFactory.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/unsafe.cpp From mandy.chung at oracle.com Wed Nov 13 00:45:06 2019 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 12 Nov 2019 16:45:06 -0800 Subject: [nestmates] validation of ClassFile for hidden classes Message-ID: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> A recent review with Alex and John on [1][2] specifically on: - Hidden classes cannot participate in static nest membership as ? they do not have names. NestHost/NestMembers attributes on hidden ? classes are ignored. Instead of making validation of ClassFile for hidden classes and ordinary classes somewhat different, the alternative is to have the validation for hidden classes and ordinary classes identical.? When another class (whether ordinary or hidden) names a hidden class as its declaring class or class member (via |InnerClasses| attribute), or as its nest host (via |NestHost| attribute), or as a member of its nest (via |NestMembers| attribute), the class may successfully be created while it may fail at run time where there is any attempt to resolve a hidden class by name via any of these attributes per existing specification.? No special rule for validation of hidden classes. David, This is the revised webrev: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/webrev-hidden-class-validation/ If a hidden nestmate class has a `NestHost` or `NestMembers` attribute, and it's created to add to a member of a dynamic nest host (H), then the runtime nest host is set to `H` and these attributes will not be validated subsequently. If a hidden class has a `NestHost` or `NestMembers` attribute and created with Lookup::defineHiddenClass without NESTMATE option, then the behavior is the same as an ordinary class with a bad `NestHost` or `NestMembers` attribute (e.g. HC's nest host is not yet validated.? When it attempts to access NH's private member, it would fail to resolve NH.) I'm not sure if this is the best way to implement InstanceKlass::set_nest_host.? When there is a proposed JVMS draft, we may make more adjustment to the implementation.? So I hope this patch is good to push in the time being. This patch also includes a small javadoc change. Mandy [1] http://hg.openjdk.java.net/valhalla/valhalla/rev/ad257875959a [2] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-September/006420.html From mandy.chung at oracle.com Wed Nov 13 03:19:49 2019 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 13 Nov 2019 03:19:49 +0000 Subject: hg: valhalla/valhalla: 2 new changesets Message-ID: <201911130319.xAD3Jn2k004255@aojmv0008.oracle.com> Changeset: 0340c109eca1 Author: mchung Date: 2019-11-12 18:41 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/0340c109eca1 Merge - make/GensrcModuleInfo.gmk ! make/hotspot/symbols/symbols-unix ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.inline.hpp - src/hotspot/share/jfr/recorder/repository/jfrChunkState.cpp - src/hotspot/share/jfr/recorder/repository/jfrChunkState.hpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp - src/hotspot/share/libadt/set.cpp - src/hotspot/share/libadt/set.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/native/libjava/Class.c - src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.c - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.replacements/src/org/graalvm/compiler/api/replacements/MethodSubstitutionRegistry.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/schedule/MemoryScheduleVerification.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ExportingClassLoader.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ModuleSupport.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/ChunkParser.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/ConstantMap.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/EventParser.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/LongMap.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/ObjectFactory.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/Parser.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/ParserFactory.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/TimeConverter.java - src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/RecordingInternals.java ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/runtime/Thread/CountStackFramesAtExit.java - test/hotspot/jtreg/runtime/cds/appcds/ExtraSymbols.symbols.txt - test/hotspot/jtreg/serviceability/jvmti/ClassStatus/ClassStatus.java - test/hotspot/jtreg/serviceability/jvmti/ClassStatus/libClassStatus.c ! test/jdk/ProblemList.txt - test/jdk/java/nio/channels/DatagramChannel/AdaptDatagramSocket.java - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWith32BitOops.sh - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithHeapBasedOops.sh - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithZeroBasedOops.sh - test/jdk/jdk/jfr/event/io/MakeJAR.sh - test/jdk/jdk/jfr/event/os/TestInitialEnvironmentVariable.sh - test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.flags - test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.sh - test/jdk/jdk/jfr/javaagent/JavaAgentBuilder.java Changeset: 083bc031d121 Author: mchung Date: 2019-11-12 19:19 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/083bc031d121 Merge with hidden classes change ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.cpp ! test/langtools/tools/javac/lambda/lambdaExpression/LambdaTest6.java ! test/langtools/tools/javac/lambda/methodReference/BridgeMethod.java From david.holmes at oracle.com Wed Nov 13 05:45:12 2019 From: david.holmes at oracle.com (David Holmes) Date: Wed, 13 Nov 2019 15:45:12 +1000 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> Message-ID: Hi Mandy, On 13/11/2019 10:45 am, Mandy Chung wrote: > A recent review with Alex and John on [1][2] specifically on: > - Hidden classes cannot participate in static nest membership as > ? they do not have names. NestHost/NestMembers attributes on hidden > ? classes are ignored. > > Instead of making validation of ClassFile for hidden classes and ordinary > classes somewhat different, the alternative is to have the validation > for hidden classes and ordinary classes identical.? When another class > (whether ordinary or hidden) names a hidden class as its declaring class > or class member (via |InnerClasses| attribute), or as its nest host > (via |NestHost| attribute), or as a member of its nest > (via |NestMembers| attribute), the class may successfully be created > while it may fail at run time where there is any attempt to resolve > a hidden class by name via any of these attributes per existing > specification.? No special rule for validation of hidden classes. The problem is not dealing with these attributes naming hidden classes as you can't name a hidden class in the first place; the problem is having these attributes in hidden classes themselves. You can certainly allow the hidden class to have all these attributes and reject their use at runtime (as and when that may happen). I don't really see the benefit in doing so however as in some cases at least the specification is going to have to account for this anyway e.g ignoring static nest attributes when dynamically injecting into a nest. > David, > > This is the revised webrev: > http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/webrev-hidden-class-validation/ > > > If a hidden nestmate class has a `NestHost` or `NestMembers` attribute, > and it's created to add to a member of a dynamic nest host (H), then > the runtime nest host is set to `H` and these attributes will not > be validated subsequently. Okay. > > If a hidden class has a `NestHost` or `NestMembers` attribute and > created with Lookup::defineHiddenClass without NESTMATE option, > then the behavior is the same as an ordinary class with a bad > `NestHost` or `NestMembers` attribute (e.g. HC's nest host is > not yet validated.? When it attempts to access NH's private member, > it would fail to resolve NH.) Okay. > I'm not sure if this is the best way to implement > InstanceKlass::set_nest_host.? When there is a proposed JVMS draft, > we may make more adjustment to the implementation.? So I hope > this patch is good to push in the time being. I have a number of minor comments, but nothing to stop pushing of the patch. 364 // So we know that current class is "pristine" and its _nest_host must be NULL. It's no longer really "pristine" if it has a NestHost or NestMember attribute. I'd probably just add an additional comment: // If it has an explicit _nest_host_index or _nest_members, these will be ignored. This change: - assert((host->_nest_host == NULL && host->_nest_host_index == 0) || - (host->_nest_host == host), "proposed host is not a valid nest-host"); + assert(host->_nest_host == NULL || host->_nest_host == host, "proposed host is not a valid nest-host"); is not correct. This is asserting something about the klass we're going to be use as the hidden class's nest-host, not something about the hidden class. The proposed nest-host must be a valid nest-host. + log_trace(class, nestmates)("Type %s is a dynamic nest member of %s: the current class has a NestHost attribute", I'd be more inclined to make these warnings rather than just logging them. Either way it should state the static values are ignored. > This patch also includes a small javadoc change. + * then the name is given by the JVM of the following format: suggest: + * then the name is defined by the JVM with the following format: similarly in the MethodHandle docs. -- + * NESTMATE} option, then the hidden class was added as a member to + * the nest of a {@linkplain MethodHandles.Lookup#lookupClass() lookup class} suggest: + * NESTMATE} option, then the hidden class is added to + * the nest of the {@linkplain MethodHandles.Lookup#lookupClass() lookup class} -- - * Lookup::defineHiddenClass}. + * Lookup::defineHiddenClass} dynamically. Adding "dynamically" is not necessary here - the use of defineHiddenClass is implicitly "dynamic". Thanks, David ----- > Mandy > [1] http://hg.openjdk.java.net/valhalla/valhalla/rev/ad257875959a > [2] > https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-September/006420.html > From david.holmes at oracle.com Wed Nov 13 06:34:17 2019 From: david.holmes at oracle.com (David Holmes) Date: Wed, 13 Nov 2019 16:34:17 +1000 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> Message-ID: Correction/clarification ... On 13/11/2019 3:45 pm, David Holmes wrote: > Hi Mandy, > > On 13/11/2019 10:45 am, Mandy Chung wrote: >> A recent review with Alex and John on [1][2] specifically on: >> - Hidden classes cannot participate in static nest membership as >> ?? they do not have names. NestHost/NestMembers attributes on hidden >> ?? classes are ignored. >> >> Instead of making validation of ClassFile for hidden classes and ordinary >> classes somewhat different, the alternative is to have the validation >> for hidden classes and ordinary classes identical.? When another class >> (whether ordinary or hidden) names a hidden class as its declaring class >> or class member (via |InnerClasses| attribute), or as its nest host >> (via |NestHost| attribute), or as a member of its nest >> (via |NestMembers| attribute), the class may successfully be created >> while it may fail at run time where there is any attempt to resolve >> a hidden class by name via any of these attributes per existing >> specification.? No special rule for validation of hidden classes. > > The problem is not dealing with these attributes naming hidden classes > as you can't name a hidden class in the first place; the problem is > having these attributes in hidden classes themselves. > > You can certainly allow the hidden class to have all these attributes > and reject their use at runtime (as and when that may happen). I don't > really see the benefit in doing so however as in some cases at least the > specification is going to have to account for this anyway e.g ignoring > static nest attributes when dynamically injecting into a nest. I see from discussion on the experts list that there is move to not reject a classfile based on the semantics of attributes, so not ignoring/rejecting during classfile parsing is okay. But the specification will still have to address the interaction between static NestHost attribute and the use of dynamic nestmate injection. Thanks, David ----- >> David, >> >> This is the revised webrev: >> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/webrev-hidden-class-validation/ >> >> >> If a hidden nestmate class has a `NestHost` or `NestMembers` attribute, >> and it's created to add to a member of a dynamic nest host (H), then >> the runtime nest host is set to `H` and these attributes will not >> be validated subsequently. > > Okay. > >> >> If a hidden class has a `NestHost` or `NestMembers` attribute and >> created with Lookup::defineHiddenClass without NESTMATE option, >> then the behavior is the same as an ordinary class with a bad >> `NestHost` or `NestMembers` attribute (e.g. HC's nest host is >> not yet validated.? When it attempts to access NH's private member, >> it would fail to resolve NH.) > > Okay. > >> I'm not sure if this is the best way to implement >> InstanceKlass::set_nest_host.? When there is a proposed JVMS draft, >> we may make more adjustment to the implementation.? So I hope >> this patch is good to push in the time being. > > I have a number of minor comments, but nothing to stop pushing of the > patch. > > ?364 // So we know that current class is "pristine" and its _nest_host > must be NULL. > > It's no longer really "pristine" if it has a NestHost or NestMember > attribute. I'd probably just add an additional comment: > > // If it has an explicit _nest_host_index or _nest_members, these will > be ignored. > > This change: > > -? assert((host->_nest_host == NULL && host->_nest_host_index == 0) || > -???????? (host->_nest_host == host), "proposed host is not a valid > nest-host"); > +? assert(host->_nest_host == NULL || host->_nest_host == host, > "proposed host is not a valid nest-host"); > > is not correct. This is asserting something about the klass we're going > to be use as the hidden class's nest-host, not something about the > hidden class. The proposed nest-host must be a valid nest-host. > > +????? log_trace(class, nestmates)("Type %s is a dynamic nest member of > %s: the current class has a NestHost attribute", > > I'd be more inclined to make these warnings rather than just logging > them. Either way it should state the static values are ignored. > >> This patch also includes a small javadoc change. > > +???? * then the name is given by the JVM of the following format: > > suggest: > > +???? * then the name is defined by the JVM with the following format: > > similarly in the MethodHandle docs. > > -- > > +???? * NESTMATE} option, then the hidden class was added as a member to > +???? * the nest of a {@linkplain MethodHandles.Lookup#lookupClass() > lookup class} > > suggest: > > +???? * NESTMATE} option, then the hidden class is added to > +???? * the nest of the {@linkplain MethodHandles.Lookup#lookupClass() > lookup class} > > -- > > -???? * Lookup::defineHiddenClass}. > +???? * Lookup::defineHiddenClass} dynamically. > > Adding "dynamically" is not necessary here - the use of > defineHiddenClass is implicitly "dynamic". > > Thanks, > David > ----- > > >> Mandy >> [1] http://hg.openjdk.java.net/valhalla/valhalla/rev/ad257875959a >> [2] >> https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-September/006420.html >> From mandy.chung at oracle.com Wed Nov 13 06:53:50 2019 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 12 Nov 2019 22:53:50 -0800 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> Message-ID: <816c765d-66dc-351a-b9d6-e5d705fc2632@oracle.com> On 11/12/19 9:45 PM, David Holmes wrote: > Hi Mandy, > > On 13/11/2019 10:45 am, Mandy Chung wrote: >> A recent review with Alex and John on [1][2] specifically on: >> - Hidden classes cannot participate in static nest membership as >> ?? they do not have names. NestHost/NestMembers attributes on hidden >> ?? classes are ignored. >> >> Instead of making validation of ClassFile for hidden classes and >> ordinary >> classes somewhat different, the alternative is to have the validation >> for hidden classes and ordinary classes identical.? When another class >> (whether ordinary or hidden) names a hidden class as its declaring class >> or class member (via |InnerClasses| attribute), or as its nest host >> (via |NestHost| attribute), or as a member of its nest >> (via |NestMembers| attribute), the class may successfully be created >> while it may fail at run time where there is any attempt to resolve >> a hidden class by name via any of these attributes per existing >> specification.? No special rule for validation of hidden classes. > > The problem is not dealing with these attributes naming hidden classes > as you can't name a hidden class in the first place; the problem is > having these attributes in hidden classes themselves. That's true.? I attempt to generalize (probably unsuccessfully) the problem that can occur in a class named in these attributes that cannot be found (where this class can be a hidden class or an ordinary class that cannot be found).?? There is no good benefit to place certain restrictions on hidden classes. > > You can certainly allow the hidden class to have all these attributes > and reject their use at runtime (as and when that may happen). I don't > really see the benefit in doing so however as in some cases at least > the specification is going to have to account for this anyway e.g > ignoring static nest attributes when dynamically injecting into a nest. > >> David, >> >> This is the revised webrev: >> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/webrev-hidden-class-validation/ >> >> >> If a hidden nestmate class has a `NestHost` or `NestMembers` attribute, >> and it's created to add to a member of a dynamic nest host (H), then >> the runtime nest host is set to `H` and these attributes will not >> be validated subsequently. > > Okay. > >> >> If a hidden class has a `NestHost` or `NestMembers` attribute and >> created with Lookup::defineHiddenClass without NESTMATE option, >> then the behavior is the same as an ordinary class with a bad >> `NestHost` or `NestMembers` attribute (e.g. HC's nest host is >> not yet validated.? When it attempts to access NH's private member, >> it would fail to resolve NH.) > > Okay. > >> I'm not sure if this is the best way to implement >> InstanceKlass::set_nest_host.? When there is a proposed JVMS draft, >> we may make more adjustment to the implementation.? So I hope >> this patch is good to push in the time being. > > I have a number of minor comments, but nothing to stop pushing of the > patch. > > ?364 // So we know that current class is "pristine" and its _nest_host > must be NULL. > > It's no longer really "pristine" if it has a NestHost or NestMember > attribute. I'd probably just add an additional comment: > > // If it has an explicit _nest_host_index or _nest_members, these will > be ignored. > Updated. > This change: > > -? assert((host->_nest_host == NULL && host->_nest_host_index == 0) || > -???????? (host->_nest_host == host), "proposed host is not a valid > nest-host"); > +? assert(host->_nest_host == NULL || host->_nest_host == host, > "proposed host is not a valid nest-host"); > > is not correct. This is asserting something about the klass we're > going to be use as the hidden class's nest-host, not something about > the hidden class. The proposed nest-host must be a valid nest-host. > Thanks for catching it.? This is reverted.?? I mistakenly read it the other way. > + log_trace(class, nestmates)("Type %s is a dynamic nest member of %s: > the current class has a NestHost attribute", > > I'd be more inclined to make these warnings rather than just logging > them. Either way it should state the static values are ignored. > I leave it as logging for now.? We can do this in a future clean up.? Does VM warning on by default? >> This patch also includes a small javadoc change. > > +???? * then the name is given by the JVM of the following format: > > suggest: > > +???? * then the name is defined by the JVM with the following format: > > similarly in the MethodHandle docs. > > -- > > +???? * NESTMATE} option, then the hidden class was added as a member to > +???? * the nest of a {@linkplain MethodHandles.Lookup#lookupClass() > lookup class} > > suggest: > > +???? * NESTMATE} option, then the hidden class is added to > +???? * the nest of the {@linkplain MethodHandles.Lookup#lookupClass() > lookup class} > > -- > > -???? * Lookup::defineHiddenClass}. > +???? * Lookup::defineHiddenClass} dynamically. > > Adding "dynamically" is not necessary here - the use of > defineHiddenClass is implicitly "dynamic". > OK.? Fixed. thanks Mandy From david.holmes at oracle.com Wed Nov 13 14:01:58 2019 From: david.holmes at oracle.com (David Holmes) Date: Thu, 14 Nov 2019 00:01:58 +1000 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: <816c765d-66dc-351a-b9d6-e5d705fc2632@oracle.com> References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> <816c765d-66dc-351a-b9d6-e5d705fc2632@oracle.com> Message-ID: Hi Mandy, > Does VM warning on by default? Yes. Thanks, David On 13/11/2019 4:53 pm, Mandy Chung wrote: > > > On 11/12/19 9:45 PM, David Holmes wrote: >> Hi Mandy, >> >> On 13/11/2019 10:45 am, Mandy Chung wrote: >>> A recent review with Alex and John on [1][2] specifically on: >>> - Hidden classes cannot participate in static nest membership as >>> ?? they do not have names. NestHost/NestMembers attributes on hidden >>> ?? classes are ignored. >>> >>> Instead of making validation of ClassFile for hidden classes and >>> ordinary >>> classes somewhat different, the alternative is to have the validation >>> for hidden classes and ordinary classes identical.? When another class >>> (whether ordinary or hidden) names a hidden class as its declaring class >>> or class member (via |InnerClasses| attribute), or as its nest host >>> (via |NestHost| attribute), or as a member of its nest >>> (via |NestMembers| attribute), the class may successfully be created >>> while it may fail at run time where there is any attempt to resolve >>> a hidden class by name via any of these attributes per existing >>> specification.? No special rule for validation of hidden classes. >> >> The problem is not dealing with these attributes naming hidden classes >> as you can't name a hidden class in the first place; the problem is >> having these attributes in hidden classes themselves. > > That's true.? I attempt to generalize (probably unsuccessfully) the > problem that can occur in a class named in these attributes that cannot > be found (where this class can be a hidden class or an ordinary class > that cannot be found).?? There is no good benefit to place certain > restrictions on hidden classes. > >> >> You can certainly allow the hidden class to have all these attributes >> and reject their use at runtime (as and when that may happen). I don't >> really see the benefit in doing so however as in some cases at least >> the specification is going to have to account for this anyway e.g >> ignoring static nest attributes when dynamically injecting into a nest. >> >>> David, >>> >>> This is the revised webrev: >>> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/webrev-hidden-class-validation/ >>> >>> >>> If a hidden nestmate class has a `NestHost` or `NestMembers` attribute, >>> and it's created to add to a member of a dynamic nest host (H), then >>> the runtime nest host is set to `H` and these attributes will not >>> be validated subsequently. >> >> Okay. >> >>> >>> If a hidden class has a `NestHost` or `NestMembers` attribute and >>> created with Lookup::defineHiddenClass without NESTMATE option, >>> then the behavior is the same as an ordinary class with a bad >>> `NestHost` or `NestMembers` attribute (e.g. HC's nest host is >>> not yet validated.? When it attempts to access NH's private member, >>> it would fail to resolve NH.) >> >> Okay. >> >>> I'm not sure if this is the best way to implement >>> InstanceKlass::set_nest_host.? When there is a proposed JVMS draft, >>> we may make more adjustment to the implementation.? So I hope >>> this patch is good to push in the time being. >> >> I have a number of minor comments, but nothing to stop pushing of the >> patch. >> >> ?364 // So we know that current class is "pristine" and its _nest_host >> must be NULL. >> >> It's no longer really "pristine" if it has a NestHost or NestMember >> attribute. I'd probably just add an additional comment: >> >> // If it has an explicit _nest_host_index or _nest_members, these will >> be ignored. >> > > Updated. > >> This change: >> >> -? assert((host->_nest_host == NULL && host->_nest_host_index == 0) || >> -???????? (host->_nest_host == host), "proposed host is not a valid >> nest-host"); >> +? assert(host->_nest_host == NULL || host->_nest_host == host, >> "proposed host is not a valid nest-host"); >> >> is not correct. This is asserting something about the klass we're >> going to be use as the hidden class's nest-host, not something about >> the hidden class. The proposed nest-host must be a valid nest-host. >> > > Thanks for catching it.? This is reverted.?? I mistakenly read it the > other way. > >> + log_trace(class, nestmates)("Type %s is a dynamic nest member of %s: >> the current class has a NestHost attribute", >> >> I'd be more inclined to make these warnings rather than just logging >> them. Either way it should state the static values are ignored. >> > > I leave it as logging for now.? We can do this in a future clean up. > Does VM warning on by default? > >>> This patch also includes a small javadoc change. >> >> +???? * then the name is given by the JVM of the following format: >> >> suggest: >> >> +???? * then the name is defined by the JVM with the following format: >> >> similarly in the MethodHandle docs. >> >> -- >> >> +???? * NESTMATE} option, then the hidden class was added as a member to >> +???? * the nest of a {@linkplain MethodHandles.Lookup#lookupClass() >> lookup class} >> >> suggest: >> >> +???? * NESTMATE} option, then the hidden class is added to >> +???? * the nest of the {@linkplain MethodHandles.Lookup#lookupClass() >> lookup class} >> >> -- >> >> -???? * Lookup::defineHiddenClass}. >> +???? * Lookup::defineHiddenClass} dynamically. >> >> Adding "dynamically" is not necessary here - the use of >> defineHiddenClass is implicitly "dynamic". >> > > OK.? Fixed. > > thanks > Mandy From mandy.chung at oracle.com Wed Nov 13 16:13:28 2019 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 13 Nov 2019 16:13:28 +0000 Subject: hg: valhalla/valhalla: [nestmates] validation of a hidden class no longer ignores NestHost/NestMembers attribute Message-ID: <201911131613.xADGDTGR011499@aojmv0008.oracle.com> Changeset: b47549f9745f Author: mchung Date: 2019-11-13 08:13 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b47549f9745f [nestmates] validation of a hidden class no longer ignores NestHost/NestMembers attribute ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! test/hotspot/jtreg/runtime/Nestmates/membership/TestDynamicNestmateMembership.java ! test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java From john.r.rose at oracle.com Wed Nov 13 19:47:11 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 13 Nov 2019 11:47:11 -0800 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> Message-ID: <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> On Nov 12, 2019, at 10:34 PM, David Holmes wrote: > > I see from discussion on the experts list that there is move to not reject a classfile based on the semantics of attributes, so not ignoring/rejecting during classfile parsing is okay. But the specification will still have to address the interaction between static NestHost attribute and the use of dynamic nestmate injection. The *normative* parts of the spec. already do address this interaction, as a corollary of the rules for normal classes (as applied to hidden classes). Here?s the reasoning: A NH attribute is futile (confers no additional access) in the case where the the class containing the NH and the actual intended NH (however that is determined) cannot symbolically resolve each other. There is a similar point for any *element* of a NMs attribute. Basically, nestmates are always able to name each other. The corollary to this for HCs is that a HC cannot benefit in any way from either a NMs or a NH attribute; such attributes are futile in exactly the same way that they would be on ?broken? regular classes. There is thus no need to special case the interaction of HCs with these attributes. So you need to do a little theorem-proving to derive the behavior of NH on a HC, but it?s not too hard, and perfectly sound, and thus no new normative language is needed. Or so I think. OTOH, the spec. *does* deserve a bit of non-normative commentary observing the corollary. I assume you and I are in agreement here, but if you know a fault in my reasoning I?m all ears! (?Eyes?) ? John From john.r.rose at oracle.com Wed Nov 13 19:48:33 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 13 Nov 2019 11:48:33 -0800 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> Message-ID: <1ED74BAE-68E2-4D9A-8612-C444187E2D27@oracle.com> On Nov 13, 2019, at 11:47 AM, John Rose wrote: > > Basically, nestmates are always able to name each other. Correction: Nestmates linked via the NH and NMs attributes. HC nestmates use a different linkage. From mandy.chung at oracle.com Wed Nov 13 20:52:33 2019 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 13 Nov 2019 20:52:33 +0000 Subject: hg: valhalla/valhalla: [nestmates] validate the flags and class data arguments only set for hidden classes Message-ID: <201911132052.xADKqYRg015297@aojmv0008.oracle.com> Changeset: 49b13a115884 Author: mchung Date: 2019-11-13 12:52 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/49b13a115884 [nestmates] validate the flags and class data arguments only set for hidden classes ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/prims/jvm.cpp From david.holmes at oracle.com Thu Nov 14 02:10:55 2019 From: david.holmes at oracle.com (David Holmes) Date: Thu, 14 Nov 2019 12:10:55 +1000 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> Message-ID: <1eac37b9-0100-13d5-3125-51711bd1eb05@oracle.com> Hi John, On 14/11/2019 5:47 am, John Rose wrote: > On Nov 12, 2019, at 10:34 PM, David Holmes > wrote: >> >> I see from discussion on the experts list that there is move to not >> reject a classfile based on the semantics of attributes, so not >> ignoring/rejecting during classfile parsing is okay. But the >> specification will still have to address the interaction between >> static NestHost attribute and the use of dynamic nestmate injection. > > The *normative* parts of the spec. already do address this > interaction, as a corollary of the rules for normal classes (as > applied to hidden classes). > > Here?s the reasoning: A NH attribute is futile (confers no > additional access) in the case where the the class containing the NH > and the actual intended NH (however that is determined) cannot > symbolically resolve each other. There is a similar point for any > *element* of a NMs attribute. Basically, nestmates are always able > to name each other. The corollary to this for HCs is that a HC > cannot benefit in any way from either a NMs or a NH attribute; such > attributes are futile in exactly the same way that they would be on > ?broken? regular classes. There is thus no need to special case the > interaction of HCs with these attributes. > > So you need to do a little theorem-proving to derive the behavior of > NH on a HC, but it?s not too hard, and perfectly sound, and thus no > new normative language is needed. Or so I think. > > OTOH, the spec. *does* deserve a bit of non-normative commentary > observing the corollary. > > I assume you and I are in agreement here, but if you know a fault in > my reasoning I?m all ears! (?Eyes?) If we dynamically inject the HC into a nest then the normal resolution of any NH/NM attribute (which must fail as you point out) will not actually occur. This ties into the notion of "runtime nest host" which has to be introduced into the spec in 5.4.4 to support dynamic nestmates - as outlined in other emails. That formulation previously assumed we were ignoring a NH/NM attribute in a HC, so now we are not ignoring them we just need to be sure that the formulation handles that case okay - which I think it does. Cheers, David > > ? John From john.r.rose at oracle.com Thu Nov 14 03:49:42 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 13 Nov 2019 19:49:42 -0800 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: <1eac37b9-0100-13d5-3125-51711bd1eb05@oracle.com> References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> <1eac37b9-0100-13d5-3125-51711bd1eb05@oracle.com> Message-ID: <5F0D8AD6-8DDF-4C7E-BA4F-D3C6B269B3B2@oracle.com> On Nov 13, 2019, at 6:10 PM, David Holmes wrote: > > This ties into the notion of "runtime nest host" which has to be introduced into the spec in 5.4.4 to support dynamic nestmates - as outlined in other emails. That formulation previously assumed we were ignoring a NH/NM attribute in a HC, so now we are not ignoring them we just need to be sure that the formulation handles that case okay - which I think it does. Right, that makes sense, and now I see where you are coming from about ignoring those attributes. If the dynamic host is consulted *instead* of the NestHost and NestMembers attributes, for both link resolution and for reflection, *and* if there is no other use of those attributes, then they can truly be said to be ?ignored?. In my view the statement that NH/NMs are ignored is explanatory, not normative, because it is a corollary of the normative rules which pertain to NH and NMs and the preferential use of the dynamic host property when performing link resolution and reflection. My next question: Where is the most recent draft of the specification of link resolution and reflection of hidden classes which are injected into nests? Does the JVMS get a tweak, since it only talks about the attributes? ? John P.S. I also dumped some thoughts about classData on https://bugs.openjdk.java.net/browse/JDK-8171335 some of which relate to nestmate considerations. From david.holmes at oracle.com Thu Nov 14 04:49:28 2019 From: david.holmes at oracle.com (David Holmes) Date: Thu, 14 Nov 2019 14:49:28 +1000 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: <5F0D8AD6-8DDF-4C7E-BA4F-D3C6B269B3B2@oracle.com> References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> <1eac37b9-0100-13d5-3125-51711bd1eb05@oracle.com> <5F0D8AD6-8DDF-4C7E-BA4F-D3C6B269B3B2@oracle.com> Message-ID: <172f52ac-901a-ea7c-6610-4b51e1fdcfae@oracle.com> Hi John, On 14/11/2019 1:49 pm, John Rose wrote: > On Nov 13, 2019, at 6:10 PM, David Holmes > wrote: >> >> This ties into the notion of "runtime nest host" which has to be >> introduced into the spec in 5.4.4 to support dynamic nestmates - as >> outlined in other emails. That formulation previously assumed we were >> ignoring a NH/NM attribute in a HC, so now we are not ignoring them we >> just need to be sure that the formulation handles that case okay - >> which I think it does. > > Right, that makes sense, and now I see where you are coming from > about ignoring those attributes. If the dynamic host is consulted > *instead* of the NestHost and NestMembers attributes, for both link > resolution and for reflection, *and* if there is no other use of > those attributes, then they can truly be said to be ?ignored?. > > In my view the statement that NH/NMs are ignored is explanatory, not > normative, because it is a corollary of the normative rules which > pertain to NH and NMs and the preferential use of the dynamic host > property when performing link resolution and reflection. > > My next question: Where is the most recent draft of the > specification of link resolution and reflection of hidden classes > which are injected into nests? Does the JVMS get a tweak, since it > only talks about the attributes? There is a task for updating the JVMS for hidden classes, including the dynamic nestmate aspect: https://bugs.openjdk.java.net/browse/JDK-8231313 I just updated with my suggestions regarding dynamic nestmates, previously expressed in email with Mandy and Alex. But I note that suggestion doesn't quite do what was just discussed: "The runtime nest host of a class C is its static nest host if that can be resolved without error, else C itself if the static nest host cannot be resolved without error, else the nest host of the nest the class was programmatically defined to be a member of." We would want the programmatic nesthost to take precedence, then try to resolve the static NH etc. Not sure if Mandy has the reflection aspect documented outside of email at the moment. David ----- > ? John > > P.S. I also dumped some thoughts about classData on > https://bugs.openjdk.java.net/browse/JDK-8171335 > some of which relate to nestmate considerations. From john.r.rose at oracle.com Thu Nov 14 05:01:54 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 13 Nov 2019 21:01:54 -0800 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: <172f52ac-901a-ea7c-6610-4b51e1fdcfae@oracle.com> References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> <1eac37b9-0100-13d5-3125-51711bd1eb05@oracle.com> <5F0D8AD6-8DDF-4C7E-BA4F-D3C6B269B3B2@oracle.com> <172f52ac-901a-ea7c-6610-4b51e1fdcfae@oracle.com> Message-ID: On Nov 13, 2019, at 8:49 PM, David Holmes wrote: > > We would want the programmatic nesthost to take precedence, then try to resolve the static NH etc. Yes, determining the dynamic nest host of a HC must happen before the attrbutes are examined. In this sense the attributes will be ignored for HCs. The JVM has a rule for computing the host H or H'. I think it?s harmless (in practice) that the derivation of the dynamic nest host H? or H for the non-HC part of a resolution request might throw because a non-hidden class has a broken attribute. That?s just the cost of doing business with the bidirectional relations of the NH/NMs attributes. > Not sure if Mandy has the reflection aspect documented outside of email at the moment. I think she has that covered in the API spec for jl.Class. http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/specdiff/java.base/java/lang/Class.html ? John From mandy.chung at oracle.com Thu Nov 14 05:34:18 2019 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 13 Nov 2019 21:34:18 -0800 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> <1eac37b9-0100-13d5-3125-51711bd1eb05@oracle.com> <5F0D8AD6-8DDF-4C7E-BA4F-D3C6B269B3B2@oracle.com> <172f52ac-901a-ea7c-6610-4b51e1fdcfae@oracle.com> Message-ID: <7dfb1b2d-0e12-4a1e-e484-9280d6f91b1c@oracle.com> On 11/13/19 9:01 PM, John Rose wrote: > On Nov 13, 2019, at 8:49 PM, David Holmes > wrote: >> >> We would want the programmatic nesthost to take precedence, then try >> to resolve the static NH etc. > > Yes, determining the dynamic nest host of a HC must happen before the > attrbutes > are examined. ?In this sense the attributes will be ignored for HCs. > ?The JVM has > a rule for computing the host H or H'. > > I think it?s harmless (in practice) that the derivation of the dynamic > nest host H? or H > for the non-HC part of a resolution request might throw because a > non-hidden > class has a broken attribute. ?That?s just the cost of doing business > with the > bidirectional relations of the NH/NMs attributes. > >> Not sure if Mandy has the reflection aspect documented outside of >> email at the moment. > > I think she has that covered in the API spec for jl.Class. > > http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8171335/specdiff/java.base/java/lang/Class.html This is what we have in the nestmates branch: Class::getNestHost returns the runtime nest host.?? Note that JDK 13 does not have the runtime nest host concept but Class::getNestHost returns this Class if it fails the nest membership validation. Class::getNestMembers will first determine the runtime nest host and then returns all members of the nest of this class. Lookup::defineHiddenClass with NESTMATE option first will determine the runtime nest host of the lookup class (that should be the same as what LC.getNestHost() returns) and the runtime nest host of the lookup class will be the dynamic nest host of HC.??? In other words, HC's NH and NM attributes are effectively ignored. Then this will give consistent views: ??? HC.getNestHost == LC.getNestHost ??? HC.getNestMembers == LC.getNestMembers I think JVMS should mention these reflection APIs along with Lookup::defineHiddenClass that will compute the runtime nest host. If HC is not defined as a nestmate (i.e. Lookup::dHC is called without NESTMATE option), if a symbolic reference triggers the nestmate access control test before the runtime nest host of HC is not set, any error will be thrown due to the bad nest membership during access check. Mandy From john.r.rose at oracle.com Thu Nov 14 06:14:29 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 13 Nov 2019 22:14:29 -0800 Subject: [nestmates] validation of ClassFile for hidden classes In-Reply-To: <7dfb1b2d-0e12-4a1e-e484-9280d6f91b1c@oracle.com> References: <546e5506-a9c5-7f44-9ae7-256fd46bc54c@oracle.com> <64881F5B-EF51-4EB6-8C72-F9CB6E7CA938@oracle.com> <1eac37b9-0100-13d5-3125-51711bd1eb05@oracle.com> <5F0D8AD6-8DDF-4C7E-BA4F-D3C6B269B3B2@oracle.com> <172f52ac-901a-ea7c-6610-4b51e1fdcfae@oracle.com> <7dfb1b2d-0e12-4a1e-e484-9280d6f91b1c@oracle.com> Message-ID: Yes to all of the above; thank you! On Nov 13, 2019, at 9:34 PM, Mandy Chung wrote: > > If HC is not defined as a nestmate (i.e. Lookup::dHC is called without NESTMATE option), if a symbolic reference triggers the nestmate access control test before the runtime nest host of HC is not set, any error will be thrown due to the bad nest membership during access check. If there?s no NESTMATE option, then no special rule is needed, since we can prove that the HC?s dynamic/runtime nest host will never be anything else than the HC itself. (Getting there might involve executing a broken NestHost attribute and swallowing an error, just like a broken normal class.) And if the HC tries to access some private field D.x of some class D, the access should fail, with or without a NestHost or NestMembers attribute in HC that may attempt to ?hook into? D?s nest. Finally, the access failure (of the futile HC trying to get to D.x) should be pretty much the same, whether HC was loaded via Lookup::dAC (without the NESTMATE option) or as a normal class (where the names just don?t line up). In both cases, a broken NestHost attribute fails to validate and the resulting error flows through to fail the linkage of D.x. If there?s no NestHost attribute then the error is raised at a slightly different point, but D.x still fails. If Lookup::dAC loads the HC with the NESTMATE option, if D is not in the right nest (that of the lookup class LC) then the access to D.x should fail. It will fail differently, since in that case HC has a well-defined nest. (And that is regardless of its NestHost attribute, which doesn?t have any impact on the access control logic.) ?I hope I got that right. There?s a table that wants to be built here, for failure modes in these cases: C refers to private D.x, but fails to be part of D?s nest C is { normal class, HC w/o nestmate, HC with NESTMATE into LC } x C has { futile NestHost attribute, futile NestMembers attribute, neither attribute } Here, LC is not a member of D?s nest. If it were then C could get to D.x. Likewise, the futile NestHost attribute doesn?t point to D?s NH, or if it does then D?s NH doesn?t point back at C. Likewise, the futile NestMembers attribute doesn?t point to D, or if it does then D doesn?t claim C as a NestHost. And if C is a HC then we know nobody can point back to it. From rwestrel at redhat.com Thu Nov 14 09:55:57 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Thu, 14 Nov 2019 10:55:57 +0100 Subject: RFR: aaload/aastore profiling Message-ID: <87y2widbo2.fsf@redhat.com> http://cr.openjdk.java.net/~roland/valhalla/aaload-aastore-profiling/ This patch adds profiling for aaload and aastore in order to improve code generation for inline types. Array type, element type whether the array is flat or null free are collected for both aaload and aastore. aastore already collects some profiling (element type). In practice, the new profile collection scheme at aastore replaces the old one. The patch includes changes to C2 so it leverages the new profiling. At an aaload, if profiling reports a single array type, c2 casts the array type to the profiled type if it helps avoid a flat array check. Otherwise, if profiling reports no accurate type for the array, c2 can cast the array to non flat or non null free based on profile data. MonomorphicArrayCheck is also modified to take advantage of the new profiling. So at an aastore, if profile data sugggests an array type, the array should be always casted to that array type. Roland. From tobias.hartmann at oracle.com Thu Nov 14 15:26:41 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 14 Nov 2019 16:26:41 +0100 Subject: RFR(S): 8234108: [lworld] Call site reresolution fails for ValueBootstrapMethods::isSubstitutable0 callee Message-ID: <9fc64c03-ae20-b635-4bca-653906b48cd3@oracle.com> Hi, please review the following patch: https://bugs.openjdk.java.net/browse/JDK-8234108 http://cr.openjdk.java.net/~thartmann/8234108/webrev.00/ The C2 acmp implementation emits a runtime call to ValueBootstrapMethods::isSubstitutable0. If that method got compiled but becomes non-entrant, we patch the entry to call SharedRuntime::get_handle_wrong_method_stub(). The re-resolution code then looks at the current bytecode of the caller and expects it to be an invoke. Roland already fixed that for static call resolution [1], we should do the same for re-resolution. I've moved the check into SharedRuntime::find_callee_info_helper which is used for both resolution and re-resolution. Thanks, Tobias [1] http://hg.openjdk.java.net/valhalla/valhalla/rev/1d216028b57b#l8.7 From david.simms at oracle.com Fri Nov 15 08:32:46 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 15 Nov 2019 09:32:46 +0100 Subject: RFR(S): 8234108: [lworld] Call site reresolution fails for ValueBootstrapMethods::isSubstitutable0 callee In-Reply-To: <9fc64c03-ae20-b635-4bca-653906b48cd3@oracle.com> References: <9fc64c03-ae20-b635-4bca-653906b48cd3@oracle.com> Message-ID: Looks good sir, especially appreciate the new test, push it /D On 14/11/19 4:26 PM, Tobias Hartmann wrote: > Hi, > > please review the following patch: > https://bugs.openjdk.java.net/browse/JDK-8234108 > http://cr.openjdk.java.net/~thartmann/8234108/webrev.00/ > > The C2 acmp implementation emits a runtime call to ValueBootstrapMethods::isSubstitutable0. If that > method got compiled but becomes non-entrant, we patch the entry to call > SharedRuntime::get_handle_wrong_method_stub(). The re-resolution code then looks at the current > bytecode of the caller and expects it to be an invoke. Roland already fixed that for static call > resolution [1], we should do the same for re-resolution. I've moved the check into > SharedRuntime::find_callee_info_helper which is used for both resolution and re-resolution. > > Thanks, > Tobias > > [1] http://hg.openjdk.java.net/valhalla/valhalla/rev/1d216028b57b#l8.7 From tobias.hartmann at oracle.com Fri Nov 15 08:38:50 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Fri, 15 Nov 2019 08:38:50 +0000 Subject: hg: valhalla/valhalla: 8234108: [lworld] Call site reresolution fails for ValueBootstrapMethods::isSubstitutable0 callee Message-ID: <201911150838.xAF8coTe015365@aojmv0008.oracle.com> Changeset: 7e19dedbfb55 Author: thartmann Date: 2019-11-15 09:38 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7e19dedbfb55 8234108: [lworld] Call site reresolution fails for ValueBootstrapMethods::isSubstitutable0 callee Reviewed-by: dsimms ! src/hotspot/share/runtime/sharedRuntime.cpp + test/hotspot/jtreg/compiler/valhalla/valuetypes/TestIsSubstitutableReresolution.java From tobias.hartmann at oracle.com Fri Nov 15 08:38:52 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 15 Nov 2019 09:38:52 +0100 Subject: RFR(S): 8234108: [lworld] Call site reresolution fails for ValueBootstrapMethods::isSubstitutable0 callee In-Reply-To: References: <9fc64c03-ae20-b635-4bca-653906b48cd3@oracle.com> Message-ID: Thanks for the review! Pushed. Best regards, Tobias On 15.11.19 09:32, David Simms wrote: > > Looks good sir, especially appreciate the new test, push it > > /D > > On 14/11/19 4:26 PM, Tobias Hartmann wrote: >> Hi, >> >> please review the following patch: >> https://bugs.openjdk.java.net/browse/JDK-8234108 >> http://cr.openjdk.java.net/~thartmann/8234108/webrev.00/ >> >> The C2 acmp implementation emits a runtime call to ValueBootstrapMethods::isSubstitutable0. If that >> method got compiled but becomes non-entrant, we patch the entry to call >> SharedRuntime::get_handle_wrong_method_stub(). The re-resolution code then looks at the current >> bytecode of the caller and expects it to be an invoke. Roland already fixed that for static call >> resolution [1], we should do the same for re-resolution. I've moved the check into >> SharedRuntime::find_callee_info_helper which is used for both resolution and re-resolution. >> >> Thanks, >> Tobias >> >> [1] http://hg.openjdk.java.net/valhalla/valhalla/rev/1d216028b57b#l8.7 > > From tobias.hartmann at oracle.com Fri Nov 15 11:47:58 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 15 Nov 2019 12:47:58 +0100 Subject: RFR: aaload/aastore profiling In-Reply-To: <87y2widbo2.fsf@redhat.com> References: <87y2widbo2.fsf@redhat.com> Message-ID: Hi Roland, very nice. Here are some comments: - macroAssembler_x86.cpp:3462, indentation is wrong - c1_Runtime1.cpp:476, can you move this into the else branch (line 485) to avoid the is_flattened() check and also move the assert into the two branches? - ciMethod.cpp:697, can this assert be removed? - ciObjArrayKlass.cpp: why are these checks required? - parseHelper.cpp and parse2.cpp, this code is very hard to read - comments would be helpful :) - TestLWorld.java:2318, can this be removed? - ValueTypeTest.java, nice refactoring. I had something similar in the queue. Can lines 553, 565 be removed? - Should the C1 and interpreter profiling be guarded by EnableValhalla? I've executed some testing, all passed! How did you verify performance? Please file an enhancement for this so we can better keep track of related tasks. Thanks, Tobias On 14.11.19 10:55, Roland Westrelin wrote: > > http://cr.openjdk.java.net/~roland/valhalla/aaload-aastore-profiling/ > > This patch adds profiling for aaload and aastore in order to improve > code generation for inline types. > > Array type, element type whether the array is flat or null free are > collected for both aaload and aastore. aastore already collects some > profiling (element type). In practice, the new profile collection scheme > at aastore replaces the old one. > > The patch includes changes to C2 so it leverages the new profiling. At > an aaload, if profiling reports a single array type, c2 casts the array > type to the profiled type if it helps avoid a flat array > check. Otherwise, if profiling reports no accurate type for the array, > c2 can cast the array to non flat or non null free based on profile > data. > > MonomorphicArrayCheck is also modified to take advantage of the new > profiling. So at an aastore, if profile data sugggests an array type, > the array should be always casted to that array type. > > Roland. > From rwestrel at redhat.com Fri Nov 15 15:00:29 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Fri, 15 Nov 2019 16:00:29 +0100 Subject: RFR: aaload/aastore profiling In-Reply-To: References: <87y2widbo2.fsf@redhat.com> Message-ID: <87k181chgy.fsf@redhat.com> Hi Tobias, Thanks for reviewing this. > - c1_Runtime1.cpp:476, can you move this into the else branch (line 485) to avoid the is_flattened() > check and also move the assert into the two branches? This? diff -r f81c768ad125 src/hotspot/share/c1/c1_Runtime1.cpp --- a/src/hotspot/share/c1/c1_Runtime1.cpp Wed Nov 13 17:51:40 2019 +0100 +++ b/src/hotspot/share/c1/c1_Runtime1.cpp Fri Nov 15 15:55:56 2019 +0100 @@ -473,15 +473,16 @@ JRT_ENTRY(void, Runtime1::store_flattened_array(JavaThread* thread, valueArrayOopDesc* array, int index, oopDesc* value)) - assert(ArrayKlass::cast(array->klass())->storage_properties().is_flattened() || (ArrayKlass::cast(array->klass())->storage_properties().is_null_free() && value == NULL), "should not be called"); if (ArrayKlass::cast(array->klass())->storage_properties().is_flattened()) { profile_flat_array(thread); } NOT_PRODUCT(_store_flattened_array_slowcase_cnt++;) if (value == NULL) { + assert(ArrayKlass::cast(array->klass())->storage_properties().is_flattened() || ArrayKlass::cast(array->klass())->storage_properties().is_null_free(), "should not be called"); SharedRuntime::throw_and_post_jvmti_exception(thread, vmSymbols::java_lang_NullPointerException()); } else { + assert(ArrayKlass::cast(array->klass())->storage_properties().is_flattened(), "should not be called"); array->value_copy_to_index(value, index); } JRT_END > - ciObjArrayKlass.cpp: why are these checks required? A non null free value array has a subtype, the null free value array, right? Without that change, the c1 code assumes that if it sees any value array, it knows the exact type. > - TestLWorld.java:2318, can this be removed? > - ValueTypeTest.java, nice refactoring. I had something similar in the queue. Can lines 553, 565 be > removed? Yep. Sorry, I forgot about those. > - Should the C1 and interpreter profiling be guarded by EnableValhalla? The problem is that I replaced the existing aastore profiling. So with -EnableValhalla we would go back to the previous aastore profiling and previous MonomorphicArrayCheck? > I've executed some testing, all passed! How did you verify performance? Easy. I didn't. It obviously improves performance! :-) > Please file an enhancement for this so we can better keep track of related tasks. What you're saying is I need a bug id for this change, right? Roland. From tobias.hartmann at oracle.com Fri Nov 15 15:25:04 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Fri, 15 Nov 2019 16:25:04 +0100 Subject: RFR: aaload/aastore profiling In-Reply-To: <87k181chgy.fsf@redhat.com> References: <87y2widbo2.fsf@redhat.com> <87k181chgy.fsf@redhat.com> Message-ID: <7d71a7d6-a04b-efbe-09bc-571e920996d4@oracle.com> Hi Roland, On 15.11.19 16:00, Roland Westrelin wrote: > This? > > diff -r f81c768ad125 src/hotspot/share/c1/c1_Runtime1.cpp > --- a/src/hotspot/share/c1/c1_Runtime1.cpp Wed Nov 13 17:51:40 2019 +0100 > +++ b/src/hotspot/share/c1/c1_Runtime1.cpp Fri Nov 15 15:55:56 2019 +0100 > @@ -473,15 +473,16 @@ > > > JRT_ENTRY(void, Runtime1::store_flattened_array(JavaThread* thread, valueArrayOopDesc* array, int index, oopDesc* value)) > - assert(ArrayKlass::cast(array->klass())->storage_properties().is_flattened() || (ArrayKlass::cast(array->klass())->storage_properties().is_null_free() && value == NULL), "should not be called"); > if (ArrayKlass::cast(array->klass())->storage_properties().is_flattened()) { > profile_flat_array(thread); > } > > NOT_PRODUCT(_store_flattened_array_slowcase_cnt++;) > if (value == NULL) { > + assert(ArrayKlass::cast(array->klass())->storage_properties().is_flattened() || ArrayKlass::cast(array->klass())->storage_properties().is_null_free(), "should not be called"); > SharedRuntime::throw_and_post_jvmti_exception(thread, vmSymbols::java_lang_NullPointerException()); > } else { > + assert(ArrayKlass::cast(array->klass())->storage_properties().is_flattened(), "should not be called"); > array->value_copy_to_index(value, index); > } > JRT_END My bad, that doesn't make it easier to read. Leave it as is. >> - ciObjArrayKlass.cpp: why are these checks required? > > A non null free value array has a subtype, the null free value array, > right? > Without that change, the c1 code assumes that if it sees any value > array, it knows the exact type. Okay, I was just wondering why we didn't need that code before. >> - Should the C1 and interpreter profiling be guarded by EnableValhalla? > > The problem is that I replaced the existing aastore profiling. So with > -EnableValhalla we would go back to the previous aastore profiling and > previous MonomorphicArrayCheck? Right if that's getting too complex, we can just have it always enabled. >> I've executed some testing, all passed! How did you verify performance? > > Easy. I didn't. It obviously improves performance! :-) Okay :) Maybe Sergey can do some evaluation once this is in. >> Please file an enhancement for this so we can better keep track of related tasks. > > What you're saying is I need a bug id for this change, right? Yes. It would be good if someone from runtime could look at this as well. Best regards, Tobias From rwestrel at redhat.com Fri Nov 15 16:15:37 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Fri, 15 Nov 2019 17:15:37 +0100 Subject: RFR: aaload/aastore profiling In-Reply-To: <7d71a7d6-a04b-efbe-09bc-571e920996d4@oracle.com> References: <87y2widbo2.fsf@redhat.com> <87k181chgy.fsf@redhat.com> <7d71a7d6-a04b-efbe-09bc-571e920996d4@oracle.com> Message-ID: <87a78xcdzq.fsf@redhat.com> >> A non null free value array has a subtype, the null free value array, >> right? >> Without that change, the c1 code assumes that if it sees any value >> array, it knows the exact type. > > Okay, I was just wondering why we didn't need that code before. Could be it's only used by profiling and so incorrect profiling doesn't cause any failure. >> The problem is that I replaced the existing aastore profiling. So with >> -EnableValhalla we would go back to the previous aastore profiling and >> previous MonomorphicArrayCheck? > > Right if that's getting too complex, we can just have it always enabled. Also for -EnableValhalla/+EnableValhalla performance comparisons, I think it makes sense that -EnableValhalla runs with the improved MonomorphicArrayCheck or type speculation that leverages the new aaload/aastore profile data. Roland. From rwestrel at redhat.com Fri Nov 15 16:52:18 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Fri, 15 Nov 2019 17:52:18 +0100 Subject: RFR: aaload/aastore profiling In-Reply-To: <87a78xcdzq.fsf@redhat.com> References: <87y2widbo2.fsf@redhat.com> <87k181chgy.fsf@redhat.com> <7d71a7d6-a04b-efbe-09bc-571e920996d4@oracle.com> <87a78xcdzq.fsf@redhat.com> Message-ID: <877e41ccal.fsf@redhat.com> Here is an updated webrev: http://cr.openjdk.java.net/~roland/valhalla/aaload-aastore-profiling/webrev.01/ Roland. From tobias.hartmann at oracle.com Mon Nov 18 07:22:03 2019 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Mon, 18 Nov 2019 08:22:03 +0100 Subject: RFR: aaload/aastore profiling In-Reply-To: <877e41ccal.fsf@redhat.com> References: <87y2widbo2.fsf@redhat.com> <87k181chgy.fsf@redhat.com> <7d71a7d6-a04b-efbe-09bc-571e920996d4@oracle.com> <87a78xcdzq.fsf@redhat.com> <877e41ccal.fsf@redhat.com> Message-ID: <97d59255-7414-f434-7472-4b35b059e8a7@oracle.com> Looks good. Best regards, Tobias On 15.11.19 17:52, Roland Westrelin wrote: > > Here is an updated webrev: > > http://cr.openjdk.java.net/~roland/valhalla/aaload-aastore-profiling/webrev.01/ > > Roland. > From frederic.parain at oracle.com Mon Nov 18 20:58:23 2019 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Mon, 18 Nov 2019 20:58:23 +0000 Subject: hg: valhalla/valhalla: 8234246: [lworld] InterpreterRuntime::is_substitutable fails with guarantee(!HAS_PENDING_EXCEPTION) failed: isSubstitutable() raised exception Message-ID: <201911182058.xAIKwNoS002248@aojmv0008.oracle.com> Changeset: 05e57d7c7c6f Author: fparain Date: 2019-11-18 15:57 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/05e57d7c7c6f 8234246: [lworld] InterpreterRuntime::is_substitutable fails with guarantee(!HAS_PENDING_EXCEPTION) failed: isSubstitutable() raised exception Reviewed-by: mchung ! src/hotspot/share/interpreter/interpreterRuntime.cpp From tobias.hartmann at oracle.com Wed Nov 20 09:20:05 2019 From: tobias.hartmann at oracle.com (tobias.hartmann at oracle.com) Date: Wed, 20 Nov 2019 09:20:05 +0000 Subject: hg: valhalla/valhalla: 8234492: [lworld] Endless loop when reresolving C2 compiled call to isSubstitutable0 Message-ID: <201911200920.xAK9K546005452@aojmv0008.oracle.com> Changeset: f6f169af0f2c Author: thartmann Date: 2019-11-20 10:19 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f6f169af0f2c 8234492: [lworld] Endless loop when reresolving C2 compiled call to isSubstitutable0 ! src/hotspot/share/runtime/sharedRuntime.cpp From david.simms at oracle.com Wed Nov 20 13:36:18 2019 From: david.simms at oracle.com (David Simms) Date: Wed, 20 Nov 2019 14:36:18 +0100 Subject: RFR: JDK-8234507 [lworld] Macro ASM version of access_value_copy Message-ID: <33568549-6463-9877-fd4b-3d17894abbb7@oracle.com> Bug/RFE: https://bugs.openjdk.java.net/browse/JDK-8234507 Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8234507/webrev0/ Greetings, ??? In working towards complete support for the "Heap Access API", I have added "MacroAssembler::access_value_copy". Given the complexity of performing essentially a "clone" operation (oop iteration applying barrier logic interspersed with memcpy), it is currently implemented simply as a leaf call (has very little overhead). ? There maybe be further opportunities to optimized for value type containing no oops etc, but this general purpose variant would probably remain as "fall back" implementation, so it seem like decent first step for building on. ? In order to provide testing for "MacroAssembler::access_value_copy", I created a "fast path" alternative for "InterpreterRuntime::read_flattened_field()" see: "InterpreterMacroAssembler::read_flattened_field()". This required quite a number of support methods, i.e. assembler versions of: * "InstanceKlass::get_value_field_klass()" * "ValueKlass::read_flattened_field()" o is_empty_value() o default_value() o allocate_instance() o data_for_oop() This increased the scope of the change, most of these ancillary helpers make up the bulk of the change. I feel this was necessary in order to evaluate whether the performance gains were the amount of engineering required to avoid interpreter runtime calls. Micro-benchmarking show a x3 performance gain for reading int sized value type field (and x2 gain for reading empty value type field). So answer seems to confirm Frederic's desire to remove as many runtime calls as possible. Of interest: "MacroAssembler::allocate_instance()". I took the guts out of "TemplateTable::_new" in order to allocate "oop buffer". This seems like fairly general code (not specific to interpreter), thinking we can refactor some of our other tlab allocations to use this (perhaps "MacroAssembler::store_value_type_fields_to_buf") Still running testing, there may be a subtle bug hiding...but this patch is taking it's time, best gather feedback at this point. /David Simms From david.simms at oracle.com Wed Nov 20 14:07:21 2019 From: david.simms at oracle.com (David Simms) Date: Wed, 20 Nov 2019 15:07:21 +0100 Subject: RFR: JDK-8234507 [lworld] Macro ASM version of access_value_copy In-Reply-To: <33568549-6463-9877-fd4b-3d17894abbb7@oracle.com> References: <33568549-6463-9877-fd4b-3d17894abbb7@oracle.com> Message-ID: From further testing it looks like eden_allocate requires "obj" arg as "rax", so some juggling of regs remains to be done in "InterpreterMacroAssembler::read_flattened_field()" On 20/11/19 2:36 PM, David Simms wrote: > > Bug/RFE: https://bugs.openjdk.java.net/browse/JDK-8234507 > > Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8234507/webrev0/ > > > Greetings, > > ??? In working towards complete support for the "Heap Access API", I > have added "MacroAssembler::access_value_copy". Given the complexity > of performing essentially a "clone" operation (oop iteration applying > barrier logic interspersed with memcpy), it is currently implemented > simply as a leaf call (has very little overhead). > > ? There maybe be further opportunities to optimized for value type > containing no oops etc, but this general purpose variant would > probably remain as "fall back" implementation, so it seem like decent > first step for building on. > > ? In order to provide testing for "MacroAssembler::access_value_copy", > I created a "fast path" alternative for > "InterpreterRuntime::read_flattened_field()" see: > "InterpreterMacroAssembler::read_flattened_field()". This required > quite a number of support methods, i.e. assembler versions of: > > ?* "InstanceKlass::get_value_field_klass()" > ?* "ValueKlass::read_flattened_field()" > ???? o is_empty_value() > ???? o default_value() > ???? o allocate_instance() > ???? o data_for_oop() > > This increased the scope of the change, most of these ancillary > helpers make up the bulk of the change. I feel this was necessary in > order to evaluate whether the performance gains were the amount of > engineering required to avoid interpreter runtime calls. > Micro-benchmarking show a x3 performance gain for reading int sized > value type field (and x2 gain for reading empty value type field). So > answer seems to confirm Frederic's desire to remove as many runtime > calls as possible. > > Of interest: "MacroAssembler::allocate_instance()". I took the guts > out of "TemplateTable::_new" in order to allocate "oop buffer". This > seems like fairly general code (not specific to interpreter), thinking > we can refactor some of our other tlab allocations to use this > (perhaps "MacroAssembler::store_value_type_fields_to_buf") > > Still running testing, there may be a subtle bug hiding...but this > patch is taking it's time, best gather feedback at this point. > > /David Simms > From frederic.parain at oracle.com Wed Nov 20 20:55:12 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Wed, 20 Nov 2019 15:55:12 -0500 Subject: RFR: aaload/aastore profiling In-Reply-To: <87y2widbo2.fsf@redhat.com> References: <87y2widbo2.fsf@redhat.com> Message-ID: Roland, Thank you for fixing this and for having implemented the interpreter part. I?ve just looked at the x86 interpreter code: src/hotspot/cpu/x86/interp_masm_x86.cpp No comment src/hotspot/cpu/x86/interp_masm_x86.hpp No comment src/hotspot/cpu/x86/macroAssembler_x86.cpp No comment src/hotspot/cpu/x86/macroAssembler_x86.hpp No comment src/hotspot/cpu/x86/templateTable_x86.cpp line 822-823: single blank line is enough I don?t know if a CR has already been created or not, but please, check that it has the 'platform-specific? tag so Dmitry could easily find that there?s some work to do for the Aarch64 platform. Regards, Fred > On Nov 14, 2019, at 04:55, Roland Westrelin wrote: > > > http://cr.openjdk.java.net/~roland/valhalla/aaload-aastore-profiling/ > > This patch adds profiling for aaload and aastore in order to improve > code generation for inline types. > > Array type, element type whether the array is flat or null free are > collected for both aaload and aastore. aastore already collects some > profiling (element type). In practice, the new profile collection scheme > at aastore replaces the old one. > > The patch includes changes to C2 so it leverages the new profiling. At > an aaload, if profiling reports a single array type, c2 casts the array > type to the profiled type if it helps avoid a flat array > check. Otherwise, if profiling reports no accurate type for the array, > c2 can cast the array to non flat or non null free based on profile > data. > > MonomorphicArrayCheck is also modified to take advantage of the new > profiling. So at an aastore, if profile data sugggests an array type, > the array should be always casted to that array type. > > Roland. > From mandy.chung at oracle.com Wed Nov 20 23:48:25 2019 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 20 Nov 2019 23:48:25 +0000 Subject: hg: valhalla/valhalla: [nestmates] Revise classData method that can be called as a BSM for condy Message-ID: <201911202348.xAKNmPlA011105@aojmv0008.oracle.com> Changeset: d104555d70ca Author: mchung Date: 2019-11-20 15:48 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d104555d70ca [nestmates] Revise classData method that can be called as a BSM for condy Also, a new ORIGINAL access mode bit is added to indicate that a Lookup is an orginial and not a teleported copy with full privilege access. ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/sun/invoke/util/VerifyAccess.java ! test/jdk/java/lang/invoke/AccessControlTest.java ! test/jdk/java/lang/invoke/DropLookupModeTest.java ! test/jdk/java/lang/invoke/defineHiddenClass/DefineClassWithClassData.java ! test/jdk/java/lang/invoke/modules/m3/jdk/test/ModuleAccessTest.java ! test/jdk/java/lang/invoke/nestmates/Invoker.java ! test/jdk/java/lang/invoke/nestmates/NestmateTest.java From david.simms at oracle.com Thu Nov 21 09:39:35 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Thu, 21 Nov 2019 09:39:35 +0000 Subject: hg: valhalla/valhalla: 166 new changesets Message-ID: <201911210939.xAL9diBN001097@aojmv0008.oracle.com> Changeset: 1edb08142cea Author: thartmann Date: 2019-11-08 09:16 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1edb08142cea 8233788: Remove useless asserts in PhaseCFG::insert_anti_dependences Summary: Removed useless asserts. Reviewed-by: kvn ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/gcm.cpp Changeset: 47c20fc6a517 Author: tschatzl Date: 2019-11-08 10:01 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/47c20fc6a517 8189737: Make HeapRegion not derive from Space Reviewed-by: sjohanss, kbarrett ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp ! src/hotspot/share/gc/cms/parNewGeneration.cpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.cpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp ! src/hotspot/share/gc/g1/heapRegion.inline.hpp ! src/hotspot/share/gc/g1/vmStructs_g1.hpp ! src/hotspot/share/gc/parallel/asPSYoungGen.cpp ! src/hotspot/share/gc/parallel/mutableSpace.cpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psMarkSweepDecorator.cpp ! src/hotspot/share/gc/parallel/psOldGen.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/gc/parallel/psYoungGen.cpp ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/shared/generation.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/spaceDecorator.cpp ! src/hotspot/share/gc/shared/spaceDecorator.hpp + src/hotspot/share/gc/shared/spaceDecorator.inline.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/G1CollectedHeap.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegion.java + src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/HeapRegionClosure.java + src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/g1/PrintRegionClosure.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/PrintRegionClosure.java ! test/hotspot/gtest/gc/g1/test_g1HeapVerifier.cpp Changeset: c709424ad48f Author: jvernee Date: 2019-11-08 10:55 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c709424ad48f 8233389: Add PrintIdeal to compiler directives Summary: Add PrintIdeal as a compiler directive in order to enable PrintIdeal for only a single method. Reviewed-by: roland, neliasso, vlivanov, thartmann ! src/hotspot/share/compiler/compilerDirectives.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp Changeset: 5606867a5e6e Author: zgu Date: 2019-11-08 09:50 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5606867a5e6e 8233339: Shenandoah: Centralize load barrier decisions into ShenandoahBarrierSet Reviewed-by: rkennke ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp Changeset: 66b1db608c12 Author: zgu Date: 2019-11-08 09:51 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/66b1db608c12 8233337: Shenandoah: Cleanup AArch64 SBSA::load_reference_barrier_not_null() Reviewed-by: rkennke ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp Changeset: 3760767a7231 Author: bpb Date: 2019-11-08 08:12 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3760767a7231 8220479: java/nio/channels/Selector/SelectWithConsumer.java failed at testTwoChannels() Reviewed-by: bpb Contributed-by: alan.bateman at oracle.com ! test/jdk/java/nio/channels/Selector/SelectWithConsumer.java Changeset: f92ef5d182b5 Author: zgu Date: 2019-11-08 11:41 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f92ef5d182b5 8233850: Shenandoah: Shenandoah thread count ergonomics should be container aware Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp Changeset: 7f1d2c3a99da Author: iklam Date: 2019-11-08 11:03 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7f1d2c3a99da 8233855: [TESTBUG] appcds/FieldLayoutFlags.java failed to clean up files after test Reviewed-by: hseigel ! test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java Changeset: 90cf1d4e712f Author: fyang Date: 2019-11-08 16:53 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/90cf1d4e712f 8233839: aarch64: missing memory barrier in NewObjectArrayStub and NewTypeArrayStub Reviewed-by: adinn ! src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp Changeset: 9e2f184eac99 Author: xuelei Date: 2019-11-08 18:35 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/9e2f184eac99 8233621: Mismatch in jsse.enableMFLNExtension property name Reviewed-by: mullan ! src/java.base/share/classes/sun/security/ssl/SSLExtension.java Changeset: 6bc29ebe053e Author: alanb Date: 2019-11-09 09:13 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6bc29ebe053e 8216472: (se) Stack overflow during selection operation leads to crash (win) Reviewed-by: alanb Contributed-by: akashche at redhat.com ! src/java.base/windows/classes/sun/nio/ch/WindowsSelectorImpl.java ! src/java.base/windows/native/libnio/ch/WindowsSelectorImpl.c + test/jdk/java/nio/channels/Selector/StackOverflowTest.java Changeset: 612c58965775 Author: alanb Date: 2019-11-09 11:48 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/612c58965775 8233435: (dc) DatagramChannel should allow IPv6 socket join IPv4 multicast groups (macOS, win) Reviewed-by: dfuchs ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/unix/native/libnio/ch/Net.c ! src/java.base/windows/native/libnio/ch/Net.c ! test/jdk/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java ! test/jdk/java/nio/channels/DatagramChannel/SocketOptionTests.java Changeset: d595f1faace2 Author: iignatyev Date: 2019-11-09 10:27 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d595f1faace2 8233745: [JVMCI] TranslatedException should serialize classloader and module info Reviewed-by: kvn, dnsimon ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/TranslatedException.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestTranslatedException.java Changeset: 586415e8abcb Author: chagedorn Date: 2019-11-11 10:41 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/586415e8abcb 8229694: JVM crash in SWPointer during C2 OSR compilation Summary: Handle the case where there is only 1 pack and no operations left when calling SuperWord::find_align_to_ref() to find the best alignment again. Reviewed-by: kvn, vlivanov, thartmann ! src/hotspot/share/opto/superword.cpp + test/hotspot/jtreg/compiler/loopopts/superword/AlignmentOnePack.java Changeset: 01d47d511f5f Author: mgronlun Date: 2019-11-11 11:25 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/01d47d511f5f 8231922: Could not find field with name revokedClass Reviewed-by: egahlin ! test/jdk/jdk/jfr/event/runtime/TestBiasedLockRevocationEvents.java Changeset: d3f1cb09b704 Author: rschmelter Date: 2019-11-11 12:06 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d3f1cb09b704 8233790: Forward output from heap dumper to jcmd/jmap Reviewed-by: stuefe, sspitsyn, cjplummer ! src/hotspot/share/services/attachListener.cpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/heapDumper.cpp ! src/hotspot/share/services/heapDumper.hpp Changeset: 333c2b653434 Author: sjohanss Date: 2019-11-11 13:20 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/333c2b653434 8233065: PSParallelCompact::move_and_update is unused and should be removed Reviewed-by: lkorinth, tschatzl ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.hpp Changeset: 0c5fb962e11e Author: igerasim Date: 2019-11-11 05:09 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/0c5fb962e11e 8233886: TEST_BUG jdk/java/net/CookieHandler/B6791927.java hit hardcoded expiration date Reviewed-by: chegar, vtewari ! test/jdk/java/net/CookieHandler/B6791927.java Changeset: d4cae08239f7 Author: egahlin Date: 2019-11-11 14:47 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d4cae08239f7 8230767: FlightRecorderListener returns null recording Reviewed-by: mseledtsov, mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecording.java + test/jdk/jdk/jfr/api/recorder/TestRecorderListenerWithDump.java Changeset: e4d7fcab43d7 Author: phedlin Date: 2018-04-24 13:59 +0200 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e4d7fcab43d7 8233498: Remove dead code. Reviewed-by: neliasso ! src/hotspot/cpu/sparc/c1_MacroAssembler_sparc.cpp ! src/hotspot/cpu/sparc/interp_masm_sparc.cpp ! src/hotspot/cpu/sparc/interp_masm_sparc.hpp ! src/hotspot/cpu/sparc/macroAssembler_sparc.cpp ! src/hotspot/cpu/sparc/macroAssembler_sparc.hpp ! src/hotspot/cpu/sparc/macroAssembler_sparc.inline.hpp Changeset: 36fde8064316 Author: goetz Date: 2019-11-11 16:24 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/36fde8064316 8231757: [ppc] Fix VerifyOops. Errors show since 8231058. Summary: Also make the checks print the wrong value and where a failure occurred. Reviewed-by: dholmes, mdoerr ! src/hotspot/cpu/ppc/c1_CodeStubs_ppc.cpp ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp ! src/hotspot/cpu/ppc/c1_MacroAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/g1/g1BarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/globalDefinitions_ppc.hpp ! src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp ! src/hotspot/cpu/ppc/macroAssembler_ppc.hpp ! src/hotspot/cpu/ppc/methodHandles_ppc.cpp ! src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp ! src/hotspot/cpu/ppc/stubGenerator_ppc.cpp ! test/hotspot/jtreg/runtime/CheckUnhandledOops/TestVerifyOops.java Changeset: b9a85aa023b1 Author: phedlin Date: 2019-11-11 16:59 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b9a85aa023b1 8233918: 8233498 broke build on SPARC Reviewed-by: eosterlund ! src/hotspot/cpu/sparc/interp_masm_sparc.hpp Changeset: 3b9eeae66fa0 Author: coleenp Date: 2019-11-11 12:11 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3b9eeae66fa0 8232735: Convert PrintJNIResolving to Unified Logging Summary: converted the existing output at debug level because it is noisy Reviewed-by: iklam, dholmes ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/prims/jniCheck.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/nativeLookup.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp Changeset: 51196a273f8c Author: dtitov Date: 2019-11-11 11:09 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/51196a273f8c 8233868: Unproblem list sun/tools/jstat/jstatClassloadOutput1.sh Reviewed-by: amenkov, cjplummer ! test/jdk/ProblemList.txt Changeset: aebd72de84b0 Author: henryjen Date: 2019-11-11 17:43 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/aebd72de84b0 8231863: Crash if classpath is read from @argument file and the main gets option argument Reviewed-by: alanb, mchung Contributed-by: Mat Carter ! src/java.base/share/native/libjli/args.c ! test/jdk/tools/launcher/ArgsFileTest.java ! test/jdk/tools/launcher/TestHelper.java Changeset: cfc7bb9a5a92 Author: jlahoda Date: 2019-11-12 06:32 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/cfc7bb9a5a92 8232684: Make switch expressions final Reviewed-by: alanb, mcimadamore, kvn ! src/java.base/share/classes/jdk/internal/PreviewFeature.java ! src/jdk.compiler/share/classes/com/sun/source/tree/CaseTree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/SwitchExpressionTree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/Tree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/TreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/tree/YieldTree.java ! src/jdk.compiler/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Preview.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! test/hotspot/jtreg/runtime/execstack/TestMT.java ! test/hotspot/jtreg/vmTestbase/gc/gctests/gctest02/gctest02.java ! test/hotspot/jtreg/vmTestbase/jit/regression/b4446672/b4446672.java ! test/hotspot/jtreg/vmTestbase/nsk/monitoring/stress/thread/strace001.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jdi/JDIEventsDebuggee.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jdi/MonitorEventsDebuggee.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jpda/StateTestThread.java ! test/hotspot/jtreg/vmTestbase/nsk/share/locks/LockingThread.java ! test/hotspot/jtreg/vmTestbase/nsk/share/locks/MonitorLockingThread.java ! test/hotspot/jtreg/vmTestbase/nsk/share/runner/ThreadsRunner.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/jni/GarbageGenerator.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace001.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace002.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace005.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/strace/strace006.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/thread/thread005.java ! test/hotspot/jtreg/vmTestbase/nsk/stress/thread/thread006.java ! test/jdk/com/sun/jdi/InvokeHangTest.java ! test/jdk/com/sun/jdi/SimulResumerTest.java ! test/jdk/com/sun/jdi/TwoThreadsTest.java ! test/jdk/java/awt/Graphics2D/MTGraphicsAccessTest/MTGraphicsAccessTest.java ! test/jdk/jdk/jfr/event/runtime/TestThreadCpuTimeEvent.java ! test/langtools/tools/javac/ConditionalWithVoid.java ! test/langtools/tools/javac/ConditionalWithVoid.out ! test/langtools/tools/javac/diags/examples.not-yet.txt ! test/langtools/tools/javac/diags/examples/BreakOutsideSwitchExpression.java ! test/langtools/tools/javac/diags/examples/ContinueOutsideSwitchExpression.java ! test/langtools/tools/javac/diags/examples/IllegalRefToRestrictedType.java ! test/langtools/tools/javac/diags/examples/IncompatibleTypesInSwitchExpression.java ! test/langtools/tools/javac/diags/examples/InvalidYield.java ! test/langtools/tools/javac/diags/examples/InvalidYieldWarning.java ! test/langtools/tools/javac/diags/examples/MultipleCaseLabels.java ! test/langtools/tools/javac/diags/examples/NoSwitchExpression.java ! test/langtools/tools/javac/diags/examples/NoSwitchExpressionQualify.java ! test/langtools/tools/javac/diags/examples/NotExhaustive.java - test/langtools/tools/javac/diags/examples/RestrictedTypeNotAllowedPreview.java ! test/langtools/tools/javac/diags/examples/ReturnOutsideSwitchExpression.java ! test/langtools/tools/javac/diags/examples/RuleCompletesNormally.java ! test/langtools/tools/javac/diags/examples/SwitchCaseUnexpectedStatement.java ! test/langtools/tools/javac/diags/examples/SwitchExpressionCompletesNormally.java ! test/langtools/tools/javac/diags/examples/SwitchExpressionEmpty.java ! test/langtools/tools/javac/diags/examples/SwitchExpressionNoResultExpressions.java ! test/langtools/tools/javac/diags/examples/SwitchExpressionTargetCantBeVoid.java ! test/langtools/tools/javac/diags/examples/SwitchExpressions.java ! test/langtools/tools/javac/diags/examples/SwitchMixingCaseTypes.java ! test/langtools/tools/javac/diags/examples/SwitchRules.java ! test/langtools/tools/javac/expswitch/ExpSwitchNestingTest.java ! test/langtools/tools/javac/lambda/BadSwitchExpressionLambda.java ! test/langtools/tools/javac/lambda/BadSwitchExpressionLambda.out ! test/langtools/tools/javac/parser/JavacParserTest.java ! test/langtools/tools/javac/switchexpr/BlockExpression.java ! test/langtools/tools/javac/switchexpr/BooleanNumericNonNumeric.java ! test/langtools/tools/javac/switchexpr/BooleanNumericNonNumeric.out ! test/langtools/tools/javac/switchexpr/BreakTest.java ! test/langtools/tools/javac/switchexpr/CRT.java ! test/langtools/tools/javac/switchexpr/DefiniteAssignment1.java ! test/langtools/tools/javac/switchexpr/DefiniteAssignment2.java ! test/langtools/tools/javac/switchexpr/DefiniteAssignment2.out ! test/langtools/tools/javac/switchexpr/EmptySwitch.java ! test/langtools/tools/javac/switchexpr/EmptySwitch.out ! test/langtools/tools/javac/switchexpr/ExhaustiveEnumSwitch.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitch-old.out ! test/langtools/tools/javac/switchexpr/ExpressionSwitch.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks1.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks2.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBreaks2.out ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBugs.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchBugsInGen.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchCodeFromJLS.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchDA.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchEmbedding.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchFallThrough.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchFallThrough1.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchFlow.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchFlow.out ! test/langtools/tools/javac/switchexpr/ExpressionSwitchInExpressionSwitch.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchInfer.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchInfer.out ! test/langtools/tools/javac/switchexpr/ExpressionSwitchIntersectionTypes.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchNotExhaustive.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchNotExhaustive.out ! test/langtools/tools/javac/switchexpr/ExpressionSwitchToString.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchUnreachable.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchUnreachable.out ! test/langtools/tools/javac/switchexpr/LambdaCapture.java ! test/langtools/tools/javac/switchexpr/ParseIncomplete.java ! test/langtools/tools/javac/switchexpr/ParserRecovery.java ! test/langtools/tools/javac/switchexpr/ParserRecovery.out ! test/langtools/tools/javac/switchexpr/SwitchExpressionIsNotAConstant.java ! test/langtools/tools/javac/switchexpr/SwitchExpressionScopesIsolated.java ! test/langtools/tools/javac/switchexpr/SwitchExpressionScopesIsolated.out ! test/langtools/tools/javac/switchexpr/SwitchExpressionSimpleVisitorTest.java ! test/langtools/tools/javac/switchexpr/TryCatch.java ! test/langtools/tools/javac/switchexpr/TryCatchFinally.java ! test/langtools/tools/javac/switchexpr/WarnWrongYieldTest.java ! test/langtools/tools/javac/switchexpr/WarnWrongYieldTest.out ! test/langtools/tools/javac/switchexpr/WrongBreakTest.java ! test/langtools/tools/javac/switchexpr/WrongBreakTest.out ! test/langtools/tools/javac/switchexpr/WrongYieldTest.java ! test/langtools/tools/javac/switchexpr/WrongYieldTest.out ! test/langtools/tools/javac/switchextra/CaseTest.java ! test/langtools/tools/javac/switchextra/DefiniteAssignment1.java ! test/langtools/tools/javac/switchextra/DefiniteAssignment2.java ! test/langtools/tools/javac/switchextra/DefiniteAssignment2.out ! test/langtools/tools/javac/switchextra/MultipleLabelsExpression-old.out ! test/langtools/tools/javac/switchextra/MultipleLabelsExpression.java ! test/langtools/tools/javac/switchextra/MultipleLabelsStatement-old.out ! test/langtools/tools/javac/switchextra/MultipleLabelsStatement.java ! test/langtools/tools/javac/switchextra/RuleParsingTest.java ! test/langtools/tools/javac/switchextra/SwitchArrowBrokenConstant.java ! test/langtools/tools/javac/switchextra/SwitchArrowBrokenConstant.out ! test/langtools/tools/javac/switchextra/SwitchStatementArrow-old.out ! test/langtools/tools/javac/switchextra/SwitchStatementArrow.java ! test/langtools/tools/javac/switchextra/SwitchStatementBroken.java ! test/langtools/tools/javac/switchextra/SwitchStatementBroken.out ! test/langtools/tools/javac/switchextra/SwitchStatementBroken2.java ! test/langtools/tools/javac/switchextra/SwitchStatementBroken2.out ! test/langtools/tools/javac/switchextra/SwitchStatementScopesIsolated.java ! test/langtools/tools/javac/switchextra/SwitchStatementScopesIsolated.out ! test/langtools/tools/jdeps/listdeps/ListModuleDeps.java Changeset: ff1887930406 Author: thartmann Date: 2019-11-12 10:16 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ff1887930406 8233529: loopTransform.cpp:2984: Error: assert(p_f->Opcode() == Op_IfFalse) failed Summary: Strengthened asserts in locate_pre_from_main() and added a check for is_main_no_pre_loop(). Reviewed-by: kvn, vlivanov ! src/hotspot/share/opto/loopTransform.cpp + test/hotspot/jtreg/compiler/loopopts/TestRemoveMainPostLoops.java Changeset: f0dca628176c Author: dnsimon Date: 2019-11-12 10:19 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f0dca628176c 8233900: [JVMCI] improve help text for EnableJVMCIProduct option Reviewed-by: kvn ! src/hotspot/share/jvmci/jvmci_globals.hpp Changeset: b046ba510bbc Author: igerasim Date: 2019-11-12 01:36 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b046ba510bbc 8233884: Avoid looking up standard charsets in security libraries Reviewed-by: coffeys ! src/java.base/share/classes/com/sun/crypto/provider/JceKeyStore.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java ! src/java.base/share/classes/com/sun/crypto/provider/TlsPrfGenerator.java ! src/java.base/share/classes/javax/crypto/CryptoPermissions.java ! src/java.base/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! src/java.base/share/classes/sun/security/provider/ConfigFile.java ! src/java.base/share/classes/sun/security/provider/DomainKeyStore.java ! src/java.base/share/classes/sun/security/provider/JavaKeyStore.java ! src/java.base/share/classes/sun/security/provider/KeyProtector.java ! src/java.base/share/classes/sun/security/provider/PolicyFile.java ! src/java.base/share/classes/sun/security/ssl/SSLLogger.java ! src/java.base/share/classes/sun/security/util/DerInputStream.java ! src/java.base/share/classes/sun/security/util/DerOutputStream.java ! src/java.base/share/classes/sun/security/util/DerValue.java ! src/java.base/share/classes/sun/security/util/DomainName.java ! src/java.base/share/classes/sun/security/util/HexDumpEncoder.java ! src/java.base/share/classes/sun/security/x509/AVA.java ! src/java.base/share/classes/sun/security/x509/X509CertImpl.java ! src/java.security.jgss/share/classes/sun/security/jgss/GSSNameImpl.java ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/Krb5NameElement.java ! src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSNameElement.java ! src/java.security.jgss/share/classes/sun/security/jgss/wrapper/NativeGSSFactory.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ETypeInfo.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/PAData.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/PAForUserEnc.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/AesDkCrypto.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/AesSha2DkCrypto.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/dk/DkCrypto.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ktab/KeyTabEntry.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ktab/KeyTabOutputStream.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/util/KerberosString.java ! src/java.security.sasl/share/classes/com/sun/security/sasl/ClientFactoryImpl.java ! src/java.security.sasl/share/classes/com/sun/security/sasl/CramMD5Client.java ! src/java.security.sasl/share/classes/com/sun/security/sasl/CramMD5Server.java ! src/java.security.sasl/share/classes/com/sun/security/sasl/ExternalClient.java ! src/java.security.sasl/share/classes/com/sun/security/sasl/PlainClient.java ! src/java.security.sasl/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java ! src/java.security.sasl/share/classes/com/sun/security/sasl/digest/DigestMD5Client.java ! src/java.security.sasl/share/classes/com/sun/security/sasl/digest/DigestMD5Server.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Util.java ! src/jdk.crypto.ucrypto/solaris/classes/com/oracle/security/ucrypto/Config.java ! src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java Changeset: b398685dd029 Author: eosterlund Date: 2019-11-12 09:25 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b398685dd029 8233506: ZGC: the load for Reference.get() can be converted to a load for strong refs Reviewed-by: thartmann, neliasso, pliden ! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp ! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/graphKit.hpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/memnode.hpp Changeset: f51714d3385d Author: eosterlund Date: 2019-11-12 09:27 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f51714d3385d 8224817: Implementation of JEP 364: ZGC on macOS Reviewed-by: pliden, stefank ! make/autoconf/hotspot.m4 + src/hotspot/os/bsd/gc/z/zBackingFile_bsd.cpp + src/hotspot/os/bsd/gc/z/zBackingFile_bsd.hpp + src/hotspot/os/bsd/gc/z/zLargePages_bsd.cpp + src/hotspot/os/bsd/gc/z/zNUMA_bsd.cpp + src/hotspot/os/bsd/gc/z/zPhysicalMemoryBacking_bsd.cpp + src/hotspot/os/bsd/gc/z/zPhysicalMemoryBacking_bsd.hpp Changeset: 65dc025d5e7e Author: jiefu Date: 2019-11-11 17:40 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/65dc025d5e7e 8233885: Test fails with assert(comp != __null) failed: Ensure we have a compiler Reviewed-by: thartmann, iveresov ! src/hotspot/share/compiler/compilerDefinitions.cpp ! src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp + test/hotspot/jtreg/compiler/compilercontrol/CompilationModeHighOnlyTest.java Changeset: 4dbdb7a8fa75 Author: fweimer Date: 2019-11-12 12:19 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/4dbdb7a8fa75 8233941: adlc should not generate Pipeline_Use_Cycle_Mask::operator= Summary: Removed useless = operator. Reviewed-by: kvn, thartmann ! src/hotspot/share/adlc/output_h.cpp Changeset: 3786a0962570 Author: jboes Date: 2019-11-08 11:15 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3786a0962570 8232853: AuthenticationFilter.Cache::remove may throw ConcurrentModificationException Summary: Change implementation to use iterator instead of plain LinkedList Reviewed-by: dfuchs, vtewari ! src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java + test/jdk/java/net/httpclient/AuthFilterCacheTest.java Changeset: ad05ed6f2a77 Author: mdoerr Date: 2019-11-12 16:13 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ad05ed6f2a77 8233820: Test crashed with assert(phi->operand_count() != 1 || phi->subst() != phi) failed: missed trivial simplification Summary: Verification code needs to skip illegal phi functions. Reviewed-by: thartmann, vlivanov ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_Optimizer.cpp Changeset: 404560ee1088 Author: tschatzl Date: 2019-11-12 16:28 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/404560ee1088 8233792: TestG1ParallelPhases.java fails with phase NonYoungFreeCSet not found (2) Reviewed-by: lkorinth, kbarrett ! test/jdk/jdk/jfr/event/gc/collection/TestG1ParallelPhases.java Changeset: 642d7d7ed426 Author: mbalao Date: 2019-11-12 12:36 -0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/642d7d7ed426 8233946: Add @since 13 annotation to KerberosPrincipal.KRB_NT_ENTERPRISE field Reviewed-by: clanger ! src/java.security.jgss/share/classes/javax/security/auth/kerberos/KerberosPrincipal.java Changeset: 3d2575331a41 Author: darcy Date: 2019-11-12 10:45 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3d2575331a41 8233940: Preview API tests for String methods should use ${jdk.version} as -source arg Reviewed-by: jlaskey, jlahoda ! test/jdk/java/lang/String/Formatted.java ! test/jdk/java/lang/String/StripIndent.java + test/jdk/java/lang/String/TEST.properties ! test/jdk/java/lang/String/TranslateEscapes.java Changeset: b9a42ca342db Author: eosterlund Date: 2019-11-12 20:01 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b9a42ca342db 8233061: ZGC: Enforce memory ordering in segmented bit maps Reviewed-by: pliden, stefank ! src/hotspot/share/gc/z/zLiveMap.cpp ! src/hotspot/share/gc/z/zLiveMap.inline.hpp Changeset: c60978f87d45 Author: eosterlund Date: 2019-11-12 20:01 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c60978f87d45 8233797: ZGC: Unify naming convention for functions using atomics Reviewed-by: pliden, stefank ! src/hotspot/share/gc/z/zLiveMap.cpp ! src/hotspot/share/gc/z/zLiveMap.hpp ! src/hotspot/share/gc/z/zLiveMap.inline.hpp ! src/hotspot/share/gc/z/zMarkCache.inline.hpp ! src/hotspot/share/gc/z/zMarkStack.hpp ! src/hotspot/share/gc/z/zMarkStack.inline.hpp ! src/hotspot/share/gc/z/zMarkStackAllocator.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp ! test/hotspot/gtest/gc/z/test_zLiveMap.cpp Changeset: 1251d78fafbf Author: eosterlund Date: 2019-11-12 20:14 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1251d78fafbf 8230661: ZGC: Stop reloading oops in load barriers Reviewed-by: pliden, stefank ! src/hotspot/share/gc/z/zBarrier.hpp ! src/hotspot/share/gc/z/zBarrier.inline.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zUnload.cpp ! src/hotspot/share/gc/z/zUnload.hpp Changeset: d6d8fdc95ed2 Author: fweimer Date: 2019-11-12 21:00 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d6d8fdc95ed2 8233880: Support compilers with multi-digit major version numbers Reviewed-by: tbell ! make/autoconf/toolchain.m4 Changeset: 8910b995a2ee Author: bchristi Date: 2019-11-12 13:49 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8910b995a2ee 8226297: Dual-pivot quicksort improvements Reviewed-by: dl, lbourges Contributed-by: Vladimir Yaroslavskiy ! src/java.base/share/classes/java/util/Arrays.java ! src/java.base/share/classes/java/util/ArraysParallelSortHelpers.java ! src/java.base/share/classes/java/util/DualPivotQuicksort.java - test/jdk/java/util/Arrays/ParallelSorting.java ! test/jdk/java/util/Arrays/Sorting.java + test/jdk/java/util/Arrays/java.base/java/util/SortingHelper.java Changeset: 1a79b4bfc85a Author: naoto Date: 2019-11-12 14:05 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1a79b4bfc85a 8232860: Error formatting integer values with MessageFormat.format() using HOST provider Reviewed-by: rriggs ! src/java.base/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/java.base/share/classes/sun/util/locale/provider/HostLocaleProviderAdapter.java ! src/java.base/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c ! test/jdk/java/util/Locale/LocaleProviders.java ! test/jdk/java/util/Locale/LocaleProvidersRun.java Changeset: 8c9d0451433b Author: amlu Date: 2019-11-13 09:09 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8c9d0451433b 8233961: Problem list tools/jlink/JLinkReproducibleTest.java for windows-all Reviewed-by: alanb ! test/jdk/ProblemList.txt Changeset: 846fee5ea75e Author: ysuenaga Date: 2019-11-13 10:27 +0900 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/846fee5ea75e 8233785: Incorrect JDK version is reported in hs_err log Reviewed-by: dholmes, stuefe ! src/hotspot/share/runtime/java.cpp Changeset: a8104278b4d0 Author: thartmann Date: 2019-11-13 08:43 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a8104278b4d0 8233656: assert(d->is_CFG() && n->is_CFG()) failed: must have CFG nodes Summary: Explicitly handle ProjNodes with TOP input. Reviewed-by: kvn, vlivanov ! src/hotspot/share/opto/phaseX.cpp Changeset: 6c78185c99d7 Author: michaelm Date: 2019-11-13 09:09 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6c78185c99d7 8233958: Memory retention due to HttpsURLConnection finalizer that serves no purpose Reviewed-by: dfuchs, rriggs ! src/java.base/share/classes/sun/net/www/protocol/https/DelegateHttpsURLConnection.java ! src/java.base/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java Changeset: dc1899bb84c0 Author: smonteith Date: 2019-11-13 17:24 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/dc1899bb84c0 8231841: AArch64: debug.cpp help() is missing an AArch64 line for pns Summary: Adds missing line for aarch64 to debug.cpp help() for pns Reviewed-by: adinn Contributed-by: alan.hayward at arm.com ! src/hotspot/share/utilities/debug.cpp Changeset: 7bbaa3c416e7 Author: mdoerr Date: 2019-10-21 19:58 +0200 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7bbaa3c416e7 8230459: Test failed to resume JVMCI CompilerThread Reviewed-by: dholmes, kvn ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileBroker.hpp Changeset: f0312c7d5b37 Author: bsrbnd Date: 2019-11-13 11:21 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f0312c7d5b37 8214239: Missing x86_64.ad patterns for clearing and setting long vector bits Reviewed-by: kvn, vlivanov, jrose, sviswanathan ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad + test/hotspot/jtreg/compiler/c2/TestBitSetAndReset.java + test/micro/org/openjdk/bench/vm/compiler/BitSetAndReset.java Changeset: ba6c248cae19 Author: lkorinth Date: 2019-11-13 11:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ba6c248cae19 8232365: Implementation for JEP 363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector Reviewed-by: kbarrett, tschatzl, erikj, coleenp, dholmes ! make/autoconf/hotspot.m4 ! make/hotspot/lib/JvmDtraceObjects.gmk ! make/hotspot/lib/JvmFeatures.gmk ! make/hotspot/src/native/dtrace/generateJvmOffsets.cpp ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/globals_aarch64.hpp ! src/hotspot/cpu/arm/globals_arm.hpp ! src/hotspot/cpu/ppc/globals_ppc.hpp ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/s390/globals_s390.hpp ! src/hotspot/cpu/sparc/globals_sparc.hpp ! src/hotspot/cpu/x86/globals_x86.hpp ! src/hotspot/cpu/zero/globals_zero.hpp - src/hotspot/share/gc/cms/adaptiveFreeList.cpp - src/hotspot/share/gc/cms/adaptiveFreeList.hpp - src/hotspot/share/gc/cms/allocationStats.cpp - src/hotspot/share/gc/cms/allocationStats.hpp - src/hotspot/share/gc/cms/cmsArguments.cpp - src/hotspot/share/gc/cms/cmsArguments.hpp - src/hotspot/share/gc/cms/cmsCardTable.cpp - src/hotspot/share/gc/cms/cmsCardTable.hpp - src/hotspot/share/gc/cms/cmsGCStats.cpp - src/hotspot/share/gc/cms/cmsGCStats.hpp - src/hotspot/share/gc/cms/cmsHeap.cpp - src/hotspot/share/gc/cms/cmsHeap.hpp - src/hotspot/share/gc/cms/cmsHeap.inline.hpp - src/hotspot/share/gc/cms/cmsLockVerifier.cpp - src/hotspot/share/gc/cms/cmsLockVerifier.hpp - src/hotspot/share/gc/cms/cmsOopClosures.hpp - src/hotspot/share/gc/cms/cmsOopClosures.inline.hpp - src/hotspot/share/gc/cms/cmsVMOperations.cpp - src/hotspot/share/gc/cms/cmsVMOperations.hpp - src/hotspot/share/gc/cms/cms_globals.hpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.hpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.inline.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.inline.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepThread.cpp - src/hotspot/share/gc/cms/concurrentMarkSweepThread.hpp - src/hotspot/share/gc/cms/freeChunk.cpp - src/hotspot/share/gc/cms/freeChunk.hpp - src/hotspot/share/gc/cms/gSpaceCounters.cpp - src/hotspot/share/gc/cms/gSpaceCounters.hpp - src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.cpp - src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.hpp - src/hotspot/share/gc/cms/parNewGeneration.cpp - src/hotspot/share/gc/cms/parNewGeneration.hpp - src/hotspot/share/gc/cms/parNewGeneration.inline.hpp - src/hotspot/share/gc/cms/parOopClosures.hpp - src/hotspot/share/gc/cms/parOopClosures.inline.hpp - src/hotspot/share/gc/cms/promotionInfo.cpp - src/hotspot/share/gc/cms/promotionInfo.hpp - src/hotspot/share/gc/cms/promotionInfo.inline.hpp - src/hotspot/share/gc/cms/vmStructs_cms.hpp - src/hotspot/share/gc/cms/yieldingWorkgroup.cpp - src/hotspot/share/gc/cms/yieldingWorkgroup.hpp ! src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp ! src/hotspot/share/gc/parallel/psPromotionManager.hpp ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/serial/tenuredGeneration.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.hpp ! src/hotspot/share/gc/shared/blockOffsetTable.cpp ! src/hotspot/share/gc/shared/blockOffsetTable.hpp ! src/hotspot/share/gc/shared/blockOffsetTable.inline.hpp ! src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.cpp ! src/hotspot/share/gc/shared/collectedHeap.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/gcArguments.cpp ! src/hotspot/share/gc/shared/gcCause.cpp ! src/hotspot/share/gc/shared/gcCause.hpp ! src/hotspot/share/gc/shared/gcConfig.cpp ! src/hotspot/share/gc/shared/gcConfiguration.cpp ! src/hotspot/share/gc/shared/gcName.hpp ! src/hotspot/share/gc/shared/gcStats.hpp ! src/hotspot/share/gc/shared/gcTrace.hpp ! src/hotspot/share/gc/shared/gcTraceSend.cpp ! src/hotspot/share/gc/shared/gcVMOperations.cpp ! src/hotspot/share/gc/shared/gc_globals.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/generation.cpp ! src/hotspot/share/gc/shared/generation.hpp ! src/hotspot/share/gc/shared/generationSpec.cpp ! src/hotspot/share/gc/shared/jvmFlagConstraintsGC.cpp ! src/hotspot/share/gc/shared/jvmFlagConstraintsGC.hpp ! src/hotspot/share/gc/shared/preservedMarks.hpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp ! src/hotspot/share/gc/shared/vmStructs_gc.hpp ! src/hotspot/share/gc/shared/workerPolicy.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace.hpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/markWord.hpp ! src/hotspot/share/oops/markWord.inline.hpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/macro.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.hpp ! src/hotspot/share/runtime/flags/jvmFlag.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/vmOperations.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/utilities/dtrace_disabled.hpp ! src/hotspot/share/utilities/macros.hpp ! src/java.base/share/man/java.1 - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/AdaptiveFreeList.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSBitMap.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSCollector.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSHeap.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ConcurrentMarkSweepGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/LinearAllocBlock.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ParNewGeneration.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GCName.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/Generation.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GenerationFactory.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/Universe.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Mark.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Thread.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalRuntime.java ! test/hotspot/jtreg/TEST.ROOT ! test/hotspot/jtreg/TEST.groups ! test/hotspot/jtreg/compiler/c2/aarch64/TestVolatiles.java - test/hotspot/jtreg/compiler/c2/aarch64/TestVolatilesCMS.java - test/hotspot/jtreg/compiler/c2/aarch64/TestVolatilesCMSCondMark.java ! test/hotspot/jtreg/gc/TestAgeOutput.java ! test/hotspot/jtreg/gc/TestFullGCCount.java ! test/hotspot/jtreg/gc/TestGenerationPerfCounter.java - test/hotspot/jtreg/gc/TestMemoryInitializationWithCMS.java ! test/hotspot/jtreg/gc/TestMemoryMXBeansAndPoolsPresence.java ! test/hotspot/jtreg/gc/TestNumWorkerOutput.java ! test/hotspot/jtreg/gc/TestPolicyNamePerfCounter.java ! test/hotspot/jtreg/gc/TestSmallHeap.java ! test/hotspot/jtreg/gc/TestSystemGC.java ! test/hotspot/jtreg/gc/arguments/GCTypes.java ! test/hotspot/jtreg/gc/arguments/TestAlignmentToUseLargePages.java - test/hotspot/jtreg/gc/arguments/TestCMSHeapSizeFlags.java ! test/hotspot/jtreg/gc/arguments/TestDisableDefaultGC.java ! test/hotspot/jtreg/gc/arguments/TestMaxNewSize.java ! test/hotspot/jtreg/gc/arguments/TestNewRatioFlag.java ! test/hotspot/jtreg/gc/arguments/TestNewSizeFlags.java ! test/hotspot/jtreg/gc/arguments/TestParallelGCThreads.java ! test/hotspot/jtreg/gc/arguments/TestParallelRefProc.java ! test/hotspot/jtreg/gc/arguments/TestSelectDefaultGC.java ! test/hotspot/jtreg/gc/arguments/TestSurvivorRatioFlag.java ! test/hotspot/jtreg/gc/arguments/TestUseCompressedOopsErgo.java - test/hotspot/jtreg/gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java ! test/hotspot/jtreg/gc/class_unloading/TestClassUnloadingDisabled.java - test/hotspot/jtreg/gc/cms/DisableResizePLAB.java - test/hotspot/jtreg/gc/cms/GuardShrinkWarning.java - test/hotspot/jtreg/gc/cms/TestBubbleUpRef.java - test/hotspot/jtreg/gc/cms/TestCMSScavengeBeforeRemark.java - test/hotspot/jtreg/gc/cms/TestCriticalPriority.java - test/hotspot/jtreg/gc/cms/TestMBeanCMS.java - test/hotspot/jtreg/gc/concurrent_phase_control/TestConcurrentPhaseControlCMS.java ! test/hotspot/jtreg/gc/ergonomics/TestDynamicNumberOfGCThreads.java ! test/hotspot/jtreg/gc/ergonomics/TestInitialGCThreadLogging.java ! test/hotspot/jtreg/gc/logging/TestGCId.java - test/hotspot/jtreg/gc/metaspace/TestMetaspaceCMSCancel.java ! test/hotspot/jtreg/gc/metaspace/TestSizeTransitions.java - test/hotspot/jtreg/gc/startup_warnings/TestCMS.java ! test/hotspot/jtreg/gc/stress/TestReclaimStringsLeaksMemory.java - test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithCMS.java - test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithCMS.java - test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithParNew.java - test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithParNew.java - test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithCMS.java ! test/hotspot/jtreg/gc/survivorAlignment/SurvivorAlignmentTestMain.java ! test/hotspot/jtreg/runtime/7167069/PrintAsFlag.java ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOption.java ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java ! test/hotspot/jtreg/runtime/CommandLine/TestNullTerminatedFlags.java ! test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java ! test/hotspot/jtreg/runtime/cds/appcds/CommandLineFlagCombo.java ! test/hotspot/jtreg/runtime/cds/appcds/sharedStrings/IncompatibleOptions.java ! test/hotspot/jtreg/runtime/testlibrary/ClassUnloadCommon.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java ! test/hotspot/jtreg/serviceability/sa/TestIntConstant.java ! test/hotspot/jtreg/serviceability/sa/TestUniverse.java ! test/hotspot/jtreg/vmTestbase/metaspace/gc/watermark_0_1/TestDescription.java ! test/hotspot/jtreg/vmTestbase/metaspace/gc/watermark_10_20/TestDescription.java ! test/hotspot/jtreg/vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java ! test/hotspot/jtreg/vmTestbase/metaspace/gc/watermark_99_100/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java ! test/jdk/com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java ! test/jdk/java/lang/management/GarbageCollectorMXBean/GcInfoCompositeType.java ! test/jdk/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java ! test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest.java ! test/jdk/java/lang/management/MemoryMXBean/LowMemoryTest2.sh - test/jdk/java/lang/management/MemoryMXBean/MemoryManagementConcMarkSweepGC.sh ! test/jdk/java/lang/management/MemoryMXBean/PendingAllGC.sh ! test/jdk/java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java ! test/jdk/jdk/jfr/event/gc/collection/GCEventAll.java - test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithParNew.java - test/jdk/jdk/jfr/event/gc/collection/TestYoungGarbageCollectionEventWithParNew.java ! test/jdk/jdk/jfr/event/gc/detailed/PromotionEvent.java - test/jdk/jdk/jfr/event/gc/detailed/TestCMSConcurrentModeFailureEvent.java - test/jdk/jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParNew.java - test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventConcurrentCMS.java - test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventParNewCMS.java - test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSMarkSweep.java ! test/jdk/jdk/jfr/event/gc/stacktrace/AllocationStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestConcMarkSweepAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceConcMarkSweepGCAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestParNewAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/oldobject/TestCMS.java ! test/jdk/jdk/jfr/event/oldobject/TestMetadataRetention.java ! test/jdk/jdk/jfr/event/runtime/TestClassLoadingStatisticsEvent.java ! test/jdk/jdk/jfr/event/runtime/TestClassUnloadEvent.java ! test/jdk/jdk/jfr/event/runtime/TestVmFlagChangedEvent.java ! test/lib/jdk/test/lib/Utils.java ! test/lib/jdk/test/lib/jfr/GCHelper.java ! test/lib/sun/hotspot/WhiteBox.java ! test/lib/sun/hotspot/gc/GC.java Changeset: 57ad70bcf06c Author: coffeys Date: 2019-11-13 11:27 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/57ad70bcf06c 8233731: repeated typo "fro" for "for" Reviewed-by: dfuchs Contributed-by: kiran.sidhartha.ravikumar at oracle.com ! src/java.base/share/classes/java/util/Arrays.java Changeset: 15936b142f86 Author: coleenp Date: 2019-11-13 08:23 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/15936b142f86 8233913: Remove implicit conversion from Method* to methodHandle Summary: Fix call sites to use existing THREAD local or pass down THREAD local for shallower callsites. Make linkResolver methods return Method* for caller to handleize if needed. Reviewed-by: iklam, thartmann, hseigel ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/aot/aotCompiledMethod.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/ci/ciExceptionHandler.cpp ! src/hotspot/share/ci/ciField.cpp ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/ci/ciMethod.cpp ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/ci/ciStreams.cpp ! src/hotspot/share/classfile/bytecodeAssembler.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/code/compiledIC.cpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/tieredThresholdPolicy.cpp ! src/hotspot/share/compiler/tieredThresholdPolicy.hpp ! src/hotspot/share/interpreter/abstractInterpreter.cpp ! src/hotspot/share/interpreter/bytecode.cpp ! src/hotspot/share/interpreter/bytecode.hpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/interpreter/rewriter.cpp ! src/hotspot/share/interpreter/rewriter.hpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.cpp ! src/hotspot/share/jvmci/compilerRuntime.cpp ! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp ! src/hotspot/share/jvmci/jvmciCompiler.cpp ! src/hotspot/share/jvmci/jvmciCompiler.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciEnv.cpp ! src/hotspot/share/jvmci/jvmciJavaClasses.cpp ! src/hotspot/share/jvmci/jvmciRuntime.cpp ! src/hotspot/share/jvmci/jvmciRuntime.hpp ! src/hotspot/share/memory/dynamicArchive.cpp ! src/hotspot/share/memory/heapShared.cpp ! src/hotspot/share/memory/metaspaceShared.cpp ! src/hotspot/share/memory/metaspaceShared.hpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/fieldInfo.hpp ! src/hotspot/share/oops/fieldStreams.hpp + src/hotspot/share/oops/fieldStreams.inline.hpp ! src/hotspot/share/oops/generateOopMap.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp ! src/hotspot/share/prims/jvmtiCodeBlobEvents.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.hpp ! src/hotspot/share/prims/methodComparator.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/prims/nativeLookup.cpp ! src/hotspot/share/prims/stackwalk.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/fieldDescriptor.cpp ! src/hotspot/share/runtime/fieldDescriptor.inline.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/handles.hpp ! src/hotspot/share/runtime/handles.inline.hpp ! src/hotspot/share/runtime/javaCalls.cpp ! src/hotspot/share/runtime/reflection.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! src/hotspot/share/runtime/vframeArray.cpp ! src/hotspot/share/utilities/exceptions.cpp ! src/hotspot/share/utilities/xmlstream.cpp ! src/hotspot/share/utilities/xmlstream.hpp Changeset: c8e15590c7cc Author: amlu Date: 2019-11-13 21:56 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c8e15590c7cc 8234079: ZipFileInputStreamSkipTest.java runs zero test Reviewed-by: lancea ! test/jdk/java/util/zip/ZipFile/ZipFileInputStreamSkipTest.java Changeset: 3f57daa2d6eb Author: jjg Date: 2019-11-13 10:33 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3f57daa2d6eb 8234025: Elements.getPackageElement(ModuleElement,CharSequence) returns null for unnamed package Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java + test/langtools/tools/javac/api/TestModuleUnnamedPackage.java Changeset: 27a266d5fb13 Author: mullan Date: 2019-11-13 13:43 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/27a266d5fb13 8214483: Remove algorithms that use MD5 or DES from security requirements Reviewed-by: xuelei ! src/java.base/share/classes/java/security/AlgorithmParameters.java ! src/java.base/share/classes/java/security/MessageDigest.java ! src/java.base/share/classes/javax/crypto/Cipher.java ! src/java.base/share/classes/javax/crypto/KeyGenerator.java ! src/java.base/share/classes/javax/crypto/Mac.java ! src/java.base/share/classes/javax/crypto/SecretKeyFactory.java Changeset: fce1fa1bdc91 Author: sangheki Date: 2019-11-13 10:49 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fce1fa1bdc91 8220310: Implementation: NUMA-Aware Memory Allocation for G1, Mutator (1/3) Reviewed-by: kbarrett, sjohanss, tschatzl, pliden ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/gc/g1/g1AllocRegion.cpp ! src/hotspot/share/gc/g1/g1AllocRegion.hpp ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1Allocator.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp + src/hotspot/share/gc/g1/g1NUMA.cpp + src/hotspot/share/gc/g1/g1NUMA.hpp ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.hpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/gc/g1/heapRegionManager.hpp ! src/hotspot/share/gc/g1/heapRegionSet.hpp ! src/hotspot/share/gc/g1/heapRegionSet.inline.hpp ! src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.cpp ! src/hotspot/share/gc/g1/heterogeneousHeapRegionManager.hpp ! src/hotspot/share/logging/logPrefix.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/os.hpp + test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchRegions.java ! test/lib/sun/hotspot/WhiteBox.java Changeset: df6f2350edfa Author: sangheki Date: 2019-11-13 10:49 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/df6f2350edfa 8220311: Implementation: NUMA-Aware Memory Allocation for G1, Survivor (2/3) Reviewed-by: kbarrett, sjohanss, tschatzl ! src/hotspot/share/gc/g1/g1AllocRegion.cpp ! src/hotspot/share/gc/g1/g1AllocRegion.hpp ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1Allocator.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp Changeset: 6530de931b8e Author: sangheki Date: 2019-11-13 10:51 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6530de931b8e 8220312: Implementation: NUMA-Aware Memory Allocation for G1, Logging (3/3) Reviewed-by: kbarrett, sjohanss, tschatzl ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_linux.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1EdenRegions.hpp ! src/hotspot/share/gc/g1/g1HeapTransition.cpp ! src/hotspot/share/gc/g1/g1HeapTransition.hpp ! src/hotspot/share/gc/g1/g1NUMA.cpp ! src/hotspot/share/gc/g1/g1NUMA.hpp + src/hotspot/share/gc/g1/g1NUMAStats.cpp + src/hotspot/share/gc/g1/g1NUMAStats.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp + src/hotspot/share/gc/g1/g1RegionsOnNodes.cpp + src/hotspot/share/gc/g1/g1RegionsOnNodes.hpp ! src/hotspot/share/gc/g1/g1SurvivorRegions.cpp ! src/hotspot/share/gc/g1/g1SurvivorRegions.hpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/gc/g1/heapRegionManager.hpp ! src/hotspot/share/gc/g1/heapRegionSet.cpp ! src/hotspot/share/gc/g1/heapRegionSet.hpp ! src/hotspot/share/gc/g1/heapRegionSet.inline.hpp ! test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchRegions.java Changeset: 058d299b22b6 Author: iignatyev Date: 2019-11-13 10:59 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/058d299b22b6 8225756: [testbug] compiler/loopstripmining/CheckLoopStripMining.java sets too short a SafepointTimeoutDelay Reviewed-by: kvn, epavlova, roland, mdoerr ! test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMining.java Changeset: f1a5d48d0471 Author: iignatyev Date: 2019-11-13 11:34 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f1a5d48d0471 8226795: compiler/tiered/Level2RecompilationTest.java fails when XX:TieredStopAtLevel=1/2/3 is set Reviewed-by: redestad ! test/hotspot/jtreg/compiler/profiling/TestTypeProfiling.java ! test/hotspot/jtreg/compiler/tiered/Level2RecompilationTest.java ! test/hotspot/jtreg/compiler/whitebox/OSRFailureLevel4Test.java Changeset: 5f458adec06b Author: cjplummer Date: 2019-11-13 13:05 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5f458adec06b 8231635: SA Stackwalking code stuck in BasicTypeDataBase.findDynamicTypeForAddress() Summary: Better checking for invalid stack address when walking the stack frames Reviewed-by: sspitsyn, dtitov ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/amd64/AMD64CurrentFrameGuess.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/x86/X86CurrentFrameGuess.java ! test/hotspot/jtreg/ProblemList.txt Changeset: 439a147b2c0c Author: amenkov Date: 2019-11-13 14:08 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/439a147b2c0c 8231915: two JDI tests interfere with each other Reviewed-by: sspitsyn, dtitov ! test/jdk/com/sun/jdi/JdwpListenTest.java Changeset: f080b08daace Author: kbarrett Date: 2019-11-13 18:00 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f080b08daace 8232588: G1 concurrent System.gc can return early or late 8233279: G1: GCLocker GC with +GCLockerInvokesConcurrent spins while cycle in progress Summary: Refactor G1CH::try_collect and fix bugs with concurrent collections. Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp ! src/hotspot/share/gc/g1/g1VMOperations.cpp ! src/hotspot/share/gc/g1/g1VMOperations.hpp ! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/vmOperations.hpp Changeset: dc45ed0ab083 Author: darcy Date: 2019-11-13 15:16 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/dc45ed0ab083 8233096: Update javax.lang.model for switch expressions Reviewed-by: jjg, jlahoda ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java ! test/langtools/tools/javac/processing/model/TestSourceVersion.java Changeset: e0d59f0c2b7d Author: jiefu Date: 2019-11-14 10:02 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e0d59f0c2b7d 8234130: Zero VM build broken after JDK-8233913 Reviewed-by: coleenp ! src/hotspot/share/interpreter/bytecodeInterpreter.cpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp Changeset: 22ee476cc664 Author: iklam Date: 2019-11-13 16:36 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/22ee476cc664 8231610: Relocate the CDS archive if it cannot be mapped to the requested address Reviewed-by: jiangli, coleenp, ccheung ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp ! src/hotspot/share/include/cds.h ! src/hotspot/share/memory/allocation.hpp + src/hotspot/share/memory/archiveUtils.cpp + src/hotspot/share/memory/archiveUtils.hpp ! src/hotspot/share/memory/dynamicArchive.cpp ! src/hotspot/share/memory/dynamicArchive.hpp ! src/hotspot/share/memory/filemap.cpp ! src/hotspot/share/memory/filemap.hpp ! src/hotspot/share/memory/heapShared.cpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace.hpp ! src/hotspot/share/memory/metaspaceClosure.hpp ! src/hotspot/share/memory/metaspaceShared.cpp ! src/hotspot/share/memory/metaspaceShared.hpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/constMethod.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/arguments.hpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/FileMapInfo.java ! src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c ! src/jdk.hotspot.agent/solaris/native/libsaproc/saproc.cpp ! test/hotspot/jtreg/TEST.groups ! test/hotspot/jtreg/runtime/cds/SpaceUtilizationCheck.java + test/hotspot/jtreg/runtime/cds/appcds/ArchiveRelocationTest.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveRelocationTest.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveTestBase.java Changeset: 558da4a0e31b Author: jwilhelm Date: 2019-11-14 03:01 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/558da4a0e31b Added tag jdk-14+23 for changeset 15936b142f86 ! .hgtags Changeset: b987ea528c21 Author: iklam Date: 2019-11-13 19:55 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b987ea528c21 8234133: VM build broken due to memory/archiveUtils.inline.hpp Reviewed-by: dholmes + src/hotspot/share/memory/archiveUtils.inline.hpp Changeset: 355f4f42dda5 Author: jvernee Date: 2019-11-14 10:55 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/355f4f42dda5 8233920: MethodHandles::tryFinally generates illegal bytecode for long/double return type Reviewed-by: redestad, vlivanov, jrose ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! test/jdk/java/lang/invoke/TryFinallyTest.java Changeset: 95a99e617f28 Author: redestad Date: 2019-11-14 15:24 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/95a99e617f28 8234003: Improve IndexSet iteration Reviewed-by: neliasso, thartmann ! src/hotspot/share/opto/chaitin.cpp ! src/hotspot/share/opto/coalesce.cpp ! src/hotspot/share/opto/ifg.cpp ! src/hotspot/share/opto/indexSet.cpp ! src/hotspot/share/opto/indexSet.hpp ! src/hotspot/share/opto/live.cpp ! src/hotspot/share/opto/reg_split.cpp Changeset: 3e4d8b5856f3 Author: lancea Date: 2019-11-14 10:54 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3e4d8b5856f3 8234080: jdk/nio/zipfs/CRCWriteTest.java fails Reviewed-by: clanger, amlu ! test/jdk/jdk/nio/zipfs/CRCWriteTest.java Changeset: de56632f796d Author: bpb Date: 2019-11-14 09:06 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/de56632f796d 8146298: (dc spec) connect and disconnect methods should specify that they may block Reviewed-by: alanb, chegar, dfuchs, darcy ! src/java.base/share/classes/java/nio/channels/DatagramChannel.java Changeset: 1c071f73949a Author: joehw Date: 2019-11-14 18:41 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1c071f73949a 8233686: XML transformer uses excessive amount of memory Summary: remove unnecessary object creation and also update xalan.md file Reviewed-by: lancea ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/DOM2TO.java ! src/java.xml/share/legal/xalan.md Changeset: 625262261ef2 Author: pconcannon Date: 2019-11-14 10:49 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/625262261ef2 8233860: AfterClose.java test incorrectly handles IP_MULTICAST_IF Summary: Correction to invalid value used to ensure test fails as expected. Reviewed-by: alanb, dfuchs, vtewari ! test/jdk/java/net/SocketOption/AfterClose.java Changeset: 6933b57d7667 Author: pconcannon Date: 2019-11-14 11:04 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6933b57d7667 8233989: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java Summary: This fix adds an IPv4 version of test SetLoopbackMode.java that calls SetLoopbackMode in IPv4 only mode, and runs only if IPv4 is enabled. Reviewed-by: dfuchs ! test/jdk/java/net/MulticastSocket/SetLoopbackMode.java + test/jdk/java/net/MulticastSocket/SetLoopbackModeIPv4.java Changeset: 5d4c3724e4c7 Author: mseledtsov Date: 2019-11-14 11:16 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5d4c3724e4c7 8232244: [TESTBUG] Incorrect comment in TestClassUnloadEvent.java Summary: Removed incorrect comment Reviewed-by: iignatyev ! test/jdk/jdk/jfr/event/runtime/TestClassUnloadEvent.java Changeset: 03fbcd06b4c0 Author: dlong Date: 2019-11-14 12:21 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/03fbcd06b4c0 8233841: Update Graal Reviewed-by: kvn ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64BaseAssembler.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64.test/src/org/graalvm/compiler/core/aarch64/test/AArch64ElideL2ITest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64NodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/spi/ForeignCallLinkage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/HashMapGetTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnsafeVirtualizationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EATestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/UnsafeEATest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/CompilationWrapper.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/GraalError.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotEpilogueBlockEndOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotEpilogueOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotRegisterAllocationConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotRestoreRbpOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotReturnOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompilationWrapperTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorldTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotForeignCallLinkageImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/JVMCIVersionCheck.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/Stub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayCompareToOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayEqualsOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayIndexOfOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Call.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64FrameMap.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64StringLatin1InflateOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64StringUTF16CompressOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Ternary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64VZeroUpper.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorBinary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorCompareOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorFloatCompareOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorInstruction.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorMove.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/vector/AMD64VectorUnary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/LIRInstruction.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/asm/CompilationResultBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/CompareNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/InvocationPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionsParser.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/MethodHandleNode.java Changeset: e6baa47fbacf Author: jjg Date: 2019-11-14 12:42 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e6baa47fbacf 8234183: [TESTBUG] tools/javac/api/TestModuleUnnamedPackage.java fails to compile Reviewed-by: jjg Contributed-by: fujie at loongson.cn ! test/langtools/tools/javac/api/TestModuleUnnamedPackage.java Changeset: 148921c01038 Author: manc Date: 2019-11-13 16:49 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/148921c01038 8234127: BasicHashtable does not support small table_size Reviewed-by: coleenp, jiangli ! src/hotspot/share/utilities/hashtable.cpp Changeset: 124164752fe4 Author: iklam Date: 2019-11-14 14:54 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/124164752fe4 8234196: [TESTBUG] DynamicArchiveRelocationTest.java missing "ArchiveRelocationMode == 1 ...." Reviewed-by: dcubed ! test/hotspot/jtreg/runtime/cds/appcds/ArchiveRelocationTest.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveRelocationTest.java Changeset: 9afab9bf3e6a Author: fyang Date: 2019-11-14 15:07 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/9afab9bf3e6a 8233912: aarch64: minor improvements of atomic operations Reviewed-by: aph ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp Changeset: 4a09d4df104c Author: never Date: 2019-11-14 16:34 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/4a09d4df104c 8233888: jdk.vm.ci.hotspot.test.VirtualObjectLayoutTest.testFormat(): Unexpected error verifying Reviewed-by: kvn, iignatyev ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/VirtualObjectTestBase.java Changeset: 046e4024e55a Author: weijun Date: 2019-11-15 09:06 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/046e4024e55a 8214024: Remove the default keytool -keyalg value Reviewed-by: mullan ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/tools/keytool/Resources.java ! test/hotspot/jtreg/runtime/cds/appcds/JarBuilder.java ! test/jdk/java/security/Policy/ExtensiblePolicy/ExtensiblePolicyWithJarTest.java ! test/jdk/java/security/Policy/SignedJar/SignedJarTest.java ! test/jdk/sun/security/pkcs12/PBES2Encoding.java ! test/jdk/sun/security/pkcs12/ParamsTest.java ! test/jdk/sun/security/pkcs12/SameDN.java ! test/jdk/sun/security/tools/jarsigner/AltProvider.java ! test/jdk/sun/security/tools/jarsigner/JavaKeyStoreAliasCaseInsensitive.java ! test/jdk/sun/security/tools/jarsigner/LineBrokenMultiByteCharacter.java ! test/jdk/sun/security/tools/jarsigner/multiRelease/MVJarSigningTest.java - test/jdk/sun/security/tools/keytool/DeprecateKeyalg.java ! test/jdk/sun/security/tools/keytool/DupImport.java ! test/jdk/sun/security/tools/keytool/HasSrcStoretypeOption.java ! test/jdk/sun/security/tools/keytool/ImportPrompt.java ! test/jdk/sun/security/tools/keytool/KeyAlg.java ! test/jdk/sun/security/tools/keytool/KeyToolTest.java ! test/jdk/sun/security/tools/keytool/PKCS12Passwd.java ! test/jdk/sun/security/tools/keytool/ProbingFailure.java ! test/jdk/sun/security/tools/keytool/RealType.java + test/jdk/sun/security/tools/keytool/RemoveKeyAlgDefault.java ! test/jdk/sun/security/tools/keytool/WeakAlg.java ! test/jdk/sun/security/tools/keytool/console.sh ! test/jdk/sun/security/tools/keytool/i18n.html Changeset: 76ae9aa0e794 Author: dholmes Date: 2019-11-14 22:36 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/76ae9aa0e794 8233549: Thread interrupted state must only be accessed when not in a safepoint-safe state Reviewed-by: dcubed, sspitsyn ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiRawMonitor.cpp ! src/hotspot/share/prims/jvmtiRawMonitor.hpp ! src/hotspot/share/runtime/objectMonitor.cpp ! test/hotspot/jtreg/ProblemList.txt Changeset: 11b96254ea92 Author: rhalade Date: 2019-11-14 19:49 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/11b96254ea92 8232019: Add LuxTrust certificate updates to the existing root program Reviewed-by: mullan + make/data/cacerts/luxtrustglobalroot2ca + test/jdk/security/infra/java/security/cert/CertPathValidator/certification/LuxTrustCA.java ! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Changeset: 6f42d2a19117 Author: mdoerr Date: 2019-11-15 11:09 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6f42d2a19117 8234188: AIX build broken after 8220310 Reviewed-by: hseigel ! src/hotspot/os/aix/os_aix.cpp Changeset: 52752425712c Author: jiefu Date: 2019-11-15 19:38 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/52752425712c 8234245: sun/security/lib/cacerts/VerifyCACerts.java fails due to wrong checksum Reviewed-by: mullan ! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Changeset: 8c4c358272a9 Author: jiefu Date: 2019-11-15 20:39 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8c4c358272a9 8234232: [TESTBUG] gc/shenandoah/jvmti/TestHeapDump.java fails with -Xcomp Reviewed-by: zgu ! test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java Changeset: fe87a92570db Author: simonis Date: 2019-11-15 20:29 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fe87a92570db 8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater() Reviewed-by: clanger, lancea ! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java + test/jdk/jdk/nio/zipfs/ReleaseDeflater.java Changeset: 700a2ad8fc19 Author: zgu Date: 2019-11-15 15:33 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/700a2ad8fc19 8204128: NMT might report incorrect numbers for Compiler area Reviewed-by: stuefe, tschatzl ! src/hotspot/share/memory/arena.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/services/mallocTracker.hpp ! src/hotspot/share/services/memTracker.hpp + test/hotspot/jtreg/runtime/NMT/HugeArenaTracking.java ! test/lib/sun/hotspot/WhiteBox.java Changeset: c545e449137c Author: manc Date: 2019-11-14 17:34 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c545e449137c 8234208: Logging reports zero total refined cards under "Before GC RS summary" Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1Policy.hpp ! src/hotspot/share/gc/g1/g1RemSetSummary.cpp ! src/hotspot/share/gc/g1/g1RemSetSummary.hpp Changeset: a129f10e1b9a Author: kbarrett Date: 2019-11-15 16:58 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a129f10e1b9a 8233280: Remove GCLockerInvokesConcurrent Summary: Remove use and make option obsolete. Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/shared/gc_globals.hpp ! src/hotspot/share/runtime/arguments.cpp Changeset: 8e7f29b1ad4a Author: iignatyev Date: 2019-11-15 14:22 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8e7f29b1ad4a 8214904: Test8004741.java failed due to "Too few ThreadDeath hits; expected at least 6 but saw only 5" Reviewed-by: kvn, epavlova ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/compiler/c2/Test8004741.java Changeset: 8f92795b39e5 Author: dcubed Date: 2019-11-15 18:31 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8f92795b39e5 8234272: ProblemList runtime/NMT/HugeArenaTracking.java Reviewed-by: iignatyev ! test/hotspot/jtreg/ProblemList.txt Changeset: 89c44961a84f Author: dcubed Date: 2019-11-15 21:19 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/89c44961a84f 8234274: [BACKOUT] JDK-8204128 NMT might report incorrect numbers for Compiler area Reviewed-by: zgu ! src/hotspot/share/memory/arena.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/services/mallocTracker.hpp ! src/hotspot/share/services/memTracker.hpp ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/runtime/NMT/HugeArenaTracking.java ! test/lib/sun/hotspot/WhiteBox.java Changeset: 7bdc4f073c7f Author: mbaesken Date: 2019-11-15 16:10 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7bdc4f073c7f 8233219: NMT output on AIX misses some categories Reviewed-by: stuefe, zgu ! src/hotspot/share/services/virtualMemoryTracker.cpp Changeset: fc68b2cdfeeb Author: sgehwolf Date: 2019-11-06 18:06 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fc68b2cdfeeb 8233712: Limit default tests jobs based on ulimit -u setting Reviewed-by: erikj, ihse ! make/RunTests.gmk ! make/RunTestsPrebuiltSpec.gmk ! make/autoconf/basics.m4 ! make/autoconf/spec.gmk.in Changeset: 7cbffba2156b Author: redestad Date: 2019-11-18 16:10 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7cbffba2156b 8234248: More VectorSet cleanups Reviewed-by: neliasso, thartmann ! src/hotspot/share/libadt/vectset.cpp ! src/hotspot/share/libadt/vectset.hpp Changeset: 5d73255c2d52 Author: lucy Date: 2019-11-18 17:11 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5d73255c2d52 8233787: Break cycle in vm_version* includes Reviewed-by: kbarrett, mdoerr ! make/hotspot/lib/CompileJvm.gmk ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.hpp ! src/hotspot/cpu/aarch64/vm_version_ext_aarch64.hpp ! src/hotspot/cpu/arm/register_arm.hpp ! src/hotspot/cpu/arm/vm_version_arm.hpp ! src/hotspot/cpu/arm/vm_version_arm_32.cpp ! src/hotspot/cpu/arm/vm_version_ext_arm.hpp ! src/hotspot/cpu/ppc/vm_version_ext_ppc.hpp ! src/hotspot/cpu/ppc/vm_version_ppc.cpp ! src/hotspot/cpu/ppc/vm_version_ppc.hpp ! src/hotspot/cpu/s390/register_s390.hpp ! src/hotspot/cpu/s390/vm_version_ext_s390.hpp ! src/hotspot/cpu/s390/vm_version_s390.cpp ! src/hotspot/cpu/s390/vm_version_s390.hpp ! src/hotspot/cpu/sparc/vm_version_ext_sparc.hpp ! src/hotspot/cpu/sparc/vm_version_sparc.cpp ! src/hotspot/cpu/sparc/vm_version_sparc.hpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/x86/vm_version_ext_x86.hpp ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/cpu/x86/vm_version_x86.hpp ! src/hotspot/cpu/zero/register_zero.hpp ! src/hotspot/cpu/zero/vm_version_ext_zero.hpp ! src/hotspot/cpu/zero/vm_version_zero.cpp ! src/hotspot/cpu/zero/vm_version_zero.hpp ! src/hotspot/os/bsd/os_perf_bsd.cpp ! src/hotspot/os/windows/os_perf_windows.cpp ! src/hotspot/os_cpu/bsd_x86/vm_version_bsd_x86.cpp ! src/hotspot/os_cpu/bsd_zero/vm_version_bsd_zero.cpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_aarch64/vm_version_linux_aarch64.cpp ! src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp ! src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.hpp ! src/hotspot/os_cpu/linux_arm/vm_version_linux_arm_32.cpp ! src/hotspot/os_cpu/linux_s390/atomic_linux_s390.hpp ! src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp ! src/hotspot/os_cpu/linux_sparc/vm_version_linux_sparc.cpp ! src/hotspot/os_cpu/linux_x86/vm_version_linux_x86.cpp ! src/hotspot/os_cpu/linux_zero/vm_version_linux_zero.cpp ! src/hotspot/os_cpu/solaris_sparc/vm_version_solaris_sparc.cpp ! src/hotspot/os_cpu/solaris_x86/vm_version_solaris_x86.cpp ! src/hotspot/os_cpu/windows_x86/vm_version_windows_x86.cpp + src/hotspot/share/runtime/abstract_vm_version.cpp + src/hotspot/share/runtime/abstract_vm_version.hpp ! src/hotspot/share/runtime/vm_version.cpp ! src/hotspot/share/runtime/vm_version.hpp Changeset: d01fe40e9cd8 Author: dfuchs Date: 2019-11-18 16:48 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d01fe40e9cd8 8233141: DatagramSocket.send doesn't specify exception thrown when no target address Summary: DatagramSocket and MulticastSocket send methods are changed to throw IllegalArgumentException if no target address can be determined. Reviewed-by: alanb ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/java/net/MulticastSocket.java + test/jdk/java/net/DatagramSocket/AddressNotSet.java ! test/jdk/java/net/DatagramSocket/SendDatagramToBadAddress.java Changeset: 5ac4a49f5399 Author: mdoerr Date: 2019-11-18 18:21 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5ac4a49f5399 8233193: Incorrect bailout from possibly_add_compiler_threads Reviewed-by: dholmes, thartmann ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileBroker.hpp Changeset: ac11b83e0f38 Author: cgo Date: 2019-11-18 13:22 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ac11b83e0f38 8234324: ARM32 build broken after 8231610 Reviewed-by: iklam, aph ! src/hotspot/share/memory/filemap.cpp Changeset: d8eddc0ba770 Author: iignatyev Date: 2019-11-18 14:13 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d8eddc0ba770 8234304: runtime/cds/appcds/javaldr tests should use driver mode Reviewed-by: iklam, mseledtsov ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/AnonVmClassesDuringDump.java ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/ArrayTest.java ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/GCDuringDump.java ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/GCSharedStringsDuringDump.java ! test/hotspot/jtreg/runtime/cds/appcds/javaldr/HumongousDuringDump.java Changeset: 601b3fe3786d Author: iignatyev Date: 2019-11-18 16:03 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/601b3fe3786d 8233462: serviceability/tmtools/jstat tests times out with -Xcomp Reviewed-by: sspitsyn ! test/hotspot/jtreg/serviceability/tmtools/share/common/ToolRunner.java Changeset: 6645186a5a31 Author: ysuenaga Date: 2019-11-19 13:33 +0900 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6645186a5a31 8220074: Clean up GCC 8.3 errors in LittleCMS Reviewed-by: prr ! make/lib/Awt2dLibraries.gmk Changeset: 189f47d990b5 Author: dholmes Date: 2019-11-18 23:41 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/189f47d990b5 8215355: Object monitor deadlock with no threads holding the monitor (using jemalloc 5.1) Reviewed-by: rehn, stuefe, dcubed, sspitsyn ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java Changeset: 580fb715b29d Author: alanb Date: 2019-11-19 11:35 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/580fb715b29d 8233922: Service binding augments module graph with observable incubator modules Reviewed-by: mchung ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/lang/module/Resolver.java ! src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java ! src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java ! src/java.base/share/classes/jdk/internal/module/Modules.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java ! test/jdk/jdk/modules/etc/DefaultModules.java + test/jdk/jdk/modules/etc/TestJson.java + test/jdk/jdk/modules/etc/TestRootModules.java - test/jdk/jdk/modules/etc/src/TestJson.java - test/jdk/jdk/modules/etc/src/TestRootModules.java + test/jdk/jdk/modules/incubator/ServiceBinding.java + test/jdk/jdk/modules/incubator/TestBootLayer.java Changeset: fc998c509521 Author: cgo Date: 2019-11-15 11:05 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fc998c509521 8231954: Test compiler/codegen/TestCharVect2.java only works with server VMs Reviewed-by: iignatyev, kvn ! test/hotspot/jtreg/compiler/codegen/TestCharVect2.java Changeset: faac483dfb30 Author: bchristi Date: 2019-11-19 10:02 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/faac483dfb30 8233272: The Class.forName specification should be updated to match the long-standing implementation with respect to class linking Reviewed-by: dholmes, mchung ! src/java.base/share/classes/java/lang/Class.java + test/jdk/java/lang/Class/forName/NonLinking/Container.java + test/jdk/java/lang/Class/forName/NonLinking/MissingClass.java + test/jdk/java/lang/Class/forName/NonLinking/NonLinking.java Changeset: 302c4d2e7b3a Author: sangheki Date: 2019-11-19 12:28 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/302c4d2e7b3a 8232533: G1 uses only a single thread for pretouching the java heap Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp Changeset: f68fd04fe463 Author: redestad Date: 2019-11-19 23:22 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f68fd04fe463 8233497: Optimize default method generation by data structure reuse Reviewed-by: lfoltan, coleenp, igerasim ! src/hotspot/share/classfile/defaultMethods.cpp Changeset: bd436284147d Author: weijun Date: 2019-11-20 08:12 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/bd436284147d 8234377: new BitArray(0).toString() throws ArrayIndexOutOfBoundsException Reviewed-by: mullan, wetmore ! src/java.base/share/classes/sun/security/util/BitArray.java + test/jdk/sun/security/util/BitArray/EmptyBitArray.java Changeset: c4be5e03aff7 Author: darcy Date: 2019-11-19 16:26 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c4be5e03aff7 8234381: API docs should mention special handling of enums in serialization Reviewed-by: rriggs ! src/java.base/share/classes/java/io/Serializable.java ! src/java.base/share/classes/java/lang/Enum.java Changeset: 1037c4d14378 Author: bulasevich Date: 2019-11-20 09:29 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1037c4d14378 8233113: ARM32: assert on UnsafeJlong mutex rank check Reviewed-by: coleenp, dholmes ! src/hotspot/share/runtime/mutex.cpp ! test/hotspot/jtreg/runtime/Safepoint/NoSafepointVerifier.java Changeset: 341293626de7 Author: itakiguchi Date: 2019-11-20 16:37 +0900 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/341293626de7 8230873: [AIX] GUI app does not work with UTF-8 locale on minimum software requirements Summary: Fix fontconfig.properties file for AIX UTF-8 locales Reviewed-by: clanger ! make/data/fontconfig/aix.fontconfig.properties Changeset: ea044aedc2b6 Author: lucy Date: 2019-11-20 09:12 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ea044aedc2b6 8231460: Performance issue (CodeHeap) with large free blocks Reviewed-by: adinn, stuefe ! src/hotspot/share/memory/heap.cpp ! src/hotspot/share/memory/heap.hpp Changeset: 455612b3161a Author: alanb Date: 2019-11-20 08:35 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/455612b3161a 8231259: (dc) DatagramChannel::disconnect re-binds socket to the wildcard address (macOS) Reviewed-by: dfuchs, chegar ! src/java.base/macosx/classes/sun/nio/ch/KQueueSelectorImpl.java ! src/java.base/share/classes/java/nio/channels/spi/AbstractSelectableChannel.java ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/java.base/share/classes/sun/nio/ch/MembershipRegistry.java ! src/java.base/share/classes/sun/nio/ch/NativeDispatcher.java ! src/java.base/share/classes/sun/nio/ch/SelectionKeyImpl.java ! src/java.base/unix/classes/sun/nio/ch/DatagramDispatcher.java ! src/java.base/unix/classes/sun/nio/ch/FileDispatcherImpl.java ! src/java.base/unix/native/libnio/ch/FileDispatcherImpl.c - test/jdk/java/nio/channels/DatagramChannel/AddressesAfterDisconnect.java + test/jdk/java/nio/channels/DatagramChannel/AfterDisconnect.java Changeset: e735301d76b9 Author: pliden Date: 2019-11-20 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e735301d76b9 8234379: ZGC: Do not resize TALBs unless -XX:ResizeTLAB is enabled Reviewed-by: eosterlund, tschatzl ! src/hotspot/share/gc/z/zThreadLocalAllocBuffer.cpp Changeset: 877c000fd688 Author: pliden Date: 2019-11-20 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/877c000fd688 8234312: ZGC: Adjust warmup criteria Reviewed-by: eosterlund, stefank ! src/hotspot/share/gc/z/zDirector.cpp ! src/hotspot/share/gc/z/zDriver.cpp ! src/hotspot/share/gc/z/zStat.cpp ! src/hotspot/share/gc/z/zStat.hpp Changeset: 3b998574be4b Author: pliden Date: 2019-11-20 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3b998574be4b 8234338: ZGC: Improve small heap usage Reviewed-by: eosterlund, stefank ! src/hotspot/share/gc/z/zGlobals.cpp ! src/hotspot/share/gc/z/zGlobals.hpp + src/hotspot/share/gc/z/zHeuristics.cpp + src/hotspot/share/gc/z/zHeuristics.hpp ! src/hotspot/share/gc/z/zInitialize.cpp ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/gc/z/zObjectAllocator.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zRelocationSetSelector.cpp ! src/hotspot/share/gc/z/zWorkers.cpp + test/hotspot/jtreg/gc/z/TestSmallHeap.java Changeset: 82b2ba888190 Author: pliden Date: 2019-11-20 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/82b2ba888190 8234361: ZGC: Move heuristics code in ZWorker to ZHeuristics Reviewed-by: eosterlund, stefank ! src/hotspot/share/gc/z/zArguments.cpp ! src/hotspot/share/gc/z/zHeuristics.cpp ! src/hotspot/share/gc/z/zHeuristics.hpp ! src/hotspot/share/gc/z/zWorkers.cpp ! src/hotspot/share/gc/z/zWorkers.hpp Changeset: 8babf00875bc Author: pliden Date: 2019-11-20 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8babf00875bc 8234382: Test tools/javac/processing/model/testgetallmembers/Main.java using too small heap Reviewed-by: eosterlund, tschatzl ! test/langtools/tools/javac/processing/model/testgetallmembers/Main.java Changeset: 59272e9e0635 Author: pliden Date: 2019-11-20 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/59272e9e0635 8234383: Test TestBiasedLockRevocationEvents.java assumes -XX:UseBiasedLocking is enabled Reviewed-by: mgronlun, tschatzl ! test/jdk/jdk/jfr/event/runtime/TestBiasedLockRevocationEvents.java Changeset: 1152339c298a Author: pliden Date: 2019-11-20 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1152339c298a 8234437: Remove CollectedHeap::safe_object_iterate() Reviewed-by: kbarrett, sjohanss ! src/hotspot/share/gc/epsilon/epsilonHeap.cpp ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/generation.cpp ! src/hotspot/share/gc/shared/generation.hpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/space.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/memory/heapInspection.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/services/heapDumper.cpp Changeset: 0c2e1808f800 Author: pliden Date: 2019-11-20 10:37 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/0c2e1808f800 8234438: Remove some CMS leftovers Reviewed-by: kbarrett, sjohanss ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/space.hpp ! src/hotspot/share/gc/shared/space.inline.hpp ! src/hotspot/share/memory/freeList.hpp ! src/hotspot/share/memory/iterator.hpp Changeset: 14fa9e70ae71 Author: dcubed Date: 2019-11-20 09:10 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/14fa9e70ae71 8230876: baseline cleanups from Async Monitor Deflation v2.0[789] Reviewed-by: dholmes, kvn ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/runtime/objectMonitor.cpp ! src/hotspot/share/runtime/objectMonitor.hpp ! src/hotspot/share/runtime/objectMonitor.inline.hpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/threadSMR.cpp ! src/hotspot/share/runtime/vmStructs.cpp Changeset: b313bcb68b4c Author: eosterlund Date: 2019-11-20 14:51 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b313bcb68b4c 8234512: Missing pieces from JDK-8224816 Reviewed-by: rehn, pliden, kbarrett, gziemski ! src/hotspot/os/bsd/os_bsd.cpp Changeset: 438337c846fb Author: mbalao Date: 2019-11-12 00:30 -0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/438337c846fb 8233404: System property to set the number of PBE iterations in JCEKS keystores Reviewed-by: weijun ! src/java.base/share/classes/com/sun/crypto/provider/KeyProtector.java ! src/java.base/share/conf/security/java.security + test/jdk/com/sun/crypto/provider/KeyProtector/IterationCount.java Changeset: 6374e632b1ea Author: amenkov Date: 2019-11-20 16:10 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6374e632b1ea 8234358: Update ProblemList entry for NashornPopFrameTest Reviewed-by: dtitov, cjplummer ! test/jdk/ProblemList.txt Changeset: 09b295eb214b Author: iignatyev Date: 2019-11-20 18:23 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/09b295eb214b 8147017: Platform.isGraal should be removed Reviewed-by: kvn, mseledtsov ! test/hotspot/jtreg/gc/g1/TestGCLogMessages.java ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/common/optionsvalidation/JVMOptionsUtils.java ! test/hotspot/jtreg/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java ! test/lib/jdk/test/lib/Platform.java ! test/lib/jdk/test/lib/cli/CommandLineOptionTest.java Changeset: 39ac7aeb6fde Author: jwilhelm Date: 2019-11-21 03:33 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/39ac7aeb6fde Added tag jdk-14+24 for changeset 438337c846fb ! .hgtags Changeset: 90e9e7921ae5 Author: jiefu Date: 2019-11-21 09:55 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/90e9e7921ae5 8234499: [Graal] compiler/compilercontrol/CompilationModeHighOnlyTest.java test fails with timeout Reviewed-by: iignatyev ! test/hotspot/jtreg/compiler/compilercontrol/CompilationModeHighOnlyTest.java Changeset: 2c55c2fc08f5 Author: xgong Date: 2019-11-20 05:58 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2c55c2fc08f5 8234321: Call cache flush after generating trampoline. Reviewed-by: adinn, iklam ! src/hotspot/share/interpreter/abstractInterpreter.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: 51673a0b6df0 Author: mbaesken Date: 2019-11-19 09:56 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/51673a0b6df0 8234323: NULL-check return value of SurfaceData_InitOps on macosx Reviewed-by: clanger ! src/java.desktop/macosx/native/libawt_lwawt/awt/ImageSurfaceData.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/PrinterSurfaceData.m Changeset: 2cf90f3e8195 Author: serb Date: 2019-10-15 22:42 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2cf90f3e8195 8232225: Rework the fix for JDK-8071483 Reviewed-by: prr - test/jdk/java/awt/Color/AlphaColorTest.java - test/jdk/java/awt/Color/GetMinMaxValue_ICC_ColorSpace.java - test/jdk/java/awt/Color/HeadlessColor.java - test/jdk/java/awt/Color/LoadProfileWithSM.java - test/jdk/java/awt/Color/LoadStandardProfilesTest.java - test/jdk/java/awt/Color/OpacityChange/OpacityChange.java - test/jdk/java/awt/Color/XRenderTranslucentColorDrawTest.java + test/jdk/java/awt/ColorClass/AlphaColorTest.java + test/jdk/java/awt/ColorClass/HeadlessColor.java + test/jdk/java/awt/ColorClass/OpacityChange/OpacityChange.java + test/jdk/java/awt/ColorClass/XRenderTranslucentColorDrawTest.java + test/jdk/java/awt/color/GetMinMaxValue_ICC_ColorSpace.java + test/jdk/java/awt/color/LoadProfileWithSM.java + test/jdk/java/awt/color/LoadStandardProfilesTest.java Changeset: 8612b8012718 Author: aivanov Date: 2019-10-16 22:30 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8612b8012718 8223558: Java does not render Myanmar script correctly Reviewed-by: prr, serb ! make/data/fontconfig/windows.fontconfig.properties ! src/java.desktop/share/classes/sun/font/FontUtilities.java + test/jdk/java/awt/font/Fallback/MyanmarFallbackTest.java + test/jdk/java/awt/font/TextLayout/MyanmarTextTest.java Changeset: 7dae4286f1cc Author: serb Date: 2019-10-17 14:07 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7dae4286f1cc 8230869: [macos 10.15] The String "X Y Z" was not set to application's icon in the taskbar Reviewed-by: jdv, psadhukhan ! src/java.desktop/macosx/classes/apple/laf/JRSUIUtils.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CTaskbarPeer.java Changeset: 945f5bfab0f7 Author: prr Date: 2019-10-18 09:25 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/945f5bfab0f7 Merge Changeset: 85d7af399ef5 Author: serb Date: 2019-10-24 01:02 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/85d7af399ef5 8213119: [macos] java/awt/GraphicsDevice/CheckDisplayModes.java fails Reviewed-by: prr, jdv ! src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsDevice.m ! test/jdk/ProblemList.txt ! test/jdk/java/awt/GraphicsDevice/CheckDisplayModes.java Changeset: 6654f5611420 Author: prr Date: 2019-10-25 13:32 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6654f5611420 8175984: ICC_Profile has un-needed, not-empty finalize method Reviewed-by: jdv, serb ! src/java.desktop/share/classes/java/awt/color/ICC_Profile.java Changeset: 0fa6b6461451 Author: arapte Date: 2019-10-30 16:59 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/0fa6b6461451 8226892: ActionListeners on JRadioButtons don't get notified when selection is changed with arrow keys Reviewed-by: serb, psadhukhan ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicRadioButtonUI.java ! test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java Changeset: f4270450976b Author: prr Date: 2019-10-30 13:47 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f4270450976b 8232154: Update Mesa 3-D Headers to version 19.2.1 Reviewed-by: serb, kcr ! src/java.desktop/share/legal/mesa3d.md - src/java.desktop/share/legal/opengl.md ! src/java.desktop/share/native/common/java2d/opengl/J2D_GL/gl.h ! src/java.desktop/share/native/common/java2d/opengl/J2D_GL/glext.h + src/java.desktop/share/native/common/java2d/opengl/J2D_GL/khrplatform.h ! src/java.desktop/unix/native/common/java2d/opengl/J2D_GL/glx.h ! src/java.desktop/unix/native/common/java2d/opengl/J2D_GL/glxext.h ! src/java.desktop/windows/native/libawt/java2d/opengl/J2D_GL/wglext.h Changeset: d2123a27cfe7 Author: serb Date: 2019-10-24 14:54 -0700 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d2123a27cfe7 8232200: [macos 10.15] Windows in fullscreen tests jumps around the screen Reviewed-by: prr ! src/java.desktop/macosx/classes/sun/awt/CGraphicsDevice.java ! test/jdk/ProblemList.txt + test/jdk/java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java Changeset: f5adbf111424 Author: prr Date: 2019-11-04 10:01 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f5adbf111424 8233097: Fontmetrics for large Fonts has zero width Reviewed-by: jdv, serb ! src/java.desktop/share/native/libfontmanager/freetypeScaler.c + test/jdk/java/awt/FontClass/MassiveMetricsTest.java Changeset: afda8f7d266c Author: psadhukhan Date: 2019-11-05 11:00 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/afda8f7d266c Merge - make/GensrcModuleInfo.gmk - src/hotspot/share/jfr/recorder/repository/jfrChunkState.cpp - src/hotspot/share/jfr/recorder/repository/jfrChunkState.hpp - src/jdk.hotspot.agent/linux/native/libsaproc/LinuxDebuggerLocal.c - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.api.replacements/src/org/graalvm/compiler/api/replacements/MethodSubstitutionRegistry.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/schedule/MemoryScheduleVerification.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ExportingClassLoader.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/ModuleSupport.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/ChunkParser.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/ConstantMap.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/EventParser.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/LongMap.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/ObjectFactory.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/Parser.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/ParserFactory.java - src/jdk.jfr/share/classes/jdk/jfr/consumer/TimeConverter.java - src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/RecordingInternals.java - test/hotspot/gtest/oops/test_markOop.cpp - test/hotspot/jtreg/runtime/Thread/CountStackFramesAtExit.java - test/hotspot/jtreg/runtime/cds/appcds/ExtraSymbols.symbols.txt - test/hotspot/jtreg/serviceability/jvmti/ClassStatus/ClassStatus.java - test/hotspot/jtreg/serviceability/jvmti/ClassStatus/libClassStatus.c ! test/jdk/ProblemList.txt - test/jdk/java/math/BigInteger/DivisionOverflow.java - test/jdk/java/math/BigInteger/StringConstructorOverflow.java - test/jdk/java/math/BigInteger/SymmetricRangeTests.java - test/jdk/java/nio/channels/DatagramChannel/AdaptDatagramSocket.java Changeset: ff11b9700a34 Author: psadhukhan Date: 2019-11-05 16:33 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ff11b9700a34 8233583: ProblemList javax/swing/JWindow/ShapedAndTranslucentWindows/ShapedTranslucentPerPixelTranslucentGradient.java & ShapedPerPixelTranslucentGradient.java failing incosistently in linux-x64 Reviewed-by: jdv ! test/jdk/ProblemList.txt Changeset: 119ae24bce3e Author: prr Date: 2019-11-05 15:55 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/119ae24bce3e 8233649: Update ProblemList.txt to exclude failing headful tests on macos Reviewed-by: serb ! test/jdk/ProblemList.txt Changeset: d8888ab6c0ec Author: psadhukhan Date: 2019-11-06 10:48 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d8888ab6c0ec 8229935: [TEST_BUG]: bug8132119.java inconsistently positions text Reviewed-by: serb ! test/jdk/ProblemList.txt ! test/jdk/javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java Changeset: a4ecc45541da Author: psadhukhan Date: 2019-11-06 11:05 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a4ecc45541da 8231084: Large performance regression in SwingMark TextArea in 14-b13 8231336: Corrupted option dialog in JTHarness with JDK14b13 Reviewed-by: serb, prr ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! test/jdk/ProblemList.txt - test/jdk/javax/swing/JEditorPane/8226513/JEditorPaneLayoutTest.java - test/jdk/javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java Changeset: d0bfaae2ff33 Author: psadhukhan Date: 2019-11-07 11:30 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d0bfaae2ff33 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings Reviewed-by: serb, prr ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m Changeset: d0b0b4ee4481 Author: serb Date: 2019-11-08 05:24 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d0b0b4ee4481 8233657: Intermittent NPE in Component.validate() Reviewed-by: prr ! src/java.desktop/share/classes/java/awt/Component.java + test/jdk/java/awt/Component/Validate/NullFontValidate.java Changeset: 7a5060f0039f Author: psadhukhan Date: 2019-11-08 13:16 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7a5060f0039f 8233833: ProblemList java/awt/Frame/FrameLocation/FrameLocation.java for linux-x64 Reviewed-by: serb ! test/jdk/ProblemList.txt Changeset: 571089680cb2 Author: psadhukhan Date: 2019-11-12 12:29 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/571089680cb2 8233910: java/awt/ColorClass/AlphaColorTest.java is failing intermittently in nightly lnux-x64 system Reviewed-by: serb, prr ! test/jdk/java/awt/ColorClass/AlphaColorTest.java Changeset: d5af26ef7b95 Author: neugens Date: 2019-11-12 15:54 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d5af26ef7b95 8231991: Mouse wheel change focus on awt/swing windows Summary: Avoid focus logic when only mouse wheel is moved up/down. Reviewed-by: serb, dmarkov ! src/java.desktop/unix/classes/sun/awt/X11/XBaseWindow.java ! src/java.desktop/unix/classes/sun/awt/X11/XConstants.java + test/jdk/java/awt/event/MouseWheelEvent/WheelModifier/MouseWheelOnBackgroundComponent.java Changeset: ede8023f6b72 Author: psadhukhan Date: 2019-11-14 10:56 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ede8023f6b72 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64 Reviewed-by: serb ! test/jdk/ProblemList.txt Changeset: 9db62a092725 Author: psadhukhan Date: 2019-11-14 10:59 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/9db62a092725 8233634: [TESTBUG] Swing text test bug4278839.java fails on macos Reviewed-by: serb ! test/jdk/ProblemList.txt ! test/jdk/javax/swing/text/DefaultEditorKit/4278839/bug4278839.java Changeset: b5cdba232fca Author: serb Date: 2019-11-14 15:13 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b5cdba232fca 8232433: [macos 10.15] java/awt/Window/LocationAtScreenCorner/LocationAtScreenCorner.java may fail Reviewed-by: prr ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m ! test/jdk/java/awt/Window/LocationAtScreenCorner/LocationAtScreenCorner.java Changeset: 88ddd6943a06 Author: neugens Date: 2019-11-15 09:27 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/88ddd6943a06 8234107: Several AWT modal dialog tests failing on Linux after JDK-8231991 Summary: Fix off by one in wheel detection logic Reviewed-by: prr ! src/java.desktop/unix/classes/sun/awt/X11/XBaseWindow.java ! src/java.desktop/unix/classes/sun/awt/X11/XConstants.java Changeset: 1e8bbeb86204 Author: jdv Date: 2019-11-15 16:58 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1e8bbeb86204 8234184: [TESTBUG] java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java fails in Windows Reviewed-by: psadhukhan ! test/jdk/java/awt/Mouse/EnterExitEvents/ModalDialogEnterExitEventsTest.java Changeset: a56b7a304bac Author: ysuenaga Date: 2019-11-20 09:28 +0900 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a56b7a304bac 8233707: systemScale.cpp could not compile with VS2019 Reviewed-by: serb, aivanov ! src/java.desktop/windows/native/common/awt/systemscale/systemScale.cpp Changeset: b83adf4bd4ee Author: psadhukhan Date: 2019-11-20 10:52 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b83adf4bd4ee Merge - src/hotspot/share/gc/cms/adaptiveFreeList.cpp - src/hotspot/share/gc/cms/adaptiveFreeList.hpp - src/hotspot/share/gc/cms/allocationStats.cpp - src/hotspot/share/gc/cms/allocationStats.hpp - src/hotspot/share/gc/cms/cmsArguments.cpp - src/hotspot/share/gc/cms/cmsArguments.hpp - src/hotspot/share/gc/cms/cmsCardTable.cpp - src/hotspot/share/gc/cms/cmsCardTable.hpp - src/hotspot/share/gc/cms/cmsGCStats.cpp - src/hotspot/share/gc/cms/cmsGCStats.hpp - src/hotspot/share/gc/cms/cmsHeap.cpp - src/hotspot/share/gc/cms/cmsHeap.hpp - src/hotspot/share/gc/cms/cmsHeap.inline.hpp - src/hotspot/share/gc/cms/cmsLockVerifier.cpp - src/hotspot/share/gc/cms/cmsLockVerifier.hpp - src/hotspot/share/gc/cms/cmsOopClosures.hpp - src/hotspot/share/gc/cms/cmsOopClosures.inline.hpp - src/hotspot/share/gc/cms/cmsVMOperations.cpp - src/hotspot/share/gc/cms/cmsVMOperations.hpp - src/hotspot/share/gc/cms/cms_globals.hpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.hpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.inline.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.inline.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepThread.cpp - src/hotspot/share/gc/cms/concurrentMarkSweepThread.hpp - src/hotspot/share/gc/cms/freeChunk.cpp - src/hotspot/share/gc/cms/freeChunk.hpp - src/hotspot/share/gc/cms/gSpaceCounters.cpp - src/hotspot/share/gc/cms/gSpaceCounters.hpp - src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.cpp - src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.hpp - src/hotspot/share/gc/cms/parNewGeneration.cpp - src/hotspot/share/gc/cms/parNewGeneration.hpp - src/hotspot/share/gc/cms/parNewGeneration.inline.hpp - src/hotspot/share/gc/cms/parOopClosures.hpp - src/hotspot/share/gc/cms/parOopClosures.inline.hpp - src/hotspot/share/gc/cms/promotionInfo.cpp - src/hotspot/share/gc/cms/promotionInfo.hpp - src/hotspot/share/gc/cms/promotionInfo.inline.hpp - src/hotspot/share/gc/cms/vmStructs_cms.hpp - src/hotspot/share/gc/cms/yieldingWorkgroup.cpp - src/hotspot/share/gc/cms/yieldingWorkgroup.hpp - src/hotspot/share/libadt/set.cpp - src/hotspot/share/libadt/set.hpp - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/AdaptiveFreeList.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSBitMap.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSCollector.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSHeap.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ConcurrentMarkSweepGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/LinearAllocBlock.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ParNewGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/PrintRegionClosure.java - test/hotspot/jtreg/compiler/c2/aarch64/TestVolatilesCMS.java - test/hotspot/jtreg/compiler/c2/aarch64/TestVolatilesCMSCondMark.java - test/hotspot/jtreg/gc/TestMemoryInitializationWithCMS.java - test/hotspot/jtreg/gc/arguments/TestCMSHeapSizeFlags.java - test/hotspot/jtreg/gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java - test/hotspot/jtreg/gc/cms/DisableResizePLAB.java - test/hotspot/jtreg/gc/cms/GuardShrinkWarning.java - test/hotspot/jtreg/gc/cms/TestBubbleUpRef.java - test/hotspot/jtreg/gc/cms/TestCMSScavengeBeforeRemark.java - test/hotspot/jtreg/gc/cms/TestCriticalPriority.java - test/hotspot/jtreg/gc/cms/TestMBeanCMS.java - test/hotspot/jtreg/gc/concurrent_phase_control/TestConcurrentPhaseControlCMS.java - test/hotspot/jtreg/gc/metaspace/TestMetaspaceCMSCancel.java - test/hotspot/jtreg/gc/startup_warnings/TestCMS.java - test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithCMS.java - test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithCMS.java - test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithParNew.java - test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithParNew.java - test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithCMS.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java ! test/jdk/ProblemList.txt - test/jdk/java/lang/management/MemoryMXBean/MemoryManagementConcMarkSweepGC.sh - test/jdk/java/util/Arrays/ParallelSorting.java - test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithParNew.java - test/jdk/jdk/jfr/event/gc/collection/TestYoungGarbageCollectionEventWithParNew.java - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWith32BitOops.sh - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithHeapBasedOops.sh - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithZeroBasedOops.sh - test/jdk/jdk/jfr/event/gc/detailed/TestCMSConcurrentModeFailureEvent.java - test/jdk/jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParNew.java - test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventConcurrentCMS.java - test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventParNewCMS.java - test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestConcMarkSweepAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceConcMarkSweepGCAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestParNewAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/io/MakeJAR.sh - test/jdk/jdk/jfr/event/oldobject/TestCMS.java - test/jdk/jdk/jfr/event/os/TestInitialEnvironmentVariable.sh - test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.flags - test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.sh - test/jdk/jdk/jfr/javaagent/JavaAgentBuilder.java - test/jdk/jdk/modules/etc/src/TestJson.java - test/jdk/jdk/modules/etc/src/TestRootModules.java - test/jdk/sun/security/tools/keytool/DeprecateKeyalg.java - test/langtools/tools/javac/diags/examples/RestrictedTypeNotAllowedPreview.java Changeset: 10385df5d986 Author: psadhukhan Date: 2019-11-20 11:29 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/10385df5d986 8234332: [TESTBUG] java/awt/Focus/DisposedWindow/DisposeDialogNotActivateOwnerTest/DisposeDialogNotActivateOwnerTest.java fails on linux-x64 nightly Reviewed-by: serb ! test/jdk/java/awt/Focus/DisposedWindow/DisposeDialogNotActivateOwnerTest/DisposeDialogNotActivateOwnerTest.java Changeset: b9bde9d224b9 Author: trebari Date: 2019-11-20 12:18 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b9bde9d224b9 8190763: Class cast exception on (CompoundEdit) UndoableEditEvent.getEdit() Reviewed-by: psadhukhan, pbansal, serb ! src/java.desktop/share/classes/javax/swing/text/AbstractDocument.java + test/jdk/javax/swing/text/AbstractDocument/8190763/TestCCEOnEditEvent.java Changeset: 7567ce83f3b5 Author: psadhukhan Date: 2019-11-21 13:50 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7567ce83f3b5 Merge ! test/jdk/ProblemList.txt - test/jdk/java/nio/channels/DatagramChannel/AddressesAfterDisconnect.java From rwestrel at redhat.com Thu Nov 21 10:26:03 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Thu, 21 Nov 2019 11:26:03 +0100 Subject: RFR: aaload/aastore profiling In-Reply-To: <97d59255-7414-f434-7472-4b35b059e8a7@oracle.com> References: <87y2widbo2.fsf@redhat.com> <87k181chgy.fsf@redhat.com> <7d71a7d6-a04b-efbe-09bc-571e920996d4@oracle.com> <87a78xcdzq.fsf@redhat.com> <877e41ccal.fsf@redhat.com> <97d59255-7414-f434-7472-4b35b059e8a7@oracle.com> Message-ID: <87sgmhbk5g.fsf@redhat.com> Thanks for the review, Tobias. Roland. From rwestrel at redhat.com Thu Nov 21 10:37:46 2019 From: rwestrel at redhat.com (Roland Westrelin) Date: Thu, 21 Nov 2019 11:37:46 +0100 Subject: RFR: aaload/aastore profiling In-Reply-To: References: <87y2widbo2.fsf@redhat.com> Message-ID: <87pnhlbjlx.fsf@redhat.com> Thanks for the review. I'll remove the extra blank line. > I don?t know if a CR has already been created or not, but please, check > that it has the 'platform-specific? tag so Dmitry could easily find > that there?s some work to do for the Aarch64 platform. I created 8234572 and added the platform-specific label. Roland. From rwestrel at redhat.com Thu Nov 21 10:53:40 2019 From: rwestrel at redhat.com (rwestrel at redhat.com) Date: Thu, 21 Nov 2019 10:53:40 +0000 Subject: hg: valhalla/valhalla: 8234572: [lworld] aaload/aastore profiling Message-ID: <201911211053.xALArf92013173@aojmv0008.oracle.com> Changeset: be83c4f1f94c Author: roland Date: 2019-11-15 17:41 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/be83c4f1f94c 8234572: [lworld] aaload/aastore profiling Reviewed-by: thartmann, fparain ! src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp ! src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp ! src/hotspot/cpu/s390/interp_masm_s390.cpp ! src/hotspot/cpu/sparc/interp_masm_sparc.cpp ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/interp_masm_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/share/c1/c1_Canonicalizer.cpp ! src/hotspot/share/c1/c1_Compilation.hpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_GraphBuilder.hpp ! src/hotspot/share/c1/c1_Instruction.hpp ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/c1/c1_ValueMap.cpp ! src/hotspot/share/ci/ciMethod.cpp ! src/hotspot/share/ci/ciMethod.hpp ! src/hotspot/share/ci/ciMethodData.cpp ! src/hotspot/share/ci/ciMethodData.hpp ! src/hotspot/share/ci/ciObjArrayKlass.cpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/oops/methodData.hpp ! src/hotspot/share/opto/c2_globals.hpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/parse.hpp ! src/hotspot/share/opto/parse2.cpp ! src/hotspot/share/opto/parseHelper.cpp + test/hotspot/jtreg/compiler/valhalla/valuetypes/TestLWorldProfiling.java ! test/hotspot/jtreg/compiler/valhalla/valuetypes/ValueTypeTest.java From david.simms at oracle.com Thu Nov 21 11:10:25 2019 From: david.simms at oracle.com (David Simms) Date: Thu, 21 Nov 2019 12:10:25 +0100 Subject: RFR: JDK-8234507 [lworld] Macro ASM version of access_value_copy In-Reply-To: References: <33568549-6463-9877-fd4b-3d17894abbb7@oracle.com> Message-ID: Updated webrev0, Tests pass On 20/11/19 3:07 PM, David Simms wrote: > > From further testing it looks like eden_allocate requires "obj" arg as > "rax", so some juggling of regs remains to be done in > "InterpreterMacroAssembler::read_flattened_field()" > > On 20/11/19 2:36 PM, David Simms wrote: >> >> Bug/RFE: https://bugs.openjdk.java.net/browse/JDK-8234507 >> >> Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8234507/webrev0/ >> >> >> Greetings, >> >> ??? In working towards complete support for the "Heap Access API", I >> have added "MacroAssembler::access_value_copy". Given the complexity >> of performing essentially a "clone" operation (oop iteration applying >> barrier logic interspersed with memcpy), it is currently implemented >> simply as a leaf call (has very little overhead). >> >> ? There maybe be further opportunities to optimized for value type >> containing no oops etc, but this general purpose variant would >> probably remain as "fall back" implementation, so it seem like decent >> first step for building on. >> >> ? In order to provide testing for >> "MacroAssembler::access_value_copy", I created a "fast path" >> alternative for "InterpreterRuntime::read_flattened_field()" see: >> "InterpreterMacroAssembler::read_flattened_field()". This required >> quite a number of support methods, i.e. assembler versions of: >> >> ?* "InstanceKlass::get_value_field_klass()" >> ?* "ValueKlass::read_flattened_field()" >> ???? o is_empty_value() >> ???? o default_value() >> ???? o allocate_instance() >> ???? o data_for_oop() >> >> This increased the scope of the change, most of these ancillary >> helpers make up the bulk of the change. I feel this was necessary in >> order to evaluate whether the performance gains were the amount of >> engineering required to avoid interpreter runtime calls. >> Micro-benchmarking show a x3 performance gain for reading int sized >> value type field (and x2 gain for reading empty value type field). So >> answer seems to confirm Frederic's desire to remove as many runtime >> calls as possible. >> >> Of interest: "MacroAssembler::allocate_instance()". I took the guts >> out of "TemplateTable::_new" in order to allocate "oop buffer". This >> seems like fairly general code (not specific to interpreter), >> thinking we can refactor some of our other tlab allocations to use >> this (perhaps "MacroAssembler::store_value_type_fields_to_buf") >> >> Still running testing, there may be a subtle bug hiding...but this >> patch is taking it's time, best gather feedback at this point. >> >> /David Simms >> > From david.simms at oracle.com Thu Nov 21 14:12:11 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Thu, 21 Nov 2019 14:12:11 +0000 Subject: hg: valhalla/valhalla: 2 new changesets Message-ID: <201911211412.xALECBYv008295@aojmv0008.oracle.com> Changeset: 0f9d18b5e5c4 Author: dsimms Date: 2019-11-21 13:52 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/0f9d18b5e5c4 Merge ! .hgtags ! make/autoconf/hotspot.m4 ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp ! src/hotspot/cpu/aarch64/globals_aarch64.hpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/ppc/globals_ppc.hpp ! src/hotspot/cpu/sparc/globals_sparc.hpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/globals_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/cpu/zero/globals_zero.hpp ! src/hotspot/share/c1/c1_Canonicalizer.cpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_Instruction.cpp ! src/hotspot/share/c1/c1_Optimizer.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/ci/bcEscapeAnalyzer.cpp ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/ci/ciField.cpp ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/ci/ciMethod.cpp ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/ci/ciStreams.cpp ! src/hotspot/share/classfile/bytecodeAssembler.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/fieldLayoutBuilder.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/vmSymbols.cpp ! src/hotspot/share/code/compiledIC.cpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileBroker.cpp - src/hotspot/share/gc/cms/adaptiveFreeList.cpp - src/hotspot/share/gc/cms/adaptiveFreeList.hpp - src/hotspot/share/gc/cms/allocationStats.cpp - src/hotspot/share/gc/cms/allocationStats.hpp - src/hotspot/share/gc/cms/cmsArguments.cpp - src/hotspot/share/gc/cms/cmsArguments.hpp - src/hotspot/share/gc/cms/cmsCardTable.cpp - src/hotspot/share/gc/cms/cmsCardTable.hpp - src/hotspot/share/gc/cms/cmsGCStats.cpp - src/hotspot/share/gc/cms/cmsGCStats.hpp - src/hotspot/share/gc/cms/cmsHeap.cpp - src/hotspot/share/gc/cms/cmsHeap.hpp - src/hotspot/share/gc/cms/cmsHeap.inline.hpp - src/hotspot/share/gc/cms/cmsLockVerifier.cpp - src/hotspot/share/gc/cms/cmsLockVerifier.hpp - src/hotspot/share/gc/cms/cmsOopClosures.hpp - src/hotspot/share/gc/cms/cmsOopClosures.inline.hpp - src/hotspot/share/gc/cms/cmsVMOperations.cpp - src/hotspot/share/gc/cms/cmsVMOperations.hpp - src/hotspot/share/gc/cms/cms_globals.hpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.hpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.inline.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.inline.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepThread.cpp - src/hotspot/share/gc/cms/concurrentMarkSweepThread.hpp - src/hotspot/share/gc/cms/freeChunk.cpp - src/hotspot/share/gc/cms/freeChunk.hpp - src/hotspot/share/gc/cms/gSpaceCounters.cpp - src/hotspot/share/gc/cms/gSpaceCounters.hpp - src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.cpp - src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.hpp - src/hotspot/share/gc/cms/parNewGeneration.cpp - src/hotspot/share/gc/cms/parNewGeneration.hpp - src/hotspot/share/gc/cms/parNewGeneration.inline.hpp - src/hotspot/share/gc/cms/parOopClosures.hpp - src/hotspot/share/gc/cms/parOopClosures.inline.hpp - src/hotspot/share/gc/cms/promotionInfo.cpp - src/hotspot/share/gc/cms/promotionInfo.hpp - src/hotspot/share/gc/cms/promotionInfo.inline.hpp - src/hotspot/share/gc/cms/vmStructs_cms.hpp - src/hotspot/share/gc/cms/yieldingWorkgroup.cpp - src/hotspot/share/gc/cms/yieldingWorkgroup.hpp ! src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/shared/c2/barrierSetC2.cpp ! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp ! src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/gc/z/zBarrier.hpp ! src/hotspot/share/interpreter/bytecode.hpp ! src/hotspot/share/interpreter/bytecodeInterpreter.cpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/interpreter/rewriter.cpp ! src/hotspot/share/jvmci/compilerRuntime.cpp ! src/hotspot/share/jvmci/jvmciCodeInstaller.cpp ! src/hotspot/share/jvmci/jvmciCompiler.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciEnv.cpp - src/hotspot/share/libadt/set.cpp - src/hotspot/share/libadt/set.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/allocation.hpp ! src/hotspot/share/memory/heapInspection.cpp ! src/hotspot/share/memory/heapShared.cpp ! src/hotspot/share/memory/iterator.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/fieldInfo.hpp ! src/hotspot/share/oops/fieldStreams.hpp ! src/hotspot/share/oops/generateOopMap.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/markWord.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/valueKlass.cpp ! src/hotspot/share/opto/chaitin.cpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/opto/escape.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/graphKit.hpp ! src/hotspot/share/opto/ifnode.cpp ! src/hotspot/share/opto/lcm.cpp ! src/hotspot/share/opto/live.cpp ! src/hotspot/share/opto/loopopts.cpp ! src/hotspot/share/opto/macro.cpp ! src/hotspot/share/opto/matcher.cpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/memnode.hpp ! src/hotspot/share/opto/node.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/opto/phaseX.cpp ! src/hotspot/share/opto/phaseX.hpp ! src/hotspot/share/opto/stringopts.cpp ! src/hotspot/share/prims/jniCheck.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiCodeBlobEvents.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/prims/methodComparator.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/fieldDescriptor.cpp ! src/hotspot/share/runtime/fieldDescriptor.inline.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/handles.hpp ! src/hotspot/share/runtime/handles.inline.hpp ! src/hotspot/share/runtime/javaCalls.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/reflection.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vframeArray.cpp ! src/hotspot/share/runtime/vmOperations.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/services/diagnosticCommand.cpp ! src/hotspot/share/services/heapDumper.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/jdk.compiler/share/classes/com/sun/source/tree/Tree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/TreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/AdaptiveFreeList.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSBitMap.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSCollector.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSHeap.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ConcurrentMarkSweepGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/LinearAllocBlock.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ParNewGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/PrintRegionClosure.java ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/TEST.groups - test/hotspot/jtreg/compiler/c2/aarch64/TestVolatilesCMS.java - test/hotspot/jtreg/compiler/c2/aarch64/TestVolatilesCMSCondMark.java - test/hotspot/jtreg/gc/TestMemoryInitializationWithCMS.java - test/hotspot/jtreg/gc/arguments/TestCMSHeapSizeFlags.java - test/hotspot/jtreg/gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java - test/hotspot/jtreg/gc/cms/DisableResizePLAB.java - test/hotspot/jtreg/gc/cms/GuardShrinkWarning.java - test/hotspot/jtreg/gc/cms/TestBubbleUpRef.java - test/hotspot/jtreg/gc/cms/TestCMSScavengeBeforeRemark.java - test/hotspot/jtreg/gc/cms/TestCriticalPriority.java - test/hotspot/jtreg/gc/cms/TestMBeanCMS.java - test/hotspot/jtreg/gc/concurrent_phase_control/TestConcurrentPhaseControlCMS.java - test/hotspot/jtreg/gc/metaspace/TestMetaspaceCMSCancel.java - test/hotspot/jtreg/gc/startup_warnings/TestCMS.java - test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithCMS.java - test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithCMS.java - test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithParNew.java - test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithParNew.java - test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithCMS.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java ! test/jdk/ProblemList.txt - test/jdk/java/lang/management/MemoryMXBean/MemoryManagementConcMarkSweepGC.sh - test/jdk/java/nio/channels/DatagramChannel/AddressesAfterDisconnect.java - test/jdk/java/util/Arrays/ParallelSorting.java - test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithParNew.java - test/jdk/jdk/jfr/event/gc/collection/TestYoungGarbageCollectionEventWithParNew.java - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWith32BitOops.sh - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithHeapBasedOops.sh - test/jdk/jdk/jfr/event/gc/configuration/TestGCHeapConfigurationEventWithZeroBasedOops.sh - test/jdk/jdk/jfr/event/gc/detailed/TestCMSConcurrentModeFailureEvent.java - test/jdk/jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParNew.java - test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventConcurrentCMS.java - test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventParNewCMS.java - test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestConcMarkSweepAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceConcMarkSweepGCAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestParNewAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/io/MakeJAR.sh - test/jdk/jdk/jfr/event/oldobject/TestCMS.java - test/jdk/jdk/jfr/event/os/TestInitialEnvironmentVariable.sh - test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.flags - test/jdk/jdk/jfr/event/runtime/TestVMInfoEvent.sh - test/jdk/jdk/jfr/javaagent/JavaAgentBuilder.java - test/jdk/jdk/modules/etc/src/TestJson.java - test/jdk/jdk/modules/etc/src/TestRootModules.java - test/jdk/sun/security/tools/keytool/DeprecateKeyalg.java ! test/langtools/tools/javac/diags/examples.not-yet.txt - test/langtools/tools/javac/diags/examples/RestrictedTypeNotAllowedPreview.java ! test/lib/sun/hotspot/WhiteBox.java Changeset: 3545cdec8d9e Author: dsimms Date: 2019-11-21 14:58 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3545cdec8d9e Merge ! src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp ! src/hotspot/cpu/sparc/interp_masm_sparc.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/share/c1/c1_Canonicalizer.cpp ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/ci/ciMethod.cpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/opto/graphKit.cpp From frederic.parain at oracle.com Thu Nov 21 16:20:06 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Thu, 21 Nov 2019 11:20:06 -0500 Subject: RFR: JDK-8234507 [lworld] Macro ASM version of access_value_copy In-Reply-To: References: <33568549-6463-9877-fd4b-3d17894abbb7@oracle.com> Message-ID: David, Thank you for this work, it was huge but it seems you tackled it nicely. Nice refactoring of the allocation code. And the performance numbers sound great. Here?s my feedback on your webrev: src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp No comment src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp No comment src/hotspot/cpu/x86/interp_masm_x86.cpp No comment src/hotspot/cpu/x86/interp_masm_x86.hpp line 227: does the method really need to be virtual? src/hotspot/cpu/x86/macroAssembler_x86.cpp line 4520: using temp_reg instead of obj for the temp register of test_klass_is_empty_value() would make the code easier to read (just my opinion) src/hotspot/cpu/x86/macroAssembler_x86.hpp line 107: I don?t get the comment (seems to be a bad copy/paste from line 574) line 551: does the method really need to be virtual? src/hotspot/cpu/x86/templateTable_x86.cpp line 4339: the template of defaultvalue could be simplified by using the new get_empty_value_oop() line 3704: qputfield could be re-written to use access_value_copy() and avoid the runtime call (this could be delayed to another CR) line 3795: Label slow_path is not used src/hotspot/share/gc/shared/collectedHeap.hpp src/hotspot/share/gc/shared/collectedHeap.inline.hpp No comment src/hotspot/share/gc/shared/memAllocator.cpp No comment src/hotspot/share/gc/shared/memAllocator.hpp No comment src/hotspot/share/oops/instanceKlass.cpp line 508: [style] add empty line? src/hotspot/share/oops/instanceKlass.hpp No comment src/hotspot/share/oops/valueKlass.cpp no comment src/hotspot/share/oops/valueKlass.hpp line 109: allocate_instance_buffer() it would be helpful to have a comment here to explicitly state that the allocated instance memory has not been cleared, so initialization of its payload *must* follow before returning the oop to Java (there?s a comment in collectedHeap.hpp, but people have to dig in to find it) src/hotspot/share/gc/shared/barrierSetRuntime.cpp No comment src/hotspot/share/gc/shared/barrierSetRuntime.hpp No comment Regards, Fred > On Nov 21, 2019, at 06:10, David Simms wrote: > > > Updated webrev0, Tests pass > > On 20/11/19 3:07 PM, David Simms wrote: >> >> From further testing it looks like eden_allocate requires "obj" arg as "rax", so some juggling of regs remains to be done in "InterpreterMacroAssembler::read_flattened_field()" >> >> On 20/11/19 2:36 PM, David Simms wrote: >>> >>> Bug/RFE: https://bugs.openjdk.java.net/browse/JDK-8234507 >>> >>> Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8234507/webrev0/ >>> >>> >>> Greetings, >>> >>> In working towards complete support for the "Heap Access API", I have added "MacroAssembler::access_value_copy". Given the complexity of performing essentially a "clone" operation (oop iteration applying barrier logic interspersed with memcpy), it is currently implemented simply as a leaf call (has very little overhead). >>> >>> There maybe be further opportunities to optimized for value type containing no oops etc, but this general purpose variant would probably remain as "fall back" implementation, so it seem like decent first step for building on. >>> >>> In order to provide testing for "MacroAssembler::access_value_copy", I created a "fast path" alternative for "InterpreterRuntime::read_flattened_field()" see: "InterpreterMacroAssembler::read_flattened_field()". This required quite a number of support methods, i.e. assembler versions of: >>> >>> * "InstanceKlass::get_value_field_klass()" >>> * "ValueKlass::read_flattened_field()" >>> o is_empty_value() >>> o default_value() >>> o allocate_instance() >>> o data_for_oop() >>> >>> This increased the scope of the change, most of these ancillary helpers make up the bulk of the change. I feel this was necessary in order to evaluate whether the performance gains were the amount of engineering required to avoid interpreter runtime calls. Micro-benchmarking show a x3 performance gain for reading int sized value type field (and x2 gain for reading empty value type field). So answer seems to confirm Frederic's desire to remove as many runtime calls as possible. >>> >>> Of interest: "MacroAssembler::allocate_instance()". I took the guts out of "TemplateTable::_new" in order to allocate "oop buffer". This seems like fairly general code (not specific to interpreter), thinking we can refactor some of our other tlab allocations to use this (perhaps "MacroAssembler::store_value_type_fields_to_buf") >>> >>> Still running testing, there may be a subtle bug hiding...but this patch is taking it's time, best gather feedback at this point. >>> >>> /David Simms >>> >> > From mandy.chung at oracle.com Thu Nov 21 22:18:00 2019 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 21 Nov 2019 22:18:00 +0000 Subject: hg: valhalla/valhalla: Merge Message-ID: <201911212218.xALMI0la021038@aojmv0008.oracle.com> Changeset: 8043aa8339b0 Author: mchung Date: 2019-11-21 14:13 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8043aa8339b0 Merge ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/ci/ciField.cpp ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/defaultMethods.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/vmSymbols.cpp - src/hotspot/share/gc/cms/adaptiveFreeList.cpp - src/hotspot/share/gc/cms/adaptiveFreeList.hpp - src/hotspot/share/gc/cms/allocationStats.cpp - src/hotspot/share/gc/cms/allocationStats.hpp - src/hotspot/share/gc/cms/cmsArguments.cpp - src/hotspot/share/gc/cms/cmsArguments.hpp - src/hotspot/share/gc/cms/cmsCardTable.cpp - src/hotspot/share/gc/cms/cmsCardTable.hpp - src/hotspot/share/gc/cms/cmsGCStats.cpp - src/hotspot/share/gc/cms/cmsGCStats.hpp - src/hotspot/share/gc/cms/cmsHeap.cpp - src/hotspot/share/gc/cms/cmsHeap.hpp - src/hotspot/share/gc/cms/cmsHeap.inline.hpp - src/hotspot/share/gc/cms/cmsLockVerifier.cpp - src/hotspot/share/gc/cms/cmsLockVerifier.hpp - src/hotspot/share/gc/cms/cmsOopClosures.hpp - src/hotspot/share/gc/cms/cmsOopClosures.inline.hpp - src/hotspot/share/gc/cms/cmsVMOperations.cpp - src/hotspot/share/gc/cms/cmsVMOperations.hpp - src/hotspot/share/gc/cms/cms_globals.hpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.cpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.hpp - src/hotspot/share/gc/cms/compactibleFreeListSpace.inline.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.inline.hpp - src/hotspot/share/gc/cms/concurrentMarkSweepThread.cpp - src/hotspot/share/gc/cms/concurrentMarkSweepThread.hpp - src/hotspot/share/gc/cms/freeChunk.cpp - src/hotspot/share/gc/cms/freeChunk.hpp - src/hotspot/share/gc/cms/gSpaceCounters.cpp - src/hotspot/share/gc/cms/gSpaceCounters.hpp - src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.cpp - src/hotspot/share/gc/cms/jvmFlagConstraintsCMS.hpp - src/hotspot/share/gc/cms/parNewGeneration.cpp - src/hotspot/share/gc/cms/parNewGeneration.hpp - src/hotspot/share/gc/cms/parNewGeneration.inline.hpp - src/hotspot/share/gc/cms/parOopClosures.hpp - src/hotspot/share/gc/cms/parOopClosures.inline.hpp - src/hotspot/share/gc/cms/promotionInfo.cpp - src/hotspot/share/gc/cms/promotionInfo.hpp - src/hotspot/share/gc/cms/promotionInfo.inline.hpp - src/hotspot/share/gc/cms/vmStructs_cms.hpp - src/hotspot/share/gc/cms/yieldingWorkgroup.cpp - src/hotspot/share/gc/cms/yieldingWorkgroup.hpp ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace.hpp ! src/hotspot/share/memory/metaspaceShared.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiClassFileReconstituter.cpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/runtime/reflection.cpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java - src/java.desktop/share/legal/opengl.md - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/AdaptiveFreeList.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSBitMap.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSCollector.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CMSHeap.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ConcurrentMarkSweepGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/LinearAllocBlock.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/cms/ParNewGeneration.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/PrintRegionClosure.java ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/compiler/c2/aarch64/TestVolatilesCMS.java - test/hotspot/jtreg/compiler/c2/aarch64/TestVolatilesCMSCondMark.java - test/hotspot/jtreg/gc/TestMemoryInitializationWithCMS.java - test/hotspot/jtreg/gc/arguments/TestCMSHeapSizeFlags.java - test/hotspot/jtreg/gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java - test/hotspot/jtreg/gc/cms/DisableResizePLAB.java - test/hotspot/jtreg/gc/cms/GuardShrinkWarning.java - test/hotspot/jtreg/gc/cms/TestBubbleUpRef.java - test/hotspot/jtreg/gc/cms/TestCMSScavengeBeforeRemark.java - test/hotspot/jtreg/gc/cms/TestCriticalPriority.java - test/hotspot/jtreg/gc/cms/TestMBeanCMS.java - test/hotspot/jtreg/gc/concurrent_phase_control/TestConcurrentPhaseControlCMS.java - test/hotspot/jtreg/gc/metaspace/TestMetaspaceCMSCancel.java - test/hotspot/jtreg/gc/startup_warnings/TestCMS.java - test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithCMS.java - test/hotspot/jtreg/gc/stress/gclocker/TestGCLockerWithCMS.java - test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressAllocationGCEventsWithParNew.java - test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithCMS.java - test/hotspot/jtreg/gc/stress/jfr/TestStressBigAllocationGCEventsWithParNew.java - test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithCMS.java ! test/hotspot/jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorGCCMSTest.java ! test/jdk/ProblemList.txt - test/jdk/java/awt/Color/AlphaColorTest.java - test/jdk/java/awt/Color/GetMinMaxValue_ICC_ColorSpace.java - test/jdk/java/awt/Color/HeadlessColor.java - test/jdk/java/awt/Color/LoadProfileWithSM.java - test/jdk/java/awt/Color/LoadStandardProfilesTest.java - test/jdk/java/awt/Color/OpacityChange/OpacityChange.java - test/jdk/java/awt/Color/XRenderTranslucentColorDrawTest.java - test/jdk/java/lang/management/MemoryMXBean/MemoryManagementConcMarkSweepGC.sh - test/jdk/java/nio/channels/DatagramChannel/AddressesAfterDisconnect.java - test/jdk/java/util/Arrays/ParallelSorting.java - test/jdk/javax/swing/JEditorPane/8226513/JEditorPaneLayoutTest.java - test/jdk/javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java - test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/collection/TestGCCauseWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/collection/TestGCEventMixedWithParNew.java - test/jdk/jdk/jfr/event/gc/collection/TestYoungGarbageCollectionEventWithParNew.java - test/jdk/jdk/jfr/event/gc/detailed/TestCMSConcurrentModeFailureEvent.java - test/jdk/jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParNew.java - test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventConcurrentCMS.java - test/jdk/jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventParNewCMS.java - test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSConcurrent.java - test/jdk/jdk/jfr/event/gc/refstat/TestRefStatEventWithCMSMarkSweep.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestConcMarkSweepAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestMetaspaceConcMarkSweepGCAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/gc/stacktrace/TestParNewAllocationPendingStackTrace.java - test/jdk/jdk/jfr/event/oldobject/TestCMS.java - test/jdk/jdk/modules/etc/src/TestJson.java - test/jdk/jdk/modules/etc/src/TestRootModules.java - test/jdk/sun/security/tools/keytool/DeprecateKeyalg.java - test/langtools/tools/javac/diags/examples/RestrictedTypeNotAllowedPreview.java From mandy.chung at oracle.com Thu Nov 21 22:53:44 2019 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 21 Nov 2019 22:53:44 +0000 Subject: hg: valhalla/valhalla: [nestmates] small javadoc tweak Message-ID: <201911212253.xALMri34012771@aojmv0008.oracle.com> Changeset: 1f45c168090c Author: mchung Date: 2019-11-21 14:53 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1f45c168090c [nestmates] small javadoc tweak ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java From ioi.lam at oracle.com Fri Nov 22 00:06:46 2019 From: ioi.lam at oracle.com (ioi.lam at oracle.com) Date: Fri, 22 Nov 2019 00:06:46 +0000 Subject: hg: valhalla/valhalla: [lworld] Fixed --disable-precompiled-headers build. Message-ID: <201911220006.xAM06lrA025927@aojmv0008.oracle.com> Changeset: 06cb499d2fde Author: iklam Date: 2019-11-21 16:01 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/06cb499d2fde [lworld] Fixed --disable-precompiled-headers build. ! src/hotspot/share/adlc/main.cpp From david.simms at oracle.com Fri Nov 22 13:03:37 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 22 Nov 2019 14:03:37 +0100 Subject: RFR: JDK-8234507 [lworld] Macro ASM version of access_value_copy In-Reply-To: References: <33568549-6463-9877-fd4b-3d17894abbb7@oracle.com> Message-ID: Thanks for the review, I know it is not the easiest code to pick through, thanks for taking the time... Updated webrev1: http://cr.openjdk.java.net/~dsimms/valhalla/8234507/webrev1/ All comments applied, see below for details... On 21/11/19 5:20 PM, Frederic Parain wrote: > David, > > Thank you for this work, it was huge but it seems you tackled it nicely. > Nice refactoring of the allocation code. > And the performance numbers sound great. > > Here?s my feedback on your webrev: > > > src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp > > No comment > > src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp > > No comment > > src/hotspot/cpu/x86/interp_masm_x86.cpp > > No comment > > src/hotspot/cpu/x86/interp_masm_x86.hpp > > line 227: does the method really need to be virtual? Nope, removed > > src/hotspot/cpu/x86/macroAssembler_x86.cpp > > line 4520: using temp_reg instead of obj for the temp register of test_klass_is_empty_value() > would make the code easier to read (just my opinion) You are correct, done > > src/hotspot/cpu/x86/macroAssembler_x86.hpp > > line 107: I don?t get the comment (seems to be a bad copy/paste from line 574) > line 551: does the method really need to be virtual? 107: you are right, looks like when I rearranged where method decls went 551: nope, removed > src/hotspot/cpu/x86/templateTable_x86.cpp > > line 4339: the template of defaultvalue could be simplified by using the new get_empty_value_oop() > line 3704: qputfield could be re-written to use access_value_copy() and avoid the runtime call > (this could be delayed to another CR) > line 3795: Label slow_path is not used 4339: Done 3704: Yeap, but deferred for another CR for now (JDK-8234632 for putfield and JDK-8234633 for aaload/aastore) 3795: Label removed > > src/hotspot/share/gc/shared/collectedHeap.hpp > > src/hotspot/share/gc/shared/collectedHeap.inline.hpp > > No comment > > src/hotspot/share/gc/shared/memAllocator.cpp > > No comment > > src/hotspot/share/gc/shared/memAllocator.hpp > > No comment > > src/hotspot/share/oops/instanceKlass.cpp > > line 508: [style] add empty line? > > src/hotspot/share/oops/instanceKlass.hpp > > No comment > > src/hotspot/share/oops/valueKlass.cpp > > no comment > > src/hotspot/share/oops/valueKlass.hpp > > line 109: allocate_instance_buffer() it would be helpful to have a comment here to explicitly > state that the allocated instance memory has not been cleared, so initialization of > its payload *must* follow before returning the oop to Java (there?s a comment in > collectedHeap.hpp, but people have to dig in to find it) Good spotting. This was left over code from attempting to improve the interpreter runtime call, I really should have given it a little more care than the initial benchmarking hack. Commented as: ? // allocates a stand alone value buffer in the Java heap ? // DOES NOT have memory cleared, user MUST initialize payload before ? // returning to Java (i.e.: value_copy) > src/hotspot/share/gc/shared/barrierSetRuntime.cpp > > No comment > > src/hotspot/share/gc/shared/barrierSetRuntime.hpp > > No comment > > Regards, > > Fred From frederic.parain at oracle.com Fri Nov 22 14:16:41 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Fri, 22 Nov 2019 09:16:41 -0500 Subject: RFR: JDK-8234507 [lworld] Macro ASM version of access_value_copy In-Reply-To: References: <33568549-6463-9877-fd4b-3d17894abbb7@oracle.com> Message-ID: <29B6A100-EC36-4236-89F6-B11D86CFD24C@oracle.com> David, Thank you for making these changes. Looks good to me. Regards, Fred > On Nov 22, 2019, at 08:03, David Simms wrote: > > > Thanks for the review, I know it is not the easiest code to pick through, thanks for taking the time... > > Updated webrev1: http://cr.openjdk.java.net/~dsimms/valhalla/8234507/webrev1/ > > All comments applied, see below for details... > > On 21/11/19 5:20 PM, Frederic Parain wrote: >> David, >> >> Thank you for this work, it was huge but it seems you tackled it nicely. >> Nice refactoring of the allocation code. >> And the performance numbers sound great. >> >> Here?s my feedback on your webrev: >> >> >> src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp >> >> No comment >> >> src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp >> >> No comment >> >> src/hotspot/cpu/x86/interp_masm_x86.cpp >> >> No comment >> >> src/hotspot/cpu/x86/interp_masm_x86.hpp >> >> line 227: does the method really need to be virtual? > > Nope, removed > >> >> src/hotspot/cpu/x86/macroAssembler_x86.cpp >> >> line 4520: using temp_reg instead of obj for the temp register of test_klass_is_empty_value() >> would make the code easier to read (just my opinion) > You are correct, done >> >> src/hotspot/cpu/x86/macroAssembler_x86.hpp >> >> line 107: I don?t get the comment (seems to be a bad copy/paste from line 574) >> line 551: does the method really need to be virtual? > > 107: you are right, looks like when I rearranged where method decls went > > 551: nope, removed > >> src/hotspot/cpu/x86/templateTable_x86.cpp >> >> line 4339: the template of defaultvalue could be simplified by using the new get_empty_value_oop() >> line 3704: qputfield could be re-written to use access_value_copy() and avoid the runtime call >> (this could be delayed to another CR) >> line 3795: Label slow_path is not used > > 4339: Done > > 3704: Yeap, but deferred for another CR for now (JDK-8234632 for putfield and JDK-8234633 for aaload/aastore) > > 3795: Label removed > >> >> src/hotspot/share/gc/shared/collectedHeap.hpp >> >> src/hotspot/share/gc/shared/collectedHeap.inline.hpp >> >> No comment >> >> src/hotspot/share/gc/shared/memAllocator.cpp >> >> No comment >> >> src/hotspot/share/gc/shared/memAllocator.hpp >> >> No comment >> >> src/hotspot/share/oops/instanceKlass.cpp >> >> line 508: [style] add empty line? >> >> src/hotspot/share/oops/instanceKlass.hpp >> >> No comment >> >> src/hotspot/share/oops/valueKlass.cpp >> >> no comment >> >> src/hotspot/share/oops/valueKlass.hpp >> >> line 109: allocate_instance_buffer() it would be helpful to have a comment here to explicitly >> state that the allocated instance memory has not been cleared, so initialization of >> its payload *must* follow before returning the oop to Java (there?s a comment in >> collectedHeap.hpp, but people have to dig in to find it) > > Good spotting. This was left over code from attempting to improve the interpreter runtime call, I really should have given it a little more care than the initial benchmarking hack. Commented as: > > // allocates a stand alone value buffer in the Java heap > // DOES NOT have memory cleared, user MUST initialize payload before > // returning to Java (i.e.: value_copy) > >> src/hotspot/share/gc/shared/barrierSetRuntime.cpp >> >> No comment >> >> src/hotspot/share/gc/shared/barrierSetRuntime.hpp >> >> No comment >> >> Regards, >> >> Fred > > > From david.simms at oracle.com Fri Nov 22 14:17:26 2019 From: david.simms at oracle.com (David Simms) Date: Fri, 22 Nov 2019 15:17:26 +0100 Subject: RFR: JDK-8234507 [lworld] Macro ASM version of access_value_copy In-Reply-To: <29B6A100-EC36-4236-89F6-B11D86CFD24C@oracle.com> References: <33568549-6463-9877-fd4b-3d17894abbb7@oracle.com> <29B6A100-EC36-4236-89F6-B11D86CFD24C@oracle.com> Message-ID: Thanks again ! On 22/11/19 3:16 PM, Frederic Parain wrote: > David, > > Thank you for making these changes. > Looks good to me. > > Regards, > > Fred > > >> On Nov 22, 2019, at 08:03, David Simms wrote: >> >> >> Thanks for the review, I know it is not the easiest code to pick through, thanks for taking the time... >> >> Updated webrev1: http://cr.openjdk.java.net/~dsimms/valhalla/8234507/webrev1/ >> >> All comments applied, see below for details... >> >> On 21/11/19 5:20 PM, Frederic Parain wrote: >>> David, >>> >>> Thank you for this work, it was huge but it seems you tackled it nicely. >>> Nice refactoring of the allocation code. >>> And the performance numbers sound great. >>> >>> Here?s my feedback on your webrev: >>> >>> >>> src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp >>> >>> No comment >>> >>> src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp >>> >>> No comment >>> >>> src/hotspot/cpu/x86/interp_masm_x86.cpp >>> >>> No comment >>> >>> src/hotspot/cpu/x86/interp_masm_x86.hpp >>> >>> line 227: does the method really need to be virtual? >> Nope, removed >> >>> src/hotspot/cpu/x86/macroAssembler_x86.cpp >>> >>> line 4520: using temp_reg instead of obj for the temp register of test_klass_is_empty_value() >>> would make the code easier to read (just my opinion) >> You are correct, done >>> src/hotspot/cpu/x86/macroAssembler_x86.hpp >>> >>> line 107: I don?t get the comment (seems to be a bad copy/paste from line 574) >>> line 551: does the method really need to be virtual? >> 107: you are right, looks like when I rearranged where method decls went >> >> 551: nope, removed >> >>> src/hotspot/cpu/x86/templateTable_x86.cpp >>> >>> line 4339: the template of defaultvalue could be simplified by using the new get_empty_value_oop() >>> line 3704: qputfield could be re-written to use access_value_copy() and avoid the runtime call >>> (this could be delayed to another CR) >>> line 3795: Label slow_path is not used >> 4339: Done >> >> 3704: Yeap, but deferred for another CR for now (JDK-8234632 for putfield and JDK-8234633 for aaload/aastore) >> >> 3795: Label removed >> >>> src/hotspot/share/gc/shared/collectedHeap.hpp >>> >>> src/hotspot/share/gc/shared/collectedHeap.inline.hpp >>> >>> No comment >>> >>> src/hotspot/share/gc/shared/memAllocator.cpp >>> >>> No comment >>> >>> src/hotspot/share/gc/shared/memAllocator.hpp >>> >>> No comment >>> >>> src/hotspot/share/oops/instanceKlass.cpp >>> >>> line 508: [style] add empty line? >>> >>> src/hotspot/share/oops/instanceKlass.hpp >>> >>> No comment >>> >>> src/hotspot/share/oops/valueKlass.cpp >>> >>> no comment >>> >>> src/hotspot/share/oops/valueKlass.hpp >>> >>> line 109: allocate_instance_buffer() it would be helpful to have a comment here to explicitly >>> state that the allocated instance memory has not been cleared, so initialization of >>> its payload *must* follow before returning the oop to Java (there?s a comment in >>> collectedHeap.hpp, but people have to dig in to find it) >> Good spotting. This was left over code from attempting to improve the interpreter runtime call, I really should have given it a little more care than the initial benchmarking hack. Commented as: >> >> // allocates a stand alone value buffer in the Java heap >> // DOES NOT have memory cleared, user MUST initialize payload before >> // returning to Java (i.e.: value_copy) >> >>> src/hotspot/share/gc/shared/barrierSetRuntime.cpp >>> >>> No comment >>> >>> src/hotspot/share/gc/shared/barrierSetRuntime.hpp >>> >>> No comment >>> >>> Regards, >>> >>> Fred >> >> From david.simms at oracle.com Fri Nov 22 14:19:32 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Fri, 22 Nov 2019 14:19:32 +0000 Subject: hg: valhalla/valhalla: 8234507: [lworld] Macro ASM version of access_value_copy Message-ID: <201911221419.xAMEJXVQ027083@aojmv0008.oracle.com> Changeset: 7fca6c5e0d99 Author: dsimms Date: 2019-11-22 15:19 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7fca6c5e0d99 8234507: [lworld] Macro ASM version of access_value_copy Reviewed-by: fparain ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/interp_masm_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/templateTable_x86.cpp + src/hotspot/share/gc/shared/barrierSetRuntime.cpp + src/hotspot/share/gc/shared/barrierSetRuntime.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/collectedHeap.inline.hpp ! src/hotspot/share/gc/shared/memAllocator.cpp ! src/hotspot/share/gc/shared/memAllocator.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/valueKlass.cpp ! src/hotspot/share/oops/valueKlass.hpp From forax at univ-mlv.fr Fri Nov 22 14:57:40 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Fri, 22 Nov 2019 15:57:40 +0100 (CET) Subject: Hidden classes + class data Message-ID: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> Hi Mandy, hi all I've played a little with the nestmates branch, trying to see how to re-implement the reflection API based on the method handle API. https://gist.github.com/forax/d0f0034190bc479b86ce977fb94ca176 A question, correct me if i'm wrong but every hidden classes has its own bytecode array even when i call defineHiddenClassWithClassData several times with the same byte array ? Also, is it possible to have a Lookup.defineClass variation that takes a class data as parameter but do not create a hidden class, something like Class defineClassWithClassData(byte[] bytes, Object classData, boolean initialize) It would be very convenient in order to generate a something like a lambda body (not the lambda adapter/proxy) where you want it to appear in th stacktrace because it's a code produced by a user. R?mi From mandy.chung at oracle.com Fri Nov 22 16:56:24 2019 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 22 Nov 2019 08:56:24 -0800 Subject: Hidden classes + class data In-Reply-To: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> Message-ID: <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> On 11/22/19 6:57 AM, Remi Forax wrote: > Hi Mandy, > hi all > > I've played a little with the nestmates branch, trying to see how to re-implement the reflection API based on the method handle API. > > https://gist.github.com/forax/d0f0034190bc479b86ce977fb94ca176 > > A question, correct me if i'm wrong but every hidden classes has its own bytecode array even when i call defineHiddenClassWithClassData several times with the same byte array ? Yes it does.? It clones the given byte array to avoid it might be modified after any kind of validation.? Lookup::defineClass does the clone too.?? Perhaps we have to rethink about the security aspect vs the overhead of cloning? > Also, is it possible to have a Lookup.defineClass variation that takes a class data as parameter but do not create a hidden class, something like > Class defineClassWithClassData(byte[] bytes, Object classData, boolean initialize) > > It would be very convenient in order to generate a something like a lambda body (not the lambda adapter/proxy) where you want it to appear in th stacktrace because it's a code produced by a user. Does this also need access to its nestmate?? Our intent is to limit the dynamic nestmates to hidden classes as the current scope for this work. ? ? Separate the extension of dynamic nestmates to ordinary classes in the future. Mandy From brian.goetz at oracle.com Fri Nov 22 17:00:35 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 22 Nov 2019 12:00:35 -0500 Subject: Hidden classes + class data In-Reply-To: <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> Message-ID: <65152B04-2358-46C6-828E-A0700E43BEF6@oracle.com> When we have frozen arrays, this is solved by freezing the array, which is a no-op if the array is already frozen. > On Nov 22, 2019, at 11:56 AM, Mandy Chung wrote: > > > > On 11/22/19 6:57 AM, Remi Forax wrote: >> Hi Mandy, >> hi all >> >> I've played a little with the nestmates branch, trying to see how to re-implement the reflection API based on the method handle API. >> >> https://gist.github.com/forax/d0f0034190bc479b86ce977fb94ca176 >> >> A question, correct me if i'm wrong but every hidden classes has its own bytecode array even when i call defineHiddenClassWithClassData several times with the same byte array ? > > Yes it does. It clones the given byte array to avoid it might be modified after any kind of validation. Lookup::defineClass does the clone too. Perhaps we have to rethink about the security aspect vs the overhead of cloning? > >> Also, is it possible to have a Lookup.defineClass variation that takes a class data as parameter but do not create a hidden class, something like >> Class defineClassWithClassData(byte[] bytes, Object classData, boolean initialize) >> >> It would be very convenient in order to generate a something like a lambda body (not the lambda adapter/proxy) where you want it to appear in th stacktrace because it's a code produced by a user. > > Does this also need access to its nestmate? Our intent is to limit the dynamic nestmates to hidden classes as the current scope for this work. Separate the extension of dynamic nestmates to ordinary classes in the future. > > Mandy From forax at univ-mlv.fr Fri Nov 22 21:03:24 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Fri, 22 Nov 2019 22:03:24 +0100 (CET) Subject: Hidden classes + class data In-Reply-To: <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> Message-ID: <1098952777.2254848.1574456604781.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "mandy chung" > ?: "Remi Forax" > Cc: "valhalla-dev" > Envoy?: Vendredi 22 Novembre 2019 17:56:24 > Objet: Re: Hidden classes + class data > On 11/22/19 6:57 AM, Remi Forax wrote: >> Hi Mandy, >> hi all >> >> I've played a little with the nestmates branch, trying to see how to >> re-implement the reflection API based on the method handle API. >> >> https://gist.github.com/forax/d0f0034190bc479b86ce977fb94ca176 >> >> A question, correct me if i'm wrong but every hidden classes has its own >> bytecode array even when i call defineHiddenClassWithClassData several times >> with the same byte array ? > > Yes it does.? It clones the given byte array to avoid it might be > modified after any kind of validation.? Lookup::defineClass does the > clone too.?? Perhaps we have to rethink about the security aspect vs the > overhead of cloning ? > Apart what Brian said about Array 2.0, i've no real solution. >> Also, is it possible to have a Lookup.defineClass variation that takes a class >> data as parameter but do not create a hidden class, something like >> Class defineClassWithClassData(byte[] bytes, Object classData, boolean >> initialize) >> >> It would be very convenient in order to generate a something like a lambda body >> (not the lambda adapter/proxy) where you want it to appear in th stacktrace >> because it's a code produced by a user. > > Does this also need access to its nestmate?? no, it's a plain java class that needs a classData object. > Our intent is to limit the dynamic nestmates to hidden classes as the current scope for this work. > Separate the extension of dynamic nestmates to ordinary classes in the future. again, correct me if i'm wrong, technically, it's not really dynamic nestmates, it's more nest host delegation ? The hidden class being able to delegate all the security checks to another class. > > Mandy R?mi From frederic.parain at oracle.com Fri Nov 22 21:08:08 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Fri, 22 Nov 2019 16:08:08 -0500 Subject: RFR: JNI support for flattened arrays Message-ID: Please review these changes adding JNI support for flattened arrays. The model for accessing flattened arrays from native code is the same as for primitive arrays, with these two new methods: void* (JNICALL *GetFlattenedArrayElements) (JNIEnv* env, jarray array , jboolean *isCopy); void (JNICALL *ReleaseFlattenedArrayElements) (JNIEnv* env, jarray, void* elem, jint mode); Native access to inline types arrays is allowed only if the array is flattened and array elements do not contain oops. However, native code needs more information to deal with inline types arrays: In order to get the size of an element of the array: jsize (JNICALL *GetFlattenedArrayElementSize) (JNIEnv* env, jarray array); In order to get the class of the array elements: jclass (JNICALL *GetFlattenedArrayElementClass) (JNIEnv* env, jarray array); An in order to get the offset of a field inside an array element, or inside a flattened field: jsize (JNICALL *GetFieldOffsetInFlattenedLayout) (JNIEnv* env, jclass clazz, const char *name, const char *signature, jboolean* isFlattened); The webrev includes tests showing examples on how to interact with a flattened array from native code (initialization, update, sorting). Webrev: http://cr.openjdk.java.net/~fparain/jniflattenedarrays/webrev.00/index.html Thank you, Fred From frederic.parain at oracle.com Fri Nov 22 21:31:44 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Fri, 22 Nov 2019 16:31:44 -0500 Subject: RFR: 8234688 [lworld] Supporting volatile semantic for flattenable fields Message-ID: <243E0AF1-6C25-427B-B307-810C0114408E@oracle.com> Please review this small changeset to support volatile flattenable fields. The short term solution is to not flatten these fields. CR: https://bugs.openjdk.java.net/browse/JDK-8234688 Webrev: http://cr.openjdk.java.net/~fparain/volatile/webrev.00/ Thank you, Fred From mandy.chung at oracle.com Sat Nov 23 00:54:31 2019 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 22 Nov 2019 16:54:31 -0800 Subject: Hidden classes + class data In-Reply-To: <1098952777.2254848.1574456604781.JavaMail.zimbra@u-pem.fr> References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> <1098952777.2254848.1574456604781.JavaMail.zimbra@u-pem.fr> Message-ID: <378dc22a-9975-d93d-155e-02ee2c804c0d@oracle.com> On 11/22/19 1:03 PM, forax at univ-mlv.fr wrote: > again, correct me if i'm wrong, technically, it's not really dynamic nestmates, it's more nest host delegation ? > The hidden class being able to delegate all the security checks to another class. A hidden class does have the same nest access as specified in JVMS, i.e. all members (ordinary or hidden classes) in the same nest can access each other's private members. OTOH, VM anonymous class is more of "nest host delegation"? which may be what you are thinking.? It is not added to other's nest. A hidden class [1] can join the nest of the lookup class by defining it with NESTMATE class option.?? If the lookup class is LC that defines HC as a nestmate, HC will join the nest of LC whose nest host is equivalent to the class returned by LC.getNestHost().? The hidden nestmate classes section in [1] would need some? editing but hope that gives a good starting point (that reflects the discussion [2][3]) Mandy [1] https://bugs.openjdk.java.net/browse/JDK-8220607 [2] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-October/006429.html [3] https://mail.openjdk.java.net/pipermail/valhalla-dev/2019-November/006535.html From david.holmes at oracle.com Sun Nov 24 23:17:36 2019 From: david.holmes at oracle.com (David Holmes) Date: Mon, 25 Nov 2019 09:17:36 +1000 Subject: Hidden classes + class data In-Reply-To: <1098952777.2254848.1574456604781.JavaMail.zimbra@u-pem.fr> References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> <1098952777.2254848.1574456604781.JavaMail.zimbra@u-pem.fr> Message-ID: On 23/11/2019 7:03 am, forax at univ-mlv.fr wrote: > ----- Mail original ----- >> De: "mandy chung" >> ?: "Remi Forax" >> Cc: "valhalla-dev" >> Envoy?: Vendredi 22 Novembre 2019 17:56:24 >> Objet: Re: Hidden classes + class data > >> On 11/22/19 6:57 AM, Remi Forax wrote: >>> Hi Mandy, >>> hi all >>> >>> I've played a little with the nestmates branch, trying to see how to >>> re-implement the reflection API based on the method handle API. >>> >>> https://gist.github.com/forax/d0f0034190bc479b86ce977fb94ca176 >>> >>> A question, correct me if i'm wrong but every hidden classes has its own >>> bytecode array even when i call defineHiddenClassWithClassData several times >>> with the same byte array ? >> >> Yes it does.? It clones the given byte array to avoid it might be >> modified after any kind of validation.? Lookup::defineClass does the >> clone too.?? Perhaps we have to rethink about the security aspect vs the >> overhead of cloning ? >> > > Apart what Brian said about Array 2.0, i've no real solution. > >>> Also, is it possible to have a Lookup.defineClass variation that takes a class >>> data as parameter but do not create a hidden class, something like >>> Class defineClassWithClassData(byte[] bytes, Object classData, boolean >>> initialize) >>> >>> It would be very convenient in order to generate a something like a lambda body >>> (not the lambda adapter/proxy) where you want it to appear in th stacktrace >>> because it's a code produced by a user. >> >> Does this also need access to its nestmate? > > no, it's a plain java class that needs a classData object. > >> Our intent is to limit the dynamic nestmates to hidden classes as the current scope for this work. >> Separate the extension of dynamic nestmates to ordinary classes in the future. > > again, correct me if i'm wrong, technically, it's not really dynamic nestmates, it's more nest host delegation ? > The hidden class being able to delegate all the security checks to another class. No it is dynamic nestmates. The hidden class declares the existing nest-host as its nest-host (thereby dynamically injecting itself into the nest) and there after will pass all nestmate access checks between itself, the host and any other nest members. David ----- > > >> >> Mandy > > R?mi > From david.simms at oracle.com Mon Nov 25 09:27:21 2019 From: david.simms at oracle.com (David Simms) Date: Mon, 25 Nov 2019 10:27:21 +0100 Subject: RFR: 8234688 [lworld] Supporting volatile semantic for flattenable fields In-Reply-To: <243E0AF1-6C25-427B-B307-810C0114408E@oracle.com> References: <243E0AF1-6C25-427B-B307-810C0114408E@oracle.com> Message-ID: <54ce60ce-00aa-ae88-0c2c-1aff1ba51916@oracle.com> I'm good with the change, nice to add a test, thanks for that. Just a small comment: we could probably allow for the flattening for sizes that are naturally atomic for the H/W, i.e. x86_64 allows 64 bits ? (Assuming correct alignment for "Copy::conjoint_memory_atomic" to consume). /D On 22/11/19 10:31 PM, Frederic Parain wrote: > Please review this small changeset to support volatile flattenable fields. > The short term solution is to not flatten these fields. > > CR: > https://bugs.openjdk.java.net/browse/JDK-8234688 > > Webrev: > http://cr.openjdk.java.net/~fparain/volatile/webrev.00/ > > Thank you, > > Fred From harold.seigel at oracle.com Mon Nov 25 14:30:24 2019 From: harold.seigel at oracle.com (harold.seigel at oracle.com) Date: Mon, 25 Nov 2019 14:30:24 +0000 Subject: hg: valhalla/valhalla: Summary: Remove eager load-time initialization of hidden classes Message-ID: <201911251430.xAPEUOAa008769@aojmv0008.oracle.com> Changeset: 61ee2fdd77ea Author: hseigel Date: 2019-11-25 14:29 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/61ee2fdd77ea Summary: Remove eager load-time initialization of hidden classes Reviewed-by: mchung ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/oops/instanceKlass.cpp From frederic.parain at oracle.com Mon Nov 25 14:39:50 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Mon, 25 Nov 2019 09:39:50 -0500 Subject: RFR: 8234688 [lworld] Supporting volatile semantic for flattenable fields In-Reply-To: <54ce60ce-00aa-ae88-0c2c-1aff1ba51916@oracle.com> References: <243E0AF1-6C25-427B-B307-810C0114408E@oracle.com> <54ce60ce-00aa-ae88-0c2c-1aff1ba51916@oracle.com> Message-ID: <5707ca82-c2a8-cd29-087a-4fe2f1b9f8dc@oracle.com> David, Thank you for the review. The main problem with flattening of small volatile inline fields is not the layout or the runtime, but the support in the JIT that is not trivial (it impacts scalarization). After discussion with Tobias, this is not something likely to be implemented in the short term. Fred On 11/25/19 4:27 AM, David Simms wrote: > > I'm good with the change, nice to add a test, thanks for that. > > Just a small comment: we could probably allow for the flattening for > sizes that are naturally atomic for the H/W, i.e. x86_64 allows 64 bits > ? (Assuming correct alignment for "Copy::conjoint_memory_atomic" to > consume). > > /D > > > On 22/11/19 10:31 PM, Frederic Parain wrote: >> Please review this small changeset to support volatile flattenable >> fields. >> The short term solution is to not flatten these fields. >> >> CR: >> https://bugs.openjdk.java.net/browse/JDK-8234688 >> >> Webrev: >> http://cr.openjdk.java.net/~fparain/volatile/webrev.00/ >> >> Thank you, >> >> Fred > > From frederic.parain at oracle.com Mon Nov 25 16:07:54 2019 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Mon, 25 Nov 2019 16:07:54 +0000 Subject: hg: valhalla/valhalla: 8234688: [lworld] Supporting volatile semantic for flattenable fields Message-ID: <201911251607.xAPG7tOr008576@aojmv0008.oracle.com> Changeset: 472b585add8c Author: fparain Date: 2019-11-25 11:07 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/472b585add8c 8234688: [lworld] Supporting volatile semantic for flattenable fields Reviewed-by: dsimms ! src/hotspot/share/classfile/fieldLayoutBuilder.cpp + test/hotspot/jtreg/runtime/valhalla/valuetypes/VolatileTest.java From david.simms at oracle.com Mon Nov 25 16:36:25 2019 From: david.simms at oracle.com (David Simms) Date: Mon, 25 Nov 2019 17:36:25 +0100 Subject: RFR: JNI support for flattened arrays In-Reply-To: References: Message-ID: <6309be44-0240-b80e-8dec-145adff99962@oracle.com> So there is an element of "you have got to know what you doing" with these APIs. But that is the nature of JNI itself. So this does enable very specific use case where users wish to transfer the specific types of raw data, with no Java object references embedded, as that is not technically feasible just now (perhaps with some pinning). Get/SetObjectArrayElement provide a good general purpose solution for most... ...however for raw performance, we need to open this possibility of using raw array data. Even for JDK internals, it would be nice to have in the repo. One might argue that Panama would be the way forward, but until it exists side by side we can't rely upon it's existence, or pretend to know each other's release schedules. Code itself follows the rest, there is a small indent issue at jni.h:1905 ...otherwise, go and head and push. /D On 2019-11-22 22:08, Frederic Parain wrote: > Please review these changes adding JNI support for flattened arrays. > > The model for accessing flattened arrays from native code is the same > as for primitive arrays, with these two new methods: > > void* (JNICALL *GetFlattenedArrayElements) > (JNIEnv* env, jarray array , jboolean *isCopy); > void (JNICALL *ReleaseFlattenedArrayElements) > (JNIEnv* env, jarray, void* elem, jint mode); > > Native access to inline types arrays is allowed only if the array is > flattened and array elements do not contain oops. > > However, native code needs more information to deal with inline types > arrays: > > In order to get the size of an element of the array: > > jsize (JNICALL *GetFlattenedArrayElementSize) > (JNIEnv* env, jarray array); > > In order to get the class of the array elements: > > jclass (JNICALL *GetFlattenedArrayElementClass) > (JNIEnv* env, jarray array); > > > An in order to get the offset of a field inside an array element, or > inside a flattened field: > > jsize (JNICALL *GetFieldOffsetInFlattenedLayout) > (JNIEnv* env, jclass clazz, const char *name, const char *signature, jboolean* isFlattened); > > The webrev includes tests showing examples on how to interact with > a flattened array from native code (initialization, update, sorting). > > Webrev: > http://cr.openjdk.java.net/~fparain/jniflattenedarrays/webrev.00/index.html > > Thank you, > > Fred > > From frederic.parain at oracle.com Mon Nov 25 20:09:04 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Mon, 25 Nov 2019 15:09:04 -0500 Subject: RFR: JNI support for flattened arrays In-Reply-To: <6309be44-0240-b80e-8dec-145adff99962@oracle.com> References: <6309be44-0240-b80e-8dec-145adff99962@oracle.com> Message-ID: David, Thank you for the review and for clarifying the motivation of this work. I?ve fixed the indentation in jni.h. Fred > On Nov 25, 2019, at 11:36, David Simms wrote: > > > So there is an element of "you have got to know what you doing" with these APIs. But that is the nature of JNI itself. > > So this does enable very specific use case where users wish to transfer the specific types of raw data, with no Java object references embedded, as that is not technically feasible just now (perhaps with some pinning). Get/SetObjectArrayElement provide a good general purpose solution for most... > > ...however for raw performance, we need to open this possibility of using raw array data. Even for JDK internals, it would be nice to have in the repo. One might argue that Panama would be the way forward, but until it exists side by side we can't rely upon it's existence, or pretend to know each other's release schedules. > > Code itself follows the rest, there is a small indent issue at jni.h:1905 > > ...otherwise, go and head and push. > > /D > > > On 2019-11-22 22:08, Frederic Parain wrote: >> Please review these changes adding JNI support for flattened arrays. >> >> The model for accessing flattened arrays from native code is the same >> as for primitive arrays, with these two new methods: >> >> void* (JNICALL *GetFlattenedArrayElements) >> (JNIEnv* env, jarray array , jboolean *isCopy); >> void (JNICALL *ReleaseFlattenedArrayElements) >> (JNIEnv* env, jarray, void* elem, jint mode); >> >> Native access to inline types arrays is allowed only if the array is >> flattened and array elements do not contain oops. >> >> However, native code needs more information to deal with inline types >> arrays: >> >> In order to get the size of an element of the array: >> >> jsize (JNICALL *GetFlattenedArrayElementSize) >> (JNIEnv* env, jarray array); >> >> In order to get the class of the array elements: >> >> jclass (JNICALL *GetFlattenedArrayElementClass) >> (JNIEnv* env, jarray array); >> >> >> An in order to get the offset of a field inside an array element, or >> inside a flattened field: >> >> jsize (JNICALL *GetFieldOffsetInFlattenedLayout) >> (JNIEnv* env, jclass clazz, const char *name, const char *signature, jboolean* isFlattened); >> >> The webrev includes tests showing examples on how to interact with >> a flattened array from native code (initialization, update, sorting). >> >> Webrev: >> http://cr.openjdk.java.net/~fparain/jniflattenedarrays/webrev.00/index.html >> >> Thank you, >> >> Fred >> > From frederic.parain at oracle.com Mon Nov 25 20:21:32 2019 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Mon, 25 Nov 2019 20:21:32 +0000 Subject: hg: valhalla/valhalla: 8234761: [lworld] JNI extensions to provide direct access to flattened arrays Message-ID: <201911252021.xAPKLXtl015658@aojmv0008.oracle.com> Changeset: 1f1c848dcdfd Author: fparain Date: 2019-11-25 15:20 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1f1c848dcdfd 8234761: [lworld] JNI extensions to provide direct access to flattened arrays Reviewed-by: dsimms ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jniCheck.cpp ! src/java.base/share/native/include/jni.h + test/hotspot/jtreg/runtime/valhalla/valuetypes/TestJNIArrays.java + test/hotspot/jtreg/runtime/valhalla/valuetypes/libTestJNIArrays.c From forax at univ-mlv.fr Tue Nov 26 11:18:13 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Tue, 26 Nov 2019 12:18:13 +0100 (CET) Subject: Hidden classes + class data In-Reply-To: References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> <1098952777.2254848.1574456604781.JavaMail.zimbra@u-pem.fr> Message-ID: <1345330569.831250.1574767093059.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "David Holmes" > ?: "Remi Forax" , "mandy chung" > Cc: "valhalla-dev" > Envoy?: Lundi 25 Novembre 2019 00:17:36 > Objet: Re: Hidden classes + class data [...] >>> Our intent is to limit the dynamic nestmates to hidden classes as the current >>> scope for this work. >>> Separate the extension of dynamic nestmates to ordinary classes in the future. >> >> again, correct me if i'm wrong, technically, it's not really dynamic nestmates, >> it's more nest host delegation ? >> The hidden class being able to delegate all the security checks to another >> class. > > No it is dynamic nestmates. The hidden class declares the existing > nest-host as its nest-host (thereby dynamically injecting itself into > the nest) and there after will pass all nestmate access checks between > itself, the host and any other nest members. > > David > ----- > Ok ! thanks David and Mandy. R?mi From david.simms at oracle.com Tue Nov 26 16:13:06 2019 From: david.simms at oracle.com (David Simms) Date: Tue, 26 Nov 2019 17:13:06 +0100 Subject: RFR 8233200: [lworld] compiler/runtime/Test8010927.java fails with fatal error: DEBUG MESSAGE: Verify oop store failed Message-ID: Bug/RFE: https://bugs.openjdk.java.net/browse/JDK-8233200 Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8233200/webrev0/ Subtle mess up in the use of "MemAllocator::finish()", it is virtual and there is an overload which potentially safepoints, thereby possibly moving the initial allocation...(requires allocation of large array) "-XX:+ZVerifyViews" turned out to be an excellent debugging tool, so I enabled it in ValueOops testing, along with increased test array size (decrease G1 required GC count to 10 since the larger array was taking more test run time). I believe relates to JDK-8231755, which I removed from the problem list and re-tested. Cheers /David Simms From frederic.parain at oracle.com Tue Nov 26 16:25:28 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Tue, 26 Nov 2019 11:25:28 -0500 Subject: RFR 8233200: [lworld] compiler/runtime/Test8010927.java fails with fatal error: DEBUG MESSAGE: Verify oop store failed In-Reply-To: References: Message-ID: <0A1A1436-5CCC-496C-B97D-591073606954@oracle.com> Looks good to me. Fred > On Nov 26, 2019, at 11:13, David Simms wrote: > > > Bug/RFE: https://bugs.openjdk.java.net/browse/JDK-8233200 > > Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8233200/webrev0/ > > > Subtle mess up in the use of "MemAllocator::finish()", it is virtual and there is an overload which potentially safepoints, thereby possibly moving the initial allocation...(requires allocation of large array) > > "-XX:+ZVerifyViews" turned out to be an excellent debugging tool, so I enabled it in ValueOops testing, along with increased test array size (decrease G1 required GC count to 10 since the larger array was taking more test run time). > > I believe relates to JDK-8231755, which I removed from the problem list and re-tested. > > Cheers > > /David Simms > From david.simms at oracle.com Tue Nov 26 16:35:09 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Tue, 26 Nov 2019 16:35:09 +0000 Subject: hg: valhalla/valhalla: 8233200: [lworld] compiler/runtime/Test8010927.java fails with fatal error: DEBUG MESSAGE: Verify oop store failed Message-ID: <201911261635.xAQGZ9PV001201@aojmv0008.oracle.com> Changeset: 99c5c766dc9c Author: dsimms Date: 2019-11-26 17:34 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/99c5c766dc9c 8233200: [lworld] compiler/runtime/Test8010927.java fails with fatal error: DEBUG MESSAGE: Verify oop store failed Reviewed-by: fparain ! src/hotspot/share/gc/shared/memAllocator.cpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueOops.java From forax at univ-mlv.fr Tue Nov 26 23:03:52 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Wed, 27 Nov 2019 00:03:52 +0100 (CET) Subject: Hidden classes + class data In-Reply-To: <65152B04-2358-46C6-828E-A0700E43BEF6@oracle.com> References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> <65152B04-2358-46C6-828E-A0700E43BEF6@oracle.com> Message-ID: <1737758747.13944.1574809432804.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "Brian Goetz" > ?: "mandy chung" > Cc: "Remi Forax" , "valhalla-dev" > Envoy?: Vendredi 22 Novembre 2019 18:00:35 > Objet: Re: Hidden classes + class data > When we have frozen arrays, this is solved by freezing the array, which is a > no-op if the array is already frozen. or wait until we have having a real class templating mechanism because passing a class data object is a de-generate case of class templating with a kiddy pool containing only one Object. hummm I wonder if defineHiddenClassWithClassData should not take another class as parameter instead of a byte array (using the byte array of that class) enabling more sharing of the bytecode and allowing to do the verification only once if defineHiddenClassWithClassData is called several times with the same Class. R?mi > >> On Nov 22, 2019, at 11:56 AM, Mandy Chung wrote: >> >> >> >> On 11/22/19 6:57 AM, Remi Forax wrote: >>> Hi Mandy, >>> hi all >>> >>> I've played a little with the nestmates branch, trying to see how to >>> re-implement the reflection API based on the method handle API. >>> >>> https://gist.github.com/forax/d0f0034190bc479b86ce977fb94ca176 >>> >>> A question, correct me if i'm wrong but every hidden classes has its own >>> bytecode array even when i call defineHiddenClassWithClassData several times >>> with the same byte array ? >> >> Yes it does. It clones the given byte array to avoid it might be modified after >> any kind of validation. Lookup::defineClass does the clone too. Perhaps we >> have to rethink about the security aspect vs the overhead of cloning? >> >>> Also, is it possible to have a Lookup.defineClass variation that takes a class >>> data as parameter but do not create a hidden class, something like >>> Class defineClassWithClassData(byte[] bytes, Object classData, boolean >>> initialize) >>> >>> It would be very convenient in order to generate a something like a lambda body >>> (not the lambda adapter/proxy) where you want it to appear in th stacktrace >>> because it's a code produced by a user. >> >> Does this also need access to its nestmate? Our intent is to limit the dynamic >> nestmates to hidden classes as the current scope for this work. Separate >> the extension of dynamic nestmates to ordinary classes in the future. >> > > Mandy From john.r.rose at oracle.com Wed Nov 27 00:55:16 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 27 Nov 2019 00:55:16 +0000 (UTC) Subject: Hidden classes + class data In-Reply-To: <1737758747.13944.1574809432804.JavaMail.zimbra@u-pem.fr> References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> <65152B04-2358-46C6-828E-A0700E43BEF6@oracle.com> <1737758747.13944.1574809432804.JavaMail.zimbra@u-pem.fr> Message-ID: <66898D0F-53EE-42C8-AC9E-288BE7400DA3@oracle.com> On Nov 26, 2019, at 3:03 PM, forax at univ-mlv.fr wrote: > > I wonder if defineHiddenClassWithClassData should not take another class as parameter instead of a byte array (using the byte array of that class) enabling more sharing of the bytecode and allowing to do the verification only once if defineHiddenClassWithClassData is called several times with the same Class. Yes. I?d like to try this with templates, when we get them, since templates are supposed to share metadata with their species. E.g., for a lambda form of a predefined shape with 2 free variables (a type and a MH), define it as a template with those parameters and inject it as many times as you see distinct combinations of those parameters. From mandy.chung at oracle.com Wed Nov 27 01:30:57 2019 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 26 Nov 2019 17:30:57 -0800 Subject: Hidden classes + class data In-Reply-To: <66898D0F-53EE-42C8-AC9E-288BE7400DA3@oracle.com> References: <871949138.2149512.1574434660660.JavaMail.zimbra@u-pem.fr> <94ddd5c6-9729-e03f-9246-e30e83267c02@oracle.com> <65152B04-2358-46C6-828E-A0700E43BEF6@oracle.com> <1737758747.13944.1574809432804.JavaMail.zimbra@u-pem.fr> <66898D0F-53EE-42C8-AC9E-288BE7400DA3@oracle.com> Message-ID: On 11/26/19 4:55 PM, John Rose wrote: > On Nov 26, 2019, at 3:03 PM, forax at univ-mlv.fr wrote: >> I wonder if defineHiddenClassWithClassData should not take another class as parameter instead of a byte array (using the byte array of that class) enabling more sharing of the bytecode and allowing to do the verification only once if defineHiddenClassWithClassData is called several times with the same Class. > Yes. I?d like to try this with templates, when we get them, since > templates are supposed to share metadata with their species. > > E.g., for a lambda form of a predefined shape with 2 free variables > (a type and a MH), define it as a template with those parameters > and inject it as many times as you see distinct combinations of > those parameters. This produces a distinct Class mirror for each hidden class defined from the same metadata (class bytes) with a different class data. Perhaps we can experiment ClassDefiner builder-like API.?? I will explore this. Mandy From frederic.parain at oracle.com Wed Nov 27 01:40:31 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Tue, 26 Nov 2019 20:40:31 -0500 Subject: RFR: 8234632 [lworld] Create fast path for putfield of inlined values Message-ID: <4E559F8D-AA7C-4424-ACAA-78A4DE03B682@oracle.com> Please review this change in the interpreter replacing the runtime call in putfield with ASM access_value_copy when writing flattened fields. CR: https://bugs.openjdk.java.net/browse/JDK-8234632 Webrev: http://cr.openjdk.java.net/~fparain/8234632/webrev.00/index.html Testing: tier 1,2 and 3 with Mach5. Thank you, Fred From david.simms at oracle.com Wed Nov 27 02:41:52 2019 From: david.simms at oracle.com (David Simms) Date: Wed, 27 Nov 2019 03:41:52 +0100 Subject: RFR: 8234632 [lworld] Create fast path for putfield of inlined values In-Reply-To: <4E559F8D-AA7C-4424-ACAA-78A4DE03B682@oracle.com> References: <4E559F8D-AA7C-4424-ACAA-78A4DE03B682@oracle.com> Message-ID: <9eff9da2-cffb-b64e-490e-ba35debf53e3@oracle.com> Looks good. On 2019-11-27 02:40, Frederic Parain wrote: > Please review this change in the interpreter replacing the runtime > call in putfield with ASM access_value_copy when writing flattened fields. > > CR: > https://bugs.openjdk.java.net/browse/JDK-8234632 > > Webrev: > http://cr.openjdk.java.net/~fparain/8234632/webrev.00/index.html > > Testing: tier 1,2 and 3 with Mach5. > > Thank you, > > Fred > > From frederic.parain at oracle.com Wed Nov 27 12:57:06 2019 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Wed, 27 Nov 2019 12:57:06 +0000 Subject: hg: valhalla/valhalla: 8234632: [lworld] Create fast path for putfield of inlined values Message-ID: <201911271257.xARCv7cv014476@aojmv0008.oracle.com> Changeset: 10b5227a8bda Author: fparain Date: 2019-11-27 07:56 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/10b5227a8bda 8234632: [lworld] Create fast path for putfield of inlined values Reviewed-by: dsimms ! src/hotspot/cpu/x86/templateTable_x86.cpp ! src/hotspot/cpu/x86/templateTable_x86.hpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/interpreter/interpreterRuntime.hpp From frederic.parain at oracle.com Wed Nov 27 12:57:22 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Wed, 27 Nov 2019 07:57:22 -0500 Subject: RFR: 8234632 [lworld] Create fast path for putfield of inlined values In-Reply-To: <9eff9da2-cffb-b64e-490e-ba35debf53e3@oracle.com> References: <4E559F8D-AA7C-4424-ACAA-78A4DE03B682@oracle.com> <9eff9da2-cffb-b64e-490e-ba35debf53e3@oracle.com> Message-ID: Thank you. Fred > On Nov 26, 2019, at 21:41, David Simms wrote: > > > Looks good. > > On 2019-11-27 02:40, Frederic Parain wrote: >> Please review this change in the interpreter replacing the runtime >> call in putfield with ASM access_value_copy when writing flattened fields. >> >> CR: >> https://bugs.openjdk.java.net/browse/JDK-8234632 >> >> Webrev: >> http://cr.openjdk.java.net/~fparain/8234632/webrev.00/index.html >> >> Testing: tier 1,2 and 3 with Mach5. >> >> Thank you, >> >> Fred >> >> > From frederic.parain at oracle.com Wed Nov 27 15:31:41 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Wed, 27 Nov 2019 10:31:41 -0500 Subject: RFR[XS]: 8234912 [lworld] getfield should use fast path before being quickened Message-ID: Please review this another small change allowing the interpreter to use the fast path to read flattened field before the getfield byte code get rewritten to a quick form. CR: https://bugs.openjdk.java.net/browse/JDK-8234912 Webrev: http://cr.openjdk.java.net/~fparain/8234912/webrev.00/index.html Testing: tiers 1 to 3 with Mach5 Thank you, Fred From david.simms at oracle.com Wed Nov 27 16:02:12 2019 From: david.simms at oracle.com (David Simms) Date: Wed, 27 Nov 2019 17:02:12 +0100 Subject: RFR[XS]: 8234912 [lworld] getfield should use fast path before being quickened In-Reply-To: References: Message-ID: Ah, the holder klass is resolved here...nice. Looks good. On 27/11/19 4:31 pm, Frederic Parain wrote: > Please review this another small change allowing the interpreter > to use the fast path to read flattened field before the getfield > byte code get rewritten to a quick form. > > CR: > https://bugs.openjdk.java.net/browse/JDK-8234912 > > Webrev: > http://cr.openjdk.java.net/~fparain/8234912/webrev.00/index.html > > Testing: tiers 1 to 3 with Mach5 > > Thank you, > > Fred > From frederic.parain at oracle.com Wed Nov 27 16:04:14 2019 From: frederic.parain at oracle.com (Frederic Parain) Date: Wed, 27 Nov 2019 11:04:14 -0500 Subject: RFR[XS]: 8234912 [lworld] getfield should use fast path before being quickened In-Reply-To: References: Message-ID: <705AC404-5EBC-4422-BB4A-588255140B58@oracle.com> Thank you, Fred > On Nov 27, 2019, at 11:02, David Simms wrote: > > > Ah, the holder klass is resolved here...nice. > > Looks good. > > On 27/11/19 4:31 pm, Frederic Parain wrote: >> Please review this another small change allowing the interpreter >> to use the fast path to read flattened field before the getfield >> byte code get rewritten to a quick form. >> >> CR: >> https://bugs.openjdk.java.net/browse/JDK-8234912 >> >> Webrev: >> http://cr.openjdk.java.net/~fparain/8234912/webrev.00/index.html >> >> Testing: tiers 1 to 3 with Mach5 >> >> Thank you, >> >> Fred >> > From frederic.parain at oracle.com Wed Nov 27 16:06:27 2019 From: frederic.parain at oracle.com (frederic.parain at oracle.com) Date: Wed, 27 Nov 2019 16:06:27 +0000 Subject: hg: valhalla/valhalla: 8234912: [lworld] getfield should use fast path before being quickened Message-ID: <201911271606.xARG6Shi002834@aojmv0008.oracle.com> Changeset: e5100f2b92e3 Author: fparain Date: 2019-11-27 11:06 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e5100f2b92e3 8234912: [lworld] getfield should use fast path before being quickened Reviewed-by: dsimms ! src/hotspot/cpu/x86/templateTable_x86.cpp From david.simms at oracle.com Wed Nov 27 16:13:47 2019 From: david.simms at oracle.com (David Simms) Date: Wed, 27 Nov 2019 17:13:47 +0100 Subject: RFR: 8234633 [lworld] Create fast path for aaload/aastore of inlined values Message-ID: <7d000703-4553-e315-5982-761ed44f57e6@oracle.com> Bug/RFE: https://bugs.openjdk.java.net/browse/JDK-8234633 Webrev: http://cr.openjdk.java.net/~dsimms/valhalla/8234633/webrev0/ Continued hand rolling assembler, new for aaload and aastore. Added "MacroAssembler::data_for_value_array_index()" provides similar operation to "valueArrayOopDesc::value_at_addr". /David Simms From john.r.rose at oracle.com Thu Nov 28 03:44:44 2019 From: john.r.rose at oracle.com (John Rose) Date: Wed, 27 Nov 2019 19:44:44 -0800 Subject: RFR: JNI support for flattened arrays In-Reply-To: References: Message-ID: It would be reasonable to have similar functions that can handle inlines that are general mixes of primitives and references. For example, getters and setters of flat primitive data can leave holes where the oops are, just padding with zeroes (on get) or ignoring (on set). That handles all primitive data in all kinds of inlines. This functionality could be added to your current function for bulk getting. To handle references, a 2-dimensional getter could be defined: jobject (JNICALL *GetFlattenedArrayElementReference) (JNIEnv *env, jobjectArray array, jsize index, int offset); void (JNICALL *SetFlattenedArrayElementReference) (JNIEnv *env, jobjectArray array, jsize index, int offset, jobject val); jsize (JNICALL *GetFlattenedArrayElementReferenceCount) (JNIEnv* env, jarray array); The ?offset? field would be whatever is returned by GetFieldOffsetInFlattenedLayout. Alternatively, it could be an ordinal less than the ReferenceCount. Since there is no single-element variation on GetFlattenedArrayElements, there?s no way to stream over a flattened array. Perhaps should GetFlattenedArrayElements should allow a slice of the array to be grabbed, not always the whole array? Or perhaps we just want this to do single element access: jsize (JNICALL *GetFlattenedArrayElement) (JNIEnv *env, jobjectArray array, jsize index, // two output buffers; oop positions in primBuf are garbage or zero jsize primBufSize, void* primBuf, jsize oopBufLength, jobject* oopBuf); jsize (JNICALL *SetFlattenedArrayElement) (JNIEnv *env, jobjectArray array, jsize index, // two input buffers; oop positions in primBuf are ignored jsize primBufSize, void* primBuf, jsize oopBufLength, jobject* oopBuf); Returns -1 (JNI_ERR) if something goes wrong, such as a deficient primBufSize or oopBufLength. (User should check ahead on those.) > On Nov 22, 2019, at 1:08 PM, Frederic Parain wrote: > > Please review these changes adding JNI support for flattened arrays. > > The model for accessing flattened arrays from native code is the same > as for primitive arrays, with these two new methods: > > void* (JNICALL *GetFlattenedArrayElements) > (JNIEnv* env, jarray array , jboolean *isCopy); > void (JNICALL *ReleaseFlattenedArrayElements) > (JNIEnv* env, jarray, void* elem, jint mode); > > Native access to inline types arrays is allowed only if the array is > flattened and array elements do not contain oops. > > However, native code needs more information to deal with inline types > arrays: > > In order to get the size of an element of the array: > > jsize (JNICALL *GetFlattenedArrayElementSize) > (JNIEnv* env, jarray array); > > In order to get the class of the array elements: > > jclass (JNICALL *GetFlattenedArrayElementClass) > (JNIEnv* env, jarray array); > > > An in order to get the offset of a field inside an array element, or > inside a flattened field: > > jsize (JNICALL *GetFieldOffsetInFlattenedLayout) > (JNIEnv* env, jclass clazz, const char *name, const char *signature, jboolean* isFlattened); > > The webrev includes tests showing examples on how to interact with > a flattened array from native code (initialization, update, sorting). > > Webrev: > http://cr.openjdk.java.net/~fparain/jniflattenedarrays/webrev.00/index.html > > Thank you, > > Fred > > From david.simms at oracle.com Thu Nov 28 12:47:56 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Thu, 28 Nov 2019 12:47:56 +0000 Subject: hg: valhalla/valhalla: 102 new changesets Message-ID: <201911281248.xASCm7lM024903@aojmv0008.oracle.com> Changeset: bb3472aa26c8 Author: mbaesken Date: 2019-11-20 14:16 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/bb3472aa26c8 8234501: remove obsolete NET_ReadV Reviewed-by: alanb, vtewari ! src/java.base/aix/native/libnet/aix_close.c ! src/java.base/linux/native/libnet/linux_close.c ! src/java.base/macosx/native/libnet/bsd_close.c ! src/java.base/solaris/native/libnet/solaris_close.c ! src/java.base/unix/native/libnet/net_util_md.h Changeset: 92c98aa0f801 Author: tschatzl Date: 2019-11-21 11:42 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/92c98aa0f801 8228609: G1 copy cost prediction uses used vs. actual copied byte Summary: Let the object copy cost predictor use the actual copied bytes as input for the prediction instead of the used bytes. Reviewed-by: kbarrett, sjohanss ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1EvacuationInfo.hpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp ! src/hotspot/share/gc/g1/g1HeterogeneousHeapPolicy.cpp ! src/hotspot/share/gc/g1/g1HeterogeneousHeapPolicy.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1Policy.hpp ! src/hotspot/share/gc/g1/g1Trace.cpp ! src/hotspot/share/gc/shared/workerDataArray.cpp ! src/hotspot/share/gc/shared/workerDataArray.hpp ! src/hotspot/share/gc/shared/workerDataArray.inline.hpp ! test/hotspot/jtreg/gc/g1/TestGCLogMessages.java Changeset: a096dfdcabde Author: coffeys Date: 2019-11-21 11:31 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a096dfdcabde 8233801: GCMEmptyIv.java test fails on Solaris 11.4 Reviewed-by: valeriep ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11AEADCipher.java Changeset: a686b67a59d9 Author: pconcannon Date: 2019-11-20 10:13 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a686b67a59d9 8234103: DatagramSocketImpl::socket is not needed Summary: DatagramSocketImpl has a socket field that links back to the DatagramSocket. This is only used to figure out whether multicasting is supported or not. This fix replaces it with a boolean isMulticast. Reviewed-by: alanb, chegar, dfuchs ! src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/java/net/DatagramSocketImpl.java ! src/java.base/unix/classes/java/net/DefaultDatagramSocketImplFactory.java ! src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java ! src/java.base/windows/classes/java/net/DefaultDatagramSocketImplFactory.java ! src/java.base/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java ! src/java.base/windows/classes/java/net/TwoStacksPlainDatagramSocketImpl.java Changeset: b24f4caa1411 Author: jboes Date: 2019-11-21 09:10 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b24f4caa1411 8234335: Remove line break in class declaration in java.base Summary: Remove line break in class declarations where applicable Reviewed-by: rriggs, lancea ! src/java.base/share/classes/java/io/BufferedInputStream.java ! src/java.base/share/classes/java/io/CharArrayWriter.java ! src/java.base/share/classes/java/io/DataInput.java ! src/java.base/share/classes/java/io/DataInputStream.java ! src/java.base/share/classes/java/io/DataOutput.java ! src/java.base/share/classes/java/io/DataOutputStream.java ! src/java.base/share/classes/java/io/EOFException.java ! src/java.base/share/classes/java/io/FileInputStream.java ! src/java.base/share/classes/java/io/FileOutputStream.java ! src/java.base/share/classes/java/io/FilterInputStream.java ! src/java.base/share/classes/java/io/IOException.java ! src/java.base/share/classes/java/io/InterruptedIOException.java ! src/java.base/share/classes/java/io/LineNumberInputStream.java ! src/java.base/share/classes/java/io/PipedOutputStream.java ! src/java.base/share/classes/java/io/PushbackInputStream.java ! src/java.base/share/classes/java/io/SequenceInputStream.java ! src/java.base/share/classes/java/io/StringBufferInputStream.java ! src/java.base/share/classes/java/io/UTFDataFormatException.java ! src/java.base/share/classes/java/lang/AbstractMethodError.java ! src/java.base/share/classes/java/lang/ArrayStoreException.java ! src/java.base/share/classes/java/lang/ClassCastException.java ! src/java.base/share/classes/java/lang/ClassFormatError.java ! src/java.base/share/classes/java/lang/CloneNotSupportedException.java ! src/java.base/share/classes/java/lang/IllegalArgumentException.java ! src/java.base/share/classes/java/lang/IllegalMonitorStateException.java ! src/java.base/share/classes/java/lang/IllegalStateException.java ! src/java.base/share/classes/java/lang/IncompatibleClassChangeError.java ! src/java.base/share/classes/java/lang/InstantiationError.java ! src/java.base/share/classes/java/lang/InstantiationException.java ! src/java.base/share/classes/java/lang/InterruptedException.java ! src/java.base/share/classes/java/lang/LinkageError.java ! src/java.base/share/classes/java/lang/NegativeArraySizeException.java ! src/java.base/share/classes/java/lang/NoClassDefFoundError.java ! src/java.base/share/classes/java/lang/NoSuchFieldError.java ! src/java.base/share/classes/java/lang/NoSuchMethodError.java ! src/java.base/share/classes/java/lang/NoSuchMethodException.java ! src/java.base/share/classes/java/lang/NullPointerException.java ! src/java.base/share/classes/java/lang/NumberFormatException.java ! src/java.base/share/classes/java/lang/StackOverflowError.java ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/java/lang/ThreadGroup.java ! src/java.base/share/classes/java/lang/UnknownError.java ! src/java.base/share/classes/java/lang/UnsatisfiedLinkError.java ! src/java.base/share/classes/java/lang/UnsupportedClassVersionError.java ! src/java.base/share/classes/java/lang/VerifyError.java ! src/java.base/share/classes/java/lang/invoke/AbstractConstantGroup.java ! src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java ! src/java.base/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/java.base/share/classes/java/lang/invoke/CallSite.java ! src/java.base/share/classes/java/lang/invoke/ClassSpecializer.java ! src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/java.base/share/classes/java/lang/invoke/InfoFromMemberName.java ! src/java.base/share/classes/java/lang/invoke/Invokers.java ! src/java.base/share/classes/java/lang/invoke/MemberName.java ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/MethodType.java ! src/java.base/share/classes/java/lang/invoke/SimpleMethodHandle.java ! src/java.base/share/classes/java/lang/invoke/WrongMethodTypeException.java ! src/java.base/share/classes/java/lang/reflect/Member.java ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/java/net/DatagramSocketImplFactory.java ! src/java.base/share/classes/java/net/HttpRetryException.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/net/MulticastSocket.java ! src/java.base/share/classes/java/net/ProtocolException.java ! src/java.base/share/classes/java/net/ServerSocket.java ! src/java.base/share/classes/java/net/Socket.java ! src/java.base/share/classes/java/net/SocketException.java ! src/java.base/share/classes/java/net/SocketImplFactory.java ! src/java.base/share/classes/java/net/UnknownHostException.java ! src/java.base/share/classes/java/text/ParseException.java ! src/java.base/share/classes/java/util/EmptyStackException.java ! src/java.base/share/classes/java/util/InputMismatchException.java ! src/java.base/share/classes/java/util/MissingResourceException.java ! src/java.base/share/classes/java/util/NoSuchElementException.java ! src/java.base/share/classes/java/util/Properties.java ! src/java.base/share/classes/java/util/Random.java ! src/java.base/share/classes/java/util/Stack.java ! src/java.base/share/classes/java/util/StringTokenizer.java ! src/java.base/share/classes/java/util/jar/JarEntry.java ! src/java.base/share/classes/java/util/jar/JarException.java ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/classes/java/util/jar/JarInputStream.java ! src/java.base/share/classes/java/util/jar/JarOutputStream.java ! src/java.base/share/classes/java/util/zip/Adler32.java ! src/java.base/share/classes/java/util/zip/CRC32.java ! src/java.base/share/classes/java/util/zip/CheckedInputStream.java ! src/java.base/share/classes/java/util/zip/CheckedOutputStream.java ! src/java.base/share/classes/java/util/zip/DataFormatException.java ! src/java.base/share/classes/java/util/zip/DeflaterOutputStream.java ! src/java.base/share/classes/java/util/zip/GZIPInputStream.java ! src/java.base/share/classes/java/util/zip/GZIPOutputStream.java ! src/java.base/share/classes/java/util/zip/InflaterInputStream.java ! src/java.base/share/classes/java/util/zip/ZipEntry.java ! src/java.base/share/classes/java/util/zip/ZipException.java ! src/java.base/share/classes/java/util/zip/ZipFile.java ! src/java.base/share/classes/java/util/zip/ZipInputStream.java ! src/java.base/share/classes/java/util/zip/ZipOutputStream.java Changeset: 533f1183d7c6 Author: chegar Date: 2019-11-21 12:14 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/533f1183d7c6 8233845: (sctp) Relax assertion in sun.nio.ch.sctp.AssociationChange::association Reviewed-by: alanb ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/AssociationChange.java Changeset: 696e6a7e3b6a Author: chegar Date: 2019-11-21 12:14 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/696e6a7e3b6a 8232101: (sctp) Add minimal sanity tests for SCTP Reviewed-by: alanb + test/jdk/java/net/SctpSanity.java Changeset: 7b10581e9632 Author: chegar Date: 2019-11-21 12:14 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7b10581e9632 8232097: (sctp) SctpNet.init() results in java.lang.UnsatisfiedLinkError Reviewed-by: alanb ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpNet.java Changeset: afcc8af048e6 Author: chegar Date: 2019-11-21 12:14 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/afcc8af048e6 8233847: (sctp) Flx link-local IPv6 scope handling and test cleanup Reviewed-by: alanb ! src/java.base/share/classes/module-info.java ! src/jdk.sctp/share/classes/com/sun/nio/sctp/HandlerResult.java ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpNet.java ! test/jdk/com/sun/nio/sctp/SctpChannel/Bind.java ! test/jdk/com/sun/nio/sctp/SctpChannel/CommUp.java ! test/jdk/com/sun/nio/sctp/SctpChannel/Connect.java ! test/jdk/com/sun/nio/sctp/SctpChannel/SocketOptionTests.java ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/Branch.java ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/Send.java ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/SendFailed.java ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/SocketOptionTests.java Changeset: 61091a42f19d Author: pconcannon Date: 2019-11-21 16:33 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/61091a42f19d 8234083: DatagramSocket should report SO_BROADCAST as a supported option Summary: DatagramSocket had a setBroadcast and getBroadcast setter/getter pair but curiously didn't report SO_BROADCAST as a supported option. Note: the source code changes were accidentally pushed with 8234103 so this changeset only has the test changes. The reviewers listed below had already reviewed the full (source+test) changes. Reviewed-by: alanb, vtewari, chegar ! test/jdk/java/net/SocketOption/OptionsTest.java Changeset: 7a3218ad8e7c Author: alitvinov Date: 2019-11-21 17:04 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7a3218ad8e7c 8068184: Fix for JDK-8032832 caused a deadlock Reviewed-by: dfuchs, chegar ! src/java.base/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java Changeset: 8a24f1e73c0d Author: hseigel Date: 2019-11-21 18:54 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8a24f1e73c0d 8234058: runtime/CompressedOops/CompressedClassPointers.java fails with 'Narrow klass base: 0x0000000000000000' missing from stdout/stderr Summary: Don't run test on Windows because ASLR can cause unexpected memory addresses Reviewed-by: coleenp ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java Changeset: 78184b74af6e Author: jjg Date: 2019-11-21 13:41 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/78184b74af6e 8234051: doclet crashes if HTML files in module doc-files directories Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/DocFileElement.java ! test/langtools/jdk/javadoc/doclet/testDocFiles/TestDocFiles.java - test/langtools/jdk/javadoc/doclet/testDocFiles/pkg/Test.java - test/langtools/jdk/javadoc/doclet/testDocFiles/pkg/doc-files/test.txt Changeset: 71a84cee0c39 Author: iignatyev Date: 2019-11-21 14:15 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/71a84cee0c39 8234290: compiler/c2/Test6857159.java times out and fail to clean up files Reviewed-by: thartmann ! test/hotspot/jtreg/compiler/c2/Test6857159.java Changeset: b470da55a673 Author: joehw Date: 2019-11-22 00:29 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b470da55a673 8233548: Update CUP to v0.11b Reviewed-by: lancea ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathParser.java ! src/java.xml/share/legal/jcup.md Changeset: 229aa067e4cc Author: weijun Date: 2019-11-22 09:33 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/229aa067e4cc 8026393: jarsigner never shows a warning in badKeyUsage case Reviewed-by: mullan - test/jdk/sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java Changeset: e7df7c86eda1 Author: xuelei Date: 2019-11-21 18:42 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e7df7c86eda1 8233954: UnsatisfiedLinkError or NoSuchAlgorithmException after removing sunec.dll Reviewed-by: ascarpino ! src/java.base/share/classes/sun/security/ssl/NamedGroup.java ! src/java.base/share/classes/sun/security/ssl/SignatureScheme.java Changeset: fcd74557a9cc Author: dbuck Date: 2019-11-21 23:32 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fcd74557a9cc 8230611: infinite loop in LogOutputList::wait_until_no_readers() Summary: Add copy constructor and copy assignment operator to ensure reader count remains accurate Reviewed-by: kbarrett, dholmes ! src/hotspot/share/logging/logOutputList.hpp Changeset: 47c879f478d2 Author: clanger Date: 2019-11-22 09:25 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/47c879f478d2 8234089: (zipfs) Remove classes JarFileSystemProvider and JarFileSystem Reviewed-by: lancea, alanb - src/jdk.zipfs/share/classes/jdk/nio/zipfs/JarFileSystem.java - src/jdk.zipfs/share/classes/jdk/nio/zipfs/JarFileSystemProvider.java ! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java ! src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystemProvider.java ! test/jdk/java/lang/module/customfs/ModulesInCustomFileSystem.java ! test/jdk/jdk/nio/zipfs/jarfs/JFSTester.java ! test/jdk/jdk/nio/zipfs/jarfs/MultiReleaseJarTest.java Changeset: 82db5000a845 Author: mbaesken Date: 2019-11-18 16:49 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/82db5000a845 8234339: replace JLI_StrTok in java_md_solinux.c Reviewed-by: clanger, rriggs ! src/java.base/share/native/libjli/jli_util.h ! src/java.base/unix/native/libjli/java_md_solinux.c Changeset: a1155217a563 Author: tschatzl Date: 2019-11-22 10:03 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a1155217a563 8233306: Sort members in G1's HeapRegion after removal of Space dependency Reviewed-by: sangheki, sjohanss ! src/hotspot/share/gc/g1/g1FullGCCompactTask.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp ! src/hotspot/share/gc/g1/heapRegion.inline.hpp Changeset: 01cc6bb2a090 Author: tschatzl Date: 2019-11-22 10:03 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/01cc6bb2a090 8233997: Some members of HeapRegion are not cleared in HeapRegion::hr_clear() Reviewed-by: sjohanss, sangheki ! src/hotspot/share/gc/g1/heapRegion.cpp Changeset: 72e15d757e6c Author: tschatzl Date: 2019-11-22 10:03 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/72e15d757e6c 8234000: Make HeapRegion::bottom/end/hrm_index const Reviewed-by: kbarrett, sjohanss ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegion.hpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/gc/g1/vmStructs_g1.hpp Changeset: cc3a82fc7bcb Author: tschatzl Date: 2019-11-22 10:03 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/cc3a82fc7bcb 8233702: Introduce helper function to clamp value to range Reviewed-by: sjohanss, kbarrett ! src/hotspot/cpu/aarch64/gc/z/zGlobals_aarch64.cpp ! src/hotspot/cpu/x86/gc/z/zGlobals_x86.cpp ! src/hotspot/share/gc/epsilon/epsilonHeap.cpp ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/parallel/asPSYoungGen.cpp ! src/hotspot/share/gc/parallel/psOldGen.cpp ! src/hotspot/share/gc/parallel/psYoungGen.cpp ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/shared/genArguments.cpp ! src/hotspot/share/gc/shared/plab.cpp ! src/hotspot/share/gc/shared/taskqueue.cpp ! src/hotspot/share/gc/shared/threadLocalAllocBuffer.cpp ! src/hotspot/share/opto/parse2.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/utilities/globalDefinitions.hpp Changeset: f4f60bb75ee4 Author: tschatzl Date: 2019-11-22 10:03 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f4f60bb75ee4 8233597: Clean up code in G1Analytics::compute_pause_time_ratio Reviewed-by: kbarrett, sjohanss ! src/hotspot/share/gc/g1/g1Analytics.cpp Changeset: f16e4154dd7b Author: sspitsyn Date: 2019-11-22 10:07 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f16e4154dd7b 8169467: GetLocalInstance returns JVMTI_ERROR_TYPE_MISMATCH (rather than JVMTI_ERROR_INVALID_SLOT) on static method Summary: Add necessary check to GetLocalInstance implementation Reviewed-by: amenkov, cjplummer ! src/hotspot/share/prims/jvmtiImpl.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/GetLocalVariable/getlocal003.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/GetLocalVariable/getlocal003/getlocal003.cpp Changeset: 55fdee124e89 Author: dfuchs Date: 2019-11-22 11:52 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/55fdee124e89 8233296: MulticastSocket getOption/setOption inverts the value of IP_MULTICAST_LOOP Summary: MulticastSocket.getOption(StandardSocketOption.IP_MULTICAST_LOOP) now returns true if loopback mode is enabled, and MulticastSocket.setOption(StandardSocketOption.IP_MULTICAST_LOOP, true) enables loopback mode. No other behavioral changes. Reviewed-by: alanb, chegar ! src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java + test/jdk/java/net/MulticastSocket/SetLoopbackOption.java ! test/jdk/java/net/SocketOption/OptionsTest.java Changeset: 80e1201f6c9a Author: dcubed Date: 2019-11-22 09:06 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/80e1201f6c9a 8234544: ObjectSynchronizer::FastHashCode() cleanups from Async Monitor Deflation project Reviewed-by: dholmes ! src/hotspot/share/runtime/synchronizer.cpp Changeset: a0f39cc47387 Author: egahlin Date: 2019-11-22 17:20 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a0f39cc47387 8233700: EventStream not closed Reviewed-by: mgronlun, mseledtsov ! src/hotspot/share/jfr/jni/jfrJniMethod.cpp ! src/hotspot/share/jfr/jni/jfrJniMethod.hpp ! src/hotspot/share/jfr/jni/jfrJniMethodRegistration.cpp ! src/hotspot/share/jfr/recorder/repository/jfrChunk.cpp ! src/hotspot/share/jfr/recorder/repository/jfrChunk.hpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp ! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.hpp ! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp ! src/hotspot/share/jfr/recorder/repository/jfrRepository.hpp ! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp ! src/jdk.jfr/share/classes/jdk/jfr/consumer/EventStream.java ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/JVM.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecorder.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecording.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/Repository.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/ShutdownHook.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/AbstractEventStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkHeader.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventDirectoryStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/EventFileStream.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/RepositoryFiles.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/DCmdConfigure.java + test/jdk/jdk/jfr/api/consumer/recordingstream/TestStoppedRecording.java + test/jdk/jdk/jfr/api/consumer/streaming/TestInProcessMigration.java + test/jdk/jdk/jfr/api/consumer/streaming/TestJVMCrash.java + test/jdk/jdk/jfr/api/consumer/streaming/TestJVMExit.java + test/jdk/jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java + test/jdk/jdk/jfr/api/consumer/streaming/TestProcess.java - test/jdk/jdk/jfr/api/consumer/streaming/TestRepositoryMigration.java Changeset: 46084917fde7 Author: bpb Date: 2019-11-22 09:00 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/46084917fde7 8164993: (ch) ReadableByteChannel should note a possible IllegalArgumentException Reviewed-by: alanb, darcy ! src/java.base/share/classes/java/nio/channels/DatagramChannel.java ! src/java.base/share/classes/java/nio/channels/FileChannel.java ! src/java.base/share/classes/java/nio/channels/ReadableByteChannel.java ! src/java.base/share/classes/java/nio/channels/ScatteringByteChannel.java Changeset: ddb327877207 Author: dfuchs Date: 2019-11-22 17:53 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ddb327877207 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached" Summary: fix the test to run in /othervm mode Reviewed-by: chegar ! test/jdk/jdk/net/Sockets/QuickAckTest.java Changeset: fba8fa613d1a Author: jjg Date: 2019-11-22 10:38 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fba8fa613d1a 8232170: FSInfo#getJarClassPath throws an exception not declared in its throws clause Reviewed-by: jjg Contributed-by: jai.forums2013 at gmail.com ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/FSInfo.java + test/langtools/tools/javac/file/FSInfoTest.java Changeset: a2a921609481 Author: mchung Date: 2019-11-22 11:34 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a2a921609481 8233956: MethodHandles.dropArguments javadoc lists parameters in wrong order Reviewed-by: jjg ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java Changeset: 2b9027360909 Author: mseledtsov Date: 2019-11-22 13:44 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2b9027360909 8229209: [TESTBUG] test for cross-process JFR event streaming Summary: New test for cross-process JFR event streaming Reviewed-by: iignatyev, egahlin + test/jdk/jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java Changeset: d4ddf19c2624 Author: jjg Date: 2019-11-22 16:26 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d4ddf19c2624 8234687: change javap reporting on unknown attributes Reviewed-by: mchung ! src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java + test/langtools/tools/javap/BadAttributeName.java Changeset: bd9dba789919 Author: manc Date: 2019-11-22 17:03 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/bd9dba789919 8087198: G1 card refinement: batching, sorting Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSet.hpp Changeset: ee0030a2a306 Author: iklam Date: 2019-11-22 14:48 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ee0030a2a306 8234429: appcds/dynamicArchive tests crashing with Graal Reviewed-by: ccheung ! src/hotspot/share/memory/dynamicArchive.cpp Changeset: 0f41ac6bb9dd Author: iklam Date: 2019-11-22 15:31 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/0f41ac6bb9dd 8233446: Improve error handling when specified dynamic archive doesn't exist Reviewed-by: lfoltan, ccheung ! src/hotspot/share/memory/filemap.cpp Changeset: e2ee246e44e3 Author: iklam Date: 2019-11-22 15:32 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e2ee246e44e3 8234622: [TESTBUG] ArchivedModuleCompareTest.java fails with -vmoptions:-Xlog:cds Reviewed-by: mseledtsov ! test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java ! test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedModuleCompareTest.java Changeset: 2601fc0874be Author: dlong Date: 2019-11-22 19:23 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/2601fc0874be 8234432: AOT tests failing with 'used 'epsilon gc' is different from current 'g1 gc'' after CMS removal Reviewed-by: kvn ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Main.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalRuntime.java Changeset: 9fe5d0d4e9c5 Author: egahlin Date: 2019-11-24 01:03 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/9fe5d0d4e9c5 8226897: Provide object age with JFR OldObjectSample event Reviewed-by: mgronlun, mseledtsov ! src/hotspot/share/jfr/leakprofiler/checkpoint/eventEmitter.cpp ! src/hotspot/share/jfr/metadata/metadata.xml ! src/hotspot/share/utilities/ticks.hpp + test/jdk/jdk/jfr/event/oldobject/TestObjectAge.java Changeset: b3116877866f Author: weijun Date: 2019-10-10 17:36 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b3116877866f 8231507: Update Apache Santuario (XML Signature) to version 2.1.4 Reviewed-by: weijun Contributed-by: fedor.burdun at azulsystems.com, weijun.wang at oracle.com ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/Init.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/Canonicalizer.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/c14n/CanonicalizerSpi.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/KeyResolverSpi.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/SignedInfo.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/XMLSignatureInput.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/transforms/implementations/TransformBase64Decode.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/WeakObjectPool.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java ! src/java.xml.crypto/share/legal/santuario.md Changeset: 23ecaf949f8f Author: lkorinth Date: 2019-11-25 08:11 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/23ecaf949f8f 8233029: Obsolete flag GCTaskTimeStampEntries Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/shared/gc_globals.hpp ! src/hotspot/share/runtime/arguments.cpp ! test/hotspot/gtest/runtime/test_globals.cpp ! test/hotspot/jtreg/gc/parallel/TestPrintGCDetailsVerbose.java Changeset: 6ba3d8d41135 Author: eosterlund Date: 2019-11-25 09:10 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6ba3d8d41135 8234509: Race in macOS os::processor_id() Reviewed-by: dholmes, pliden, rehn ! src/hotspot/os/bsd/os_bsd.cpp Changeset: fb1d9bf1be2b Author: mbaesken Date: 2019-11-22 10:29 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fb1d9bf1be2b 8234629: remove unused functions from libnet Reviewed-by: alanb, vtewari ! src/java.base/share/native/libnet/net_util.c ! src/java.base/share/native/libnet/net_util.h ! src/java.base/unix/native/libnet/DefaultProxySelector.c ! src/java.base/unix/native/libnet/net_util_md.c ! src/java.base/unix/native/libnet/net_util_md.h Changeset: 6a897a8ef4af Author: mgronlun Date: 2019-11-25 11:08 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/6a897a8ef4af 8234433: TestUnloadEventClassCount fails with "assert(SafepointSynchronize::is_at_safepoint()) failed: invariant" Reviewed-by: pliden ! src/hotspot/share/jfr/jni/jfrGetAllEventClasses.cpp Changeset: de882051f7a5 Author: pliden Date: 2019-11-25 12:34 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/de882051f7a5 8234573: ZGC: Enable ZVerifyMarking by default in debug builds Reviewed-by: stefank, tschatzl ! src/hotspot/share/gc/z/z_globals.hpp Changeset: fcad92f425c5 Author: egahlin Date: 2019-11-25 14:06 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/fcad92f425c5 8234703: JFR TestOutOfProcessMigration.java should clean up files Reviewed-by: mgronlun ! test/jdk/jdk/jfr/api/consumer/streaming/TestJVMCrash.java ! test/jdk/jdk/jfr/api/consumer/streaming/TestJVMExit.java ! test/jdk/jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java ! test/jdk/jdk/jfr/api/consumer/streaming/TestProcess.java Changeset: 56bf71d64d51 Author: stefank Date: 2019-11-25 12:22 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/56bf71d64d51 8234562: Move OrderAccess::release_store*/load_acquire to Atomic Reviewed-by: rehn, dholmes ! src/hotspot/cpu/ppc/nativeInst_ppc.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp ! src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp ! src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp ! src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.hpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp ! src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp ! src/hotspot/os_cpu/linux_s390/atomic_linux_s390.hpp ! src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp ! src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp ! src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.hpp ! src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp ! src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.hpp ! src/hotspot/share/classfile/classLoader.inline.hpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/compiledMethod.inline.hpp ! src/hotspot/share/code/dependencyContext.cpp ! src/hotspot/share/gc/g1/g1CodeCacheRemSet.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/gc/shared/oopStorage.cpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/taskqueue.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahEvacOOMHandler.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/z/zLiveMap.cpp ! src/hotspot/share/gc/z/zLiveMap.inline.hpp ! src/hotspot/share/gc/z/zNMethodData.cpp ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/interpreter/oopMapCache.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdEpoch.hpp ! src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp ! src/hotspot/share/jfr/utilities/jfrHashtable.hpp ! src/hotspot/share/logging/logDecorations.cpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/oops/accessBackend.inline.hpp ! src/hotspot/share/oops/array.hpp ! src/hotspot/share/oops/arrayKlass.inline.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/constantPool.inline.hpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.inline.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.inline.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.inline.hpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/oops/methodData.inline.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnvBase.hpp ! src/hotspot/share/prims/jvmtiRawMonitor.cpp ! src/hotspot/share/runtime/atomic.hpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/interfaceSupport.cpp ! src/hotspot/share/runtime/objectMonitor.cpp ! src/hotspot/share/runtime/orderAccess.hpp ! src/hotspot/share/runtime/perfMemory.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/threadHeapSampler.cpp ! src/hotspot/share/runtime/threadSMR.cpp ! src/hotspot/share/runtime/threadSMR.inline.hpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/services/memoryManager.cpp ! src/hotspot/share/services/memoryPool.cpp ! src/hotspot/share/utilities/bitMap.inline.hpp ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp ! src/hotspot/share/utilities/concurrentHashTableTasks.inline.hpp ! src/hotspot/share/utilities/globalCounter.cpp ! src/hotspot/share/utilities/globalCounter.inline.hpp ! src/hotspot/share/utilities/hashtable.inline.hpp ! src/hotspot/share/utilities/singleWriterSynchronizer.cpp ! test/hotspot/gtest/gc/g1/test_g1FreeIdSet.cpp ! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp ! test/hotspot/gtest/utilities/test_globalCounter.cpp ! test/hotspot/gtest/utilities/test_globalCounter_nested.cpp ! test/hotspot/gtest/utilities/test_lockFreeStack.cpp ! test/hotspot/gtest/utilities/test_singleWriterSynchronizer.cpp ! test/hotspot/gtest/utilities/test_waitBarrier.cpp Changeset: e92153ed8bdc Author: stefank Date: 2019-11-25 12:30 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/e92153ed8bdc 8234736: Harmonize parameter order in Atomic - store Reviewed-by: rehn, dholmes ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp ! src/hotspot/os_cpu/bsd_zero/atomic_bsd_zero.hpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp ! src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp ! src/hotspot/os_cpu/linux_zero/atomic_linux_zero.hpp ! src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/dependencyContext.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! src/hotspot/share/gc/z/zLock.inline.hpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/gc/z/zNMethod.cpp ! src/hotspot/share/memory/allocation.inline.hpp ! src/hotspot/share/oops/accessBackend.inline.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/methodData.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/runtime/atomic.hpp ! src/hotspot/share/runtime/basicLock.hpp ! src/hotspot/share/runtime/objectMonitor.inline.hpp ! src/hotspot/share/services/attachListener.hpp ! src/hotspot/share/utilities/lockFreeStack.hpp ! src/hotspot/share/utilities/vmError.cpp Changeset: 29b0d0b61615 Author: stefank Date: 2019-11-25 12:31 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/29b0d0b61615 8234737: Harmonize parameter order in Atomic - add Reviewed-by: rehn, dholmes ! src/hotspot/cpu/arm/stubGenerator_arm.cpp ! src/hotspot/cpu/sparc/stubGenerator_sparc.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp ! src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp ! src/hotspot/os_cpu/bsd_zero/atomic_bsd_zero.hpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp ! src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp ! src/hotspot/os_cpu/linux_s390/atomic_linux_s390.hpp ! src/hotspot/os_cpu/linux_sparc/atomic_linux_sparc.hpp ! src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp ! src/hotspot/os_cpu/linux_zero/atomic_linux_zero.hpp ! src/hotspot/os_cpu/solaris_sparc/atomic_solaris_sparc.hpp ! src/hotspot/os_cpu/solaris_x86/atomic_solaris_x86.hpp ! src/hotspot/os_cpu/solaris_x86/solaris_x86_64.il ! src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp ! src/hotspot/share/classfile/classLoaderDataGraph.inline.hpp ! src/hotspot/share/classfile/stringTable.cpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectionSetChooser.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1EvacStats.inline.hpp ! src/hotspot/share/gc/g1/g1FullGCAdjustTask.cpp ! src/hotspot/share/gc/g1/g1HotCardCache.cpp ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp ! src/hotspot/share/gc/g1/g1RedirtyCardsQueue.cpp ! src/hotspot/share/gc/g1/g1RegionMarkStatsCache.inline.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/parallel/parMarkBitMap.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.hpp ! src/hotspot/share/gc/shared/oopStorage.cpp ! src/hotspot/share/gc/shared/plab.inline.hpp ! src/hotspot/share/gc/shared/preservedMarks.cpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.cpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupQueue.cpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp ! src/hotspot/share/gc/shared/workgroup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/z/zArray.inline.hpp ! src/hotspot/share/gc/z/zLiveMap.inline.hpp ! src/hotspot/share/gc/z/zMarkStackAllocator.cpp ! src/hotspot/share/gc/z/zMarkTerminate.inline.hpp ! src/hotspot/share/gc/z/zNMethodTableIteration.cpp ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/gc/z/zRelocationSet.inline.hpp ! src/hotspot/share/gc/z/zStat.cpp ! src/hotspot/share/jfr/utilities/jfrRefCountPointer.hpp ! src/hotspot/share/logging/logOutputList.cpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/prims/resolvedMethodTable.cpp ! src/hotspot/share/runtime/atomic.hpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/threadSMR.cpp ! src/hotspot/share/runtime/threadSMR.inline.hpp ! src/hotspot/share/services/mallocSiteTable.hpp ! src/hotspot/share/services/mallocTracker.hpp ! src/hotspot/share/utilities/concurrentHashTableTasks.inline.hpp ! src/hotspot/share/utilities/globalCounter.cpp ! src/hotspot/share/utilities/singleWriterSynchronizer.cpp ! src/hotspot/share/utilities/singleWriterSynchronizer.hpp ! src/hotspot/share/utilities/waitBarrier_generic.cpp ! test/hotspot/gtest/gc/g1/test_g1FreeIdSet.cpp ! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp Changeset: a6deb69743d4 Author: stefank Date: 2019-11-25 12:32 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a6deb69743d4 8234738: Harmonize parameter order in Atomic - sub Reviewed-by: rehn, dholmes ! src/hotspot/share/classfile/classLoaderDataGraph.inline.hpp ! src/hotspot/share/code/dependencyContext.cpp ! src/hotspot/share/gc/shared/oopStorage.cpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/workgroup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! src/hotspot/share/gc/z/zMarkTerminate.inline.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/runtime/atomic.hpp ! src/hotspot/share/services/mallocTracker.hpp Changeset: 4cbfa5077d68 Author: stefank Date: 2019-11-25 12:32 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/4cbfa5077d68 8234739: Harmonize parameter order in Atomic - xchg Reviewed-by: rehn, dholmes ! src/hotspot/cpu/arm/stubGenerator_arm.cpp ! src/hotspot/cpu/sparc/stubGenerator_sparc.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp ! src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp ! src/hotspot/os_cpu/bsd_zero/atomic_bsd_zero.hpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp ! src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp ! src/hotspot/os_cpu/linux_s390/atomic_linux_s390.hpp ! src/hotspot/os_cpu/linux_sparc/atomic_linux_sparc.hpp ! src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp ! src/hotspot/os_cpu/linux_zero/atomic_linux_zero.hpp ! src/hotspot/os_cpu/solaris_sparc/atomic_solaris_sparc.hpp ! src/hotspot/os_cpu/solaris_x86/atomic_solaris_x86.hpp ! src/hotspot/os_cpu/solaris_x86/solaris_x86_64.il ! src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileBroker.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/modRefBarrierSet.hpp ! src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp ! src/hotspot/share/gc/z/zBarrierSet.hpp ! src/hotspot/share/gc/z/zBarrierSet.inline.hpp ! src/hotspot/share/gc/z/zReferenceProcessor.cpp ! src/hotspot/share/gc/z/zStat.cpp ! src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/access.hpp ! src/hotspot/share/oops/access.inline.hpp ! src/hotspot/share/oops/accessBackend.hpp ! src/hotspot/share/oops/accessBackend.inline.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/runtime/atomic.hpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/threadSMR.cpp ! src/hotspot/share/utilities/lockFreeStack.hpp Changeset: 623722a6aeb9 Author: stefank Date: 2019-11-25 12:33 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/623722a6aeb9 8234740: Harmonize parameter order in Atomic - cmpxchg Reviewed-by: rehn, dholmes ! src/hotspot/cpu/arm/stubGenerator_arm.cpp ! src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp ! src/hotspot/cpu/s390/interp_masm_s390.cpp ! src/hotspot/cpu/sparc/stubGenerator_sparc.cpp ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/os/windows/threadCritical_windows.cpp ! src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp ! src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp ! src/hotspot/os_cpu/bsd_x86/bsd_x86_32.s ! src/hotspot/os_cpu/bsd_zero/atomic_bsd_zero.hpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp ! src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp ! src/hotspot/os_cpu/linux_s390/atomic_linux_s390.hpp ! src/hotspot/os_cpu/linux_sparc/atomic_linux_sparc.hpp ! src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp ! src/hotspot/os_cpu/linux_x86/linux_x86_32.s ! src/hotspot/os_cpu/linux_zero/atomic_linux_zero.hpp ! src/hotspot/os_cpu/solaris_sparc/atomic_solaris_sparc.hpp ! src/hotspot/os_cpu/solaris_x86/atomic_solaris_x86.hpp ! src/hotspot/os_cpu/solaris_x86/solaris_x86_64.il ! src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/dependencyContext.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileBroker.hpp ! src/hotspot/share/gc/epsilon/epsilonHeap.cpp ! src/hotspot/share/gc/g1/g1CodeCacheRemSet.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1FreeIdSet.cpp ! src/hotspot/share/gc/g1/g1HotCardCache.cpp ! src/hotspot/share/gc/g1/g1ParallelCleaning.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/heapRegion.inline.hpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.hpp ! src/hotspot/share/gc/parallel/mutableNUMASpace.cpp ! src/hotspot/share/gc/parallel/mutableSpace.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/cardTableRS.cpp ! src/hotspot/share/gc/shared/modRefBarrierSet.hpp ! src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp ! src/hotspot/share/gc/shared/oopStorage.cpp ! src/hotspot/share/gc/shared/parallelCleaning.cpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/taskqueue.cpp ! src/hotspot/share/gc/shared/taskqueue.inline.hpp ! src/hotspot/share/gc/shared/workgroup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahClosures.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahEvacOOMHandler.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegionCounters.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp ! src/hotspot/share/gc/z/zBarrier.inline.hpp ! src/hotspot/share/gc/z/zBarrierSet.hpp ! src/hotspot/share/gc/z/zBarrierSet.inline.hpp ! src/hotspot/share/gc/z/zBitMap.inline.hpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! src/hotspot/share/gc/z/zLiveMap.cpp ! src/hotspot/share/gc/z/zMarkStack.inline.hpp ! src/hotspot/share/gc/z/zMarkStackAllocator.cpp ! src/hotspot/share/gc/z/zMarkTerminate.inline.hpp ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/gc/z/zOopClosures.inline.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zRootsIterator.cpp ! src/hotspot/share/gc/z/zStat.cpp ! src/hotspot/share/interpreter/bytecodeInterpreter.cpp ! src/hotspot/share/interpreter/oopMapCache.cpp ! src/hotspot/share/jfr/leakprofiler/sampling/objectSampler.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceId.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp ! src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp ! src/hotspot/share/jfr/recorder/storage/jfrBuffer.cpp ! src/hotspot/share/jfr/recorder/storage/jfrStorageControl.cpp ! src/hotspot/share/jfr/utilities/jfrAllocation.cpp ! src/hotspot/share/jfr/utilities/jfrTryLock.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciRuntime.cpp ! src/hotspot/share/jvmci/metadataHandleBlock.cpp ! src/hotspot/share/logging/logDecorations.cpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/oops/access.hpp ! src/hotspot/share/oops/access.inline.hpp ! src/hotspot/share/oops/accessBackend.hpp ! src/hotspot/share/oops/accessBackend.inline.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/oops/objArrayOop.cpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiRawMonitor.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/runtime/atomic.hpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/interfaceSupport.cpp ! src/hotspot/share/runtime/objectMonitor.cpp ! src/hotspot/share/runtime/os.cpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/threadSMR.cpp ! src/hotspot/share/runtime/threadSMR.inline.hpp ! src/hotspot/share/services/attachListener.hpp ! src/hotspot/share/services/mallocSiteTable.cpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/utilities/accessFlags.cpp ! src/hotspot/share/utilities/bitMap.cpp ! src/hotspot/share/utilities/bitMap.inline.hpp ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp ! src/hotspot/share/utilities/debug.cpp ! src/hotspot/share/utilities/lockFreeStack.hpp ! src/hotspot/share/utilities/singleWriterSynchronizer.cpp ! src/hotspot/share/utilities/vmError.cpp ! src/hotspot/share/utilities/waitBarrier_generic.cpp Changeset: 1647ed87bf1e Author: stefank Date: 2019-11-25 14:56 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1647ed87bf1e 8234010: ZGC: Change ZResurrection to use Atomic::load/store Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/z/zResurrection.cpp ! src/hotspot/share/gc/z/zResurrection.inline.hpp Changeset: 58f842703bc5 Author: stefank Date: 2019-11-25 14:57 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/58f842703bc5 8234009: ZGC: Move resurrection unblock to before the _unload.purge() call Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp Changeset: a74627659f96 Author: stefank Date: 2019-11-25 15:00 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a74627659f96 8234602: ZGC: Windows compile error in ZHeuristic Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/z/zHeuristics.cpp Changeset: 4c2557ab304e Author: eosterlund Date: 2019-11-25 15:21 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/4c2557ab304e 8234531: Remove CMS code from CLDG and safepoint cleanup Reviewed-by: coleenp, zgu ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/classfile/classLoaderDataGraph.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/safepoint.hpp Changeset: 127ca611f19b Author: mgronlun Date: 2019-11-25 18:38 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/127ca611f19b 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing Reviewed-by: sspitsyn, egahlin ! src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp ! src/hotspot/share/jfr/jfr.cpp ! src/hotspot/share/jfr/jfr.hpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jfr/jni/jfrJniMethod.cpp ! src/hotspot/share/jfr/recorder/jfrRecorder.cpp ! src/hotspot/share/jfr/recorder/jfrRecorder.hpp ! src/hotspot/share/jfr/recorder/service/jfrOptionSet.cpp ! src/hotspot/share/jfr/recorder/service/jfrOptionSet.hpp ! src/hotspot/share/runtime/thread.cpp ! src/jdk.jfr/share/classes/jdk/jfr/internal/JVM.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java Changeset: b0a649295f25 Author: never Date: 2019-11-25 11:13 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/b0a649295f25 8234359: [JVMCI] invalidate_nmethod_mirror shouldn't use a phantom reference Reviewed-by: kvn, eosterlund ! src/hotspot/share/jvmci/jvmciRuntime.cpp Changeset: 4cf1246fbb9c Author: mgronlun Date: 2019-11-25 20:18 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/4cf1246fbb9c 8234684: JFR crashes when rotating the JFR output during assertion failure Reviewed-by: egahlin, mseledtsov ! src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp Changeset: 06970ab040d4 Author: dnsimon Date: 2019-11-25 12:08 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/06970ab040d4 8234681: Remove UseJVMCIClassLoader logic from JVMCI code Reviewed-by: kvn, iignatyev ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/Services.java Changeset: f34ad283fcd6 Author: bpb Date: 2019-11-25 15:30 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f34ad283fcd6 8179320: File.getUsableSpace() returns a negative number on very large file system Reviewed-by: alanb, rriggs, darcy ! src/java.base/share/classes/java/io/File.java Changeset: 981a55672786 Author: sspitsyn Date: 2019-11-26 02:32 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/981a55672786 8221372: Test vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java times out Summary: Update test to get rid of unneeded MethodEntry/MethodExit events Reviewed-by: amenkov, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetThreadState/thrstat001/thrstat001.cpp Changeset: d9a3bddcffcc Author: sadayapalam Date: 2019-11-26 11:13 +0530 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d9a3bddcffcc 8234729: Javac should eagerly change code generation for method references to avert IllegalAccessError in future. Reviewed-by: mcimadamore ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java + test/langtools/tools/javac/lambda/methodReference/ProtectedInaccessibleMethodRefTest2.java + test/langtools/tools/javac/lambda/methodReference/pack/I.java + test/langtools/tools/javac/lambda/methodReference/pack/J.java Changeset: 4444591b3ac0 Author: pliden Date: 2019-11-26 11:57 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/4444591b3ac0 8234619: ZGC: gc/z/TestSmallHeap.java failure with Out Of Memory Reviewed-by: tschatzl, eosterlund ! test/hotspot/jtreg/gc/z/TestSmallHeap.java Changeset: 611f6bfe7c30 Author: stefank Date: 2019-11-26 13:50 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/611f6bfe7c30 8234798: Build failure after atomic changes in JDK-8234563 Reviewed-by: tschatzl, rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahEvacOOMHandler.cpp Changeset: ac6f7738a0ee Author: zgu Date: 2019-11-26 09:27 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/ac6f7738a0ee 8234270: [REDO] JDK-8204128 NMT might report incorrect numbers for Compiler area Reviewed-by: stuefe, minqi ! src/hotspot/share/memory/arena.cpp ! src/hotspot/share/memory/resourceArea.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/services/mallocTracker.hpp ! src/hotspot/share/services/memTracker.hpp + test/hotspot/jtreg/runtime/NMT/HugeArenaTracking.java ! test/lib/sun/hotspot/WhiteBox.java Changeset: d5a1c6545a2b Author: rkennke Date: 2019-11-26 14:48 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d5a1c6545a2b 8234768: Shenandoah: Streamline enqueueing runtime barriers Reviewed-by: zgu ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp Changeset: 9170826a3d76 Author: pchilanomate Date: 2019-11-26 15:21 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/9170826a3d76 8234613: JavaThread can escape back to Java from an ongoing handshake Summary: Check again if we have a pending/in-progress handshake operation after executing ~ThreadInVMForHandshake() Reviewed-by: coleenp, dcubed, dholmes, rehn ! src/hotspot/share/runtime/handshake.cpp Changeset: eb3e2a5c2bcd Author: egahlin Date: 2019-11-26 17:00 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/eb3e2a5c2bcd 8233870: JFR TestSetEndTime.java times out - onClose() is never called Reviewed-by: mgronlun ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkHeader.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/consumer/ChunkParser.java ! test/jdk/jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java Changeset: a6e25566cb56 Author: vlivanov Date: 2019-11-26 16:09 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a6e25566cb56 8234401: ConstantCallSite may stuck in non-frozen state Reviewed-by: psandoz ! src/java.base/share/classes/java/lang/invoke/CallSite.java ! src/java.base/share/classes/java/lang/invoke/ConstantCallSite.java ! src/java.base/share/classes/java/lang/invoke/MutableCallSite.java ! src/java.base/share/classes/java/lang/invoke/VolatileCallSite.java ! test/jdk/java/lang/invoke/CallSiteTest.java Changeset: 94a84abb873b Author: vlivanov Date: 2019-11-26 16:09 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/94a84abb873b 8234403: C2: Enable CallSite.target updates in constructors Reviewed-by: psandoz, kvn ! src/hotspot/share/opto/parse3.cpp Changeset: 31272cef28e2 Author: jbhateja Date: 2019-11-26 16:09 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/31272cef28e2 8234387: C2: Better support of operands with multiple match rules in AD files Reviewed-by: vlivanov, sviswanathan, thartmann, dlong ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/adlc/archDesc.cpp Changeset: 8375560db76b Author: jbhateja Date: 2019-11-26 16:09 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8375560db76b 8234394: C2: Dynamic register class support in ADLC Reviewed-by: vlivanov, sviswanathan, thartmann, kvn ! src/hotspot/share/adlc/adlparse.cpp ! src/hotspot/share/adlc/archDesc.cpp ! src/hotspot/share/adlc/formsopt.cpp ! src/hotspot/share/adlc/formsopt.hpp ! src/hotspot/share/adlc/output_c.cpp Changeset: f9905e7c96aa Author: vlivanov Date: 2019-11-26 19:18 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f9905e7c96aa Merge Changeset: dff8053bdb74 Author: sviswanathan Date: 2019-11-26 19:19 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/dff8053bdb74 8234610: MaxVectorSize set wrongly when UseAVX=3 is specified after JDK-8221092 Reviewed-by: kvn, vlivanov ! src/hotspot/cpu/x86/vm_version_x86.cpp Changeset: eef0bf57357c Author: cgo Date: 2019-11-26 10:00 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/eef0bf57357c 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC Reviewed-by: erikj ! make/autoconf/flags-cflags.m4 Changeset: f5f129bfa403 Author: iklam Date: 2019-11-22 17:45 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/f5f129bfa403 8234539: ArchiveRelocationTest.java failed: Archive mapping should always succeed Reviewed-by: ccheung ! src/hotspot/share/memory/filemap.cpp ! src/hotspot/share/memory/metaspaceShared.cpp Changeset: 78aa7484c722 Author: zgu Date: 2019-11-26 14:33 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/78aa7484c722 8233500: Shenandoah: Shenandoah load barrier should save registers before calling keep alive barrier on x86 Reviewed-by: rkennke ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp Changeset: 88502b1cf76f Author: zgu Date: 2019-09-09 11:43 -0400 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/88502b1cf76f 8230765: Implement nmethod barrier for x86_32 platforms Reviewed-by: rkennke, eosterlund ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/barrierSetNMethod_x86.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.hpp ! src/hotspot/cpu/x86/stubRoutines_x86_32.cpp ! src/hotspot/share/gc/shared/barrierSetNMethod.cpp ! src/hotspot/share/gc/shared/barrierSetNMethod.hpp ! src/hotspot/share/gc/z/zBarrierSetNMethod.cpp ! src/hotspot/share/gc/z/zBarrierSetNMethod.hpp Changeset: 7799a51dbe30 Author: jlahoda Date: 2019-11-27 09:00 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7799a51dbe30 8231826: Implement javac changes for pattern matching for instanceof Reviewed-by: mcimadamore Contributed-by: brian.goetz at oracle.com, gavin.bierman at oracle.com, maurizio.cimadamore at oracle.com, srikanth.adayapalam at oracle.com, vicente.romero at oracle.com, jan.lahoda at oracle.com ! src/java.base/share/classes/jdk/internal/PreviewFeature.java + src/jdk.compiler/share/classes/com/sun/source/tree/BindingPatternTree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/InstanceOfTree.java + src/jdk.compiler/share/classes/com/sun/source/tree/PatternTree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/Tree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/TreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Preview.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/CompileStates.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java + src/jdk.compiler/share/classes/com/sun/tools/javac/comp/MatchBindingsComputer.java + src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TreeDiffer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TreeHasher.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Code.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! test/langtools/tools/javac/annotations/typeAnnotations/classfile/ClassfileTestHelper.java ! test/langtools/tools/javac/annotations/typeAnnotations/classfile/CombinationsTargetTest2.java + test/langtools/tools/javac/annotations/typeAnnotations/classfile/Patterns.java ! test/langtools/tools/javac/api/TestGetElementReference.java ! test/langtools/tools/javac/api/TestGetElementReferenceData.java + test/langtools/tools/javac/diags/examples/InstanceofReifiableNotSafe.java + test/langtools/tools/javac/diags/examples/MatchBindingExists.java + test/langtools/tools/javac/diags/examples/PatternBindingMayNotBeAssigned.java + test/langtools/tools/javac/diags/examples/PatternMatchingInstanceof.java + test/langtools/tools/javac/diags/examples/ReifiableTypesInstanceof.java ! test/langtools/tools/javac/lambda/deduplication/Deduplication.java ! test/langtools/tools/javac/lib/DPrinter.java + test/langtools/tools/javac/patterns/BindingsExistTest.java + test/langtools/tools/javac/patterns/BindingsExistTest.out + test/langtools/tools/javac/patterns/BindingsTest1.java + test/langtools/tools/javac/patterns/BindingsTest1Merging.java + test/langtools/tools/javac/patterns/BindingsTest1Merging.out + test/langtools/tools/javac/patterns/BindingsTest2.java + test/langtools/tools/javac/patterns/BindingsTest2.out + test/langtools/tools/javac/patterns/CastConversionMatch.java + test/langtools/tools/javac/patterns/CastConversionMatch.out + test/langtools/tools/javac/patterns/DuplicateBindingTest.java + test/langtools/tools/javac/patterns/DuplicateBindingTest.out + test/langtools/tools/javac/patterns/EnsureTypesOrderTest.java + test/langtools/tools/javac/patterns/EnsureTypesOrderTest.out + test/langtools/tools/javac/patterns/ExamplesFromProposal.java + test/langtools/tools/javac/patterns/ImpossibleTypeTest.java + test/langtools/tools/javac/patterns/ImpossibleTypeTest.out + test/langtools/tools/javac/patterns/LocalVariableTable.java + test/langtools/tools/javac/patterns/MatchBindingScopeTest.java + test/langtools/tools/javac/patterns/MatchBindingScopeTest.out + test/langtools/tools/javac/patterns/NullsInPatterns.java + test/langtools/tools/javac/patterns/PatternMatchPosTest.java + test/langtools/tools/javac/patterns/PatternMatchPosTest.out + test/langtools/tools/javac/patterns/PatternMatchPosTestData.java + test/langtools/tools/javac/patterns/PatternTypeTest2.java + test/langtools/tools/javac/patterns/PatternVariablesAreFinal.java + test/langtools/tools/javac/patterns/PatternVariablesAreFinal.out + test/langtools/tools/javac/patterns/PatternVariablesAreFinal2.java + test/langtools/tools/javac/patterns/PatternsSimpleVisitorTest.java + test/langtools/tools/javac/patterns/Reifiable.java + test/langtools/tools/javac/patterns/Reifiable.out + test/langtools/tools/javac/patterns/ReifiableOld-old.out + test/langtools/tools/javac/patterns/ReifiableOld.java + test/langtools/tools/javac/patterns/ReifiableOld.out + test/langtools/tools/javac/patterns/UncheckedWarningOnMatchesTest.java + test/langtools/tools/javac/patterns/UncheckedWarningOnMatchesTest.out + test/langtools/tools/javac/patterns/scope/ScopeTest.java + test/langtools/tools/javac/patterns/scope/TEST.properties Changeset: a2441ac23eeb Author: mbaesken Date: 2019-11-26 13:55 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/a2441ac23eeb 8234809: set relro in linker flags when building with gcc Reviewed-by: erikj, fweimer ! make/autoconf/flags-ldflags.m4 Changeset: c04fa10636fd Author: mbaesken Date: 2019-11-27 10:07 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c04fa10636fd 8234525: enable link-time section-gc for linux s390x to remove unused code Reviewed-by: erikj, mdoerr ! make/autoconf/flags-cflags.m4 ! make/autoconf/flags-ldflags.m4 Changeset: 3b1afeb49a20 Author: tschatzl Date: 2019-11-27 10:19 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/3b1afeb49a20 8233301: Implementation of JEP 366: Deprecate the ParallelScavenge + SerialOld GC Combination Summary: Deprecate the ParallelScavenge + SerialOld GC combinations by deprecating the UseParallelOldGC flag. Also reviewed by Bernd Eckenfels. Reviewed-by: pliden ! src/hotspot/share/gc/shared/gc_globals.hpp ! src/hotspot/share/runtime/arguments.cpp ! test/hotspot/jtreg/gc/startup_warnings/TestParallelScavengeSerialOld.java ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: c887851da33d Author: tschatzl Date: 2019-11-27 10:21 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/c887851da33d Merge Changeset: 97d13893ec3c Author: stefank Date: 2019-11-26 10:47 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/97d13893ec3c 8234748: Clean up atomic and orderAccess includes Reviewed-by: dholmes ! src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp ! src/hotspot/cpu/arm/nativeInst_arm_32.hpp ! src/hotspot/cpu/arm/relocInfo_arm.cpp ! src/hotspot/cpu/x86/rdtsc_x86.cpp ! src/hotspot/cpu/zero/cppInterpreter_zero.cpp ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/windows/osThread_windows.cpp ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/aot/aotCompiledMethod.cpp ! src/hotspot/share/asm/assembler.cpp ! src/hotspot/share/classfile/classLoader.inline.hpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/classfile/dictionary.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/compiledMethod.inline.hpp ! src/hotspot/share/code/dependencyContext.cpp ! src/hotspot/share/compiler/compileBroker.hpp ! src/hotspot/share/gc/epsilon/epsilonHeap.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1CardTable.cpp ! src/hotspot/share/gc/g1/g1CodeCacheRemSet.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1CollectionSet.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1ParallelCleaning.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1StringDedup.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp ! src/hotspot/share/gc/g1/sparsePRT.cpp ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.hpp ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/gc/shared/parallelCleaning.cpp ! src/hotspot/share/gc/shared/preservedMarks.cpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahClosures.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahEvacOOMHandler.cpp ! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegionCounters.cpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSharedVariables.hpp ! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/z/zLiveMap.cpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/gc/z/zMarkTerminate.inline.hpp ! src/hotspot/share/gc/z/zNMethod.cpp ! src/hotspot/share/gc/z/zNMethodData.cpp ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zReferenceProcessor.cpp ! src/hotspot/share/interpreter/oopMapCache.cpp ! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp ! src/hotspot/share/jfr/recorder/storage/jfrStorage.cpp ! src/hotspot/share/jfr/recorder/stringpool/jfrStringPool.cpp ! src/hotspot/share/jfr/utilities/jfrHashtable.hpp ! src/hotspot/share/jvmci/jvmciCompiler.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/jvmciRuntime.cpp ! src/hotspot/share/jvmci/metadataHandleBlock.cpp ! src/hotspot/share/logging/logDecorations.cpp ! src/hotspot/share/memory/allocation.cpp ! src/hotspot/share/memory/arena.cpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.cpp ! src/hotspot/share/oops/accessBackend.inline.hpp ! src/hotspot/share/oops/arrayKlass.inline.hpp ! src/hotspot/share/oops/constantPool.inline.hpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.inline.hpp ! src/hotspot/share/oops/instanceKlass.inline.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.inline.hpp ! src/hotspot/share/oops/methodData.inline.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnvBase.hpp ! src/hotspot/share/prims/jvmtiImpl.cpp ! src/hotspot/share/prims/resolvedMethodTable.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/interfaceSupport.cpp ! src/hotspot/share/runtime/perfMemory.cpp ! src/hotspot/share/runtime/safepointMechanism.cpp ! src/hotspot/share/runtime/sweeper.cpp ! src/hotspot/share/runtime/threadHeapSampler.cpp ! src/hotspot/share/runtime/threadSMR.cpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/services/lowMemoryDetector.hpp ! src/hotspot/share/services/mallocSiteTable.hpp ! src/hotspot/share/services/mallocTracker.cpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/services/memoryManager.cpp ! src/hotspot/share/services/memoryPool.cpp ! src/hotspot/share/services/threadIdTable.cpp ! src/hotspot/share/services/threadStackTracker.cpp ! src/hotspot/share/services/virtualMemoryTracker.cpp ! src/hotspot/share/utilities/bitMap.inline.hpp ! src/hotspot/share/utilities/concurrentHashTableTasks.inline.hpp ! src/hotspot/share/utilities/globalCounter.cpp ! src/hotspot/share/utilities/globalCounter.inline.hpp ! src/hotspot/share/utilities/hashtable.inline.hpp Changeset: 54cf02d52c1b Author: phedlin Date: 2019-11-15 16:39 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/54cf02d52c1b 8220376: C2: Int >0 not recognized as !=0 for div by 0 check Reviewed-by: neliasso, vlivanov, mdoerr ! src/hotspot/share/opto/cfgnode.hpp ! src/hotspot/share/opto/ifnode.cpp Changeset: 95b1385dd476 Author: stefank Date: 2019-11-27 11:31 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/95b1385dd476 8234897: 8234748: Clean up atomic and orderAccess includes - part 2 Reviewed-by: tschatzl, dholmes ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os_cpu/solaris_x86/os_solaris_x86.cpp ! src/hotspot/share/gc/g1/g1CardTable.cpp ! src/hotspot/share/gc/shenandoah/shenandoahForwarding.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/z/zLiveMap.inline.hpp ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/methodData.cpp Changeset: 5af9fa90cd7b Author: sjohanss Date: 2019-11-27 12:18 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/5af9fa90cd7b 8141637: Parallelize single threaded heap region iteration during Pre Evacuate Collection Set Reviewed-by: tschatzl, lkorinth ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSet.hpp Changeset: 48b88b9c11eb Author: hannesw Date: 2019-11-27 13:08 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/48b88b9c11eb 8223378: CSS solution for navbar problem with elements is not ideal Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractOverviewIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SubWriterHolderWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/BodyContents.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlStyle.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/AnnotationTypeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/ClassWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/ConstantsSummaryWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/ModuleSummaryWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/PackageSummaryWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/SerializedFormWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ClassBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ConstantsSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PackageSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/script.js ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testHtmlLandmarkRegions/TestHtmlLandmarkRegions.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testJavascript/TestJavascript.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNavigation/TestNavigation.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testSearchScript/javadoc-search.js ! test/langtools/jdk/javadoc/doclet/testStylesheet/TestStylesheet.java ! test/langtools/jdk/javadoc/doclet/testTopOption/TestTopOption.java Changeset: 8b6cc0bb93d0 Author: darcy Date: 2019-11-27 06:36 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/8b6cc0bb93d0 8234781: Update description of InvalidClassException to include more conditions Reviewed-by: alanb, chegar ! src/java.base/share/classes/java/io/InvalidClassException.java Changeset: 9186be5c78ba Author: zgu Date: 2019-11-27 11:52 -0500 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/9186be5c78ba 8228720: Shenandoah: Implementation of concurrent class unloading Reviewed-by: rkennke ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp ! src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp + src/hotspot/share/gc/shenandoah/shenandoahBarrierSetNMethod.cpp + src/hotspot/share/gc/shenandoah/shenandoahBarrierSetNMethod.hpp ! src/hotspot/share/gc/shenandoah/shenandoahClosures.hpp ! src/hotspot/share/gc/shenandoah/shenandoahClosures.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentRoots.hpp ! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp + src/hotspot/share/gc/shenandoah/shenandoahLock.cpp ! src/hotspot/share/gc/shenandoah/shenandoahLock.hpp + src/hotspot/share/gc/shenandoah/shenandoahNMethod.cpp + src/hotspot/share/gc/shenandoah/shenandoahNMethod.hpp + src/hotspot/share/gc/shenandoah/shenandoahNMethod.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahNormalMode.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootVerifier.hpp ! src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp + src/hotspot/share/gc/shenandoah/shenandoahUnload.cpp + src/hotspot/share/gc/shenandoah/shenandoahUnload.hpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp ! src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp ! test/hotspot/jtreg/gc/shenandoah/options/TestClassUnloadingArguments.java Changeset: 498ce2452972 Author: darcy Date: 2019-11-27 10:23 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/498ce2452972 8234917: Explicitly discuss java.lang.Enum in Class.isEnum spec Reviewed-by: jjg ! src/java.base/share/classes/java/lang/Class.java Changeset: de2896bc018a Author: jboes Date: 2019-11-27 15:13 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/de2896bc018a 8234799: javadoc of java.util.Arrays.compare(T[] a, T[] b) misses the word "less" Summary: Add word "less" to method-level javadoc Reviewed-by: dfuchs, lancea ! src/java.base/share/classes/java/util/Arrays.java Changeset: 17d242844fc9 Author: pconcannon Date: 2019-11-27 16:01 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/17d242844fc9 8233018: Add a new test to verify that DatagramSocket is not interruptible Summary: Test added to check the interruptability of DatagramSocket, MulticastSocket and DatagramSocketAdaptor. Reviewed-by: chegar, dfuchs + test/jdk/java/net/DatagramSocket/InterruptibleDatagramSocket.java Changeset: 60bdcb9a7b94 Author: mli Date: 2019-11-28 13:48 +0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/60bdcb9a7b94 8232446: logging enhancement for rmi when socket closed Reviewed-by: rriggs, plevart ! src/java.rmi/share/classes/sun/rmi/transport/tcp/TCPConnection.java ! src/java.rmi/share/classes/sun/rmi/transport/tcp/TCPTransport.java Changeset: d67bb40f422c Author: jwilhelm Date: 2019-11-28 07:05 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/d67bb40f422c Added tag jdk-14+25 for changeset 17d242844fc9 ! .hgtags Changeset: 24e8cdead5f3 Author: ssahoo Date: 2019-11-27 22:11 -0800 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/24e8cdead5f3 8234725: sun/security/ssl/SSLContextImpl tests support TLSv1.3 Summary: Missing TLSv1.3 test cases Reviewed-by: xuelei ! test/jdk/sun/security/ssl/SSLContextImpl/IllegalProtocolProperty.java ! test/jdk/sun/security/ssl/SSLContextImpl/SSLContextVersion.java Changeset: 1d6e62764eee Author: bulasevich Date: 2019-11-28 10:57 +0300 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/1d6e62764eee 8234891: AArch64: Fix build failure after JDK-8234387 Reviewed-by: vlivanov, smonteith ! src/hotspot/cpu/aarch64/aarch64.ad Changeset: 643d9cf3d8fc Author: mdoerr Date: 2019-11-28 12:05 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/643d9cf3d8fc 8234645: ARM32: C1: PatchingStub for field access: not enough bytes Reviewed-by: cgo, goetz ! src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp Changeset: 219ec11136d9 Author: dfuchs Date: 2019-11-28 12:28 +0000 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/219ec11136d9 8223196: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java fails on Solaris SPARC Summary: The test is fixed to use InetAddress.getLocalHost consistently, instead of a mix of getLocalHost/wildcard addresses. Reviewed-by: chegar, vtewari ! test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/Launcher.java ! test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/StateTest.java From david.simms at oracle.com Thu Nov 28 15:52:42 2019 From: david.simms at oracle.com (david.simms at oracle.com) Date: Thu, 28 Nov 2019 15:52:42 +0000 Subject: hg: valhalla/valhalla: Merge Message-ID: <201911281552.xASFqglj017243@aojmv0008.oracle.com> Changeset: 7d7f1d0f283a Author: dsimms Date: 2019-11-28 16:52 +0100 URL: https://hg.openjdk.java.net/valhalla/valhalla/rev/7d7f1d0f283a Merge ! .hgtags ! src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp ! src/hotspot/cpu/s390/interp_masm_s390.cpp ! src/hotspot/cpu/x86/gc/shared/barrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/modRefBarrierSet.hpp ! src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp ! src/hotspot/share/gc/z/zBarrierSet.hpp ! src/hotspot/share/gc/z/zBarrierSet.inline.hpp ! src/hotspot/share/interpreter/bytecodeInterpreter.cpp ! src/hotspot/share/interpreter/oopMapCache.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/memory/allocation.inline.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/access.hpp ! src/hotspot/share/oops/access.inline.hpp ! src/hotspot/share/oops/accessBackend.hpp ! src/hotspot/share/oops/accessBackend.inline.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.inline.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/oops/methodData.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/valueKlass.cpp ! src/hotspot/share/oops/valueKlass.hpp ! src/hotspot/share/opto/cfgnode.hpp ! src/hotspot/share/opto/ifnode.cpp ! src/hotspot/share/opto/parse2.cpp ! src/hotspot/share/opto/parse3.cpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiImpl.cpp ! src/hotspot/share/prims/unsafe.cpp ! src/hotspot/share/prims/whitebox.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/interfaceSupport.cpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/utilities/globalDefinitions.hpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/java.base/share/classes/java/lang/invoke/InfoFromMemberName.java ! src/java.base/share/classes/java/lang/invoke/MemberName.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/MethodType.java ! src/java.base/share/classes/module-info.java - src/java.desktop/share/legal/opengl.md ! src/jdk.compiler/share/classes/com/sun/source/tree/Tree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/TreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Code.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java - src/jdk.zipfs/share/classes/jdk/nio/zipfs/JarFileSystem.java - src/jdk.zipfs/share/classes/jdk/nio/zipfs/JarFileSystemProvider.java ! test/hotspot/jtreg/runtime/CompressedOops/CompressedClassPointers.java ! test/jdk/ProblemList.txt - test/jdk/java/awt/Color/AlphaColorTest.java - test/jdk/java/awt/Color/GetMinMaxValue_ICC_ColorSpace.java - test/jdk/java/awt/Color/HeadlessColor.java - test/jdk/java/awt/Color/LoadProfileWithSM.java - test/jdk/java/awt/Color/LoadStandardProfilesTest.java - test/jdk/java/awt/Color/OpacityChange/OpacityChange.java - test/jdk/java/awt/Color/XRenderTranslucentColorDrawTest.java - test/jdk/javax/swing/JEditorPane/8226513/JEditorPaneLayoutTest.java - test/jdk/javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java - test/jdk/jdk/jfr/api/consumer/streaming/TestRepositoryMigration.java - test/jdk/sun/security/tools/jarsigner/warnings/BadKeyUsageTest.java - test/langtools/jdk/javadoc/doclet/testDocFiles/pkg/Test.java - test/langtools/jdk/javadoc/doclet/testDocFiles/pkg/doc-files/test.txt ! test/lib/sun/hotspot/WhiteBox.java