[lworld] RFR: 8244975: [lworld] Investigate if VM can implement Object::hashCode by calling ValueBootstrapMethods for inline types [v3]

David Simms dsimms at openjdk.java.net
Mon Aug 10 10:39:19 UTC 2020


On Mon, 10 Aug 2020 09:03:37 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

> +1 for javac changes, assuming tests are all green

Looks like I did break something:
`ValueModifierTest.java:16:28: compiler.err.override.meth: (compiler.misc.cant.override: toString(),
compiler.misc.anonymous.class: ValueModifierTest$3, toString(), value), final`

rather than .out file:

`ValueModifierTest.java:16:28: compiler.err.override.meth: (compiler.misc.cant.override: hashCode(),
compiler.misc.anonymous.class: ValueModifierTest$3, hashCode(), value), final`

Not sure I completely understand the test...ahh, yeah I do, no longer generate hashCode, but toString was

-------------

PR: https://git.openjdk.java.net/valhalla/pull/136


More information about the valhalla-dev mailing list