[lworld] RFR: 8252024: [lworld] Lock ordering issue when printing nmethod labels

Tobias Hartmann thartmann at openjdk.java.net
Mon Dec 14 11:25:16 UTC 2020


We hit an assert while printing nmethod entry point labels when attempting to create a symbol from the `SigEntry` to iterate over. The problem is that we are holding the tty lock and symbol creation also acquires certain locks. I've refactored the code to completely avoid symbol creation and also fixed an issue where names of reference argument types are not printed anymore (because we don't keep track of that in `SigEntry`). I've also removed lots of dead code leftovers from old reserved entry support in the calling convention.

Thanks,
Tobias

-------------

Commit messages:
 - 8252024: [lworld] Lock ordering issue when printing nmethod labels

Changes: https://git.openjdk.java.net/valhalla/pull/302/files
 Webrev: https://webrevs.openjdk.java.net/?repo=valhalla&pr=302&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8252024
  Stats: 186 lines in 13 files changed: 34 ins; 78 del; 74 mod
  Patch: https://git.openjdk.java.net/valhalla/pull/302.diff
  Fetch: git fetch https://git.openjdk.java.net/valhalla pull/302/head:pull/302

PR: https://git.openjdk.java.net/valhalla/pull/302


More information about the valhalla-dev mailing list