[lworld] RFR: 8249396: JNI function IsSameObject should apply the substitutability test for inline types [v2]

[Frederic Parain]

On Wed, 15 Jul 2020 13:16:41 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indent and add comment
>
> Hi Fred,
> The changes look good.  Could you add a comment that the code in JNIHandles::is_same_object() is similar to
> InterpreterRuntime::is_substitutable()? Thanks, Harold

Harold,

Thank you for reviewing.
I've added a comment to JNIHandles::is_same_object(), let me know if it is explicit enough.

Regards,

Fred

> src/hotspot/share/runtime/jniHandles.cpp line 357:
> 
>> 356:         ret = result.get_jboolean();
>> 357:     }
>> 358:   }
> 
> indentation issue:  could lines 338 - 356 should be shifted 2 spaces to the left.

Fixed

-------------

PR: https://git.openjdk.java.net/valhalla/pull/108