[lworld] [Rev 02] RFR: 8247357: Flattenable field concept needs some cleanup

[Harold Seigel]

On Fri, 12 Jun 2020 19:14:38 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Please review these changes cleaning up the flattenable field concept.
>> The concept has evolved with time and now all fields with an inline type are by definition flattenable, so the need to
>> have a "flattenable bit" on the side is gone. The changeset contains a mix of renaming and code cleaning. The changes
>> don't include JIT code, which would be fix in a follow-up patch.
>> Thank you,
>> 
>> Fred
>
> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The pull request now
> contains eight commits:
>  - Merge remote-tracking branch 'upstream/lworld' into flattenable_squashed2
>  - Renaming in comments
>  - Merge remote-tracking branch 'upstream/lworld' into flattenable_squashed2
>  - Renaming again (allocated_inline -> inlined)
>  - Merge remote-tracking branch 'upstream/lworld' into flattenable_squashed2
>  - More renaming
>  - Merge remote-tracking branch 'upstream/lworld' into flattenable_squashed2
>  - Remove flattenable concept and associated code

Hi Fred,
The changes look good.  One minor misspelling in templateTable_x86.cpp, "fiel" instead of "field".
Also, should JVM_ACC_FIELD_INLINED be 4000 instead of 8000?
Thanks, Harold

-------------

Marked as reviewed by hseigel (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/77