[lworld] RFR: 8255995: templateTable_x86.cpp (TemplateTable::if_acmp) not always do correct null check.

Frederic Parain fparain at openjdk.java.net
Tue Nov 17 18:56:09 UTC 2020


On Tue, 17 Nov 2020 17:54:36 GMT, David Simms <dsimms at openjdk.org> wrote:

> Testing both pointers at the same time, doesn't account for the case where bits
> completely miss each other, resulting in zero as result e.g.
> 
>   test(0x10, 0x01) == 0x10 & 0x01 == 0, yet neither are null

LGTM

Fred

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/266


More information about the valhalla-dev mailing list