RFR: 8252180: [JEP 390] Deprecate wrapper class constructors for removal
Dan Smith
dlsmith at openjdk.java.net
Tue Oct 13 17:58:26 UTC 2020
On Fri, 9 Oct 2020 21:39:44 GMT, Dan Smith <dlsmith at openjdk.org> wrote:
>>> Should change issue number to 8254271, which is targeted to 'repo-valhalla'. (I'm actually not sure what happens if you
>>> push with 8252180, which is targeted to 'tbd'...)
>>
>> The fields in the bug are just hints for people. The actual push using git is specific to the repo and branch its
>> targeted to. The bugs are updated after the fact by 'hgupdater'.
>
>> > Should change issue number to 8254271, which is targeted to 'repo-valhalla'. (I'm actually not sure what happens if you
>> > push with 8252180, which is targeted to 'tbd'...)
>>
>> The fields in the bug are just hints for people. The actual push using git is specific to the repo and branch its
>> targeted to. The bugs are updated after the fact by 'hgupdater'.
>
> Understood.
>
> I'm saying it needs to be configured so that 'hgupdater' leaves 8252180 open and closes 8254271. (And I'm unsure of
> exactly how things will go wrong otherwise. I know sometimes hgupdater will create backport issues...)
Clarification on integration behavior:
The model is that each pull to `valhalla` or `jdk` needs a separate bugid. That's the workflow we need to follow unless
we can flesh out and get tooling support for an alternative model.
I'm asking that 8252180 be reserved for the `jdk` pull and for the CSR. And that all pulls to `valhalla` use bugids of
subtasks of that issue, such as 8254271.
Robin says if you push with bugid 8252180 (which is targeted to 'tbd'), the issue will be closed, disrupting its use
for the `jdk` pull and CSR. He will consider adding a guard that warns about the mismatch of JBS target and PR target
to prevent this sort of accident.
-------------
PR: https://git.openjdk.java.net/valhalla/pull/221
More information about the valhalla-dev
mailing list