RFR: 8254274: Development to add 'lint' warning for @ValueBased classes [v3]

Jim Laskey jlaskey at openjdk.java.net
Thu Oct 29 10:27:55 UTC 2020


On Thu, 29 Oct 2020 06:04:20 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> New javac lint mode (-Xlint:synchronize) to warn about client side as well JDK internal attempts to synchronize on instances of value based classes
>
> Srikanth Adayapalam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8254274: Messages should refer to value-based classes and not to the internal annotation

Wondering if keyword SYNCHRONIZATION is too broad, suggest VALUE_ SYNCHRONIZATION. Would it make sense to have a test for a class.ref type value?

-------------

Marked as reviewed by jlaskey (Reviewer).

PR: https://git.openjdk.java.net/valhalla/pull/237



More information about the valhalla-dev mailing list