[lworld] RFR: 8253218 ClassFileParser hits assert(klass->access_flags().is_inline_t…

[Harold Seigel]

On Wed, 16 Sep 2020 20:43:39 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Please review this fix for JDK-8253218.  The fix throws a ClassFormatError exception if a class file, with an old class
>> file version, contains a Q signature.
>> The fix was tested with tiers 1-2 on Windows, Linux x64, and MacOS, and tiers 3-5 on Linux x64.
>
> src/hotspot/share/classfile/classFileParser.cpp line 5302:
> 
>> 5300:                                                    TRAPS) const {
>> 5301:   if (!_need_verify) { return; }
>> 5302:   if (!supports_inline_types() && signature->is_Q_signature()) {
> 
> Shouldn't the test also include a check for Q-arrays?  (signature->is_Q_array_signature()) ?

Yes, it should check for Q-arrays.  I'll add the check.  Thanks!

-------------

PR: https://git.openjdk.java.net/valhalla/pull/191