[lworld] RFR: 8264897: [lworld] C2: Use BarrierSetC2::obj_allocate to buffer inline type in PhaseMacroExpand::expand_mh_intrinsic_return [v2]

[Tobias Hartmann]

On Fri, 16 Apr 2021 08:38:58 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> src/hotspot/share/opto/macro.cpp line 3239:
>> 
>>> 3237:     case Node::Class_FlatArrayCheck:
>>> 3238:       expand_flatarraycheck_node(n->as_FlatArrayCheck());
>>> 3239:       assert(C->macro_count() == (old_macro_count - 1), "expansion must have deleted one node from macro list");
>> 
>> Why did you delete these asserts?
>
> It seems the checking happens nevertheless right after switch:
> 
> https://github.com/openjdk/valhalla/blob/5e88e8a08c4532840c66177e0032953ba6e2956c/src/hotspot/share/opto/macro.cpp#L3220-L3227

Right, good catch!

-------------

PR: https://git.openjdk.java.net/valhalla/pull/385