RFR: universal type variables: initial prototype [v4]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Aug 12 18:38:40 UTC 2021


On Thu, 12 Aug 2021 17:53:14 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> First iteration of the protype for universal type variables
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments, another iteration

Looks good - just one nitpick

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java line 1991:

> 1989:             this.isReferenceProjection = isReferenceProjection;
> 1990:             this.isUniversal = (tsym.flags_field & UNIVERSAL) != 0;
> 1991:             if (isUniversal && !isReferenceProjection) {

isn't `isReferenceProjection` always `false` here (you have just created the class)

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/521


More information about the valhalla-dev mailing list