[lworld] RFR: 8269956: [lworld] javac should generate `ldc LPoint; ` for class literal Point.class [v2]
Mandy Chung
mchung at openjdk.java.net
Tue Jul 27 17:17:44 UTC 2021
On Tue, 27 Jul 2021 12:50:20 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:
>> Adjust meaning of type name in class literal expressions. Adjust tests accordingly
>
> Srikanth Adayapalam has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review comments (reinstate original code by backing out unneeded calls to asValueType() in addHelperClasses method invocation)
Looks okay.
test/jdk/valhalla/valuetypes/PrimitiveTypeConversionTest.java line 64:
> 62: public static void primitiveWidening() throws Throwable {
> 63: MethodHandles.Lookup lookup = MethodHandles.lookup();
> 64: MethodHandle mh1 = lookup.findStatic(PrimitiveTypeConversionTest.class, "narrow", methodType(Value.class.asValueType(), Value.ref.class));
Suggestion:
MethodHandle mh1 = lookup.findStatic(PrimitiveTypeConversionTest.class, "narrow", methodType(Value.class.asValueType(), Value.class.asPrimaryType()));
This change will be needed anyway if it's decided to disallow `Value.ref.class` and `Value.val.class`. We can wait until that discussion is resolved.
-------------
Marked as reviewed by mchung (Committer).
PR: https://git.openjdk.java.net/valhalla/pull/501
More information about the valhalla-dev
mailing list