[lworld] RFR: Convert valhalla/inlinetypes tests to new IR framework

Ekaterina Pavlova epavlova at openjdk.java.net
Mon Jun 21 22:43:20 UTC 2021


This PR converts compiler/valhalla/inlinetypes tests based on old Valhalla/IR test framework to new one 
which was recently integrated by Christian as part of JDK-8254129.
The tests which were we decided to convert are basically the ones which extends InlineTypeTest class.
The rest of compiler/valhalla/inlinetypes tests were agreed (with Christian and Tobias) to keep untouched 
as they are in most cases regression tests.

The conversion rules/approach is pretty well described in the bug's description section (see JDK-8263024).
A detailed description of new IR test framework could found in test/hotspot/jtreg/compiler/lib/ir_framework/README.md.

Testing:
 Ran compiler/valhalla/inlinetypes in all the configurations used in hs-tier1-9.
 There 2 failed converted tests:
  compiler/valhalla/inlinetypes//TestNullableArrays.java - new bug JDK-8269070 filed
  compiler/valhalla/inlinetypes/TestIntrinsics.java - know issue tracked by JDK-8239003


Big thanks to Christian and Tobias for advice and help during this tests conversion.

Please review the changes.

Thanks,
Katya

-------------

Commit messages:
 - Converted to new IR framework

Changes: https://git.openjdk.java.net/valhalla/pull/457/files
 Webrev: https://webrevs.openjdk.java.net/?repo=valhalla&pr=457&range=00
  Stats: 5208 lines in 23 files changed: 1020 ins; 1275 del; 2913 mod
  Patch: https://git.openjdk.java.net/valhalla/pull/457.diff
  Fetch: git fetch https://git.openjdk.java.net/valhalla pull/457/head:pull/457

PR: https://git.openjdk.java.net/valhalla/pull/457



More information about the valhalla-dev mailing list