[lworld] RFR: [lworld] jcmd VM.class_print_layout crash due to NULL cld name

Yi Yang github.com+5010047+kelthuzadx at openjdk.java.net
Mon Mar 1 11:49:26 UTC 2021


Hi, can I have a review of this one-line fix?

jcmd VM.class_print_layout crashes when printing classes which loaded by bootstrap loader since these classes has NULL class_loder_data()->name().

But actually, I wonder to know why we don't print the layout by modifications of existing functions in FieldLayoutBuilder::build_layout directly? It seems FieldLayoutBuilder can gather more complete layout information.

Thanks,
Yang

-------------

Commit messages:
 - jcmd VM.class_print_layout crash due to NULL cld name

Changes: https://git.openjdk.java.net/valhalla/pull/354/files
 Webrev: https://webrevs.openjdk.java.net/?repo=valhalla&pr=354&range=00
  Stats: 74 lines in 2 files changed: 73 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/valhalla/pull/354.diff
  Fetch: git fetch https://git.openjdk.java.net/valhalla pull/354/head:pull/354

PR: https://git.openjdk.java.net/valhalla/pull/354



More information about the valhalla-dev mailing list