[lworld] RFR: 8262746: [lworld] jcmd VM.class_print_layout crash due to NULL cld name

Frederic Parain fparain at openjdk.java.net
Tue Mar 2 14:08:57 UTC 2021


On Mon, 1 Mar 2021 11:42:07 GMT, Yi Yang <github.com+5010047+kelthuzadx at openjdk.org> wrote:

> Hi, can I have a review of this one-line fix?
> 
> jcmd VM.class_print_layout crashes when printing classes which loaded by bootstrap loader since these classes has NULL class_loder_data()->name().
> 
> But actually, I wonder to know why we don't print the layout by modifications of existing functions in FieldLayoutBuilder::build_layout directly? It seems FieldLayoutBuilder can gather more complete layout information.
> 
> Thanks,
> Yang

Looks good to me.

Thank you for fixing it.

Fred

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/354



More information about the valhalla-dev mailing list