[lworld] RFR: 8263067: [lworld] Use tlab_allocate in MacroAssembler::store_inline_type_fields_to_buf
Tobias Hartmann
thartmann at openjdk.java.net
Fri Mar 5 08:09:47 UTC 2021
On Fri, 5 Mar 2021 07:53:40 GMT, Yi Yang <github.com+5010047+kelthuzadx at openjdk.org> wrote:
>> Hi Yang,
>>
>> I had this on my To-Do list as well, thanks for fixing! I'm just wondering if we shouldn't also attempt an allocation in eden if `UseTLAB` is disabled? Similar to what code in `MacroAssembler::allocate_instance` does.
>>
>> Thanks,
>> Tobias
>
> Hi Tobias,
>
> I think it's reasonable. We can create such a buffered instance similar to `MacroAssembler::allocate_instance` or just using it. What do you think? If you think it's a feasible way, I can also try to tweak the implementation, keeping using the same buffer allocation mechanism on aarch64.
>
> Thanks!
> Yang
Yes, I think it would be nice to factor the common code out of `MacroAssembler::allocate_instance` (we don't need the zeroing and some of the checks) and use it for buffer allocation.
-------------
PR: https://git.openjdk.java.net/valhalla/pull/362
More information about the valhalla-dev
mailing list