[lworld] RFR: 8263900: [lworld] Make .default a separate node type in the parser.

[Srikanth Adayapalam]

On Mon, 22 Mar 2021 12:02:12 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> To prepare for making .default a poly expression and to implement further logic, .default-expressions should be split off as a separate AST node.
>
> Thanks Jesper, I will review this one and help you take it forward.

I have made one high level pass over the changes, more verifying on the boiler plate parts. Need to delve deeper in Attr, Gen, Parser, TransValues, will do this tomorrow.

Here are some comments so far:

(1) Is DefaultExpression better named as DefaultInstance or DefaultValue ??
(2) Should com.sun.tools.javac.tree.JCTree.JCDefaultExpression#getClazz - for consistency sake return JCExpression ??
(compare similar cases in JCTree)
(3) Do we need a visitor in SourceComputer in CRTable.java ??

-------------

PR: https://git.openjdk.java.net/valhalla/pull/370